1 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
3 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
4 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
5 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
7 * Test/TestCopyRescaleDicom.cxx : remove unused variable
8 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
9 containing found sequences
11 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
14 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
15 Some fields in BinEntry must be copied to not seg fault when making the :
16 gdcm::File *copy = new gdcm::File( copyH );
17 and tests are now made on good variables
19 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
21 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
23 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
24 * Add vtkGdcmWriter example and test
26 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * Test/TestUtil.cxx : reformat the source code
28 * vtk/vtkGdcmReader.cxx : remove and change prints
29 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
31 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
32 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
34 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
36 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
38 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
40 by an eof to prevent all bad read of the file... and in this case, the
43 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * Example/Volume2Dicom.cxx : comment unused variables
45 * Test/PrintDicomDir.cxx : comment unused variables
46 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
47 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
48 method that is redondant with AddEntry.
49 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
52 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * Bug fix due my last commit (compilation under Windows).
54 * Example/Volume2Dicom : bug fix in the file and reformatting source code
55 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
57 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
59 - Remove printf / sprintf
60 - include iostream AFTER gdcm so we don't get warnings
61 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
63 - Also remove tons of include from header files, hopefully this should
64 speeup the compilation time, since it was becoming a dog slow.
65 - Remove gdcm.h as it include way too many files and slow down compilation
66 (plus it is not up to date)
67 - remove 'using namespace std' this is BAD !
69 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * Remove memory leaks on the DicomDir
71 * Remove some useless datas in DicomDirObject
72 * Add usefull methods in SQItem, to be complient withe the ElementSet
74 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
77 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
79 future, with convertion)
80 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
81 and ImageDataSize values. Remove the method to get the PixelReadConverter
82 from the output of the class
84 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
87 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
89 and vtkErrorMacro use.
90 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
92 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
95 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
96 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
97 The string leaves only in the fonction. So when we make a .c_str(), we
98 get the pointeur on the first element, element that will be destroyed
99 immediately after thee instruction.
100 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
101 file has been opened : the test must be made on the content of the
102 pointer and not directly on the pointer !
105 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
107 the python part recompiles
109 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
111 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
112 X session is killed (for my computer... it seems to not be identic on
115 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
117 avoid problems (otherwise, the difference test between the visible image
118 and the reference is incorrect. If the reference is greater than the
119 screen resolution, it's produce errors).
120 Can be used for only one image. Can be used with a visible flag.
121 * vtk/vtkGdcmReader.cxx : remove commented codes.
122 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
123 under windows at compilation
124 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
126 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
128 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
130 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
131 tests on the image size X, Y, Z
133 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
135 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
136 between the class name and the file name
138 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * src/ : fix compilation warnings for the Write method (2 different
140 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
141 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
142 variable... create a static method in gdcm::Document to access to
143 this variable content.
145 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
147 file, to be accessed by other files (like gdcmFile). Remove commented
148 code. Move the change of the header to the gdcmFile, using the
150 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
151 To be sure of that (and simplify calls), the Write of the header now
152 gets a file name and not a file pointer (std::ifstream).
153 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
154 DocEntryArchive. Remove all open of the written file
156 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
159 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
161 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
163 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
164 some corresponding methods. Write correctly the file and check before
166 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
167 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
168 is now on RGB datas (as before my last commit
169 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
171 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
173 Add a print information of the type of the entry
174 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
175 It was in the gdcmFile, and all write have been regrouped
176 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
177 Write correctly all dicom files (in decompressed mode only at this time)
178 * Test/ : test on files are now made using Raw datas and not color datas if
180 * Example/PrintFile.cxx : add more printings
182 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
183 * Amelioration of code, remove some code copy. For the loading of
184 BinEntry (in gdcmDocument), add the test to verify if the file is already
187 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
189 remove a DocEntry in the header (push an empty DocEntry)
190 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
191 lines. Bug fix in the initialization of the PixelConvert and the
193 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
194 use in TestCopyDicom (now this test can run under windows... but fails)
195 * Test/TestCopyDicom.cxx : amelioration of the test :
196 - test the pixels written
197 - add test points to quickly find where is the error
198 - can set a file name input and output in arguments
199 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
200 amelioration of the test output
202 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
204 all replaced DocEntry's
205 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
206 Now, each needed DocEntry to modify is duplicated, modified and inserted
207 to the header using DocEntryArchive. Thus, after save, we can restore the
208 header initial state.
210 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
211 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
213 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
215 correct to copy it. The DictEntry is specified at the DocEntry creation,
216 then, it musn't change in the time.
217 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
218 header correctly. At this time, the change is only made for the first
219 level of the Document. In the future, it might consider sequences.
220 The change is made by replacing a DocEntry by an other that is created
221 outside the class. The old value is kept. When we restore the header
222 status, the added DocEntry is deleted and replaced by the old value.
223 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
224 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
225 set the write type to explicit VR, implicit VR or ACR. Add methods to set
226 the write mode to native, decompressed or RGB (but not used at this time)
228 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
230 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
232 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
234 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
236 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
237 set because already copied when copying the BinEntry's of the header
238 * Test/TestAllReadCompareDicom.cxx : remove warnings
240 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
242 Two problems appear when doing it :
243 - with the gdcmFile : when the GetImageData method is called, the pixels
244 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
245 datas (pixels). And each structure destruct the datas when it's
246 destructed. So we have two destructions for the same datas. To solve it,
247 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
248 datas or not. If it doesn't own datas, then they will not destroyed by
250 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
251 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
252 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
253 create a double destruction of the same DocEntry's. So, to solve it,
254 the TagHT is simply cleared and the DicomDir* elements are destroyed.
255 * TODO : add an entry concerning memory leaks in the DicomDir
257 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
259 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
262 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
264 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
265 after it have been deleted
267 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
268 * FIX: src/* fix the doxygen warnings.
269 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
270 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
271 was erroneously defined with a size of 15 instead of 16. [many thanks
272 to Jean Michel Rouet for pointing out this bug].
274 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
275 1. Finish merging JMR patch for writting DICOM from scratch
276 2. Fix -hopefully- bug with MONOCHROME and space vs null character
277 3. Use const ref when possible
278 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
279 5. A few more comments
280 6. CreateUniqueUID can now be called without parameter"
282 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
283 * ENH: Slightly bigger patch:
284 1. Getting toward full integration of JMR patch for writting dicom from scratch
285 2. Update Test to test part of this patch: CreateUniqueUID
286 3. File was not close properly in gdcmDict
287 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
288 5. Use of const ref instead of copy (speed issue)
289 6. Remove temporary (duplicate) string in TranslateToKey
290 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
291 8. Do not repeat virtual in subclasses
292 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
294 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
295 * Apply first patch toward better string comparison when dealing with broken
296 DICOM files. Essentially the string could be padded with a space instead
297 of a null character as defined by standard
299 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
301 because never used... and in the same time, that's remove some memory leaks
303 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * src/gdcmFile.cxx : now delete the PixelConvert instance.
305 * In examples and tests : change the type of image data variables from void*
306 to uint8_t*. Remmove all delete on image data variables
308 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
310 Verify the file pointer value before open the file, and if it's not null,
311 a verbose message is generated.
312 Close correctly the file when the file isn't considered dicom-like. The
313 correctly close is a call to CloseFile.
314 When closing the file pointer, test if its not null to close the file.
315 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
316 file. For an uncompressed image, the copied datas correspond in the least
317 case to the image size (calculated) or the image size specified in the
318 header. A verbose is generated if these two size mismatch
320 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
322 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
323 break under windows (with msvc6 compilation).
325 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
326 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
327 compiling with MSVC6)
329 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
330 * Bugs fix for the Windows build with VC6
331 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
332 needed (only for projects required VTK). If the VTK is included in all
333 projects, there is conflicts with the jpeg lib of vtk when compiling the
334 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
335 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
336 when compiling the gdcm_wrap.cxx file (created by the compilation of the
338 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
339 (like it's already made for the cout use). Otherwise, conflict with the
342 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
345 - comments on the DicomDir::Method related usage added.
346 - now that we use the namespace gdcm, a lot of internal classes do
347 NOT need to be wrapped anymore.
348 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
349 DicomDir::Method) new example added.
351 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
352 * Improve string manipulation. I now inforce the notion of 'DicomString'
353 A DicomString can contain as many \0 as they want
354 and it is *always* of even length.
355 We only support odd length for very rare case.
356 And in the near future this should be removed.
358 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
359 * /binary_write/ gdcm source. Now even on big endian we are writting
360 little endian. This should -heopfully- fix some tests
362 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 * Now the dictionary is compiled into gdcm lib. This is a default
364 behavior, thus any dic file specified is picked before failback to
365 the one comiled into lib
367 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
368 * Change internals for gdcmDict. Don't use any 'new' any more.
369 This should definitely solve any leak problem, and we should be
370 as fast as before, as long as don't modify too much the dictionary.
372 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
373 * STYLE: ivars should start with a capital letter.
374 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
375 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
377 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
379 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
380 new 2004 dictionaries added (thanks to JPR).
381 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
382 * CLEANUP_ROUND (15) for gdcmPixelConvert
383 - RLEFrame::NumberFragments is now of type unsigned int
384 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
385 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
388 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
389 * Initial work in gathering all transfer syntax accessors. clearly
390 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
391 ivars, but only one transfersyntax (class) ivar with equivalent method on
394 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
395 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
396 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
397 discussed (plus I didn't like having a 2000 lines patch not commited)
399 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
400 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
401 * CLEANUP_ROUND (14) for gdcmPixelConvert
402 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
403 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
404 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
406 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
407 anymore and hence avoids storing a copy of PixelConvert::Decompressed
408 into File::Pixel_Data.
410 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
412 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
413 * CLEANUP_ROUND (13) for gdcmPixelConvert
414 Substituted File::ParsePixelData() with PixelConvert::Print() new
416 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
417 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
418 method to those classes.
419 - src/gdcmFile.[cxx|h]:
420 -- Added a ::Print() method.
421 -- PixelConverter is now a reference instead of a member.
422 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
423 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
425 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
427 collaboration diagram and inheritance diagram should be generated with
429 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
430 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
431 pointlessly wrapped (see
432 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
433 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
434 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
435 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
436 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
437 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
438 -- File::Initialise: PixelConverter setup moved away to
439 PixelConverter::GrabInformationsFromHeader()
440 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
441 interpretation moved away to PixelConverter::BuildRGBImage()
443 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
444 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
445 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
447 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
449 displayed on Win32 when a brutal abort() occurs (because of uncatched
450 exception). See TODO new entry of this commit for more on this.
451 * TODO added new entry.
452 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
453 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
454 - HandleColor is no longer called from gdcmFile.cxx
455 - gdcmPixelConvert.cxx clean up on method arguments and internal
456 variable names for semantical coherence.
458 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
459 * Finished lossless transition, not only do we now read all lossless jpeg
460 images, without the need of the Cornwell lib, but we do read them properly now
461 * To reduce code (well to avoid code duplication), I defined a common place
462 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
463 redefine symbols. This is not prefect but this the best solution I found for a
464 compilation time jpeg option.
466 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
467 * Update jpeg ijg lib to support lossless jpeg implementation
468 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
470 * Also added a special copyright for dcmtk since we use their bugfixes.
473 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
474 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
475 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
476 matters, as stated in warning note at begining of %include section).
477 * src/gdcmDicomDir*.[cxx|h]: coding style
478 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
479 * src/gdcmJpeg8.cxx: doxygen fix.
480 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
481 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
482 from File:: to PixelConvert::.
484 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
485 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
486 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
487 - more code moved away from File:: to PixelConvert::
488 - fat setup of PixelConverter set in place in File::Initialise.
490 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
491 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
492 namespace at the file system level. So now you should convert your examples
494 gdcmHeader -> gdcm::Header
495 It would be nice if people keep in mind to no open the namespace, since it
496 allows compilation on broken plateform which were defining common symbol in
497 the standart namespace (like LP, Unknown ...)
499 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
501 The JPEG fragments are now parsed at the same stage than the RLE
502 information. All code related to JPEG is now in gdcmPixelConvert:
503 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
504 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
505 export a gdcmFile:: method. Those are simply global functions
506 (for the time being this is better than having them attach to
507 either gdcmFile:: or gdcmPixelConvert::).
508 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
509 and stores the result in a gdcmJPEGFragmentsInfo.
510 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
511 code (among other stuff) moved away from gdcmFile:; to
514 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
515 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
516 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
517 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
518 clean up of RLE related code.
519 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
520 - src/gdcmRLE.cxx removed
521 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
522 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
523 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
524 * CLEANUP_ROUND (9) for gdcmPixelConvert
525 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
526 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
527 away from gdcmFile:: to gdcmPixelConvert::.
529 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
530 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
531 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
532 This is because Parse7Fe0 used to parse the pixels to compute the
533 length. This task was passed over to FindDocEntryLengthOB() a long
534 time ago, EXCEPT I had forgotten the OW case...
535 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
536 we just recylce the code for parsing RLE fragments and computing
538 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
539 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
540 with the retired Parse7Fe0().
541 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
542 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
544 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
545 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
546 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
547 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
548 - src/CMakeLists.txt: alphabetic order reodering + new entries.
549 * CLEANUP_ROUND (4) for gdcmPixelConvert
550 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
551 to return an unused length.
553 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
554 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
555 this should be cleanner from the plane view. The iostream are erally a pain
556 to use to do simple stuff.
558 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
559 * Redo the compilation of the ijg jpeg library. Now only one source is
560 necesseray. No need to rename file by hand what so ever. CMake handle the
561 copying of the file within different directory, configure header file to
562 modify some symbol. The only addition made to ijg wasd a mangle table so
563 that symbol are different wether we are within 8bits or 12bits.
565 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * Added documentation of vtkgdcmReader on Website:
567 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
568 with it's binary name).
569 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
570 the Website to be more complete.
571 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
572 doxygenated documentation.
573 - Doc/DoxyVtkGdcmReaderExamples.txt added
574 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
575 DoxyVtkGdmReaderExamples.html )
576 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
577 * CLEANUP_ROUND (3) for gdcmPixelConvert
578 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
580 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * CLEANUP_ROUND (2) for gdcmPixelConvert
582 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
584 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * CLEANUP_ROUND for gdcmPixelConvert:
586 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
587 - src/gdcmPixelStuff[h|cxx] removed
588 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
589 - src/CMakeLists.txt changed accordingly
591 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
592 gdcmVersion.py moved to newly created ATTIC related
593 gdcmPython/SetupOldies/ directory.
594 * Autotools clean up:
595 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
596 - autogen.sh configure.in acinclude.m4 python.m4 removed
598 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
599 * src/*.cxx *.h Reference to License.htm fixed to License.html.
600 * Doc/CMakeLists.txt, doxygen.config.in: fix.
601 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
603 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
604 * TODO updated with Mathieu suggestions. I proposed a template for
605 describing TODO entries and used it for new entries.
606 * Added Doc/Website/CodingStyle.html, Developpers.html,
607 DeveloppersPython.html, GdcmDataCvs.html and
608 DownloadVersion0_1.html, DownloadVersion0_3.html.
609 * Some Doc/*.txt Doxygen files (which do not really concern the
610 documentation itself, but the website) moved to html and
611 placed in directory Doc/Website:
612 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
613 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
614 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
615 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
616 * CMakeLists.txt changed accordingly.
617 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
618 DeveloppersPython.html
619 * INSTALL nows refers to Doc/Website/Installation.html
621 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
622 * Added Doc/Website directory, that contains a first raw version
625 2004-09-23 Jean-Pierre Roux
626 * FIX In order not to be poluted any longer by casting problems,
627 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
628 we can now delete[] it safely
629 * VoidArea is now called BinArea (less confusing name),
630 and all the methods called ...VoidArea... are now ... BinArea...
631 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
633 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
635 clear) TagHT, which is an inherited member of gdcmElementSet. It is
636 up to the destructor of gdcmElementSet to clean up TagHt and it's
639 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
640 * Test/CMakeLists.txt: update to follow gdcmData renamings.
641 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
643 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
644 * ENH: added some utility method that builds a flat dictionnary
645 holding all the Dicom entries contained in the recursive structure
646 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
648 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
649 BuildFlatHashTable() that build a flat dictionary.
650 - src/gdcmElementSet.h: added a new private GetTag() accessor.
651 gdcmDocument is now a friend of gdcmElementSet.
652 - src/gdcmElementSet.cxx: clean up.
653 - Example/FlatHashTablePrint.cxx added.
654 - Example/CmakeLists.txt changed accordingly
656 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
658 moved away from gdcmDocEntrySet (since this class is an abstract class
659 acting like an interface). SQDepthLevel and BaseTagKey are now
661 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
662 and associated accessors. Doxygenation of the class.
663 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
665 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
666 Use SQDepthLevel accessor instead. ::Print() adapted.
667 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
668 - src/gdcmDocument.cxx changed accordingly.
670 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
671 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
672 - The following is the doxygen comment of the typedef declaration
673 of gdcmagKey in src/gdcmCommon.h:
674 gdcmTagKey is made to old an "universal" (as in URL, Universal
675 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
676 A dicom tag allways has a group and an element, but a set of tags
677 embeded in various (optionally nested) sequences and sharing
678 the same group and element all share the same (group, element)
679 "identifier". Hence the (group, element) cannot be used as an
680 identifier (in gdcm we shall refer to a "TagKey") of a tag.
681 In order to construct a proper tag identifier (i.e. a key) we
682 consider the following definition of a TagKey:
683 - let Group, Element be the string representation of the
684 group and element dicom tag members,
685 - let ItemNumber be the string representation of the integer
686 index of the considered item number of a sequence,
687 Let the key of a tag embeded in a sequence, noted SeqTag, be
689 /ItemNumber#Group|Element
690 where "/", "#" and "|" are characters acting as separators.
691 Then the general form of a gdcmTagKey is given by:
692 Group|Element<SeqTag>
693 where <SeqTag> means NO or many instances of SeqTag.
694 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
697 but the gdcmTagKey of a tag "embeded" is the first item of
698 a sequence, itself nested in the third item of a sequence is the
700 0004|1220/2#0008|0082/0#0008|0090
701 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
702 order to hold the new sequence compatible key. Previously, the
703 GetKey() method would look in the underlying gdcmDictEntry.
704 - src/gdcmDocEntry.cxx:
705 -- constructor now copies the underlying DictEntry key, in the local
707 -- ::Print: displays the member Key, instead of the (group, element).
708 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
709 - src/gdcmDocEntrySet.h:xi
710 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
711 -- now has a new BaseTagKey member.
713 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
714 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
716 This poses the problem with the semantics of the following lines
717 LoadEntryVoidArea(0x0028,0x1201); // R LUT
718 LoadEntryVoidArea(0x0028,0x1202); // G LUT
719 LoadEntryVoidArea(0x0028,0x1203); // B LUT
720 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
721 to the long FIXME note for what the problem is. Nevertheless in
722 order to get things working the dicom dictionary was altered !
723 Please fix things urgently...
724 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
725 information), see above note on moving the member VoidArea. Nevertheless
726 the following entries previously correctly set as US are now inproperly
728 0028 1201 OW IMG Red Palette Color Lookup Table Data
729 0028 1202 OW IMG Green Palette Color Lookup Table Data
730 0028 1203 OW IMG Blue Palette Color Lookup Table Data
731 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
732 of gdcmDocEntry moved to gdcmSeqEntry.
733 * src/gdcmSeqEntry.cxx: STYLE.
735 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
736 * Test/TestAllEntryVerify.cxx minor fix and added comments.
738 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
739 * gdcmPython/testSuite.py: all the test suite in python is now moved
740 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
741 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
742 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
744 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
746 to avoid inclusion recursion until STL is reached.
747 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
748 mecanism. errno.h is not included in gdcm anymore.
749 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
750 (gdcmFormatError now inherits from gdcmFormatUnexpected).
752 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
753 gdcmData/TestAllEntryVerifyReference.txt
754 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
755 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
756 exception_on_error parameter.
757 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
758 - vtk/vtkGdcmReader.cxx changed accordingly,
759 - Example/*.cxx and Test/*.cxx changed accordingly.
761 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
763 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
764 enable_sequences removed from gdcmHeader constructor and dependencies.
765 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
766 * gdcmPython/demo/PrintHeader.py: dummy fix.
767 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
768 skip_shadow removed from gdcmHeader constructor and dependencies.
769 * Example/*.cxx and Test/*.cxx changed accordingly.
771 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
773 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
775 2004-07-21 Jean-Pierre Roux
776 * FIX Now, Parsing and Printing a DICOMDIR do work!
777 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
779 2004-07-20 Jean-Pierre Roux
780 * FIX Some brain damaged headers have Zero-Lenght fields
781 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
783 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
784 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
785 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
786 variable (instance of gdcmDebug) by a definition macro, and the instance
787 is now in static in the gdcmDebug class
788 * src/gdcmSQItem.h : (FIXME) remove an undefined method
789 * Test/PrintAllDocument.cxx : bug fix in the result of the test
791 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
792 * WARNING: ctest now depends more tightly on gdcmData. You should
793 check out gdcmData properly for things to run smoothly...
794 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
795 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
796 we need the pixels not be loaded in order to use the ValEntry
797 that displays position and size).
798 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
799 This is a C++ based equivalent of gdcmPython/testSuite.py that should
800 be deprecated. If you have any doubts about the advantages of a
801 modern scripting language (read Python) versus grass root C++ (i.e.
802 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
803 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
804 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
805 Anyhow, consider documenting the gdcmData images in
806 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
808 * Test/CMakeLists.txt:
809 - now uses TestAllEntryVerify.cxx
810 - specific comments on oldACR00001.ima (now renamed in gdcmData
811 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
812 gdcmData/TestAllEntryVerifyReference.txt
815 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
816 * src/*.[h|cxx] : typedef clean up
817 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
818 - TagKey renamed to gdcmTagKey (for external usage)
819 - VRKey renamed to gdcmVRKey (for external usage)
820 - removal of typedef duplication.
821 - Removed all unecessary inline keyword from class inline definitions.
822 - Some method|function(void) declarations replaced with method|function().
823 * src/jpeg/libijg12/jdhuff12.c:
824 - printf polluting ctest removed.
825 - TAB removal for comminting
827 - TestAllReadCompareDicom.cxx: added a test that compares all the
828 images in gdcmDataImages.h with corresponding images in
829 gdcmData/BaselineDicom/. When baseline images are not present
830 this test creates them.
831 Note: we need to validate each reference image, but before that
832 I'd like to rename them with a more explicit name...
833 - CMakeLists.txt: changed accordingly.
834 * Example/*.cxx: examples now only include gdcm.h (as opposed to
835 including each header needed).
837 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * Test/*.cxx and Example/*.cxx: moved some examples away from the
839 test suite to the Example directory. Are concerned:
844 - TestWriteSimple.cxx
845 * Test/CMakeLists.txt: added some comments on reasons for black listing
846 image gdcmData/oldACR00001.ima
848 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * Test/CmakeList.txt: removed the following from black list (to be coherent
850 with removal from gdcmData):
851 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
852 - gdcm-MR-PHILIPS-16.dcm
854 Added the following because after last cvs update, they cause
855 ctest -R TestReadWriteReadCompare
857 - gdcm-MR-SIEMENS-16-1.acr
859 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
860 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
861 new comments in this file) we temporarily (sigh) move to a weaker
863 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
864 we don't need to black list the following images anymore:
865 - 8BitsUncompressedColor.dcm
867 - US-PAL-8-10x-echo.dcm
868 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
869 fixes and the beautified code ;-)
870 This fixes the bug introduced in version 1.42 (when beautifying)
871 that made the parsing of 8BitsRunLengthColor.dcm unproper.
872 Note: ctest was blind to this bug (this means we need to still
873 improve the test suite). The bug could be detected by using
874 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
876 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
877 and by displaying the (garbage) produced file temp.XDCM...
879 2004-06-29 Jean-Pierre Roux
880 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
881 - replace by uggly but working old code :-(
882 A lot of things should be OK again.
883 It's really urgent to have a test suite that *tests*,
884 to prevent Frog's beautifying sessions to break all the stuff
885 (twice, withing a fortnigh ...)
887 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
888 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
889 redundancy) to added Test/TestReadWriteReadCompare.cxx
890 * Test/CmakeList.txt: because the compare test of
891 Test/TestReadWriteReadCompare.cxx fails, the following images are
892 black listed: - 8BitsUncompressedColor.dcm
894 - US-PAL-8-10x-echo.dcm
895 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
896 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
897 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
898 and ad-hoc kludge. This kludge is now removed, and on encountering
899 such an image (OB field brain damaged) we set errno. Then in
900 ::FindDocLength() we "fix" the length as being ALL what remains
901 in the file (until EOF). We then proceed, hoping for the best...
902 This fixes a SegFault in ShowDicom when trying to write such an
904 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
905 (because TestWriteRead breaks on it, after a non conformal commit?).
906 ctest now runs properly, except for MakeDicomDir (which was allways
907 broken) and the Python related stuff (still not fixed).
909 2004-06-24 Jean-Pierre Roux
910 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
911 FIX : Test/TestReadWrite now iterates on all the file names
912 (instead of infinite loop)
913 ENH : Test/TestWriteRead now iterates on all the file names
915 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
916 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
918 2004-06-24 Jean-Pierre Roux
919 FIX : - now Write drops LUT Descriptors and LUTs (if any)
920 when SamplesPerPixel =3
921 - now Write is no longer confused by
922 'BitsAllocated = 12" and 'BitsStored=12"
923 - "UN" value representation Elements are now written correctly
924 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
925 ENH : - now gdcmHeader has its own Write methods
926 (in order to split the job that has not to be done
929 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
931 loop on the same image until memory went out.
932 Note: this means we still have gobs of memory loss in PrintDocument
933 * src/gdcmDocument.cxx: fixes problem on parsing on file
934 gdcmData/16BitsJpegLosslessGrayScale.dcm.
936 2004-06-24 Jean-Pierre Roux
937 FIX : Write - All the Sequences and Sequence Item are now written
938 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
939 is added a the end, when necessary.
940 - A lot of brain-damaged images, that were read correctly are
941 now written correctly
942 - length compatible BinEntry are now loaded correctly
943 (even for odd groups)
944 Note : only Explicit Value Representation was checked.
945 (question : is implicit VR really necessary for gdcm ?)
947 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * DEVELOPPER: added a proposition of coding style.
949 * src/gdcmDocEntry.h: removed every inline declaration (for test of
952 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
953 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
954 Use the gdcmDocEntry::Print() and Write() instead.
955 * src/gdcmDocument.cxx: bug fix.
957 2004-06-22 Jean-Pierre Roux
958 FIX : gdcmDocument.cxx
959 - Now we do recognize the JpegLossLess format (there was a misstyping in
960 code 'beautyfication' :-(
961 - Now we automaticaticaly load the Luts, if any
963 2004-06-22 Jean-Pierre Roux
964 In order : to write Sequences, whatever their imbrication level,
965 : to allow user to create his own Sequences
966 a lot of modif where necessary (adding, moving, or virtualising methods)
968 WARNING : save your own sources *before* cvs up !
971 ADD virtual void Write(FILE *fp, FileType filetype);
974 ADD virtual void Write(FILE *fp, FileType filetype);
975 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
978 ADD virtual void Write (FILE *fp, FileType filetype)=0;
979 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
980 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
981 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
982 ADD std::string GetEntryByName(TagName name);
983 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
985 std::string vr = "unkn",
986 std::string fourth = "unkn",
987 std::string name = "unkn");
988 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
989 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
990 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
991 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
992 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
993 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
994 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
995 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
998 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
999 ADD virtual std::string GetEntryByName (TagName tagName);
1000 ADD virtual std::string GetEntryVRByName (TagName tagName);
1001 REM virtual bool Write(FILE *, FileType);
1002 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1003 FILE *_fp, FileType type);
1004 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1005 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1006 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1007 REM virtual std::string GetEntryByName (std::string tagName);
1008 REM virtual std::string GetEntryVRByName (std::string tagName);
1009 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1010 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1011 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1013 std::string vr = "unkn",
1014 std::string fourth = "unkn",
1015 std::string name = "unkn");
1016 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1017 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1018 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1019 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1022 ADD virtual void Write(FILE *fp, FileType filetype);
1025 ADD virtual void Write(FILE *fp,FileType filetype);
1028 ADD virtual void Write(FILE *fp, FileType filetype);
1029 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1030 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1031 REM std::string GetEntryByName(TagName name);
1034 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1036 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1038 The default constructor invoked by the line
1039 gdcmHeader *f1 = new gdcmHeader( header );
1040 was gdcmHeader::gdcmHeader(bool) instead of the expected
1041 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1042 Hence the parsing wasn't executed... See also below.
1043 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1044 as explicit constructor didn't do the trick to fix the above problem.
1045 Could anyone explain why ?
1046 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1047 properly calls gdcmValEntry::Print() (that was weed out from
1048 code related to gdcmBinEntry).
1050 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1051 * In order to fix memory leaks:
1052 - Test/TestWriteSimple.cxx: added cleaning of free store through
1054 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1055 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1056 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1057 (through the call to ::AddDicomDirMeta()) or the destructor
1058 would crash when deleting uninitialized ::metaElems].
1059 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1060 - src/gdcmDocument.cxx:
1061 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1062 from dynamic stores.
1063 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1064 was causing memory leaks.
1065 - src/gdcmSQItem.cxx:
1066 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1067 cleanly handled with polymophism: sorry but my milage is low).
1068 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1069 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1070 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1071 This avoids SegFaulting.
1072 - src/gdcmSQItem.h: coding style.
1074 - Test/TestWriteSimple still severely sucks. The output image content
1075 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1076 damaged when displayed with vtkgdcmViewer.
1077 - on memory leaks: TestWriteSimple leaks really less (see entry
1078 of 2004-06-18 in Changelog file for the call to valgrind).
1079 - on segfaults: ctest now passes all the tests but one (no more
1081 * Erroneous leading white fix:
1082 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1083 white[s] (as opposed to from >> xxx, that removes it [them].
1084 - src/gdcmTS.cxx: ditto.
1085 - gdcmPython/testSuite.py: dirty related kludge removed.
1086 * src/*: remaining references to gdcmParser removed.
1087 * src/*[cxx|h]: added copy[way]left header.
1090 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1091 * In order to fix writing of dicom files:
1092 - Test/TestWriteSimple.cxx: a simpler example of writing.
1093 - Test/CMakeLists.txt changed accordingly.
1094 - src/gdcmDocument.cxx:
1095 -- The destructor now recursilvely removes potential sequences.
1096 -- Bug fix in ::IsJPEG2000()
1097 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1098 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1100 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1101 to only declared) and build on top of
1102 ::GetDocEntryByNumber(guint16, guint16).
1103 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1104 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1105 for usage in destructor and treatement of promotion in
1106 ::ReplaceOrCreateByNumber().
1107 - src/gdcmSQItem.cxx: destructor should better handle his job.
1108 Test/TestWriteSimple now runs (or at least it DOES something).
1109 * We can now start hutting memory links. A good starting point is:
1110 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1111 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1112 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1114 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1115 * Valgrind note: after Mathieu Malaterre teached me how to read
1116 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1118 Using gcc, you can force the STL to use malloc and to free memory as
1119 soon as possible by globally disabling memory caching.
1120 With 3.2.2 and later, you should export the environment variable
1121 GLIBCPP_FORCE_NEW before running your program.
1122 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1123 simply vanish (it is still not clear to me, whether this means that
1124 STL std::string leaks or if valgrind believes it leaks...).
1125 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1126 running bin/gdcmTests makeDicomDir):
1127 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1128 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1130 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1131 SegFaulting (I drowned in DicomDir related code when trying to
1132 understand why the list is empty...).
1133 * src/gdcmDocument.h: first BSD license header try.
1134 * Doc/License.txt added.
1136 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * src/gdcmDocument.[h|cxx]:
1138 - Clean up of the Transfer related predicates. They are now all based
1139 on new method isGivenTransferSyntax, that (should) handle properly
1140 the padding problem.
1141 - general clean up, simplification, and coding style.
1142 - Specific clean up of Parse7FE0() (umproperly named actually).
1143 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1145 2004-06-14 Jean-Pierre Roux
1147 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1148 - fix the display of SQItem ordinal number
1149 - add the GetSQItemByOrdinalNumber method
1150 - remove some useless never written private methods
1152 2004-06-14 Jean-Pierre Roux
1154 - adding a constructor taking a gdcmDocEntry as an input param
1155 - ReplaceOrCreateByNumber now returns :
1156 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1157 a gdcmValEntry * if a string value is passed as a param
1159 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1160 according to the param type (no longer sets a gdcmDocEntry)
1161 - GetValEntryByNumber, GetBinEntryByNumber added
1162 - NewValEntryByNumber and NewBinEntryByNumber added
1164 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1166 - GetSQItemNumber and SetSQItemNumber added, to provide
1167 a (relative) Item identier inside a given Sequence
1168 \warning : some pb remaining around this number
1170 - AddEntry now takes the Item Number as a param
1172 - adding a constructor taking a gdcmDocEntry as an input param
1174 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * Memory leak hunt with the following command:
1176 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1177 --show-reachable=yes gdcmTests PrintDocument
1178 It looks like many (all?) leaks are due to the STL (or a bad usage
1179 of the STL. The lines producing the leaks now have a comment with
1180 a "MEMORY LEAK" tag: you can retrieve them with
1181 grep "MEMORY LEAK" src/*
1182 Here are two typical examples which I can't help fixing:
1187 char * test = "babo";
1188 name = test; //// <--- valgrind detects 960 bytes lost in
1189 //// call to std::string::operator=(char const*)
1190 name.clear(); //// Doesn't help !
1198 std::cout << "Type a bunch of characters followed by RETURN: ";
1199 getline(std::cin, line); //// <--- valgrind dectects a loss
1200 //// of 1320 bytes in call to
1201 /// std::basic_istream<>& std::getline<>
1207 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1208 * src/gdcmHeader.[cxx|h]:
1209 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1210 and related, moved away to gdcmDocument.
1211 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1212 the corresponding protected accessors of inherited class
1213 gdcmDocument, removed ! As a consequence gdcmFile had to be
1214 declared friend of class gdcmDocument (see below).
1215 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1216 - Clean up of undefined or unused methods.
1217 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1218 account the changes to gdcmHeader.h).
1219 * src/gdcmDocument.h:
1220 - gdcmFile is now a friend class (in order to take into account the
1221 changes to gdcmHeader.h).
1222 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1223 (see changes to gdcmHeader.h).
1224 - Accessors (reading on the form GetEntry*) are now public.
1225 - Clean up of undefined or unused methods.
1226 * src/gdcmDocument.cxx:
1227 - adaptation to changes to gdcmDocument.h
1228 - ::OpenFile now writes a verbose message when file cannot be opened.
1229 - some std::string properly set to VRKey
1230 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1231 references to gdcmDocument.
1232 * Test/TestFindTags.cxx: changed accordingly to above changes.
1233 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1234 cvs repository gdcmData.
1236 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1238 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1239 conflicts with gdcmValEntry::voidArea.
1240 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1241 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1242 Value representation between StringRepresentable and BinaryRepresentable.
1243 * src/gdcmDocument.cxx:
1244 - method ParseDES: proper indentation restored and usage of
1245 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1246 - method LoadDocEntry: the fingerprint left in the SetValue() of
1247 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1248 removed. Reverting to previous code segment with the proper
1249 dynamic_cast< gdcmValEntry* >.
1250 Note: this was (partially) breaking the python test suite
1251 (gdcmPython/testSuite.py) that made usage of the above
1252 fingerprint to check presence of "Pixel Data".
1253 * src/gdcmDocEntry.h: coding style.
1254 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1255 now taken into account.
1256 * gdcmPython/gdcm.i: adaptation to the new internal representation
1257 of gdcm (exit gdcmParser, hello gdcmDocument).
1258 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1260 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1261 anymore, but instead prints the loaded Python dictionary.
1262 * .... alas, the python testSuite is still broken.
1264 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1265 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1267 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1268 * src/gdcmUtil.h : export methods
1270 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1271 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1273 * Initial addition of automatic python testing
1274 * Initial addition of automatic image comparison
1276 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1277 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1278 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1280 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1281 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1282 * Test/ShowDicom.cxx : bug fix for msvc compilation
1283 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1285 2004-05-04 Jean-Pierre Roux
1286 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1287 new concepts (and new classes) :
1288 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1289 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1290 - Sequence Doc Entries (gdcmSeqEntries)
1291 a Sequence is composed of Items.
1292 Each item is a set of Doc Entries (this is recursive)
1293 The non uniqueness of the 'Dicom tag' is due to this recursivity
1294 (never taken into account)
1295 Our unability to add a new 'entry' in the header
1296 at the proper location (neither in the H-Table (map or multimap),
1297 nor in the Chained List is also due to this recursivity.
1298 Don't try, right now, to use/modify/compile these new sources :
1299 nothing is finished.
1300 We just commit all the stuff, 'as is', in order not to loose it.
1302 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1303 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1305 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1306 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1307 file prefix (SetFilePrefix)
1309 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1310 * Add a new test: ShowDicom, for now this is just the c++ version of
1311 checkRead.sh, later it will be able to compare the image read against a
1313 * Replace the DEBUG on the stack with a global entry in cmake interface:
1314 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1316 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1317 * Add an example subdir, with a real example on how to read + write a
1320 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1321 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1322 * Doc/CMakeLists.txt: the main page is now properly differentiated
1323 between the developper and user version.
1324 * Doc/doxygen.config.in: dropped search related obsolete flags
1325 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1327 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1328 * DEVELOPPER: added some helpfull comments for compile/test/install
1331 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1332 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1333 src directory, now generated in the build dir.
1334 2. Tests as mentionned smarter
1336 4. Add a new method in gdcmDict that return the PubDict by name
1337 this is interesting for 3rd party lib like ITK,
1338 where we could set the institution name / patient name...
1340 * ENH: 1. Now the test suite is working for real
1341 2. All binaries are now output in the gdcm-bin directory
1342 (this was not true before)
1344 2004-04-28 Jean-Pierre Roux
1345 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1346 SeQuence indented printing of Dicom Header.
1347 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1348 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1349 Computation of SQDepthLevel is now part of gdcmHeader constructor
1350 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1351 tree-like structure of a Dicom Header.
1352 * FIX Test code cleaning
1354 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1355 * ENH: Adding automatic testing
1356 1. Need a DartConfig.cmake to submit to public
1357 2. Add a test driver gdcmTest.cxx
1358 3. gdcmTestMain, an helper for the main test driver gdcmTest
1359 4. Files in Test don't have a main anymore, this becomes interesting
1360 when we add more and more tests, thus dsw don't have to load
1362 * ENH: Adding a GDCM_DATA_ROOT for testing
1363 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1364 one file instead of seven + some small cleanup
1366 2004-04-22 Jean-Pierre Roux
1367 * ENH Minor changes to the Print() methods.
1368 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1369 Header printing. Example given with :
1370 > PrintHeader fileName 2 new
1371 (SQ based tree-like structure still to be done for the Header ...)
1373 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1374 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1375 1. I have added some unsigned where needed
1376 2. Some function parameter not used -> (void)
1377 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1378 4. g++ don't like character '\' in comment
1379 5. #define jpeg_create_decompress jCreaDecompress
1380 this really need to be fixed
1381 6. virtualize destructor of gdcmObject ... leakage
1382 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1383 this also really need to be fixed
1384 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1385 remove compression file
1386 (as we only do decompression, right ?)
1387 * ENH: Change malloc/calloc/free with c++ equivalent
1389 2004-04-21 Jean-Pierre Roux
1390 * FIX gdcmHeaderHelper::GetXSpacing
1391 when a single value is found (bug ?), xpacing is now
1392 defaulted to yspacing
1394 2004-04-19 Jean-Pierre Roux
1395 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1396 * ENH add parameters :
1397 bool exception_on_error = false,
1398 bool enable_sequences = false,
1399 bool ignore_shadow = false
1400 to the gdcmFile constructors to be full gdcmParser compliant
1401 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1402 to allow reading of PAPYRUS 3.0 files
1404 2004-04-06 Jean-Pierre Roux
1405 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1407 2004-04-02 Jean-Pierre Roux
1408 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1409 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1410 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1412 2004-03-30 Jean-Pierre Roux
1413 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1414 for ACR file, written out as DICOM files (hope so...)
1416 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1417 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1418 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1419 moved to base class gdcmParser and only the specialisation is kept
1421 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1422 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1423 already does the job.
1424 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1425 (to be consistent with gdcmParser::WriteEntries).
1427 2004-03-30 Benoit Regrain
1428 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1429 upate of the object's instance. It's passed to 2 in the unfavorable
1430 case : one in the ExecuteInformation, one in the ExecuteData
1432 2004-03-29 Jean-Pierre Roux
1433 * ENH : Check on file type to be written moved
1434 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1435 * FIX : gdcmObject::ResetBoundaries now stops properly
1436 when end-of-list is reached
1437 : gdcmVersion modified (as Benoit Regrain asked)
1439 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1441 * src/gdcmUtil.cxx: added forgotten iostream include.
1442 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1443 equivalent to ExplicitVR in existing code).
1445 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1446 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1447 now contains all the gdcmGlobal related code.
1448 * minor coding style and doxygenation changes.
1450 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1451 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1452 now contains all the Debug related code.
1453 * minor clean-up of includes in src/*.cxx
1454 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1455 CreateCleanString) removed.
1456 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1457 * Doc/DoxyMainPageUser.txt added.
1458 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1459 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1460 src/gdcmDirList.cxx)
1462 2004-03-24 Jean-Pierre Roux
1463 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1465 2004-03-23 Jean-Pierre Roux
1466 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1467 big endian made volumes
1468 * ENH Now gdcmParser constructor and destructor are protected to forbid
1469 end user to instanciate class gdcmParser
1470 (only gdcmHeader and gdcmDicomDir are meaningfull)
1472 2004-03-22 Benoit Regrain
1473 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1474 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1475 gdcmSerie to gdcmDicomDirSerie
1477 2004-03-19 Jean-Pierre Roux
1478 * ENH Now the tree-like structure describing a DICOMDIR comming from
1479 an already existing DICOMDIR file is consistent with
1480 the home-made tree-like structure build ex-nihilo
1481 or build from the files held (recursively) in a Directory
1482 functions gdcmDicomDir::CheckBoundaries()
1483 gdcmObject::SetBoundaries() added
1485 2004-03-17 Jean-Pierre Roux
1486 * REM (Eric Boix bug) : removal of meaningless
1487 gdcmDicomDirImage::NewImage function.
1488 * FIX now file names and directory name are written properly in the
1490 * FIX now gdcmDicomDir constructor may be call without any trick
1493 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1494 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1495 of gdcmDicomDirImage::NewImage as empty function.
1497 2004-02-28 Jean-Pierre Roux
1498 * ENH add gdcmDicomDir:NewPatient
1499 add gdcmDicomDirPatient:NewStudy
1500 add gdcmDicomDirStudy:NewSerie
1501 add gdcmDicomDirSerie:NewImage
1502 to allow making gdcDicomDir object.
1503 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1504 (as opposite to the gdcmHeader chained list)
1506 2004-02-11 Benoit Regrain
1507 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1508 when using from python
1510 2004-02-10 Benoit Regrain
1511 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1512 * FIX : in gdcmDicomDir when the directory is empty
1513 * ENH : add callback and methods to get the progression of dicomDir
1516 2004-02-06 Jean-Pierre Roux
1517 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1518 - GDCM_META added to gdcmDicomDirType
1519 - class gdcmMeta created
1520 * ENH : - A brief summary is now displayed at the beginning of
1521 'testDicomDir' to help disaster magnitude estimation
1522 * REM : Now useless Test/explDICOMDIR.cxx
1524 2004-02-05 Benoit Regrain
1525 * ENH : add methods in gdcmObject to get the hash table or the list of
1527 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1528 * FIX : wrapping python for TagHeaderEntryHT
1530 2004-02-04 Benoit Regrain
1531 * FIX : even length for some strings when writting the dicom dir
1532 * FIX : sort the images in the dicom dir
1533 * FIX : Bug fix for python use of dicom dir
1534 * ADD : a python demo
1536 2004-02-04 Jean-Pierre Roux
1537 * FIX : Final solution (?) for icone embedded images
1538 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1539 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1540 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1541 gdcmData/gdcm-MR-SIEMENS-16.acr1
1542 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1543 to make full checking easier
1545 2004-02-04 Benoit Regrain
1546 * FIX : WriteEntries : coding style & logic in parameters
1547 * FIX : Set the elements to create the DicomDir in a dictionary file
1549 2004-02-03 Benoit Regrain
1550 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1551 * gdcmDicomDir : add the load of directory
1552 * Bug fix and print add-on
1554 2004-02-03 Jean-Pierre Roux
1555 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1556 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1557 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1558 * FIX gdcmParser.cxx : 'group length' elements are now considered
1559 as integers, even for shadow groups, when file is Implicit VR
1561 2004-02-02 Jean-Pierre Roux
1562 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1564 of the last synonym :-(
1565 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1567 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1568 * FIX taking into account the possible 7fe0,0010 multiplicity
1569 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1570 to allow removal of references to 7fe0,0010, to deal with
1571 ACR-NEMA images, when 0028,0200 is meaningfull
1573 2004-01-31 Jean-Pierre Roux
1574 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1575 no longer writes 'Un' on disk
1576 * FIX SQ elements with actual length are now dealt with corectly
1577 * FIX gdcmFile::WriteBase make the difference, for color images, between
1578 the length (for Palette expanded images)
1579 and Raw Length (non expanded image + Palette)
1580 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1581 (that broke Write). Replaced by UL.
1582 Aware user will reload the field if he
1583 thinks it's necesssary
1585 2004-01-30 Jean-Pierre Roux
1586 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1587 when 'dirty Acr' is found, to be compliant with the new
1588 IsReadable() methods.
1590 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1591 (no DOUBLE images in kosher DICOM,
1592 but so usefull for people that miss them ;-)
1594 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1595 DICOMDIR related utilities (not checked as Windoze compliant)
1597 2004-01-28 Jean-Pierre Roux
1598 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1600 2004-01-27 Jean-Pierre Roux
1601 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1602 to allow skipping the shadow elements, to save memory space.
1603 The TRUE value for this param has to be used
1604 with a FALSE value for the 'enable_sequence' param.
1605 ('public elements' may be embedded in 'shadow Sequences')
1606 * gdcmHeader methods now deal with 'embedded icones images' in the header
1607 (even when an 'icone image sequence' is announced by the
1608 element (0x0088,0x0200), but there is NO icone at all ...
1610 * gdcmHeader sometimes Image Location value doesn't follow
1611 the supposed processor endianity (see gdcmData/cr172241.dcm).
1614 * gdcmHeader add the method
1615 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1616 to get *all* the Header Entries with the same tag.
1617 GetHeaderEntrySameName is probabely *useless*
1618 (no meaning : Name is *not* an identifier within the Dictionnary)
1620 2004-01-26 Benoit Regrain
1621 * Bug fix in the print of hexadecimal representations. Remove long fields
1622 in the print and add a third level of print to print them
1624 2004-01-23 Benoit Regrain
1625 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1626 * Bug fix on test suite after remove the strip made on not string fields
1627 * Split the IsReadable method between gdcmParser which test that the file
1628 is dicom and gdcmHeader which test that it's an image file
1630 2004-01-22 Benoit Regrain
1631 * DicomDir : clean code, add methods, set variables in protected or private
1632 * gdcmUtil : bug fix for the clean string method
1634 2004-01-19 Benoit Regrain
1635 * Add the use of shadow dictionaries
1636 * bug fix and coding style
1638 2004-01-19 Benoit Regrain
1639 * src/gdcmFile.cxx : bug fix concerning the close of file
1640 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1641 * Add the update of header entries using the shadow library
1643 2004-01-19 Benoit Regrain
1644 * removal of file gdcmHeader2.cxx
1645 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1646 inheriting from gdcmParser. This split is to prepare the integration
1647 of dicom dir parsing
1648 * bug fix under python
1650 2004-01-16 Jean-Pierre Roux
1651 * REM removal of class gdcmHeaderEntrySet
1652 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1653 * ADD add file gdcmHeader2.cxx
1654 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1656 2004-01-15 Benoit Regrain
1657 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1658 entries created while parsing the header. Thus, they will be destroyed
1659 when the gdcmDictSet will be destroyed
1660 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1663 2004-01-15 Benoit Regrain
1664 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1665 made a fatal error because of the memory release at the end of program.
1666 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1667 some memory and vtk seems to have some problems with that.
1668 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1670 2004-01-14 Benoit Regrain
1671 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1672 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1673 * src/*.[h|cxx] : make changes due to class name changes
1674 * gdcmPython/demo/*.py : bug fix due to method names
1676 2004-01-13 Benoit Regrain
1677 * src/*.[h|cxx] : coding style
1678 * vtk/*.[h|cxx] : coding style
1680 2004-01-13 Benoit Regrain
1681 * gdcmPython/testSuite.py : test the readable flag of file for tests
1682 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1683 It's lied to the stl compilation by MSVC (windows, always windows...)
1684 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1686 2004-01-12 Benoit Regrain
1687 * src/*.h : add comments
1688 * src/gdcmDictSet.h : set the method BuildDictPath in public
1689 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1690 directly setted in the source code
1691 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1694 2004-01-09 Benoit Regrain
1695 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1696 * setup.py : use a reference to gdcmVERSION
1698 2004-01-07 Benoit Regrain
1699 * Modification to compile with the distutils.
1702 2003-12-10 Benoit Regrain
1703 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1704 can use a gdcmHeaderHelper to load datas
1705 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1706 made in the source code
1708 2003-12-10 Benoit Regrain
1709 * Update Windows projects and .cvsignore files
1711 2003-11-12 Jean-Pierre Roux
1712 * ENH gdcmHeader constructor has one more parameter (default value : false)
1713 that allows the user to 'go inside' the SeQuences only
1715 gdcmElValSet:Print takes it into account
1717 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1718 * ENH: Update gdcmPython/CMakeLists
1719 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1720 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1722 2003-11-10 Jean-Pierre Roux
1723 * FIX : gdcmHeader::LoadElements is now based
1724 on the ListTag listElem member,
1725 not longer on the TagElValueHT tagHt member
1726 * ENH : PrintPubElVal shows (temporarily) both results,
1727 with the tagHt member and the listElem member.
1728 (it's easier to 'see' the problems when using Printheader)
1730 * FIX : old private member LgrElem is now splitted into
1731 ReadLength : Length actually found on disk (updated only
1732 if bug fixing is necessary), for internal
1734 UsableLength : Updated by FixFoundLength, to fix a bug
1735 or to allow Parser going on.
1736 Will allow to re-write a kosher header when a SeQuence
1737 with a length (not 0000) is found
1738 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1739 because gdcmElValSet::Add does not update ListElem
1742 2003-11-07 Jean-Pierre Roux
1743 * FIX misstyping in Transfert Syntax name table
1744 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1745 when they have an actual length (not 0000 nor FFFFF)
1746 (Nobody should care of it, but DICOMDIR explorers)
1748 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1749 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1751 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1752 * ENH: vtkGdcmReader now supports LUT !
1753 (vtkgdcmViewer for now is not able to use them though)
1755 2003-11-05 Jean-Pierre Roux
1756 * in testSuite.py : new files names for checking the package
1757 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1758 that returns the pixel area size to the *aware* (vtk) user
1759 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1761 2003-11-05 Benoit Regrain
1762 * in testSuite.py : Modify the rules for checking the paths
1763 : Explicit error messages
1764 * in __init__.py : Related modif
1766 2003-11-03 Jean-Pierre Roux
1767 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1768 to be used by aware (vtk) users that want to manage
1769 LUT (and no to turn the PALETTE image into an RGB pixels one)
1770 * GetPixelType now returns 8U for 24 Bits images
1771 (vtkGdcmReader compliant)
1773 2003-10-31 Jean-Pierre Roux
1774 * Removal of *all* gdcmData images and add them again
1775 in order to loose the 'history' of un-anonymised images
1777 2003-10-31 Jean-Pierre Roux
1778 * RMV : removal of useless jBitsInJsample.h
1779 for both 8 and 12 Bits JPEG Lossy Libraries
1781 2003-10-31 Jean-Pierre Roux
1782 * ENH : Add the functions gdcmFile::GetImageDataRaw
1783 gdcmFile::GetImageDataIntoVectorRaw
1784 that act as GetImageData and GetImageDataIntoVector
1785 except the making of an RGB Plane from Gray Plane + LUT
1786 Intended to aware (vtk) users who know how to manage
1789 GetLUTRGBA return a R,G,B,A LUT if any
1790 lgrTotaleRaw gives the 'Raw' length
1791 GetImageDataRaw returns the gray Plane
1792 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1793 (They stay Grey, just like with other Dicom viewers :-(
1795 2003-10-30 Jean-Pierre Roux
1796 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1798 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1799 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1800 being coherents dicom files.
1802 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1803 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1805 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1806 * ENH: Two steps is necessary to please VC++ compiler...
1807 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1808 * ENH: Add include dir to medcon lib
1809 * FIX: only one function is being exported for now !
1810 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1812 2003-10-29 Jean-Pierre Roux
1813 * adding gdcmHeader::GetLUTRGBA
1814 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1815 --> Mathieu, the modif u're waiting for is not yet committed
1816 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1818 2003-10-27 Jean-Pierre Roux
1819 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1820 00191113.dcm DermaColorLossLess.dcm
1821 MxTwinLossLess.dcm RadBWLossLess.dcm
1822 * ENH: For version prior to vtkImageViewer2 -r 1.19
1823 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1825 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1826 * Removal of ido stuff in CMakeLists.txt
1828 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1829 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1830 * FIX: remove a call to ->Modified ... see comments
1831 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1833 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1834 * FIX: Problem with path for libvtkgdcmPython
1835 * ENH: Try adding a search script for python site-package
1836 * RMV: Remove some file from medcon lib that are not necessary
1837 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1838 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1839 * FIX: More pragma disable fro VC++,
1840 I don't think I break something as it is also disable in VTK/ITK.
1841 But it fasten debug compilation time.
1843 2003-10-23 Jean-Pierre Roux
1844 * gdcm now deals with 16 Bits Run Length Encoded images
1845 (they are compressed as 2 planes images,
1846 one for the high Bytes, the other for low Bytes)
1848 2003-10-22 Jean-Pierre Roux
1849 * Now CheckRead takes into account :
1850 - the bugged 'Leonardo' Siemens images
1851 - the XA images, sent thru the burning VPRO station
1852 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1855 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1856 * FIX: When copying a Makefile.am to CMakeLists.txt
1857 one should remove the '\'
1859 2003-10-22 Jean-Pierre Roux
1860 * in gdcmData adding a bugged 'Leonardo' Siemens image
1861 (wrong lengths in header)
1862 OK with gdcm, KO with the other viewers :-)
1863 * add a GE dlx XA image, thru the VEPRO burning station
1866 2003-10-21 Jean-Pierre Roux
1867 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1868 for a brutal checking of vtkgdcmViewer compliance
1870 2003-10-21 Jean-Pierre Roux
1871 * add the files for 'xmedcon' Jpeg Lossless library
1872 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1874 2003-10-21 Jean-Pierre Roux
1875 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1877 2003-10-21 Jean-Pierre Roux
1878 * garbage Siemens 'Leonardo' images dealt with
1879 (the patch is easy to remove)
1880 * cosmetic changes to avoid warnings
1882 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1883 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1884 no need to press 'r' now.
1886 2003-10-20 Jean-Pierre Roux
1887 * upgrade of checkRead.sh checkWrite.sh according
1888 to new Jpeg Lossless decompressor
1889 * add US.3405.1.dcm, a genuine RGB medical file ...
1890 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1891 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1893 2003-10-15 Jean-Pierre Roux
1894 * general anonymisation in gdcmData
1895 * adding the 'color files' from
1896 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1897 * adding some well knowed bugged-header images
1898 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1899 waiting for their inclusion in Python testsuite
1901 2003-10-15 Jean-Pierre Roux
1902 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1903 no longer seg faults when file is not found
1905 2003-10-14 Jean-Pierre Roux
1906 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1909 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1910 * TODO: *.in file to genereate a UseGDCM later
1912 2003-10-14 Jean-Pierre Roux
1913 * Some supposed-to-be Dicom Images have no preamble.
1914 OpenFile takes it into account
1915 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1916 * Missing elements added in dicomV3.dic
1917 (just to be affraid : have a look at
1918 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1919 and do it again next year ;->
1921 2003-10-13 Jean-Pierre Roux
1922 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1923 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1924 But there are NOT. It's fixed !
1926 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1927 * FIX: "jpeglib.h" was not found on VC++
1928 * FIX: vtkgdcm was not being installed
1930 2003-10-10 Jean-Pierre Roux
1931 * ENH : OpenFile closes the file if it *really* doesn't look like
1932 an ACR-NEMA / DICOM one.
1933 * FIX : testWrite no longer writes an empty file if the source file
1934 is not gdcm Readable
1935 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1938 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * FIX: CMake generate now documentation
1940 * ENH: out of source doc build !
1941 * ENH: Generate both user and dev documentation
1942 * ENH: Should work on windows too
1943 * ENH: Only one doxygen config.in file is needed
1944 * FIX: make install should be ok now on ùnix plateform
1945 * FIX: PATH to dictionary was wrong (missing /)
1946 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1948 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1949 * vtkGdcmReader is now able to read rgb dicom file.
1950 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1951 * added a gdcmViewer to vtk test, use mouse to control
1952 window level & window width
1954 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1955 * CMake-ification of gdcm, we have now two build system
1956 * FIX: on cygwin Wsock32 doesn't exist
1957 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1959 2003-10-06 Emanuel Ollart
1960 * FIX : compilation process wad broken.
1961 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1963 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1964 * change gdcmViewer -> vtkgdcmViewer
1965 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1967 2003-10-06 Jean-Pierre Roux
1968 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1969 ( e.g : well known GE images with a wrong elem length,
1970 : Philips MRI Images with a wrong Huffman table)
1971 * still to be done : allow the reading of bugged LEONARDO Siemens images
1973 2003-10-03 Jean-Pierre Roux
1974 * Odd length strings are padded with '\0' (not with spaces,
1975 to remain compliant with already defined strings,
1976 like Transfert Syntax UID and others)
1978 2003-10-03 Jean-Pierre Roux
1979 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1980 to allow displaying RGB images (not only by affim ;-)
1982 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1983 * vtkGdcmReader is now able to read rgb dicom file.
1984 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1986 2003-10-03 Jean-Pierre Roux
1987 * A few nasty patches to allow the reading of a lot of nasty images
1988 ( e.g : well known GE images with a wrong elem length,
1989 : Philips MRI Images with a wrong Huffman table)
1990 * still to be done : allow the reading of bugged LEONARDO Siemens images
1992 2003-10-03 Jean-Pierre Roux
1993 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1995 2003-10-03 Jean-Pierre Roux
1996 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1997 to allow displaying RGB images (not only by affim ;-)
1999 2003-10-03 Jean-Pierre Roux
2000 * gdcmFile::GetImageDataIntoVector now
2001 - deals with MultiFrames MultiFragments Run Length Encoded files
2002 - deals with YcBcR (YBR_FULL) files
2003 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2004 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2006 (no sample found :-(
2008 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2009 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2010 Two reasons: - clear things
2011 - third parties acces gdcm through header files, so won't
2012 suffer anymore VC++ complains
2014 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2015 * add argv[1] in testvtkGdcmReader.cxx
2018 2003-09-24 Jean-Pierre Roux
2019 * The lines are now eigthy characters long.for
2020 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2022 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2023 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2024 char* to std::string. Thus, the use of strdup becomes useless. (see
2025 previous commis of Malaterre)
2026 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2027 before the last Malaterre's commit.
2029 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * This commit should fix the Debug building under VC++, the problem
2031 was mainly a mixture of debug and release lib being loaded at startup.
2032 * I also remove a depency to a specific C function: strdup. Because I had
2033 to force the link to msvcrtd (whereas strdup is in libc).
2035 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2036 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2037 located in the gdcmCommon.h file. All use of reference of tha has been
2038 changed to now use the variable GDCM_UNFOUND.
2040 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2042 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2043 Dicom dictionary. The test suite can now be run again. Note:
2044 I'm note very happy with the " (RET)" changes. I believe this
2045 RETAINED comment should be dropped when parsing the dictionary.
2046 - PACKAGER corrected
2048 - AUTHORS updated and now in alphabetical order
2049 * Makefile.am now exports gdcm.dsw for Windoze users.
2051 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2052 * cygwin complains about missing std:: in subdir Test/
2054 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2055 * remove some methods that are now in gdcmHeaderHelper
2057 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2058 * vtkGdcmReader set spacing and origin correctly
2060 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2061 * Fix a few delete/delete[] mismatch
2063 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2064 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2065 interpretation to data given by gdcmHeader. For instance there are
2066 heuristics to get informations (look at different places).
2067 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2068 sorting DICOM images based on different strategies.
2069 * modified Makefiles accordingly.
2071 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2072 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2073 when building in debug mode
2074 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2075 src/win32/gdcmdll.dsp
2076 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2078 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2079 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2082 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2083 * src/win32/libgdcmjpeg12.dsp was not dos format
2084 * src/win32/libgdcmjpeg12.dsp :
2085 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2086 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2088 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2089 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2091 * src/gdcmFile.cxx : bug fix in affectation type
2092 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2093 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2094 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2095 symbols... future problem ?
2097 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2098 * src/win32/libgdcmijpeg12.dsp was missing
2099 * modified gdcm.dsw accordingly
2101 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2102 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2104 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2105 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2106 commit of JPR (before his hollidays to facilitate our work).
2107 * setup.py : bug fix in code. Modifications made while the last commit
2108 of JPR. The code hasn't been tested before the commit... it's so
2109 useless to make that (for best programmer that is JPR) !!!
2111 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2112 * tagged the current version as Version0_3 (i.e. version 0.3)
2114 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2115 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2116 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2117 * *.dsp : modifications to use new libgdcmijpeg8 library
2118 * setup.py : bug fix on VTKPATH variable
2119 * PACKAGER : adding all concerning windows
2121 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2122 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2124 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2125 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2126 test suite reported error.
2127 * PACKAGER file added (describes what a packager must do when
2128 packaging a new release).
2129 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2130 * configure.in: upgraded version number to 0.3.0
2131 * fixing build of rpm (through rpm -ta):
2132 - Doc/Makefile.am exports proper doxygen files
2133 - src/jpeg/libijg8/Makefile.am exports the include files.
2135 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2136 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2137 * src/gdcmHeader.h : formatting code
2139 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2140 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2141 We were obtaining error message from vtk. Now, creation of file list
2142 is made in an internal list to prevent this problem.
2143 Bug fix when output is empty.
2144 Bug fix in update of progress value. Previous commit for this was a bad
2146 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2148 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2149 * src/gdcmHeader.h : added method to get the file name
2150 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2151 files. Added method to remove all files on the input
2152 Added FIXME comment concerning the bad parsing of header made by
2153 ExecuteInformation method (in ExecuteData method)
2155 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2156 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2157 when using make instal.
2158 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2159 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2161 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2162 * setup.py : adding include dir of jpeg lib to compile all sources
2163 * */Win32/*.dsp : JPR fix for windows compilation
2165 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2166 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2168 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2169 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2171 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2172 * setup.py is again effective on un*x (takes into account the
2173 addon of the jpeg library)
2174 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2175 * Doc/Doxy* updated (includes above enhancements)
2176 * INSTALL now points to web documentation
2178 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2179 * src/gdcmHeader.h doesn't make unnecessary reference to
2181 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2183 * src/gdcm*.[cxx|h] :
2184 - to allow compilation with gcc 3.x
2185 -- clean up of STL usage (added explicit usage of std::)
2186 -- small fixes on exceptions.
2187 Note: linking not tested !
2188 - clean of doxygen comments to avoid warnings at documentation
2190 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2191 dependent convertion).
2193 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2194 * Clean up of previous JPR garbage commit (not even commented in the
2196 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2197 - moved all jpeg related files from src to src/jpeg/libijg8, with
2198 addition/modification of Makefile.am and configure.in.
2199 - the testSuite is still brain damage (not guilty).
2201 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2202 * WrapVTK.py : modifications to get correctly vtk source files to
2204 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2205 (FileName -> Filename)
2207 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2208 * vtk/vtkGdcmReader.[cxx/h]:
2209 - UpdateProgress method should now be effective
2210 - removed the limitation on having only images loaded (as opposed
2212 - when building a stack of images/volume, a lesser number of
2213 gdcmHeader and gdcmFile instances should be used (hopefully
2214 accelerating things).
2215 - when building a stack of images/volumes, files which are not
2216 loadable (wrong path-filename, wrong permissions on existing file,
2217 or file not parsable by gdcm) are replaced with a black image
2218 in the stack (for the caller to notice the problem).
2220 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2223 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2224 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2225 between standard library (std) and vtk library (problems are found
2226 under Windows... thanks Windows !)
2228 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2229 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2231 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2233 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2234 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2236 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2237 * When compiling with distutils (see setup.py) the C++ compiler is
2238 called with different flags than the default ones (with automake).
2239 In order to fix all those warning, I compiled gdcm with the command
2240 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2241 and went for warning fixes:
2242 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2243 up from unused variables.
2244 - vtk/vtkGdcmReader.cxx: potential bug fix.
2245 * src/gdcmHeader.h: Doxygen warning cleanup
2247 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2248 * gdcmPython/gdcm.i:
2249 - typemaps correction to take into account the systematic replacement
2250 of "using namespace std" with std:: prefix e.g. std::list,
2251 std::string... (cf changes of 2003-05-21).
2252 - gdcmGlob global variable of type gdcmGlobal (defined in
2253 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2254 exported to Python a as cvar.
2255 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2256 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2257 gdcmDictSet.GetPubDictTagNames() and
2258 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2259 C++ static methods).
2260 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2261 with the above changes.
2263 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2264 * setup.py, manifest.in : bug fix under linux
2266 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2267 * Modification of setup.py to compile vtk part too. Then, we have 2
2268 wrappers which must work with same distutils. For that, we have a
2269 generic distutils in distusiltsWrapping.py ; with :
2270 - build_extWrap class to wrap generically all extensions,
2271 - ExtensionWrap base class for all wrapping extension that contains
2273 - Wrapper interface which wrap sources
2274 + In WrapSwig.py we have extension and wrapper for Swig
2275 + In WrapVTK.py we have extension and wrapper for VTK
2276 * MANIFEST.in : modifications to consider vtk directory and new python
2277 files for compilation
2279 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2280 * Added python wrappers of vtkGdcmReader vtk class (see the
2281 source in vtk/vtkGdcmReader.cxx) :
2282 - vtk/Makefile.am now builds a library
2283 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2284 python library (as opposed to _gdcm.so wich are the python
2285 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2286 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2288 - configure.in has an additional flag --enable-vtk that needs
2289 to be set to enable compilation of vtk related code, that is:
2290 + vtk/vtkGdcmReader.so and
2291 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2292 + gdcmPython/vtkgdcmPython.so (see above)
2293 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2294 be read when compressed or when HighBit + 1 != BitsStored),
2295 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2296 the usage of the python wrapper of vtkGdcmReader vtk class.
2297 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2298 * src/*.[h] all occurences of stl classes are now prefixed with
2299 std::, and all occurences of "using namespace std;" where removed.
2300 This is to avoid pollution of global namespace in included files.
2301 Apparently vtk does not avoid this pitfall: when using both
2302 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2303 collision of various stl members (principally cout...).
2304 * gdcmPython/testSuite.py now cleanly removes temprory generated
2306 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2307 comply with above changes)
2309 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2310 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2311 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2312 vtk data structure (an image Flip was required).
2313 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2314 * cosmetic changes in documentation.
2316 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2317 * src/gdcmHeader.cxx: the constructor no longer exits when an
2318 unexisting file is given as argument.
2319 * The subdirectory Data (containing all the images used for the
2320 test suite) is not part of this repository anymore. A new module
2321 containing those images is now available at
2322 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2323 with the name gdcmData.
2324 All the python scripts (including the package initialisation file
2325 gdcmPython/__init__.py) were adapated to take this change into
2326 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2328 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2329 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2330 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2331 demo of the usage of this class.
2332 Compilation of this vtk part is only done when using the --enable-vtk
2333 at configure (or autogen.sh) stage.
2335 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2336 * More memory link related corrections and documentation fixes.
2338 - maximum info is obtained with a command of the form:
2339 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2340 --show-reachable=yes PrintHeader
2341 - the remaining reachable blocks seem to come from the STL
2342 allocation scheme through the usage of map and list. It looks
2343 like this memory cannot be freed but it is not a memory leak
2344 (in fact further invocation to the STL would recollect the
2345 unused memory allthough it cannot explicitely be freed).
2346 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2347 of displaying an image parsed with gdcm and displayed with VTK.
2348 Note: some images don't seem to work e.g.
2349 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2350 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2351 Allthough this weakens the semantics, it is a ditch attempt to
2352 make gdcm more thread friendly.
2354 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2355 * Memory link hunt (by using valgrind through the command
2356 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2357 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2358 gdcmHeader::_dicom_vr.
2359 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2360 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2362 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2364 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2365 * src/Makefile.am now exports all the necessary include files at
2369 * UpdateGroupLength replaced by new one
2372 * UpdateGroupLength re-written using H-Table
2373 (named UpdateGroupLengthNew untill checks are over)
2375 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2376 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2377 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2379 - gdcmHeader::GetPubElValSet removed.
2380 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2381 UpdateGroupLength, WriteElements, Write.
2382 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2383 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2384 carried the same semantics.
2385 - src/gdcmHeaderIdo.cxx changed accordingly.
2386 - gdcmFile::WriteBase now regroups all the codes from previous
2387 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2388 - enum FileType moved to gdcmCommon.h
2389 * src/gdcmHeader.cxx AddDefault trashed
2390 * gdcmGetXSize added
2391 * getimageDataSize now calls gdcmGetXSize
2392 * Test/*.cxx changed to agree with above changes
2394 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2395 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2396 (to avoid double call by end user).
2397 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2398 by end user, since gdcmHeader::gdcmHeader now handles it.
2400 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2401 * gdcm/Doc many doxygen changes:
2402 - Doxyfile now has two different versions, DoxyfileUsers that generates
2403 the html.users end users oriented documentation and
2404 DoxyfileDeveloppers that generates the html.developper developper
2405 oriented documentation.
2406 - README changed accordingly
2407 - requirement.txt removed (old design info moved to TODO).
2408 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2409 DoxyMainPage.txt, DoxyPython.txt provide more information.
2410 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2411 be updated by simply regenerating the docs with doxygen and copying
2412 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2413 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2414 all the tests in the form "if (<map>.count() >1)" were removed.
2415 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2416 ill-formed documentation sections.
2417 * src/gdcmHeader.cxx: ditto
2419 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * setup.py fixed for un*x (needed macro for stdint.h)
2421 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2422 un*ces with sh-utils test utility.
2423 * gdcmPython/demo/test.py renamed to PrintHeader.py
2424 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2425 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2426 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2427 * src/gdcm*.cxx JPR's bad inclusion fixed.
2429 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2431 * gdcmPython/demo/test.py changed accordingly.
2433 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2434 * gdcmPython/Makefile.am fixed linking against libstdc++
2435 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2436 * Swig subdir (historical tests of swig version 1.3.17++) removed
2437 * Test/testChangeEntete.cxx some lines commented out in order to make
2439 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2440 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2442 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2444 hence the user doesn't need this explicit call.
2445 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2446 i.e. LoadElements() call removed.
2447 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2448 - src/Makefile.am declares the proper flag for g++.
2449 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2450 for adding user defined new tags.
2451 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2452 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2453 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2455 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2456 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2457 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2458 src/Makefile.am : the project should properly compile and install
2459 with the autotools, included the python wrappers part.
2460 * gdcm.spec.in : added a spec file for RPM packaging.
2462 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2463 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2465 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2467 to exported to the environement (see gdcmPython/testSuite.py
2469 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2470 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2471 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2472 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2473 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2475 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * gdcmPython/__init__.py doesn't crash anymore when running in
2477 in InstallMode or PreInstallMode but with an environement given
2478 value of GDCM_DICT_PATH.
2479 * src/gdcmDictSet.[cxx/h] coding style.
2481 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2483 * src/gdcm.h general comments moved to TODO, and README
2484 * src/gdcm.h should now be seen as a user commodity (including it
2485 should suffice to fully use gdcm). It is nowhere including within
2486 any of the kernel files src/*.cxx and src/*.h.
2488 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2490 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2492 * src/gdcm*.cxx only include their corresponding include file
2493 (as opposed to gdcm.h)
2494 * gdcmPython/gdcm.i changed accordingly
2495 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2496 the autogen.sh generated "make snapshot" command to work.
2497 * autogen.sh removed history related references to crea package.
2499 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2500 * distutilsSwigCPlusPlus.py work around some swig portability
2503 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2505 was done in a last ditch attempt to get setup.py _really_
2506 operationnal. The python/gdcmPython layaout add the advantage
2507 of hidding away the python related distutils specific files
2508 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2509 Alas, the src directory was out of scope (i.e. it's relative
2510 position to setup.py was ../src) which made things impossible to
2511 handle (see previous version of python/setup.py). Crossing fingers...
2513 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * python/setup.py now works on Un*x. (harder than I thougth)
2515 * python/distutilsSwigCPlusPlus.py can now have include files
2516 among the list of sources.
2518 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2519 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2520 * modifications in MSVC projects
2522 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2523 * As stated by the first lines of Test/ExceptionAndPython/README, it
2524 looks like we can move back to original usage of exception within
2525 src/gdcm* and hence remove the errno stuff that was introduced
2526 as a quick and dirty fixture of this problem (added to the TODO).
2527 * Doc/Doxyfile configuration file for Doxygen and corresponding
2528 README file for usage added.
2529 * Test/testWrite.cxx added. This new test comes from a split of
2530 test.cxx that is now reverted to its original purpous i.e.
2531 testing the proper parsing of a Dicom related file.
2532 testWrite.cxx concentrates on testing the IO part of gdcm.
2533 * Test/bug1.cxx (containing a bug on WIn32) added.
2534 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2535 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2536 whose purpose is to publish the content of the TagNames of the
2537 Dicom public dictionnary were not accessible without an
2538 instance of class gdcmHeader.
2539 - those methods are now static methods of gdcmDictSet and hence
2540 require no instances at all to be invocated.
2541 - within gdcmDictSet this change required to change some method
2542 to class methods (i.e. are now static) among which SetDictPath
2543 (renamed to BuildDictPath) and LoadDefaultPubDict.
2544 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2545 the above changes by calling the new method classes of gdcmDictSet.
2546 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2547 the above to be effective.
2548 * python/gdcmPython: in order to wrap properly the above changes
2549 for Python, swig version now needs to be > 1.3.17.
2550 * python/gdcmPython/Makefile fixed to adapt itself to new
2551 configure/make shema introduced by Johan Montagnat (thanks for the
2552 contribution). Alas this Makefile cannot be turned into a proper
2553 Makefile.am without some heavy changes in the configure.in
2554 (for python dectection).
2555 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2556 now avoids publishing the empty entries.
2558 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2559 * python/setup.py : bug fix concerning install under windows
2560 ExtraPath reused :-P
2561 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2563 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2564 * Dicts/dicomV3.dic : remove double spaces !!!
2565 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2566 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2569 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2571 method. Doxygenation.
2572 * src/gdcm.h clean up of JPR spurious comments.
2574 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2575 * python/distutilsSwigCPlusPlus.py now properly collects the
2576 shadow classes generated by "swig -c++" (gdcm.py in our case)
2577 when using "python setup.py install".
2578 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2579 reexports the working classes.
2580 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2581 by the classical C errno scheme. This is to prevent an obscure
2582 behavior of the python wrappers when importing wxPython.wx prior
2583 to gdcmPython (which ended up in an abort call). An illustration
2584 of this oddity can be found in the Test/ExceptionAndPython
2585 subdir (see the README file). This problem probably due to
2586 an combination of g++ and dynamic loading.
2587 * added Test/ExceptionAndPython (see above)
2589 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2590 * Changed the layout of the python part to avoid bloating main
2591 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2592 i.e. the distutils arsenal. All the python related stuff is
2593 again in a python subdir, but the package itself is now in
2595 * setup.py was cleaned up:
2596 - pythonIncludePath removed
2597 - python setup.py bdist target is now functional.
2598 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2599 collision with other packages). gdcmPython/demo/*.py changed
2602 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2603 * python subdir moved to gdcmPython (preparation of distutils packaging).
2604 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2605 distutils installer is operational.
2606 * - gdcmPython/__init__.py now properly loads the swig generated
2607 shadow classes (from gdcm.py).
2608 - gdcmPython/demo/*.py changed to import the package gdcmPython
2609 instead of gdcmPython/demo/load.py.
2610 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2612 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2613 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2614 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2615 entries within the associated public Dicom dictionary resp. the same
2616 information but sorted by the fourth field (PAT, IMG, DIR) of the
2618 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2619 are now in the "???" group.
2620 - python/gdcm.i changed accordingly,
2621 - python/demo/printGroupedPublicDict.py added, that gives an example
2622 of the above new functionalities in Python.
2624 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * src/gdcm.h, gdcmHeader.cxx:
2626 - historic references to glib's g_malloc and g_free (#defined)
2627 were definitively removed.
2628 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2629 * src/gdcmElValSet.cxx:
2630 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2631 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2632 - GetElValue(string) renamed to GetElValueByName.
2633 - Added GetElementByName(string).
2634 * src/gdcmHeader.cxx: added
2635 - GetPubElValRepByNumber(guint16, guint16)
2636 - GetPubElValRepByName(string)
2637 - GetShaElValRepByNumber(guint16, guint16)
2638 - GetShaElValRepByName(string)
2639 - GetShaElValByNumber(guint16, guint16)
2640 - GetShaElValRepByName(string)
2641 - GetElValRepByNumber(guint16, guint16)
2642 - GetElValRepByName(string)
2643 - GetElValByNumber(guint16, guint16)
2644 - GetElValRepByName(string)
2645 * Doc/requirements.txt added.
2647 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2648 * Test/Makefile building now depends on the one of libgdcm.so
2649 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2650 pixel data) aware which enables finding the address (offset) of
2651 the pixel data of JPEG encoded DICOM files. This leaves only a single
2652 file in the testSuite whose pixel data address (offset) is unknown.
2653 * python/testSuite.py changed accordingly.
2655 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2656 * VC++ has some strong limitations when working with the STL, as stated
2657 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2658 "Also note that some STL containers (map, set, queue, list, deque)
2659 cannot be exported. [...]
2660 Some STL classes contain nested classes. These classes can not
2662 This is caused by a designed limitation that once a template
2663 class is instantiated, it can not be re-instantiated and
2665 Since our usage of map<> is ubiquitous in gdcm, this "designed
2666 limitation" of VC++ is a pitfall.
2667 Hence the Python wrappers of gdcm cannot be incrementally linked
2668 against the c++ dynamic library. The dirty but only workaround is
2669 to forget about incremental link of dynamic libraries and to generate
2670 the Python wrappers library with the inclusions of the underlying C++
2672 The following modifications concern this matter on Win32/VC++:
2673 - wrapping python correct with standalone wrapped dll (don't use separate
2674 dll under windows !!!!)
2675 - python21_d debug mode enabled (ask Frog how to use it :-)
2676 - NO problem with having an STL member of class for example string in C++
2677 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2678 - Python test of dcmlib in Python is ok under windows on a large set
2680 * removed glib references
2681 * typedef's inserted in gdcm.i for correct swig type management
2683 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2684 * python/demo/*.py load.py extracted from test.py. Added explore.py
2685 that only displays required tags and testAll.py that parses all
2686 the files of the testsuite without using unittest.
2687 * python/testSuite.py other additional test on new files added.
2688 * Data/* new test files added accordingly to the testSuite.
2689 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2690 the vr in the file differs from the one of the dictionary.
2692 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2693 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2694 values, but limits itself to values which are below a user specified
2695 size (by default 1024 bytes).
2696 * python/gdcm.i : elements not loaded (because their size is above the
2697 user specified treshold) are exported with their TagKey as key of the
2698 python dictionary. This enables the testsuite to make some checks
2699 on the unloaded elements (since we have their offset and size).
2700 * python/testSuite.py
2701 - now tests for the existence and proper value of the pixel data
2702 - two new examples added.
2703 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2705 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2707 aware. See the strategy comments in gdcmHeader::FindeLength().
2708 * Test/test.cxx now accepts a filename as first argument.
2709 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2710 * python/testSuite.py changed to integrate test on above files.
2712 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2714 the vr was also RET.
2715 * python/testSuite.py more tests added.
2717 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * python/testSuite.py unittest test suite added (uses Data)
2719 * Data/* dcm and acr files for the test suite.
2720 * glib dependance removed from un*x version. We now use ISO C99
2721 7.18 Integer types (see stdint.h)
2722 - python/Makefile, src/Makefile src/gdcm.h
2723 * src/ when an explicit vr (like dicom files) suddenly poped an
2724 implicit element we use to mark the underlying DictEntry of the
2725 concerned ElValue with "Implicit". This strategy was damageable
2726 too the public or provite dictionaries, since some of their vr
2727 would be changed. Since Header::FindLength heavily relies on the
2728 detection by Header::FindVR of falsely explicit elements, I
2729 added an extra ImplicitVr member to ElValue (boolean).
2730 The rest of the changes we the necessary adaptations.
2732 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2735 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2737 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2738 * Adaptation for porting to VC++:
2740 o forced to use std namespace (for string to be known)
2741 o all class use __declspec export style on WIN32
2742 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2743 (in stdlib.h on Win32 but in std:: for gcc)
2744 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2745 variable GDCM_DICT_PATH.
2746 * src/gdcmHeader.cxx verbose comments made discrete.
2748 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * python/gdcm.i: added a typemap that converts a C++ hashing table
2750 to native Python dictionary.
2751 * python/demo/test.py:
2752 - now uses the native dictionary for exploration of gdcmHeader.
2753 - takes an optional filename argument (the file to parse).
2754 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2755 PubElVals hashing table.
2756 * Dicts/dicomV3.dic removed error prone trailing spaces.
2758 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * Python wrapping process moved away from src/Makefile to
2760 newly created python/Makefile (as well as gdcm.i)
2761 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2762 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2763 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2764 from the environement variable GDCM_DICT_PATH (when existing).
2765 * src/gdcmDict::GetTag bug fix.
2767 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * Straightforward temporary fixes for swig to build the python wrappers.
2769 src/Makefile now has a python working entry [by working we mean
2770 that we can import de shadow classes without errors].
2772 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2773 * hashtest.cxx removed (since allready in Test)
2774 * src/gdcmlib.h renamed to src/gdcm.h
2775 * src/dcm.i renamed to src/gdcm.i
2776 * src/Makefile prepared for python wrapping
2778 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * src/gdcmHeader.cxx :
2780 - Parsing of header is now separated from loading of element values
2781 (see gdcmHeader::LoadElements).
2782 - general clean up of hopefully all file access (creation of
2783 ReadInt16 and ReadInt32)
2785 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * src/gdcmHeader.cxx :
2787 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2789 - SetLgrElem renamed to SetLength
2790 - GetLgrElem renamed to GetLength
2791 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2792 * src/gdcmElValSet.cxx fixed both GetElValue methods
2793 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2794 due to IdoDude was cleaned out.
2796 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2797 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2798 concentrates on finding the value representation (when it exists).
2799 RecupLgr now only finds the element value length, and it avoids
2800 returning the unecessary skL (skipped length).
2801 Also, offsetCourant was simply removed (with taille_fich) since
2802 it was redundant with the File position internals (by using
2803 ftell and fseek). This also made skL (see above in RecupLgr) usage
2805 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2806 on the libido specificities which are handled through class
2808 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2811 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * Truckload of changes. Parsing of header is barely functional
2813 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2815 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2816 * src/gdcmHeader.cxx many addons of low level methods
2818 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2820 and _IdDcmSWAP_LONG.
2822 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * This corresponds to all the changes decided at the meeting of
2824 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob