1 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Apply first patch toward better string comparison when dealing with broken
3 DICOM files. Essentially the string could be padded with a space instead
4 of a null character as defined by standard
6 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
8 because never used... and in the same time, that's remove some memory leaks
10 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmFile.cxx : now delete the PixelConvert instance.
12 * In examples and tests : change the type of image data variables from void*
13 to uint8_t*. Remmove all delete on image data variables
15 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
17 Verify the file pointer value before open the file, and if it's not null,
18 a verbose message is generated.
19 Close correctly the file when the file isn't considered dicom-like. The
20 correctly close is a call to CloseFile.
21 When closing the file pointer, test if its not null to close the file.
22 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
23 file. For an uncompressed image, the copied datas correspond in the least
24 case to the image size (calculated) or the image size specified in the
25 header. A verbose is generated if these two size mismatch
27 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
29 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
30 break under windows (with msvc6 compilation).
32 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
36 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Bugs fix for the Windows build with VC6
38 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
39 needed (only for projects required VTK). If the VTK is included in all
40 projects, there is conflicts with the jpeg lib of vtk when compiling the
41 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
42 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
43 when compiling the gdcm_wrap.cxx file (created by the compilation of the
45 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
46 (like it's already made for the cout use). Otherwise, conflict with the
49 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
52 - comments on the DicomDir::Method related usage added.
53 - now that we use the namespace gdcm, a lot of internal classes do
54 NOT need to be wrapped anymore.
55 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
56 DicomDir::Method) new example added.
58 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
59 * Improve string manipulation. I now inforce the notion of 'DicomString'
60 A DicomString can contain as many \0 as they want
61 and it is *always* of even length.
62 We only support odd length for very rare case.
63 And in the near future this should be removed.
65 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
66 * /binary_write/ gdcm source. Now even on big endian we are writting
67 little endian. This should -heopfully- fix some tests
69 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
70 * Now the dictionary is compiled into gdcm lib. This is a default
71 behavior, thus any dic file specified is picked before failback to
72 the one comiled into lib
74 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
75 * Change internals for gdcmDict. Don't use any 'new' any more.
76 This should definitely solve any leak problem, and we should be
77 as fast as before, as long as don't modify too much the dictionary.
79 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
80 * STYLE: ivars should start with a capital letter.
81 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
82 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
84 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
85 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
86 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
87 new 2004 dictionaries added (thanks to JPR).
88 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
89 * CLEANUP_ROUND (15) for gdcmPixelConvert
90 - RLEFrame::NumberFragments is now of type unsigned int
91 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
92 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
95 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
96 * Initial work in gathering all transfer syntax accessors. clearly
97 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
98 ivars, but only one transfersyntax (class) ivar with equivalent method on
101 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
102 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
103 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
104 discussed (plus I didn't like having a 2000 lines patch not commited)
106 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
108 * CLEANUP_ROUND (14) for gdcmPixelConvert
109 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
110 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
111 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
113 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
114 anymore and hence avoids storing a copy of PixelConvert::Decompressed
115 into File::Pixel_Data.
117 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
118 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
119 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
120 * CLEANUP_ROUND (13) for gdcmPixelConvert
121 Substituted File::ParsePixelData() with PixelConvert::Print() new
123 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
124 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
125 method to those classes.
126 - src/gdcmFile.[cxx|h]:
127 -- Added a ::Print() method.
128 -- PixelConverter is now a reference instead of a member.
129 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
130 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
132 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
133 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
134 collaboration diagram and inheritance diagram should be generated with
136 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
137 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
138 pointlessly wrapped (see
139 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
140 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
141 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
142 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
143 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
144 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
145 -- File::Initialise: PixelConverter setup moved away to
146 PixelConverter::GrabInformationsFromHeader()
147 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
148 interpretation moved away to PixelConverter::BuildRGBImage()
150 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
151 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
152 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
154 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
155 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
156 displayed on Win32 when a brutal abort() occurs (because of uncatched
157 exception). See TODO new entry of this commit for more on this.
158 * TODO added new entry.
159 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
160 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
161 - HandleColor is no longer called from gdcmFile.cxx
162 - gdcmPixelConvert.cxx clean up on method arguments and internal
163 variable names for semantical coherence.
165 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
166 * Finished lossless transition, not only do we now read all lossless jpeg
167 images, without the need of the Cornwell lib, but we do read them properly now
168 * To reduce code (well to avoid code duplication), I defined a common place
169 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
170 redefine symbols. This is not prefect but this the best solution I found for a
171 compilation time jpeg option.
173 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
174 * Update jpeg ijg lib to support lossless jpeg implementation
175 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
177 * Also added a special copyright for dcmtk since we use their bugfixes.
180 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
181 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
182 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
183 matters, as stated in warning note at begining of %include section).
184 * src/gdcmDicomDir*.[cxx|h]: coding style
185 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
186 * src/gdcmJpeg8.cxx: doxygen fix.
187 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
188 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
189 from File:: to PixelConvert::.
191 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
193 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
194 - more code moved away from File:: to PixelConvert::
195 - fat setup of PixelConverter set in place in File::Initialise.
197 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
198 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
199 namespace at the file system level. So now you should convert your examples
201 gdcmHeader -> gdcm::Header
202 It would be nice if people keep in mind to no open the namespace, since it
203 allows compilation on broken plateform which were defining common symbol in
204 the standart namespace (like LP, Unknown ...)
206 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
207 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
208 The JPEG fragments are now parsed at the same stage than the RLE
209 information. All code related to JPEG is now in gdcmPixelConvert:
210 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
211 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
212 export a gdcmFile:: method. Those are simply global functions
213 (for the time being this is better than having them attach to
214 either gdcmFile:: or gdcmPixelConvert::).
215 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
216 and stores the result in a gdcmJPEGFragmentsInfo.
217 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
218 code (among other stuff) moved away from gdcmFile:; to
221 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
222 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
223 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
224 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
225 clean up of RLE related code.
226 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
227 - src/gdcmRLE.cxx removed
228 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
229 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
230 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
231 * CLEANUP_ROUND (9) for gdcmPixelConvert
232 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
233 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
234 away from gdcmFile:: to gdcmPixelConvert::.
236 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
237 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
238 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
239 This is because Parse7Fe0 used to parse the pixels to compute the
240 length. This task was passed over to FindDocEntryLengthOB() a long
241 time ago, EXCEPT I had forgotten the OW case...
242 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
243 we just recylce the code for parsing RLE fragments and computing
245 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
246 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
247 with the retired Parse7Fe0().
248 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
249 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
251 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
253 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
254 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
255 - src/CMakeLists.txt: alphabetic order reodering + new entries.
256 * CLEANUP_ROUND (4) for gdcmPixelConvert
257 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
258 to return an unused length.
260 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
261 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
262 this should be cleanner from the plane view. The iostream are erally a pain
263 to use to do simple stuff.
265 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
266 * Redo the compilation of the ijg jpeg library. Now only one source is
267 necesseray. No need to rename file by hand what so ever. CMake handle the
268 copying of the file within different directory, configure header file to
269 modify some symbol. The only addition made to ijg wasd a mangle table so
270 that symbol are different wether we are within 8bits or 12bits.
272 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * Added documentation of vtkgdcmReader on Website:
274 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
275 with it's binary name).
276 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
277 the Website to be more complete.
278 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
279 doxygenated documentation.
280 - Doc/DoxyVtkGdcmReaderExamples.txt added
281 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
282 DoxyVtkGdmReaderExamples.html )
283 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
284 * CLEANUP_ROUND (3) for gdcmPixelConvert
285 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
287 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * CLEANUP_ROUND (2) for gdcmPixelConvert
289 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
291 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * CLEANUP_ROUND for gdcmPixelConvert:
293 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
294 - src/gdcmPixelStuff[h|cxx] removed
295 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
296 - src/CMakeLists.txt changed accordingly
298 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
299 gdcmVersion.py moved to newly created ATTIC related
300 gdcmPython/SetupOldies/ directory.
301 * Autotools clean up:
302 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
303 - autogen.sh configure.in acinclude.m4 python.m4 removed
305 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * src/*.cxx *.h Reference to License.htm fixed to License.html.
307 * Doc/CMakeLists.txt, doxygen.config.in: fix.
308 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
310 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
311 * TODO updated with Mathieu suggestions. I proposed a template for
312 describing TODO entries and used it for new entries.
313 * Added Doc/Website/CodingStyle.html, Developpers.html,
314 DeveloppersPython.html, GdcmDataCvs.html and
315 DownloadVersion0_1.html, DownloadVersion0_3.html.
316 * Some Doc/*.txt Doxygen files (which do not really concern the
317 documentation itself, but the website) moved to html and
318 placed in directory Doc/Website:
319 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
320 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
321 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
322 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
323 * CMakeLists.txt changed accordingly.
324 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
325 DeveloppersPython.html
326 * INSTALL nows refers to Doc/Website/Installation.html
328 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
329 * Added Doc/Website directory, that contains a first raw version
332 2004-09-23 Jean-Pierre Roux
333 * FIX In order not to be poluted any longer by casting problems,
334 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
335 we can now delete[] it safely
336 * VoidArea is now called BinArea (less confusing name),
337 and all the methods called ...VoidArea... are now ... BinArea...
338 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
340 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
342 clear) TagHT, which is an inherited member of gdcmElementSet. It is
343 up to the destructor of gdcmElementSet to clean up TagHt and it's
346 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
347 * Test/CMakeLists.txt: update to follow gdcmData renamings.
348 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
350 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
351 * ENH: added some utility method that builds a flat dictionnary
352 holding all the Dicom entries contained in the recursive structure
353 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
355 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
356 BuildFlatHashTable() that build a flat dictionary.
357 - src/gdcmElementSet.h: added a new private GetTag() accessor.
358 gdcmDocument is now a friend of gdcmElementSet.
359 - src/gdcmElementSet.cxx: clean up.
360 - Example/FlatHashTablePrint.cxx added.
361 - Example/CmakeLists.txt changed accordingly
363 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
364 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
365 moved away from gdcmDocEntrySet (since this class is an abstract class
366 acting like an interface). SQDepthLevel and BaseTagKey are now
368 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
369 and associated accessors. Doxygenation of the class.
370 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
372 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
373 Use SQDepthLevel accessor instead. ::Print() adapted.
374 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
375 - src/gdcmDocument.cxx changed accordingly.
377 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
379 - The following is the doxygen comment of the typedef declaration
380 of gdcmagKey in src/gdcmCommon.h:
381 gdcmTagKey is made to old an "universal" (as in URL, Universal
382 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
383 A dicom tag allways has a group and an element, but a set of tags
384 embeded in various (optionally nested) sequences and sharing
385 the same group and element all share the same (group, element)
386 "identifier". Hence the (group, element) cannot be used as an
387 identifier (in gdcm we shall refer to a "TagKey") of a tag.
388 In order to construct a proper tag identifier (i.e. a key) we
389 consider the following definition of a TagKey:
390 - let Group, Element be the string representation of the
391 group and element dicom tag members,
392 - let ItemNumber be the string representation of the integer
393 index of the considered item number of a sequence,
394 Let the key of a tag embeded in a sequence, noted SeqTag, be
396 /ItemNumber#Group|Element
397 where "/", "#" and "|" are characters acting as separators.
398 Then the general form of a gdcmTagKey is given by:
399 Group|Element<SeqTag>
400 where <SeqTag> means NO or many instances of SeqTag.
401 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
404 but the gdcmTagKey of a tag "embeded" is the first item of
405 a sequence, itself nested in the third item of a sequence is the
407 0004|1220/2#0008|0082/0#0008|0090
408 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
409 order to hold the new sequence compatible key. Previously, the
410 GetKey() method would look in the underlying gdcmDictEntry.
411 - src/gdcmDocEntry.cxx:
412 -- constructor now copies the underlying DictEntry key, in the local
414 -- ::Print: displays the member Key, instead of the (group, element).
415 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
416 - src/gdcmDocEntrySet.h:xi
417 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
418 -- now has a new BaseTagKey member.
420 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
421 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
423 This poses the problem with the semantics of the following lines
424 LoadEntryVoidArea(0x0028,0x1201); // R LUT
425 LoadEntryVoidArea(0x0028,0x1202); // G LUT
426 LoadEntryVoidArea(0x0028,0x1203); // B LUT
427 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
428 to the long FIXME note for what the problem is. Nevertheless in
429 order to get things working the dicom dictionary was altered !
430 Please fix things urgently...
431 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
432 information), see above note on moving the member VoidArea. Nevertheless
433 the following entries previously correctly set as US are now inproperly
435 0028 1201 OW IMG Red Palette Color Lookup Table Data
436 0028 1202 OW IMG Green Palette Color Lookup Table Data
437 0028 1203 OW IMG Blue Palette Color Lookup Table Data
438 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
439 of gdcmDocEntry moved to gdcmSeqEntry.
440 * src/gdcmSeqEntry.cxx: STYLE.
442 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
443 * Test/TestAllEntryVerify.cxx minor fix and added comments.
445 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
446 * gdcmPython/testSuite.py: all the test suite in python is now moved
447 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
448 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
449 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
451 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
452 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
453 to avoid inclusion recursion until STL is reached.
454 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
455 mecanism. errno.h is not included in gdcm anymore.
456 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
457 (gdcmFormatError now inherits from gdcmFormatUnexpected).
459 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
460 gdcmData/TestAllEntryVerifyReference.txt
461 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
462 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
463 exception_on_error parameter.
464 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
465 - vtk/vtkGdcmReader.cxx changed accordingly,
466 - Example/*.cxx and Test/*.cxx changed accordingly.
468 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
469 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
470 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
471 enable_sequences removed from gdcmHeader constructor and dependencies.
472 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
473 * gdcmPython/demo/PrintHeader.py: dummy fix.
474 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
475 skip_shadow removed from gdcmHeader constructor and dependencies.
476 * Example/*.cxx and Test/*.cxx changed accordingly.
478 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
479 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
480 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
482 2004-07-21 Jean-Pierre Roux
483 * FIX Now, Parsing and Printing a DICOMDIR do work!
484 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
486 2004-07-20 Jean-Pierre Roux
487 * FIX Some brain damaged headers have Zero-Lenght fields
488 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
490 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
492 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
493 variable (instance of gdcmDebug) by a definition macro, and the instance
494 is now in static in the gdcmDebug class
495 * src/gdcmSQItem.h : (FIXME) remove an undefined method
496 * Test/PrintAllDocument.cxx : bug fix in the result of the test
498 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
499 * WARNING: ctest now depends more tightly on gdcmData. You should
500 check out gdcmData properly for things to run smoothly...
501 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
502 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
503 we need the pixels not be loaded in order to use the ValEntry
504 that displays position and size).
505 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
506 This is a C++ based equivalent of gdcmPython/testSuite.py that should
507 be deprecated. If you have any doubts about the advantages of a
508 modern scripting language (read Python) versus grass root C++ (i.e.
509 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
510 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
511 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
512 Anyhow, consider documenting the gdcmData images in
513 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
515 * Test/CMakeLists.txt:
516 - now uses TestAllEntryVerify.cxx
517 - specific comments on oldACR00001.ima (now renamed in gdcmData
518 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
519 gdcmData/TestAllEntryVerifyReference.txt
522 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
523 * src/*.[h|cxx] : typedef clean up
524 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
525 - TagKey renamed to gdcmTagKey (for external usage)
526 - VRKey renamed to gdcmVRKey (for external usage)
527 - removal of typedef duplication.
528 - Removed all unecessary inline keyword from class inline definitions.
529 - Some method|function(void) declarations replaced with method|function().
530 * src/jpeg/libijg12/jdhuff12.c:
531 - printf polluting ctest removed.
532 - TAB removal for comminting
534 - TestAllReadCompareDicom.cxx: added a test that compares all the
535 images in gdcmDataImages.h with corresponding images in
536 gdcmData/BaselineDicom/. When baseline images are not present
537 this test creates them.
538 Note: we need to validate each reference image, but before that
539 I'd like to rename them with a more explicit name...
540 - CMakeLists.txt: changed accordingly.
541 * Example/*.cxx: examples now only include gdcm.h (as opposed to
542 including each header needed).
544 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
545 * Test/*.cxx and Example/*.cxx: moved some examples away from the
546 test suite to the Example directory. Are concerned:
551 - TestWriteSimple.cxx
552 * Test/CMakeLists.txt: added some comments on reasons for black listing
553 image gdcmData/oldACR00001.ima
555 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
556 * Test/CmakeList.txt: removed the following from black list (to be coherent
557 with removal from gdcmData):
558 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
559 - gdcm-MR-PHILIPS-16.dcm
561 Added the following because after last cvs update, they cause
562 ctest -R TestReadWriteReadCompare
564 - gdcm-MR-SIEMENS-16-1.acr
566 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
567 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
568 new comments in this file) we temporarily (sigh) move to a weaker
570 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
571 we don't need to black list the following images anymore:
572 - 8BitsUncompressedColor.dcm
574 - US-PAL-8-10x-echo.dcm
575 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
576 fixes and the beautified code ;-)
577 This fixes the bug introduced in version 1.42 (when beautifying)
578 that made the parsing of 8BitsRunLengthColor.dcm unproper.
579 Note: ctest was blind to this bug (this means we need to still
580 improve the test suite). The bug could be detected by using
581 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
583 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
584 and by displaying the (garbage) produced file temp.XDCM...
586 2004-06-29 Jean-Pierre Roux
587 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
588 - replace by uggly but working old code :-(
589 A lot of things should be OK again.
590 It's really urgent to have a test suite that *tests*,
591 to prevent Frog's beautifying sessions to break all the stuff
592 (twice, withing a fortnigh ...)
594 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
595 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
596 redundancy) to added Test/TestReadWriteReadCompare.cxx
597 * Test/CmakeList.txt: because the compare test of
598 Test/TestReadWriteReadCompare.cxx fails, the following images are
599 black listed: - 8BitsUncompressedColor.dcm
601 - US-PAL-8-10x-echo.dcm
602 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
603 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
604 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
605 and ad-hoc kludge. This kludge is now removed, and on encountering
606 such an image (OB field brain damaged) we set errno. Then in
607 ::FindDocLength() we "fix" the length as being ALL what remains
608 in the file (until EOF). We then proceed, hoping for the best...
609 This fixes a SegFault in ShowDicom when trying to write such an
611 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
612 (because TestWriteRead breaks on it, after a non conformal commit?).
613 ctest now runs properly, except for MakeDicomDir (which was allways
614 broken) and the Python related stuff (still not fixed).
616 2004-06-24 Jean-Pierre Roux
617 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
618 FIX : Test/TestReadWrite now iterates on all the file names
619 (instead of infinite loop)
620 ENH : Test/TestWriteRead now iterates on all the file names
622 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
623 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
625 2004-06-24 Jean-Pierre Roux
626 FIX : - now Write drops LUT Descriptors and LUTs (if any)
627 when SamplesPerPixel =3
628 - now Write is no longer confused by
629 'BitsAllocated = 12" and 'BitsStored=12"
630 - "UN" value representation Elements are now written correctly
631 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
632 ENH : - now gdcmHeader has its own Write methods
633 (in order to split the job that has not to be done
636 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
637 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
638 loop on the same image until memory went out.
639 Note: this means we still have gobs of memory loss in PrintDocument
640 * src/gdcmDocument.cxx: fixes problem on parsing on file
641 gdcmData/16BitsJpegLosslessGrayScale.dcm.
643 2004-06-24 Jean-Pierre Roux
644 FIX : Write - All the Sequences and Sequence Item are now written
645 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
646 is added a the end, when necessary.
647 - A lot of brain-damaged images, that were read correctly are
648 now written correctly
649 - length compatible BinEntry are now loaded correctly
650 (even for odd groups)
651 Note : only Explicit Value Representation was checked.
652 (question : is implicit VR really necessary for gdcm ?)
654 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
655 * DEVELOPPER: added a proposition of coding style.
656 * src/gdcmDocEntry.h: removed every inline declaration (for test of
659 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
661 Use the gdcmDocEntry::Print() and Write() instead.
662 * src/gdcmDocument.cxx: bug fix.
664 2004-06-22 Jean-Pierre Roux
665 FIX : gdcmDocument.cxx
666 - Now we do recognize the JpegLossLess format (there was a misstyping in
667 code 'beautyfication' :-(
668 - Now we automaticaticaly load the Luts, if any
670 2004-06-22 Jean-Pierre Roux
671 In order : to write Sequences, whatever their imbrication level,
672 : to allow user to create his own Sequences
673 a lot of modif where necessary (adding, moving, or virtualising methods)
675 WARNING : save your own sources *before* cvs up !
678 ADD virtual void Write(FILE *fp, FileType filetype);
681 ADD virtual void Write(FILE *fp, FileType filetype);
682 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
685 ADD virtual void Write (FILE *fp, FileType filetype)=0;
686 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
687 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
688 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
689 ADD std::string GetEntryByName(TagName name);
690 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
692 std::string vr = "unkn",
693 std::string fourth = "unkn",
694 std::string name = "unkn");
695 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
696 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
697 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
698 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
699 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
700 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
701 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
702 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
705 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
706 ADD virtual std::string GetEntryByName (TagName tagName);
707 ADD virtual std::string GetEntryVRByName (TagName tagName);
708 REM virtual bool Write(FILE *, FileType);
709 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
710 FILE *_fp, FileType type);
711 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
712 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
713 REM virtual bool WriteEntries(FILE *_fp,FileType type);
714 REM virtual std::string GetEntryByName (std::string tagName);
715 REM virtual std::string GetEntryVRByName (std::string tagName);
716 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
717 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
718 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
720 std::string vr = "unkn",
721 std::string fourth = "unkn",
722 std::string name = "unkn");
723 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
724 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
725 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
726 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
729 ADD virtual void Write(FILE *fp, FileType filetype);
732 ADD virtual void Write(FILE *fp,FileType filetype);
735 ADD virtual void Write(FILE *fp, FileType filetype);
736 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
737 REM std::string GetEntryByNumber(guint16 group, guint16 element);
738 REM std::string GetEntryByName(TagName name);
741 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
743 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
745 The default constructor invoked by the line
746 gdcmHeader *f1 = new gdcmHeader( header );
747 was gdcmHeader::gdcmHeader(bool) instead of the expected
748 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
749 Hence the parsing wasn't executed... See also below.
750 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
751 as explicit constructor didn't do the trick to fix the above problem.
752 Could anyone explain why ?
753 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
754 properly calls gdcmValEntry::Print() (that was weed out from
755 code related to gdcmBinEntry).
757 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
758 * In order to fix memory leaks:
759 - Test/TestWriteSimple.cxx: added cleaning of free store through
761 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
762 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
763 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
764 (through the call to ::AddDicomDirMeta()) or the destructor
765 would crash when deleting uninitialized ::metaElems].
766 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
767 - src/gdcmDocument.cxx:
768 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
770 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
771 was causing memory leaks.
772 - src/gdcmSQItem.cxx:
773 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
774 cleanly handled with polymophism: sorry but my milage is low).
775 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
776 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
777 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
778 This avoids SegFaulting.
779 - src/gdcmSQItem.h: coding style.
781 - Test/TestWriteSimple still severely sucks. The output image content
782 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
783 damaged when displayed with vtkgdcmViewer.
784 - on memory leaks: TestWriteSimple leaks really less (see entry
785 of 2004-06-18 in Changelog file for the call to valgrind).
786 - on segfaults: ctest now passes all the tests but one (no more
788 * Erroneous leading white fix:
789 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
790 white[s] (as opposed to from >> xxx, that removes it [them].
791 - src/gdcmTS.cxx: ditto.
792 - gdcmPython/testSuite.py: dirty related kludge removed.
793 * src/*: remaining references to gdcmParser removed.
794 * src/*[cxx|h]: added copy[way]left header.
797 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * In order to fix writing of dicom files:
799 - Test/TestWriteSimple.cxx: a simpler example of writing.
800 - Test/CMakeLists.txt changed accordingly.
801 - src/gdcmDocument.cxx:
802 -- The destructor now recursilvely removes potential sequences.
803 -- Bug fix in ::IsJPEG2000()
804 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
805 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
807 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
808 to only declared) and build on top of
809 ::GetDocEntryByNumber(guint16, guint16).
810 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
811 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
812 for usage in destructor and treatement of promotion in
813 ::ReplaceOrCreateByNumber().
814 - src/gdcmSQItem.cxx: destructor should better handle his job.
815 Test/TestWriteSimple now runs (or at least it DOES something).
816 * We can now start hutting memory links. A good starting point is:
817 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
818 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
819 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
821 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
822 * Valgrind note: after Mathieu Malaterre teached me how to read
823 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
825 Using gcc, you can force the STL to use malloc and to free memory as
826 soon as possible by globally disabling memory caching.
827 With 3.2.2 and later, you should export the environment variable
828 GLIBCPP_FORCE_NEW before running your program.
829 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
830 simply vanish (it is still not clear to me, whether this means that
831 STL std::string leaks or if valgrind believes it leaks...).
832 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
833 running bin/gdcmTests makeDicomDir):
834 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
835 - Test/makeDicomDir.cxx now properly traps empty lists and returns
837 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
838 SegFaulting (I drowned in DicomDir related code when trying to
839 understand why the list is empty...).
840 * src/gdcmDocument.h: first BSD license header try.
841 * Doc/License.txt added.
843 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * src/gdcmDocument.[h|cxx]:
845 - Clean up of the Transfer related predicates. They are now all based
846 on new method isGivenTransferSyntax, that (should) handle properly
848 - general clean up, simplification, and coding style.
849 - Specific clean up of Parse7FE0() (umproperly named actually).
850 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
852 2004-06-14 Jean-Pierre Roux
854 - fix the display of Sequence Delimitor (SQDepthLevel pb)
855 - fix the display of SQItem ordinal number
856 - add the GetSQItemByOrdinalNumber method
857 - remove some useless never written private methods
859 2004-06-14 Jean-Pierre Roux
861 - adding a constructor taking a gdcmDocEntry as an input param
862 - ReplaceOrCreateByNumber now returns :
863 a gdcmBinEntry * if a Binary (void *) value is passed as a param
864 a gdcmValEntry * if a string value is passed as a param
866 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
867 according to the param type (no longer sets a gdcmDocEntry)
868 - GetValEntryByNumber, GetBinEntryByNumber added
869 - NewValEntryByNumber and NewBinEntryByNumber added
871 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
873 - GetSQItemNumber and SetSQItemNumber added, to provide
874 a (relative) Item identier inside a given Sequence
875 \warning : some pb remaining around this number
877 - AddEntry now takes the Item Number as a param
879 - adding a constructor taking a gdcmDocEntry as an input param
881 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * Memory leak hunt with the following command:
883 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
884 --show-reachable=yes gdcmTests PrintDocument
885 It looks like many (all?) leaks are due to the STL (or a bad usage
886 of the STL. The lines producing the leaks now have a comment with
887 a "MEMORY LEAK" tag: you can retrieve them with
888 grep "MEMORY LEAK" src/*
889 Here are two typical examples which I can't help fixing:
894 char * test = "babo";
895 name = test; //// <--- valgrind detects 960 bytes lost in
896 //// call to std::string::operator=(char const*)
897 name.clear(); //// Doesn't help !
905 std::cout << "Type a bunch of characters followed by RETURN: ";
906 getline(std::cin, line); //// <--- valgrind dectects a loss
907 //// of 1320 bytes in call to
908 /// std::basic_istream<>& std::getline<>
914 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * src/gdcmHeader.[cxx|h]:
916 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
917 and related, moved away to gdcmDocument.
918 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
919 the corresponding protected accessors of inherited class
920 gdcmDocument, removed ! As a consequence gdcmFile had to be
921 declared friend of class gdcmDocument (see below).
922 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
923 - Clean up of undefined or unused methods.
924 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
925 account the changes to gdcmHeader.h).
926 * src/gdcmDocument.h:
927 - gdcmFile is now a friend class (in order to take into account the
928 changes to gdcmHeader.h).
929 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
930 (see changes to gdcmHeader.h).
931 - Accessors (reading on the form GetEntry*) are now public.
932 - Clean up of undefined or unused methods.
933 * src/gdcmDocument.cxx:
934 - adaptation to changes to gdcmDocument.h
935 - ::OpenFile now writes a verbose message when file cannot be opened.
936 - some std::string properly set to VRKey
937 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
938 references to gdcmDocument.
939 * Test/TestFindTags.cxx: changed accordingly to above changes.
940 * gdcmPython/testSuite.py: adapted to renaming of acr files in
941 cvs repository gdcmData.
943 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
945 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
946 conflicts with gdcmValEntry::voidArea.
947 * src/gdcmValEntry.cxx: unmatching comment wiped out.
948 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
949 Value representation between StringRepresentable and BinaryRepresentable.
950 * src/gdcmDocument.cxx:
951 - method ParseDES: proper indentation restored and usage of
952 gdcmVR::IsVROfGdcmStringRepresentable wired in.
953 - method LoadDocEntry: the fingerprint left in the SetValue() of
954 unloaded entries (length > MaxSizeLoadEntry) had curiously been
955 removed. Reverting to previous code segment with the proper
956 dynamic_cast< gdcmValEntry* >.
957 Note: this was (partially) breaking the python test suite
958 (gdcmPython/testSuite.py) that made usage of the above
959 fingerprint to check presence of "Pixel Data".
960 * src/gdcmDocEntry.h: coding style.
961 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
962 now taken into account.
963 * gdcmPython/gdcm.i: adaptation to the new internal representation
964 of gdcm (exit gdcmParser, hello gdcmDocument).
965 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
967 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
968 anymore, but instead prints the loaded Python dictionary.
969 * .... alas, the python testSuite is still broken.
971 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
972 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
974 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
975 * src/gdcmUtil.h : export methods
977 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
978 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
980 * Initial addition of automatic python testing
981 * Initial addition of automatic image comparison
983 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
984 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
985 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
987 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
988 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
989 * Test/ShowDicom.cxx : bug fix for msvc compilation
990 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
992 2004-05-04 Jean-Pierre Roux
993 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
994 new concepts (and new classes) :
995 a 'gdcmDocument' is composed of a set of Doc Entries, that are
996 - elementary gdcmDocEntries (former gdcmHeaderEntries)
997 - Sequence Doc Entries (gdcmSeqEntries)
998 a Sequence is composed of Items.
999 Each item is a set of Doc Entries (this is recursive)
1000 The non uniqueness of the 'Dicom tag' is due to this recursivity
1001 (never taken into account)
1002 Our unability to add a new 'entry' in the header
1003 at the proper location (neither in the H-Table (map or multimap),
1004 nor in the Chained List is also due to this recursivity.
1005 Don't try, right now, to use/modify/compile these new sources :
1006 nothing is finished.
1007 We just commit all the stuff, 'as is', in order not to loose it.
1009 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1010 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1012 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1013 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1014 file prefix (SetFilePrefix)
1016 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1017 * Add a new test: ShowDicom, for now this is just the c++ version of
1018 checkRead.sh, later it will be able to compare the image read against a
1020 * Replace the DEBUG on the stack with a global entry in cmake interface:
1021 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1023 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1024 * Add an example subdir, with a real example on how to read + write a
1027 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1028 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1029 * Doc/CMakeLists.txt: the main page is now properly differentiated
1030 between the developper and user version.
1031 * Doc/doxygen.config.in: dropped search related obsolete flags
1032 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1034 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1035 * DEVELOPPER: added some helpfull comments for compile/test/install
1038 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1039 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1040 src directory, now generated in the build dir.
1041 2. Tests as mentionned smarter
1043 4. Add a new method in gdcmDict that return the PubDict by name
1044 this is interesting for 3rd party lib like ITK,
1045 where we could set the institution name / patient name...
1047 * ENH: 1. Now the test suite is working for real
1048 2. All binaries are now output in the gdcm-bin directory
1049 (this was not true before)
1051 2004-04-28 Jean-Pierre Roux
1052 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1053 SeQuence indented printing of Dicom Header.
1054 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1055 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1056 Computation of SQDepthLevel is now part of gdcmHeader constructor
1057 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1058 tree-like structure of a Dicom Header.
1059 * FIX Test code cleaning
1061 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1062 * ENH: Adding automatic testing
1063 1. Need a DartConfig.cmake to submit to public
1064 2. Add a test driver gdcmTest.cxx
1065 3. gdcmTestMain, an helper for the main test driver gdcmTest
1066 4. Files in Test don't have a main anymore, this becomes interesting
1067 when we add more and more tests, thus dsw don't have to load
1069 * ENH: Adding a GDCM_DATA_ROOT for testing
1070 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1071 one file instead of seven + some small cleanup
1073 2004-04-22 Jean-Pierre Roux
1074 * ENH Minor changes to the Print() methods.
1075 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1076 Header printing. Example given with :
1077 > PrintHeader fileName 2 new
1078 (SQ based tree-like structure still to be done for the Header ...)
1080 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1081 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1082 1. I have added some unsigned where needed
1083 2. Some function parameter not used -> (void)
1084 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1085 4. g++ don't like character '\' in comment
1086 5. #define jpeg_create_decompress jCreaDecompress
1087 this really need to be fixed
1088 6. virtualize destructor of gdcmObject ... leakage
1089 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1090 this also really need to be fixed
1091 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1092 remove compression file
1093 (as we only do decompression, right ?)
1094 * ENH: Change malloc/calloc/free with c++ equivalent
1096 2004-04-21 Jean-Pierre Roux
1097 * FIX gdcmHeaderHelper::GetXSpacing
1098 when a single value is found (bug ?), xpacing is now
1099 defaulted to yspacing
1101 2004-04-19 Jean-Pierre Roux
1102 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1103 * ENH add parameters :
1104 bool exception_on_error = false,
1105 bool enable_sequences = false,
1106 bool ignore_shadow = false
1107 to the gdcmFile constructors to be full gdcmParser compliant
1108 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1109 to allow reading of PAPYRUS 3.0 files
1111 2004-04-06 Jean-Pierre Roux
1112 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1114 2004-04-02 Jean-Pierre Roux
1115 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1116 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1117 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1119 2004-03-30 Jean-Pierre Roux
1120 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1121 for ACR file, written out as DICOM files (hope so...)
1123 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1125 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1126 moved to base class gdcmParser and only the specialisation is kept
1128 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1129 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1130 already does the job.
1131 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1132 (to be consistent with gdcmParser::WriteEntries).
1134 2004-03-30 Benoit Regrain
1135 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1136 upate of the object's instance. It's passed to 2 in the unfavorable
1137 case : one in the ExecuteInformation, one in the ExecuteData
1139 2004-03-29 Jean-Pierre Roux
1140 * ENH : Check on file type to be written moved
1141 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1142 * FIX : gdcmObject::ResetBoundaries now stops properly
1143 when end-of-list is reached
1144 : gdcmVersion modified (as Benoit Regrain asked)
1146 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1148 * src/gdcmUtil.cxx: added forgotten iostream include.
1149 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1150 equivalent to ExplicitVR in existing code).
1152 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1153 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1154 now contains all the gdcmGlobal related code.
1155 * minor coding style and doxygenation changes.
1157 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1159 now contains all the Debug related code.
1160 * minor clean-up of includes in src/*.cxx
1161 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1162 CreateCleanString) removed.
1163 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1164 * Doc/DoxyMainPageUser.txt added.
1165 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1166 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1167 src/gdcmDirList.cxx)
1169 2004-03-24 Jean-Pierre Roux
1170 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1172 2004-03-23 Jean-Pierre Roux
1173 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1174 big endian made volumes
1175 * ENH Now gdcmParser constructor and destructor are protected to forbid
1176 end user to instanciate class gdcmParser
1177 (only gdcmHeader and gdcmDicomDir are meaningfull)
1179 2004-03-22 Benoit Regrain
1180 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1181 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1182 gdcmSerie to gdcmDicomDirSerie
1184 2004-03-19 Jean-Pierre Roux
1185 * ENH Now the tree-like structure describing a DICOMDIR comming from
1186 an already existing DICOMDIR file is consistent with
1187 the home-made tree-like structure build ex-nihilo
1188 or build from the files held (recursively) in a Directory
1189 functions gdcmDicomDir::CheckBoundaries()
1190 gdcmObject::SetBoundaries() added
1192 2004-03-17 Jean-Pierre Roux
1193 * REM (Eric Boix bug) : removal of meaningless
1194 gdcmDicomDirImage::NewImage function.
1195 * FIX now file names and directory name are written properly in the
1197 * FIX now gdcmDicomDir constructor may be call without any trick
1200 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1201 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1202 of gdcmDicomDirImage::NewImage as empty function.
1204 2004-02-28 Jean-Pierre Roux
1205 * ENH add gdcmDicomDir:NewPatient
1206 add gdcmDicomDirPatient:NewStudy
1207 add gdcmDicomDirStudy:NewSerie
1208 add gdcmDicomDirSerie:NewImage
1209 to allow making gdcDicomDir object.
1210 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1211 (as opposite to the gdcmHeader chained list)
1213 2004-02-11 Benoit Regrain
1214 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1215 when using from python
1217 2004-02-10 Benoit Regrain
1218 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1219 * FIX : in gdcmDicomDir when the directory is empty
1220 * ENH : add callback and methods to get the progression of dicomDir
1223 2004-02-06 Jean-Pierre Roux
1224 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1225 - GDCM_META added to gdcmDicomDirType
1226 - class gdcmMeta created
1227 * ENH : - A brief summary is now displayed at the beginning of
1228 'testDicomDir' to help disaster magnitude estimation
1229 * REM : Now useless Test/explDICOMDIR.cxx
1231 2004-02-05 Benoit Regrain
1232 * ENH : add methods in gdcmObject to get the hash table or the list of
1234 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1235 * FIX : wrapping python for TagHeaderEntryHT
1237 2004-02-04 Benoit Regrain
1238 * FIX : even length for some strings when writting the dicom dir
1239 * FIX : sort the images in the dicom dir
1240 * FIX : Bug fix for python use of dicom dir
1241 * ADD : a python demo
1243 2004-02-04 Jean-Pierre Roux
1244 * FIX : Final solution (?) for icone embedded images
1245 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1246 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1247 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1248 gdcmData/gdcm-MR-SIEMENS-16.acr1
1249 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1250 to make full checking easier
1252 2004-02-04 Benoit Regrain
1253 * FIX : WriteEntries : coding style & logic in parameters
1254 * FIX : Set the elements to create the DicomDir in a dictionary file
1256 2004-02-03 Benoit Regrain
1257 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1258 * gdcmDicomDir : add the load of directory
1259 * Bug fix and print add-on
1261 2004-02-03 Jean-Pierre Roux
1262 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1263 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1264 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1265 * FIX gdcmParser.cxx : 'group length' elements are now considered
1266 as integers, even for shadow groups, when file is Implicit VR
1268 2004-02-02 Jean-Pierre Roux
1269 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1271 of the last synonym :-(
1272 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1274 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1275 * FIX taking into account the possible 7fe0,0010 multiplicity
1276 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1277 to allow removal of references to 7fe0,0010, to deal with
1278 ACR-NEMA images, when 0028,0200 is meaningfull
1280 2004-01-31 Jean-Pierre Roux
1281 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1282 no longer writes 'Un' on disk
1283 * FIX SQ elements with actual length are now dealt with corectly
1284 * FIX gdcmFile::WriteBase make the difference, for color images, between
1285 the length (for Palette expanded images)
1286 and Raw Length (non expanded image + Palette)
1287 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1288 (that broke Write). Replaced by UL.
1289 Aware user will reload the field if he
1290 thinks it's necesssary
1292 2004-01-30 Jean-Pierre Roux
1293 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1294 when 'dirty Acr' is found, to be compliant with the new
1295 IsReadable() methods.
1297 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1298 (no DOUBLE images in kosher DICOM,
1299 but so usefull for people that miss them ;-)
1301 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1302 DICOMDIR related utilities (not checked as Windoze compliant)
1304 2004-01-28 Jean-Pierre Roux
1305 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1307 2004-01-27 Jean-Pierre Roux
1308 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1309 to allow skipping the shadow elements, to save memory space.
1310 The TRUE value for this param has to be used
1311 with a FALSE value for the 'enable_sequence' param.
1312 ('public elements' may be embedded in 'shadow Sequences')
1313 * gdcmHeader methods now deal with 'embedded icones images' in the header
1314 (even when an 'icone image sequence' is announced by the
1315 element (0x0088,0x0200), but there is NO icone at all ...
1317 * gdcmHeader sometimes Image Location value doesn't follow
1318 the supposed processor endianity (see gdcmData/cr172241.dcm).
1321 * gdcmHeader add the method
1322 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1323 to get *all* the Header Entries with the same tag.
1324 GetHeaderEntrySameName is probabely *useless*
1325 (no meaning : Name is *not* an identifier within the Dictionnary)
1327 2004-01-26 Benoit Regrain
1328 * Bug fix in the print of hexadecimal representations. Remove long fields
1329 in the print and add a third level of print to print them
1331 2004-01-23 Benoit Regrain
1332 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1333 * Bug fix on test suite after remove the strip made on not string fields
1334 * Split the IsReadable method between gdcmParser which test that the file
1335 is dicom and gdcmHeader which test that it's an image file
1337 2004-01-22 Benoit Regrain
1338 * DicomDir : clean code, add methods, set variables in protected or private
1339 * gdcmUtil : bug fix for the clean string method
1341 2004-01-19 Benoit Regrain
1342 * Add the use of shadow dictionaries
1343 * bug fix and coding style
1345 2004-01-19 Benoit Regrain
1346 * src/gdcmFile.cxx : bug fix concerning the close of file
1347 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1348 * Add the update of header entries using the shadow library
1350 2004-01-19 Benoit Regrain
1351 * removal of file gdcmHeader2.cxx
1352 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1353 inheriting from gdcmParser. This split is to prepare the integration
1354 of dicom dir parsing
1355 * bug fix under python
1357 2004-01-16 Jean-Pierre Roux
1358 * REM removal of class gdcmHeaderEntrySet
1359 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1360 * ADD add file gdcmHeader2.cxx
1361 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1363 2004-01-15 Benoit Regrain
1364 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1365 entries created while parsing the header. Thus, they will be destroyed
1366 when the gdcmDictSet will be destroyed
1367 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1370 2004-01-15 Benoit Regrain
1371 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1372 made a fatal error because of the memory release at the end of program.
1373 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1374 some memory and vtk seems to have some problems with that.
1375 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1377 2004-01-14 Benoit Regrain
1378 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1379 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1380 * src/*.[h|cxx] : make changes due to class name changes
1381 * gdcmPython/demo/*.py : bug fix due to method names
1383 2004-01-13 Benoit Regrain
1384 * src/*.[h|cxx] : coding style
1385 * vtk/*.[h|cxx] : coding style
1387 2004-01-13 Benoit Regrain
1388 * gdcmPython/testSuite.py : test the readable flag of file for tests
1389 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1390 It's lied to the stl compilation by MSVC (windows, always windows...)
1391 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1393 2004-01-12 Benoit Regrain
1394 * src/*.h : add comments
1395 * src/gdcmDictSet.h : set the method BuildDictPath in public
1396 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1397 directly setted in the source code
1398 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1401 2004-01-09 Benoit Regrain
1402 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1403 * setup.py : use a reference to gdcmVERSION
1405 2004-01-07 Benoit Regrain
1406 * Modification to compile with the distutils.
1409 2003-12-10 Benoit Regrain
1410 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1411 can use a gdcmHeaderHelper to load datas
1412 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1413 made in the source code
1415 2003-12-10 Benoit Regrain
1416 * Update Windows projects and .cvsignore files
1418 2003-11-12 Jean-Pierre Roux
1419 * ENH gdcmHeader constructor has one more parameter (default value : false)
1420 that allows the user to 'go inside' the SeQuences only
1422 gdcmElValSet:Print takes it into account
1424 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1425 * ENH: Update gdcmPython/CMakeLists
1426 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1427 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1429 2003-11-10 Jean-Pierre Roux
1430 * FIX : gdcmHeader::LoadElements is now based
1431 on the ListTag listElem member,
1432 not longer on the TagElValueHT tagHt member
1433 * ENH : PrintPubElVal shows (temporarily) both results,
1434 with the tagHt member and the listElem member.
1435 (it's easier to 'see' the problems when using Printheader)
1437 * FIX : old private member LgrElem is now splitted into
1438 ReadLength : Length actually found on disk (updated only
1439 if bug fixing is necessary), for internal
1441 UsableLength : Updated by FixFoundLength, to fix a bug
1442 or to allow Parser going on.
1443 Will allow to re-write a kosher header when a SeQuence
1444 with a length (not 0000) is found
1445 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1446 because gdcmElValSet::Add does not update ListElem
1449 2003-11-07 Jean-Pierre Roux
1450 * FIX misstyping in Transfert Syntax name table
1451 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1452 when they have an actual length (not 0000 nor FFFFF)
1453 (Nobody should care of it, but DICOMDIR explorers)
1455 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1456 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1458 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1459 * ENH: vtkGdcmReader now supports LUT !
1460 (vtkgdcmViewer for now is not able to use them though)
1462 2003-11-05 Jean-Pierre Roux
1463 * in testSuite.py : new files names for checking the package
1464 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1465 that returns the pixel area size to the *aware* (vtk) user
1466 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1468 2003-11-05 Benoit Regrain
1469 * in testSuite.py : Modify the rules for checking the paths
1470 : Explicit error messages
1471 * in __init__.py : Related modif
1473 2003-11-03 Jean-Pierre Roux
1474 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1475 to be used by aware (vtk) users that want to manage
1476 LUT (and no to turn the PALETTE image into an RGB pixels one)
1477 * GetPixelType now returns 8U for 24 Bits images
1478 (vtkGdcmReader compliant)
1480 2003-10-31 Jean-Pierre Roux
1481 * Removal of *all* gdcmData images and add them again
1482 in order to loose the 'history' of un-anonymised images
1484 2003-10-31 Jean-Pierre Roux
1485 * RMV : removal of useless jBitsInJsample.h
1486 for both 8 and 12 Bits JPEG Lossy Libraries
1488 2003-10-31 Jean-Pierre Roux
1489 * ENH : Add the functions gdcmFile::GetImageDataRaw
1490 gdcmFile::GetImageDataIntoVectorRaw
1491 that act as GetImageData and GetImageDataIntoVector
1492 except the making of an RGB Plane from Gray Plane + LUT
1493 Intended to aware (vtk) users who know how to manage
1496 GetLUTRGBA return a R,G,B,A LUT if any
1497 lgrTotaleRaw gives the 'Raw' length
1498 GetImageDataRaw returns the gray Plane
1499 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1500 (They stay Grey, just like with other Dicom viewers :-(
1502 2003-10-30 Jean-Pierre Roux
1503 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1505 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1506 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1507 being coherents dicom files.
1509 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1510 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1512 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1513 * ENH: Two steps is necessary to please VC++ compiler...
1514 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1515 * ENH: Add include dir to medcon lib
1516 * FIX: only one function is being exported for now !
1517 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1519 2003-10-29 Jean-Pierre Roux
1520 * adding gdcmHeader::GetLUTRGBA
1521 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1522 --> Mathieu, the modif u're waiting for is not yet committed
1523 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1525 2003-10-27 Jean-Pierre Roux
1526 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1527 00191113.dcm DermaColorLossLess.dcm
1528 MxTwinLossLess.dcm RadBWLossLess.dcm
1529 * ENH: For version prior to vtkImageViewer2 -r 1.19
1530 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1532 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1533 * Removal of ido stuff in CMakeLists.txt
1535 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1536 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1537 * FIX: remove a call to ->Modified ... see comments
1538 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1540 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1541 * FIX: Problem with path for libvtkgdcmPython
1542 * ENH: Try adding a search script for python site-package
1543 * RMV: Remove some file from medcon lib that are not necessary
1544 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1545 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1546 * FIX: More pragma disable fro VC++,
1547 I don't think I break something as it is also disable in VTK/ITK.
1548 But it fasten debug compilation time.
1550 2003-10-23 Jean-Pierre Roux
1551 * gdcm now deals with 16 Bits Run Length Encoded images
1552 (they are compressed as 2 planes images,
1553 one for the high Bytes, the other for low Bytes)
1555 2003-10-22 Jean-Pierre Roux
1556 * Now CheckRead takes into account :
1557 - the bugged 'Leonardo' Siemens images
1558 - the XA images, sent thru the burning VPRO station
1559 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1562 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1563 * FIX: When copying a Makefile.am to CMakeLists.txt
1564 one should remove the '\'
1566 2003-10-22 Jean-Pierre Roux
1567 * in gdcmData adding a bugged 'Leonardo' Siemens image
1568 (wrong lengths in header)
1569 OK with gdcm, KO with the other viewers :-)
1570 * add a GE dlx XA image, thru the VEPRO burning station
1573 2003-10-21 Jean-Pierre Roux
1574 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1575 for a brutal checking of vtkgdcmViewer compliance
1577 2003-10-21 Jean-Pierre Roux
1578 * add the files for 'xmedcon' Jpeg Lossless library
1579 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1581 2003-10-21 Jean-Pierre Roux
1582 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1584 2003-10-21 Jean-Pierre Roux
1585 * garbage Siemens 'Leonardo' images dealt with
1586 (the patch is easy to remove)
1587 * cosmetic changes to avoid warnings
1589 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1590 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1591 no need to press 'r' now.
1593 2003-10-20 Jean-Pierre Roux
1594 * upgrade of checkRead.sh checkWrite.sh according
1595 to new Jpeg Lossless decompressor
1596 * add US.3405.1.dcm, a genuine RGB medical file ...
1597 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1598 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1600 2003-10-15 Jean-Pierre Roux
1601 * general anonymisation in gdcmData
1602 * adding the 'color files' from
1603 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1604 * adding some well knowed bugged-header images
1605 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1606 waiting for their inclusion in Python testsuite
1608 2003-10-15 Jean-Pierre Roux
1609 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1610 no longer seg faults when file is not found
1612 2003-10-14 Jean-Pierre Roux
1613 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1616 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1617 * TODO: *.in file to genereate a UseGDCM later
1619 2003-10-14 Jean-Pierre Roux
1620 * Some supposed-to-be Dicom Images have no preamble.
1621 OpenFile takes it into account
1622 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1623 * Missing elements added in dicomV3.dic
1624 (just to be affraid : have a look at
1625 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1626 and do it again next year ;->
1628 2003-10-13 Jean-Pierre Roux
1629 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1630 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1631 But there are NOT. It's fixed !
1633 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1634 * FIX: "jpeglib.h" was not found on VC++
1635 * FIX: vtkgdcm was not being installed
1637 2003-10-10 Jean-Pierre Roux
1638 * ENH : OpenFile closes the file if it *really* doesn't look like
1639 an ACR-NEMA / DICOM one.
1640 * FIX : testWrite no longer writes an empty file if the source file
1641 is not gdcm Readable
1642 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1645 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1646 * FIX: CMake generate now documentation
1647 * ENH: out of source doc build !
1648 * ENH: Generate both user and dev documentation
1649 * ENH: Should work on windows too
1650 * ENH: Only one doxygen config.in file is needed
1651 * FIX: make install should be ok now on ùnix plateform
1652 * FIX: PATH to dictionary was wrong (missing /)
1653 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1655 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1656 * vtkGdcmReader is now able to read rgb dicom file.
1657 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1658 * added a gdcmViewer to vtk test, use mouse to control
1659 window level & window width
1661 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1662 * CMake-ification of gdcm, we have now two build system
1663 * FIX: on cygwin Wsock32 doesn't exist
1664 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1666 2003-10-06 Emanuel Ollart
1667 * FIX : compilation process wad broken.
1668 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1670 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1671 * change gdcmViewer -> vtkgdcmViewer
1672 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1674 2003-10-06 Jean-Pierre Roux
1675 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1676 ( e.g : well known GE images with a wrong elem length,
1677 : Philips MRI Images with a wrong Huffman table)
1678 * still to be done : allow the reading of bugged LEONARDO Siemens images
1680 2003-10-03 Jean-Pierre Roux
1681 * Odd length strings are padded with '\0' (not with spaces,
1682 to remain compliant with already defined strings,
1683 like Transfert Syntax UID and others)
1685 2003-10-03 Jean-Pierre Roux
1686 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1687 to allow displaying RGB images (not only by affim ;-)
1689 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1690 * vtkGdcmReader is now able to read rgb dicom file.
1691 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1693 2003-10-03 Jean-Pierre Roux
1694 * A few nasty patches to allow the reading of a lot of nasty images
1695 ( e.g : well known GE images with a wrong elem length,
1696 : Philips MRI Images with a wrong Huffman table)
1697 * still to be done : allow the reading of bugged LEONARDO Siemens images
1699 2003-10-03 Jean-Pierre Roux
1700 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1702 2003-10-03 Jean-Pierre Roux
1703 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1704 to allow displaying RGB images (not only by affim ;-)
1706 2003-10-03 Jean-Pierre Roux
1707 * gdcmFile::GetImageDataIntoVector now
1708 - deals with MultiFrames MultiFragments Run Length Encoded files
1709 - deals with YcBcR (YBR_FULL) files
1710 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1711 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1713 (no sample found :-(
1715 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1716 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1717 Two reasons: - clear things
1718 - third parties acces gdcm through header files, so won't
1719 suffer anymore VC++ complains
1721 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1722 * add argv[1] in testvtkGdcmReader.cxx
1725 2003-09-24 Jean-Pierre Roux
1726 * The lines are now eigthy characters long.for
1727 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1729 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1730 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1731 char* to std::string. Thus, the use of strdup becomes useless. (see
1732 previous commis of Malaterre)
1733 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1734 before the last Malaterre's commit.
1736 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1737 * This commit should fix the Debug building under VC++, the problem
1738 was mainly a mixture of debug and release lib being loaded at startup.
1739 * I also remove a depency to a specific C function: strdup. Because I had
1740 to force the link to msvcrtd (whereas strdup is in libc).
1742 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1743 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1744 located in the gdcmCommon.h file. All use of reference of tha has been
1745 changed to now use the variable GDCM_UNFOUND.
1747 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1749 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1750 Dicom dictionary. The test suite can now be run again. Note:
1751 I'm note very happy with the " (RET)" changes. I believe this
1752 RETAINED comment should be dropped when parsing the dictionary.
1753 - PACKAGER corrected
1755 - AUTHORS updated and now in alphabetical order
1756 * Makefile.am now exports gdcm.dsw for Windoze users.
1758 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1759 * cygwin complains about missing std:: in subdir Test/
1761 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1762 * remove some methods that are now in gdcmHeaderHelper
1764 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1765 * vtkGdcmReader set spacing and origin correctly
1767 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1768 * Fix a few delete/delete[] mismatch
1770 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1771 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1772 interpretation to data given by gdcmHeader. For instance there are
1773 heuristics to get informations (look at different places).
1774 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1775 sorting DICOM images based on different strategies.
1776 * modified Makefiles accordingly.
1778 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1779 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1780 when building in debug mode
1781 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1782 src/win32/gdcmdll.dsp
1783 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1785 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1786 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1789 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1790 * src/win32/libgdcmjpeg12.dsp was not dos format
1791 * src/win32/libgdcmjpeg12.dsp :
1792 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1793 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1795 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1796 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1798 * src/gdcmFile.cxx : bug fix in affectation type
1799 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1800 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1801 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1802 symbols... future problem ?
1804 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1805 * src/win32/libgdcmijpeg12.dsp was missing
1806 * modified gdcm.dsw accordingly
1808 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1809 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1811 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1812 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1813 commit of JPR (before his hollidays to facilitate our work).
1814 * setup.py : bug fix in code. Modifications made while the last commit
1815 of JPR. The code hasn't been tested before the commit... it's so
1816 useless to make that (for best programmer that is JPR) !!!
1818 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1819 * tagged the current version as Version0_3 (i.e. version 0.3)
1821 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1822 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1823 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1824 * *.dsp : modifications to use new libgdcmijpeg8 library
1825 * setup.py : bug fix on VTKPATH variable
1826 * PACKAGER : adding all concerning windows
1828 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1829 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1831 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1832 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1833 test suite reported error.
1834 * PACKAGER file added (describes what a packager must do when
1835 packaging a new release).
1836 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1837 * configure.in: upgraded version number to 0.3.0
1838 * fixing build of rpm (through rpm -ta):
1839 - Doc/Makefile.am exports proper doxygen files
1840 - src/jpeg/libijg8/Makefile.am exports the include files.
1842 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1843 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1844 * src/gdcmHeader.h : formatting code
1846 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1847 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1848 We were obtaining error message from vtk. Now, creation of file list
1849 is made in an internal list to prevent this problem.
1850 Bug fix when output is empty.
1851 Bug fix in update of progress value. Previous commit for this was a bad
1853 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1855 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1856 * src/gdcmHeader.h : added method to get the file name
1857 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1858 files. Added method to remove all files on the input
1859 Added FIXME comment concerning the bad parsing of header made by
1860 ExecuteInformation method (in ExecuteData method)
1862 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1863 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1864 when using make instal.
1865 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1866 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1868 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1869 * setup.py : adding include dir of jpeg lib to compile all sources
1870 * */Win32/*.dsp : JPR fix for windows compilation
1872 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1873 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1875 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1876 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1878 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1879 * setup.py is again effective on un*x (takes into account the
1880 addon of the jpeg library)
1881 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1882 * Doc/Doxy* updated (includes above enhancements)
1883 * INSTALL now points to web documentation
1885 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1886 * src/gdcmHeader.h doesn't make unnecessary reference to
1888 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1890 * src/gdcm*.[cxx|h] :
1891 - to allow compilation with gcc 3.x
1892 -- clean up of STL usage (added explicit usage of std::)
1893 -- small fixes on exceptions.
1894 Note: linking not tested !
1895 - clean of doxygen comments to avoid warnings at documentation
1897 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1898 dependent convertion).
1900 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1901 * Clean up of previous JPR garbage commit (not even commented in the
1903 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1904 - moved all jpeg related files from src to src/jpeg/libijg8, with
1905 addition/modification of Makefile.am and configure.in.
1906 - the testSuite is still brain damage (not guilty).
1908 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1909 * WrapVTK.py : modifications to get correctly vtk source files to
1911 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1912 (FileName -> Filename)
1914 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1915 * vtk/vtkGdcmReader.[cxx/h]:
1916 - UpdateProgress method should now be effective
1917 - removed the limitation on having only images loaded (as opposed
1919 - when building a stack of images/volume, a lesser number of
1920 gdcmHeader and gdcmFile instances should be used (hopefully
1921 accelerating things).
1922 - when building a stack of images/volumes, files which are not
1923 loadable (wrong path-filename, wrong permissions on existing file,
1924 or file not parsable by gdcm) are replaced with a black image
1925 in the stack (for the caller to notice the problem).
1927 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1928 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1930 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1931 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1932 between standard library (std) and vtk library (problems are found
1933 under Windows... thanks Windows !)
1935 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1938 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1940 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1941 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1943 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1944 * When compiling with distutils (see setup.py) the C++ compiler is
1945 called with different flags than the default ones (with automake).
1946 In order to fix all those warning, I compiled gdcm with the command
1947 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1948 and went for warning fixes:
1949 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1950 up from unused variables.
1951 - vtk/vtkGdcmReader.cxx: potential bug fix.
1952 * src/gdcmHeader.h: Doxygen warning cleanup
1954 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * gdcmPython/gdcm.i:
1956 - typemaps correction to take into account the systematic replacement
1957 of "using namespace std" with std:: prefix e.g. std::list,
1958 std::string... (cf changes of 2003-05-21).
1959 - gdcmGlob global variable of type gdcmGlobal (defined in
1960 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1961 exported to Python a as cvar.
1962 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1963 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1964 gdcmDictSet.GetPubDictTagNames() and
1965 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1966 C++ static methods).
1967 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1968 with the above changes.
1970 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1971 * setup.py, manifest.in : bug fix under linux
1973 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1974 * Modification of setup.py to compile vtk part too. Then, we have 2
1975 wrappers which must work with same distutils. For that, we have a
1976 generic distutils in distusiltsWrapping.py ; with :
1977 - build_extWrap class to wrap generically all extensions,
1978 - ExtensionWrap base class for all wrapping extension that contains
1980 - Wrapper interface which wrap sources
1981 + In WrapSwig.py we have extension and wrapper for Swig
1982 + In WrapVTK.py we have extension and wrapper for VTK
1983 * MANIFEST.in : modifications to consider vtk directory and new python
1984 files for compilation
1986 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1987 * Added python wrappers of vtkGdcmReader vtk class (see the
1988 source in vtk/vtkGdcmReader.cxx) :
1989 - vtk/Makefile.am now builds a library
1990 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1991 python library (as opposed to _gdcm.so wich are the python
1992 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1993 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1995 - configure.in has an additional flag --enable-vtk that needs
1996 to be set to enable compilation of vtk related code, that is:
1997 + vtk/vtkGdcmReader.so and
1998 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1999 + gdcmPython/vtkgdcmPython.so (see above)
2000 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2001 be read when compressed or when HighBit + 1 != BitsStored),
2002 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2003 the usage of the python wrapper of vtkGdcmReader vtk class.
2004 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2005 * src/*.[h] all occurences of stl classes are now prefixed with
2006 std::, and all occurences of "using namespace std;" where removed.
2007 This is to avoid pollution of global namespace in included files.
2008 Apparently vtk does not avoid this pitfall: when using both
2009 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2010 collision of various stl members (principally cout...).
2011 * gdcmPython/testSuite.py now cleanly removes temprory generated
2013 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2014 comply with above changes)
2016 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2017 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2018 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2019 vtk data structure (an image Flip was required).
2020 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2021 * cosmetic changes in documentation.
2023 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2024 * src/gdcmHeader.cxx: the constructor no longer exits when an
2025 unexisting file is given as argument.
2026 * The subdirectory Data (containing all the images used for the
2027 test suite) is not part of this repository anymore. A new module
2028 containing those images is now available at
2029 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2030 with the name gdcmData.
2031 All the python scripts (including the package initialisation file
2032 gdcmPython/__init__.py) were adapated to take this change into
2033 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2035 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2036 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2037 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2038 demo of the usage of this class.
2039 Compilation of this vtk part is only done when using the --enable-vtk
2040 at configure (or autogen.sh) stage.
2042 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2043 * More memory link related corrections and documentation fixes.
2045 - maximum info is obtained with a command of the form:
2046 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2047 --show-reachable=yes PrintHeader
2048 - the remaining reachable blocks seem to come from the STL
2049 allocation scheme through the usage of map and list. It looks
2050 like this memory cannot be freed but it is not a memory leak
2051 (in fact further invocation to the STL would recollect the
2052 unused memory allthough it cannot explicitely be freed).
2053 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2054 of displaying an image parsed with gdcm and displayed with VTK.
2055 Note: some images don't seem to work e.g.
2056 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2057 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2058 Allthough this weakens the semantics, it is a ditch attempt to
2059 make gdcm more thread friendly.
2061 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2062 * Memory link hunt (by using valgrind through the command
2063 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2064 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2065 gdcmHeader::_dicom_vr.
2066 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2067 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2069 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2071 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2072 * src/Makefile.am now exports all the necessary include files at
2076 * UpdateGroupLength replaced by new one
2079 * UpdateGroupLength re-written using H-Table
2080 (named UpdateGroupLengthNew untill checks are over)
2082 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2083 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2084 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2086 - gdcmHeader::GetPubElValSet removed.
2087 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2088 UpdateGroupLength, WriteElements, Write.
2089 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2090 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2091 carried the same semantics.
2092 - src/gdcmHeaderIdo.cxx changed accordingly.
2093 - gdcmFile::WriteBase now regroups all the codes from previous
2094 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2095 - enum FileType moved to gdcmCommon.h
2096 * src/gdcmHeader.cxx AddDefault trashed
2097 * gdcmGetXSize added
2098 * getimageDataSize now calls gdcmGetXSize
2099 * Test/*.cxx changed to agree with above changes
2101 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2103 (to avoid double call by end user).
2104 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2105 by end user, since gdcmHeader::gdcmHeader now handles it.
2107 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2108 * gdcm/Doc many doxygen changes:
2109 - Doxyfile now has two different versions, DoxyfileUsers that generates
2110 the html.users end users oriented documentation and
2111 DoxyfileDeveloppers that generates the html.developper developper
2112 oriented documentation.
2113 - README changed accordingly
2114 - requirement.txt removed (old design info moved to TODO).
2115 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2116 DoxyMainPage.txt, DoxyPython.txt provide more information.
2117 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2118 be updated by simply regenerating the docs with doxygen and copying
2119 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2120 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2121 all the tests in the form "if (<map>.count() >1)" were removed.
2122 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2123 ill-formed documentation sections.
2124 * src/gdcmHeader.cxx: ditto
2126 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2127 * setup.py fixed for un*x (needed macro for stdint.h)
2128 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2129 un*ces with sh-utils test utility.
2130 * gdcmPython/demo/test.py renamed to PrintHeader.py
2131 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2132 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2133 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2134 * src/gdcm*.cxx JPR's bad inclusion fixed.
2136 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2137 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2138 * gdcmPython/demo/test.py changed accordingly.
2140 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * gdcmPython/Makefile.am fixed linking against libstdc++
2142 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2143 * Swig subdir (historical tests of swig version 1.3.17++) removed
2144 * Test/testChangeEntete.cxx some lines commented out in order to make
2146 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2147 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2149 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2150 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2151 hence the user doesn't need this explicit call.
2152 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2153 i.e. LoadElements() call removed.
2154 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2155 - src/Makefile.am declares the proper flag for g++.
2156 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2157 for adding user defined new tags.
2158 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2159 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2160 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2162 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2163 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2164 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2165 src/Makefile.am : the project should properly compile and install
2166 with the autotools, included the python wrappers part.
2167 * gdcm.spec.in : added a spec file for RPM packaging.
2169 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2170 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2172 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2173 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2174 to exported to the environement (see gdcmPython/testSuite.py
2176 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2177 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2178 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2179 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2180 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2182 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * gdcmPython/__init__.py doesn't crash anymore when running in
2184 in InstallMode or PreInstallMode but with an environement given
2185 value of GDCM_DICT_PATH.
2186 * src/gdcmDictSet.[cxx/h] coding style.
2188 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2189 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2190 * src/gdcm.h general comments moved to TODO, and README
2191 * src/gdcm.h should now be seen as a user commodity (including it
2192 should suffice to fully use gdcm). It is nowhere including within
2193 any of the kernel files src/*.cxx and src/*.h.
2195 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2196 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2197 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2199 * src/gdcm*.cxx only include their corresponding include file
2200 (as opposed to gdcm.h)
2201 * gdcmPython/gdcm.i changed accordingly
2202 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2203 the autogen.sh generated "make snapshot" command to work.
2204 * autogen.sh removed history related references to crea package.
2206 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2207 * distutilsSwigCPlusPlus.py work around some swig portability
2210 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2211 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2212 was done in a last ditch attempt to get setup.py _really_
2213 operationnal. The python/gdcmPython layaout add the advantage
2214 of hidding away the python related distutils specific files
2215 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2216 Alas, the src directory was out of scope (i.e. it's relative
2217 position to setup.py was ../src) which made things impossible to
2218 handle (see previous version of python/setup.py). Crossing fingers...
2220 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * python/setup.py now works on Un*x. (harder than I thougth)
2222 * python/distutilsSwigCPlusPlus.py can now have include files
2223 among the list of sources.
2225 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2226 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2227 * modifications in MSVC projects
2229 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2230 * As stated by the first lines of Test/ExceptionAndPython/README, it
2231 looks like we can move back to original usage of exception within
2232 src/gdcm* and hence remove the errno stuff that was introduced
2233 as a quick and dirty fixture of this problem (added to the TODO).
2234 * Doc/Doxyfile configuration file for Doxygen and corresponding
2235 README file for usage added.
2236 * Test/testWrite.cxx added. This new test comes from a split of
2237 test.cxx that is now reverted to its original purpous i.e.
2238 testing the proper parsing of a Dicom related file.
2239 testWrite.cxx concentrates on testing the IO part of gdcm.
2240 * Test/bug1.cxx (containing a bug on WIn32) added.
2241 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2242 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2243 whose purpose is to publish the content of the TagNames of the
2244 Dicom public dictionnary were not accessible without an
2245 instance of class gdcmHeader.
2246 - those methods are now static methods of gdcmDictSet and hence
2247 require no instances at all to be invocated.
2248 - within gdcmDictSet this change required to change some method
2249 to class methods (i.e. are now static) among which SetDictPath
2250 (renamed to BuildDictPath) and LoadDefaultPubDict.
2251 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2252 the above changes by calling the new method classes of gdcmDictSet.
2253 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2254 the above to be effective.
2255 * python/gdcmPython: in order to wrap properly the above changes
2256 for Python, swig version now needs to be > 1.3.17.
2257 * python/gdcmPython/Makefile fixed to adapt itself to new
2258 configure/make shema introduced by Johan Montagnat (thanks for the
2259 contribution). Alas this Makefile cannot be turned into a proper
2260 Makefile.am without some heavy changes in the configure.in
2261 (for python dectection).
2262 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2263 now avoids publishing the empty entries.
2265 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2266 * python/setup.py : bug fix concerning install under windows
2267 ExtraPath reused :-P
2268 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2270 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2271 * Dicts/dicomV3.dic : remove double spaces !!!
2272 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2273 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2276 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2278 method. Doxygenation.
2279 * src/gdcm.h clean up of JPR spurious comments.
2281 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2282 * python/distutilsSwigCPlusPlus.py now properly collects the
2283 shadow classes generated by "swig -c++" (gdcm.py in our case)
2284 when using "python setup.py install".
2285 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2286 reexports the working classes.
2287 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2288 by the classical C errno scheme. This is to prevent an obscure
2289 behavior of the python wrappers when importing wxPython.wx prior
2290 to gdcmPython (which ended up in an abort call). An illustration
2291 of this oddity can be found in the Test/ExceptionAndPython
2292 subdir (see the README file). This problem probably due to
2293 an combination of g++ and dynamic loading.
2294 * added Test/ExceptionAndPython (see above)
2296 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2297 * Changed the layout of the python part to avoid bloating main
2298 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2299 i.e. the distutils arsenal. All the python related stuff is
2300 again in a python subdir, but the package itself is now in
2302 * setup.py was cleaned up:
2303 - pythonIncludePath removed
2304 - python setup.py bdist target is now functional.
2305 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2306 collision with other packages). gdcmPython/demo/*.py changed
2309 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2310 * python subdir moved to gdcmPython (preparation of distutils packaging).
2311 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2312 distutils installer is operational.
2313 * - gdcmPython/__init__.py now properly loads the swig generated
2314 shadow classes (from gdcm.py).
2315 - gdcmPython/demo/*.py changed to import the package gdcmPython
2316 instead of gdcmPython/demo/load.py.
2317 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2319 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2320 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2321 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2322 entries within the associated public Dicom dictionary resp. the same
2323 information but sorted by the fourth field (PAT, IMG, DIR) of the
2325 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2326 are now in the "???" group.
2327 - python/gdcm.i changed accordingly,
2328 - python/demo/printGroupedPublicDict.py added, that gives an example
2329 of the above new functionalities in Python.
2331 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2332 * src/gdcm.h, gdcmHeader.cxx:
2333 - historic references to glib's g_malloc and g_free (#defined)
2334 were definitively removed.
2335 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2336 * src/gdcmElValSet.cxx:
2337 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2338 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2339 - GetElValue(string) renamed to GetElValueByName.
2340 - Added GetElementByName(string).
2341 * src/gdcmHeader.cxx: added
2342 - GetPubElValRepByNumber(guint16, guint16)
2343 - GetPubElValRepByName(string)
2344 - GetShaElValRepByNumber(guint16, guint16)
2345 - GetShaElValRepByName(string)
2346 - GetShaElValByNumber(guint16, guint16)
2347 - GetShaElValRepByName(string)
2348 - GetElValRepByNumber(guint16, guint16)
2349 - GetElValRepByName(string)
2350 - GetElValByNumber(guint16, guint16)
2351 - GetElValRepByName(string)
2352 * Doc/requirements.txt added.
2354 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2355 * Test/Makefile building now depends on the one of libgdcm.so
2356 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2357 pixel data) aware which enables finding the address (offset) of
2358 the pixel data of JPEG encoded DICOM files. This leaves only a single
2359 file in the testSuite whose pixel data address (offset) is unknown.
2360 * python/testSuite.py changed accordingly.
2362 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2363 * VC++ has some strong limitations when working with the STL, as stated
2364 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2365 "Also note that some STL containers (map, set, queue, list, deque)
2366 cannot be exported. [...]
2367 Some STL classes contain nested classes. These classes can not
2369 This is caused by a designed limitation that once a template
2370 class is instantiated, it can not be re-instantiated and
2372 Since our usage of map<> is ubiquitous in gdcm, this "designed
2373 limitation" of VC++ is a pitfall.
2374 Hence the Python wrappers of gdcm cannot be incrementally linked
2375 against the c++ dynamic library. The dirty but only workaround is
2376 to forget about incremental link of dynamic libraries and to generate
2377 the Python wrappers library with the inclusions of the underlying C++
2379 The following modifications concern this matter on Win32/VC++:
2380 - wrapping python correct with standalone wrapped dll (don't use separate
2381 dll under windows !!!!)
2382 - python21_d debug mode enabled (ask Frog how to use it :-)
2383 - NO problem with having an STL member of class for example string in C++
2384 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2385 - Python test of dcmlib in Python is ok under windows on a large set
2387 * removed glib references
2388 * typedef's inserted in gdcm.i for correct swig type management
2390 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * python/demo/*.py load.py extracted from test.py. Added explore.py
2392 that only displays required tags and testAll.py that parses all
2393 the files of the testsuite without using unittest.
2394 * python/testSuite.py other additional test on new files added.
2395 * Data/* new test files added accordingly to the testSuite.
2396 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2397 the vr in the file differs from the one of the dictionary.
2399 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2401 values, but limits itself to values which are below a user specified
2402 size (by default 1024 bytes).
2403 * python/gdcm.i : elements not loaded (because their size is above the
2404 user specified treshold) are exported with their TagKey as key of the
2405 python dictionary. This enables the testsuite to make some checks
2406 on the unloaded elements (since we have their offset and size).
2407 * python/testSuite.py
2408 - now tests for the existence and proper value of the pixel data
2409 - two new examples added.
2410 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2412 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2413 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2414 aware. See the strategy comments in gdcmHeader::FindeLength().
2415 * Test/test.cxx now accepts a filename as first argument.
2416 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2417 * python/testSuite.py changed to integrate test on above files.
2419 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2421 the vr was also RET.
2422 * python/testSuite.py more tests added.
2424 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * python/testSuite.py unittest test suite added (uses Data)
2426 * Data/* dcm and acr files for the test suite.
2427 * glib dependance removed from un*x version. We now use ISO C99
2428 7.18 Integer types (see stdint.h)
2429 - python/Makefile, src/Makefile src/gdcm.h
2430 * src/ when an explicit vr (like dicom files) suddenly poped an
2431 implicit element we use to mark the underlying DictEntry of the
2432 concerned ElValue with "Implicit". This strategy was damageable
2433 too the public or provite dictionaries, since some of their vr
2434 would be changed. Since Header::FindLength heavily relies on the
2435 detection by Header::FindVR of falsely explicit elements, I
2436 added an extra ImplicitVr member to ElValue (boolean).
2437 The rest of the changes we the necessary adaptations.
2439 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2442 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2444 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * Adaptation for porting to VC++:
2447 o forced to use std namespace (for string to be known)
2448 o all class use __declspec export style on WIN32
2449 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2450 (in stdlib.h on Win32 but in std:: for gcc)
2451 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2452 variable GDCM_DICT_PATH.
2453 * src/gdcmHeader.cxx verbose comments made discrete.
2455 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2456 * python/gdcm.i: added a typemap that converts a C++ hashing table
2457 to native Python dictionary.
2458 * python/demo/test.py:
2459 - now uses the native dictionary for exploration of gdcmHeader.
2460 - takes an optional filename argument (the file to parse).
2461 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2462 PubElVals hashing table.
2463 * Dicts/dicomV3.dic removed error prone trailing spaces.
2465 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * Python wrapping process moved away from src/Makefile to
2467 newly created python/Makefile (as well as gdcm.i)
2468 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2469 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2470 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2471 from the environement variable GDCM_DICT_PATH (when existing).
2472 * src/gdcmDict::GetTag bug fix.
2474 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * Straightforward temporary fixes for swig to build the python wrappers.
2476 src/Makefile now has a python working entry [by working we mean
2477 that we can import de shadow classes without errors].
2479 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2480 * hashtest.cxx removed (since allready in Test)
2481 * src/gdcmlib.h renamed to src/gdcm.h
2482 * src/dcm.i renamed to src/gdcm.i
2483 * src/Makefile prepared for python wrapping
2485 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * src/gdcmHeader.cxx :
2487 - Parsing of header is now separated from loading of element values
2488 (see gdcmHeader::LoadElements).
2489 - general clean up of hopefully all file access (creation of
2490 ReadInt16 and ReadInt32)
2492 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2493 * src/gdcmHeader.cxx :
2494 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2496 - SetLgrElem renamed to SetLength
2497 - GetLgrElem renamed to GetLength
2498 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2499 * src/gdcmElValSet.cxx fixed both GetElValue methods
2500 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2501 due to IdoDude was cleaned out.
2503 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2505 concentrates on finding the value representation (when it exists).
2506 RecupLgr now only finds the element value length, and it avoids
2507 returning the unecessary skL (skipped length).
2508 Also, offsetCourant was simply removed (with taille_fich) since
2509 it was redundant with the File position internals (by using
2510 ftell and fseek). This also made skL (see above in RecupLgr) usage
2512 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2513 on the libido specificities which are handled through class
2515 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2518 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2519 * Truckload of changes. Parsing of header is barely functional
2520 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2522 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2523 * src/gdcmHeader.cxx many addons of low level methods
2525 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2526 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2527 and _IdDcmSWAP_LONG.
2529 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * This corresponds to all the changes decided at the meeting of
2531 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob