1 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
3 The default constructor invoked by the line
4 gdcmHeader *f1 = new gdcmHeader( header );
5 was gdcmHeader::gdcmHeader(bool) instead of the expected
6 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
7 Hence the parsing wasn't executed... See also below.
8 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
9 as explicit constructor didn't do the trick to fix the above problem.
10 Could anyone explain why ?
11 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
12 properly calls gdcmValEntry::Print() (that was weed out from
13 code related to gdcmBinEntry).
15 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
16 * In order to fix memory leaks:
17 - Test/TestWriteSimple.cxx: added cleaning of free store through
19 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
20 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
21 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
22 (through the call to ::AddDicomDirMeta()) or the destructor
23 would crash when deleting uninitialized ::metaElems].
24 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
25 - src/gdcmDocument.cxx:
26 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
28 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
29 was causing memory leaks.
31 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
32 cleanly handled with polymophism: sorry but my milage is low).
33 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
34 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
35 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
36 This avoids SegFaulting.
37 - src/gdcmSQItem.h: coding style.
39 - Test/TestWriteSimple still severely sucks. The output image content
40 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
41 damaged when displayed with vtkgdcmViewer.
42 - on memory leaks: TestWriteSimple leaks really less (see entry
43 of 2004-06-18 in Changelog file for the call to valgrind).
44 - on segfaults: ctest now passes all the tests but one (no more
46 * Erroneous leading white fix:
47 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
48 white[s] (as opposed to from >> xxx, that removes it [them].
49 - src/gdcmTS.cxx: ditto.
50 - gdcmPython/testSuite.py: dirty related kludge removed.
51 * src/*: remaining references to gdcmParser removed.
52 * src/*[cxx|h]: added copy[way]left header.
54 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
55 * In order to fix writing of dicom files:
56 - Test/TestWriteSimple.cxx: a simpler example of writing.
57 - Test/CMakeLists.txt changed accordingly.
58 - src/gdcmDocument.cxx:
59 -- The destructor now recursilvely removes potential sequences.
60 -- Bug fix in ::IsJPEG2000()
61 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
62 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
64 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
65 to only declared) and build on top of
66 ::GetDocEntryByNumber(guint16, guint16).
67 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
68 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
69 for usage in destructor and treatement of promotion in
70 ::ReplaceOrCreateByNumber().
71 - src/gdcmSQItem.cxx: destructor should better handle his job.
72 Test/TestWriteSimple now runs (or at least it DOES something).
73 * We can now start hutting memory links. A good starting point is:
74 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
75 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
76 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
78 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
79 * Valgrind note: after Mathieu Malaterre teached me how to read
80 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
82 Using gcc, you can force the STL to use malloc and to free memory as
83 soon as possible by globally disabling memory caching.
84 With 3.2.2 and later, you should export the environment variable
85 GLIBCPP_FORCE_NEW before running your program.
86 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
87 simply vanish (it is still not clear to me, whether this means that
88 STL std::string leaks or if valgrind believes it leaks...).
89 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
90 running bin/gdcmTests makeDicomDir):
91 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
92 - Test/makeDicomDir.cxx now properly traps empty lists and returns
94 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
95 SegFaulting (I drowned in DicomDir related code when trying to
96 understand why the list is empty...).
97 * src/gdcmDocument.h: first BSD license header try.
98 * Doc/License.txt added.
100 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
101 * src/gdcmDocument.[h|cxx]:
102 - Clean up of the Transfer related predicates. They are now all based
103 on new method isGivenTransferSyntax, that (should) handle properly
105 - general clean up, simplification, and coding style.
106 - Specific clean up of Parse7FE0() (umproperly named actually).
107 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
109 2004-06-14 Jean-Pierre Roux
111 - fix the display of Sequence Delimitor (SQDepthLevel pb)
112 - fix the display of SQItem ordinal number
113 - add the GetSQItemByOrdinalNumber method
114 - remove some useless never written private methods
116 2004-06-14 Jean-Pierre Roux
118 - adding a constructor taking a gdcmDocEntry as an input param
119 - ReplaceOrCreateByNumber now returns :
120 a gdcmBinEntry * if a Binary (void *) value is passed as a param
121 a gdcmValEntry * if a string value is passed as a param
123 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
124 according to the param type (no longer sets a gdcmDocEntry)
125 - GetValEntryByNumber, GetBinEntryByNumber added
126 - NewValEntryByNumber and NewBinEntryByNumber added
128 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
130 - GetSQItemNumber and SetSQItemNumber added, to provide
131 a (relative) Item identier inside a given Sequence
132 \warning : some pb remaining around this number
134 - AddEntry now takes the Item Number as a param
136 - adding a constructor taking a gdcmDocEntry as an input param
138 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * Memory leak hunt with the following command:
140 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
141 --show-reachable=yes gdcmTests PrintDocument
142 It looks like many (all?) leaks are due to the STL (or a bad usage
143 of the STL. The lines producing the leaks now have a comment with
144 a "MEMORY LEAK" tag: you can retrieve them with
145 grep "MEMORY LEAK" src/*
146 Here are two typical examples which I can't help fixing:
151 char * test = "babo";
152 name = test; //// <--- valgrind detects 960 bytes lost in
153 //// call to std::string::operator=(char const*)
154 name.clear(); //// Doesn't help !
162 std::cout << "Type a bunch of characters followed by RETURN: ";
163 getline(std::cin, line); //// <--- valgrind dectects a loss
164 //// of 1320 bytes in call to
165 /// std::basic_istream<>& std::getline<>
171 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * src/gdcmHeader.[cxx|h]:
173 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
174 and related, moved away to gdcmDocument.
175 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
176 the corresponding protected accessors of inherited class
177 gdcmDocument, removed ! As a consequence gdcmFile had to be
178 declared friend of class gdcmDocument (see below).
179 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
180 - Clean up of undefined or unused methods.
181 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
182 account the changes to gdcmHeader.h).
183 * src/gdcmDocument.h:
184 - gdcmFile is now a friend class (in order to take into account the
185 changes to gdcmHeader.h).
186 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
187 (see changes to gdcmHeader.h).
188 - Accessors (reading on the form GetEntry*) are now public.
189 - Clean up of undefined or unused methods.
190 * src/gdcmDocument.cxx:
191 - adaptation to changes to gdcmDocument.h
192 - ::OpenFile now writes a verbose message when file cannot be opened.
193 - some std::string properly set to VRKey
194 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
195 references to gdcmDocument.
196 * Test/TestFindTags.cxx: changed accordingly to above changes.
197 * gdcmPython/testSuite.py: adapted to renaming of acr files in
198 cvs repository gdcmData.
200 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
201 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
202 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
203 conflicts with gdcmValEntry::voidArea.
204 * src/gdcmValEntry.cxx: unmatching comment wiped out.
205 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
206 Value representation between StringRepresentable and BinaryRepresentable.
207 * src/gdcmDocument.cxx:
208 - method ParseDES: proper indentation restored and usage of
209 gdcmVR::IsVROfGdcmStringRepresentable wired in.
210 - method LoadDocEntry: the fingerprint left in the SetValue() of
211 unloaded entries (length > MaxSizeLoadEntry) had curiously been
212 removed. Reverting to previous code segment with the proper
213 dynamic_cast< gdcmValEntry* >.
214 Note: this was (partially) breaking the python test suite
215 (gdcmPython/testSuite.py) that made usage of the above
216 fingerprint to check presence of "Pixel Data".
217 * src/gdcmDocEntry.h: coding style.
218 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
219 now taken into account.
220 * gdcmPython/gdcm.i: adaptation to the new internal representation
221 of gdcm (exit gdcmParser, hello gdcmDocument).
222 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
224 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
225 anymore, but instead prints the loaded Python dictionary.
226 * .... alas, the python testSuite is still broken.
228 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
231 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
232 * src/gdcmUtil.h : export methods
234 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
237 * Initial addition of automatic python testing
238 * Initial addition of automatic image comparison
240 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
242 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
244 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
246 * Test/ShowDicom.cxx : bug fix for msvc compilation
247 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
249 2004-05-04 Jean-Pierre Roux
250 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
251 new concepts (and new classes) :
252 a 'gdcmDocument' is composed of a set of Doc Entries, that are
253 - elementary gdcmDocEntries (former gdcmHeaderEntries)
254 - Sequence Doc Entries (gdcmSeqEntries)
255 a Sequence is composed of Items.
256 Each item is a set of Doc Entries (this is recursive)
257 The non uniqueness of the 'Dicom tag' is due to this recursivity
258 (never taken into account)
259 Our unability to add a new 'entry' in the header
260 at the proper location (neither in the H-Table (map or multimap),
261 nor in the Chained List is also due to this recursivity.
262 Don't try, right now, to use/modify/compile these new sources :
264 We just commit all the stuff, 'as is', in order not to loose it.
266 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
269 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
271 file prefix (SetFilePrefix)
273 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
274 * Add a new test: ShowDicom, for now this is just the c++ version of
275 checkRead.sh, later it will be able to compare the image read against a
277 * Replace the DEBUG on the stack with a global entry in cmake interface:
278 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
280 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
281 * Add an example subdir, with a real example on how to read + write a
284 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
286 * Doc/CMakeLists.txt: the main page is now properly differentiated
287 between the developper and user version.
288 * Doc/doxygen.config.in: dropped search related obsolete flags
289 * src/gdcmParser.h, gdcmHeader.h: doxygenation
291 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * DEVELOPPER: added some helpfull comments for compile/test/install
295 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
296 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
297 src directory, now generated in the build dir.
298 2. Tests as mentionned smarter
300 4. Add a new method in gdcmDict that return the PubDict by name
301 this is interesting for 3rd party lib like ITK,
302 where we could set the institution name / patient name...
304 * ENH: 1. Now the test suite is working for real
305 2. All binaries are now output in the gdcm-bin directory
306 (this was not true before)
308 2004-04-28 Jean-Pierre Roux
309 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
310 SeQuence indented printing of Dicom Header.
311 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
312 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
313 Computation of SQDepthLevel is now part of gdcmHeader constructor
314 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
315 tree-like structure of a Dicom Header.
316 * FIX Test code cleaning
318 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
319 * ENH: Adding automatic testing
320 1. Need a DartConfig.cmake to submit to public
321 2. Add a test driver gdcmTest.cxx
322 3. gdcmTestMain, an helper for the main test driver gdcmTest
323 4. Files in Test don't have a main anymore, this becomes interesting
324 when we add more and more tests, thus dsw don't have to load
326 * ENH: Adding a GDCM_DATA_ROOT for testing
327 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
328 one file instead of seven + some small cleanup
330 2004-04-22 Jean-Pierre Roux
331 * ENH Minor changes to the Print() methods.
332 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
333 Header printing. Example given with :
334 > PrintHeader fileName 2 new
335 (SQ based tree-like structure still to be done for the Header ...)
337 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
338 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
339 1. I have added some unsigned where needed
340 2. Some function parameter not used -> (void)
341 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
342 4. g++ don't like character '\' in comment
343 5. #define jpeg_create_decompress jCreaDecompress
344 this really need to be fixed
345 6. virtualize destructor of gdcmObject ... leakage
346 7. sscanf(g->first.c_str(),"%x",&gr_bid);
347 this also really need to be fixed
348 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
349 remove compression file
350 (as we only do decompression, right ?)
351 * ENH: Change malloc/calloc/free with c++ equivalent
353 2004-04-21 Jean-Pierre Roux
354 * FIX gdcmHeaderHelper::GetXSpacing
355 when a single value is found (bug ?), xpacing is now
356 defaulted to yspacing
358 2004-04-19 Jean-Pierre Roux
359 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
360 * ENH add parameters :
361 bool exception_on_error = false,
362 bool enable_sequences = false,
363 bool ignore_shadow = false
364 to the gdcmFile constructors to be full gdcmParser compliant
365 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
366 to allow reading of PAPYRUS 3.0 files
368 2004-04-06 Jean-Pierre Roux
369 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
371 2004-04-02 Jean-Pierre Roux
372 * ADD : Test/checksequence.sh, for a general recap on SQ pb
373 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
374 for Philips spurious Tag fffe|0000 while rewritting Dicom files
376 2004-03-30 Jean-Pierre Roux
377 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
378 for ACR file, written out as DICOM files (hope so...)
380 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
381 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
382 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
383 moved to base class gdcmParser and only the specialisation is kept
385 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
386 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
387 already does the job.
388 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
389 (to be consistent with gdcmParser::WriteEntries).
391 2004-03-30 Benoit Regrain
392 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
393 upate of the object's instance. It's passed to 2 in the unfavorable
394 case : one in the ExecuteInformation, one in the ExecuteData
396 2004-03-29 Jean-Pierre Roux
397 * ENH : Check on file type to be written moved
398 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
399 * FIX : gdcmObject::ResetBoundaries now stops properly
400 when end-of-list is reached
401 : gdcmVersion modified (as Benoit Regrain asked)
403 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
404 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
405 * src/gdcmUtil.cxx: added forgotten iostream include.
406 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
407 equivalent to ExplicitVR in existing code).
409 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
410 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
411 now contains all the gdcmGlobal related code.
412 * minor coding style and doxygenation changes.
414 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
415 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
416 now contains all the Debug related code.
417 * minor clean-up of includes in src/*.cxx
418 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
419 CreateCleanString) removed.
420 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
421 * Doc/DoxyMainPageUser.txt added.
422 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
423 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
426 2004-03-24 Jean-Pierre Roux
427 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
429 2004-03-23 Jean-Pierre Roux
430 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
431 big endian made volumes
432 * ENH Now gdcmParser constructor and destructor are protected to forbid
433 end user to instanciate class gdcmParser
434 (only gdcmHeader and gdcmDicomDir are meaningfull)
436 2004-03-22 Benoit Regrain
437 * FIX : src/gdcmDicomDir.cxx : make windows compilable
438 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
439 gdcmSerie to gdcmDicomDirSerie
441 2004-03-19 Jean-Pierre Roux
442 * ENH Now the tree-like structure describing a DICOMDIR comming from
443 an already existing DICOMDIR file is consistent with
444 the home-made tree-like structure build ex-nihilo
445 or build from the files held (recursively) in a Directory
446 functions gdcmDicomDir::CheckBoundaries()
447 gdcmObject::SetBoundaries() added
449 2004-03-17 Jean-Pierre Roux
450 * REM (Eric Boix bug) : removal of meaningless
451 gdcmDicomDirImage::NewImage function.
452 * FIX now file names and directory name are written properly in the
454 * FIX now gdcmDicomDir constructor may be call without any trick
457 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
459 of gdcmDicomDirImage::NewImage as empty function.
461 2004-02-28 Jean-Pierre Roux
462 * ENH add gdcmDicomDir:NewPatient
463 add gdcmDicomDirPatient:NewStudy
464 add gdcmDicomDirStudy:NewSerie
465 add gdcmDicomDirSerie:NewImage
466 to allow making gdcDicomDir object.
467 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
468 (as opposite to the gdcmHeader chained list)
470 2004-02-11 Benoit Regrain
471 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
472 when using from python
474 2004-02-10 Benoit Regrain
475 * FIX : bug fix in the gdcmDirList for the recursivity in directories
476 * FIX : in gdcmDicomDir when the directory is empty
477 * ENH : add callback and methods to get the progression of dicomDir
480 2004-02-06 Jean-Pierre Roux
481 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
482 - GDCM_META added to gdcmDicomDirType
483 - class gdcmMeta created
484 * ENH : - A brief summary is now displayed at the beginning of
485 'testDicomDir' to help disaster magnitude estimation
486 * REM : Now useless Test/explDICOMDIR.cxx
488 2004-02-05 Benoit Regrain
489 * ENH : add methods in gdcmObject to get the hash table or the list of
491 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
492 * FIX : wrapping python for TagHeaderEntryHT
494 2004-02-04 Benoit Regrain
495 * FIX : even length for some strings when writting the dicom dir
496 * FIX : sort the images in the dicom dir
497 * FIX : Bug fix for python use of dicom dir
498 * ADD : a python demo
500 2004-02-04 Jean-Pierre Roux
501 * FIX : Final solution (?) for icone embedded images
502 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
503 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
504 add groups 6002, 6004, 6006, to allow 'clean' parsing of
505 gdcmData/gdcm-MR-SIEMENS-16.acr1
506 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
507 to make full checking easier
509 2004-02-04 Benoit Regrain
510 * FIX : WriteEntries : coding style & logic in parameters
511 * FIX : Set the elements to create the DicomDir in a dictionary file
513 2004-02-03 Benoit Regrain
514 * gdcmDirList : to parse a hard drive directory in recursive (or not)
515 * gdcmDicomDir : add the load of directory
516 * Bug fix and print add-on
518 2004-02-03 Jean-Pierre Roux
519 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
520 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
521 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
522 * FIX gdcmParser.cxx : 'group length' elements are now considered
523 as integers, even for shadow groups, when file is Implicit VR
525 2004-02-02 Jean-Pierre Roux
526 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
528 of the last synonym :-(
529 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
531 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
532 * FIX taking into account the possible 7fe0,0010 multiplicity
533 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
534 to allow removal of references to 7fe0,0010, to deal with
535 ACR-NEMA images, when 0028,0200 is meaningfull
537 2004-01-31 Jean-Pierre Roux
538 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
539 no longer writes 'Un' on disk
540 * FIX SQ elements with actual length are now dealt with corectly
541 * FIX gdcmFile::WriteBase make the difference, for color images, between
542 the length (for Palette expanded images)
543 and Raw Length (non expanded image + Palette)
544 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
545 (that broke Write). Replaced by UL.
546 Aware user will reload the field if he
547 thinks it's necesssary
549 2004-01-30 Jean-Pierre Roux
550 * gdcmParser::CheckSwap() now defaults the filetype to ACR
551 when 'dirty Acr' is found, to be compliant with the new
552 IsReadable() methods.
554 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
555 (no DOUBLE images in kosher DICOM,
556 but so usefull for people that miss them ;-)
558 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
559 DICOMDIR related utilities (not checked as Windoze compliant)
561 2004-01-28 Jean-Pierre Roux
562 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
564 2004-01-27 Jean-Pierre Roux
565 * gdcmParser constructor has a new boolean param,'ignore_shadow',
566 to allow skipping the shadow elements, to save memory space.
567 The TRUE value for this param has to be used
568 with a FALSE value for the 'enable_sequence' param.
569 ('public elements' may be embedded in 'shadow Sequences')
570 * gdcmHeader methods now deal with 'embedded icones images' in the header
571 (even when an 'icone image sequence' is announced by the
572 element (0x0088,0x0200), but there is NO icone at all ...
574 * gdcmHeader sometimes Image Location value doesn't follow
575 the supposed processor endianity (see gdcmData/cr172241.dcm).
578 * gdcmHeader add the method
579 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
580 to get *all* the Header Entries with the same tag.
581 GetHeaderEntrySameName is probabely *useless*
582 (no meaning : Name is *not* an identifier within the Dictionnary)
584 2004-01-26 Benoit Regrain
585 * Bug fix in the print of hexadecimal representations. Remove long fields
586 in the print and add a third level of print to print them
588 2004-01-23 Benoit Regrain
589 * Bug fix on field having a VR = 'UI'. Assume that is a string field
590 * Bug fix on test suite after remove the strip made on not string fields
591 * Split the IsReadable method between gdcmParser which test that the file
592 is dicom and gdcmHeader which test that it's an image file
594 2004-01-22 Benoit Regrain
595 * DicomDir : clean code, add methods, set variables in protected or private
596 * gdcmUtil : bug fix for the clean string method
598 2004-01-19 Benoit Regrain
599 * Add the use of shadow dictionaries
600 * bug fix and coding style
602 2004-01-19 Benoit Regrain
603 * src/gdcmFile.cxx : bug fix concerning the close of file
604 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
605 * Add the update of header entries using the shadow library
607 2004-01-19 Benoit Regrain
608 * removal of file gdcmHeader2.cxx
609 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
610 inheriting from gdcmParser. This split is to prepare the integration
612 * bug fix under python
614 2004-01-16 Jean-Pierre Roux
615 * REM removal of class gdcmHeaderEntrySet
616 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
617 * ADD add file gdcmHeader2.cxx
618 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
620 2004-01-15 Benoit Regrain
621 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
622 entries created while parsing the header. Thus, they will be destroyed
623 when the gdcmDictSet will be destroyed
624 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
627 2004-01-15 Benoit Regrain
628 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
629 made a fatal error because of the memory release at the end of program.
630 The problem was in vtkGdcmReader::ExecuteData where we were allocate
631 some memory and vtk seems to have some problems with that.
632 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
634 2004-01-14 Benoit Regrain
635 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
636 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
637 * src/*.[h|cxx] : make changes due to class name changes
638 * gdcmPython/demo/*.py : bug fix due to method names
640 2004-01-13 Benoit Regrain
641 * src/*.[h|cxx] : coding style
642 * vtk/*.[h|cxx] : coding style
644 2004-01-13 Benoit Regrain
645 * gdcmPython/testSuite.py : test the readable flag of file for tests
646 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
647 It's lied to the stl compilation by MSVC (windows, always windows...)
648 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
650 2004-01-12 Benoit Regrain
651 * src/*.h : add comments
652 * src/gdcmDictSet.h : set the method BuildDictPath in public
653 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
654 directly setted in the source code
655 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
658 2004-01-09 Benoit Regrain
659 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
660 * setup.py : use a reference to gdcmVERSION
662 2004-01-07 Benoit Regrain
663 * Modification to compile with the distutils.
666 2003-12-10 Benoit Regrain
667 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
668 can use a gdcmHeaderHelper to load datas
669 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
670 made in the source code
672 2003-12-10 Benoit Regrain
673 * Update Windows projects and .cvsignore files
675 2003-11-12 Jean-Pierre Roux
676 * ENH gdcmHeader constructor has one more parameter (default value : false)
677 that allows the user to 'go inside' the SeQuences only
679 gdcmElValSet:Print takes it into account
681 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
682 * ENH: Update gdcmPython/CMakeLists
683 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
684 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
686 2003-11-10 Jean-Pierre Roux
687 * FIX : gdcmHeader::LoadElements is now based
688 on the ListTag listElem member,
689 not longer on the TagElValueHT tagHt member
690 * ENH : PrintPubElVal shows (temporarily) both results,
691 with the tagHt member and the listElem member.
692 (it's easier to 'see' the problems when using Printheader)
694 * FIX : old private member LgrElem is now splitted into
695 ReadLength : Length actually found on disk (updated only
696 if bug fixing is necessary), for internal
698 UsableLength : Updated by FixFoundLength, to fix a bug
699 or to allow Parser going on.
700 Will allow to re-write a kosher header when a SeQuence
701 with a length (not 0000) is found
702 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
703 because gdcmElValSet::Add does not update ListElem
706 2003-11-07 Jean-Pierre Roux
707 * FIX misstyping in Transfert Syntax name table
708 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
709 when they have an actual length (not 0000 nor FFFFF)
710 (Nobody should care of it, but DICOMDIR explorers)
712 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
713 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
715 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
716 * ENH: vtkGdcmReader now supports LUT !
717 (vtkgdcmViewer for now is not able to use them though)
719 2003-11-05 Jean-Pierre Roux
720 * in testSuite.py : new files names for checking the package
721 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
722 that returns the pixel area size to the *aware* (vtk) user
723 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
725 2003-11-05 Benoit Regrain
726 * in testSuite.py : Modify the rules for checking the paths
727 : Explicit error messages
728 * in __init__.py : Related modif
730 2003-11-03 Jean-Pierre Roux
731 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
732 to be used by aware (vtk) users that want to manage
733 LUT (and no to turn the PALETTE image into an RGB pixels one)
734 * GetPixelType now returns 8U for 24 Bits images
735 (vtkGdcmReader compliant)
737 2003-10-31 Jean-Pierre Roux
738 * Removal of *all* gdcmData images and add them again
739 in order to loose the 'history' of un-anonymised images
741 2003-10-31 Jean-Pierre Roux
742 * RMV : removal of useless jBitsInJsample.h
743 for both 8 and 12 Bits JPEG Lossy Libraries
745 2003-10-31 Jean-Pierre Roux
746 * ENH : Add the functions gdcmFile::GetImageDataRaw
747 gdcmFile::GetImageDataIntoVectorRaw
748 that act as GetImageData and GetImageDataIntoVector
749 except the making of an RGB Plane from Gray Plane + LUT
750 Intended to aware (vtk) users who know how to manage
753 GetLUTRGBA return a R,G,B,A LUT if any
754 lgrTotaleRaw gives the 'Raw' length
755 GetImageDataRaw returns the gray Plane
756 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
757 (They stay Grey, just like with other Dicom viewers :-(
759 2003-10-30 Jean-Pierre Roux
760 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
762 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
763 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
764 being coherents dicom files.
766 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
767 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
769 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
770 * ENH: Two steps is necessary to please VC++ compiler...
771 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
772 * ENH: Add include dir to medcon lib
773 * FIX: only one function is being exported for now !
774 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
776 2003-10-29 Jean-Pierre Roux
777 * adding gdcmHeader::GetLUTRGBA
778 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
779 --> Mathieu, the modif u're waiting for is not yet committed
780 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
782 2003-10-27 Jean-Pierre Roux
783 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
784 00191113.dcm DermaColorLossLess.dcm
785 MxTwinLossLess.dcm RadBWLossLess.dcm
786 * ENH: For version prior to vtkImageViewer2 -r 1.19
787 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
789 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
790 * Removal of ido stuff in CMakeLists.txt
792 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
793 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
794 * FIX: remove a call to ->Modified ... see comments
795 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
797 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
798 * FIX: Problem with path for libvtkgdcmPython
799 * ENH: Try adding a search script for python site-package
800 * RMV: Remove some file from medcon lib that are not necessary
801 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
802 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
803 * FIX: More pragma disable fro VC++,
804 I don't think I break something as it is also disable in VTK/ITK.
805 But it fasten debug compilation time.
807 2003-10-23 Jean-Pierre Roux
808 * gdcm now deals with 16 Bits Run Length Encoded images
809 (they are compressed as 2 planes images,
810 one for the high Bytes, the other for low Bytes)
812 2003-10-22 Jean-Pierre Roux
813 * Now CheckRead takes into account :
814 - the bugged 'Leonardo' Siemens images
815 - the XA images, sent thru the burning VPRO station
816 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
819 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
820 * FIX: When copying a Makefile.am to CMakeLists.txt
821 one should remove the '\'
823 2003-10-22 Jean-Pierre Roux
824 * in gdcmData adding a bugged 'Leonardo' Siemens image
825 (wrong lengths in header)
826 OK with gdcm, KO with the other viewers :-)
827 * add a GE dlx XA image, thru the VEPRO burning station
830 2003-10-21 Jean-Pierre Roux
831 * in gdcmData add the checkvtkgdcmViewer.sh shell script
832 for a brutal checking of vtkgdcmViewer compliance
834 2003-10-21 Jean-Pierre Roux
835 * add the files for 'xmedcon' Jpeg Lossless library
836 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
838 2003-10-21 Jean-Pierre Roux
839 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
841 2003-10-21 Jean-Pierre Roux
842 * garbage Siemens 'Leonardo' images dealt with
843 (the patch is easy to remove)
844 * cosmetic changes to avoid warnings
846 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
847 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
848 no need to press 'r' now.
850 2003-10-20 Jean-Pierre Roux
851 * upgrade of checkRead.sh checkWrite.sh according
852 to new Jpeg Lossless decompressor
853 * add US.3405.1.dcm, a genuine RGB medical file ...
854 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
855 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
857 2003-10-15 Jean-Pierre Roux
858 * general anonymisation in gdcmData
859 * adding the 'color files' from
860 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
861 * adding some well knowed bugged-header images
862 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
863 waiting for their inclusion in Python testsuite
865 2003-10-15 Jean-Pierre Roux
866 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
867 no longer seg faults when file is not found
869 2003-10-14 Jean-Pierre Roux
870 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
873 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
874 * TODO: *.in file to genereate a UseGDCM later
876 2003-10-14 Jean-Pierre Roux
877 * Some supposed-to-be Dicom Images have no preamble.
878 OpenFile takes it into account
879 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
880 * Missing elements added in dicomV3.dic
881 (just to be affraid : have a look at
882 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
883 and do it again next year ;->
885 2003-10-13 Jean-Pierre Roux
886 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
887 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
888 But there are NOT. It's fixed !
890 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
891 * FIX: "jpeglib.h" was not found on VC++
892 * FIX: vtkgdcm was not being installed
894 2003-10-10 Jean-Pierre Roux
895 * ENH : OpenFile closes the file if it *really* doesn't look like
896 an ACR-NEMA / DICOM one.
897 * FIX : testWrite no longer writes an empty file if the source file
899 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
902 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
903 * FIX: CMake generate now documentation
904 * ENH: out of source doc build !
905 * ENH: Generate both user and dev documentation
906 * ENH: Should work on windows too
907 * ENH: Only one doxygen config.in file is needed
908 * FIX: make install should be ok now on ùnix plateform
909 * FIX: PATH to dictionary was wrong (missing /)
910 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
912 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
913 * vtkGdcmReader is now able to read rgb dicom file.
914 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
915 * added a gdcmViewer to vtk test, use mouse to control
916 window level & window width
918 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
919 * CMake-ification of gdcm, we have now two build system
920 * FIX: on cygwin Wsock32 doesn't exist
921 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
923 2003-10-06 Emanuel Ollart
924 * FIX : compilation process wad broken.
925 Changed gdcmViewer_sources to vtkgdcmViewer_sources
927 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
928 * change gdcmViewer -> vtkgdcmViewer
929 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
931 2003-10-06 Jean-Pierre Roux
932 * FIX :A few nasty patches to allow the reading of a lot of nasty images
933 ( e.g : well known GE images with a wrong elem length,
934 : Philips MRI Images with a wrong Huffman table)
935 * still to be done : allow the reading of bugged LEONARDO Siemens images
937 2003-10-03 Jean-Pierre Roux
938 * Odd length strings are padded with '\0' (not with spaces,
939 to remain compliant with already defined strings,
940 like Transfert Syntax UID and others)
942 2003-10-03 Jean-Pierre Roux
943 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
944 to allow displaying RGB images (not only by affim ;-)
946 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
947 * vtkGdcmReader is now able to read rgb dicom file.
948 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
950 2003-10-03 Jean-Pierre Roux
951 * A few nasty patches to allow the reading of a lot of nasty images
952 ( e.g : well known GE images with a wrong elem length,
953 : Philips MRI Images with a wrong Huffman table)
954 * still to be done : allow the reading of bugged LEONARDO Siemens images
956 2003-10-03 Jean-Pierre Roux
957 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
959 2003-10-03 Jean-Pierre Roux
960 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
961 to allow displaying RGB images (not only by affim ;-)
963 2003-10-03 Jean-Pierre Roux
964 * gdcmFile::GetImageDataIntoVector now
965 - deals with MultiFrames MultiFragments Run Length Encoded files
966 - deals with YcBcR (YBR_FULL) files
967 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
968 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
972 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
973 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
974 Two reasons: - clear things
975 - third parties acces gdcm through header files, so won't
976 suffer anymore VC++ complains
978 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
979 * add argv[1] in testvtkGdcmReader.cxx
982 2003-09-24 Jean-Pierre Roux
983 * The lines are now eigthy characters long.for
984 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
986 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
987 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
988 char* to std::string. Thus, the use of strdup becomes useless. (see
989 previous commis of Malaterre)
990 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
991 before the last Malaterre's commit.
993 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
994 * This commit should fix the Debug building under VC++, the problem
995 was mainly a mixture of debug and release lib being loaded at startup.
996 * I also remove a depency to a specific C function: strdup. Because I had
997 to force the link to msvcrtd (whereas strdup is in libc).
999 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1000 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1001 located in the gdcmCommon.h file. All use of reference of tha has been
1002 changed to now use the variable GDCM_UNFOUND.
1004 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1006 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1007 Dicom dictionary. The test suite can now be run again. Note:
1008 I'm note very happy with the " (RET)" changes. I believe this
1009 RETAINED comment should be dropped when parsing the dictionary.
1010 - PACKAGER corrected
1012 - AUTHORS updated and now in alphabetical order
1013 * Makefile.am now exports gdcm.dsw for Windoze users.
1015 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1016 * cygwin complains about missing std:: in subdir Test/
1018 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1019 * remove some methods that are now in gdcmHeaderHelper
1021 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1022 * vtkGdcmReader set spacing and origin correctly
1024 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1025 * Fix a few delete/delete[] mismatch
1027 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1028 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1029 interpretation to data given by gdcmHeader. For instance there are
1030 heuristics to get informations (look at different places).
1031 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1032 sorting DICOM images based on different strategies.
1033 * modified Makefiles accordingly.
1035 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1036 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1037 when building in debug mode
1038 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1039 src/win32/gdcmdll.dsp
1040 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1042 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1043 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1046 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1047 * src/win32/libgdcmjpeg12.dsp was not dos format
1048 * src/win32/libgdcmjpeg12.dsp :
1049 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1050 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1052 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1053 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1055 * src/gdcmFile.cxx : bug fix in affectation type
1056 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1057 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1058 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1059 symbols... future problem ?
1061 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1062 * src/win32/libgdcmijpeg12.dsp was missing
1063 * modified gdcm.dsw accordingly
1065 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1066 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1068 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1069 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1070 commit of JPR (before his hollidays to facilitate our work).
1071 * setup.py : bug fix in code. Modifications made while the last commit
1072 of JPR. The code hasn't been tested before the commit... it's so
1073 useless to make that (for best programmer that is JPR) !!!
1075 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * tagged the current version as Version0_3 (i.e. version 0.3)
1078 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1079 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1080 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1081 * *.dsp : modifications to use new libgdcmijpeg8 library
1082 * setup.py : bug fix on VTKPATH variable
1083 * PACKAGER : adding all concerning windows
1085 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1086 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1088 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1089 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1090 test suite reported error.
1091 * PACKAGER file added (describes what a packager must do when
1092 packaging a new release).
1093 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1094 * configure.in: upgraded version number to 0.3.0
1095 * fixing build of rpm (through rpm -ta):
1096 - Doc/Makefile.am exports proper doxygen files
1097 - src/jpeg/libijg8/Makefile.am exports the include files.
1099 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1100 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1101 * src/gdcmHeader.h : formatting code
1103 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1104 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1105 We were obtaining error message from vtk. Now, creation of file list
1106 is made in an internal list to prevent this problem.
1107 Bug fix when output is empty.
1108 Bug fix in update of progress value. Previous commit for this was a bad
1110 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1112 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1113 * src/gdcmHeader.h : added method to get the file name
1114 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1115 files. Added method to remove all files on the input
1116 Added FIXME comment concerning the bad parsing of header made by
1117 ExecuteInformation method (in ExecuteData method)
1119 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1120 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1121 when using make instal.
1122 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1123 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1125 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1126 * setup.py : adding include dir of jpeg lib to compile all sources
1127 * */Win32/*.dsp : JPR fix for windows compilation
1129 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1130 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1132 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1133 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1135 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * setup.py is again effective on un*x (takes into account the
1137 addon of the jpeg library)
1138 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1139 * Doc/Doxy* updated (includes above enhancements)
1140 * INSTALL now points to web documentation
1142 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1143 * src/gdcmHeader.h doesn't make unnecessary reference to
1145 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1147 * src/gdcm*.[cxx|h] :
1148 - to allow compilation with gcc 3.x
1149 -- clean up of STL usage (added explicit usage of std::)
1150 -- small fixes on exceptions.
1151 Note: linking not tested !
1152 - clean of doxygen comments to avoid warnings at documentation
1154 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1155 dependent convertion).
1157 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * Clean up of previous JPR garbage commit (not even commented in the
1160 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1161 - moved all jpeg related files from src to src/jpeg/libijg8, with
1162 addition/modification of Makefile.am and configure.in.
1163 - the testSuite is still brain damage (not guilty).
1165 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1166 * WrapVTK.py : modifications to get correctly vtk source files to
1168 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1169 (FileName -> Filename)
1171 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1172 * vtk/vtkGdcmReader.[cxx/h]:
1173 - UpdateProgress method should now be effective
1174 - removed the limitation on having only images loaded (as opposed
1176 - when building a stack of images/volume, a lesser number of
1177 gdcmHeader and gdcmFile instances should be used (hopefully
1178 accelerating things).
1179 - when building a stack of images/volumes, files which are not
1180 loadable (wrong path-filename, wrong permissions on existing file,
1181 or file not parsable by gdcm) are replaced with a black image
1182 in the stack (for the caller to notice the problem).
1184 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1185 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1187 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1188 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1189 between standard library (std) and vtk library (problems are found
1190 under Windows... thanks Windows !)
1192 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1193 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1195 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1197 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1198 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1200 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1201 * When compiling with distutils (see setup.py) the C++ compiler is
1202 called with different flags than the default ones (with automake).
1203 In order to fix all those warning, I compiled gdcm with the command
1204 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1205 and went for warning fixes:
1206 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1207 up from unused variables.
1208 - vtk/vtkGdcmReader.cxx: potential bug fix.
1209 * src/gdcmHeader.h: Doxygen warning cleanup
1211 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1212 * gdcmPython/gdcm.i:
1213 - typemaps correction to take into account the systematic replacement
1214 of "using namespace std" with std:: prefix e.g. std::list,
1215 std::string... (cf changes of 2003-05-21).
1216 - gdcmGlob global variable of type gdcmGlobal (defined in
1217 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1218 exported to Python a as cvar.
1219 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1220 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1221 gdcmDictSet.GetPubDictTagNames() and
1222 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1223 C++ static methods).
1224 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1225 with the above changes.
1227 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1228 * setup.py, manifest.in : bug fix under linux
1230 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1231 * Modification of setup.py to compile vtk part too. Then, we have 2
1232 wrappers which must work with same distutils. For that, we have a
1233 generic distutils in distusiltsWrapping.py ; with :
1234 - build_extWrap class to wrap generically all extensions,
1235 - ExtensionWrap base class for all wrapping extension that contains
1237 - Wrapper interface which wrap sources
1238 + In WrapSwig.py we have extension and wrapper for Swig
1239 + In WrapVTK.py we have extension and wrapper for VTK
1240 * MANIFEST.in : modifications to consider vtk directory and new python
1241 files for compilation
1243 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1244 * Added python wrappers of vtkGdcmReader vtk class (see the
1245 source in vtk/vtkGdcmReader.cxx) :
1246 - vtk/Makefile.am now builds a library
1247 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1248 python library (as opposed to _gdcm.so wich are the python
1249 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1250 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1252 - configure.in has an additional flag --enable-vtk that needs
1253 to be set to enable compilation of vtk related code, that is:
1254 + vtk/vtkGdcmReader.so and
1255 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1256 + gdcmPython/vtkgdcmPython.so (see above)
1257 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1258 be read when compressed or when HighBit + 1 != BitsStored),
1259 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1260 the usage of the python wrapper of vtkGdcmReader vtk class.
1261 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1262 * src/*.[h] all occurences of stl classes are now prefixed with
1263 std::, and all occurences of "using namespace std;" where removed.
1264 This is to avoid pollution of global namespace in included files.
1265 Apparently vtk does not avoid this pitfall: when using both
1266 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1267 collision of various stl members (principally cout...).
1268 * gdcmPython/testSuite.py now cleanly removes temprory generated
1270 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1271 comply with above changes)
1273 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1274 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1275 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1276 vtk data structure (an image Flip was required).
1277 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1278 * cosmetic changes in documentation.
1280 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1281 * src/gdcmHeader.cxx: the constructor no longer exits when an
1282 unexisting file is given as argument.
1283 * The subdirectory Data (containing all the images used for the
1284 test suite) is not part of this repository anymore. A new module
1285 containing those images is now available at
1286 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1287 with the name gdcmData.
1288 All the python scripts (including the package initialisation file
1289 gdcmPython/__init__.py) were adapated to take this change into
1290 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1292 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1293 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1294 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1295 demo of the usage of this class.
1296 Compilation of this vtk part is only done when using the --enable-vtk
1297 at configure (or autogen.sh) stage.
1299 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1300 * More memory link related corrections and documentation fixes.
1302 - maximum info is obtained with a command of the form:
1303 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1304 --show-reachable=yes PrintHeader
1305 - the remaining reachable blocks seem to come from the STL
1306 allocation scheme through the usage of map and list. It looks
1307 like this memory cannot be freed but it is not a memory leak
1308 (in fact further invocation to the STL would recollect the
1309 unused memory allthough it cannot explicitely be freed).
1310 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1311 of displaying an image parsed with gdcm and displayed with VTK.
1312 Note: some images don't seem to work e.g.
1313 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1314 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1315 Allthough this weakens the semantics, it is a ditch attempt to
1316 make gdcm more thread friendly.
1318 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1319 * Memory link hunt (by using valgrind through the command
1320 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1321 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1322 gdcmHeader::_dicom_vr.
1323 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1324 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1326 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1328 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1329 * src/Makefile.am now exports all the necessary include files at
1333 * UpdateGroupLength replaced by new one
1336 * UpdateGroupLength re-written using H-Table
1337 (named UpdateGroupLengthNew untill checks are over)
1339 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1340 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1341 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1343 - gdcmHeader::GetPubElValSet removed.
1344 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1345 UpdateGroupLength, WriteElements, Write.
1346 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1347 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1348 carried the same semantics.
1349 - src/gdcmHeaderIdo.cxx changed accordingly.
1350 - gdcmFile::WriteBase now regroups all the codes from previous
1351 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1352 - enum FileType moved to gdcmCommon.h
1353 * src/gdcmHeader.cxx AddDefault trashed
1354 * gdcmGetXSize added
1355 * getimageDataSize now calls gdcmGetXSize
1356 * Test/*.cxx changed to agree with above changes
1358 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1359 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1360 (to avoid double call by end user).
1361 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1362 by end user, since gdcmHeader::gdcmHeader now handles it.
1364 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * gdcm/Doc many doxygen changes:
1366 - Doxyfile now has two different versions, DoxyfileUsers that generates
1367 the html.users end users oriented documentation and
1368 DoxyfileDeveloppers that generates the html.developper developper
1369 oriented documentation.
1370 - README changed accordingly
1371 - requirement.txt removed (old design info moved to TODO).
1372 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1373 DoxyMainPage.txt, DoxyPython.txt provide more information.
1374 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1375 be updated by simply regenerating the docs with doxygen and copying
1376 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1377 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1378 all the tests in the form "if (<map>.count() >1)" were removed.
1379 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1380 ill-formed documentation sections.
1381 * src/gdcmHeader.cxx: ditto
1383 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1384 * setup.py fixed for un*x (needed macro for stdint.h)
1385 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1386 un*ces with sh-utils test utility.
1387 * gdcmPython/demo/test.py renamed to PrintHeader.py
1388 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1389 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1390 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1391 * src/gdcm*.cxx JPR's bad inclusion fixed.
1393 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1394 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1395 * gdcmPython/demo/test.py changed accordingly.
1397 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1398 * gdcmPython/Makefile.am fixed linking against libstdc++
1399 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1400 * Swig subdir (historical tests of swig version 1.3.17++) removed
1401 * Test/testChangeEntete.cxx some lines commented out in order to make
1403 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1404 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1406 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1407 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1408 hence the user doesn't need this explicit call.
1409 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1410 i.e. LoadElements() call removed.
1411 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1412 - src/Makefile.am declares the proper flag for g++.
1413 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1414 for adding user defined new tags.
1415 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1416 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1417 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1419 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1420 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1421 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1422 src/Makefile.am : the project should properly compile and install
1423 with the autotools, included the python wrappers part.
1424 * gdcm.spec.in : added a spec file for RPM packaging.
1426 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1427 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1429 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1430 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1431 to exported to the environement (see gdcmPython/testSuite.py
1433 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1434 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1435 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1436 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1437 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1439 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * gdcmPython/__init__.py doesn't crash anymore when running in
1441 in InstallMode or PreInstallMode but with an environement given
1442 value of GDCM_DICT_PATH.
1443 * src/gdcmDictSet.[cxx/h] coding style.
1445 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1446 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1447 * src/gdcm.h general comments moved to TODO, and README
1448 * src/gdcm.h should now be seen as a user commodity (including it
1449 should suffice to fully use gdcm). It is nowhere including within
1450 any of the kernel files src/*.cxx and src/*.h.
1452 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1453 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1454 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1456 * src/gdcm*.cxx only include their corresponding include file
1457 (as opposed to gdcm.h)
1458 * gdcmPython/gdcm.i changed accordingly
1459 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1460 the autogen.sh generated "make snapshot" command to work.
1461 * autogen.sh removed history related references to crea package.
1463 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1464 * distutilsSwigCPlusPlus.py work around some swig portability
1467 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1468 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1469 was done in a last ditch attempt to get setup.py _really_
1470 operationnal. The python/gdcmPython layaout add the advantage
1471 of hidding away the python related distutils specific files
1472 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1473 Alas, the src directory was out of scope (i.e. it's relative
1474 position to setup.py was ../src) which made things impossible to
1475 handle (see previous version of python/setup.py). Crossing fingers...
1477 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * python/setup.py now works on Un*x. (harder than I thougth)
1479 * python/distutilsSwigCPlusPlus.py can now have include files
1480 among the list of sources.
1482 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1483 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1484 * modifications in MSVC projects
1486 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1487 * As stated by the first lines of Test/ExceptionAndPython/README, it
1488 looks like we can move back to original usage of exception within
1489 src/gdcm* and hence remove the errno stuff that was introduced
1490 as a quick and dirty fixture of this problem (added to the TODO).
1491 * Doc/Doxyfile configuration file for Doxygen and corresponding
1492 README file for usage added.
1493 * Test/testWrite.cxx added. This new test comes from a split of
1494 test.cxx that is now reverted to its original purpous i.e.
1495 testing the proper parsing of a Dicom related file.
1496 testWrite.cxx concentrates on testing the IO part of gdcm.
1497 * Test/bug1.cxx (containing a bug on WIn32) added.
1498 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1499 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1500 whose purpose is to publish the content of the TagNames of the
1501 Dicom public dictionnary were not accessible without an
1502 instance of class gdcmHeader.
1503 - those methods are now static methods of gdcmDictSet and hence
1504 require no instances at all to be invocated.
1505 - within gdcmDictSet this change required to change some method
1506 to class methods (i.e. are now static) among which SetDictPath
1507 (renamed to BuildDictPath) and LoadDefaultPubDict.
1508 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1509 the above changes by calling the new method classes of gdcmDictSet.
1510 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1511 the above to be effective.
1512 * python/gdcmPython: in order to wrap properly the above changes
1513 for Python, swig version now needs to be > 1.3.17.
1514 * python/gdcmPython/Makefile fixed to adapt itself to new
1515 configure/make shema introduced by Johan Montagnat (thanks for the
1516 contribution). Alas this Makefile cannot be turned into a proper
1517 Makefile.am without some heavy changes in the configure.in
1518 (for python dectection).
1519 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1520 now avoids publishing the empty entries.
1522 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1523 * python/setup.py : bug fix concerning install under windows
1524 ExtraPath reused :-P
1525 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1527 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1528 * Dicts/dicomV3.dic : remove double spaces !!!
1529 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1530 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1533 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1535 method. Doxygenation.
1536 * src/gdcm.h clean up of JPR spurious comments.
1538 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1539 * python/distutilsSwigCPlusPlus.py now properly collects the
1540 shadow classes generated by "swig -c++" (gdcm.py in our case)
1541 when using "python setup.py install".
1542 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1543 reexports the working classes.
1544 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1545 by the classical C errno scheme. This is to prevent an obscure
1546 behavior of the python wrappers when importing wxPython.wx prior
1547 to gdcmPython (which ended up in an abort call). An illustration
1548 of this oddity can be found in the Test/ExceptionAndPython
1549 subdir (see the README file). This problem probably due to
1550 an combination of g++ and dynamic loading.
1551 * added Test/ExceptionAndPython (see above)
1553 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1554 * Changed the layout of the python part to avoid bloating main
1555 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1556 i.e. the distutils arsenal. All the python related stuff is
1557 again in a python subdir, but the package itself is now in
1559 * setup.py was cleaned up:
1560 - pythonIncludePath removed
1561 - python setup.py bdist target is now functional.
1562 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1563 collision with other packages). gdcmPython/demo/*.py changed
1566 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1567 * python subdir moved to gdcmPython (preparation of distutils packaging).
1568 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1569 distutils installer is operational.
1570 * - gdcmPython/__init__.py now properly loads the swig generated
1571 shadow classes (from gdcm.py).
1572 - gdcmPython/demo/*.py changed to import the package gdcmPython
1573 instead of gdcmPython/demo/load.py.
1574 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1576 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1577 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1578 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1579 entries within the associated public Dicom dictionary resp. the same
1580 information but sorted by the fourth field (PAT, IMG, DIR) of the
1582 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1583 are now in the "???" group.
1584 - python/gdcm.i changed accordingly,
1585 - python/demo/printGroupedPublicDict.py added, that gives an example
1586 of the above new functionalities in Python.
1588 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * src/gdcm.h, gdcmHeader.cxx:
1590 - historic references to glib's g_malloc and g_free (#defined)
1591 were definitively removed.
1592 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1593 * src/gdcmElValSet.cxx:
1594 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1595 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1596 - GetElValue(string) renamed to GetElValueByName.
1597 - Added GetElementByName(string).
1598 * src/gdcmHeader.cxx: added
1599 - GetPubElValRepByNumber(guint16, guint16)
1600 - GetPubElValRepByName(string)
1601 - GetShaElValRepByNumber(guint16, guint16)
1602 - GetShaElValRepByName(string)
1603 - GetShaElValByNumber(guint16, guint16)
1604 - GetShaElValRepByName(string)
1605 - GetElValRepByNumber(guint16, guint16)
1606 - GetElValRepByName(string)
1607 - GetElValByNumber(guint16, guint16)
1608 - GetElValRepByName(string)
1609 * Doc/requirements.txt added.
1611 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1612 * Test/Makefile building now depends on the one of libgdcm.so
1613 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1614 pixel data) aware which enables finding the address (offset) of
1615 the pixel data of JPEG encoded DICOM files. This leaves only a single
1616 file in the testSuite whose pixel data address (offset) is unknown.
1617 * python/testSuite.py changed accordingly.
1619 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1620 * VC++ has some strong limitations when working with the STL, as stated
1621 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1622 "Also note that some STL containers (map, set, queue, list, deque)
1623 cannot be exported. [...]
1624 Some STL classes contain nested classes. These classes can not
1626 This is caused by a designed limitation that once a template
1627 class is instantiated, it can not be re-instantiated and
1629 Since our usage of map<> is ubiquitous in gdcm, this "designed
1630 limitation" of VC++ is a pitfall.
1631 Hence the Python wrappers of gdcm cannot be incrementally linked
1632 against the c++ dynamic library. The dirty but only workaround is
1633 to forget about incremental link of dynamic libraries and to generate
1634 the Python wrappers library with the inclusions of the underlying C++
1636 The following modifications concern this matter on Win32/VC++:
1637 - wrapping python correct with standalone wrapped dll (don't use separate
1638 dll under windows !!!!)
1639 - python21_d debug mode enabled (ask Frog how to use it :-)
1640 - NO problem with having an STL member of class for example string in C++
1641 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1642 - Python test of dcmlib in Python is ok under windows on a large set
1644 * removed glib references
1645 * typedef's inserted in gdcm.i for correct swig type management
1647 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1648 * python/demo/*.py load.py extracted from test.py. Added explore.py
1649 that only displays required tags and testAll.py that parses all
1650 the files of the testsuite without using unittest.
1651 * python/testSuite.py other additional test on new files added.
1652 * Data/* new test files added accordingly to the testSuite.
1653 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1654 the vr in the file differs from the one of the dictionary.
1656 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1658 values, but limits itself to values which are below a user specified
1659 size (by default 1024 bytes).
1660 * python/gdcm.i : elements not loaded (because their size is above the
1661 user specified treshold) are exported with their TagKey as key of the
1662 python dictionary. This enables the testsuite to make some checks
1663 on the unloaded elements (since we have their offset and size).
1664 * python/testSuite.py
1665 - now tests for the existence and proper value of the pixel data
1666 - two new examples added.
1667 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1669 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1670 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1671 aware. See the strategy comments in gdcmHeader::FindeLength().
1672 * Test/test.cxx now accepts a filename as first argument.
1673 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1674 * python/testSuite.py changed to integrate test on above files.
1676 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1677 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1678 the vr was also RET.
1679 * python/testSuite.py more tests added.
1681 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1682 * python/testSuite.py unittest test suite added (uses Data)
1683 * Data/* dcm and acr files for the test suite.
1684 * glib dependance removed from un*x version. We now use ISO C99
1685 7.18 Integer types (see stdint.h)
1686 - python/Makefile, src/Makefile src/gdcm.h
1687 * src/ when an explicit vr (like dicom files) suddenly poped an
1688 implicit element we use to mark the underlying DictEntry of the
1689 concerned ElValue with "Implicit". This strategy was damageable
1690 too the public or provite dictionaries, since some of their vr
1691 would be changed. Since Header::FindLength heavily relies on the
1692 detection by Header::FindVR of falsely explicit elements, I
1693 added an extra ImplicitVr member to ElValue (boolean).
1694 The rest of the changes we the necessary adaptations.
1696 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1697 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1699 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1701 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1702 * Adaptation for porting to VC++:
1704 o forced to use std namespace (for string to be known)
1705 o all class use __declspec export style on WIN32
1706 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1707 (in stdlib.h on Win32 but in std:: for gcc)
1708 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1709 variable GDCM_DICT_PATH.
1710 * src/gdcmHeader.cxx verbose comments made discrete.
1712 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1713 * python/gdcm.i: added a typemap that converts a C++ hashing table
1714 to native Python dictionary.
1715 * python/demo/test.py:
1716 - now uses the native dictionary for exploration of gdcmHeader.
1717 - takes an optional filename argument (the file to parse).
1718 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1719 PubElVals hashing table.
1720 * Dicts/dicomV3.dic removed error prone trailing spaces.
1722 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1723 * Python wrapping process moved away from src/Makefile to
1724 newly created python/Makefile (as well as gdcm.i)
1725 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1726 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1727 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1728 from the environement variable GDCM_DICT_PATH (when existing).
1729 * src/gdcmDict::GetTag bug fix.
1731 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1732 * Straightforward temporary fixes for swig to build the python wrappers.
1733 src/Makefile now has a python working entry [by working we mean
1734 that we can import de shadow classes without errors].
1736 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1737 * hashtest.cxx removed (since allready in Test)
1738 * src/gdcmlib.h renamed to src/gdcm.h
1739 * src/dcm.i renamed to src/gdcm.i
1740 * src/Makefile prepared for python wrapping
1742 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1743 * src/gdcmHeader.cxx :
1744 - Parsing of header is now separated from loading of element values
1745 (see gdcmHeader::LoadElements).
1746 - general clean up of hopefully all file access (creation of
1747 ReadInt16 and ReadInt32)
1749 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1750 * src/gdcmHeader.cxx :
1751 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1753 - SetLgrElem renamed to SetLength
1754 - GetLgrElem renamed to GetLength
1755 - ~gdcmHeader() made virtual to pesky warning messages at compile.
1756 * src/gdcmElValSet.cxx fixed both GetElValue methods
1757 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
1758 due to IdoDude was cleaned out.
1760 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1761 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
1762 concentrates on finding the value representation (when it exists).
1763 RecupLgr now only finds the element value length, and it avoids
1764 returning the unecessary skL (skipped length).
1765 Also, offsetCourant was simply removed (with taille_fich) since
1766 it was redundant with the File position internals (by using
1767 ftell and fseek). This also made skL (see above in RecupLgr) usage
1769 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
1770 on the libido specificities which are handled through class
1772 * Test/implicit_vr.dcm dicom v3 in implicit value representation
1775 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1776 * Truckload of changes. Parsing of header is barely functional
1777 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
1779 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * src/gdcmHeader.cxx many addons of low level methods
1782 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1783 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
1784 and _IdDcmSWAP_LONG.
1786 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1787 * This corresponds to all the changes decided at the meeting of
1788 May 23 2002. Needless to say we are running late...