1 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 1. Finish merging JMR patch for writting DICOM from scratch
3 2. Fix -hopefully- bug with MONOCHROME and space vs null character
4 3. Use const ref when possible
5 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
7 6. CreateUniqueUID can now be called without parameter"
9 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
10 * ENH: Slightly bigger patch:
11 1. Getting toward full integration of JMR patch for writting dicom from scratch
12 2. Update Test to test part of this patch: CreateUniqueUID
13 3. File was not close properly in gdcmDict
14 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
15 5. Use of const ref instead of copy (speed issue)
16 6. Remove temporary (duplicate) string in TranslateToKey
17 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
18 8. Do not repeat virtual in subclasses
19 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
21 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
22 * Apply first patch toward better string comparison when dealing with broken
23 DICOM files. Essentially the string could be padded with a space instead
24 of a null character as defined by standard
26 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
28 because never used... and in the same time, that's remove some memory leaks
30 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmFile.cxx : now delete the PixelConvert instance.
32 * In examples and tests : change the type of image data variables from void*
33 to uint8_t*. Remmove all delete on image data variables
35 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
37 Verify the file pointer value before open the file, and if it's not null,
38 a verbose message is generated.
39 Close correctly the file when the file isn't considered dicom-like. The
40 correctly close is a call to CloseFile.
41 When closing the file pointer, test if its not null to close the file.
42 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
43 file. For an uncompressed image, the copied datas correspond in the least
44 case to the image size (calculated) or the image size specified in the
45 header. A verbose is generated if these two size mismatch
47 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
49 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
50 break under windows (with msvc6 compilation).
52 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
56 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * Bugs fix for the Windows build with VC6
58 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
59 needed (only for projects required VTK). If the VTK is included in all
60 projects, there is conflicts with the jpeg lib of vtk when compiling the
61 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
62 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
63 when compiling the gdcm_wrap.cxx file (created by the compilation of the
65 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
66 (like it's already made for the cout use). Otherwise, conflict with the
69 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
70 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
72 - comments on the DicomDir::Method related usage added.
73 - now that we use the namespace gdcm, a lot of internal classes do
74 NOT need to be wrapped anymore.
75 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
76 DicomDir::Method) new example added.
78 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
79 * Improve string manipulation. I now inforce the notion of 'DicomString'
80 A DicomString can contain as many \0 as they want
81 and it is *always* of even length.
82 We only support odd length for very rare case.
83 And in the near future this should be removed.
85 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
86 * /binary_write/ gdcm source. Now even on big endian we are writting
87 little endian. This should -heopfully- fix some tests
89 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
90 * Now the dictionary is compiled into gdcm lib. This is a default
91 behavior, thus any dic file specified is picked before failback to
92 the one comiled into lib
94 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
95 * Change internals for gdcmDict. Don't use any 'new' any more.
96 This should definitely solve any leak problem, and we should be
97 as fast as before, as long as don't modify too much the dictionary.
99 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
100 * STYLE: ivars should start with a capital letter.
101 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
102 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
104 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
105 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
106 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
107 new 2004 dictionaries added (thanks to JPR).
108 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
109 * CLEANUP_ROUND (15) for gdcmPixelConvert
110 - RLEFrame::NumberFragments is now of type unsigned int
111 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
112 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
115 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
116 * Initial work in gathering all transfer syntax accessors. clearly
117 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
118 ivars, but only one transfersyntax (class) ivar with equivalent method on
121 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
122 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
123 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
124 discussed (plus I didn't like having a 2000 lines patch not commited)
126 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
127 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
128 * CLEANUP_ROUND (14) for gdcmPixelConvert
129 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
130 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
131 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
133 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
134 anymore and hence avoids storing a copy of PixelConvert::Decompressed
135 into File::Pixel_Data.
137 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
138 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
139 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
140 * CLEANUP_ROUND (13) for gdcmPixelConvert
141 Substituted File::ParsePixelData() with PixelConvert::Print() new
143 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
144 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
145 method to those classes.
146 - src/gdcmFile.[cxx|h]:
147 -- Added a ::Print() method.
148 -- PixelConverter is now a reference instead of a member.
149 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
150 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
152 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
153 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
154 collaboration diagram and inheritance diagram should be generated with
156 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
157 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
158 pointlessly wrapped (see
159 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
160 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
161 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
162 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
163 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
164 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
165 -- File::Initialise: PixelConverter setup moved away to
166 PixelConverter::GrabInformationsFromHeader()
167 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
168 interpretation moved away to PixelConverter::BuildRGBImage()
170 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
171 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
172 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
174 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
175 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
176 displayed on Win32 when a brutal abort() occurs (because of uncatched
177 exception). See TODO new entry of this commit for more on this.
178 * TODO added new entry.
179 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
180 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
181 - HandleColor is no longer called from gdcmFile.cxx
182 - gdcmPixelConvert.cxx clean up on method arguments and internal
183 variable names for semantical coherence.
185 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
186 * Finished lossless transition, not only do we now read all lossless jpeg
187 images, without the need of the Cornwell lib, but we do read them properly now
188 * To reduce code (well to avoid code duplication), I defined a common place
189 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
190 redefine symbols. This is not prefect but this the best solution I found for a
191 compilation time jpeg option.
193 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
194 * Update jpeg ijg lib to support lossless jpeg implementation
195 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
197 * Also added a special copyright for dcmtk since we use their bugfixes.
200 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
201 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
202 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
203 matters, as stated in warning note at begining of %include section).
204 * src/gdcmDicomDir*.[cxx|h]: coding style
205 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
206 * src/gdcmJpeg8.cxx: doxygen fix.
207 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
208 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
209 from File:: to PixelConvert::.
211 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
212 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
213 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
214 - more code moved away from File:: to PixelConvert::
215 - fat setup of PixelConverter set in place in File::Initialise.
217 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
218 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
219 namespace at the file system level. So now you should convert your examples
221 gdcmHeader -> gdcm::Header
222 It would be nice if people keep in mind to no open the namespace, since it
223 allows compilation on broken plateform which were defining common symbol in
224 the standart namespace (like LP, Unknown ...)
226 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
227 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
228 The JPEG fragments are now parsed at the same stage than the RLE
229 information. All code related to JPEG is now in gdcmPixelConvert:
230 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
231 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
232 export a gdcmFile:: method. Those are simply global functions
233 (for the time being this is better than having them attach to
234 either gdcmFile:: or gdcmPixelConvert::).
235 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
236 and stores the result in a gdcmJPEGFragmentsInfo.
237 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
238 code (among other stuff) moved away from gdcmFile:; to
241 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
242 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
243 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
244 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
245 clean up of RLE related code.
246 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
247 - src/gdcmRLE.cxx removed
248 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
249 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
250 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
251 * CLEANUP_ROUND (9) for gdcmPixelConvert
252 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
253 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
254 away from gdcmFile:: to gdcmPixelConvert::.
256 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
257 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
258 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
259 This is because Parse7Fe0 used to parse the pixels to compute the
260 length. This task was passed over to FindDocEntryLengthOB() a long
261 time ago, EXCEPT I had forgotten the OW case...
262 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
263 we just recylce the code for parsing RLE fragments and computing
265 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
266 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
267 with the retired Parse7Fe0().
268 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
269 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
271 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
272 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
273 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
274 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
275 - src/CMakeLists.txt: alphabetic order reodering + new entries.
276 * CLEANUP_ROUND (4) for gdcmPixelConvert
277 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
278 to return an unused length.
280 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
281 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
282 this should be cleanner from the plane view. The iostream are erally a pain
283 to use to do simple stuff.
285 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
286 * Redo the compilation of the ijg jpeg library. Now only one source is
287 necesseray. No need to rename file by hand what so ever. CMake handle the
288 copying of the file within different directory, configure header file to
289 modify some symbol. The only addition made to ijg wasd a mangle table so
290 that symbol are different wether we are within 8bits or 12bits.
292 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
293 * Added documentation of vtkgdcmReader on Website:
294 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
295 with it's binary name).
296 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
297 the Website to be more complete.
298 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
299 doxygenated documentation.
300 - Doc/DoxyVtkGdcmReaderExamples.txt added
301 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
302 DoxyVtkGdmReaderExamples.html )
303 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
304 * CLEANUP_ROUND (3) for gdcmPixelConvert
305 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
307 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
308 * CLEANUP_ROUND (2) for gdcmPixelConvert
309 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
311 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
312 * CLEANUP_ROUND for gdcmPixelConvert:
313 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
314 - src/gdcmPixelStuff[h|cxx] removed
315 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
316 - src/CMakeLists.txt changed accordingly
318 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
319 gdcmVersion.py moved to newly created ATTIC related
320 gdcmPython/SetupOldies/ directory.
321 * Autotools clean up:
322 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
323 - autogen.sh configure.in acinclude.m4 python.m4 removed
325 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
326 * src/*.cxx *.h Reference to License.htm fixed to License.html.
327 * Doc/CMakeLists.txt, doxygen.config.in: fix.
328 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
330 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
331 * TODO updated with Mathieu suggestions. I proposed a template for
332 describing TODO entries and used it for new entries.
333 * Added Doc/Website/CodingStyle.html, Developpers.html,
334 DeveloppersPython.html, GdcmDataCvs.html and
335 DownloadVersion0_1.html, DownloadVersion0_3.html.
336 * Some Doc/*.txt Doxygen files (which do not really concern the
337 documentation itself, but the website) moved to html and
338 placed in directory Doc/Website:
339 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
340 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
341 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
342 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
343 * CMakeLists.txt changed accordingly.
344 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
345 DeveloppersPython.html
346 * INSTALL nows refers to Doc/Website/Installation.html
348 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
349 * Added Doc/Website directory, that contains a first raw version
352 2004-09-23 Jean-Pierre Roux
353 * FIX In order not to be poluted any longer by casting problems,
354 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
355 we can now delete[] it safely
356 * VoidArea is now called BinArea (less confusing name),
357 and all the methods called ...VoidArea... are now ... BinArea...
358 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
360 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
361 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
362 clear) TagHT, which is an inherited member of gdcmElementSet. It is
363 up to the destructor of gdcmElementSet to clean up TagHt and it's
366 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
367 * Test/CMakeLists.txt: update to follow gdcmData renamings.
368 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
370 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
371 * ENH: added some utility method that builds a flat dictionnary
372 holding all the Dicom entries contained in the recursive structure
373 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
375 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
376 BuildFlatHashTable() that build a flat dictionary.
377 - src/gdcmElementSet.h: added a new private GetTag() accessor.
378 gdcmDocument is now a friend of gdcmElementSet.
379 - src/gdcmElementSet.cxx: clean up.
380 - Example/FlatHashTablePrint.cxx added.
381 - Example/CmakeLists.txt changed accordingly
383 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
385 moved away from gdcmDocEntrySet (since this class is an abstract class
386 acting like an interface). SQDepthLevel and BaseTagKey are now
388 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
389 and associated accessors. Doxygenation of the class.
390 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
392 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
393 Use SQDepthLevel accessor instead. ::Print() adapted.
394 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
395 - src/gdcmDocument.cxx changed accordingly.
397 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
398 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
399 - The following is the doxygen comment of the typedef declaration
400 of gdcmagKey in src/gdcmCommon.h:
401 gdcmTagKey is made to old an "universal" (as in URL, Universal
402 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
403 A dicom tag allways has a group and an element, but a set of tags
404 embeded in various (optionally nested) sequences and sharing
405 the same group and element all share the same (group, element)
406 "identifier". Hence the (group, element) cannot be used as an
407 identifier (in gdcm we shall refer to a "TagKey") of a tag.
408 In order to construct a proper tag identifier (i.e. a key) we
409 consider the following definition of a TagKey:
410 - let Group, Element be the string representation of the
411 group and element dicom tag members,
412 - let ItemNumber be the string representation of the integer
413 index of the considered item number of a sequence,
414 Let the key of a tag embeded in a sequence, noted SeqTag, be
416 /ItemNumber#Group|Element
417 where "/", "#" and "|" are characters acting as separators.
418 Then the general form of a gdcmTagKey is given by:
419 Group|Element<SeqTag>
420 where <SeqTag> means NO or many instances of SeqTag.
421 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
424 but the gdcmTagKey of a tag "embeded" is the first item of
425 a sequence, itself nested in the third item of a sequence is the
427 0004|1220/2#0008|0082/0#0008|0090
428 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
429 order to hold the new sequence compatible key. Previously, the
430 GetKey() method would look in the underlying gdcmDictEntry.
431 - src/gdcmDocEntry.cxx:
432 -- constructor now copies the underlying DictEntry key, in the local
434 -- ::Print: displays the member Key, instead of the (group, element).
435 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
436 - src/gdcmDocEntrySet.h:xi
437 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
438 -- now has a new BaseTagKey member.
440 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
441 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
443 This poses the problem with the semantics of the following lines
444 LoadEntryVoidArea(0x0028,0x1201); // R LUT
445 LoadEntryVoidArea(0x0028,0x1202); // G LUT
446 LoadEntryVoidArea(0x0028,0x1203); // B LUT
447 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
448 to the long FIXME note for what the problem is. Nevertheless in
449 order to get things working the dicom dictionary was altered !
450 Please fix things urgently...
451 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
452 information), see above note on moving the member VoidArea. Nevertheless
453 the following entries previously correctly set as US are now inproperly
455 0028 1201 OW IMG Red Palette Color Lookup Table Data
456 0028 1202 OW IMG Green Palette Color Lookup Table Data
457 0028 1203 OW IMG Blue Palette Color Lookup Table Data
458 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
459 of gdcmDocEntry moved to gdcmSeqEntry.
460 * src/gdcmSeqEntry.cxx: STYLE.
462 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
463 * Test/TestAllEntryVerify.cxx minor fix and added comments.
465 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
466 * gdcmPython/testSuite.py: all the test suite in python is now moved
467 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
468 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
469 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
471 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
473 to avoid inclusion recursion until STL is reached.
474 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
475 mecanism. errno.h is not included in gdcm anymore.
476 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
477 (gdcmFormatError now inherits from gdcmFormatUnexpected).
479 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
480 gdcmData/TestAllEntryVerifyReference.txt
481 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
482 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
483 exception_on_error parameter.
484 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
485 - vtk/vtkGdcmReader.cxx changed accordingly,
486 - Example/*.cxx and Test/*.cxx changed accordingly.
488 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
489 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
490 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
491 enable_sequences removed from gdcmHeader constructor and dependencies.
492 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
493 * gdcmPython/demo/PrintHeader.py: dummy fix.
494 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
495 skip_shadow removed from gdcmHeader constructor and dependencies.
496 * Example/*.cxx and Test/*.cxx changed accordingly.
498 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
499 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
500 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
502 2004-07-21 Jean-Pierre Roux
503 * FIX Now, Parsing and Printing a DICOMDIR do work!
504 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
506 2004-07-20 Jean-Pierre Roux
507 * FIX Some brain damaged headers have Zero-Lenght fields
508 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
510 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
511 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
512 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
513 variable (instance of gdcmDebug) by a definition macro, and the instance
514 is now in static in the gdcmDebug class
515 * src/gdcmSQItem.h : (FIXME) remove an undefined method
516 * Test/PrintAllDocument.cxx : bug fix in the result of the test
518 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
519 * WARNING: ctest now depends more tightly on gdcmData. You should
520 check out gdcmData properly for things to run smoothly...
521 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
522 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
523 we need the pixels not be loaded in order to use the ValEntry
524 that displays position and size).
525 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
526 This is a C++ based equivalent of gdcmPython/testSuite.py that should
527 be deprecated. If you have any doubts about the advantages of a
528 modern scripting language (read Python) versus grass root C++ (i.e.
529 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
530 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
531 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
532 Anyhow, consider documenting the gdcmData images in
533 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
535 * Test/CMakeLists.txt:
536 - now uses TestAllEntryVerify.cxx
537 - specific comments on oldACR00001.ima (now renamed in gdcmData
538 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
539 gdcmData/TestAllEntryVerifyReference.txt
542 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * src/*.[h|cxx] : typedef clean up
544 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
545 - TagKey renamed to gdcmTagKey (for external usage)
546 - VRKey renamed to gdcmVRKey (for external usage)
547 - removal of typedef duplication.
548 - Removed all unecessary inline keyword from class inline definitions.
549 - Some method|function(void) declarations replaced with method|function().
550 * src/jpeg/libijg12/jdhuff12.c:
551 - printf polluting ctest removed.
552 - TAB removal for comminting
554 - TestAllReadCompareDicom.cxx: added a test that compares all the
555 images in gdcmDataImages.h with corresponding images in
556 gdcmData/BaselineDicom/. When baseline images are not present
557 this test creates them.
558 Note: we need to validate each reference image, but before that
559 I'd like to rename them with a more explicit name...
560 - CMakeLists.txt: changed accordingly.
561 * Example/*.cxx: examples now only include gdcm.h (as opposed to
562 including each header needed).
564 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
565 * Test/*.cxx and Example/*.cxx: moved some examples away from the
566 test suite to the Example directory. Are concerned:
571 - TestWriteSimple.cxx
572 * Test/CMakeLists.txt: added some comments on reasons for black listing
573 image gdcmData/oldACR00001.ima
575 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
576 * Test/CmakeList.txt: removed the following from black list (to be coherent
577 with removal from gdcmData):
578 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
579 - gdcm-MR-PHILIPS-16.dcm
581 Added the following because after last cvs update, they cause
582 ctest -R TestReadWriteReadCompare
584 - gdcm-MR-SIEMENS-16-1.acr
586 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
587 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
588 new comments in this file) we temporarily (sigh) move to a weaker
590 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
591 we don't need to black list the following images anymore:
592 - 8BitsUncompressedColor.dcm
594 - US-PAL-8-10x-echo.dcm
595 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
596 fixes and the beautified code ;-)
597 This fixes the bug introduced in version 1.42 (when beautifying)
598 that made the parsing of 8BitsRunLengthColor.dcm unproper.
599 Note: ctest was blind to this bug (this means we need to still
600 improve the test suite). The bug could be detected by using
601 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
603 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
604 and by displaying the (garbage) produced file temp.XDCM...
606 2004-06-29 Jean-Pierre Roux
607 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
608 - replace by uggly but working old code :-(
609 A lot of things should be OK again.
610 It's really urgent to have a test suite that *tests*,
611 to prevent Frog's beautifying sessions to break all the stuff
612 (twice, withing a fortnigh ...)
614 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
615 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
616 redundancy) to added Test/TestReadWriteReadCompare.cxx
617 * Test/CmakeList.txt: because the compare test of
618 Test/TestReadWriteReadCompare.cxx fails, the following images are
619 black listed: - 8BitsUncompressedColor.dcm
621 - US-PAL-8-10x-echo.dcm
622 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
623 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
624 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
625 and ad-hoc kludge. This kludge is now removed, and on encountering
626 such an image (OB field brain damaged) we set errno. Then in
627 ::FindDocLength() we "fix" the length as being ALL what remains
628 in the file (until EOF). We then proceed, hoping for the best...
629 This fixes a SegFault in ShowDicom when trying to write such an
631 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
632 (because TestWriteRead breaks on it, after a non conformal commit?).
633 ctest now runs properly, except for MakeDicomDir (which was allways
634 broken) and the Python related stuff (still not fixed).
636 2004-06-24 Jean-Pierre Roux
637 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
638 FIX : Test/TestReadWrite now iterates on all the file names
639 (instead of infinite loop)
640 ENH : Test/TestWriteRead now iterates on all the file names
642 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
645 2004-06-24 Jean-Pierre Roux
646 FIX : - now Write drops LUT Descriptors and LUTs (if any)
647 when SamplesPerPixel =3
648 - now Write is no longer confused by
649 'BitsAllocated = 12" and 'BitsStored=12"
650 - "UN" value representation Elements are now written correctly
651 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
652 ENH : - now gdcmHeader has its own Write methods
653 (in order to split the job that has not to be done
656 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
658 loop on the same image until memory went out.
659 Note: this means we still have gobs of memory loss in PrintDocument
660 * src/gdcmDocument.cxx: fixes problem on parsing on file
661 gdcmData/16BitsJpegLosslessGrayScale.dcm.
663 2004-06-24 Jean-Pierre Roux
664 FIX : Write - All the Sequences and Sequence Item are now written
665 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
666 is added a the end, when necessary.
667 - A lot of brain-damaged images, that were read correctly are
668 now written correctly
669 - length compatible BinEntry are now loaded correctly
670 (even for odd groups)
671 Note : only Explicit Value Representation was checked.
672 (question : is implicit VR really necessary for gdcm ?)
674 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
675 * DEVELOPPER: added a proposition of coding style.
676 * src/gdcmDocEntry.h: removed every inline declaration (for test of
679 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
681 Use the gdcmDocEntry::Print() and Write() instead.
682 * src/gdcmDocument.cxx: bug fix.
684 2004-06-22 Jean-Pierre Roux
685 FIX : gdcmDocument.cxx
686 - Now we do recognize the JpegLossLess format (there was a misstyping in
687 code 'beautyfication' :-(
688 - Now we automaticaticaly load the Luts, if any
690 2004-06-22 Jean-Pierre Roux
691 In order : to write Sequences, whatever their imbrication level,
692 : to allow user to create his own Sequences
693 a lot of modif where necessary (adding, moving, or virtualising methods)
695 WARNING : save your own sources *before* cvs up !
698 ADD virtual void Write(FILE *fp, FileType filetype);
701 ADD virtual void Write(FILE *fp, FileType filetype);
702 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
705 ADD virtual void Write (FILE *fp, FileType filetype)=0;
706 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
707 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
708 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
709 ADD std::string GetEntryByName(TagName name);
710 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
712 std::string vr = "unkn",
713 std::string fourth = "unkn",
714 std::string name = "unkn");
715 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
716 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
717 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
718 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
719 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
720 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
721 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
722 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
725 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
726 ADD virtual std::string GetEntryByName (TagName tagName);
727 ADD virtual std::string GetEntryVRByName (TagName tagName);
728 REM virtual bool Write(FILE *, FileType);
729 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
730 FILE *_fp, FileType type);
731 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
732 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
733 REM virtual bool WriteEntries(FILE *_fp,FileType type);
734 REM virtual std::string GetEntryByName (std::string tagName);
735 REM virtual std::string GetEntryVRByName (std::string tagName);
736 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
737 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
738 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
740 std::string vr = "unkn",
741 std::string fourth = "unkn",
742 std::string name = "unkn");
743 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
744 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
745 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
746 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
749 ADD virtual void Write(FILE *fp, FileType filetype);
752 ADD virtual void Write(FILE *fp,FileType filetype);
755 ADD virtual void Write(FILE *fp, FileType filetype);
756 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
757 REM std::string GetEntryByNumber(guint16 group, guint16 element);
758 REM std::string GetEntryByName(TagName name);
761 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
763 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
764 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
765 The default constructor invoked by the line
766 gdcmHeader *f1 = new gdcmHeader( header );
767 was gdcmHeader::gdcmHeader(bool) instead of the expected
768 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
769 Hence the parsing wasn't executed... See also below.
770 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
771 as explicit constructor didn't do the trick to fix the above problem.
772 Could anyone explain why ?
773 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
774 properly calls gdcmValEntry::Print() (that was weed out from
775 code related to gdcmBinEntry).
777 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * In order to fix memory leaks:
779 - Test/TestWriteSimple.cxx: added cleaning of free store through
781 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
782 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
783 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
784 (through the call to ::AddDicomDirMeta()) or the destructor
785 would crash when deleting uninitialized ::metaElems].
786 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
787 - src/gdcmDocument.cxx:
788 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
790 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
791 was causing memory leaks.
792 - src/gdcmSQItem.cxx:
793 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
794 cleanly handled with polymophism: sorry but my milage is low).
795 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
796 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
797 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
798 This avoids SegFaulting.
799 - src/gdcmSQItem.h: coding style.
801 - Test/TestWriteSimple still severely sucks. The output image content
802 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
803 damaged when displayed with vtkgdcmViewer.
804 - on memory leaks: TestWriteSimple leaks really less (see entry
805 of 2004-06-18 in Changelog file for the call to valgrind).
806 - on segfaults: ctest now passes all the tests but one (no more
808 * Erroneous leading white fix:
809 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
810 white[s] (as opposed to from >> xxx, that removes it [them].
811 - src/gdcmTS.cxx: ditto.
812 - gdcmPython/testSuite.py: dirty related kludge removed.
813 * src/*: remaining references to gdcmParser removed.
814 * src/*[cxx|h]: added copy[way]left header.
817 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
818 * In order to fix writing of dicom files:
819 - Test/TestWriteSimple.cxx: a simpler example of writing.
820 - Test/CMakeLists.txt changed accordingly.
821 - src/gdcmDocument.cxx:
822 -- The destructor now recursilvely removes potential sequences.
823 -- Bug fix in ::IsJPEG2000()
824 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
825 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
827 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
828 to only declared) and build on top of
829 ::GetDocEntryByNumber(guint16, guint16).
830 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
831 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
832 for usage in destructor and treatement of promotion in
833 ::ReplaceOrCreateByNumber().
834 - src/gdcmSQItem.cxx: destructor should better handle his job.
835 Test/TestWriteSimple now runs (or at least it DOES something).
836 * We can now start hutting memory links. A good starting point is:
837 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
838 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
839 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
841 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
842 * Valgrind note: after Mathieu Malaterre teached me how to read
843 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
845 Using gcc, you can force the STL to use malloc and to free memory as
846 soon as possible by globally disabling memory caching.
847 With 3.2.2 and later, you should export the environment variable
848 GLIBCPP_FORCE_NEW before running your program.
849 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
850 simply vanish (it is still not clear to me, whether this means that
851 STL std::string leaks or if valgrind believes it leaks...).
852 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
853 running bin/gdcmTests makeDicomDir):
854 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
855 - Test/makeDicomDir.cxx now properly traps empty lists and returns
857 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
858 SegFaulting (I drowned in DicomDir related code when trying to
859 understand why the list is empty...).
860 * src/gdcmDocument.h: first BSD license header try.
861 * Doc/License.txt added.
863 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * src/gdcmDocument.[h|cxx]:
865 - Clean up of the Transfer related predicates. They are now all based
866 on new method isGivenTransferSyntax, that (should) handle properly
868 - general clean up, simplification, and coding style.
869 - Specific clean up of Parse7FE0() (umproperly named actually).
870 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
872 2004-06-14 Jean-Pierre Roux
874 - fix the display of Sequence Delimitor (SQDepthLevel pb)
875 - fix the display of SQItem ordinal number
876 - add the GetSQItemByOrdinalNumber method
877 - remove some useless never written private methods
879 2004-06-14 Jean-Pierre Roux
881 - adding a constructor taking a gdcmDocEntry as an input param
882 - ReplaceOrCreateByNumber now returns :
883 a gdcmBinEntry * if a Binary (void *) value is passed as a param
884 a gdcmValEntry * if a string value is passed as a param
886 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
887 according to the param type (no longer sets a gdcmDocEntry)
888 - GetValEntryByNumber, GetBinEntryByNumber added
889 - NewValEntryByNumber and NewBinEntryByNumber added
891 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
893 - GetSQItemNumber and SetSQItemNumber added, to provide
894 a (relative) Item identier inside a given Sequence
895 \warning : some pb remaining around this number
897 - AddEntry now takes the Item Number as a param
899 - adding a constructor taking a gdcmDocEntry as an input param
901 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
902 * Memory leak hunt with the following command:
903 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
904 --show-reachable=yes gdcmTests PrintDocument
905 It looks like many (all?) leaks are due to the STL (or a bad usage
906 of the STL. The lines producing the leaks now have a comment with
907 a "MEMORY LEAK" tag: you can retrieve them with
908 grep "MEMORY LEAK" src/*
909 Here are two typical examples which I can't help fixing:
914 char * test = "babo";
915 name = test; //// <--- valgrind detects 960 bytes lost in
916 //// call to std::string::operator=(char const*)
917 name.clear(); //// Doesn't help !
925 std::cout << "Type a bunch of characters followed by RETURN: ";
926 getline(std::cin, line); //// <--- valgrind dectects a loss
927 //// of 1320 bytes in call to
928 /// std::basic_istream<>& std::getline<>
934 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
935 * src/gdcmHeader.[cxx|h]:
936 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
937 and related, moved away to gdcmDocument.
938 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
939 the corresponding protected accessors of inherited class
940 gdcmDocument, removed ! As a consequence gdcmFile had to be
941 declared friend of class gdcmDocument (see below).
942 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
943 - Clean up of undefined or unused methods.
944 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
945 account the changes to gdcmHeader.h).
946 * src/gdcmDocument.h:
947 - gdcmFile is now a friend class (in order to take into account the
948 changes to gdcmHeader.h).
949 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
950 (see changes to gdcmHeader.h).
951 - Accessors (reading on the form GetEntry*) are now public.
952 - Clean up of undefined or unused methods.
953 * src/gdcmDocument.cxx:
954 - adaptation to changes to gdcmDocument.h
955 - ::OpenFile now writes a verbose message when file cannot be opened.
956 - some std::string properly set to VRKey
957 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
958 references to gdcmDocument.
959 * Test/TestFindTags.cxx: changed accordingly to above changes.
960 * gdcmPython/testSuite.py: adapted to renaming of acr files in
961 cvs repository gdcmData.
963 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
965 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
966 conflicts with gdcmValEntry::voidArea.
967 * src/gdcmValEntry.cxx: unmatching comment wiped out.
968 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
969 Value representation between StringRepresentable and BinaryRepresentable.
970 * src/gdcmDocument.cxx:
971 - method ParseDES: proper indentation restored and usage of
972 gdcmVR::IsVROfGdcmStringRepresentable wired in.
973 - method LoadDocEntry: the fingerprint left in the SetValue() of
974 unloaded entries (length > MaxSizeLoadEntry) had curiously been
975 removed. Reverting to previous code segment with the proper
976 dynamic_cast< gdcmValEntry* >.
977 Note: this was (partially) breaking the python test suite
978 (gdcmPython/testSuite.py) that made usage of the above
979 fingerprint to check presence of "Pixel Data".
980 * src/gdcmDocEntry.h: coding style.
981 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
982 now taken into account.
983 * gdcmPython/gdcm.i: adaptation to the new internal representation
984 of gdcm (exit gdcmParser, hello gdcmDocument).
985 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
987 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
988 anymore, but instead prints the loaded Python dictionary.
989 * .... alas, the python testSuite is still broken.
991 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
992 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
994 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
995 * src/gdcmUtil.h : export methods
997 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
998 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1000 * Initial addition of automatic python testing
1001 * Initial addition of automatic image comparison
1003 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1004 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1005 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1007 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1008 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1009 * Test/ShowDicom.cxx : bug fix for msvc compilation
1010 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1012 2004-05-04 Jean-Pierre Roux
1013 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1014 new concepts (and new classes) :
1015 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1016 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1017 - Sequence Doc Entries (gdcmSeqEntries)
1018 a Sequence is composed of Items.
1019 Each item is a set of Doc Entries (this is recursive)
1020 The non uniqueness of the 'Dicom tag' is due to this recursivity
1021 (never taken into account)
1022 Our unability to add a new 'entry' in the header
1023 at the proper location (neither in the H-Table (map or multimap),
1024 nor in the Chained List is also due to this recursivity.
1025 Don't try, right now, to use/modify/compile these new sources :
1026 nothing is finished.
1027 We just commit all the stuff, 'as is', in order not to loose it.
1029 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1030 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1032 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1033 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1034 file prefix (SetFilePrefix)
1036 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1037 * Add a new test: ShowDicom, for now this is just the c++ version of
1038 checkRead.sh, later it will be able to compare the image read against a
1040 * Replace the DEBUG on the stack with a global entry in cmake interface:
1041 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1043 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1044 * Add an example subdir, with a real example on how to read + write a
1047 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1049 * Doc/CMakeLists.txt: the main page is now properly differentiated
1050 between the developper and user version.
1051 * Doc/doxygen.config.in: dropped search related obsolete flags
1052 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1054 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1055 * DEVELOPPER: added some helpfull comments for compile/test/install
1058 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1059 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1060 src directory, now generated in the build dir.
1061 2. Tests as mentionned smarter
1063 4. Add a new method in gdcmDict that return the PubDict by name
1064 this is interesting for 3rd party lib like ITK,
1065 where we could set the institution name / patient name...
1067 * ENH: 1. Now the test suite is working for real
1068 2. All binaries are now output in the gdcm-bin directory
1069 (this was not true before)
1071 2004-04-28 Jean-Pierre Roux
1072 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1073 SeQuence indented printing of Dicom Header.
1074 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1075 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1076 Computation of SQDepthLevel is now part of gdcmHeader constructor
1077 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1078 tree-like structure of a Dicom Header.
1079 * FIX Test code cleaning
1081 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1082 * ENH: Adding automatic testing
1083 1. Need a DartConfig.cmake to submit to public
1084 2. Add a test driver gdcmTest.cxx
1085 3. gdcmTestMain, an helper for the main test driver gdcmTest
1086 4. Files in Test don't have a main anymore, this becomes interesting
1087 when we add more and more tests, thus dsw don't have to load
1089 * ENH: Adding a GDCM_DATA_ROOT for testing
1090 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1091 one file instead of seven + some small cleanup
1093 2004-04-22 Jean-Pierre Roux
1094 * ENH Minor changes to the Print() methods.
1095 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1096 Header printing. Example given with :
1097 > PrintHeader fileName 2 new
1098 (SQ based tree-like structure still to be done for the Header ...)
1100 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1101 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1102 1. I have added some unsigned where needed
1103 2. Some function parameter not used -> (void)
1104 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1105 4. g++ don't like character '\' in comment
1106 5. #define jpeg_create_decompress jCreaDecompress
1107 this really need to be fixed
1108 6. virtualize destructor of gdcmObject ... leakage
1109 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1110 this also really need to be fixed
1111 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1112 remove compression file
1113 (as we only do decompression, right ?)
1114 * ENH: Change malloc/calloc/free with c++ equivalent
1116 2004-04-21 Jean-Pierre Roux
1117 * FIX gdcmHeaderHelper::GetXSpacing
1118 when a single value is found (bug ?), xpacing is now
1119 defaulted to yspacing
1121 2004-04-19 Jean-Pierre Roux
1122 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1123 * ENH add parameters :
1124 bool exception_on_error = false,
1125 bool enable_sequences = false,
1126 bool ignore_shadow = false
1127 to the gdcmFile constructors to be full gdcmParser compliant
1128 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1129 to allow reading of PAPYRUS 3.0 files
1131 2004-04-06 Jean-Pierre Roux
1132 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1134 2004-04-02 Jean-Pierre Roux
1135 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1136 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1137 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1139 2004-03-30 Jean-Pierre Roux
1140 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1141 for ACR file, written out as DICOM files (hope so...)
1143 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1145 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1146 moved to base class gdcmParser and only the specialisation is kept
1148 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1149 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1150 already does the job.
1151 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1152 (to be consistent with gdcmParser::WriteEntries).
1154 2004-03-30 Benoit Regrain
1155 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1156 upate of the object's instance. It's passed to 2 in the unfavorable
1157 case : one in the ExecuteInformation, one in the ExecuteData
1159 2004-03-29 Jean-Pierre Roux
1160 * ENH : Check on file type to be written moved
1161 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1162 * FIX : gdcmObject::ResetBoundaries now stops properly
1163 when end-of-list is reached
1164 : gdcmVersion modified (as Benoit Regrain asked)
1166 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1167 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1168 * src/gdcmUtil.cxx: added forgotten iostream include.
1169 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1170 equivalent to ExplicitVR in existing code).
1172 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1173 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1174 now contains all the gdcmGlobal related code.
1175 * minor coding style and doxygenation changes.
1177 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1178 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1179 now contains all the Debug related code.
1180 * minor clean-up of includes in src/*.cxx
1181 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1182 CreateCleanString) removed.
1183 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1184 * Doc/DoxyMainPageUser.txt added.
1185 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1186 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1187 src/gdcmDirList.cxx)
1189 2004-03-24 Jean-Pierre Roux
1190 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1192 2004-03-23 Jean-Pierre Roux
1193 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1194 big endian made volumes
1195 * ENH Now gdcmParser constructor and destructor are protected to forbid
1196 end user to instanciate class gdcmParser
1197 (only gdcmHeader and gdcmDicomDir are meaningfull)
1199 2004-03-22 Benoit Regrain
1200 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1201 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1202 gdcmSerie to gdcmDicomDirSerie
1204 2004-03-19 Jean-Pierre Roux
1205 * ENH Now the tree-like structure describing a DICOMDIR comming from
1206 an already existing DICOMDIR file is consistent with
1207 the home-made tree-like structure build ex-nihilo
1208 or build from the files held (recursively) in a Directory
1209 functions gdcmDicomDir::CheckBoundaries()
1210 gdcmObject::SetBoundaries() added
1212 2004-03-17 Jean-Pierre Roux
1213 * REM (Eric Boix bug) : removal of meaningless
1214 gdcmDicomDirImage::NewImage function.
1215 * FIX now file names and directory name are written properly in the
1217 * FIX now gdcmDicomDir constructor may be call without any trick
1220 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1221 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1222 of gdcmDicomDirImage::NewImage as empty function.
1224 2004-02-28 Jean-Pierre Roux
1225 * ENH add gdcmDicomDir:NewPatient
1226 add gdcmDicomDirPatient:NewStudy
1227 add gdcmDicomDirStudy:NewSerie
1228 add gdcmDicomDirSerie:NewImage
1229 to allow making gdcDicomDir object.
1230 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1231 (as opposite to the gdcmHeader chained list)
1233 2004-02-11 Benoit Regrain
1234 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1235 when using from python
1237 2004-02-10 Benoit Regrain
1238 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1239 * FIX : in gdcmDicomDir when the directory is empty
1240 * ENH : add callback and methods to get the progression of dicomDir
1243 2004-02-06 Jean-Pierre Roux
1244 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1245 - GDCM_META added to gdcmDicomDirType
1246 - class gdcmMeta created
1247 * ENH : - A brief summary is now displayed at the beginning of
1248 'testDicomDir' to help disaster magnitude estimation
1249 * REM : Now useless Test/explDICOMDIR.cxx
1251 2004-02-05 Benoit Regrain
1252 * ENH : add methods in gdcmObject to get the hash table or the list of
1254 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1255 * FIX : wrapping python for TagHeaderEntryHT
1257 2004-02-04 Benoit Regrain
1258 * FIX : even length for some strings when writting the dicom dir
1259 * FIX : sort the images in the dicom dir
1260 * FIX : Bug fix for python use of dicom dir
1261 * ADD : a python demo
1263 2004-02-04 Jean-Pierre Roux
1264 * FIX : Final solution (?) for icone embedded images
1265 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1266 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1267 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1268 gdcmData/gdcm-MR-SIEMENS-16.acr1
1269 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1270 to make full checking easier
1272 2004-02-04 Benoit Regrain
1273 * FIX : WriteEntries : coding style & logic in parameters
1274 * FIX : Set the elements to create the DicomDir in a dictionary file
1276 2004-02-03 Benoit Regrain
1277 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1278 * gdcmDicomDir : add the load of directory
1279 * Bug fix and print add-on
1281 2004-02-03 Jean-Pierre Roux
1282 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1283 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1284 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1285 * FIX gdcmParser.cxx : 'group length' elements are now considered
1286 as integers, even for shadow groups, when file is Implicit VR
1288 2004-02-02 Jean-Pierre Roux
1289 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1291 of the last synonym :-(
1292 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1294 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1295 * FIX taking into account the possible 7fe0,0010 multiplicity
1296 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1297 to allow removal of references to 7fe0,0010, to deal with
1298 ACR-NEMA images, when 0028,0200 is meaningfull
1300 2004-01-31 Jean-Pierre Roux
1301 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1302 no longer writes 'Un' on disk
1303 * FIX SQ elements with actual length are now dealt with corectly
1304 * FIX gdcmFile::WriteBase make the difference, for color images, between
1305 the length (for Palette expanded images)
1306 and Raw Length (non expanded image + Palette)
1307 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1308 (that broke Write). Replaced by UL.
1309 Aware user will reload the field if he
1310 thinks it's necesssary
1312 2004-01-30 Jean-Pierre Roux
1313 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1314 when 'dirty Acr' is found, to be compliant with the new
1315 IsReadable() methods.
1317 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1318 (no DOUBLE images in kosher DICOM,
1319 but so usefull for people that miss them ;-)
1321 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1322 DICOMDIR related utilities (not checked as Windoze compliant)
1324 2004-01-28 Jean-Pierre Roux
1325 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1327 2004-01-27 Jean-Pierre Roux
1328 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1329 to allow skipping the shadow elements, to save memory space.
1330 The TRUE value for this param has to be used
1331 with a FALSE value for the 'enable_sequence' param.
1332 ('public elements' may be embedded in 'shadow Sequences')
1333 * gdcmHeader methods now deal with 'embedded icones images' in the header
1334 (even when an 'icone image sequence' is announced by the
1335 element (0x0088,0x0200), but there is NO icone at all ...
1337 * gdcmHeader sometimes Image Location value doesn't follow
1338 the supposed processor endianity (see gdcmData/cr172241.dcm).
1341 * gdcmHeader add the method
1342 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1343 to get *all* the Header Entries with the same tag.
1344 GetHeaderEntrySameName is probabely *useless*
1345 (no meaning : Name is *not* an identifier within the Dictionnary)
1347 2004-01-26 Benoit Regrain
1348 * Bug fix in the print of hexadecimal representations. Remove long fields
1349 in the print and add a third level of print to print them
1351 2004-01-23 Benoit Regrain
1352 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1353 * Bug fix on test suite after remove the strip made on not string fields
1354 * Split the IsReadable method between gdcmParser which test that the file
1355 is dicom and gdcmHeader which test that it's an image file
1357 2004-01-22 Benoit Regrain
1358 * DicomDir : clean code, add methods, set variables in protected or private
1359 * gdcmUtil : bug fix for the clean string method
1361 2004-01-19 Benoit Regrain
1362 * Add the use of shadow dictionaries
1363 * bug fix and coding style
1365 2004-01-19 Benoit Regrain
1366 * src/gdcmFile.cxx : bug fix concerning the close of file
1367 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1368 * Add the update of header entries using the shadow library
1370 2004-01-19 Benoit Regrain
1371 * removal of file gdcmHeader2.cxx
1372 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1373 inheriting from gdcmParser. This split is to prepare the integration
1374 of dicom dir parsing
1375 * bug fix under python
1377 2004-01-16 Jean-Pierre Roux
1378 * REM removal of class gdcmHeaderEntrySet
1379 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1380 * ADD add file gdcmHeader2.cxx
1381 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1383 2004-01-15 Benoit Regrain
1384 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1385 entries created while parsing the header. Thus, they will be destroyed
1386 when the gdcmDictSet will be destroyed
1387 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1390 2004-01-15 Benoit Regrain
1391 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1392 made a fatal error because of the memory release at the end of program.
1393 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1394 some memory and vtk seems to have some problems with that.
1395 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1397 2004-01-14 Benoit Regrain
1398 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1399 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1400 * src/*.[h|cxx] : make changes due to class name changes
1401 * gdcmPython/demo/*.py : bug fix due to method names
1403 2004-01-13 Benoit Regrain
1404 * src/*.[h|cxx] : coding style
1405 * vtk/*.[h|cxx] : coding style
1407 2004-01-13 Benoit Regrain
1408 * gdcmPython/testSuite.py : test the readable flag of file for tests
1409 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1410 It's lied to the stl compilation by MSVC (windows, always windows...)
1411 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1413 2004-01-12 Benoit Regrain
1414 * src/*.h : add comments
1415 * src/gdcmDictSet.h : set the method BuildDictPath in public
1416 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1417 directly setted in the source code
1418 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1421 2004-01-09 Benoit Regrain
1422 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1423 * setup.py : use a reference to gdcmVERSION
1425 2004-01-07 Benoit Regrain
1426 * Modification to compile with the distutils.
1429 2003-12-10 Benoit Regrain
1430 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1431 can use a gdcmHeaderHelper to load datas
1432 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1433 made in the source code
1435 2003-12-10 Benoit Regrain
1436 * Update Windows projects and .cvsignore files
1438 2003-11-12 Jean-Pierre Roux
1439 * ENH gdcmHeader constructor has one more parameter (default value : false)
1440 that allows the user to 'go inside' the SeQuences only
1442 gdcmElValSet:Print takes it into account
1444 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1445 * ENH: Update gdcmPython/CMakeLists
1446 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1447 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1449 2003-11-10 Jean-Pierre Roux
1450 * FIX : gdcmHeader::LoadElements is now based
1451 on the ListTag listElem member,
1452 not longer on the TagElValueHT tagHt member
1453 * ENH : PrintPubElVal shows (temporarily) both results,
1454 with the tagHt member and the listElem member.
1455 (it's easier to 'see' the problems when using Printheader)
1457 * FIX : old private member LgrElem is now splitted into
1458 ReadLength : Length actually found on disk (updated only
1459 if bug fixing is necessary), for internal
1461 UsableLength : Updated by FixFoundLength, to fix a bug
1462 or to allow Parser going on.
1463 Will allow to re-write a kosher header when a SeQuence
1464 with a length (not 0000) is found
1465 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1466 because gdcmElValSet::Add does not update ListElem
1469 2003-11-07 Jean-Pierre Roux
1470 * FIX misstyping in Transfert Syntax name table
1471 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1472 when they have an actual length (not 0000 nor FFFFF)
1473 (Nobody should care of it, but DICOMDIR explorers)
1475 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1476 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1478 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1479 * ENH: vtkGdcmReader now supports LUT !
1480 (vtkgdcmViewer for now is not able to use them though)
1482 2003-11-05 Jean-Pierre Roux
1483 * in testSuite.py : new files names for checking the package
1484 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1485 that returns the pixel area size to the *aware* (vtk) user
1486 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1488 2003-11-05 Benoit Regrain
1489 * in testSuite.py : Modify the rules for checking the paths
1490 : Explicit error messages
1491 * in __init__.py : Related modif
1493 2003-11-03 Jean-Pierre Roux
1494 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1495 to be used by aware (vtk) users that want to manage
1496 LUT (and no to turn the PALETTE image into an RGB pixels one)
1497 * GetPixelType now returns 8U for 24 Bits images
1498 (vtkGdcmReader compliant)
1500 2003-10-31 Jean-Pierre Roux
1501 * Removal of *all* gdcmData images and add them again
1502 in order to loose the 'history' of un-anonymised images
1504 2003-10-31 Jean-Pierre Roux
1505 * RMV : removal of useless jBitsInJsample.h
1506 for both 8 and 12 Bits JPEG Lossy Libraries
1508 2003-10-31 Jean-Pierre Roux
1509 * ENH : Add the functions gdcmFile::GetImageDataRaw
1510 gdcmFile::GetImageDataIntoVectorRaw
1511 that act as GetImageData and GetImageDataIntoVector
1512 except the making of an RGB Plane from Gray Plane + LUT
1513 Intended to aware (vtk) users who know how to manage
1516 GetLUTRGBA return a R,G,B,A LUT if any
1517 lgrTotaleRaw gives the 'Raw' length
1518 GetImageDataRaw returns the gray Plane
1519 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1520 (They stay Grey, just like with other Dicom viewers :-(
1522 2003-10-30 Jean-Pierre Roux
1523 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1525 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1526 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1527 being coherents dicom files.
1529 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1530 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1532 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1533 * ENH: Two steps is necessary to please VC++ compiler...
1534 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1535 * ENH: Add include dir to medcon lib
1536 * FIX: only one function is being exported for now !
1537 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1539 2003-10-29 Jean-Pierre Roux
1540 * adding gdcmHeader::GetLUTRGBA
1541 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1542 --> Mathieu, the modif u're waiting for is not yet committed
1543 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1545 2003-10-27 Jean-Pierre Roux
1546 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1547 00191113.dcm DermaColorLossLess.dcm
1548 MxTwinLossLess.dcm RadBWLossLess.dcm
1549 * ENH: For version prior to vtkImageViewer2 -r 1.19
1550 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1552 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1553 * Removal of ido stuff in CMakeLists.txt
1555 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1556 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1557 * FIX: remove a call to ->Modified ... see comments
1558 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1560 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1561 * FIX: Problem with path for libvtkgdcmPython
1562 * ENH: Try adding a search script for python site-package
1563 * RMV: Remove some file from medcon lib that are not necessary
1564 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1565 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1566 * FIX: More pragma disable fro VC++,
1567 I don't think I break something as it is also disable in VTK/ITK.
1568 But it fasten debug compilation time.
1570 2003-10-23 Jean-Pierre Roux
1571 * gdcm now deals with 16 Bits Run Length Encoded images
1572 (they are compressed as 2 planes images,
1573 one for the high Bytes, the other for low Bytes)
1575 2003-10-22 Jean-Pierre Roux
1576 * Now CheckRead takes into account :
1577 - the bugged 'Leonardo' Siemens images
1578 - the XA images, sent thru the burning VPRO station
1579 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1582 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1583 * FIX: When copying a Makefile.am to CMakeLists.txt
1584 one should remove the '\'
1586 2003-10-22 Jean-Pierre Roux
1587 * in gdcmData adding a bugged 'Leonardo' Siemens image
1588 (wrong lengths in header)
1589 OK with gdcm, KO with the other viewers :-)
1590 * add a GE dlx XA image, thru the VEPRO burning station
1593 2003-10-21 Jean-Pierre Roux
1594 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1595 for a brutal checking of vtkgdcmViewer compliance
1597 2003-10-21 Jean-Pierre Roux
1598 * add the files for 'xmedcon' Jpeg Lossless library
1599 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1601 2003-10-21 Jean-Pierre Roux
1602 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1604 2003-10-21 Jean-Pierre Roux
1605 * garbage Siemens 'Leonardo' images dealt with
1606 (the patch is easy to remove)
1607 * cosmetic changes to avoid warnings
1609 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1610 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1611 no need to press 'r' now.
1613 2003-10-20 Jean-Pierre Roux
1614 * upgrade of checkRead.sh checkWrite.sh according
1615 to new Jpeg Lossless decompressor
1616 * add US.3405.1.dcm, a genuine RGB medical file ...
1617 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1618 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1620 2003-10-15 Jean-Pierre Roux
1621 * general anonymisation in gdcmData
1622 * adding the 'color files' from
1623 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1624 * adding some well knowed bugged-header images
1625 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1626 waiting for their inclusion in Python testsuite
1628 2003-10-15 Jean-Pierre Roux
1629 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1630 no longer seg faults when file is not found
1632 2003-10-14 Jean-Pierre Roux
1633 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1636 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1637 * TODO: *.in file to genereate a UseGDCM later
1639 2003-10-14 Jean-Pierre Roux
1640 * Some supposed-to-be Dicom Images have no preamble.
1641 OpenFile takes it into account
1642 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1643 * Missing elements added in dicomV3.dic
1644 (just to be affraid : have a look at
1645 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1646 and do it again next year ;->
1648 2003-10-13 Jean-Pierre Roux
1649 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1650 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1651 But there are NOT. It's fixed !
1653 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1654 * FIX: "jpeglib.h" was not found on VC++
1655 * FIX: vtkgdcm was not being installed
1657 2003-10-10 Jean-Pierre Roux
1658 * ENH : OpenFile closes the file if it *really* doesn't look like
1659 an ACR-NEMA / DICOM one.
1660 * FIX : testWrite no longer writes an empty file if the source file
1661 is not gdcm Readable
1662 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1665 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1666 * FIX: CMake generate now documentation
1667 * ENH: out of source doc build !
1668 * ENH: Generate both user and dev documentation
1669 * ENH: Should work on windows too
1670 * ENH: Only one doxygen config.in file is needed
1671 * FIX: make install should be ok now on ùnix plateform
1672 * FIX: PATH to dictionary was wrong (missing /)
1673 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1675 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * vtkGdcmReader is now able to read rgb dicom file.
1677 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1678 * added a gdcmViewer to vtk test, use mouse to control
1679 window level & window width
1681 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1682 * CMake-ification of gdcm, we have now two build system
1683 * FIX: on cygwin Wsock32 doesn't exist
1684 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1686 2003-10-06 Emanuel Ollart
1687 * FIX : compilation process wad broken.
1688 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1690 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1691 * change gdcmViewer -> vtkgdcmViewer
1692 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1694 2003-10-06 Jean-Pierre Roux
1695 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1696 ( e.g : well known GE images with a wrong elem length,
1697 : Philips MRI Images with a wrong Huffman table)
1698 * still to be done : allow the reading of bugged LEONARDO Siemens images
1700 2003-10-03 Jean-Pierre Roux
1701 * Odd length strings are padded with '\0' (not with spaces,
1702 to remain compliant with already defined strings,
1703 like Transfert Syntax UID and others)
1705 2003-10-03 Jean-Pierre Roux
1706 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1707 to allow displaying RGB images (not only by affim ;-)
1709 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1710 * vtkGdcmReader is now able to read rgb dicom file.
1711 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1713 2003-10-03 Jean-Pierre Roux
1714 * A few nasty patches to allow the reading of a lot of nasty images
1715 ( e.g : well known GE images with a wrong elem length,
1716 : Philips MRI Images with a wrong Huffman table)
1717 * still to be done : allow the reading of bugged LEONARDO Siemens images
1719 2003-10-03 Jean-Pierre Roux
1720 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1722 2003-10-03 Jean-Pierre Roux
1723 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1724 to allow displaying RGB images (not only by affim ;-)
1726 2003-10-03 Jean-Pierre Roux
1727 * gdcmFile::GetImageDataIntoVector now
1728 - deals with MultiFrames MultiFragments Run Length Encoded files
1729 - deals with YcBcR (YBR_FULL) files
1730 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1731 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1733 (no sample found :-(
1735 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1736 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1737 Two reasons: - clear things
1738 - third parties acces gdcm through header files, so won't
1739 suffer anymore VC++ complains
1741 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1742 * add argv[1] in testvtkGdcmReader.cxx
1745 2003-09-24 Jean-Pierre Roux
1746 * The lines are now eigthy characters long.for
1747 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1749 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1750 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1751 char* to std::string. Thus, the use of strdup becomes useless. (see
1752 previous commis of Malaterre)
1753 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1754 before the last Malaterre's commit.
1756 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1757 * This commit should fix the Debug building under VC++, the problem
1758 was mainly a mixture of debug and release lib being loaded at startup.
1759 * I also remove a depency to a specific C function: strdup. Because I had
1760 to force the link to msvcrtd (whereas strdup is in libc).
1762 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1763 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1764 located in the gdcmCommon.h file. All use of reference of tha has been
1765 changed to now use the variable GDCM_UNFOUND.
1767 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1769 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1770 Dicom dictionary. The test suite can now be run again. Note:
1771 I'm note very happy with the " (RET)" changes. I believe this
1772 RETAINED comment should be dropped when parsing the dictionary.
1773 - PACKAGER corrected
1775 - AUTHORS updated and now in alphabetical order
1776 * Makefile.am now exports gdcm.dsw for Windoze users.
1778 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1779 * cygwin complains about missing std:: in subdir Test/
1781 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1782 * remove some methods that are now in gdcmHeaderHelper
1784 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1785 * vtkGdcmReader set spacing and origin correctly
1787 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1788 * Fix a few delete/delete[] mismatch
1790 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1791 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1792 interpretation to data given by gdcmHeader. For instance there are
1793 heuristics to get informations (look at different places).
1794 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1795 sorting DICOM images based on different strategies.
1796 * modified Makefiles accordingly.
1798 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1799 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1800 when building in debug mode
1801 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1802 src/win32/gdcmdll.dsp
1803 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1805 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1806 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1809 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1810 * src/win32/libgdcmjpeg12.dsp was not dos format
1811 * src/win32/libgdcmjpeg12.dsp :
1812 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1813 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1815 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1816 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1818 * src/gdcmFile.cxx : bug fix in affectation type
1819 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1820 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1821 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1822 symbols... future problem ?
1824 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1825 * src/win32/libgdcmijpeg12.dsp was missing
1826 * modified gdcm.dsw accordingly
1828 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1829 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1831 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1832 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1833 commit of JPR (before his hollidays to facilitate our work).
1834 * setup.py : bug fix in code. Modifications made while the last commit
1835 of JPR. The code hasn't been tested before the commit... it's so
1836 useless to make that (for best programmer that is JPR) !!!
1838 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * tagged the current version as Version0_3 (i.e. version 0.3)
1841 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1842 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1843 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1844 * *.dsp : modifications to use new libgdcmijpeg8 library
1845 * setup.py : bug fix on VTKPATH variable
1846 * PACKAGER : adding all concerning windows
1848 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1849 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1851 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1852 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1853 test suite reported error.
1854 * PACKAGER file added (describes what a packager must do when
1855 packaging a new release).
1856 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1857 * configure.in: upgraded version number to 0.3.0
1858 * fixing build of rpm (through rpm -ta):
1859 - Doc/Makefile.am exports proper doxygen files
1860 - src/jpeg/libijg8/Makefile.am exports the include files.
1862 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1863 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1864 * src/gdcmHeader.h : formatting code
1866 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1867 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1868 We were obtaining error message from vtk. Now, creation of file list
1869 is made in an internal list to prevent this problem.
1870 Bug fix when output is empty.
1871 Bug fix in update of progress value. Previous commit for this was a bad
1873 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1875 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1876 * src/gdcmHeader.h : added method to get the file name
1877 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1878 files. Added method to remove all files on the input
1879 Added FIXME comment concerning the bad parsing of header made by
1880 ExecuteInformation method (in ExecuteData method)
1882 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1883 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1884 when using make instal.
1885 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1886 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1888 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1889 * setup.py : adding include dir of jpeg lib to compile all sources
1890 * */Win32/*.dsp : JPR fix for windows compilation
1892 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1893 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1895 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1896 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1898 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1899 * setup.py is again effective on un*x (takes into account the
1900 addon of the jpeg library)
1901 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1902 * Doc/Doxy* updated (includes above enhancements)
1903 * INSTALL now points to web documentation
1905 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1906 * src/gdcmHeader.h doesn't make unnecessary reference to
1908 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1910 * src/gdcm*.[cxx|h] :
1911 - to allow compilation with gcc 3.x
1912 -- clean up of STL usage (added explicit usage of std::)
1913 -- small fixes on exceptions.
1914 Note: linking not tested !
1915 - clean of doxygen comments to avoid warnings at documentation
1917 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1918 dependent convertion).
1920 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * Clean up of previous JPR garbage commit (not even commented in the
1923 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1924 - moved all jpeg related files from src to src/jpeg/libijg8, with
1925 addition/modification of Makefile.am and configure.in.
1926 - the testSuite is still brain damage (not guilty).
1928 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1929 * WrapVTK.py : modifications to get correctly vtk source files to
1931 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1932 (FileName -> Filename)
1934 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1935 * vtk/vtkGdcmReader.[cxx/h]:
1936 - UpdateProgress method should now be effective
1937 - removed the limitation on having only images loaded (as opposed
1939 - when building a stack of images/volume, a lesser number of
1940 gdcmHeader and gdcmFile instances should be used (hopefully
1941 accelerating things).
1942 - when building a stack of images/volumes, files which are not
1943 loadable (wrong path-filename, wrong permissions on existing file,
1944 or file not parsable by gdcm) are replaced with a black image
1945 in the stack (for the caller to notice the problem).
1947 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1950 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1951 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1952 between standard library (std) and vtk library (problems are found
1953 under Windows... thanks Windows !)
1955 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1956 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1958 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1960 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1961 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1963 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1964 * When compiling with distutils (see setup.py) the C++ compiler is
1965 called with different flags than the default ones (with automake).
1966 In order to fix all those warning, I compiled gdcm with the command
1967 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1968 and went for warning fixes:
1969 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1970 up from unused variables.
1971 - vtk/vtkGdcmReader.cxx: potential bug fix.
1972 * src/gdcmHeader.h: Doxygen warning cleanup
1974 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1975 * gdcmPython/gdcm.i:
1976 - typemaps correction to take into account the systematic replacement
1977 of "using namespace std" with std:: prefix e.g. std::list,
1978 std::string... (cf changes of 2003-05-21).
1979 - gdcmGlob global variable of type gdcmGlobal (defined in
1980 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1981 exported to Python a as cvar.
1982 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1983 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1984 gdcmDictSet.GetPubDictTagNames() and
1985 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1986 C++ static methods).
1987 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1988 with the above changes.
1990 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1991 * setup.py, manifest.in : bug fix under linux
1993 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1994 * Modification of setup.py to compile vtk part too. Then, we have 2
1995 wrappers which must work with same distutils. For that, we have a
1996 generic distutils in distusiltsWrapping.py ; with :
1997 - build_extWrap class to wrap generically all extensions,
1998 - ExtensionWrap base class for all wrapping extension that contains
2000 - Wrapper interface which wrap sources
2001 + In WrapSwig.py we have extension and wrapper for Swig
2002 + In WrapVTK.py we have extension and wrapper for VTK
2003 * MANIFEST.in : modifications to consider vtk directory and new python
2004 files for compilation
2006 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2007 * Added python wrappers of vtkGdcmReader vtk class (see the
2008 source in vtk/vtkGdcmReader.cxx) :
2009 - vtk/Makefile.am now builds a library
2010 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2011 python library (as opposed to _gdcm.so wich are the python
2012 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2013 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2015 - configure.in has an additional flag --enable-vtk that needs
2016 to be set to enable compilation of vtk related code, that is:
2017 + vtk/vtkGdcmReader.so and
2018 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2019 + gdcmPython/vtkgdcmPython.so (see above)
2020 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2021 be read when compressed or when HighBit + 1 != BitsStored),
2022 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2023 the usage of the python wrapper of vtkGdcmReader vtk class.
2024 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2025 * src/*.[h] all occurences of stl classes are now prefixed with
2026 std::, and all occurences of "using namespace std;" where removed.
2027 This is to avoid pollution of global namespace in included files.
2028 Apparently vtk does not avoid this pitfall: when using both
2029 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2030 collision of various stl members (principally cout...).
2031 * gdcmPython/testSuite.py now cleanly removes temprory generated
2033 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2034 comply with above changes)
2036 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2037 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2038 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2039 vtk data structure (an image Flip was required).
2040 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2041 * cosmetic changes in documentation.
2043 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2044 * src/gdcmHeader.cxx: the constructor no longer exits when an
2045 unexisting file is given as argument.
2046 * The subdirectory Data (containing all the images used for the
2047 test suite) is not part of this repository anymore. A new module
2048 containing those images is now available at
2049 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2050 with the name gdcmData.
2051 All the python scripts (including the package initialisation file
2052 gdcmPython/__init__.py) were adapated to take this change into
2053 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2055 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2056 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2057 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2058 demo of the usage of this class.
2059 Compilation of this vtk part is only done when using the --enable-vtk
2060 at configure (or autogen.sh) stage.
2062 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2063 * More memory link related corrections and documentation fixes.
2065 - maximum info is obtained with a command of the form:
2066 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2067 --show-reachable=yes PrintHeader
2068 - the remaining reachable blocks seem to come from the STL
2069 allocation scheme through the usage of map and list. It looks
2070 like this memory cannot be freed but it is not a memory leak
2071 (in fact further invocation to the STL would recollect the
2072 unused memory allthough it cannot explicitely be freed).
2073 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2074 of displaying an image parsed with gdcm and displayed with VTK.
2075 Note: some images don't seem to work e.g.
2076 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2077 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2078 Allthough this weakens the semantics, it is a ditch attempt to
2079 make gdcm more thread friendly.
2081 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2082 * Memory link hunt (by using valgrind through the command
2083 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2084 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2085 gdcmHeader::_dicom_vr.
2086 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2087 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2089 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2091 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2092 * src/Makefile.am now exports all the necessary include files at
2096 * UpdateGroupLength replaced by new one
2099 * UpdateGroupLength re-written using H-Table
2100 (named UpdateGroupLengthNew untill checks are over)
2102 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2103 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2104 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2106 - gdcmHeader::GetPubElValSet removed.
2107 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2108 UpdateGroupLength, WriteElements, Write.
2109 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2110 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2111 carried the same semantics.
2112 - src/gdcmHeaderIdo.cxx changed accordingly.
2113 - gdcmFile::WriteBase now regroups all the codes from previous
2114 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2115 - enum FileType moved to gdcmCommon.h
2116 * src/gdcmHeader.cxx AddDefault trashed
2117 * gdcmGetXSize added
2118 * getimageDataSize now calls gdcmGetXSize
2119 * Test/*.cxx changed to agree with above changes
2121 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2122 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2123 (to avoid double call by end user).
2124 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2125 by end user, since gdcmHeader::gdcmHeader now handles it.
2127 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * gdcm/Doc many doxygen changes:
2129 - Doxyfile now has two different versions, DoxyfileUsers that generates
2130 the html.users end users oriented documentation and
2131 DoxyfileDeveloppers that generates the html.developper developper
2132 oriented documentation.
2133 - README changed accordingly
2134 - requirement.txt removed (old design info moved to TODO).
2135 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2136 DoxyMainPage.txt, DoxyPython.txt provide more information.
2137 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2138 be updated by simply regenerating the docs with doxygen and copying
2139 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2140 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2141 all the tests in the form "if (<map>.count() >1)" were removed.
2142 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2143 ill-formed documentation sections.
2144 * src/gdcmHeader.cxx: ditto
2146 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2147 * setup.py fixed for un*x (needed macro for stdint.h)
2148 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2149 un*ces with sh-utils test utility.
2150 * gdcmPython/demo/test.py renamed to PrintHeader.py
2151 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2152 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2153 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2154 * src/gdcm*.cxx JPR's bad inclusion fixed.
2156 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2158 * gdcmPython/demo/test.py changed accordingly.
2160 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * gdcmPython/Makefile.am fixed linking against libstdc++
2162 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2163 * Swig subdir (historical tests of swig version 1.3.17++) removed
2164 * Test/testChangeEntete.cxx some lines commented out in order to make
2166 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2167 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2169 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2171 hence the user doesn't need this explicit call.
2172 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2173 i.e. LoadElements() call removed.
2174 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2175 - src/Makefile.am declares the proper flag for g++.
2176 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2177 for adding user defined new tags.
2178 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2179 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2180 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2182 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2183 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2184 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2185 src/Makefile.am : the project should properly compile and install
2186 with the autotools, included the python wrappers part.
2187 * gdcm.spec.in : added a spec file for RPM packaging.
2189 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2190 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2192 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2193 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2194 to exported to the environement (see gdcmPython/testSuite.py
2196 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2197 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2198 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2199 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2200 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2202 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2203 * gdcmPython/__init__.py doesn't crash anymore when running in
2204 in InstallMode or PreInstallMode but with an environement given
2205 value of GDCM_DICT_PATH.
2206 * src/gdcmDictSet.[cxx/h] coding style.
2208 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2209 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2210 * src/gdcm.h general comments moved to TODO, and README
2211 * src/gdcm.h should now be seen as a user commodity (including it
2212 should suffice to fully use gdcm). It is nowhere including within
2213 any of the kernel files src/*.cxx and src/*.h.
2215 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2217 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2219 * src/gdcm*.cxx only include their corresponding include file
2220 (as opposed to gdcm.h)
2221 * gdcmPython/gdcm.i changed accordingly
2222 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2223 the autogen.sh generated "make snapshot" command to work.
2224 * autogen.sh removed history related references to crea package.
2226 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2227 * distutilsSwigCPlusPlus.py work around some swig portability
2230 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2231 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2232 was done in a last ditch attempt to get setup.py _really_
2233 operationnal. The python/gdcmPython layaout add the advantage
2234 of hidding away the python related distutils specific files
2235 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2236 Alas, the src directory was out of scope (i.e. it's relative
2237 position to setup.py was ../src) which made things impossible to
2238 handle (see previous version of python/setup.py). Crossing fingers...
2240 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2241 * python/setup.py now works on Un*x. (harder than I thougth)
2242 * python/distutilsSwigCPlusPlus.py can now have include files
2243 among the list of sources.
2245 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2246 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2247 * modifications in MSVC projects
2249 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * As stated by the first lines of Test/ExceptionAndPython/README, it
2251 looks like we can move back to original usage of exception within
2252 src/gdcm* and hence remove the errno stuff that was introduced
2253 as a quick and dirty fixture of this problem (added to the TODO).
2254 * Doc/Doxyfile configuration file for Doxygen and corresponding
2255 README file for usage added.
2256 * Test/testWrite.cxx added. This new test comes from a split of
2257 test.cxx that is now reverted to its original purpous i.e.
2258 testing the proper parsing of a Dicom related file.
2259 testWrite.cxx concentrates on testing the IO part of gdcm.
2260 * Test/bug1.cxx (containing a bug on WIn32) added.
2261 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2262 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2263 whose purpose is to publish the content of the TagNames of the
2264 Dicom public dictionnary were not accessible without an
2265 instance of class gdcmHeader.
2266 - those methods are now static methods of gdcmDictSet and hence
2267 require no instances at all to be invocated.
2268 - within gdcmDictSet this change required to change some method
2269 to class methods (i.e. are now static) among which SetDictPath
2270 (renamed to BuildDictPath) and LoadDefaultPubDict.
2271 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2272 the above changes by calling the new method classes of gdcmDictSet.
2273 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2274 the above to be effective.
2275 * python/gdcmPython: in order to wrap properly the above changes
2276 for Python, swig version now needs to be > 1.3.17.
2277 * python/gdcmPython/Makefile fixed to adapt itself to new
2278 configure/make shema introduced by Johan Montagnat (thanks for the
2279 contribution). Alas this Makefile cannot be turned into a proper
2280 Makefile.am without some heavy changes in the configure.in
2281 (for python dectection).
2282 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2283 now avoids publishing the empty entries.
2285 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2286 * python/setup.py : bug fix concerning install under windows
2287 ExtraPath reused :-P
2288 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2290 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2291 * Dicts/dicomV3.dic : remove double spaces !!!
2292 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2293 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2296 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2297 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2298 method. Doxygenation.
2299 * src/gdcm.h clean up of JPR spurious comments.
2301 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2302 * python/distutilsSwigCPlusPlus.py now properly collects the
2303 shadow classes generated by "swig -c++" (gdcm.py in our case)
2304 when using "python setup.py install".
2305 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2306 reexports the working classes.
2307 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2308 by the classical C errno scheme. This is to prevent an obscure
2309 behavior of the python wrappers when importing wxPython.wx prior
2310 to gdcmPython (which ended up in an abort call). An illustration
2311 of this oddity can be found in the Test/ExceptionAndPython
2312 subdir (see the README file). This problem probably due to
2313 an combination of g++ and dynamic loading.
2314 * added Test/ExceptionAndPython (see above)
2316 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2317 * Changed the layout of the python part to avoid bloating main
2318 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2319 i.e. the distutils arsenal. All the python related stuff is
2320 again in a python subdir, but the package itself is now in
2322 * setup.py was cleaned up:
2323 - pythonIncludePath removed
2324 - python setup.py bdist target is now functional.
2325 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2326 collision with other packages). gdcmPython/demo/*.py changed
2329 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2330 * python subdir moved to gdcmPython (preparation of distutils packaging).
2331 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2332 distutils installer is operational.
2333 * - gdcmPython/__init__.py now properly loads the swig generated
2334 shadow classes (from gdcm.py).
2335 - gdcmPython/demo/*.py changed to import the package gdcmPython
2336 instead of gdcmPython/demo/load.py.
2337 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2339 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2340 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2341 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2342 entries within the associated public Dicom dictionary resp. the same
2343 information but sorted by the fourth field (PAT, IMG, DIR) of the
2345 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2346 are now in the "???" group.
2347 - python/gdcm.i changed accordingly,
2348 - python/demo/printGroupedPublicDict.py added, that gives an example
2349 of the above new functionalities in Python.
2351 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * src/gdcm.h, gdcmHeader.cxx:
2353 - historic references to glib's g_malloc and g_free (#defined)
2354 were definitively removed.
2355 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2356 * src/gdcmElValSet.cxx:
2357 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2358 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2359 - GetElValue(string) renamed to GetElValueByName.
2360 - Added GetElementByName(string).
2361 * src/gdcmHeader.cxx: added
2362 - GetPubElValRepByNumber(guint16, guint16)
2363 - GetPubElValRepByName(string)
2364 - GetShaElValRepByNumber(guint16, guint16)
2365 - GetShaElValRepByName(string)
2366 - GetShaElValByNumber(guint16, guint16)
2367 - GetShaElValRepByName(string)
2368 - GetElValRepByNumber(guint16, guint16)
2369 - GetElValRepByName(string)
2370 - GetElValByNumber(guint16, guint16)
2371 - GetElValRepByName(string)
2372 * Doc/requirements.txt added.
2374 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * Test/Makefile building now depends on the one of libgdcm.so
2376 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2377 pixel data) aware which enables finding the address (offset) of
2378 the pixel data of JPEG encoded DICOM files. This leaves only a single
2379 file in the testSuite whose pixel data address (offset) is unknown.
2380 * python/testSuite.py changed accordingly.
2382 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2383 * VC++ has some strong limitations when working with the STL, as stated
2384 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2385 "Also note that some STL containers (map, set, queue, list, deque)
2386 cannot be exported. [...]
2387 Some STL classes contain nested classes. These classes can not
2389 This is caused by a designed limitation that once a template
2390 class is instantiated, it can not be re-instantiated and
2392 Since our usage of map<> is ubiquitous in gdcm, this "designed
2393 limitation" of VC++ is a pitfall.
2394 Hence the Python wrappers of gdcm cannot be incrementally linked
2395 against the c++ dynamic library. The dirty but only workaround is
2396 to forget about incremental link of dynamic libraries and to generate
2397 the Python wrappers library with the inclusions of the underlying C++
2399 The following modifications concern this matter on Win32/VC++:
2400 - wrapping python correct with standalone wrapped dll (don't use separate
2401 dll under windows !!!!)
2402 - python21_d debug mode enabled (ask Frog how to use it :-)
2403 - NO problem with having an STL member of class for example string in C++
2404 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2405 - Python test of dcmlib in Python is ok under windows on a large set
2407 * removed glib references
2408 * typedef's inserted in gdcm.i for correct swig type management
2410 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * python/demo/*.py load.py extracted from test.py. Added explore.py
2412 that only displays required tags and testAll.py that parses all
2413 the files of the testsuite without using unittest.
2414 * python/testSuite.py other additional test on new files added.
2415 * Data/* new test files added accordingly to the testSuite.
2416 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2417 the vr in the file differs from the one of the dictionary.
2419 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2421 values, but limits itself to values which are below a user specified
2422 size (by default 1024 bytes).
2423 * python/gdcm.i : elements not loaded (because their size is above the
2424 user specified treshold) are exported with their TagKey as key of the
2425 python dictionary. This enables the testsuite to make some checks
2426 on the unloaded elements (since we have their offset and size).
2427 * python/testSuite.py
2428 - now tests for the existence and proper value of the pixel data
2429 - two new examples added.
2430 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2432 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2434 aware. See the strategy comments in gdcmHeader::FindeLength().
2435 * Test/test.cxx now accepts a filename as first argument.
2436 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2437 * python/testSuite.py changed to integrate test on above files.
2439 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2441 the vr was also RET.
2442 * python/testSuite.py more tests added.
2444 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * python/testSuite.py unittest test suite added (uses Data)
2446 * Data/* dcm and acr files for the test suite.
2447 * glib dependance removed from un*x version. We now use ISO C99
2448 7.18 Integer types (see stdint.h)
2449 - python/Makefile, src/Makefile src/gdcm.h
2450 * src/ when an explicit vr (like dicom files) suddenly poped an
2451 implicit element we use to mark the underlying DictEntry of the
2452 concerned ElValue with "Implicit". This strategy was damageable
2453 too the public or provite dictionaries, since some of their vr
2454 would be changed. Since Header::FindLength heavily relies on the
2455 detection by Header::FindVR of falsely explicit elements, I
2456 added an extra ImplicitVr member to ElValue (boolean).
2457 The rest of the changes we the necessary adaptations.
2459 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2460 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2462 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2464 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2465 * Adaptation for porting to VC++:
2467 o forced to use std namespace (for string to be known)
2468 o all class use __declspec export style on WIN32
2469 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2470 (in stdlib.h on Win32 but in std:: for gcc)
2471 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2472 variable GDCM_DICT_PATH.
2473 * src/gdcmHeader.cxx verbose comments made discrete.
2475 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * python/gdcm.i: added a typemap that converts a C++ hashing table
2477 to native Python dictionary.
2478 * python/demo/test.py:
2479 - now uses the native dictionary for exploration of gdcmHeader.
2480 - takes an optional filename argument (the file to parse).
2481 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2482 PubElVals hashing table.
2483 * Dicts/dicomV3.dic removed error prone trailing spaces.
2485 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * Python wrapping process moved away from src/Makefile to
2487 newly created python/Makefile (as well as gdcm.i)
2488 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2489 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2490 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2491 from the environement variable GDCM_DICT_PATH (when existing).
2492 * src/gdcmDict::GetTag bug fix.
2494 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * Straightforward temporary fixes for swig to build the python wrappers.
2496 src/Makefile now has a python working entry [by working we mean
2497 that we can import de shadow classes without errors].
2499 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2500 * hashtest.cxx removed (since allready in Test)
2501 * src/gdcmlib.h renamed to src/gdcm.h
2502 * src/dcm.i renamed to src/gdcm.i
2503 * src/Makefile prepared for python wrapping
2505 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2506 * src/gdcmHeader.cxx :
2507 - Parsing of header is now separated from loading of element values
2508 (see gdcmHeader::LoadElements).
2509 - general clean up of hopefully all file access (creation of
2510 ReadInt16 and ReadInt32)
2512 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2513 * src/gdcmHeader.cxx :
2514 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2516 - SetLgrElem renamed to SetLength
2517 - GetLgrElem renamed to GetLength
2518 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2519 * src/gdcmElValSet.cxx fixed both GetElValue methods
2520 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2521 due to IdoDude was cleaned out.
2523 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2525 concentrates on finding the value representation (when it exists).
2526 RecupLgr now only finds the element value length, and it avoids
2527 returning the unecessary skL (skipped length).
2528 Also, offsetCourant was simply removed (with taille_fich) since
2529 it was redundant with the File position internals (by using
2530 ftell and fseek). This also made skL (see above in RecupLgr) usage
2532 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2533 on the libido specificities which are handled through class
2535 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2538 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2539 * Truckload of changes. Parsing of header is barely functional
2540 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2542 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2543 * src/gdcmHeader.cxx many addons of low level methods
2545 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2546 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2547 and _IdDcmSWAP_LONG.
2549 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2550 * This corresponds to all the changes decided at the meeting of
2551 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob