1 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
3 future, with convertion)
4 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
5 and ImageDataSize values. Remove the method to get the PixelReadConverter
6 from the output of the class
8 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
11 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
13 and vtkErrorMacro use.
14 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
16 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
19 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
20 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
21 The string leaves only in the fonction. So when we make a .c_str(), we
22 get the pointeur on the first element, element that will be destroyed
23 immediately after thee instruction.
24 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
25 file has been opened : the test must be made on the content of the
26 pointer and not directly on the pointer !
29 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
31 the python part recompiles
33 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
35 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
36 X session is killed (for my computer... it seems to not be identic on
39 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
41 avoid problems (otherwise, the difference test between the visible image
42 and the reference is incorrect. If the reference is greater than the
43 screen resolution, it's produce errors).
44 Can be used for only one image. Can be used with a visible flag.
45 * vtk/vtkGdcmReader.cxx : remove commented codes.
46 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
47 under windows at compilation
48 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
50 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
52 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
54 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
55 tests on the image size X, Y, Z
57 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
59 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
60 between the class name and the file name
62 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/ : fix compilation warnings for the Write method (2 different
64 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
65 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
66 variable... create a static method in gdcm::Document to access to
67 this variable content.
69 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
71 file, to be accessed by other files (like gdcmFile). Remove commented
72 code. Move the change of the header to the gdcmFile, using the
74 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
75 To be sure of that (and simplify calls), the Write of the header now
76 gets a file name and not a file pointer (std::ifstream).
77 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
78 DocEntryArchive. Remove all open of the written file
80 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
83 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
85 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
87 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
88 some corresponding methods. Write correctly the file and check before
90 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
91 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
92 is now on RGB datas (as before my last commit
93 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
95 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
97 Add a print information of the type of the entry
98 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
99 It was in the gdcmFile, and all write have been regrouped
100 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
101 Write correctly all dicom files (in decompressed mode only at this time)
102 * Test/ : test on files are now made using Raw datas and not color datas if
104 * Example/PrintFile.cxx : add more printings
106 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * Amelioration of code, remove some code copy. For the loading of
108 BinEntry (in gdcmDocument), add the test to verify if the file is already
111 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
113 remove a DocEntry in the header (push an empty DocEntry)
114 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
115 lines. Bug fix in the initialization of the PixelConvert and the
117 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
118 use in TestCopyDicom (now this test can run under windows... but fails)
119 * Test/TestCopyDicom.cxx : amelioration of the test :
120 - test the pixels written
121 - add test points to quickly find where is the error
122 - can set a file name input and output in arguments
123 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
124 amelioration of the test output
126 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
128 all replaced DocEntry's
129 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
130 Now, each needed DocEntry to modify is duplicated, modified and inserted
131 to the header using DocEntryArchive. Thus, after save, we can restore the
132 header initial state.
134 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
137 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
139 correct to copy it. The DictEntry is specified at the DocEntry creation,
140 then, it musn't change in the time.
141 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
142 header correctly. At this time, the change is only made for the first
143 level of the Document. In the future, it might consider sequences.
144 The change is made by replacing a DocEntry by an other that is created
145 outside the class. The old value is kept. When we restore the header
146 status, the added DocEntry is deleted and replaced by the old value.
147 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
148 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
149 set the write type to explicit VR, implicit VR or ACR. Add methods to set
150 the write mode to native, decompressed or RGB (but not used at this time)
152 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
154 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
156 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
158 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
160 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
161 set because already copied when copying the BinEntry's of the header
162 * Test/TestAllReadCompareDicom.cxx : remove warnings
164 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
166 Two problems appear when doing it :
167 - with the gdcmFile : when the GetImageData method is called, the pixels
168 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
169 datas (pixels). And each structure destruct the datas when it's
170 destructed. So we have two destructions for the same datas. To solve it,
171 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
172 datas or not. If it doesn't own datas, then they will not destroyed by
174 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
175 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
176 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
177 create a double destruction of the same DocEntry's. So, to solve it,
178 the TagHT is simply cleared and the DicomDir* elements are destroyed.
179 * TODO : add an entry concerning memory leaks in the DicomDir
181 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
183 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
186 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
188 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
189 after it have been deleted
191 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * FIX: src/* fix the doxygen warnings.
193 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
194 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
195 was erroneously defined with a size of 15 instead of 16. [many thanks
196 to Jean Michel Rouet for pointing out this bug].
198 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
199 1. Finish merging JMR patch for writting DICOM from scratch
200 2. Fix -hopefully- bug with MONOCHROME and space vs null character
201 3. Use const ref when possible
202 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
203 5. A few more comments
204 6. CreateUniqueUID can now be called without parameter"
206 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
207 * ENH: Slightly bigger patch:
208 1. Getting toward full integration of JMR patch for writting dicom from scratch
209 2. Update Test to test part of this patch: CreateUniqueUID
210 3. File was not close properly in gdcmDict
211 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
212 5. Use of const ref instead of copy (speed issue)
213 6. Remove temporary (duplicate) string in TranslateToKey
214 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
215 8. Do not repeat virtual in subclasses
216 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
218 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
219 * Apply first patch toward better string comparison when dealing with broken
220 DICOM files. Essentially the string could be padded with a space instead
221 of a null character as defined by standard
223 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
225 because never used... and in the same time, that's remove some memory leaks
227 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
228 * src/gdcmFile.cxx : now delete the PixelConvert instance.
229 * In examples and tests : change the type of image data variables from void*
230 to uint8_t*. Remmove all delete on image data variables
232 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
234 Verify the file pointer value before open the file, and if it's not null,
235 a verbose message is generated.
236 Close correctly the file when the file isn't considered dicom-like. The
237 correctly close is a call to CloseFile.
238 When closing the file pointer, test if its not null to close the file.
239 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
240 file. For an uncompressed image, the copied datas correspond in the least
241 case to the image size (calculated) or the image size specified in the
242 header. A verbose is generated if these two size mismatch
244 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
246 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
247 break under windows (with msvc6 compilation).
249 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
251 compiling with MSVC6)
253 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * Bugs fix for the Windows build with VC6
255 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
256 needed (only for projects required VTK). If the VTK is included in all
257 projects, there is conflicts with the jpeg lib of vtk when compiling the
258 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
259 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
260 when compiling the gdcm_wrap.cxx file (created by the compilation of the
262 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
263 (like it's already made for the cout use). Otherwise, conflict with the
266 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
269 - comments on the DicomDir::Method related usage added.
270 - now that we use the namespace gdcm, a lot of internal classes do
271 NOT need to be wrapped anymore.
272 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
273 DicomDir::Method) new example added.
275 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
276 * Improve string manipulation. I now inforce the notion of 'DicomString'
277 A DicomString can contain as many \0 as they want
278 and it is *always* of even length.
279 We only support odd length for very rare case.
280 And in the near future this should be removed.
282 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
283 * /binary_write/ gdcm source. Now even on big endian we are writting
284 little endian. This should -heopfully- fix some tests
286 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
287 * Now the dictionary is compiled into gdcm lib. This is a default
288 behavior, thus any dic file specified is picked before failback to
289 the one comiled into lib
291 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
292 * Change internals for gdcmDict. Don't use any 'new' any more.
293 This should definitely solve any leak problem, and we should be
294 as fast as before, as long as don't modify too much the dictionary.
296 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
297 * STYLE: ivars should start with a capital letter.
298 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
299 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
301 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
302 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
303 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
304 new 2004 dictionaries added (thanks to JPR).
305 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
306 * CLEANUP_ROUND (15) for gdcmPixelConvert
307 - RLEFrame::NumberFragments is now of type unsigned int
308 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
309 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
312 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
313 * Initial work in gathering all transfer syntax accessors. clearly
314 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
315 ivars, but only one transfersyntax (class) ivar with equivalent method on
318 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
319 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
320 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
321 discussed (plus I didn't like having a 2000 lines patch not commited)
323 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
324 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
325 * CLEANUP_ROUND (14) for gdcmPixelConvert
326 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
327 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
328 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
330 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
331 anymore and hence avoids storing a copy of PixelConvert::Decompressed
332 into File::Pixel_Data.
334 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
335 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
336 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
337 * CLEANUP_ROUND (13) for gdcmPixelConvert
338 Substituted File::ParsePixelData() with PixelConvert::Print() new
340 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
341 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
342 method to those classes.
343 - src/gdcmFile.[cxx|h]:
344 -- Added a ::Print() method.
345 -- PixelConverter is now a reference instead of a member.
346 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
347 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
349 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
350 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
351 collaboration diagram and inheritance diagram should be generated with
353 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
354 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
355 pointlessly wrapped (see
356 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
357 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
358 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
359 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
360 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
361 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
362 -- File::Initialise: PixelConverter setup moved away to
363 PixelConverter::GrabInformationsFromHeader()
364 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
365 interpretation moved away to PixelConverter::BuildRGBImage()
367 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
368 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
369 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
371 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
372 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
373 displayed on Win32 when a brutal abort() occurs (because of uncatched
374 exception). See TODO new entry of this commit for more on this.
375 * TODO added new entry.
376 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
377 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
378 - HandleColor is no longer called from gdcmFile.cxx
379 - gdcmPixelConvert.cxx clean up on method arguments and internal
380 variable names for semantical coherence.
382 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
383 * Finished lossless transition, not only do we now read all lossless jpeg
384 images, without the need of the Cornwell lib, but we do read them properly now
385 * To reduce code (well to avoid code duplication), I defined a common place
386 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
387 redefine symbols. This is not prefect but this the best solution I found for a
388 compilation time jpeg option.
390 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
391 * Update jpeg ijg lib to support lossless jpeg implementation
392 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
394 * Also added a special copyright for dcmtk since we use their bugfixes.
397 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
398 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
399 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
400 matters, as stated in warning note at begining of %include section).
401 * src/gdcmDicomDir*.[cxx|h]: coding style
402 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
403 * src/gdcmJpeg8.cxx: doxygen fix.
404 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
405 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
406 from File:: to PixelConvert::.
408 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
409 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
410 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
411 - more code moved away from File:: to PixelConvert::
412 - fat setup of PixelConverter set in place in File::Initialise.
414 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
415 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
416 namespace at the file system level. So now you should convert your examples
418 gdcmHeader -> gdcm::Header
419 It would be nice if people keep in mind to no open the namespace, since it
420 allows compilation on broken plateform which were defining common symbol in
421 the standart namespace (like LP, Unknown ...)
423 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
424 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
425 The JPEG fragments are now parsed at the same stage than the RLE
426 information. All code related to JPEG is now in gdcmPixelConvert:
427 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
428 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
429 export a gdcmFile:: method. Those are simply global functions
430 (for the time being this is better than having them attach to
431 either gdcmFile:: or gdcmPixelConvert::).
432 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
433 and stores the result in a gdcmJPEGFragmentsInfo.
434 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
435 code (among other stuff) moved away from gdcmFile:; to
438 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
439 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
440 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
441 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
442 clean up of RLE related code.
443 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
444 - src/gdcmRLE.cxx removed
445 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
446 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
447 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
448 * CLEANUP_ROUND (9) for gdcmPixelConvert
449 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
450 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
451 away from gdcmFile:: to gdcmPixelConvert::.
453 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
454 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
455 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
456 This is because Parse7Fe0 used to parse the pixels to compute the
457 length. This task was passed over to FindDocEntryLengthOB() a long
458 time ago, EXCEPT I had forgotten the OW case...
459 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
460 we just recylce the code for parsing RLE fragments and computing
462 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
463 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
464 with the retired Parse7Fe0().
465 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
466 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
468 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
469 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
470 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
471 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
472 - src/CMakeLists.txt: alphabetic order reodering + new entries.
473 * CLEANUP_ROUND (4) for gdcmPixelConvert
474 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
475 to return an unused length.
477 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
478 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
479 this should be cleanner from the plane view. The iostream are erally a pain
480 to use to do simple stuff.
482 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
483 * Redo the compilation of the ijg jpeg library. Now only one source is
484 necesseray. No need to rename file by hand what so ever. CMake handle the
485 copying of the file within different directory, configure header file to
486 modify some symbol. The only addition made to ijg wasd a mangle table so
487 that symbol are different wether we are within 8bits or 12bits.
489 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * Added documentation of vtkgdcmReader on Website:
491 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
492 with it's binary name).
493 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
494 the Website to be more complete.
495 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
496 doxygenated documentation.
497 - Doc/DoxyVtkGdcmReaderExamples.txt added
498 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
499 DoxyVtkGdmReaderExamples.html )
500 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
501 * CLEANUP_ROUND (3) for gdcmPixelConvert
502 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
504 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
505 * CLEANUP_ROUND (2) for gdcmPixelConvert
506 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
508 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
509 * CLEANUP_ROUND for gdcmPixelConvert:
510 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
511 - src/gdcmPixelStuff[h|cxx] removed
512 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
513 - src/CMakeLists.txt changed accordingly
515 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
516 gdcmVersion.py moved to newly created ATTIC related
517 gdcmPython/SetupOldies/ directory.
518 * Autotools clean up:
519 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
520 - autogen.sh configure.in acinclude.m4 python.m4 removed
522 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
523 * src/*.cxx *.h Reference to License.htm fixed to License.html.
524 * Doc/CMakeLists.txt, doxygen.config.in: fix.
525 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
527 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
528 * TODO updated with Mathieu suggestions. I proposed a template for
529 describing TODO entries and used it for new entries.
530 * Added Doc/Website/CodingStyle.html, Developpers.html,
531 DeveloppersPython.html, GdcmDataCvs.html and
532 DownloadVersion0_1.html, DownloadVersion0_3.html.
533 * Some Doc/*.txt Doxygen files (which do not really concern the
534 documentation itself, but the website) moved to html and
535 placed in directory Doc/Website:
536 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
537 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
538 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
539 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
540 * CMakeLists.txt changed accordingly.
541 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
542 DeveloppersPython.html
543 * INSTALL nows refers to Doc/Website/Installation.html
545 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
546 * Added Doc/Website directory, that contains a first raw version
549 2004-09-23 Jean-Pierre Roux
550 * FIX In order not to be poluted any longer by casting problems,
551 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
552 we can now delete[] it safely
553 * VoidArea is now called BinArea (less confusing name),
554 and all the methods called ...VoidArea... are now ... BinArea...
555 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
557 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
559 clear) TagHT, which is an inherited member of gdcmElementSet. It is
560 up to the destructor of gdcmElementSet to clean up TagHt and it's
563 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
564 * Test/CMakeLists.txt: update to follow gdcmData renamings.
565 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
567 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * ENH: added some utility method that builds a flat dictionnary
569 holding all the Dicom entries contained in the recursive structure
570 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
572 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
573 BuildFlatHashTable() that build a flat dictionary.
574 - src/gdcmElementSet.h: added a new private GetTag() accessor.
575 gdcmDocument is now a friend of gdcmElementSet.
576 - src/gdcmElementSet.cxx: clean up.
577 - Example/FlatHashTablePrint.cxx added.
578 - Example/CmakeLists.txt changed accordingly
580 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
582 moved away from gdcmDocEntrySet (since this class is an abstract class
583 acting like an interface). SQDepthLevel and BaseTagKey are now
585 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
586 and associated accessors. Doxygenation of the class.
587 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
589 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
590 Use SQDepthLevel accessor instead. ::Print() adapted.
591 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
592 - src/gdcmDocument.cxx changed accordingly.
594 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
595 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
596 - The following is the doxygen comment of the typedef declaration
597 of gdcmagKey in src/gdcmCommon.h:
598 gdcmTagKey is made to old an "universal" (as in URL, Universal
599 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
600 A dicom tag allways has a group and an element, but a set of tags
601 embeded in various (optionally nested) sequences and sharing
602 the same group and element all share the same (group, element)
603 "identifier". Hence the (group, element) cannot be used as an
604 identifier (in gdcm we shall refer to a "TagKey") of a tag.
605 In order to construct a proper tag identifier (i.e. a key) we
606 consider the following definition of a TagKey:
607 - let Group, Element be the string representation of the
608 group and element dicom tag members,
609 - let ItemNumber be the string representation of the integer
610 index of the considered item number of a sequence,
611 Let the key of a tag embeded in a sequence, noted SeqTag, be
613 /ItemNumber#Group|Element
614 where "/", "#" and "|" are characters acting as separators.
615 Then the general form of a gdcmTagKey is given by:
616 Group|Element<SeqTag>
617 where <SeqTag> means NO or many instances of SeqTag.
618 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
621 but the gdcmTagKey of a tag "embeded" is the first item of
622 a sequence, itself nested in the third item of a sequence is the
624 0004|1220/2#0008|0082/0#0008|0090
625 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
626 order to hold the new sequence compatible key. Previously, the
627 GetKey() method would look in the underlying gdcmDictEntry.
628 - src/gdcmDocEntry.cxx:
629 -- constructor now copies the underlying DictEntry key, in the local
631 -- ::Print: displays the member Key, instead of the (group, element).
632 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
633 - src/gdcmDocEntrySet.h:xi
634 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
635 -- now has a new BaseTagKey member.
637 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
638 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
640 This poses the problem with the semantics of the following lines
641 LoadEntryVoidArea(0x0028,0x1201); // R LUT
642 LoadEntryVoidArea(0x0028,0x1202); // G LUT
643 LoadEntryVoidArea(0x0028,0x1203); // B LUT
644 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
645 to the long FIXME note for what the problem is. Nevertheless in
646 order to get things working the dicom dictionary was altered !
647 Please fix things urgently...
648 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
649 information), see above note on moving the member VoidArea. Nevertheless
650 the following entries previously correctly set as US are now inproperly
652 0028 1201 OW IMG Red Palette Color Lookup Table Data
653 0028 1202 OW IMG Green Palette Color Lookup Table Data
654 0028 1203 OW IMG Blue Palette Color Lookup Table Data
655 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
656 of gdcmDocEntry moved to gdcmSeqEntry.
657 * src/gdcmSeqEntry.cxx: STYLE.
659 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * Test/TestAllEntryVerify.cxx minor fix and added comments.
662 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
663 * gdcmPython/testSuite.py: all the test suite in python is now moved
664 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
665 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
666 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
668 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
669 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
670 to avoid inclusion recursion until STL is reached.
671 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
672 mecanism. errno.h is not included in gdcm anymore.
673 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
674 (gdcmFormatError now inherits from gdcmFormatUnexpected).
676 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
677 gdcmData/TestAllEntryVerifyReference.txt
678 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
679 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
680 exception_on_error parameter.
681 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
682 - vtk/vtkGdcmReader.cxx changed accordingly,
683 - Example/*.cxx and Test/*.cxx changed accordingly.
685 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
687 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
688 enable_sequences removed from gdcmHeader constructor and dependencies.
689 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
690 * gdcmPython/demo/PrintHeader.py: dummy fix.
691 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
692 skip_shadow removed from gdcmHeader constructor and dependencies.
693 * Example/*.cxx and Test/*.cxx changed accordingly.
695 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
696 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
697 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
699 2004-07-21 Jean-Pierre Roux
700 * FIX Now, Parsing and Printing a DICOMDIR do work!
701 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
703 2004-07-20 Jean-Pierre Roux
704 * FIX Some brain damaged headers have Zero-Lenght fields
705 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
707 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
708 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
709 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
710 variable (instance of gdcmDebug) by a definition macro, and the instance
711 is now in static in the gdcmDebug class
712 * src/gdcmSQItem.h : (FIXME) remove an undefined method
713 * Test/PrintAllDocument.cxx : bug fix in the result of the test
715 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
716 * WARNING: ctest now depends more tightly on gdcmData. You should
717 check out gdcmData properly for things to run smoothly...
718 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
719 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
720 we need the pixels not be loaded in order to use the ValEntry
721 that displays position and size).
722 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
723 This is a C++ based equivalent of gdcmPython/testSuite.py that should
724 be deprecated. If you have any doubts about the advantages of a
725 modern scripting language (read Python) versus grass root C++ (i.e.
726 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
727 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
728 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
729 Anyhow, consider documenting the gdcmData images in
730 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
732 * Test/CMakeLists.txt:
733 - now uses TestAllEntryVerify.cxx
734 - specific comments on oldACR00001.ima (now renamed in gdcmData
735 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
736 gdcmData/TestAllEntryVerifyReference.txt
739 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
740 * src/*.[h|cxx] : typedef clean up
741 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
742 - TagKey renamed to gdcmTagKey (for external usage)
743 - VRKey renamed to gdcmVRKey (for external usage)
744 - removal of typedef duplication.
745 - Removed all unecessary inline keyword from class inline definitions.
746 - Some method|function(void) declarations replaced with method|function().
747 * src/jpeg/libijg12/jdhuff12.c:
748 - printf polluting ctest removed.
749 - TAB removal for comminting
751 - TestAllReadCompareDicom.cxx: added a test that compares all the
752 images in gdcmDataImages.h with corresponding images in
753 gdcmData/BaselineDicom/. When baseline images are not present
754 this test creates them.
755 Note: we need to validate each reference image, but before that
756 I'd like to rename them with a more explicit name...
757 - CMakeLists.txt: changed accordingly.
758 * Example/*.cxx: examples now only include gdcm.h (as opposed to
759 including each header needed).
761 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * Test/*.cxx and Example/*.cxx: moved some examples away from the
763 test suite to the Example directory. Are concerned:
768 - TestWriteSimple.cxx
769 * Test/CMakeLists.txt: added some comments on reasons for black listing
770 image gdcmData/oldACR00001.ima
772 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
773 * Test/CmakeList.txt: removed the following from black list (to be coherent
774 with removal from gdcmData):
775 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
776 - gdcm-MR-PHILIPS-16.dcm
778 Added the following because after last cvs update, they cause
779 ctest -R TestReadWriteReadCompare
781 - gdcm-MR-SIEMENS-16-1.acr
783 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
784 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
785 new comments in this file) we temporarily (sigh) move to a weaker
787 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
788 we don't need to black list the following images anymore:
789 - 8BitsUncompressedColor.dcm
791 - US-PAL-8-10x-echo.dcm
792 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
793 fixes and the beautified code ;-)
794 This fixes the bug introduced in version 1.42 (when beautifying)
795 that made the parsing of 8BitsRunLengthColor.dcm unproper.
796 Note: ctest was blind to this bug (this means we need to still
797 improve the test suite). The bug could be detected by using
798 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
800 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
801 and by displaying the (garbage) produced file temp.XDCM...
803 2004-06-29 Jean-Pierre Roux
804 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
805 - replace by uggly but working old code :-(
806 A lot of things should be OK again.
807 It's really urgent to have a test suite that *tests*,
808 to prevent Frog's beautifying sessions to break all the stuff
809 (twice, withing a fortnigh ...)
811 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
812 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
813 redundancy) to added Test/TestReadWriteReadCompare.cxx
814 * Test/CmakeList.txt: because the compare test of
815 Test/TestReadWriteReadCompare.cxx fails, the following images are
816 black listed: - 8BitsUncompressedColor.dcm
818 - US-PAL-8-10x-echo.dcm
819 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
820 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
821 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
822 and ad-hoc kludge. This kludge is now removed, and on encountering
823 such an image (OB field brain damaged) we set errno. Then in
824 ::FindDocLength() we "fix" the length as being ALL what remains
825 in the file (until EOF). We then proceed, hoping for the best...
826 This fixes a SegFault in ShowDicom when trying to write such an
828 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
829 (because TestWriteRead breaks on it, after a non conformal commit?).
830 ctest now runs properly, except for MakeDicomDir (which was allways
831 broken) and the Python related stuff (still not fixed).
833 2004-06-24 Jean-Pierre Roux
834 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
835 FIX : Test/TestReadWrite now iterates on all the file names
836 (instead of infinite loop)
837 ENH : Test/TestWriteRead now iterates on all the file names
839 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
840 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
842 2004-06-24 Jean-Pierre Roux
843 FIX : - now Write drops LUT Descriptors and LUTs (if any)
844 when SamplesPerPixel =3
845 - now Write is no longer confused by
846 'BitsAllocated = 12" and 'BitsStored=12"
847 - "UN" value representation Elements are now written correctly
848 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
849 ENH : - now gdcmHeader has its own Write methods
850 (in order to split the job that has not to be done
853 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
854 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
855 loop on the same image until memory went out.
856 Note: this means we still have gobs of memory loss in PrintDocument
857 * src/gdcmDocument.cxx: fixes problem on parsing on file
858 gdcmData/16BitsJpegLosslessGrayScale.dcm.
860 2004-06-24 Jean-Pierre Roux
861 FIX : Write - All the Sequences and Sequence Item are now written
862 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
863 is added a the end, when necessary.
864 - A lot of brain-damaged images, that were read correctly are
865 now written correctly
866 - length compatible BinEntry are now loaded correctly
867 (even for odd groups)
868 Note : only Explicit Value Representation was checked.
869 (question : is implicit VR really necessary for gdcm ?)
871 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
872 * DEVELOPPER: added a proposition of coding style.
873 * src/gdcmDocEntry.h: removed every inline declaration (for test of
876 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
878 Use the gdcmDocEntry::Print() and Write() instead.
879 * src/gdcmDocument.cxx: bug fix.
881 2004-06-22 Jean-Pierre Roux
882 FIX : gdcmDocument.cxx
883 - Now we do recognize the JpegLossLess format (there was a misstyping in
884 code 'beautyfication' :-(
885 - Now we automaticaticaly load the Luts, if any
887 2004-06-22 Jean-Pierre Roux
888 In order : to write Sequences, whatever their imbrication level,
889 : to allow user to create his own Sequences
890 a lot of modif where necessary (adding, moving, or virtualising methods)
892 WARNING : save your own sources *before* cvs up !
895 ADD virtual void Write(FILE *fp, FileType filetype);
898 ADD virtual void Write(FILE *fp, FileType filetype);
899 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
902 ADD virtual void Write (FILE *fp, FileType filetype)=0;
903 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
904 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
905 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
906 ADD std::string GetEntryByName(TagName name);
907 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
909 std::string vr = "unkn",
910 std::string fourth = "unkn",
911 std::string name = "unkn");
912 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
913 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
914 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
915 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
916 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
917 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
918 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
919 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
922 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
923 ADD virtual std::string GetEntryByName (TagName tagName);
924 ADD virtual std::string GetEntryVRByName (TagName tagName);
925 REM virtual bool Write(FILE *, FileType);
926 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
927 FILE *_fp, FileType type);
928 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
929 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
930 REM virtual bool WriteEntries(FILE *_fp,FileType type);
931 REM virtual std::string GetEntryByName (std::string tagName);
932 REM virtual std::string GetEntryVRByName (std::string tagName);
933 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
934 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
935 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
937 std::string vr = "unkn",
938 std::string fourth = "unkn",
939 std::string name = "unkn");
940 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
941 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
942 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
943 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
946 ADD virtual void Write(FILE *fp, FileType filetype);
949 ADD virtual void Write(FILE *fp,FileType filetype);
952 ADD virtual void Write(FILE *fp, FileType filetype);
953 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
954 REM std::string GetEntryByNumber(guint16 group, guint16 element);
955 REM std::string GetEntryByName(TagName name);
958 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
960 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
961 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
962 The default constructor invoked by the line
963 gdcmHeader *f1 = new gdcmHeader( header );
964 was gdcmHeader::gdcmHeader(bool) instead of the expected
965 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
966 Hence the parsing wasn't executed... See also below.
967 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
968 as explicit constructor didn't do the trick to fix the above problem.
969 Could anyone explain why ?
970 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
971 properly calls gdcmValEntry::Print() (that was weed out from
972 code related to gdcmBinEntry).
974 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * In order to fix memory leaks:
976 - Test/TestWriteSimple.cxx: added cleaning of free store through
978 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
979 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
980 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
981 (through the call to ::AddDicomDirMeta()) or the destructor
982 would crash when deleting uninitialized ::metaElems].
983 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
984 - src/gdcmDocument.cxx:
985 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
987 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
988 was causing memory leaks.
989 - src/gdcmSQItem.cxx:
990 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
991 cleanly handled with polymophism: sorry but my milage is low).
992 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
993 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
994 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
995 This avoids SegFaulting.
996 - src/gdcmSQItem.h: coding style.
998 - Test/TestWriteSimple still severely sucks. The output image content
999 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1000 damaged when displayed with vtkgdcmViewer.
1001 - on memory leaks: TestWriteSimple leaks really less (see entry
1002 of 2004-06-18 in Changelog file for the call to valgrind).
1003 - on segfaults: ctest now passes all the tests but one (no more
1005 * Erroneous leading white fix:
1006 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1007 white[s] (as opposed to from >> xxx, that removes it [them].
1008 - src/gdcmTS.cxx: ditto.
1009 - gdcmPython/testSuite.py: dirty related kludge removed.
1010 * src/*: remaining references to gdcmParser removed.
1011 * src/*[cxx|h]: added copy[way]left header.
1014 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1015 * In order to fix writing of dicom files:
1016 - Test/TestWriteSimple.cxx: a simpler example of writing.
1017 - Test/CMakeLists.txt changed accordingly.
1018 - src/gdcmDocument.cxx:
1019 -- The destructor now recursilvely removes potential sequences.
1020 -- Bug fix in ::IsJPEG2000()
1021 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1022 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1024 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1025 to only declared) and build on top of
1026 ::GetDocEntryByNumber(guint16, guint16).
1027 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1028 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1029 for usage in destructor and treatement of promotion in
1030 ::ReplaceOrCreateByNumber().
1031 - src/gdcmSQItem.cxx: destructor should better handle his job.
1032 Test/TestWriteSimple now runs (or at least it DOES something).
1033 * We can now start hutting memory links. A good starting point is:
1034 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1035 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1036 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1038 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1039 * Valgrind note: after Mathieu Malaterre teached me how to read
1040 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1042 Using gcc, you can force the STL to use malloc and to free memory as
1043 soon as possible by globally disabling memory caching.
1044 With 3.2.2 and later, you should export the environment variable
1045 GLIBCPP_FORCE_NEW before running your program.
1046 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1047 simply vanish (it is still not clear to me, whether this means that
1048 STL std::string leaks or if valgrind believes it leaks...).
1049 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1050 running bin/gdcmTests makeDicomDir):
1051 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1052 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1054 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1055 SegFaulting (I drowned in DicomDir related code when trying to
1056 understand why the list is empty...).
1057 * src/gdcmDocument.h: first BSD license header try.
1058 * Doc/License.txt added.
1060 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1061 * src/gdcmDocument.[h|cxx]:
1062 - Clean up of the Transfer related predicates. They are now all based
1063 on new method isGivenTransferSyntax, that (should) handle properly
1064 the padding problem.
1065 - general clean up, simplification, and coding style.
1066 - Specific clean up of Parse7FE0() (umproperly named actually).
1067 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1069 2004-06-14 Jean-Pierre Roux
1071 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1072 - fix the display of SQItem ordinal number
1073 - add the GetSQItemByOrdinalNumber method
1074 - remove some useless never written private methods
1076 2004-06-14 Jean-Pierre Roux
1078 - adding a constructor taking a gdcmDocEntry as an input param
1079 - ReplaceOrCreateByNumber now returns :
1080 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1081 a gdcmValEntry * if a string value is passed as a param
1083 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1084 according to the param type (no longer sets a gdcmDocEntry)
1085 - GetValEntryByNumber, GetBinEntryByNumber added
1086 - NewValEntryByNumber and NewBinEntryByNumber added
1088 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1090 - GetSQItemNumber and SetSQItemNumber added, to provide
1091 a (relative) Item identier inside a given Sequence
1092 \warning : some pb remaining around this number
1094 - AddEntry now takes the Item Number as a param
1096 - adding a constructor taking a gdcmDocEntry as an input param
1098 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * Memory leak hunt with the following command:
1100 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1101 --show-reachable=yes gdcmTests PrintDocument
1102 It looks like many (all?) leaks are due to the STL (or a bad usage
1103 of the STL. The lines producing the leaks now have a comment with
1104 a "MEMORY LEAK" tag: you can retrieve them with
1105 grep "MEMORY LEAK" src/*
1106 Here are two typical examples which I can't help fixing:
1111 char * test = "babo";
1112 name = test; //// <--- valgrind detects 960 bytes lost in
1113 //// call to std::string::operator=(char const*)
1114 name.clear(); //// Doesn't help !
1122 std::cout << "Type a bunch of characters followed by RETURN: ";
1123 getline(std::cin, line); //// <--- valgrind dectects a loss
1124 //// of 1320 bytes in call to
1125 /// std::basic_istream<>& std::getline<>
1131 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * src/gdcmHeader.[cxx|h]:
1133 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1134 and related, moved away to gdcmDocument.
1135 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1136 the corresponding protected accessors of inherited class
1137 gdcmDocument, removed ! As a consequence gdcmFile had to be
1138 declared friend of class gdcmDocument (see below).
1139 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1140 - Clean up of undefined or unused methods.
1141 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1142 account the changes to gdcmHeader.h).
1143 * src/gdcmDocument.h:
1144 - gdcmFile is now a friend class (in order to take into account the
1145 changes to gdcmHeader.h).
1146 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1147 (see changes to gdcmHeader.h).
1148 - Accessors (reading on the form GetEntry*) are now public.
1149 - Clean up of undefined or unused methods.
1150 * src/gdcmDocument.cxx:
1151 - adaptation to changes to gdcmDocument.h
1152 - ::OpenFile now writes a verbose message when file cannot be opened.
1153 - some std::string properly set to VRKey
1154 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1155 references to gdcmDocument.
1156 * Test/TestFindTags.cxx: changed accordingly to above changes.
1157 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1158 cvs repository gdcmData.
1160 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1161 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1162 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1163 conflicts with gdcmValEntry::voidArea.
1164 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1165 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1166 Value representation between StringRepresentable and BinaryRepresentable.
1167 * src/gdcmDocument.cxx:
1168 - method ParseDES: proper indentation restored and usage of
1169 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1170 - method LoadDocEntry: the fingerprint left in the SetValue() of
1171 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1172 removed. Reverting to previous code segment with the proper
1173 dynamic_cast< gdcmValEntry* >.
1174 Note: this was (partially) breaking the python test suite
1175 (gdcmPython/testSuite.py) that made usage of the above
1176 fingerprint to check presence of "Pixel Data".
1177 * src/gdcmDocEntry.h: coding style.
1178 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1179 now taken into account.
1180 * gdcmPython/gdcm.i: adaptation to the new internal representation
1181 of gdcm (exit gdcmParser, hello gdcmDocument).
1182 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1184 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1185 anymore, but instead prints the loaded Python dictionary.
1186 * .... alas, the python testSuite is still broken.
1188 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1189 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1191 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1192 * src/gdcmUtil.h : export methods
1194 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1195 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1197 * Initial addition of automatic python testing
1198 * Initial addition of automatic image comparison
1200 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1201 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1202 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1204 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1205 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1206 * Test/ShowDicom.cxx : bug fix for msvc compilation
1207 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1209 2004-05-04 Jean-Pierre Roux
1210 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1211 new concepts (and new classes) :
1212 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1213 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1214 - Sequence Doc Entries (gdcmSeqEntries)
1215 a Sequence is composed of Items.
1216 Each item is a set of Doc Entries (this is recursive)
1217 The non uniqueness of the 'Dicom tag' is due to this recursivity
1218 (never taken into account)
1219 Our unability to add a new 'entry' in the header
1220 at the proper location (neither in the H-Table (map or multimap),
1221 nor in the Chained List is also due to this recursivity.
1222 Don't try, right now, to use/modify/compile these new sources :
1223 nothing is finished.
1224 We just commit all the stuff, 'as is', in order not to loose it.
1226 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1227 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1229 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1230 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1231 file prefix (SetFilePrefix)
1233 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1234 * Add a new test: ShowDicom, for now this is just the c++ version of
1235 checkRead.sh, later it will be able to compare the image read against a
1237 * Replace the DEBUG on the stack with a global entry in cmake interface:
1238 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1240 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1241 * Add an example subdir, with a real example on how to read + write a
1244 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1245 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1246 * Doc/CMakeLists.txt: the main page is now properly differentiated
1247 between the developper and user version.
1248 * Doc/doxygen.config.in: dropped search related obsolete flags
1249 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1251 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1252 * DEVELOPPER: added some helpfull comments for compile/test/install
1255 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1256 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1257 src directory, now generated in the build dir.
1258 2. Tests as mentionned smarter
1260 4. Add a new method in gdcmDict that return the PubDict by name
1261 this is interesting for 3rd party lib like ITK,
1262 where we could set the institution name / patient name...
1264 * ENH: 1. Now the test suite is working for real
1265 2. All binaries are now output in the gdcm-bin directory
1266 (this was not true before)
1268 2004-04-28 Jean-Pierre Roux
1269 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1270 SeQuence indented printing of Dicom Header.
1271 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1272 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1273 Computation of SQDepthLevel is now part of gdcmHeader constructor
1274 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1275 tree-like structure of a Dicom Header.
1276 * FIX Test code cleaning
1278 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1279 * ENH: Adding automatic testing
1280 1. Need a DartConfig.cmake to submit to public
1281 2. Add a test driver gdcmTest.cxx
1282 3. gdcmTestMain, an helper for the main test driver gdcmTest
1283 4. Files in Test don't have a main anymore, this becomes interesting
1284 when we add more and more tests, thus dsw don't have to load
1286 * ENH: Adding a GDCM_DATA_ROOT for testing
1287 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1288 one file instead of seven + some small cleanup
1290 2004-04-22 Jean-Pierre Roux
1291 * ENH Minor changes to the Print() methods.
1292 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1293 Header printing. Example given with :
1294 > PrintHeader fileName 2 new
1295 (SQ based tree-like structure still to be done for the Header ...)
1297 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1298 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1299 1. I have added some unsigned where needed
1300 2. Some function parameter not used -> (void)
1301 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1302 4. g++ don't like character '\' in comment
1303 5. #define jpeg_create_decompress jCreaDecompress
1304 this really need to be fixed
1305 6. virtualize destructor of gdcmObject ... leakage
1306 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1307 this also really need to be fixed
1308 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1309 remove compression file
1310 (as we only do decompression, right ?)
1311 * ENH: Change malloc/calloc/free with c++ equivalent
1313 2004-04-21 Jean-Pierre Roux
1314 * FIX gdcmHeaderHelper::GetXSpacing
1315 when a single value is found (bug ?), xpacing is now
1316 defaulted to yspacing
1318 2004-04-19 Jean-Pierre Roux
1319 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1320 * ENH add parameters :
1321 bool exception_on_error = false,
1322 bool enable_sequences = false,
1323 bool ignore_shadow = false
1324 to the gdcmFile constructors to be full gdcmParser compliant
1325 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1326 to allow reading of PAPYRUS 3.0 files
1328 2004-04-06 Jean-Pierre Roux
1329 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1331 2004-04-02 Jean-Pierre Roux
1332 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1333 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1334 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1336 2004-03-30 Jean-Pierre Roux
1337 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1338 for ACR file, written out as DICOM files (hope so...)
1340 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1341 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1342 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1343 moved to base class gdcmParser and only the specialisation is kept
1345 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1346 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1347 already does the job.
1348 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1349 (to be consistent with gdcmParser::WriteEntries).
1351 2004-03-30 Benoit Regrain
1352 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1353 upate of the object's instance. It's passed to 2 in the unfavorable
1354 case : one in the ExecuteInformation, one in the ExecuteData
1356 2004-03-29 Jean-Pierre Roux
1357 * ENH : Check on file type to be written moved
1358 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1359 * FIX : gdcmObject::ResetBoundaries now stops properly
1360 when end-of-list is reached
1361 : gdcmVersion modified (as Benoit Regrain asked)
1363 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1364 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1365 * src/gdcmUtil.cxx: added forgotten iostream include.
1366 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1367 equivalent to ExplicitVR in existing code).
1369 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1370 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1371 now contains all the gdcmGlobal related code.
1372 * minor coding style and doxygenation changes.
1374 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1375 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1376 now contains all the Debug related code.
1377 * minor clean-up of includes in src/*.cxx
1378 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1379 CreateCleanString) removed.
1380 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1381 * Doc/DoxyMainPageUser.txt added.
1382 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1383 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1384 src/gdcmDirList.cxx)
1386 2004-03-24 Jean-Pierre Roux
1387 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1389 2004-03-23 Jean-Pierre Roux
1390 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1391 big endian made volumes
1392 * ENH Now gdcmParser constructor and destructor are protected to forbid
1393 end user to instanciate class gdcmParser
1394 (only gdcmHeader and gdcmDicomDir are meaningfull)
1396 2004-03-22 Benoit Regrain
1397 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1398 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1399 gdcmSerie to gdcmDicomDirSerie
1401 2004-03-19 Jean-Pierre Roux
1402 * ENH Now the tree-like structure describing a DICOMDIR comming from
1403 an already existing DICOMDIR file is consistent with
1404 the home-made tree-like structure build ex-nihilo
1405 or build from the files held (recursively) in a Directory
1406 functions gdcmDicomDir::CheckBoundaries()
1407 gdcmObject::SetBoundaries() added
1409 2004-03-17 Jean-Pierre Roux
1410 * REM (Eric Boix bug) : removal of meaningless
1411 gdcmDicomDirImage::NewImage function.
1412 * FIX now file names and directory name are written properly in the
1414 * FIX now gdcmDicomDir constructor may be call without any trick
1417 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1418 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1419 of gdcmDicomDirImage::NewImage as empty function.
1421 2004-02-28 Jean-Pierre Roux
1422 * ENH add gdcmDicomDir:NewPatient
1423 add gdcmDicomDirPatient:NewStudy
1424 add gdcmDicomDirStudy:NewSerie
1425 add gdcmDicomDirSerie:NewImage
1426 to allow making gdcDicomDir object.
1427 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1428 (as opposite to the gdcmHeader chained list)
1430 2004-02-11 Benoit Regrain
1431 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1432 when using from python
1434 2004-02-10 Benoit Regrain
1435 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1436 * FIX : in gdcmDicomDir when the directory is empty
1437 * ENH : add callback and methods to get the progression of dicomDir
1440 2004-02-06 Jean-Pierre Roux
1441 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1442 - GDCM_META added to gdcmDicomDirType
1443 - class gdcmMeta created
1444 * ENH : - A brief summary is now displayed at the beginning of
1445 'testDicomDir' to help disaster magnitude estimation
1446 * REM : Now useless Test/explDICOMDIR.cxx
1448 2004-02-05 Benoit Regrain
1449 * ENH : add methods in gdcmObject to get the hash table or the list of
1451 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1452 * FIX : wrapping python for TagHeaderEntryHT
1454 2004-02-04 Benoit Regrain
1455 * FIX : even length for some strings when writting the dicom dir
1456 * FIX : sort the images in the dicom dir
1457 * FIX : Bug fix for python use of dicom dir
1458 * ADD : a python demo
1460 2004-02-04 Jean-Pierre Roux
1461 * FIX : Final solution (?) for icone embedded images
1462 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1463 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1464 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1465 gdcmData/gdcm-MR-SIEMENS-16.acr1
1466 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1467 to make full checking easier
1469 2004-02-04 Benoit Regrain
1470 * FIX : WriteEntries : coding style & logic in parameters
1471 * FIX : Set the elements to create the DicomDir in a dictionary file
1473 2004-02-03 Benoit Regrain
1474 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1475 * gdcmDicomDir : add the load of directory
1476 * Bug fix and print add-on
1478 2004-02-03 Jean-Pierre Roux
1479 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1480 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1481 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1482 * FIX gdcmParser.cxx : 'group length' elements are now considered
1483 as integers, even for shadow groups, when file is Implicit VR
1485 2004-02-02 Jean-Pierre Roux
1486 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1488 of the last synonym :-(
1489 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1491 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1492 * FIX taking into account the possible 7fe0,0010 multiplicity
1493 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1494 to allow removal of references to 7fe0,0010, to deal with
1495 ACR-NEMA images, when 0028,0200 is meaningfull
1497 2004-01-31 Jean-Pierre Roux
1498 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1499 no longer writes 'Un' on disk
1500 * FIX SQ elements with actual length are now dealt with corectly
1501 * FIX gdcmFile::WriteBase make the difference, for color images, between
1502 the length (for Palette expanded images)
1503 and Raw Length (non expanded image + Palette)
1504 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1505 (that broke Write). Replaced by UL.
1506 Aware user will reload the field if he
1507 thinks it's necesssary
1509 2004-01-30 Jean-Pierre Roux
1510 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1511 when 'dirty Acr' is found, to be compliant with the new
1512 IsReadable() methods.
1514 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1515 (no DOUBLE images in kosher DICOM,
1516 but so usefull for people that miss them ;-)
1518 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1519 DICOMDIR related utilities (not checked as Windoze compliant)
1521 2004-01-28 Jean-Pierre Roux
1522 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1524 2004-01-27 Jean-Pierre Roux
1525 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1526 to allow skipping the shadow elements, to save memory space.
1527 The TRUE value for this param has to be used
1528 with a FALSE value for the 'enable_sequence' param.
1529 ('public elements' may be embedded in 'shadow Sequences')
1530 * gdcmHeader methods now deal with 'embedded icones images' in the header
1531 (even when an 'icone image sequence' is announced by the
1532 element (0x0088,0x0200), but there is NO icone at all ...
1534 * gdcmHeader sometimes Image Location value doesn't follow
1535 the supposed processor endianity (see gdcmData/cr172241.dcm).
1538 * gdcmHeader add the method
1539 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1540 to get *all* the Header Entries with the same tag.
1541 GetHeaderEntrySameName is probabely *useless*
1542 (no meaning : Name is *not* an identifier within the Dictionnary)
1544 2004-01-26 Benoit Regrain
1545 * Bug fix in the print of hexadecimal representations. Remove long fields
1546 in the print and add a third level of print to print them
1548 2004-01-23 Benoit Regrain
1549 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1550 * Bug fix on test suite after remove the strip made on not string fields
1551 * Split the IsReadable method between gdcmParser which test that the file
1552 is dicom and gdcmHeader which test that it's an image file
1554 2004-01-22 Benoit Regrain
1555 * DicomDir : clean code, add methods, set variables in protected or private
1556 * gdcmUtil : bug fix for the clean string method
1558 2004-01-19 Benoit Regrain
1559 * Add the use of shadow dictionaries
1560 * bug fix and coding style
1562 2004-01-19 Benoit Regrain
1563 * src/gdcmFile.cxx : bug fix concerning the close of file
1564 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1565 * Add the update of header entries using the shadow library
1567 2004-01-19 Benoit Regrain
1568 * removal of file gdcmHeader2.cxx
1569 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1570 inheriting from gdcmParser. This split is to prepare the integration
1571 of dicom dir parsing
1572 * bug fix under python
1574 2004-01-16 Jean-Pierre Roux
1575 * REM removal of class gdcmHeaderEntrySet
1576 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1577 * ADD add file gdcmHeader2.cxx
1578 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1580 2004-01-15 Benoit Regrain
1581 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1582 entries created while parsing the header. Thus, they will be destroyed
1583 when the gdcmDictSet will be destroyed
1584 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1587 2004-01-15 Benoit Regrain
1588 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1589 made a fatal error because of the memory release at the end of program.
1590 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1591 some memory and vtk seems to have some problems with that.
1592 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1594 2004-01-14 Benoit Regrain
1595 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1596 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1597 * src/*.[h|cxx] : make changes due to class name changes
1598 * gdcmPython/demo/*.py : bug fix due to method names
1600 2004-01-13 Benoit Regrain
1601 * src/*.[h|cxx] : coding style
1602 * vtk/*.[h|cxx] : coding style
1604 2004-01-13 Benoit Regrain
1605 * gdcmPython/testSuite.py : test the readable flag of file for tests
1606 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1607 It's lied to the stl compilation by MSVC (windows, always windows...)
1608 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1610 2004-01-12 Benoit Regrain
1611 * src/*.h : add comments
1612 * src/gdcmDictSet.h : set the method BuildDictPath in public
1613 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1614 directly setted in the source code
1615 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1618 2004-01-09 Benoit Regrain
1619 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1620 * setup.py : use a reference to gdcmVERSION
1622 2004-01-07 Benoit Regrain
1623 * Modification to compile with the distutils.
1626 2003-12-10 Benoit Regrain
1627 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1628 can use a gdcmHeaderHelper to load datas
1629 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1630 made in the source code
1632 2003-12-10 Benoit Regrain
1633 * Update Windows projects and .cvsignore files
1635 2003-11-12 Jean-Pierre Roux
1636 * ENH gdcmHeader constructor has one more parameter (default value : false)
1637 that allows the user to 'go inside' the SeQuences only
1639 gdcmElValSet:Print takes it into account
1641 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1642 * ENH: Update gdcmPython/CMakeLists
1643 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1644 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1646 2003-11-10 Jean-Pierre Roux
1647 * FIX : gdcmHeader::LoadElements is now based
1648 on the ListTag listElem member,
1649 not longer on the TagElValueHT tagHt member
1650 * ENH : PrintPubElVal shows (temporarily) both results,
1651 with the tagHt member and the listElem member.
1652 (it's easier to 'see' the problems when using Printheader)
1654 * FIX : old private member LgrElem is now splitted into
1655 ReadLength : Length actually found on disk (updated only
1656 if bug fixing is necessary), for internal
1658 UsableLength : Updated by FixFoundLength, to fix a bug
1659 or to allow Parser going on.
1660 Will allow to re-write a kosher header when a SeQuence
1661 with a length (not 0000) is found
1662 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1663 because gdcmElValSet::Add does not update ListElem
1666 2003-11-07 Jean-Pierre Roux
1667 * FIX misstyping in Transfert Syntax name table
1668 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1669 when they have an actual length (not 0000 nor FFFFF)
1670 (Nobody should care of it, but DICOMDIR explorers)
1672 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1673 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1675 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * ENH: vtkGdcmReader now supports LUT !
1677 (vtkgdcmViewer for now is not able to use them though)
1679 2003-11-05 Jean-Pierre Roux
1680 * in testSuite.py : new files names for checking the package
1681 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1682 that returns the pixel area size to the *aware* (vtk) user
1683 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1685 2003-11-05 Benoit Regrain
1686 * in testSuite.py : Modify the rules for checking the paths
1687 : Explicit error messages
1688 * in __init__.py : Related modif
1690 2003-11-03 Jean-Pierre Roux
1691 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1692 to be used by aware (vtk) users that want to manage
1693 LUT (and no to turn the PALETTE image into an RGB pixels one)
1694 * GetPixelType now returns 8U for 24 Bits images
1695 (vtkGdcmReader compliant)
1697 2003-10-31 Jean-Pierre Roux
1698 * Removal of *all* gdcmData images and add them again
1699 in order to loose the 'history' of un-anonymised images
1701 2003-10-31 Jean-Pierre Roux
1702 * RMV : removal of useless jBitsInJsample.h
1703 for both 8 and 12 Bits JPEG Lossy Libraries
1705 2003-10-31 Jean-Pierre Roux
1706 * ENH : Add the functions gdcmFile::GetImageDataRaw
1707 gdcmFile::GetImageDataIntoVectorRaw
1708 that act as GetImageData and GetImageDataIntoVector
1709 except the making of an RGB Plane from Gray Plane + LUT
1710 Intended to aware (vtk) users who know how to manage
1713 GetLUTRGBA return a R,G,B,A LUT if any
1714 lgrTotaleRaw gives the 'Raw' length
1715 GetImageDataRaw returns the gray Plane
1716 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1717 (They stay Grey, just like with other Dicom viewers :-(
1719 2003-10-30 Jean-Pierre Roux
1720 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1722 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1723 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1724 being coherents dicom files.
1726 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1727 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1729 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1730 * ENH: Two steps is necessary to please VC++ compiler...
1731 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1732 * ENH: Add include dir to medcon lib
1733 * FIX: only one function is being exported for now !
1734 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1736 2003-10-29 Jean-Pierre Roux
1737 * adding gdcmHeader::GetLUTRGBA
1738 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1739 --> Mathieu, the modif u're waiting for is not yet committed
1740 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1742 2003-10-27 Jean-Pierre Roux
1743 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1744 00191113.dcm DermaColorLossLess.dcm
1745 MxTwinLossLess.dcm RadBWLossLess.dcm
1746 * ENH: For version prior to vtkImageViewer2 -r 1.19
1747 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1749 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1750 * Removal of ido stuff in CMakeLists.txt
1752 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1753 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1754 * FIX: remove a call to ->Modified ... see comments
1755 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1757 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1758 * FIX: Problem with path for libvtkgdcmPython
1759 * ENH: Try adding a search script for python site-package
1760 * RMV: Remove some file from medcon lib that are not necessary
1761 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1762 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1763 * FIX: More pragma disable fro VC++,
1764 I don't think I break something as it is also disable in VTK/ITK.
1765 But it fasten debug compilation time.
1767 2003-10-23 Jean-Pierre Roux
1768 * gdcm now deals with 16 Bits Run Length Encoded images
1769 (they are compressed as 2 planes images,
1770 one for the high Bytes, the other for low Bytes)
1772 2003-10-22 Jean-Pierre Roux
1773 * Now CheckRead takes into account :
1774 - the bugged 'Leonardo' Siemens images
1775 - the XA images, sent thru the burning VPRO station
1776 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1779 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1780 * FIX: When copying a Makefile.am to CMakeLists.txt
1781 one should remove the '\'
1783 2003-10-22 Jean-Pierre Roux
1784 * in gdcmData adding a bugged 'Leonardo' Siemens image
1785 (wrong lengths in header)
1786 OK with gdcm, KO with the other viewers :-)
1787 * add a GE dlx XA image, thru the VEPRO burning station
1790 2003-10-21 Jean-Pierre Roux
1791 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1792 for a brutal checking of vtkgdcmViewer compliance
1794 2003-10-21 Jean-Pierre Roux
1795 * add the files for 'xmedcon' Jpeg Lossless library
1796 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1798 2003-10-21 Jean-Pierre Roux
1799 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1801 2003-10-21 Jean-Pierre Roux
1802 * garbage Siemens 'Leonardo' images dealt with
1803 (the patch is easy to remove)
1804 * cosmetic changes to avoid warnings
1806 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1807 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1808 no need to press 'r' now.
1810 2003-10-20 Jean-Pierre Roux
1811 * upgrade of checkRead.sh checkWrite.sh according
1812 to new Jpeg Lossless decompressor
1813 * add US.3405.1.dcm, a genuine RGB medical file ...
1814 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1815 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1817 2003-10-15 Jean-Pierre Roux
1818 * general anonymisation in gdcmData
1819 * adding the 'color files' from
1820 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1821 * adding some well knowed bugged-header images
1822 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1823 waiting for their inclusion in Python testsuite
1825 2003-10-15 Jean-Pierre Roux
1826 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1827 no longer seg faults when file is not found
1829 2003-10-14 Jean-Pierre Roux
1830 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1833 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1834 * TODO: *.in file to genereate a UseGDCM later
1836 2003-10-14 Jean-Pierre Roux
1837 * Some supposed-to-be Dicom Images have no preamble.
1838 OpenFile takes it into account
1839 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1840 * Missing elements added in dicomV3.dic
1841 (just to be affraid : have a look at
1842 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1843 and do it again next year ;->
1845 2003-10-13 Jean-Pierre Roux
1846 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1847 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1848 But there are NOT. It's fixed !
1850 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1851 * FIX: "jpeglib.h" was not found on VC++
1852 * FIX: vtkgdcm was not being installed
1854 2003-10-10 Jean-Pierre Roux
1855 * ENH : OpenFile closes the file if it *really* doesn't look like
1856 an ACR-NEMA / DICOM one.
1857 * FIX : testWrite no longer writes an empty file if the source file
1858 is not gdcm Readable
1859 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1862 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1863 * FIX: CMake generate now documentation
1864 * ENH: out of source doc build !
1865 * ENH: Generate both user and dev documentation
1866 * ENH: Should work on windows too
1867 * ENH: Only one doxygen config.in file is needed
1868 * FIX: make install should be ok now on ùnix plateform
1869 * FIX: PATH to dictionary was wrong (missing /)
1870 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1872 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1873 * vtkGdcmReader is now able to read rgb dicom file.
1874 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1875 * added a gdcmViewer to vtk test, use mouse to control
1876 window level & window width
1878 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1879 * CMake-ification of gdcm, we have now two build system
1880 * FIX: on cygwin Wsock32 doesn't exist
1881 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1883 2003-10-06 Emanuel Ollart
1884 * FIX : compilation process wad broken.
1885 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1887 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * change gdcmViewer -> vtkgdcmViewer
1889 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1891 2003-10-06 Jean-Pierre Roux
1892 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1893 ( e.g : well known GE images with a wrong elem length,
1894 : Philips MRI Images with a wrong Huffman table)
1895 * still to be done : allow the reading of bugged LEONARDO Siemens images
1897 2003-10-03 Jean-Pierre Roux
1898 * Odd length strings are padded with '\0' (not with spaces,
1899 to remain compliant with already defined strings,
1900 like Transfert Syntax UID and others)
1902 2003-10-03 Jean-Pierre Roux
1903 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1904 to allow displaying RGB images (not only by affim ;-)
1906 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1907 * vtkGdcmReader is now able to read rgb dicom file.
1908 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1910 2003-10-03 Jean-Pierre Roux
1911 * A few nasty patches to allow the reading of a lot of nasty images
1912 ( e.g : well known GE images with a wrong elem length,
1913 : Philips MRI Images with a wrong Huffman table)
1914 * still to be done : allow the reading of bugged LEONARDO Siemens images
1916 2003-10-03 Jean-Pierre Roux
1917 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1919 2003-10-03 Jean-Pierre Roux
1920 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1921 to allow displaying RGB images (not only by affim ;-)
1923 2003-10-03 Jean-Pierre Roux
1924 * gdcmFile::GetImageDataIntoVector now
1925 - deals with MultiFrames MultiFragments Run Length Encoded files
1926 - deals with YcBcR (YBR_FULL) files
1927 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1928 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1930 (no sample found :-(
1932 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1933 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1934 Two reasons: - clear things
1935 - third parties acces gdcm through header files, so won't
1936 suffer anymore VC++ complains
1938 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * add argv[1] in testvtkGdcmReader.cxx
1942 2003-09-24 Jean-Pierre Roux
1943 * The lines are now eigthy characters long.for
1944 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1946 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1947 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1948 char* to std::string. Thus, the use of strdup becomes useless. (see
1949 previous commis of Malaterre)
1950 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1951 before the last Malaterre's commit.
1953 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1954 * This commit should fix the Debug building under VC++, the problem
1955 was mainly a mixture of debug and release lib being loaded at startup.
1956 * I also remove a depency to a specific C function: strdup. Because I had
1957 to force the link to msvcrtd (whereas strdup is in libc).
1959 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1960 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1961 located in the gdcmCommon.h file. All use of reference of tha has been
1962 changed to now use the variable GDCM_UNFOUND.
1964 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1966 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1967 Dicom dictionary. The test suite can now be run again. Note:
1968 I'm note very happy with the " (RET)" changes. I believe this
1969 RETAINED comment should be dropped when parsing the dictionary.
1970 - PACKAGER corrected
1972 - AUTHORS updated and now in alphabetical order
1973 * Makefile.am now exports gdcm.dsw for Windoze users.
1975 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1976 * cygwin complains about missing std:: in subdir Test/
1978 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1979 * remove some methods that are now in gdcmHeaderHelper
1981 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1982 * vtkGdcmReader set spacing and origin correctly
1984 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1985 * Fix a few delete/delete[] mismatch
1987 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1988 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1989 interpretation to data given by gdcmHeader. For instance there are
1990 heuristics to get informations (look at different places).
1991 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1992 sorting DICOM images based on different strategies.
1993 * modified Makefiles accordingly.
1995 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1996 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1997 when building in debug mode
1998 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1999 src/win32/gdcmdll.dsp
2000 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2002 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2003 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2006 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2007 * src/win32/libgdcmjpeg12.dsp was not dos format
2008 * src/win32/libgdcmjpeg12.dsp :
2009 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2010 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2012 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2013 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2015 * src/gdcmFile.cxx : bug fix in affectation type
2016 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2017 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2018 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2019 symbols... future problem ?
2021 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2022 * src/win32/libgdcmijpeg12.dsp was missing
2023 * modified gdcm.dsw accordingly
2025 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2026 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2028 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2029 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2030 commit of JPR (before his hollidays to facilitate our work).
2031 * setup.py : bug fix in code. Modifications made while the last commit
2032 of JPR. The code hasn't been tested before the commit... it's so
2033 useless to make that (for best programmer that is JPR) !!!
2035 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * tagged the current version as Version0_3 (i.e. version 0.3)
2038 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2039 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2040 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2041 * *.dsp : modifications to use new libgdcmijpeg8 library
2042 * setup.py : bug fix on VTKPATH variable
2043 * PACKAGER : adding all concerning windows
2045 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2046 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2048 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2049 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2050 test suite reported error.
2051 * PACKAGER file added (describes what a packager must do when
2052 packaging a new release).
2053 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2054 * configure.in: upgraded version number to 0.3.0
2055 * fixing build of rpm (through rpm -ta):
2056 - Doc/Makefile.am exports proper doxygen files
2057 - src/jpeg/libijg8/Makefile.am exports the include files.
2059 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2060 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2061 * src/gdcmHeader.h : formatting code
2063 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2064 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2065 We were obtaining error message from vtk. Now, creation of file list
2066 is made in an internal list to prevent this problem.
2067 Bug fix when output is empty.
2068 Bug fix in update of progress value. Previous commit for this was a bad
2070 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2072 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2073 * src/gdcmHeader.h : added method to get the file name
2074 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2075 files. Added method to remove all files on the input
2076 Added FIXME comment concerning the bad parsing of header made by
2077 ExecuteInformation method (in ExecuteData method)
2079 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2081 when using make instal.
2082 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2083 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2085 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2086 * setup.py : adding include dir of jpeg lib to compile all sources
2087 * */Win32/*.dsp : JPR fix for windows compilation
2089 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2090 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2092 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2093 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2095 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2096 * setup.py is again effective on un*x (takes into account the
2097 addon of the jpeg library)
2098 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2099 * Doc/Doxy* updated (includes above enhancements)
2100 * INSTALL now points to web documentation
2102 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2103 * src/gdcmHeader.h doesn't make unnecessary reference to
2105 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2107 * src/gdcm*.[cxx|h] :
2108 - to allow compilation with gcc 3.x
2109 -- clean up of STL usage (added explicit usage of std::)
2110 -- small fixes on exceptions.
2111 Note: linking not tested !
2112 - clean of doxygen comments to avoid warnings at documentation
2114 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2115 dependent convertion).
2117 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2118 * Clean up of previous JPR garbage commit (not even commented in the
2120 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2121 - moved all jpeg related files from src to src/jpeg/libijg8, with
2122 addition/modification of Makefile.am and configure.in.
2123 - the testSuite is still brain damage (not guilty).
2125 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2126 * WrapVTK.py : modifications to get correctly vtk source files to
2128 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2129 (FileName -> Filename)
2131 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2132 * vtk/vtkGdcmReader.[cxx/h]:
2133 - UpdateProgress method should now be effective
2134 - removed the limitation on having only images loaded (as opposed
2136 - when building a stack of images/volume, a lesser number of
2137 gdcmHeader and gdcmFile instances should be used (hopefully
2138 accelerating things).
2139 - when building a stack of images/volumes, files which are not
2140 loadable (wrong path-filename, wrong permissions on existing file,
2141 or file not parsable by gdcm) are replaced with a black image
2142 in the stack (for the caller to notice the problem).
2144 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2145 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2147 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2148 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2149 between standard library (std) and vtk library (problems are found
2150 under Windows... thanks Windows !)
2152 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2153 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2155 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2157 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2158 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2160 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * When compiling with distutils (see setup.py) the C++ compiler is
2162 called with different flags than the default ones (with automake).
2163 In order to fix all those warning, I compiled gdcm with the command
2164 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2165 and went for warning fixes:
2166 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2167 up from unused variables.
2168 - vtk/vtkGdcmReader.cxx: potential bug fix.
2169 * src/gdcmHeader.h: Doxygen warning cleanup
2171 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2172 * gdcmPython/gdcm.i:
2173 - typemaps correction to take into account the systematic replacement
2174 of "using namespace std" with std:: prefix e.g. std::list,
2175 std::string... (cf changes of 2003-05-21).
2176 - gdcmGlob global variable of type gdcmGlobal (defined in
2177 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2178 exported to Python a as cvar.
2179 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2180 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2181 gdcmDictSet.GetPubDictTagNames() and
2182 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2183 C++ static methods).
2184 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2185 with the above changes.
2187 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2188 * setup.py, manifest.in : bug fix under linux
2190 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2191 * Modification of setup.py to compile vtk part too. Then, we have 2
2192 wrappers which must work with same distutils. For that, we have a
2193 generic distutils in distusiltsWrapping.py ; with :
2194 - build_extWrap class to wrap generically all extensions,
2195 - ExtensionWrap base class for all wrapping extension that contains
2197 - Wrapper interface which wrap sources
2198 + In WrapSwig.py we have extension and wrapper for Swig
2199 + In WrapVTK.py we have extension and wrapper for VTK
2200 * MANIFEST.in : modifications to consider vtk directory and new python
2201 files for compilation
2203 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2204 * Added python wrappers of vtkGdcmReader vtk class (see the
2205 source in vtk/vtkGdcmReader.cxx) :
2206 - vtk/Makefile.am now builds a library
2207 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2208 python library (as opposed to _gdcm.so wich are the python
2209 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2210 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2212 - configure.in has an additional flag --enable-vtk that needs
2213 to be set to enable compilation of vtk related code, that is:
2214 + vtk/vtkGdcmReader.so and
2215 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2216 + gdcmPython/vtkgdcmPython.so (see above)
2217 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2218 be read when compressed or when HighBit + 1 != BitsStored),
2219 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2220 the usage of the python wrapper of vtkGdcmReader vtk class.
2221 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2222 * src/*.[h] all occurences of stl classes are now prefixed with
2223 std::, and all occurences of "using namespace std;" where removed.
2224 This is to avoid pollution of global namespace in included files.
2225 Apparently vtk does not avoid this pitfall: when using both
2226 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2227 collision of various stl members (principally cout...).
2228 * gdcmPython/testSuite.py now cleanly removes temprory generated
2230 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2231 comply with above changes)
2233 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2234 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2235 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2236 vtk data structure (an image Flip was required).
2237 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2238 * cosmetic changes in documentation.
2240 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2241 * src/gdcmHeader.cxx: the constructor no longer exits when an
2242 unexisting file is given as argument.
2243 * The subdirectory Data (containing all the images used for the
2244 test suite) is not part of this repository anymore. A new module
2245 containing those images is now available at
2246 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2247 with the name gdcmData.
2248 All the python scripts (including the package initialisation file
2249 gdcmPython/__init__.py) were adapated to take this change into
2250 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2252 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2253 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2254 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2255 demo of the usage of this class.
2256 Compilation of this vtk part is only done when using the --enable-vtk
2257 at configure (or autogen.sh) stage.
2259 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2260 * More memory link related corrections and documentation fixes.
2262 - maximum info is obtained with a command of the form:
2263 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2264 --show-reachable=yes PrintHeader
2265 - the remaining reachable blocks seem to come from the STL
2266 allocation scheme through the usage of map and list. It looks
2267 like this memory cannot be freed but it is not a memory leak
2268 (in fact further invocation to the STL would recollect the
2269 unused memory allthough it cannot explicitely be freed).
2270 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2271 of displaying an image parsed with gdcm and displayed with VTK.
2272 Note: some images don't seem to work e.g.
2273 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2274 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2275 Allthough this weakens the semantics, it is a ditch attempt to
2276 make gdcm more thread friendly.
2278 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2279 * Memory link hunt (by using valgrind through the command
2280 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2281 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2282 gdcmHeader::_dicom_vr.
2283 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2284 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2286 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2288 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2289 * src/Makefile.am now exports all the necessary include files at
2293 * UpdateGroupLength replaced by new one
2296 * UpdateGroupLength re-written using H-Table
2297 (named UpdateGroupLengthNew untill checks are over)
2299 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2300 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2301 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2303 - gdcmHeader::GetPubElValSet removed.
2304 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2305 UpdateGroupLength, WriteElements, Write.
2306 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2307 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2308 carried the same semantics.
2309 - src/gdcmHeaderIdo.cxx changed accordingly.
2310 - gdcmFile::WriteBase now regroups all the codes from previous
2311 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2312 - enum FileType moved to gdcmCommon.h
2313 * src/gdcmHeader.cxx AddDefault trashed
2314 * gdcmGetXSize added
2315 * getimageDataSize now calls gdcmGetXSize
2316 * Test/*.cxx changed to agree with above changes
2318 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2319 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2320 (to avoid double call by end user).
2321 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2322 by end user, since gdcmHeader::gdcmHeader now handles it.
2324 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2325 * gdcm/Doc many doxygen changes:
2326 - Doxyfile now has two different versions, DoxyfileUsers that generates
2327 the html.users end users oriented documentation and
2328 DoxyfileDeveloppers that generates the html.developper developper
2329 oriented documentation.
2330 - README changed accordingly
2331 - requirement.txt removed (old design info moved to TODO).
2332 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2333 DoxyMainPage.txt, DoxyPython.txt provide more information.
2334 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2335 be updated by simply regenerating the docs with doxygen and copying
2336 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2337 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2338 all the tests in the form "if (<map>.count() >1)" were removed.
2339 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2340 ill-formed documentation sections.
2341 * src/gdcmHeader.cxx: ditto
2343 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * setup.py fixed for un*x (needed macro for stdint.h)
2345 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2346 un*ces with sh-utils test utility.
2347 * gdcmPython/demo/test.py renamed to PrintHeader.py
2348 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2349 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2350 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2351 * src/gdcm*.cxx JPR's bad inclusion fixed.
2353 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2354 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2355 * gdcmPython/demo/test.py changed accordingly.
2357 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2358 * gdcmPython/Makefile.am fixed linking against libstdc++
2359 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2360 * Swig subdir (historical tests of swig version 1.3.17++) removed
2361 * Test/testChangeEntete.cxx some lines commented out in order to make
2363 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2364 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2366 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2367 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2368 hence the user doesn't need this explicit call.
2369 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2370 i.e. LoadElements() call removed.
2371 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2372 - src/Makefile.am declares the proper flag for g++.
2373 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2374 for adding user defined new tags.
2375 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2376 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2377 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2379 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2380 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2381 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2382 src/Makefile.am : the project should properly compile and install
2383 with the autotools, included the python wrappers part.
2384 * gdcm.spec.in : added a spec file for RPM packaging.
2386 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2387 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2389 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2390 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2391 to exported to the environement (see gdcmPython/testSuite.py
2393 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2394 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2395 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2396 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2397 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2399 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * gdcmPython/__init__.py doesn't crash anymore when running in
2401 in InstallMode or PreInstallMode but with an environement given
2402 value of GDCM_DICT_PATH.
2403 * src/gdcmDictSet.[cxx/h] coding style.
2405 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2406 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2407 * src/gdcm.h general comments moved to TODO, and README
2408 * src/gdcm.h should now be seen as a user commodity (including it
2409 should suffice to fully use gdcm). It is nowhere including within
2410 any of the kernel files src/*.cxx and src/*.h.
2412 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2413 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2414 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2416 * src/gdcm*.cxx only include their corresponding include file
2417 (as opposed to gdcm.h)
2418 * gdcmPython/gdcm.i changed accordingly
2419 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2420 the autogen.sh generated "make snapshot" command to work.
2421 * autogen.sh removed history related references to crea package.
2423 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2424 * distutilsSwigCPlusPlus.py work around some swig portability
2427 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2428 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2429 was done in a last ditch attempt to get setup.py _really_
2430 operationnal. The python/gdcmPython layaout add the advantage
2431 of hidding away the python related distutils specific files
2432 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2433 Alas, the src directory was out of scope (i.e. it's relative
2434 position to setup.py was ../src) which made things impossible to
2435 handle (see previous version of python/setup.py). Crossing fingers...
2437 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2438 * python/setup.py now works on Un*x. (harder than I thougth)
2439 * python/distutilsSwigCPlusPlus.py can now have include files
2440 among the list of sources.
2442 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2443 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2444 * modifications in MSVC projects
2446 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * As stated by the first lines of Test/ExceptionAndPython/README, it
2448 looks like we can move back to original usage of exception within
2449 src/gdcm* and hence remove the errno stuff that was introduced
2450 as a quick and dirty fixture of this problem (added to the TODO).
2451 * Doc/Doxyfile configuration file for Doxygen and corresponding
2452 README file for usage added.
2453 * Test/testWrite.cxx added. This new test comes from a split of
2454 test.cxx that is now reverted to its original purpous i.e.
2455 testing the proper parsing of a Dicom related file.
2456 testWrite.cxx concentrates on testing the IO part of gdcm.
2457 * Test/bug1.cxx (containing a bug on WIn32) added.
2458 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2459 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2460 whose purpose is to publish the content of the TagNames of the
2461 Dicom public dictionnary were not accessible without an
2462 instance of class gdcmHeader.
2463 - those methods are now static methods of gdcmDictSet and hence
2464 require no instances at all to be invocated.
2465 - within gdcmDictSet this change required to change some method
2466 to class methods (i.e. are now static) among which SetDictPath
2467 (renamed to BuildDictPath) and LoadDefaultPubDict.
2468 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2469 the above changes by calling the new method classes of gdcmDictSet.
2470 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2471 the above to be effective.
2472 * python/gdcmPython: in order to wrap properly the above changes
2473 for Python, swig version now needs to be > 1.3.17.
2474 * python/gdcmPython/Makefile fixed to adapt itself to new
2475 configure/make shema introduced by Johan Montagnat (thanks for the
2476 contribution). Alas this Makefile cannot be turned into a proper
2477 Makefile.am without some heavy changes in the configure.in
2478 (for python dectection).
2479 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2480 now avoids publishing the empty entries.
2482 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2483 * python/setup.py : bug fix concerning install under windows
2484 ExtraPath reused :-P
2485 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2487 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2488 * Dicts/dicomV3.dic : remove double spaces !!!
2489 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2490 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2493 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2494 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2495 method. Doxygenation.
2496 * src/gdcm.h clean up of JPR spurious comments.
2498 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * python/distutilsSwigCPlusPlus.py now properly collects the
2500 shadow classes generated by "swig -c++" (gdcm.py in our case)
2501 when using "python setup.py install".
2502 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2503 reexports the working classes.
2504 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2505 by the classical C errno scheme. This is to prevent an obscure
2506 behavior of the python wrappers when importing wxPython.wx prior
2507 to gdcmPython (which ended up in an abort call). An illustration
2508 of this oddity can be found in the Test/ExceptionAndPython
2509 subdir (see the README file). This problem probably due to
2510 an combination of g++ and dynamic loading.
2511 * added Test/ExceptionAndPython (see above)
2513 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * Changed the layout of the python part to avoid bloating main
2515 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2516 i.e. the distutils arsenal. All the python related stuff is
2517 again in a python subdir, but the package itself is now in
2519 * setup.py was cleaned up:
2520 - pythonIncludePath removed
2521 - python setup.py bdist target is now functional.
2522 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2523 collision with other packages). gdcmPython/demo/*.py changed
2526 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2527 * python subdir moved to gdcmPython (preparation of distutils packaging).
2528 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2529 distutils installer is operational.
2530 * - gdcmPython/__init__.py now properly loads the swig generated
2531 shadow classes (from gdcm.py).
2532 - gdcmPython/demo/*.py changed to import the package gdcmPython
2533 instead of gdcmPython/demo/load.py.
2534 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2536 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2538 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2539 entries within the associated public Dicom dictionary resp. the same
2540 information but sorted by the fourth field (PAT, IMG, DIR) of the
2542 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2543 are now in the "???" group.
2544 - python/gdcm.i changed accordingly,
2545 - python/demo/printGroupedPublicDict.py added, that gives an example
2546 of the above new functionalities in Python.
2548 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2549 * src/gdcm.h, gdcmHeader.cxx:
2550 - historic references to glib's g_malloc and g_free (#defined)
2551 were definitively removed.
2552 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2553 * src/gdcmElValSet.cxx:
2554 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2555 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2556 - GetElValue(string) renamed to GetElValueByName.
2557 - Added GetElementByName(string).
2558 * src/gdcmHeader.cxx: added
2559 - GetPubElValRepByNumber(guint16, guint16)
2560 - GetPubElValRepByName(string)
2561 - GetShaElValRepByNumber(guint16, guint16)
2562 - GetShaElValRepByName(string)
2563 - GetShaElValByNumber(guint16, guint16)
2564 - GetShaElValRepByName(string)
2565 - GetElValRepByNumber(guint16, guint16)
2566 - GetElValRepByName(string)
2567 - GetElValByNumber(guint16, guint16)
2568 - GetElValRepByName(string)
2569 * Doc/requirements.txt added.
2571 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2572 * Test/Makefile building now depends on the one of libgdcm.so
2573 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2574 pixel data) aware which enables finding the address (offset) of
2575 the pixel data of JPEG encoded DICOM files. This leaves only a single
2576 file in the testSuite whose pixel data address (offset) is unknown.
2577 * python/testSuite.py changed accordingly.
2579 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2580 * VC++ has some strong limitations when working with the STL, as stated
2581 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2582 "Also note that some STL containers (map, set, queue, list, deque)
2583 cannot be exported. [...]
2584 Some STL classes contain nested classes. These classes can not
2586 This is caused by a designed limitation that once a template
2587 class is instantiated, it can not be re-instantiated and
2589 Since our usage of map<> is ubiquitous in gdcm, this "designed
2590 limitation" of VC++ is a pitfall.
2591 Hence the Python wrappers of gdcm cannot be incrementally linked
2592 against the c++ dynamic library. The dirty but only workaround is
2593 to forget about incremental link of dynamic libraries and to generate
2594 the Python wrappers library with the inclusions of the underlying C++
2596 The following modifications concern this matter on Win32/VC++:
2597 - wrapping python correct with standalone wrapped dll (don't use separate
2598 dll under windows !!!!)
2599 - python21_d debug mode enabled (ask Frog how to use it :-)
2600 - NO problem with having an STL member of class for example string in C++
2601 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2602 - Python test of dcmlib in Python is ok under windows on a large set
2604 * removed glib references
2605 * typedef's inserted in gdcm.i for correct swig type management
2607 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2608 * python/demo/*.py load.py extracted from test.py. Added explore.py
2609 that only displays required tags and testAll.py that parses all
2610 the files of the testsuite without using unittest.
2611 * python/testSuite.py other additional test on new files added.
2612 * Data/* new test files added accordingly to the testSuite.
2613 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2614 the vr in the file differs from the one of the dictionary.
2616 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2618 values, but limits itself to values which are below a user specified
2619 size (by default 1024 bytes).
2620 * python/gdcm.i : elements not loaded (because their size is above the
2621 user specified treshold) are exported with their TagKey as key of the
2622 python dictionary. This enables the testsuite to make some checks
2623 on the unloaded elements (since we have their offset and size).
2624 * python/testSuite.py
2625 - now tests for the existence and proper value of the pixel data
2626 - two new examples added.
2627 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2629 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2631 aware. See the strategy comments in gdcmHeader::FindeLength().
2632 * Test/test.cxx now accepts a filename as first argument.
2633 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2634 * python/testSuite.py changed to integrate test on above files.
2636 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2637 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2638 the vr was also RET.
2639 * python/testSuite.py more tests added.
2641 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * python/testSuite.py unittest test suite added (uses Data)
2643 * Data/* dcm and acr files for the test suite.
2644 * glib dependance removed from un*x version. We now use ISO C99
2645 7.18 Integer types (see stdint.h)
2646 - python/Makefile, src/Makefile src/gdcm.h
2647 * src/ when an explicit vr (like dicom files) suddenly poped an
2648 implicit element we use to mark the underlying DictEntry of the
2649 concerned ElValue with "Implicit". This strategy was damageable
2650 too the public or provite dictionaries, since some of their vr
2651 would be changed. Since Header::FindLength heavily relies on the
2652 detection by Header::FindVR of falsely explicit elements, I
2653 added an extra ImplicitVr member to ElValue (boolean).
2654 The rest of the changes we the necessary adaptations.
2656 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2659 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2661 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2662 * Adaptation for porting to VC++:
2664 o forced to use std namespace (for string to be known)
2665 o all class use __declspec export style on WIN32
2666 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2667 (in stdlib.h on Win32 but in std:: for gcc)
2668 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2669 variable GDCM_DICT_PATH.
2670 * src/gdcmHeader.cxx verbose comments made discrete.
2672 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2673 * python/gdcm.i: added a typemap that converts a C++ hashing table
2674 to native Python dictionary.
2675 * python/demo/test.py:
2676 - now uses the native dictionary for exploration of gdcmHeader.
2677 - takes an optional filename argument (the file to parse).
2678 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2679 PubElVals hashing table.
2680 * Dicts/dicomV3.dic removed error prone trailing spaces.
2682 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2683 * Python wrapping process moved away from src/Makefile to
2684 newly created python/Makefile (as well as gdcm.i)
2685 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2686 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2687 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2688 from the environement variable GDCM_DICT_PATH (when existing).
2689 * src/gdcmDict::GetTag bug fix.
2691 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * Straightforward temporary fixes for swig to build the python wrappers.
2693 src/Makefile now has a python working entry [by working we mean
2694 that we can import de shadow classes without errors].
2696 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * hashtest.cxx removed (since allready in Test)
2698 * src/gdcmlib.h renamed to src/gdcm.h
2699 * src/dcm.i renamed to src/gdcm.i
2700 * src/Makefile prepared for python wrapping
2702 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * src/gdcmHeader.cxx :
2704 - Parsing of header is now separated from loading of element values
2705 (see gdcmHeader::LoadElements).
2706 - general clean up of hopefully all file access (creation of
2707 ReadInt16 and ReadInt32)
2709 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2710 * src/gdcmHeader.cxx :
2711 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2713 - SetLgrElem renamed to SetLength
2714 - GetLgrElem renamed to GetLength
2715 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2716 * src/gdcmElValSet.cxx fixed both GetElValue methods
2717 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2718 due to IdoDude was cleaned out.
2720 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2722 concentrates on finding the value representation (when it exists).
2723 RecupLgr now only finds the element value length, and it avoids
2724 returning the unecessary skL (skipped length).
2725 Also, offsetCourant was simply removed (with taille_fich) since
2726 it was redundant with the File position internals (by using
2727 ftell and fseek). This also made skL (see above in RecupLgr) usage
2729 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2730 on the libido specificities which are handled through class
2732 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2735 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * Truckload of changes. Parsing of header is barely functional
2737 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2739 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2740 * src/gdcmHeader.cxx many addons of low level methods
2742 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2744 and _IdDcmSWAP_LONG.
2746 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * This corresponds to all the changes decided at the meeting of
2748 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob