1 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * In order to fix memory leaks:
3 - Test/TestWriteSimple.cxx: added cleaning of free store through
5 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
6 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
7 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
8 (through the call to ::AddDicomDirMeta()) or the destructor
9 would crash when deleting uninitialized ::metaElems].
10 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
11 - src/gdcmDocument.cxx:
12 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
14 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
15 was causing memory leaks.
17 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
18 cleanly handled with polymophism: sorry but my milage is low).
19 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
20 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
21 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
22 This avoids SegFaulting.
23 - src/gdcmSQItem.h: coding style.
25 - Test/TestWriteSimple still severely sucks. The output image content
26 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
27 damaged when displayed with vtkgdcmViewer.
28 - on memory leaks: TestWriteSimple leaks really less (see entry
29 of 2004-06-18 in Changelog file for the call to valgrind).
30 - on segfaults: ctest now passes all the tests but one (no more
33 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
34 * In order to fix writing of dicom files:
35 - Test/TestWriteSimple.cxx: a simpler example of writing.
36 - Test/CMakeLists.txt changed accordingly.
37 - src/gdcmDocument.cxx:
38 -- The destructor now recursilvely removes potential sequences.
39 -- Bug fix in ::IsJPEG2000()
40 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
41 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
43 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
44 to only declared) and build on top of
45 ::GetDocEntryByNumber(guint16, guint16).
46 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
47 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
48 for usage in destructor and treatement of promotion in
49 ::ReplaceOrCreateByNumber().
50 - src/gdcmSQItem.cxx: destructor should better handle his job.
51 Test/TestWriteSimple now runs (or at least it DOES something).
52 * We can now start hutting memory links. A good starting point is:
53 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
54 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
55 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
57 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * Valgrind note: after Mathieu Malaterre teached me how to read
59 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
61 Using gcc, you can force the STL to use malloc and to free memory as
62 soon as possible by globally disabling memory caching.
63 With 3.2.2 and later, you should export the environment variable
64 GLIBCPP_FORCE_NEW before running your program.
65 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
66 simply vanish (it is still not clear to me, whether this means that
67 STL std::string leaks or if valgrind believes it leaks...).
68 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
69 running bin/gdcmTests makeDicomDir):
70 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
71 - Test/makeDicomDir.cxx now properly traps empty lists and returns
73 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
74 SegFaulting (I drowned in DicomDir related code when trying to
75 understand why the list is empty...).
76 * src/gdcmDocument.h: first BSD license header try.
77 * Doc/License.txt added.
79 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
80 * src/gdcmDocument.[h|cxx]:
81 - Clean up of the Transfer related predicates. They are now all based
82 on new method isGivenTransferSyntax, that (should) handle properly
84 - general clean up, simplification, and coding style.
85 - Specific clean up of Parse7FE0() (umproperly named actually).
86 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
88 2004-06-14 Jean-Pierre Roux
90 - fix the display of Sequence Delimitor (SQDepthLevel pb)
91 - fix the display of SQItem ordinal number
92 - add the GetSQItemByOrdinalNumber method
93 - remove some useless never written private methods
95 2004-06-14 Jean-Pierre Roux
97 - adding a constructor taking a gdcmDocEntry as an input param
98 - ReplaceOrCreateByNumber now returns :
99 a gdcmBinEntry * if a Binary (void *) value is passed as a param
100 a gdcmValEntry * if a string value is passed as a param
102 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
103 according to the param type (no longer sets a gdcmDocEntry)
104 - GetValEntryByNumber, GetBinEntryByNumber added
105 - NewValEntryByNumber and NewBinEntryByNumber added
107 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
109 - GetSQItemNumber and SetSQItemNumber added, to provide
110 a (relative) Item identier inside a given Sequence
111 \warning : some pb remaining around this number
113 - AddEntry now takes the Item Number as a param
115 - adding a constructor taking a gdcmDocEntry as an input param
117 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
118 * Memory leak hunt with the following command:
119 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
120 --show-reachable=yes gdcmTests PrintDocument
121 It looks like many (all?) leaks are due to the STL (or a bad usage
122 of the STL. The lines producing the leaks now have a comment with
123 a "MEMORY LEAK" tag: you can retrieve them with
124 grep "MEMORY LEAK" src/*
125 Here are two typical examples which I can't help fixing:
130 char * test = "babo";
131 name = test; //// <--- valgrind detects 960 bytes lost in
132 //// call to std::string::operator=(char const*)
133 name.clear(); //// Doesn't help !
141 std::cout << "Type a bunch of characters followed by RETURN: ";
142 getline(std::cin, line); //// <--- valgrind dectects a loss
143 //// of 1320 bytes in call to
144 /// std::basic_istream<>& std::getline<>
150 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
151 * src/gdcmHeader.[cxx|h]:
152 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
153 and related, moved away to gdcmDocument.
154 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
155 the corresponding protected accessors of inherited class
156 gdcmDocument, removed ! As a consequence gdcmFile had to be
157 declared friend of class gdcmDocument (see below).
158 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
159 - Clean up of undefined or unused methods.
160 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
161 account the changes to gdcmHeader.h).
162 * src/gdcmDocument.h:
163 - gdcmFile is now a friend class (in order to take into account the
164 changes to gdcmHeader.h).
165 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
166 (see changes to gdcmHeader.h).
167 - Accessors (reading on the form GetEntry*) are now public.
168 - Clean up of undefined or unused methods.
169 * src/gdcmDocument.cxx:
170 - adaptation to changes to gdcmDocument.h
171 - ::OpenFile now writes a verbose message when file cannot be opened.
172 - some std::string properly set to VRKey
173 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
174 references to gdcmDocument.
175 * Test/TestFindTags.cxx: changed accordingly to above changes.
176 * gdcmPython/testSuite.py: adapted to renaming of acr files in
177 cvs repository gdcmData.
179 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
180 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
181 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
182 conflicts with gdcmValEntry::voidArea.
183 * src/gdcmValEntry.cxx: unmatching comment wiped out.
184 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
185 Value representation between StringRepresentable and BinaryRepresentable.
186 * src/gdcmDocument.cxx:
187 - method ParseDES: proper indentation restored and usage of
188 gdcmVR::IsVROfGdcmStringRepresentable wired in.
189 - method LoadDocEntry: the fingerprint left in the SetValue() of
190 unloaded entries (length > MaxSizeLoadEntry) had curiously been
191 removed. Reverting to previous code segment with the proper
192 dynamic_cast< gdcmValEntry* >.
193 Note: this was (partially) breaking the python test suite
194 (gdcmPython/testSuite.py) that made usage of the above
195 fingerprint to check presence of "Pixel Data".
196 * src/gdcmDocEntry.h: coding style.
197 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
198 now taken into account.
199 * gdcmPython/gdcm.i: adaptation to the new internal representation
200 of gdcm (exit gdcmParser, hello gdcmDocument).
201 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
203 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
204 anymore, but instead prints the loaded Python dictionary.
205 * .... alas, the python testSuite is still broken.
207 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
208 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
210 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
211 * src/gdcmUtil.h : export methods
213 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
214 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
216 * Initial addition of automatic python testing
217 * Initial addition of automatic image comparison
219 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
221 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
223 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
225 * Test/ShowDicom.cxx : bug fix for msvc compilation
226 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
228 2004-05-04 Jean-Pierre Roux
229 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
230 new concepts (and new classes) :
231 a 'gdcmDocument' is composed of a set of Doc Entries, that are
232 - elementary gdcmDocEntries (former gdcmHeaderEntries)
233 - Sequence Doc Entries (gdcmSeqEntries)
234 a Sequence is composed of Items.
235 Each item is a set of Doc Entries (this is recursive)
236 The non uniqueness of the 'Dicom tag' is due to this recursivity
237 (never taken into account)
238 Our unability to add a new 'entry' in the header
239 at the proper location (neither in the H-Table (map or multimap),
240 nor in the Chained List is also due to this recursivity.
241 Don't try, right now, to use/modify/compile these new sources :
243 We just commit all the stuff, 'as is', in order not to loose it.
245 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
248 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
250 file prefix (SetFilePrefix)
252 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
253 * Add a new test: ShowDicom, for now this is just the c++ version of
254 checkRead.sh, later it will be able to compare the image read against a
256 * Replace the DEBUG on the stack with a global entry in cmake interface:
257 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
259 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
260 * Add an example subdir, with a real example on how to read + write a
263 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
265 * Doc/CMakeLists.txt: the main page is now properly differentiated
266 between the developper and user version.
267 * Doc/doxygen.config.in: dropped search related obsolete flags
268 * src/gdcmParser.h, gdcmHeader.h: doxygenation
270 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
271 * DEVELOPPER: added some helpfull comments for compile/test/install
274 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
275 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
276 src directory, now generated in the build dir.
277 2. Tests as mentionned smarter
279 4. Add a new method in gdcmDict that return the PubDict by name
280 this is interesting for 3rd party lib like ITK,
281 where we could set the institution name / patient name...
283 * ENH: 1. Now the test suite is working for real
284 2. All binaries are now output in the gdcm-bin directory
285 (this was not true before)
287 2004-04-28 Jean-Pierre Roux
288 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
289 SeQuence indented printing of Dicom Header.
290 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
291 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
292 Computation of SQDepthLevel is now part of gdcmHeader constructor
293 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
294 tree-like structure of a Dicom Header.
295 * FIX Test code cleaning
297 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
298 * ENH: Adding automatic testing
299 1. Need a DartConfig.cmake to submit to public
300 2. Add a test driver gdcmTest.cxx
301 3. gdcmTestMain, an helper for the main test driver gdcmTest
302 4. Files in Test don't have a main anymore, this becomes interesting
303 when we add more and more tests, thus dsw don't have to load
305 * ENH: Adding a GDCM_DATA_ROOT for testing
306 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
307 one file instead of seven + some small cleanup
309 2004-04-22 Jean-Pierre Roux
310 * ENH Minor changes to the Print() methods.
311 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
312 Header printing. Example given with :
313 > PrintHeader fileName 2 new
314 (SQ based tree-like structure still to be done for the Header ...)
316 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
317 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
318 1. I have added some unsigned where needed
319 2. Some function parameter not used -> (void)
320 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
321 4. g++ don't like character '\' in comment
322 5. #define jpeg_create_decompress jCreaDecompress
323 this really need to be fixed
324 6. virtualize destructor of gdcmObject ... leakage
325 7. sscanf(g->first.c_str(),"%x",&gr_bid);
326 this also really need to be fixed
327 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
328 remove compression file
329 (as we only do decompression, right ?)
330 * ENH: Change malloc/calloc/free with c++ equivalent
332 2004-04-21 Jean-Pierre Roux
333 * FIX gdcmHeaderHelper::GetXSpacing
334 when a single value is found (bug ?), xpacing is now
335 defaulted to yspacing
337 2004-04-19 Jean-Pierre Roux
338 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
339 * ENH add parameters :
340 bool exception_on_error = false,
341 bool enable_sequences = false,
342 bool ignore_shadow = false
343 to the gdcmFile constructors to be full gdcmParser compliant
344 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
345 to allow reading of PAPYRUS 3.0 files
347 2004-04-06 Jean-Pierre Roux
348 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
350 2004-04-02 Jean-Pierre Roux
351 * ADD : Test/checksequence.sh, for a general recap on SQ pb
352 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
353 for Philips spurious Tag fffe|0000 while rewritting Dicom files
355 2004-03-30 Jean-Pierre Roux
356 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
357 for ACR file, written out as DICOM files (hope so...)
359 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
360 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
361 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
362 moved to base class gdcmParser and only the specialisation is kept
364 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
365 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
366 already does the job.
367 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
368 (to be consistent with gdcmParser::WriteEntries).
370 2004-03-30 Benoit Regrain
371 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
372 upate of the object's instance. It's passed to 2 in the unfavorable
373 case : one in the ExecuteInformation, one in the ExecuteData
375 2004-03-29 Jean-Pierre Roux
376 * ENH : Check on file type to be written moved
377 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
378 * FIX : gdcmObject::ResetBoundaries now stops properly
379 when end-of-list is reached
380 : gdcmVersion modified (as Benoit Regrain asked)
382 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
383 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
384 * src/gdcmUtil.cxx: added forgotten iostream include.
385 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
386 equivalent to ExplicitVR in existing code).
388 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
389 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
390 now contains all the gdcmGlobal related code.
391 * minor coding style and doxygenation changes.
393 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
394 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
395 now contains all the Debug related code.
396 * minor clean-up of includes in src/*.cxx
397 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
398 CreateCleanString) removed.
399 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
400 * Doc/DoxyMainPageUser.txt added.
401 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
402 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
405 2004-03-24 Jean-Pierre Roux
406 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
408 2004-03-23 Jean-Pierre Roux
409 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
410 big endian made volumes
411 * ENH Now gdcmParser constructor and destructor are protected to forbid
412 end user to instanciate class gdcmParser
413 (only gdcmHeader and gdcmDicomDir are meaningfull)
415 2004-03-22 Benoit Regrain
416 * FIX : src/gdcmDicomDir.cxx : make windows compilable
417 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
418 gdcmSerie to gdcmDicomDirSerie
420 2004-03-19 Jean-Pierre Roux
421 * ENH Now the tree-like structure describing a DICOMDIR comming from
422 an already existing DICOMDIR file is consistent with
423 the home-made tree-like structure build ex-nihilo
424 or build from the files held (recursively) in a Directory
425 functions gdcmDicomDir::CheckBoundaries()
426 gdcmObject::SetBoundaries() added
428 2004-03-17 Jean-Pierre Roux
429 * REM (Eric Boix bug) : removal of meaningless
430 gdcmDicomDirImage::NewImage function.
431 * FIX now file names and directory name are written properly in the
433 * FIX now gdcmDicomDir constructor may be call without any trick
436 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
437 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
438 of gdcmDicomDirImage::NewImage as empty function.
440 2004-02-28 Jean-Pierre Roux
441 * ENH add gdcmDicomDir:NewPatient
442 add gdcmDicomDirPatient:NewStudy
443 add gdcmDicomDirStudy:NewSerie
444 add gdcmDicomDirSerie:NewImage
445 to allow making gdcDicomDir object.
446 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
447 (as opposite to the gdcmHeader chained list)
449 2004-02-11 Benoit Regrain
450 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
451 when using from python
453 2004-02-10 Benoit Regrain
454 * FIX : bug fix in the gdcmDirList for the recursivity in directories
455 * FIX : in gdcmDicomDir when the directory is empty
456 * ENH : add callback and methods to get the progression of dicomDir
459 2004-02-06 Jean-Pierre Roux
460 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
461 - GDCM_META added to gdcmDicomDirType
462 - class gdcmMeta created
463 * ENH : - A brief summary is now displayed at the beginning of
464 'testDicomDir' to help disaster magnitude estimation
465 * REM : Now useless Test/explDICOMDIR.cxx
467 2004-02-05 Benoit Regrain
468 * ENH : add methods in gdcmObject to get the hash table or the list of
470 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
471 * FIX : wrapping python for TagHeaderEntryHT
473 2004-02-04 Benoit Regrain
474 * FIX : even length for some strings when writting the dicom dir
475 * FIX : sort the images in the dicom dir
476 * FIX : Bug fix for python use of dicom dir
477 * ADD : a python demo
479 2004-02-04 Jean-Pierre Roux
480 * FIX : Final solution (?) for icone embedded images
481 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
482 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
483 add groups 6002, 6004, 6006, to allow 'clean' parsing of
484 gdcmData/gdcm-MR-SIEMENS-16.acr1
485 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
486 to make full checking easier
488 2004-02-04 Benoit Regrain
489 * FIX : WriteEntries : coding style & logic in parameters
490 * FIX : Set the elements to create the DicomDir in a dictionary file
492 2004-02-03 Benoit Regrain
493 * gdcmDirList : to parse a hard drive directory in recursive (or not)
494 * gdcmDicomDir : add the load of directory
495 * Bug fix and print add-on
497 2004-02-03 Jean-Pierre Roux
498 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
499 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
500 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
501 * FIX gdcmParser.cxx : 'group length' elements are now considered
502 as integers, even for shadow groups, when file is Implicit VR
504 2004-02-02 Jean-Pierre Roux
505 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
507 of the last synonym :-(
508 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
510 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
511 * FIX taking into account the possible 7fe0,0010 multiplicity
512 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
513 to allow removal of references to 7fe0,0010, to deal with
514 ACR-NEMA images, when 0028,0200 is meaningfull
516 2004-01-31 Jean-Pierre Roux
517 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
518 no longer writes 'Un' on disk
519 * FIX SQ elements with actual length are now dealt with corectly
520 * FIX gdcmFile::WriteBase make the difference, for color images, between
521 the length (for Palette expanded images)
522 and Raw Length (non expanded image + Palette)
523 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
524 (that broke Write). Replaced by UL.
525 Aware user will reload the field if he
526 thinks it's necesssary
528 2004-01-30 Jean-Pierre Roux
529 * gdcmParser::CheckSwap() now defaults the filetype to ACR
530 when 'dirty Acr' is found, to be compliant with the new
531 IsReadable() methods.
533 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
534 (no DOUBLE images in kosher DICOM,
535 but so usefull for people that miss them ;-)
537 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
538 DICOMDIR related utilities (not checked as Windoze compliant)
540 2004-01-28 Jean-Pierre Roux
541 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
543 2004-01-27 Jean-Pierre Roux
544 * gdcmParser constructor has a new boolean param,'ignore_shadow',
545 to allow skipping the shadow elements, to save memory space.
546 The TRUE value for this param has to be used
547 with a FALSE value for the 'enable_sequence' param.
548 ('public elements' may be embedded in 'shadow Sequences')
549 * gdcmHeader methods now deal with 'embedded icones images' in the header
550 (even when an 'icone image sequence' is announced by the
551 element (0x0088,0x0200), but there is NO icone at all ...
553 * gdcmHeader sometimes Image Location value doesn't follow
554 the supposed processor endianity (see gdcmData/cr172241.dcm).
557 * gdcmHeader add the method
558 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
559 to get *all* the Header Entries with the same tag.
560 GetHeaderEntrySameName is probabely *useless*
561 (no meaning : Name is *not* an identifier within the Dictionnary)
563 2004-01-26 Benoit Regrain
564 * Bug fix in the print of hexadecimal representations. Remove long fields
565 in the print and add a third level of print to print them
567 2004-01-23 Benoit Regrain
568 * Bug fix on field having a VR = 'UI'. Assume that is a string field
569 * Bug fix on test suite after remove the strip made on not string fields
570 * Split the IsReadable method between gdcmParser which test that the file
571 is dicom and gdcmHeader which test that it's an image file
573 2004-01-22 Benoit Regrain
574 * DicomDir : clean code, add methods, set variables in protected or private
575 * gdcmUtil : bug fix for the clean string method
577 2004-01-19 Benoit Regrain
578 * Add the use of shadow dictionaries
579 * bug fix and coding style
581 2004-01-19 Benoit Regrain
582 * src/gdcmFile.cxx : bug fix concerning the close of file
583 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
584 * Add the update of header entries using the shadow library
586 2004-01-19 Benoit Regrain
587 * removal of file gdcmHeader2.cxx
588 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
589 inheriting from gdcmParser. This split is to prepare the integration
591 * bug fix under python
593 2004-01-16 Jean-Pierre Roux
594 * REM removal of class gdcmHeaderEntrySet
595 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
596 * ADD add file gdcmHeader2.cxx
597 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
599 2004-01-15 Benoit Regrain
600 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
601 entries created while parsing the header. Thus, they will be destroyed
602 when the gdcmDictSet will be destroyed
603 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
606 2004-01-15 Benoit Regrain
607 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
608 made a fatal error because of the memory release at the end of program.
609 The problem was in vtkGdcmReader::ExecuteData where we were allocate
610 some memory and vtk seems to have some problems with that.
611 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
613 2004-01-14 Benoit Regrain
614 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
615 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
616 * src/*.[h|cxx] : make changes due to class name changes
617 * gdcmPython/demo/*.py : bug fix due to method names
619 2004-01-13 Benoit Regrain
620 * src/*.[h|cxx] : coding style
621 * vtk/*.[h|cxx] : coding style
623 2004-01-13 Benoit Regrain
624 * gdcmPython/testSuite.py : test the readable flag of file for tests
625 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
626 It's lied to the stl compilation by MSVC (windows, always windows...)
627 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
629 2004-01-12 Benoit Regrain
630 * src/*.h : add comments
631 * src/gdcmDictSet.h : set the method BuildDictPath in public
632 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
633 directly setted in the source code
634 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
637 2004-01-09 Benoit Regrain
638 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
639 * setup.py : use a reference to gdcmVERSION
641 2004-01-07 Benoit Regrain
642 * Modification to compile with the distutils.
645 2003-12-10 Benoit Regrain
646 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
647 can use a gdcmHeaderHelper to load datas
648 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
649 made in the source code
651 2003-12-10 Benoit Regrain
652 * Update Windows projects and .cvsignore files
654 2003-11-12 Jean-Pierre Roux
655 * ENH gdcmHeader constructor has one more parameter (default value : false)
656 that allows the user to 'go inside' the SeQuences only
658 gdcmElValSet:Print takes it into account
660 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
661 * ENH: Update gdcmPython/CMakeLists
662 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
663 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
665 2003-11-10 Jean-Pierre Roux
666 * FIX : gdcmHeader::LoadElements is now based
667 on the ListTag listElem member,
668 not longer on the TagElValueHT tagHt member
669 * ENH : PrintPubElVal shows (temporarily) both results,
670 with the tagHt member and the listElem member.
671 (it's easier to 'see' the problems when using Printheader)
673 * FIX : old private member LgrElem is now splitted into
674 ReadLength : Length actually found on disk (updated only
675 if bug fixing is necessary), for internal
677 UsableLength : Updated by FixFoundLength, to fix a bug
678 or to allow Parser going on.
679 Will allow to re-write a kosher header when a SeQuence
680 with a length (not 0000) is found
681 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
682 because gdcmElValSet::Add does not update ListElem
685 2003-11-07 Jean-Pierre Roux
686 * FIX misstyping in Transfert Syntax name table
687 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
688 when they have an actual length (not 0000 nor FFFFF)
689 (Nobody should care of it, but DICOMDIR explorers)
691 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
692 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
694 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
695 * ENH: vtkGdcmReader now supports LUT !
696 (vtkgdcmViewer for now is not able to use them though)
698 2003-11-05 Jean-Pierre Roux
699 * in testSuite.py : new files names for checking the package
700 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
701 that returns the pixel area size to the *aware* (vtk) user
702 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
704 2003-11-05 Benoit Regrain
705 * in testSuite.py : Modify the rules for checking the paths
706 : Explicit error messages
707 * in __init__.py : Related modif
709 2003-11-03 Jean-Pierre Roux
710 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
711 to be used by aware (vtk) users that want to manage
712 LUT (and no to turn the PALETTE image into an RGB pixels one)
713 * GetPixelType now returns 8U for 24 Bits images
714 (vtkGdcmReader compliant)
716 2003-10-31 Jean-Pierre Roux
717 * Removal of *all* gdcmData images and add them again
718 in order to loose the 'history' of un-anonymised images
720 2003-10-31 Jean-Pierre Roux
721 * RMV : removal of useless jBitsInJsample.h
722 for both 8 and 12 Bits JPEG Lossy Libraries
724 2003-10-31 Jean-Pierre Roux
725 * ENH : Add the functions gdcmFile::GetImageDataRaw
726 gdcmFile::GetImageDataIntoVectorRaw
727 that act as GetImageData and GetImageDataIntoVector
728 except the making of an RGB Plane from Gray Plane + LUT
729 Intended to aware (vtk) users who know how to manage
732 GetLUTRGBA return a R,G,B,A LUT if any
733 lgrTotaleRaw gives the 'Raw' length
734 GetImageDataRaw returns the gray Plane
735 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
736 (They stay Grey, just like with other Dicom viewers :-(
738 2003-10-30 Jean-Pierre Roux
739 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
741 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
742 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
743 being coherents dicom files.
745 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
746 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
748 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
749 * ENH: Two steps is necessary to please VC++ compiler...
750 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
751 * ENH: Add include dir to medcon lib
752 * FIX: only one function is being exported for now !
753 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
755 2003-10-29 Jean-Pierre Roux
756 * adding gdcmHeader::GetLUTRGBA
757 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
758 --> Mathieu, the modif u're waiting for is not yet committed
759 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
761 2003-10-27 Jean-Pierre Roux
762 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
763 00191113.dcm DermaColorLossLess.dcm
764 MxTwinLossLess.dcm RadBWLossLess.dcm
765 * ENH: For version prior to vtkImageViewer2 -r 1.19
766 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
768 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
769 * Removal of ido stuff in CMakeLists.txt
771 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
772 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
773 * FIX: remove a call to ->Modified ... see comments
774 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
776 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
777 * FIX: Problem with path for libvtkgdcmPython
778 * ENH: Try adding a search script for python site-package
779 * RMV: Remove some file from medcon lib that are not necessary
780 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
781 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
782 * FIX: More pragma disable fro VC++,
783 I don't think I break something as it is also disable in VTK/ITK.
784 But it fasten debug compilation time.
786 2003-10-23 Jean-Pierre Roux
787 * gdcm now deals with 16 Bits Run Length Encoded images
788 (they are compressed as 2 planes images,
789 one for the high Bytes, the other for low Bytes)
791 2003-10-22 Jean-Pierre Roux
792 * Now CheckRead takes into account :
793 - the bugged 'Leonardo' Siemens images
794 - the XA images, sent thru the burning VPRO station
795 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
798 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
799 * FIX: When copying a Makefile.am to CMakeLists.txt
800 one should remove the '\'
802 2003-10-22 Jean-Pierre Roux
803 * in gdcmData adding a bugged 'Leonardo' Siemens image
804 (wrong lengths in header)
805 OK with gdcm, KO with the other viewers :-)
806 * add a GE dlx XA image, thru the VEPRO burning station
809 2003-10-21 Jean-Pierre Roux
810 * in gdcmData add the checkvtkgdcmViewer.sh shell script
811 for a brutal checking of vtkgdcmViewer compliance
813 2003-10-21 Jean-Pierre Roux
814 * add the files for 'xmedcon' Jpeg Lossless library
815 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
817 2003-10-21 Jean-Pierre Roux
818 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
820 2003-10-21 Jean-Pierre Roux
821 * garbage Siemens 'Leonardo' images dealt with
822 (the patch is easy to remove)
823 * cosmetic changes to avoid warnings
825 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
826 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
827 no need to press 'r' now.
829 2003-10-20 Jean-Pierre Roux
830 * upgrade of checkRead.sh checkWrite.sh according
831 to new Jpeg Lossless decompressor
832 * add US.3405.1.dcm, a genuine RGB medical file ...
833 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
834 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
836 2003-10-15 Jean-Pierre Roux
837 * general anonymisation in gdcmData
838 * adding the 'color files' from
839 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
840 * adding some well knowed bugged-header images
841 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
842 waiting for their inclusion in Python testsuite
844 2003-10-15 Jean-Pierre Roux
845 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
846 no longer seg faults when file is not found
848 2003-10-14 Jean-Pierre Roux
849 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
852 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
853 * TODO: *.in file to genereate a UseGDCM later
855 2003-10-14 Jean-Pierre Roux
856 * Some supposed-to-be Dicom Images have no preamble.
857 OpenFile takes it into account
858 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
859 * Missing elements added in dicomV3.dic
860 (just to be affraid : have a look at
861 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
862 and do it again next year ;->
864 2003-10-13 Jean-Pierre Roux
865 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
866 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
867 But there are NOT. It's fixed !
869 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
870 * FIX: "jpeglib.h" was not found on VC++
871 * FIX: vtkgdcm was not being installed
873 2003-10-10 Jean-Pierre Roux
874 * ENH : OpenFile closes the file if it *really* doesn't look like
875 an ACR-NEMA / DICOM one.
876 * FIX : testWrite no longer writes an empty file if the source file
878 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
881 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
882 * FIX: CMake generate now documentation
883 * ENH: out of source doc build !
884 * ENH: Generate both user and dev documentation
885 * ENH: Should work on windows too
886 * ENH: Only one doxygen config.in file is needed
887 * FIX: make install should be ok now on ùnix plateform
888 * FIX: PATH to dictionary was wrong (missing /)
889 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
891 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
892 * vtkGdcmReader is now able to read rgb dicom file.
893 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
894 * added a gdcmViewer to vtk test, use mouse to control
895 window level & window width
897 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
898 * CMake-ification of gdcm, we have now two build system
899 * FIX: on cygwin Wsock32 doesn't exist
900 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
902 2003-10-06 Emanuel Ollart
903 * FIX : compilation process wad broken.
904 Changed gdcmViewer_sources to vtkgdcmViewer_sources
906 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
907 * change gdcmViewer -> vtkgdcmViewer
908 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
910 2003-10-06 Jean-Pierre Roux
911 * FIX :A few nasty patches to allow the reading of a lot of nasty images
912 ( e.g : well known GE images with a wrong elem length,
913 : Philips MRI Images with a wrong Huffman table)
914 * still to be done : allow the reading of bugged LEONARDO Siemens images
916 2003-10-03 Jean-Pierre Roux
917 * Odd length strings are padded with '\0' (not with spaces,
918 to remain compliant with already defined strings,
919 like Transfert Syntax UID and others)
921 2003-10-03 Jean-Pierre Roux
922 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
923 to allow displaying RGB images (not only by affim ;-)
925 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
926 * vtkGdcmReader is now able to read rgb dicom file.
927 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
929 2003-10-03 Jean-Pierre Roux
930 * A few nasty patches to allow the reading of a lot of nasty images
931 ( e.g : well known GE images with a wrong elem length,
932 : Philips MRI Images with a wrong Huffman table)
933 * still to be done : allow the reading of bugged LEONARDO Siemens images
935 2003-10-03 Jean-Pierre Roux
936 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
938 2003-10-03 Jean-Pierre Roux
939 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
940 to allow displaying RGB images (not only by affim ;-)
942 2003-10-03 Jean-Pierre Roux
943 * gdcmFile::GetImageDataIntoVector now
944 - deals with MultiFrames MultiFragments Run Length Encoded files
945 - deals with YcBcR (YBR_FULL) files
946 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
947 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
951 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
952 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
953 Two reasons: - clear things
954 - third parties acces gdcm through header files, so won't
955 suffer anymore VC++ complains
957 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
958 * add argv[1] in testvtkGdcmReader.cxx
961 2003-09-24 Jean-Pierre Roux
962 * The lines are now eigthy characters long.for
963 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
965 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
966 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
967 char* to std::string. Thus, the use of strdup becomes useless. (see
968 previous commis of Malaterre)
969 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
970 before the last Malaterre's commit.
972 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
973 * This commit should fix the Debug building under VC++, the problem
974 was mainly a mixture of debug and release lib being loaded at startup.
975 * I also remove a depency to a specific C function: strdup. Because I had
976 to force the link to msvcrtd (whereas strdup is in libc).
978 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
979 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
980 located in the gdcmCommon.h file. All use of reference of tha has been
981 changed to now use the variable GDCM_UNFOUND.
983 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
985 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
986 Dicom dictionary. The test suite can now be run again. Note:
987 I'm note very happy with the " (RET)" changes. I believe this
988 RETAINED comment should be dropped when parsing the dictionary.
991 - AUTHORS updated and now in alphabetical order
992 * Makefile.am now exports gdcm.dsw for Windoze users.
994 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
995 * cygwin complains about missing std:: in subdir Test/
997 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
998 * remove some methods that are now in gdcmHeaderHelper
1000 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1001 * vtkGdcmReader set spacing and origin correctly
1003 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1004 * Fix a few delete/delete[] mismatch
1006 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1007 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1008 interpretation to data given by gdcmHeader. For instance there are
1009 heuristics to get informations (look at different places).
1010 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1011 sorting DICOM images based on different strategies.
1012 * modified Makefiles accordingly.
1014 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1015 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1016 when building in debug mode
1017 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1018 src/win32/gdcmdll.dsp
1019 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1021 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1022 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1025 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1026 * src/win32/libgdcmjpeg12.dsp was not dos format
1027 * src/win32/libgdcmjpeg12.dsp :
1028 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1029 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1031 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1032 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1034 * src/gdcmFile.cxx : bug fix in affectation type
1035 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1036 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1037 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1038 symbols... future problem ?
1040 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1041 * src/win32/libgdcmijpeg12.dsp was missing
1042 * modified gdcm.dsw accordingly
1044 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1045 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1047 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1048 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1049 commit of JPR (before his hollidays to facilitate our work).
1050 * setup.py : bug fix in code. Modifications made while the last commit
1051 of JPR. The code hasn't been tested before the commit... it's so
1052 useless to make that (for best programmer that is JPR) !!!
1054 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1055 * tagged the current version as Version0_3 (i.e. version 0.3)
1057 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1058 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1059 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1060 * *.dsp : modifications to use new libgdcmijpeg8 library
1061 * setup.py : bug fix on VTKPATH variable
1062 * PACKAGER : adding all concerning windows
1064 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1065 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1067 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1068 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1069 test suite reported error.
1070 * PACKAGER file added (describes what a packager must do when
1071 packaging a new release).
1072 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1073 * configure.in: upgraded version number to 0.3.0
1074 * fixing build of rpm (through rpm -ta):
1075 - Doc/Makefile.am exports proper doxygen files
1076 - src/jpeg/libijg8/Makefile.am exports the include files.
1078 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1079 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1080 * src/gdcmHeader.h : formatting code
1082 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1083 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1084 We were obtaining error message from vtk. Now, creation of file list
1085 is made in an internal list to prevent this problem.
1086 Bug fix when output is empty.
1087 Bug fix in update of progress value. Previous commit for this was a bad
1089 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1091 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1092 * src/gdcmHeader.h : added method to get the file name
1093 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1094 files. Added method to remove all files on the input
1095 Added FIXME comment concerning the bad parsing of header made by
1096 ExecuteInformation method (in ExecuteData method)
1098 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1099 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1100 when using make instal.
1101 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1102 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1104 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1105 * setup.py : adding include dir of jpeg lib to compile all sources
1106 * */Win32/*.dsp : JPR fix for windows compilation
1108 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1109 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1111 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1112 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1114 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1115 * setup.py is again effective on un*x (takes into account the
1116 addon of the jpeg library)
1117 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1118 * Doc/Doxy* updated (includes above enhancements)
1119 * INSTALL now points to web documentation
1121 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * src/gdcmHeader.h doesn't make unnecessary reference to
1124 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1126 * src/gdcm*.[cxx|h] :
1127 - to allow compilation with gcc 3.x
1128 -- clean up of STL usage (added explicit usage of std::)
1129 -- small fixes on exceptions.
1130 Note: linking not tested !
1131 - clean of doxygen comments to avoid warnings at documentation
1133 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1134 dependent convertion).
1136 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * Clean up of previous JPR garbage commit (not even commented in the
1139 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1140 - moved all jpeg related files from src to src/jpeg/libijg8, with
1141 addition/modification of Makefile.am and configure.in.
1142 - the testSuite is still brain damage (not guilty).
1144 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1145 * WrapVTK.py : modifications to get correctly vtk source files to
1147 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1148 (FileName -> Filename)
1150 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * vtk/vtkGdcmReader.[cxx/h]:
1152 - UpdateProgress method should now be effective
1153 - removed the limitation on having only images loaded (as opposed
1155 - when building a stack of images/volume, a lesser number of
1156 gdcmHeader and gdcmFile instances should be used (hopefully
1157 accelerating things).
1158 - when building a stack of images/volumes, files which are not
1159 loadable (wrong path-filename, wrong permissions on existing file,
1160 or file not parsable by gdcm) are replaced with a black image
1161 in the stack (for the caller to notice the problem).
1163 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1164 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1166 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1167 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1168 between standard library (std) and vtk library (problems are found
1169 under Windows... thanks Windows !)
1171 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1172 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1174 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1176 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1177 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1179 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1180 * When compiling with distutils (see setup.py) the C++ compiler is
1181 called with different flags than the default ones (with automake).
1182 In order to fix all those warning, I compiled gdcm with the command
1183 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1184 and went for warning fixes:
1185 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1186 up from unused variables.
1187 - vtk/vtkGdcmReader.cxx: potential bug fix.
1188 * src/gdcmHeader.h: Doxygen warning cleanup
1190 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * gdcmPython/gdcm.i:
1192 - typemaps correction to take into account the systematic replacement
1193 of "using namespace std" with std:: prefix e.g. std::list,
1194 std::string... (cf changes of 2003-05-21).
1195 - gdcmGlob global variable of type gdcmGlobal (defined in
1196 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1197 exported to Python a as cvar.
1198 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1199 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1200 gdcmDictSet.GetPubDictTagNames() and
1201 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1202 C++ static methods).
1203 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1204 with the above changes.
1206 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1207 * setup.py, manifest.in : bug fix under linux
1209 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1210 * Modification of setup.py to compile vtk part too. Then, we have 2
1211 wrappers which must work with same distutils. For that, we have a
1212 generic distutils in distusiltsWrapping.py ; with :
1213 - build_extWrap class to wrap generically all extensions,
1214 - ExtensionWrap base class for all wrapping extension that contains
1216 - Wrapper interface which wrap sources
1217 + In WrapSwig.py we have extension and wrapper for Swig
1218 + In WrapVTK.py we have extension and wrapper for VTK
1219 * MANIFEST.in : modifications to consider vtk directory and new python
1220 files for compilation
1222 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1223 * Added python wrappers of vtkGdcmReader vtk class (see the
1224 source in vtk/vtkGdcmReader.cxx) :
1225 - vtk/Makefile.am now builds a library
1226 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1227 python library (as opposed to _gdcm.so wich are the python
1228 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1229 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1231 - configure.in has an additional flag --enable-vtk that needs
1232 to be set to enable compilation of vtk related code, that is:
1233 + vtk/vtkGdcmReader.so and
1234 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1235 + gdcmPython/vtkgdcmPython.so (see above)
1236 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1237 be read when compressed or when HighBit + 1 != BitsStored),
1238 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1239 the usage of the python wrapper of vtkGdcmReader vtk class.
1240 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1241 * src/*.[h] all occurences of stl classes are now prefixed with
1242 std::, and all occurences of "using namespace std;" where removed.
1243 This is to avoid pollution of global namespace in included files.
1244 Apparently vtk does not avoid this pitfall: when using both
1245 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1246 collision of various stl members (principally cout...).
1247 * gdcmPython/testSuite.py now cleanly removes temprory generated
1249 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1250 comply with above changes)
1252 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1253 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1254 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1255 vtk data structure (an image Flip was required).
1256 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1257 * cosmetic changes in documentation.
1259 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1260 * src/gdcmHeader.cxx: the constructor no longer exits when an
1261 unexisting file is given as argument.
1262 * The subdirectory Data (containing all the images used for the
1263 test suite) is not part of this repository anymore. A new module
1264 containing those images is now available at
1265 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1266 with the name gdcmData.
1267 All the python scripts (including the package initialisation file
1268 gdcmPython/__init__.py) were adapated to take this change into
1269 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1271 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1272 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1273 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1274 demo of the usage of this class.
1275 Compilation of this vtk part is only done when using the --enable-vtk
1276 at configure (or autogen.sh) stage.
1278 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1279 * More memory link related corrections and documentation fixes.
1281 - maximum info is obtained with a command of the form:
1282 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1283 --show-reachable=yes PrintHeader
1284 - the remaining reachable blocks seem to come from the STL
1285 allocation scheme through the usage of map and list. It looks
1286 like this memory cannot be freed but it is not a memory leak
1287 (in fact further invocation to the STL would recollect the
1288 unused memory allthough it cannot explicitely be freed).
1289 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1290 of displaying an image parsed with gdcm and displayed with VTK.
1291 Note: some images don't seem to work e.g.
1292 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1293 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1294 Allthough this weakens the semantics, it is a ditch attempt to
1295 make gdcm more thread friendly.
1297 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1298 * Memory link hunt (by using valgrind through the command
1299 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1300 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1301 gdcmHeader::_dicom_vr.
1302 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1303 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1305 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1307 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1308 * src/Makefile.am now exports all the necessary include files at
1312 * UpdateGroupLength replaced by new one
1315 * UpdateGroupLength re-written using H-Table
1316 (named UpdateGroupLengthNew untill checks are over)
1318 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1319 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1320 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1322 - gdcmHeader::GetPubElValSet removed.
1323 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1324 UpdateGroupLength, WriteElements, Write.
1325 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1326 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1327 carried the same semantics.
1328 - src/gdcmHeaderIdo.cxx changed accordingly.
1329 - gdcmFile::WriteBase now regroups all the codes from previous
1330 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1331 - enum FileType moved to gdcmCommon.h
1332 * src/gdcmHeader.cxx AddDefault trashed
1333 * gdcmGetXSize added
1334 * getimageDataSize now calls gdcmGetXSize
1335 * Test/*.cxx changed to agree with above changes
1337 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1338 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1339 (to avoid double call by end user).
1340 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1341 by end user, since gdcmHeader::gdcmHeader now handles it.
1343 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * gdcm/Doc many doxygen changes:
1345 - Doxyfile now has two different versions, DoxyfileUsers that generates
1346 the html.users end users oriented documentation and
1347 DoxyfileDeveloppers that generates the html.developper developper
1348 oriented documentation.
1349 - README changed accordingly
1350 - requirement.txt removed (old design info moved to TODO).
1351 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1352 DoxyMainPage.txt, DoxyPython.txt provide more information.
1353 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1354 be updated by simply regenerating the docs with doxygen and copying
1355 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1356 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1357 all the tests in the form "if (<map>.count() >1)" were removed.
1358 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1359 ill-formed documentation sections.
1360 * src/gdcmHeader.cxx: ditto
1362 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * setup.py fixed for un*x (needed macro for stdint.h)
1364 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1365 un*ces with sh-utils test utility.
1366 * gdcmPython/demo/test.py renamed to PrintHeader.py
1367 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1368 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1369 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1370 * src/gdcm*.cxx JPR's bad inclusion fixed.
1372 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1373 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1374 * gdcmPython/demo/test.py changed accordingly.
1376 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1377 * gdcmPython/Makefile.am fixed linking against libstdc++
1378 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1379 * Swig subdir (historical tests of swig version 1.3.17++) removed
1380 * Test/testChangeEntete.cxx some lines commented out in order to make
1382 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1383 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1385 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1387 hence the user doesn't need this explicit call.
1388 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1389 i.e. LoadElements() call removed.
1390 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1391 - src/Makefile.am declares the proper flag for g++.
1392 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1393 for adding user defined new tags.
1394 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1395 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1396 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1398 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1399 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1400 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1401 src/Makefile.am : the project should properly compile and install
1402 with the autotools, included the python wrappers part.
1403 * gdcm.spec.in : added a spec file for RPM packaging.
1405 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1406 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1408 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1410 to exported to the environement (see gdcmPython/testSuite.py
1412 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1413 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1414 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1415 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1416 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1418 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1419 * gdcmPython/__init__.py doesn't crash anymore when running in
1420 in InstallMode or PreInstallMode but with an environement given
1421 value of GDCM_DICT_PATH.
1422 * src/gdcmDictSet.[cxx/h] coding style.
1424 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1425 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1426 * src/gdcm.h general comments moved to TODO, and README
1427 * src/gdcm.h should now be seen as a user commodity (including it
1428 should suffice to fully use gdcm). It is nowhere including within
1429 any of the kernel files src/*.cxx and src/*.h.
1431 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1432 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1433 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1435 * src/gdcm*.cxx only include their corresponding include file
1436 (as opposed to gdcm.h)
1437 * gdcmPython/gdcm.i changed accordingly
1438 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1439 the autogen.sh generated "make snapshot" command to work.
1440 * autogen.sh removed history related references to crea package.
1442 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * distutilsSwigCPlusPlus.py work around some swig portability
1446 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1447 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1448 was done in a last ditch attempt to get setup.py _really_
1449 operationnal. The python/gdcmPython layaout add the advantage
1450 of hidding away the python related distutils specific files
1451 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1452 Alas, the src directory was out of scope (i.e. it's relative
1453 position to setup.py was ../src) which made things impossible to
1454 handle (see previous version of python/setup.py). Crossing fingers...
1456 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * python/setup.py now works on Un*x. (harder than I thougth)
1458 * python/distutilsSwigCPlusPlus.py can now have include files
1459 among the list of sources.
1461 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1462 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1463 * modifications in MSVC projects
1465 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1466 * As stated by the first lines of Test/ExceptionAndPython/README, it
1467 looks like we can move back to original usage of exception within
1468 src/gdcm* and hence remove the errno stuff that was introduced
1469 as a quick and dirty fixture of this problem (added to the TODO).
1470 * Doc/Doxyfile configuration file for Doxygen and corresponding
1471 README file for usage added.
1472 * Test/testWrite.cxx added. This new test comes from a split of
1473 test.cxx that is now reverted to its original purpous i.e.
1474 testing the proper parsing of a Dicom related file.
1475 testWrite.cxx concentrates on testing the IO part of gdcm.
1476 * Test/bug1.cxx (containing a bug on WIn32) added.
1477 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1478 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1479 whose purpose is to publish the content of the TagNames of the
1480 Dicom public dictionnary were not accessible without an
1481 instance of class gdcmHeader.
1482 - those methods are now static methods of gdcmDictSet and hence
1483 require no instances at all to be invocated.
1484 - within gdcmDictSet this change required to change some method
1485 to class methods (i.e. are now static) among which SetDictPath
1486 (renamed to BuildDictPath) and LoadDefaultPubDict.
1487 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1488 the above changes by calling the new method classes of gdcmDictSet.
1489 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1490 the above to be effective.
1491 * python/gdcmPython: in order to wrap properly the above changes
1492 for Python, swig version now needs to be > 1.3.17.
1493 * python/gdcmPython/Makefile fixed to adapt itself to new
1494 configure/make shema introduced by Johan Montagnat (thanks for the
1495 contribution). Alas this Makefile cannot be turned into a proper
1496 Makefile.am without some heavy changes in the configure.in
1497 (for python dectection).
1498 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1499 now avoids publishing the empty entries.
1501 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1502 * python/setup.py : bug fix concerning install under windows
1503 ExtraPath reused :-P
1504 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1506 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * Dicts/dicomV3.dic : remove double spaces !!!
1508 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1509 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1512 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1513 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1514 method. Doxygenation.
1515 * src/gdcm.h clean up of JPR spurious comments.
1517 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1518 * python/distutilsSwigCPlusPlus.py now properly collects the
1519 shadow classes generated by "swig -c++" (gdcm.py in our case)
1520 when using "python setup.py install".
1521 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1522 reexports the working classes.
1523 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1524 by the classical C errno scheme. This is to prevent an obscure
1525 behavior of the python wrappers when importing wxPython.wx prior
1526 to gdcmPython (which ended up in an abort call). An illustration
1527 of this oddity can be found in the Test/ExceptionAndPython
1528 subdir (see the README file). This problem probably due to
1529 an combination of g++ and dynamic loading.
1530 * added Test/ExceptionAndPython (see above)
1532 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1533 * Changed the layout of the python part to avoid bloating main
1534 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1535 i.e. the distutils arsenal. All the python related stuff is
1536 again in a python subdir, but the package itself is now in
1538 * setup.py was cleaned up:
1539 - pythonIncludePath removed
1540 - python setup.py bdist target is now functional.
1541 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1542 collision with other packages). gdcmPython/demo/*.py changed
1545 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1546 * python subdir moved to gdcmPython (preparation of distutils packaging).
1547 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1548 distutils installer is operational.
1549 * - gdcmPython/__init__.py now properly loads the swig generated
1550 shadow classes (from gdcm.py).
1551 - gdcmPython/demo/*.py changed to import the package gdcmPython
1552 instead of gdcmPython/demo/load.py.
1553 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1555 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1556 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1557 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1558 entries within the associated public Dicom dictionary resp. the same
1559 information but sorted by the fourth field (PAT, IMG, DIR) of the
1561 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1562 are now in the "???" group.
1563 - python/gdcm.i changed accordingly,
1564 - python/demo/printGroupedPublicDict.py added, that gives an example
1565 of the above new functionalities in Python.
1567 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1568 * src/gdcm.h, gdcmHeader.cxx:
1569 - historic references to glib's g_malloc and g_free (#defined)
1570 were definitively removed.
1571 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1572 * src/gdcmElValSet.cxx:
1573 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1574 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1575 - GetElValue(string) renamed to GetElValueByName.
1576 - Added GetElementByName(string).
1577 * src/gdcmHeader.cxx: added
1578 - GetPubElValRepByNumber(guint16, guint16)
1579 - GetPubElValRepByName(string)
1580 - GetShaElValRepByNumber(guint16, guint16)
1581 - GetShaElValRepByName(string)
1582 - GetShaElValByNumber(guint16, guint16)
1583 - GetShaElValRepByName(string)
1584 - GetElValRepByNumber(guint16, guint16)
1585 - GetElValRepByName(string)
1586 - GetElValByNumber(guint16, guint16)
1587 - GetElValRepByName(string)
1588 * Doc/requirements.txt added.
1590 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1591 * Test/Makefile building now depends on the one of libgdcm.so
1592 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1593 pixel data) aware which enables finding the address (offset) of
1594 the pixel data of JPEG encoded DICOM files. This leaves only a single
1595 file in the testSuite whose pixel data address (offset) is unknown.
1596 * python/testSuite.py changed accordingly.
1598 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1599 * VC++ has some strong limitations when working with the STL, as stated
1600 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1601 "Also note that some STL containers (map, set, queue, list, deque)
1602 cannot be exported. [...]
1603 Some STL classes contain nested classes. These classes can not
1605 This is caused by a designed limitation that once a template
1606 class is instantiated, it can not be re-instantiated and
1608 Since our usage of map<> is ubiquitous in gdcm, this "designed
1609 limitation" of VC++ is a pitfall.
1610 Hence the Python wrappers of gdcm cannot be incrementally linked
1611 against the c++ dynamic library. The dirty but only workaround is
1612 to forget about incremental link of dynamic libraries and to generate
1613 the Python wrappers library with the inclusions of the underlying C++
1615 The following modifications concern this matter on Win32/VC++:
1616 - wrapping python correct with standalone wrapped dll (don't use separate
1617 dll under windows !!!!)
1618 - python21_d debug mode enabled (ask Frog how to use it :-)
1619 - NO problem with having an STL member of class for example string in C++
1620 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1621 - Python test of dcmlib in Python is ok under windows on a large set
1623 * removed glib references
1624 * typedef's inserted in gdcm.i for correct swig type management
1626 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1627 * python/demo/*.py load.py extracted from test.py. Added explore.py
1628 that only displays required tags and testAll.py that parses all
1629 the files of the testsuite without using unittest.
1630 * python/testSuite.py other additional test on new files added.
1631 * Data/* new test files added accordingly to the testSuite.
1632 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1633 the vr in the file differs from the one of the dictionary.
1635 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1636 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1637 values, but limits itself to values which are below a user specified
1638 size (by default 1024 bytes).
1639 * python/gdcm.i : elements not loaded (because their size is above the
1640 user specified treshold) are exported with their TagKey as key of the
1641 python dictionary. This enables the testsuite to make some checks
1642 on the unloaded elements (since we have their offset and size).
1643 * python/testSuite.py
1644 - now tests for the existence and proper value of the pixel data
1645 - two new examples added.
1646 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1648 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1649 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1650 aware. See the strategy comments in gdcmHeader::FindeLength().
1651 * Test/test.cxx now accepts a filename as first argument.
1652 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1653 * python/testSuite.py changed to integrate test on above files.
1655 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1656 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1657 the vr was also RET.
1658 * python/testSuite.py more tests added.
1660 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1661 * python/testSuite.py unittest test suite added (uses Data)
1662 * Data/* dcm and acr files for the test suite.
1663 * glib dependance removed from un*x version. We now use ISO C99
1664 7.18 Integer types (see stdint.h)
1665 - python/Makefile, src/Makefile src/gdcm.h
1666 * src/ when an explicit vr (like dicom files) suddenly poped an
1667 implicit element we use to mark the underlying DictEntry of the
1668 concerned ElValue with "Implicit". This strategy was damageable
1669 too the public or provite dictionaries, since some of their vr
1670 would be changed. Since Header::FindLength heavily relies on the
1671 detection by Header::FindVR of falsely explicit elements, I
1672 added an extra ImplicitVr member to ElValue (boolean).
1673 The rest of the changes we the necessary adaptations.
1675 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1676 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1678 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1680 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1681 * Adaptation for porting to VC++:
1683 o forced to use std namespace (for string to be known)
1684 o all class use __declspec export style on WIN32
1685 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1686 (in stdlib.h on Win32 but in std:: for gcc)
1687 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1688 variable GDCM_DICT_PATH.
1689 * src/gdcmHeader.cxx verbose comments made discrete.
1691 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1692 * python/gdcm.i: added a typemap that converts a C++ hashing table
1693 to native Python dictionary.
1694 * python/demo/test.py:
1695 - now uses the native dictionary for exploration of gdcmHeader.
1696 - takes an optional filename argument (the file to parse).
1697 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1698 PubElVals hashing table.
1699 * Dicts/dicomV3.dic removed error prone trailing spaces.
1701 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1702 * Python wrapping process moved away from src/Makefile to
1703 newly created python/Makefile (as well as gdcm.i)
1704 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1705 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1706 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1707 from the environement variable GDCM_DICT_PATH (when existing).
1708 * src/gdcmDict::GetTag bug fix.
1710 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1711 * Straightforward temporary fixes for swig to build the python wrappers.
1712 src/Makefile now has a python working entry [by working we mean
1713 that we can import de shadow classes without errors].
1715 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1716 * hashtest.cxx removed (since allready in Test)
1717 * src/gdcmlib.h renamed to src/gdcm.h
1718 * src/dcm.i renamed to src/gdcm.i
1719 * src/Makefile prepared for python wrapping
1721 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * src/gdcmHeader.cxx :
1723 - Parsing of header is now separated from loading of element values
1724 (see gdcmHeader::LoadElements).
1725 - general clean up of hopefully all file access (creation of
1726 ReadInt16 and ReadInt32)
1728 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * src/gdcmHeader.cxx :
1730 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1732 - SetLgrElem renamed to SetLength
1733 - GetLgrElem renamed to GetLength
1734 - ~gdcmHeader() made virtual to pesky warning messages at compile.
1735 * src/gdcmElValSet.cxx fixed both GetElValue methods
1736 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
1737 due to IdoDude was cleaned out.
1739 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1740 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
1741 concentrates on finding the value representation (when it exists).
1742 RecupLgr now only finds the element value length, and it avoids
1743 returning the unecessary skL (skipped length).
1744 Also, offsetCourant was simply removed (with taille_fich) since
1745 it was redundant with the File position internals (by using
1746 ftell and fseek). This also made skL (see above in RecupLgr) usage
1748 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
1749 on the libido specificities which are handled through class
1751 * Test/implicit_vr.dcm dicom v3 in implicit value representation
1754 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1755 * Truckload of changes. Parsing of header is barely functional
1756 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
1758 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1759 * src/gdcmHeader.cxx many addons of low level methods
1761 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
1763 and _IdDcmSWAP_LONG.
1765 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1766 * This corresponds to all the changes decided at the meeting of
1767 May 23 2002. Needless to say we are running late...