1 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
3 all replaced DocEntry's
4 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
5 Now, each needed DocEntry to modify is duplicated, modified and inserted
6 to the header using DocEntryArchive. Thus, after save, we can restore the
9 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
12 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
14 correct to copy it. The DictEntry is specified at the DocEntry creation,
15 then, it musn't change in the time.
16 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
17 header correctly. At this time, the change is only made for the first
18 level of the Document. In the future, it might consider sequences.
19 The change is made by replacing a DocEntry by an other that is created
20 outside the class. The old value is kept. When we restore the header
21 status, the added DocEntry is deleted and replaced by the old value.
22 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
23 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
24 set the write type to explicit VR, implicit VR or ACR. Add methods to set
25 the write mode to native, decompressed or RGB (but not used at this time)
27 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
29 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
31 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
33 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
35 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
36 set because already copied when copying the BinEntry's of the header
37 * Test/TestAllReadCompareDicom.cxx : remove warnings
39 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
41 Two problems appear when doing it :
42 - with the gdcmFile : when the GetImageData method is called, the pixels
43 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
44 datas (pixels). And each structure destruct the datas when it's
45 destructed. So we have two destructions for the same datas. To solve it,
46 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
47 datas or not. If it doesn't own datas, then they will not destroyed by
49 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
50 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
51 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
52 create a double destruction of the same DocEntry's. So, to solve it,
53 the TagHT is simply cleared and the DicomDir* elements are destroyed.
54 * TODO : add an entry concerning memory leaks in the DicomDir
56 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
58 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
61 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
63 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
64 after it have been deleted
66 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
67 * FIX: src/* fix the doxygen warnings.
68 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
69 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
70 was erroneously defined with a size of 15 instead of 16. [many thanks
71 to Jean Michel Rouet for pointing out this bug].
73 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
74 1. Finish merging JMR patch for writting DICOM from scratch
75 2. Fix -hopefully- bug with MONOCHROME and space vs null character
76 3. Use const ref when possible
77 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
78 5. A few more comments
79 6. CreateUniqueUID can now be called without parameter"
81 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
82 * ENH: Slightly bigger patch:
83 1. Getting toward full integration of JMR patch for writting dicom from scratch
84 2. Update Test to test part of this patch: CreateUniqueUID
85 3. File was not close properly in gdcmDict
86 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
87 5. Use of const ref instead of copy (speed issue)
88 6. Remove temporary (duplicate) string in TranslateToKey
89 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
90 8. Do not repeat virtual in subclasses
91 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
93 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
94 * Apply first patch toward better string comparison when dealing with broken
95 DICOM files. Essentially the string could be padded with a space instead
96 of a null character as defined by standard
98 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
100 because never used... and in the same time, that's remove some memory leaks
102 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/gdcmFile.cxx : now delete the PixelConvert instance.
104 * In examples and tests : change the type of image data variables from void*
105 to uint8_t*. Remmove all delete on image data variables
107 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
109 Verify the file pointer value before open the file, and if it's not null,
110 a verbose message is generated.
111 Close correctly the file when the file isn't considered dicom-like. The
112 correctly close is a call to CloseFile.
113 When closing the file pointer, test if its not null to close the file.
114 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
115 file. For an uncompressed image, the copied datas correspond in the least
116 case to the image size (calculated) or the image size specified in the
117 header. A verbose is generated if these two size mismatch
119 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
121 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
122 break under windows (with msvc6 compilation).
124 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
126 compiling with MSVC6)
128 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * Bugs fix for the Windows build with VC6
130 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
131 needed (only for projects required VTK). If the VTK is included in all
132 projects, there is conflicts with the jpeg lib of vtk when compiling the
133 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
134 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
135 when compiling the gdcm_wrap.cxx file (created by the compilation of the
137 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
138 (like it's already made for the cout use). Otherwise, conflict with the
141 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
142 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
144 - comments on the DicomDir::Method related usage added.
145 - now that we use the namespace gdcm, a lot of internal classes do
146 NOT need to be wrapped anymore.
147 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
148 DicomDir::Method) new example added.
150 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
151 * Improve string manipulation. I now inforce the notion of 'DicomString'
152 A DicomString can contain as many \0 as they want
153 and it is *always* of even length.
154 We only support odd length for very rare case.
155 And in the near future this should be removed.
157 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
158 * /binary_write/ gdcm source. Now even on big endian we are writting
159 little endian. This should -heopfully- fix some tests
161 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
162 * Now the dictionary is compiled into gdcm lib. This is a default
163 behavior, thus any dic file specified is picked before failback to
164 the one comiled into lib
166 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
167 * Change internals for gdcmDict. Don't use any 'new' any more.
168 This should definitely solve any leak problem, and we should be
169 as fast as before, as long as don't modify too much the dictionary.
171 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
172 * STYLE: ivars should start with a capital letter.
173 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
174 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
176 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
177 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
178 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
179 new 2004 dictionaries added (thanks to JPR).
180 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
181 * CLEANUP_ROUND (15) for gdcmPixelConvert
182 - RLEFrame::NumberFragments is now of type unsigned int
183 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
184 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
187 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
188 * Initial work in gathering all transfer syntax accessors. clearly
189 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
190 ivars, but only one transfersyntax (class) ivar with equivalent method on
193 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
194 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
195 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
196 discussed (plus I didn't like having a 2000 lines patch not commited)
198 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
199 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
200 * CLEANUP_ROUND (14) for gdcmPixelConvert
201 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
202 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
203 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
205 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
206 anymore and hence avoids storing a copy of PixelConvert::Decompressed
207 into File::Pixel_Data.
209 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
210 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
211 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
212 * CLEANUP_ROUND (13) for gdcmPixelConvert
213 Substituted File::ParsePixelData() with PixelConvert::Print() new
215 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
216 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
217 method to those classes.
218 - src/gdcmFile.[cxx|h]:
219 -- Added a ::Print() method.
220 -- PixelConverter is now a reference instead of a member.
221 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
222 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
224 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
226 collaboration diagram and inheritance diagram should be generated with
228 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
229 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
230 pointlessly wrapped (see
231 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
232 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
233 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
234 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
235 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
236 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
237 -- File::Initialise: PixelConverter setup moved away to
238 PixelConverter::GrabInformationsFromHeader()
239 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
240 interpretation moved away to PixelConverter::BuildRGBImage()
242 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
243 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
244 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
246 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
248 displayed on Win32 when a brutal abort() occurs (because of uncatched
249 exception). See TODO new entry of this commit for more on this.
250 * TODO added new entry.
251 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
252 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
253 - HandleColor is no longer called from gdcmFile.cxx
254 - gdcmPixelConvert.cxx clean up on method arguments and internal
255 variable names for semantical coherence.
257 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * Finished lossless transition, not only do we now read all lossless jpeg
259 images, without the need of the Cornwell lib, but we do read them properly now
260 * To reduce code (well to avoid code duplication), I defined a common place
261 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
262 redefine symbols. This is not prefect but this the best solution I found for a
263 compilation time jpeg option.
265 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
266 * Update jpeg ijg lib to support lossless jpeg implementation
267 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
269 * Also added a special copyright for dcmtk since we use their bugfixes.
272 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
274 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
275 matters, as stated in warning note at begining of %include section).
276 * src/gdcmDicomDir*.[cxx|h]: coding style
277 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
278 * src/gdcmJpeg8.cxx: doxygen fix.
279 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
280 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
281 from File:: to PixelConvert::.
283 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
285 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
286 - more code moved away from File:: to PixelConvert::
287 - fat setup of PixelConverter set in place in File::Initialise.
289 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
290 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
291 namespace at the file system level. So now you should convert your examples
293 gdcmHeader -> gdcm::Header
294 It would be nice if people keep in mind to no open the namespace, since it
295 allows compilation on broken plateform which were defining common symbol in
296 the standart namespace (like LP, Unknown ...)
298 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
300 The JPEG fragments are now parsed at the same stage than the RLE
301 information. All code related to JPEG is now in gdcmPixelConvert:
302 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
303 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
304 export a gdcmFile:: method. Those are simply global functions
305 (for the time being this is better than having them attach to
306 either gdcmFile:: or gdcmPixelConvert::).
307 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
308 and stores the result in a gdcmJPEGFragmentsInfo.
309 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
310 code (among other stuff) moved away from gdcmFile:; to
313 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
315 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
316 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
317 clean up of RLE related code.
318 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
319 - src/gdcmRLE.cxx removed
320 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
321 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
322 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
323 * CLEANUP_ROUND (9) for gdcmPixelConvert
324 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
325 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
326 away from gdcmFile:: to gdcmPixelConvert::.
328 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
329 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
330 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
331 This is because Parse7Fe0 used to parse the pixels to compute the
332 length. This task was passed over to FindDocEntryLengthOB() a long
333 time ago, EXCEPT I had forgotten the OW case...
334 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
335 we just recylce the code for parsing RLE fragments and computing
337 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
338 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
339 with the retired Parse7Fe0().
340 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
341 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
343 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
344 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
345 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
346 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
347 - src/CMakeLists.txt: alphabetic order reodering + new entries.
348 * CLEANUP_ROUND (4) for gdcmPixelConvert
349 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
350 to return an unused length.
352 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
354 this should be cleanner from the plane view. The iostream are erally a pain
355 to use to do simple stuff.
357 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * Redo the compilation of the ijg jpeg library. Now only one source is
359 necesseray. No need to rename file by hand what so ever. CMake handle the
360 copying of the file within different directory, configure header file to
361 modify some symbol. The only addition made to ijg wasd a mangle table so
362 that symbol are different wether we are within 8bits or 12bits.
364 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
365 * Added documentation of vtkgdcmReader on Website:
366 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
367 with it's binary name).
368 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
369 the Website to be more complete.
370 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
371 doxygenated documentation.
372 - Doc/DoxyVtkGdcmReaderExamples.txt added
373 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
374 DoxyVtkGdmReaderExamples.html )
375 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
376 * CLEANUP_ROUND (3) for gdcmPixelConvert
377 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
379 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
380 * CLEANUP_ROUND (2) for gdcmPixelConvert
381 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
383 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * CLEANUP_ROUND for gdcmPixelConvert:
385 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
386 - src/gdcmPixelStuff[h|cxx] removed
387 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
388 - src/CMakeLists.txt changed accordingly
390 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
391 gdcmVersion.py moved to newly created ATTIC related
392 gdcmPython/SetupOldies/ directory.
393 * Autotools clean up:
394 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
395 - autogen.sh configure.in acinclude.m4 python.m4 removed
397 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
398 * src/*.cxx *.h Reference to License.htm fixed to License.html.
399 * Doc/CMakeLists.txt, doxygen.config.in: fix.
400 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
402 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
403 * TODO updated with Mathieu suggestions. I proposed a template for
404 describing TODO entries and used it for new entries.
405 * Added Doc/Website/CodingStyle.html, Developpers.html,
406 DeveloppersPython.html, GdcmDataCvs.html and
407 DownloadVersion0_1.html, DownloadVersion0_3.html.
408 * Some Doc/*.txt Doxygen files (which do not really concern the
409 documentation itself, but the website) moved to html and
410 placed in directory Doc/Website:
411 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
412 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
413 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
414 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
415 * CMakeLists.txt changed accordingly.
416 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
417 DeveloppersPython.html
418 * INSTALL nows refers to Doc/Website/Installation.html
420 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
421 * Added Doc/Website directory, that contains a first raw version
424 2004-09-23 Jean-Pierre Roux
425 * FIX In order not to be poluted any longer by casting problems,
426 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
427 we can now delete[] it safely
428 * VoidArea is now called BinArea (less confusing name),
429 and all the methods called ...VoidArea... are now ... BinArea...
430 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
432 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
433 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
434 clear) TagHT, which is an inherited member of gdcmElementSet. It is
435 up to the destructor of gdcmElementSet to clean up TagHt and it's
438 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
439 * Test/CMakeLists.txt: update to follow gdcmData renamings.
440 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
442 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
443 * ENH: added some utility method that builds a flat dictionnary
444 holding all the Dicom entries contained in the recursive structure
445 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
447 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
448 BuildFlatHashTable() that build a flat dictionary.
449 - src/gdcmElementSet.h: added a new private GetTag() accessor.
450 gdcmDocument is now a friend of gdcmElementSet.
451 - src/gdcmElementSet.cxx: clean up.
452 - Example/FlatHashTablePrint.cxx added.
453 - Example/CmakeLists.txt changed accordingly
455 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
456 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
457 moved away from gdcmDocEntrySet (since this class is an abstract class
458 acting like an interface). SQDepthLevel and BaseTagKey are now
460 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
461 and associated accessors. Doxygenation of the class.
462 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
464 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
465 Use SQDepthLevel accessor instead. ::Print() adapted.
466 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
467 - src/gdcmDocument.cxx changed accordingly.
469 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
471 - The following is the doxygen comment of the typedef declaration
472 of gdcmagKey in src/gdcmCommon.h:
473 gdcmTagKey is made to old an "universal" (as in URL, Universal
474 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
475 A dicom tag allways has a group and an element, but a set of tags
476 embeded in various (optionally nested) sequences and sharing
477 the same group and element all share the same (group, element)
478 "identifier". Hence the (group, element) cannot be used as an
479 identifier (in gdcm we shall refer to a "TagKey") of a tag.
480 In order to construct a proper tag identifier (i.e. a key) we
481 consider the following definition of a TagKey:
482 - let Group, Element be the string representation of the
483 group and element dicom tag members,
484 - let ItemNumber be the string representation of the integer
485 index of the considered item number of a sequence,
486 Let the key of a tag embeded in a sequence, noted SeqTag, be
488 /ItemNumber#Group|Element
489 where "/", "#" and "|" are characters acting as separators.
490 Then the general form of a gdcmTagKey is given by:
491 Group|Element<SeqTag>
492 where <SeqTag> means NO or many instances of SeqTag.
493 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
496 but the gdcmTagKey of a tag "embeded" is the first item of
497 a sequence, itself nested in the third item of a sequence is the
499 0004|1220/2#0008|0082/0#0008|0090
500 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
501 order to hold the new sequence compatible key. Previously, the
502 GetKey() method would look in the underlying gdcmDictEntry.
503 - src/gdcmDocEntry.cxx:
504 -- constructor now copies the underlying DictEntry key, in the local
506 -- ::Print: displays the member Key, instead of the (group, element).
507 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
508 - src/gdcmDocEntrySet.h:xi
509 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
510 -- now has a new BaseTagKey member.
512 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
513 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
515 This poses the problem with the semantics of the following lines
516 LoadEntryVoidArea(0x0028,0x1201); // R LUT
517 LoadEntryVoidArea(0x0028,0x1202); // G LUT
518 LoadEntryVoidArea(0x0028,0x1203); // B LUT
519 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
520 to the long FIXME note for what the problem is. Nevertheless in
521 order to get things working the dicom dictionary was altered !
522 Please fix things urgently...
523 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
524 information), see above note on moving the member VoidArea. Nevertheless
525 the following entries previously correctly set as US are now inproperly
527 0028 1201 OW IMG Red Palette Color Lookup Table Data
528 0028 1202 OW IMG Green Palette Color Lookup Table Data
529 0028 1203 OW IMG Blue Palette Color Lookup Table Data
530 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
531 of gdcmDocEntry moved to gdcmSeqEntry.
532 * src/gdcmSeqEntry.cxx: STYLE.
534 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
535 * Test/TestAllEntryVerify.cxx minor fix and added comments.
537 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
538 * gdcmPython/testSuite.py: all the test suite in python is now moved
539 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
540 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
541 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
543 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
544 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
545 to avoid inclusion recursion until STL is reached.
546 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
547 mecanism. errno.h is not included in gdcm anymore.
548 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
549 (gdcmFormatError now inherits from gdcmFormatUnexpected).
551 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
552 gdcmData/TestAllEntryVerifyReference.txt
553 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
554 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
555 exception_on_error parameter.
556 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
557 - vtk/vtkGdcmReader.cxx changed accordingly,
558 - Example/*.cxx and Test/*.cxx changed accordingly.
560 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
561 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
562 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
563 enable_sequences removed from gdcmHeader constructor and dependencies.
564 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
565 * gdcmPython/demo/PrintHeader.py: dummy fix.
566 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
567 skip_shadow removed from gdcmHeader constructor and dependencies.
568 * Example/*.cxx and Test/*.cxx changed accordingly.
570 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
571 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
572 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
574 2004-07-21 Jean-Pierre Roux
575 * FIX Now, Parsing and Printing a DICOMDIR do work!
576 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
578 2004-07-20 Jean-Pierre Roux
579 * FIX Some brain damaged headers have Zero-Lenght fields
580 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
582 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
584 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
585 variable (instance of gdcmDebug) by a definition macro, and the instance
586 is now in static in the gdcmDebug class
587 * src/gdcmSQItem.h : (FIXME) remove an undefined method
588 * Test/PrintAllDocument.cxx : bug fix in the result of the test
590 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * WARNING: ctest now depends more tightly on gdcmData. You should
592 check out gdcmData properly for things to run smoothly...
593 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
594 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
595 we need the pixels not be loaded in order to use the ValEntry
596 that displays position and size).
597 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
598 This is a C++ based equivalent of gdcmPython/testSuite.py that should
599 be deprecated. If you have any doubts about the advantages of a
600 modern scripting language (read Python) versus grass root C++ (i.e.
601 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
602 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
603 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
604 Anyhow, consider documenting the gdcmData images in
605 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
607 * Test/CMakeLists.txt:
608 - now uses TestAllEntryVerify.cxx
609 - specific comments on oldACR00001.ima (now renamed in gdcmData
610 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
611 gdcmData/TestAllEntryVerifyReference.txt
614 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
615 * src/*.[h|cxx] : typedef clean up
616 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
617 - TagKey renamed to gdcmTagKey (for external usage)
618 - VRKey renamed to gdcmVRKey (for external usage)
619 - removal of typedef duplication.
620 - Removed all unecessary inline keyword from class inline definitions.
621 - Some method|function(void) declarations replaced with method|function().
622 * src/jpeg/libijg12/jdhuff12.c:
623 - printf polluting ctest removed.
624 - TAB removal for comminting
626 - TestAllReadCompareDicom.cxx: added a test that compares all the
627 images in gdcmDataImages.h with corresponding images in
628 gdcmData/BaselineDicom/. When baseline images are not present
629 this test creates them.
630 Note: we need to validate each reference image, but before that
631 I'd like to rename them with a more explicit name...
632 - CMakeLists.txt: changed accordingly.
633 * Example/*.cxx: examples now only include gdcm.h (as opposed to
634 including each header needed).
636 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
637 * Test/*.cxx and Example/*.cxx: moved some examples away from the
638 test suite to the Example directory. Are concerned:
643 - TestWriteSimple.cxx
644 * Test/CMakeLists.txt: added some comments on reasons for black listing
645 image gdcmData/oldACR00001.ima
647 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
648 * Test/CmakeList.txt: removed the following from black list (to be coherent
649 with removal from gdcmData):
650 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
651 - gdcm-MR-PHILIPS-16.dcm
653 Added the following because after last cvs update, they cause
654 ctest -R TestReadWriteReadCompare
656 - gdcm-MR-SIEMENS-16-1.acr
658 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
659 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
660 new comments in this file) we temporarily (sigh) move to a weaker
662 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
663 we don't need to black list the following images anymore:
664 - 8BitsUncompressedColor.dcm
666 - US-PAL-8-10x-echo.dcm
667 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
668 fixes and the beautified code ;-)
669 This fixes the bug introduced in version 1.42 (when beautifying)
670 that made the parsing of 8BitsRunLengthColor.dcm unproper.
671 Note: ctest was blind to this bug (this means we need to still
672 improve the test suite). The bug could be detected by using
673 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
675 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
676 and by displaying the (garbage) produced file temp.XDCM...
678 2004-06-29 Jean-Pierre Roux
679 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
680 - replace by uggly but working old code :-(
681 A lot of things should be OK again.
682 It's really urgent to have a test suite that *tests*,
683 to prevent Frog's beautifying sessions to break all the stuff
684 (twice, withing a fortnigh ...)
686 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
687 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
688 redundancy) to added Test/TestReadWriteReadCompare.cxx
689 * Test/CmakeList.txt: because the compare test of
690 Test/TestReadWriteReadCompare.cxx fails, the following images are
691 black listed: - 8BitsUncompressedColor.dcm
693 - US-PAL-8-10x-echo.dcm
694 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
695 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
696 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
697 and ad-hoc kludge. This kludge is now removed, and on encountering
698 such an image (OB field brain damaged) we set errno. Then in
699 ::FindDocLength() we "fix" the length as being ALL what remains
700 in the file (until EOF). We then proceed, hoping for the best...
701 This fixes a SegFault in ShowDicom when trying to write such an
703 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
704 (because TestWriteRead breaks on it, after a non conformal commit?).
705 ctest now runs properly, except for MakeDicomDir (which was allways
706 broken) and the Python related stuff (still not fixed).
708 2004-06-24 Jean-Pierre Roux
709 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
710 FIX : Test/TestReadWrite now iterates on all the file names
711 (instead of infinite loop)
712 ENH : Test/TestWriteRead now iterates on all the file names
714 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
715 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
717 2004-06-24 Jean-Pierre Roux
718 FIX : - now Write drops LUT Descriptors and LUTs (if any)
719 when SamplesPerPixel =3
720 - now Write is no longer confused by
721 'BitsAllocated = 12" and 'BitsStored=12"
722 - "UN" value representation Elements are now written correctly
723 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
724 ENH : - now gdcmHeader has its own Write methods
725 (in order to split the job that has not to be done
728 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
729 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
730 loop on the same image until memory went out.
731 Note: this means we still have gobs of memory loss in PrintDocument
732 * src/gdcmDocument.cxx: fixes problem on parsing on file
733 gdcmData/16BitsJpegLosslessGrayScale.dcm.
735 2004-06-24 Jean-Pierre Roux
736 FIX : Write - All the Sequences and Sequence Item are now written
737 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
738 is added a the end, when necessary.
739 - A lot of brain-damaged images, that were read correctly are
740 now written correctly
741 - length compatible BinEntry are now loaded correctly
742 (even for odd groups)
743 Note : only Explicit Value Representation was checked.
744 (question : is implicit VR really necessary for gdcm ?)
746 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
747 * DEVELOPPER: added a proposition of coding style.
748 * src/gdcmDocEntry.h: removed every inline declaration (for test of
751 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
753 Use the gdcmDocEntry::Print() and Write() instead.
754 * src/gdcmDocument.cxx: bug fix.
756 2004-06-22 Jean-Pierre Roux
757 FIX : gdcmDocument.cxx
758 - Now we do recognize the JpegLossLess format (there was a misstyping in
759 code 'beautyfication' :-(
760 - Now we automaticaticaly load the Luts, if any
762 2004-06-22 Jean-Pierre Roux
763 In order : to write Sequences, whatever their imbrication level,
764 : to allow user to create his own Sequences
765 a lot of modif where necessary (adding, moving, or virtualising methods)
767 WARNING : save your own sources *before* cvs up !
770 ADD virtual void Write(FILE *fp, FileType filetype);
773 ADD virtual void Write(FILE *fp, FileType filetype);
774 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
777 ADD virtual void Write (FILE *fp, FileType filetype)=0;
778 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
779 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
780 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
781 ADD std::string GetEntryByName(TagName name);
782 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
784 std::string vr = "unkn",
785 std::string fourth = "unkn",
786 std::string name = "unkn");
787 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
788 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
789 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
790 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
791 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
792 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
793 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
794 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
797 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
798 ADD virtual std::string GetEntryByName (TagName tagName);
799 ADD virtual std::string GetEntryVRByName (TagName tagName);
800 REM virtual bool Write(FILE *, FileType);
801 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
802 FILE *_fp, FileType type);
803 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
804 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
805 REM virtual bool WriteEntries(FILE *_fp,FileType type);
806 REM virtual std::string GetEntryByName (std::string tagName);
807 REM virtual std::string GetEntryVRByName (std::string tagName);
808 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
809 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
810 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
812 std::string vr = "unkn",
813 std::string fourth = "unkn",
814 std::string name = "unkn");
815 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
816 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
817 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
818 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
821 ADD virtual void Write(FILE *fp, FileType filetype);
824 ADD virtual void Write(FILE *fp,FileType filetype);
827 ADD virtual void Write(FILE *fp, FileType filetype);
828 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
829 REM std::string GetEntryByNumber(guint16 group, guint16 element);
830 REM std::string GetEntryByName(TagName name);
833 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
835 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
837 The default constructor invoked by the line
838 gdcmHeader *f1 = new gdcmHeader( header );
839 was gdcmHeader::gdcmHeader(bool) instead of the expected
840 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
841 Hence the parsing wasn't executed... See also below.
842 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
843 as explicit constructor didn't do the trick to fix the above problem.
844 Could anyone explain why ?
845 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
846 properly calls gdcmValEntry::Print() (that was weed out from
847 code related to gdcmBinEntry).
849 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * In order to fix memory leaks:
851 - Test/TestWriteSimple.cxx: added cleaning of free store through
853 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
854 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
855 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
856 (through the call to ::AddDicomDirMeta()) or the destructor
857 would crash when deleting uninitialized ::metaElems].
858 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
859 - src/gdcmDocument.cxx:
860 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
862 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
863 was causing memory leaks.
864 - src/gdcmSQItem.cxx:
865 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
866 cleanly handled with polymophism: sorry but my milage is low).
867 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
868 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
869 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
870 This avoids SegFaulting.
871 - src/gdcmSQItem.h: coding style.
873 - Test/TestWriteSimple still severely sucks. The output image content
874 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
875 damaged when displayed with vtkgdcmViewer.
876 - on memory leaks: TestWriteSimple leaks really less (see entry
877 of 2004-06-18 in Changelog file for the call to valgrind).
878 - on segfaults: ctest now passes all the tests but one (no more
880 * Erroneous leading white fix:
881 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
882 white[s] (as opposed to from >> xxx, that removes it [them].
883 - src/gdcmTS.cxx: ditto.
884 - gdcmPython/testSuite.py: dirty related kludge removed.
885 * src/*: remaining references to gdcmParser removed.
886 * src/*[cxx|h]: added copy[way]left header.
889 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
890 * In order to fix writing of dicom files:
891 - Test/TestWriteSimple.cxx: a simpler example of writing.
892 - Test/CMakeLists.txt changed accordingly.
893 - src/gdcmDocument.cxx:
894 -- The destructor now recursilvely removes potential sequences.
895 -- Bug fix in ::IsJPEG2000()
896 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
897 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
899 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
900 to only declared) and build on top of
901 ::GetDocEntryByNumber(guint16, guint16).
902 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
903 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
904 for usage in destructor and treatement of promotion in
905 ::ReplaceOrCreateByNumber().
906 - src/gdcmSQItem.cxx: destructor should better handle his job.
907 Test/TestWriteSimple now runs (or at least it DOES something).
908 * We can now start hutting memory links. A good starting point is:
909 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
910 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
911 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
913 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
914 * Valgrind note: after Mathieu Malaterre teached me how to read
915 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
917 Using gcc, you can force the STL to use malloc and to free memory as
918 soon as possible by globally disabling memory caching.
919 With 3.2.2 and later, you should export the environment variable
920 GLIBCPP_FORCE_NEW before running your program.
921 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
922 simply vanish (it is still not clear to me, whether this means that
923 STL std::string leaks or if valgrind believes it leaks...).
924 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
925 running bin/gdcmTests makeDicomDir):
926 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
927 - Test/makeDicomDir.cxx now properly traps empty lists and returns
929 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
930 SegFaulting (I drowned in DicomDir related code when trying to
931 understand why the list is empty...).
932 * src/gdcmDocument.h: first BSD license header try.
933 * Doc/License.txt added.
935 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * src/gdcmDocument.[h|cxx]:
937 - Clean up of the Transfer related predicates. They are now all based
938 on new method isGivenTransferSyntax, that (should) handle properly
940 - general clean up, simplification, and coding style.
941 - Specific clean up of Parse7FE0() (umproperly named actually).
942 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
944 2004-06-14 Jean-Pierre Roux
946 - fix the display of Sequence Delimitor (SQDepthLevel pb)
947 - fix the display of SQItem ordinal number
948 - add the GetSQItemByOrdinalNumber method
949 - remove some useless never written private methods
951 2004-06-14 Jean-Pierre Roux
953 - adding a constructor taking a gdcmDocEntry as an input param
954 - ReplaceOrCreateByNumber now returns :
955 a gdcmBinEntry * if a Binary (void *) value is passed as a param
956 a gdcmValEntry * if a string value is passed as a param
958 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
959 according to the param type (no longer sets a gdcmDocEntry)
960 - GetValEntryByNumber, GetBinEntryByNumber added
961 - NewValEntryByNumber and NewBinEntryByNumber added
963 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
965 - GetSQItemNumber and SetSQItemNumber added, to provide
966 a (relative) Item identier inside a given Sequence
967 \warning : some pb remaining around this number
969 - AddEntry now takes the Item Number as a param
971 - adding a constructor taking a gdcmDocEntry as an input param
973 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * Memory leak hunt with the following command:
975 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
976 --show-reachable=yes gdcmTests PrintDocument
977 It looks like many (all?) leaks are due to the STL (or a bad usage
978 of the STL. The lines producing the leaks now have a comment with
979 a "MEMORY LEAK" tag: you can retrieve them with
980 grep "MEMORY LEAK" src/*
981 Here are two typical examples which I can't help fixing:
986 char * test = "babo";
987 name = test; //// <--- valgrind detects 960 bytes lost in
988 //// call to std::string::operator=(char const*)
989 name.clear(); //// Doesn't help !
997 std::cout << "Type a bunch of characters followed by RETURN: ";
998 getline(std::cin, line); //// <--- valgrind dectects a loss
999 //// of 1320 bytes in call to
1000 /// std::basic_istream<>& std::getline<>
1006 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * src/gdcmHeader.[cxx|h]:
1008 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1009 and related, moved away to gdcmDocument.
1010 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1011 the corresponding protected accessors of inherited class
1012 gdcmDocument, removed ! As a consequence gdcmFile had to be
1013 declared friend of class gdcmDocument (see below).
1014 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1015 - Clean up of undefined or unused methods.
1016 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1017 account the changes to gdcmHeader.h).
1018 * src/gdcmDocument.h:
1019 - gdcmFile is now a friend class (in order to take into account the
1020 changes to gdcmHeader.h).
1021 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1022 (see changes to gdcmHeader.h).
1023 - Accessors (reading on the form GetEntry*) are now public.
1024 - Clean up of undefined or unused methods.
1025 * src/gdcmDocument.cxx:
1026 - adaptation to changes to gdcmDocument.h
1027 - ::OpenFile now writes a verbose message when file cannot be opened.
1028 - some std::string properly set to VRKey
1029 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1030 references to gdcmDocument.
1031 * Test/TestFindTags.cxx: changed accordingly to above changes.
1032 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1033 cvs repository gdcmData.
1035 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1036 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1037 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1038 conflicts with gdcmValEntry::voidArea.
1039 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1040 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1041 Value representation between StringRepresentable and BinaryRepresentable.
1042 * src/gdcmDocument.cxx:
1043 - method ParseDES: proper indentation restored and usage of
1044 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1045 - method LoadDocEntry: the fingerprint left in the SetValue() of
1046 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1047 removed. Reverting to previous code segment with the proper
1048 dynamic_cast< gdcmValEntry* >.
1049 Note: this was (partially) breaking the python test suite
1050 (gdcmPython/testSuite.py) that made usage of the above
1051 fingerprint to check presence of "Pixel Data".
1052 * src/gdcmDocEntry.h: coding style.
1053 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1054 now taken into account.
1055 * gdcmPython/gdcm.i: adaptation to the new internal representation
1056 of gdcm (exit gdcmParser, hello gdcmDocument).
1057 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1059 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1060 anymore, but instead prints the loaded Python dictionary.
1061 * .... alas, the python testSuite is still broken.
1063 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1064 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1066 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1067 * src/gdcmUtil.h : export methods
1069 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1070 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1072 * Initial addition of automatic python testing
1073 * Initial addition of automatic image comparison
1075 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1076 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1077 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1079 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1080 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1081 * Test/ShowDicom.cxx : bug fix for msvc compilation
1082 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1084 2004-05-04 Jean-Pierre Roux
1085 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1086 new concepts (and new classes) :
1087 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1088 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1089 - Sequence Doc Entries (gdcmSeqEntries)
1090 a Sequence is composed of Items.
1091 Each item is a set of Doc Entries (this is recursive)
1092 The non uniqueness of the 'Dicom tag' is due to this recursivity
1093 (never taken into account)
1094 Our unability to add a new 'entry' in the header
1095 at the proper location (neither in the H-Table (map or multimap),
1096 nor in the Chained List is also due to this recursivity.
1097 Don't try, right now, to use/modify/compile these new sources :
1098 nothing is finished.
1099 We just commit all the stuff, 'as is', in order not to loose it.
1101 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1102 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1104 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1105 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1106 file prefix (SetFilePrefix)
1108 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1109 * Add a new test: ShowDicom, for now this is just the c++ version of
1110 checkRead.sh, later it will be able to compare the image read against a
1112 * Replace the DEBUG on the stack with a global entry in cmake interface:
1113 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1115 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1116 * Add an example subdir, with a real example on how to read + write a
1119 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1120 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1121 * Doc/CMakeLists.txt: the main page is now properly differentiated
1122 between the developper and user version.
1123 * Doc/doxygen.config.in: dropped search related obsolete flags
1124 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1126 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1127 * DEVELOPPER: added some helpfull comments for compile/test/install
1130 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1131 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1132 src directory, now generated in the build dir.
1133 2. Tests as mentionned smarter
1135 4. Add a new method in gdcmDict that return the PubDict by name
1136 this is interesting for 3rd party lib like ITK,
1137 where we could set the institution name / patient name...
1139 * ENH: 1. Now the test suite is working for real
1140 2. All binaries are now output in the gdcm-bin directory
1141 (this was not true before)
1143 2004-04-28 Jean-Pierre Roux
1144 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1145 SeQuence indented printing of Dicom Header.
1146 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1147 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1148 Computation of SQDepthLevel is now part of gdcmHeader constructor
1149 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1150 tree-like structure of a Dicom Header.
1151 * FIX Test code cleaning
1153 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1154 * ENH: Adding automatic testing
1155 1. Need a DartConfig.cmake to submit to public
1156 2. Add a test driver gdcmTest.cxx
1157 3. gdcmTestMain, an helper for the main test driver gdcmTest
1158 4. Files in Test don't have a main anymore, this becomes interesting
1159 when we add more and more tests, thus dsw don't have to load
1161 * ENH: Adding a GDCM_DATA_ROOT for testing
1162 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1163 one file instead of seven + some small cleanup
1165 2004-04-22 Jean-Pierre Roux
1166 * ENH Minor changes to the Print() methods.
1167 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1168 Header printing. Example given with :
1169 > PrintHeader fileName 2 new
1170 (SQ based tree-like structure still to be done for the Header ...)
1172 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1173 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1174 1. I have added some unsigned where needed
1175 2. Some function parameter not used -> (void)
1176 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1177 4. g++ don't like character '\' in comment
1178 5. #define jpeg_create_decompress jCreaDecompress
1179 this really need to be fixed
1180 6. virtualize destructor of gdcmObject ... leakage
1181 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1182 this also really need to be fixed
1183 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1184 remove compression file
1185 (as we only do decompression, right ?)
1186 * ENH: Change malloc/calloc/free with c++ equivalent
1188 2004-04-21 Jean-Pierre Roux
1189 * FIX gdcmHeaderHelper::GetXSpacing
1190 when a single value is found (bug ?), xpacing is now
1191 defaulted to yspacing
1193 2004-04-19 Jean-Pierre Roux
1194 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1195 * ENH add parameters :
1196 bool exception_on_error = false,
1197 bool enable_sequences = false,
1198 bool ignore_shadow = false
1199 to the gdcmFile constructors to be full gdcmParser compliant
1200 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1201 to allow reading of PAPYRUS 3.0 files
1203 2004-04-06 Jean-Pierre Roux
1204 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1206 2004-04-02 Jean-Pierre Roux
1207 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1208 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1209 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1211 2004-03-30 Jean-Pierre Roux
1212 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1213 for ACR file, written out as DICOM files (hope so...)
1215 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1216 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1217 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1218 moved to base class gdcmParser and only the specialisation is kept
1220 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1221 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1222 already does the job.
1223 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1224 (to be consistent with gdcmParser::WriteEntries).
1226 2004-03-30 Benoit Regrain
1227 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1228 upate of the object's instance. It's passed to 2 in the unfavorable
1229 case : one in the ExecuteInformation, one in the ExecuteData
1231 2004-03-29 Jean-Pierre Roux
1232 * ENH : Check on file type to be written moved
1233 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1234 * FIX : gdcmObject::ResetBoundaries now stops properly
1235 when end-of-list is reached
1236 : gdcmVersion modified (as Benoit Regrain asked)
1238 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1239 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1240 * src/gdcmUtil.cxx: added forgotten iostream include.
1241 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1242 equivalent to ExplicitVR in existing code).
1244 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1245 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1246 now contains all the gdcmGlobal related code.
1247 * minor coding style and doxygenation changes.
1249 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1250 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1251 now contains all the Debug related code.
1252 * minor clean-up of includes in src/*.cxx
1253 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1254 CreateCleanString) removed.
1255 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1256 * Doc/DoxyMainPageUser.txt added.
1257 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1258 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1259 src/gdcmDirList.cxx)
1261 2004-03-24 Jean-Pierre Roux
1262 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1264 2004-03-23 Jean-Pierre Roux
1265 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1266 big endian made volumes
1267 * ENH Now gdcmParser constructor and destructor are protected to forbid
1268 end user to instanciate class gdcmParser
1269 (only gdcmHeader and gdcmDicomDir are meaningfull)
1271 2004-03-22 Benoit Regrain
1272 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1273 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1274 gdcmSerie to gdcmDicomDirSerie
1276 2004-03-19 Jean-Pierre Roux
1277 * ENH Now the tree-like structure describing a DICOMDIR comming from
1278 an already existing DICOMDIR file is consistent with
1279 the home-made tree-like structure build ex-nihilo
1280 or build from the files held (recursively) in a Directory
1281 functions gdcmDicomDir::CheckBoundaries()
1282 gdcmObject::SetBoundaries() added
1284 2004-03-17 Jean-Pierre Roux
1285 * REM (Eric Boix bug) : removal of meaningless
1286 gdcmDicomDirImage::NewImage function.
1287 * FIX now file names and directory name are written properly in the
1289 * FIX now gdcmDicomDir constructor may be call without any trick
1292 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1294 of gdcmDicomDirImage::NewImage as empty function.
1296 2004-02-28 Jean-Pierre Roux
1297 * ENH add gdcmDicomDir:NewPatient
1298 add gdcmDicomDirPatient:NewStudy
1299 add gdcmDicomDirStudy:NewSerie
1300 add gdcmDicomDirSerie:NewImage
1301 to allow making gdcDicomDir object.
1302 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1303 (as opposite to the gdcmHeader chained list)
1305 2004-02-11 Benoit Regrain
1306 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1307 when using from python
1309 2004-02-10 Benoit Regrain
1310 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1311 * FIX : in gdcmDicomDir when the directory is empty
1312 * ENH : add callback and methods to get the progression of dicomDir
1315 2004-02-06 Jean-Pierre Roux
1316 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1317 - GDCM_META added to gdcmDicomDirType
1318 - class gdcmMeta created
1319 * ENH : - A brief summary is now displayed at the beginning of
1320 'testDicomDir' to help disaster magnitude estimation
1321 * REM : Now useless Test/explDICOMDIR.cxx
1323 2004-02-05 Benoit Regrain
1324 * ENH : add methods in gdcmObject to get the hash table or the list of
1326 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1327 * FIX : wrapping python for TagHeaderEntryHT
1329 2004-02-04 Benoit Regrain
1330 * FIX : even length for some strings when writting the dicom dir
1331 * FIX : sort the images in the dicom dir
1332 * FIX : Bug fix for python use of dicom dir
1333 * ADD : a python demo
1335 2004-02-04 Jean-Pierre Roux
1336 * FIX : Final solution (?) for icone embedded images
1337 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1338 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1339 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1340 gdcmData/gdcm-MR-SIEMENS-16.acr1
1341 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1342 to make full checking easier
1344 2004-02-04 Benoit Regrain
1345 * FIX : WriteEntries : coding style & logic in parameters
1346 * FIX : Set the elements to create the DicomDir in a dictionary file
1348 2004-02-03 Benoit Regrain
1349 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1350 * gdcmDicomDir : add the load of directory
1351 * Bug fix and print add-on
1353 2004-02-03 Jean-Pierre Roux
1354 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1355 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1356 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1357 * FIX gdcmParser.cxx : 'group length' elements are now considered
1358 as integers, even for shadow groups, when file is Implicit VR
1360 2004-02-02 Jean-Pierre Roux
1361 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1363 of the last synonym :-(
1364 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1366 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1367 * FIX taking into account the possible 7fe0,0010 multiplicity
1368 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1369 to allow removal of references to 7fe0,0010, to deal with
1370 ACR-NEMA images, when 0028,0200 is meaningfull
1372 2004-01-31 Jean-Pierre Roux
1373 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1374 no longer writes 'Un' on disk
1375 * FIX SQ elements with actual length are now dealt with corectly
1376 * FIX gdcmFile::WriteBase make the difference, for color images, between
1377 the length (for Palette expanded images)
1378 and Raw Length (non expanded image + Palette)
1379 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1380 (that broke Write). Replaced by UL.
1381 Aware user will reload the field if he
1382 thinks it's necesssary
1384 2004-01-30 Jean-Pierre Roux
1385 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1386 when 'dirty Acr' is found, to be compliant with the new
1387 IsReadable() methods.
1389 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1390 (no DOUBLE images in kosher DICOM,
1391 but so usefull for people that miss them ;-)
1393 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1394 DICOMDIR related utilities (not checked as Windoze compliant)
1396 2004-01-28 Jean-Pierre Roux
1397 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1399 2004-01-27 Jean-Pierre Roux
1400 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1401 to allow skipping the shadow elements, to save memory space.
1402 The TRUE value for this param has to be used
1403 with a FALSE value for the 'enable_sequence' param.
1404 ('public elements' may be embedded in 'shadow Sequences')
1405 * gdcmHeader methods now deal with 'embedded icones images' in the header
1406 (even when an 'icone image sequence' is announced by the
1407 element (0x0088,0x0200), but there is NO icone at all ...
1409 * gdcmHeader sometimes Image Location value doesn't follow
1410 the supposed processor endianity (see gdcmData/cr172241.dcm).
1413 * gdcmHeader add the method
1414 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1415 to get *all* the Header Entries with the same tag.
1416 GetHeaderEntrySameName is probabely *useless*
1417 (no meaning : Name is *not* an identifier within the Dictionnary)
1419 2004-01-26 Benoit Regrain
1420 * Bug fix in the print of hexadecimal representations. Remove long fields
1421 in the print and add a third level of print to print them
1423 2004-01-23 Benoit Regrain
1424 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1425 * Bug fix on test suite after remove the strip made on not string fields
1426 * Split the IsReadable method between gdcmParser which test that the file
1427 is dicom and gdcmHeader which test that it's an image file
1429 2004-01-22 Benoit Regrain
1430 * DicomDir : clean code, add methods, set variables in protected or private
1431 * gdcmUtil : bug fix for the clean string method
1433 2004-01-19 Benoit Regrain
1434 * Add the use of shadow dictionaries
1435 * bug fix and coding style
1437 2004-01-19 Benoit Regrain
1438 * src/gdcmFile.cxx : bug fix concerning the close of file
1439 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1440 * Add the update of header entries using the shadow library
1442 2004-01-19 Benoit Regrain
1443 * removal of file gdcmHeader2.cxx
1444 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1445 inheriting from gdcmParser. This split is to prepare the integration
1446 of dicom dir parsing
1447 * bug fix under python
1449 2004-01-16 Jean-Pierre Roux
1450 * REM removal of class gdcmHeaderEntrySet
1451 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1452 * ADD add file gdcmHeader2.cxx
1453 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1455 2004-01-15 Benoit Regrain
1456 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1457 entries created while parsing the header. Thus, they will be destroyed
1458 when the gdcmDictSet will be destroyed
1459 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1462 2004-01-15 Benoit Regrain
1463 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1464 made a fatal error because of the memory release at the end of program.
1465 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1466 some memory and vtk seems to have some problems with that.
1467 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1469 2004-01-14 Benoit Regrain
1470 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1471 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1472 * src/*.[h|cxx] : make changes due to class name changes
1473 * gdcmPython/demo/*.py : bug fix due to method names
1475 2004-01-13 Benoit Regrain
1476 * src/*.[h|cxx] : coding style
1477 * vtk/*.[h|cxx] : coding style
1479 2004-01-13 Benoit Regrain
1480 * gdcmPython/testSuite.py : test the readable flag of file for tests
1481 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1482 It's lied to the stl compilation by MSVC (windows, always windows...)
1483 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1485 2004-01-12 Benoit Regrain
1486 * src/*.h : add comments
1487 * src/gdcmDictSet.h : set the method BuildDictPath in public
1488 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1489 directly setted in the source code
1490 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1493 2004-01-09 Benoit Regrain
1494 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1495 * setup.py : use a reference to gdcmVERSION
1497 2004-01-07 Benoit Regrain
1498 * Modification to compile with the distutils.
1501 2003-12-10 Benoit Regrain
1502 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1503 can use a gdcmHeaderHelper to load datas
1504 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1505 made in the source code
1507 2003-12-10 Benoit Regrain
1508 * Update Windows projects and .cvsignore files
1510 2003-11-12 Jean-Pierre Roux
1511 * ENH gdcmHeader constructor has one more parameter (default value : false)
1512 that allows the user to 'go inside' the SeQuences only
1514 gdcmElValSet:Print takes it into account
1516 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1517 * ENH: Update gdcmPython/CMakeLists
1518 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1519 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1521 2003-11-10 Jean-Pierre Roux
1522 * FIX : gdcmHeader::LoadElements is now based
1523 on the ListTag listElem member,
1524 not longer on the TagElValueHT tagHt member
1525 * ENH : PrintPubElVal shows (temporarily) both results,
1526 with the tagHt member and the listElem member.
1527 (it's easier to 'see' the problems when using Printheader)
1529 * FIX : old private member LgrElem is now splitted into
1530 ReadLength : Length actually found on disk (updated only
1531 if bug fixing is necessary), for internal
1533 UsableLength : Updated by FixFoundLength, to fix a bug
1534 or to allow Parser going on.
1535 Will allow to re-write a kosher header when a SeQuence
1536 with a length (not 0000) is found
1537 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1538 because gdcmElValSet::Add does not update ListElem
1541 2003-11-07 Jean-Pierre Roux
1542 * FIX misstyping in Transfert Syntax name table
1543 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1544 when they have an actual length (not 0000 nor FFFFF)
1545 (Nobody should care of it, but DICOMDIR explorers)
1547 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1548 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1550 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1551 * ENH: vtkGdcmReader now supports LUT !
1552 (vtkgdcmViewer for now is not able to use them though)
1554 2003-11-05 Jean-Pierre Roux
1555 * in testSuite.py : new files names for checking the package
1556 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1557 that returns the pixel area size to the *aware* (vtk) user
1558 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1560 2003-11-05 Benoit Regrain
1561 * in testSuite.py : Modify the rules for checking the paths
1562 : Explicit error messages
1563 * in __init__.py : Related modif
1565 2003-11-03 Jean-Pierre Roux
1566 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1567 to be used by aware (vtk) users that want to manage
1568 LUT (and no to turn the PALETTE image into an RGB pixels one)
1569 * GetPixelType now returns 8U for 24 Bits images
1570 (vtkGdcmReader compliant)
1572 2003-10-31 Jean-Pierre Roux
1573 * Removal of *all* gdcmData images and add them again
1574 in order to loose the 'history' of un-anonymised images
1576 2003-10-31 Jean-Pierre Roux
1577 * RMV : removal of useless jBitsInJsample.h
1578 for both 8 and 12 Bits JPEG Lossy Libraries
1580 2003-10-31 Jean-Pierre Roux
1581 * ENH : Add the functions gdcmFile::GetImageDataRaw
1582 gdcmFile::GetImageDataIntoVectorRaw
1583 that act as GetImageData and GetImageDataIntoVector
1584 except the making of an RGB Plane from Gray Plane + LUT
1585 Intended to aware (vtk) users who know how to manage
1588 GetLUTRGBA return a R,G,B,A LUT if any
1589 lgrTotaleRaw gives the 'Raw' length
1590 GetImageDataRaw returns the gray Plane
1591 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1592 (They stay Grey, just like with other Dicom viewers :-(
1594 2003-10-30 Jean-Pierre Roux
1595 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1597 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1598 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1599 being coherents dicom files.
1601 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1602 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1604 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1605 * ENH: Two steps is necessary to please VC++ compiler...
1606 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1607 * ENH: Add include dir to medcon lib
1608 * FIX: only one function is being exported for now !
1609 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1611 2003-10-29 Jean-Pierre Roux
1612 * adding gdcmHeader::GetLUTRGBA
1613 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1614 --> Mathieu, the modif u're waiting for is not yet committed
1615 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1617 2003-10-27 Jean-Pierre Roux
1618 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1619 00191113.dcm DermaColorLossLess.dcm
1620 MxTwinLossLess.dcm RadBWLossLess.dcm
1621 * ENH: For version prior to vtkImageViewer2 -r 1.19
1622 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1624 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1625 * Removal of ido stuff in CMakeLists.txt
1627 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1628 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1629 * FIX: remove a call to ->Modified ... see comments
1630 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1632 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1633 * FIX: Problem with path for libvtkgdcmPython
1634 * ENH: Try adding a search script for python site-package
1635 * RMV: Remove some file from medcon lib that are not necessary
1636 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1637 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1638 * FIX: More pragma disable fro VC++,
1639 I don't think I break something as it is also disable in VTK/ITK.
1640 But it fasten debug compilation time.
1642 2003-10-23 Jean-Pierre Roux
1643 * gdcm now deals with 16 Bits Run Length Encoded images
1644 (they are compressed as 2 planes images,
1645 one for the high Bytes, the other for low Bytes)
1647 2003-10-22 Jean-Pierre Roux
1648 * Now CheckRead takes into account :
1649 - the bugged 'Leonardo' Siemens images
1650 - the XA images, sent thru the burning VPRO station
1651 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1654 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1655 * FIX: When copying a Makefile.am to CMakeLists.txt
1656 one should remove the '\'
1658 2003-10-22 Jean-Pierre Roux
1659 * in gdcmData adding a bugged 'Leonardo' Siemens image
1660 (wrong lengths in header)
1661 OK with gdcm, KO with the other viewers :-)
1662 * add a GE dlx XA image, thru the VEPRO burning station
1665 2003-10-21 Jean-Pierre Roux
1666 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1667 for a brutal checking of vtkgdcmViewer compliance
1669 2003-10-21 Jean-Pierre Roux
1670 * add the files for 'xmedcon' Jpeg Lossless library
1671 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1673 2003-10-21 Jean-Pierre Roux
1674 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1676 2003-10-21 Jean-Pierre Roux
1677 * garbage Siemens 'Leonardo' images dealt with
1678 (the patch is easy to remove)
1679 * cosmetic changes to avoid warnings
1681 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1682 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1683 no need to press 'r' now.
1685 2003-10-20 Jean-Pierre Roux
1686 * upgrade of checkRead.sh checkWrite.sh according
1687 to new Jpeg Lossless decompressor
1688 * add US.3405.1.dcm, a genuine RGB medical file ...
1689 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1690 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1692 2003-10-15 Jean-Pierre Roux
1693 * general anonymisation in gdcmData
1694 * adding the 'color files' from
1695 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1696 * adding some well knowed bugged-header images
1697 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1698 waiting for their inclusion in Python testsuite
1700 2003-10-15 Jean-Pierre Roux
1701 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1702 no longer seg faults when file is not found
1704 2003-10-14 Jean-Pierre Roux
1705 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1708 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1709 * TODO: *.in file to genereate a UseGDCM later
1711 2003-10-14 Jean-Pierre Roux
1712 * Some supposed-to-be Dicom Images have no preamble.
1713 OpenFile takes it into account
1714 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1715 * Missing elements added in dicomV3.dic
1716 (just to be affraid : have a look at
1717 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1718 and do it again next year ;->
1720 2003-10-13 Jean-Pierre Roux
1721 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1722 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1723 But there are NOT. It's fixed !
1725 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1726 * FIX: "jpeglib.h" was not found on VC++
1727 * FIX: vtkgdcm was not being installed
1729 2003-10-10 Jean-Pierre Roux
1730 * ENH : OpenFile closes the file if it *really* doesn't look like
1731 an ACR-NEMA / DICOM one.
1732 * FIX : testWrite no longer writes an empty file if the source file
1733 is not gdcm Readable
1734 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1737 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1738 * FIX: CMake generate now documentation
1739 * ENH: out of source doc build !
1740 * ENH: Generate both user and dev documentation
1741 * ENH: Should work on windows too
1742 * ENH: Only one doxygen config.in file is needed
1743 * FIX: make install should be ok now on ùnix plateform
1744 * FIX: PATH to dictionary was wrong (missing /)
1745 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1747 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1748 * vtkGdcmReader is now able to read rgb dicom file.
1749 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1750 * added a gdcmViewer to vtk test, use mouse to control
1751 window level & window width
1753 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1754 * CMake-ification of gdcm, we have now two build system
1755 * FIX: on cygwin Wsock32 doesn't exist
1756 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1758 2003-10-06 Emanuel Ollart
1759 * FIX : compilation process wad broken.
1760 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1762 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1763 * change gdcmViewer -> vtkgdcmViewer
1764 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1766 2003-10-06 Jean-Pierre Roux
1767 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1768 ( e.g : well known GE images with a wrong elem length,
1769 : Philips MRI Images with a wrong Huffman table)
1770 * still to be done : allow the reading of bugged LEONARDO Siemens images
1772 2003-10-03 Jean-Pierre Roux
1773 * Odd length strings are padded with '\0' (not with spaces,
1774 to remain compliant with already defined strings,
1775 like Transfert Syntax UID and others)
1777 2003-10-03 Jean-Pierre Roux
1778 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1779 to allow displaying RGB images (not only by affim ;-)
1781 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1782 * vtkGdcmReader is now able to read rgb dicom file.
1783 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1785 2003-10-03 Jean-Pierre Roux
1786 * A few nasty patches to allow the reading of a lot of nasty images
1787 ( e.g : well known GE images with a wrong elem length,
1788 : Philips MRI Images with a wrong Huffman table)
1789 * still to be done : allow the reading of bugged LEONARDO Siemens images
1791 2003-10-03 Jean-Pierre Roux
1792 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1794 2003-10-03 Jean-Pierre Roux
1795 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1796 to allow displaying RGB images (not only by affim ;-)
1798 2003-10-03 Jean-Pierre Roux
1799 * gdcmFile::GetImageDataIntoVector now
1800 - deals with MultiFrames MultiFragments Run Length Encoded files
1801 - deals with YcBcR (YBR_FULL) files
1802 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1803 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1805 (no sample found :-(
1807 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1808 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1809 Two reasons: - clear things
1810 - third parties acces gdcm through header files, so won't
1811 suffer anymore VC++ complains
1813 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1814 * add argv[1] in testvtkGdcmReader.cxx
1817 2003-09-24 Jean-Pierre Roux
1818 * The lines are now eigthy characters long.for
1819 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1821 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1822 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1823 char* to std::string. Thus, the use of strdup becomes useless. (see
1824 previous commis of Malaterre)
1825 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1826 before the last Malaterre's commit.
1828 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1829 * This commit should fix the Debug building under VC++, the problem
1830 was mainly a mixture of debug and release lib being loaded at startup.
1831 * I also remove a depency to a specific C function: strdup. Because I had
1832 to force the link to msvcrtd (whereas strdup is in libc).
1834 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1835 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1836 located in the gdcmCommon.h file. All use of reference of tha has been
1837 changed to now use the variable GDCM_UNFOUND.
1839 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1841 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1842 Dicom dictionary. The test suite can now be run again. Note:
1843 I'm note very happy with the " (RET)" changes. I believe this
1844 RETAINED comment should be dropped when parsing the dictionary.
1845 - PACKAGER corrected
1847 - AUTHORS updated and now in alphabetical order
1848 * Makefile.am now exports gdcm.dsw for Windoze users.
1850 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1851 * cygwin complains about missing std:: in subdir Test/
1853 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1854 * remove some methods that are now in gdcmHeaderHelper
1856 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1857 * vtkGdcmReader set spacing and origin correctly
1859 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1860 * Fix a few delete/delete[] mismatch
1862 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1863 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1864 interpretation to data given by gdcmHeader. For instance there are
1865 heuristics to get informations (look at different places).
1866 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1867 sorting DICOM images based on different strategies.
1868 * modified Makefiles accordingly.
1870 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1872 when building in debug mode
1873 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1874 src/win32/gdcmdll.dsp
1875 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1877 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1878 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1881 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1882 * src/win32/libgdcmjpeg12.dsp was not dos format
1883 * src/win32/libgdcmjpeg12.dsp :
1884 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1885 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1887 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1888 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1890 * src/gdcmFile.cxx : bug fix in affectation type
1891 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1892 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1893 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1894 symbols... future problem ?
1896 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1897 * src/win32/libgdcmijpeg12.dsp was missing
1898 * modified gdcm.dsw accordingly
1900 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1901 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1903 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1904 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1905 commit of JPR (before his hollidays to facilitate our work).
1906 * setup.py : bug fix in code. Modifications made while the last commit
1907 of JPR. The code hasn't been tested before the commit... it's so
1908 useless to make that (for best programmer that is JPR) !!!
1910 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1911 * tagged the current version as Version0_3 (i.e. version 0.3)
1913 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1914 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1915 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1916 * *.dsp : modifications to use new libgdcmijpeg8 library
1917 * setup.py : bug fix on VTKPATH variable
1918 * PACKAGER : adding all concerning windows
1920 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1923 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1924 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1925 test suite reported error.
1926 * PACKAGER file added (describes what a packager must do when
1927 packaging a new release).
1928 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1929 * configure.in: upgraded version number to 0.3.0
1930 * fixing build of rpm (through rpm -ta):
1931 - Doc/Makefile.am exports proper doxygen files
1932 - src/jpeg/libijg8/Makefile.am exports the include files.
1934 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1935 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1936 * src/gdcmHeader.h : formatting code
1938 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1939 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1940 We were obtaining error message from vtk. Now, creation of file list
1941 is made in an internal list to prevent this problem.
1942 Bug fix when output is empty.
1943 Bug fix in update of progress value. Previous commit for this was a bad
1945 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1947 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1948 * src/gdcmHeader.h : added method to get the file name
1949 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1950 files. Added method to remove all files on the input
1951 Added FIXME comment concerning the bad parsing of header made by
1952 ExecuteInformation method (in ExecuteData method)
1954 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1956 when using make instal.
1957 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1958 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1960 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1961 * setup.py : adding include dir of jpeg lib to compile all sources
1962 * */Win32/*.dsp : JPR fix for windows compilation
1964 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1965 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1967 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1968 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1970 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * setup.py is again effective on un*x (takes into account the
1972 addon of the jpeg library)
1973 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1974 * Doc/Doxy* updated (includes above enhancements)
1975 * INSTALL now points to web documentation
1977 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * src/gdcmHeader.h doesn't make unnecessary reference to
1980 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1982 * src/gdcm*.[cxx|h] :
1983 - to allow compilation with gcc 3.x
1984 -- clean up of STL usage (added explicit usage of std::)
1985 -- small fixes on exceptions.
1986 Note: linking not tested !
1987 - clean of doxygen comments to avoid warnings at documentation
1989 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1990 dependent convertion).
1992 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1993 * Clean up of previous JPR garbage commit (not even commented in the
1995 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1996 - moved all jpeg related files from src to src/jpeg/libijg8, with
1997 addition/modification of Makefile.am and configure.in.
1998 - the testSuite is still brain damage (not guilty).
2000 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2001 * WrapVTK.py : modifications to get correctly vtk source files to
2003 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2004 (FileName -> Filename)
2006 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2007 * vtk/vtkGdcmReader.[cxx/h]:
2008 - UpdateProgress method should now be effective
2009 - removed the limitation on having only images loaded (as opposed
2011 - when building a stack of images/volume, a lesser number of
2012 gdcmHeader and gdcmFile instances should be used (hopefully
2013 accelerating things).
2014 - when building a stack of images/volumes, files which are not
2015 loadable (wrong path-filename, wrong permissions on existing file,
2016 or file not parsable by gdcm) are replaced with a black image
2017 in the stack (for the caller to notice the problem).
2019 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2020 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2022 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2023 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2024 between standard library (std) and vtk library (problems are found
2025 under Windows... thanks Windows !)
2027 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2028 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2030 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2032 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2033 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2035 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * When compiling with distutils (see setup.py) the C++ compiler is
2037 called with different flags than the default ones (with automake).
2038 In order to fix all those warning, I compiled gdcm with the command
2039 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2040 and went for warning fixes:
2041 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2042 up from unused variables.
2043 - vtk/vtkGdcmReader.cxx: potential bug fix.
2044 * src/gdcmHeader.h: Doxygen warning cleanup
2046 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2047 * gdcmPython/gdcm.i:
2048 - typemaps correction to take into account the systematic replacement
2049 of "using namespace std" with std:: prefix e.g. std::list,
2050 std::string... (cf changes of 2003-05-21).
2051 - gdcmGlob global variable of type gdcmGlobal (defined in
2052 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2053 exported to Python a as cvar.
2054 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2055 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2056 gdcmDictSet.GetPubDictTagNames() and
2057 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2058 C++ static methods).
2059 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2060 with the above changes.
2062 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2063 * setup.py, manifest.in : bug fix under linux
2065 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2066 * Modification of setup.py to compile vtk part too. Then, we have 2
2067 wrappers which must work with same distutils. For that, we have a
2068 generic distutils in distusiltsWrapping.py ; with :
2069 - build_extWrap class to wrap generically all extensions,
2070 - ExtensionWrap base class for all wrapping extension that contains
2072 - Wrapper interface which wrap sources
2073 + In WrapSwig.py we have extension and wrapper for Swig
2074 + In WrapVTK.py we have extension and wrapper for VTK
2075 * MANIFEST.in : modifications to consider vtk directory and new python
2076 files for compilation
2078 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2079 * Added python wrappers of vtkGdcmReader vtk class (see the
2080 source in vtk/vtkGdcmReader.cxx) :
2081 - vtk/Makefile.am now builds a library
2082 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2083 python library (as opposed to _gdcm.so wich are the python
2084 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2085 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2087 - configure.in has an additional flag --enable-vtk that needs
2088 to be set to enable compilation of vtk related code, that is:
2089 + vtk/vtkGdcmReader.so and
2090 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2091 + gdcmPython/vtkgdcmPython.so (see above)
2092 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2093 be read when compressed or when HighBit + 1 != BitsStored),
2094 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2095 the usage of the python wrapper of vtkGdcmReader vtk class.
2096 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2097 * src/*.[h] all occurences of stl classes are now prefixed with
2098 std::, and all occurences of "using namespace std;" where removed.
2099 This is to avoid pollution of global namespace in included files.
2100 Apparently vtk does not avoid this pitfall: when using both
2101 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2102 collision of various stl members (principally cout...).
2103 * gdcmPython/testSuite.py now cleanly removes temprory generated
2105 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2106 comply with above changes)
2108 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2109 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2110 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2111 vtk data structure (an image Flip was required).
2112 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2113 * cosmetic changes in documentation.
2115 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2116 * src/gdcmHeader.cxx: the constructor no longer exits when an
2117 unexisting file is given as argument.
2118 * The subdirectory Data (containing all the images used for the
2119 test suite) is not part of this repository anymore. A new module
2120 containing those images is now available at
2121 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2122 with the name gdcmData.
2123 All the python scripts (including the package initialisation file
2124 gdcmPython/__init__.py) were adapated to take this change into
2125 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2127 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2128 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2129 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2130 demo of the usage of this class.
2131 Compilation of this vtk part is only done when using the --enable-vtk
2132 at configure (or autogen.sh) stage.
2134 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2135 * More memory link related corrections and documentation fixes.
2137 - maximum info is obtained with a command of the form:
2138 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2139 --show-reachable=yes PrintHeader
2140 - the remaining reachable blocks seem to come from the STL
2141 allocation scheme through the usage of map and list. It looks
2142 like this memory cannot be freed but it is not a memory leak
2143 (in fact further invocation to the STL would recollect the
2144 unused memory allthough it cannot explicitely be freed).
2145 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2146 of displaying an image parsed with gdcm and displayed with VTK.
2147 Note: some images don't seem to work e.g.
2148 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2149 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2150 Allthough this weakens the semantics, it is a ditch attempt to
2151 make gdcm more thread friendly.
2153 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2154 * Memory link hunt (by using valgrind through the command
2155 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2156 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2157 gdcmHeader::_dicom_vr.
2158 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2159 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2161 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2163 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2164 * src/Makefile.am now exports all the necessary include files at
2168 * UpdateGroupLength replaced by new one
2171 * UpdateGroupLength re-written using H-Table
2172 (named UpdateGroupLengthNew untill checks are over)
2174 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2175 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2176 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2178 - gdcmHeader::GetPubElValSet removed.
2179 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2180 UpdateGroupLength, WriteElements, Write.
2181 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2182 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2183 carried the same semantics.
2184 - src/gdcmHeaderIdo.cxx changed accordingly.
2185 - gdcmFile::WriteBase now regroups all the codes from previous
2186 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2187 - enum FileType moved to gdcmCommon.h
2188 * src/gdcmHeader.cxx AddDefault trashed
2189 * gdcmGetXSize added
2190 * getimageDataSize now calls gdcmGetXSize
2191 * Test/*.cxx changed to agree with above changes
2193 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2194 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2195 (to avoid double call by end user).
2196 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2197 by end user, since gdcmHeader::gdcmHeader now handles it.
2199 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2200 * gdcm/Doc many doxygen changes:
2201 - Doxyfile now has two different versions, DoxyfileUsers that generates
2202 the html.users end users oriented documentation and
2203 DoxyfileDeveloppers that generates the html.developper developper
2204 oriented documentation.
2205 - README changed accordingly
2206 - requirement.txt removed (old design info moved to TODO).
2207 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2208 DoxyMainPage.txt, DoxyPython.txt provide more information.
2209 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2210 be updated by simply regenerating the docs with doxygen and copying
2211 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2212 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2213 all the tests in the form "if (<map>.count() >1)" were removed.
2214 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2215 ill-formed documentation sections.
2216 * src/gdcmHeader.cxx: ditto
2218 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * setup.py fixed for un*x (needed macro for stdint.h)
2220 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2221 un*ces with sh-utils test utility.
2222 * gdcmPython/demo/test.py renamed to PrintHeader.py
2223 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2224 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2225 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2226 * src/gdcm*.cxx JPR's bad inclusion fixed.
2228 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2229 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2230 * gdcmPython/demo/test.py changed accordingly.
2232 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * gdcmPython/Makefile.am fixed linking against libstdc++
2234 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2235 * Swig subdir (historical tests of swig version 1.3.17++) removed
2236 * Test/testChangeEntete.cxx some lines commented out in order to make
2238 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2239 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2241 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2242 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2243 hence the user doesn't need this explicit call.
2244 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2245 i.e. LoadElements() call removed.
2246 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2247 - src/Makefile.am declares the proper flag for g++.
2248 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2249 for adding user defined new tags.
2250 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2251 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2252 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2254 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2255 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2256 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2257 src/Makefile.am : the project should properly compile and install
2258 with the autotools, included the python wrappers part.
2259 * gdcm.spec.in : added a spec file for RPM packaging.
2261 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2262 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2264 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2265 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2266 to exported to the environement (see gdcmPython/testSuite.py
2268 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2269 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2270 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2271 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2272 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2274 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2275 * gdcmPython/__init__.py doesn't crash anymore when running in
2276 in InstallMode or PreInstallMode but with an environement given
2277 value of GDCM_DICT_PATH.
2278 * src/gdcmDictSet.[cxx/h] coding style.
2280 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2281 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2282 * src/gdcm.h general comments moved to TODO, and README
2283 * src/gdcm.h should now be seen as a user commodity (including it
2284 should suffice to fully use gdcm). It is nowhere including within
2285 any of the kernel files src/*.cxx and src/*.h.
2287 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2288 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2289 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2291 * src/gdcm*.cxx only include their corresponding include file
2292 (as opposed to gdcm.h)
2293 * gdcmPython/gdcm.i changed accordingly
2294 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2295 the autogen.sh generated "make snapshot" command to work.
2296 * autogen.sh removed history related references to crea package.
2298 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2299 * distutilsSwigCPlusPlus.py work around some swig portability
2302 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2304 was done in a last ditch attempt to get setup.py _really_
2305 operationnal. The python/gdcmPython layaout add the advantage
2306 of hidding away the python related distutils specific files
2307 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2308 Alas, the src directory was out of scope (i.e. it's relative
2309 position to setup.py was ../src) which made things impossible to
2310 handle (see previous version of python/setup.py). Crossing fingers...
2312 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * python/setup.py now works on Un*x. (harder than I thougth)
2314 * python/distutilsSwigCPlusPlus.py can now have include files
2315 among the list of sources.
2317 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2318 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2319 * modifications in MSVC projects
2321 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * As stated by the first lines of Test/ExceptionAndPython/README, it
2323 looks like we can move back to original usage of exception within
2324 src/gdcm* and hence remove the errno stuff that was introduced
2325 as a quick and dirty fixture of this problem (added to the TODO).
2326 * Doc/Doxyfile configuration file for Doxygen and corresponding
2327 README file for usage added.
2328 * Test/testWrite.cxx added. This new test comes from a split of
2329 test.cxx that is now reverted to its original purpous i.e.
2330 testing the proper parsing of a Dicom related file.
2331 testWrite.cxx concentrates on testing the IO part of gdcm.
2332 * Test/bug1.cxx (containing a bug on WIn32) added.
2333 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2334 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2335 whose purpose is to publish the content of the TagNames of the
2336 Dicom public dictionnary were not accessible without an
2337 instance of class gdcmHeader.
2338 - those methods are now static methods of gdcmDictSet and hence
2339 require no instances at all to be invocated.
2340 - within gdcmDictSet this change required to change some method
2341 to class methods (i.e. are now static) among which SetDictPath
2342 (renamed to BuildDictPath) and LoadDefaultPubDict.
2343 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2344 the above changes by calling the new method classes of gdcmDictSet.
2345 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2346 the above to be effective.
2347 * python/gdcmPython: in order to wrap properly the above changes
2348 for Python, swig version now needs to be > 1.3.17.
2349 * python/gdcmPython/Makefile fixed to adapt itself to new
2350 configure/make shema introduced by Johan Montagnat (thanks for the
2351 contribution). Alas this Makefile cannot be turned into a proper
2352 Makefile.am without some heavy changes in the configure.in
2353 (for python dectection).
2354 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2355 now avoids publishing the empty entries.
2357 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2358 * python/setup.py : bug fix concerning install under windows
2359 ExtraPath reused :-P
2360 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2362 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2363 * Dicts/dicomV3.dic : remove double spaces !!!
2364 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2365 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2368 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2369 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2370 method. Doxygenation.
2371 * src/gdcm.h clean up of JPR spurious comments.
2373 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2374 * python/distutilsSwigCPlusPlus.py now properly collects the
2375 shadow classes generated by "swig -c++" (gdcm.py in our case)
2376 when using "python setup.py install".
2377 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2378 reexports the working classes.
2379 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2380 by the classical C errno scheme. This is to prevent an obscure
2381 behavior of the python wrappers when importing wxPython.wx prior
2382 to gdcmPython (which ended up in an abort call). An illustration
2383 of this oddity can be found in the Test/ExceptionAndPython
2384 subdir (see the README file). This problem probably due to
2385 an combination of g++ and dynamic loading.
2386 * added Test/ExceptionAndPython (see above)
2388 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2389 * Changed the layout of the python part to avoid bloating main
2390 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2391 i.e. the distutils arsenal. All the python related stuff is
2392 again in a python subdir, but the package itself is now in
2394 * setup.py was cleaned up:
2395 - pythonIncludePath removed
2396 - python setup.py bdist target is now functional.
2397 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2398 collision with other packages). gdcmPython/demo/*.py changed
2401 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2402 * python subdir moved to gdcmPython (preparation of distutils packaging).
2403 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2404 distutils installer is operational.
2405 * - gdcmPython/__init__.py now properly loads the swig generated
2406 shadow classes (from gdcm.py).
2407 - gdcmPython/demo/*.py changed to import the package gdcmPython
2408 instead of gdcmPython/demo/load.py.
2409 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2411 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2412 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2413 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2414 entries within the associated public Dicom dictionary resp. the same
2415 information but sorted by the fourth field (PAT, IMG, DIR) of the
2417 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2418 are now in the "???" group.
2419 - python/gdcm.i changed accordingly,
2420 - python/demo/printGroupedPublicDict.py added, that gives an example
2421 of the above new functionalities in Python.
2423 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2424 * src/gdcm.h, gdcmHeader.cxx:
2425 - historic references to glib's g_malloc and g_free (#defined)
2426 were definitively removed.
2427 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2428 * src/gdcmElValSet.cxx:
2429 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2430 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2431 - GetElValue(string) renamed to GetElValueByName.
2432 - Added GetElementByName(string).
2433 * src/gdcmHeader.cxx: added
2434 - GetPubElValRepByNumber(guint16, guint16)
2435 - GetPubElValRepByName(string)
2436 - GetShaElValRepByNumber(guint16, guint16)
2437 - GetShaElValRepByName(string)
2438 - GetShaElValByNumber(guint16, guint16)
2439 - GetShaElValRepByName(string)
2440 - GetElValRepByNumber(guint16, guint16)
2441 - GetElValRepByName(string)
2442 - GetElValByNumber(guint16, guint16)
2443 - GetElValRepByName(string)
2444 * Doc/requirements.txt added.
2446 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * Test/Makefile building now depends on the one of libgdcm.so
2448 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2449 pixel data) aware which enables finding the address (offset) of
2450 the pixel data of JPEG encoded DICOM files. This leaves only a single
2451 file in the testSuite whose pixel data address (offset) is unknown.
2452 * python/testSuite.py changed accordingly.
2454 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2455 * VC++ has some strong limitations when working with the STL, as stated
2456 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2457 "Also note that some STL containers (map, set, queue, list, deque)
2458 cannot be exported. [...]
2459 Some STL classes contain nested classes. These classes can not
2461 This is caused by a designed limitation that once a template
2462 class is instantiated, it can not be re-instantiated and
2464 Since our usage of map<> is ubiquitous in gdcm, this "designed
2465 limitation" of VC++ is a pitfall.
2466 Hence the Python wrappers of gdcm cannot be incrementally linked
2467 against the c++ dynamic library. The dirty but only workaround is
2468 to forget about incremental link of dynamic libraries and to generate
2469 the Python wrappers library with the inclusions of the underlying C++
2471 The following modifications concern this matter on Win32/VC++:
2472 - wrapping python correct with standalone wrapped dll (don't use separate
2473 dll under windows !!!!)
2474 - python21_d debug mode enabled (ask Frog how to use it :-)
2475 - NO problem with having an STL member of class for example string in C++
2476 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2477 - Python test of dcmlib in Python is ok under windows on a large set
2479 * removed glib references
2480 * typedef's inserted in gdcm.i for correct swig type management
2482 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2483 * python/demo/*.py load.py extracted from test.py. Added explore.py
2484 that only displays required tags and testAll.py that parses all
2485 the files of the testsuite without using unittest.
2486 * python/testSuite.py other additional test on new files added.
2487 * Data/* new test files added accordingly to the testSuite.
2488 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2489 the vr in the file differs from the one of the dictionary.
2491 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2493 values, but limits itself to values which are below a user specified
2494 size (by default 1024 bytes).
2495 * python/gdcm.i : elements not loaded (because their size is above the
2496 user specified treshold) are exported with their TagKey as key of the
2497 python dictionary. This enables the testsuite to make some checks
2498 on the unloaded elements (since we have their offset and size).
2499 * python/testSuite.py
2500 - now tests for the existence and proper value of the pixel data
2501 - two new examples added.
2502 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2504 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2505 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2506 aware. See the strategy comments in gdcmHeader::FindeLength().
2507 * Test/test.cxx now accepts a filename as first argument.
2508 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2509 * python/testSuite.py changed to integrate test on above files.
2511 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2512 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2513 the vr was also RET.
2514 * python/testSuite.py more tests added.
2516 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * python/testSuite.py unittest test suite added (uses Data)
2518 * Data/* dcm and acr files for the test suite.
2519 * glib dependance removed from un*x version. We now use ISO C99
2520 7.18 Integer types (see stdint.h)
2521 - python/Makefile, src/Makefile src/gdcm.h
2522 * src/ when an explicit vr (like dicom files) suddenly poped an
2523 implicit element we use to mark the underlying DictEntry of the
2524 concerned ElValue with "Implicit". This strategy was damageable
2525 too the public or provite dictionaries, since some of their vr
2526 would be changed. Since Header::FindLength heavily relies on the
2527 detection by Header::FindVR of falsely explicit elements, I
2528 added an extra ImplicitVr member to ElValue (boolean).
2529 The rest of the changes we the necessary adaptations.
2531 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2534 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2536 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * Adaptation for porting to VC++:
2539 o forced to use std namespace (for string to be known)
2540 o all class use __declspec export style on WIN32
2541 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2542 (in stdlib.h on Win32 but in std:: for gcc)
2543 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2544 variable GDCM_DICT_PATH.
2545 * src/gdcmHeader.cxx verbose comments made discrete.
2547 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * python/gdcm.i: added a typemap that converts a C++ hashing table
2549 to native Python dictionary.
2550 * python/demo/test.py:
2551 - now uses the native dictionary for exploration of gdcmHeader.
2552 - takes an optional filename argument (the file to parse).
2553 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2554 PubElVals hashing table.
2555 * Dicts/dicomV3.dic removed error prone trailing spaces.
2557 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2558 * Python wrapping process moved away from src/Makefile to
2559 newly created python/Makefile (as well as gdcm.i)
2560 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2561 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2562 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2563 from the environement variable GDCM_DICT_PATH (when existing).
2564 * src/gdcmDict::GetTag bug fix.
2566 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * Straightforward temporary fixes for swig to build the python wrappers.
2568 src/Makefile now has a python working entry [by working we mean
2569 that we can import de shadow classes without errors].
2571 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2572 * hashtest.cxx removed (since allready in Test)
2573 * src/gdcmlib.h renamed to src/gdcm.h
2574 * src/dcm.i renamed to src/gdcm.i
2575 * src/Makefile prepared for python wrapping
2577 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2578 * src/gdcmHeader.cxx :
2579 - Parsing of header is now separated from loading of element values
2580 (see gdcmHeader::LoadElements).
2581 - general clean up of hopefully all file access (creation of
2582 ReadInt16 and ReadInt32)
2584 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2585 * src/gdcmHeader.cxx :
2586 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2588 - SetLgrElem renamed to SetLength
2589 - GetLgrElem renamed to GetLength
2590 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2591 * src/gdcmElValSet.cxx fixed both GetElValue methods
2592 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2593 due to IdoDude was cleaned out.
2595 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2597 concentrates on finding the value representation (when it exists).
2598 RecupLgr now only finds the element value length, and it avoids
2599 returning the unecessary skL (skipped length).
2600 Also, offsetCourant was simply removed (with taille_fich) since
2601 it was redundant with the File position internals (by using
2602 ftell and fseek). This also made skL (see above in RecupLgr) usage
2604 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2605 on the libido specificities which are handled through class
2607 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2610 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * Truckload of changes. Parsing of header is barely functional
2612 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2614 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * src/gdcmHeader.cxx many addons of low level methods
2617 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2618 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2619 and _IdDcmSWAP_LONG.
2621 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2622 * This corresponds to all the changes decided at the meeting of
2623 May 23 2002. Needless to say we are running late...