1 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
3 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
4 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
5 - src/CMakeLists.txt: alphabetic order reodering + new entries.
7 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
8 * Added documentation of vtkgdcmReader on Website:
9 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
10 with it's binary name).
11 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
12 the Website to be more complete.
13 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
14 doxygenated documentation.
15 - Doc/DoxyVtkGdcmReaderExamples.txt added
16 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
17 DoxyVtkGdmReaderExamples.html )
18 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
19 * CLEANUP_ROUND (3) for gdcmPixelConvert
20 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
22 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
23 * CLEANUP_ROUND (2) for gdcmPixelConvert
24 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
26 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
27 * CLEANUP_ROUND for gdcmPixelConvert:
28 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
29 - src/gdcmPixelStuff[h|cxx] removed
30 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
31 - src/CMakeLists.txt changed accordingly
33 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
34 gdcmVersion.py moved to newly created ATTIC related
35 gdcmPython/SetupOldies/ directory.
37 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
38 - autogen.sh configure.in acinclude.m4 python.m4 removed
40 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
41 * src/*.cxx *.h Reference to License.htm fixed to License.html.
42 * Doc/CMakeLists.txt, doxygen.config.in: fix.
43 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
45 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
46 * TODO updated with Mathieu suggestions. I proposed a template for
47 describing TODO entries and used it for new entries.
48 * Added Doc/Website/CodingStyle.html, Developpers.html,
49 DeveloppersPython.html, GdcmDataCvs.html and
50 DownloadVersion0_1.html, DownloadVersion0_3.html.
51 * Some Doc/*.txt Doxygen files (which do not really concern the
52 documentation itself, but the website) moved to html and
53 placed in directory Doc/Website:
54 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
55 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
56 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
57 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
58 * CMakeLists.txt changed accordingly.
59 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
60 DeveloppersPython.html
61 * INSTALL nows refers to Doc/Website/Installation.html
63 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
64 * Added Doc/Website directory, that contains a first raw version
67 2004-09-23 Jean-Pierre Roux
68 * FIX In order not to be poluted any longer by casting problems,
69 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
70 we can now delete[] it safely
71 * VoidArea is now called BinArea (less confusing name),
72 and all the methods called ...VoidArea... are now ... BinArea...
73 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
75 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
77 clear) TagHT, which is an inherited member of gdcmElementSet. It is
78 up to the destructor of gdcmElementSet to clean up TagHt and it's
81 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
82 * Test/CMakeLists.txt: update to follow gdcmData renamings.
83 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
85 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
86 * ENH: added some utility method that builds a flat dictionnary
87 holding all the Dicom entries contained in the recursive structure
88 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
90 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
91 BuildFlatHashTable() that build a flat dictionary.
92 - src/gdcmElementSet.h: added a new private GetTag() accessor.
93 gdcmDocument is now a friend of gdcmElementSet.
94 - src/gdcmElementSet.cxx: clean up.
95 - Example/FlatHashTablePrint.cxx added.
96 - Example/CmakeLists.txt changed accordingly
98 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
99 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
100 moved away from gdcmDocEntrySet (since this class is an abstract class
101 acting like an interface). SQDepthLevel and BaseTagKey are now
103 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
104 and associated accessors. Doxygenation of the class.
105 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
107 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
108 Use SQDepthLevel accessor instead. ::Print() adapted.
109 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
110 - src/gdcmDocument.cxx changed accordingly.
112 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
113 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
114 - The following is the doxygen comment of the typedef declaration
115 of gdcmagKey in src/gdcmCommon.h:
116 gdcmTagKey is made to old an "universal" (as in URL, Universal
117 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
118 A dicom tag allways has a group and an element, but a set of tags
119 embeded in various (optionally nested) sequences and sharing
120 the same group and element all share the same (group, element)
121 "identifier". Hence the (group, element) cannot be used as an
122 identifier (in gdcm we shall refer to a "TagKey") of a tag.
123 In order to construct a proper tag identifier (i.e. a key) we
124 consider the following definition of a TagKey:
125 - let Group, Element be the string representation of the
126 group and element dicom tag members,
127 - let ItemNumber be the string representation of the integer
128 index of the considered item number of a sequence,
129 Let the key of a tag embeded in a sequence, noted SeqTag, be
131 /ItemNumber#Group|Element
132 where "/", "#" and "|" are characters acting as separators.
133 Then the general form of a gdcmTagKey is given by:
134 Group|Element<SeqTag>
135 where <SeqTag> means NO or many instances of SeqTag.
136 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
139 but the gdcmTagKey of a tag "embeded" is the first item of
140 a sequence, itself nested in the third item of a sequence is the
142 0004|1220/2#0008|0082/0#0008|0090
143 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
144 order to hold the new sequence compatible key. Previously, the
145 GetKey() method would look in the underlying gdcmDictEntry.
146 - src/gdcmDocEntry.cxx:
147 -- constructor now copies the underlying DictEntry key, in the local
149 -- ::Print: displays the member Key, instead of the (group, element).
150 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
151 - src/gdcmDocEntrySet.h:xi
152 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
153 -- now has a new BaseTagKey member.
155 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
156 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
158 This poses the problem with the semantics of the following lines
159 LoadEntryVoidArea(0x0028,0x1201); // R LUT
160 LoadEntryVoidArea(0x0028,0x1202); // G LUT
161 LoadEntryVoidArea(0x0028,0x1203); // B LUT
162 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
163 to the long FIXME note for what the problem is. Nevertheless in
164 order to get things working the dicom dictionary was altered !
165 Please fix things urgently...
166 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
167 information), see above note on moving the member VoidArea. Nevertheless
168 the following entries previously correctly set as US are now inproperly
170 0028 1201 OW IMG Red Palette Color Lookup Table Data
171 0028 1202 OW IMG Green Palette Color Lookup Table Data
172 0028 1203 OW IMG Blue Palette Color Lookup Table Data
173 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
174 of gdcmDocEntry moved to gdcmSeqEntry.
175 * src/gdcmSeqEntry.cxx: STYLE.
177 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
178 * Test/TestAllEntryVerify.cxx minor fix and added comments.
180 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
181 * gdcmPython/testSuite.py: all the test suite in python is now moved
182 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
183 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
184 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
186 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
188 to avoid inclusion recursion until STL is reached.
189 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
190 mecanism. errno.h is not included in gdcm anymore.
191 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
192 (gdcmFormatError now inherits from gdcmFormatUnexpected).
194 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
195 gdcmData/TestAllEntryVerifyReference.txt
196 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
197 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
198 exception_on_error parameter.
199 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
200 - vtk/vtkGdcmReader.cxx changed accordingly,
201 - Example/*.cxx and Test/*.cxx changed accordingly.
203 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
204 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
205 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
206 enable_sequences removed from gdcmHeader constructor and dependencies.
207 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
208 * gdcmPython/demo/PrintHeader.py: dummy fix.
209 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
210 skip_shadow removed from gdcmHeader constructor and dependencies.
211 * Example/*.cxx and Test/*.cxx changed accordingly.
213 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
215 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
217 2004-07-21 Jean-Pierre Roux
218 * FIX Now, Parsing and Printing a DICOMDIR do work!
219 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
221 2004-07-20 Jean-Pierre Roux
222 * FIX Some brain damaged headers have Zero-Lenght fields
223 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
225 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
227 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
228 variable (instance of gdcmDebug) by a definition macro, and the instance
229 is now in static in the gdcmDebug class
230 * src/gdcmSQItem.h : (FIXME) remove an undefined method
231 * Test/PrintAllDocument.cxx : bug fix in the result of the test
233 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
234 * WARNING: ctest now depends more tightly on gdcmData. You should
235 check out gdcmData properly for things to run smoothly...
236 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
237 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
238 we need the pixels not be loaded in order to use the ValEntry
239 that displays position and size).
240 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
241 This is a C++ based equivalent of gdcmPython/testSuite.py that should
242 be deprecated. If you have any doubts about the advantages of a
243 modern scripting language (read Python) versus grass root C++ (i.e.
244 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
245 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
246 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
247 Anyhow, consider documenting the gdcmData images in
248 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
250 * Test/CMakeLists.txt:
251 - now uses TestAllEntryVerify.cxx
252 - specific comments on oldACR00001.ima (now renamed in gdcmData
253 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
254 gdcmData/TestAllEntryVerifyReference.txt
257 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
258 * src/*.[h|cxx] : typedef clean up
259 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
260 - TagKey renamed to gdcmTagKey (for external usage)
261 - VRKey renamed to gdcmVRKey (for external usage)
262 - removal of typedef duplication.
263 - Removed all unecessary inline keyword from class inline definitions.
264 - Some method|function(void) declarations replaced with method|function().
265 * src/jpeg/libijg12/jdhuff12.c:
266 - printf polluting ctest removed.
267 - TAB removal for comminting
269 - TestAllReadCompareDicom.cxx: added a test that compares all the
270 images in gdcmDataImages.h with corresponding images in
271 gdcmData/BaselineDicom/. When baseline images are not present
272 this test creates them.
273 Note: we need to validate each reference image, but before that
274 I'd like to rename them with a more explicit name...
275 - CMakeLists.txt: changed accordingly.
276 * Example/*.cxx: examples now only include gdcm.h (as opposed to
277 including each header needed).
279 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
280 * Test/*.cxx and Example/*.cxx: moved some examples away from the
281 test suite to the Example directory. Are concerned:
286 - TestWriteSimple.cxx
287 * Test/CMakeLists.txt: added some comments on reasons for black listing
288 image gdcmData/oldACR00001.ima
290 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * Test/CmakeList.txt: removed the following from black list (to be coherent
292 with removal from gdcmData):
293 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
294 - gdcm-MR-PHILIPS-16.dcm
296 Added the following because after last cvs update, they cause
297 ctest -R TestReadWriteReadCompare
299 - gdcm-MR-SIEMENS-16-1.acr
301 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
302 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
303 new comments in this file) we temporarily (sigh) move to a weaker
305 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
306 we don't need to black list the following images anymore:
307 - 8BitsUncompressedColor.dcm
309 - US-PAL-8-10x-echo.dcm
310 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
311 fixes and the beautified code ;-)
312 This fixes the bug introduced in version 1.42 (when beautifying)
313 that made the parsing of 8BitsRunLengthColor.dcm unproper.
314 Note: ctest was blind to this bug (this means we need to still
315 improve the test suite). The bug could be detected by using
316 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
318 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
319 and by displaying the (garbage) produced file temp.XDCM...
321 2004-06-29 Jean-Pierre Roux
322 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
323 - replace by uggly but working old code :-(
324 A lot of things should be OK again.
325 It's really urgent to have a test suite that *tests*,
326 to prevent Frog's beautifying sessions to break all the stuff
327 (twice, withing a fortnigh ...)
329 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
330 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
331 redundancy) to added Test/TestReadWriteReadCompare.cxx
332 * Test/CmakeList.txt: because the compare test of
333 Test/TestReadWriteReadCompare.cxx fails, the following images are
334 black listed: - 8BitsUncompressedColor.dcm
336 - US-PAL-8-10x-echo.dcm
337 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
338 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
339 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
340 and ad-hoc kludge. This kludge is now removed, and on encountering
341 such an image (OB field brain damaged) we set errno. Then in
342 ::FindDocLength() we "fix" the length as being ALL what remains
343 in the file (until EOF). We then proceed, hoping for the best...
344 This fixes a SegFault in ShowDicom when trying to write such an
346 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
347 (because TestWriteRead breaks on it, after a non conformal commit?).
348 ctest now runs properly, except for MakeDicomDir (which was allways
349 broken) and the Python related stuff (still not fixed).
351 2004-06-24 Jean-Pierre Roux
352 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
353 FIX : Test/TestReadWrite now iterates on all the file names
354 (instead of infinite loop)
355 ENH : Test/TestWriteRead now iterates on all the file names
357 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
358 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
360 2004-06-24 Jean-Pierre Roux
361 FIX : - now Write drops LUT Descriptors and LUTs (if any)
362 when SamplesPerPixel =3
363 - now Write is no longer confused by
364 'BitsAllocated = 12" and 'BitsStored=12"
365 - "UN" value representation Elements are now written correctly
366 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
367 ENH : - now gdcmHeader has its own Write methods
368 (in order to split the job that has not to be done
371 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
372 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
373 loop on the same image until memory went out.
374 Note: this means we still have gobs of memory loss in PrintDocument
375 * src/gdcmDocument.cxx: fixes problem on parsing on file
376 gdcmData/16BitsJpegLosslessGrayScale.dcm.
378 2004-06-24 Jean-Pierre Roux
379 FIX : Write - All the Sequences and Sequence Item are now written
380 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
381 is added a the end, when necessary.
382 - A lot of brain-damaged images, that were read correctly are
383 now written correctly
384 - length compatible BinEntry are now loaded correctly
385 (even for odd groups)
386 Note : only Explicit Value Representation was checked.
387 (question : is implicit VR really necessary for gdcm ?)
389 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
390 * DEVELOPPER: added a proposition of coding style.
391 * src/gdcmDocEntry.h: removed every inline declaration (for test of
394 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
395 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
396 Use the gdcmDocEntry::Print() and Write() instead.
397 * src/gdcmDocument.cxx: bug fix.
399 2004-06-22 Jean-Pierre Roux
400 FIX : gdcmDocument.cxx
401 - Now we do recognize the JpegLossLess format (there was a misstyping in
402 code 'beautyfication' :-(
403 - Now we automaticaticaly load the Luts, if any
405 2004-06-22 Jean-Pierre Roux
406 In order : to write Sequences, whatever their imbrication level,
407 : to allow user to create his own Sequences
408 a lot of modif where necessary (adding, moving, or virtualising methods)
410 WARNING : save your own sources *before* cvs up !
413 ADD virtual void Write(FILE *fp, FileType filetype);
416 ADD virtual void Write(FILE *fp, FileType filetype);
417 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
420 ADD virtual void Write (FILE *fp, FileType filetype)=0;
421 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
422 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
423 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
424 ADD std::string GetEntryByName(TagName name);
425 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
427 std::string vr = "unkn",
428 std::string fourth = "unkn",
429 std::string name = "unkn");
430 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
431 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
432 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
433 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
434 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
435 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
436 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
437 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
440 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
441 ADD virtual std::string GetEntryByName (TagName tagName);
442 ADD virtual std::string GetEntryVRByName (TagName tagName);
443 REM virtual bool Write(FILE *, FileType);
444 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
445 FILE *_fp, FileType type);
446 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
447 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
448 REM virtual bool WriteEntries(FILE *_fp,FileType type);
449 REM virtual std::string GetEntryByName (std::string tagName);
450 REM virtual std::string GetEntryVRByName (std::string tagName);
451 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
452 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
453 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
455 std::string vr = "unkn",
456 std::string fourth = "unkn",
457 std::string name = "unkn");
458 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
459 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
460 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
461 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
464 ADD virtual void Write(FILE *fp, FileType filetype);
467 ADD virtual void Write(FILE *fp,FileType filetype);
470 ADD virtual void Write(FILE *fp, FileType filetype);
471 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
472 REM std::string GetEntryByNumber(guint16 group, guint16 element);
473 REM std::string GetEntryByName(TagName name);
476 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
478 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
479 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
480 The default constructor invoked by the line
481 gdcmHeader *f1 = new gdcmHeader( header );
482 was gdcmHeader::gdcmHeader(bool) instead of the expected
483 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
484 Hence the parsing wasn't executed... See also below.
485 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
486 as explicit constructor didn't do the trick to fix the above problem.
487 Could anyone explain why ?
488 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
489 properly calls gdcmValEntry::Print() (that was weed out from
490 code related to gdcmBinEntry).
492 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
493 * In order to fix memory leaks:
494 - Test/TestWriteSimple.cxx: added cleaning of free store through
496 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
497 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
498 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
499 (through the call to ::AddDicomDirMeta()) or the destructor
500 would crash when deleting uninitialized ::metaElems].
501 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
502 - src/gdcmDocument.cxx:
503 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
505 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
506 was causing memory leaks.
507 - src/gdcmSQItem.cxx:
508 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
509 cleanly handled with polymophism: sorry but my milage is low).
510 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
511 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
512 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
513 This avoids SegFaulting.
514 - src/gdcmSQItem.h: coding style.
516 - Test/TestWriteSimple still severely sucks. The output image content
517 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
518 damaged when displayed with vtkgdcmViewer.
519 - on memory leaks: TestWriteSimple leaks really less (see entry
520 of 2004-06-18 in Changelog file for the call to valgrind).
521 - on segfaults: ctest now passes all the tests but one (no more
523 * Erroneous leading white fix:
524 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
525 white[s] (as opposed to from >> xxx, that removes it [them].
526 - src/gdcmTS.cxx: ditto.
527 - gdcmPython/testSuite.py: dirty related kludge removed.
528 * src/*: remaining references to gdcmParser removed.
529 * src/*[cxx|h]: added copy[way]left header.
532 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
533 * In order to fix writing of dicom files:
534 - Test/TestWriteSimple.cxx: a simpler example of writing.
535 - Test/CMakeLists.txt changed accordingly.
536 - src/gdcmDocument.cxx:
537 -- The destructor now recursilvely removes potential sequences.
538 -- Bug fix in ::IsJPEG2000()
539 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
540 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
542 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
543 to only declared) and build on top of
544 ::GetDocEntryByNumber(guint16, guint16).
545 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
546 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
547 for usage in destructor and treatement of promotion in
548 ::ReplaceOrCreateByNumber().
549 - src/gdcmSQItem.cxx: destructor should better handle his job.
550 Test/TestWriteSimple now runs (or at least it DOES something).
551 * We can now start hutting memory links. A good starting point is:
552 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
553 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
554 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
556 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
557 * Valgrind note: after Mathieu Malaterre teached me how to read
558 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
560 Using gcc, you can force the STL to use malloc and to free memory as
561 soon as possible by globally disabling memory caching.
562 With 3.2.2 and later, you should export the environment variable
563 GLIBCPP_FORCE_NEW before running your program.
564 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
565 simply vanish (it is still not clear to me, whether this means that
566 STL std::string leaks or if valgrind believes it leaks...).
567 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
568 running bin/gdcmTests makeDicomDir):
569 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
570 - Test/makeDicomDir.cxx now properly traps empty lists and returns
572 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
573 SegFaulting (I drowned in DicomDir related code when trying to
574 understand why the list is empty...).
575 * src/gdcmDocument.h: first BSD license header try.
576 * Doc/License.txt added.
578 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
579 * src/gdcmDocument.[h|cxx]:
580 - Clean up of the Transfer related predicates. They are now all based
581 on new method isGivenTransferSyntax, that (should) handle properly
583 - general clean up, simplification, and coding style.
584 - Specific clean up of Parse7FE0() (umproperly named actually).
585 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
587 2004-06-14 Jean-Pierre Roux
589 - fix the display of Sequence Delimitor (SQDepthLevel pb)
590 - fix the display of SQItem ordinal number
591 - add the GetSQItemByOrdinalNumber method
592 - remove some useless never written private methods
594 2004-06-14 Jean-Pierre Roux
596 - adding a constructor taking a gdcmDocEntry as an input param
597 - ReplaceOrCreateByNumber now returns :
598 a gdcmBinEntry * if a Binary (void *) value is passed as a param
599 a gdcmValEntry * if a string value is passed as a param
601 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
602 according to the param type (no longer sets a gdcmDocEntry)
603 - GetValEntryByNumber, GetBinEntryByNumber added
604 - NewValEntryByNumber and NewBinEntryByNumber added
606 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
608 - GetSQItemNumber and SetSQItemNumber added, to provide
609 a (relative) Item identier inside a given Sequence
610 \warning : some pb remaining around this number
612 - AddEntry now takes the Item Number as a param
614 - adding a constructor taking a gdcmDocEntry as an input param
616 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
617 * Memory leak hunt with the following command:
618 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
619 --show-reachable=yes gdcmTests PrintDocument
620 It looks like many (all?) leaks are due to the STL (or a bad usage
621 of the STL. The lines producing the leaks now have a comment with
622 a "MEMORY LEAK" tag: you can retrieve them with
623 grep "MEMORY LEAK" src/*
624 Here are two typical examples which I can't help fixing:
629 char * test = "babo";
630 name = test; //// <--- valgrind detects 960 bytes lost in
631 //// call to std::string::operator=(char const*)
632 name.clear(); //// Doesn't help !
640 std::cout << "Type a bunch of characters followed by RETURN: ";
641 getline(std::cin, line); //// <--- valgrind dectects a loss
642 //// of 1320 bytes in call to
643 /// std::basic_istream<>& std::getline<>
649 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * src/gdcmHeader.[cxx|h]:
651 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
652 and related, moved away to gdcmDocument.
653 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
654 the corresponding protected accessors of inherited class
655 gdcmDocument, removed ! As a consequence gdcmFile had to be
656 declared friend of class gdcmDocument (see below).
657 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
658 - Clean up of undefined or unused methods.
659 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
660 account the changes to gdcmHeader.h).
661 * src/gdcmDocument.h:
662 - gdcmFile is now a friend class (in order to take into account the
663 changes to gdcmHeader.h).
664 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
665 (see changes to gdcmHeader.h).
666 - Accessors (reading on the form GetEntry*) are now public.
667 - Clean up of undefined or unused methods.
668 * src/gdcmDocument.cxx:
669 - adaptation to changes to gdcmDocument.h
670 - ::OpenFile now writes a verbose message when file cannot be opened.
671 - some std::string properly set to VRKey
672 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
673 references to gdcmDocument.
674 * Test/TestFindTags.cxx: changed accordingly to above changes.
675 * gdcmPython/testSuite.py: adapted to renaming of acr files in
676 cvs repository gdcmData.
678 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
680 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
681 conflicts with gdcmValEntry::voidArea.
682 * src/gdcmValEntry.cxx: unmatching comment wiped out.
683 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
684 Value representation between StringRepresentable and BinaryRepresentable.
685 * src/gdcmDocument.cxx:
686 - method ParseDES: proper indentation restored and usage of
687 gdcmVR::IsVROfGdcmStringRepresentable wired in.
688 - method LoadDocEntry: the fingerprint left in the SetValue() of
689 unloaded entries (length > MaxSizeLoadEntry) had curiously been
690 removed. Reverting to previous code segment with the proper
691 dynamic_cast< gdcmValEntry* >.
692 Note: this was (partially) breaking the python test suite
693 (gdcmPython/testSuite.py) that made usage of the above
694 fingerprint to check presence of "Pixel Data".
695 * src/gdcmDocEntry.h: coding style.
696 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
697 now taken into account.
698 * gdcmPython/gdcm.i: adaptation to the new internal representation
699 of gdcm (exit gdcmParser, hello gdcmDocument).
700 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
702 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
703 anymore, but instead prints the loaded Python dictionary.
704 * .... alas, the python testSuite is still broken.
706 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
707 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
709 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
710 * src/gdcmUtil.h : export methods
712 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
713 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
715 * Initial addition of automatic python testing
716 * Initial addition of automatic image comparison
718 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
719 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
720 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
722 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
723 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
724 * Test/ShowDicom.cxx : bug fix for msvc compilation
725 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
727 2004-05-04 Jean-Pierre Roux
728 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
729 new concepts (and new classes) :
730 a 'gdcmDocument' is composed of a set of Doc Entries, that are
731 - elementary gdcmDocEntries (former gdcmHeaderEntries)
732 - Sequence Doc Entries (gdcmSeqEntries)
733 a Sequence is composed of Items.
734 Each item is a set of Doc Entries (this is recursive)
735 The non uniqueness of the 'Dicom tag' is due to this recursivity
736 (never taken into account)
737 Our unability to add a new 'entry' in the header
738 at the proper location (neither in the H-Table (map or multimap),
739 nor in the Chained List is also due to this recursivity.
740 Don't try, right now, to use/modify/compile these new sources :
742 We just commit all the stuff, 'as is', in order not to loose it.
744 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
745 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
747 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
748 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
749 file prefix (SetFilePrefix)
751 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
752 * Add a new test: ShowDicom, for now this is just the c++ version of
753 checkRead.sh, later it will be able to compare the image read against a
755 * Replace the DEBUG on the stack with a global entry in cmake interface:
756 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
758 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
759 * Add an example subdir, with a real example on how to read + write a
762 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
763 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
764 * Doc/CMakeLists.txt: the main page is now properly differentiated
765 between the developper and user version.
766 * Doc/doxygen.config.in: dropped search related obsolete flags
767 * src/gdcmParser.h, gdcmHeader.h: doxygenation
769 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
770 * DEVELOPPER: added some helpfull comments for compile/test/install
773 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
774 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
775 src directory, now generated in the build dir.
776 2. Tests as mentionned smarter
778 4. Add a new method in gdcmDict that return the PubDict by name
779 this is interesting for 3rd party lib like ITK,
780 where we could set the institution name / patient name...
782 * ENH: 1. Now the test suite is working for real
783 2. All binaries are now output in the gdcm-bin directory
784 (this was not true before)
786 2004-04-28 Jean-Pierre Roux
787 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
788 SeQuence indented printing of Dicom Header.
789 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
790 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
791 Computation of SQDepthLevel is now part of gdcmHeader constructor
792 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
793 tree-like structure of a Dicom Header.
794 * FIX Test code cleaning
796 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
797 * ENH: Adding automatic testing
798 1. Need a DartConfig.cmake to submit to public
799 2. Add a test driver gdcmTest.cxx
800 3. gdcmTestMain, an helper for the main test driver gdcmTest
801 4. Files in Test don't have a main anymore, this becomes interesting
802 when we add more and more tests, thus dsw don't have to load
804 * ENH: Adding a GDCM_DATA_ROOT for testing
805 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
806 one file instead of seven + some small cleanup
808 2004-04-22 Jean-Pierre Roux
809 * ENH Minor changes to the Print() methods.
810 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
811 Header printing. Example given with :
812 > PrintHeader fileName 2 new
813 (SQ based tree-like structure still to be done for the Header ...)
815 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
816 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
817 1. I have added some unsigned where needed
818 2. Some function parameter not used -> (void)
819 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
820 4. g++ don't like character '\' in comment
821 5. #define jpeg_create_decompress jCreaDecompress
822 this really need to be fixed
823 6. virtualize destructor of gdcmObject ... leakage
824 7. sscanf(g->first.c_str(),"%x",&gr_bid);
825 this also really need to be fixed
826 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
827 remove compression file
828 (as we only do decompression, right ?)
829 * ENH: Change malloc/calloc/free with c++ equivalent
831 2004-04-21 Jean-Pierre Roux
832 * FIX gdcmHeaderHelper::GetXSpacing
833 when a single value is found (bug ?), xpacing is now
834 defaulted to yspacing
836 2004-04-19 Jean-Pierre Roux
837 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
838 * ENH add parameters :
839 bool exception_on_error = false,
840 bool enable_sequences = false,
841 bool ignore_shadow = false
842 to the gdcmFile constructors to be full gdcmParser compliant
843 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
844 to allow reading of PAPYRUS 3.0 files
846 2004-04-06 Jean-Pierre Roux
847 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
849 2004-04-02 Jean-Pierre Roux
850 * ADD : Test/checksequence.sh, for a general recap on SQ pb
851 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
852 for Philips spurious Tag fffe|0000 while rewritting Dicom files
854 2004-03-30 Jean-Pierre Roux
855 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
856 for ACR file, written out as DICOM files (hope so...)
858 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
859 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
860 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
861 moved to base class gdcmParser and only the specialisation is kept
863 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
864 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
865 already does the job.
866 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
867 (to be consistent with gdcmParser::WriteEntries).
869 2004-03-30 Benoit Regrain
870 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
871 upate of the object's instance. It's passed to 2 in the unfavorable
872 case : one in the ExecuteInformation, one in the ExecuteData
874 2004-03-29 Jean-Pierre Roux
875 * ENH : Check on file type to be written moved
876 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
877 * FIX : gdcmObject::ResetBoundaries now stops properly
878 when end-of-list is reached
879 : gdcmVersion modified (as Benoit Regrain asked)
881 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
883 * src/gdcmUtil.cxx: added forgotten iostream include.
884 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
885 equivalent to ExplicitVR in existing code).
887 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
888 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
889 now contains all the gdcmGlobal related code.
890 * minor coding style and doxygenation changes.
892 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
893 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
894 now contains all the Debug related code.
895 * minor clean-up of includes in src/*.cxx
896 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
897 CreateCleanString) removed.
898 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
899 * Doc/DoxyMainPageUser.txt added.
900 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
901 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
904 2004-03-24 Jean-Pierre Roux
905 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
907 2004-03-23 Jean-Pierre Roux
908 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
909 big endian made volumes
910 * ENH Now gdcmParser constructor and destructor are protected to forbid
911 end user to instanciate class gdcmParser
912 (only gdcmHeader and gdcmDicomDir are meaningfull)
914 2004-03-22 Benoit Regrain
915 * FIX : src/gdcmDicomDir.cxx : make windows compilable
916 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
917 gdcmSerie to gdcmDicomDirSerie
919 2004-03-19 Jean-Pierre Roux
920 * ENH Now the tree-like structure describing a DICOMDIR comming from
921 an already existing DICOMDIR file is consistent with
922 the home-made tree-like structure build ex-nihilo
923 or build from the files held (recursively) in a Directory
924 functions gdcmDicomDir::CheckBoundaries()
925 gdcmObject::SetBoundaries() added
927 2004-03-17 Jean-Pierre Roux
928 * REM (Eric Boix bug) : removal of meaningless
929 gdcmDicomDirImage::NewImage function.
930 * FIX now file names and directory name are written properly in the
932 * FIX now gdcmDicomDir constructor may be call without any trick
935 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
936 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
937 of gdcmDicomDirImage::NewImage as empty function.
939 2004-02-28 Jean-Pierre Roux
940 * ENH add gdcmDicomDir:NewPatient
941 add gdcmDicomDirPatient:NewStudy
942 add gdcmDicomDirStudy:NewSerie
943 add gdcmDicomDirSerie:NewImage
944 to allow making gdcDicomDir object.
945 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
946 (as opposite to the gdcmHeader chained list)
948 2004-02-11 Benoit Regrain
949 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
950 when using from python
952 2004-02-10 Benoit Regrain
953 * FIX : bug fix in the gdcmDirList for the recursivity in directories
954 * FIX : in gdcmDicomDir when the directory is empty
955 * ENH : add callback and methods to get the progression of dicomDir
958 2004-02-06 Jean-Pierre Roux
959 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
960 - GDCM_META added to gdcmDicomDirType
961 - class gdcmMeta created
962 * ENH : - A brief summary is now displayed at the beginning of
963 'testDicomDir' to help disaster magnitude estimation
964 * REM : Now useless Test/explDICOMDIR.cxx
966 2004-02-05 Benoit Regrain
967 * ENH : add methods in gdcmObject to get the hash table or the list of
969 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
970 * FIX : wrapping python for TagHeaderEntryHT
972 2004-02-04 Benoit Regrain
973 * FIX : even length for some strings when writting the dicom dir
974 * FIX : sort the images in the dicom dir
975 * FIX : Bug fix for python use of dicom dir
976 * ADD : a python demo
978 2004-02-04 Jean-Pierre Roux
979 * FIX : Final solution (?) for icone embedded images
980 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
981 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
982 add groups 6002, 6004, 6006, to allow 'clean' parsing of
983 gdcmData/gdcm-MR-SIEMENS-16.acr1
984 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
985 to make full checking easier
987 2004-02-04 Benoit Regrain
988 * FIX : WriteEntries : coding style & logic in parameters
989 * FIX : Set the elements to create the DicomDir in a dictionary file
991 2004-02-03 Benoit Regrain
992 * gdcmDirList : to parse a hard drive directory in recursive (or not)
993 * gdcmDicomDir : add the load of directory
994 * Bug fix and print add-on
996 2004-02-03 Jean-Pierre Roux
997 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
998 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
999 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1000 * FIX gdcmParser.cxx : 'group length' elements are now considered
1001 as integers, even for shadow groups, when file is Implicit VR
1003 2004-02-02 Jean-Pierre Roux
1004 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1006 of the last synonym :-(
1007 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1009 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1010 * FIX taking into account the possible 7fe0,0010 multiplicity
1011 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1012 to allow removal of references to 7fe0,0010, to deal with
1013 ACR-NEMA images, when 0028,0200 is meaningfull
1015 2004-01-31 Jean-Pierre Roux
1016 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1017 no longer writes 'Un' on disk
1018 * FIX SQ elements with actual length are now dealt with corectly
1019 * FIX gdcmFile::WriteBase make the difference, for color images, between
1020 the length (for Palette expanded images)
1021 and Raw Length (non expanded image + Palette)
1022 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1023 (that broke Write). Replaced by UL.
1024 Aware user will reload the field if he
1025 thinks it's necesssary
1027 2004-01-30 Jean-Pierre Roux
1028 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1029 when 'dirty Acr' is found, to be compliant with the new
1030 IsReadable() methods.
1032 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1033 (no DOUBLE images in kosher DICOM,
1034 but so usefull for people that miss them ;-)
1036 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1037 DICOMDIR related utilities (not checked as Windoze compliant)
1039 2004-01-28 Jean-Pierre Roux
1040 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1042 2004-01-27 Jean-Pierre Roux
1043 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1044 to allow skipping the shadow elements, to save memory space.
1045 The TRUE value for this param has to be used
1046 with a FALSE value for the 'enable_sequence' param.
1047 ('public elements' may be embedded in 'shadow Sequences')
1048 * gdcmHeader methods now deal with 'embedded icones images' in the header
1049 (even when an 'icone image sequence' is announced by the
1050 element (0x0088,0x0200), but there is NO icone at all ...
1052 * gdcmHeader sometimes Image Location value doesn't follow
1053 the supposed processor endianity (see gdcmData/cr172241.dcm).
1056 * gdcmHeader add the method
1057 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1058 to get *all* the Header Entries with the same tag.
1059 GetHeaderEntrySameName is probabely *useless*
1060 (no meaning : Name is *not* an identifier within the Dictionnary)
1062 2004-01-26 Benoit Regrain
1063 * Bug fix in the print of hexadecimal representations. Remove long fields
1064 in the print and add a third level of print to print them
1066 2004-01-23 Benoit Regrain
1067 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1068 * Bug fix on test suite after remove the strip made on not string fields
1069 * Split the IsReadable method between gdcmParser which test that the file
1070 is dicom and gdcmHeader which test that it's an image file
1072 2004-01-22 Benoit Regrain
1073 * DicomDir : clean code, add methods, set variables in protected or private
1074 * gdcmUtil : bug fix for the clean string method
1076 2004-01-19 Benoit Regrain
1077 * Add the use of shadow dictionaries
1078 * bug fix and coding style
1080 2004-01-19 Benoit Regrain
1081 * src/gdcmFile.cxx : bug fix concerning the close of file
1082 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1083 * Add the update of header entries using the shadow library
1085 2004-01-19 Benoit Regrain
1086 * removal of file gdcmHeader2.cxx
1087 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1088 inheriting from gdcmParser. This split is to prepare the integration
1089 of dicom dir parsing
1090 * bug fix under python
1092 2004-01-16 Jean-Pierre Roux
1093 * REM removal of class gdcmHeaderEntrySet
1094 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1095 * ADD add file gdcmHeader2.cxx
1096 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1098 2004-01-15 Benoit Regrain
1099 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1100 entries created while parsing the header. Thus, they will be destroyed
1101 when the gdcmDictSet will be destroyed
1102 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1105 2004-01-15 Benoit Regrain
1106 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1107 made a fatal error because of the memory release at the end of program.
1108 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1109 some memory and vtk seems to have some problems with that.
1110 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1112 2004-01-14 Benoit Regrain
1113 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1114 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1115 * src/*.[h|cxx] : make changes due to class name changes
1116 * gdcmPython/demo/*.py : bug fix due to method names
1118 2004-01-13 Benoit Regrain
1119 * src/*.[h|cxx] : coding style
1120 * vtk/*.[h|cxx] : coding style
1122 2004-01-13 Benoit Regrain
1123 * gdcmPython/testSuite.py : test the readable flag of file for tests
1124 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1125 It's lied to the stl compilation by MSVC (windows, always windows...)
1126 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1128 2004-01-12 Benoit Regrain
1129 * src/*.h : add comments
1130 * src/gdcmDictSet.h : set the method BuildDictPath in public
1131 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1132 directly setted in the source code
1133 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1136 2004-01-09 Benoit Regrain
1137 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1138 * setup.py : use a reference to gdcmVERSION
1140 2004-01-07 Benoit Regrain
1141 * Modification to compile with the distutils.
1144 2003-12-10 Benoit Regrain
1145 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1146 can use a gdcmHeaderHelper to load datas
1147 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1148 made in the source code
1150 2003-12-10 Benoit Regrain
1151 * Update Windows projects and .cvsignore files
1153 2003-11-12 Jean-Pierre Roux
1154 * ENH gdcmHeader constructor has one more parameter (default value : false)
1155 that allows the user to 'go inside' the SeQuences only
1157 gdcmElValSet:Print takes it into account
1159 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1160 * ENH: Update gdcmPython/CMakeLists
1161 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1162 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1164 2003-11-10 Jean-Pierre Roux
1165 * FIX : gdcmHeader::LoadElements is now based
1166 on the ListTag listElem member,
1167 not longer on the TagElValueHT tagHt member
1168 * ENH : PrintPubElVal shows (temporarily) both results,
1169 with the tagHt member and the listElem member.
1170 (it's easier to 'see' the problems when using Printheader)
1172 * FIX : old private member LgrElem is now splitted into
1173 ReadLength : Length actually found on disk (updated only
1174 if bug fixing is necessary), for internal
1176 UsableLength : Updated by FixFoundLength, to fix a bug
1177 or to allow Parser going on.
1178 Will allow to re-write a kosher header when a SeQuence
1179 with a length (not 0000) is found
1180 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1181 because gdcmElValSet::Add does not update ListElem
1184 2003-11-07 Jean-Pierre Roux
1185 * FIX misstyping in Transfert Syntax name table
1186 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1187 when they have an actual length (not 0000 nor FFFFF)
1188 (Nobody should care of it, but DICOMDIR explorers)
1190 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1191 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1193 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1194 * ENH: vtkGdcmReader now supports LUT !
1195 (vtkgdcmViewer for now is not able to use them though)
1197 2003-11-05 Jean-Pierre Roux
1198 * in testSuite.py : new files names for checking the package
1199 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1200 that returns the pixel area size to the *aware* (vtk) user
1201 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1203 2003-11-05 Benoit Regrain
1204 * in testSuite.py : Modify the rules for checking the paths
1205 : Explicit error messages
1206 * in __init__.py : Related modif
1208 2003-11-03 Jean-Pierre Roux
1209 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1210 to be used by aware (vtk) users that want to manage
1211 LUT (and no to turn the PALETTE image into an RGB pixels one)
1212 * GetPixelType now returns 8U for 24 Bits images
1213 (vtkGdcmReader compliant)
1215 2003-10-31 Jean-Pierre Roux
1216 * Removal of *all* gdcmData images and add them again
1217 in order to loose the 'history' of un-anonymised images
1219 2003-10-31 Jean-Pierre Roux
1220 * RMV : removal of useless jBitsInJsample.h
1221 for both 8 and 12 Bits JPEG Lossy Libraries
1223 2003-10-31 Jean-Pierre Roux
1224 * ENH : Add the functions gdcmFile::GetImageDataRaw
1225 gdcmFile::GetImageDataIntoVectorRaw
1226 that act as GetImageData and GetImageDataIntoVector
1227 except the making of an RGB Plane from Gray Plane + LUT
1228 Intended to aware (vtk) users who know how to manage
1231 GetLUTRGBA return a R,G,B,A LUT if any
1232 lgrTotaleRaw gives the 'Raw' length
1233 GetImageDataRaw returns the gray Plane
1234 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1235 (They stay Grey, just like with other Dicom viewers :-(
1237 2003-10-30 Jean-Pierre Roux
1238 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1240 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1241 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1242 being coherents dicom files.
1244 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1245 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1247 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1248 * ENH: Two steps is necessary to please VC++ compiler...
1249 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1250 * ENH: Add include dir to medcon lib
1251 * FIX: only one function is being exported for now !
1252 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1254 2003-10-29 Jean-Pierre Roux
1255 * adding gdcmHeader::GetLUTRGBA
1256 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1257 --> Mathieu, the modif u're waiting for is not yet committed
1258 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1260 2003-10-27 Jean-Pierre Roux
1261 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1262 00191113.dcm DermaColorLossLess.dcm
1263 MxTwinLossLess.dcm RadBWLossLess.dcm
1264 * ENH: For version prior to vtkImageViewer2 -r 1.19
1265 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1267 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1268 * Removal of ido stuff in CMakeLists.txt
1270 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1271 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1272 * FIX: remove a call to ->Modified ... see comments
1273 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1275 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1276 * FIX: Problem with path for libvtkgdcmPython
1277 * ENH: Try adding a search script for python site-package
1278 * RMV: Remove some file from medcon lib that are not necessary
1279 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1280 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1281 * FIX: More pragma disable fro VC++,
1282 I don't think I break something as it is also disable in VTK/ITK.
1283 But it fasten debug compilation time.
1285 2003-10-23 Jean-Pierre Roux
1286 * gdcm now deals with 16 Bits Run Length Encoded images
1287 (they are compressed as 2 planes images,
1288 one for the high Bytes, the other for low Bytes)
1290 2003-10-22 Jean-Pierre Roux
1291 * Now CheckRead takes into account :
1292 - the bugged 'Leonardo' Siemens images
1293 - the XA images, sent thru the burning VPRO station
1294 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1297 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1298 * FIX: When copying a Makefile.am to CMakeLists.txt
1299 one should remove the '\'
1301 2003-10-22 Jean-Pierre Roux
1302 * in gdcmData adding a bugged 'Leonardo' Siemens image
1303 (wrong lengths in header)
1304 OK with gdcm, KO with the other viewers :-)
1305 * add a GE dlx XA image, thru the VEPRO burning station
1308 2003-10-21 Jean-Pierre Roux
1309 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1310 for a brutal checking of vtkgdcmViewer compliance
1312 2003-10-21 Jean-Pierre Roux
1313 * add the files for 'xmedcon' Jpeg Lossless library
1314 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1316 2003-10-21 Jean-Pierre Roux
1317 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1319 2003-10-21 Jean-Pierre Roux
1320 * garbage Siemens 'Leonardo' images dealt with
1321 (the patch is easy to remove)
1322 * cosmetic changes to avoid warnings
1324 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1325 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1326 no need to press 'r' now.
1328 2003-10-20 Jean-Pierre Roux
1329 * upgrade of checkRead.sh checkWrite.sh according
1330 to new Jpeg Lossless decompressor
1331 * add US.3405.1.dcm, a genuine RGB medical file ...
1332 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1333 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1335 2003-10-15 Jean-Pierre Roux
1336 * general anonymisation in gdcmData
1337 * adding the 'color files' from
1338 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1339 * adding some well knowed bugged-header images
1340 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1341 waiting for their inclusion in Python testsuite
1343 2003-10-15 Jean-Pierre Roux
1344 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1345 no longer seg faults when file is not found
1347 2003-10-14 Jean-Pierre Roux
1348 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1351 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1352 * TODO: *.in file to genereate a UseGDCM later
1354 2003-10-14 Jean-Pierre Roux
1355 * Some supposed-to-be Dicom Images have no preamble.
1356 OpenFile takes it into account
1357 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1358 * Missing elements added in dicomV3.dic
1359 (just to be affraid : have a look at
1360 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1361 and do it again next year ;->
1363 2003-10-13 Jean-Pierre Roux
1364 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1365 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1366 But there are NOT. It's fixed !
1368 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1369 * FIX: "jpeglib.h" was not found on VC++
1370 * FIX: vtkgdcm was not being installed
1372 2003-10-10 Jean-Pierre Roux
1373 * ENH : OpenFile closes the file if it *really* doesn't look like
1374 an ACR-NEMA / DICOM one.
1375 * FIX : testWrite no longer writes an empty file if the source file
1376 is not gdcm Readable
1377 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1380 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1381 * FIX: CMake generate now documentation
1382 * ENH: out of source doc build !
1383 * ENH: Generate both user and dev documentation
1384 * ENH: Should work on windows too
1385 * ENH: Only one doxygen config.in file is needed
1386 * FIX: make install should be ok now on ùnix plateform
1387 * FIX: PATH to dictionary was wrong (missing /)
1388 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1390 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1391 * vtkGdcmReader is now able to read rgb dicom file.
1392 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1393 * added a gdcmViewer to vtk test, use mouse to control
1394 window level & window width
1396 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1397 * CMake-ification of gdcm, we have now two build system
1398 * FIX: on cygwin Wsock32 doesn't exist
1399 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1401 2003-10-06 Emanuel Ollart
1402 * FIX : compilation process wad broken.
1403 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1405 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1406 * change gdcmViewer -> vtkgdcmViewer
1407 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1409 2003-10-06 Jean-Pierre Roux
1410 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1411 ( e.g : well known GE images with a wrong elem length,
1412 : Philips MRI Images with a wrong Huffman table)
1413 * still to be done : allow the reading of bugged LEONARDO Siemens images
1415 2003-10-03 Jean-Pierre Roux
1416 * Odd length strings are padded with '\0' (not with spaces,
1417 to remain compliant with already defined strings,
1418 like Transfert Syntax UID and others)
1420 2003-10-03 Jean-Pierre Roux
1421 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1422 to allow displaying RGB images (not only by affim ;-)
1424 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1425 * vtkGdcmReader is now able to read rgb dicom file.
1426 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1428 2003-10-03 Jean-Pierre Roux
1429 * A few nasty patches to allow the reading of a lot of nasty images
1430 ( e.g : well known GE images with a wrong elem length,
1431 : Philips MRI Images with a wrong Huffman table)
1432 * still to be done : allow the reading of bugged LEONARDO Siemens images
1434 2003-10-03 Jean-Pierre Roux
1435 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1437 2003-10-03 Jean-Pierre Roux
1438 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1439 to allow displaying RGB images (not only by affim ;-)
1441 2003-10-03 Jean-Pierre Roux
1442 * gdcmFile::GetImageDataIntoVector now
1443 - deals with MultiFrames MultiFragments Run Length Encoded files
1444 - deals with YcBcR (YBR_FULL) files
1445 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1446 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1448 (no sample found :-(
1450 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1451 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1452 Two reasons: - clear things
1453 - third parties acces gdcm through header files, so won't
1454 suffer anymore VC++ complains
1456 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1457 * add argv[1] in testvtkGdcmReader.cxx
1460 2003-09-24 Jean-Pierre Roux
1461 * The lines are now eigthy characters long.for
1462 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1464 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1465 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1466 char* to std::string. Thus, the use of strdup becomes useless. (see
1467 previous commis of Malaterre)
1468 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1469 before the last Malaterre's commit.
1471 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1472 * This commit should fix the Debug building under VC++, the problem
1473 was mainly a mixture of debug and release lib being loaded at startup.
1474 * I also remove a depency to a specific C function: strdup. Because I had
1475 to force the link to msvcrtd (whereas strdup is in libc).
1477 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1478 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1479 located in the gdcmCommon.h file. All use of reference of tha has been
1480 changed to now use the variable GDCM_UNFOUND.
1482 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1484 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1485 Dicom dictionary. The test suite can now be run again. Note:
1486 I'm note very happy with the " (RET)" changes. I believe this
1487 RETAINED comment should be dropped when parsing the dictionary.
1488 - PACKAGER corrected
1490 - AUTHORS updated and now in alphabetical order
1491 * Makefile.am now exports gdcm.dsw for Windoze users.
1493 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1494 * cygwin complains about missing std:: in subdir Test/
1496 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1497 * remove some methods that are now in gdcmHeaderHelper
1499 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1500 * vtkGdcmReader set spacing and origin correctly
1502 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1503 * Fix a few delete/delete[] mismatch
1505 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1506 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1507 interpretation to data given by gdcmHeader. For instance there are
1508 heuristics to get informations (look at different places).
1509 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1510 sorting DICOM images based on different strategies.
1511 * modified Makefiles accordingly.
1513 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1514 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1515 when building in debug mode
1516 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1517 src/win32/gdcmdll.dsp
1518 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1520 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1521 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1524 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1525 * src/win32/libgdcmjpeg12.dsp was not dos format
1526 * src/win32/libgdcmjpeg12.dsp :
1527 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1528 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1530 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1531 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1533 * src/gdcmFile.cxx : bug fix in affectation type
1534 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1535 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1536 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1537 symbols... future problem ?
1539 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1540 * src/win32/libgdcmijpeg12.dsp was missing
1541 * modified gdcm.dsw accordingly
1543 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1544 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1546 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1547 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1548 commit of JPR (before his hollidays to facilitate our work).
1549 * setup.py : bug fix in code. Modifications made while the last commit
1550 of JPR. The code hasn't been tested before the commit... it's so
1551 useless to make that (for best programmer that is JPR) !!!
1553 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1554 * tagged the current version as Version0_3 (i.e. version 0.3)
1556 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1557 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1558 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1559 * *.dsp : modifications to use new libgdcmijpeg8 library
1560 * setup.py : bug fix on VTKPATH variable
1561 * PACKAGER : adding all concerning windows
1563 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1564 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1566 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1567 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1568 test suite reported error.
1569 * PACKAGER file added (describes what a packager must do when
1570 packaging a new release).
1571 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1572 * configure.in: upgraded version number to 0.3.0
1573 * fixing build of rpm (through rpm -ta):
1574 - Doc/Makefile.am exports proper doxygen files
1575 - src/jpeg/libijg8/Makefile.am exports the include files.
1577 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1578 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1579 * src/gdcmHeader.h : formatting code
1581 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1582 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1583 We were obtaining error message from vtk. Now, creation of file list
1584 is made in an internal list to prevent this problem.
1585 Bug fix when output is empty.
1586 Bug fix in update of progress value. Previous commit for this was a bad
1588 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1590 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1591 * src/gdcmHeader.h : added method to get the file name
1592 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1593 files. Added method to remove all files on the input
1594 Added FIXME comment concerning the bad parsing of header made by
1595 ExecuteInformation method (in ExecuteData method)
1597 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1598 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1599 when using make instal.
1600 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1601 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1603 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1604 * setup.py : adding include dir of jpeg lib to compile all sources
1605 * */Win32/*.dsp : JPR fix for windows compilation
1607 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1608 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1610 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1611 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1613 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1614 * setup.py is again effective on un*x (takes into account the
1615 addon of the jpeg library)
1616 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1617 * Doc/Doxy* updated (includes above enhancements)
1618 * INSTALL now points to web documentation
1620 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1621 * src/gdcmHeader.h doesn't make unnecessary reference to
1623 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1625 * src/gdcm*.[cxx|h] :
1626 - to allow compilation with gcc 3.x
1627 -- clean up of STL usage (added explicit usage of std::)
1628 -- small fixes on exceptions.
1629 Note: linking not tested !
1630 - clean of doxygen comments to avoid warnings at documentation
1632 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1633 dependent convertion).
1635 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1636 * Clean up of previous JPR garbage commit (not even commented in the
1638 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1639 - moved all jpeg related files from src to src/jpeg/libijg8, with
1640 addition/modification of Makefile.am and configure.in.
1641 - the testSuite is still brain damage (not guilty).
1643 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1644 * WrapVTK.py : modifications to get correctly vtk source files to
1646 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1647 (FileName -> Filename)
1649 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * vtk/vtkGdcmReader.[cxx/h]:
1651 - UpdateProgress method should now be effective
1652 - removed the limitation on having only images loaded (as opposed
1654 - when building a stack of images/volume, a lesser number of
1655 gdcmHeader and gdcmFile instances should be used (hopefully
1656 accelerating things).
1657 - when building a stack of images/volumes, files which are not
1658 loadable (wrong path-filename, wrong permissions on existing file,
1659 or file not parsable by gdcm) are replaced with a black image
1660 in the stack (for the caller to notice the problem).
1662 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1663 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1665 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1666 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1667 between standard library (std) and vtk library (problems are found
1668 under Windows... thanks Windows !)
1670 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1671 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1673 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1675 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1676 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1678 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1679 * When compiling with distutils (see setup.py) the C++ compiler is
1680 called with different flags than the default ones (with automake).
1681 In order to fix all those warning, I compiled gdcm with the command
1682 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1683 and went for warning fixes:
1684 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1685 up from unused variables.
1686 - vtk/vtkGdcmReader.cxx: potential bug fix.
1687 * src/gdcmHeader.h: Doxygen warning cleanup
1689 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1690 * gdcmPython/gdcm.i:
1691 - typemaps correction to take into account the systematic replacement
1692 of "using namespace std" with std:: prefix e.g. std::list,
1693 std::string... (cf changes of 2003-05-21).
1694 - gdcmGlob global variable of type gdcmGlobal (defined in
1695 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1696 exported to Python a as cvar.
1697 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1698 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1699 gdcmDictSet.GetPubDictTagNames() and
1700 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1701 C++ static methods).
1702 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1703 with the above changes.
1705 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1706 * setup.py, manifest.in : bug fix under linux
1708 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1709 * Modification of setup.py to compile vtk part too. Then, we have 2
1710 wrappers which must work with same distutils. For that, we have a
1711 generic distutils in distusiltsWrapping.py ; with :
1712 - build_extWrap class to wrap generically all extensions,
1713 - ExtensionWrap base class for all wrapping extension that contains
1715 - Wrapper interface which wrap sources
1716 + In WrapSwig.py we have extension and wrapper for Swig
1717 + In WrapVTK.py we have extension and wrapper for VTK
1718 * MANIFEST.in : modifications to consider vtk directory and new python
1719 files for compilation
1721 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1722 * Added python wrappers of vtkGdcmReader vtk class (see the
1723 source in vtk/vtkGdcmReader.cxx) :
1724 - vtk/Makefile.am now builds a library
1725 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1726 python library (as opposed to _gdcm.so wich are the python
1727 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1728 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1730 - configure.in has an additional flag --enable-vtk that needs
1731 to be set to enable compilation of vtk related code, that is:
1732 + vtk/vtkGdcmReader.so and
1733 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1734 + gdcmPython/vtkgdcmPython.so (see above)
1735 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1736 be read when compressed or when HighBit + 1 != BitsStored),
1737 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1738 the usage of the python wrapper of vtkGdcmReader vtk class.
1739 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1740 * src/*.[h] all occurences of stl classes are now prefixed with
1741 std::, and all occurences of "using namespace std;" where removed.
1742 This is to avoid pollution of global namespace in included files.
1743 Apparently vtk does not avoid this pitfall: when using both
1744 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1745 collision of various stl members (principally cout...).
1746 * gdcmPython/testSuite.py now cleanly removes temprory generated
1748 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1749 comply with above changes)
1751 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1752 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1753 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1754 vtk data structure (an image Flip was required).
1755 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1756 * cosmetic changes in documentation.
1758 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1759 * src/gdcmHeader.cxx: the constructor no longer exits when an
1760 unexisting file is given as argument.
1761 * The subdirectory Data (containing all the images used for the
1762 test suite) is not part of this repository anymore. A new module
1763 containing those images is now available at
1764 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1765 with the name gdcmData.
1766 All the python scripts (including the package initialisation file
1767 gdcmPython/__init__.py) were adapated to take this change into
1768 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1770 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1771 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1772 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1773 demo of the usage of this class.
1774 Compilation of this vtk part is only done when using the --enable-vtk
1775 at configure (or autogen.sh) stage.
1777 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1778 * More memory link related corrections and documentation fixes.
1780 - maximum info is obtained with a command of the form:
1781 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1782 --show-reachable=yes PrintHeader
1783 - the remaining reachable blocks seem to come from the STL
1784 allocation scheme through the usage of map and list. It looks
1785 like this memory cannot be freed but it is not a memory leak
1786 (in fact further invocation to the STL would recollect the
1787 unused memory allthough it cannot explicitely be freed).
1788 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1789 of displaying an image parsed with gdcm and displayed with VTK.
1790 Note: some images don't seem to work e.g.
1791 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1792 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1793 Allthough this weakens the semantics, it is a ditch attempt to
1794 make gdcm more thread friendly.
1796 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1797 * Memory link hunt (by using valgrind through the command
1798 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1799 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1800 gdcmHeader::_dicom_vr.
1801 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1802 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1804 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1806 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1807 * src/Makefile.am now exports all the necessary include files at
1811 * UpdateGroupLength replaced by new one
1814 * UpdateGroupLength re-written using H-Table
1815 (named UpdateGroupLengthNew untill checks are over)
1817 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1818 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1819 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1821 - gdcmHeader::GetPubElValSet removed.
1822 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1823 UpdateGroupLength, WriteElements, Write.
1824 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1825 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1826 carried the same semantics.
1827 - src/gdcmHeaderIdo.cxx changed accordingly.
1828 - gdcmFile::WriteBase now regroups all the codes from previous
1829 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1830 - enum FileType moved to gdcmCommon.h
1831 * src/gdcmHeader.cxx AddDefault trashed
1832 * gdcmGetXSize added
1833 * getimageDataSize now calls gdcmGetXSize
1834 * Test/*.cxx changed to agree with above changes
1836 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1837 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1838 (to avoid double call by end user).
1839 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1840 by end user, since gdcmHeader::gdcmHeader now handles it.
1842 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1843 * gdcm/Doc many doxygen changes:
1844 - Doxyfile now has two different versions, DoxyfileUsers that generates
1845 the html.users end users oriented documentation and
1846 DoxyfileDeveloppers that generates the html.developper developper
1847 oriented documentation.
1848 - README changed accordingly
1849 - requirement.txt removed (old design info moved to TODO).
1850 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1851 DoxyMainPage.txt, DoxyPython.txt provide more information.
1852 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1853 be updated by simply regenerating the docs with doxygen and copying
1854 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1855 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1856 all the tests in the form "if (<map>.count() >1)" were removed.
1857 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1858 ill-formed documentation sections.
1859 * src/gdcmHeader.cxx: ditto
1861 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * setup.py fixed for un*x (needed macro for stdint.h)
1863 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1864 un*ces with sh-utils test utility.
1865 * gdcmPython/demo/test.py renamed to PrintHeader.py
1866 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1867 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1868 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1869 * src/gdcm*.cxx JPR's bad inclusion fixed.
1871 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1872 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1873 * gdcmPython/demo/test.py changed accordingly.
1875 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1876 * gdcmPython/Makefile.am fixed linking against libstdc++
1877 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1878 * Swig subdir (historical tests of swig version 1.3.17++) removed
1879 * Test/testChangeEntete.cxx some lines commented out in order to make
1881 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1882 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1884 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1885 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1886 hence the user doesn't need this explicit call.
1887 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1888 i.e. LoadElements() call removed.
1889 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1890 - src/Makefile.am declares the proper flag for g++.
1891 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1892 for adding user defined new tags.
1893 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1894 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1895 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1897 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1898 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1899 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1900 src/Makefile.am : the project should properly compile and install
1901 with the autotools, included the python wrappers part.
1902 * gdcm.spec.in : added a spec file for RPM packaging.
1904 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1905 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1907 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1908 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1909 to exported to the environement (see gdcmPython/testSuite.py
1911 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1912 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1913 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1914 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1915 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1917 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1918 * gdcmPython/__init__.py doesn't crash anymore when running in
1919 in InstallMode or PreInstallMode but with an environement given
1920 value of GDCM_DICT_PATH.
1921 * src/gdcmDictSet.[cxx/h] coding style.
1923 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1924 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1925 * src/gdcm.h general comments moved to TODO, and README
1926 * src/gdcm.h should now be seen as a user commodity (including it
1927 should suffice to fully use gdcm). It is nowhere including within
1928 any of the kernel files src/*.cxx and src/*.h.
1930 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1931 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1932 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1934 * src/gdcm*.cxx only include their corresponding include file
1935 (as opposed to gdcm.h)
1936 * gdcmPython/gdcm.i changed accordingly
1937 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1938 the autogen.sh generated "make snapshot" command to work.
1939 * autogen.sh removed history related references to crea package.
1941 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1942 * distutilsSwigCPlusPlus.py work around some swig portability
1945 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1946 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1947 was done in a last ditch attempt to get setup.py _really_
1948 operationnal. The python/gdcmPython layaout add the advantage
1949 of hidding away the python related distutils specific files
1950 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1951 Alas, the src directory was out of scope (i.e. it's relative
1952 position to setup.py was ../src) which made things impossible to
1953 handle (see previous version of python/setup.py). Crossing fingers...
1955 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1956 * python/setup.py now works on Un*x. (harder than I thougth)
1957 * python/distutilsSwigCPlusPlus.py can now have include files
1958 among the list of sources.
1960 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1961 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1962 * modifications in MSVC projects
1964 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1965 * As stated by the first lines of Test/ExceptionAndPython/README, it
1966 looks like we can move back to original usage of exception within
1967 src/gdcm* and hence remove the errno stuff that was introduced
1968 as a quick and dirty fixture of this problem (added to the TODO).
1969 * Doc/Doxyfile configuration file for Doxygen and corresponding
1970 README file for usage added.
1971 * Test/testWrite.cxx added. This new test comes from a split of
1972 test.cxx that is now reverted to its original purpous i.e.
1973 testing the proper parsing of a Dicom related file.
1974 testWrite.cxx concentrates on testing the IO part of gdcm.
1975 * Test/bug1.cxx (containing a bug on WIn32) added.
1976 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1977 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1978 whose purpose is to publish the content of the TagNames of the
1979 Dicom public dictionnary were not accessible without an
1980 instance of class gdcmHeader.
1981 - those methods are now static methods of gdcmDictSet and hence
1982 require no instances at all to be invocated.
1983 - within gdcmDictSet this change required to change some method
1984 to class methods (i.e. are now static) among which SetDictPath
1985 (renamed to BuildDictPath) and LoadDefaultPubDict.
1986 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1987 the above changes by calling the new method classes of gdcmDictSet.
1988 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1989 the above to be effective.
1990 * python/gdcmPython: in order to wrap properly the above changes
1991 for Python, swig version now needs to be > 1.3.17.
1992 * python/gdcmPython/Makefile fixed to adapt itself to new
1993 configure/make shema introduced by Johan Montagnat (thanks for the
1994 contribution). Alas this Makefile cannot be turned into a proper
1995 Makefile.am without some heavy changes in the configure.in
1996 (for python dectection).
1997 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1998 now avoids publishing the empty entries.
2000 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2001 * python/setup.py : bug fix concerning install under windows
2002 ExtraPath reused :-P
2003 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2005 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2006 * Dicts/dicomV3.dic : remove double spaces !!!
2007 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2008 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2011 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2012 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2013 method. Doxygenation.
2014 * src/gdcm.h clean up of JPR spurious comments.
2016 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2017 * python/distutilsSwigCPlusPlus.py now properly collects the
2018 shadow classes generated by "swig -c++" (gdcm.py in our case)
2019 when using "python setup.py install".
2020 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2021 reexports the working classes.
2022 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2023 by the classical C errno scheme. This is to prevent an obscure
2024 behavior of the python wrappers when importing wxPython.wx prior
2025 to gdcmPython (which ended up in an abort call). An illustration
2026 of this oddity can be found in the Test/ExceptionAndPython
2027 subdir (see the README file). This problem probably due to
2028 an combination of g++ and dynamic loading.
2029 * added Test/ExceptionAndPython (see above)
2031 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2032 * Changed the layout of the python part to avoid bloating main
2033 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2034 i.e. the distutils arsenal. All the python related stuff is
2035 again in a python subdir, but the package itself is now in
2037 * setup.py was cleaned up:
2038 - pythonIncludePath removed
2039 - python setup.py bdist target is now functional.
2040 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2041 collision with other packages). gdcmPython/demo/*.py changed
2044 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * python subdir moved to gdcmPython (preparation of distutils packaging).
2046 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2047 distutils installer is operational.
2048 * - gdcmPython/__init__.py now properly loads the swig generated
2049 shadow classes (from gdcm.py).
2050 - gdcmPython/demo/*.py changed to import the package gdcmPython
2051 instead of gdcmPython/demo/load.py.
2052 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2054 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2055 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2056 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2057 entries within the associated public Dicom dictionary resp. the same
2058 information but sorted by the fourth field (PAT, IMG, DIR) of the
2060 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2061 are now in the "???" group.
2062 - python/gdcm.i changed accordingly,
2063 - python/demo/printGroupedPublicDict.py added, that gives an example
2064 of the above new functionalities in Python.
2066 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * src/gdcm.h, gdcmHeader.cxx:
2068 - historic references to glib's g_malloc and g_free (#defined)
2069 were definitively removed.
2070 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2071 * src/gdcmElValSet.cxx:
2072 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2073 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2074 - GetElValue(string) renamed to GetElValueByName.
2075 - Added GetElementByName(string).
2076 * src/gdcmHeader.cxx: added
2077 - GetPubElValRepByNumber(guint16, guint16)
2078 - GetPubElValRepByName(string)
2079 - GetShaElValRepByNumber(guint16, guint16)
2080 - GetShaElValRepByName(string)
2081 - GetShaElValByNumber(guint16, guint16)
2082 - GetShaElValRepByName(string)
2083 - GetElValRepByNumber(guint16, guint16)
2084 - GetElValRepByName(string)
2085 - GetElValByNumber(guint16, guint16)
2086 - GetElValRepByName(string)
2087 * Doc/requirements.txt added.
2089 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2090 * Test/Makefile building now depends on the one of libgdcm.so
2091 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2092 pixel data) aware which enables finding the address (offset) of
2093 the pixel data of JPEG encoded DICOM files. This leaves only a single
2094 file in the testSuite whose pixel data address (offset) is unknown.
2095 * python/testSuite.py changed accordingly.
2097 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2098 * VC++ has some strong limitations when working with the STL, as stated
2099 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2100 "Also note that some STL containers (map, set, queue, list, deque)
2101 cannot be exported. [...]
2102 Some STL classes contain nested classes. These classes can not
2104 This is caused by a designed limitation that once a template
2105 class is instantiated, it can not be re-instantiated and
2107 Since our usage of map<> is ubiquitous in gdcm, this "designed
2108 limitation" of VC++ is a pitfall.
2109 Hence the Python wrappers of gdcm cannot be incrementally linked
2110 against the c++ dynamic library. The dirty but only workaround is
2111 to forget about incremental link of dynamic libraries and to generate
2112 the Python wrappers library with the inclusions of the underlying C++
2114 The following modifications concern this matter on Win32/VC++:
2115 - wrapping python correct with standalone wrapped dll (don't use separate
2116 dll under windows !!!!)
2117 - python21_d debug mode enabled (ask Frog how to use it :-)
2118 - NO problem with having an STL member of class for example string in C++
2119 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2120 - Python test of dcmlib in Python is ok under windows on a large set
2122 * removed glib references
2123 * typedef's inserted in gdcm.i for correct swig type management
2125 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2126 * python/demo/*.py load.py extracted from test.py. Added explore.py
2127 that only displays required tags and testAll.py that parses all
2128 the files of the testsuite without using unittest.
2129 * python/testSuite.py other additional test on new files added.
2130 * Data/* new test files added accordingly to the testSuite.
2131 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2132 the vr in the file differs from the one of the dictionary.
2134 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2136 values, but limits itself to values which are below a user specified
2137 size (by default 1024 bytes).
2138 * python/gdcm.i : elements not loaded (because their size is above the
2139 user specified treshold) are exported with their TagKey as key of the
2140 python dictionary. This enables the testsuite to make some checks
2141 on the unloaded elements (since we have their offset and size).
2142 * python/testSuite.py
2143 - now tests for the existence and proper value of the pixel data
2144 - two new examples added.
2145 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2147 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2149 aware. See the strategy comments in gdcmHeader::FindeLength().
2150 * Test/test.cxx now accepts a filename as first argument.
2151 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2152 * python/testSuite.py changed to integrate test on above files.
2154 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2155 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2156 the vr was also RET.
2157 * python/testSuite.py more tests added.
2159 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2160 * python/testSuite.py unittest test suite added (uses Data)
2161 * Data/* dcm and acr files for the test suite.
2162 * glib dependance removed from un*x version. We now use ISO C99
2163 7.18 Integer types (see stdint.h)
2164 - python/Makefile, src/Makefile src/gdcm.h
2165 * src/ when an explicit vr (like dicom files) suddenly poped an
2166 implicit element we use to mark the underlying DictEntry of the
2167 concerned ElValue with "Implicit". This strategy was damageable
2168 too the public or provite dictionaries, since some of their vr
2169 would be changed. Since Header::FindLength heavily relies on the
2170 detection by Header::FindVR of falsely explicit elements, I
2171 added an extra ImplicitVr member to ElValue (boolean).
2172 The rest of the changes we the necessary adaptations.
2174 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2177 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2179 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2180 * Adaptation for porting to VC++:
2182 o forced to use std namespace (for string to be known)
2183 o all class use __declspec export style on WIN32
2184 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2185 (in stdlib.h on Win32 but in std:: for gcc)
2186 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2187 variable GDCM_DICT_PATH.
2188 * src/gdcmHeader.cxx verbose comments made discrete.
2190 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2191 * python/gdcm.i: added a typemap that converts a C++ hashing table
2192 to native Python dictionary.
2193 * python/demo/test.py:
2194 - now uses the native dictionary for exploration of gdcmHeader.
2195 - takes an optional filename argument (the file to parse).
2196 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2197 PubElVals hashing table.
2198 * Dicts/dicomV3.dic removed error prone trailing spaces.
2200 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2201 * Python wrapping process moved away from src/Makefile to
2202 newly created python/Makefile (as well as gdcm.i)
2203 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2204 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2205 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2206 from the environement variable GDCM_DICT_PATH (when existing).
2207 * src/gdcmDict::GetTag bug fix.
2209 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2210 * Straightforward temporary fixes for swig to build the python wrappers.
2211 src/Makefile now has a python working entry [by working we mean
2212 that we can import de shadow classes without errors].
2214 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * hashtest.cxx removed (since allready in Test)
2216 * src/gdcmlib.h renamed to src/gdcm.h
2217 * src/dcm.i renamed to src/gdcm.i
2218 * src/Makefile prepared for python wrapping
2220 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * src/gdcmHeader.cxx :
2222 - Parsing of header is now separated from loading of element values
2223 (see gdcmHeader::LoadElements).
2224 - general clean up of hopefully all file access (creation of
2225 ReadInt16 and ReadInt32)
2227 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2228 * src/gdcmHeader.cxx :
2229 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2231 - SetLgrElem renamed to SetLength
2232 - GetLgrElem renamed to GetLength
2233 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2234 * src/gdcmElValSet.cxx fixed both GetElValue methods
2235 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2236 due to IdoDude was cleaned out.
2238 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2239 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2240 concentrates on finding the value representation (when it exists).
2241 RecupLgr now only finds the element value length, and it avoids
2242 returning the unecessary skL (skipped length).
2243 Also, offsetCourant was simply removed (with taille_fich) since
2244 it was redundant with the File position internals (by using
2245 ftell and fseek). This also made skL (see above in RecupLgr) usage
2247 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2248 on the libido specificities which are handled through class
2250 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2253 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2254 * Truckload of changes. Parsing of header is barely functional
2255 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2257 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2258 * src/gdcmHeader.cxx many addons of low level methods
2260 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2262 and _IdDcmSWAP_LONG.
2264 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2265 * This corresponds to all the changes decided at the meeting of
2266 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob