1 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * CLEANUP_ROUND for gdcmPixelConvert:
3 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
4 - src/gdcmPixelStuff[h|cxx] removed
5 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
6 - src/CMakeLists.txt changed accordingly
8 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
9 gdcmVersion.py moved to newly created ATTIC related
10 gdcmPython/SetupOldies/ directory.
12 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
13 - autogen.sh configure.in acinclude.m4 python.m4 removed
15 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
16 * src/*.cxx *.h Reference to License.htm fixed to License.html.
17 * Doc/CMakeLists.txt, doxygen.config.in: fix.
18 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
20 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
21 * TODO updated with Mathieu suggestions. I proposed a template for
22 describing TODO entries and used it for new entries.
23 * Added Doc/Website/CodingStyle.html, Developpers.html,
24 DeveloppersPython.html, GdcmDataCvs.html and
25 DownloadVersion0_1.html, DownloadVersion0_3.html.
26 * Some Doc/*.txt Doxygen files (which do not really concern the
27 documentation itself, but the website) moved to html and
28 placed in directory Doc/Website:
29 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
30 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
31 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
32 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
33 * CMakeLists.txt changed accordingly.
34 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
35 DeveloppersPython.html
36 * INSTALL nows refers to Doc/Website/Installation.html
38 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
39 * Added Doc/Website directory, that contains a first raw version
42 2004-09-23 Jean-Pierre Roux
43 * FIX In order not to be poluted any longer by casting problems,
44 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
45 we can now delete[] it safely
46 * VoidArea is now called BinArea (less confusing name),
47 and all the methods called ...VoidArea... are now ... BinArea...
48 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
50 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
51 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
52 clear) TagHT, which is an inherited member of gdcmElementSet. It is
53 up to the destructor of gdcmElementSet to clean up TagHt and it's
56 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
57 * Test/CMakeLists.txt: update to follow gdcmData renamings.
58 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
60 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
61 * ENH: added some utility method that builds a flat dictionnary
62 holding all the Dicom entries contained in the recursive structure
63 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
65 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
66 BuildFlatHashTable() that build a flat dictionary.
67 - src/gdcmElementSet.h: added a new private GetTag() accessor.
68 gdcmDocument is now a friend of gdcmElementSet.
69 - src/gdcmElementSet.cxx: clean up.
70 - Example/FlatHashTablePrint.cxx added.
71 - Example/CmakeLists.txt changed accordingly
73 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
74 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
75 moved away from gdcmDocEntrySet (since this class is an abstract class
76 acting like an interface). SQDepthLevel and BaseTagKey are now
78 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
79 and associated accessors. Doxygenation of the class.
80 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
82 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
83 Use SQDepthLevel accessor instead. ::Print() adapted.
84 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
85 - src/gdcmDocument.cxx changed accordingly.
87 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
88 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
89 - The following is the doxygen comment of the typedef declaration
90 of gdcmagKey in src/gdcmCommon.h:
91 gdcmTagKey is made to old an "universal" (as in URL, Universal
92 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
93 A dicom tag allways has a group and an element, but a set of tags
94 embeded in various (optionally nested) sequences and sharing
95 the same group and element all share the same (group, element)
96 "identifier". Hence the (group, element) cannot be used as an
97 identifier (in gdcm we shall refer to a "TagKey") of a tag.
98 In order to construct a proper tag identifier (i.e. a key) we
99 consider the following definition of a TagKey:
100 - let Group, Element be the string representation of the
101 group and element dicom tag members,
102 - let ItemNumber be the string representation of the integer
103 index of the considered item number of a sequence,
104 Let the key of a tag embeded in a sequence, noted SeqTag, be
106 /ItemNumber#Group|Element
107 where "/", "#" and "|" are characters acting as separators.
108 Then the general form of a gdcmTagKey is given by:
109 Group|Element<SeqTag>
110 where <SeqTag> means NO or many instances of SeqTag.
111 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
114 but the gdcmTagKey of a tag "embeded" is the first item of
115 a sequence, itself nested in the third item of a sequence is the
117 0004|1220/2#0008|0082/0#0008|0090
118 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
119 order to hold the new sequence compatible key. Previously, the
120 GetKey() method would look in the underlying gdcmDictEntry.
121 - src/gdcmDocEntry.cxx:
122 -- constructor now copies the underlying DictEntry key, in the local
124 -- ::Print: displays the member Key, instead of the (group, element).
125 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
126 - src/gdcmDocEntrySet.h:xi
127 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
128 -- now has a new BaseTagKey member.
130 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
131 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
133 This poses the problem with the semantics of the following lines
134 LoadEntryVoidArea(0x0028,0x1201); // R LUT
135 LoadEntryVoidArea(0x0028,0x1202); // G LUT
136 LoadEntryVoidArea(0x0028,0x1203); // B LUT
137 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
138 to the long FIXME note for what the problem is. Nevertheless in
139 order to get things working the dicom dictionary was altered !
140 Please fix things urgently...
141 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
142 information), see above note on moving the member VoidArea. Nevertheless
143 the following entries previously correctly set as US are now inproperly
145 0028 1201 OW IMG Red Palette Color Lookup Table Data
146 0028 1202 OW IMG Green Palette Color Lookup Table Data
147 0028 1203 OW IMG Blue Palette Color Lookup Table Data
148 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
149 of gdcmDocEntry moved to gdcmSeqEntry.
150 * src/gdcmSeqEntry.cxx: STYLE.
152 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
153 * Test/TestAllEntryVerify.cxx minor fix and added comments.
155 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
156 * gdcmPython/testSuite.py: all the test suite in python is now moved
157 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
158 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
159 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
161 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
162 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
163 to avoid inclusion recursion until STL is reached.
164 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
165 mecanism. errno.h is not included in gdcm anymore.
166 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
167 (gdcmFormatError now inherits from gdcmFormatUnexpected).
169 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
170 gdcmData/TestAllEntryVerifyReference.txt
171 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
172 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
173 exception_on_error parameter.
174 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
175 - vtk/vtkGdcmReader.cxx changed accordingly,
176 - Example/*.cxx and Test/*.cxx changed accordingly.
178 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
179 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
180 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
181 enable_sequences removed from gdcmHeader constructor and dependencies.
182 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
183 * gdcmPython/demo/PrintHeader.py: dummy fix.
184 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
185 skip_shadow removed from gdcmHeader constructor and dependencies.
186 * Example/*.cxx and Test/*.cxx changed accordingly.
188 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
189 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
190 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
192 2004-07-21 Jean-Pierre Roux
193 * FIX Now, Parsing and Printing a DICOMDIR do work!
194 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
196 2004-07-20 Jean-Pierre Roux
197 * FIX Some brain damaged headers have Zero-Lenght fields
198 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
200 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
202 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
203 variable (instance of gdcmDebug) by a definition macro, and the instance
204 is now in static in the gdcmDebug class
205 * src/gdcmSQItem.h : (FIXME) remove an undefined method
206 * Test/PrintAllDocument.cxx : bug fix in the result of the test
208 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
209 * WARNING: ctest now depends more tightly on gdcmData. You should
210 check out gdcmData properly for things to run smoothly...
211 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
212 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
213 we need the pixels not be loaded in order to use the ValEntry
214 that displays position and size).
215 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
216 This is a C++ based equivalent of gdcmPython/testSuite.py that should
217 be deprecated. If you have any doubts about the advantages of a
218 modern scripting language (read Python) versus grass root C++ (i.e.
219 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
220 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
221 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
222 Anyhow, consider documenting the gdcmData images in
223 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
225 * Test/CMakeLists.txt:
226 - now uses TestAllEntryVerify.cxx
227 - specific comments on oldACR00001.ima (now renamed in gdcmData
228 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
229 gdcmData/TestAllEntryVerifyReference.txt
232 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
233 * src/*.[h|cxx] : typedef clean up
234 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
235 - TagKey renamed to gdcmTagKey (for external usage)
236 - VRKey renamed to gdcmVRKey (for external usage)
237 - removal of typedef duplication.
238 - Removed all unecessary inline keyword from class inline definitions.
239 - Some method|function(void) declarations replaced with method|function().
240 * src/jpeg/libijg12/jdhuff12.c:
241 - printf polluting ctest removed.
242 - TAB removal for comminting
244 - TestAllReadCompareDicom.cxx: added a test that compares all the
245 images in gdcmDataImages.h with corresponding images in
246 gdcmData/BaselineDicom/. When baseline images are not present
247 this test creates them.
248 Note: we need to validate each reference image, but before that
249 I'd like to rename them with a more explicit name...
250 - CMakeLists.txt: changed accordingly.
251 * Example/*.cxx: examples now only include gdcm.h (as opposed to
252 including each header needed).
254 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
255 * Test/*.cxx and Example/*.cxx: moved some examples away from the
256 test suite to the Example directory. Are concerned:
261 - TestWriteSimple.cxx
262 * Test/CMakeLists.txt: added some comments on reasons for black listing
263 image gdcmData/oldACR00001.ima
265 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
266 * Test/CmakeList.txt: removed the following from black list (to be coherent
267 with removal from gdcmData):
268 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
269 - gdcm-MR-PHILIPS-16.dcm
271 Added the following because after last cvs update, they cause
272 ctest -R TestReadWriteReadCompare
274 - gdcm-MR-SIEMENS-16-1.acr
276 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
277 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
278 new comments in this file) we temporarily (sigh) move to a weaker
280 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
281 we don't need to black list the following images anymore:
282 - 8BitsUncompressedColor.dcm
284 - US-PAL-8-10x-echo.dcm
285 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
286 fixes and the beautified code ;-)
287 This fixes the bug introduced in version 1.42 (when beautifying)
288 that made the parsing of 8BitsRunLengthColor.dcm unproper.
289 Note: ctest was blind to this bug (this means we need to still
290 improve the test suite). The bug could be detected by using
291 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
293 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
294 and by displaying the (garbage) produced file temp.XDCM...
296 2004-06-29 Jean-Pierre Roux
297 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
298 - replace by uggly but working old code :-(
299 A lot of things should be OK again.
300 It's really urgent to have a test suite that *tests*,
301 to prevent Frog's beautifying sessions to break all the stuff
302 (twice, withing a fortnigh ...)
304 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
305 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
306 redundancy) to added Test/TestReadWriteReadCompare.cxx
307 * Test/CmakeList.txt: because the compare test of
308 Test/TestReadWriteReadCompare.cxx fails, the following images are
309 black listed: - 8BitsUncompressedColor.dcm
311 - US-PAL-8-10x-echo.dcm
312 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
313 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
314 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
315 and ad-hoc kludge. This kludge is now removed, and on encountering
316 such an image (OB field brain damaged) we set errno. Then in
317 ::FindDocLength() we "fix" the length as being ALL what remains
318 in the file (until EOF). We then proceed, hoping for the best...
319 This fixes a SegFault in ShowDicom when trying to write such an
321 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
322 (because TestWriteRead breaks on it, after a non conformal commit?).
323 ctest now runs properly, except for MakeDicomDir (which was allways
324 broken) and the Python related stuff (still not fixed).
326 2004-06-24 Jean-Pierre Roux
327 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
328 FIX : Test/TestReadWrite now iterates on all the file names
329 (instead of infinite loop)
330 ENH : Test/TestWriteRead now iterates on all the file names
332 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
335 2004-06-24 Jean-Pierre Roux
336 FIX : - now Write drops LUT Descriptors and LUTs (if any)
337 when SamplesPerPixel =3
338 - now Write is no longer confused by
339 'BitsAllocated = 12" and 'BitsStored=12"
340 - "UN" value representation Elements are now written correctly
341 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
342 ENH : - now gdcmHeader has its own Write methods
343 (in order to split the job that has not to be done
346 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
347 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
348 loop on the same image until memory went out.
349 Note: this means we still have gobs of memory loss in PrintDocument
350 * src/gdcmDocument.cxx: fixes problem on parsing on file
351 gdcmData/16BitsJpegLosslessGrayScale.dcm.
353 2004-06-24 Jean-Pierre Roux
354 FIX : Write - All the Sequences and Sequence Item are now written
355 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
356 is added a the end, when necessary.
357 - A lot of brain-damaged images, that were read correctly are
358 now written correctly
359 - length compatible BinEntry are now loaded correctly
360 (even for odd groups)
361 Note : only Explicit Value Representation was checked.
362 (question : is implicit VR really necessary for gdcm ?)
364 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
365 * DEVELOPPER: added a proposition of coding style.
366 * src/gdcmDocEntry.h: removed every inline declaration (for test of
369 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
370 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
371 Use the gdcmDocEntry::Print() and Write() instead.
372 * src/gdcmDocument.cxx: bug fix.
374 2004-06-22 Jean-Pierre Roux
375 FIX : gdcmDocument.cxx
376 - Now we do recognize the JpegLossLess format (there was a misstyping in
377 code 'beautyfication' :-(
378 - Now we automaticaticaly load the Luts, if any
380 2004-06-22 Jean-Pierre Roux
381 In order : to write Sequences, whatever their imbrication level,
382 : to allow user to create his own Sequences
383 a lot of modif where necessary (adding, moving, or virtualising methods)
385 WARNING : save your own sources *before* cvs up !
388 ADD virtual void Write(FILE *fp, FileType filetype);
391 ADD virtual void Write(FILE *fp, FileType filetype);
392 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
395 ADD virtual void Write (FILE *fp, FileType filetype)=0;
396 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
397 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
398 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
399 ADD std::string GetEntryByName(TagName name);
400 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
402 std::string vr = "unkn",
403 std::string fourth = "unkn",
404 std::string name = "unkn");
405 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
406 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
407 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
408 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
409 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
410 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
411 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
412 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
415 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
416 ADD virtual std::string GetEntryByName (TagName tagName);
417 ADD virtual std::string GetEntryVRByName (TagName tagName);
418 REM virtual bool Write(FILE *, FileType);
419 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
420 FILE *_fp, FileType type);
421 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
422 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
423 REM virtual bool WriteEntries(FILE *_fp,FileType type);
424 REM virtual std::string GetEntryByName (std::string tagName);
425 REM virtual std::string GetEntryVRByName (std::string tagName);
426 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
427 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
428 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
430 std::string vr = "unkn",
431 std::string fourth = "unkn",
432 std::string name = "unkn");
433 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
434 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
435 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
436 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
439 ADD virtual void Write(FILE *fp, FileType filetype);
442 ADD virtual void Write(FILE *fp,FileType filetype);
445 ADD virtual void Write(FILE *fp, FileType filetype);
446 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
447 REM std::string GetEntryByNumber(guint16 group, guint16 element);
448 REM std::string GetEntryByName(TagName name);
451 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
453 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
454 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
455 The default constructor invoked by the line
456 gdcmHeader *f1 = new gdcmHeader( header );
457 was gdcmHeader::gdcmHeader(bool) instead of the expected
458 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
459 Hence the parsing wasn't executed... See also below.
460 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
461 as explicit constructor didn't do the trick to fix the above problem.
462 Could anyone explain why ?
463 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
464 properly calls gdcmValEntry::Print() (that was weed out from
465 code related to gdcmBinEntry).
467 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
468 * In order to fix memory leaks:
469 - Test/TestWriteSimple.cxx: added cleaning of free store through
471 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
472 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
473 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
474 (through the call to ::AddDicomDirMeta()) or the destructor
475 would crash when deleting uninitialized ::metaElems].
476 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
477 - src/gdcmDocument.cxx:
478 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
480 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
481 was causing memory leaks.
482 - src/gdcmSQItem.cxx:
483 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
484 cleanly handled with polymophism: sorry but my milage is low).
485 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
486 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
487 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
488 This avoids SegFaulting.
489 - src/gdcmSQItem.h: coding style.
491 - Test/TestWriteSimple still severely sucks. The output image content
492 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
493 damaged when displayed with vtkgdcmViewer.
494 - on memory leaks: TestWriteSimple leaks really less (see entry
495 of 2004-06-18 in Changelog file for the call to valgrind).
496 - on segfaults: ctest now passes all the tests but one (no more
498 * Erroneous leading white fix:
499 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
500 white[s] (as opposed to from >> xxx, that removes it [them].
501 - src/gdcmTS.cxx: ditto.
502 - gdcmPython/testSuite.py: dirty related kludge removed.
503 * src/*: remaining references to gdcmParser removed.
504 * src/*[cxx|h]: added copy[way]left header.
507 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
508 * In order to fix writing of dicom files:
509 - Test/TestWriteSimple.cxx: a simpler example of writing.
510 - Test/CMakeLists.txt changed accordingly.
511 - src/gdcmDocument.cxx:
512 -- The destructor now recursilvely removes potential sequences.
513 -- Bug fix in ::IsJPEG2000()
514 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
515 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
517 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
518 to only declared) and build on top of
519 ::GetDocEntryByNumber(guint16, guint16).
520 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
521 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
522 for usage in destructor and treatement of promotion in
523 ::ReplaceOrCreateByNumber().
524 - src/gdcmSQItem.cxx: destructor should better handle his job.
525 Test/TestWriteSimple now runs (or at least it DOES something).
526 * We can now start hutting memory links. A good starting point is:
527 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
528 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
529 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
531 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
532 * Valgrind note: after Mathieu Malaterre teached me how to read
533 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
535 Using gcc, you can force the STL to use malloc and to free memory as
536 soon as possible by globally disabling memory caching.
537 With 3.2.2 and later, you should export the environment variable
538 GLIBCPP_FORCE_NEW before running your program.
539 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
540 simply vanish (it is still not clear to me, whether this means that
541 STL std::string leaks or if valgrind believes it leaks...).
542 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
543 running bin/gdcmTests makeDicomDir):
544 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
545 - Test/makeDicomDir.cxx now properly traps empty lists and returns
547 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
548 SegFaulting (I drowned in DicomDir related code when trying to
549 understand why the list is empty...).
550 * src/gdcmDocument.h: first BSD license header try.
551 * Doc/License.txt added.
553 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
554 * src/gdcmDocument.[h|cxx]:
555 - Clean up of the Transfer related predicates. They are now all based
556 on new method isGivenTransferSyntax, that (should) handle properly
558 - general clean up, simplification, and coding style.
559 - Specific clean up of Parse7FE0() (umproperly named actually).
560 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
562 2004-06-14 Jean-Pierre Roux
564 - fix the display of Sequence Delimitor (SQDepthLevel pb)
565 - fix the display of SQItem ordinal number
566 - add the GetSQItemByOrdinalNumber method
567 - remove some useless never written private methods
569 2004-06-14 Jean-Pierre Roux
571 - adding a constructor taking a gdcmDocEntry as an input param
572 - ReplaceOrCreateByNumber now returns :
573 a gdcmBinEntry * if a Binary (void *) value is passed as a param
574 a gdcmValEntry * if a string value is passed as a param
576 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
577 according to the param type (no longer sets a gdcmDocEntry)
578 - GetValEntryByNumber, GetBinEntryByNumber added
579 - NewValEntryByNumber and NewBinEntryByNumber added
581 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
583 - GetSQItemNumber and SetSQItemNumber added, to provide
584 a (relative) Item identier inside a given Sequence
585 \warning : some pb remaining around this number
587 - AddEntry now takes the Item Number as a param
589 - adding a constructor taking a gdcmDocEntry as an input param
591 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * Memory leak hunt with the following command:
593 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
594 --show-reachable=yes gdcmTests PrintDocument
595 It looks like many (all?) leaks are due to the STL (or a bad usage
596 of the STL. The lines producing the leaks now have a comment with
597 a "MEMORY LEAK" tag: you can retrieve them with
598 grep "MEMORY LEAK" src/*
599 Here are two typical examples which I can't help fixing:
604 char * test = "babo";
605 name = test; //// <--- valgrind detects 960 bytes lost in
606 //// call to std::string::operator=(char const*)
607 name.clear(); //// Doesn't help !
615 std::cout << "Type a bunch of characters followed by RETURN: ";
616 getline(std::cin, line); //// <--- valgrind dectects a loss
617 //// of 1320 bytes in call to
618 /// std::basic_istream<>& std::getline<>
624 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
625 * src/gdcmHeader.[cxx|h]:
626 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
627 and related, moved away to gdcmDocument.
628 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
629 the corresponding protected accessors of inherited class
630 gdcmDocument, removed ! As a consequence gdcmFile had to be
631 declared friend of class gdcmDocument (see below).
632 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
633 - Clean up of undefined or unused methods.
634 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
635 account the changes to gdcmHeader.h).
636 * src/gdcmDocument.h:
637 - gdcmFile is now a friend class (in order to take into account the
638 changes to gdcmHeader.h).
639 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
640 (see changes to gdcmHeader.h).
641 - Accessors (reading on the form GetEntry*) are now public.
642 - Clean up of undefined or unused methods.
643 * src/gdcmDocument.cxx:
644 - adaptation to changes to gdcmDocument.h
645 - ::OpenFile now writes a verbose message when file cannot be opened.
646 - some std::string properly set to VRKey
647 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
648 references to gdcmDocument.
649 * Test/TestFindTags.cxx: changed accordingly to above changes.
650 * gdcmPython/testSuite.py: adapted to renaming of acr files in
651 cvs repository gdcmData.
653 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
654 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
655 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
656 conflicts with gdcmValEntry::voidArea.
657 * src/gdcmValEntry.cxx: unmatching comment wiped out.
658 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
659 Value representation between StringRepresentable and BinaryRepresentable.
660 * src/gdcmDocument.cxx:
661 - method ParseDES: proper indentation restored and usage of
662 gdcmVR::IsVROfGdcmStringRepresentable wired in.
663 - method LoadDocEntry: the fingerprint left in the SetValue() of
664 unloaded entries (length > MaxSizeLoadEntry) had curiously been
665 removed. Reverting to previous code segment with the proper
666 dynamic_cast< gdcmValEntry* >.
667 Note: this was (partially) breaking the python test suite
668 (gdcmPython/testSuite.py) that made usage of the above
669 fingerprint to check presence of "Pixel Data".
670 * src/gdcmDocEntry.h: coding style.
671 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
672 now taken into account.
673 * gdcmPython/gdcm.i: adaptation to the new internal representation
674 of gdcm (exit gdcmParser, hello gdcmDocument).
675 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
677 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
678 anymore, but instead prints the loaded Python dictionary.
679 * .... alas, the python testSuite is still broken.
681 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
684 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
685 * src/gdcmUtil.h : export methods
687 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
688 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
690 * Initial addition of automatic python testing
691 * Initial addition of automatic image comparison
693 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
694 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
695 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
697 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
698 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
699 * Test/ShowDicom.cxx : bug fix for msvc compilation
700 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
702 2004-05-04 Jean-Pierre Roux
703 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
704 new concepts (and new classes) :
705 a 'gdcmDocument' is composed of a set of Doc Entries, that are
706 - elementary gdcmDocEntries (former gdcmHeaderEntries)
707 - Sequence Doc Entries (gdcmSeqEntries)
708 a Sequence is composed of Items.
709 Each item is a set of Doc Entries (this is recursive)
710 The non uniqueness of the 'Dicom tag' is due to this recursivity
711 (never taken into account)
712 Our unability to add a new 'entry' in the header
713 at the proper location (neither in the H-Table (map or multimap),
714 nor in the Chained List is also due to this recursivity.
715 Don't try, right now, to use/modify/compile these new sources :
717 We just commit all the stuff, 'as is', in order not to loose it.
719 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
720 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
722 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
723 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
724 file prefix (SetFilePrefix)
726 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
727 * Add a new test: ShowDicom, for now this is just the c++ version of
728 checkRead.sh, later it will be able to compare the image read against a
730 * Replace the DEBUG on the stack with a global entry in cmake interface:
731 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
733 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
734 * Add an example subdir, with a real example on how to read + write a
737 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
738 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
739 * Doc/CMakeLists.txt: the main page is now properly differentiated
740 between the developper and user version.
741 * Doc/doxygen.config.in: dropped search related obsolete flags
742 * src/gdcmParser.h, gdcmHeader.h: doxygenation
744 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * DEVELOPPER: added some helpfull comments for compile/test/install
748 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
749 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
750 src directory, now generated in the build dir.
751 2. Tests as mentionned smarter
753 4. Add a new method in gdcmDict that return the PubDict by name
754 this is interesting for 3rd party lib like ITK,
755 where we could set the institution name / patient name...
757 * ENH: 1. Now the test suite is working for real
758 2. All binaries are now output in the gdcm-bin directory
759 (this was not true before)
761 2004-04-28 Jean-Pierre Roux
762 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
763 SeQuence indented printing of Dicom Header.
764 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
765 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
766 Computation of SQDepthLevel is now part of gdcmHeader constructor
767 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
768 tree-like structure of a Dicom Header.
769 * FIX Test code cleaning
771 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
772 * ENH: Adding automatic testing
773 1. Need a DartConfig.cmake to submit to public
774 2. Add a test driver gdcmTest.cxx
775 3. gdcmTestMain, an helper for the main test driver gdcmTest
776 4. Files in Test don't have a main anymore, this becomes interesting
777 when we add more and more tests, thus dsw don't have to load
779 * ENH: Adding a GDCM_DATA_ROOT for testing
780 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
781 one file instead of seven + some small cleanup
783 2004-04-22 Jean-Pierre Roux
784 * ENH Minor changes to the Print() methods.
785 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
786 Header printing. Example given with :
787 > PrintHeader fileName 2 new
788 (SQ based tree-like structure still to be done for the Header ...)
790 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
791 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
792 1. I have added some unsigned where needed
793 2. Some function parameter not used -> (void)
794 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
795 4. g++ don't like character '\' in comment
796 5. #define jpeg_create_decompress jCreaDecompress
797 this really need to be fixed
798 6. virtualize destructor of gdcmObject ... leakage
799 7. sscanf(g->first.c_str(),"%x",&gr_bid);
800 this also really need to be fixed
801 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
802 remove compression file
803 (as we only do decompression, right ?)
804 * ENH: Change malloc/calloc/free with c++ equivalent
806 2004-04-21 Jean-Pierre Roux
807 * FIX gdcmHeaderHelper::GetXSpacing
808 when a single value is found (bug ?), xpacing is now
809 defaulted to yspacing
811 2004-04-19 Jean-Pierre Roux
812 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
813 * ENH add parameters :
814 bool exception_on_error = false,
815 bool enable_sequences = false,
816 bool ignore_shadow = false
817 to the gdcmFile constructors to be full gdcmParser compliant
818 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
819 to allow reading of PAPYRUS 3.0 files
821 2004-04-06 Jean-Pierre Roux
822 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
824 2004-04-02 Jean-Pierre Roux
825 * ADD : Test/checksequence.sh, for a general recap on SQ pb
826 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
827 for Philips spurious Tag fffe|0000 while rewritting Dicom files
829 2004-03-30 Jean-Pierre Roux
830 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
831 for ACR file, written out as DICOM files (hope so...)
833 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
834 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
835 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
836 moved to base class gdcmParser and only the specialisation is kept
838 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
839 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
840 already does the job.
841 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
842 (to be consistent with gdcmParser::WriteEntries).
844 2004-03-30 Benoit Regrain
845 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
846 upate of the object's instance. It's passed to 2 in the unfavorable
847 case : one in the ExecuteInformation, one in the ExecuteData
849 2004-03-29 Jean-Pierre Roux
850 * ENH : Check on file type to be written moved
851 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
852 * FIX : gdcmObject::ResetBoundaries now stops properly
853 when end-of-list is reached
854 : gdcmVersion modified (as Benoit Regrain asked)
856 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
857 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
858 * src/gdcmUtil.cxx: added forgotten iostream include.
859 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
860 equivalent to ExplicitVR in existing code).
862 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
863 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
864 now contains all the gdcmGlobal related code.
865 * minor coding style and doxygenation changes.
867 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
868 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
869 now contains all the Debug related code.
870 * minor clean-up of includes in src/*.cxx
871 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
872 CreateCleanString) removed.
873 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
874 * Doc/DoxyMainPageUser.txt added.
875 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
876 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
879 2004-03-24 Jean-Pierre Roux
880 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
882 2004-03-23 Jean-Pierre Roux
883 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
884 big endian made volumes
885 * ENH Now gdcmParser constructor and destructor are protected to forbid
886 end user to instanciate class gdcmParser
887 (only gdcmHeader and gdcmDicomDir are meaningfull)
889 2004-03-22 Benoit Regrain
890 * FIX : src/gdcmDicomDir.cxx : make windows compilable
891 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
892 gdcmSerie to gdcmDicomDirSerie
894 2004-03-19 Jean-Pierre Roux
895 * ENH Now the tree-like structure describing a DICOMDIR comming from
896 an already existing DICOMDIR file is consistent with
897 the home-made tree-like structure build ex-nihilo
898 or build from the files held (recursively) in a Directory
899 functions gdcmDicomDir::CheckBoundaries()
900 gdcmObject::SetBoundaries() added
902 2004-03-17 Jean-Pierre Roux
903 * REM (Eric Boix bug) : removal of meaningless
904 gdcmDicomDirImage::NewImage function.
905 * FIX now file names and directory name are written properly in the
907 * FIX now gdcmDicomDir constructor may be call without any trick
910 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
912 of gdcmDicomDirImage::NewImage as empty function.
914 2004-02-28 Jean-Pierre Roux
915 * ENH add gdcmDicomDir:NewPatient
916 add gdcmDicomDirPatient:NewStudy
917 add gdcmDicomDirStudy:NewSerie
918 add gdcmDicomDirSerie:NewImage
919 to allow making gdcDicomDir object.
920 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
921 (as opposite to the gdcmHeader chained list)
923 2004-02-11 Benoit Regrain
924 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
925 when using from python
927 2004-02-10 Benoit Regrain
928 * FIX : bug fix in the gdcmDirList for the recursivity in directories
929 * FIX : in gdcmDicomDir when the directory is empty
930 * ENH : add callback and methods to get the progression of dicomDir
933 2004-02-06 Jean-Pierre Roux
934 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
935 - GDCM_META added to gdcmDicomDirType
936 - class gdcmMeta created
937 * ENH : - A brief summary is now displayed at the beginning of
938 'testDicomDir' to help disaster magnitude estimation
939 * REM : Now useless Test/explDICOMDIR.cxx
941 2004-02-05 Benoit Regrain
942 * ENH : add methods in gdcmObject to get the hash table or the list of
944 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
945 * FIX : wrapping python for TagHeaderEntryHT
947 2004-02-04 Benoit Regrain
948 * FIX : even length for some strings when writting the dicom dir
949 * FIX : sort the images in the dicom dir
950 * FIX : Bug fix for python use of dicom dir
951 * ADD : a python demo
953 2004-02-04 Jean-Pierre Roux
954 * FIX : Final solution (?) for icone embedded images
955 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
956 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
957 add groups 6002, 6004, 6006, to allow 'clean' parsing of
958 gdcmData/gdcm-MR-SIEMENS-16.acr1
959 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
960 to make full checking easier
962 2004-02-04 Benoit Regrain
963 * FIX : WriteEntries : coding style & logic in parameters
964 * FIX : Set the elements to create the DicomDir in a dictionary file
966 2004-02-03 Benoit Regrain
967 * gdcmDirList : to parse a hard drive directory in recursive (or not)
968 * gdcmDicomDir : add the load of directory
969 * Bug fix and print add-on
971 2004-02-03 Jean-Pierre Roux
972 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
973 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
974 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
975 * FIX gdcmParser.cxx : 'group length' elements are now considered
976 as integers, even for shadow groups, when file is Implicit VR
978 2004-02-02 Jean-Pierre Roux
979 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
981 of the last synonym :-(
982 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
984 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
985 * FIX taking into account the possible 7fe0,0010 multiplicity
986 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
987 to allow removal of references to 7fe0,0010, to deal with
988 ACR-NEMA images, when 0028,0200 is meaningfull
990 2004-01-31 Jean-Pierre Roux
991 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
992 no longer writes 'Un' on disk
993 * FIX SQ elements with actual length are now dealt with corectly
994 * FIX gdcmFile::WriteBase make the difference, for color images, between
995 the length (for Palette expanded images)
996 and Raw Length (non expanded image + Palette)
997 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
998 (that broke Write). Replaced by UL.
999 Aware user will reload the field if he
1000 thinks it's necesssary
1002 2004-01-30 Jean-Pierre Roux
1003 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1004 when 'dirty Acr' is found, to be compliant with the new
1005 IsReadable() methods.
1007 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1008 (no DOUBLE images in kosher DICOM,
1009 but so usefull for people that miss them ;-)
1011 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1012 DICOMDIR related utilities (not checked as Windoze compliant)
1014 2004-01-28 Jean-Pierre Roux
1015 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1017 2004-01-27 Jean-Pierre Roux
1018 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1019 to allow skipping the shadow elements, to save memory space.
1020 The TRUE value for this param has to be used
1021 with a FALSE value for the 'enable_sequence' param.
1022 ('public elements' may be embedded in 'shadow Sequences')
1023 * gdcmHeader methods now deal with 'embedded icones images' in the header
1024 (even when an 'icone image sequence' is announced by the
1025 element (0x0088,0x0200), but there is NO icone at all ...
1027 * gdcmHeader sometimes Image Location value doesn't follow
1028 the supposed processor endianity (see gdcmData/cr172241.dcm).
1031 * gdcmHeader add the method
1032 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1033 to get *all* the Header Entries with the same tag.
1034 GetHeaderEntrySameName is probabely *useless*
1035 (no meaning : Name is *not* an identifier within the Dictionnary)
1037 2004-01-26 Benoit Regrain
1038 * Bug fix in the print of hexadecimal representations. Remove long fields
1039 in the print and add a third level of print to print them
1041 2004-01-23 Benoit Regrain
1042 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1043 * Bug fix on test suite after remove the strip made on not string fields
1044 * Split the IsReadable method between gdcmParser which test that the file
1045 is dicom and gdcmHeader which test that it's an image file
1047 2004-01-22 Benoit Regrain
1048 * DicomDir : clean code, add methods, set variables in protected or private
1049 * gdcmUtil : bug fix for the clean string method
1051 2004-01-19 Benoit Regrain
1052 * Add the use of shadow dictionaries
1053 * bug fix and coding style
1055 2004-01-19 Benoit Regrain
1056 * src/gdcmFile.cxx : bug fix concerning the close of file
1057 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1058 * Add the update of header entries using the shadow library
1060 2004-01-19 Benoit Regrain
1061 * removal of file gdcmHeader2.cxx
1062 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1063 inheriting from gdcmParser. This split is to prepare the integration
1064 of dicom dir parsing
1065 * bug fix under python
1067 2004-01-16 Jean-Pierre Roux
1068 * REM removal of class gdcmHeaderEntrySet
1069 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1070 * ADD add file gdcmHeader2.cxx
1071 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1073 2004-01-15 Benoit Regrain
1074 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1075 entries created while parsing the header. Thus, they will be destroyed
1076 when the gdcmDictSet will be destroyed
1077 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1080 2004-01-15 Benoit Regrain
1081 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1082 made a fatal error because of the memory release at the end of program.
1083 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1084 some memory and vtk seems to have some problems with that.
1085 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1087 2004-01-14 Benoit Regrain
1088 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1089 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1090 * src/*.[h|cxx] : make changes due to class name changes
1091 * gdcmPython/demo/*.py : bug fix due to method names
1093 2004-01-13 Benoit Regrain
1094 * src/*.[h|cxx] : coding style
1095 * vtk/*.[h|cxx] : coding style
1097 2004-01-13 Benoit Regrain
1098 * gdcmPython/testSuite.py : test the readable flag of file for tests
1099 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1100 It's lied to the stl compilation by MSVC (windows, always windows...)
1101 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1103 2004-01-12 Benoit Regrain
1104 * src/*.h : add comments
1105 * src/gdcmDictSet.h : set the method BuildDictPath in public
1106 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1107 directly setted in the source code
1108 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1111 2004-01-09 Benoit Regrain
1112 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1113 * setup.py : use a reference to gdcmVERSION
1115 2004-01-07 Benoit Regrain
1116 * Modification to compile with the distutils.
1119 2003-12-10 Benoit Regrain
1120 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1121 can use a gdcmHeaderHelper to load datas
1122 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1123 made in the source code
1125 2003-12-10 Benoit Regrain
1126 * Update Windows projects and .cvsignore files
1128 2003-11-12 Jean-Pierre Roux
1129 * ENH gdcmHeader constructor has one more parameter (default value : false)
1130 that allows the user to 'go inside' the SeQuences only
1132 gdcmElValSet:Print takes it into account
1134 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1135 * ENH: Update gdcmPython/CMakeLists
1136 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1137 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1139 2003-11-10 Jean-Pierre Roux
1140 * FIX : gdcmHeader::LoadElements is now based
1141 on the ListTag listElem member,
1142 not longer on the TagElValueHT tagHt member
1143 * ENH : PrintPubElVal shows (temporarily) both results,
1144 with the tagHt member and the listElem member.
1145 (it's easier to 'see' the problems when using Printheader)
1147 * FIX : old private member LgrElem is now splitted into
1148 ReadLength : Length actually found on disk (updated only
1149 if bug fixing is necessary), for internal
1151 UsableLength : Updated by FixFoundLength, to fix a bug
1152 or to allow Parser going on.
1153 Will allow to re-write a kosher header when a SeQuence
1154 with a length (not 0000) is found
1155 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1156 because gdcmElValSet::Add does not update ListElem
1159 2003-11-07 Jean-Pierre Roux
1160 * FIX misstyping in Transfert Syntax name table
1161 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1162 when they have an actual length (not 0000 nor FFFFF)
1163 (Nobody should care of it, but DICOMDIR explorers)
1165 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1166 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1168 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1169 * ENH: vtkGdcmReader now supports LUT !
1170 (vtkgdcmViewer for now is not able to use them though)
1172 2003-11-05 Jean-Pierre Roux
1173 * in testSuite.py : new files names for checking the package
1174 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1175 that returns the pixel area size to the *aware* (vtk) user
1176 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1178 2003-11-05 Benoit Regrain
1179 * in testSuite.py : Modify the rules for checking the paths
1180 : Explicit error messages
1181 * in __init__.py : Related modif
1183 2003-11-03 Jean-Pierre Roux
1184 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1185 to be used by aware (vtk) users that want to manage
1186 LUT (and no to turn the PALETTE image into an RGB pixels one)
1187 * GetPixelType now returns 8U for 24 Bits images
1188 (vtkGdcmReader compliant)
1190 2003-10-31 Jean-Pierre Roux
1191 * Removal of *all* gdcmData images and add them again
1192 in order to loose the 'history' of un-anonymised images
1194 2003-10-31 Jean-Pierre Roux
1195 * RMV : removal of useless jBitsInJsample.h
1196 for both 8 and 12 Bits JPEG Lossy Libraries
1198 2003-10-31 Jean-Pierre Roux
1199 * ENH : Add the functions gdcmFile::GetImageDataRaw
1200 gdcmFile::GetImageDataIntoVectorRaw
1201 that act as GetImageData and GetImageDataIntoVector
1202 except the making of an RGB Plane from Gray Plane + LUT
1203 Intended to aware (vtk) users who know how to manage
1206 GetLUTRGBA return a R,G,B,A LUT if any
1207 lgrTotaleRaw gives the 'Raw' length
1208 GetImageDataRaw returns the gray Plane
1209 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1210 (They stay Grey, just like with other Dicom viewers :-(
1212 2003-10-30 Jean-Pierre Roux
1213 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1215 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1216 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1217 being coherents dicom files.
1219 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1220 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1222 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1223 * ENH: Two steps is necessary to please VC++ compiler...
1224 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1225 * ENH: Add include dir to medcon lib
1226 * FIX: only one function is being exported for now !
1227 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1229 2003-10-29 Jean-Pierre Roux
1230 * adding gdcmHeader::GetLUTRGBA
1231 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1232 --> Mathieu, the modif u're waiting for is not yet committed
1233 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1235 2003-10-27 Jean-Pierre Roux
1236 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1237 00191113.dcm DermaColorLossLess.dcm
1238 MxTwinLossLess.dcm RadBWLossLess.dcm
1239 * ENH: For version prior to vtkImageViewer2 -r 1.19
1240 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1242 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1243 * Removal of ido stuff in CMakeLists.txt
1245 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1246 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1247 * FIX: remove a call to ->Modified ... see comments
1248 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1250 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1251 * FIX: Problem with path for libvtkgdcmPython
1252 * ENH: Try adding a search script for python site-package
1253 * RMV: Remove some file from medcon lib that are not necessary
1254 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1255 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1256 * FIX: More pragma disable fro VC++,
1257 I don't think I break something as it is also disable in VTK/ITK.
1258 But it fasten debug compilation time.
1260 2003-10-23 Jean-Pierre Roux
1261 * gdcm now deals with 16 Bits Run Length Encoded images
1262 (they are compressed as 2 planes images,
1263 one for the high Bytes, the other for low Bytes)
1265 2003-10-22 Jean-Pierre Roux
1266 * Now CheckRead takes into account :
1267 - the bugged 'Leonardo' Siemens images
1268 - the XA images, sent thru the burning VPRO station
1269 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1272 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1273 * FIX: When copying a Makefile.am to CMakeLists.txt
1274 one should remove the '\'
1276 2003-10-22 Jean-Pierre Roux
1277 * in gdcmData adding a bugged 'Leonardo' Siemens image
1278 (wrong lengths in header)
1279 OK with gdcm, KO with the other viewers :-)
1280 * add a GE dlx XA image, thru the VEPRO burning station
1283 2003-10-21 Jean-Pierre Roux
1284 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1285 for a brutal checking of vtkgdcmViewer compliance
1287 2003-10-21 Jean-Pierre Roux
1288 * add the files for 'xmedcon' Jpeg Lossless library
1289 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1291 2003-10-21 Jean-Pierre Roux
1292 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1294 2003-10-21 Jean-Pierre Roux
1295 * garbage Siemens 'Leonardo' images dealt with
1296 (the patch is easy to remove)
1297 * cosmetic changes to avoid warnings
1299 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1300 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1301 no need to press 'r' now.
1303 2003-10-20 Jean-Pierre Roux
1304 * upgrade of checkRead.sh checkWrite.sh according
1305 to new Jpeg Lossless decompressor
1306 * add US.3405.1.dcm, a genuine RGB medical file ...
1307 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1308 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1310 2003-10-15 Jean-Pierre Roux
1311 * general anonymisation in gdcmData
1312 * adding the 'color files' from
1313 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1314 * adding some well knowed bugged-header images
1315 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1316 waiting for their inclusion in Python testsuite
1318 2003-10-15 Jean-Pierre Roux
1319 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1320 no longer seg faults when file is not found
1322 2003-10-14 Jean-Pierre Roux
1323 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1326 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1327 * TODO: *.in file to genereate a UseGDCM later
1329 2003-10-14 Jean-Pierre Roux
1330 * Some supposed-to-be Dicom Images have no preamble.
1331 OpenFile takes it into account
1332 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1333 * Missing elements added in dicomV3.dic
1334 (just to be affraid : have a look at
1335 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1336 and do it again next year ;->
1338 2003-10-13 Jean-Pierre Roux
1339 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1340 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1341 But there are NOT. It's fixed !
1343 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1344 * FIX: "jpeglib.h" was not found on VC++
1345 * FIX: vtkgdcm was not being installed
1347 2003-10-10 Jean-Pierre Roux
1348 * ENH : OpenFile closes the file if it *really* doesn't look like
1349 an ACR-NEMA / DICOM one.
1350 * FIX : testWrite no longer writes an empty file if the source file
1351 is not gdcm Readable
1352 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1355 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1356 * FIX: CMake generate now documentation
1357 * ENH: out of source doc build !
1358 * ENH: Generate both user and dev documentation
1359 * ENH: Should work on windows too
1360 * ENH: Only one doxygen config.in file is needed
1361 * FIX: make install should be ok now on ùnix plateform
1362 * FIX: PATH to dictionary was wrong (missing /)
1363 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1365 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1366 * vtkGdcmReader is now able to read rgb dicom file.
1367 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1368 * added a gdcmViewer to vtk test, use mouse to control
1369 window level & window width
1371 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1372 * CMake-ification of gdcm, we have now two build system
1373 * FIX: on cygwin Wsock32 doesn't exist
1374 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1376 2003-10-06 Emanuel Ollart
1377 * FIX : compilation process wad broken.
1378 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1380 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1381 * change gdcmViewer -> vtkgdcmViewer
1382 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1384 2003-10-06 Jean-Pierre Roux
1385 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1386 ( e.g : well known GE images with a wrong elem length,
1387 : Philips MRI Images with a wrong Huffman table)
1388 * still to be done : allow the reading of bugged LEONARDO Siemens images
1390 2003-10-03 Jean-Pierre Roux
1391 * Odd length strings are padded with '\0' (not with spaces,
1392 to remain compliant with already defined strings,
1393 like Transfert Syntax UID and others)
1395 2003-10-03 Jean-Pierre Roux
1396 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1397 to allow displaying RGB images (not only by affim ;-)
1399 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1400 * vtkGdcmReader is now able to read rgb dicom file.
1401 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1403 2003-10-03 Jean-Pierre Roux
1404 * A few nasty patches to allow the reading of a lot of nasty images
1405 ( e.g : well known GE images with a wrong elem length,
1406 : Philips MRI Images with a wrong Huffman table)
1407 * still to be done : allow the reading of bugged LEONARDO Siemens images
1409 2003-10-03 Jean-Pierre Roux
1410 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1412 2003-10-03 Jean-Pierre Roux
1413 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1414 to allow displaying RGB images (not only by affim ;-)
1416 2003-10-03 Jean-Pierre Roux
1417 * gdcmFile::GetImageDataIntoVector now
1418 - deals with MultiFrames MultiFragments Run Length Encoded files
1419 - deals with YcBcR (YBR_FULL) files
1420 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1421 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1423 (no sample found :-(
1425 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1426 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1427 Two reasons: - clear things
1428 - third parties acces gdcm through header files, so won't
1429 suffer anymore VC++ complains
1431 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1432 * add argv[1] in testvtkGdcmReader.cxx
1435 2003-09-24 Jean-Pierre Roux
1436 * The lines are now eigthy characters long.for
1437 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1439 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1440 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1441 char* to std::string. Thus, the use of strdup becomes useless. (see
1442 previous commis of Malaterre)
1443 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1444 before the last Malaterre's commit.
1446 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1447 * This commit should fix the Debug building under VC++, the problem
1448 was mainly a mixture of debug and release lib being loaded at startup.
1449 * I also remove a depency to a specific C function: strdup. Because I had
1450 to force the link to msvcrtd (whereas strdup is in libc).
1452 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1453 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1454 located in the gdcmCommon.h file. All use of reference of tha has been
1455 changed to now use the variable GDCM_UNFOUND.
1457 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1459 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1460 Dicom dictionary. The test suite can now be run again. Note:
1461 I'm note very happy with the " (RET)" changes. I believe this
1462 RETAINED comment should be dropped when parsing the dictionary.
1463 - PACKAGER corrected
1465 - AUTHORS updated and now in alphabetical order
1466 * Makefile.am now exports gdcm.dsw for Windoze users.
1468 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1469 * cygwin complains about missing std:: in subdir Test/
1471 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1472 * remove some methods that are now in gdcmHeaderHelper
1474 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1475 * vtkGdcmReader set spacing and origin correctly
1477 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1478 * Fix a few delete/delete[] mismatch
1480 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1481 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1482 interpretation to data given by gdcmHeader. For instance there are
1483 heuristics to get informations (look at different places).
1484 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1485 sorting DICOM images based on different strategies.
1486 * modified Makefiles accordingly.
1488 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1489 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1490 when building in debug mode
1491 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1492 src/win32/gdcmdll.dsp
1493 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1495 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1496 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1499 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1500 * src/win32/libgdcmjpeg12.dsp was not dos format
1501 * src/win32/libgdcmjpeg12.dsp :
1502 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1503 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1505 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1506 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1508 * src/gdcmFile.cxx : bug fix in affectation type
1509 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1510 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1511 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1512 symbols... future problem ?
1514 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1515 * src/win32/libgdcmijpeg12.dsp was missing
1516 * modified gdcm.dsw accordingly
1518 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1519 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1521 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1522 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1523 commit of JPR (before his hollidays to facilitate our work).
1524 * setup.py : bug fix in code. Modifications made while the last commit
1525 of JPR. The code hasn't been tested before the commit... it's so
1526 useless to make that (for best programmer that is JPR) !!!
1528 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1529 * tagged the current version as Version0_3 (i.e. version 0.3)
1531 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1532 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1533 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1534 * *.dsp : modifications to use new libgdcmijpeg8 library
1535 * setup.py : bug fix on VTKPATH variable
1536 * PACKAGER : adding all concerning windows
1538 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1539 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1541 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1542 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1543 test suite reported error.
1544 * PACKAGER file added (describes what a packager must do when
1545 packaging a new release).
1546 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1547 * configure.in: upgraded version number to 0.3.0
1548 * fixing build of rpm (through rpm -ta):
1549 - Doc/Makefile.am exports proper doxygen files
1550 - src/jpeg/libijg8/Makefile.am exports the include files.
1552 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1553 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1554 * src/gdcmHeader.h : formatting code
1556 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1557 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1558 We were obtaining error message from vtk. Now, creation of file list
1559 is made in an internal list to prevent this problem.
1560 Bug fix when output is empty.
1561 Bug fix in update of progress value. Previous commit for this was a bad
1563 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1565 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1566 * src/gdcmHeader.h : added method to get the file name
1567 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1568 files. Added method to remove all files on the input
1569 Added FIXME comment concerning the bad parsing of header made by
1570 ExecuteInformation method (in ExecuteData method)
1572 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1573 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1574 when using make instal.
1575 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1576 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1578 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1579 * setup.py : adding include dir of jpeg lib to compile all sources
1580 * */Win32/*.dsp : JPR fix for windows compilation
1582 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1583 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1585 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1586 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1588 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * setup.py is again effective on un*x (takes into account the
1590 addon of the jpeg library)
1591 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1592 * Doc/Doxy* updated (includes above enhancements)
1593 * INSTALL now points to web documentation
1595 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1596 * src/gdcmHeader.h doesn't make unnecessary reference to
1598 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1600 * src/gdcm*.[cxx|h] :
1601 - to allow compilation with gcc 3.x
1602 -- clean up of STL usage (added explicit usage of std::)
1603 -- small fixes on exceptions.
1604 Note: linking not tested !
1605 - clean of doxygen comments to avoid warnings at documentation
1607 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1608 dependent convertion).
1610 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1611 * Clean up of previous JPR garbage commit (not even commented in the
1613 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1614 - moved all jpeg related files from src to src/jpeg/libijg8, with
1615 addition/modification of Makefile.am and configure.in.
1616 - the testSuite is still brain damage (not guilty).
1618 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1619 * WrapVTK.py : modifications to get correctly vtk source files to
1621 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1622 (FileName -> Filename)
1624 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1625 * vtk/vtkGdcmReader.[cxx/h]:
1626 - UpdateProgress method should now be effective
1627 - removed the limitation on having only images loaded (as opposed
1629 - when building a stack of images/volume, a lesser number of
1630 gdcmHeader and gdcmFile instances should be used (hopefully
1631 accelerating things).
1632 - when building a stack of images/volumes, files which are not
1633 loadable (wrong path-filename, wrong permissions on existing file,
1634 or file not parsable by gdcm) are replaced with a black image
1635 in the stack (for the caller to notice the problem).
1637 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1638 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1640 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1641 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1642 between standard library (std) and vtk library (problems are found
1643 under Windows... thanks Windows !)
1645 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1646 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1648 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1650 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1651 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1653 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1654 * When compiling with distutils (see setup.py) the C++ compiler is
1655 called with different flags than the default ones (with automake).
1656 In order to fix all those warning, I compiled gdcm with the command
1657 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1658 and went for warning fixes:
1659 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1660 up from unused variables.
1661 - vtk/vtkGdcmReader.cxx: potential bug fix.
1662 * src/gdcmHeader.h: Doxygen warning cleanup
1664 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1665 * gdcmPython/gdcm.i:
1666 - typemaps correction to take into account the systematic replacement
1667 of "using namespace std" with std:: prefix e.g. std::list,
1668 std::string... (cf changes of 2003-05-21).
1669 - gdcmGlob global variable of type gdcmGlobal (defined in
1670 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1671 exported to Python a as cvar.
1672 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1673 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1674 gdcmDictSet.GetPubDictTagNames() and
1675 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1676 C++ static methods).
1677 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1678 with the above changes.
1680 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1681 * setup.py, manifest.in : bug fix under linux
1683 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1684 * Modification of setup.py to compile vtk part too. Then, we have 2
1685 wrappers which must work with same distutils. For that, we have a
1686 generic distutils in distusiltsWrapping.py ; with :
1687 - build_extWrap class to wrap generically all extensions,
1688 - ExtensionWrap base class for all wrapping extension that contains
1690 - Wrapper interface which wrap sources
1691 + In WrapSwig.py we have extension and wrapper for Swig
1692 + In WrapVTK.py we have extension and wrapper for VTK
1693 * MANIFEST.in : modifications to consider vtk directory and new python
1694 files for compilation
1696 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1697 * Added python wrappers of vtkGdcmReader vtk class (see the
1698 source in vtk/vtkGdcmReader.cxx) :
1699 - vtk/Makefile.am now builds a library
1700 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1701 python library (as opposed to _gdcm.so wich are the python
1702 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1703 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1705 - configure.in has an additional flag --enable-vtk that needs
1706 to be set to enable compilation of vtk related code, that is:
1707 + vtk/vtkGdcmReader.so and
1708 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1709 + gdcmPython/vtkgdcmPython.so (see above)
1710 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1711 be read when compressed or when HighBit + 1 != BitsStored),
1712 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1713 the usage of the python wrapper of vtkGdcmReader vtk class.
1714 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1715 * src/*.[h] all occurences of stl classes are now prefixed with
1716 std::, and all occurences of "using namespace std;" where removed.
1717 This is to avoid pollution of global namespace in included files.
1718 Apparently vtk does not avoid this pitfall: when using both
1719 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1720 collision of various stl members (principally cout...).
1721 * gdcmPython/testSuite.py now cleanly removes temprory generated
1723 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1724 comply with above changes)
1726 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1727 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1728 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1729 vtk data structure (an image Flip was required).
1730 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1731 * cosmetic changes in documentation.
1733 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1734 * src/gdcmHeader.cxx: the constructor no longer exits when an
1735 unexisting file is given as argument.
1736 * The subdirectory Data (containing all the images used for the
1737 test suite) is not part of this repository anymore. A new module
1738 containing those images is now available at
1739 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1740 with the name gdcmData.
1741 All the python scripts (including the package initialisation file
1742 gdcmPython/__init__.py) were adapated to take this change into
1743 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1745 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1746 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1747 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1748 demo of the usage of this class.
1749 Compilation of this vtk part is only done when using the --enable-vtk
1750 at configure (or autogen.sh) stage.
1752 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1753 * More memory link related corrections and documentation fixes.
1755 - maximum info is obtained with a command of the form:
1756 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1757 --show-reachable=yes PrintHeader
1758 - the remaining reachable blocks seem to come from the STL
1759 allocation scheme through the usage of map and list. It looks
1760 like this memory cannot be freed but it is not a memory leak
1761 (in fact further invocation to the STL would recollect the
1762 unused memory allthough it cannot explicitely be freed).
1763 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1764 of displaying an image parsed with gdcm and displayed with VTK.
1765 Note: some images don't seem to work e.g.
1766 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1767 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1768 Allthough this weakens the semantics, it is a ditch attempt to
1769 make gdcm more thread friendly.
1771 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1772 * Memory link hunt (by using valgrind through the command
1773 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1774 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1775 gdcmHeader::_dicom_vr.
1776 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1777 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1779 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1781 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1782 * src/Makefile.am now exports all the necessary include files at
1786 * UpdateGroupLength replaced by new one
1789 * UpdateGroupLength re-written using H-Table
1790 (named UpdateGroupLengthNew untill checks are over)
1792 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1793 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1794 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1796 - gdcmHeader::GetPubElValSet removed.
1797 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1798 UpdateGroupLength, WriteElements, Write.
1799 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1800 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1801 carried the same semantics.
1802 - src/gdcmHeaderIdo.cxx changed accordingly.
1803 - gdcmFile::WriteBase now regroups all the codes from previous
1804 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1805 - enum FileType moved to gdcmCommon.h
1806 * src/gdcmHeader.cxx AddDefault trashed
1807 * gdcmGetXSize added
1808 * getimageDataSize now calls gdcmGetXSize
1809 * Test/*.cxx changed to agree with above changes
1811 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1812 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1813 (to avoid double call by end user).
1814 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1815 by end user, since gdcmHeader::gdcmHeader now handles it.
1817 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1818 * gdcm/Doc many doxygen changes:
1819 - Doxyfile now has two different versions, DoxyfileUsers that generates
1820 the html.users end users oriented documentation and
1821 DoxyfileDeveloppers that generates the html.developper developper
1822 oriented documentation.
1823 - README changed accordingly
1824 - requirement.txt removed (old design info moved to TODO).
1825 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1826 DoxyMainPage.txt, DoxyPython.txt provide more information.
1827 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1828 be updated by simply regenerating the docs with doxygen and copying
1829 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1830 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1831 all the tests in the form "if (<map>.count() >1)" were removed.
1832 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1833 ill-formed documentation sections.
1834 * src/gdcmHeader.cxx: ditto
1836 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1837 * setup.py fixed for un*x (needed macro for stdint.h)
1838 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1839 un*ces with sh-utils test utility.
1840 * gdcmPython/demo/test.py renamed to PrintHeader.py
1841 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1842 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1843 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1844 * src/gdcm*.cxx JPR's bad inclusion fixed.
1846 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1847 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1848 * gdcmPython/demo/test.py changed accordingly.
1850 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1851 * gdcmPython/Makefile.am fixed linking against libstdc++
1852 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1853 * Swig subdir (historical tests of swig version 1.3.17++) removed
1854 * Test/testChangeEntete.cxx some lines commented out in order to make
1856 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1857 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1859 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1860 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1861 hence the user doesn't need this explicit call.
1862 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1863 i.e. LoadElements() call removed.
1864 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1865 - src/Makefile.am declares the proper flag for g++.
1866 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1867 for adding user defined new tags.
1868 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1869 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1870 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1872 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1873 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1874 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1875 src/Makefile.am : the project should properly compile and install
1876 with the autotools, included the python wrappers part.
1877 * gdcm.spec.in : added a spec file for RPM packaging.
1879 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1880 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1882 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1883 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1884 to exported to the environement (see gdcmPython/testSuite.py
1886 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1887 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1888 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1889 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1890 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1892 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1893 * gdcmPython/__init__.py doesn't crash anymore when running in
1894 in InstallMode or PreInstallMode but with an environement given
1895 value of GDCM_DICT_PATH.
1896 * src/gdcmDictSet.[cxx/h] coding style.
1898 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1899 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1900 * src/gdcm.h general comments moved to TODO, and README
1901 * src/gdcm.h should now be seen as a user commodity (including it
1902 should suffice to fully use gdcm). It is nowhere including within
1903 any of the kernel files src/*.cxx and src/*.h.
1905 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1906 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1907 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1909 * src/gdcm*.cxx only include their corresponding include file
1910 (as opposed to gdcm.h)
1911 * gdcmPython/gdcm.i changed accordingly
1912 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1913 the autogen.sh generated "make snapshot" command to work.
1914 * autogen.sh removed history related references to crea package.
1916 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1917 * distutilsSwigCPlusPlus.py work around some swig portability
1920 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1922 was done in a last ditch attempt to get setup.py _really_
1923 operationnal. The python/gdcmPython layaout add the advantage
1924 of hidding away the python related distutils specific files
1925 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1926 Alas, the src directory was out of scope (i.e. it's relative
1927 position to setup.py was ../src) which made things impossible to
1928 handle (see previous version of python/setup.py). Crossing fingers...
1930 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1931 * python/setup.py now works on Un*x. (harder than I thougth)
1932 * python/distutilsSwigCPlusPlus.py can now have include files
1933 among the list of sources.
1935 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1936 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1937 * modifications in MSVC projects
1939 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1940 * As stated by the first lines of Test/ExceptionAndPython/README, it
1941 looks like we can move back to original usage of exception within
1942 src/gdcm* and hence remove the errno stuff that was introduced
1943 as a quick and dirty fixture of this problem (added to the TODO).
1944 * Doc/Doxyfile configuration file for Doxygen and corresponding
1945 README file for usage added.
1946 * Test/testWrite.cxx added. This new test comes from a split of
1947 test.cxx that is now reverted to its original purpous i.e.
1948 testing the proper parsing of a Dicom related file.
1949 testWrite.cxx concentrates on testing the IO part of gdcm.
1950 * Test/bug1.cxx (containing a bug on WIn32) added.
1951 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1952 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1953 whose purpose is to publish the content of the TagNames of the
1954 Dicom public dictionnary were not accessible without an
1955 instance of class gdcmHeader.
1956 - those methods are now static methods of gdcmDictSet and hence
1957 require no instances at all to be invocated.
1958 - within gdcmDictSet this change required to change some method
1959 to class methods (i.e. are now static) among which SetDictPath
1960 (renamed to BuildDictPath) and LoadDefaultPubDict.
1961 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1962 the above changes by calling the new method classes of gdcmDictSet.
1963 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1964 the above to be effective.
1965 * python/gdcmPython: in order to wrap properly the above changes
1966 for Python, swig version now needs to be > 1.3.17.
1967 * python/gdcmPython/Makefile fixed to adapt itself to new
1968 configure/make shema introduced by Johan Montagnat (thanks for the
1969 contribution). Alas this Makefile cannot be turned into a proper
1970 Makefile.am without some heavy changes in the configure.in
1971 (for python dectection).
1972 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1973 now avoids publishing the empty entries.
1975 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1976 * python/setup.py : bug fix concerning install under windows
1977 ExtraPath reused :-P
1978 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1980 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1981 * Dicts/dicomV3.dic : remove double spaces !!!
1982 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1983 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1986 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1987 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1988 method. Doxygenation.
1989 * src/gdcm.h clean up of JPR spurious comments.
1991 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1992 * python/distutilsSwigCPlusPlus.py now properly collects the
1993 shadow classes generated by "swig -c++" (gdcm.py in our case)
1994 when using "python setup.py install".
1995 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1996 reexports the working classes.
1997 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1998 by the classical C errno scheme. This is to prevent an obscure
1999 behavior of the python wrappers when importing wxPython.wx prior
2000 to gdcmPython (which ended up in an abort call). An illustration
2001 of this oddity can be found in the Test/ExceptionAndPython
2002 subdir (see the README file). This problem probably due to
2003 an combination of g++ and dynamic loading.
2004 * added Test/ExceptionAndPython (see above)
2006 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2007 * Changed the layout of the python part to avoid bloating main
2008 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2009 i.e. the distutils arsenal. All the python related stuff is
2010 again in a python subdir, but the package itself is now in
2012 * setup.py was cleaned up:
2013 - pythonIncludePath removed
2014 - python setup.py bdist target is now functional.
2015 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2016 collision with other packages). gdcmPython/demo/*.py changed
2019 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2020 * python subdir moved to gdcmPython (preparation of distutils packaging).
2021 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2022 distutils installer is operational.
2023 * - gdcmPython/__init__.py now properly loads the swig generated
2024 shadow classes (from gdcm.py).
2025 - gdcmPython/demo/*.py changed to import the package gdcmPython
2026 instead of gdcmPython/demo/load.py.
2027 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2029 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2030 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2031 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2032 entries within the associated public Dicom dictionary resp. the same
2033 information but sorted by the fourth field (PAT, IMG, DIR) of the
2035 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2036 are now in the "???" group.
2037 - python/gdcm.i changed accordingly,
2038 - python/demo/printGroupedPublicDict.py added, that gives an example
2039 of the above new functionalities in Python.
2041 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * src/gdcm.h, gdcmHeader.cxx:
2043 - historic references to glib's g_malloc and g_free (#defined)
2044 were definitively removed.
2045 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2046 * src/gdcmElValSet.cxx:
2047 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2048 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2049 - GetElValue(string) renamed to GetElValueByName.
2050 - Added GetElementByName(string).
2051 * src/gdcmHeader.cxx: added
2052 - GetPubElValRepByNumber(guint16, guint16)
2053 - GetPubElValRepByName(string)
2054 - GetShaElValRepByNumber(guint16, guint16)
2055 - GetShaElValRepByName(string)
2056 - GetShaElValByNumber(guint16, guint16)
2057 - GetShaElValRepByName(string)
2058 - GetElValRepByNumber(guint16, guint16)
2059 - GetElValRepByName(string)
2060 - GetElValByNumber(guint16, guint16)
2061 - GetElValRepByName(string)
2062 * Doc/requirements.txt added.
2064 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2065 * Test/Makefile building now depends on the one of libgdcm.so
2066 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2067 pixel data) aware which enables finding the address (offset) of
2068 the pixel data of JPEG encoded DICOM files. This leaves only a single
2069 file in the testSuite whose pixel data address (offset) is unknown.
2070 * python/testSuite.py changed accordingly.
2072 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2073 * VC++ has some strong limitations when working with the STL, as stated
2074 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2075 "Also note that some STL containers (map, set, queue, list, deque)
2076 cannot be exported. [...]
2077 Some STL classes contain nested classes. These classes can not
2079 This is caused by a designed limitation that once a template
2080 class is instantiated, it can not be re-instantiated and
2082 Since our usage of map<> is ubiquitous in gdcm, this "designed
2083 limitation" of VC++ is a pitfall.
2084 Hence the Python wrappers of gdcm cannot be incrementally linked
2085 against the c++ dynamic library. The dirty but only workaround is
2086 to forget about incremental link of dynamic libraries and to generate
2087 the Python wrappers library with the inclusions of the underlying C++
2089 The following modifications concern this matter on Win32/VC++:
2090 - wrapping python correct with standalone wrapped dll (don't use separate
2091 dll under windows !!!!)
2092 - python21_d debug mode enabled (ask Frog how to use it :-)
2093 - NO problem with having an STL member of class for example string in C++
2094 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2095 - Python test of dcmlib in Python is ok under windows on a large set
2097 * removed glib references
2098 * typedef's inserted in gdcm.i for correct swig type management
2100 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2101 * python/demo/*.py load.py extracted from test.py. Added explore.py
2102 that only displays required tags and testAll.py that parses all
2103 the files of the testsuite without using unittest.
2104 * python/testSuite.py other additional test on new files added.
2105 * Data/* new test files added accordingly to the testSuite.
2106 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2107 the vr in the file differs from the one of the dictionary.
2109 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2110 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2111 values, but limits itself to values which are below a user specified
2112 size (by default 1024 bytes).
2113 * python/gdcm.i : elements not loaded (because their size is above the
2114 user specified treshold) are exported with their TagKey as key of the
2115 python dictionary. This enables the testsuite to make some checks
2116 on the unloaded elements (since we have their offset and size).
2117 * python/testSuite.py
2118 - now tests for the existence and proper value of the pixel data
2119 - two new examples added.
2120 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2122 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2123 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2124 aware. See the strategy comments in gdcmHeader::FindeLength().
2125 * Test/test.cxx now accepts a filename as first argument.
2126 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2127 * python/testSuite.py changed to integrate test on above files.
2129 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2130 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2131 the vr was also RET.
2132 * python/testSuite.py more tests added.
2134 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * python/testSuite.py unittest test suite added (uses Data)
2136 * Data/* dcm and acr files for the test suite.
2137 * glib dependance removed from un*x version. We now use ISO C99
2138 7.18 Integer types (see stdint.h)
2139 - python/Makefile, src/Makefile src/gdcm.h
2140 * src/ when an explicit vr (like dicom files) suddenly poped an
2141 implicit element we use to mark the underlying DictEntry of the
2142 concerned ElValue with "Implicit". This strategy was damageable
2143 too the public or provite dictionaries, since some of their vr
2144 would be changed. Since Header::FindLength heavily relies on the
2145 detection by Header::FindVR of falsely explicit elements, I
2146 added an extra ImplicitVr member to ElValue (boolean).
2147 The rest of the changes we the necessary adaptations.
2149 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2150 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2152 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2154 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2155 * Adaptation for porting to VC++:
2157 o forced to use std namespace (for string to be known)
2158 o all class use __declspec export style on WIN32
2159 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2160 (in stdlib.h on Win32 but in std:: for gcc)
2161 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2162 variable GDCM_DICT_PATH.
2163 * src/gdcmHeader.cxx verbose comments made discrete.
2165 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2166 * python/gdcm.i: added a typemap that converts a C++ hashing table
2167 to native Python dictionary.
2168 * python/demo/test.py:
2169 - now uses the native dictionary for exploration of gdcmHeader.
2170 - takes an optional filename argument (the file to parse).
2171 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2172 PubElVals hashing table.
2173 * Dicts/dicomV3.dic removed error prone trailing spaces.
2175 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2176 * Python wrapping process moved away from src/Makefile to
2177 newly created python/Makefile (as well as gdcm.i)
2178 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2179 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2180 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2181 from the environement variable GDCM_DICT_PATH (when existing).
2182 * src/gdcmDict::GetTag bug fix.
2184 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2185 * Straightforward temporary fixes for swig to build the python wrappers.
2186 src/Makefile now has a python working entry [by working we mean
2187 that we can import de shadow classes without errors].
2189 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2190 * hashtest.cxx removed (since allready in Test)
2191 * src/gdcmlib.h renamed to src/gdcm.h
2192 * src/dcm.i renamed to src/gdcm.i
2193 * src/Makefile prepared for python wrapping
2195 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2196 * src/gdcmHeader.cxx :
2197 - Parsing of header is now separated from loading of element values
2198 (see gdcmHeader::LoadElements).
2199 - general clean up of hopefully all file access (creation of
2200 ReadInt16 and ReadInt32)
2202 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2203 * src/gdcmHeader.cxx :
2204 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2206 - SetLgrElem renamed to SetLength
2207 - GetLgrElem renamed to GetLength
2208 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2209 * src/gdcmElValSet.cxx fixed both GetElValue methods
2210 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2211 due to IdoDude was cleaned out.
2213 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2214 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2215 concentrates on finding the value representation (when it exists).
2216 RecupLgr now only finds the element value length, and it avoids
2217 returning the unecessary skL (skipped length).
2218 Also, offsetCourant was simply removed (with taille_fich) since
2219 it was redundant with the File position internals (by using
2220 ftell and fseek). This also made skL (see above in RecupLgr) usage
2222 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2223 on the libido specificities which are handled through class
2225 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2228 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2229 * Truckload of changes. Parsing of header is barely functional
2230 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2232 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * src/gdcmHeader.cxx many addons of low level methods
2235 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2236 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2237 and _IdDcmSWAP_LONG.
2239 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * This corresponds to all the changes decided at the meeting of
2241 May 23 2002. Needless to say we are running late...