1 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
3 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
5 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
7 by an eof to prevent all bad read of the file... and in this case, the
10 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Example/Volume2Dicom.cxx : comment unused variables
12 * Test/PrintDicomDir.cxx : comment unused variables
13 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
14 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
15 method that is redondant with AddEntry.
16 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
19 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * Bug fix due my last commit (compilation under Windows).
21 * Example/Volume2Dicom : bug fix in the file and reformatting source code
22 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
24 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
26 - Remove printf / sprintf
27 - include iostream AFTER gdcm so we don't get warnings
28 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
30 - Also remove tons of include from header files, hopefully this should
31 speeup the compilation time, since it was becoming a dog slow.
32 - Remove gdcm.h as it include way too many files and slow down compilation
33 (plus it is not up to date)
34 - remove 'using namespace std' this is BAD !
36 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Remove memory leaks on the DicomDir
38 * Remove some useless datas in DicomDirObject
39 * Add usefull methods in SQItem, to be complient withe the ElementSet
41 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
44 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
46 future, with convertion)
47 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
48 and ImageDataSize values. Remove the method to get the PixelReadConverter
49 from the output of the class
51 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
54 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
56 and vtkErrorMacro use.
57 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
59 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
62 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
63 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
64 The string leaves only in the fonction. So when we make a .c_str(), we
65 get the pointeur on the first element, element that will be destroyed
66 immediately after thee instruction.
67 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
68 file has been opened : the test must be made on the content of the
69 pointer and not directly on the pointer !
72 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
74 the python part recompiles
76 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
78 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
79 X session is killed (for my computer... it seems to not be identic on
82 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
84 avoid problems (otherwise, the difference test between the visible image
85 and the reference is incorrect. If the reference is greater than the
86 screen resolution, it's produce errors).
87 Can be used for only one image. Can be used with a visible flag.
88 * vtk/vtkGdcmReader.cxx : remove commented codes.
89 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
90 under windows at compilation
91 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
93 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
95 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
97 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
98 tests on the image size X, Y, Z
100 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
102 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
103 between the class name and the file name
105 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/ : fix compilation warnings for the Write method (2 different
107 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
108 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
109 variable... create a static method in gdcm::Document to access to
110 this variable content.
112 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
114 file, to be accessed by other files (like gdcmFile). Remove commented
115 code. Move the change of the header to the gdcmFile, using the
117 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
118 To be sure of that (and simplify calls), the Write of the header now
119 gets a file name and not a file pointer (std::ifstream).
120 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
121 DocEntryArchive. Remove all open of the written file
123 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
126 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
128 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
130 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
131 some corresponding methods. Write correctly the file and check before
133 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
134 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
135 is now on RGB datas (as before my last commit
136 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
138 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
140 Add a print information of the type of the entry
141 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
142 It was in the gdcmFile, and all write have been regrouped
143 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
144 Write correctly all dicom files (in decompressed mode only at this time)
145 * Test/ : test on files are now made using Raw datas and not color datas if
147 * Example/PrintFile.cxx : add more printings
149 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * Amelioration of code, remove some code copy. For the loading of
151 BinEntry (in gdcmDocument), add the test to verify if the file is already
154 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
156 remove a DocEntry in the header (push an empty DocEntry)
157 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
158 lines. Bug fix in the initialization of the PixelConvert and the
160 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
161 use in TestCopyDicom (now this test can run under windows... but fails)
162 * Test/TestCopyDicom.cxx : amelioration of the test :
163 - test the pixels written
164 - add test points to quickly find where is the error
165 - can set a file name input and output in arguments
166 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
167 amelioration of the test output
169 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
171 all replaced DocEntry's
172 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
173 Now, each needed DocEntry to modify is duplicated, modified and inserted
174 to the header using DocEntryArchive. Thus, after save, we can restore the
175 header initial state.
177 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
180 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
182 correct to copy it. The DictEntry is specified at the DocEntry creation,
183 then, it musn't change in the time.
184 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
185 header correctly. At this time, the change is only made for the first
186 level of the Document. In the future, it might consider sequences.
187 The change is made by replacing a DocEntry by an other that is created
188 outside the class. The old value is kept. When we restore the header
189 status, the added DocEntry is deleted and replaced by the old value.
190 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
191 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
192 set the write type to explicit VR, implicit VR or ACR. Add methods to set
193 the write mode to native, decompressed or RGB (but not used at this time)
195 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
197 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
199 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
201 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
203 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
204 set because already copied when copying the BinEntry's of the header
205 * Test/TestAllReadCompareDicom.cxx : remove warnings
207 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
208 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
209 Two problems appear when doing it :
210 - with the gdcmFile : when the GetImageData method is called, the pixels
211 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
212 datas (pixels). And each structure destruct the datas when it's
213 destructed. So we have two destructions for the same datas. To solve it,
214 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
215 datas or not. If it doesn't own datas, then they will not destroyed by
217 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
218 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
219 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
220 create a double destruction of the same DocEntry's. So, to solve it,
221 the TagHT is simply cleared and the DicomDir* elements are destroyed.
222 * TODO : add an entry concerning memory leaks in the DicomDir
224 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
225 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
226 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
229 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
231 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
232 after it have been deleted
234 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * FIX: src/* fix the doxygen warnings.
236 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
237 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
238 was erroneously defined with a size of 15 instead of 16. [many thanks
239 to Jean Michel Rouet for pointing out this bug].
241 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
242 1. Finish merging JMR patch for writting DICOM from scratch
243 2. Fix -hopefully- bug with MONOCHROME and space vs null character
244 3. Use const ref when possible
245 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
246 5. A few more comments
247 6. CreateUniqueUID can now be called without parameter"
249 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
250 * ENH: Slightly bigger patch:
251 1. Getting toward full integration of JMR patch for writting dicom from scratch
252 2. Update Test to test part of this patch: CreateUniqueUID
253 3. File was not close properly in gdcmDict
254 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
255 5. Use of const ref instead of copy (speed issue)
256 6. Remove temporary (duplicate) string in TranslateToKey
257 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
258 8. Do not repeat virtual in subclasses
259 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
261 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
262 * Apply first patch toward better string comparison when dealing with broken
263 DICOM files. Essentially the string could be padded with a space instead
264 of a null character as defined by standard
266 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
268 because never used... and in the same time, that's remove some memory leaks
270 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * src/gdcmFile.cxx : now delete the PixelConvert instance.
272 * In examples and tests : change the type of image data variables from void*
273 to uint8_t*. Remmove all delete on image data variables
275 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
277 Verify the file pointer value before open the file, and if it's not null,
278 a verbose message is generated.
279 Close correctly the file when the file isn't considered dicom-like. The
280 correctly close is a call to CloseFile.
281 When closing the file pointer, test if its not null to close the file.
282 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
283 file. For an uncompressed image, the copied datas correspond in the least
284 case to the image size (calculated) or the image size specified in the
285 header. A verbose is generated if these two size mismatch
287 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
289 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
290 break under windows (with msvc6 compilation).
292 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
294 compiling with MSVC6)
296 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
297 * Bugs fix for the Windows build with VC6
298 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
299 needed (only for projects required VTK). If the VTK is included in all
300 projects, there is conflicts with the jpeg lib of vtk when compiling the
301 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
302 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
303 when compiling the gdcm_wrap.cxx file (created by the compilation of the
305 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
306 (like it's already made for the cout use). Otherwise, conflict with the
309 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
312 - comments on the DicomDir::Method related usage added.
313 - now that we use the namespace gdcm, a lot of internal classes do
314 NOT need to be wrapped anymore.
315 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
316 DicomDir::Method) new example added.
318 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
319 * Improve string manipulation. I now inforce the notion of 'DicomString'
320 A DicomString can contain as many \0 as they want
321 and it is *always* of even length.
322 We only support odd length for very rare case.
323 And in the near future this should be removed.
325 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
326 * /binary_write/ gdcm source. Now even on big endian we are writting
327 little endian. This should -heopfully- fix some tests
329 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
330 * Now the dictionary is compiled into gdcm lib. This is a default
331 behavior, thus any dic file specified is picked before failback to
332 the one comiled into lib
334 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
335 * Change internals for gdcmDict. Don't use any 'new' any more.
336 This should definitely solve any leak problem, and we should be
337 as fast as before, as long as don't modify too much the dictionary.
339 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
340 * STYLE: ivars should start with a capital letter.
341 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
342 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
344 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
345 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
346 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
347 new 2004 dictionaries added (thanks to JPR).
348 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
349 * CLEANUP_ROUND (15) for gdcmPixelConvert
350 - RLEFrame::NumberFragments is now of type unsigned int
351 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
352 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
355 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
356 * Initial work in gathering all transfer syntax accessors. clearly
357 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
358 ivars, but only one transfersyntax (class) ivar with equivalent method on
361 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
362 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
363 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
364 discussed (plus I didn't like having a 2000 lines patch not commited)
366 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
367 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
368 * CLEANUP_ROUND (14) for gdcmPixelConvert
369 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
370 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
371 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
373 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
374 anymore and hence avoids storing a copy of PixelConvert::Decompressed
375 into File::Pixel_Data.
377 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
379 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
380 * CLEANUP_ROUND (13) for gdcmPixelConvert
381 Substituted File::ParsePixelData() with PixelConvert::Print() new
383 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
384 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
385 method to those classes.
386 - src/gdcmFile.[cxx|h]:
387 -- Added a ::Print() method.
388 -- PixelConverter is now a reference instead of a member.
389 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
390 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
392 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
393 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
394 collaboration diagram and inheritance diagram should be generated with
396 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
397 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
398 pointlessly wrapped (see
399 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
400 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
401 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
402 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
403 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
404 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
405 -- File::Initialise: PixelConverter setup moved away to
406 PixelConverter::GrabInformationsFromHeader()
407 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
408 interpretation moved away to PixelConverter::BuildRGBImage()
410 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
411 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
412 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
414 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
415 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
416 displayed on Win32 when a brutal abort() occurs (because of uncatched
417 exception). See TODO new entry of this commit for more on this.
418 * TODO added new entry.
419 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
420 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
421 - HandleColor is no longer called from gdcmFile.cxx
422 - gdcmPixelConvert.cxx clean up on method arguments and internal
423 variable names for semantical coherence.
425 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
426 * Finished lossless transition, not only do we now read all lossless jpeg
427 images, without the need of the Cornwell lib, but we do read them properly now
428 * To reduce code (well to avoid code duplication), I defined a common place
429 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
430 redefine symbols. This is not prefect but this the best solution I found for a
431 compilation time jpeg option.
433 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
434 * Update jpeg ijg lib to support lossless jpeg implementation
435 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
437 * Also added a special copyright for dcmtk since we use their bugfixes.
440 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
441 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
442 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
443 matters, as stated in warning note at begining of %include section).
444 * src/gdcmDicomDir*.[cxx|h]: coding style
445 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
446 * src/gdcmJpeg8.cxx: doxygen fix.
447 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
448 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
449 from File:: to PixelConvert::.
451 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
452 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
453 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
454 - more code moved away from File:: to PixelConvert::
455 - fat setup of PixelConverter set in place in File::Initialise.
457 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
458 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
459 namespace at the file system level. So now you should convert your examples
461 gdcmHeader -> gdcm::Header
462 It would be nice if people keep in mind to no open the namespace, since it
463 allows compilation on broken plateform which were defining common symbol in
464 the standart namespace (like LP, Unknown ...)
466 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
468 The JPEG fragments are now parsed at the same stage than the RLE
469 information. All code related to JPEG is now in gdcmPixelConvert:
470 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
471 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
472 export a gdcmFile:: method. Those are simply global functions
473 (for the time being this is better than having them attach to
474 either gdcmFile:: or gdcmPixelConvert::).
475 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
476 and stores the result in a gdcmJPEGFragmentsInfo.
477 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
478 code (among other stuff) moved away from gdcmFile:; to
481 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
482 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
483 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
484 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
485 clean up of RLE related code.
486 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
487 - src/gdcmRLE.cxx removed
488 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
489 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
490 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
491 * CLEANUP_ROUND (9) for gdcmPixelConvert
492 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
493 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
494 away from gdcmFile:: to gdcmPixelConvert::.
496 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
497 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
498 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
499 This is because Parse7Fe0 used to parse the pixels to compute the
500 length. This task was passed over to FindDocEntryLengthOB() a long
501 time ago, EXCEPT I had forgotten the OW case...
502 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
503 we just recylce the code for parsing RLE fragments and computing
505 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
506 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
507 with the retired Parse7Fe0().
508 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
509 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
511 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
513 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
514 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
515 - src/CMakeLists.txt: alphabetic order reodering + new entries.
516 * CLEANUP_ROUND (4) for gdcmPixelConvert
517 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
518 to return an unused length.
520 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
521 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
522 this should be cleanner from the plane view. The iostream are erally a pain
523 to use to do simple stuff.
525 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
526 * Redo the compilation of the ijg jpeg library. Now only one source is
527 necesseray. No need to rename file by hand what so ever. CMake handle the
528 copying of the file within different directory, configure header file to
529 modify some symbol. The only addition made to ijg wasd a mangle table so
530 that symbol are different wether we are within 8bits or 12bits.
532 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
533 * Added documentation of vtkgdcmReader on Website:
534 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
535 with it's binary name).
536 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
537 the Website to be more complete.
538 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
539 doxygenated documentation.
540 - Doc/DoxyVtkGdcmReaderExamples.txt added
541 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
542 DoxyVtkGdmReaderExamples.html )
543 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
544 * CLEANUP_ROUND (3) for gdcmPixelConvert
545 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
547 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * CLEANUP_ROUND (2) for gdcmPixelConvert
549 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
551 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
552 * CLEANUP_ROUND for gdcmPixelConvert:
553 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
554 - src/gdcmPixelStuff[h|cxx] removed
555 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
556 - src/CMakeLists.txt changed accordingly
558 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
559 gdcmVersion.py moved to newly created ATTIC related
560 gdcmPython/SetupOldies/ directory.
561 * Autotools clean up:
562 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
563 - autogen.sh configure.in acinclude.m4 python.m4 removed
565 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * src/*.cxx *.h Reference to License.htm fixed to License.html.
567 * Doc/CMakeLists.txt, doxygen.config.in: fix.
568 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
570 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
571 * TODO updated with Mathieu suggestions. I proposed a template for
572 describing TODO entries and used it for new entries.
573 * Added Doc/Website/CodingStyle.html, Developpers.html,
574 DeveloppersPython.html, GdcmDataCvs.html and
575 DownloadVersion0_1.html, DownloadVersion0_3.html.
576 * Some Doc/*.txt Doxygen files (which do not really concern the
577 documentation itself, but the website) moved to html and
578 placed in directory Doc/Website:
579 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
580 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
581 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
582 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
583 * CMakeLists.txt changed accordingly.
584 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
585 DeveloppersPython.html
586 * INSTALL nows refers to Doc/Website/Installation.html
588 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
589 * Added Doc/Website directory, that contains a first raw version
592 2004-09-23 Jean-Pierre Roux
593 * FIX In order not to be poluted any longer by casting problems,
594 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
595 we can now delete[] it safely
596 * VoidArea is now called BinArea (less confusing name),
597 and all the methods called ...VoidArea... are now ... BinArea...
598 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
600 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
601 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
602 clear) TagHT, which is an inherited member of gdcmElementSet. It is
603 up to the destructor of gdcmElementSet to clean up TagHt and it's
606 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * Test/CMakeLists.txt: update to follow gdcmData renamings.
608 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
610 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * ENH: added some utility method that builds a flat dictionnary
612 holding all the Dicom entries contained in the recursive structure
613 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
615 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
616 BuildFlatHashTable() that build a flat dictionary.
617 - src/gdcmElementSet.h: added a new private GetTag() accessor.
618 gdcmDocument is now a friend of gdcmElementSet.
619 - src/gdcmElementSet.cxx: clean up.
620 - Example/FlatHashTablePrint.cxx added.
621 - Example/CmakeLists.txt changed accordingly
623 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
624 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
625 moved away from gdcmDocEntrySet (since this class is an abstract class
626 acting like an interface). SQDepthLevel and BaseTagKey are now
628 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
629 and associated accessors. Doxygenation of the class.
630 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
632 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
633 Use SQDepthLevel accessor instead. ::Print() adapted.
634 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
635 - src/gdcmDocument.cxx changed accordingly.
637 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
638 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
639 - The following is the doxygen comment of the typedef declaration
640 of gdcmagKey in src/gdcmCommon.h:
641 gdcmTagKey is made to old an "universal" (as in URL, Universal
642 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
643 A dicom tag allways has a group and an element, but a set of tags
644 embeded in various (optionally nested) sequences and sharing
645 the same group and element all share the same (group, element)
646 "identifier". Hence the (group, element) cannot be used as an
647 identifier (in gdcm we shall refer to a "TagKey") of a tag.
648 In order to construct a proper tag identifier (i.e. a key) we
649 consider the following definition of a TagKey:
650 - let Group, Element be the string representation of the
651 group and element dicom tag members,
652 - let ItemNumber be the string representation of the integer
653 index of the considered item number of a sequence,
654 Let the key of a tag embeded in a sequence, noted SeqTag, be
656 /ItemNumber#Group|Element
657 where "/", "#" and "|" are characters acting as separators.
658 Then the general form of a gdcmTagKey is given by:
659 Group|Element<SeqTag>
660 where <SeqTag> means NO or many instances of SeqTag.
661 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
664 but the gdcmTagKey of a tag "embeded" is the first item of
665 a sequence, itself nested in the third item of a sequence is the
667 0004|1220/2#0008|0082/0#0008|0090
668 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
669 order to hold the new sequence compatible key. Previously, the
670 GetKey() method would look in the underlying gdcmDictEntry.
671 - src/gdcmDocEntry.cxx:
672 -- constructor now copies the underlying DictEntry key, in the local
674 -- ::Print: displays the member Key, instead of the (group, element).
675 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
676 - src/gdcmDocEntrySet.h:xi
677 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
678 -- now has a new BaseTagKey member.
680 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
681 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
683 This poses the problem with the semantics of the following lines
684 LoadEntryVoidArea(0x0028,0x1201); // R LUT
685 LoadEntryVoidArea(0x0028,0x1202); // G LUT
686 LoadEntryVoidArea(0x0028,0x1203); // B LUT
687 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
688 to the long FIXME note for what the problem is. Nevertheless in
689 order to get things working the dicom dictionary was altered !
690 Please fix things urgently...
691 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
692 information), see above note on moving the member VoidArea. Nevertheless
693 the following entries previously correctly set as US are now inproperly
695 0028 1201 OW IMG Red Palette Color Lookup Table Data
696 0028 1202 OW IMG Green Palette Color Lookup Table Data
697 0028 1203 OW IMG Blue Palette Color Lookup Table Data
698 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
699 of gdcmDocEntry moved to gdcmSeqEntry.
700 * src/gdcmSeqEntry.cxx: STYLE.
702 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * Test/TestAllEntryVerify.cxx minor fix and added comments.
705 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * gdcmPython/testSuite.py: all the test suite in python is now moved
707 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
708 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
709 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
711 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
712 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
713 to avoid inclusion recursion until STL is reached.
714 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
715 mecanism. errno.h is not included in gdcm anymore.
716 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
717 (gdcmFormatError now inherits from gdcmFormatUnexpected).
719 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
720 gdcmData/TestAllEntryVerifyReference.txt
721 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
722 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
723 exception_on_error parameter.
724 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
725 - vtk/vtkGdcmReader.cxx changed accordingly,
726 - Example/*.cxx and Test/*.cxx changed accordingly.
728 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
729 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
730 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
731 enable_sequences removed from gdcmHeader constructor and dependencies.
732 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
733 * gdcmPython/demo/PrintHeader.py: dummy fix.
734 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
735 skip_shadow removed from gdcmHeader constructor and dependencies.
736 * Example/*.cxx and Test/*.cxx changed accordingly.
738 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
739 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
740 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
742 2004-07-21 Jean-Pierre Roux
743 * FIX Now, Parsing and Printing a DICOMDIR do work!
744 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
746 2004-07-20 Jean-Pierre Roux
747 * FIX Some brain damaged headers have Zero-Lenght fields
748 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
750 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
752 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
753 variable (instance of gdcmDebug) by a definition macro, and the instance
754 is now in static in the gdcmDebug class
755 * src/gdcmSQItem.h : (FIXME) remove an undefined method
756 * Test/PrintAllDocument.cxx : bug fix in the result of the test
758 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
759 * WARNING: ctest now depends more tightly on gdcmData. You should
760 check out gdcmData properly for things to run smoothly...
761 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
762 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
763 we need the pixels not be loaded in order to use the ValEntry
764 that displays position and size).
765 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
766 This is a C++ based equivalent of gdcmPython/testSuite.py that should
767 be deprecated. If you have any doubts about the advantages of a
768 modern scripting language (read Python) versus grass root C++ (i.e.
769 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
770 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
771 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
772 Anyhow, consider documenting the gdcmData images in
773 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
775 * Test/CMakeLists.txt:
776 - now uses TestAllEntryVerify.cxx
777 - specific comments on oldACR00001.ima (now renamed in gdcmData
778 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
779 gdcmData/TestAllEntryVerifyReference.txt
782 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
783 * src/*.[h|cxx] : typedef clean up
784 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
785 - TagKey renamed to gdcmTagKey (for external usage)
786 - VRKey renamed to gdcmVRKey (for external usage)
787 - removal of typedef duplication.
788 - Removed all unecessary inline keyword from class inline definitions.
789 - Some method|function(void) declarations replaced with method|function().
790 * src/jpeg/libijg12/jdhuff12.c:
791 - printf polluting ctest removed.
792 - TAB removal for comminting
794 - TestAllReadCompareDicom.cxx: added a test that compares all the
795 images in gdcmDataImages.h with corresponding images in
796 gdcmData/BaselineDicom/. When baseline images are not present
797 this test creates them.
798 Note: we need to validate each reference image, but before that
799 I'd like to rename them with a more explicit name...
800 - CMakeLists.txt: changed accordingly.
801 * Example/*.cxx: examples now only include gdcm.h (as opposed to
802 including each header needed).
804 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * Test/*.cxx and Example/*.cxx: moved some examples away from the
806 test suite to the Example directory. Are concerned:
811 - TestWriteSimple.cxx
812 * Test/CMakeLists.txt: added some comments on reasons for black listing
813 image gdcmData/oldACR00001.ima
815 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
816 * Test/CmakeList.txt: removed the following from black list (to be coherent
817 with removal from gdcmData):
818 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
819 - gdcm-MR-PHILIPS-16.dcm
821 Added the following because after last cvs update, they cause
822 ctest -R TestReadWriteReadCompare
824 - gdcm-MR-SIEMENS-16-1.acr
826 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
827 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
828 new comments in this file) we temporarily (sigh) move to a weaker
830 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
831 we don't need to black list the following images anymore:
832 - 8BitsUncompressedColor.dcm
834 - US-PAL-8-10x-echo.dcm
835 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
836 fixes and the beautified code ;-)
837 This fixes the bug introduced in version 1.42 (when beautifying)
838 that made the parsing of 8BitsRunLengthColor.dcm unproper.
839 Note: ctest was blind to this bug (this means we need to still
840 improve the test suite). The bug could be detected by using
841 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
843 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
844 and by displaying the (garbage) produced file temp.XDCM...
846 2004-06-29 Jean-Pierre Roux
847 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
848 - replace by uggly but working old code :-(
849 A lot of things should be OK again.
850 It's really urgent to have a test suite that *tests*,
851 to prevent Frog's beautifying sessions to break all the stuff
852 (twice, withing a fortnigh ...)
854 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
855 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
856 redundancy) to added Test/TestReadWriteReadCompare.cxx
857 * Test/CmakeList.txt: because the compare test of
858 Test/TestReadWriteReadCompare.cxx fails, the following images are
859 black listed: - 8BitsUncompressedColor.dcm
861 - US-PAL-8-10x-echo.dcm
862 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
863 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
864 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
865 and ad-hoc kludge. This kludge is now removed, and on encountering
866 such an image (OB field brain damaged) we set errno. Then in
867 ::FindDocLength() we "fix" the length as being ALL what remains
868 in the file (until EOF). We then proceed, hoping for the best...
869 This fixes a SegFault in ShowDicom when trying to write such an
871 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
872 (because TestWriteRead breaks on it, after a non conformal commit?).
873 ctest now runs properly, except for MakeDicomDir (which was allways
874 broken) and the Python related stuff (still not fixed).
876 2004-06-24 Jean-Pierre Roux
877 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
878 FIX : Test/TestReadWrite now iterates on all the file names
879 (instead of infinite loop)
880 ENH : Test/TestWriteRead now iterates on all the file names
882 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
883 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
885 2004-06-24 Jean-Pierre Roux
886 FIX : - now Write drops LUT Descriptors and LUTs (if any)
887 when SamplesPerPixel =3
888 - now Write is no longer confused by
889 'BitsAllocated = 12" and 'BitsStored=12"
890 - "UN" value representation Elements are now written correctly
891 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
892 ENH : - now gdcmHeader has its own Write methods
893 (in order to split the job that has not to be done
896 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
898 loop on the same image until memory went out.
899 Note: this means we still have gobs of memory loss in PrintDocument
900 * src/gdcmDocument.cxx: fixes problem on parsing on file
901 gdcmData/16BitsJpegLosslessGrayScale.dcm.
903 2004-06-24 Jean-Pierre Roux
904 FIX : Write - All the Sequences and Sequence Item are now written
905 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
906 is added a the end, when necessary.
907 - A lot of brain-damaged images, that were read correctly are
908 now written correctly
909 - length compatible BinEntry are now loaded correctly
910 (even for odd groups)
911 Note : only Explicit Value Representation was checked.
912 (question : is implicit VR really necessary for gdcm ?)
914 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * DEVELOPPER: added a proposition of coding style.
916 * src/gdcmDocEntry.h: removed every inline declaration (for test of
919 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
920 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
921 Use the gdcmDocEntry::Print() and Write() instead.
922 * src/gdcmDocument.cxx: bug fix.
924 2004-06-22 Jean-Pierre Roux
925 FIX : gdcmDocument.cxx
926 - Now we do recognize the JpegLossLess format (there was a misstyping in
927 code 'beautyfication' :-(
928 - Now we automaticaticaly load the Luts, if any
930 2004-06-22 Jean-Pierre Roux
931 In order : to write Sequences, whatever their imbrication level,
932 : to allow user to create his own Sequences
933 a lot of modif where necessary (adding, moving, or virtualising methods)
935 WARNING : save your own sources *before* cvs up !
938 ADD virtual void Write(FILE *fp, FileType filetype);
941 ADD virtual void Write(FILE *fp, FileType filetype);
942 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
945 ADD virtual void Write (FILE *fp, FileType filetype)=0;
946 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
947 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
948 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
949 ADD std::string GetEntryByName(TagName name);
950 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
952 std::string vr = "unkn",
953 std::string fourth = "unkn",
954 std::string name = "unkn");
955 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
956 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
957 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
958 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
959 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
960 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
961 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
962 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
965 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
966 ADD virtual std::string GetEntryByName (TagName tagName);
967 ADD virtual std::string GetEntryVRByName (TagName tagName);
968 REM virtual bool Write(FILE *, FileType);
969 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
970 FILE *_fp, FileType type);
971 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
972 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
973 REM virtual bool WriteEntries(FILE *_fp,FileType type);
974 REM virtual std::string GetEntryByName (std::string tagName);
975 REM virtual std::string GetEntryVRByName (std::string tagName);
976 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
977 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
978 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
980 std::string vr = "unkn",
981 std::string fourth = "unkn",
982 std::string name = "unkn");
983 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
984 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
985 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
986 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
989 ADD virtual void Write(FILE *fp, FileType filetype);
992 ADD virtual void Write(FILE *fp,FileType filetype);
995 ADD virtual void Write(FILE *fp, FileType filetype);
996 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
997 REM std::string GetEntryByNumber(guint16 group, guint16 element);
998 REM std::string GetEntryByName(TagName name);
1001 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1003 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1005 The default constructor invoked by the line
1006 gdcmHeader *f1 = new gdcmHeader( header );
1007 was gdcmHeader::gdcmHeader(bool) instead of the expected
1008 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1009 Hence the parsing wasn't executed... See also below.
1010 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1011 as explicit constructor didn't do the trick to fix the above problem.
1012 Could anyone explain why ?
1013 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1014 properly calls gdcmValEntry::Print() (that was weed out from
1015 code related to gdcmBinEntry).
1017 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1018 * In order to fix memory leaks:
1019 - Test/TestWriteSimple.cxx: added cleaning of free store through
1021 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1022 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1023 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1024 (through the call to ::AddDicomDirMeta()) or the destructor
1025 would crash when deleting uninitialized ::metaElems].
1026 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1027 - src/gdcmDocument.cxx:
1028 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1029 from dynamic stores.
1030 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1031 was causing memory leaks.
1032 - src/gdcmSQItem.cxx:
1033 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1034 cleanly handled with polymophism: sorry but my milage is low).
1035 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1036 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1037 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1038 This avoids SegFaulting.
1039 - src/gdcmSQItem.h: coding style.
1041 - Test/TestWriteSimple still severely sucks. The output image content
1042 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1043 damaged when displayed with vtkgdcmViewer.
1044 - on memory leaks: TestWriteSimple leaks really less (see entry
1045 of 2004-06-18 in Changelog file for the call to valgrind).
1046 - on segfaults: ctest now passes all the tests but one (no more
1048 * Erroneous leading white fix:
1049 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1050 white[s] (as opposed to from >> xxx, that removes it [them].
1051 - src/gdcmTS.cxx: ditto.
1052 - gdcmPython/testSuite.py: dirty related kludge removed.
1053 * src/*: remaining references to gdcmParser removed.
1054 * src/*[cxx|h]: added copy[way]left header.
1057 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * In order to fix writing of dicom files:
1059 - Test/TestWriteSimple.cxx: a simpler example of writing.
1060 - Test/CMakeLists.txt changed accordingly.
1061 - src/gdcmDocument.cxx:
1062 -- The destructor now recursilvely removes potential sequences.
1063 -- Bug fix in ::IsJPEG2000()
1064 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1065 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1067 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1068 to only declared) and build on top of
1069 ::GetDocEntryByNumber(guint16, guint16).
1070 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1071 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1072 for usage in destructor and treatement of promotion in
1073 ::ReplaceOrCreateByNumber().
1074 - src/gdcmSQItem.cxx: destructor should better handle his job.
1075 Test/TestWriteSimple now runs (or at least it DOES something).
1076 * We can now start hutting memory links. A good starting point is:
1077 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1078 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1079 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1081 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1082 * Valgrind note: after Mathieu Malaterre teached me how to read
1083 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1085 Using gcc, you can force the STL to use malloc and to free memory as
1086 soon as possible by globally disabling memory caching.
1087 With 3.2.2 and later, you should export the environment variable
1088 GLIBCPP_FORCE_NEW before running your program.
1089 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1090 simply vanish (it is still not clear to me, whether this means that
1091 STL std::string leaks or if valgrind believes it leaks...).
1092 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1093 running bin/gdcmTests makeDicomDir):
1094 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1095 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1097 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1098 SegFaulting (I drowned in DicomDir related code when trying to
1099 understand why the list is empty...).
1100 * src/gdcmDocument.h: first BSD license header try.
1101 * Doc/License.txt added.
1103 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1104 * src/gdcmDocument.[h|cxx]:
1105 - Clean up of the Transfer related predicates. They are now all based
1106 on new method isGivenTransferSyntax, that (should) handle properly
1107 the padding problem.
1108 - general clean up, simplification, and coding style.
1109 - Specific clean up of Parse7FE0() (umproperly named actually).
1110 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1112 2004-06-14 Jean-Pierre Roux
1114 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1115 - fix the display of SQItem ordinal number
1116 - add the GetSQItemByOrdinalNumber method
1117 - remove some useless never written private methods
1119 2004-06-14 Jean-Pierre Roux
1121 - adding a constructor taking a gdcmDocEntry as an input param
1122 - ReplaceOrCreateByNumber now returns :
1123 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1124 a gdcmValEntry * if a string value is passed as a param
1126 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1127 according to the param type (no longer sets a gdcmDocEntry)
1128 - GetValEntryByNumber, GetBinEntryByNumber added
1129 - NewValEntryByNumber and NewBinEntryByNumber added
1131 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1133 - GetSQItemNumber and SetSQItemNumber added, to provide
1134 a (relative) Item identier inside a given Sequence
1135 \warning : some pb remaining around this number
1137 - AddEntry now takes the Item Number as a param
1139 - adding a constructor taking a gdcmDocEntry as an input param
1141 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1142 * Memory leak hunt with the following command:
1143 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1144 --show-reachable=yes gdcmTests PrintDocument
1145 It looks like many (all?) leaks are due to the STL (or a bad usage
1146 of the STL. The lines producing the leaks now have a comment with
1147 a "MEMORY LEAK" tag: you can retrieve them with
1148 grep "MEMORY LEAK" src/*
1149 Here are two typical examples which I can't help fixing:
1154 char * test = "babo";
1155 name = test; //// <--- valgrind detects 960 bytes lost in
1156 //// call to std::string::operator=(char const*)
1157 name.clear(); //// Doesn't help !
1165 std::cout << "Type a bunch of characters followed by RETURN: ";
1166 getline(std::cin, line); //// <--- valgrind dectects a loss
1167 //// of 1320 bytes in call to
1168 /// std::basic_istream<>& std::getline<>
1174 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * src/gdcmHeader.[cxx|h]:
1176 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1177 and related, moved away to gdcmDocument.
1178 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1179 the corresponding protected accessors of inherited class
1180 gdcmDocument, removed ! As a consequence gdcmFile had to be
1181 declared friend of class gdcmDocument (see below).
1182 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1183 - Clean up of undefined or unused methods.
1184 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1185 account the changes to gdcmHeader.h).
1186 * src/gdcmDocument.h:
1187 - gdcmFile is now a friend class (in order to take into account the
1188 changes to gdcmHeader.h).
1189 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1190 (see changes to gdcmHeader.h).
1191 - Accessors (reading on the form GetEntry*) are now public.
1192 - Clean up of undefined or unused methods.
1193 * src/gdcmDocument.cxx:
1194 - adaptation to changes to gdcmDocument.h
1195 - ::OpenFile now writes a verbose message when file cannot be opened.
1196 - some std::string properly set to VRKey
1197 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1198 references to gdcmDocument.
1199 * Test/TestFindTags.cxx: changed accordingly to above changes.
1200 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1201 cvs repository gdcmData.
1203 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1204 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1205 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1206 conflicts with gdcmValEntry::voidArea.
1207 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1208 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1209 Value representation between StringRepresentable and BinaryRepresentable.
1210 * src/gdcmDocument.cxx:
1211 - method ParseDES: proper indentation restored and usage of
1212 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1213 - method LoadDocEntry: the fingerprint left in the SetValue() of
1214 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1215 removed. Reverting to previous code segment with the proper
1216 dynamic_cast< gdcmValEntry* >.
1217 Note: this was (partially) breaking the python test suite
1218 (gdcmPython/testSuite.py) that made usage of the above
1219 fingerprint to check presence of "Pixel Data".
1220 * src/gdcmDocEntry.h: coding style.
1221 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1222 now taken into account.
1223 * gdcmPython/gdcm.i: adaptation to the new internal representation
1224 of gdcm (exit gdcmParser, hello gdcmDocument).
1225 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1227 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1228 anymore, but instead prints the loaded Python dictionary.
1229 * .... alas, the python testSuite is still broken.
1231 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1232 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1234 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1235 * src/gdcmUtil.h : export methods
1237 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1238 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1240 * Initial addition of automatic python testing
1241 * Initial addition of automatic image comparison
1243 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1244 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1245 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1247 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1248 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1249 * Test/ShowDicom.cxx : bug fix for msvc compilation
1250 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1252 2004-05-04 Jean-Pierre Roux
1253 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1254 new concepts (and new classes) :
1255 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1256 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1257 - Sequence Doc Entries (gdcmSeqEntries)
1258 a Sequence is composed of Items.
1259 Each item is a set of Doc Entries (this is recursive)
1260 The non uniqueness of the 'Dicom tag' is due to this recursivity
1261 (never taken into account)
1262 Our unability to add a new 'entry' in the header
1263 at the proper location (neither in the H-Table (map or multimap),
1264 nor in the Chained List is also due to this recursivity.
1265 Don't try, right now, to use/modify/compile these new sources :
1266 nothing is finished.
1267 We just commit all the stuff, 'as is', in order not to loose it.
1269 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1270 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1272 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1273 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1274 file prefix (SetFilePrefix)
1276 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1277 * Add a new test: ShowDicom, for now this is just the c++ version of
1278 checkRead.sh, later it will be able to compare the image read against a
1280 * Replace the DEBUG on the stack with a global entry in cmake interface:
1281 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1283 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1284 * Add an example subdir, with a real example on how to read + write a
1287 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1288 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1289 * Doc/CMakeLists.txt: the main page is now properly differentiated
1290 between the developper and user version.
1291 * Doc/doxygen.config.in: dropped search related obsolete flags
1292 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1294 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1295 * DEVELOPPER: added some helpfull comments for compile/test/install
1298 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1299 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1300 src directory, now generated in the build dir.
1301 2. Tests as mentionned smarter
1303 4. Add a new method in gdcmDict that return the PubDict by name
1304 this is interesting for 3rd party lib like ITK,
1305 where we could set the institution name / patient name...
1307 * ENH: 1. Now the test suite is working for real
1308 2. All binaries are now output in the gdcm-bin directory
1309 (this was not true before)
1311 2004-04-28 Jean-Pierre Roux
1312 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1313 SeQuence indented printing of Dicom Header.
1314 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1315 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1316 Computation of SQDepthLevel is now part of gdcmHeader constructor
1317 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1318 tree-like structure of a Dicom Header.
1319 * FIX Test code cleaning
1321 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1322 * ENH: Adding automatic testing
1323 1. Need a DartConfig.cmake to submit to public
1324 2. Add a test driver gdcmTest.cxx
1325 3. gdcmTestMain, an helper for the main test driver gdcmTest
1326 4. Files in Test don't have a main anymore, this becomes interesting
1327 when we add more and more tests, thus dsw don't have to load
1329 * ENH: Adding a GDCM_DATA_ROOT for testing
1330 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1331 one file instead of seven + some small cleanup
1333 2004-04-22 Jean-Pierre Roux
1334 * ENH Minor changes to the Print() methods.
1335 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1336 Header printing. Example given with :
1337 > PrintHeader fileName 2 new
1338 (SQ based tree-like structure still to be done for the Header ...)
1340 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1341 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1342 1. I have added some unsigned where needed
1343 2. Some function parameter not used -> (void)
1344 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1345 4. g++ don't like character '\' in comment
1346 5. #define jpeg_create_decompress jCreaDecompress
1347 this really need to be fixed
1348 6. virtualize destructor of gdcmObject ... leakage
1349 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1350 this also really need to be fixed
1351 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1352 remove compression file
1353 (as we only do decompression, right ?)
1354 * ENH: Change malloc/calloc/free with c++ equivalent
1356 2004-04-21 Jean-Pierre Roux
1357 * FIX gdcmHeaderHelper::GetXSpacing
1358 when a single value is found (bug ?), xpacing is now
1359 defaulted to yspacing
1361 2004-04-19 Jean-Pierre Roux
1362 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1363 * ENH add parameters :
1364 bool exception_on_error = false,
1365 bool enable_sequences = false,
1366 bool ignore_shadow = false
1367 to the gdcmFile constructors to be full gdcmParser compliant
1368 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1369 to allow reading of PAPYRUS 3.0 files
1371 2004-04-06 Jean-Pierre Roux
1372 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1374 2004-04-02 Jean-Pierre Roux
1375 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1376 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1377 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1379 2004-03-30 Jean-Pierre Roux
1380 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1381 for ACR file, written out as DICOM files (hope so...)
1383 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1384 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1385 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1386 moved to base class gdcmParser and only the specialisation is kept
1388 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1389 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1390 already does the job.
1391 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1392 (to be consistent with gdcmParser::WriteEntries).
1394 2004-03-30 Benoit Regrain
1395 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1396 upate of the object's instance. It's passed to 2 in the unfavorable
1397 case : one in the ExecuteInformation, one in the ExecuteData
1399 2004-03-29 Jean-Pierre Roux
1400 * ENH : Check on file type to be written moved
1401 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1402 * FIX : gdcmObject::ResetBoundaries now stops properly
1403 when end-of-list is reached
1404 : gdcmVersion modified (as Benoit Regrain asked)
1406 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1407 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1408 * src/gdcmUtil.cxx: added forgotten iostream include.
1409 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1410 equivalent to ExplicitVR in existing code).
1412 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1413 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1414 now contains all the gdcmGlobal related code.
1415 * minor coding style and doxygenation changes.
1417 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1418 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1419 now contains all the Debug related code.
1420 * minor clean-up of includes in src/*.cxx
1421 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1422 CreateCleanString) removed.
1423 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1424 * Doc/DoxyMainPageUser.txt added.
1425 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1426 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1427 src/gdcmDirList.cxx)
1429 2004-03-24 Jean-Pierre Roux
1430 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1432 2004-03-23 Jean-Pierre Roux
1433 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1434 big endian made volumes
1435 * ENH Now gdcmParser constructor and destructor are protected to forbid
1436 end user to instanciate class gdcmParser
1437 (only gdcmHeader and gdcmDicomDir are meaningfull)
1439 2004-03-22 Benoit Regrain
1440 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1441 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1442 gdcmSerie to gdcmDicomDirSerie
1444 2004-03-19 Jean-Pierre Roux
1445 * ENH Now the tree-like structure describing a DICOMDIR comming from
1446 an already existing DICOMDIR file is consistent with
1447 the home-made tree-like structure build ex-nihilo
1448 or build from the files held (recursively) in a Directory
1449 functions gdcmDicomDir::CheckBoundaries()
1450 gdcmObject::SetBoundaries() added
1452 2004-03-17 Jean-Pierre Roux
1453 * REM (Eric Boix bug) : removal of meaningless
1454 gdcmDicomDirImage::NewImage function.
1455 * FIX now file names and directory name are written properly in the
1457 * FIX now gdcmDicomDir constructor may be call without any trick
1460 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1461 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1462 of gdcmDicomDirImage::NewImage as empty function.
1464 2004-02-28 Jean-Pierre Roux
1465 * ENH add gdcmDicomDir:NewPatient
1466 add gdcmDicomDirPatient:NewStudy
1467 add gdcmDicomDirStudy:NewSerie
1468 add gdcmDicomDirSerie:NewImage
1469 to allow making gdcDicomDir object.
1470 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1471 (as opposite to the gdcmHeader chained list)
1473 2004-02-11 Benoit Regrain
1474 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1475 when using from python
1477 2004-02-10 Benoit Regrain
1478 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1479 * FIX : in gdcmDicomDir when the directory is empty
1480 * ENH : add callback and methods to get the progression of dicomDir
1483 2004-02-06 Jean-Pierre Roux
1484 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1485 - GDCM_META added to gdcmDicomDirType
1486 - class gdcmMeta created
1487 * ENH : - A brief summary is now displayed at the beginning of
1488 'testDicomDir' to help disaster magnitude estimation
1489 * REM : Now useless Test/explDICOMDIR.cxx
1491 2004-02-05 Benoit Regrain
1492 * ENH : add methods in gdcmObject to get the hash table or the list of
1494 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1495 * FIX : wrapping python for TagHeaderEntryHT
1497 2004-02-04 Benoit Regrain
1498 * FIX : even length for some strings when writting the dicom dir
1499 * FIX : sort the images in the dicom dir
1500 * FIX : Bug fix for python use of dicom dir
1501 * ADD : a python demo
1503 2004-02-04 Jean-Pierre Roux
1504 * FIX : Final solution (?) for icone embedded images
1505 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1506 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1507 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1508 gdcmData/gdcm-MR-SIEMENS-16.acr1
1509 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1510 to make full checking easier
1512 2004-02-04 Benoit Regrain
1513 * FIX : WriteEntries : coding style & logic in parameters
1514 * FIX : Set the elements to create the DicomDir in a dictionary file
1516 2004-02-03 Benoit Regrain
1517 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1518 * gdcmDicomDir : add the load of directory
1519 * Bug fix and print add-on
1521 2004-02-03 Jean-Pierre Roux
1522 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1523 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1524 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1525 * FIX gdcmParser.cxx : 'group length' elements are now considered
1526 as integers, even for shadow groups, when file is Implicit VR
1528 2004-02-02 Jean-Pierre Roux
1529 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1531 of the last synonym :-(
1532 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1534 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1535 * FIX taking into account the possible 7fe0,0010 multiplicity
1536 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1537 to allow removal of references to 7fe0,0010, to deal with
1538 ACR-NEMA images, when 0028,0200 is meaningfull
1540 2004-01-31 Jean-Pierre Roux
1541 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1542 no longer writes 'Un' on disk
1543 * FIX SQ elements with actual length are now dealt with corectly
1544 * FIX gdcmFile::WriteBase make the difference, for color images, between
1545 the length (for Palette expanded images)
1546 and Raw Length (non expanded image + Palette)
1547 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1548 (that broke Write). Replaced by UL.
1549 Aware user will reload the field if he
1550 thinks it's necesssary
1552 2004-01-30 Jean-Pierre Roux
1553 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1554 when 'dirty Acr' is found, to be compliant with the new
1555 IsReadable() methods.
1557 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1558 (no DOUBLE images in kosher DICOM,
1559 but so usefull for people that miss them ;-)
1561 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1562 DICOMDIR related utilities (not checked as Windoze compliant)
1564 2004-01-28 Jean-Pierre Roux
1565 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1567 2004-01-27 Jean-Pierre Roux
1568 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1569 to allow skipping the shadow elements, to save memory space.
1570 The TRUE value for this param has to be used
1571 with a FALSE value for the 'enable_sequence' param.
1572 ('public elements' may be embedded in 'shadow Sequences')
1573 * gdcmHeader methods now deal with 'embedded icones images' in the header
1574 (even when an 'icone image sequence' is announced by the
1575 element (0x0088,0x0200), but there is NO icone at all ...
1577 * gdcmHeader sometimes Image Location value doesn't follow
1578 the supposed processor endianity (see gdcmData/cr172241.dcm).
1581 * gdcmHeader add the method
1582 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1583 to get *all* the Header Entries with the same tag.
1584 GetHeaderEntrySameName is probabely *useless*
1585 (no meaning : Name is *not* an identifier within the Dictionnary)
1587 2004-01-26 Benoit Regrain
1588 * Bug fix in the print of hexadecimal representations. Remove long fields
1589 in the print and add a third level of print to print them
1591 2004-01-23 Benoit Regrain
1592 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1593 * Bug fix on test suite after remove the strip made on not string fields
1594 * Split the IsReadable method between gdcmParser which test that the file
1595 is dicom and gdcmHeader which test that it's an image file
1597 2004-01-22 Benoit Regrain
1598 * DicomDir : clean code, add methods, set variables in protected or private
1599 * gdcmUtil : bug fix for the clean string method
1601 2004-01-19 Benoit Regrain
1602 * Add the use of shadow dictionaries
1603 * bug fix and coding style
1605 2004-01-19 Benoit Regrain
1606 * src/gdcmFile.cxx : bug fix concerning the close of file
1607 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1608 * Add the update of header entries using the shadow library
1610 2004-01-19 Benoit Regrain
1611 * removal of file gdcmHeader2.cxx
1612 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1613 inheriting from gdcmParser. This split is to prepare the integration
1614 of dicom dir parsing
1615 * bug fix under python
1617 2004-01-16 Jean-Pierre Roux
1618 * REM removal of class gdcmHeaderEntrySet
1619 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1620 * ADD add file gdcmHeader2.cxx
1621 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1623 2004-01-15 Benoit Regrain
1624 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1625 entries created while parsing the header. Thus, they will be destroyed
1626 when the gdcmDictSet will be destroyed
1627 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1630 2004-01-15 Benoit Regrain
1631 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1632 made a fatal error because of the memory release at the end of program.
1633 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1634 some memory and vtk seems to have some problems with that.
1635 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1637 2004-01-14 Benoit Regrain
1638 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1639 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1640 * src/*.[h|cxx] : make changes due to class name changes
1641 * gdcmPython/demo/*.py : bug fix due to method names
1643 2004-01-13 Benoit Regrain
1644 * src/*.[h|cxx] : coding style
1645 * vtk/*.[h|cxx] : coding style
1647 2004-01-13 Benoit Regrain
1648 * gdcmPython/testSuite.py : test the readable flag of file for tests
1649 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1650 It's lied to the stl compilation by MSVC (windows, always windows...)
1651 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1653 2004-01-12 Benoit Regrain
1654 * src/*.h : add comments
1655 * src/gdcmDictSet.h : set the method BuildDictPath in public
1656 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1657 directly setted in the source code
1658 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1661 2004-01-09 Benoit Regrain
1662 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1663 * setup.py : use a reference to gdcmVERSION
1665 2004-01-07 Benoit Regrain
1666 * Modification to compile with the distutils.
1669 2003-12-10 Benoit Regrain
1670 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1671 can use a gdcmHeaderHelper to load datas
1672 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1673 made in the source code
1675 2003-12-10 Benoit Regrain
1676 * Update Windows projects and .cvsignore files
1678 2003-11-12 Jean-Pierre Roux
1679 * ENH gdcmHeader constructor has one more parameter (default value : false)
1680 that allows the user to 'go inside' the SeQuences only
1682 gdcmElValSet:Print takes it into account
1684 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * ENH: Update gdcmPython/CMakeLists
1686 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1687 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1689 2003-11-10 Jean-Pierre Roux
1690 * FIX : gdcmHeader::LoadElements is now based
1691 on the ListTag listElem member,
1692 not longer on the TagElValueHT tagHt member
1693 * ENH : PrintPubElVal shows (temporarily) both results,
1694 with the tagHt member and the listElem member.
1695 (it's easier to 'see' the problems when using Printheader)
1697 * FIX : old private member LgrElem is now splitted into
1698 ReadLength : Length actually found on disk (updated only
1699 if bug fixing is necessary), for internal
1701 UsableLength : Updated by FixFoundLength, to fix a bug
1702 or to allow Parser going on.
1703 Will allow to re-write a kosher header when a SeQuence
1704 with a length (not 0000) is found
1705 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1706 because gdcmElValSet::Add does not update ListElem
1709 2003-11-07 Jean-Pierre Roux
1710 * FIX misstyping in Transfert Syntax name table
1711 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1712 when they have an actual length (not 0000 nor FFFFF)
1713 (Nobody should care of it, but DICOMDIR explorers)
1715 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1716 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1718 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1719 * ENH: vtkGdcmReader now supports LUT !
1720 (vtkgdcmViewer for now is not able to use them though)
1722 2003-11-05 Jean-Pierre Roux
1723 * in testSuite.py : new files names for checking the package
1724 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1725 that returns the pixel area size to the *aware* (vtk) user
1726 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1728 2003-11-05 Benoit Regrain
1729 * in testSuite.py : Modify the rules for checking the paths
1730 : Explicit error messages
1731 * in __init__.py : Related modif
1733 2003-11-03 Jean-Pierre Roux
1734 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1735 to be used by aware (vtk) users that want to manage
1736 LUT (and no to turn the PALETTE image into an RGB pixels one)
1737 * GetPixelType now returns 8U for 24 Bits images
1738 (vtkGdcmReader compliant)
1740 2003-10-31 Jean-Pierre Roux
1741 * Removal of *all* gdcmData images and add them again
1742 in order to loose the 'history' of un-anonymised images
1744 2003-10-31 Jean-Pierre Roux
1745 * RMV : removal of useless jBitsInJsample.h
1746 for both 8 and 12 Bits JPEG Lossy Libraries
1748 2003-10-31 Jean-Pierre Roux
1749 * ENH : Add the functions gdcmFile::GetImageDataRaw
1750 gdcmFile::GetImageDataIntoVectorRaw
1751 that act as GetImageData and GetImageDataIntoVector
1752 except the making of an RGB Plane from Gray Plane + LUT
1753 Intended to aware (vtk) users who know how to manage
1756 GetLUTRGBA return a R,G,B,A LUT if any
1757 lgrTotaleRaw gives the 'Raw' length
1758 GetImageDataRaw returns the gray Plane
1759 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1760 (They stay Grey, just like with other Dicom viewers :-(
1762 2003-10-30 Jean-Pierre Roux
1763 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1765 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1766 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1767 being coherents dicom files.
1769 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1772 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1773 * ENH: Two steps is necessary to please VC++ compiler...
1774 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1775 * ENH: Add include dir to medcon lib
1776 * FIX: only one function is being exported for now !
1777 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1779 2003-10-29 Jean-Pierre Roux
1780 * adding gdcmHeader::GetLUTRGBA
1781 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1782 --> Mathieu, the modif u're waiting for is not yet committed
1783 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1785 2003-10-27 Jean-Pierre Roux
1786 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1787 00191113.dcm DermaColorLossLess.dcm
1788 MxTwinLossLess.dcm RadBWLossLess.dcm
1789 * ENH: For version prior to vtkImageViewer2 -r 1.19
1790 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1792 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1793 * Removal of ido stuff in CMakeLists.txt
1795 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1796 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1797 * FIX: remove a call to ->Modified ... see comments
1798 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1800 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1801 * FIX: Problem with path for libvtkgdcmPython
1802 * ENH: Try adding a search script for python site-package
1803 * RMV: Remove some file from medcon lib that are not necessary
1804 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1805 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1806 * FIX: More pragma disable fro VC++,
1807 I don't think I break something as it is also disable in VTK/ITK.
1808 But it fasten debug compilation time.
1810 2003-10-23 Jean-Pierre Roux
1811 * gdcm now deals with 16 Bits Run Length Encoded images
1812 (they are compressed as 2 planes images,
1813 one for the high Bytes, the other for low Bytes)
1815 2003-10-22 Jean-Pierre Roux
1816 * Now CheckRead takes into account :
1817 - the bugged 'Leonardo' Siemens images
1818 - the XA images, sent thru the burning VPRO station
1819 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1822 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * FIX: When copying a Makefile.am to CMakeLists.txt
1824 one should remove the '\'
1826 2003-10-22 Jean-Pierre Roux
1827 * in gdcmData adding a bugged 'Leonardo' Siemens image
1828 (wrong lengths in header)
1829 OK with gdcm, KO with the other viewers :-)
1830 * add a GE dlx XA image, thru the VEPRO burning station
1833 2003-10-21 Jean-Pierre Roux
1834 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1835 for a brutal checking of vtkgdcmViewer compliance
1837 2003-10-21 Jean-Pierre Roux
1838 * add the files for 'xmedcon' Jpeg Lossless library
1839 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1841 2003-10-21 Jean-Pierre Roux
1842 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1844 2003-10-21 Jean-Pierre Roux
1845 * garbage Siemens 'Leonardo' images dealt with
1846 (the patch is easy to remove)
1847 * cosmetic changes to avoid warnings
1849 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1851 no need to press 'r' now.
1853 2003-10-20 Jean-Pierre Roux
1854 * upgrade of checkRead.sh checkWrite.sh according
1855 to new Jpeg Lossless decompressor
1856 * add US.3405.1.dcm, a genuine RGB medical file ...
1857 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1858 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1860 2003-10-15 Jean-Pierre Roux
1861 * general anonymisation in gdcmData
1862 * adding the 'color files' from
1863 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1864 * adding some well knowed bugged-header images
1865 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1866 waiting for their inclusion in Python testsuite
1868 2003-10-15 Jean-Pierre Roux
1869 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1870 no longer seg faults when file is not found
1872 2003-10-14 Jean-Pierre Roux
1873 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1876 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1877 * TODO: *.in file to genereate a UseGDCM later
1879 2003-10-14 Jean-Pierre Roux
1880 * Some supposed-to-be Dicom Images have no preamble.
1881 OpenFile takes it into account
1882 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1883 * Missing elements added in dicomV3.dic
1884 (just to be affraid : have a look at
1885 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1886 and do it again next year ;->
1888 2003-10-13 Jean-Pierre Roux
1889 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1890 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1891 But there are NOT. It's fixed !
1893 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1894 * FIX: "jpeglib.h" was not found on VC++
1895 * FIX: vtkgdcm was not being installed
1897 2003-10-10 Jean-Pierre Roux
1898 * ENH : OpenFile closes the file if it *really* doesn't look like
1899 an ACR-NEMA / DICOM one.
1900 * FIX : testWrite no longer writes an empty file if the source file
1901 is not gdcm Readable
1902 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1905 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1906 * FIX: CMake generate now documentation
1907 * ENH: out of source doc build !
1908 * ENH: Generate both user and dev documentation
1909 * ENH: Should work on windows too
1910 * ENH: Only one doxygen config.in file is needed
1911 * FIX: make install should be ok now on ùnix plateform
1912 * FIX: PATH to dictionary was wrong (missing /)
1913 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1915 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1916 * vtkGdcmReader is now able to read rgb dicom file.
1917 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1918 * added a gdcmViewer to vtk test, use mouse to control
1919 window level & window width
1921 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1922 * CMake-ification of gdcm, we have now two build system
1923 * FIX: on cygwin Wsock32 doesn't exist
1924 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1926 2003-10-06 Emanuel Ollart
1927 * FIX : compilation process wad broken.
1928 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1930 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * change gdcmViewer -> vtkgdcmViewer
1932 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1934 2003-10-06 Jean-Pierre Roux
1935 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1936 ( e.g : well known GE images with a wrong elem length,
1937 : Philips MRI Images with a wrong Huffman table)
1938 * still to be done : allow the reading of bugged LEONARDO Siemens images
1940 2003-10-03 Jean-Pierre Roux
1941 * Odd length strings are padded with '\0' (not with spaces,
1942 to remain compliant with already defined strings,
1943 like Transfert Syntax UID and others)
1945 2003-10-03 Jean-Pierre Roux
1946 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1947 to allow displaying RGB images (not only by affim ;-)
1949 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1950 * vtkGdcmReader is now able to read rgb dicom file.
1951 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1953 2003-10-03 Jean-Pierre Roux
1954 * A few nasty patches to allow the reading of a lot of nasty images
1955 ( e.g : well known GE images with a wrong elem length,
1956 : Philips MRI Images with a wrong Huffman table)
1957 * still to be done : allow the reading of bugged LEONARDO Siemens images
1959 2003-10-03 Jean-Pierre Roux
1960 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1962 2003-10-03 Jean-Pierre Roux
1963 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1964 to allow displaying RGB images (not only by affim ;-)
1966 2003-10-03 Jean-Pierre Roux
1967 * gdcmFile::GetImageDataIntoVector now
1968 - deals with MultiFrames MultiFragments Run Length Encoded files
1969 - deals with YcBcR (YBR_FULL) files
1970 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1971 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1973 (no sample found :-(
1975 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1976 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1977 Two reasons: - clear things
1978 - third parties acces gdcm through header files, so won't
1979 suffer anymore VC++ complains
1981 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1982 * add argv[1] in testvtkGdcmReader.cxx
1985 2003-09-24 Jean-Pierre Roux
1986 * The lines are now eigthy characters long.for
1987 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1989 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1990 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1991 char* to std::string. Thus, the use of strdup becomes useless. (see
1992 previous commis of Malaterre)
1993 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1994 before the last Malaterre's commit.
1996 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1997 * This commit should fix the Debug building under VC++, the problem
1998 was mainly a mixture of debug and release lib being loaded at startup.
1999 * I also remove a depency to a specific C function: strdup. Because I had
2000 to force the link to msvcrtd (whereas strdup is in libc).
2002 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2003 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2004 located in the gdcmCommon.h file. All use of reference of tha has been
2005 changed to now use the variable GDCM_UNFOUND.
2007 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2009 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2010 Dicom dictionary. The test suite can now be run again. Note:
2011 I'm note very happy with the " (RET)" changes. I believe this
2012 RETAINED comment should be dropped when parsing the dictionary.
2013 - PACKAGER corrected
2015 - AUTHORS updated and now in alphabetical order
2016 * Makefile.am now exports gdcm.dsw for Windoze users.
2018 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2019 * cygwin complains about missing std:: in subdir Test/
2021 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2022 * remove some methods that are now in gdcmHeaderHelper
2024 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2025 * vtkGdcmReader set spacing and origin correctly
2027 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2028 * Fix a few delete/delete[] mismatch
2030 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2031 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2032 interpretation to data given by gdcmHeader. For instance there are
2033 heuristics to get informations (look at different places).
2034 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2035 sorting DICOM images based on different strategies.
2036 * modified Makefiles accordingly.
2038 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2039 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2040 when building in debug mode
2041 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2042 src/win32/gdcmdll.dsp
2043 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2045 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2046 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2049 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2050 * src/win32/libgdcmjpeg12.dsp was not dos format
2051 * src/win32/libgdcmjpeg12.dsp :
2052 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2053 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2055 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2056 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2058 * src/gdcmFile.cxx : bug fix in affectation type
2059 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2060 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2061 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2062 symbols... future problem ?
2064 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2065 * src/win32/libgdcmijpeg12.dsp was missing
2066 * modified gdcm.dsw accordingly
2068 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2069 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2071 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2072 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2073 commit of JPR (before his hollidays to facilitate our work).
2074 * setup.py : bug fix in code. Modifications made while the last commit
2075 of JPR. The code hasn't been tested before the commit... it's so
2076 useless to make that (for best programmer that is JPR) !!!
2078 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2079 * tagged the current version as Version0_3 (i.e. version 0.3)
2081 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2082 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2083 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2084 * *.dsp : modifications to use new libgdcmijpeg8 library
2085 * setup.py : bug fix on VTKPATH variable
2086 * PACKAGER : adding all concerning windows
2088 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2091 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2092 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2093 test suite reported error.
2094 * PACKAGER file added (describes what a packager must do when
2095 packaging a new release).
2096 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2097 * configure.in: upgraded version number to 0.3.0
2098 * fixing build of rpm (through rpm -ta):
2099 - Doc/Makefile.am exports proper doxygen files
2100 - src/jpeg/libijg8/Makefile.am exports the include files.
2102 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2103 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2104 * src/gdcmHeader.h : formatting code
2106 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2107 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2108 We were obtaining error message from vtk. Now, creation of file list
2109 is made in an internal list to prevent this problem.
2110 Bug fix when output is empty.
2111 Bug fix in update of progress value. Previous commit for this was a bad
2113 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2115 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2116 * src/gdcmHeader.h : added method to get the file name
2117 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2118 files. Added method to remove all files on the input
2119 Added FIXME comment concerning the bad parsing of header made by
2120 ExecuteInformation method (in ExecuteData method)
2122 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2123 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2124 when using make instal.
2125 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2126 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2128 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2129 * setup.py : adding include dir of jpeg lib to compile all sources
2130 * */Win32/*.dsp : JPR fix for windows compilation
2132 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2133 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2135 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2136 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2138 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2139 * setup.py is again effective on un*x (takes into account the
2140 addon of the jpeg library)
2141 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2142 * Doc/Doxy* updated (includes above enhancements)
2143 * INSTALL now points to web documentation
2145 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2146 * src/gdcmHeader.h doesn't make unnecessary reference to
2148 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2150 * src/gdcm*.[cxx|h] :
2151 - to allow compilation with gcc 3.x
2152 -- clean up of STL usage (added explicit usage of std::)
2153 -- small fixes on exceptions.
2154 Note: linking not tested !
2155 - clean of doxygen comments to avoid warnings at documentation
2157 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2158 dependent convertion).
2160 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * Clean up of previous JPR garbage commit (not even commented in the
2163 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2164 - moved all jpeg related files from src to src/jpeg/libijg8, with
2165 addition/modification of Makefile.am and configure.in.
2166 - the testSuite is still brain damage (not guilty).
2168 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2169 * WrapVTK.py : modifications to get correctly vtk source files to
2171 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2172 (FileName -> Filename)
2174 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * vtk/vtkGdcmReader.[cxx/h]:
2176 - UpdateProgress method should now be effective
2177 - removed the limitation on having only images loaded (as opposed
2179 - when building a stack of images/volume, a lesser number of
2180 gdcmHeader and gdcmFile instances should be used (hopefully
2181 accelerating things).
2182 - when building a stack of images/volumes, files which are not
2183 loadable (wrong path-filename, wrong permissions on existing file,
2184 or file not parsable by gdcm) are replaced with a black image
2185 in the stack (for the caller to notice the problem).
2187 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2188 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2190 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2191 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2192 between standard library (std) and vtk library (problems are found
2193 under Windows... thanks Windows !)
2195 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2196 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2198 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2200 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2201 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2203 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * When compiling with distutils (see setup.py) the C++ compiler is
2205 called with different flags than the default ones (with automake).
2206 In order to fix all those warning, I compiled gdcm with the command
2207 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2208 and went for warning fixes:
2209 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2210 up from unused variables.
2211 - vtk/vtkGdcmReader.cxx: potential bug fix.
2212 * src/gdcmHeader.h: Doxygen warning cleanup
2214 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * gdcmPython/gdcm.i:
2216 - typemaps correction to take into account the systematic replacement
2217 of "using namespace std" with std:: prefix e.g. std::list,
2218 std::string... (cf changes of 2003-05-21).
2219 - gdcmGlob global variable of type gdcmGlobal (defined in
2220 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2221 exported to Python a as cvar.
2222 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2223 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2224 gdcmDictSet.GetPubDictTagNames() and
2225 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2226 C++ static methods).
2227 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2228 with the above changes.
2230 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2231 * setup.py, manifest.in : bug fix under linux
2233 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2234 * Modification of setup.py to compile vtk part too. Then, we have 2
2235 wrappers which must work with same distutils. For that, we have a
2236 generic distutils in distusiltsWrapping.py ; with :
2237 - build_extWrap class to wrap generically all extensions,
2238 - ExtensionWrap base class for all wrapping extension that contains
2240 - Wrapper interface which wrap sources
2241 + In WrapSwig.py we have extension and wrapper for Swig
2242 + In WrapVTK.py we have extension and wrapper for VTK
2243 * MANIFEST.in : modifications to consider vtk directory and new python
2244 files for compilation
2246 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2247 * Added python wrappers of vtkGdcmReader vtk class (see the
2248 source in vtk/vtkGdcmReader.cxx) :
2249 - vtk/Makefile.am now builds a library
2250 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2251 python library (as opposed to _gdcm.so wich are the python
2252 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2253 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2255 - configure.in has an additional flag --enable-vtk that needs
2256 to be set to enable compilation of vtk related code, that is:
2257 + vtk/vtkGdcmReader.so and
2258 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2259 + gdcmPython/vtkgdcmPython.so (see above)
2260 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2261 be read when compressed or when HighBit + 1 != BitsStored),
2262 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2263 the usage of the python wrapper of vtkGdcmReader vtk class.
2264 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2265 * src/*.[h] all occurences of stl classes are now prefixed with
2266 std::, and all occurences of "using namespace std;" where removed.
2267 This is to avoid pollution of global namespace in included files.
2268 Apparently vtk does not avoid this pitfall: when using both
2269 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2270 collision of various stl members (principally cout...).
2271 * gdcmPython/testSuite.py now cleanly removes temprory generated
2273 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2274 comply with above changes)
2276 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2277 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2278 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2279 vtk data structure (an image Flip was required).
2280 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2281 * cosmetic changes in documentation.
2283 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2284 * src/gdcmHeader.cxx: the constructor no longer exits when an
2285 unexisting file is given as argument.
2286 * The subdirectory Data (containing all the images used for the
2287 test suite) is not part of this repository anymore. A new module
2288 containing those images is now available at
2289 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2290 with the name gdcmData.
2291 All the python scripts (including the package initialisation file
2292 gdcmPython/__init__.py) were adapated to take this change into
2293 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2295 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2296 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2297 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2298 demo of the usage of this class.
2299 Compilation of this vtk part is only done when using the --enable-vtk
2300 at configure (or autogen.sh) stage.
2302 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2303 * More memory link related corrections and documentation fixes.
2305 - maximum info is obtained with a command of the form:
2306 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2307 --show-reachable=yes PrintHeader
2308 - the remaining reachable blocks seem to come from the STL
2309 allocation scheme through the usage of map and list. It looks
2310 like this memory cannot be freed but it is not a memory leak
2311 (in fact further invocation to the STL would recollect the
2312 unused memory allthough it cannot explicitely be freed).
2313 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2314 of displaying an image parsed with gdcm and displayed with VTK.
2315 Note: some images don't seem to work e.g.
2316 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2317 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2318 Allthough this weakens the semantics, it is a ditch attempt to
2319 make gdcm more thread friendly.
2321 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2322 * Memory link hunt (by using valgrind through the command
2323 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2324 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2325 gdcmHeader::_dicom_vr.
2326 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2327 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2329 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2331 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2332 * src/Makefile.am now exports all the necessary include files at
2336 * UpdateGroupLength replaced by new one
2339 * UpdateGroupLength re-written using H-Table
2340 (named UpdateGroupLengthNew untill checks are over)
2342 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2343 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2344 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2346 - gdcmHeader::GetPubElValSet removed.
2347 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2348 UpdateGroupLength, WriteElements, Write.
2349 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2350 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2351 carried the same semantics.
2352 - src/gdcmHeaderIdo.cxx changed accordingly.
2353 - gdcmFile::WriteBase now regroups all the codes from previous
2354 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2355 - enum FileType moved to gdcmCommon.h
2356 * src/gdcmHeader.cxx AddDefault trashed
2357 * gdcmGetXSize added
2358 * getimageDataSize now calls gdcmGetXSize
2359 * Test/*.cxx changed to agree with above changes
2361 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2363 (to avoid double call by end user).
2364 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2365 by end user, since gdcmHeader::gdcmHeader now handles it.
2367 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * gdcm/Doc many doxygen changes:
2369 - Doxyfile now has two different versions, DoxyfileUsers that generates
2370 the html.users end users oriented documentation and
2371 DoxyfileDeveloppers that generates the html.developper developper
2372 oriented documentation.
2373 - README changed accordingly
2374 - requirement.txt removed (old design info moved to TODO).
2375 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2376 DoxyMainPage.txt, DoxyPython.txt provide more information.
2377 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2378 be updated by simply regenerating the docs with doxygen and copying
2379 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2380 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2381 all the tests in the form "if (<map>.count() >1)" were removed.
2382 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2383 ill-formed documentation sections.
2384 * src/gdcmHeader.cxx: ditto
2386 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2387 * setup.py fixed for un*x (needed macro for stdint.h)
2388 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2389 un*ces with sh-utils test utility.
2390 * gdcmPython/demo/test.py renamed to PrintHeader.py
2391 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2392 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2393 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2394 * src/gdcm*.cxx JPR's bad inclusion fixed.
2396 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2397 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2398 * gdcmPython/demo/test.py changed accordingly.
2400 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2401 * gdcmPython/Makefile.am fixed linking against libstdc++
2402 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2403 * Swig subdir (historical tests of swig version 1.3.17++) removed
2404 * Test/testChangeEntete.cxx some lines commented out in order to make
2406 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2407 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2409 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2410 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2411 hence the user doesn't need this explicit call.
2412 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2413 i.e. LoadElements() call removed.
2414 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2415 - src/Makefile.am declares the proper flag for g++.
2416 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2417 for adding user defined new tags.
2418 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2419 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2420 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2422 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2423 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2424 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2425 src/Makefile.am : the project should properly compile and install
2426 with the autotools, included the python wrappers part.
2427 * gdcm.spec.in : added a spec file for RPM packaging.
2429 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2430 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2432 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2434 to exported to the environement (see gdcmPython/testSuite.py
2436 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2437 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2438 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2439 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2440 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2442 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * gdcmPython/__init__.py doesn't crash anymore when running in
2444 in InstallMode or PreInstallMode but with an environement given
2445 value of GDCM_DICT_PATH.
2446 * src/gdcmDictSet.[cxx/h] coding style.
2448 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2449 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2450 * src/gdcm.h general comments moved to TODO, and README
2451 * src/gdcm.h should now be seen as a user commodity (including it
2452 should suffice to fully use gdcm). It is nowhere including within
2453 any of the kernel files src/*.cxx and src/*.h.
2455 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2456 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2457 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2459 * src/gdcm*.cxx only include their corresponding include file
2460 (as opposed to gdcm.h)
2461 * gdcmPython/gdcm.i changed accordingly
2462 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2463 the autogen.sh generated "make snapshot" command to work.
2464 * autogen.sh removed history related references to crea package.
2466 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2467 * distutilsSwigCPlusPlus.py work around some swig portability
2470 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2472 was done in a last ditch attempt to get setup.py _really_
2473 operationnal. The python/gdcmPython layaout add the advantage
2474 of hidding away the python related distutils specific files
2475 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2476 Alas, the src directory was out of scope (i.e. it's relative
2477 position to setup.py was ../src) which made things impossible to
2478 handle (see previous version of python/setup.py). Crossing fingers...
2480 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2481 * python/setup.py now works on Un*x. (harder than I thougth)
2482 * python/distutilsSwigCPlusPlus.py can now have include files
2483 among the list of sources.
2485 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2486 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2487 * modifications in MSVC projects
2489 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2490 * As stated by the first lines of Test/ExceptionAndPython/README, it
2491 looks like we can move back to original usage of exception within
2492 src/gdcm* and hence remove the errno stuff that was introduced
2493 as a quick and dirty fixture of this problem (added to the TODO).
2494 * Doc/Doxyfile configuration file for Doxygen and corresponding
2495 README file for usage added.
2496 * Test/testWrite.cxx added. This new test comes from a split of
2497 test.cxx that is now reverted to its original purpous i.e.
2498 testing the proper parsing of a Dicom related file.
2499 testWrite.cxx concentrates on testing the IO part of gdcm.
2500 * Test/bug1.cxx (containing a bug on WIn32) added.
2501 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2502 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2503 whose purpose is to publish the content of the TagNames of the
2504 Dicom public dictionnary were not accessible without an
2505 instance of class gdcmHeader.
2506 - those methods are now static methods of gdcmDictSet and hence
2507 require no instances at all to be invocated.
2508 - within gdcmDictSet this change required to change some method
2509 to class methods (i.e. are now static) among which SetDictPath
2510 (renamed to BuildDictPath) and LoadDefaultPubDict.
2511 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2512 the above changes by calling the new method classes of gdcmDictSet.
2513 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2514 the above to be effective.
2515 * python/gdcmPython: in order to wrap properly the above changes
2516 for Python, swig version now needs to be > 1.3.17.
2517 * python/gdcmPython/Makefile fixed to adapt itself to new
2518 configure/make shema introduced by Johan Montagnat (thanks for the
2519 contribution). Alas this Makefile cannot be turned into a proper
2520 Makefile.am without some heavy changes in the configure.in
2521 (for python dectection).
2522 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2523 now avoids publishing the empty entries.
2525 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2526 * python/setup.py : bug fix concerning install under windows
2527 ExtraPath reused :-P
2528 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2530 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2531 * Dicts/dicomV3.dic : remove double spaces !!!
2532 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2533 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2536 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2538 method. Doxygenation.
2539 * src/gdcm.h clean up of JPR spurious comments.
2541 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * python/distutilsSwigCPlusPlus.py now properly collects the
2543 shadow classes generated by "swig -c++" (gdcm.py in our case)
2544 when using "python setup.py install".
2545 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2546 reexports the working classes.
2547 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2548 by the classical C errno scheme. This is to prevent an obscure
2549 behavior of the python wrappers when importing wxPython.wx prior
2550 to gdcmPython (which ended up in an abort call). An illustration
2551 of this oddity can be found in the Test/ExceptionAndPython
2552 subdir (see the README file). This problem probably due to
2553 an combination of g++ and dynamic loading.
2554 * added Test/ExceptionAndPython (see above)
2556 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * Changed the layout of the python part to avoid bloating main
2558 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2559 i.e. the distutils arsenal. All the python related stuff is
2560 again in a python subdir, but the package itself is now in
2562 * setup.py was cleaned up:
2563 - pythonIncludePath removed
2564 - python setup.py bdist target is now functional.
2565 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2566 collision with other packages). gdcmPython/demo/*.py changed
2569 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * python subdir moved to gdcmPython (preparation of distutils packaging).
2571 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2572 distutils installer is operational.
2573 * - gdcmPython/__init__.py now properly loads the swig generated
2574 shadow classes (from gdcm.py).
2575 - gdcmPython/demo/*.py changed to import the package gdcmPython
2576 instead of gdcmPython/demo/load.py.
2577 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2579 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2580 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2581 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2582 entries within the associated public Dicom dictionary resp. the same
2583 information but sorted by the fourth field (PAT, IMG, DIR) of the
2585 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2586 are now in the "???" group.
2587 - python/gdcm.i changed accordingly,
2588 - python/demo/printGroupedPublicDict.py added, that gives an example
2589 of the above new functionalities in Python.
2591 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2592 * src/gdcm.h, gdcmHeader.cxx:
2593 - historic references to glib's g_malloc and g_free (#defined)
2594 were definitively removed.
2595 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2596 * src/gdcmElValSet.cxx:
2597 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2598 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2599 - GetElValue(string) renamed to GetElValueByName.
2600 - Added GetElementByName(string).
2601 * src/gdcmHeader.cxx: added
2602 - GetPubElValRepByNumber(guint16, guint16)
2603 - GetPubElValRepByName(string)
2604 - GetShaElValRepByNumber(guint16, guint16)
2605 - GetShaElValRepByName(string)
2606 - GetShaElValByNumber(guint16, guint16)
2607 - GetShaElValRepByName(string)
2608 - GetElValRepByNumber(guint16, guint16)
2609 - GetElValRepByName(string)
2610 - GetElValByNumber(guint16, guint16)
2611 - GetElValRepByName(string)
2612 * Doc/requirements.txt added.
2614 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * Test/Makefile building now depends on the one of libgdcm.so
2616 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2617 pixel data) aware which enables finding the address (offset) of
2618 the pixel data of JPEG encoded DICOM files. This leaves only a single
2619 file in the testSuite whose pixel data address (offset) is unknown.
2620 * python/testSuite.py changed accordingly.
2622 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2623 * VC++ has some strong limitations when working with the STL, as stated
2624 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2625 "Also note that some STL containers (map, set, queue, list, deque)
2626 cannot be exported. [...]
2627 Some STL classes contain nested classes. These classes can not
2629 This is caused by a designed limitation that once a template
2630 class is instantiated, it can not be re-instantiated and
2632 Since our usage of map<> is ubiquitous in gdcm, this "designed
2633 limitation" of VC++ is a pitfall.
2634 Hence the Python wrappers of gdcm cannot be incrementally linked
2635 against the c++ dynamic library. The dirty but only workaround is
2636 to forget about incremental link of dynamic libraries and to generate
2637 the Python wrappers library with the inclusions of the underlying C++
2639 The following modifications concern this matter on Win32/VC++:
2640 - wrapping python correct with standalone wrapped dll (don't use separate
2641 dll under windows !!!!)
2642 - python21_d debug mode enabled (ask Frog how to use it :-)
2643 - NO problem with having an STL member of class for example string in C++
2644 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2645 - Python test of dcmlib in Python is ok under windows on a large set
2647 * removed glib references
2648 * typedef's inserted in gdcm.i for correct swig type management
2650 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2651 * python/demo/*.py load.py extracted from test.py. Added explore.py
2652 that only displays required tags and testAll.py that parses all
2653 the files of the testsuite without using unittest.
2654 * python/testSuite.py other additional test on new files added.
2655 * Data/* new test files added accordingly to the testSuite.
2656 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2657 the vr in the file differs from the one of the dictionary.
2659 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2661 values, but limits itself to values which are below a user specified
2662 size (by default 1024 bytes).
2663 * python/gdcm.i : elements not loaded (because their size is above the
2664 user specified treshold) are exported with their TagKey as key of the
2665 python dictionary. This enables the testsuite to make some checks
2666 on the unloaded elements (since we have their offset and size).
2667 * python/testSuite.py
2668 - now tests for the existence and proper value of the pixel data
2669 - two new examples added.
2670 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2672 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2673 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2674 aware. See the strategy comments in gdcmHeader::FindeLength().
2675 * Test/test.cxx now accepts a filename as first argument.
2676 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2677 * python/testSuite.py changed to integrate test on above files.
2679 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2680 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2681 the vr was also RET.
2682 * python/testSuite.py more tests added.
2684 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * python/testSuite.py unittest test suite added (uses Data)
2686 * Data/* dcm and acr files for the test suite.
2687 * glib dependance removed from un*x version. We now use ISO C99
2688 7.18 Integer types (see stdint.h)
2689 - python/Makefile, src/Makefile src/gdcm.h
2690 * src/ when an explicit vr (like dicom files) suddenly poped an
2691 implicit element we use to mark the underlying DictEntry of the
2692 concerned ElValue with "Implicit". This strategy was damageable
2693 too the public or provite dictionaries, since some of their vr
2694 would be changed. Since Header::FindLength heavily relies on the
2695 detection by Header::FindVR of falsely explicit elements, I
2696 added an extra ImplicitVr member to ElValue (boolean).
2697 The rest of the changes we the necessary adaptations.
2699 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2702 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2704 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * Adaptation for porting to VC++:
2707 o forced to use std namespace (for string to be known)
2708 o all class use __declspec export style on WIN32
2709 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2710 (in stdlib.h on Win32 but in std:: for gcc)
2711 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2712 variable GDCM_DICT_PATH.
2713 * src/gdcmHeader.cxx verbose comments made discrete.
2715 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * python/gdcm.i: added a typemap that converts a C++ hashing table
2717 to native Python dictionary.
2718 * python/demo/test.py:
2719 - now uses the native dictionary for exploration of gdcmHeader.
2720 - takes an optional filename argument (the file to parse).
2721 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2722 PubElVals hashing table.
2723 * Dicts/dicomV3.dic removed error prone trailing spaces.
2725 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * Python wrapping process moved away from src/Makefile to
2727 newly created python/Makefile (as well as gdcm.i)
2728 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2729 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2730 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2731 from the environement variable GDCM_DICT_PATH (when existing).
2732 * src/gdcmDict::GetTag bug fix.
2734 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2735 * Straightforward temporary fixes for swig to build the python wrappers.
2736 src/Makefile now has a python working entry [by working we mean
2737 that we can import de shadow classes without errors].
2739 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2740 * hashtest.cxx removed (since allready in Test)
2741 * src/gdcmlib.h renamed to src/gdcm.h
2742 * src/dcm.i renamed to src/gdcm.i
2743 * src/Makefile prepared for python wrapping
2745 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * src/gdcmHeader.cxx :
2747 - Parsing of header is now separated from loading of element values
2748 (see gdcmHeader::LoadElements).
2749 - general clean up of hopefully all file access (creation of
2750 ReadInt16 and ReadInt32)
2752 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * src/gdcmHeader.cxx :
2754 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2756 - SetLgrElem renamed to SetLength
2757 - GetLgrElem renamed to GetLength
2758 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2759 * src/gdcmElValSet.cxx fixed both GetElValue methods
2760 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2761 due to IdoDude was cleaned out.
2763 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2765 concentrates on finding the value representation (when it exists).
2766 RecupLgr now only finds the element value length, and it avoids
2767 returning the unecessary skL (skipped length).
2768 Also, offsetCourant was simply removed (with taille_fich) since
2769 it was redundant with the File position internals (by using
2770 ftell and fseek). This also made skL (see above in RecupLgr) usage
2772 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2773 on the libido specificities which are handled through class
2775 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2778 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * Truckload of changes. Parsing of header is barely functional
2780 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2782 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2783 * src/gdcmHeader.cxx many addons of low level methods
2785 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2787 and _IdDcmSWAP_LONG.
2789 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * This corresponds to all the changes decided at the meeting of
2791 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob