1 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
3 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
4 after it have been deleted
6 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
7 * FIX: src/* fix the doxygen warnings.
9 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
10 1. Finish merging JMR patch for writting DICOM from scratch
11 2. Fix -hopefully- bug with MONOCHROME and space vs null character
12 3. Use const ref when possible
13 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
14 5. A few more comments
15 6. CreateUniqueUID can now be called without parameter"
17 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
18 * ENH: Slightly bigger patch:
19 1. Getting toward full integration of JMR patch for writting dicom from scratch
20 2. Update Test to test part of this patch: CreateUniqueUID
21 3. File was not close properly in gdcmDict
22 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
23 5. Use of const ref instead of copy (speed issue)
24 6. Remove temporary (duplicate) string in TranslateToKey
25 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
26 8. Do not repeat virtual in subclasses
27 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
29 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
30 * Apply first patch toward better string comparison when dealing with broken
31 DICOM files. Essentially the string could be padded with a space instead
32 of a null character as defined by standard
34 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
36 because never used... and in the same time, that's remove some memory leaks
38 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * src/gdcmFile.cxx : now delete the PixelConvert instance.
40 * In examples and tests : change the type of image data variables from void*
41 to uint8_t*. Remmove all delete on image data variables
43 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
45 Verify the file pointer value before open the file, and if it's not null,
46 a verbose message is generated.
47 Close correctly the file when the file isn't considered dicom-like. The
48 correctly close is a call to CloseFile.
49 When closing the file pointer, test if its not null to close the file.
50 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
51 file. For an uncompressed image, the copied datas correspond in the least
52 case to the image size (calculated) or the image size specified in the
53 header. A verbose is generated if these two size mismatch
55 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
57 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
58 break under windows (with msvc6 compilation).
60 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
64 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Bugs fix for the Windows build with VC6
66 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
67 needed (only for projects required VTK). If the VTK is included in all
68 projects, there is conflicts with the jpeg lib of vtk when compiling the
69 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
70 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
71 when compiling the gdcm_wrap.cxx file (created by the compilation of the
73 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
74 (like it's already made for the cout use). Otherwise, conflict with the
77 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
78 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
80 - comments on the DicomDir::Method related usage added.
81 - now that we use the namespace gdcm, a lot of internal classes do
82 NOT need to be wrapped anymore.
83 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
84 DicomDir::Method) new example added.
86 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
87 * Improve string manipulation. I now inforce the notion of 'DicomString'
88 A DicomString can contain as many \0 as they want
89 and it is *always* of even length.
90 We only support odd length for very rare case.
91 And in the near future this should be removed.
93 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
94 * /binary_write/ gdcm source. Now even on big endian we are writting
95 little endian. This should -heopfully- fix some tests
97 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
98 * Now the dictionary is compiled into gdcm lib. This is a default
99 behavior, thus any dic file specified is picked before failback to
100 the one comiled into lib
102 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
103 * Change internals for gdcmDict. Don't use any 'new' any more.
104 This should definitely solve any leak problem, and we should be
105 as fast as before, as long as don't modify too much the dictionary.
107 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * STYLE: ivars should start with a capital letter.
109 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
110 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
112 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
113 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
114 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
115 new 2004 dictionaries added (thanks to JPR).
116 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
117 * CLEANUP_ROUND (15) for gdcmPixelConvert
118 - RLEFrame::NumberFragments is now of type unsigned int
119 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
120 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
123 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
124 * Initial work in gathering all transfer syntax accessors. clearly
125 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
126 ivars, but only one transfersyntax (class) ivar with equivalent method on
129 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
130 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
131 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
132 discussed (plus I didn't like having a 2000 lines patch not commited)
134 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
135 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
136 * CLEANUP_ROUND (14) for gdcmPixelConvert
137 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
138 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
139 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
141 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
142 anymore and hence avoids storing a copy of PixelConvert::Decompressed
143 into File::Pixel_Data.
145 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
146 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
147 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
148 * CLEANUP_ROUND (13) for gdcmPixelConvert
149 Substituted File::ParsePixelData() with PixelConvert::Print() new
151 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
152 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
153 method to those classes.
154 - src/gdcmFile.[cxx|h]:
155 -- Added a ::Print() method.
156 -- PixelConverter is now a reference instead of a member.
157 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
158 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
160 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
161 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
162 collaboration diagram and inheritance diagram should be generated with
164 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
165 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
166 pointlessly wrapped (see
167 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
168 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
169 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
170 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
171 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
172 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
173 -- File::Initialise: PixelConverter setup moved away to
174 PixelConverter::GrabInformationsFromHeader()
175 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
176 interpretation moved away to PixelConverter::BuildRGBImage()
178 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
179 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
180 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
182 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
183 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
184 displayed on Win32 when a brutal abort() occurs (because of uncatched
185 exception). See TODO new entry of this commit for more on this.
186 * TODO added new entry.
187 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
188 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
189 - HandleColor is no longer called from gdcmFile.cxx
190 - gdcmPixelConvert.cxx clean up on method arguments and internal
191 variable names for semantical coherence.
193 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
194 * Finished lossless transition, not only do we now read all lossless jpeg
195 images, without the need of the Cornwell lib, but we do read them properly now
196 * To reduce code (well to avoid code duplication), I defined a common place
197 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
198 redefine symbols. This is not prefect but this the best solution I found for a
199 compilation time jpeg option.
201 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
202 * Update jpeg ijg lib to support lossless jpeg implementation
203 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
205 * Also added a special copyright for dcmtk since we use their bugfixes.
208 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
209 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
210 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
211 matters, as stated in warning note at begining of %include section).
212 * src/gdcmDicomDir*.[cxx|h]: coding style
213 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
214 * src/gdcmJpeg8.cxx: doxygen fix.
215 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
216 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
217 from File:: to PixelConvert::.
219 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
220 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
221 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
222 - more code moved away from File:: to PixelConvert::
223 - fat setup of PixelConverter set in place in File::Initialise.
225 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
226 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
227 namespace at the file system level. So now you should convert your examples
229 gdcmHeader -> gdcm::Header
230 It would be nice if people keep in mind to no open the namespace, since it
231 allows compilation on broken plateform which were defining common symbol in
232 the standart namespace (like LP, Unknown ...)
234 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
236 The JPEG fragments are now parsed at the same stage than the RLE
237 information. All code related to JPEG is now in gdcmPixelConvert:
238 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
239 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
240 export a gdcmFile:: method. Those are simply global functions
241 (for the time being this is better than having them attach to
242 either gdcmFile:: or gdcmPixelConvert::).
243 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
244 and stores the result in a gdcmJPEGFragmentsInfo.
245 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
246 code (among other stuff) moved away from gdcmFile:; to
249 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
250 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
251 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
252 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
253 clean up of RLE related code.
254 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
255 - src/gdcmRLE.cxx removed
256 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
257 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
258 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
259 * CLEANUP_ROUND (9) for gdcmPixelConvert
260 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
261 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
262 away from gdcmFile:: to gdcmPixelConvert::.
264 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
265 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
266 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
267 This is because Parse7Fe0 used to parse the pixels to compute the
268 length. This task was passed over to FindDocEntryLengthOB() a long
269 time ago, EXCEPT I had forgotten the OW case...
270 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
271 we just recylce the code for parsing RLE fragments and computing
273 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
274 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
275 with the retired Parse7Fe0().
276 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
277 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
279 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
280 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
281 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
282 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
283 - src/CMakeLists.txt: alphabetic order reodering + new entries.
284 * CLEANUP_ROUND (4) for gdcmPixelConvert
285 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
286 to return an unused length.
288 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
289 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
290 this should be cleanner from the plane view. The iostream are erally a pain
291 to use to do simple stuff.
293 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
294 * Redo the compilation of the ijg jpeg library. Now only one source is
295 necesseray. No need to rename file by hand what so ever. CMake handle the
296 copying of the file within different directory, configure header file to
297 modify some symbol. The only addition made to ijg wasd a mangle table so
298 that symbol are different wether we are within 8bits or 12bits.
300 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
301 * Added documentation of vtkgdcmReader on Website:
302 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
303 with it's binary name).
304 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
305 the Website to be more complete.
306 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
307 doxygenated documentation.
308 - Doc/DoxyVtkGdcmReaderExamples.txt added
309 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
310 DoxyVtkGdmReaderExamples.html )
311 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
312 * CLEANUP_ROUND (3) for gdcmPixelConvert
313 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
315 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
316 * CLEANUP_ROUND (2) for gdcmPixelConvert
317 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
319 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * CLEANUP_ROUND for gdcmPixelConvert:
321 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
322 - src/gdcmPixelStuff[h|cxx] removed
323 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
324 - src/CMakeLists.txt changed accordingly
326 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
327 gdcmVersion.py moved to newly created ATTIC related
328 gdcmPython/SetupOldies/ directory.
329 * Autotools clean up:
330 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
331 - autogen.sh configure.in acinclude.m4 python.m4 removed
333 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
334 * src/*.cxx *.h Reference to License.htm fixed to License.html.
335 * Doc/CMakeLists.txt, doxygen.config.in: fix.
336 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
338 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
339 * TODO updated with Mathieu suggestions. I proposed a template for
340 describing TODO entries and used it for new entries.
341 * Added Doc/Website/CodingStyle.html, Developpers.html,
342 DeveloppersPython.html, GdcmDataCvs.html and
343 DownloadVersion0_1.html, DownloadVersion0_3.html.
344 * Some Doc/*.txt Doxygen files (which do not really concern the
345 documentation itself, but the website) moved to html and
346 placed in directory Doc/Website:
347 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
348 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
349 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
350 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
351 * CMakeLists.txt changed accordingly.
352 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
353 DeveloppersPython.html
354 * INSTALL nows refers to Doc/Website/Installation.html
356 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
357 * Added Doc/Website directory, that contains a first raw version
360 2004-09-23 Jean-Pierre Roux
361 * FIX In order not to be poluted any longer by casting problems,
362 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
363 we can now delete[] it safely
364 * VoidArea is now called BinArea (less confusing name),
365 and all the methods called ...VoidArea... are now ... BinArea...
366 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
368 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
370 clear) TagHT, which is an inherited member of gdcmElementSet. It is
371 up to the destructor of gdcmElementSet to clean up TagHt and it's
374 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * Test/CMakeLists.txt: update to follow gdcmData renamings.
376 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
378 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
379 * ENH: added some utility method that builds a flat dictionnary
380 holding all the Dicom entries contained in the recursive structure
381 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
383 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
384 BuildFlatHashTable() that build a flat dictionary.
385 - src/gdcmElementSet.h: added a new private GetTag() accessor.
386 gdcmDocument is now a friend of gdcmElementSet.
387 - src/gdcmElementSet.cxx: clean up.
388 - Example/FlatHashTablePrint.cxx added.
389 - Example/CmakeLists.txt changed accordingly
391 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
392 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
393 moved away from gdcmDocEntrySet (since this class is an abstract class
394 acting like an interface). SQDepthLevel and BaseTagKey are now
396 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
397 and associated accessors. Doxygenation of the class.
398 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
400 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
401 Use SQDepthLevel accessor instead. ::Print() adapted.
402 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
403 - src/gdcmDocument.cxx changed accordingly.
405 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
406 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
407 - The following is the doxygen comment of the typedef declaration
408 of gdcmagKey in src/gdcmCommon.h:
409 gdcmTagKey is made to old an "universal" (as in URL, Universal
410 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
411 A dicom tag allways has a group and an element, but a set of tags
412 embeded in various (optionally nested) sequences and sharing
413 the same group and element all share the same (group, element)
414 "identifier". Hence the (group, element) cannot be used as an
415 identifier (in gdcm we shall refer to a "TagKey") of a tag.
416 In order to construct a proper tag identifier (i.e. a key) we
417 consider the following definition of a TagKey:
418 - let Group, Element be the string representation of the
419 group and element dicom tag members,
420 - let ItemNumber be the string representation of the integer
421 index of the considered item number of a sequence,
422 Let the key of a tag embeded in a sequence, noted SeqTag, be
424 /ItemNumber#Group|Element
425 where "/", "#" and "|" are characters acting as separators.
426 Then the general form of a gdcmTagKey is given by:
427 Group|Element<SeqTag>
428 where <SeqTag> means NO or many instances of SeqTag.
429 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
432 but the gdcmTagKey of a tag "embeded" is the first item of
433 a sequence, itself nested in the third item of a sequence is the
435 0004|1220/2#0008|0082/0#0008|0090
436 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
437 order to hold the new sequence compatible key. Previously, the
438 GetKey() method would look in the underlying gdcmDictEntry.
439 - src/gdcmDocEntry.cxx:
440 -- constructor now copies the underlying DictEntry key, in the local
442 -- ::Print: displays the member Key, instead of the (group, element).
443 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
444 - src/gdcmDocEntrySet.h:xi
445 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
446 -- now has a new BaseTagKey member.
448 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
449 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
451 This poses the problem with the semantics of the following lines
452 LoadEntryVoidArea(0x0028,0x1201); // R LUT
453 LoadEntryVoidArea(0x0028,0x1202); // G LUT
454 LoadEntryVoidArea(0x0028,0x1203); // B LUT
455 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
456 to the long FIXME note for what the problem is. Nevertheless in
457 order to get things working the dicom dictionary was altered !
458 Please fix things urgently...
459 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
460 information), see above note on moving the member VoidArea. Nevertheless
461 the following entries previously correctly set as US are now inproperly
463 0028 1201 OW IMG Red Palette Color Lookup Table Data
464 0028 1202 OW IMG Green Palette Color Lookup Table Data
465 0028 1203 OW IMG Blue Palette Color Lookup Table Data
466 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
467 of gdcmDocEntry moved to gdcmSeqEntry.
468 * src/gdcmSeqEntry.cxx: STYLE.
470 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
471 * Test/TestAllEntryVerify.cxx minor fix and added comments.
473 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
474 * gdcmPython/testSuite.py: all the test suite in python is now moved
475 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
476 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
477 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
479 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
480 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
481 to avoid inclusion recursion until STL is reached.
482 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
483 mecanism. errno.h is not included in gdcm anymore.
484 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
485 (gdcmFormatError now inherits from gdcmFormatUnexpected).
487 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
488 gdcmData/TestAllEntryVerifyReference.txt
489 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
490 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
491 exception_on_error parameter.
492 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
493 - vtk/vtkGdcmReader.cxx changed accordingly,
494 - Example/*.cxx and Test/*.cxx changed accordingly.
496 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
497 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
498 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
499 enable_sequences removed from gdcmHeader constructor and dependencies.
500 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
501 * gdcmPython/demo/PrintHeader.py: dummy fix.
502 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
503 skip_shadow removed from gdcmHeader constructor and dependencies.
504 * Example/*.cxx and Test/*.cxx changed accordingly.
506 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
507 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
508 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
510 2004-07-21 Jean-Pierre Roux
511 * FIX Now, Parsing and Printing a DICOMDIR do work!
512 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
514 2004-07-20 Jean-Pierre Roux
515 * FIX Some brain damaged headers have Zero-Lenght fields
516 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
518 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
520 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
521 variable (instance of gdcmDebug) by a definition macro, and the instance
522 is now in static in the gdcmDebug class
523 * src/gdcmSQItem.h : (FIXME) remove an undefined method
524 * Test/PrintAllDocument.cxx : bug fix in the result of the test
526 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * WARNING: ctest now depends more tightly on gdcmData. You should
528 check out gdcmData properly for things to run smoothly...
529 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
530 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
531 we need the pixels not be loaded in order to use the ValEntry
532 that displays position and size).
533 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
534 This is a C++ based equivalent of gdcmPython/testSuite.py that should
535 be deprecated. If you have any doubts about the advantages of a
536 modern scripting language (read Python) versus grass root C++ (i.e.
537 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
538 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
539 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
540 Anyhow, consider documenting the gdcmData images in
541 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
543 * Test/CMakeLists.txt:
544 - now uses TestAllEntryVerify.cxx
545 - specific comments on oldACR00001.ima (now renamed in gdcmData
546 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
547 gdcmData/TestAllEntryVerifyReference.txt
550 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
551 * src/*.[h|cxx] : typedef clean up
552 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
553 - TagKey renamed to gdcmTagKey (for external usage)
554 - VRKey renamed to gdcmVRKey (for external usage)
555 - removal of typedef duplication.
556 - Removed all unecessary inline keyword from class inline definitions.
557 - Some method|function(void) declarations replaced with method|function().
558 * src/jpeg/libijg12/jdhuff12.c:
559 - printf polluting ctest removed.
560 - TAB removal for comminting
562 - TestAllReadCompareDicom.cxx: added a test that compares all the
563 images in gdcmDataImages.h with corresponding images in
564 gdcmData/BaselineDicom/. When baseline images are not present
565 this test creates them.
566 Note: we need to validate each reference image, but before that
567 I'd like to rename them with a more explicit name...
568 - CMakeLists.txt: changed accordingly.
569 * Example/*.cxx: examples now only include gdcm.h (as opposed to
570 including each header needed).
572 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * Test/*.cxx and Example/*.cxx: moved some examples away from the
574 test suite to the Example directory. Are concerned:
579 - TestWriteSimple.cxx
580 * Test/CMakeLists.txt: added some comments on reasons for black listing
581 image gdcmData/oldACR00001.ima
583 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * Test/CmakeList.txt: removed the following from black list (to be coherent
585 with removal from gdcmData):
586 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
587 - gdcm-MR-PHILIPS-16.dcm
589 Added the following because after last cvs update, they cause
590 ctest -R TestReadWriteReadCompare
592 - gdcm-MR-SIEMENS-16-1.acr
594 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
595 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
596 new comments in this file) we temporarily (sigh) move to a weaker
598 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
599 we don't need to black list the following images anymore:
600 - 8BitsUncompressedColor.dcm
602 - US-PAL-8-10x-echo.dcm
603 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
604 fixes and the beautified code ;-)
605 This fixes the bug introduced in version 1.42 (when beautifying)
606 that made the parsing of 8BitsRunLengthColor.dcm unproper.
607 Note: ctest was blind to this bug (this means we need to still
608 improve the test suite). The bug could be detected by using
609 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
611 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
612 and by displaying the (garbage) produced file temp.XDCM...
614 2004-06-29 Jean-Pierre Roux
615 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
616 - replace by uggly but working old code :-(
617 A lot of things should be OK again.
618 It's really urgent to have a test suite that *tests*,
619 to prevent Frog's beautifying sessions to break all the stuff
620 (twice, withing a fortnigh ...)
622 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
623 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
624 redundancy) to added Test/TestReadWriteReadCompare.cxx
625 * Test/CmakeList.txt: because the compare test of
626 Test/TestReadWriteReadCompare.cxx fails, the following images are
627 black listed: - 8BitsUncompressedColor.dcm
629 - US-PAL-8-10x-echo.dcm
630 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
631 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
632 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
633 and ad-hoc kludge. This kludge is now removed, and on encountering
634 such an image (OB field brain damaged) we set errno. Then in
635 ::FindDocLength() we "fix" the length as being ALL what remains
636 in the file (until EOF). We then proceed, hoping for the best...
637 This fixes a SegFault in ShowDicom when trying to write such an
639 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
640 (because TestWriteRead breaks on it, after a non conformal commit?).
641 ctest now runs properly, except for MakeDicomDir (which was allways
642 broken) and the Python related stuff (still not fixed).
644 2004-06-24 Jean-Pierre Roux
645 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
646 FIX : Test/TestReadWrite now iterates on all the file names
647 (instead of infinite loop)
648 ENH : Test/TestWriteRead now iterates on all the file names
650 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
651 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
653 2004-06-24 Jean-Pierre Roux
654 FIX : - now Write drops LUT Descriptors and LUTs (if any)
655 when SamplesPerPixel =3
656 - now Write is no longer confused by
657 'BitsAllocated = 12" and 'BitsStored=12"
658 - "UN" value representation Elements are now written correctly
659 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
660 ENH : - now gdcmHeader has its own Write methods
661 (in order to split the job that has not to be done
664 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
665 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
666 loop on the same image until memory went out.
667 Note: this means we still have gobs of memory loss in PrintDocument
668 * src/gdcmDocument.cxx: fixes problem on parsing on file
669 gdcmData/16BitsJpegLosslessGrayScale.dcm.
671 2004-06-24 Jean-Pierre Roux
672 FIX : Write - All the Sequences and Sequence Item are now written
673 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
674 is added a the end, when necessary.
675 - A lot of brain-damaged images, that were read correctly are
676 now written correctly
677 - length compatible BinEntry are now loaded correctly
678 (even for odd groups)
679 Note : only Explicit Value Representation was checked.
680 (question : is implicit VR really necessary for gdcm ?)
682 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * DEVELOPPER: added a proposition of coding style.
684 * src/gdcmDocEntry.h: removed every inline declaration (for test of
687 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
689 Use the gdcmDocEntry::Print() and Write() instead.
690 * src/gdcmDocument.cxx: bug fix.
692 2004-06-22 Jean-Pierre Roux
693 FIX : gdcmDocument.cxx
694 - Now we do recognize the JpegLossLess format (there was a misstyping in
695 code 'beautyfication' :-(
696 - Now we automaticaticaly load the Luts, if any
698 2004-06-22 Jean-Pierre Roux
699 In order : to write Sequences, whatever their imbrication level,
700 : to allow user to create his own Sequences
701 a lot of modif where necessary (adding, moving, or virtualising methods)
703 WARNING : save your own sources *before* cvs up !
706 ADD virtual void Write(FILE *fp, FileType filetype);
709 ADD virtual void Write(FILE *fp, FileType filetype);
710 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
713 ADD virtual void Write (FILE *fp, FileType filetype)=0;
714 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
715 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
716 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
717 ADD std::string GetEntryByName(TagName name);
718 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
720 std::string vr = "unkn",
721 std::string fourth = "unkn",
722 std::string name = "unkn");
723 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
724 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
725 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
726 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
727 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
728 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
729 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
730 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
733 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
734 ADD virtual std::string GetEntryByName (TagName tagName);
735 ADD virtual std::string GetEntryVRByName (TagName tagName);
736 REM virtual bool Write(FILE *, FileType);
737 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
738 FILE *_fp, FileType type);
739 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
740 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
741 REM virtual bool WriteEntries(FILE *_fp,FileType type);
742 REM virtual std::string GetEntryByName (std::string tagName);
743 REM virtual std::string GetEntryVRByName (std::string tagName);
744 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
745 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
746 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
748 std::string vr = "unkn",
749 std::string fourth = "unkn",
750 std::string name = "unkn");
751 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
752 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
753 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
754 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
757 ADD virtual void Write(FILE *fp, FileType filetype);
760 ADD virtual void Write(FILE *fp,FileType filetype);
763 ADD virtual void Write(FILE *fp, FileType filetype);
764 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
765 REM std::string GetEntryByNumber(guint16 group, guint16 element);
766 REM std::string GetEntryByName(TagName name);
769 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
771 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
773 The default constructor invoked by the line
774 gdcmHeader *f1 = new gdcmHeader( header );
775 was gdcmHeader::gdcmHeader(bool) instead of the expected
776 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
777 Hence the parsing wasn't executed... See also below.
778 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
779 as explicit constructor didn't do the trick to fix the above problem.
780 Could anyone explain why ?
781 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
782 properly calls gdcmValEntry::Print() (that was weed out from
783 code related to gdcmBinEntry).
785 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
786 * In order to fix memory leaks:
787 - Test/TestWriteSimple.cxx: added cleaning of free store through
789 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
790 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
791 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
792 (through the call to ::AddDicomDirMeta()) or the destructor
793 would crash when deleting uninitialized ::metaElems].
794 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
795 - src/gdcmDocument.cxx:
796 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
798 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
799 was causing memory leaks.
800 - src/gdcmSQItem.cxx:
801 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
802 cleanly handled with polymophism: sorry but my milage is low).
803 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
804 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
805 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
806 This avoids SegFaulting.
807 - src/gdcmSQItem.h: coding style.
809 - Test/TestWriteSimple still severely sucks. The output image content
810 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
811 damaged when displayed with vtkgdcmViewer.
812 - on memory leaks: TestWriteSimple leaks really less (see entry
813 of 2004-06-18 in Changelog file for the call to valgrind).
814 - on segfaults: ctest now passes all the tests but one (no more
816 * Erroneous leading white fix:
817 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
818 white[s] (as opposed to from >> xxx, that removes it [them].
819 - src/gdcmTS.cxx: ditto.
820 - gdcmPython/testSuite.py: dirty related kludge removed.
821 * src/*: remaining references to gdcmParser removed.
822 * src/*[cxx|h]: added copy[way]left header.
825 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * In order to fix writing of dicom files:
827 - Test/TestWriteSimple.cxx: a simpler example of writing.
828 - Test/CMakeLists.txt changed accordingly.
829 - src/gdcmDocument.cxx:
830 -- The destructor now recursilvely removes potential sequences.
831 -- Bug fix in ::IsJPEG2000()
832 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
833 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
835 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
836 to only declared) and build on top of
837 ::GetDocEntryByNumber(guint16, guint16).
838 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
839 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
840 for usage in destructor and treatement of promotion in
841 ::ReplaceOrCreateByNumber().
842 - src/gdcmSQItem.cxx: destructor should better handle his job.
843 Test/TestWriteSimple now runs (or at least it DOES something).
844 * We can now start hutting memory links. A good starting point is:
845 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
846 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
847 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
849 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * Valgrind note: after Mathieu Malaterre teached me how to read
851 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
853 Using gcc, you can force the STL to use malloc and to free memory as
854 soon as possible by globally disabling memory caching.
855 With 3.2.2 and later, you should export the environment variable
856 GLIBCPP_FORCE_NEW before running your program.
857 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
858 simply vanish (it is still not clear to me, whether this means that
859 STL std::string leaks or if valgrind believes it leaks...).
860 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
861 running bin/gdcmTests makeDicomDir):
862 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
863 - Test/makeDicomDir.cxx now properly traps empty lists and returns
865 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
866 SegFaulting (I drowned in DicomDir related code when trying to
867 understand why the list is empty...).
868 * src/gdcmDocument.h: first BSD license header try.
869 * Doc/License.txt added.
871 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
872 * src/gdcmDocument.[h|cxx]:
873 - Clean up of the Transfer related predicates. They are now all based
874 on new method isGivenTransferSyntax, that (should) handle properly
876 - general clean up, simplification, and coding style.
877 - Specific clean up of Parse7FE0() (umproperly named actually).
878 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
880 2004-06-14 Jean-Pierre Roux
882 - fix the display of Sequence Delimitor (SQDepthLevel pb)
883 - fix the display of SQItem ordinal number
884 - add the GetSQItemByOrdinalNumber method
885 - remove some useless never written private methods
887 2004-06-14 Jean-Pierre Roux
889 - adding a constructor taking a gdcmDocEntry as an input param
890 - ReplaceOrCreateByNumber now returns :
891 a gdcmBinEntry * if a Binary (void *) value is passed as a param
892 a gdcmValEntry * if a string value is passed as a param
894 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
895 according to the param type (no longer sets a gdcmDocEntry)
896 - GetValEntryByNumber, GetBinEntryByNumber added
897 - NewValEntryByNumber and NewBinEntryByNumber added
899 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
901 - GetSQItemNumber and SetSQItemNumber added, to provide
902 a (relative) Item identier inside a given Sequence
903 \warning : some pb remaining around this number
905 - AddEntry now takes the Item Number as a param
907 - adding a constructor taking a gdcmDocEntry as an input param
909 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
910 * Memory leak hunt with the following command:
911 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
912 --show-reachable=yes gdcmTests PrintDocument
913 It looks like many (all?) leaks are due to the STL (or a bad usage
914 of the STL. The lines producing the leaks now have a comment with
915 a "MEMORY LEAK" tag: you can retrieve them with
916 grep "MEMORY LEAK" src/*
917 Here are two typical examples which I can't help fixing:
922 char * test = "babo";
923 name = test; //// <--- valgrind detects 960 bytes lost in
924 //// call to std::string::operator=(char const*)
925 name.clear(); //// Doesn't help !
933 std::cout << "Type a bunch of characters followed by RETURN: ";
934 getline(std::cin, line); //// <--- valgrind dectects a loss
935 //// of 1320 bytes in call to
936 /// std::basic_istream<>& std::getline<>
942 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
943 * src/gdcmHeader.[cxx|h]:
944 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
945 and related, moved away to gdcmDocument.
946 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
947 the corresponding protected accessors of inherited class
948 gdcmDocument, removed ! As a consequence gdcmFile had to be
949 declared friend of class gdcmDocument (see below).
950 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
951 - Clean up of undefined or unused methods.
952 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
953 account the changes to gdcmHeader.h).
954 * src/gdcmDocument.h:
955 - gdcmFile is now a friend class (in order to take into account the
956 changes to gdcmHeader.h).
957 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
958 (see changes to gdcmHeader.h).
959 - Accessors (reading on the form GetEntry*) are now public.
960 - Clean up of undefined or unused methods.
961 * src/gdcmDocument.cxx:
962 - adaptation to changes to gdcmDocument.h
963 - ::OpenFile now writes a verbose message when file cannot be opened.
964 - some std::string properly set to VRKey
965 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
966 references to gdcmDocument.
967 * Test/TestFindTags.cxx: changed accordingly to above changes.
968 * gdcmPython/testSuite.py: adapted to renaming of acr files in
969 cvs repository gdcmData.
971 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
973 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
974 conflicts with gdcmValEntry::voidArea.
975 * src/gdcmValEntry.cxx: unmatching comment wiped out.
976 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
977 Value representation between StringRepresentable and BinaryRepresentable.
978 * src/gdcmDocument.cxx:
979 - method ParseDES: proper indentation restored and usage of
980 gdcmVR::IsVROfGdcmStringRepresentable wired in.
981 - method LoadDocEntry: the fingerprint left in the SetValue() of
982 unloaded entries (length > MaxSizeLoadEntry) had curiously been
983 removed. Reverting to previous code segment with the proper
984 dynamic_cast< gdcmValEntry* >.
985 Note: this was (partially) breaking the python test suite
986 (gdcmPython/testSuite.py) that made usage of the above
987 fingerprint to check presence of "Pixel Data".
988 * src/gdcmDocEntry.h: coding style.
989 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
990 now taken into account.
991 * gdcmPython/gdcm.i: adaptation to the new internal representation
992 of gdcm (exit gdcmParser, hello gdcmDocument).
993 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
995 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
996 anymore, but instead prints the loaded Python dictionary.
997 * .... alas, the python testSuite is still broken.
999 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1000 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1002 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1003 * src/gdcmUtil.h : export methods
1005 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1006 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1008 * Initial addition of automatic python testing
1009 * Initial addition of automatic image comparison
1011 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1012 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1013 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1015 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1016 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1017 * Test/ShowDicom.cxx : bug fix for msvc compilation
1018 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1020 2004-05-04 Jean-Pierre Roux
1021 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1022 new concepts (and new classes) :
1023 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1024 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1025 - Sequence Doc Entries (gdcmSeqEntries)
1026 a Sequence is composed of Items.
1027 Each item is a set of Doc Entries (this is recursive)
1028 The non uniqueness of the 'Dicom tag' is due to this recursivity
1029 (never taken into account)
1030 Our unability to add a new 'entry' in the header
1031 at the proper location (neither in the H-Table (map or multimap),
1032 nor in the Chained List is also due to this recursivity.
1033 Don't try, right now, to use/modify/compile these new sources :
1034 nothing is finished.
1035 We just commit all the stuff, 'as is', in order not to loose it.
1037 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1038 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1040 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1041 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1042 file prefix (SetFilePrefix)
1044 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1045 * Add a new test: ShowDicom, for now this is just the c++ version of
1046 checkRead.sh, later it will be able to compare the image read against a
1048 * Replace the DEBUG on the stack with a global entry in cmake interface:
1049 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1051 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1052 * Add an example subdir, with a real example on how to read + write a
1055 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1056 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1057 * Doc/CMakeLists.txt: the main page is now properly differentiated
1058 between the developper and user version.
1059 * Doc/doxygen.config.in: dropped search related obsolete flags
1060 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1062 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * DEVELOPPER: added some helpfull comments for compile/test/install
1066 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1067 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1068 src directory, now generated in the build dir.
1069 2. Tests as mentionned smarter
1071 4. Add a new method in gdcmDict that return the PubDict by name
1072 this is interesting for 3rd party lib like ITK,
1073 where we could set the institution name / patient name...
1075 * ENH: 1. Now the test suite is working for real
1076 2. All binaries are now output in the gdcm-bin directory
1077 (this was not true before)
1079 2004-04-28 Jean-Pierre Roux
1080 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1081 SeQuence indented printing of Dicom Header.
1082 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1083 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1084 Computation of SQDepthLevel is now part of gdcmHeader constructor
1085 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1086 tree-like structure of a Dicom Header.
1087 * FIX Test code cleaning
1089 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1090 * ENH: Adding automatic testing
1091 1. Need a DartConfig.cmake to submit to public
1092 2. Add a test driver gdcmTest.cxx
1093 3. gdcmTestMain, an helper for the main test driver gdcmTest
1094 4. Files in Test don't have a main anymore, this becomes interesting
1095 when we add more and more tests, thus dsw don't have to load
1097 * ENH: Adding a GDCM_DATA_ROOT for testing
1098 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1099 one file instead of seven + some small cleanup
1101 2004-04-22 Jean-Pierre Roux
1102 * ENH Minor changes to the Print() methods.
1103 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1104 Header printing. Example given with :
1105 > PrintHeader fileName 2 new
1106 (SQ based tree-like structure still to be done for the Header ...)
1108 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1109 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1110 1. I have added some unsigned where needed
1111 2. Some function parameter not used -> (void)
1112 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1113 4. g++ don't like character '\' in comment
1114 5. #define jpeg_create_decompress jCreaDecompress
1115 this really need to be fixed
1116 6. virtualize destructor of gdcmObject ... leakage
1117 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1118 this also really need to be fixed
1119 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1120 remove compression file
1121 (as we only do decompression, right ?)
1122 * ENH: Change malloc/calloc/free with c++ equivalent
1124 2004-04-21 Jean-Pierre Roux
1125 * FIX gdcmHeaderHelper::GetXSpacing
1126 when a single value is found (bug ?), xpacing is now
1127 defaulted to yspacing
1129 2004-04-19 Jean-Pierre Roux
1130 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1131 * ENH add parameters :
1132 bool exception_on_error = false,
1133 bool enable_sequences = false,
1134 bool ignore_shadow = false
1135 to the gdcmFile constructors to be full gdcmParser compliant
1136 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1137 to allow reading of PAPYRUS 3.0 files
1139 2004-04-06 Jean-Pierre Roux
1140 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1142 2004-04-02 Jean-Pierre Roux
1143 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1144 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1145 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1147 2004-03-30 Jean-Pierre Roux
1148 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1149 for ACR file, written out as DICOM files (hope so...)
1151 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1152 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1153 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1154 moved to base class gdcmParser and only the specialisation is kept
1156 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1157 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1158 already does the job.
1159 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1160 (to be consistent with gdcmParser::WriteEntries).
1162 2004-03-30 Benoit Regrain
1163 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1164 upate of the object's instance. It's passed to 2 in the unfavorable
1165 case : one in the ExecuteInformation, one in the ExecuteData
1167 2004-03-29 Jean-Pierre Roux
1168 * ENH : Check on file type to be written moved
1169 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1170 * FIX : gdcmObject::ResetBoundaries now stops properly
1171 when end-of-list is reached
1172 : gdcmVersion modified (as Benoit Regrain asked)
1174 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1176 * src/gdcmUtil.cxx: added forgotten iostream include.
1177 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1178 equivalent to ExplicitVR in existing code).
1180 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1181 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1182 now contains all the gdcmGlobal related code.
1183 * minor coding style and doxygenation changes.
1185 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1186 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1187 now contains all the Debug related code.
1188 * minor clean-up of includes in src/*.cxx
1189 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1190 CreateCleanString) removed.
1191 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1192 * Doc/DoxyMainPageUser.txt added.
1193 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1194 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1195 src/gdcmDirList.cxx)
1197 2004-03-24 Jean-Pierre Roux
1198 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1200 2004-03-23 Jean-Pierre Roux
1201 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1202 big endian made volumes
1203 * ENH Now gdcmParser constructor and destructor are protected to forbid
1204 end user to instanciate class gdcmParser
1205 (only gdcmHeader and gdcmDicomDir are meaningfull)
1207 2004-03-22 Benoit Regrain
1208 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1209 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1210 gdcmSerie to gdcmDicomDirSerie
1212 2004-03-19 Jean-Pierre Roux
1213 * ENH Now the tree-like structure describing a DICOMDIR comming from
1214 an already existing DICOMDIR file is consistent with
1215 the home-made tree-like structure build ex-nihilo
1216 or build from the files held (recursively) in a Directory
1217 functions gdcmDicomDir::CheckBoundaries()
1218 gdcmObject::SetBoundaries() added
1220 2004-03-17 Jean-Pierre Roux
1221 * REM (Eric Boix bug) : removal of meaningless
1222 gdcmDicomDirImage::NewImage function.
1223 * FIX now file names and directory name are written properly in the
1225 * FIX now gdcmDicomDir constructor may be call without any trick
1228 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1229 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1230 of gdcmDicomDirImage::NewImage as empty function.
1232 2004-02-28 Jean-Pierre Roux
1233 * ENH add gdcmDicomDir:NewPatient
1234 add gdcmDicomDirPatient:NewStudy
1235 add gdcmDicomDirStudy:NewSerie
1236 add gdcmDicomDirSerie:NewImage
1237 to allow making gdcDicomDir object.
1238 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1239 (as opposite to the gdcmHeader chained list)
1241 2004-02-11 Benoit Regrain
1242 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1243 when using from python
1245 2004-02-10 Benoit Regrain
1246 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1247 * FIX : in gdcmDicomDir when the directory is empty
1248 * ENH : add callback and methods to get the progression of dicomDir
1251 2004-02-06 Jean-Pierre Roux
1252 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1253 - GDCM_META added to gdcmDicomDirType
1254 - class gdcmMeta created
1255 * ENH : - A brief summary is now displayed at the beginning of
1256 'testDicomDir' to help disaster magnitude estimation
1257 * REM : Now useless Test/explDICOMDIR.cxx
1259 2004-02-05 Benoit Regrain
1260 * ENH : add methods in gdcmObject to get the hash table or the list of
1262 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1263 * FIX : wrapping python for TagHeaderEntryHT
1265 2004-02-04 Benoit Regrain
1266 * FIX : even length for some strings when writting the dicom dir
1267 * FIX : sort the images in the dicom dir
1268 * FIX : Bug fix for python use of dicom dir
1269 * ADD : a python demo
1271 2004-02-04 Jean-Pierre Roux
1272 * FIX : Final solution (?) for icone embedded images
1273 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1274 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1275 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1276 gdcmData/gdcm-MR-SIEMENS-16.acr1
1277 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1278 to make full checking easier
1280 2004-02-04 Benoit Regrain
1281 * FIX : WriteEntries : coding style & logic in parameters
1282 * FIX : Set the elements to create the DicomDir in a dictionary file
1284 2004-02-03 Benoit Regrain
1285 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1286 * gdcmDicomDir : add the load of directory
1287 * Bug fix and print add-on
1289 2004-02-03 Jean-Pierre Roux
1290 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1291 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1292 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1293 * FIX gdcmParser.cxx : 'group length' elements are now considered
1294 as integers, even for shadow groups, when file is Implicit VR
1296 2004-02-02 Jean-Pierre Roux
1297 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1299 of the last synonym :-(
1300 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1302 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1303 * FIX taking into account the possible 7fe0,0010 multiplicity
1304 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1305 to allow removal of references to 7fe0,0010, to deal with
1306 ACR-NEMA images, when 0028,0200 is meaningfull
1308 2004-01-31 Jean-Pierre Roux
1309 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1310 no longer writes 'Un' on disk
1311 * FIX SQ elements with actual length are now dealt with corectly
1312 * FIX gdcmFile::WriteBase make the difference, for color images, between
1313 the length (for Palette expanded images)
1314 and Raw Length (non expanded image + Palette)
1315 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1316 (that broke Write). Replaced by UL.
1317 Aware user will reload the field if he
1318 thinks it's necesssary
1320 2004-01-30 Jean-Pierre Roux
1321 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1322 when 'dirty Acr' is found, to be compliant with the new
1323 IsReadable() methods.
1325 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1326 (no DOUBLE images in kosher DICOM,
1327 but so usefull for people that miss them ;-)
1329 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1330 DICOMDIR related utilities (not checked as Windoze compliant)
1332 2004-01-28 Jean-Pierre Roux
1333 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1335 2004-01-27 Jean-Pierre Roux
1336 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1337 to allow skipping the shadow elements, to save memory space.
1338 The TRUE value for this param has to be used
1339 with a FALSE value for the 'enable_sequence' param.
1340 ('public elements' may be embedded in 'shadow Sequences')
1341 * gdcmHeader methods now deal with 'embedded icones images' in the header
1342 (even when an 'icone image sequence' is announced by the
1343 element (0x0088,0x0200), but there is NO icone at all ...
1345 * gdcmHeader sometimes Image Location value doesn't follow
1346 the supposed processor endianity (see gdcmData/cr172241.dcm).
1349 * gdcmHeader add the method
1350 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1351 to get *all* the Header Entries with the same tag.
1352 GetHeaderEntrySameName is probabely *useless*
1353 (no meaning : Name is *not* an identifier within the Dictionnary)
1355 2004-01-26 Benoit Regrain
1356 * Bug fix in the print of hexadecimal representations. Remove long fields
1357 in the print and add a third level of print to print them
1359 2004-01-23 Benoit Regrain
1360 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1361 * Bug fix on test suite after remove the strip made on not string fields
1362 * Split the IsReadable method between gdcmParser which test that the file
1363 is dicom and gdcmHeader which test that it's an image file
1365 2004-01-22 Benoit Regrain
1366 * DicomDir : clean code, add methods, set variables in protected or private
1367 * gdcmUtil : bug fix for the clean string method
1369 2004-01-19 Benoit Regrain
1370 * Add the use of shadow dictionaries
1371 * bug fix and coding style
1373 2004-01-19 Benoit Regrain
1374 * src/gdcmFile.cxx : bug fix concerning the close of file
1375 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1376 * Add the update of header entries using the shadow library
1378 2004-01-19 Benoit Regrain
1379 * removal of file gdcmHeader2.cxx
1380 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1381 inheriting from gdcmParser. This split is to prepare the integration
1382 of dicom dir parsing
1383 * bug fix under python
1385 2004-01-16 Jean-Pierre Roux
1386 * REM removal of class gdcmHeaderEntrySet
1387 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1388 * ADD add file gdcmHeader2.cxx
1389 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1391 2004-01-15 Benoit Regrain
1392 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1393 entries created while parsing the header. Thus, they will be destroyed
1394 when the gdcmDictSet will be destroyed
1395 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1398 2004-01-15 Benoit Regrain
1399 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1400 made a fatal error because of the memory release at the end of program.
1401 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1402 some memory and vtk seems to have some problems with that.
1403 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1405 2004-01-14 Benoit Regrain
1406 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1407 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1408 * src/*.[h|cxx] : make changes due to class name changes
1409 * gdcmPython/demo/*.py : bug fix due to method names
1411 2004-01-13 Benoit Regrain
1412 * src/*.[h|cxx] : coding style
1413 * vtk/*.[h|cxx] : coding style
1415 2004-01-13 Benoit Regrain
1416 * gdcmPython/testSuite.py : test the readable flag of file for tests
1417 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1418 It's lied to the stl compilation by MSVC (windows, always windows...)
1419 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1421 2004-01-12 Benoit Regrain
1422 * src/*.h : add comments
1423 * src/gdcmDictSet.h : set the method BuildDictPath in public
1424 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1425 directly setted in the source code
1426 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1429 2004-01-09 Benoit Regrain
1430 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1431 * setup.py : use a reference to gdcmVERSION
1433 2004-01-07 Benoit Regrain
1434 * Modification to compile with the distutils.
1437 2003-12-10 Benoit Regrain
1438 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1439 can use a gdcmHeaderHelper to load datas
1440 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1441 made in the source code
1443 2003-12-10 Benoit Regrain
1444 * Update Windows projects and .cvsignore files
1446 2003-11-12 Jean-Pierre Roux
1447 * ENH gdcmHeader constructor has one more parameter (default value : false)
1448 that allows the user to 'go inside' the SeQuences only
1450 gdcmElValSet:Print takes it into account
1452 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1453 * ENH: Update gdcmPython/CMakeLists
1454 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1455 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1457 2003-11-10 Jean-Pierre Roux
1458 * FIX : gdcmHeader::LoadElements is now based
1459 on the ListTag listElem member,
1460 not longer on the TagElValueHT tagHt member
1461 * ENH : PrintPubElVal shows (temporarily) both results,
1462 with the tagHt member and the listElem member.
1463 (it's easier to 'see' the problems when using Printheader)
1465 * FIX : old private member LgrElem is now splitted into
1466 ReadLength : Length actually found on disk (updated only
1467 if bug fixing is necessary), for internal
1469 UsableLength : Updated by FixFoundLength, to fix a bug
1470 or to allow Parser going on.
1471 Will allow to re-write a kosher header when a SeQuence
1472 with a length (not 0000) is found
1473 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1474 because gdcmElValSet::Add does not update ListElem
1477 2003-11-07 Jean-Pierre Roux
1478 * FIX misstyping in Transfert Syntax name table
1479 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1480 when they have an actual length (not 0000 nor FFFFF)
1481 (Nobody should care of it, but DICOMDIR explorers)
1483 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1484 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1486 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1487 * ENH: vtkGdcmReader now supports LUT !
1488 (vtkgdcmViewer for now is not able to use them though)
1490 2003-11-05 Jean-Pierre Roux
1491 * in testSuite.py : new files names for checking the package
1492 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1493 that returns the pixel area size to the *aware* (vtk) user
1494 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1496 2003-11-05 Benoit Regrain
1497 * in testSuite.py : Modify the rules for checking the paths
1498 : Explicit error messages
1499 * in __init__.py : Related modif
1501 2003-11-03 Jean-Pierre Roux
1502 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1503 to be used by aware (vtk) users that want to manage
1504 LUT (and no to turn the PALETTE image into an RGB pixels one)
1505 * GetPixelType now returns 8U for 24 Bits images
1506 (vtkGdcmReader compliant)
1508 2003-10-31 Jean-Pierre Roux
1509 * Removal of *all* gdcmData images and add them again
1510 in order to loose the 'history' of un-anonymised images
1512 2003-10-31 Jean-Pierre Roux
1513 * RMV : removal of useless jBitsInJsample.h
1514 for both 8 and 12 Bits JPEG Lossy Libraries
1516 2003-10-31 Jean-Pierre Roux
1517 * ENH : Add the functions gdcmFile::GetImageDataRaw
1518 gdcmFile::GetImageDataIntoVectorRaw
1519 that act as GetImageData and GetImageDataIntoVector
1520 except the making of an RGB Plane from Gray Plane + LUT
1521 Intended to aware (vtk) users who know how to manage
1524 GetLUTRGBA return a R,G,B,A LUT if any
1525 lgrTotaleRaw gives the 'Raw' length
1526 GetImageDataRaw returns the gray Plane
1527 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1528 (They stay Grey, just like with other Dicom viewers :-(
1530 2003-10-30 Jean-Pierre Roux
1531 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1533 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1534 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1535 being coherents dicom files.
1537 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1538 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1540 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1541 * ENH: Two steps is necessary to please VC++ compiler...
1542 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1543 * ENH: Add include dir to medcon lib
1544 * FIX: only one function is being exported for now !
1545 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1547 2003-10-29 Jean-Pierre Roux
1548 * adding gdcmHeader::GetLUTRGBA
1549 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1550 --> Mathieu, the modif u're waiting for is not yet committed
1551 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1553 2003-10-27 Jean-Pierre Roux
1554 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1555 00191113.dcm DermaColorLossLess.dcm
1556 MxTwinLossLess.dcm RadBWLossLess.dcm
1557 * ENH: For version prior to vtkImageViewer2 -r 1.19
1558 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1560 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1561 * Removal of ido stuff in CMakeLists.txt
1563 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1564 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1565 * FIX: remove a call to ->Modified ... see comments
1566 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1568 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1569 * FIX: Problem with path for libvtkgdcmPython
1570 * ENH: Try adding a search script for python site-package
1571 * RMV: Remove some file from medcon lib that are not necessary
1572 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1573 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1574 * FIX: More pragma disable fro VC++,
1575 I don't think I break something as it is also disable in VTK/ITK.
1576 But it fasten debug compilation time.
1578 2003-10-23 Jean-Pierre Roux
1579 * gdcm now deals with 16 Bits Run Length Encoded images
1580 (they are compressed as 2 planes images,
1581 one for the high Bytes, the other for low Bytes)
1583 2003-10-22 Jean-Pierre Roux
1584 * Now CheckRead takes into account :
1585 - the bugged 'Leonardo' Siemens images
1586 - the XA images, sent thru the burning VPRO station
1587 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1590 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1591 * FIX: When copying a Makefile.am to CMakeLists.txt
1592 one should remove the '\'
1594 2003-10-22 Jean-Pierre Roux
1595 * in gdcmData adding a bugged 'Leonardo' Siemens image
1596 (wrong lengths in header)
1597 OK with gdcm, KO with the other viewers :-)
1598 * add a GE dlx XA image, thru the VEPRO burning station
1601 2003-10-21 Jean-Pierre Roux
1602 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1603 for a brutal checking of vtkgdcmViewer compliance
1605 2003-10-21 Jean-Pierre Roux
1606 * add the files for 'xmedcon' Jpeg Lossless library
1607 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1609 2003-10-21 Jean-Pierre Roux
1610 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1612 2003-10-21 Jean-Pierre Roux
1613 * garbage Siemens 'Leonardo' images dealt with
1614 (the patch is easy to remove)
1615 * cosmetic changes to avoid warnings
1617 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1618 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1619 no need to press 'r' now.
1621 2003-10-20 Jean-Pierre Roux
1622 * upgrade of checkRead.sh checkWrite.sh according
1623 to new Jpeg Lossless decompressor
1624 * add US.3405.1.dcm, a genuine RGB medical file ...
1625 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1626 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1628 2003-10-15 Jean-Pierre Roux
1629 * general anonymisation in gdcmData
1630 * adding the 'color files' from
1631 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1632 * adding some well knowed bugged-header images
1633 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1634 waiting for their inclusion in Python testsuite
1636 2003-10-15 Jean-Pierre Roux
1637 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1638 no longer seg faults when file is not found
1640 2003-10-14 Jean-Pierre Roux
1641 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1644 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1645 * TODO: *.in file to genereate a UseGDCM later
1647 2003-10-14 Jean-Pierre Roux
1648 * Some supposed-to-be Dicom Images have no preamble.
1649 OpenFile takes it into account
1650 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1651 * Missing elements added in dicomV3.dic
1652 (just to be affraid : have a look at
1653 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1654 and do it again next year ;->
1656 2003-10-13 Jean-Pierre Roux
1657 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1658 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1659 But there are NOT. It's fixed !
1661 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1662 * FIX: "jpeglib.h" was not found on VC++
1663 * FIX: vtkgdcm was not being installed
1665 2003-10-10 Jean-Pierre Roux
1666 * ENH : OpenFile closes the file if it *really* doesn't look like
1667 an ACR-NEMA / DICOM one.
1668 * FIX : testWrite no longer writes an empty file if the source file
1669 is not gdcm Readable
1670 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1673 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * FIX: CMake generate now documentation
1675 * ENH: out of source doc build !
1676 * ENH: Generate both user and dev documentation
1677 * ENH: Should work on windows too
1678 * ENH: Only one doxygen config.in file is needed
1679 * FIX: make install should be ok now on ùnix plateform
1680 * FIX: PATH to dictionary was wrong (missing /)
1681 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1683 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1684 * vtkGdcmReader is now able to read rgb dicom file.
1685 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1686 * added a gdcmViewer to vtk test, use mouse to control
1687 window level & window width
1689 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1690 * CMake-ification of gdcm, we have now two build system
1691 * FIX: on cygwin Wsock32 doesn't exist
1692 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1694 2003-10-06 Emanuel Ollart
1695 * FIX : compilation process wad broken.
1696 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1698 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1699 * change gdcmViewer -> vtkgdcmViewer
1700 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1702 2003-10-06 Jean-Pierre Roux
1703 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1704 ( e.g : well known GE images with a wrong elem length,
1705 : Philips MRI Images with a wrong Huffman table)
1706 * still to be done : allow the reading of bugged LEONARDO Siemens images
1708 2003-10-03 Jean-Pierre Roux
1709 * Odd length strings are padded with '\0' (not with spaces,
1710 to remain compliant with already defined strings,
1711 like Transfert Syntax UID and others)
1713 2003-10-03 Jean-Pierre Roux
1714 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1715 to allow displaying RGB images (not only by affim ;-)
1717 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1718 * vtkGdcmReader is now able to read rgb dicom file.
1719 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1721 2003-10-03 Jean-Pierre Roux
1722 * A few nasty patches to allow the reading of a lot of nasty images
1723 ( e.g : well known GE images with a wrong elem length,
1724 : Philips MRI Images with a wrong Huffman table)
1725 * still to be done : allow the reading of bugged LEONARDO Siemens images
1727 2003-10-03 Jean-Pierre Roux
1728 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1730 2003-10-03 Jean-Pierre Roux
1731 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1732 to allow displaying RGB images (not only by affim ;-)
1734 2003-10-03 Jean-Pierre Roux
1735 * gdcmFile::GetImageDataIntoVector now
1736 - deals with MultiFrames MultiFragments Run Length Encoded files
1737 - deals with YcBcR (YBR_FULL) files
1738 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1739 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1741 (no sample found :-(
1743 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1744 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1745 Two reasons: - clear things
1746 - third parties acces gdcm through header files, so won't
1747 suffer anymore VC++ complains
1749 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1750 * add argv[1] in testvtkGdcmReader.cxx
1753 2003-09-24 Jean-Pierre Roux
1754 * The lines are now eigthy characters long.for
1755 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1757 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1758 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1759 char* to std::string. Thus, the use of strdup becomes useless. (see
1760 previous commis of Malaterre)
1761 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1762 before the last Malaterre's commit.
1764 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1765 * This commit should fix the Debug building under VC++, the problem
1766 was mainly a mixture of debug and release lib being loaded at startup.
1767 * I also remove a depency to a specific C function: strdup. Because I had
1768 to force the link to msvcrtd (whereas strdup is in libc).
1770 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1771 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1772 located in the gdcmCommon.h file. All use of reference of tha has been
1773 changed to now use the variable GDCM_UNFOUND.
1775 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1777 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1778 Dicom dictionary. The test suite can now be run again. Note:
1779 I'm note very happy with the " (RET)" changes. I believe this
1780 RETAINED comment should be dropped when parsing the dictionary.
1781 - PACKAGER corrected
1783 - AUTHORS updated and now in alphabetical order
1784 * Makefile.am now exports gdcm.dsw for Windoze users.
1786 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1787 * cygwin complains about missing std:: in subdir Test/
1789 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1790 * remove some methods that are now in gdcmHeaderHelper
1792 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1793 * vtkGdcmReader set spacing and origin correctly
1795 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1796 * Fix a few delete/delete[] mismatch
1798 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1799 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1800 interpretation to data given by gdcmHeader. For instance there are
1801 heuristics to get informations (look at different places).
1802 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1803 sorting DICOM images based on different strategies.
1804 * modified Makefiles accordingly.
1806 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1807 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1808 when building in debug mode
1809 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1810 src/win32/gdcmdll.dsp
1811 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1813 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1814 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1817 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1818 * src/win32/libgdcmjpeg12.dsp was not dos format
1819 * src/win32/libgdcmjpeg12.dsp :
1820 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1821 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1823 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1824 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1826 * src/gdcmFile.cxx : bug fix in affectation type
1827 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1828 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1829 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1830 symbols... future problem ?
1832 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1833 * src/win32/libgdcmijpeg12.dsp was missing
1834 * modified gdcm.dsw accordingly
1836 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1837 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1839 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1840 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1841 commit of JPR (before his hollidays to facilitate our work).
1842 * setup.py : bug fix in code. Modifications made while the last commit
1843 of JPR. The code hasn't been tested before the commit... it's so
1844 useless to make that (for best programmer that is JPR) !!!
1846 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1847 * tagged the current version as Version0_3 (i.e. version 0.3)
1849 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1850 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1851 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1852 * *.dsp : modifications to use new libgdcmijpeg8 library
1853 * setup.py : bug fix on VTKPATH variable
1854 * PACKAGER : adding all concerning windows
1856 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1857 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1859 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1860 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1861 test suite reported error.
1862 * PACKAGER file added (describes what a packager must do when
1863 packaging a new release).
1864 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1865 * configure.in: upgraded version number to 0.3.0
1866 * fixing build of rpm (through rpm -ta):
1867 - Doc/Makefile.am exports proper doxygen files
1868 - src/jpeg/libijg8/Makefile.am exports the include files.
1870 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1871 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1872 * src/gdcmHeader.h : formatting code
1874 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1875 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1876 We were obtaining error message from vtk. Now, creation of file list
1877 is made in an internal list to prevent this problem.
1878 Bug fix when output is empty.
1879 Bug fix in update of progress value. Previous commit for this was a bad
1881 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1883 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1884 * src/gdcmHeader.h : added method to get the file name
1885 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1886 files. Added method to remove all files on the input
1887 Added FIXME comment concerning the bad parsing of header made by
1888 ExecuteInformation method (in ExecuteData method)
1890 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1892 when using make instal.
1893 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1894 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1896 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1897 * setup.py : adding include dir of jpeg lib to compile all sources
1898 * */Win32/*.dsp : JPR fix for windows compilation
1900 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1901 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1903 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1904 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1906 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1907 * setup.py is again effective on un*x (takes into account the
1908 addon of the jpeg library)
1909 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1910 * Doc/Doxy* updated (includes above enhancements)
1911 * INSTALL now points to web documentation
1913 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * src/gdcmHeader.h doesn't make unnecessary reference to
1916 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1918 * src/gdcm*.[cxx|h] :
1919 - to allow compilation with gcc 3.x
1920 -- clean up of STL usage (added explicit usage of std::)
1921 -- small fixes on exceptions.
1922 Note: linking not tested !
1923 - clean of doxygen comments to avoid warnings at documentation
1925 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1926 dependent convertion).
1928 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1929 * Clean up of previous JPR garbage commit (not even commented in the
1931 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1932 - moved all jpeg related files from src to src/jpeg/libijg8, with
1933 addition/modification of Makefile.am and configure.in.
1934 - the testSuite is still brain damage (not guilty).
1936 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1937 * WrapVTK.py : modifications to get correctly vtk source files to
1939 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1940 (FileName -> Filename)
1942 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * vtk/vtkGdcmReader.[cxx/h]:
1944 - UpdateProgress method should now be effective
1945 - removed the limitation on having only images loaded (as opposed
1947 - when building a stack of images/volume, a lesser number of
1948 gdcmHeader and gdcmFile instances should be used (hopefully
1949 accelerating things).
1950 - when building a stack of images/volumes, files which are not
1951 loadable (wrong path-filename, wrong permissions on existing file,
1952 or file not parsable by gdcm) are replaced with a black image
1953 in the stack (for the caller to notice the problem).
1955 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1956 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1958 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1959 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1960 between standard library (std) and vtk library (problems are found
1961 under Windows... thanks Windows !)
1963 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1964 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1966 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1968 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1971 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1972 * When compiling with distutils (see setup.py) the C++ compiler is
1973 called with different flags than the default ones (with automake).
1974 In order to fix all those warning, I compiled gdcm with the command
1975 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1976 and went for warning fixes:
1977 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1978 up from unused variables.
1979 - vtk/vtkGdcmReader.cxx: potential bug fix.
1980 * src/gdcmHeader.h: Doxygen warning cleanup
1982 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1983 * gdcmPython/gdcm.i:
1984 - typemaps correction to take into account the systematic replacement
1985 of "using namespace std" with std:: prefix e.g. std::list,
1986 std::string... (cf changes of 2003-05-21).
1987 - gdcmGlob global variable of type gdcmGlobal (defined in
1988 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1989 exported to Python a as cvar.
1990 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1991 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1992 gdcmDictSet.GetPubDictTagNames() and
1993 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1994 C++ static methods).
1995 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1996 with the above changes.
1998 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1999 * setup.py, manifest.in : bug fix under linux
2001 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2002 * Modification of setup.py to compile vtk part too. Then, we have 2
2003 wrappers which must work with same distutils. For that, we have a
2004 generic distutils in distusiltsWrapping.py ; with :
2005 - build_extWrap class to wrap generically all extensions,
2006 - ExtensionWrap base class for all wrapping extension that contains
2008 - Wrapper interface which wrap sources
2009 + In WrapSwig.py we have extension and wrapper for Swig
2010 + In WrapVTK.py we have extension and wrapper for VTK
2011 * MANIFEST.in : modifications to consider vtk directory and new python
2012 files for compilation
2014 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2015 * Added python wrappers of vtkGdcmReader vtk class (see the
2016 source in vtk/vtkGdcmReader.cxx) :
2017 - vtk/Makefile.am now builds a library
2018 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2019 python library (as opposed to _gdcm.so wich are the python
2020 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2021 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2023 - configure.in has an additional flag --enable-vtk that needs
2024 to be set to enable compilation of vtk related code, that is:
2025 + vtk/vtkGdcmReader.so and
2026 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2027 + gdcmPython/vtkgdcmPython.so (see above)
2028 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2029 be read when compressed or when HighBit + 1 != BitsStored),
2030 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2031 the usage of the python wrapper of vtkGdcmReader vtk class.
2032 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2033 * src/*.[h] all occurences of stl classes are now prefixed with
2034 std::, and all occurences of "using namespace std;" where removed.
2035 This is to avoid pollution of global namespace in included files.
2036 Apparently vtk does not avoid this pitfall: when using both
2037 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2038 collision of various stl members (principally cout...).
2039 * gdcmPython/testSuite.py now cleanly removes temprory generated
2041 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2042 comply with above changes)
2044 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2045 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2046 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2047 vtk data structure (an image Flip was required).
2048 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2049 * cosmetic changes in documentation.
2051 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2052 * src/gdcmHeader.cxx: the constructor no longer exits when an
2053 unexisting file is given as argument.
2054 * The subdirectory Data (containing all the images used for the
2055 test suite) is not part of this repository anymore. A new module
2056 containing those images is now available at
2057 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2058 with the name gdcmData.
2059 All the python scripts (including the package initialisation file
2060 gdcmPython/__init__.py) were adapated to take this change into
2061 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2063 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2064 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2065 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2066 demo of the usage of this class.
2067 Compilation of this vtk part is only done when using the --enable-vtk
2068 at configure (or autogen.sh) stage.
2070 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2071 * More memory link related corrections and documentation fixes.
2073 - maximum info is obtained with a command of the form:
2074 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2075 --show-reachable=yes PrintHeader
2076 - the remaining reachable blocks seem to come from the STL
2077 allocation scheme through the usage of map and list. It looks
2078 like this memory cannot be freed but it is not a memory leak
2079 (in fact further invocation to the STL would recollect the
2080 unused memory allthough it cannot explicitely be freed).
2081 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2082 of displaying an image parsed with gdcm and displayed with VTK.
2083 Note: some images don't seem to work e.g.
2084 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2085 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2086 Allthough this weakens the semantics, it is a ditch attempt to
2087 make gdcm more thread friendly.
2089 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2090 * Memory link hunt (by using valgrind through the command
2091 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2092 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2093 gdcmHeader::_dicom_vr.
2094 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2095 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2097 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2099 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2100 * src/Makefile.am now exports all the necessary include files at
2104 * UpdateGroupLength replaced by new one
2107 * UpdateGroupLength re-written using H-Table
2108 (named UpdateGroupLengthNew untill checks are over)
2110 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2111 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2112 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2114 - gdcmHeader::GetPubElValSet removed.
2115 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2116 UpdateGroupLength, WriteElements, Write.
2117 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2118 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2119 carried the same semantics.
2120 - src/gdcmHeaderIdo.cxx changed accordingly.
2121 - gdcmFile::WriteBase now regroups all the codes from previous
2122 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2123 - enum FileType moved to gdcmCommon.h
2124 * src/gdcmHeader.cxx AddDefault trashed
2125 * gdcmGetXSize added
2126 * getimageDataSize now calls gdcmGetXSize
2127 * Test/*.cxx changed to agree with above changes
2129 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2130 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2131 (to avoid double call by end user).
2132 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2133 by end user, since gdcmHeader::gdcmHeader now handles it.
2135 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2136 * gdcm/Doc many doxygen changes:
2137 - Doxyfile now has two different versions, DoxyfileUsers that generates
2138 the html.users end users oriented documentation and
2139 DoxyfileDeveloppers that generates the html.developper developper
2140 oriented documentation.
2141 - README changed accordingly
2142 - requirement.txt removed (old design info moved to TODO).
2143 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2144 DoxyMainPage.txt, DoxyPython.txt provide more information.
2145 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2146 be updated by simply regenerating the docs with doxygen and copying
2147 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2148 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2149 all the tests in the form "if (<map>.count() >1)" were removed.
2150 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2151 ill-formed documentation sections.
2152 * src/gdcmHeader.cxx: ditto
2154 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2155 * setup.py fixed for un*x (needed macro for stdint.h)
2156 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2157 un*ces with sh-utils test utility.
2158 * gdcmPython/demo/test.py renamed to PrintHeader.py
2159 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2160 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2161 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2162 * src/gdcm*.cxx JPR's bad inclusion fixed.
2164 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2165 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2166 * gdcmPython/demo/test.py changed accordingly.
2168 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2169 * gdcmPython/Makefile.am fixed linking against libstdc++
2170 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2171 * Swig subdir (historical tests of swig version 1.3.17++) removed
2172 * Test/testChangeEntete.cxx some lines commented out in order to make
2174 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2175 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2177 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2179 hence the user doesn't need this explicit call.
2180 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2181 i.e. LoadElements() call removed.
2182 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2183 - src/Makefile.am declares the proper flag for g++.
2184 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2185 for adding user defined new tags.
2186 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2187 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2188 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2190 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2191 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2192 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2193 src/Makefile.am : the project should properly compile and install
2194 with the autotools, included the python wrappers part.
2195 * gdcm.spec.in : added a spec file for RPM packaging.
2197 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2198 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2200 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2201 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2202 to exported to the environement (see gdcmPython/testSuite.py
2204 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2205 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2206 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2207 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2208 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2210 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2211 * gdcmPython/__init__.py doesn't crash anymore when running in
2212 in InstallMode or PreInstallMode but with an environement given
2213 value of GDCM_DICT_PATH.
2214 * src/gdcmDictSet.[cxx/h] coding style.
2216 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2217 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2218 * src/gdcm.h general comments moved to TODO, and README
2219 * src/gdcm.h should now be seen as a user commodity (including it
2220 should suffice to fully use gdcm). It is nowhere including within
2221 any of the kernel files src/*.cxx and src/*.h.
2223 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2224 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2225 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2227 * src/gdcm*.cxx only include their corresponding include file
2228 (as opposed to gdcm.h)
2229 * gdcmPython/gdcm.i changed accordingly
2230 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2231 the autogen.sh generated "make snapshot" command to work.
2232 * autogen.sh removed history related references to crea package.
2234 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2235 * distutilsSwigCPlusPlus.py work around some swig portability
2238 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2239 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2240 was done in a last ditch attempt to get setup.py _really_
2241 operationnal. The python/gdcmPython layaout add the advantage
2242 of hidding away the python related distutils specific files
2243 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2244 Alas, the src directory was out of scope (i.e. it's relative
2245 position to setup.py was ../src) which made things impossible to
2246 handle (see previous version of python/setup.py). Crossing fingers...
2248 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * python/setup.py now works on Un*x. (harder than I thougth)
2250 * python/distutilsSwigCPlusPlus.py can now have include files
2251 among the list of sources.
2253 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2254 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2255 * modifications in MSVC projects
2257 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2258 * As stated by the first lines of Test/ExceptionAndPython/README, it
2259 looks like we can move back to original usage of exception within
2260 src/gdcm* and hence remove the errno stuff that was introduced
2261 as a quick and dirty fixture of this problem (added to the TODO).
2262 * Doc/Doxyfile configuration file for Doxygen and corresponding
2263 README file for usage added.
2264 * Test/testWrite.cxx added. This new test comes from a split of
2265 test.cxx that is now reverted to its original purpous i.e.
2266 testing the proper parsing of a Dicom related file.
2267 testWrite.cxx concentrates on testing the IO part of gdcm.
2268 * Test/bug1.cxx (containing a bug on WIn32) added.
2269 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2270 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2271 whose purpose is to publish the content of the TagNames of the
2272 Dicom public dictionnary were not accessible without an
2273 instance of class gdcmHeader.
2274 - those methods are now static methods of gdcmDictSet and hence
2275 require no instances at all to be invocated.
2276 - within gdcmDictSet this change required to change some method
2277 to class methods (i.e. are now static) among which SetDictPath
2278 (renamed to BuildDictPath) and LoadDefaultPubDict.
2279 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2280 the above changes by calling the new method classes of gdcmDictSet.
2281 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2282 the above to be effective.
2283 * python/gdcmPython: in order to wrap properly the above changes
2284 for Python, swig version now needs to be > 1.3.17.
2285 * python/gdcmPython/Makefile fixed to adapt itself to new
2286 configure/make shema introduced by Johan Montagnat (thanks for the
2287 contribution). Alas this Makefile cannot be turned into a proper
2288 Makefile.am without some heavy changes in the configure.in
2289 (for python dectection).
2290 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2291 now avoids publishing the empty entries.
2293 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2294 * python/setup.py : bug fix concerning install under windows
2295 ExtraPath reused :-P
2296 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2298 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2299 * Dicts/dicomV3.dic : remove double spaces !!!
2300 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2301 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2304 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2305 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2306 method. Doxygenation.
2307 * src/gdcm.h clean up of JPR spurious comments.
2309 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2310 * python/distutilsSwigCPlusPlus.py now properly collects the
2311 shadow classes generated by "swig -c++" (gdcm.py in our case)
2312 when using "python setup.py install".
2313 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2314 reexports the working classes.
2315 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2316 by the classical C errno scheme. This is to prevent an obscure
2317 behavior of the python wrappers when importing wxPython.wx prior
2318 to gdcmPython (which ended up in an abort call). An illustration
2319 of this oddity can be found in the Test/ExceptionAndPython
2320 subdir (see the README file). This problem probably due to
2321 an combination of g++ and dynamic loading.
2322 * added Test/ExceptionAndPython (see above)
2324 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2325 * Changed the layout of the python part to avoid bloating main
2326 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2327 i.e. the distutils arsenal. All the python related stuff is
2328 again in a python subdir, but the package itself is now in
2330 * setup.py was cleaned up:
2331 - pythonIncludePath removed
2332 - python setup.py bdist target is now functional.
2333 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2334 collision with other packages). gdcmPython/demo/*.py changed
2337 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2338 * python subdir moved to gdcmPython (preparation of distutils packaging).
2339 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2340 distutils installer is operational.
2341 * - gdcmPython/__init__.py now properly loads the swig generated
2342 shadow classes (from gdcm.py).
2343 - gdcmPython/demo/*.py changed to import the package gdcmPython
2344 instead of gdcmPython/demo/load.py.
2345 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2347 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2348 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2349 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2350 entries within the associated public Dicom dictionary resp. the same
2351 information but sorted by the fourth field (PAT, IMG, DIR) of the
2353 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2354 are now in the "???" group.
2355 - python/gdcm.i changed accordingly,
2356 - python/demo/printGroupedPublicDict.py added, that gives an example
2357 of the above new functionalities in Python.
2359 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2360 * src/gdcm.h, gdcmHeader.cxx:
2361 - historic references to glib's g_malloc and g_free (#defined)
2362 were definitively removed.
2363 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2364 * src/gdcmElValSet.cxx:
2365 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2366 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2367 - GetElValue(string) renamed to GetElValueByName.
2368 - Added GetElementByName(string).
2369 * src/gdcmHeader.cxx: added
2370 - GetPubElValRepByNumber(guint16, guint16)
2371 - GetPubElValRepByName(string)
2372 - GetShaElValRepByNumber(guint16, guint16)
2373 - GetShaElValRepByName(string)
2374 - GetShaElValByNumber(guint16, guint16)
2375 - GetShaElValRepByName(string)
2376 - GetElValRepByNumber(guint16, guint16)
2377 - GetElValRepByName(string)
2378 - GetElValByNumber(guint16, guint16)
2379 - GetElValRepByName(string)
2380 * Doc/requirements.txt added.
2382 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * Test/Makefile building now depends on the one of libgdcm.so
2384 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2385 pixel data) aware which enables finding the address (offset) of
2386 the pixel data of JPEG encoded DICOM files. This leaves only a single
2387 file in the testSuite whose pixel data address (offset) is unknown.
2388 * python/testSuite.py changed accordingly.
2390 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2391 * VC++ has some strong limitations when working with the STL, as stated
2392 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2393 "Also note that some STL containers (map, set, queue, list, deque)
2394 cannot be exported. [...]
2395 Some STL classes contain nested classes. These classes can not
2397 This is caused by a designed limitation that once a template
2398 class is instantiated, it can not be re-instantiated and
2400 Since our usage of map<> is ubiquitous in gdcm, this "designed
2401 limitation" of VC++ is a pitfall.
2402 Hence the Python wrappers of gdcm cannot be incrementally linked
2403 against the c++ dynamic library. The dirty but only workaround is
2404 to forget about incremental link of dynamic libraries and to generate
2405 the Python wrappers library with the inclusions of the underlying C++
2407 The following modifications concern this matter on Win32/VC++:
2408 - wrapping python correct with standalone wrapped dll (don't use separate
2409 dll under windows !!!!)
2410 - python21_d debug mode enabled (ask Frog how to use it :-)
2411 - NO problem with having an STL member of class for example string in C++
2412 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2413 - Python test of dcmlib in Python is ok under windows on a large set
2415 * removed glib references
2416 * typedef's inserted in gdcm.i for correct swig type management
2418 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2419 * python/demo/*.py load.py extracted from test.py. Added explore.py
2420 that only displays required tags and testAll.py that parses all
2421 the files of the testsuite without using unittest.
2422 * python/testSuite.py other additional test on new files added.
2423 * Data/* new test files added accordingly to the testSuite.
2424 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2425 the vr in the file differs from the one of the dictionary.
2427 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2428 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2429 values, but limits itself to values which are below a user specified
2430 size (by default 1024 bytes).
2431 * python/gdcm.i : elements not loaded (because their size is above the
2432 user specified treshold) are exported with their TagKey as key of the
2433 python dictionary. This enables the testsuite to make some checks
2434 on the unloaded elements (since we have their offset and size).
2435 * python/testSuite.py
2436 - now tests for the existence and proper value of the pixel data
2437 - two new examples added.
2438 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2440 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2442 aware. See the strategy comments in gdcmHeader::FindeLength().
2443 * Test/test.cxx now accepts a filename as first argument.
2444 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2445 * python/testSuite.py changed to integrate test on above files.
2447 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2449 the vr was also RET.
2450 * python/testSuite.py more tests added.
2452 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * python/testSuite.py unittest test suite added (uses Data)
2454 * Data/* dcm and acr files for the test suite.
2455 * glib dependance removed from un*x version. We now use ISO C99
2456 7.18 Integer types (see stdint.h)
2457 - python/Makefile, src/Makefile src/gdcm.h
2458 * src/ when an explicit vr (like dicom files) suddenly poped an
2459 implicit element we use to mark the underlying DictEntry of the
2460 concerned ElValue with "Implicit". This strategy was damageable
2461 too the public or provite dictionaries, since some of their vr
2462 would be changed. Since Header::FindLength heavily relies on the
2463 detection by Header::FindVR of falsely explicit elements, I
2464 added an extra ImplicitVr member to ElValue (boolean).
2465 The rest of the changes we the necessary adaptations.
2467 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2468 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2470 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2472 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * Adaptation for porting to VC++:
2475 o forced to use std namespace (for string to be known)
2476 o all class use __declspec export style on WIN32
2477 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2478 (in stdlib.h on Win32 but in std:: for gcc)
2479 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2480 variable GDCM_DICT_PATH.
2481 * src/gdcmHeader.cxx verbose comments made discrete.
2483 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2484 * python/gdcm.i: added a typemap that converts a C++ hashing table
2485 to native Python dictionary.
2486 * python/demo/test.py:
2487 - now uses the native dictionary for exploration of gdcmHeader.
2488 - takes an optional filename argument (the file to parse).
2489 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2490 PubElVals hashing table.
2491 * Dicts/dicomV3.dic removed error prone trailing spaces.
2493 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2494 * Python wrapping process moved away from src/Makefile to
2495 newly created python/Makefile (as well as gdcm.i)
2496 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2497 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2498 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2499 from the environement variable GDCM_DICT_PATH (when existing).
2500 * src/gdcmDict::GetTag bug fix.
2502 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2503 * Straightforward temporary fixes for swig to build the python wrappers.
2504 src/Makefile now has a python working entry [by working we mean
2505 that we can import de shadow classes without errors].
2507 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * hashtest.cxx removed (since allready in Test)
2509 * src/gdcmlib.h renamed to src/gdcm.h
2510 * src/dcm.i renamed to src/gdcm.i
2511 * src/Makefile prepared for python wrapping
2513 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * src/gdcmHeader.cxx :
2515 - Parsing of header is now separated from loading of element values
2516 (see gdcmHeader::LoadElements).
2517 - general clean up of hopefully all file access (creation of
2518 ReadInt16 and ReadInt32)
2520 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * src/gdcmHeader.cxx :
2522 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2524 - SetLgrElem renamed to SetLength
2525 - GetLgrElem renamed to GetLength
2526 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2527 * src/gdcmElValSet.cxx fixed both GetElValue methods
2528 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2529 due to IdoDude was cleaned out.
2531 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2533 concentrates on finding the value representation (when it exists).
2534 RecupLgr now only finds the element value length, and it avoids
2535 returning the unecessary skL (skipped length).
2536 Also, offsetCourant was simply removed (with taille_fich) since
2537 it was redundant with the File position internals (by using
2538 ftell and fseek). This also made skL (see above in RecupLgr) usage
2540 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2541 on the libido specificities which are handled through class
2543 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2546 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * Truckload of changes. Parsing of header is barely functional
2548 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2550 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2551 * src/gdcmHeader.cxx many addons of low level methods
2553 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2554 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2555 and _IdDcmSWAP_LONG.
2557 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2558 * This corresponds to all the changes decided at the meeting of
2559 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob