1 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
3 commit of JPR (before his hollidays to facilitate our work).
4 * setup.py : bug fix in code. Modifications made while the last commit
5 of JPR. The code hasn't been tested before the commit... it's so
6 useless to make that (for best programmer that is JPR) !!!
8 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
9 * tagged the current version as Version0_3 (i.e. version 0.3)
11 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
13 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
14 * *.dsp : modifications to use new libgdcmijpeg8 library
15 * setup.py : bug fix on VTKPATH variable
16 * PACKAGER : adding all concerning windows
18 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
19 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
21 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
22 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
23 test suite reported error.
24 * PACKAGER file added (describes what a packager must do when
25 packaging a new release).
26 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
27 * configure.in: upgraded version number to 0.3.0
28 * fixing build of rpm (through rpm -ta):
29 - Doc/Makefile.am exports proper doxygen files
30 - src/jpeg/libijg8/Makefile.am exports the include files.
32 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
34 * src/gdcmHeader.h : formatting code
36 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
38 We were obtaining error message from vtk. Now, creation of file list
39 is made in an internal list to prevent this problem.
40 Bug fix when output is empty.
41 Bug fix in update of progress value. Previous commit for this was a bad
43 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
45 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/gdcmHeader.h : added method to get the file name
47 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
48 files. Added method to remove all files on the input
49 Added FIXME comment concerning the bad parsing of header made by
50 ExecuteInformation method (in ExecuteData method)
52 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
53 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
54 when using make instal.
55 * src/gdcmFile.cxx : bug fix under Window after JPR commit
56 RQ : the JPR doesn't appear in the ChangeLog... normal for him
58 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * setup.py : adding include dir of jpeg lib to compile all sources
60 * */Win32/*.dsp : JPR fix for windows compilation
62 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
65 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
66 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
68 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
69 * setup.py is again effective on un*x (takes into account the
70 addon of the jpeg library)
71 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
72 * Doc/Doxy* updated (includes above enhancements)
73 * INSTALL now points to web documentation
75 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * src/gdcmHeader.h doesn't make unnecessary reference to
78 * gdcmPython/Makefile.am now avoids calling the wrappers for the
81 - to allow compilation with gcc 3.x
82 -- clean up of STL usage (added explicit usage of std::)
83 -- small fixes on exceptions.
84 Note: linking not tested !
85 - clean of doxygen comments to avoid warnings at documentation
87 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
88 dependent convertion).
90 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
91 * Clean up of previous JPR garbage commit (not even commented in the
93 - Test/Makefile.am removed the reference to unexisting testTS.cxx
94 - moved all jpeg related files from src to src/jpeg/libijg8, with
95 addition/modification of Makefile.am and configure.in.
96 - the testSuite is still brain damage (not guilty).
98 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * WrapVTK.py : modifications to get correctly vtk source files to
101 * vtk/vtkGdcmReader.cxx : modification for an already existing name
102 (FileName -> Filename)
104 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
105 * vtk/vtkGdcmReader.[cxx/h]:
106 - UpdateProgress method should now be effective
107 - removed the limitation on having only images loaded (as opposed
109 - when building a stack of images/volume, a lesser number of
110 gdcmHeader and gdcmFile instances should be used (hopefully
111 accelerating things).
112 - when building a stack of images/volumes, files which are not
113 loadable (wrong path-filename, wrong permissions on existing file,
114 or file not parsable by gdcm) are replaced with a black image
115 in the stack (for the caller to notice the problem).
117 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
118 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
120 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
122 between standard library (std) and vtk library (problems are found
123 under Windows... thanks Windows !)
125 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
126 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
128 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
130 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
131 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
133 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
134 * When compiling with distutils (see setup.py) the C++ compiler is
135 called with different flags than the default ones (with automake).
136 In order to fix all those warning, I compiled gdcm with the command
137 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
138 and went for warning fixes:
139 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
140 up from unused variables.
141 - vtk/vtkGdcmReader.cxx: potential bug fix.
142 * src/gdcmHeader.h: Doxygen warning cleanup
144 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
146 - typemaps correction to take into account the systematic replacement
147 of "using namespace std" with std:: prefix e.g. std::list,
148 std::string... (cf changes of 2003-05-21).
149 - gdcmGlob global variable of type gdcmGlobal (defined in
150 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
151 exported to Python a as cvar.
152 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
153 and GetPubDictTagNamesByCategory() as a replacement for deprecated
154 gdcmDictSet.GetPubDictTagNames() and
155 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
157 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
158 with the above changes.
160 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * setup.py, manifest.in : bug fix under linux
163 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * Modification of setup.py to compile vtk part too. Then, we have 2
165 wrappers which must work with same distutils. For that, we have a
166 generic distutils in distusiltsWrapping.py ; with :
167 - build_extWrap class to wrap generically all extensions,
168 - ExtensionWrap base class for all wrapping extension that contains
170 - Wrapper interface which wrap sources
171 + In WrapSwig.py we have extension and wrapper for Swig
172 + In WrapVTK.py we have extension and wrapper for VTK
173 * MANIFEST.in : modifications to consider vtk directory and new python
174 files for compilation
176 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
177 * Added python wrappers of vtkGdcmReader vtk class (see the
178 source in vtk/vtkGdcmReader.cxx) :
179 - vtk/Makefile.am now builds a library
180 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
181 python library (as opposed to _gdcm.so wich are the python
182 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
183 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
185 - configure.in has an additional flag --enable-vtk that needs
186 to be set to enable compilation of vtk related code, that is:
187 + vtk/vtkGdcmReader.so and
188 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
189 + gdcmPython/vtkgdcmPython.so (see above)
190 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
191 be read when compressed or when HighBit + 1 != BitsStored),
192 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
193 the usage of the python wrapper of vtkGdcmReader vtk class.
194 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
195 * src/*.[h] all occurences of stl classes are now prefixed with
196 std::, and all occurences of "using namespace std;" where removed.
197 This is to avoid pollution of global namespace in included files.
198 Apparently vtk does not avoid this pitfall: when using both
199 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
200 collision of various stl members (principally cout...).
201 * gdcmPython/testSuite.py now cleanly removes temprory generated
203 * gdcmPython/gdcm.i now declares a typemap for std::string (to
204 comply with above changes)
206 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
207 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
208 * vtk/vtkGdcmReader.cxx now properly inports the image in the
209 vtk data structure (an image Flip was required).
210 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
211 * cosmetic changes in documentation.
213 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
214 * src/gdcmHeader.cxx: the constructor no longer exits when an
215 unexisting file is given as argument.
216 * The subdirectory Data (containing all the images used for the
217 test suite) is not part of this repository anymore. A new module
218 containing those images is now available at
219 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
220 with the name gdcmData.
221 All the python scripts (including the package initialisation file
222 gdcmPython/__init__.py) were adapated to take this change into
223 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
225 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
226 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
227 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
228 demo of the usage of this class.
229 Compilation of this vtk part is only done when using the --enable-vtk
230 at configure (or autogen.sh) stage.
232 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
233 * More memmory link related corrections and documentation fixes.
235 - maximum info is obtained with a command of the form:
236 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
237 --show-reachable=yes PrintHeader
238 - the remaining reachable blocks seem to come from the STL
239 allocation scheme through the usage of map and list. It looks
240 like this memory cannot be freed but it is not a memory leak
241 (in fact further invocation to the STL would recollect the
242 unused memory allthough it cannot explicitely be freed).
243 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
244 of displaying an image parsed with gdcm and displayed with VTK.
245 Note: some images don't seem to work e.g.
246 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
247 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
248 Allthough this weakens the semantics, it is a ditch attempt to
249 make gdcm more thread friendly.
251 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
252 * Memory link hunt (by using valgrind through the command
253 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
254 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
255 gdcmHeader::_dicom_vr.
256 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
257 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
259 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
261 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
262 * src/Makefile.am now exports all the necessary include files at
266 * UpdateGroupLength replaced by new one
269 * UpdateGroupLength re-written using H-Table
270 (named UpdateGroupLengthNew untill checks are over)
272 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
273 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
274 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
276 - gdcmHeader::GetPubElValSet removed.
277 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
278 UpdateGroupLength, WriteElements, Write.
279 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
280 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
281 carried the same semantics.
282 - src/gdcmHeaderIdo.cxx changed accordingly.
283 - gdcmFile::WriteBase now regroups all the codes from previous
284 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
285 - enum FileType moved to gdcmCommon.h
286 * src/gdcmHeader.cxx AddDefault trashed
288 * getimageDataSize now calls gdcmGetXSize
289 * Test/*.cxx changed to agree with above changes
291 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * src/gdcmHeader.h: LoadElements() is not a public method anymore
293 (to avoid double call by end user).
294 * Test/*.cxx LoadElements() doesn't need to be called explicitely
295 by end user, since gdcmHeader::gdcmHeader now handles it.
297 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
298 * gdcm/Doc many doxygen changes:
299 - Doxyfile now has two different versions, DoxyfileUsers that generates
300 the html.users end users oriented documentation and
301 DoxyfileDeveloppers that generates the html.developper developper
302 oriented documentation.
303 - README changed accordingly
304 - requirement.txt removed (old design info moved to TODO).
305 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
306 DoxyMainPage.txt, DoxyPython.txt provide more information.
307 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
308 be updated by simply regenerating the docs with doxygen and copying
309 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
310 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
311 all the tests in the form "if (<map>.count() >1)" were removed.
312 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
313 ill-formed documentation sections.
314 * src/gdcmHeader.cxx: ditto
316 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
317 * setup.py fixed for un*x (needed macro for stdint.h)
318 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
319 un*ces with sh-utils test utility.
320 * gdcmPython/demo/test.py renamed to PrintHeader.py
321 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
322 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
323 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
324 * src/gdcm*.cxx JPR's bad inclusion fixed.
326 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
328 * gdcmPython/demo/test.py changed accordingly.
330 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
331 * gdcmPython/Makefile.am fixed linking against libstdc++
332 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
333 * Swig subdir (historical tests of swig version 1.3.17++) removed
334 * Test/testChangeEntete.cxx some lines commented out in order to make
336 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
337 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
339 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
340 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
341 hence the user doesn't need this explicit call.
342 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
343 i.e. LoadElements() call removed.
344 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
345 - src/Makefile.am declares the proper flag for g++.
346 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
347 for adding user defined new tags.
348 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
349 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
350 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
352 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
353 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
354 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
355 src/Makefile.am : the project should properly compile and install
356 with the autotools, included the python wrappers part.
357 * gdcm.spec.in : added a spec file for RPM packaging.
359 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
360 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
362 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
363 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
364 to exported to the environement (see gdcmPython/testSuite.py
366 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
367 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
368 ElValue class renamed to gdcmElValue for obvious consistency reasons.
369 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
370 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
372 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * gdcmPython/__init__.py doesn't crash anymore when running in
374 in InstallMode or PreInstallMode but with an environement given
375 value of GDCM_DICT_PATH.
376 * src/gdcmDictSet.[cxx/h] coding style.
378 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
379 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
380 * src/gdcm.h general comments moved to TODO, and README
381 * src/gdcm.h should now be seen as a user commodity (including it
382 should suffice to fully use gdcm). It is nowhere including within
383 any of the kernel files src/*.cxx and src/*.h.
385 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
387 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
389 * src/gdcm*.cxx only include their corresponding include file
390 (as opposed to gdcm.h)
391 * gdcmPython/gdcm.i changed accordingly
392 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
393 the autogen.sh generated "make snapshot" command to work.
394 * autogen.sh removed history related references to crea package.
396 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
397 * distutilsSwigCPlusPlus.py work around some swig portability
400 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * Eventually, python/gdcmPython was renamed to gdcmPython. This
402 was done in a last ditch attempt to get setup.py _really_
403 operationnal. The python/gdcmPython layaout add the advantage
404 of hidding away the python related distutils specific files
405 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
406 Alas, the src directory was out of scope (i.e. it's relative
407 position to setup.py was ../src) which made things impossible to
408 handle (see previous version of python/setup.py). Crossing fingers...
410 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * python/setup.py now works on Un*x. (harder than I thougth)
412 * python/distutilsSwigCPlusPlus.py can now have include files
413 among the list of sources.
415 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
416 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
417 * modifications in MSVC projects
419 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
420 * As stated by the first lines of Test/ExceptionAndPython/README, it
421 looks like we can move back to original usage of exception within
422 src/gdcm* and hence remove the errno stuff that was introduced
423 as a quick and dirty fixture of this problem (added to the TODO).
424 * Doc/Doxyfile configuration file for Doxygen and corresponding
425 README file for usage added.
426 * Test/testWrite.cxx added. This new test comes from a split of
427 test.cxx that is now reverted to its original purpous i.e.
428 testing the proper parsing of a Dicom related file.
429 testWrite.cxx concentrates on testing the IO part of gdcm.
430 * Test/bug1.cxx (containing a bug on WIn32) added.
431 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
432 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
433 whose purpose is to publish the content of the TagNames of the
434 Dicom public dictionnary were not accessible without an
435 instance of class gdcmHeader.
436 - those methods are now static methods of gdcmDictSet and hence
437 require no instances at all to be invocated.
438 - within gdcmDictSet this change required to change some method
439 to class methods (i.e. are now static) among which SetDictPath
440 (renamed to BuildDictPath) and LoadDefaultPubDict.
441 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
442 the above changes by calling the new method classes of gdcmDictSet.
443 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
444 the above to be effective.
445 * python/gdcmPython: in order to wrap properly the above changes
446 for Python, swig version now needs to be > 1.3.17.
447 * python/gdcmPython/Makefile fixed to adapt itself to new
448 configure/make shema introduced by Johan Montagnat (thanks for the
449 contribution). Alas this Makefile cannot be turned into a proper
450 Makefile.am without some heavy changes in the configure.in
451 (for python dectection).
452 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
453 now avoids publishing the empty entries.
455 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
456 * python/setup.py : bug fix concerning install under windows
458 * gdcm.dsw : bug fix concerning path for libraries for python !!!
460 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
461 * Dicts/dicomV3.dic : remove double spaces !!!
462 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
463 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
466 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
468 method. Doxygenation.
469 * src/gdcm.h clean up of JPR spurious comments.
471 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * python/distutilsSwigCPlusPlus.py now properly collects the
473 shadow classes generated by "swig -c++" (gdcm.py in our case)
474 when using "python setup.py install".
475 * python/gdcmPython/__init__.py imports gdcm.py and only manually
476 reexports the working classes.
477 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
478 by the classical C errno scheme. This is to prevent an obscure
479 behavior of the python wrappers when importing wxPython.wx prior
480 to gdcmPython (which ended up in an abort call). An illustration
481 of this oddity can be found in the Test/ExceptionAndPython
482 subdir (see the README file). This problem probably due to
483 an combination of g++ and dynamic loading.
484 * added Test/ExceptionAndPython (see above)
486 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
487 * Changed the layout of the python part to avoid bloating main
488 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
489 i.e. the distutils arsenal. All the python related stuff is
490 again in a python subdir, but the package itself is now in
492 * setup.py was cleaned up:
493 - pythonIncludePath removed
494 - python setup.py bdist target is now functional.
495 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
496 collision with other packages). gdcmPython/demo/*.py changed
498 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
499 * python subdir moved to gdcmPython (preparation of distutils packaging).
500 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
501 distutils installer is operational.
502 * - gdcmPython/__init__.py now properly loads the swig generated
503 shadow classes (from gdcm.py).
504 - gdcmPython/demo/*.py changed to import the package gdcmPython
505 instead of gdcmPython/demo/load.py.
506 - gdcmPython/testSuite.py changed to import the package gdcmPython.
509 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
510 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
511 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
512 entries within the associated public Dicom dictionary resp. the same
513 information but sorted by the fourth field (PAT, IMG, DIR) of the
515 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
516 are now in the "???" group.
517 - python/gdcm.i changed accordingly,
518 - python/demo/printGroupedPublicDict.py added, that gives an example
519 of the above new functionalities in Python.
521 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
522 * src/gdcm.h, gdcmHeader.cxx:
523 - historic references to glib's g_malloc and g_free (#defined)
524 were definitively removed.
525 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
526 * src/gdcmElValSet.cxx:
527 - GetElement(guint32, guint32) renamed to GetElementByNumber.
528 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
529 - GetElValue(string) renamed to GetElValueByName.
530 - Added GetElementByName(string).
531 * src/gdcmHeader.cxx: added
532 - GetPubElValRepByNumber(guint16, guint16)
533 - GetPubElValRepByName(string)
534 - GetShaElValRepByNumber(guint16, guint16)
535 - GetShaElValRepByName(string)
536 - GetShaElValByNumber(guint16, guint16)
537 - GetShaElValRepByName(string)
538 - GetElValRepByNumber(guint16, guint16)
539 - GetElValRepByName(string)
540 - GetElValByNumber(guint16, guint16)
541 - GetElValRepByName(string)
542 * Doc/requirements.txt added.
544 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
545 * Test/Makefile building now depends on the one of libgdcm.so
546 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
547 pixel data) aware which enables finding the address (offset) of
548 the pixel data of JPEG encoded DICOM files. This leaves only a single
549 file in the testSuite whose pixel data address (offset) is unknown.
550 * python/testSuite.py changed accordingly.
552 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
553 * VC++ has some strong limitations when working with the STL, as stated
554 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
555 "Also note that some STL containers (map, set, queue, list, deque)
556 cannot be exported. [...]
557 Some STL classes contain nested classes. These classes can not
559 This is caused by a designed limitation that once a template
560 class is instantiated, it can not be re-instantiated and
562 Since our usage of map<> is ubiquitous in gdcm, this "designed
563 limitation" of VC++ is a pitfall.
564 Hence the Python wrappers of gdcm cannot be incrementally linked
565 against the c++ dynamic library. The dirty but only workaround is
566 to forget about incremental link of dynamic libraries and to generate
567 the Python wrappers library with the inclusions of the underlying C++
569 The following modifications concern this matter on Win32/VC++:
570 - wrapping python correct with standalone wrapped dll (don't use separate
571 dll under windows !!!!)
572 - python21_d debug mode enabled (ask Frog how to use it :-)
573 - NO problem with having an STL member of class for example string in C++
574 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
575 - Python test of dcmlib in Python is ok under windows on a large set
577 * removed glib references
578 * typedef's inserted in gdcm.i for correct swig type management
580 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * python/demo/*.py load.py extracted from test.py. Added explore.py
582 that only displays required tags and testAll.py that parses all
583 the files of the testsuite without using unittest.
584 * python/testSuite.py other additional test on new files added.
585 * Data/* new test files added accordingly to the testSuite.
586 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
587 the vr in the file differs from the one of the dictionary.
589 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
590 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
591 values, but limits itself to values which are below a user specified
592 size (by default 1024 bytes).
593 * python/gdcm.i : elements not loaded (because their size is above the
594 user specified treshold) are exported with their TagKey as key of the
595 python dictionary. This enables the testsuite to make some checks
596 on the unloaded elements (since we have their offset and size).
597 * python/testSuite.py
598 - now tests for the existence and proper value of the pixel data
599 - two new examples added.
600 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
602 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
604 aware. See the strategy comments in gdcmHeader::FindeLength().
605 * Test/test.cxx now accepts a filename as first argument.
606 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
607 * python/testSuite.py changed to integrate test on above files.
609 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
610 * Dicts/dicomV3.dic removed all the trailing (RET) when the
612 * python/testSuite.py more tests added.
614 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
615 * python/testSuite.py unittest test suite added (uses Data)
616 * Data/* dcm and acr files for the test suite.
617 * glib dependance removed from un*x version. We now use ISO C99
618 7.18 Integer types (see stdint.h)
619 - python/Makefile, src/Makefile src/gdcm.h
620 * src/ when an explicit vr (like dicom files) suddenly poped an
621 implicit element we use to mark the underlying DictEntry of the
622 concerned ElValue with "Implicit". This strategy was damageable
623 too the public or provite dictionaries, since some of their vr
624 would be changed. Since Header::FindLength heavily relies on the
625 detection by Header::FindVR of falsely explicit elements, I
626 added an extra ImplicitVr member to ElValue (boolean).
627 The rest of the changes we the necessary adaptations.
629 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
630 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
632 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
634 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * Adaptation for porting to VC++:
637 o forced to use std namespace (for string to be known)
638 o all class use __declspec export style on WIN32
639 - src/gdcmUtil.cxx new Exit method that wraps the exit call
640 (in stdlib.h on Win32 but in std:: for gcc)
641 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
642 variable GDCM_DICT_PATH.
643 * src/gdcmHeader.cxx verbose comments made discrete.
645 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * python/gdcm.i: added a typemap that converts a C++ hashing table
647 to native Python dictionary.
648 * python/demo/test.py:
649 - now uses the native dictionary for exploration of gdcmHeader.
650 - takes an optional filename argument (the file to parse).
651 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
652 PubElVals hashing table.
653 * Dicts/dicomV3.dic removed error prone trailing spaces.
655 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
656 * Python wrapping process moved away from src/Makefile to
657 newly created python/Makefile (as well as gdcm.i)
658 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
659 * src/gdcmHeader::FindLength only looks for current vr when necessary.
660 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
661 from the environement variable GDCM_DICT_PATH (when existing).
662 * src/gdcmDict::GetTag bug fix.
664 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
665 * Straightforward temporary fixes for swig to build the python wrappers.
666 src/Makefile now has a python working entry [by working we mean
667 that we can import de shadow classes without errors].
669 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
670 * hashtest.cxx removed (since allready in Test)
671 * src/gdcmlib.h renamed to src/gdcm.h
672 * src/dcm.i renamed to src/gdcm.i
673 * src/Makefile prepared for python wrapping
675 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * src/gdcmHeader.cxx :
677 - Parsing of header is now separated from loading of element values
678 (see gdcmHeader::LoadElements).
679 - general clean up of hopefully all file access (creation of
680 ReadInt16 and ReadInt32)
682 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * src/gdcmHeader.cxx :
684 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
686 - SetLgrElem renamed to SetLength
687 - GetLgrElem renamed to GetLength
688 - ~gdcmHeader() made virtual to pesky warning messages at compile.
689 * src/gdcmElValSet.cxx fixed both GetElValue methods
690 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
691 due to IdoDude was cleaned out.
693 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
695 concentrates on finding the value representation (when it exists).
696 RecupLgr now only finds the element value length, and it avoids
697 returning the unecessary skL (skipped length).
698 Also, offsetCourant was simply removed (with taille_fich) since
699 it was redundant with the File position internals (by using
700 ftell and fseek). This also made skL (see above in RecupLgr) usage
702 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
703 on the libido specificities which are handled through class
705 * Test/implicit_vr.dcm dicom v3 in implicit value representation
708 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * Truckload of changes. Parsing of header is barely functional
710 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
712 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
713 * src/gdcmHeader.cxx many addons of low level methods
715 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
716 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
719 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
720 * This corresponds to all the changes decided at the meeting of
721 May 23 2002. Needless to say we are running late...