1 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
4 Dicom dictionary. The test suite can now be run again. Note:
5 I'm note very happy with the " (RET)" changes. I believe this
6 RETAINED comment should be dropped when parsing the dictionary.
9 - AUTHORS updated and now in alphabetical order
10 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
11 * cygwin complains about missing std:: in subdir Test/
12 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * remove some methods that are now in gdcmHeaderHelper
14 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
15 * vtkGdcmReader set spacing and origin correctly
16 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
17 * Fix a few delete/delete[] mismatch
18 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
19 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
20 interpretation to data given by gdcmHeader. For instance there are
21 heuristics to get informations (look at different places).
22 * it also include a specific class: gdcmSerieHeaderHelper devoted to
23 sorting DICOM images based on different strategies.
24 * modified Makefiles accordingly.
25 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
26 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
27 when building in debug mode
28 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
30 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
31 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
32 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks to valgrind.
33 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
34 * src/win32/libgdcmjpeg12.dsp was not dos format
35 * src/win32/libgdcmjpeg12.dsp : libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
36 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
37 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
40 * src/gdcmFile.cxx : bug fix in affectation type
41 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
42 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
43 * Modifs of MVSC projects to compile them. Not concerning 2 identic
44 symbols... futur problem ?
45 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
46 * src/win32/libgdcmijpeg12.dsp was missing
47 * modified gdcm.dsw accordingly
48 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
49 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
50 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
52 commit of JPR (before his hollidays to facilitate our work).
53 * setup.py : bug fix in code. Modifications made while the last commit
54 of JPR. The code hasn't been tested before the commit... it's so
55 useless to make that (for best programmer that is JPR) !!!
56 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
57 * tagged the current version as Version0_3 (i.e. version 0.3)
58 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
60 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
61 * *.dsp : modifications to use new libgdcmijpeg8 library
62 * setup.py : bug fix on VTKPATH variable
63 * PACKAGER : adding all concerning windows
64 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
65 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
67 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
68 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
69 test suite reported error.
70 * PACKAGER file added (describes what a packager must do when
71 packaging a new release).
72 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
73 * configure.in: upgraded version number to 0.3.0
74 * fixing build of rpm (through rpm -ta):
75 - Doc/Makefile.am exports proper doxygen files
76 - src/jpeg/libijg8/Makefile.am exports the include files.
77 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
79 * src/gdcmHeader.h : formatting code
80 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
82 We were obtaining error message from vtk. Now, creation of file list
83 is made in an internal list to prevent this problem.
84 Bug fix when output is empty.
85 Bug fix in update of progress value. Previous commit for this was a bad
87 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
88 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmHeader.h : added method to get the file name
90 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
91 files. Added method to remove all files on the input
92 Added FIXME comment concerning the bad parsing of header made by
93 ExecuteInformation method (in ExecuteData method)
94 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
95 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
96 when using make instal.
97 * src/gdcmFile.cxx : bug fix under Window after JPR commit
98 RQ : the JPR doesn't appear in the ChangeLog... normal for him
99 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * setup.py : adding include dir of jpeg lib to compile all sources
101 * */Win32/*.dsp : JPR fix for windows compilation
102 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
105 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
106 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
107 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
108 * setup.py is again effective on un*x (takes into account the
109 addon of the jpeg library)
110 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
111 * Doc/Doxy* updated (includes above enhancements)
112 * INSTALL now points to web documentation
113 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
114 * src/gdcmHeader.h doesn't make unnecessary reference to
116 * gdcmPython/Makefile.am now avoids calling the wrappers for the
118 * src/gdcm*.[cxx|h] :
119 - to allow compilation with gcc 3.x
120 -- clean up of STL usage (added explicit usage of std::)
121 -- small fixes on exceptions.
122 Note: linking not tested !
123 - clean of doxygen comments to avoid warnings at documentation
125 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
126 dependent convertion).
127 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 * Clean up of previous JPR garbage commit (not even commented in the
130 - Test/Makefile.am removed the reference to unexisting testTS.cxx
131 - moved all jpeg related files from src to src/jpeg/libijg8, with
132 addition/modification of Makefile.am and configure.in.
133 - the testSuite is still brain damage (not guilty).
134 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * WrapVTK.py : modifications to get correctly vtk source files to
137 * vtk/vtkGdcmReader.cxx : modification for an already existing name
138 (FileName -> Filename)
139 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
140 * vtk/vtkGdcmReader.[cxx/h]:
141 - UpdateProgress method should now be effective
142 - removed the limitation on having only images loaded (as opposed
144 - when building a stack of images/volume, a lesser number of
145 gdcmHeader and gdcmFile instances should be used (hopefully
146 accelerating things).
147 - when building a stack of images/volumes, files which are not
148 loadable (wrong path-filename, wrong permissions on existing file,
149 or file not parsable by gdcm) are replaced with a black image
150 in the stack (for the caller to notice the problem).
151 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
152 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
153 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
155 between standard library (std) and vtk library (problems are found
156 under Windows... thanks Windows !)
157 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
158 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
160 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
161 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
162 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
163 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
164 * When compiling with distutils (see setup.py) the C++ compiler is
165 called with different flags than the default ones (with automake).
166 In order to fix all those warning, I compiled gdcm with the command
167 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
168 and went for warning fixes:
169 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
170 up from unused variables.
171 - vtk/vtkGdcmReader.cxx: potential bug fix.
172 * src/gdcmHeader.h: Doxygen warning cleanup
173 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
175 - typemaps correction to take into account the systematic replacement
176 of "using namespace std" with std:: prefix e.g. std::list,
177 std::string... (cf changes of 2003-05-21).
178 - gdcmGlob global variable of type gdcmGlobal (defined in
179 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
180 exported to Python a as cvar.
181 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
182 and GetPubDictTagNamesByCategory() as a replacement for deprecated
183 gdcmDictSet.GetPubDictTagNames() and
184 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
186 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
187 with the above changes.
188 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * setup.py, manifest.in : bug fix under linux
190 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * Modification of setup.py to compile vtk part too. Then, we have 2
192 wrappers which must work with same distutils. For that, we have a
193 generic distutils in distusiltsWrapping.py ; with :
194 - build_extWrap class to wrap generically all extensions,
195 - ExtensionWrap base class for all wrapping extension that contains
197 - Wrapper interface which wrap sources
198 + In WrapSwig.py we have extension and wrapper for Swig
199 + In WrapVTK.py we have extension and wrapper for VTK
200 * MANIFEST.in : modifications to consider vtk directory and new python
201 files for compilation
202 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
203 * Added python wrappers of vtkGdcmReader vtk class (see the
204 source in vtk/vtkGdcmReader.cxx) :
205 - vtk/Makefile.am now builds a library
206 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
207 python library (as opposed to _gdcm.so wich are the python
208 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
209 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
211 - configure.in has an additional flag --enable-vtk that needs
212 to be set to enable compilation of vtk related code, that is:
213 + vtk/vtkGdcmReader.so and
214 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
215 + gdcmPython/vtkgdcmPython.so (see above)
216 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
217 be read when compressed or when HighBit + 1 != BitsStored),
218 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
219 the usage of the python wrapper of vtkGdcmReader vtk class.
220 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
221 * src/*.[h] all occurences of stl classes are now prefixed with
222 std::, and all occurences of "using namespace std;" where removed.
223 This is to avoid pollution of global namespace in included files.
224 Apparently vtk does not avoid this pitfall: when using both
225 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
226 collision of various stl members (principally cout...).
227 * gdcmPython/testSuite.py now cleanly removes temprory generated
229 * gdcmPython/gdcm.i now declares a typemap for std::string (to
230 comply with above changes)
231 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
232 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
233 * vtk/vtkGdcmReader.cxx now properly inports the image in the
234 vtk data structure (an image Flip was required).
235 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
236 * cosmetic changes in documentation.
237 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
238 * src/gdcmHeader.cxx: the constructor no longer exits when an
239 unexisting file is given as argument.
240 * The subdirectory Data (containing all the images used for the
241 test suite) is not part of this repository anymore. A new module
242 containing those images is now available at
243 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
244 with the name gdcmData.
245 All the python scripts (including the package initialisation file
246 gdcmPython/__init__.py) were adapated to take this change into
247 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
248 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
249 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
250 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
251 demo of the usage of this class.
252 Compilation of this vtk part is only done when using the --enable-vtk
253 at configure (or autogen.sh) stage.
254 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
255 * More memmory link related corrections and documentation fixes.
257 - maximum info is obtained with a command of the form:
258 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
259 --show-reachable=yes PrintHeader
260 - the remaining reachable blocks seem to come from the STL
261 allocation scheme through the usage of map and list. It looks
262 like this memory cannot be freed but it is not a memory leak
263 (in fact further invocation to the STL would recollect the
264 unused memory allthough it cannot explicitely be freed).
265 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
266 of displaying an image parsed with gdcm and displayed with VTK.
267 Note: some images don't seem to work e.g.
268 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
269 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
270 Allthough this weakens the semantics, it is a ditch attempt to
271 make gdcm more thread friendly.
272 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
273 * Memory link hunt (by using valgrind through the command
274 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
275 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
276 gdcmHeader::_dicom_vr.
277 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
278 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
280 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
281 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
282 * src/Makefile.am now exports all the necessary include files at
285 * UpdateGroupLength replaced by new one
287 * UpdateGroupLength re-written using H-Table
288 (named UpdateGroupLengthNew untill checks are over)
290 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
291 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
292 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
294 - gdcmHeader::GetPubElValSet removed.
295 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
296 UpdateGroupLength, WriteElements, Write.
297 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
298 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
299 carried the same semantics.
300 - src/gdcmHeaderIdo.cxx changed accordingly.
301 - gdcmFile::WriteBase now regroups all the codes from previous
302 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
303 - enum FileType moved to gdcmCommon.h
304 * src/gdcmHeader.cxx AddDefault trashed
306 * getimageDataSize now calls gdcmGetXSize
307 * Test/*.cxx changed to agree with above changes
308 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
309 * src/gdcmHeader.h: LoadElements() is not a public method anymore
310 (to avoid double call by end user).
311 * Test/*.cxx LoadElements() doesn't need to be called explicitely
312 by end user, since gdcmHeader::gdcmHeader now handles it.
313 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * gdcm/Doc many doxygen changes:
315 - Doxyfile now has two different versions, DoxyfileUsers that generates
316 the html.users end users oriented documentation and
317 DoxyfileDeveloppers that generates the html.developper developper
318 oriented documentation.
319 - README changed accordingly
320 - requirement.txt removed (old design info moved to TODO).
321 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
322 DoxyMainPage.txt, DoxyPython.txt provide more information.
323 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
324 be updated by simply regenerating the docs with doxygen and copying
325 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
326 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
327 all the tests in the form "if (<map>.count() >1)" were removed.
328 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
329 ill-formed documentation sections.
330 * src/gdcmHeader.cxx: ditto
331 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
332 * setup.py fixed for un*x (needed macro for stdint.h)
333 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
334 un*ces with sh-utils test utility.
335 * gdcmPython/demo/test.py renamed to PrintHeader.py
336 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
337 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
338 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
339 * src/gdcm*.cxx JPR's bad inclusion fixed.
340 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
342 * gdcmPython/demo/test.py changed accordingly.
343 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
344 * gdcmPython/Makefile.am fixed linking against libstdc++
345 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
346 * Swig subdir (historical tests of swig version 1.3.17++) removed
347 * Test/testChangeEntete.cxx some lines commented out in order to make
349 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
350 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
351 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
353 hence the user doesn't need this explicit call.
354 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
355 i.e. LoadElements() call removed.
356 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
357 - src/Makefile.am declares the proper flag for g++.
358 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
359 for adding user defined new tags.
360 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
361 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
362 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
363 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
364 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
365 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
366 src/Makefile.am : the project should properly compile and install
367 with the autotools, included the python wrappers part.
368 * gdcm.spec.in : added a spec file for RPM packaging.
369 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
370 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
371 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
372 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
373 to exported to the environement (see gdcmPython/testSuite.py
375 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
376 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
377 ElValue class renamed to gdcmElValue for obvious consistency reasons.
378 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
379 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
380 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
381 * gdcmPython/__init__.py doesn't crash anymore when running in
382 in InstallMode or PreInstallMode but with an environement given
383 value of GDCM_DICT_PATH.
384 * src/gdcmDictSet.[cxx/h] coding style.
385 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
387 * src/gdcm.h general comments moved to TODO, and README
388 * src/gdcm.h should now be seen as a user commodity (including it
389 should suffice to fully use gdcm). It is nowhere including within
390 any of the kernel files src/*.cxx and src/*.h.
391 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
392 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
393 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
395 * src/gdcm*.cxx only include their corresponding include file
396 (as opposed to gdcm.h)
397 * gdcmPython/gdcm.i changed accordingly
398 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
399 the autogen.sh generated "make snapshot" command to work.
400 * autogen.sh removed history related references to crea package.
401 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
402 * distutilsSwigCPlusPlus.py work around some swig portability
404 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * Eventually, python/gdcmPython was renamed to gdcmPython. This
406 was done in a last ditch attempt to get setup.py _really_
407 operationnal. The python/gdcmPython layaout add the advantage
408 of hidding away the python related distutils specific files
409 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
410 Alas, the src directory was out of scope (i.e. it's relative
411 position to setup.py was ../src) which made things impossible to
412 handle (see previous version of python/setup.py). Crossing fingers...
413 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
414 * python/setup.py now works on Un*x. (harder than I thougth)
415 * python/distutilsSwigCPlusPlus.py can now have include files
416 among the list of sources.
418 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
419 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
420 * modifications in MSVC projects
421 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
422 * As stated by the first lines of Test/ExceptionAndPython/README, it
423 looks like we can move back to original usage of exception within
424 src/gdcm* and hence remove the errno stuff that was introduced
425 as a quick and dirty fixture of this problem (added to the TODO).
426 * Doc/Doxyfile configuration file for Doxygen and corresponding
427 README file for usage added.
428 * Test/testWrite.cxx added. This new test comes from a split of
429 test.cxx that is now reverted to its original purpous i.e.
430 testing the proper parsing of a Dicom related file.
431 testWrite.cxx concentrates on testing the IO part of gdcm.
432 * Test/bug1.cxx (containing a bug on WIn32) added.
433 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
434 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
435 whose purpose is to publish the content of the TagNames of the
436 Dicom public dictionnary were not accessible without an
437 instance of class gdcmHeader.
438 - those methods are now static methods of gdcmDictSet and hence
439 require no instances at all to be invocated.
440 - within gdcmDictSet this change required to change some method
441 to class methods (i.e. are now static) among which SetDictPath
442 (renamed to BuildDictPath) and LoadDefaultPubDict.
443 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
444 the above changes by calling the new method classes of gdcmDictSet.
445 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
446 the above to be effective.
447 * python/gdcmPython: in order to wrap properly the above changes
448 for Python, swig version now needs to be > 1.3.17.
449 * python/gdcmPython/Makefile fixed to adapt itself to new
450 configure/make shema introduced by Johan Montagnat (thanks for the
451 contribution). Alas this Makefile cannot be turned into a proper
452 Makefile.am without some heavy changes in the configure.in
453 (for python dectection).
454 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
455 now avoids publishing the empty entries.
456 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * python/setup.py : bug fix concerning install under windows
459 * gdcm.dsw : bug fix concerning path for libraries for python !!!
460 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
461 * Dicts/dicomV3.dic : remove double spaces !!!
462 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
463 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
465 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
466 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
467 method. Doxygenation.
468 * src/gdcm.h clean up of JPR spurious comments.
469 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * python/distutilsSwigCPlusPlus.py now properly collects the
471 shadow classes generated by "swig -c++" (gdcm.py in our case)
472 when using "python setup.py install".
473 * python/gdcmPython/__init__.py imports gdcm.py and only manually
474 reexports the working classes.
475 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
476 by the classical C errno scheme. This is to prevent an obscure
477 behavior of the python wrappers when importing wxPython.wx prior
478 to gdcmPython (which ended up in an abort call). An illustration
479 of this oddity can be found in the Test/ExceptionAndPython
480 subdir (see the README file). This problem probably due to
481 an combination of g++ and dynamic loading.
482 * added Test/ExceptionAndPython (see above)
483 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
484 * Changed the layout of the python part to avoid bloating main
485 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
486 i.e. the distutils arsenal. All the python related stuff is
487 again in a python subdir, but the package itself is now in
489 * setup.py was cleaned up:
490 - pythonIncludePath removed
491 - python setup.py bdist target is now functional.
492 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
493 collision with other packages). gdcmPython/demo/*.py changed
495 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
496 * python subdir moved to gdcmPython (preparation of distutils packaging).
497 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
498 distutils installer is operational.
499 * - gdcmPython/__init__.py now properly loads the swig generated
500 shadow classes (from gdcm.py).
501 - gdcmPython/demo/*.py changed to import the package gdcmPython
502 instead of gdcmPython/demo/load.py.
503 - gdcmPython/testSuite.py changed to import the package gdcmPython.
505 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
507 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
508 entries within the associated public Dicom dictionary resp. the same
509 information but sorted by the fourth field (PAT, IMG, DIR) of the
511 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
512 are now in the "???" group.
513 - python/gdcm.i changed accordingly,
514 - python/demo/printGroupedPublicDict.py added, that gives an example
515 of the above new functionalities in Python.
516 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * src/gdcm.h, gdcmHeader.cxx:
518 - historic references to glib's g_malloc and g_free (#defined)
519 were definitively removed.
520 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
521 * src/gdcmElValSet.cxx:
522 - GetElement(guint32, guint32) renamed to GetElementByNumber.
523 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
524 - GetElValue(string) renamed to GetElValueByName.
525 - Added GetElementByName(string).
526 * src/gdcmHeader.cxx: added
527 - GetPubElValRepByNumber(guint16, guint16)
528 - GetPubElValRepByName(string)
529 - GetShaElValRepByNumber(guint16, guint16)
530 - GetShaElValRepByName(string)
531 - GetShaElValByNumber(guint16, guint16)
532 - GetShaElValRepByName(string)
533 - GetElValRepByNumber(guint16, guint16)
534 - GetElValRepByName(string)
535 - GetElValByNumber(guint16, guint16)
536 - GetElValRepByName(string)
537 * Doc/requirements.txt added.
538 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * Test/Makefile building now depends on the one of libgdcm.so
540 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
541 pixel data) aware which enables finding the address (offset) of
542 the pixel data of JPEG encoded DICOM files. This leaves only a single
543 file in the testSuite whose pixel data address (offset) is unknown.
544 * python/testSuite.py changed accordingly.
545 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
546 * VC++ has some strong limitations when working with the STL, as stated
547 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
548 "Also note that some STL containers (map, set, queue, list, deque)
549 cannot be exported. [...]
550 Some STL classes contain nested classes. These classes can not
552 This is caused by a designed limitation that once a template
553 class is instantiated, it can not be re-instantiated and
555 Since our usage of map<> is ubiquitous in gdcm, this "designed
556 limitation" of VC++ is a pitfall.
557 Hence the Python wrappers of gdcm cannot be incrementally linked
558 against the c++ dynamic library. The dirty but only workaround is
559 to forget about incremental link of dynamic libraries and to generate
560 the Python wrappers library with the inclusions of the underlying C++
562 The following modifications concern this matter on Win32/VC++:
563 - wrapping python correct with standalone wrapped dll (don't use separate
564 dll under windows !!!!)
565 - python21_d debug mode enabled (ask Frog how to use it :-)
566 - NO problem with having an STL member of class for example string in C++
567 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
568 - Python test of dcmlib in Python is ok under windows on a large set
570 * removed glib references
571 * typedef's inserted in gdcm.i for correct swig type management
572 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * python/demo/*.py load.py extracted from test.py. Added explore.py
574 that only displays required tags and testAll.py that parses all
575 the files of the testsuite without using unittest.
576 * python/testSuite.py other additional test on new files added.
577 * Data/* new test files added accordingly to the testSuite.
578 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
579 the vr in the file differs from the one of the dictionary.
580 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
582 values, but limits itself to values which are below a user specified
583 size (by default 1024 bytes).
584 * python/gdcm.i : elements not loaded (because their size is above the
585 user specified treshold) are exported with their TagKey as key of the
586 python dictionary. This enables the testsuite to make some checks
587 on the unloaded elements (since we have their offset and size).
588 * python/testSuite.py
589 - now tests for the existence and proper value of the pixel data
590 - two new examples added.
591 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
592 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
593 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
594 aware. See the strategy comments in gdcmHeader::FindeLength().
595 * Test/test.cxx now accepts a filename as first argument.
596 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
597 * python/testSuite.py changed to integrate test on above files.
598 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
599 * Dicts/dicomV3.dic removed all the trailing (RET) when the
601 * python/testSuite.py more tests added.
602 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * python/testSuite.py unittest test suite added (uses Data)
604 * Data/* dcm and acr files for the test suite.
605 * glib dependance removed from un*x version. We now use ISO C99
606 7.18 Integer types (see stdint.h)
607 - python/Makefile, src/Makefile src/gdcm.h
608 * src/ when an explicit vr (like dicom files) suddenly poped an
609 implicit element we use to mark the underlying DictEntry of the
610 concerned ElValue with "Implicit". This strategy was damageable
611 too the public or provite dictionaries, since some of their vr
612 would be changed. Since Header::FindLength heavily relies on the
613 detection by Header::FindVR of falsely explicit elements, I
614 added an extra ImplicitVr member to ElValue (boolean).
615 The rest of the changes we the necessary adaptations.
616 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
617 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
619 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
620 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
621 * Adaptation for porting to VC++:
623 o forced to use std namespace (for string to be known)
624 o all class use __declspec export style on WIN32
625 - src/gdcmUtil.cxx new Exit method that wraps the exit call
626 (in stdlib.h on Win32 but in std:: for gcc)
627 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
628 variable GDCM_DICT_PATH.
629 * src/gdcmHeader.cxx verbose comments made discrete.
630 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
631 * python/gdcm.i: added a typemap that converts a C++ hashing table
632 to native Python dictionary.
633 * python/demo/test.py:
634 - now uses the native dictionary for exploration of gdcmHeader.
635 - takes an optional filename argument (the file to parse).
636 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
637 PubElVals hashing table.
638 * Dicts/dicomV3.dic removed error prone trailing spaces.
639 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
640 * Python wrapping process moved away from src/Makefile to
641 newly created python/Makefile (as well as gdcm.i)
642 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
643 * src/gdcmHeader::FindLength only looks for current vr when necessary.
644 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
645 from the environement variable GDCM_DICT_PATH (when existing).
646 * src/gdcmDict::GetTag bug fix.
647 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
648 * Straightforward temporary fixes for swig to build the python wrappers.
649 src/Makefile now has a python working entry [by working we mean
650 that we can import de shadow classes without errors].
651 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
652 * hashtest.cxx removed (since allready in Test)
653 * src/gdcmlib.h renamed to src/gdcm.h
654 * src/dcm.i renamed to src/gdcm.i
655 * src/Makefile prepared for python wrapping
656 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * src/gdcmHeader.cxx :
658 - Parsing of header is now separated from loading of element values
659 (see gdcmHeader::LoadElements).
660 - general clean up of hopefully all file access (creation of
661 ReadInt16 and ReadInt32)
662 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
663 * src/gdcmHeader.cxx :
664 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
666 - SetLgrElem renamed to SetLength
667 - GetLgrElem renamed to GetLength
668 - ~gdcmHeader() made virtual to pesky warning messages at compile.
669 * src/gdcmElValSet.cxx fixed both GetElValue methods
670 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
671 due to IdoDude was cleaned out.
672 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
674 concentrates on finding the value representation (when it exists).
675 RecupLgr now only finds the element value length, and it avoids
676 returning the unecessary skL (skipped length).
677 Also, offsetCourant was simply removed (with taille_fich) since
678 it was redundant with the File position internals (by using
679 ftell and fseek). This also made skL (see above in RecupLgr) usage
681 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
682 on the libido specificities which are handled through class
684 * Test/implicit_vr.dcm dicom v3 in implicit value representation
686 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
687 * Truckload of changes. Parsing of header is barely functional
688 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
689 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
690 * src/gdcmHeader.cxx many addons of low level methods
691 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
694 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * This corresponds to all the changes decided at the meeting of
696 May 23 2002. Needless to say we are running late...