1 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Example/Volume2Dicom.cxx : comment unused variables
3 * Test/PrintDicomDir.cxx : comment unused variables
4 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
5 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
6 method that is redondant with AddEntry.
7 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
10 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Bug fix due my last commit (compilation under Windows).
12 * Example/Volume2Dicom : bug fix in the file and reformatting source code
13 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
15 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
17 - Remove printf / sprintf
18 - include iostream AFTER gdcm so we don't get warnings
19 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
21 - Also remove tons of include from header files, hopefully this should
22 speeup the compilation time, since it was becoming a dog slow.
23 - Remove gdcm.h as it include way too many files and slow down compilation
24 (plus it is not up to date)
25 - remove 'using namespace std' this is BAD !
27 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * Remove memory leaks on the DicomDir
29 * Remove some useless datas in DicomDirObject
30 * Add usefull methods in SQItem, to be complient withe the ElementSet
32 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
35 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
37 future, with convertion)
38 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
39 and ImageDataSize values. Remove the method to get the PixelReadConverter
40 from the output of the class
42 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
45 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
47 and vtkErrorMacro use.
48 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
50 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
53 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
54 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
55 The string leaves only in the fonction. So when we make a .c_str(), we
56 get the pointeur on the first element, element that will be destroyed
57 immediately after thee instruction.
58 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
59 file has been opened : the test must be made on the content of the
60 pointer and not directly on the pointer !
63 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
65 the python part recompiles
67 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
69 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
70 X session is killed (for my computer... it seems to not be identic on
73 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
75 avoid problems (otherwise, the difference test between the visible image
76 and the reference is incorrect. If the reference is greater than the
77 screen resolution, it's produce errors).
78 Can be used for only one image. Can be used with a visible flag.
79 * vtk/vtkGdcmReader.cxx : remove commented codes.
80 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
81 under windows at compilation
82 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
84 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
86 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
88 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
89 tests on the image size X, Y, Z
91 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
93 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
94 between the class name and the file name
96 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * src/ : fix compilation warnings for the Write method (2 different
98 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
99 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
100 variable... create a static method in gdcm::Document to access to
101 this variable content.
103 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
105 file, to be accessed by other files (like gdcmFile). Remove commented
106 code. Move the change of the header to the gdcmFile, using the
108 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
109 To be sure of that (and simplify calls), the Write of the header now
110 gets a file name and not a file pointer (std::ifstream).
111 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
112 DocEntryArchive. Remove all open of the written file
114 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
117 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
119 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
121 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
122 some corresponding methods. Write correctly the file and check before
124 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
125 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
126 is now on RGB datas (as before my last commit
127 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
129 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
131 Add a print information of the type of the entry
132 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
133 It was in the gdcmFile, and all write have been regrouped
134 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
135 Write correctly all dicom files (in decompressed mode only at this time)
136 * Test/ : test on files are now made using Raw datas and not color datas if
138 * Example/PrintFile.cxx : add more printings
140 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * Amelioration of code, remove some code copy. For the loading of
142 BinEntry (in gdcmDocument), add the test to verify if the file is already
145 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
147 remove a DocEntry in the header (push an empty DocEntry)
148 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
149 lines. Bug fix in the initialization of the PixelConvert and the
151 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
152 use in TestCopyDicom (now this test can run under windows... but fails)
153 * Test/TestCopyDicom.cxx : amelioration of the test :
154 - test the pixels written
155 - add test points to quickly find where is the error
156 - can set a file name input and output in arguments
157 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
158 amelioration of the test output
160 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
162 all replaced DocEntry's
163 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
164 Now, each needed DocEntry to modify is duplicated, modified and inserted
165 to the header using DocEntryArchive. Thus, after save, we can restore the
166 header initial state.
168 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
171 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
173 correct to copy it. The DictEntry is specified at the DocEntry creation,
174 then, it musn't change in the time.
175 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
176 header correctly. At this time, the change is only made for the first
177 level of the Document. In the future, it might consider sequences.
178 The change is made by replacing a DocEntry by an other that is created
179 outside the class. The old value is kept. When we restore the header
180 status, the added DocEntry is deleted and replaced by the old value.
181 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
182 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
183 set the write type to explicit VR, implicit VR or ACR. Add methods to set
184 the write mode to native, decompressed or RGB (but not used at this time)
186 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
188 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
190 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
192 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
194 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
195 set because already copied when copying the BinEntry's of the header
196 * Test/TestAllReadCompareDicom.cxx : remove warnings
198 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
200 Two problems appear when doing it :
201 - with the gdcmFile : when the GetImageData method is called, the pixels
202 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
203 datas (pixels). And each structure destruct the datas when it's
204 destructed. So we have two destructions for the same datas. To solve it,
205 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
206 datas or not. If it doesn't own datas, then they will not destroyed by
208 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
209 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
210 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
211 create a double destruction of the same DocEntry's. So, to solve it,
212 the TagHT is simply cleared and the DicomDir* elements are destroyed.
213 * TODO : add an entry concerning memory leaks in the DicomDir
215 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
217 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
220 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
222 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
223 after it have been deleted
225 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
226 * FIX: src/* fix the doxygen warnings.
227 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
228 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
229 was erroneously defined with a size of 15 instead of 16. [many thanks
230 to Jean Michel Rouet for pointing out this bug].
232 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
233 1. Finish merging JMR patch for writting DICOM from scratch
234 2. Fix -hopefully- bug with MONOCHROME and space vs null character
235 3. Use const ref when possible
236 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
237 5. A few more comments
238 6. CreateUniqueUID can now be called without parameter"
240 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
241 * ENH: Slightly bigger patch:
242 1. Getting toward full integration of JMR patch for writting dicom from scratch
243 2. Update Test to test part of this patch: CreateUniqueUID
244 3. File was not close properly in gdcmDict
245 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
246 5. Use of const ref instead of copy (speed issue)
247 6. Remove temporary (duplicate) string in TranslateToKey
248 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
249 8. Do not repeat virtual in subclasses
250 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
252 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
253 * Apply first patch toward better string comparison when dealing with broken
254 DICOM files. Essentially the string could be padded with a space instead
255 of a null character as defined by standard
257 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
259 because never used... and in the same time, that's remove some memory leaks
261 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * src/gdcmFile.cxx : now delete the PixelConvert instance.
263 * In examples and tests : change the type of image data variables from void*
264 to uint8_t*. Remmove all delete on image data variables
266 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
268 Verify the file pointer value before open the file, and if it's not null,
269 a verbose message is generated.
270 Close correctly the file when the file isn't considered dicom-like. The
271 correctly close is a call to CloseFile.
272 When closing the file pointer, test if its not null to close the file.
273 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
274 file. For an uncompressed image, the copied datas correspond in the least
275 case to the image size (calculated) or the image size specified in the
276 header. A verbose is generated if these two size mismatch
278 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
280 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
281 break under windows (with msvc6 compilation).
283 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
285 compiling with MSVC6)
287 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * Bugs fix for the Windows build with VC6
289 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
290 needed (only for projects required VTK). If the VTK is included in all
291 projects, there is conflicts with the jpeg lib of vtk when compiling the
292 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
293 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
294 when compiling the gdcm_wrap.cxx file (created by the compilation of the
296 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
297 (like it's already made for the cout use). Otherwise, conflict with the
300 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
301 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
303 - comments on the DicomDir::Method related usage added.
304 - now that we use the namespace gdcm, a lot of internal classes do
305 NOT need to be wrapped anymore.
306 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
307 DicomDir::Method) new example added.
309 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
310 * Improve string manipulation. I now inforce the notion of 'DicomString'
311 A DicomString can contain as many \0 as they want
312 and it is *always* of even length.
313 We only support odd length for very rare case.
314 And in the near future this should be removed.
316 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
317 * /binary_write/ gdcm source. Now even on big endian we are writting
318 little endian. This should -heopfully- fix some tests
320 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 * Now the dictionary is compiled into gdcm lib. This is a default
322 behavior, thus any dic file specified is picked before failback to
323 the one comiled into lib
325 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
326 * Change internals for gdcmDict. Don't use any 'new' any more.
327 This should definitely solve any leak problem, and we should be
328 as fast as before, as long as don't modify too much the dictionary.
330 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
331 * STYLE: ivars should start with a capital letter.
332 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
333 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
335 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
336 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
337 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
338 new 2004 dictionaries added (thanks to JPR).
339 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
340 * CLEANUP_ROUND (15) for gdcmPixelConvert
341 - RLEFrame::NumberFragments is now of type unsigned int
342 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
343 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
346 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
347 * Initial work in gathering all transfer syntax accessors. clearly
348 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
349 ivars, but only one transfersyntax (class) ivar with equivalent method on
352 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
354 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
355 discussed (plus I didn't like having a 2000 lines patch not commited)
357 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
358 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
359 * CLEANUP_ROUND (14) for gdcmPixelConvert
360 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
361 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
362 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
364 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
365 anymore and hence avoids storing a copy of PixelConvert::Decompressed
366 into File::Pixel_Data.
368 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
370 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
371 * CLEANUP_ROUND (13) for gdcmPixelConvert
372 Substituted File::ParsePixelData() with PixelConvert::Print() new
374 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
375 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
376 method to those classes.
377 - src/gdcmFile.[cxx|h]:
378 -- Added a ::Print() method.
379 -- PixelConverter is now a reference instead of a member.
380 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
381 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
383 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
385 collaboration diagram and inheritance diagram should be generated with
387 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
388 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
389 pointlessly wrapped (see
390 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
391 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
392 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
393 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
394 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
395 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
396 -- File::Initialise: PixelConverter setup moved away to
397 PixelConverter::GrabInformationsFromHeader()
398 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
399 interpretation moved away to PixelConverter::BuildRGBImage()
401 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
402 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
403 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
405 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
406 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
407 displayed on Win32 when a brutal abort() occurs (because of uncatched
408 exception). See TODO new entry of this commit for more on this.
409 * TODO added new entry.
410 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
411 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
412 - HandleColor is no longer called from gdcmFile.cxx
413 - gdcmPixelConvert.cxx clean up on method arguments and internal
414 variable names for semantical coherence.
416 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
417 * Finished lossless transition, not only do we now read all lossless jpeg
418 images, without the need of the Cornwell lib, but we do read them properly now
419 * To reduce code (well to avoid code duplication), I defined a common place
420 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
421 redefine symbols. This is not prefect but this the best solution I found for a
422 compilation time jpeg option.
424 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
425 * Update jpeg ijg lib to support lossless jpeg implementation
426 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
428 * Also added a special copyright for dcmtk since we use their bugfixes.
431 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
433 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
434 matters, as stated in warning note at begining of %include section).
435 * src/gdcmDicomDir*.[cxx|h]: coding style
436 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
437 * src/gdcmJpeg8.cxx: doxygen fix.
438 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
439 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
440 from File:: to PixelConvert::.
442 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
443 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
444 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
445 - more code moved away from File:: to PixelConvert::
446 - fat setup of PixelConverter set in place in File::Initialise.
448 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
449 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
450 namespace at the file system level. So now you should convert your examples
452 gdcmHeader -> gdcm::Header
453 It would be nice if people keep in mind to no open the namespace, since it
454 allows compilation on broken plateform which were defining common symbol in
455 the standart namespace (like LP, Unknown ...)
457 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
459 The JPEG fragments are now parsed at the same stage than the RLE
460 information. All code related to JPEG is now in gdcmPixelConvert:
461 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
462 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
463 export a gdcmFile:: method. Those are simply global functions
464 (for the time being this is better than having them attach to
465 either gdcmFile:: or gdcmPixelConvert::).
466 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
467 and stores the result in a gdcmJPEGFragmentsInfo.
468 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
469 code (among other stuff) moved away from gdcmFile:; to
472 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
473 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
474 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
475 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
476 clean up of RLE related code.
477 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
478 - src/gdcmRLE.cxx removed
479 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
480 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
481 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
482 * CLEANUP_ROUND (9) for gdcmPixelConvert
483 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
484 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
485 away from gdcmFile:: to gdcmPixelConvert::.
487 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
489 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
490 This is because Parse7Fe0 used to parse the pixels to compute the
491 length. This task was passed over to FindDocEntryLengthOB() a long
492 time ago, EXCEPT I had forgotten the OW case...
493 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
494 we just recylce the code for parsing RLE fragments and computing
496 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
497 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
498 with the retired Parse7Fe0().
499 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
500 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
502 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
503 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
504 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
505 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
506 - src/CMakeLists.txt: alphabetic order reodering + new entries.
507 * CLEANUP_ROUND (4) for gdcmPixelConvert
508 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
509 to return an unused length.
511 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
512 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
513 this should be cleanner from the plane view. The iostream are erally a pain
514 to use to do simple stuff.
516 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
517 * Redo the compilation of the ijg jpeg library. Now only one source is
518 necesseray. No need to rename file by hand what so ever. CMake handle the
519 copying of the file within different directory, configure header file to
520 modify some symbol. The only addition made to ijg wasd a mangle table so
521 that symbol are different wether we are within 8bits or 12bits.
523 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
524 * Added documentation of vtkgdcmReader on Website:
525 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
526 with it's binary name).
527 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
528 the Website to be more complete.
529 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
530 doxygenated documentation.
531 - Doc/DoxyVtkGdcmReaderExamples.txt added
532 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
533 DoxyVtkGdmReaderExamples.html )
534 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
535 * CLEANUP_ROUND (3) for gdcmPixelConvert
536 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
538 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * CLEANUP_ROUND (2) for gdcmPixelConvert
540 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
542 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * CLEANUP_ROUND for gdcmPixelConvert:
544 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
545 - src/gdcmPixelStuff[h|cxx] removed
546 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
547 - src/CMakeLists.txt changed accordingly
549 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
550 gdcmVersion.py moved to newly created ATTIC related
551 gdcmPython/SetupOldies/ directory.
552 * Autotools clean up:
553 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
554 - autogen.sh configure.in acinclude.m4 python.m4 removed
556 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
557 * src/*.cxx *.h Reference to License.htm fixed to License.html.
558 * Doc/CMakeLists.txt, doxygen.config.in: fix.
559 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
561 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
562 * TODO updated with Mathieu suggestions. I proposed a template for
563 describing TODO entries and used it for new entries.
564 * Added Doc/Website/CodingStyle.html, Developpers.html,
565 DeveloppersPython.html, GdcmDataCvs.html and
566 DownloadVersion0_1.html, DownloadVersion0_3.html.
567 * Some Doc/*.txt Doxygen files (which do not really concern the
568 documentation itself, but the website) moved to html and
569 placed in directory Doc/Website:
570 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
571 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
572 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
573 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
574 * CMakeLists.txt changed accordingly.
575 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
576 DeveloppersPython.html
577 * INSTALL nows refers to Doc/Website/Installation.html
579 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
580 * Added Doc/Website directory, that contains a first raw version
583 2004-09-23 Jean-Pierre Roux
584 * FIX In order not to be poluted any longer by casting problems,
585 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
586 we can now delete[] it safely
587 * VoidArea is now called BinArea (less confusing name),
588 and all the methods called ...VoidArea... are now ... BinArea...
589 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
591 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
593 clear) TagHT, which is an inherited member of gdcmElementSet. It is
594 up to the destructor of gdcmElementSet to clean up TagHt and it's
597 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * Test/CMakeLists.txt: update to follow gdcmData renamings.
599 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
601 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
602 * ENH: added some utility method that builds a flat dictionnary
603 holding all the Dicom entries contained in the recursive structure
604 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
606 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
607 BuildFlatHashTable() that build a flat dictionary.
608 - src/gdcmElementSet.h: added a new private GetTag() accessor.
609 gdcmDocument is now a friend of gdcmElementSet.
610 - src/gdcmElementSet.cxx: clean up.
611 - Example/FlatHashTablePrint.cxx added.
612 - Example/CmakeLists.txt changed accordingly
614 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
615 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
616 moved away from gdcmDocEntrySet (since this class is an abstract class
617 acting like an interface). SQDepthLevel and BaseTagKey are now
619 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
620 and associated accessors. Doxygenation of the class.
621 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
623 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
624 Use SQDepthLevel accessor instead. ::Print() adapted.
625 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
626 - src/gdcmDocument.cxx changed accordingly.
628 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
629 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
630 - The following is the doxygen comment of the typedef declaration
631 of gdcmagKey in src/gdcmCommon.h:
632 gdcmTagKey is made to old an "universal" (as in URL, Universal
633 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
634 A dicom tag allways has a group and an element, but a set of tags
635 embeded in various (optionally nested) sequences and sharing
636 the same group and element all share the same (group, element)
637 "identifier". Hence the (group, element) cannot be used as an
638 identifier (in gdcm we shall refer to a "TagKey") of a tag.
639 In order to construct a proper tag identifier (i.e. a key) we
640 consider the following definition of a TagKey:
641 - let Group, Element be the string representation of the
642 group and element dicom tag members,
643 - let ItemNumber be the string representation of the integer
644 index of the considered item number of a sequence,
645 Let the key of a tag embeded in a sequence, noted SeqTag, be
647 /ItemNumber#Group|Element
648 where "/", "#" and "|" are characters acting as separators.
649 Then the general form of a gdcmTagKey is given by:
650 Group|Element<SeqTag>
651 where <SeqTag> means NO or many instances of SeqTag.
652 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
655 but the gdcmTagKey of a tag "embeded" is the first item of
656 a sequence, itself nested in the third item of a sequence is the
658 0004|1220/2#0008|0082/0#0008|0090
659 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
660 order to hold the new sequence compatible key. Previously, the
661 GetKey() method would look in the underlying gdcmDictEntry.
662 - src/gdcmDocEntry.cxx:
663 -- constructor now copies the underlying DictEntry key, in the local
665 -- ::Print: displays the member Key, instead of the (group, element).
666 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
667 - src/gdcmDocEntrySet.h:xi
668 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
669 -- now has a new BaseTagKey member.
671 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
672 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
674 This poses the problem with the semantics of the following lines
675 LoadEntryVoidArea(0x0028,0x1201); // R LUT
676 LoadEntryVoidArea(0x0028,0x1202); // G LUT
677 LoadEntryVoidArea(0x0028,0x1203); // B LUT
678 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
679 to the long FIXME note for what the problem is. Nevertheless in
680 order to get things working the dicom dictionary was altered !
681 Please fix things urgently...
682 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
683 information), see above note on moving the member VoidArea. Nevertheless
684 the following entries previously correctly set as US are now inproperly
686 0028 1201 OW IMG Red Palette Color Lookup Table Data
687 0028 1202 OW IMG Green Palette Color Lookup Table Data
688 0028 1203 OW IMG Blue Palette Color Lookup Table Data
689 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
690 of gdcmDocEntry moved to gdcmSeqEntry.
691 * src/gdcmSeqEntry.cxx: STYLE.
693 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * Test/TestAllEntryVerify.cxx minor fix and added comments.
696 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
697 * gdcmPython/testSuite.py: all the test suite in python is now moved
698 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
699 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
700 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
702 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
704 to avoid inclusion recursion until STL is reached.
705 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
706 mecanism. errno.h is not included in gdcm anymore.
707 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
708 (gdcmFormatError now inherits from gdcmFormatUnexpected).
710 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
711 gdcmData/TestAllEntryVerifyReference.txt
712 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
713 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
714 exception_on_error parameter.
715 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
716 - vtk/vtkGdcmReader.cxx changed accordingly,
717 - Example/*.cxx and Test/*.cxx changed accordingly.
719 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
720 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
721 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
722 enable_sequences removed from gdcmHeader constructor and dependencies.
723 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
724 * gdcmPython/demo/PrintHeader.py: dummy fix.
725 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
726 skip_shadow removed from gdcmHeader constructor and dependencies.
727 * Example/*.cxx and Test/*.cxx changed accordingly.
729 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
731 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
733 2004-07-21 Jean-Pierre Roux
734 * FIX Now, Parsing and Printing a DICOMDIR do work!
735 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
737 2004-07-20 Jean-Pierre Roux
738 * FIX Some brain damaged headers have Zero-Lenght fields
739 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
741 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
742 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
743 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
744 variable (instance of gdcmDebug) by a definition macro, and the instance
745 is now in static in the gdcmDebug class
746 * src/gdcmSQItem.h : (FIXME) remove an undefined method
747 * Test/PrintAllDocument.cxx : bug fix in the result of the test
749 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
750 * WARNING: ctest now depends more tightly on gdcmData. You should
751 check out gdcmData properly for things to run smoothly...
752 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
753 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
754 we need the pixels not be loaded in order to use the ValEntry
755 that displays position and size).
756 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
757 This is a C++ based equivalent of gdcmPython/testSuite.py that should
758 be deprecated. If you have any doubts about the advantages of a
759 modern scripting language (read Python) versus grass root C++ (i.e.
760 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
761 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
762 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
763 Anyhow, consider documenting the gdcmData images in
764 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
766 * Test/CMakeLists.txt:
767 - now uses TestAllEntryVerify.cxx
768 - specific comments on oldACR00001.ima (now renamed in gdcmData
769 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
770 gdcmData/TestAllEntryVerifyReference.txt
773 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * src/*.[h|cxx] : typedef clean up
775 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
776 - TagKey renamed to gdcmTagKey (for external usage)
777 - VRKey renamed to gdcmVRKey (for external usage)
778 - removal of typedef duplication.
779 - Removed all unecessary inline keyword from class inline definitions.
780 - Some method|function(void) declarations replaced with method|function().
781 * src/jpeg/libijg12/jdhuff12.c:
782 - printf polluting ctest removed.
783 - TAB removal for comminting
785 - TestAllReadCompareDicom.cxx: added a test that compares all the
786 images in gdcmDataImages.h with corresponding images in
787 gdcmData/BaselineDicom/. When baseline images are not present
788 this test creates them.
789 Note: we need to validate each reference image, but before that
790 I'd like to rename them with a more explicit name...
791 - CMakeLists.txt: changed accordingly.
792 * Example/*.cxx: examples now only include gdcm.h (as opposed to
793 including each header needed).
795 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * Test/*.cxx and Example/*.cxx: moved some examples away from the
797 test suite to the Example directory. Are concerned:
802 - TestWriteSimple.cxx
803 * Test/CMakeLists.txt: added some comments on reasons for black listing
804 image gdcmData/oldACR00001.ima
806 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
807 * Test/CmakeList.txt: removed the following from black list (to be coherent
808 with removal from gdcmData):
809 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
810 - gdcm-MR-PHILIPS-16.dcm
812 Added the following because after last cvs update, they cause
813 ctest -R TestReadWriteReadCompare
815 - gdcm-MR-SIEMENS-16-1.acr
817 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
818 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
819 new comments in this file) we temporarily (sigh) move to a weaker
821 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
822 we don't need to black list the following images anymore:
823 - 8BitsUncompressedColor.dcm
825 - US-PAL-8-10x-echo.dcm
826 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
827 fixes and the beautified code ;-)
828 This fixes the bug introduced in version 1.42 (when beautifying)
829 that made the parsing of 8BitsRunLengthColor.dcm unproper.
830 Note: ctest was blind to this bug (this means we need to still
831 improve the test suite). The bug could be detected by using
832 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
834 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
835 and by displaying the (garbage) produced file temp.XDCM...
837 2004-06-29 Jean-Pierre Roux
838 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
839 - replace by uggly but working old code :-(
840 A lot of things should be OK again.
841 It's really urgent to have a test suite that *tests*,
842 to prevent Frog's beautifying sessions to break all the stuff
843 (twice, withing a fortnigh ...)
845 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
846 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
847 redundancy) to added Test/TestReadWriteReadCompare.cxx
848 * Test/CmakeList.txt: because the compare test of
849 Test/TestReadWriteReadCompare.cxx fails, the following images are
850 black listed: - 8BitsUncompressedColor.dcm
852 - US-PAL-8-10x-echo.dcm
853 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
854 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
855 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
856 and ad-hoc kludge. This kludge is now removed, and on encountering
857 such an image (OB field brain damaged) we set errno. Then in
858 ::FindDocLength() we "fix" the length as being ALL what remains
859 in the file (until EOF). We then proceed, hoping for the best...
860 This fixes a SegFault in ShowDicom when trying to write such an
862 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
863 (because TestWriteRead breaks on it, after a non conformal commit?).
864 ctest now runs properly, except for MakeDicomDir (which was allways
865 broken) and the Python related stuff (still not fixed).
867 2004-06-24 Jean-Pierre Roux
868 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
869 FIX : Test/TestReadWrite now iterates on all the file names
870 (instead of infinite loop)
871 ENH : Test/TestWriteRead now iterates on all the file names
873 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
874 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
876 2004-06-24 Jean-Pierre Roux
877 FIX : - now Write drops LUT Descriptors and LUTs (if any)
878 when SamplesPerPixel =3
879 - now Write is no longer confused by
880 'BitsAllocated = 12" and 'BitsStored=12"
881 - "UN" value representation Elements are now written correctly
882 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
883 ENH : - now gdcmHeader has its own Write methods
884 (in order to split the job that has not to be done
887 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
888 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
889 loop on the same image until memory went out.
890 Note: this means we still have gobs of memory loss in PrintDocument
891 * src/gdcmDocument.cxx: fixes problem on parsing on file
892 gdcmData/16BitsJpegLosslessGrayScale.dcm.
894 2004-06-24 Jean-Pierre Roux
895 FIX : Write - All the Sequences and Sequence Item are now written
896 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
897 is added a the end, when necessary.
898 - A lot of brain-damaged images, that were read correctly are
899 now written correctly
900 - length compatible BinEntry are now loaded correctly
901 (even for odd groups)
902 Note : only Explicit Value Representation was checked.
903 (question : is implicit VR really necessary for gdcm ?)
905 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * DEVELOPPER: added a proposition of coding style.
907 * src/gdcmDocEntry.h: removed every inline declaration (for test of
910 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
912 Use the gdcmDocEntry::Print() and Write() instead.
913 * src/gdcmDocument.cxx: bug fix.
915 2004-06-22 Jean-Pierre Roux
916 FIX : gdcmDocument.cxx
917 - Now we do recognize the JpegLossLess format (there was a misstyping in
918 code 'beautyfication' :-(
919 - Now we automaticaticaly load the Luts, if any
921 2004-06-22 Jean-Pierre Roux
922 In order : to write Sequences, whatever their imbrication level,
923 : to allow user to create his own Sequences
924 a lot of modif where necessary (adding, moving, or virtualising methods)
926 WARNING : save your own sources *before* cvs up !
929 ADD virtual void Write(FILE *fp, FileType filetype);
932 ADD virtual void Write(FILE *fp, FileType filetype);
933 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
936 ADD virtual void Write (FILE *fp, FileType filetype)=0;
937 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
938 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
939 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
940 ADD std::string GetEntryByName(TagName name);
941 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
943 std::string vr = "unkn",
944 std::string fourth = "unkn",
945 std::string name = "unkn");
946 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
947 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
948 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
949 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
950 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
951 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
952 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
953 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
956 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
957 ADD virtual std::string GetEntryByName (TagName tagName);
958 ADD virtual std::string GetEntryVRByName (TagName tagName);
959 REM virtual bool Write(FILE *, FileType);
960 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
961 FILE *_fp, FileType type);
962 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
963 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
964 REM virtual bool WriteEntries(FILE *_fp,FileType type);
965 REM virtual std::string GetEntryByName (std::string tagName);
966 REM virtual std::string GetEntryVRByName (std::string tagName);
967 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
968 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
969 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
971 std::string vr = "unkn",
972 std::string fourth = "unkn",
973 std::string name = "unkn");
974 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
975 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
976 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
977 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
980 ADD virtual void Write(FILE *fp, FileType filetype);
983 ADD virtual void Write(FILE *fp,FileType filetype);
986 ADD virtual void Write(FILE *fp, FileType filetype);
987 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
988 REM std::string GetEntryByNumber(guint16 group, guint16 element);
989 REM std::string GetEntryByName(TagName name);
992 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
994 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
995 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
996 The default constructor invoked by the line
997 gdcmHeader *f1 = new gdcmHeader( header );
998 was gdcmHeader::gdcmHeader(bool) instead of the expected
999 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1000 Hence the parsing wasn't executed... See also below.
1001 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1002 as explicit constructor didn't do the trick to fix the above problem.
1003 Could anyone explain why ?
1004 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1005 properly calls gdcmValEntry::Print() (that was weed out from
1006 code related to gdcmBinEntry).
1008 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1009 * In order to fix memory leaks:
1010 - Test/TestWriteSimple.cxx: added cleaning of free store through
1012 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1013 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1014 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1015 (through the call to ::AddDicomDirMeta()) or the destructor
1016 would crash when deleting uninitialized ::metaElems].
1017 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1018 - src/gdcmDocument.cxx:
1019 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1020 from dynamic stores.
1021 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1022 was causing memory leaks.
1023 - src/gdcmSQItem.cxx:
1024 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1025 cleanly handled with polymophism: sorry but my milage is low).
1026 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1027 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1028 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1029 This avoids SegFaulting.
1030 - src/gdcmSQItem.h: coding style.
1032 - Test/TestWriteSimple still severely sucks. The output image content
1033 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1034 damaged when displayed with vtkgdcmViewer.
1035 - on memory leaks: TestWriteSimple leaks really less (see entry
1036 of 2004-06-18 in Changelog file for the call to valgrind).
1037 - on segfaults: ctest now passes all the tests but one (no more
1039 * Erroneous leading white fix:
1040 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1041 white[s] (as opposed to from >> xxx, that removes it [them].
1042 - src/gdcmTS.cxx: ditto.
1043 - gdcmPython/testSuite.py: dirty related kludge removed.
1044 * src/*: remaining references to gdcmParser removed.
1045 * src/*[cxx|h]: added copy[way]left header.
1048 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1049 * In order to fix writing of dicom files:
1050 - Test/TestWriteSimple.cxx: a simpler example of writing.
1051 - Test/CMakeLists.txt changed accordingly.
1052 - src/gdcmDocument.cxx:
1053 -- The destructor now recursilvely removes potential sequences.
1054 -- Bug fix in ::IsJPEG2000()
1055 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1056 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1058 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1059 to only declared) and build on top of
1060 ::GetDocEntryByNumber(guint16, guint16).
1061 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1062 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1063 for usage in destructor and treatement of promotion in
1064 ::ReplaceOrCreateByNumber().
1065 - src/gdcmSQItem.cxx: destructor should better handle his job.
1066 Test/TestWriteSimple now runs (or at least it DOES something).
1067 * We can now start hutting memory links. A good starting point is:
1068 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1069 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1070 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1072 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * Valgrind note: after Mathieu Malaterre teached me how to read
1074 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1076 Using gcc, you can force the STL to use malloc and to free memory as
1077 soon as possible by globally disabling memory caching.
1078 With 3.2.2 and later, you should export the environment variable
1079 GLIBCPP_FORCE_NEW before running your program.
1080 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1081 simply vanish (it is still not clear to me, whether this means that
1082 STL std::string leaks or if valgrind believes it leaks...).
1083 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1084 running bin/gdcmTests makeDicomDir):
1085 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1086 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1088 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1089 SegFaulting (I drowned in DicomDir related code when trying to
1090 understand why the list is empty...).
1091 * src/gdcmDocument.h: first BSD license header try.
1092 * Doc/License.txt added.
1094 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * src/gdcmDocument.[h|cxx]:
1096 - Clean up of the Transfer related predicates. They are now all based
1097 on new method isGivenTransferSyntax, that (should) handle properly
1098 the padding problem.
1099 - general clean up, simplification, and coding style.
1100 - Specific clean up of Parse7FE0() (umproperly named actually).
1101 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1103 2004-06-14 Jean-Pierre Roux
1105 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1106 - fix the display of SQItem ordinal number
1107 - add the GetSQItemByOrdinalNumber method
1108 - remove some useless never written private methods
1110 2004-06-14 Jean-Pierre Roux
1112 - adding a constructor taking a gdcmDocEntry as an input param
1113 - ReplaceOrCreateByNumber now returns :
1114 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1115 a gdcmValEntry * if a string value is passed as a param
1117 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1118 according to the param type (no longer sets a gdcmDocEntry)
1119 - GetValEntryByNumber, GetBinEntryByNumber added
1120 - NewValEntryByNumber and NewBinEntryByNumber added
1122 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1124 - GetSQItemNumber and SetSQItemNumber added, to provide
1125 a (relative) Item identier inside a given Sequence
1126 \warning : some pb remaining around this number
1128 - AddEntry now takes the Item Number as a param
1130 - adding a constructor taking a gdcmDocEntry as an input param
1132 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * Memory leak hunt with the following command:
1134 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1135 --show-reachable=yes gdcmTests PrintDocument
1136 It looks like many (all?) leaks are due to the STL (or a bad usage
1137 of the STL. The lines producing the leaks now have a comment with
1138 a "MEMORY LEAK" tag: you can retrieve them with
1139 grep "MEMORY LEAK" src/*
1140 Here are two typical examples which I can't help fixing:
1145 char * test = "babo";
1146 name = test; //// <--- valgrind detects 960 bytes lost in
1147 //// call to std::string::operator=(char const*)
1148 name.clear(); //// Doesn't help !
1156 std::cout << "Type a bunch of characters followed by RETURN: ";
1157 getline(std::cin, line); //// <--- valgrind dectects a loss
1158 //// of 1320 bytes in call to
1159 /// std::basic_istream<>& std::getline<>
1165 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1166 * src/gdcmHeader.[cxx|h]:
1167 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1168 and related, moved away to gdcmDocument.
1169 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1170 the corresponding protected accessors of inherited class
1171 gdcmDocument, removed ! As a consequence gdcmFile had to be
1172 declared friend of class gdcmDocument (see below).
1173 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1174 - Clean up of undefined or unused methods.
1175 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1176 account the changes to gdcmHeader.h).
1177 * src/gdcmDocument.h:
1178 - gdcmFile is now a friend class (in order to take into account the
1179 changes to gdcmHeader.h).
1180 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1181 (see changes to gdcmHeader.h).
1182 - Accessors (reading on the form GetEntry*) are now public.
1183 - Clean up of undefined or unused methods.
1184 * src/gdcmDocument.cxx:
1185 - adaptation to changes to gdcmDocument.h
1186 - ::OpenFile now writes a verbose message when file cannot be opened.
1187 - some std::string properly set to VRKey
1188 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1189 references to gdcmDocument.
1190 * Test/TestFindTags.cxx: changed accordingly to above changes.
1191 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1192 cvs repository gdcmData.
1194 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1195 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1196 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1197 conflicts with gdcmValEntry::voidArea.
1198 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1199 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1200 Value representation between StringRepresentable and BinaryRepresentable.
1201 * src/gdcmDocument.cxx:
1202 - method ParseDES: proper indentation restored and usage of
1203 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1204 - method LoadDocEntry: the fingerprint left in the SetValue() of
1205 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1206 removed. Reverting to previous code segment with the proper
1207 dynamic_cast< gdcmValEntry* >.
1208 Note: this was (partially) breaking the python test suite
1209 (gdcmPython/testSuite.py) that made usage of the above
1210 fingerprint to check presence of "Pixel Data".
1211 * src/gdcmDocEntry.h: coding style.
1212 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1213 now taken into account.
1214 * gdcmPython/gdcm.i: adaptation to the new internal representation
1215 of gdcm (exit gdcmParser, hello gdcmDocument).
1216 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1218 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1219 anymore, but instead prints the loaded Python dictionary.
1220 * .... alas, the python testSuite is still broken.
1222 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1223 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1225 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1226 * src/gdcmUtil.h : export methods
1228 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1229 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1231 * Initial addition of automatic python testing
1232 * Initial addition of automatic image comparison
1234 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1235 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1236 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1238 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1239 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1240 * Test/ShowDicom.cxx : bug fix for msvc compilation
1241 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1243 2004-05-04 Jean-Pierre Roux
1244 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1245 new concepts (and new classes) :
1246 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1247 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1248 - Sequence Doc Entries (gdcmSeqEntries)
1249 a Sequence is composed of Items.
1250 Each item is a set of Doc Entries (this is recursive)
1251 The non uniqueness of the 'Dicom tag' is due to this recursivity
1252 (never taken into account)
1253 Our unability to add a new 'entry' in the header
1254 at the proper location (neither in the H-Table (map or multimap),
1255 nor in the Chained List is also due to this recursivity.
1256 Don't try, right now, to use/modify/compile these new sources :
1257 nothing is finished.
1258 We just commit all the stuff, 'as is', in order not to loose it.
1260 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1261 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1263 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1264 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1265 file prefix (SetFilePrefix)
1267 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1268 * Add a new test: ShowDicom, for now this is just the c++ version of
1269 checkRead.sh, later it will be able to compare the image read against a
1271 * Replace the DEBUG on the stack with a global entry in cmake interface:
1272 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1274 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1275 * Add an example subdir, with a real example on how to read + write a
1278 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1279 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1280 * Doc/CMakeLists.txt: the main page is now properly differentiated
1281 between the developper and user version.
1282 * Doc/doxygen.config.in: dropped search related obsolete flags
1283 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1285 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1286 * DEVELOPPER: added some helpfull comments for compile/test/install
1289 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1290 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1291 src directory, now generated in the build dir.
1292 2. Tests as mentionned smarter
1294 4. Add a new method in gdcmDict that return the PubDict by name
1295 this is interesting for 3rd party lib like ITK,
1296 where we could set the institution name / patient name...
1298 * ENH: 1. Now the test suite is working for real
1299 2. All binaries are now output in the gdcm-bin directory
1300 (this was not true before)
1302 2004-04-28 Jean-Pierre Roux
1303 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1304 SeQuence indented printing of Dicom Header.
1305 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1306 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1307 Computation of SQDepthLevel is now part of gdcmHeader constructor
1308 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1309 tree-like structure of a Dicom Header.
1310 * FIX Test code cleaning
1312 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1313 * ENH: Adding automatic testing
1314 1. Need a DartConfig.cmake to submit to public
1315 2. Add a test driver gdcmTest.cxx
1316 3. gdcmTestMain, an helper for the main test driver gdcmTest
1317 4. Files in Test don't have a main anymore, this becomes interesting
1318 when we add more and more tests, thus dsw don't have to load
1320 * ENH: Adding a GDCM_DATA_ROOT for testing
1321 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1322 one file instead of seven + some small cleanup
1324 2004-04-22 Jean-Pierre Roux
1325 * ENH Minor changes to the Print() methods.
1326 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1327 Header printing. Example given with :
1328 > PrintHeader fileName 2 new
1329 (SQ based tree-like structure still to be done for the Header ...)
1331 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1332 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1333 1. I have added some unsigned where needed
1334 2. Some function parameter not used -> (void)
1335 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1336 4. g++ don't like character '\' in comment
1337 5. #define jpeg_create_decompress jCreaDecompress
1338 this really need to be fixed
1339 6. virtualize destructor of gdcmObject ... leakage
1340 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1341 this also really need to be fixed
1342 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1343 remove compression file
1344 (as we only do decompression, right ?)
1345 * ENH: Change malloc/calloc/free with c++ equivalent
1347 2004-04-21 Jean-Pierre Roux
1348 * FIX gdcmHeaderHelper::GetXSpacing
1349 when a single value is found (bug ?), xpacing is now
1350 defaulted to yspacing
1352 2004-04-19 Jean-Pierre Roux
1353 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1354 * ENH add parameters :
1355 bool exception_on_error = false,
1356 bool enable_sequences = false,
1357 bool ignore_shadow = false
1358 to the gdcmFile constructors to be full gdcmParser compliant
1359 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1360 to allow reading of PAPYRUS 3.0 files
1362 2004-04-06 Jean-Pierre Roux
1363 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1365 2004-04-02 Jean-Pierre Roux
1366 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1367 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1368 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1370 2004-03-30 Jean-Pierre Roux
1371 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1372 for ACR file, written out as DICOM files (hope so...)
1374 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1375 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1376 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1377 moved to base class gdcmParser and only the specialisation is kept
1379 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1380 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1381 already does the job.
1382 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1383 (to be consistent with gdcmParser::WriteEntries).
1385 2004-03-30 Benoit Regrain
1386 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1387 upate of the object's instance. It's passed to 2 in the unfavorable
1388 case : one in the ExecuteInformation, one in the ExecuteData
1390 2004-03-29 Jean-Pierre Roux
1391 * ENH : Check on file type to be written moved
1392 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1393 * FIX : gdcmObject::ResetBoundaries now stops properly
1394 when end-of-list is reached
1395 : gdcmVersion modified (as Benoit Regrain asked)
1397 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1398 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1399 * src/gdcmUtil.cxx: added forgotten iostream include.
1400 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1401 equivalent to ExplicitVR in existing code).
1403 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1404 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1405 now contains all the gdcmGlobal related code.
1406 * minor coding style and doxygenation changes.
1408 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1410 now contains all the Debug related code.
1411 * minor clean-up of includes in src/*.cxx
1412 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1413 CreateCleanString) removed.
1414 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1415 * Doc/DoxyMainPageUser.txt added.
1416 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1417 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1418 src/gdcmDirList.cxx)
1420 2004-03-24 Jean-Pierre Roux
1421 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1423 2004-03-23 Jean-Pierre Roux
1424 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1425 big endian made volumes
1426 * ENH Now gdcmParser constructor and destructor are protected to forbid
1427 end user to instanciate class gdcmParser
1428 (only gdcmHeader and gdcmDicomDir are meaningfull)
1430 2004-03-22 Benoit Regrain
1431 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1432 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1433 gdcmSerie to gdcmDicomDirSerie
1435 2004-03-19 Jean-Pierre Roux
1436 * ENH Now the tree-like structure describing a DICOMDIR comming from
1437 an already existing DICOMDIR file is consistent with
1438 the home-made tree-like structure build ex-nihilo
1439 or build from the files held (recursively) in a Directory
1440 functions gdcmDicomDir::CheckBoundaries()
1441 gdcmObject::SetBoundaries() added
1443 2004-03-17 Jean-Pierre Roux
1444 * REM (Eric Boix bug) : removal of meaningless
1445 gdcmDicomDirImage::NewImage function.
1446 * FIX now file names and directory name are written properly in the
1448 * FIX now gdcmDicomDir constructor may be call without any trick
1451 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1452 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1453 of gdcmDicomDirImage::NewImage as empty function.
1455 2004-02-28 Jean-Pierre Roux
1456 * ENH add gdcmDicomDir:NewPatient
1457 add gdcmDicomDirPatient:NewStudy
1458 add gdcmDicomDirStudy:NewSerie
1459 add gdcmDicomDirSerie:NewImage
1460 to allow making gdcDicomDir object.
1461 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1462 (as opposite to the gdcmHeader chained list)
1464 2004-02-11 Benoit Regrain
1465 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1466 when using from python
1468 2004-02-10 Benoit Regrain
1469 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1470 * FIX : in gdcmDicomDir when the directory is empty
1471 * ENH : add callback and methods to get the progression of dicomDir
1474 2004-02-06 Jean-Pierre Roux
1475 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1476 - GDCM_META added to gdcmDicomDirType
1477 - class gdcmMeta created
1478 * ENH : - A brief summary is now displayed at the beginning of
1479 'testDicomDir' to help disaster magnitude estimation
1480 * REM : Now useless Test/explDICOMDIR.cxx
1482 2004-02-05 Benoit Regrain
1483 * ENH : add methods in gdcmObject to get the hash table or the list of
1485 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1486 * FIX : wrapping python for TagHeaderEntryHT
1488 2004-02-04 Benoit Regrain
1489 * FIX : even length for some strings when writting the dicom dir
1490 * FIX : sort the images in the dicom dir
1491 * FIX : Bug fix for python use of dicom dir
1492 * ADD : a python demo
1494 2004-02-04 Jean-Pierre Roux
1495 * FIX : Final solution (?) for icone embedded images
1496 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1497 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1498 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1499 gdcmData/gdcm-MR-SIEMENS-16.acr1
1500 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1501 to make full checking easier
1503 2004-02-04 Benoit Regrain
1504 * FIX : WriteEntries : coding style & logic in parameters
1505 * FIX : Set the elements to create the DicomDir in a dictionary file
1507 2004-02-03 Benoit Regrain
1508 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1509 * gdcmDicomDir : add the load of directory
1510 * Bug fix and print add-on
1512 2004-02-03 Jean-Pierre Roux
1513 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1514 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1515 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1516 * FIX gdcmParser.cxx : 'group length' elements are now considered
1517 as integers, even for shadow groups, when file is Implicit VR
1519 2004-02-02 Jean-Pierre Roux
1520 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1522 of the last synonym :-(
1523 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1525 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1526 * FIX taking into account the possible 7fe0,0010 multiplicity
1527 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1528 to allow removal of references to 7fe0,0010, to deal with
1529 ACR-NEMA images, when 0028,0200 is meaningfull
1531 2004-01-31 Jean-Pierre Roux
1532 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1533 no longer writes 'Un' on disk
1534 * FIX SQ elements with actual length are now dealt with corectly
1535 * FIX gdcmFile::WriteBase make the difference, for color images, between
1536 the length (for Palette expanded images)
1537 and Raw Length (non expanded image + Palette)
1538 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1539 (that broke Write). Replaced by UL.
1540 Aware user will reload the field if he
1541 thinks it's necesssary
1543 2004-01-30 Jean-Pierre Roux
1544 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1545 when 'dirty Acr' is found, to be compliant with the new
1546 IsReadable() methods.
1548 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1549 (no DOUBLE images in kosher DICOM,
1550 but so usefull for people that miss them ;-)
1552 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1553 DICOMDIR related utilities (not checked as Windoze compliant)
1555 2004-01-28 Jean-Pierre Roux
1556 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1558 2004-01-27 Jean-Pierre Roux
1559 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1560 to allow skipping the shadow elements, to save memory space.
1561 The TRUE value for this param has to be used
1562 with a FALSE value for the 'enable_sequence' param.
1563 ('public elements' may be embedded in 'shadow Sequences')
1564 * gdcmHeader methods now deal with 'embedded icones images' in the header
1565 (even when an 'icone image sequence' is announced by the
1566 element (0x0088,0x0200), but there is NO icone at all ...
1568 * gdcmHeader sometimes Image Location value doesn't follow
1569 the supposed processor endianity (see gdcmData/cr172241.dcm).
1572 * gdcmHeader add the method
1573 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1574 to get *all* the Header Entries with the same tag.
1575 GetHeaderEntrySameName is probabely *useless*
1576 (no meaning : Name is *not* an identifier within the Dictionnary)
1578 2004-01-26 Benoit Regrain
1579 * Bug fix in the print of hexadecimal representations. Remove long fields
1580 in the print and add a third level of print to print them
1582 2004-01-23 Benoit Regrain
1583 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1584 * Bug fix on test suite after remove the strip made on not string fields
1585 * Split the IsReadable method between gdcmParser which test that the file
1586 is dicom and gdcmHeader which test that it's an image file
1588 2004-01-22 Benoit Regrain
1589 * DicomDir : clean code, add methods, set variables in protected or private
1590 * gdcmUtil : bug fix for the clean string method
1592 2004-01-19 Benoit Regrain
1593 * Add the use of shadow dictionaries
1594 * bug fix and coding style
1596 2004-01-19 Benoit Regrain
1597 * src/gdcmFile.cxx : bug fix concerning the close of file
1598 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1599 * Add the update of header entries using the shadow library
1601 2004-01-19 Benoit Regrain
1602 * removal of file gdcmHeader2.cxx
1603 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1604 inheriting from gdcmParser. This split is to prepare the integration
1605 of dicom dir parsing
1606 * bug fix under python
1608 2004-01-16 Jean-Pierre Roux
1609 * REM removal of class gdcmHeaderEntrySet
1610 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1611 * ADD add file gdcmHeader2.cxx
1612 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1614 2004-01-15 Benoit Regrain
1615 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1616 entries created while parsing the header. Thus, they will be destroyed
1617 when the gdcmDictSet will be destroyed
1618 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1621 2004-01-15 Benoit Regrain
1622 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1623 made a fatal error because of the memory release at the end of program.
1624 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1625 some memory and vtk seems to have some problems with that.
1626 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1628 2004-01-14 Benoit Regrain
1629 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1630 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1631 * src/*.[h|cxx] : make changes due to class name changes
1632 * gdcmPython/demo/*.py : bug fix due to method names
1634 2004-01-13 Benoit Regrain
1635 * src/*.[h|cxx] : coding style
1636 * vtk/*.[h|cxx] : coding style
1638 2004-01-13 Benoit Regrain
1639 * gdcmPython/testSuite.py : test the readable flag of file for tests
1640 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1641 It's lied to the stl compilation by MSVC (windows, always windows...)
1642 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1644 2004-01-12 Benoit Regrain
1645 * src/*.h : add comments
1646 * src/gdcmDictSet.h : set the method BuildDictPath in public
1647 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1648 directly setted in the source code
1649 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1652 2004-01-09 Benoit Regrain
1653 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1654 * setup.py : use a reference to gdcmVERSION
1656 2004-01-07 Benoit Regrain
1657 * Modification to compile with the distutils.
1660 2003-12-10 Benoit Regrain
1661 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1662 can use a gdcmHeaderHelper to load datas
1663 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1664 made in the source code
1666 2003-12-10 Benoit Regrain
1667 * Update Windows projects and .cvsignore files
1669 2003-11-12 Jean-Pierre Roux
1670 * ENH gdcmHeader constructor has one more parameter (default value : false)
1671 that allows the user to 'go inside' the SeQuences only
1673 gdcmElValSet:Print takes it into account
1675 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * ENH: Update gdcmPython/CMakeLists
1677 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1678 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1680 2003-11-10 Jean-Pierre Roux
1681 * FIX : gdcmHeader::LoadElements is now based
1682 on the ListTag listElem member,
1683 not longer on the TagElValueHT tagHt member
1684 * ENH : PrintPubElVal shows (temporarily) both results,
1685 with the tagHt member and the listElem member.
1686 (it's easier to 'see' the problems when using Printheader)
1688 * FIX : old private member LgrElem is now splitted into
1689 ReadLength : Length actually found on disk (updated only
1690 if bug fixing is necessary), for internal
1692 UsableLength : Updated by FixFoundLength, to fix a bug
1693 or to allow Parser going on.
1694 Will allow to re-write a kosher header when a SeQuence
1695 with a length (not 0000) is found
1696 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1697 because gdcmElValSet::Add does not update ListElem
1700 2003-11-07 Jean-Pierre Roux
1701 * FIX misstyping in Transfert Syntax name table
1702 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1703 when they have an actual length (not 0000 nor FFFFF)
1704 (Nobody should care of it, but DICOMDIR explorers)
1706 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1707 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1709 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1710 * ENH: vtkGdcmReader now supports LUT !
1711 (vtkgdcmViewer for now is not able to use them though)
1713 2003-11-05 Jean-Pierre Roux
1714 * in testSuite.py : new files names for checking the package
1715 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1716 that returns the pixel area size to the *aware* (vtk) user
1717 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1719 2003-11-05 Benoit Regrain
1720 * in testSuite.py : Modify the rules for checking the paths
1721 : Explicit error messages
1722 * in __init__.py : Related modif
1724 2003-11-03 Jean-Pierre Roux
1725 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1726 to be used by aware (vtk) users that want to manage
1727 LUT (and no to turn the PALETTE image into an RGB pixels one)
1728 * GetPixelType now returns 8U for 24 Bits images
1729 (vtkGdcmReader compliant)
1731 2003-10-31 Jean-Pierre Roux
1732 * Removal of *all* gdcmData images and add them again
1733 in order to loose the 'history' of un-anonymised images
1735 2003-10-31 Jean-Pierre Roux
1736 * RMV : removal of useless jBitsInJsample.h
1737 for both 8 and 12 Bits JPEG Lossy Libraries
1739 2003-10-31 Jean-Pierre Roux
1740 * ENH : Add the functions gdcmFile::GetImageDataRaw
1741 gdcmFile::GetImageDataIntoVectorRaw
1742 that act as GetImageData and GetImageDataIntoVector
1743 except the making of an RGB Plane from Gray Plane + LUT
1744 Intended to aware (vtk) users who know how to manage
1747 GetLUTRGBA return a R,G,B,A LUT if any
1748 lgrTotaleRaw gives the 'Raw' length
1749 GetImageDataRaw returns the gray Plane
1750 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1751 (They stay Grey, just like with other Dicom viewers :-(
1753 2003-10-30 Jean-Pierre Roux
1754 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1756 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1757 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1758 being coherents dicom files.
1760 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1761 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1763 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1764 * ENH: Two steps is necessary to please VC++ compiler...
1765 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1766 * ENH: Add include dir to medcon lib
1767 * FIX: only one function is being exported for now !
1768 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1770 2003-10-29 Jean-Pierre Roux
1771 * adding gdcmHeader::GetLUTRGBA
1772 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1773 --> Mathieu, the modif u're waiting for is not yet committed
1774 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1776 2003-10-27 Jean-Pierre Roux
1777 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1778 00191113.dcm DermaColorLossLess.dcm
1779 MxTwinLossLess.dcm RadBWLossLess.dcm
1780 * ENH: For version prior to vtkImageViewer2 -r 1.19
1781 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1783 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1784 * Removal of ido stuff in CMakeLists.txt
1786 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1787 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1788 * FIX: remove a call to ->Modified ... see comments
1789 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1791 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1792 * FIX: Problem with path for libvtkgdcmPython
1793 * ENH: Try adding a search script for python site-package
1794 * RMV: Remove some file from medcon lib that are not necessary
1795 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1796 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1797 * FIX: More pragma disable fro VC++,
1798 I don't think I break something as it is also disable in VTK/ITK.
1799 But it fasten debug compilation time.
1801 2003-10-23 Jean-Pierre Roux
1802 * gdcm now deals with 16 Bits Run Length Encoded images
1803 (they are compressed as 2 planes images,
1804 one for the high Bytes, the other for low Bytes)
1806 2003-10-22 Jean-Pierre Roux
1807 * Now CheckRead takes into account :
1808 - the bugged 'Leonardo' Siemens images
1809 - the XA images, sent thru the burning VPRO station
1810 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1813 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1814 * FIX: When copying a Makefile.am to CMakeLists.txt
1815 one should remove the '\'
1817 2003-10-22 Jean-Pierre Roux
1818 * in gdcmData adding a bugged 'Leonardo' Siemens image
1819 (wrong lengths in header)
1820 OK with gdcm, KO with the other viewers :-)
1821 * add a GE dlx XA image, thru the VEPRO burning station
1824 2003-10-21 Jean-Pierre Roux
1825 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1826 for a brutal checking of vtkgdcmViewer compliance
1828 2003-10-21 Jean-Pierre Roux
1829 * add the files for 'xmedcon' Jpeg Lossless library
1830 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1832 2003-10-21 Jean-Pierre Roux
1833 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1835 2003-10-21 Jean-Pierre Roux
1836 * garbage Siemens 'Leonardo' images dealt with
1837 (the patch is easy to remove)
1838 * cosmetic changes to avoid warnings
1840 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1842 no need to press 'r' now.
1844 2003-10-20 Jean-Pierre Roux
1845 * upgrade of checkRead.sh checkWrite.sh according
1846 to new Jpeg Lossless decompressor
1847 * add US.3405.1.dcm, a genuine RGB medical file ...
1848 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1849 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1851 2003-10-15 Jean-Pierre Roux
1852 * general anonymisation in gdcmData
1853 * adding the 'color files' from
1854 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1855 * adding some well knowed bugged-header images
1856 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1857 waiting for their inclusion in Python testsuite
1859 2003-10-15 Jean-Pierre Roux
1860 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1861 no longer seg faults when file is not found
1863 2003-10-14 Jean-Pierre Roux
1864 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1867 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1868 * TODO: *.in file to genereate a UseGDCM later
1870 2003-10-14 Jean-Pierre Roux
1871 * Some supposed-to-be Dicom Images have no preamble.
1872 OpenFile takes it into account
1873 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1874 * Missing elements added in dicomV3.dic
1875 (just to be affraid : have a look at
1876 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1877 and do it again next year ;->
1879 2003-10-13 Jean-Pierre Roux
1880 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1881 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1882 But there are NOT. It's fixed !
1884 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1885 * FIX: "jpeglib.h" was not found on VC++
1886 * FIX: vtkgdcm was not being installed
1888 2003-10-10 Jean-Pierre Roux
1889 * ENH : OpenFile closes the file if it *really* doesn't look like
1890 an ACR-NEMA / DICOM one.
1891 * FIX : testWrite no longer writes an empty file if the source file
1892 is not gdcm Readable
1893 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1896 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1897 * FIX: CMake generate now documentation
1898 * ENH: out of source doc build !
1899 * ENH: Generate both user and dev documentation
1900 * ENH: Should work on windows too
1901 * ENH: Only one doxygen config.in file is needed
1902 * FIX: make install should be ok now on ùnix plateform
1903 * FIX: PATH to dictionary was wrong (missing /)
1904 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1906 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1907 * vtkGdcmReader is now able to read rgb dicom file.
1908 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1909 * added a gdcmViewer to vtk test, use mouse to control
1910 window level & window width
1912 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1913 * CMake-ification of gdcm, we have now two build system
1914 * FIX: on cygwin Wsock32 doesn't exist
1915 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1917 2003-10-06 Emanuel Ollart
1918 * FIX : compilation process wad broken.
1919 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1921 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1922 * change gdcmViewer -> vtkgdcmViewer
1923 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1925 2003-10-06 Jean-Pierre Roux
1926 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1927 ( e.g : well known GE images with a wrong elem length,
1928 : Philips MRI Images with a wrong Huffman table)
1929 * still to be done : allow the reading of bugged LEONARDO Siemens images
1931 2003-10-03 Jean-Pierre Roux
1932 * Odd length strings are padded with '\0' (not with spaces,
1933 to remain compliant with already defined strings,
1934 like Transfert Syntax UID and others)
1936 2003-10-03 Jean-Pierre Roux
1937 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1938 to allow displaying RGB images (not only by affim ;-)
1940 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1941 * vtkGdcmReader is now able to read rgb dicom file.
1942 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1944 2003-10-03 Jean-Pierre Roux
1945 * A few nasty patches to allow the reading of a lot of nasty images
1946 ( e.g : well known GE images with a wrong elem length,
1947 : Philips MRI Images with a wrong Huffman table)
1948 * still to be done : allow the reading of bugged LEONARDO Siemens images
1950 2003-10-03 Jean-Pierre Roux
1951 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1953 2003-10-03 Jean-Pierre Roux
1954 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1955 to allow displaying RGB images (not only by affim ;-)
1957 2003-10-03 Jean-Pierre Roux
1958 * gdcmFile::GetImageDataIntoVector now
1959 - deals with MultiFrames MultiFragments Run Length Encoded files
1960 - deals with YcBcR (YBR_FULL) files
1961 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1962 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1964 (no sample found :-(
1966 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1967 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1968 Two reasons: - clear things
1969 - third parties acces gdcm through header files, so won't
1970 suffer anymore VC++ complains
1972 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1973 * add argv[1] in testvtkGdcmReader.cxx
1976 2003-09-24 Jean-Pierre Roux
1977 * The lines are now eigthy characters long.for
1978 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1980 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1981 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1982 char* to std::string. Thus, the use of strdup becomes useless. (see
1983 previous commis of Malaterre)
1984 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1985 before the last Malaterre's commit.
1987 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1988 * This commit should fix the Debug building under VC++, the problem
1989 was mainly a mixture of debug and release lib being loaded at startup.
1990 * I also remove a depency to a specific C function: strdup. Because I had
1991 to force the link to msvcrtd (whereas strdup is in libc).
1993 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1994 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1995 located in the gdcmCommon.h file. All use of reference of tha has been
1996 changed to now use the variable GDCM_UNFOUND.
1998 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2000 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2001 Dicom dictionary. The test suite can now be run again. Note:
2002 I'm note very happy with the " (RET)" changes. I believe this
2003 RETAINED comment should be dropped when parsing the dictionary.
2004 - PACKAGER corrected
2006 - AUTHORS updated and now in alphabetical order
2007 * Makefile.am now exports gdcm.dsw for Windoze users.
2009 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2010 * cygwin complains about missing std:: in subdir Test/
2012 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2013 * remove some methods that are now in gdcmHeaderHelper
2015 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2016 * vtkGdcmReader set spacing and origin correctly
2018 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2019 * Fix a few delete/delete[] mismatch
2021 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2022 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2023 interpretation to data given by gdcmHeader. For instance there are
2024 heuristics to get informations (look at different places).
2025 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2026 sorting DICOM images based on different strategies.
2027 * modified Makefiles accordingly.
2029 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2031 when building in debug mode
2032 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2033 src/win32/gdcmdll.dsp
2034 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2036 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2037 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2040 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2041 * src/win32/libgdcmjpeg12.dsp was not dos format
2042 * src/win32/libgdcmjpeg12.dsp :
2043 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2044 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2046 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2047 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2049 * src/gdcmFile.cxx : bug fix in affectation type
2050 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2051 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2052 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2053 symbols... future problem ?
2055 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2056 * src/win32/libgdcmijpeg12.dsp was missing
2057 * modified gdcm.dsw accordingly
2059 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2060 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2062 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2063 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2064 commit of JPR (before his hollidays to facilitate our work).
2065 * setup.py : bug fix in code. Modifications made while the last commit
2066 of JPR. The code hasn't been tested before the commit... it's so
2067 useless to make that (for best programmer that is JPR) !!!
2069 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2070 * tagged the current version as Version0_3 (i.e. version 0.3)
2072 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2073 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2074 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2075 * *.dsp : modifications to use new libgdcmijpeg8 library
2076 * setup.py : bug fix on VTKPATH variable
2077 * PACKAGER : adding all concerning windows
2079 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2082 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2083 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2084 test suite reported error.
2085 * PACKAGER file added (describes what a packager must do when
2086 packaging a new release).
2087 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2088 * configure.in: upgraded version number to 0.3.0
2089 * fixing build of rpm (through rpm -ta):
2090 - Doc/Makefile.am exports proper doxygen files
2091 - src/jpeg/libijg8/Makefile.am exports the include files.
2093 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2094 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2095 * src/gdcmHeader.h : formatting code
2097 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2098 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2099 We were obtaining error message from vtk. Now, creation of file list
2100 is made in an internal list to prevent this problem.
2101 Bug fix when output is empty.
2102 Bug fix in update of progress value. Previous commit for this was a bad
2104 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2106 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2107 * src/gdcmHeader.h : added method to get the file name
2108 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2109 files. Added method to remove all files on the input
2110 Added FIXME comment concerning the bad parsing of header made by
2111 ExecuteInformation method (in ExecuteData method)
2113 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2114 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2115 when using make instal.
2116 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2117 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2119 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2120 * setup.py : adding include dir of jpeg lib to compile all sources
2121 * */Win32/*.dsp : JPR fix for windows compilation
2123 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2124 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2126 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2127 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2129 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2130 * setup.py is again effective on un*x (takes into account the
2131 addon of the jpeg library)
2132 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2133 * Doc/Doxy* updated (includes above enhancements)
2134 * INSTALL now points to web documentation
2136 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2137 * src/gdcmHeader.h doesn't make unnecessary reference to
2139 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2141 * src/gdcm*.[cxx|h] :
2142 - to allow compilation with gcc 3.x
2143 -- clean up of STL usage (added explicit usage of std::)
2144 -- small fixes on exceptions.
2145 Note: linking not tested !
2146 - clean of doxygen comments to avoid warnings at documentation
2148 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2149 dependent convertion).
2151 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2152 * Clean up of previous JPR garbage commit (not even commented in the
2154 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2155 - moved all jpeg related files from src to src/jpeg/libijg8, with
2156 addition/modification of Makefile.am and configure.in.
2157 - the testSuite is still brain damage (not guilty).
2159 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2160 * WrapVTK.py : modifications to get correctly vtk source files to
2162 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2163 (FileName -> Filename)
2165 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2166 * vtk/vtkGdcmReader.[cxx/h]:
2167 - UpdateProgress method should now be effective
2168 - removed the limitation on having only images loaded (as opposed
2170 - when building a stack of images/volume, a lesser number of
2171 gdcmHeader and gdcmFile instances should be used (hopefully
2172 accelerating things).
2173 - when building a stack of images/volumes, files which are not
2174 loadable (wrong path-filename, wrong permissions on existing file,
2175 or file not parsable by gdcm) are replaced with a black image
2176 in the stack (for the caller to notice the problem).
2178 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2179 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2181 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2182 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2183 between standard library (std) and vtk library (problems are found
2184 under Windows... thanks Windows !)
2186 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2187 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2189 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2191 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2192 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2194 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * When compiling with distutils (see setup.py) the C++ compiler is
2196 called with different flags than the default ones (with automake).
2197 In order to fix all those warning, I compiled gdcm with the command
2198 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2199 and went for warning fixes:
2200 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2201 up from unused variables.
2202 - vtk/vtkGdcmReader.cxx: potential bug fix.
2203 * src/gdcmHeader.h: Doxygen warning cleanup
2205 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2206 * gdcmPython/gdcm.i:
2207 - typemaps correction to take into account the systematic replacement
2208 of "using namespace std" with std:: prefix e.g. std::list,
2209 std::string... (cf changes of 2003-05-21).
2210 - gdcmGlob global variable of type gdcmGlobal (defined in
2211 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2212 exported to Python a as cvar.
2213 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2214 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2215 gdcmDictSet.GetPubDictTagNames() and
2216 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2217 C++ static methods).
2218 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2219 with the above changes.
2221 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2222 * setup.py, manifest.in : bug fix under linux
2224 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2225 * Modification of setup.py to compile vtk part too. Then, we have 2
2226 wrappers which must work with same distutils. For that, we have a
2227 generic distutils in distusiltsWrapping.py ; with :
2228 - build_extWrap class to wrap generically all extensions,
2229 - ExtensionWrap base class for all wrapping extension that contains
2231 - Wrapper interface which wrap sources
2232 + In WrapSwig.py we have extension and wrapper for Swig
2233 + In WrapVTK.py we have extension and wrapper for VTK
2234 * MANIFEST.in : modifications to consider vtk directory and new python
2235 files for compilation
2237 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2238 * Added python wrappers of vtkGdcmReader vtk class (see the
2239 source in vtk/vtkGdcmReader.cxx) :
2240 - vtk/Makefile.am now builds a library
2241 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2242 python library (as opposed to _gdcm.so wich are the python
2243 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2244 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2246 - configure.in has an additional flag --enable-vtk that needs
2247 to be set to enable compilation of vtk related code, that is:
2248 + vtk/vtkGdcmReader.so and
2249 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2250 + gdcmPython/vtkgdcmPython.so (see above)
2251 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2252 be read when compressed or when HighBit + 1 != BitsStored),
2253 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2254 the usage of the python wrapper of vtkGdcmReader vtk class.
2255 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2256 * src/*.[h] all occurences of stl classes are now prefixed with
2257 std::, and all occurences of "using namespace std;" where removed.
2258 This is to avoid pollution of global namespace in included files.
2259 Apparently vtk does not avoid this pitfall: when using both
2260 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2261 collision of various stl members (principally cout...).
2262 * gdcmPython/testSuite.py now cleanly removes temprory generated
2264 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2265 comply with above changes)
2267 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2268 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2269 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2270 vtk data structure (an image Flip was required).
2271 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2272 * cosmetic changes in documentation.
2274 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2275 * src/gdcmHeader.cxx: the constructor no longer exits when an
2276 unexisting file is given as argument.
2277 * The subdirectory Data (containing all the images used for the
2278 test suite) is not part of this repository anymore. A new module
2279 containing those images is now available at
2280 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2281 with the name gdcmData.
2282 All the python scripts (including the package initialisation file
2283 gdcmPython/__init__.py) were adapated to take this change into
2284 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2286 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2287 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2288 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2289 demo of the usage of this class.
2290 Compilation of this vtk part is only done when using the --enable-vtk
2291 at configure (or autogen.sh) stage.
2293 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2294 * More memory link related corrections and documentation fixes.
2296 - maximum info is obtained with a command of the form:
2297 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2298 --show-reachable=yes PrintHeader
2299 - the remaining reachable blocks seem to come from the STL
2300 allocation scheme through the usage of map and list. It looks
2301 like this memory cannot be freed but it is not a memory leak
2302 (in fact further invocation to the STL would recollect the
2303 unused memory allthough it cannot explicitely be freed).
2304 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2305 of displaying an image parsed with gdcm and displayed with VTK.
2306 Note: some images don't seem to work e.g.
2307 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2308 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2309 Allthough this weakens the semantics, it is a ditch attempt to
2310 make gdcm more thread friendly.
2312 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2313 * Memory link hunt (by using valgrind through the command
2314 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2315 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2316 gdcmHeader::_dicom_vr.
2317 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2318 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2320 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2322 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2323 * src/Makefile.am now exports all the necessary include files at
2327 * UpdateGroupLength replaced by new one
2330 * UpdateGroupLength re-written using H-Table
2331 (named UpdateGroupLengthNew untill checks are over)
2333 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2334 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2335 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2337 - gdcmHeader::GetPubElValSet removed.
2338 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2339 UpdateGroupLength, WriteElements, Write.
2340 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2341 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2342 carried the same semantics.
2343 - src/gdcmHeaderIdo.cxx changed accordingly.
2344 - gdcmFile::WriteBase now regroups all the codes from previous
2345 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2346 - enum FileType moved to gdcmCommon.h
2347 * src/gdcmHeader.cxx AddDefault trashed
2348 * gdcmGetXSize added
2349 * getimageDataSize now calls gdcmGetXSize
2350 * Test/*.cxx changed to agree with above changes
2352 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2353 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2354 (to avoid double call by end user).
2355 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2356 by end user, since gdcmHeader::gdcmHeader now handles it.
2358 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2359 * gdcm/Doc many doxygen changes:
2360 - Doxyfile now has two different versions, DoxyfileUsers that generates
2361 the html.users end users oriented documentation and
2362 DoxyfileDeveloppers that generates the html.developper developper
2363 oriented documentation.
2364 - README changed accordingly
2365 - requirement.txt removed (old design info moved to TODO).
2366 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2367 DoxyMainPage.txt, DoxyPython.txt provide more information.
2368 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2369 be updated by simply regenerating the docs with doxygen and copying
2370 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2371 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2372 all the tests in the form "if (<map>.count() >1)" were removed.
2373 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2374 ill-formed documentation sections.
2375 * src/gdcmHeader.cxx: ditto
2377 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * setup.py fixed for un*x (needed macro for stdint.h)
2379 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2380 un*ces with sh-utils test utility.
2381 * gdcmPython/demo/test.py renamed to PrintHeader.py
2382 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2383 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2384 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2385 * src/gdcm*.cxx JPR's bad inclusion fixed.
2387 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2389 * gdcmPython/demo/test.py changed accordingly.
2391 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * gdcmPython/Makefile.am fixed linking against libstdc++
2393 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2394 * Swig subdir (historical tests of swig version 1.3.17++) removed
2395 * Test/testChangeEntete.cxx some lines commented out in order to make
2397 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2398 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2400 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2401 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2402 hence the user doesn't need this explicit call.
2403 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2404 i.e. LoadElements() call removed.
2405 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2406 - src/Makefile.am declares the proper flag for g++.
2407 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2408 for adding user defined new tags.
2409 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2410 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2411 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2413 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2414 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2415 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2416 src/Makefile.am : the project should properly compile and install
2417 with the autotools, included the python wrappers part.
2418 * gdcm.spec.in : added a spec file for RPM packaging.
2420 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2421 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2423 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2424 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2425 to exported to the environement (see gdcmPython/testSuite.py
2427 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2428 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2429 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2430 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2431 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2433 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2434 * gdcmPython/__init__.py doesn't crash anymore when running in
2435 in InstallMode or PreInstallMode but with an environement given
2436 value of GDCM_DICT_PATH.
2437 * src/gdcmDictSet.[cxx/h] coding style.
2439 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2441 * src/gdcm.h general comments moved to TODO, and README
2442 * src/gdcm.h should now be seen as a user commodity (including it
2443 should suffice to fully use gdcm). It is nowhere including within
2444 any of the kernel files src/*.cxx and src/*.h.
2446 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2448 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2450 * src/gdcm*.cxx only include their corresponding include file
2451 (as opposed to gdcm.h)
2452 * gdcmPython/gdcm.i changed accordingly
2453 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2454 the autogen.sh generated "make snapshot" command to work.
2455 * autogen.sh removed history related references to crea package.
2457 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * distutilsSwigCPlusPlus.py work around some swig portability
2461 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2463 was done in a last ditch attempt to get setup.py _really_
2464 operationnal. The python/gdcmPython layaout add the advantage
2465 of hidding away the python related distutils specific files
2466 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2467 Alas, the src directory was out of scope (i.e. it's relative
2468 position to setup.py was ../src) which made things impossible to
2469 handle (see previous version of python/setup.py). Crossing fingers...
2471 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2472 * python/setup.py now works on Un*x. (harder than I thougth)
2473 * python/distutilsSwigCPlusPlus.py can now have include files
2474 among the list of sources.
2476 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2477 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2478 * modifications in MSVC projects
2480 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2481 * As stated by the first lines of Test/ExceptionAndPython/README, it
2482 looks like we can move back to original usage of exception within
2483 src/gdcm* and hence remove the errno stuff that was introduced
2484 as a quick and dirty fixture of this problem (added to the TODO).
2485 * Doc/Doxyfile configuration file for Doxygen and corresponding
2486 README file for usage added.
2487 * Test/testWrite.cxx added. This new test comes from a split of
2488 test.cxx that is now reverted to its original purpous i.e.
2489 testing the proper parsing of a Dicom related file.
2490 testWrite.cxx concentrates on testing the IO part of gdcm.
2491 * Test/bug1.cxx (containing a bug on WIn32) added.
2492 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2493 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2494 whose purpose is to publish the content of the TagNames of the
2495 Dicom public dictionnary were not accessible without an
2496 instance of class gdcmHeader.
2497 - those methods are now static methods of gdcmDictSet and hence
2498 require no instances at all to be invocated.
2499 - within gdcmDictSet this change required to change some method
2500 to class methods (i.e. are now static) among which SetDictPath
2501 (renamed to BuildDictPath) and LoadDefaultPubDict.
2502 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2503 the above changes by calling the new method classes of gdcmDictSet.
2504 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2505 the above to be effective.
2506 * python/gdcmPython: in order to wrap properly the above changes
2507 for Python, swig version now needs to be > 1.3.17.
2508 * python/gdcmPython/Makefile fixed to adapt itself to new
2509 configure/make shema introduced by Johan Montagnat (thanks for the
2510 contribution). Alas this Makefile cannot be turned into a proper
2511 Makefile.am without some heavy changes in the configure.in
2512 (for python dectection).
2513 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2514 now avoids publishing the empty entries.
2516 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2517 * python/setup.py : bug fix concerning install under windows
2518 ExtraPath reused :-P
2519 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2521 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2522 * Dicts/dicomV3.dic : remove double spaces !!!
2523 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2524 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2527 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2528 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2529 method. Doxygenation.
2530 * src/gdcm.h clean up of JPR spurious comments.
2532 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2533 * python/distutilsSwigCPlusPlus.py now properly collects the
2534 shadow classes generated by "swig -c++" (gdcm.py in our case)
2535 when using "python setup.py install".
2536 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2537 reexports the working classes.
2538 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2539 by the classical C errno scheme. This is to prevent an obscure
2540 behavior of the python wrappers when importing wxPython.wx prior
2541 to gdcmPython (which ended up in an abort call). An illustration
2542 of this oddity can be found in the Test/ExceptionAndPython
2543 subdir (see the README file). This problem probably due to
2544 an combination of g++ and dynamic loading.
2545 * added Test/ExceptionAndPython (see above)
2547 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * Changed the layout of the python part to avoid bloating main
2549 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2550 i.e. the distutils arsenal. All the python related stuff is
2551 again in a python subdir, but the package itself is now in
2553 * setup.py was cleaned up:
2554 - pythonIncludePath removed
2555 - python setup.py bdist target is now functional.
2556 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2557 collision with other packages). gdcmPython/demo/*.py changed
2560 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * python subdir moved to gdcmPython (preparation of distutils packaging).
2562 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2563 distutils installer is operational.
2564 * - gdcmPython/__init__.py now properly loads the swig generated
2565 shadow classes (from gdcm.py).
2566 - gdcmPython/demo/*.py changed to import the package gdcmPython
2567 instead of gdcmPython/demo/load.py.
2568 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2570 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2571 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2572 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2573 entries within the associated public Dicom dictionary resp. the same
2574 information but sorted by the fourth field (PAT, IMG, DIR) of the
2576 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2577 are now in the "???" group.
2578 - python/gdcm.i changed accordingly,
2579 - python/demo/printGroupedPublicDict.py added, that gives an example
2580 of the above new functionalities in Python.
2582 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2583 * src/gdcm.h, gdcmHeader.cxx:
2584 - historic references to glib's g_malloc and g_free (#defined)
2585 were definitively removed.
2586 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2587 * src/gdcmElValSet.cxx:
2588 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2589 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2590 - GetElValue(string) renamed to GetElValueByName.
2591 - Added GetElementByName(string).
2592 * src/gdcmHeader.cxx: added
2593 - GetPubElValRepByNumber(guint16, guint16)
2594 - GetPubElValRepByName(string)
2595 - GetShaElValRepByNumber(guint16, guint16)
2596 - GetShaElValRepByName(string)
2597 - GetShaElValByNumber(guint16, guint16)
2598 - GetShaElValRepByName(string)
2599 - GetElValRepByNumber(guint16, guint16)
2600 - GetElValRepByName(string)
2601 - GetElValByNumber(guint16, guint16)
2602 - GetElValRepByName(string)
2603 * Doc/requirements.txt added.
2605 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2606 * Test/Makefile building now depends on the one of libgdcm.so
2607 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2608 pixel data) aware which enables finding the address (offset) of
2609 the pixel data of JPEG encoded DICOM files. This leaves only a single
2610 file in the testSuite whose pixel data address (offset) is unknown.
2611 * python/testSuite.py changed accordingly.
2613 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2614 * VC++ has some strong limitations when working with the STL, as stated
2615 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2616 "Also note that some STL containers (map, set, queue, list, deque)
2617 cannot be exported. [...]
2618 Some STL classes contain nested classes. These classes can not
2620 This is caused by a designed limitation that once a template
2621 class is instantiated, it can not be re-instantiated and
2623 Since our usage of map<> is ubiquitous in gdcm, this "designed
2624 limitation" of VC++ is a pitfall.
2625 Hence the Python wrappers of gdcm cannot be incrementally linked
2626 against the c++ dynamic library. The dirty but only workaround is
2627 to forget about incremental link of dynamic libraries and to generate
2628 the Python wrappers library with the inclusions of the underlying C++
2630 The following modifications concern this matter on Win32/VC++:
2631 - wrapping python correct with standalone wrapped dll (don't use separate
2632 dll under windows !!!!)
2633 - python21_d debug mode enabled (ask Frog how to use it :-)
2634 - NO problem with having an STL member of class for example string in C++
2635 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2636 - Python test of dcmlib in Python is ok under windows on a large set
2638 * removed glib references
2639 * typedef's inserted in gdcm.i for correct swig type management
2641 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * python/demo/*.py load.py extracted from test.py. Added explore.py
2643 that only displays required tags and testAll.py that parses all
2644 the files of the testsuite without using unittest.
2645 * python/testSuite.py other additional test on new files added.
2646 * Data/* new test files added accordingly to the testSuite.
2647 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2648 the vr in the file differs from the one of the dictionary.
2650 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2651 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2652 values, but limits itself to values which are below a user specified
2653 size (by default 1024 bytes).
2654 * python/gdcm.i : elements not loaded (because their size is above the
2655 user specified treshold) are exported with their TagKey as key of the
2656 python dictionary. This enables the testsuite to make some checks
2657 on the unloaded elements (since we have their offset and size).
2658 * python/testSuite.py
2659 - now tests for the existence and proper value of the pixel data
2660 - two new examples added.
2661 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2663 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2665 aware. See the strategy comments in gdcmHeader::FindeLength().
2666 * Test/test.cxx now accepts a filename as first argument.
2667 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2668 * python/testSuite.py changed to integrate test on above files.
2670 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2672 the vr was also RET.
2673 * python/testSuite.py more tests added.
2675 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * python/testSuite.py unittest test suite added (uses Data)
2677 * Data/* dcm and acr files for the test suite.
2678 * glib dependance removed from un*x version. We now use ISO C99
2679 7.18 Integer types (see stdint.h)
2680 - python/Makefile, src/Makefile src/gdcm.h
2681 * src/ when an explicit vr (like dicom files) suddenly poped an
2682 implicit element we use to mark the underlying DictEntry of the
2683 concerned ElValue with "Implicit". This strategy was damageable
2684 too the public or provite dictionaries, since some of their vr
2685 would be changed. Since Header::FindLength heavily relies on the
2686 detection by Header::FindVR of falsely explicit elements, I
2687 added an extra ImplicitVr member to ElValue (boolean).
2688 The rest of the changes we the necessary adaptations.
2690 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2693 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2695 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * Adaptation for porting to VC++:
2698 o forced to use std namespace (for string to be known)
2699 o all class use __declspec export style on WIN32
2700 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2701 (in stdlib.h on Win32 but in std:: for gcc)
2702 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2703 variable GDCM_DICT_PATH.
2704 * src/gdcmHeader.cxx verbose comments made discrete.
2706 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2707 * python/gdcm.i: added a typemap that converts a C++ hashing table
2708 to native Python dictionary.
2709 * python/demo/test.py:
2710 - now uses the native dictionary for exploration of gdcmHeader.
2711 - takes an optional filename argument (the file to parse).
2712 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2713 PubElVals hashing table.
2714 * Dicts/dicomV3.dic removed error prone trailing spaces.
2716 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2717 * Python wrapping process moved away from src/Makefile to
2718 newly created python/Makefile (as well as gdcm.i)
2719 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2720 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2721 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2722 from the environement variable GDCM_DICT_PATH (when existing).
2723 * src/gdcmDict::GetTag bug fix.
2725 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * Straightforward temporary fixes for swig to build the python wrappers.
2727 src/Makefile now has a python working entry [by working we mean
2728 that we can import de shadow classes without errors].
2730 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * hashtest.cxx removed (since allready in Test)
2732 * src/gdcmlib.h renamed to src/gdcm.h
2733 * src/dcm.i renamed to src/gdcm.i
2734 * src/Makefile prepared for python wrapping
2736 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2737 * src/gdcmHeader.cxx :
2738 - Parsing of header is now separated from loading of element values
2739 (see gdcmHeader::LoadElements).
2740 - general clean up of hopefully all file access (creation of
2741 ReadInt16 and ReadInt32)
2743 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2744 * src/gdcmHeader.cxx :
2745 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2747 - SetLgrElem renamed to SetLength
2748 - GetLgrElem renamed to GetLength
2749 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2750 * src/gdcmElValSet.cxx fixed both GetElValue methods
2751 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2752 due to IdoDude was cleaned out.
2754 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2755 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2756 concentrates on finding the value representation (when it exists).
2757 RecupLgr now only finds the element value length, and it avoids
2758 returning the unecessary skL (skipped length).
2759 Also, offsetCourant was simply removed (with taille_fich) since
2760 it was redundant with the File position internals (by using
2761 ftell and fseek). This also made skL (see above in RecupLgr) usage
2763 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2764 on the libido specificities which are handled through class
2766 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2769 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2770 * Truckload of changes. Parsing of header is barely functional
2771 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2773 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2774 * src/gdcmHeader.cxx many addons of low level methods
2776 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2778 and _IdDcmSWAP_LONG.
2780 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * This corresponds to all the changes decided at the meeting of
2782 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob