1 2004-07-20 Jean-Pierre Roux
2 * FIX Some brain damaged headers have Zero-Lenght fields
3 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
5 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
7 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
8 variable (instance of gdcmDebug) by a definition macro, and the instance
9 is now in static in the gdcmDebug class
10 * src/gdcmSQItem.h : (FIXME) remove an undefined method
11 * Test/PrintAllDocument.cxx : bug fix in the result of the test
13 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
14 * WARNING: ctest now depends more tightly on gdcmData. You should
15 check out gdcmData properly for things to run smoothly...
16 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
17 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
18 we need the pixels not be loaded in order to use the ValEntry
19 that displays position and size).
20 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
21 This is a C++ based equivalent of gdcmPython/testSuite.py that should
22 be deprecated. If you have any doubts about the advantages of a
23 modern scripting language (read Python) versus grass root C++ (i.e.
24 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
25 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
26 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
27 Anyhow, consider documenting the gdcmData images in
28 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
30 * Test/CMakeLists.txt:
31 - now uses TestAllEntryVerify.cxx
32 - specific comments on oldACR00001.ima (now renamed in gdcmData
33 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
34 gdcmData/TestAllEntryVerifyReference.txt
37 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
38 * src/*.[h|cxx] : typedef clean up
39 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
40 - TagKey renamed to gdcmTagKey (for external usage)
41 - VRKey renamed to gdcmVRKey (for external usage)
42 - removal of typedef duplication.
43 - Removed all unecessary inline keyword from class inline definitions.
44 - Some method|function(void) declarations replaced with method|function().
45 * src/jpeg/libijg12/jdhuff12.c:
46 - printf polluting ctest removed.
47 - TAB removal for comminting
49 - TestAllReadCompareDicom.cxx: added a test that compares all the
50 images in gdcmDataImages.h with corresponding images in
51 gdcmData/BaselineDicom/. When baseline images are not present
52 this test creates them.
53 Note: we need to validate each reference image, but before that
54 I'd like to rename them with a more explicit name...
55 - CMakeLists.txt: changed accordingly.
56 * Example/*.cxx: examples now only include gdcm.h (as opposed to
57 including each header needed).
59 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
60 * Test/*.cxx and Example/*.cxx: moved some examples away from the
61 test suite to the Example directory. Are concerned:
67 * Test/CMakeLists.txt: added some comments on reasons for black listing
68 image gdcmData/oldACR00001.ima
70 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
71 * Test/CmakeList.txt: removed the following from black list (to be coherent
72 with removal from gdcmData):
73 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
74 - gdcm-MR-PHILIPS-16.dcm
76 Added the following because after last cvs update, they cause
77 ctest -R TestReadWriteReadCompare
79 - gdcm-MR-SIEMENS-16-1.acr
81 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
82 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
83 new comments in this file) we temporarily (sigh) move to a weaker
85 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
86 we don't need to black list the following images anymore:
87 - 8BitsUncompressedColor.dcm
89 - US-PAL-8-10x-echo.dcm
90 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
91 fixes and the beautified code ;-)
92 This fixes the bug introduced in version 1.42 (when beautifying)
93 that made the parsing of 8BitsRunLengthColor.dcm unproper.
94 Note: ctest was blind to this bug (this means we need to still
95 improve the test suite). The bug could be detected by using
96 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
98 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
99 and by displaying the (garbage) produced file temp.XDCM...
101 2004-06-29 Jean-Pierre Roux
102 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
103 - replace by uggly but working old code :-(
104 A lot of things should be OK again.
105 It's really urgent to have a test suite that *tests*,
106 to prevent Frog's beautifying sessions to break all the stuff
107 (twice, withing a fortnigh ...)
109 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
110 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
111 redundancy) to added Test/TestReadWriteReadCompare.cxx
112 * Test/CmakeList.txt: because the compare test of
113 Test/TestReadWriteReadCompare.cxx fails, the following images are
114 black listed: - 8BitsUncompressedColor.dcm
116 - US-PAL-8-10x-echo.dcm
117 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
118 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
119 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
120 and ad-hoc kludge. This kludge is now removed, and on encountering
121 such an image (OB field brain damaged) we set errno. Then in
122 ::FindDocLength() we "fix" the length as being ALL what remains
123 in the file (until EOF). We then proceed, hoping for the best...
124 This fixes a SegFault in ShowDicom when trying to write such an
126 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
127 (because TestWriteRead breaks on it, after a non conformal commit?).
128 ctest now runs properly, except for MakeDicomDir (which was allways
129 broken) and the Python related stuff (still not fixed).
131 2004-06-24 Jean-Pierre Roux
132 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
133 FIX : Test/TestReadWrite now iterates on all the file names
134 (instead of infinite loop)
135 ENH : Test/TestWriteRead now iterates on all the file names
137 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
138 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
140 2004-06-24 Jean-Pierre Roux
141 FIX : - now Write drops LUT Descriptors and LUTs (if any)
142 when SamplesPerPixel =3
143 - now Write is no longer confused by
144 'BitsAllocated = 12" and 'BitsStored=12"
145 - "UN" value representation Elements are now written correctly
146 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
147 ENH : - now gdcmHeader has its own Write methods
148 (in order to split the job that has not to be done
151 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
152 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
153 loop on the same image until memory went out.
154 Note: this means we still have gobs of memory loss in PrintDocument
155 * src/gdcmDocument.cxx: fixes problem on parsing on file
156 gdcmData/16BitsJpegLosslessGrayScale.dcm.
158 2004-06-24 Jean-Pierre Roux
159 FIX : Write - All the Sequences and Sequence Item are now written
160 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
161 is added a the end, when necessary.
162 - A lot of brain-damaged images, that were read correctly are
163 now written correctly
164 - length compatible BinEntry are now loaded correctly
165 (even for odd groups)
166 Note : only Explicit Value Representation was checked.
167 (question : is implicit VR really necessary for gdcm ?)
169 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
170 * DEVELOPPER: added a proposition of coding style.
171 * src/gdcmDocEntry.h: removed every inline declaration (for test of
174 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
175 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
176 Use the gdcmDocEntry::Print() and Write() instead.
177 * src/gdcmDocument.cxx: bug fix.
179 2004-06-22 Jean-Pierre Roux
180 FIX : gdcmDocument.cxx
181 - Now we do recognize the JpegLossLess format (there was a misstyping in
182 code 'beautyfication' :-(
183 - Now we automaticaticaly load the Luts, if any
185 2004-06-22 Jean-Pierre Roux
186 In order : to write Sequences, whatever their imbrication level,
187 : to allow user to create his own Sequences
188 a lot of modif where necessary (adding, moving, or virtualising methods)
190 WARNING : save your own sources *before* cvs up !
193 ADD virtual void Write(FILE *fp, FileType filetype);
196 ADD virtual void Write(FILE *fp, FileType filetype);
197 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
200 ADD virtual void Write (FILE *fp, FileType filetype)=0;
201 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
202 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
203 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
204 ADD std::string GetEntryByName(TagName name);
205 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
207 std::string vr = "unkn",
208 std::string fourth = "unkn",
209 std::string name = "unkn");
210 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
211 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
212 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
213 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
214 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
215 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
216 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
217 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
220 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
221 ADD virtual std::string GetEntryByName (TagName tagName);
222 ADD virtual std::string GetEntryVRByName (TagName tagName);
223 REM virtual bool Write(FILE *, FileType);
224 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
225 FILE *_fp, FileType type);
226 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
227 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
228 REM virtual bool WriteEntries(FILE *_fp,FileType type);
229 REM virtual std::string GetEntryByName (std::string tagName);
230 REM virtual std::string GetEntryVRByName (std::string tagName);
231 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
232 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
233 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
235 std::string vr = "unkn",
236 std::string fourth = "unkn",
237 std::string name = "unkn");
238 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
239 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
240 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
241 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
244 ADD virtual void Write(FILE *fp, FileType filetype);
247 ADD virtual void Write(FILE *fp,FileType filetype);
250 ADD virtual void Write(FILE *fp, FileType filetype);
251 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
252 REM std::string GetEntryByNumber(guint16 group, guint16 element);
253 REM std::string GetEntryByName(TagName name);
256 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
258 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
259 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
260 The default constructor invoked by the line
261 gdcmHeader *f1 = new gdcmHeader( header );
262 was gdcmHeader::gdcmHeader(bool) instead of the expected
263 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
264 Hence the parsing wasn't executed... See also below.
265 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
266 as explicit constructor didn't do the trick to fix the above problem.
267 Could anyone explain why ?
268 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
269 properly calls gdcmValEntry::Print() (that was weed out from
270 code related to gdcmBinEntry).
272 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * In order to fix memory leaks:
274 - Test/TestWriteSimple.cxx: added cleaning of free store through
276 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
277 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
278 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
279 (through the call to ::AddDicomDirMeta()) or the destructor
280 would crash when deleting uninitialized ::metaElems].
281 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
282 - src/gdcmDocument.cxx:
283 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
285 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
286 was causing memory leaks.
287 - src/gdcmSQItem.cxx:
288 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
289 cleanly handled with polymophism: sorry but my milage is low).
290 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
291 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
292 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
293 This avoids SegFaulting.
294 - src/gdcmSQItem.h: coding style.
296 - Test/TestWriteSimple still severely sucks. The output image content
297 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
298 damaged when displayed with vtkgdcmViewer.
299 - on memory leaks: TestWriteSimple leaks really less (see entry
300 of 2004-06-18 in Changelog file for the call to valgrind).
301 - on segfaults: ctest now passes all the tests but one (no more
303 * Erroneous leading white fix:
304 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
305 white[s] (as opposed to from >> xxx, that removes it [them].
306 - src/gdcmTS.cxx: ditto.
307 - gdcmPython/testSuite.py: dirty related kludge removed.
308 * src/*: remaining references to gdcmParser removed.
309 * src/*[cxx|h]: added copy[way]left header.
312 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
313 * In order to fix writing of dicom files:
314 - Test/TestWriteSimple.cxx: a simpler example of writing.
315 - Test/CMakeLists.txt changed accordingly.
316 - src/gdcmDocument.cxx:
317 -- The destructor now recursilvely removes potential sequences.
318 -- Bug fix in ::IsJPEG2000()
319 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
320 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
322 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
323 to only declared) and build on top of
324 ::GetDocEntryByNumber(guint16, guint16).
325 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
326 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
327 for usage in destructor and treatement of promotion in
328 ::ReplaceOrCreateByNumber().
329 - src/gdcmSQItem.cxx: destructor should better handle his job.
330 Test/TestWriteSimple now runs (or at least it DOES something).
331 * We can now start hutting memory links. A good starting point is:
332 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
333 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
334 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
336 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
337 * Valgrind note: after Mathieu Malaterre teached me how to read
338 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
340 Using gcc, you can force the STL to use malloc and to free memory as
341 soon as possible by globally disabling memory caching.
342 With 3.2.2 and later, you should export the environment variable
343 GLIBCPP_FORCE_NEW before running your program.
344 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
345 simply vanish (it is still not clear to me, whether this means that
346 STL std::string leaks or if valgrind believes it leaks...).
347 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
348 running bin/gdcmTests makeDicomDir):
349 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
350 - Test/makeDicomDir.cxx now properly traps empty lists and returns
352 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
353 SegFaulting (I drowned in DicomDir related code when trying to
354 understand why the list is empty...).
355 * src/gdcmDocument.h: first BSD license header try.
356 * Doc/License.txt added.
358 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * src/gdcmDocument.[h|cxx]:
360 - Clean up of the Transfer related predicates. They are now all based
361 on new method isGivenTransferSyntax, that (should) handle properly
363 - general clean up, simplification, and coding style.
364 - Specific clean up of Parse7FE0() (umproperly named actually).
365 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
367 2004-06-14 Jean-Pierre Roux
369 - fix the display of Sequence Delimitor (SQDepthLevel pb)
370 - fix the display of SQItem ordinal number
371 - add the GetSQItemByOrdinalNumber method
372 - remove some useless never written private methods
374 2004-06-14 Jean-Pierre Roux
376 - adding a constructor taking a gdcmDocEntry as an input param
377 - ReplaceOrCreateByNumber now returns :
378 a gdcmBinEntry * if a Binary (void *) value is passed as a param
379 a gdcmValEntry * if a string value is passed as a param
381 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
382 according to the param type (no longer sets a gdcmDocEntry)
383 - GetValEntryByNumber, GetBinEntryByNumber added
384 - NewValEntryByNumber and NewBinEntryByNumber added
386 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
388 - GetSQItemNumber and SetSQItemNumber added, to provide
389 a (relative) Item identier inside a given Sequence
390 \warning : some pb remaining around this number
392 - AddEntry now takes the Item Number as a param
394 - adding a constructor taking a gdcmDocEntry as an input param
396 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
397 * Memory leak hunt with the following command:
398 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
399 --show-reachable=yes gdcmTests PrintDocument
400 It looks like many (all?) leaks are due to the STL (or a bad usage
401 of the STL. The lines producing the leaks now have a comment with
402 a "MEMORY LEAK" tag: you can retrieve them with
403 grep "MEMORY LEAK" src/*
404 Here are two typical examples which I can't help fixing:
409 char * test = "babo";
410 name = test; //// <--- valgrind detects 960 bytes lost in
411 //// call to std::string::operator=(char const*)
412 name.clear(); //// Doesn't help !
420 std::cout << "Type a bunch of characters followed by RETURN: ";
421 getline(std::cin, line); //// <--- valgrind dectects a loss
422 //// of 1320 bytes in call to
423 /// std::basic_istream<>& std::getline<>
429 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
430 * src/gdcmHeader.[cxx|h]:
431 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
432 and related, moved away to gdcmDocument.
433 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
434 the corresponding protected accessors of inherited class
435 gdcmDocument, removed ! As a consequence gdcmFile had to be
436 declared friend of class gdcmDocument (see below).
437 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
438 - Clean up of undefined or unused methods.
439 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
440 account the changes to gdcmHeader.h).
441 * src/gdcmDocument.h:
442 - gdcmFile is now a friend class (in order to take into account the
443 changes to gdcmHeader.h).
444 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
445 (see changes to gdcmHeader.h).
446 - Accessors (reading on the form GetEntry*) are now public.
447 - Clean up of undefined or unused methods.
448 * src/gdcmDocument.cxx:
449 - adaptation to changes to gdcmDocument.h
450 - ::OpenFile now writes a verbose message when file cannot be opened.
451 - some std::string properly set to VRKey
452 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
453 references to gdcmDocument.
454 * Test/TestFindTags.cxx: changed accordingly to above changes.
455 * gdcmPython/testSuite.py: adapted to renaming of acr files in
456 cvs repository gdcmData.
458 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
460 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
461 conflicts with gdcmValEntry::voidArea.
462 * src/gdcmValEntry.cxx: unmatching comment wiped out.
463 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
464 Value representation between StringRepresentable and BinaryRepresentable.
465 * src/gdcmDocument.cxx:
466 - method ParseDES: proper indentation restored and usage of
467 gdcmVR::IsVROfGdcmStringRepresentable wired in.
468 - method LoadDocEntry: the fingerprint left in the SetValue() of
469 unloaded entries (length > MaxSizeLoadEntry) had curiously been
470 removed. Reverting to previous code segment with the proper
471 dynamic_cast< gdcmValEntry* >.
472 Note: this was (partially) breaking the python test suite
473 (gdcmPython/testSuite.py) that made usage of the above
474 fingerprint to check presence of "Pixel Data".
475 * src/gdcmDocEntry.h: coding style.
476 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
477 now taken into account.
478 * gdcmPython/gdcm.i: adaptation to the new internal representation
479 of gdcm (exit gdcmParser, hello gdcmDocument).
480 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
482 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
483 anymore, but instead prints the loaded Python dictionary.
484 * .... alas, the python testSuite is still broken.
486 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
489 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
490 * src/gdcmUtil.h : export methods
492 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
493 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
495 * Initial addition of automatic python testing
496 * Initial addition of automatic image comparison
498 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
500 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
502 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
504 * Test/ShowDicom.cxx : bug fix for msvc compilation
505 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
507 2004-05-04 Jean-Pierre Roux
508 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
509 new concepts (and new classes) :
510 a 'gdcmDocument' is composed of a set of Doc Entries, that are
511 - elementary gdcmDocEntries (former gdcmHeaderEntries)
512 - Sequence Doc Entries (gdcmSeqEntries)
513 a Sequence is composed of Items.
514 Each item is a set of Doc Entries (this is recursive)
515 The non uniqueness of the 'Dicom tag' is due to this recursivity
516 (never taken into account)
517 Our unability to add a new 'entry' in the header
518 at the proper location (neither in the H-Table (map or multimap),
519 nor in the Chained List is also due to this recursivity.
520 Don't try, right now, to use/modify/compile these new sources :
522 We just commit all the stuff, 'as is', in order not to loose it.
524 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
525 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
527 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
529 file prefix (SetFilePrefix)
531 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
532 * Add a new test: ShowDicom, for now this is just the c++ version of
533 checkRead.sh, later it will be able to compare the image read against a
535 * Replace the DEBUG on the stack with a global entry in cmake interface:
536 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
538 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
539 * Add an example subdir, with a real example on how to read + write a
542 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
544 * Doc/CMakeLists.txt: the main page is now properly differentiated
545 between the developper and user version.
546 * Doc/doxygen.config.in: dropped search related obsolete flags
547 * src/gdcmParser.h, gdcmHeader.h: doxygenation
549 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
550 * DEVELOPPER: added some helpfull comments for compile/test/install
553 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
554 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
555 src directory, now generated in the build dir.
556 2. Tests as mentionned smarter
558 4. Add a new method in gdcmDict that return the PubDict by name
559 this is interesting for 3rd party lib like ITK,
560 where we could set the institution name / patient name...
562 * ENH: 1. Now the test suite is working for real
563 2. All binaries are now output in the gdcm-bin directory
564 (this was not true before)
566 2004-04-28 Jean-Pierre Roux
567 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
568 SeQuence indented printing of Dicom Header.
569 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
570 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
571 Computation of SQDepthLevel is now part of gdcmHeader constructor
572 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
573 tree-like structure of a Dicom Header.
574 * FIX Test code cleaning
576 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
577 * ENH: Adding automatic testing
578 1. Need a DartConfig.cmake to submit to public
579 2. Add a test driver gdcmTest.cxx
580 3. gdcmTestMain, an helper for the main test driver gdcmTest
581 4. Files in Test don't have a main anymore, this becomes interesting
582 when we add more and more tests, thus dsw don't have to load
584 * ENH: Adding a GDCM_DATA_ROOT for testing
585 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
586 one file instead of seven + some small cleanup
588 2004-04-22 Jean-Pierre Roux
589 * ENH Minor changes to the Print() methods.
590 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
591 Header printing. Example given with :
592 > PrintHeader fileName 2 new
593 (SQ based tree-like structure still to be done for the Header ...)
595 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
596 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
597 1. I have added some unsigned where needed
598 2. Some function parameter not used -> (void)
599 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
600 4. g++ don't like character '\' in comment
601 5. #define jpeg_create_decompress jCreaDecompress
602 this really need to be fixed
603 6. virtualize destructor of gdcmObject ... leakage
604 7. sscanf(g->first.c_str(),"%x",&gr_bid);
605 this also really need to be fixed
606 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
607 remove compression file
608 (as we only do decompression, right ?)
609 * ENH: Change malloc/calloc/free with c++ equivalent
611 2004-04-21 Jean-Pierre Roux
612 * FIX gdcmHeaderHelper::GetXSpacing
613 when a single value is found (bug ?), xpacing is now
614 defaulted to yspacing
616 2004-04-19 Jean-Pierre Roux
617 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
618 * ENH add parameters :
619 bool exception_on_error = false,
620 bool enable_sequences = false,
621 bool ignore_shadow = false
622 to the gdcmFile constructors to be full gdcmParser compliant
623 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
624 to allow reading of PAPYRUS 3.0 files
626 2004-04-06 Jean-Pierre Roux
627 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
629 2004-04-02 Jean-Pierre Roux
630 * ADD : Test/checksequence.sh, for a general recap on SQ pb
631 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
632 for Philips spurious Tag fffe|0000 while rewritting Dicom files
634 2004-03-30 Jean-Pierre Roux
635 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
636 for ACR file, written out as DICOM files (hope so...)
638 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
640 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
641 moved to base class gdcmParser and only the specialisation is kept
643 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
644 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
645 already does the job.
646 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
647 (to be consistent with gdcmParser::WriteEntries).
649 2004-03-30 Benoit Regrain
650 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
651 upate of the object's instance. It's passed to 2 in the unfavorable
652 case : one in the ExecuteInformation, one in the ExecuteData
654 2004-03-29 Jean-Pierre Roux
655 * ENH : Check on file type to be written moved
656 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
657 * FIX : gdcmObject::ResetBoundaries now stops properly
658 when end-of-list is reached
659 : gdcmVersion modified (as Benoit Regrain asked)
661 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
662 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
663 * src/gdcmUtil.cxx: added forgotten iostream include.
664 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
665 equivalent to ExplicitVR in existing code).
667 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
669 now contains all the gdcmGlobal related code.
670 * minor coding style and doxygenation changes.
672 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
674 now contains all the Debug related code.
675 * minor clean-up of includes in src/*.cxx
676 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
677 CreateCleanString) removed.
678 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
679 * Doc/DoxyMainPageUser.txt added.
680 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
681 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
684 2004-03-24 Jean-Pierre Roux
685 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
687 2004-03-23 Jean-Pierre Roux
688 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
689 big endian made volumes
690 * ENH Now gdcmParser constructor and destructor are protected to forbid
691 end user to instanciate class gdcmParser
692 (only gdcmHeader and gdcmDicomDir are meaningfull)
694 2004-03-22 Benoit Regrain
695 * FIX : src/gdcmDicomDir.cxx : make windows compilable
696 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
697 gdcmSerie to gdcmDicomDirSerie
699 2004-03-19 Jean-Pierre Roux
700 * ENH Now the tree-like structure describing a DICOMDIR comming from
701 an already existing DICOMDIR file is consistent with
702 the home-made tree-like structure build ex-nihilo
703 or build from the files held (recursively) in a Directory
704 functions gdcmDicomDir::CheckBoundaries()
705 gdcmObject::SetBoundaries() added
707 2004-03-17 Jean-Pierre Roux
708 * REM (Eric Boix bug) : removal of meaningless
709 gdcmDicomDirImage::NewImage function.
710 * FIX now file names and directory name are written properly in the
712 * FIX now gdcmDicomDir constructor may be call without any trick
715 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
716 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
717 of gdcmDicomDirImage::NewImage as empty function.
719 2004-02-28 Jean-Pierre Roux
720 * ENH add gdcmDicomDir:NewPatient
721 add gdcmDicomDirPatient:NewStudy
722 add gdcmDicomDirStudy:NewSerie
723 add gdcmDicomDirSerie:NewImage
724 to allow making gdcDicomDir object.
725 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
726 (as opposite to the gdcmHeader chained list)
728 2004-02-11 Benoit Regrain
729 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
730 when using from python
732 2004-02-10 Benoit Regrain
733 * FIX : bug fix in the gdcmDirList for the recursivity in directories
734 * FIX : in gdcmDicomDir when the directory is empty
735 * ENH : add callback and methods to get the progression of dicomDir
738 2004-02-06 Jean-Pierre Roux
739 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
740 - GDCM_META added to gdcmDicomDirType
741 - class gdcmMeta created
742 * ENH : - A brief summary is now displayed at the beginning of
743 'testDicomDir' to help disaster magnitude estimation
744 * REM : Now useless Test/explDICOMDIR.cxx
746 2004-02-05 Benoit Regrain
747 * ENH : add methods in gdcmObject to get the hash table or the list of
749 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
750 * FIX : wrapping python for TagHeaderEntryHT
752 2004-02-04 Benoit Regrain
753 * FIX : even length for some strings when writting the dicom dir
754 * FIX : sort the images in the dicom dir
755 * FIX : Bug fix for python use of dicom dir
756 * ADD : a python demo
758 2004-02-04 Jean-Pierre Roux
759 * FIX : Final solution (?) for icone embedded images
760 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
761 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
762 add groups 6002, 6004, 6006, to allow 'clean' parsing of
763 gdcmData/gdcm-MR-SIEMENS-16.acr1
764 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
765 to make full checking easier
767 2004-02-04 Benoit Regrain
768 * FIX : WriteEntries : coding style & logic in parameters
769 * FIX : Set the elements to create the DicomDir in a dictionary file
771 2004-02-03 Benoit Regrain
772 * gdcmDirList : to parse a hard drive directory in recursive (or not)
773 * gdcmDicomDir : add the load of directory
774 * Bug fix and print add-on
776 2004-02-03 Jean-Pierre Roux
777 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
778 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
779 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
780 * FIX gdcmParser.cxx : 'group length' elements are now considered
781 as integers, even for shadow groups, when file is Implicit VR
783 2004-02-02 Jean-Pierre Roux
784 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
786 of the last synonym :-(
787 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
789 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
790 * FIX taking into account the possible 7fe0,0010 multiplicity
791 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
792 to allow removal of references to 7fe0,0010, to deal with
793 ACR-NEMA images, when 0028,0200 is meaningfull
795 2004-01-31 Jean-Pierre Roux
796 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
797 no longer writes 'Un' on disk
798 * FIX SQ elements with actual length are now dealt with corectly
799 * FIX gdcmFile::WriteBase make the difference, for color images, between
800 the length (for Palette expanded images)
801 and Raw Length (non expanded image + Palette)
802 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
803 (that broke Write). Replaced by UL.
804 Aware user will reload the field if he
805 thinks it's necesssary
807 2004-01-30 Jean-Pierre Roux
808 * gdcmParser::CheckSwap() now defaults the filetype to ACR
809 when 'dirty Acr' is found, to be compliant with the new
810 IsReadable() methods.
812 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
813 (no DOUBLE images in kosher DICOM,
814 but so usefull for people that miss them ;-)
816 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
817 DICOMDIR related utilities (not checked as Windoze compliant)
819 2004-01-28 Jean-Pierre Roux
820 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
822 2004-01-27 Jean-Pierre Roux
823 * gdcmParser constructor has a new boolean param,'ignore_shadow',
824 to allow skipping the shadow elements, to save memory space.
825 The TRUE value for this param has to be used
826 with a FALSE value for the 'enable_sequence' param.
827 ('public elements' may be embedded in 'shadow Sequences')
828 * gdcmHeader methods now deal with 'embedded icones images' in the header
829 (even when an 'icone image sequence' is announced by the
830 element (0x0088,0x0200), but there is NO icone at all ...
832 * gdcmHeader sometimes Image Location value doesn't follow
833 the supposed processor endianity (see gdcmData/cr172241.dcm).
836 * gdcmHeader add the method
837 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
838 to get *all* the Header Entries with the same tag.
839 GetHeaderEntrySameName is probabely *useless*
840 (no meaning : Name is *not* an identifier within the Dictionnary)
842 2004-01-26 Benoit Regrain
843 * Bug fix in the print of hexadecimal representations. Remove long fields
844 in the print and add a third level of print to print them
846 2004-01-23 Benoit Regrain
847 * Bug fix on field having a VR = 'UI'. Assume that is a string field
848 * Bug fix on test suite after remove the strip made on not string fields
849 * Split the IsReadable method between gdcmParser which test that the file
850 is dicom and gdcmHeader which test that it's an image file
852 2004-01-22 Benoit Regrain
853 * DicomDir : clean code, add methods, set variables in protected or private
854 * gdcmUtil : bug fix for the clean string method
856 2004-01-19 Benoit Regrain
857 * Add the use of shadow dictionaries
858 * bug fix and coding style
860 2004-01-19 Benoit Regrain
861 * src/gdcmFile.cxx : bug fix concerning the close of file
862 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
863 * Add the update of header entries using the shadow library
865 2004-01-19 Benoit Regrain
866 * removal of file gdcmHeader2.cxx
867 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
868 inheriting from gdcmParser. This split is to prepare the integration
870 * bug fix under python
872 2004-01-16 Jean-Pierre Roux
873 * REM removal of class gdcmHeaderEntrySet
874 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
875 * ADD add file gdcmHeader2.cxx
876 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
878 2004-01-15 Benoit Regrain
879 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
880 entries created while parsing the header. Thus, they will be destroyed
881 when the gdcmDictSet will be destroyed
882 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
885 2004-01-15 Benoit Regrain
886 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
887 made a fatal error because of the memory release at the end of program.
888 The problem was in vtkGdcmReader::ExecuteData where we were allocate
889 some memory and vtk seems to have some problems with that.
890 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
892 2004-01-14 Benoit Regrain
893 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
894 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
895 * src/*.[h|cxx] : make changes due to class name changes
896 * gdcmPython/demo/*.py : bug fix due to method names
898 2004-01-13 Benoit Regrain
899 * src/*.[h|cxx] : coding style
900 * vtk/*.[h|cxx] : coding style
902 2004-01-13 Benoit Regrain
903 * gdcmPython/testSuite.py : test the readable flag of file for tests
904 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
905 It's lied to the stl compilation by MSVC (windows, always windows...)
906 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
908 2004-01-12 Benoit Regrain
909 * src/*.h : add comments
910 * src/gdcmDictSet.h : set the method BuildDictPath in public
911 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
912 directly setted in the source code
913 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
916 2004-01-09 Benoit Regrain
917 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
918 * setup.py : use a reference to gdcmVERSION
920 2004-01-07 Benoit Regrain
921 * Modification to compile with the distutils.
924 2003-12-10 Benoit Regrain
925 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
926 can use a gdcmHeaderHelper to load datas
927 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
928 made in the source code
930 2003-12-10 Benoit Regrain
931 * Update Windows projects and .cvsignore files
933 2003-11-12 Jean-Pierre Roux
934 * ENH gdcmHeader constructor has one more parameter (default value : false)
935 that allows the user to 'go inside' the SeQuences only
937 gdcmElValSet:Print takes it into account
939 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
940 * ENH: Update gdcmPython/CMakeLists
941 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
942 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
944 2003-11-10 Jean-Pierre Roux
945 * FIX : gdcmHeader::LoadElements is now based
946 on the ListTag listElem member,
947 not longer on the TagElValueHT tagHt member
948 * ENH : PrintPubElVal shows (temporarily) both results,
949 with the tagHt member and the listElem member.
950 (it's easier to 'see' the problems when using Printheader)
952 * FIX : old private member LgrElem is now splitted into
953 ReadLength : Length actually found on disk (updated only
954 if bug fixing is necessary), for internal
956 UsableLength : Updated by FixFoundLength, to fix a bug
957 or to allow Parser going on.
958 Will allow to re-write a kosher header when a SeQuence
959 with a length (not 0000) is found
960 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
961 because gdcmElValSet::Add does not update ListElem
964 2003-11-07 Jean-Pierre Roux
965 * FIX misstyping in Transfert Syntax name table
966 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
967 when they have an actual length (not 0000 nor FFFFF)
968 (Nobody should care of it, but DICOMDIR explorers)
970 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
971 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
973 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
974 * ENH: vtkGdcmReader now supports LUT !
975 (vtkgdcmViewer for now is not able to use them though)
977 2003-11-05 Jean-Pierre Roux
978 * in testSuite.py : new files names for checking the package
979 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
980 that returns the pixel area size to the *aware* (vtk) user
981 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
983 2003-11-05 Benoit Regrain
984 * in testSuite.py : Modify the rules for checking the paths
985 : Explicit error messages
986 * in __init__.py : Related modif
988 2003-11-03 Jean-Pierre Roux
989 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
990 to be used by aware (vtk) users that want to manage
991 LUT (and no to turn the PALETTE image into an RGB pixels one)
992 * GetPixelType now returns 8U for 24 Bits images
993 (vtkGdcmReader compliant)
995 2003-10-31 Jean-Pierre Roux
996 * Removal of *all* gdcmData images and add them again
997 in order to loose the 'history' of un-anonymised images
999 2003-10-31 Jean-Pierre Roux
1000 * RMV : removal of useless jBitsInJsample.h
1001 for both 8 and 12 Bits JPEG Lossy Libraries
1003 2003-10-31 Jean-Pierre Roux
1004 * ENH : Add the functions gdcmFile::GetImageDataRaw
1005 gdcmFile::GetImageDataIntoVectorRaw
1006 that act as GetImageData and GetImageDataIntoVector
1007 except the making of an RGB Plane from Gray Plane + LUT
1008 Intended to aware (vtk) users who know how to manage
1011 GetLUTRGBA return a R,G,B,A LUT if any
1012 lgrTotaleRaw gives the 'Raw' length
1013 GetImageDataRaw returns the gray Plane
1014 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1015 (They stay Grey, just like with other Dicom viewers :-(
1017 2003-10-30 Jean-Pierre Roux
1018 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1020 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1021 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1022 being coherents dicom files.
1024 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1025 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1027 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1028 * ENH: Two steps is necessary to please VC++ compiler...
1029 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1030 * ENH: Add include dir to medcon lib
1031 * FIX: only one function is being exported for now !
1032 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1034 2003-10-29 Jean-Pierre Roux
1035 * adding gdcmHeader::GetLUTRGBA
1036 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1037 --> Mathieu, the modif u're waiting for is not yet committed
1038 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1040 2003-10-27 Jean-Pierre Roux
1041 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1042 00191113.dcm DermaColorLossLess.dcm
1043 MxTwinLossLess.dcm RadBWLossLess.dcm
1044 * ENH: For version prior to vtkImageViewer2 -r 1.19
1045 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1047 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1048 * Removal of ido stuff in CMakeLists.txt
1050 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1051 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1052 * FIX: remove a call to ->Modified ... see comments
1053 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1055 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1056 * FIX: Problem with path for libvtkgdcmPython
1057 * ENH: Try adding a search script for python site-package
1058 * RMV: Remove some file from medcon lib that are not necessary
1059 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1060 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1061 * FIX: More pragma disable fro VC++,
1062 I don't think I break something as it is also disable in VTK/ITK.
1063 But it fasten debug compilation time.
1065 2003-10-23 Jean-Pierre Roux
1066 * gdcm now deals with 16 Bits Run Length Encoded images
1067 (they are compressed as 2 planes images,
1068 one for the high Bytes, the other for low Bytes)
1070 2003-10-22 Jean-Pierre Roux
1071 * Now CheckRead takes into account :
1072 - the bugged 'Leonardo' Siemens images
1073 - the XA images, sent thru the burning VPRO station
1074 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1077 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1078 * FIX: When copying a Makefile.am to CMakeLists.txt
1079 one should remove the '\'
1081 2003-10-22 Jean-Pierre Roux
1082 * in gdcmData adding a bugged 'Leonardo' Siemens image
1083 (wrong lengths in header)
1084 OK with gdcm, KO with the other viewers :-)
1085 * add a GE dlx XA image, thru the VEPRO burning station
1088 2003-10-21 Jean-Pierre Roux
1089 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1090 for a brutal checking of vtkgdcmViewer compliance
1092 2003-10-21 Jean-Pierre Roux
1093 * add the files for 'xmedcon' Jpeg Lossless library
1094 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1096 2003-10-21 Jean-Pierre Roux
1097 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1099 2003-10-21 Jean-Pierre Roux
1100 * garbage Siemens 'Leonardo' images dealt with
1101 (the patch is easy to remove)
1102 * cosmetic changes to avoid warnings
1104 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1105 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1106 no need to press 'r' now.
1108 2003-10-20 Jean-Pierre Roux
1109 * upgrade of checkRead.sh checkWrite.sh according
1110 to new Jpeg Lossless decompressor
1111 * add US.3405.1.dcm, a genuine RGB medical file ...
1112 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1113 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1115 2003-10-15 Jean-Pierre Roux
1116 * general anonymisation in gdcmData
1117 * adding the 'color files' from
1118 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1119 * adding some well knowed bugged-header images
1120 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1121 waiting for their inclusion in Python testsuite
1123 2003-10-15 Jean-Pierre Roux
1124 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1125 no longer seg faults when file is not found
1127 2003-10-14 Jean-Pierre Roux
1128 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1131 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1132 * TODO: *.in file to genereate a UseGDCM later
1134 2003-10-14 Jean-Pierre Roux
1135 * Some supposed-to-be Dicom Images have no preamble.
1136 OpenFile takes it into account
1137 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1138 * Missing elements added in dicomV3.dic
1139 (just to be affraid : have a look at
1140 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1141 and do it again next year ;->
1143 2003-10-13 Jean-Pierre Roux
1144 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1145 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1146 But there are NOT. It's fixed !
1148 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1149 * FIX: "jpeglib.h" was not found on VC++
1150 * FIX: vtkgdcm was not being installed
1152 2003-10-10 Jean-Pierre Roux
1153 * ENH : OpenFile closes the file if it *really* doesn't look like
1154 an ACR-NEMA / DICOM one.
1155 * FIX : testWrite no longer writes an empty file if the source file
1156 is not gdcm Readable
1157 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1160 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1161 * FIX: CMake generate now documentation
1162 * ENH: out of source doc build !
1163 * ENH: Generate both user and dev documentation
1164 * ENH: Should work on windows too
1165 * ENH: Only one doxygen config.in file is needed
1166 * FIX: make install should be ok now on ùnix plateform
1167 * FIX: PATH to dictionary was wrong (missing /)
1168 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1170 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1171 * vtkGdcmReader is now able to read rgb dicom file.
1172 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1173 * added a gdcmViewer to vtk test, use mouse to control
1174 window level & window width
1176 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1177 * CMake-ification of gdcm, we have now two build system
1178 * FIX: on cygwin Wsock32 doesn't exist
1179 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1181 2003-10-06 Emanuel Ollart
1182 * FIX : compilation process wad broken.
1183 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1185 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1186 * change gdcmViewer -> vtkgdcmViewer
1187 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1189 2003-10-06 Jean-Pierre Roux
1190 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1191 ( e.g : well known GE images with a wrong elem length,
1192 : Philips MRI Images with a wrong Huffman table)
1193 * still to be done : allow the reading of bugged LEONARDO Siemens images
1195 2003-10-03 Jean-Pierre Roux
1196 * Odd length strings are padded with '\0' (not with spaces,
1197 to remain compliant with already defined strings,
1198 like Transfert Syntax UID and others)
1200 2003-10-03 Jean-Pierre Roux
1201 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1202 to allow displaying RGB images (not only by affim ;-)
1204 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1205 * vtkGdcmReader is now able to read rgb dicom file.
1206 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1208 2003-10-03 Jean-Pierre Roux
1209 * A few nasty patches to allow the reading of a lot of nasty images
1210 ( e.g : well known GE images with a wrong elem length,
1211 : Philips MRI Images with a wrong Huffman table)
1212 * still to be done : allow the reading of bugged LEONARDO Siemens images
1214 2003-10-03 Jean-Pierre Roux
1215 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1217 2003-10-03 Jean-Pierre Roux
1218 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1219 to allow displaying RGB images (not only by affim ;-)
1221 2003-10-03 Jean-Pierre Roux
1222 * gdcmFile::GetImageDataIntoVector now
1223 - deals with MultiFrames MultiFragments Run Length Encoded files
1224 - deals with YcBcR (YBR_FULL) files
1225 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1226 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1228 (no sample found :-(
1230 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1231 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1232 Two reasons: - clear things
1233 - third parties acces gdcm through header files, so won't
1234 suffer anymore VC++ complains
1236 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1237 * add argv[1] in testvtkGdcmReader.cxx
1240 2003-09-24 Jean-Pierre Roux
1241 * The lines are now eigthy characters long.for
1242 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1244 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1245 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1246 char* to std::string. Thus, the use of strdup becomes useless. (see
1247 previous commis of Malaterre)
1248 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1249 before the last Malaterre's commit.
1251 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1252 * This commit should fix the Debug building under VC++, the problem
1253 was mainly a mixture of debug and release lib being loaded at startup.
1254 * I also remove a depency to a specific C function: strdup. Because I had
1255 to force the link to msvcrtd (whereas strdup is in libc).
1257 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1258 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1259 located in the gdcmCommon.h file. All use of reference of tha has been
1260 changed to now use the variable GDCM_UNFOUND.
1262 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1264 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1265 Dicom dictionary. The test suite can now be run again. Note:
1266 I'm note very happy with the " (RET)" changes. I believe this
1267 RETAINED comment should be dropped when parsing the dictionary.
1268 - PACKAGER corrected
1270 - AUTHORS updated and now in alphabetical order
1271 * Makefile.am now exports gdcm.dsw for Windoze users.
1273 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1274 * cygwin complains about missing std:: in subdir Test/
1276 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1277 * remove some methods that are now in gdcmHeaderHelper
1279 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1280 * vtkGdcmReader set spacing and origin correctly
1282 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1283 * Fix a few delete/delete[] mismatch
1285 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1286 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1287 interpretation to data given by gdcmHeader. For instance there are
1288 heuristics to get informations (look at different places).
1289 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1290 sorting DICOM images based on different strategies.
1291 * modified Makefiles accordingly.
1293 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1294 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1295 when building in debug mode
1296 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1297 src/win32/gdcmdll.dsp
1298 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1300 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1304 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1305 * src/win32/libgdcmjpeg12.dsp was not dos format
1306 * src/win32/libgdcmjpeg12.dsp :
1307 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1308 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1310 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1311 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1313 * src/gdcmFile.cxx : bug fix in affectation type
1314 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1315 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1316 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1317 symbols... future problem ?
1319 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1320 * src/win32/libgdcmijpeg12.dsp was missing
1321 * modified gdcm.dsw accordingly
1323 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1324 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1326 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1327 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1328 commit of JPR (before his hollidays to facilitate our work).
1329 * setup.py : bug fix in code. Modifications made while the last commit
1330 of JPR. The code hasn't been tested before the commit... it's so
1331 useless to make that (for best programmer that is JPR) !!!
1333 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1334 * tagged the current version as Version0_3 (i.e. version 0.3)
1336 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1337 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1338 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1339 * *.dsp : modifications to use new libgdcmijpeg8 library
1340 * setup.py : bug fix on VTKPATH variable
1341 * PACKAGER : adding all concerning windows
1343 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1346 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1347 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1348 test suite reported error.
1349 * PACKAGER file added (describes what a packager must do when
1350 packaging a new release).
1351 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1352 * configure.in: upgraded version number to 0.3.0
1353 * fixing build of rpm (through rpm -ta):
1354 - Doc/Makefile.am exports proper doxygen files
1355 - src/jpeg/libijg8/Makefile.am exports the include files.
1357 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1358 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1359 * src/gdcmHeader.h : formatting code
1361 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1362 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1363 We were obtaining error message from vtk. Now, creation of file list
1364 is made in an internal list to prevent this problem.
1365 Bug fix when output is empty.
1366 Bug fix in update of progress value. Previous commit for this was a bad
1368 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1370 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1371 * src/gdcmHeader.h : added method to get the file name
1372 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1373 files. Added method to remove all files on the input
1374 Added FIXME comment concerning the bad parsing of header made by
1375 ExecuteInformation method (in ExecuteData method)
1377 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1378 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1379 when using make instal.
1380 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1381 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1383 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1384 * setup.py : adding include dir of jpeg lib to compile all sources
1385 * */Win32/*.dsp : JPR fix for windows compilation
1387 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1388 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1390 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1391 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1393 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1394 * setup.py is again effective on un*x (takes into account the
1395 addon of the jpeg library)
1396 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1397 * Doc/Doxy* updated (includes above enhancements)
1398 * INSTALL now points to web documentation
1400 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * src/gdcmHeader.h doesn't make unnecessary reference to
1403 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1405 * src/gdcm*.[cxx|h] :
1406 - to allow compilation with gcc 3.x
1407 -- clean up of STL usage (added explicit usage of std::)
1408 -- small fixes on exceptions.
1409 Note: linking not tested !
1410 - clean of doxygen comments to avoid warnings at documentation
1412 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1413 dependent convertion).
1415 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1416 * Clean up of previous JPR garbage commit (not even commented in the
1418 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1419 - moved all jpeg related files from src to src/jpeg/libijg8, with
1420 addition/modification of Makefile.am and configure.in.
1421 - the testSuite is still brain damage (not guilty).
1423 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1424 * WrapVTK.py : modifications to get correctly vtk source files to
1426 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1427 (FileName -> Filename)
1429 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1430 * vtk/vtkGdcmReader.[cxx/h]:
1431 - UpdateProgress method should now be effective
1432 - removed the limitation on having only images loaded (as opposed
1434 - when building a stack of images/volume, a lesser number of
1435 gdcmHeader and gdcmFile instances should be used (hopefully
1436 accelerating things).
1437 - when building a stack of images/volumes, files which are not
1438 loadable (wrong path-filename, wrong permissions on existing file,
1439 or file not parsable by gdcm) are replaced with a black image
1440 in the stack (for the caller to notice the problem).
1442 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1445 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1446 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1447 between standard library (std) and vtk library (problems are found
1448 under Windows... thanks Windows !)
1450 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1451 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1453 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1455 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1456 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1458 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1459 * When compiling with distutils (see setup.py) the C++ compiler is
1460 called with different flags than the default ones (with automake).
1461 In order to fix all those warning, I compiled gdcm with the command
1462 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1463 and went for warning fixes:
1464 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1465 up from unused variables.
1466 - vtk/vtkGdcmReader.cxx: potential bug fix.
1467 * src/gdcmHeader.h: Doxygen warning cleanup
1469 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1470 * gdcmPython/gdcm.i:
1471 - typemaps correction to take into account the systematic replacement
1472 of "using namespace std" with std:: prefix e.g. std::list,
1473 std::string... (cf changes of 2003-05-21).
1474 - gdcmGlob global variable of type gdcmGlobal (defined in
1475 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1476 exported to Python a as cvar.
1477 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1478 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1479 gdcmDictSet.GetPubDictTagNames() and
1480 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1481 C++ static methods).
1482 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1483 with the above changes.
1485 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1486 * setup.py, manifest.in : bug fix under linux
1488 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1489 * Modification of setup.py to compile vtk part too. Then, we have 2
1490 wrappers which must work with same distutils. For that, we have a
1491 generic distutils in distusiltsWrapping.py ; with :
1492 - build_extWrap class to wrap generically all extensions,
1493 - ExtensionWrap base class for all wrapping extension that contains
1495 - Wrapper interface which wrap sources
1496 + In WrapSwig.py we have extension and wrapper for Swig
1497 + In WrapVTK.py we have extension and wrapper for VTK
1498 * MANIFEST.in : modifications to consider vtk directory and new python
1499 files for compilation
1501 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1502 * Added python wrappers of vtkGdcmReader vtk class (see the
1503 source in vtk/vtkGdcmReader.cxx) :
1504 - vtk/Makefile.am now builds a library
1505 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1506 python library (as opposed to _gdcm.so wich are the python
1507 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1508 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1510 - configure.in has an additional flag --enable-vtk that needs
1511 to be set to enable compilation of vtk related code, that is:
1512 + vtk/vtkGdcmReader.so and
1513 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1514 + gdcmPython/vtkgdcmPython.so (see above)
1515 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1516 be read when compressed or when HighBit + 1 != BitsStored),
1517 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1518 the usage of the python wrapper of vtkGdcmReader vtk class.
1519 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1520 * src/*.[h] all occurences of stl classes are now prefixed with
1521 std::, and all occurences of "using namespace std;" where removed.
1522 This is to avoid pollution of global namespace in included files.
1523 Apparently vtk does not avoid this pitfall: when using both
1524 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1525 collision of various stl members (principally cout...).
1526 * gdcmPython/testSuite.py now cleanly removes temprory generated
1528 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1529 comply with above changes)
1531 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1532 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1533 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1534 vtk data structure (an image Flip was required).
1535 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1536 * cosmetic changes in documentation.
1538 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1539 * src/gdcmHeader.cxx: the constructor no longer exits when an
1540 unexisting file is given as argument.
1541 * The subdirectory Data (containing all the images used for the
1542 test suite) is not part of this repository anymore. A new module
1543 containing those images is now available at
1544 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1545 with the name gdcmData.
1546 All the python scripts (including the package initialisation file
1547 gdcmPython/__init__.py) were adapated to take this change into
1548 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1550 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1551 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1552 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1553 demo of the usage of this class.
1554 Compilation of this vtk part is only done when using the --enable-vtk
1555 at configure (or autogen.sh) stage.
1557 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1558 * More memory link related corrections and documentation fixes.
1560 - maximum info is obtained with a command of the form:
1561 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1562 --show-reachable=yes PrintHeader
1563 - the remaining reachable blocks seem to come from the STL
1564 allocation scheme through the usage of map and list. It looks
1565 like this memory cannot be freed but it is not a memory leak
1566 (in fact further invocation to the STL would recollect the
1567 unused memory allthough it cannot explicitely be freed).
1568 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1569 of displaying an image parsed with gdcm and displayed with VTK.
1570 Note: some images don't seem to work e.g.
1571 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1572 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1573 Allthough this weakens the semantics, it is a ditch attempt to
1574 make gdcm more thread friendly.
1576 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1577 * Memory link hunt (by using valgrind through the command
1578 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1579 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1580 gdcmHeader::_dicom_vr.
1581 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1582 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1584 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1586 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1587 * src/Makefile.am now exports all the necessary include files at
1591 * UpdateGroupLength replaced by new one
1594 * UpdateGroupLength re-written using H-Table
1595 (named UpdateGroupLengthNew untill checks are over)
1597 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1598 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1599 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1601 - gdcmHeader::GetPubElValSet removed.
1602 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1603 UpdateGroupLength, WriteElements, Write.
1604 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1605 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1606 carried the same semantics.
1607 - src/gdcmHeaderIdo.cxx changed accordingly.
1608 - gdcmFile::WriteBase now regroups all the codes from previous
1609 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1610 - enum FileType moved to gdcmCommon.h
1611 * src/gdcmHeader.cxx AddDefault trashed
1612 * gdcmGetXSize added
1613 * getimageDataSize now calls gdcmGetXSize
1614 * Test/*.cxx changed to agree with above changes
1616 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1618 (to avoid double call by end user).
1619 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1620 by end user, since gdcmHeader::gdcmHeader now handles it.
1622 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1623 * gdcm/Doc many doxygen changes:
1624 - Doxyfile now has two different versions, DoxyfileUsers that generates
1625 the html.users end users oriented documentation and
1626 DoxyfileDeveloppers that generates the html.developper developper
1627 oriented documentation.
1628 - README changed accordingly
1629 - requirement.txt removed (old design info moved to TODO).
1630 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1631 DoxyMainPage.txt, DoxyPython.txt provide more information.
1632 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1633 be updated by simply regenerating the docs with doxygen and copying
1634 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1635 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1636 all the tests in the form "if (<map>.count() >1)" were removed.
1637 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1638 ill-formed documentation sections.
1639 * src/gdcmHeader.cxx: ditto
1641 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1642 * setup.py fixed for un*x (needed macro for stdint.h)
1643 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1644 un*ces with sh-utils test utility.
1645 * gdcmPython/demo/test.py renamed to PrintHeader.py
1646 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1647 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1648 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1649 * src/gdcm*.cxx JPR's bad inclusion fixed.
1651 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1652 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1653 * gdcmPython/demo/test.py changed accordingly.
1655 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1656 * gdcmPython/Makefile.am fixed linking against libstdc++
1657 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1658 * Swig subdir (historical tests of swig version 1.3.17++) removed
1659 * Test/testChangeEntete.cxx some lines commented out in order to make
1661 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1662 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1664 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1665 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1666 hence the user doesn't need this explicit call.
1667 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1668 i.e. LoadElements() call removed.
1669 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1670 - src/Makefile.am declares the proper flag for g++.
1671 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1672 for adding user defined new tags.
1673 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1674 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1675 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1677 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1678 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1679 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1680 src/Makefile.am : the project should properly compile and install
1681 with the autotools, included the python wrappers part.
1682 * gdcm.spec.in : added a spec file for RPM packaging.
1684 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1685 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1687 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1688 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1689 to exported to the environement (see gdcmPython/testSuite.py
1691 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1692 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1693 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1694 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1695 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1697 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1698 * gdcmPython/__init__.py doesn't crash anymore when running in
1699 in InstallMode or PreInstallMode but with an environement given
1700 value of GDCM_DICT_PATH.
1701 * src/gdcmDictSet.[cxx/h] coding style.
1703 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1704 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1705 * src/gdcm.h general comments moved to TODO, and README
1706 * src/gdcm.h should now be seen as a user commodity (including it
1707 should suffice to fully use gdcm). It is nowhere including within
1708 any of the kernel files src/*.cxx and src/*.h.
1710 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1711 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1712 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1714 * src/gdcm*.cxx only include their corresponding include file
1715 (as opposed to gdcm.h)
1716 * gdcmPython/gdcm.i changed accordingly
1717 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1718 the autogen.sh generated "make snapshot" command to work.
1719 * autogen.sh removed history related references to crea package.
1721 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * distutilsSwigCPlusPlus.py work around some swig portability
1725 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1727 was done in a last ditch attempt to get setup.py _really_
1728 operationnal. The python/gdcmPython layaout add the advantage
1729 of hidding away the python related distutils specific files
1730 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1731 Alas, the src directory was out of scope (i.e. it's relative
1732 position to setup.py was ../src) which made things impossible to
1733 handle (see previous version of python/setup.py). Crossing fingers...
1735 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * python/setup.py now works on Un*x. (harder than I thougth)
1737 * python/distutilsSwigCPlusPlus.py can now have include files
1738 among the list of sources.
1740 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1741 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1742 * modifications in MSVC projects
1744 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1745 * As stated by the first lines of Test/ExceptionAndPython/README, it
1746 looks like we can move back to original usage of exception within
1747 src/gdcm* and hence remove the errno stuff that was introduced
1748 as a quick and dirty fixture of this problem (added to the TODO).
1749 * Doc/Doxyfile configuration file for Doxygen and corresponding
1750 README file for usage added.
1751 * Test/testWrite.cxx added. This new test comes from a split of
1752 test.cxx that is now reverted to its original purpous i.e.
1753 testing the proper parsing of a Dicom related file.
1754 testWrite.cxx concentrates on testing the IO part of gdcm.
1755 * Test/bug1.cxx (containing a bug on WIn32) added.
1756 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1757 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1758 whose purpose is to publish the content of the TagNames of the
1759 Dicom public dictionnary were not accessible without an
1760 instance of class gdcmHeader.
1761 - those methods are now static methods of gdcmDictSet and hence
1762 require no instances at all to be invocated.
1763 - within gdcmDictSet this change required to change some method
1764 to class methods (i.e. are now static) among which SetDictPath
1765 (renamed to BuildDictPath) and LoadDefaultPubDict.
1766 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1767 the above changes by calling the new method classes of gdcmDictSet.
1768 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1769 the above to be effective.
1770 * python/gdcmPython: in order to wrap properly the above changes
1771 for Python, swig version now needs to be > 1.3.17.
1772 * python/gdcmPython/Makefile fixed to adapt itself to new
1773 configure/make shema introduced by Johan Montagnat (thanks for the
1774 contribution). Alas this Makefile cannot be turned into a proper
1775 Makefile.am without some heavy changes in the configure.in
1776 (for python dectection).
1777 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1778 now avoids publishing the empty entries.
1780 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1781 * python/setup.py : bug fix concerning install under windows
1782 ExtraPath reused :-P
1783 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1785 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1786 * Dicts/dicomV3.dic : remove double spaces !!!
1787 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1788 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1791 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1792 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1793 method. Doxygenation.
1794 * src/gdcm.h clean up of JPR spurious comments.
1796 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1797 * python/distutilsSwigCPlusPlus.py now properly collects the
1798 shadow classes generated by "swig -c++" (gdcm.py in our case)
1799 when using "python setup.py install".
1800 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1801 reexports the working classes.
1802 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1803 by the classical C errno scheme. This is to prevent an obscure
1804 behavior of the python wrappers when importing wxPython.wx prior
1805 to gdcmPython (which ended up in an abort call). An illustration
1806 of this oddity can be found in the Test/ExceptionAndPython
1807 subdir (see the README file). This problem probably due to
1808 an combination of g++ and dynamic loading.
1809 * added Test/ExceptionAndPython (see above)
1811 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1812 * Changed the layout of the python part to avoid bloating main
1813 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1814 i.e. the distutils arsenal. All the python related stuff is
1815 again in a python subdir, but the package itself is now in
1817 * setup.py was cleaned up:
1818 - pythonIncludePath removed
1819 - python setup.py bdist target is now functional.
1820 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1821 collision with other packages). gdcmPython/demo/*.py changed
1824 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1825 * python subdir moved to gdcmPython (preparation of distutils packaging).
1826 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1827 distutils installer is operational.
1828 * - gdcmPython/__init__.py now properly loads the swig generated
1829 shadow classes (from gdcm.py).
1830 - gdcmPython/demo/*.py changed to import the package gdcmPython
1831 instead of gdcmPython/demo/load.py.
1832 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1834 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1835 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1836 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1837 entries within the associated public Dicom dictionary resp. the same
1838 information but sorted by the fourth field (PAT, IMG, DIR) of the
1840 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1841 are now in the "???" group.
1842 - python/gdcm.i changed accordingly,
1843 - python/demo/printGroupedPublicDict.py added, that gives an example
1844 of the above new functionalities in Python.
1846 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1847 * src/gdcm.h, gdcmHeader.cxx:
1848 - historic references to glib's g_malloc and g_free (#defined)
1849 were definitively removed.
1850 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1851 * src/gdcmElValSet.cxx:
1852 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1853 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1854 - GetElValue(string) renamed to GetElValueByName.
1855 - Added GetElementByName(string).
1856 * src/gdcmHeader.cxx: added
1857 - GetPubElValRepByNumber(guint16, guint16)
1858 - GetPubElValRepByName(string)
1859 - GetShaElValRepByNumber(guint16, guint16)
1860 - GetShaElValRepByName(string)
1861 - GetShaElValByNumber(guint16, guint16)
1862 - GetShaElValRepByName(string)
1863 - GetElValRepByNumber(guint16, guint16)
1864 - GetElValRepByName(string)
1865 - GetElValByNumber(guint16, guint16)
1866 - GetElValRepByName(string)
1867 * Doc/requirements.txt added.
1869 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1870 * Test/Makefile building now depends on the one of libgdcm.so
1871 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1872 pixel data) aware which enables finding the address (offset) of
1873 the pixel data of JPEG encoded DICOM files. This leaves only a single
1874 file in the testSuite whose pixel data address (offset) is unknown.
1875 * python/testSuite.py changed accordingly.
1877 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1878 * VC++ has some strong limitations when working with the STL, as stated
1879 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1880 "Also note that some STL containers (map, set, queue, list, deque)
1881 cannot be exported. [...]
1882 Some STL classes contain nested classes. These classes can not
1884 This is caused by a designed limitation that once a template
1885 class is instantiated, it can not be re-instantiated and
1887 Since our usage of map<> is ubiquitous in gdcm, this "designed
1888 limitation" of VC++ is a pitfall.
1889 Hence the Python wrappers of gdcm cannot be incrementally linked
1890 against the c++ dynamic library. The dirty but only workaround is
1891 to forget about incremental link of dynamic libraries and to generate
1892 the Python wrappers library with the inclusions of the underlying C++
1894 The following modifications concern this matter on Win32/VC++:
1895 - wrapping python correct with standalone wrapped dll (don't use separate
1896 dll under windows !!!!)
1897 - python21_d debug mode enabled (ask Frog how to use it :-)
1898 - NO problem with having an STL member of class for example string in C++
1899 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1900 - Python test of dcmlib in Python is ok under windows on a large set
1902 * removed glib references
1903 * typedef's inserted in gdcm.i for correct swig type management
1905 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1906 * python/demo/*.py load.py extracted from test.py. Added explore.py
1907 that only displays required tags and testAll.py that parses all
1908 the files of the testsuite without using unittest.
1909 * python/testSuite.py other additional test on new files added.
1910 * Data/* new test files added accordingly to the testSuite.
1911 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1912 the vr in the file differs from the one of the dictionary.
1914 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1915 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1916 values, but limits itself to values which are below a user specified
1917 size (by default 1024 bytes).
1918 * python/gdcm.i : elements not loaded (because their size is above the
1919 user specified treshold) are exported with their TagKey as key of the
1920 python dictionary. This enables the testsuite to make some checks
1921 on the unloaded elements (since we have their offset and size).
1922 * python/testSuite.py
1923 - now tests for the existence and proper value of the pixel data
1924 - two new examples added.
1925 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1927 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1928 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1929 aware. See the strategy comments in gdcmHeader::FindeLength().
1930 * Test/test.cxx now accepts a filename as first argument.
1931 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1932 * python/testSuite.py changed to integrate test on above files.
1934 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1935 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1936 the vr was also RET.
1937 * python/testSuite.py more tests added.
1939 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1940 * python/testSuite.py unittest test suite added (uses Data)
1941 * Data/* dcm and acr files for the test suite.
1942 * glib dependance removed from un*x version. We now use ISO C99
1943 7.18 Integer types (see stdint.h)
1944 - python/Makefile, src/Makefile src/gdcm.h
1945 * src/ when an explicit vr (like dicom files) suddenly poped an
1946 implicit element we use to mark the underlying DictEntry of the
1947 concerned ElValue with "Implicit". This strategy was damageable
1948 too the public or provite dictionaries, since some of their vr
1949 would be changed. Since Header::FindLength heavily relies on the
1950 detection by Header::FindVR of falsely explicit elements, I
1951 added an extra ImplicitVr member to ElValue (boolean).
1952 The rest of the changes we the necessary adaptations.
1954 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1957 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1959 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1960 * Adaptation for porting to VC++:
1962 o forced to use std namespace (for string to be known)
1963 o all class use __declspec export style on WIN32
1964 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1965 (in stdlib.h on Win32 but in std:: for gcc)
1966 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1967 variable GDCM_DICT_PATH.
1968 * src/gdcmHeader.cxx verbose comments made discrete.
1970 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * python/gdcm.i: added a typemap that converts a C++ hashing table
1972 to native Python dictionary.
1973 * python/demo/test.py:
1974 - now uses the native dictionary for exploration of gdcmHeader.
1975 - takes an optional filename argument (the file to parse).
1976 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1977 PubElVals hashing table.
1978 * Dicts/dicomV3.dic removed error prone trailing spaces.
1980 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1981 * Python wrapping process moved away from src/Makefile to
1982 newly created python/Makefile (as well as gdcm.i)
1983 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1984 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1985 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1986 from the environement variable GDCM_DICT_PATH (when existing).
1987 * src/gdcmDict::GetTag bug fix.
1989 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1990 * Straightforward temporary fixes for swig to build the python wrappers.
1991 src/Makefile now has a python working entry [by working we mean
1992 that we can import de shadow classes without errors].
1994 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1995 * hashtest.cxx removed (since allready in Test)
1996 * src/gdcmlib.h renamed to src/gdcm.h
1997 * src/dcm.i renamed to src/gdcm.i
1998 * src/Makefile prepared for python wrapping
2000 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2001 * src/gdcmHeader.cxx :
2002 - Parsing of header is now separated from loading of element values
2003 (see gdcmHeader::LoadElements).
2004 - general clean up of hopefully all file access (creation of
2005 ReadInt16 and ReadInt32)
2007 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2008 * src/gdcmHeader.cxx :
2009 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2011 - SetLgrElem renamed to SetLength
2012 - GetLgrElem renamed to GetLength
2013 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2014 * src/gdcmElValSet.cxx fixed both GetElValue methods
2015 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2016 due to IdoDude was cleaned out.
2018 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2019 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2020 concentrates on finding the value representation (when it exists).
2021 RecupLgr now only finds the element value length, and it avoids
2022 returning the unecessary skL (skipped length).
2023 Also, offsetCourant was simply removed (with taille_fich) since
2024 it was redundant with the File position internals (by using
2025 ftell and fseek). This also made skL (see above in RecupLgr) usage
2027 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2028 on the libido specificities which are handled through class
2030 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2033 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * Truckload of changes. Parsing of header is barely functional
2035 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2037 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2038 * src/gdcmHeader.cxx many addons of low level methods
2040 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2041 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2042 and _IdDcmSWAP_LONG.
2044 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * This corresponds to all the changes decided at the meeting of
2046 May 23 2002. Needless to say we are running late...