1 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Bug fix due my last commit (compilation under Windows).
3 * Example/Volume2Dicom : bug fix in the file and reformatting source code
4 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
6 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
8 - Remove printf / sprintf
9 - include iostream AFTER gdcm so we don't get warnings
10 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
12 - Also remove tons of include from header files, hopefully this should
13 speeup the compilation time, since it was becoming a dog slow.
14 - Remove gdcm.h as it include way too many files and slow down compilation
15 (plus it is not up to date)
16 - remove 'using namespace std' this is BAD !
18 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * Remove memory leaks on the DicomDir
20 * Remove some useless datas in DicomDirObject
21 * Add usefull methods in SQItem, to be complient withe the ElementSet
23 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
26 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
28 future, with convertion)
29 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
30 and ImageDataSize values. Remove the method to get the PixelReadConverter
31 from the output of the class
33 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
36 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
38 and vtkErrorMacro use.
39 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
41 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
44 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
45 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
46 The string leaves only in the fonction. So when we make a .c_str(), we
47 get the pointeur on the first element, element that will be destroyed
48 immediately after thee instruction.
49 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
50 file has been opened : the test must be made on the content of the
51 pointer and not directly on the pointer !
54 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
56 the python part recompiles
58 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
60 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
61 X session is killed (for my computer... it seems to not be identic on
64 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
66 avoid problems (otherwise, the difference test between the visible image
67 and the reference is incorrect. If the reference is greater than the
68 screen resolution, it's produce errors).
69 Can be used for only one image. Can be used with a visible flag.
70 * vtk/vtkGdcmReader.cxx : remove commented codes.
71 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
72 under windows at compilation
73 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
75 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
77 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
79 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
80 tests on the image size X, Y, Z
82 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
84 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
85 between the class name and the file name
87 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * src/ : fix compilation warnings for the Write method (2 different
89 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
90 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
91 variable... create a static method in gdcm::Document to access to
92 this variable content.
94 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
96 file, to be accessed by other files (like gdcmFile). Remove commented
97 code. Move the change of the header to the gdcmFile, using the
99 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
100 To be sure of that (and simplify calls), the Write of the header now
101 gets a file name and not a file pointer (std::ifstream).
102 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
103 DocEntryArchive. Remove all open of the written file
105 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
108 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
110 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
112 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
113 some corresponding methods. Write correctly the file and check before
115 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
116 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
117 is now on RGB datas (as before my last commit
118 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
120 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
122 Add a print information of the type of the entry
123 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
124 It was in the gdcmFile, and all write have been regrouped
125 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
126 Write correctly all dicom files (in decompressed mode only at this time)
127 * Test/ : test on files are now made using Raw datas and not color datas if
129 * Example/PrintFile.cxx : add more printings
131 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * Amelioration of code, remove some code copy. For the loading of
133 BinEntry (in gdcmDocument), add the test to verify if the file is already
136 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
138 remove a DocEntry in the header (push an empty DocEntry)
139 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
140 lines. Bug fix in the initialization of the PixelConvert and the
142 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
143 use in TestCopyDicom (now this test can run under windows... but fails)
144 * Test/TestCopyDicom.cxx : amelioration of the test :
145 - test the pixels written
146 - add test points to quickly find where is the error
147 - can set a file name input and output in arguments
148 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
149 amelioration of the test output
151 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
153 all replaced DocEntry's
154 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
155 Now, each needed DocEntry to modify is duplicated, modified and inserted
156 to the header using DocEntryArchive. Thus, after save, we can restore the
157 header initial state.
159 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
162 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
164 correct to copy it. The DictEntry is specified at the DocEntry creation,
165 then, it musn't change in the time.
166 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
167 header correctly. At this time, the change is only made for the first
168 level of the Document. In the future, it might consider sequences.
169 The change is made by replacing a DocEntry by an other that is created
170 outside the class. The old value is kept. When we restore the header
171 status, the added DocEntry is deleted and replaced by the old value.
172 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
173 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
174 set the write type to explicit VR, implicit VR or ACR. Add methods to set
175 the write mode to native, decompressed or RGB (but not used at this time)
177 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
179 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
181 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
183 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
185 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
186 set because already copied when copying the BinEntry's of the header
187 * Test/TestAllReadCompareDicom.cxx : remove warnings
189 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
191 Two problems appear when doing it :
192 - with the gdcmFile : when the GetImageData method is called, the pixels
193 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
194 datas (pixels). And each structure destruct the datas when it's
195 destructed. So we have two destructions for the same datas. To solve it,
196 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
197 datas or not. If it doesn't own datas, then they will not destroyed by
199 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
200 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
201 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
202 create a double destruction of the same DocEntry's. So, to solve it,
203 the TagHT is simply cleared and the DicomDir* elements are destroyed.
204 * TODO : add an entry concerning memory leaks in the DicomDir
206 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
208 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
211 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
213 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
214 after it have been deleted
216 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * FIX: src/* fix the doxygen warnings.
218 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
219 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
220 was erroneously defined with a size of 15 instead of 16. [many thanks
221 to Jean Michel Rouet for pointing out this bug].
223 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
224 1. Finish merging JMR patch for writting DICOM from scratch
225 2. Fix -hopefully- bug with MONOCHROME and space vs null character
226 3. Use const ref when possible
227 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
228 5. A few more comments
229 6. CreateUniqueUID can now be called without parameter"
231 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
232 * ENH: Slightly bigger patch:
233 1. Getting toward full integration of JMR patch for writting dicom from scratch
234 2. Update Test to test part of this patch: CreateUniqueUID
235 3. File was not close properly in gdcmDict
236 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
237 5. Use of const ref instead of copy (speed issue)
238 6. Remove temporary (duplicate) string in TranslateToKey
239 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
240 8. Do not repeat virtual in subclasses
241 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
243 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
244 * Apply first patch toward better string comparison when dealing with broken
245 DICOM files. Essentially the string could be padded with a space instead
246 of a null character as defined by standard
248 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
250 because never used... and in the same time, that's remove some memory leaks
252 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * src/gdcmFile.cxx : now delete the PixelConvert instance.
254 * In examples and tests : change the type of image data variables from void*
255 to uint8_t*. Remmove all delete on image data variables
257 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
259 Verify the file pointer value before open the file, and if it's not null,
260 a verbose message is generated.
261 Close correctly the file when the file isn't considered dicom-like. The
262 correctly close is a call to CloseFile.
263 When closing the file pointer, test if its not null to close the file.
264 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
265 file. For an uncompressed image, the copied datas correspond in the least
266 case to the image size (calculated) or the image size specified in the
267 header. A verbose is generated if these two size mismatch
269 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
271 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
272 break under windows (with msvc6 compilation).
274 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
276 compiling with MSVC6)
278 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * Bugs fix for the Windows build with VC6
280 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
281 needed (only for projects required VTK). If the VTK is included in all
282 projects, there is conflicts with the jpeg lib of vtk when compiling the
283 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
284 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
285 when compiling the gdcm_wrap.cxx file (created by the compilation of the
287 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
288 (like it's already made for the cout use). Otherwise, conflict with the
291 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
294 - comments on the DicomDir::Method related usage added.
295 - now that we use the namespace gdcm, a lot of internal classes do
296 NOT need to be wrapped anymore.
297 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
298 DicomDir::Method) new example added.
300 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
301 * Improve string manipulation. I now inforce the notion of 'DicomString'
302 A DicomString can contain as many \0 as they want
303 and it is *always* of even length.
304 We only support odd length for very rare case.
305 And in the near future this should be removed.
307 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
308 * /binary_write/ gdcm source. Now even on big endian we are writting
309 little endian. This should -heopfully- fix some tests
311 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
312 * Now the dictionary is compiled into gdcm lib. This is a default
313 behavior, thus any dic file specified is picked before failback to
314 the one comiled into lib
316 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
317 * Change internals for gdcmDict. Don't use any 'new' any more.
318 This should definitely solve any leak problem, and we should be
319 as fast as before, as long as don't modify too much the dictionary.
321 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
322 * STYLE: ivars should start with a capital letter.
323 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
324 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
326 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
328 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
329 new 2004 dictionaries added (thanks to JPR).
330 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
331 * CLEANUP_ROUND (15) for gdcmPixelConvert
332 - RLEFrame::NumberFragments is now of type unsigned int
333 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
334 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
337 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
338 * Initial work in gathering all transfer syntax accessors. clearly
339 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
340 ivars, but only one transfersyntax (class) ivar with equivalent method on
343 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
344 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
345 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
346 discussed (plus I didn't like having a 2000 lines patch not commited)
348 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
349 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
350 * CLEANUP_ROUND (14) for gdcmPixelConvert
351 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
352 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
353 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
355 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
356 anymore and hence avoids storing a copy of PixelConvert::Decompressed
357 into File::Pixel_Data.
359 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
360 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
361 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
362 * CLEANUP_ROUND (13) for gdcmPixelConvert
363 Substituted File::ParsePixelData() with PixelConvert::Print() new
365 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
366 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
367 method to those classes.
368 - src/gdcmFile.[cxx|h]:
369 -- Added a ::Print() method.
370 -- PixelConverter is now a reference instead of a member.
371 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
372 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
374 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
376 collaboration diagram and inheritance diagram should be generated with
378 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
379 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
380 pointlessly wrapped (see
381 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
382 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
383 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
384 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
385 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
386 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
387 -- File::Initialise: PixelConverter setup moved away to
388 PixelConverter::GrabInformationsFromHeader()
389 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
390 interpretation moved away to PixelConverter::BuildRGBImage()
392 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
393 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
394 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
396 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
397 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
398 displayed on Win32 when a brutal abort() occurs (because of uncatched
399 exception). See TODO new entry of this commit for more on this.
400 * TODO added new entry.
401 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
402 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
403 - HandleColor is no longer called from gdcmFile.cxx
404 - gdcmPixelConvert.cxx clean up on method arguments and internal
405 variable names for semantical coherence.
407 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
408 * Finished lossless transition, not only do we now read all lossless jpeg
409 images, without the need of the Cornwell lib, but we do read them properly now
410 * To reduce code (well to avoid code duplication), I defined a common place
411 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
412 redefine symbols. This is not prefect but this the best solution I found for a
413 compilation time jpeg option.
415 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
416 * Update jpeg ijg lib to support lossless jpeg implementation
417 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
419 * Also added a special copyright for dcmtk since we use their bugfixes.
422 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
424 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
425 matters, as stated in warning note at begining of %include section).
426 * src/gdcmDicomDir*.[cxx|h]: coding style
427 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
428 * src/gdcmJpeg8.cxx: doxygen fix.
429 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
430 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
431 from File:: to PixelConvert::.
433 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
434 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
435 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
436 - more code moved away from File:: to PixelConvert::
437 - fat setup of PixelConverter set in place in File::Initialise.
439 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
440 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
441 namespace at the file system level. So now you should convert your examples
443 gdcmHeader -> gdcm::Header
444 It would be nice if people keep in mind to no open the namespace, since it
445 allows compilation on broken plateform which were defining common symbol in
446 the standart namespace (like LP, Unknown ...)
448 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
449 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
450 The JPEG fragments are now parsed at the same stage than the RLE
451 information. All code related to JPEG is now in gdcmPixelConvert:
452 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
453 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
454 export a gdcmFile:: method. Those are simply global functions
455 (for the time being this is better than having them attach to
456 either gdcmFile:: or gdcmPixelConvert::).
457 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
458 and stores the result in a gdcmJPEGFragmentsInfo.
459 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
460 code (among other stuff) moved away from gdcmFile:; to
463 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
465 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
466 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
467 clean up of RLE related code.
468 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
469 - src/gdcmRLE.cxx removed
470 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
471 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
472 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
473 * CLEANUP_ROUND (9) for gdcmPixelConvert
474 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
475 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
476 away from gdcmFile:: to gdcmPixelConvert::.
478 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
479 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
480 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
481 This is because Parse7Fe0 used to parse the pixels to compute the
482 length. This task was passed over to FindDocEntryLengthOB() a long
483 time ago, EXCEPT I had forgotten the OW case...
484 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
485 we just recylce the code for parsing RLE fragments and computing
487 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
488 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
489 with the retired Parse7Fe0().
490 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
491 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
493 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
494 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
495 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
496 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
497 - src/CMakeLists.txt: alphabetic order reodering + new entries.
498 * CLEANUP_ROUND (4) for gdcmPixelConvert
499 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
500 to return an unused length.
502 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
503 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
504 this should be cleanner from the plane view. The iostream are erally a pain
505 to use to do simple stuff.
507 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
508 * Redo the compilation of the ijg jpeg library. Now only one source is
509 necesseray. No need to rename file by hand what so ever. CMake handle the
510 copying of the file within different directory, configure header file to
511 modify some symbol. The only addition made to ijg wasd a mangle table so
512 that symbol are different wether we are within 8bits or 12bits.
514 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
515 * Added documentation of vtkgdcmReader on Website:
516 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
517 with it's binary name).
518 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
519 the Website to be more complete.
520 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
521 doxygenated documentation.
522 - Doc/DoxyVtkGdcmReaderExamples.txt added
523 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
524 DoxyVtkGdmReaderExamples.html )
525 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
526 * CLEANUP_ROUND (3) for gdcmPixelConvert
527 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
529 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
530 * CLEANUP_ROUND (2) for gdcmPixelConvert
531 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
533 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
534 * CLEANUP_ROUND for gdcmPixelConvert:
535 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
536 - src/gdcmPixelStuff[h|cxx] removed
537 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
538 - src/CMakeLists.txt changed accordingly
540 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
541 gdcmVersion.py moved to newly created ATTIC related
542 gdcmPython/SetupOldies/ directory.
543 * Autotools clean up:
544 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
545 - autogen.sh configure.in acinclude.m4 python.m4 removed
547 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * src/*.cxx *.h Reference to License.htm fixed to License.html.
549 * Doc/CMakeLists.txt, doxygen.config.in: fix.
550 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
552 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * TODO updated with Mathieu suggestions. I proposed a template for
554 describing TODO entries and used it for new entries.
555 * Added Doc/Website/CodingStyle.html, Developpers.html,
556 DeveloppersPython.html, GdcmDataCvs.html and
557 DownloadVersion0_1.html, DownloadVersion0_3.html.
558 * Some Doc/*.txt Doxygen files (which do not really concern the
559 documentation itself, but the website) moved to html and
560 placed in directory Doc/Website:
561 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
562 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
563 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
564 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
565 * CMakeLists.txt changed accordingly.
566 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
567 DeveloppersPython.html
568 * INSTALL nows refers to Doc/Website/Installation.html
570 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
571 * Added Doc/Website directory, that contains a first raw version
574 2004-09-23 Jean-Pierre Roux
575 * FIX In order not to be poluted any longer by casting problems,
576 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
577 we can now delete[] it safely
578 * VoidArea is now called BinArea (less confusing name),
579 and all the methods called ...VoidArea... are now ... BinArea...
580 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
582 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
583 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
584 clear) TagHT, which is an inherited member of gdcmElementSet. It is
585 up to the destructor of gdcmElementSet to clean up TagHt and it's
588 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
589 * Test/CMakeLists.txt: update to follow gdcmData renamings.
590 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
592 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
593 * ENH: added some utility method that builds a flat dictionnary
594 holding all the Dicom entries contained in the recursive structure
595 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
597 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
598 BuildFlatHashTable() that build a flat dictionary.
599 - src/gdcmElementSet.h: added a new private GetTag() accessor.
600 gdcmDocument is now a friend of gdcmElementSet.
601 - src/gdcmElementSet.cxx: clean up.
602 - Example/FlatHashTablePrint.cxx added.
603 - Example/CmakeLists.txt changed accordingly
605 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
607 moved away from gdcmDocEntrySet (since this class is an abstract class
608 acting like an interface). SQDepthLevel and BaseTagKey are now
610 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
611 and associated accessors. Doxygenation of the class.
612 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
614 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
615 Use SQDepthLevel accessor instead. ::Print() adapted.
616 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
617 - src/gdcmDocument.cxx changed accordingly.
619 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
621 - The following is the doxygen comment of the typedef declaration
622 of gdcmagKey in src/gdcmCommon.h:
623 gdcmTagKey is made to old an "universal" (as in URL, Universal
624 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
625 A dicom tag allways has a group and an element, but a set of tags
626 embeded in various (optionally nested) sequences and sharing
627 the same group and element all share the same (group, element)
628 "identifier". Hence the (group, element) cannot be used as an
629 identifier (in gdcm we shall refer to a "TagKey") of a tag.
630 In order to construct a proper tag identifier (i.e. a key) we
631 consider the following definition of a TagKey:
632 - let Group, Element be the string representation of the
633 group and element dicom tag members,
634 - let ItemNumber be the string representation of the integer
635 index of the considered item number of a sequence,
636 Let the key of a tag embeded in a sequence, noted SeqTag, be
638 /ItemNumber#Group|Element
639 where "/", "#" and "|" are characters acting as separators.
640 Then the general form of a gdcmTagKey is given by:
641 Group|Element<SeqTag>
642 where <SeqTag> means NO or many instances of SeqTag.
643 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
646 but the gdcmTagKey of a tag "embeded" is the first item of
647 a sequence, itself nested in the third item of a sequence is the
649 0004|1220/2#0008|0082/0#0008|0090
650 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
651 order to hold the new sequence compatible key. Previously, the
652 GetKey() method would look in the underlying gdcmDictEntry.
653 - src/gdcmDocEntry.cxx:
654 -- constructor now copies the underlying DictEntry key, in the local
656 -- ::Print: displays the member Key, instead of the (group, element).
657 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
658 - src/gdcmDocEntrySet.h:xi
659 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
660 -- now has a new BaseTagKey member.
662 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
663 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
665 This poses the problem with the semantics of the following lines
666 LoadEntryVoidArea(0x0028,0x1201); // R LUT
667 LoadEntryVoidArea(0x0028,0x1202); // G LUT
668 LoadEntryVoidArea(0x0028,0x1203); // B LUT
669 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
670 to the long FIXME note for what the problem is. Nevertheless in
671 order to get things working the dicom dictionary was altered !
672 Please fix things urgently...
673 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
674 information), see above note on moving the member VoidArea. Nevertheless
675 the following entries previously correctly set as US are now inproperly
677 0028 1201 OW IMG Red Palette Color Lookup Table Data
678 0028 1202 OW IMG Green Palette Color Lookup Table Data
679 0028 1203 OW IMG Blue Palette Color Lookup Table Data
680 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
681 of gdcmDocEntry moved to gdcmSeqEntry.
682 * src/gdcmSeqEntry.cxx: STYLE.
684 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
685 * Test/TestAllEntryVerify.cxx minor fix and added comments.
687 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * gdcmPython/testSuite.py: all the test suite in python is now moved
689 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
690 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
691 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
693 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
695 to avoid inclusion recursion until STL is reached.
696 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
697 mecanism. errno.h is not included in gdcm anymore.
698 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
699 (gdcmFormatError now inherits from gdcmFormatUnexpected).
701 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
702 gdcmData/TestAllEntryVerifyReference.txt
703 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
704 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
705 exception_on_error parameter.
706 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
707 - vtk/vtkGdcmReader.cxx changed accordingly,
708 - Example/*.cxx and Test/*.cxx changed accordingly.
710 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
711 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
712 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
713 enable_sequences removed from gdcmHeader constructor and dependencies.
714 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
715 * gdcmPython/demo/PrintHeader.py: dummy fix.
716 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
717 skip_shadow removed from gdcmHeader constructor and dependencies.
718 * Example/*.cxx and Test/*.cxx changed accordingly.
720 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
722 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
724 2004-07-21 Jean-Pierre Roux
725 * FIX Now, Parsing and Printing a DICOMDIR do work!
726 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
728 2004-07-20 Jean-Pierre Roux
729 * FIX Some brain damaged headers have Zero-Lenght fields
730 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
732 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
733 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
734 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
735 variable (instance of gdcmDebug) by a definition macro, and the instance
736 is now in static in the gdcmDebug class
737 * src/gdcmSQItem.h : (FIXME) remove an undefined method
738 * Test/PrintAllDocument.cxx : bug fix in the result of the test
740 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
741 * WARNING: ctest now depends more tightly on gdcmData. You should
742 check out gdcmData properly for things to run smoothly...
743 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
744 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
745 we need the pixels not be loaded in order to use the ValEntry
746 that displays position and size).
747 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
748 This is a C++ based equivalent of gdcmPython/testSuite.py that should
749 be deprecated. If you have any doubts about the advantages of a
750 modern scripting language (read Python) versus grass root C++ (i.e.
751 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
752 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
753 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
754 Anyhow, consider documenting the gdcmData images in
755 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
757 * Test/CMakeLists.txt:
758 - now uses TestAllEntryVerify.cxx
759 - specific comments on oldACR00001.ima (now renamed in gdcmData
760 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
761 gdcmData/TestAllEntryVerifyReference.txt
764 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * src/*.[h|cxx] : typedef clean up
766 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
767 - TagKey renamed to gdcmTagKey (for external usage)
768 - VRKey renamed to gdcmVRKey (for external usage)
769 - removal of typedef duplication.
770 - Removed all unecessary inline keyword from class inline definitions.
771 - Some method|function(void) declarations replaced with method|function().
772 * src/jpeg/libijg12/jdhuff12.c:
773 - printf polluting ctest removed.
774 - TAB removal for comminting
776 - TestAllReadCompareDicom.cxx: added a test that compares all the
777 images in gdcmDataImages.h with corresponding images in
778 gdcmData/BaselineDicom/. When baseline images are not present
779 this test creates them.
780 Note: we need to validate each reference image, but before that
781 I'd like to rename them with a more explicit name...
782 - CMakeLists.txt: changed accordingly.
783 * Example/*.cxx: examples now only include gdcm.h (as opposed to
784 including each header needed).
786 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
787 * Test/*.cxx and Example/*.cxx: moved some examples away from the
788 test suite to the Example directory. Are concerned:
793 - TestWriteSimple.cxx
794 * Test/CMakeLists.txt: added some comments on reasons for black listing
795 image gdcmData/oldACR00001.ima
797 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * Test/CmakeList.txt: removed the following from black list (to be coherent
799 with removal from gdcmData):
800 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
801 - gdcm-MR-PHILIPS-16.dcm
803 Added the following because after last cvs update, they cause
804 ctest -R TestReadWriteReadCompare
806 - gdcm-MR-SIEMENS-16-1.acr
808 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
809 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
810 new comments in this file) we temporarily (sigh) move to a weaker
812 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
813 we don't need to black list the following images anymore:
814 - 8BitsUncompressedColor.dcm
816 - US-PAL-8-10x-echo.dcm
817 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
818 fixes and the beautified code ;-)
819 This fixes the bug introduced in version 1.42 (when beautifying)
820 that made the parsing of 8BitsRunLengthColor.dcm unproper.
821 Note: ctest was blind to this bug (this means we need to still
822 improve the test suite). The bug could be detected by using
823 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
825 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
826 and by displaying the (garbage) produced file temp.XDCM...
828 2004-06-29 Jean-Pierre Roux
829 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
830 - replace by uggly but working old code :-(
831 A lot of things should be OK again.
832 It's really urgent to have a test suite that *tests*,
833 to prevent Frog's beautifying sessions to break all the stuff
834 (twice, withing a fortnigh ...)
836 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
837 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
838 redundancy) to added Test/TestReadWriteReadCompare.cxx
839 * Test/CmakeList.txt: because the compare test of
840 Test/TestReadWriteReadCompare.cxx fails, the following images are
841 black listed: - 8BitsUncompressedColor.dcm
843 - US-PAL-8-10x-echo.dcm
844 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
845 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
846 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
847 and ad-hoc kludge. This kludge is now removed, and on encountering
848 such an image (OB field brain damaged) we set errno. Then in
849 ::FindDocLength() we "fix" the length as being ALL what remains
850 in the file (until EOF). We then proceed, hoping for the best...
851 This fixes a SegFault in ShowDicom when trying to write such an
853 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
854 (because TestWriteRead breaks on it, after a non conformal commit?).
855 ctest now runs properly, except for MakeDicomDir (which was allways
856 broken) and the Python related stuff (still not fixed).
858 2004-06-24 Jean-Pierre Roux
859 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
860 FIX : Test/TestReadWrite now iterates on all the file names
861 (instead of infinite loop)
862 ENH : Test/TestWriteRead now iterates on all the file names
864 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
865 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
867 2004-06-24 Jean-Pierre Roux
868 FIX : - now Write drops LUT Descriptors and LUTs (if any)
869 when SamplesPerPixel =3
870 - now Write is no longer confused by
871 'BitsAllocated = 12" and 'BitsStored=12"
872 - "UN" value representation Elements are now written correctly
873 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
874 ENH : - now gdcmHeader has its own Write methods
875 (in order to split the job that has not to be done
878 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
880 loop on the same image until memory went out.
881 Note: this means we still have gobs of memory loss in PrintDocument
882 * src/gdcmDocument.cxx: fixes problem on parsing on file
883 gdcmData/16BitsJpegLosslessGrayScale.dcm.
885 2004-06-24 Jean-Pierre Roux
886 FIX : Write - All the Sequences and Sequence Item are now written
887 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
888 is added a the end, when necessary.
889 - A lot of brain-damaged images, that were read correctly are
890 now written correctly
891 - length compatible BinEntry are now loaded correctly
892 (even for odd groups)
893 Note : only Explicit Value Representation was checked.
894 (question : is implicit VR really necessary for gdcm ?)
896 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * DEVELOPPER: added a proposition of coding style.
898 * src/gdcmDocEntry.h: removed every inline declaration (for test of
901 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
902 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
903 Use the gdcmDocEntry::Print() and Write() instead.
904 * src/gdcmDocument.cxx: bug fix.
906 2004-06-22 Jean-Pierre Roux
907 FIX : gdcmDocument.cxx
908 - Now we do recognize the JpegLossLess format (there was a misstyping in
909 code 'beautyfication' :-(
910 - Now we automaticaticaly load the Luts, if any
912 2004-06-22 Jean-Pierre Roux
913 In order : to write Sequences, whatever their imbrication level,
914 : to allow user to create his own Sequences
915 a lot of modif where necessary (adding, moving, or virtualising methods)
917 WARNING : save your own sources *before* cvs up !
920 ADD virtual void Write(FILE *fp, FileType filetype);
923 ADD virtual void Write(FILE *fp, FileType filetype);
924 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
927 ADD virtual void Write (FILE *fp, FileType filetype)=0;
928 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
929 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
930 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
931 ADD std::string GetEntryByName(TagName name);
932 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
934 std::string vr = "unkn",
935 std::string fourth = "unkn",
936 std::string name = "unkn");
937 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
938 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
939 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
940 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
941 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
942 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
943 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
944 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
947 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
948 ADD virtual std::string GetEntryByName (TagName tagName);
949 ADD virtual std::string GetEntryVRByName (TagName tagName);
950 REM virtual bool Write(FILE *, FileType);
951 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
952 FILE *_fp, FileType type);
953 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
954 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
955 REM virtual bool WriteEntries(FILE *_fp,FileType type);
956 REM virtual std::string GetEntryByName (std::string tagName);
957 REM virtual std::string GetEntryVRByName (std::string tagName);
958 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
959 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
960 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
962 std::string vr = "unkn",
963 std::string fourth = "unkn",
964 std::string name = "unkn");
965 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
966 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
967 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
968 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
971 ADD virtual void Write(FILE *fp, FileType filetype);
974 ADD virtual void Write(FILE *fp,FileType filetype);
977 ADD virtual void Write(FILE *fp, FileType filetype);
978 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
979 REM std::string GetEntryByNumber(guint16 group, guint16 element);
980 REM std::string GetEntryByName(TagName name);
983 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
985 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
986 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
987 The default constructor invoked by the line
988 gdcmHeader *f1 = new gdcmHeader( header );
989 was gdcmHeader::gdcmHeader(bool) instead of the expected
990 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
991 Hence the parsing wasn't executed... See also below.
992 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
993 as explicit constructor didn't do the trick to fix the above problem.
994 Could anyone explain why ?
995 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
996 properly calls gdcmValEntry::Print() (that was weed out from
997 code related to gdcmBinEntry).
999 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * In order to fix memory leaks:
1001 - Test/TestWriteSimple.cxx: added cleaning of free store through
1003 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1004 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1005 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1006 (through the call to ::AddDicomDirMeta()) or the destructor
1007 would crash when deleting uninitialized ::metaElems].
1008 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1009 - src/gdcmDocument.cxx:
1010 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1011 from dynamic stores.
1012 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1013 was causing memory leaks.
1014 - src/gdcmSQItem.cxx:
1015 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1016 cleanly handled with polymophism: sorry but my milage is low).
1017 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1018 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1019 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1020 This avoids SegFaulting.
1021 - src/gdcmSQItem.h: coding style.
1023 - Test/TestWriteSimple still severely sucks. The output image content
1024 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1025 damaged when displayed with vtkgdcmViewer.
1026 - on memory leaks: TestWriteSimple leaks really less (see entry
1027 of 2004-06-18 in Changelog file for the call to valgrind).
1028 - on segfaults: ctest now passes all the tests but one (no more
1030 * Erroneous leading white fix:
1031 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1032 white[s] (as opposed to from >> xxx, that removes it [them].
1033 - src/gdcmTS.cxx: ditto.
1034 - gdcmPython/testSuite.py: dirty related kludge removed.
1035 * src/*: remaining references to gdcmParser removed.
1036 * src/*[cxx|h]: added copy[way]left header.
1039 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * In order to fix writing of dicom files:
1041 - Test/TestWriteSimple.cxx: a simpler example of writing.
1042 - Test/CMakeLists.txt changed accordingly.
1043 - src/gdcmDocument.cxx:
1044 -- The destructor now recursilvely removes potential sequences.
1045 -- Bug fix in ::IsJPEG2000()
1046 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1047 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1049 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1050 to only declared) and build on top of
1051 ::GetDocEntryByNumber(guint16, guint16).
1052 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1053 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1054 for usage in destructor and treatement of promotion in
1055 ::ReplaceOrCreateByNumber().
1056 - src/gdcmSQItem.cxx: destructor should better handle his job.
1057 Test/TestWriteSimple now runs (or at least it DOES something).
1058 * We can now start hutting memory links. A good starting point is:
1059 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1060 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1061 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1063 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * Valgrind note: after Mathieu Malaterre teached me how to read
1065 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1067 Using gcc, you can force the STL to use malloc and to free memory as
1068 soon as possible by globally disabling memory caching.
1069 With 3.2.2 and later, you should export the environment variable
1070 GLIBCPP_FORCE_NEW before running your program.
1071 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1072 simply vanish (it is still not clear to me, whether this means that
1073 STL std::string leaks or if valgrind believes it leaks...).
1074 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1075 running bin/gdcmTests makeDicomDir):
1076 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1077 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1079 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1080 SegFaulting (I drowned in DicomDir related code when trying to
1081 understand why the list is empty...).
1082 * src/gdcmDocument.h: first BSD license header try.
1083 * Doc/License.txt added.
1085 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1086 * src/gdcmDocument.[h|cxx]:
1087 - Clean up of the Transfer related predicates. They are now all based
1088 on new method isGivenTransferSyntax, that (should) handle properly
1089 the padding problem.
1090 - general clean up, simplification, and coding style.
1091 - Specific clean up of Parse7FE0() (umproperly named actually).
1092 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1094 2004-06-14 Jean-Pierre Roux
1096 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1097 - fix the display of SQItem ordinal number
1098 - add the GetSQItemByOrdinalNumber method
1099 - remove some useless never written private methods
1101 2004-06-14 Jean-Pierre Roux
1103 - adding a constructor taking a gdcmDocEntry as an input param
1104 - ReplaceOrCreateByNumber now returns :
1105 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1106 a gdcmValEntry * if a string value is passed as a param
1108 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1109 according to the param type (no longer sets a gdcmDocEntry)
1110 - GetValEntryByNumber, GetBinEntryByNumber added
1111 - NewValEntryByNumber and NewBinEntryByNumber added
1113 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1115 - GetSQItemNumber and SetSQItemNumber added, to provide
1116 a (relative) Item identier inside a given Sequence
1117 \warning : some pb remaining around this number
1119 - AddEntry now takes the Item Number as a param
1121 - adding a constructor taking a gdcmDocEntry as an input param
1123 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * Memory leak hunt with the following command:
1125 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1126 --show-reachable=yes gdcmTests PrintDocument
1127 It looks like many (all?) leaks are due to the STL (or a bad usage
1128 of the STL. The lines producing the leaks now have a comment with
1129 a "MEMORY LEAK" tag: you can retrieve them with
1130 grep "MEMORY LEAK" src/*
1131 Here are two typical examples which I can't help fixing:
1136 char * test = "babo";
1137 name = test; //// <--- valgrind detects 960 bytes lost in
1138 //// call to std::string::operator=(char const*)
1139 name.clear(); //// Doesn't help !
1147 std::cout << "Type a bunch of characters followed by RETURN: ";
1148 getline(std::cin, line); //// <--- valgrind dectects a loss
1149 //// of 1320 bytes in call to
1150 /// std::basic_istream<>& std::getline<>
1156 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * src/gdcmHeader.[cxx|h]:
1158 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1159 and related, moved away to gdcmDocument.
1160 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1161 the corresponding protected accessors of inherited class
1162 gdcmDocument, removed ! As a consequence gdcmFile had to be
1163 declared friend of class gdcmDocument (see below).
1164 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1165 - Clean up of undefined or unused methods.
1166 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1167 account the changes to gdcmHeader.h).
1168 * src/gdcmDocument.h:
1169 - gdcmFile is now a friend class (in order to take into account the
1170 changes to gdcmHeader.h).
1171 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1172 (see changes to gdcmHeader.h).
1173 - Accessors (reading on the form GetEntry*) are now public.
1174 - Clean up of undefined or unused methods.
1175 * src/gdcmDocument.cxx:
1176 - adaptation to changes to gdcmDocument.h
1177 - ::OpenFile now writes a verbose message when file cannot be opened.
1178 - some std::string properly set to VRKey
1179 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1180 references to gdcmDocument.
1181 * Test/TestFindTags.cxx: changed accordingly to above changes.
1182 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1183 cvs repository gdcmData.
1185 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1186 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1187 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1188 conflicts with gdcmValEntry::voidArea.
1189 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1190 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1191 Value representation between StringRepresentable and BinaryRepresentable.
1192 * src/gdcmDocument.cxx:
1193 - method ParseDES: proper indentation restored and usage of
1194 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1195 - method LoadDocEntry: the fingerprint left in the SetValue() of
1196 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1197 removed. Reverting to previous code segment with the proper
1198 dynamic_cast< gdcmValEntry* >.
1199 Note: this was (partially) breaking the python test suite
1200 (gdcmPython/testSuite.py) that made usage of the above
1201 fingerprint to check presence of "Pixel Data".
1202 * src/gdcmDocEntry.h: coding style.
1203 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1204 now taken into account.
1205 * gdcmPython/gdcm.i: adaptation to the new internal representation
1206 of gdcm (exit gdcmParser, hello gdcmDocument).
1207 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1209 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1210 anymore, but instead prints the loaded Python dictionary.
1211 * .... alas, the python testSuite is still broken.
1213 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1214 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1216 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1217 * src/gdcmUtil.h : export methods
1219 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1220 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1222 * Initial addition of automatic python testing
1223 * Initial addition of automatic image comparison
1225 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1226 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1227 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1229 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1230 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1231 * Test/ShowDicom.cxx : bug fix for msvc compilation
1232 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1234 2004-05-04 Jean-Pierre Roux
1235 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1236 new concepts (and new classes) :
1237 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1238 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1239 - Sequence Doc Entries (gdcmSeqEntries)
1240 a Sequence is composed of Items.
1241 Each item is a set of Doc Entries (this is recursive)
1242 The non uniqueness of the 'Dicom tag' is due to this recursivity
1243 (never taken into account)
1244 Our unability to add a new 'entry' in the header
1245 at the proper location (neither in the H-Table (map or multimap),
1246 nor in the Chained List is also due to this recursivity.
1247 Don't try, right now, to use/modify/compile these new sources :
1248 nothing is finished.
1249 We just commit all the stuff, 'as is', in order not to loose it.
1251 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1252 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1254 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1255 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1256 file prefix (SetFilePrefix)
1258 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1259 * Add a new test: ShowDicom, for now this is just the c++ version of
1260 checkRead.sh, later it will be able to compare the image read against a
1262 * Replace the DEBUG on the stack with a global entry in cmake interface:
1263 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1265 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1266 * Add an example subdir, with a real example on how to read + write a
1269 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1270 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1271 * Doc/CMakeLists.txt: the main page is now properly differentiated
1272 between the developper and user version.
1273 * Doc/doxygen.config.in: dropped search related obsolete flags
1274 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1276 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1277 * DEVELOPPER: added some helpfull comments for compile/test/install
1280 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1281 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1282 src directory, now generated in the build dir.
1283 2. Tests as mentionned smarter
1285 4. Add a new method in gdcmDict that return the PubDict by name
1286 this is interesting for 3rd party lib like ITK,
1287 where we could set the institution name / patient name...
1289 * ENH: 1. Now the test suite is working for real
1290 2. All binaries are now output in the gdcm-bin directory
1291 (this was not true before)
1293 2004-04-28 Jean-Pierre Roux
1294 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1295 SeQuence indented printing of Dicom Header.
1296 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1297 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1298 Computation of SQDepthLevel is now part of gdcmHeader constructor
1299 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1300 tree-like structure of a Dicom Header.
1301 * FIX Test code cleaning
1303 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1304 * ENH: Adding automatic testing
1305 1. Need a DartConfig.cmake to submit to public
1306 2. Add a test driver gdcmTest.cxx
1307 3. gdcmTestMain, an helper for the main test driver gdcmTest
1308 4. Files in Test don't have a main anymore, this becomes interesting
1309 when we add more and more tests, thus dsw don't have to load
1311 * ENH: Adding a GDCM_DATA_ROOT for testing
1312 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1313 one file instead of seven + some small cleanup
1315 2004-04-22 Jean-Pierre Roux
1316 * ENH Minor changes to the Print() methods.
1317 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1318 Header printing. Example given with :
1319 > PrintHeader fileName 2 new
1320 (SQ based tree-like structure still to be done for the Header ...)
1322 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1323 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1324 1. I have added some unsigned where needed
1325 2. Some function parameter not used -> (void)
1326 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1327 4. g++ don't like character '\' in comment
1328 5. #define jpeg_create_decompress jCreaDecompress
1329 this really need to be fixed
1330 6. virtualize destructor of gdcmObject ... leakage
1331 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1332 this also really need to be fixed
1333 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1334 remove compression file
1335 (as we only do decompression, right ?)
1336 * ENH: Change malloc/calloc/free with c++ equivalent
1338 2004-04-21 Jean-Pierre Roux
1339 * FIX gdcmHeaderHelper::GetXSpacing
1340 when a single value is found (bug ?), xpacing is now
1341 defaulted to yspacing
1343 2004-04-19 Jean-Pierre Roux
1344 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1345 * ENH add parameters :
1346 bool exception_on_error = false,
1347 bool enable_sequences = false,
1348 bool ignore_shadow = false
1349 to the gdcmFile constructors to be full gdcmParser compliant
1350 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1351 to allow reading of PAPYRUS 3.0 files
1353 2004-04-06 Jean-Pierre Roux
1354 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1356 2004-04-02 Jean-Pierre Roux
1357 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1358 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1359 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1361 2004-03-30 Jean-Pierre Roux
1362 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1363 for ACR file, written out as DICOM files (hope so...)
1365 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1366 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1367 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1368 moved to base class gdcmParser and only the specialisation is kept
1370 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1371 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1372 already does the job.
1373 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1374 (to be consistent with gdcmParser::WriteEntries).
1376 2004-03-30 Benoit Regrain
1377 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1378 upate of the object's instance. It's passed to 2 in the unfavorable
1379 case : one in the ExecuteInformation, one in the ExecuteData
1381 2004-03-29 Jean-Pierre Roux
1382 * ENH : Check on file type to be written moved
1383 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1384 * FIX : gdcmObject::ResetBoundaries now stops properly
1385 when end-of-list is reached
1386 : gdcmVersion modified (as Benoit Regrain asked)
1388 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1389 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1390 * src/gdcmUtil.cxx: added forgotten iostream include.
1391 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1392 equivalent to ExplicitVR in existing code).
1394 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1395 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1396 now contains all the gdcmGlobal related code.
1397 * minor coding style and doxygenation changes.
1399 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1400 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1401 now contains all the Debug related code.
1402 * minor clean-up of includes in src/*.cxx
1403 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1404 CreateCleanString) removed.
1405 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1406 * Doc/DoxyMainPageUser.txt added.
1407 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1408 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1409 src/gdcmDirList.cxx)
1411 2004-03-24 Jean-Pierre Roux
1412 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1414 2004-03-23 Jean-Pierre Roux
1415 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1416 big endian made volumes
1417 * ENH Now gdcmParser constructor and destructor are protected to forbid
1418 end user to instanciate class gdcmParser
1419 (only gdcmHeader and gdcmDicomDir are meaningfull)
1421 2004-03-22 Benoit Regrain
1422 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1423 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1424 gdcmSerie to gdcmDicomDirSerie
1426 2004-03-19 Jean-Pierre Roux
1427 * ENH Now the tree-like structure describing a DICOMDIR comming from
1428 an already existing DICOMDIR file is consistent with
1429 the home-made tree-like structure build ex-nihilo
1430 or build from the files held (recursively) in a Directory
1431 functions gdcmDicomDir::CheckBoundaries()
1432 gdcmObject::SetBoundaries() added
1434 2004-03-17 Jean-Pierre Roux
1435 * REM (Eric Boix bug) : removal of meaningless
1436 gdcmDicomDirImage::NewImage function.
1437 * FIX now file names and directory name are written properly in the
1439 * FIX now gdcmDicomDir constructor may be call without any trick
1442 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1444 of gdcmDicomDirImage::NewImage as empty function.
1446 2004-02-28 Jean-Pierre Roux
1447 * ENH add gdcmDicomDir:NewPatient
1448 add gdcmDicomDirPatient:NewStudy
1449 add gdcmDicomDirStudy:NewSerie
1450 add gdcmDicomDirSerie:NewImage
1451 to allow making gdcDicomDir object.
1452 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1453 (as opposite to the gdcmHeader chained list)
1455 2004-02-11 Benoit Regrain
1456 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1457 when using from python
1459 2004-02-10 Benoit Regrain
1460 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1461 * FIX : in gdcmDicomDir when the directory is empty
1462 * ENH : add callback and methods to get the progression of dicomDir
1465 2004-02-06 Jean-Pierre Roux
1466 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1467 - GDCM_META added to gdcmDicomDirType
1468 - class gdcmMeta created
1469 * ENH : - A brief summary is now displayed at the beginning of
1470 'testDicomDir' to help disaster magnitude estimation
1471 * REM : Now useless Test/explDICOMDIR.cxx
1473 2004-02-05 Benoit Regrain
1474 * ENH : add methods in gdcmObject to get the hash table or the list of
1476 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1477 * FIX : wrapping python for TagHeaderEntryHT
1479 2004-02-04 Benoit Regrain
1480 * FIX : even length for some strings when writting the dicom dir
1481 * FIX : sort the images in the dicom dir
1482 * FIX : Bug fix for python use of dicom dir
1483 * ADD : a python demo
1485 2004-02-04 Jean-Pierre Roux
1486 * FIX : Final solution (?) for icone embedded images
1487 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1488 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1489 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1490 gdcmData/gdcm-MR-SIEMENS-16.acr1
1491 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1492 to make full checking easier
1494 2004-02-04 Benoit Regrain
1495 * FIX : WriteEntries : coding style & logic in parameters
1496 * FIX : Set the elements to create the DicomDir in a dictionary file
1498 2004-02-03 Benoit Regrain
1499 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1500 * gdcmDicomDir : add the load of directory
1501 * Bug fix and print add-on
1503 2004-02-03 Jean-Pierre Roux
1504 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1505 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1506 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1507 * FIX gdcmParser.cxx : 'group length' elements are now considered
1508 as integers, even for shadow groups, when file is Implicit VR
1510 2004-02-02 Jean-Pierre Roux
1511 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1513 of the last synonym :-(
1514 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1516 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1517 * FIX taking into account the possible 7fe0,0010 multiplicity
1518 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1519 to allow removal of references to 7fe0,0010, to deal with
1520 ACR-NEMA images, when 0028,0200 is meaningfull
1522 2004-01-31 Jean-Pierre Roux
1523 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1524 no longer writes 'Un' on disk
1525 * FIX SQ elements with actual length are now dealt with corectly
1526 * FIX gdcmFile::WriteBase make the difference, for color images, between
1527 the length (for Palette expanded images)
1528 and Raw Length (non expanded image + Palette)
1529 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1530 (that broke Write). Replaced by UL.
1531 Aware user will reload the field if he
1532 thinks it's necesssary
1534 2004-01-30 Jean-Pierre Roux
1535 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1536 when 'dirty Acr' is found, to be compliant with the new
1537 IsReadable() methods.
1539 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1540 (no DOUBLE images in kosher DICOM,
1541 but so usefull for people that miss them ;-)
1543 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1544 DICOMDIR related utilities (not checked as Windoze compliant)
1546 2004-01-28 Jean-Pierre Roux
1547 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1549 2004-01-27 Jean-Pierre Roux
1550 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1551 to allow skipping the shadow elements, to save memory space.
1552 The TRUE value for this param has to be used
1553 with a FALSE value for the 'enable_sequence' param.
1554 ('public elements' may be embedded in 'shadow Sequences')
1555 * gdcmHeader methods now deal with 'embedded icones images' in the header
1556 (even when an 'icone image sequence' is announced by the
1557 element (0x0088,0x0200), but there is NO icone at all ...
1559 * gdcmHeader sometimes Image Location value doesn't follow
1560 the supposed processor endianity (see gdcmData/cr172241.dcm).
1563 * gdcmHeader add the method
1564 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1565 to get *all* the Header Entries with the same tag.
1566 GetHeaderEntrySameName is probabely *useless*
1567 (no meaning : Name is *not* an identifier within the Dictionnary)
1569 2004-01-26 Benoit Regrain
1570 * Bug fix in the print of hexadecimal representations. Remove long fields
1571 in the print and add a third level of print to print them
1573 2004-01-23 Benoit Regrain
1574 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1575 * Bug fix on test suite after remove the strip made on not string fields
1576 * Split the IsReadable method between gdcmParser which test that the file
1577 is dicom and gdcmHeader which test that it's an image file
1579 2004-01-22 Benoit Regrain
1580 * DicomDir : clean code, add methods, set variables in protected or private
1581 * gdcmUtil : bug fix for the clean string method
1583 2004-01-19 Benoit Regrain
1584 * Add the use of shadow dictionaries
1585 * bug fix and coding style
1587 2004-01-19 Benoit Regrain
1588 * src/gdcmFile.cxx : bug fix concerning the close of file
1589 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1590 * Add the update of header entries using the shadow library
1592 2004-01-19 Benoit Regrain
1593 * removal of file gdcmHeader2.cxx
1594 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1595 inheriting from gdcmParser. This split is to prepare the integration
1596 of dicom dir parsing
1597 * bug fix under python
1599 2004-01-16 Jean-Pierre Roux
1600 * REM removal of class gdcmHeaderEntrySet
1601 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1602 * ADD add file gdcmHeader2.cxx
1603 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1605 2004-01-15 Benoit Regrain
1606 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1607 entries created while parsing the header. Thus, they will be destroyed
1608 when the gdcmDictSet will be destroyed
1609 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1612 2004-01-15 Benoit Regrain
1613 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1614 made a fatal error because of the memory release at the end of program.
1615 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1616 some memory and vtk seems to have some problems with that.
1617 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1619 2004-01-14 Benoit Regrain
1620 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1621 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1622 * src/*.[h|cxx] : make changes due to class name changes
1623 * gdcmPython/demo/*.py : bug fix due to method names
1625 2004-01-13 Benoit Regrain
1626 * src/*.[h|cxx] : coding style
1627 * vtk/*.[h|cxx] : coding style
1629 2004-01-13 Benoit Regrain
1630 * gdcmPython/testSuite.py : test the readable flag of file for tests
1631 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1632 It's lied to the stl compilation by MSVC (windows, always windows...)
1633 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1635 2004-01-12 Benoit Regrain
1636 * src/*.h : add comments
1637 * src/gdcmDictSet.h : set the method BuildDictPath in public
1638 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1639 directly setted in the source code
1640 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1643 2004-01-09 Benoit Regrain
1644 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1645 * setup.py : use a reference to gdcmVERSION
1647 2004-01-07 Benoit Regrain
1648 * Modification to compile with the distutils.
1651 2003-12-10 Benoit Regrain
1652 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1653 can use a gdcmHeaderHelper to load datas
1654 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1655 made in the source code
1657 2003-12-10 Benoit Regrain
1658 * Update Windows projects and .cvsignore files
1660 2003-11-12 Jean-Pierre Roux
1661 * ENH gdcmHeader constructor has one more parameter (default value : false)
1662 that allows the user to 'go inside' the SeQuences only
1664 gdcmElValSet:Print takes it into account
1666 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1667 * ENH: Update gdcmPython/CMakeLists
1668 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1669 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1671 2003-11-10 Jean-Pierre Roux
1672 * FIX : gdcmHeader::LoadElements is now based
1673 on the ListTag listElem member,
1674 not longer on the TagElValueHT tagHt member
1675 * ENH : PrintPubElVal shows (temporarily) both results,
1676 with the tagHt member and the listElem member.
1677 (it's easier to 'see' the problems when using Printheader)
1679 * FIX : old private member LgrElem is now splitted into
1680 ReadLength : Length actually found on disk (updated only
1681 if bug fixing is necessary), for internal
1683 UsableLength : Updated by FixFoundLength, to fix a bug
1684 or to allow Parser going on.
1685 Will allow to re-write a kosher header when a SeQuence
1686 with a length (not 0000) is found
1687 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1688 because gdcmElValSet::Add does not update ListElem
1691 2003-11-07 Jean-Pierre Roux
1692 * FIX misstyping in Transfert Syntax name table
1693 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1694 when they have an actual length (not 0000 nor FFFFF)
1695 (Nobody should care of it, but DICOMDIR explorers)
1697 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1698 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1700 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1701 * ENH: vtkGdcmReader now supports LUT !
1702 (vtkgdcmViewer for now is not able to use them though)
1704 2003-11-05 Jean-Pierre Roux
1705 * in testSuite.py : new files names for checking the package
1706 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1707 that returns the pixel area size to the *aware* (vtk) user
1708 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1710 2003-11-05 Benoit Regrain
1711 * in testSuite.py : Modify the rules for checking the paths
1712 : Explicit error messages
1713 * in __init__.py : Related modif
1715 2003-11-03 Jean-Pierre Roux
1716 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1717 to be used by aware (vtk) users that want to manage
1718 LUT (and no to turn the PALETTE image into an RGB pixels one)
1719 * GetPixelType now returns 8U for 24 Bits images
1720 (vtkGdcmReader compliant)
1722 2003-10-31 Jean-Pierre Roux
1723 * Removal of *all* gdcmData images and add them again
1724 in order to loose the 'history' of un-anonymised images
1726 2003-10-31 Jean-Pierre Roux
1727 * RMV : removal of useless jBitsInJsample.h
1728 for both 8 and 12 Bits JPEG Lossy Libraries
1730 2003-10-31 Jean-Pierre Roux
1731 * ENH : Add the functions gdcmFile::GetImageDataRaw
1732 gdcmFile::GetImageDataIntoVectorRaw
1733 that act as GetImageData and GetImageDataIntoVector
1734 except the making of an RGB Plane from Gray Plane + LUT
1735 Intended to aware (vtk) users who know how to manage
1738 GetLUTRGBA return a R,G,B,A LUT if any
1739 lgrTotaleRaw gives the 'Raw' length
1740 GetImageDataRaw returns the gray Plane
1741 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1742 (They stay Grey, just like with other Dicom viewers :-(
1744 2003-10-30 Jean-Pierre Roux
1745 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1747 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1748 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1749 being coherents dicom files.
1751 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1752 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1754 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1755 * ENH: Two steps is necessary to please VC++ compiler...
1756 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1757 * ENH: Add include dir to medcon lib
1758 * FIX: only one function is being exported for now !
1759 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1761 2003-10-29 Jean-Pierre Roux
1762 * adding gdcmHeader::GetLUTRGBA
1763 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1764 --> Mathieu, the modif u're waiting for is not yet committed
1765 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1767 2003-10-27 Jean-Pierre Roux
1768 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1769 00191113.dcm DermaColorLossLess.dcm
1770 MxTwinLossLess.dcm RadBWLossLess.dcm
1771 * ENH: For version prior to vtkImageViewer2 -r 1.19
1772 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1774 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1775 * Removal of ido stuff in CMakeLists.txt
1777 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1778 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1779 * FIX: remove a call to ->Modified ... see comments
1780 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1782 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1783 * FIX: Problem with path for libvtkgdcmPython
1784 * ENH: Try adding a search script for python site-package
1785 * RMV: Remove some file from medcon lib that are not necessary
1786 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1787 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1788 * FIX: More pragma disable fro VC++,
1789 I don't think I break something as it is also disable in VTK/ITK.
1790 But it fasten debug compilation time.
1792 2003-10-23 Jean-Pierre Roux
1793 * gdcm now deals with 16 Bits Run Length Encoded images
1794 (they are compressed as 2 planes images,
1795 one for the high Bytes, the other for low Bytes)
1797 2003-10-22 Jean-Pierre Roux
1798 * Now CheckRead takes into account :
1799 - the bugged 'Leonardo' Siemens images
1800 - the XA images, sent thru the burning VPRO station
1801 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1804 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1805 * FIX: When copying a Makefile.am to CMakeLists.txt
1806 one should remove the '\'
1808 2003-10-22 Jean-Pierre Roux
1809 * in gdcmData adding a bugged 'Leonardo' Siemens image
1810 (wrong lengths in header)
1811 OK with gdcm, KO with the other viewers :-)
1812 * add a GE dlx XA image, thru the VEPRO burning station
1815 2003-10-21 Jean-Pierre Roux
1816 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1817 for a brutal checking of vtkgdcmViewer compliance
1819 2003-10-21 Jean-Pierre Roux
1820 * add the files for 'xmedcon' Jpeg Lossless library
1821 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1823 2003-10-21 Jean-Pierre Roux
1824 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1826 2003-10-21 Jean-Pierre Roux
1827 * garbage Siemens 'Leonardo' images dealt with
1828 (the patch is easy to remove)
1829 * cosmetic changes to avoid warnings
1831 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1832 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1833 no need to press 'r' now.
1835 2003-10-20 Jean-Pierre Roux
1836 * upgrade of checkRead.sh checkWrite.sh according
1837 to new Jpeg Lossless decompressor
1838 * add US.3405.1.dcm, a genuine RGB medical file ...
1839 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1840 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1842 2003-10-15 Jean-Pierre Roux
1843 * general anonymisation in gdcmData
1844 * adding the 'color files' from
1845 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1846 * adding some well knowed bugged-header images
1847 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1848 waiting for their inclusion in Python testsuite
1850 2003-10-15 Jean-Pierre Roux
1851 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1852 no longer seg faults when file is not found
1854 2003-10-14 Jean-Pierre Roux
1855 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1858 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1859 * TODO: *.in file to genereate a UseGDCM later
1861 2003-10-14 Jean-Pierre Roux
1862 * Some supposed-to-be Dicom Images have no preamble.
1863 OpenFile takes it into account
1864 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1865 * Missing elements added in dicomV3.dic
1866 (just to be affraid : have a look at
1867 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1868 and do it again next year ;->
1870 2003-10-13 Jean-Pierre Roux
1871 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1872 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1873 But there are NOT. It's fixed !
1875 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1876 * FIX: "jpeglib.h" was not found on VC++
1877 * FIX: vtkgdcm was not being installed
1879 2003-10-10 Jean-Pierre Roux
1880 * ENH : OpenFile closes the file if it *really* doesn't look like
1881 an ACR-NEMA / DICOM one.
1882 * FIX : testWrite no longer writes an empty file if the source file
1883 is not gdcm Readable
1884 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1887 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * FIX: CMake generate now documentation
1889 * ENH: out of source doc build !
1890 * ENH: Generate both user and dev documentation
1891 * ENH: Should work on windows too
1892 * ENH: Only one doxygen config.in file is needed
1893 * FIX: make install should be ok now on ùnix plateform
1894 * FIX: PATH to dictionary was wrong (missing /)
1895 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1897 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1898 * vtkGdcmReader is now able to read rgb dicom file.
1899 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1900 * added a gdcmViewer to vtk test, use mouse to control
1901 window level & window width
1903 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1904 * CMake-ification of gdcm, we have now two build system
1905 * FIX: on cygwin Wsock32 doesn't exist
1906 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1908 2003-10-06 Emanuel Ollart
1909 * FIX : compilation process wad broken.
1910 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1912 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1913 * change gdcmViewer -> vtkgdcmViewer
1914 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1916 2003-10-06 Jean-Pierre Roux
1917 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1918 ( e.g : well known GE images with a wrong elem length,
1919 : Philips MRI Images with a wrong Huffman table)
1920 * still to be done : allow the reading of bugged LEONARDO Siemens images
1922 2003-10-03 Jean-Pierre Roux
1923 * Odd length strings are padded with '\0' (not with spaces,
1924 to remain compliant with already defined strings,
1925 like Transfert Syntax UID and others)
1927 2003-10-03 Jean-Pierre Roux
1928 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1929 to allow displaying RGB images (not only by affim ;-)
1931 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1932 * vtkGdcmReader is now able to read rgb dicom file.
1933 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1935 2003-10-03 Jean-Pierre Roux
1936 * A few nasty patches to allow the reading of a lot of nasty images
1937 ( e.g : well known GE images with a wrong elem length,
1938 : Philips MRI Images with a wrong Huffman table)
1939 * still to be done : allow the reading of bugged LEONARDO Siemens images
1941 2003-10-03 Jean-Pierre Roux
1942 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1944 2003-10-03 Jean-Pierre Roux
1945 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1946 to allow displaying RGB images (not only by affim ;-)
1948 2003-10-03 Jean-Pierre Roux
1949 * gdcmFile::GetImageDataIntoVector now
1950 - deals with MultiFrames MultiFragments Run Length Encoded files
1951 - deals with YcBcR (YBR_FULL) files
1952 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1953 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1955 (no sample found :-(
1957 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1958 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1959 Two reasons: - clear things
1960 - third parties acces gdcm through header files, so won't
1961 suffer anymore VC++ complains
1963 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1964 * add argv[1] in testvtkGdcmReader.cxx
1967 2003-09-24 Jean-Pierre Roux
1968 * The lines are now eigthy characters long.for
1969 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1971 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1972 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1973 char* to std::string. Thus, the use of strdup becomes useless. (see
1974 previous commis of Malaterre)
1975 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1976 before the last Malaterre's commit.
1978 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1979 * This commit should fix the Debug building under VC++, the problem
1980 was mainly a mixture of debug and release lib being loaded at startup.
1981 * I also remove a depency to a specific C function: strdup. Because I had
1982 to force the link to msvcrtd (whereas strdup is in libc).
1984 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1985 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1986 located in the gdcmCommon.h file. All use of reference of tha has been
1987 changed to now use the variable GDCM_UNFOUND.
1989 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1991 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1992 Dicom dictionary. The test suite can now be run again. Note:
1993 I'm note very happy with the " (RET)" changes. I believe this
1994 RETAINED comment should be dropped when parsing the dictionary.
1995 - PACKAGER corrected
1997 - AUTHORS updated and now in alphabetical order
1998 * Makefile.am now exports gdcm.dsw for Windoze users.
2000 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2001 * cygwin complains about missing std:: in subdir Test/
2003 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2004 * remove some methods that are now in gdcmHeaderHelper
2006 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2007 * vtkGdcmReader set spacing and origin correctly
2009 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2010 * Fix a few delete/delete[] mismatch
2012 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2013 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2014 interpretation to data given by gdcmHeader. For instance there are
2015 heuristics to get informations (look at different places).
2016 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2017 sorting DICOM images based on different strategies.
2018 * modified Makefiles accordingly.
2020 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2022 when building in debug mode
2023 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2024 src/win32/gdcmdll.dsp
2025 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2027 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2028 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2031 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2032 * src/win32/libgdcmjpeg12.dsp was not dos format
2033 * src/win32/libgdcmjpeg12.dsp :
2034 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2035 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2037 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2038 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2040 * src/gdcmFile.cxx : bug fix in affectation type
2041 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2042 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2043 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2044 symbols... future problem ?
2046 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2047 * src/win32/libgdcmijpeg12.dsp was missing
2048 * modified gdcm.dsw accordingly
2050 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2051 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2053 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2054 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2055 commit of JPR (before his hollidays to facilitate our work).
2056 * setup.py : bug fix in code. Modifications made while the last commit
2057 of JPR. The code hasn't been tested before the commit... it's so
2058 useless to make that (for best programmer that is JPR) !!!
2060 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2061 * tagged the current version as Version0_3 (i.e. version 0.3)
2063 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2064 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2065 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2066 * *.dsp : modifications to use new libgdcmijpeg8 library
2067 * setup.py : bug fix on VTKPATH variable
2068 * PACKAGER : adding all concerning windows
2070 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2071 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2073 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2074 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2075 test suite reported error.
2076 * PACKAGER file added (describes what a packager must do when
2077 packaging a new release).
2078 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2079 * configure.in: upgraded version number to 0.3.0
2080 * fixing build of rpm (through rpm -ta):
2081 - Doc/Makefile.am exports proper doxygen files
2082 - src/jpeg/libijg8/Makefile.am exports the include files.
2084 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2085 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2086 * src/gdcmHeader.h : formatting code
2088 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2089 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2090 We were obtaining error message from vtk. Now, creation of file list
2091 is made in an internal list to prevent this problem.
2092 Bug fix when output is empty.
2093 Bug fix in update of progress value. Previous commit for this was a bad
2095 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2097 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2098 * src/gdcmHeader.h : added method to get the file name
2099 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2100 files. Added method to remove all files on the input
2101 Added FIXME comment concerning the bad parsing of header made by
2102 ExecuteInformation method (in ExecuteData method)
2104 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2105 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2106 when using make instal.
2107 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2108 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2110 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2111 * setup.py : adding include dir of jpeg lib to compile all sources
2112 * */Win32/*.dsp : JPR fix for windows compilation
2114 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2115 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2117 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2118 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2120 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * setup.py is again effective on un*x (takes into account the
2122 addon of the jpeg library)
2123 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2124 * Doc/Doxy* updated (includes above enhancements)
2125 * INSTALL now points to web documentation
2127 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * src/gdcmHeader.h doesn't make unnecessary reference to
2130 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2132 * src/gdcm*.[cxx|h] :
2133 - to allow compilation with gcc 3.x
2134 -- clean up of STL usage (added explicit usage of std::)
2135 -- small fixes on exceptions.
2136 Note: linking not tested !
2137 - clean of doxygen comments to avoid warnings at documentation
2139 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2140 dependent convertion).
2142 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2143 * Clean up of previous JPR garbage commit (not even commented in the
2145 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2146 - moved all jpeg related files from src to src/jpeg/libijg8, with
2147 addition/modification of Makefile.am and configure.in.
2148 - the testSuite is still brain damage (not guilty).
2150 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2151 * WrapVTK.py : modifications to get correctly vtk source files to
2153 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2154 (FileName -> Filename)
2156 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * vtk/vtkGdcmReader.[cxx/h]:
2158 - UpdateProgress method should now be effective
2159 - removed the limitation on having only images loaded (as opposed
2161 - when building a stack of images/volume, a lesser number of
2162 gdcmHeader and gdcmFile instances should be used (hopefully
2163 accelerating things).
2164 - when building a stack of images/volumes, files which are not
2165 loadable (wrong path-filename, wrong permissions on existing file,
2166 or file not parsable by gdcm) are replaced with a black image
2167 in the stack (for the caller to notice the problem).
2169 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2172 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2173 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2174 between standard library (std) and vtk library (problems are found
2175 under Windows... thanks Windows !)
2177 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2180 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2182 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2185 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2186 * When compiling with distutils (see setup.py) the C++ compiler is
2187 called with different flags than the default ones (with automake).
2188 In order to fix all those warning, I compiled gdcm with the command
2189 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2190 and went for warning fixes:
2191 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2192 up from unused variables.
2193 - vtk/vtkGdcmReader.cxx: potential bug fix.
2194 * src/gdcmHeader.h: Doxygen warning cleanup
2196 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2197 * gdcmPython/gdcm.i:
2198 - typemaps correction to take into account the systematic replacement
2199 of "using namespace std" with std:: prefix e.g. std::list,
2200 std::string... (cf changes of 2003-05-21).
2201 - gdcmGlob global variable of type gdcmGlobal (defined in
2202 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2203 exported to Python a as cvar.
2204 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2205 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2206 gdcmDictSet.GetPubDictTagNames() and
2207 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2208 C++ static methods).
2209 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2210 with the above changes.
2212 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2213 * setup.py, manifest.in : bug fix under linux
2215 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2216 * Modification of setup.py to compile vtk part too. Then, we have 2
2217 wrappers which must work with same distutils. For that, we have a
2218 generic distutils in distusiltsWrapping.py ; with :
2219 - build_extWrap class to wrap generically all extensions,
2220 - ExtensionWrap base class for all wrapping extension that contains
2222 - Wrapper interface which wrap sources
2223 + In WrapSwig.py we have extension and wrapper for Swig
2224 + In WrapVTK.py we have extension and wrapper for VTK
2225 * MANIFEST.in : modifications to consider vtk directory and new python
2226 files for compilation
2228 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2229 * Added python wrappers of vtkGdcmReader vtk class (see the
2230 source in vtk/vtkGdcmReader.cxx) :
2231 - vtk/Makefile.am now builds a library
2232 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2233 python library (as opposed to _gdcm.so wich are the python
2234 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2235 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2237 - configure.in has an additional flag --enable-vtk that needs
2238 to be set to enable compilation of vtk related code, that is:
2239 + vtk/vtkGdcmReader.so and
2240 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2241 + gdcmPython/vtkgdcmPython.so (see above)
2242 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2243 be read when compressed or when HighBit + 1 != BitsStored),
2244 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2245 the usage of the python wrapper of vtkGdcmReader vtk class.
2246 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2247 * src/*.[h] all occurences of stl classes are now prefixed with
2248 std::, and all occurences of "using namespace std;" where removed.
2249 This is to avoid pollution of global namespace in included files.
2250 Apparently vtk does not avoid this pitfall: when using both
2251 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2252 collision of various stl members (principally cout...).
2253 * gdcmPython/testSuite.py now cleanly removes temprory generated
2255 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2256 comply with above changes)
2258 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2259 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2260 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2261 vtk data structure (an image Flip was required).
2262 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2263 * cosmetic changes in documentation.
2265 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2266 * src/gdcmHeader.cxx: the constructor no longer exits when an
2267 unexisting file is given as argument.
2268 * The subdirectory Data (containing all the images used for the
2269 test suite) is not part of this repository anymore. A new module
2270 containing those images is now available at
2271 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2272 with the name gdcmData.
2273 All the python scripts (including the package initialisation file
2274 gdcmPython/__init__.py) were adapated to take this change into
2275 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2277 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2278 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2279 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2280 demo of the usage of this class.
2281 Compilation of this vtk part is only done when using the --enable-vtk
2282 at configure (or autogen.sh) stage.
2284 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2285 * More memory link related corrections and documentation fixes.
2287 - maximum info is obtained with a command of the form:
2288 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2289 --show-reachable=yes PrintHeader
2290 - the remaining reachable blocks seem to come from the STL
2291 allocation scheme through the usage of map and list. It looks
2292 like this memory cannot be freed but it is not a memory leak
2293 (in fact further invocation to the STL would recollect the
2294 unused memory allthough it cannot explicitely be freed).
2295 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2296 of displaying an image parsed with gdcm and displayed with VTK.
2297 Note: some images don't seem to work e.g.
2298 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2299 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2300 Allthough this weakens the semantics, it is a ditch attempt to
2301 make gdcm more thread friendly.
2303 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2304 * Memory link hunt (by using valgrind through the command
2305 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2306 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2307 gdcmHeader::_dicom_vr.
2308 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2309 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2311 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2313 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2314 * src/Makefile.am now exports all the necessary include files at
2318 * UpdateGroupLength replaced by new one
2321 * UpdateGroupLength re-written using H-Table
2322 (named UpdateGroupLengthNew untill checks are over)
2324 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2325 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2326 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2328 - gdcmHeader::GetPubElValSet removed.
2329 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2330 UpdateGroupLength, WriteElements, Write.
2331 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2332 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2333 carried the same semantics.
2334 - src/gdcmHeaderIdo.cxx changed accordingly.
2335 - gdcmFile::WriteBase now regroups all the codes from previous
2336 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2337 - enum FileType moved to gdcmCommon.h
2338 * src/gdcmHeader.cxx AddDefault trashed
2339 * gdcmGetXSize added
2340 * getimageDataSize now calls gdcmGetXSize
2341 * Test/*.cxx changed to agree with above changes
2343 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2345 (to avoid double call by end user).
2346 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2347 by end user, since gdcmHeader::gdcmHeader now handles it.
2349 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2350 * gdcm/Doc many doxygen changes:
2351 - Doxyfile now has two different versions, DoxyfileUsers that generates
2352 the html.users end users oriented documentation and
2353 DoxyfileDeveloppers that generates the html.developper developper
2354 oriented documentation.
2355 - README changed accordingly
2356 - requirement.txt removed (old design info moved to TODO).
2357 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2358 DoxyMainPage.txt, DoxyPython.txt provide more information.
2359 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2360 be updated by simply regenerating the docs with doxygen and copying
2361 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2362 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2363 all the tests in the form "if (<map>.count() >1)" were removed.
2364 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2365 ill-formed documentation sections.
2366 * src/gdcmHeader.cxx: ditto
2368 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2369 * setup.py fixed for un*x (needed macro for stdint.h)
2370 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2371 un*ces with sh-utils test utility.
2372 * gdcmPython/demo/test.py renamed to PrintHeader.py
2373 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2374 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2375 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2376 * src/gdcm*.cxx JPR's bad inclusion fixed.
2378 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2379 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2380 * gdcmPython/demo/test.py changed accordingly.
2382 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * gdcmPython/Makefile.am fixed linking against libstdc++
2384 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2385 * Swig subdir (historical tests of swig version 1.3.17++) removed
2386 * Test/testChangeEntete.cxx some lines commented out in order to make
2388 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2389 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2391 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2393 hence the user doesn't need this explicit call.
2394 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2395 i.e. LoadElements() call removed.
2396 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2397 - src/Makefile.am declares the proper flag for g++.
2398 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2399 for adding user defined new tags.
2400 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2401 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2402 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2404 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2405 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2406 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2407 src/Makefile.am : the project should properly compile and install
2408 with the autotools, included the python wrappers part.
2409 * gdcm.spec.in : added a spec file for RPM packaging.
2411 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2412 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2414 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2415 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2416 to exported to the environement (see gdcmPython/testSuite.py
2418 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2419 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2420 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2421 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2422 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2424 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * gdcmPython/__init__.py doesn't crash anymore when running in
2426 in InstallMode or PreInstallMode but with an environement given
2427 value of GDCM_DICT_PATH.
2428 * src/gdcmDictSet.[cxx/h] coding style.
2430 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2432 * src/gdcm.h general comments moved to TODO, and README
2433 * src/gdcm.h should now be seen as a user commodity (including it
2434 should suffice to fully use gdcm). It is nowhere including within
2435 any of the kernel files src/*.cxx and src/*.h.
2437 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2438 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2439 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2441 * src/gdcm*.cxx only include their corresponding include file
2442 (as opposed to gdcm.h)
2443 * gdcmPython/gdcm.i changed accordingly
2444 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2445 the autogen.sh generated "make snapshot" command to work.
2446 * autogen.sh removed history related references to crea package.
2448 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2449 * distutilsSwigCPlusPlus.py work around some swig portability
2452 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2454 was done in a last ditch attempt to get setup.py _really_
2455 operationnal. The python/gdcmPython layaout add the advantage
2456 of hidding away the python related distutils specific files
2457 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2458 Alas, the src directory was out of scope (i.e. it's relative
2459 position to setup.py was ../src) which made things impossible to
2460 handle (see previous version of python/setup.py). Crossing fingers...
2462 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2463 * python/setup.py now works on Un*x. (harder than I thougth)
2464 * python/distutilsSwigCPlusPlus.py can now have include files
2465 among the list of sources.
2467 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2468 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2469 * modifications in MSVC projects
2471 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2472 * As stated by the first lines of Test/ExceptionAndPython/README, it
2473 looks like we can move back to original usage of exception within
2474 src/gdcm* and hence remove the errno stuff that was introduced
2475 as a quick and dirty fixture of this problem (added to the TODO).
2476 * Doc/Doxyfile configuration file for Doxygen and corresponding
2477 README file for usage added.
2478 * Test/testWrite.cxx added. This new test comes from a split of
2479 test.cxx that is now reverted to its original purpous i.e.
2480 testing the proper parsing of a Dicom related file.
2481 testWrite.cxx concentrates on testing the IO part of gdcm.
2482 * Test/bug1.cxx (containing a bug on WIn32) added.
2483 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2484 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2485 whose purpose is to publish the content of the TagNames of the
2486 Dicom public dictionnary were not accessible without an
2487 instance of class gdcmHeader.
2488 - those methods are now static methods of gdcmDictSet and hence
2489 require no instances at all to be invocated.
2490 - within gdcmDictSet this change required to change some method
2491 to class methods (i.e. are now static) among which SetDictPath
2492 (renamed to BuildDictPath) and LoadDefaultPubDict.
2493 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2494 the above changes by calling the new method classes of gdcmDictSet.
2495 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2496 the above to be effective.
2497 * python/gdcmPython: in order to wrap properly the above changes
2498 for Python, swig version now needs to be > 1.3.17.
2499 * python/gdcmPython/Makefile fixed to adapt itself to new
2500 configure/make shema introduced by Johan Montagnat (thanks for the
2501 contribution). Alas this Makefile cannot be turned into a proper
2502 Makefile.am without some heavy changes in the configure.in
2503 (for python dectection).
2504 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2505 now avoids publishing the empty entries.
2507 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2508 * python/setup.py : bug fix concerning install under windows
2509 ExtraPath reused :-P
2510 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2512 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2513 * Dicts/dicomV3.dic : remove double spaces !!!
2514 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2515 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2518 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2519 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2520 method. Doxygenation.
2521 * src/gdcm.h clean up of JPR spurious comments.
2523 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * python/distutilsSwigCPlusPlus.py now properly collects the
2525 shadow classes generated by "swig -c++" (gdcm.py in our case)
2526 when using "python setup.py install".
2527 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2528 reexports the working classes.
2529 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2530 by the classical C errno scheme. This is to prevent an obscure
2531 behavior of the python wrappers when importing wxPython.wx prior
2532 to gdcmPython (which ended up in an abort call). An illustration
2533 of this oddity can be found in the Test/ExceptionAndPython
2534 subdir (see the README file). This problem probably due to
2535 an combination of g++ and dynamic loading.
2536 * added Test/ExceptionAndPython (see above)
2538 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2539 * Changed the layout of the python part to avoid bloating main
2540 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2541 i.e. the distutils arsenal. All the python related stuff is
2542 again in a python subdir, but the package itself is now in
2544 * setup.py was cleaned up:
2545 - pythonIncludePath removed
2546 - python setup.py bdist target is now functional.
2547 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2548 collision with other packages). gdcmPython/demo/*.py changed
2551 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * python subdir moved to gdcmPython (preparation of distutils packaging).
2553 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2554 distutils installer is operational.
2555 * - gdcmPython/__init__.py now properly loads the swig generated
2556 shadow classes (from gdcm.py).
2557 - gdcmPython/demo/*.py changed to import the package gdcmPython
2558 instead of gdcmPython/demo/load.py.
2559 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2561 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2562 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2563 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2564 entries within the associated public Dicom dictionary resp. the same
2565 information but sorted by the fourth field (PAT, IMG, DIR) of the
2567 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2568 are now in the "???" group.
2569 - python/gdcm.i changed accordingly,
2570 - python/demo/printGroupedPublicDict.py added, that gives an example
2571 of the above new functionalities in Python.
2573 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2574 * src/gdcm.h, gdcmHeader.cxx:
2575 - historic references to glib's g_malloc and g_free (#defined)
2576 were definitively removed.
2577 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2578 * src/gdcmElValSet.cxx:
2579 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2580 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2581 - GetElValue(string) renamed to GetElValueByName.
2582 - Added GetElementByName(string).
2583 * src/gdcmHeader.cxx: added
2584 - GetPubElValRepByNumber(guint16, guint16)
2585 - GetPubElValRepByName(string)
2586 - GetShaElValRepByNumber(guint16, guint16)
2587 - GetShaElValRepByName(string)
2588 - GetShaElValByNumber(guint16, guint16)
2589 - GetShaElValRepByName(string)
2590 - GetElValRepByNumber(guint16, guint16)
2591 - GetElValRepByName(string)
2592 - GetElValByNumber(guint16, guint16)
2593 - GetElValRepByName(string)
2594 * Doc/requirements.txt added.
2596 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2597 * Test/Makefile building now depends on the one of libgdcm.so
2598 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2599 pixel data) aware which enables finding the address (offset) of
2600 the pixel data of JPEG encoded DICOM files. This leaves only a single
2601 file in the testSuite whose pixel data address (offset) is unknown.
2602 * python/testSuite.py changed accordingly.
2604 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2605 * VC++ has some strong limitations when working with the STL, as stated
2606 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2607 "Also note that some STL containers (map, set, queue, list, deque)
2608 cannot be exported. [...]
2609 Some STL classes contain nested classes. These classes can not
2611 This is caused by a designed limitation that once a template
2612 class is instantiated, it can not be re-instantiated and
2614 Since our usage of map<> is ubiquitous in gdcm, this "designed
2615 limitation" of VC++ is a pitfall.
2616 Hence the Python wrappers of gdcm cannot be incrementally linked
2617 against the c++ dynamic library. The dirty but only workaround is
2618 to forget about incremental link of dynamic libraries and to generate
2619 the Python wrappers library with the inclusions of the underlying C++
2621 The following modifications concern this matter on Win32/VC++:
2622 - wrapping python correct with standalone wrapped dll (don't use separate
2623 dll under windows !!!!)
2624 - python21_d debug mode enabled (ask Frog how to use it :-)
2625 - NO problem with having an STL member of class for example string in C++
2626 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2627 - Python test of dcmlib in Python is ok under windows on a large set
2629 * removed glib references
2630 * typedef's inserted in gdcm.i for correct swig type management
2632 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * python/demo/*.py load.py extracted from test.py. Added explore.py
2634 that only displays required tags and testAll.py that parses all
2635 the files of the testsuite without using unittest.
2636 * python/testSuite.py other additional test on new files added.
2637 * Data/* new test files added accordingly to the testSuite.
2638 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2639 the vr in the file differs from the one of the dictionary.
2641 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2643 values, but limits itself to values which are below a user specified
2644 size (by default 1024 bytes).
2645 * python/gdcm.i : elements not loaded (because their size is above the
2646 user specified treshold) are exported with their TagKey as key of the
2647 python dictionary. This enables the testsuite to make some checks
2648 on the unloaded elements (since we have their offset and size).
2649 * python/testSuite.py
2650 - now tests for the existence and proper value of the pixel data
2651 - two new examples added.
2652 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2654 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2655 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2656 aware. See the strategy comments in gdcmHeader::FindeLength().
2657 * Test/test.cxx now accepts a filename as first argument.
2658 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2659 * python/testSuite.py changed to integrate test on above files.
2661 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2662 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2663 the vr was also RET.
2664 * python/testSuite.py more tests added.
2666 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2667 * python/testSuite.py unittest test suite added (uses Data)
2668 * Data/* dcm and acr files for the test suite.
2669 * glib dependance removed from un*x version. We now use ISO C99
2670 7.18 Integer types (see stdint.h)
2671 - python/Makefile, src/Makefile src/gdcm.h
2672 * src/ when an explicit vr (like dicom files) suddenly poped an
2673 implicit element we use to mark the underlying DictEntry of the
2674 concerned ElValue with "Implicit". This strategy was damageable
2675 too the public or provite dictionaries, since some of their vr
2676 would be changed. Since Header::FindLength heavily relies on the
2677 detection by Header::FindVR of falsely explicit elements, I
2678 added an extra ImplicitVr member to ElValue (boolean).
2679 The rest of the changes we the necessary adaptations.
2681 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2684 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2686 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2687 * Adaptation for porting to VC++:
2689 o forced to use std namespace (for string to be known)
2690 o all class use __declspec export style on WIN32
2691 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2692 (in stdlib.h on Win32 but in std:: for gcc)
2693 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2694 variable GDCM_DICT_PATH.
2695 * src/gdcmHeader.cxx verbose comments made discrete.
2697 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2698 * python/gdcm.i: added a typemap that converts a C++ hashing table
2699 to native Python dictionary.
2700 * python/demo/test.py:
2701 - now uses the native dictionary for exploration of gdcmHeader.
2702 - takes an optional filename argument (the file to parse).
2703 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2704 PubElVals hashing table.
2705 * Dicts/dicomV3.dic removed error prone trailing spaces.
2707 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * Python wrapping process moved away from src/Makefile to
2709 newly created python/Makefile (as well as gdcm.i)
2710 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2711 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2712 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2713 from the environement variable GDCM_DICT_PATH (when existing).
2714 * src/gdcmDict::GetTag bug fix.
2716 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2717 * Straightforward temporary fixes for swig to build the python wrappers.
2718 src/Makefile now has a python working entry [by working we mean
2719 that we can import de shadow classes without errors].
2721 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2722 * hashtest.cxx removed (since allready in Test)
2723 * src/gdcmlib.h renamed to src/gdcm.h
2724 * src/dcm.i renamed to src/gdcm.i
2725 * src/Makefile prepared for python wrapping
2727 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2728 * src/gdcmHeader.cxx :
2729 - Parsing of header is now separated from loading of element values
2730 (see gdcmHeader::LoadElements).
2731 - general clean up of hopefully all file access (creation of
2732 ReadInt16 and ReadInt32)
2734 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2735 * src/gdcmHeader.cxx :
2736 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2738 - SetLgrElem renamed to SetLength
2739 - GetLgrElem renamed to GetLength
2740 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2741 * src/gdcmElValSet.cxx fixed both GetElValue methods
2742 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2743 due to IdoDude was cleaned out.
2745 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2747 concentrates on finding the value representation (when it exists).
2748 RecupLgr now only finds the element value length, and it avoids
2749 returning the unecessary skL (skipped length).
2750 Also, offsetCourant was simply removed (with taille_fich) since
2751 it was redundant with the File position internals (by using
2752 ftell and fseek). This also made skL (see above in RecupLgr) usage
2754 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2755 on the libido specificities which are handled through class
2757 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2760 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * Truckload of changes. Parsing of header is barely functional
2762 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2764 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2765 * src/gdcmHeader.cxx many addons of low level methods
2767 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2769 and _IdDcmSWAP_LONG.
2771 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2772 * This corresponds to all the changes decided at the meeting of
2773 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob