1 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * In order to fix writing of dicom files:
3 - Test/TestWriteSimple.cxx: a simpler example of writing.
4 - Test/CMakeLists.txt changed accordingly.
5 - src/gdcmDocument.cxx:
6 -- The destructor now recursilvely removes potential sequences.
7 -- Bug fix in ::IsJPEG2000()
8 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
9 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
11 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
12 to only declared) and build on top of
13 ::GetDocEntryByNumber(guint16, guint16).
14 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
15 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
16 for usage in destructor and treatement of promotion in
17 ::ReplaceOrCreateByNumber().
18 - src/gdcmSQItem.cxx: destructor should better handle his job.
19 Test/TestWriteSimple now runs (or at least it DOES something).
20 * We can now start hutting memory links. A good starting point is:
21 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
22 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
23 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
25 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
26 * Valgrind note: after Mathieu Malaterre teached me how to read
27 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
29 Using gcc, you can force the STL to use malloc and to free memory as
30 soon as possible by globally disabling memory caching.
31 With 3.2.2 and later, you should export the environment variable
32 GLIBCPP_FORCE_NEW before running your program.
33 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
34 simply vanish (it is still not clear to me, whether this means that
35 STL std::string leaks or if valgrind believes it leaks...).
36 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
37 running bin/gdcmTests makeDicomDir):
38 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
39 - Test/makeDicomDir.cxx now properly traps empty lists and returns
41 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
42 SegFaulting (I drowned in DicomDir related code when trying to
43 understand why the list is empty...).
44 * src/gdcmDocument.h: first BSD license header try.
45 * Doc/License.txt added.
47 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
48 * src/gdcmDocument.[h|cxx]:
49 - Clean up of the Transfer related predicates. They are now all based
50 on new method isGivenTransferSyntax, that (should) handle properly
52 - general clean up, simplification, and coding style.
53 - Specific clean up of Parse7FE0() (umproperly named actually).
54 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
56 2004-06-14 Jean-Pierre Roux
58 - fix the display of Sequence Delimitor (SQDepthLevel pb)
59 - fix the display of SQItem ordinal number
60 - add the GetSQItemByOrdinalNumber method
61 - remove some useless never written private methods
63 2004-06-14 Jean-Pierre Roux
65 - adding a constructor taking a gdcmDocEntry as an input param
66 - ReplaceOrCreateByNumber now returns :
67 a gdcmBinEntry * if a Binary (void *) value is passed as a param
68 a gdcmValEntry * if a string value is passed as a param
70 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
71 according to the param type (no longer sets a gdcmDocEntry)
72 - GetValEntryByNumber, GetBinEntryByNumber added
73 - NewValEntryByNumber and NewBinEntryByNumber added
75 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
77 - GetSQItemNumber and SetSQItemNumber added, to provide
78 a (relative) Item identier inside a given Sequence
79 \warning : some pb remaining around this number
81 - AddEntry now takes the Item Number as a param
83 - adding a constructor taking a gdcmDocEntry as an input param
85 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
86 * Memory leak hunt with the following command:
87 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
88 --show-reachable=yes gdcmTests PrintDocument
89 It looks like many (all?) leaks are due to the STL (or a bad usage
90 of the STL. The lines producing the leaks now have a comment with
91 a "MEMORY LEAK" tag: you can retrieve them with
92 grep "MEMORY LEAK" src/*
93 Here are two typical examples which I can't help fixing:
99 name = test; //// <--- valgrind detects 960 bytes lost in
100 //// call to std::string::operator=(char const*)
101 name.clear(); //// Doesn't help !
109 std::cout << "Type a bunch of characters followed by RETURN: ";
110 getline(std::cin, line); //// <--- valgrind dectects a loss
111 //// of 1320 bytes in call to
112 /// std::basic_istream<>& std::getline<>
118 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
119 * src/gdcmHeader.[cxx|h]:
120 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
121 and related, moved away to gdcmDocument.
122 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
123 the corresponding protected accessors of inherited class
124 gdcmDocument, removed ! As a consequence gdcmFile had to be
125 declared friend of class gdcmDocument (see below).
126 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
127 - Clean up of undefined or unused methods.
128 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
129 account the changes to gdcmHeader.h).
130 * src/gdcmDocument.h:
131 - gdcmFile is now a friend class (in order to take into account the
132 changes to gdcmHeader.h).
133 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
134 (see changes to gdcmHeader.h).
135 - Accessors (reading on the form GetEntry*) are now public.
136 - Clean up of undefined or unused methods.
137 * src/gdcmDocument.cxx:
138 - adaptation to changes to gdcmDocument.h
139 - ::OpenFile now writes a verbose message when file cannot be opened.
140 - some std::string properly set to VRKey
141 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
142 references to gdcmDocument.
143 * Test/TestFindTags.cxx: changed accordingly to above changes.
144 * gdcmPython/testSuite.py: adapted to renaming of acr files in
145 cvs repository gdcmData.
147 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
148 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
149 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
150 conflicts with gdcmValEntry::voidArea.
151 * src/gdcmValEntry.cxx: unmatching comment wiped out.
152 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
153 Value representation between StringRepresentable and BinaryRepresentable.
154 * src/gdcmDocument.cxx:
155 - method ParseDES: proper indentation restored and usage of
156 gdcmVR::IsVROfGdcmStringRepresentable wired in.
157 - method LoadDocEntry: the fingerprint left in the SetValue() of
158 unloaded entries (length > MaxSizeLoadEntry) had curiously been
159 removed. Reverting to previous code segment with the proper
160 dynamic_cast< gdcmValEntry* >.
161 Note: this was (partially) breaking the python test suite
162 (gdcmPython/testSuite.py) that made usage of the above
163 fingerprint to check presence of "Pixel Data".
164 * src/gdcmDocEntry.h: coding style.
165 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
166 now taken into account.
167 * gdcmPython/gdcm.i: adaptation to the new internal representation
168 of gdcm (exit gdcmParser, hello gdcmDocument).
169 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
171 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
172 anymore, but instead prints the loaded Python dictionary.
173 * .... alas, the python testSuite is still broken.
175 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
178 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
179 * src/gdcmUtil.h : export methods
181 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
182 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
184 * Initial addition of automatic python testing
185 * Initial addition of automatic image comparison
187 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
189 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
191 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
193 * Test/ShowDicom.cxx : bug fix for msvc compilation
194 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
196 2004-05-04 Jean-Pierre Roux
197 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
198 new concepts (and new classes) :
199 a 'gdcmDocument' is composed of a set of Doc Entries, that are
200 - elementary gdcmDocEntries (former gdcmHeaderEntries)
201 - Sequence Doc Entries (gdcmSeqEntries)
202 a Sequence is composed of Items.
203 Each item is a set of Doc Entries (this is recursive)
204 The non uniqueness of the 'Dicom tag' is due to this recursivity
205 (never taken into account)
206 Our unability to add a new 'entry' in the header
207 at the proper location (neither in the H-Table (map or multimap),
208 nor in the Chained List is also due to this recursivity.
209 Don't try, right now, to use/modify/compile these new sources :
211 We just commit all the stuff, 'as is', in order not to loose it.
213 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
216 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
218 file prefix (SetFilePrefix)
220 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
221 * Add a new test: ShowDicom, for now this is just the c++ version of
222 checkRead.sh, later it will be able to compare the image read against a
224 * Replace the DEBUG on the stack with a global entry in cmake interface:
225 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
227 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
228 * Add an example subdir, with a real example on how to read + write a
231 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
232 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
233 * Doc/CMakeLists.txt: the main page is now properly differentiated
234 between the developper and user version.
235 * Doc/doxygen.config.in: dropped search related obsolete flags
236 * src/gdcmParser.h, gdcmHeader.h: doxygenation
238 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
239 * DEVELOPPER: added some helpfull comments for compile/test/install
242 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
243 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
244 src directory, now generated in the build dir.
245 2. Tests as mentionned smarter
247 4. Add a new method in gdcmDict that return the PubDict by name
248 this is interesting for 3rd party lib like ITK,
249 where we could set the institution name / patient name...
251 * ENH: 1. Now the test suite is working for real
252 2. All binaries are now output in the gdcm-bin directory
253 (this was not true before)
255 2004-04-28 Jean-Pierre Roux
256 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
257 SeQuence indented printing of Dicom Header.
258 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
259 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
260 Computation of SQDepthLevel is now part of gdcmHeader constructor
261 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
262 tree-like structure of a Dicom Header.
263 * FIX Test code cleaning
265 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
266 * ENH: Adding automatic testing
267 1. Need a DartConfig.cmake to submit to public
268 2. Add a test driver gdcmTest.cxx
269 3. gdcmTestMain, an helper for the main test driver gdcmTest
270 4. Files in Test don't have a main anymore, this becomes interesting
271 when we add more and more tests, thus dsw don't have to load
273 * ENH: Adding a GDCM_DATA_ROOT for testing
274 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
275 one file instead of seven + some small cleanup
277 2004-04-22 Jean-Pierre Roux
278 * ENH Minor changes to the Print() methods.
279 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
280 Header printing. Example given with :
281 > PrintHeader fileName 2 new
282 (SQ based tree-like structure still to be done for the Header ...)
284 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
285 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
286 1. I have added some unsigned where needed
287 2. Some function parameter not used -> (void)
288 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
289 4. g++ don't like character '\' in comment
290 5. #define jpeg_create_decompress jCreaDecompress
291 this really need to be fixed
292 6. virtualize destructor of gdcmObject ... leakage
293 7. sscanf(g->first.c_str(),"%x",&gr_bid);
294 this also really need to be fixed
295 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
296 remove compression file
297 (as we only do decompression, right ?)
298 * ENH: Change malloc/calloc/free with c++ equivalent
300 2004-04-21 Jean-Pierre Roux
301 * FIX gdcmHeaderHelper::GetXSpacing
302 when a single value is found (bug ?), xpacing is now
303 defaulted to yspacing
305 2004-04-19 Jean-Pierre Roux
306 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
307 * ENH add parameters :
308 bool exception_on_error = false,
309 bool enable_sequences = false,
310 bool ignore_shadow = false
311 to the gdcmFile constructors to be full gdcmParser compliant
312 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
313 to allow reading of PAPYRUS 3.0 files
315 2004-04-06 Jean-Pierre Roux
316 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
318 2004-04-02 Jean-Pierre Roux
319 * ADD : Test/checksequence.sh, for a general recap on SQ pb
320 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
321 for Philips spurious Tag fffe|0000 while rewritting Dicom files
323 2004-03-30 Jean-Pierre Roux
324 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
325 for ACR file, written out as DICOM files (hope so...)
327 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
328 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
329 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
330 moved to base class gdcmParser and only the specialisation is kept
332 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
333 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
334 already does the job.
335 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
336 (to be consistent with gdcmParser::WriteEntries).
338 2004-03-30 Benoit Regrain
339 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
340 upate of the object's instance. It's passed to 2 in the unfavorable
341 case : one in the ExecuteInformation, one in the ExecuteData
343 2004-03-29 Jean-Pierre Roux
344 * ENH : Check on file type to be written moved
345 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
346 * FIX : gdcmObject::ResetBoundaries now stops properly
347 when end-of-list is reached
348 : gdcmVersion modified (as Benoit Regrain asked)
350 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
351 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
352 * src/gdcmUtil.cxx: added forgotten iostream include.
353 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
354 equivalent to ExplicitVR in existing code).
356 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
357 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
358 now contains all the gdcmGlobal related code.
359 * minor coding style and doxygenation changes.
361 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
362 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
363 now contains all the Debug related code.
364 * minor clean-up of includes in src/*.cxx
365 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
366 CreateCleanString) removed.
367 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
368 * Doc/DoxyMainPageUser.txt added.
369 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
370 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
373 2004-03-24 Jean-Pierre Roux
374 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
376 2004-03-23 Jean-Pierre Roux
377 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
378 big endian made volumes
379 * ENH Now gdcmParser constructor and destructor are protected to forbid
380 end user to instanciate class gdcmParser
381 (only gdcmHeader and gdcmDicomDir are meaningfull)
383 2004-03-22 Benoit Regrain
384 * FIX : src/gdcmDicomDir.cxx : make windows compilable
385 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
386 gdcmSerie to gdcmDicomDirSerie
388 2004-03-19 Jean-Pierre Roux
389 * ENH Now the tree-like structure describing a DICOMDIR comming from
390 an already existing DICOMDIR file is consistent with
391 the home-made tree-like structure build ex-nihilo
392 or build from the files held (recursively) in a Directory
393 functions gdcmDicomDir::CheckBoundaries()
394 gdcmObject::SetBoundaries() added
396 2004-03-17 Jean-Pierre Roux
397 * REM (Eric Boix bug) : removal of meaningless
398 gdcmDicomDirImage::NewImage function.
399 * FIX now file names and directory name are written properly in the
401 * FIX now gdcmDicomDir constructor may be call without any trick
404 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
406 of gdcmDicomDirImage::NewImage as empty function.
408 2004-02-28 Jean-Pierre Roux
409 * ENH add gdcmDicomDir:NewPatient
410 add gdcmDicomDirPatient:NewStudy
411 add gdcmDicomDirStudy:NewSerie
412 add gdcmDicomDirSerie:NewImage
413 to allow making gdcDicomDir object.
414 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
415 (as opposite to the gdcmHeader chained list)
417 2004-02-11 Benoit Regrain
418 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
419 when using from python
421 2004-02-10 Benoit Regrain
422 * FIX : bug fix in the gdcmDirList for the recursivity in directories
423 * FIX : in gdcmDicomDir when the directory is empty
424 * ENH : add callback and methods to get the progression of dicomDir
427 2004-02-06 Jean-Pierre Roux
428 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
429 - GDCM_META added to gdcmDicomDirType
430 - class gdcmMeta created
431 * ENH : - A brief summary is now displayed at the beginning of
432 'testDicomDir' to help disaster magnitude estimation
433 * REM : Now useless Test/explDICOMDIR.cxx
435 2004-02-05 Benoit Regrain
436 * ENH : add methods in gdcmObject to get the hash table or the list of
438 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
439 * FIX : wrapping python for TagHeaderEntryHT
441 2004-02-04 Benoit Regrain
442 * FIX : even length for some strings when writting the dicom dir
443 * FIX : sort the images in the dicom dir
444 * FIX : Bug fix for python use of dicom dir
445 * ADD : a python demo
447 2004-02-04 Jean-Pierre Roux
448 * FIX : Final solution (?) for icone embedded images
449 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
450 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
451 add groups 6002, 6004, 6006, to allow 'clean' parsing of
452 gdcmData/gdcm-MR-SIEMENS-16.acr1
453 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
454 to make full checking easier
456 2004-02-04 Benoit Regrain
457 * FIX : WriteEntries : coding style & logic in parameters
458 * FIX : Set the elements to create the DicomDir in a dictionary file
460 2004-02-03 Benoit Regrain
461 * gdcmDirList : to parse a hard drive directory in recursive (or not)
462 * gdcmDicomDir : add the load of directory
463 * Bug fix and print add-on
465 2004-02-03 Jean-Pierre Roux
466 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
467 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
468 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
469 * FIX gdcmParser.cxx : 'group length' elements are now considered
470 as integers, even for shadow groups, when file is Implicit VR
472 2004-02-02 Jean-Pierre Roux
473 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
475 of the last synonym :-(
476 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
478 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
479 * FIX taking into account the possible 7fe0,0010 multiplicity
480 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
481 to allow removal of references to 7fe0,0010, to deal with
482 ACR-NEMA images, when 0028,0200 is meaningfull
484 2004-01-31 Jean-Pierre Roux
485 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
486 no longer writes 'Un' on disk
487 * FIX SQ elements with actual length are now dealt with corectly
488 * FIX gdcmFile::WriteBase make the difference, for color images, between
489 the length (for Palette expanded images)
490 and Raw Length (non expanded image + Palette)
491 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
492 (that broke Write). Replaced by UL.
493 Aware user will reload the field if he
494 thinks it's necesssary
496 2004-01-30 Jean-Pierre Roux
497 * gdcmParser::CheckSwap() now defaults the filetype to ACR
498 when 'dirty Acr' is found, to be compliant with the new
499 IsReadable() methods.
501 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
502 (no DOUBLE images in kosher DICOM,
503 but so usefull for people that miss them ;-)
505 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
506 DICOMDIR related utilities (not checked as Windoze compliant)
508 2004-01-28 Jean-Pierre Roux
509 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
511 2004-01-27 Jean-Pierre Roux
512 * gdcmParser constructor has a new boolean param,'ignore_shadow',
513 to allow skipping the shadow elements, to save memory space.
514 The TRUE value for this param has to be used
515 with a FALSE value for the 'enable_sequence' param.
516 ('public elements' may be embedded in 'shadow Sequences')
517 * gdcmHeader methods now deal with 'embedded icones images' in the header
518 (even when an 'icone image sequence' is announced by the
519 element (0x0088,0x0200), but there is NO icone at all ...
521 * gdcmHeader sometimes Image Location value doesn't follow
522 the supposed processor endianity (see gdcmData/cr172241.dcm).
525 * gdcmHeader add the method
526 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
527 to get *all* the Header Entries with the same tag.
528 GetHeaderEntrySameName is probabely *useless*
529 (no meaning : Name is *not* an identifier within the Dictionnary)
531 2004-01-26 Benoit Regrain
532 * Bug fix in the print of hexadecimal representations. Remove long fields
533 in the print and add a third level of print to print them
535 2004-01-23 Benoit Regrain
536 * Bug fix on field having a VR = 'UI'. Assume that is a string field
537 * Bug fix on test suite after remove the strip made on not string fields
538 * Split the IsReadable method between gdcmParser which test that the file
539 is dicom and gdcmHeader which test that it's an image file
541 2004-01-22 Benoit Regrain
542 * DicomDir : clean code, add methods, set variables in protected or private
543 * gdcmUtil : bug fix for the clean string method
545 2004-01-19 Benoit Regrain
546 * Add the use of shadow dictionaries
547 * bug fix and coding style
549 2004-01-19 Benoit Regrain
550 * src/gdcmFile.cxx : bug fix concerning the close of file
551 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
552 * Add the update of header entries using the shadow library
554 2004-01-19 Benoit Regrain
555 * removal of file gdcmHeader2.cxx
556 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
557 inheriting from gdcmParser. This split is to prepare the integration
559 * bug fix under python
561 2004-01-16 Jean-Pierre Roux
562 * REM removal of class gdcmHeaderEntrySet
563 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
564 * ADD add file gdcmHeader2.cxx
565 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
567 2004-01-15 Benoit Regrain
568 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
569 entries created while parsing the header. Thus, they will be destroyed
570 when the gdcmDictSet will be destroyed
571 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
574 2004-01-15 Benoit Regrain
575 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
576 made a fatal error because of the memory release at the end of program.
577 The problem was in vtkGdcmReader::ExecuteData where we were allocate
578 some memory and vtk seems to have some problems with that.
579 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
581 2004-01-14 Benoit Regrain
582 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
583 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
584 * src/*.[h|cxx] : make changes due to class name changes
585 * gdcmPython/demo/*.py : bug fix due to method names
587 2004-01-13 Benoit Regrain
588 * src/*.[h|cxx] : coding style
589 * vtk/*.[h|cxx] : coding style
591 2004-01-13 Benoit Regrain
592 * gdcmPython/testSuite.py : test the readable flag of file for tests
593 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
594 It's lied to the stl compilation by MSVC (windows, always windows...)
595 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
597 2004-01-12 Benoit Regrain
598 * src/*.h : add comments
599 * src/gdcmDictSet.h : set the method BuildDictPath in public
600 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
601 directly setted in the source code
602 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
605 2004-01-09 Benoit Regrain
606 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
607 * setup.py : use a reference to gdcmVERSION
609 2004-01-07 Benoit Regrain
610 * Modification to compile with the distutils.
613 2003-12-10 Benoit Regrain
614 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
615 can use a gdcmHeaderHelper to load datas
616 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
617 made in the source code
619 2003-12-10 Benoit Regrain
620 * Update Windows projects and .cvsignore files
622 2003-11-12 Jean-Pierre Roux
623 * ENH gdcmHeader constructor has one more parameter (default value : false)
624 that allows the user to 'go inside' the SeQuences only
626 gdcmElValSet:Print takes it into account
628 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
629 * ENH: Update gdcmPython/CMakeLists
630 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
631 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
633 2003-11-10 Jean-Pierre Roux
634 * FIX : gdcmHeader::LoadElements is now based
635 on the ListTag listElem member,
636 not longer on the TagElValueHT tagHt member
637 * ENH : PrintPubElVal shows (temporarily) both results,
638 with the tagHt member and the listElem member.
639 (it's easier to 'see' the problems when using Printheader)
641 * FIX : old private member LgrElem is now splitted into
642 ReadLength : Length actually found on disk (updated only
643 if bug fixing is necessary), for internal
645 UsableLength : Updated by FixFoundLength, to fix a bug
646 or to allow Parser going on.
647 Will allow to re-write a kosher header when a SeQuence
648 with a length (not 0000) is found
649 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
650 because gdcmElValSet::Add does not update ListElem
653 2003-11-07 Jean-Pierre Roux
654 * FIX misstyping in Transfert Syntax name table
655 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
656 when they have an actual length (not 0000 nor FFFFF)
657 (Nobody should care of it, but DICOMDIR explorers)
659 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
660 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
662 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
663 * ENH: vtkGdcmReader now supports LUT !
664 (vtkgdcmViewer for now is not able to use them though)
666 2003-11-05 Jean-Pierre Roux
667 * in testSuite.py : new files names for checking the package
668 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
669 that returns the pixel area size to the *aware* (vtk) user
670 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
672 2003-11-05 Benoit Regrain
673 * in testSuite.py : Modify the rules for checking the paths
674 : Explicit error messages
675 * in __init__.py : Related modif
677 2003-11-03 Jean-Pierre Roux
678 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
679 to be used by aware (vtk) users that want to manage
680 LUT (and no to turn the PALETTE image into an RGB pixels one)
681 * GetPixelType now returns 8U for 24 Bits images
682 (vtkGdcmReader compliant)
684 2003-10-31 Jean-Pierre Roux
685 * Removal of *all* gdcmData images and add them again
686 in order to loose the 'history' of un-anonymised images
688 2003-10-31 Jean-Pierre Roux
689 * RMV : removal of useless jBitsInJsample.h
690 for both 8 and 12 Bits JPEG Lossy Libraries
692 2003-10-31 Jean-Pierre Roux
693 * ENH : Add the functions gdcmFile::GetImageDataRaw
694 gdcmFile::GetImageDataIntoVectorRaw
695 that act as GetImageData and GetImageDataIntoVector
696 except the making of an RGB Plane from Gray Plane + LUT
697 Intended to aware (vtk) users who know how to manage
700 GetLUTRGBA return a R,G,B,A LUT if any
701 lgrTotaleRaw gives the 'Raw' length
702 GetImageDataRaw returns the gray Plane
703 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
704 (They stay Grey, just like with other Dicom viewers :-(
706 2003-10-30 Jean-Pierre Roux
707 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
709 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
710 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
711 being coherents dicom files.
713 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
714 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
716 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
717 * ENH: Two steps is necessary to please VC++ compiler...
718 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
719 * ENH: Add include dir to medcon lib
720 * FIX: only one function is being exported for now !
721 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
723 2003-10-29 Jean-Pierre Roux
724 * adding gdcmHeader::GetLUTRGBA
725 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
726 --> Mathieu, the modif u're waiting for is not yet committed
727 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
729 2003-10-27 Jean-Pierre Roux
730 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
731 00191113.dcm DermaColorLossLess.dcm
732 MxTwinLossLess.dcm RadBWLossLess.dcm
733 * ENH: For version prior to vtkImageViewer2 -r 1.19
734 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
736 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
737 * Removal of ido stuff in CMakeLists.txt
739 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
740 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
741 * FIX: remove a call to ->Modified ... see comments
742 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
744 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
745 * FIX: Problem with path for libvtkgdcmPython
746 * ENH: Try adding a search script for python site-package
747 * RMV: Remove some file from medcon lib that are not necessary
748 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
749 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
750 * FIX: More pragma disable fro VC++,
751 I don't think I break something as it is also disable in VTK/ITK.
752 But it fasten debug compilation time.
754 2003-10-23 Jean-Pierre Roux
755 * gdcm now deals with 16 Bits Run Length Encoded images
756 (they are compressed as 2 planes images,
757 one for the high Bytes, the other for low Bytes)
759 2003-10-22 Jean-Pierre Roux
760 * Now CheckRead takes into account :
761 - the bugged 'Leonardo' Siemens images
762 - the XA images, sent thru the burning VPRO station
763 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
766 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
767 * FIX: When copying a Makefile.am to CMakeLists.txt
768 one should remove the '\'
770 2003-10-22 Jean-Pierre Roux
771 * in gdcmData adding a bugged 'Leonardo' Siemens image
772 (wrong lengths in header)
773 OK with gdcm, KO with the other viewers :-)
774 * add a GE dlx XA image, thru the VEPRO burning station
777 2003-10-21 Jean-Pierre Roux
778 * in gdcmData add the checkvtkgdcmViewer.sh shell script
779 for a brutal checking of vtkgdcmViewer compliance
781 2003-10-21 Jean-Pierre Roux
782 * add the files for 'xmedcon' Jpeg Lossless library
783 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
785 2003-10-21 Jean-Pierre Roux
786 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
788 2003-10-21 Jean-Pierre Roux
789 * garbage Siemens 'Leonardo' images dealt with
790 (the patch is easy to remove)
791 * cosmetic changes to avoid warnings
793 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
794 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
795 no need to press 'r' now.
797 2003-10-20 Jean-Pierre Roux
798 * upgrade of checkRead.sh checkWrite.sh according
799 to new Jpeg Lossless decompressor
800 * add US.3405.1.dcm, a genuine RGB medical file ...
801 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
802 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
804 2003-10-15 Jean-Pierre Roux
805 * general anonymisation in gdcmData
806 * adding the 'color files' from
807 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
808 * adding some well knowed bugged-header images
809 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
810 waiting for their inclusion in Python testsuite
812 2003-10-15 Jean-Pierre Roux
813 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
814 no longer seg faults when file is not found
816 2003-10-14 Jean-Pierre Roux
817 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
820 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
821 * TODO: *.in file to genereate a UseGDCM later
823 2003-10-14 Jean-Pierre Roux
824 * Some supposed-to-be Dicom Images have no preamble.
825 OpenFile takes it into account
826 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
827 * Missing elements added in dicomV3.dic
828 (just to be affraid : have a look at
829 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
830 and do it again next year ;->
832 2003-10-13 Jean-Pierre Roux
833 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
834 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
835 But there are NOT. It's fixed !
837 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
838 * FIX: "jpeglib.h" was not found on VC++
839 * FIX: vtkgdcm was not being installed
841 2003-10-10 Jean-Pierre Roux
842 * ENH : OpenFile closes the file if it *really* doesn't look like
843 an ACR-NEMA / DICOM one.
844 * FIX : testWrite no longer writes an empty file if the source file
846 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
849 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
850 * FIX: CMake generate now documentation
851 * ENH: out of source doc build !
852 * ENH: Generate both user and dev documentation
853 * ENH: Should work on windows too
854 * ENH: Only one doxygen config.in file is needed
855 * FIX: make install should be ok now on ùnix plateform
856 * FIX: PATH to dictionary was wrong (missing /)
857 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
859 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
860 * vtkGdcmReader is now able to read rgb dicom file.
861 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
862 * added a gdcmViewer to vtk test, use mouse to control
863 window level & window width
865 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
866 * CMake-ification of gdcm, we have now two build system
867 * FIX: on cygwin Wsock32 doesn't exist
868 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
870 2003-10-06 Emanuel Ollart
871 * FIX : compilation process wad broken.
872 Changed gdcmViewer_sources to vtkgdcmViewer_sources
874 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
875 * change gdcmViewer -> vtkgdcmViewer
876 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
878 2003-10-06 Jean-Pierre Roux
879 * FIX :A few nasty patches to allow the reading of a lot of nasty images
880 ( e.g : well known GE images with a wrong elem length,
881 : Philips MRI Images with a wrong Huffman table)
882 * still to be done : allow the reading of bugged LEONARDO Siemens images
884 2003-10-03 Jean-Pierre Roux
885 * Odd length strings are padded with '\0' (not with spaces,
886 to remain compliant with already defined strings,
887 like Transfert Syntax UID and others)
889 2003-10-03 Jean-Pierre Roux
890 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
891 to allow displaying RGB images (not only by affim ;-)
893 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
894 * vtkGdcmReader is now able to read rgb dicom file.
895 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
897 2003-10-03 Jean-Pierre Roux
898 * A few nasty patches to allow the reading of a lot of nasty images
899 ( e.g : well known GE images with a wrong elem length,
900 : Philips MRI Images with a wrong Huffman table)
901 * still to be done : allow the reading of bugged LEONARDO Siemens images
903 2003-10-03 Jean-Pierre Roux
904 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
906 2003-10-03 Jean-Pierre Roux
907 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
908 to allow displaying RGB images (not only by affim ;-)
910 2003-10-03 Jean-Pierre Roux
911 * gdcmFile::GetImageDataIntoVector now
912 - deals with MultiFrames MultiFragments Run Length Encoded files
913 - deals with YcBcR (YBR_FULL) files
914 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
915 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
919 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
920 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
921 Two reasons: - clear things
922 - third parties acces gdcm through header files, so won't
923 suffer anymore VC++ complains
925 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
926 * add argv[1] in testvtkGdcmReader.cxx
929 2003-09-24 Jean-Pierre Roux
930 * The lines are now eigthy characters long.for
931 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
933 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
934 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
935 char* to std::string. Thus, the use of strdup becomes useless. (see
936 previous commis of Malaterre)
937 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
938 before the last Malaterre's commit.
940 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
941 * This commit should fix the Debug building under VC++, the problem
942 was mainly a mixture of debug and release lib being loaded at startup.
943 * I also remove a depency to a specific C function: strdup. Because I had
944 to force the link to msvcrtd (whereas strdup is in libc).
946 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
947 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
948 located in the gdcmCommon.h file. All use of reference of tha has been
949 changed to now use the variable GDCM_UNFOUND.
951 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
953 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
954 Dicom dictionary. The test suite can now be run again. Note:
955 I'm note very happy with the " (RET)" changes. I believe this
956 RETAINED comment should be dropped when parsing the dictionary.
959 - AUTHORS updated and now in alphabetical order
960 * Makefile.am now exports gdcm.dsw for Windoze users.
962 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
963 * cygwin complains about missing std:: in subdir Test/
965 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
966 * remove some methods that are now in gdcmHeaderHelper
968 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
969 * vtkGdcmReader set spacing and origin correctly
971 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
972 * Fix a few delete/delete[] mismatch
974 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
975 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
976 interpretation to data given by gdcmHeader. For instance there are
977 heuristics to get informations (look at different places).
978 * it also include a specific class: gdcmSerieHeaderHelper devoted to
979 sorting DICOM images based on different strategies.
980 * modified Makefiles accordingly.
982 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
983 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
984 when building in debug mode
985 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
986 src/win32/gdcmdll.dsp
987 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
989 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
990 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
993 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
994 * src/win32/libgdcmjpeg12.dsp was not dos format
995 * src/win32/libgdcmjpeg12.dsp :
996 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
997 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
999 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1000 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1002 * src/gdcmFile.cxx : bug fix in affectation type
1003 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1004 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1005 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1006 symbols... future problem ?
1008 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1009 * src/win32/libgdcmijpeg12.dsp was missing
1010 * modified gdcm.dsw accordingly
1012 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1013 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1015 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1016 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1017 commit of JPR (before his hollidays to facilitate our work).
1018 * setup.py : bug fix in code. Modifications made while the last commit
1019 of JPR. The code hasn't been tested before the commit... it's so
1020 useless to make that (for best programmer that is JPR) !!!
1022 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1023 * tagged the current version as Version0_3 (i.e. version 0.3)
1025 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1026 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1027 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1028 * *.dsp : modifications to use new libgdcmijpeg8 library
1029 * setup.py : bug fix on VTKPATH variable
1030 * PACKAGER : adding all concerning windows
1032 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1035 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1036 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1037 test suite reported error.
1038 * PACKAGER file added (describes what a packager must do when
1039 packaging a new release).
1040 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1041 * configure.in: upgraded version number to 0.3.0
1042 * fixing build of rpm (through rpm -ta):
1043 - Doc/Makefile.am exports proper doxygen files
1044 - src/jpeg/libijg8/Makefile.am exports the include files.
1046 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1047 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1048 * src/gdcmHeader.h : formatting code
1050 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1051 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1052 We were obtaining error message from vtk. Now, creation of file list
1053 is made in an internal list to prevent this problem.
1054 Bug fix when output is empty.
1055 Bug fix in update of progress value. Previous commit for this was a bad
1057 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1059 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1060 * src/gdcmHeader.h : added method to get the file name
1061 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1062 files. Added method to remove all files on the input
1063 Added FIXME comment concerning the bad parsing of header made by
1064 ExecuteInformation method (in ExecuteData method)
1066 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1068 when using make instal.
1069 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1070 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1072 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1073 * setup.py : adding include dir of jpeg lib to compile all sources
1074 * */Win32/*.dsp : JPR fix for windows compilation
1076 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1077 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1079 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1080 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1082 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1083 * setup.py is again effective on un*x (takes into account the
1084 addon of the jpeg library)
1085 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1086 * Doc/Doxy* updated (includes above enhancements)
1087 * INSTALL now points to web documentation
1089 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * src/gdcmHeader.h doesn't make unnecessary reference to
1092 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1094 * src/gdcm*.[cxx|h] :
1095 - to allow compilation with gcc 3.x
1096 -- clean up of STL usage (added explicit usage of std::)
1097 -- small fixes on exceptions.
1098 Note: linking not tested !
1099 - clean of doxygen comments to avoid warnings at documentation
1101 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1102 dependent convertion).
1104 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1105 * Clean up of previous JPR garbage commit (not even commented in the
1107 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1108 - moved all jpeg related files from src to src/jpeg/libijg8, with
1109 addition/modification of Makefile.am and configure.in.
1110 - the testSuite is still brain damage (not guilty).
1112 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1113 * WrapVTK.py : modifications to get correctly vtk source files to
1115 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1116 (FileName -> Filename)
1118 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * vtk/vtkGdcmReader.[cxx/h]:
1120 - UpdateProgress method should now be effective
1121 - removed the limitation on having only images loaded (as opposed
1123 - when building a stack of images/volume, a lesser number of
1124 gdcmHeader and gdcmFile instances should be used (hopefully
1125 accelerating things).
1126 - when building a stack of images/volumes, files which are not
1127 loadable (wrong path-filename, wrong permissions on existing file,
1128 or file not parsable by gdcm) are replaced with a black image
1129 in the stack (for the caller to notice the problem).
1131 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1134 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1135 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1136 between standard library (std) and vtk library (problems are found
1137 under Windows... thanks Windows !)
1139 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1142 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1144 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1145 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1147 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1148 * When compiling with distutils (see setup.py) the C++ compiler is
1149 called with different flags than the default ones (with automake).
1150 In order to fix all those warning, I compiled gdcm with the command
1151 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1152 and went for warning fixes:
1153 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1154 up from unused variables.
1155 - vtk/vtkGdcmReader.cxx: potential bug fix.
1156 * src/gdcmHeader.h: Doxygen warning cleanup
1158 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1159 * gdcmPython/gdcm.i:
1160 - typemaps correction to take into account the systematic replacement
1161 of "using namespace std" with std:: prefix e.g. std::list,
1162 std::string... (cf changes of 2003-05-21).
1163 - gdcmGlob global variable of type gdcmGlobal (defined in
1164 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1165 exported to Python a as cvar.
1166 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1167 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1168 gdcmDictSet.GetPubDictTagNames() and
1169 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1170 C++ static methods).
1171 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1172 with the above changes.
1174 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1175 * setup.py, manifest.in : bug fix under linux
1177 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1178 * Modification of setup.py to compile vtk part too. Then, we have 2
1179 wrappers which must work with same distutils. For that, we have a
1180 generic distutils in distusiltsWrapping.py ; with :
1181 - build_extWrap class to wrap generically all extensions,
1182 - ExtensionWrap base class for all wrapping extension that contains
1184 - Wrapper interface which wrap sources
1185 + In WrapSwig.py we have extension and wrapper for Swig
1186 + In WrapVTK.py we have extension and wrapper for VTK
1187 * MANIFEST.in : modifications to consider vtk directory and new python
1188 files for compilation
1190 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1191 * Added python wrappers of vtkGdcmReader vtk class (see the
1192 source in vtk/vtkGdcmReader.cxx) :
1193 - vtk/Makefile.am now builds a library
1194 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1195 python library (as opposed to _gdcm.so wich are the python
1196 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1197 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1199 - configure.in has an additional flag --enable-vtk that needs
1200 to be set to enable compilation of vtk related code, that is:
1201 + vtk/vtkGdcmReader.so and
1202 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1203 + gdcmPython/vtkgdcmPython.so (see above)
1204 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1205 be read when compressed or when HighBit + 1 != BitsStored),
1206 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1207 the usage of the python wrapper of vtkGdcmReader vtk class.
1208 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1209 * src/*.[h] all occurences of stl classes are now prefixed with
1210 std::, and all occurences of "using namespace std;" where removed.
1211 This is to avoid pollution of global namespace in included files.
1212 Apparently vtk does not avoid this pitfall: when using both
1213 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1214 collision of various stl members (principally cout...).
1215 * gdcmPython/testSuite.py now cleanly removes temprory generated
1217 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1218 comply with above changes)
1220 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1221 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1222 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1223 vtk data structure (an image Flip was required).
1224 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1225 * cosmetic changes in documentation.
1227 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1228 * src/gdcmHeader.cxx: the constructor no longer exits when an
1229 unexisting file is given as argument.
1230 * The subdirectory Data (containing all the images used for the
1231 test suite) is not part of this repository anymore. A new module
1232 containing those images is now available at
1233 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1234 with the name gdcmData.
1235 All the python scripts (including the package initialisation file
1236 gdcmPython/__init__.py) were adapated to take this change into
1237 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1239 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1240 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1241 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1242 demo of the usage of this class.
1243 Compilation of this vtk part is only done when using the --enable-vtk
1244 at configure (or autogen.sh) stage.
1246 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1247 * More memory link related corrections and documentation fixes.
1249 - maximum info is obtained with a command of the form:
1250 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1251 --show-reachable=yes PrintHeader
1252 - the remaining reachable blocks seem to come from the STL
1253 allocation scheme through the usage of map and list. It looks
1254 like this memory cannot be freed but it is not a memory leak
1255 (in fact further invocation to the STL would recollect the
1256 unused memory allthough it cannot explicitely be freed).
1257 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1258 of displaying an image parsed with gdcm and displayed with VTK.
1259 Note: some images don't seem to work e.g.
1260 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1261 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1262 Allthough this weakens the semantics, it is a ditch attempt to
1263 make gdcm more thread friendly.
1265 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1266 * Memory link hunt (by using valgrind through the command
1267 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1268 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1269 gdcmHeader::_dicom_vr.
1270 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1271 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1273 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1275 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1276 * src/Makefile.am now exports all the necessary include files at
1280 * UpdateGroupLength replaced by new one
1283 * UpdateGroupLength re-written using H-Table
1284 (named UpdateGroupLengthNew untill checks are over)
1286 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1287 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1288 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1290 - gdcmHeader::GetPubElValSet removed.
1291 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1292 UpdateGroupLength, WriteElements, Write.
1293 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1294 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1295 carried the same semantics.
1296 - src/gdcmHeaderIdo.cxx changed accordingly.
1297 - gdcmFile::WriteBase now regroups all the codes from previous
1298 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1299 - enum FileType moved to gdcmCommon.h
1300 * src/gdcmHeader.cxx AddDefault trashed
1301 * gdcmGetXSize added
1302 * getimageDataSize now calls gdcmGetXSize
1303 * Test/*.cxx changed to agree with above changes
1305 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1306 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1307 (to avoid double call by end user).
1308 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1309 by end user, since gdcmHeader::gdcmHeader now handles it.
1311 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1312 * gdcm/Doc many doxygen changes:
1313 - Doxyfile now has two different versions, DoxyfileUsers that generates
1314 the html.users end users oriented documentation and
1315 DoxyfileDeveloppers that generates the html.developper developper
1316 oriented documentation.
1317 - README changed accordingly
1318 - requirement.txt removed (old design info moved to TODO).
1319 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1320 DoxyMainPage.txt, DoxyPython.txt provide more information.
1321 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1322 be updated by simply regenerating the docs with doxygen and copying
1323 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1324 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1325 all the tests in the form "if (<map>.count() >1)" were removed.
1326 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1327 ill-formed documentation sections.
1328 * src/gdcmHeader.cxx: ditto
1330 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1331 * setup.py fixed for un*x (needed macro for stdint.h)
1332 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1333 un*ces with sh-utils test utility.
1334 * gdcmPython/demo/test.py renamed to PrintHeader.py
1335 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1336 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1337 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1338 * src/gdcm*.cxx JPR's bad inclusion fixed.
1340 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1341 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1342 * gdcmPython/demo/test.py changed accordingly.
1344 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1345 * gdcmPython/Makefile.am fixed linking against libstdc++
1346 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1347 * Swig subdir (historical tests of swig version 1.3.17++) removed
1348 * Test/testChangeEntete.cxx some lines commented out in order to make
1350 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1351 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1353 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1354 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1355 hence the user doesn't need this explicit call.
1356 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1357 i.e. LoadElements() call removed.
1358 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1359 - src/Makefile.am declares the proper flag for g++.
1360 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1361 for adding user defined new tags.
1362 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1363 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1364 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1366 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1367 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1368 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1369 src/Makefile.am : the project should properly compile and install
1370 with the autotools, included the python wrappers part.
1371 * gdcm.spec.in : added a spec file for RPM packaging.
1373 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1374 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1376 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1377 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1378 to exported to the environement (see gdcmPython/testSuite.py
1380 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1381 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1382 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1383 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1384 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1386 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1387 * gdcmPython/__init__.py doesn't crash anymore when running in
1388 in InstallMode or PreInstallMode but with an environement given
1389 value of GDCM_DICT_PATH.
1390 * src/gdcmDictSet.[cxx/h] coding style.
1392 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1393 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1394 * src/gdcm.h general comments moved to TODO, and README
1395 * src/gdcm.h should now be seen as a user commodity (including it
1396 should suffice to fully use gdcm). It is nowhere including within
1397 any of the kernel files src/*.cxx and src/*.h.
1399 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1400 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1401 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1403 * src/gdcm*.cxx only include their corresponding include file
1404 (as opposed to gdcm.h)
1405 * gdcmPython/gdcm.i changed accordingly
1406 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1407 the autogen.sh generated "make snapshot" command to work.
1408 * autogen.sh removed history related references to crea package.
1410 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1411 * distutilsSwigCPlusPlus.py work around some swig portability
1414 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1415 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1416 was done in a last ditch attempt to get setup.py _really_
1417 operationnal. The python/gdcmPython layaout add the advantage
1418 of hidding away the python related distutils specific files
1419 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1420 Alas, the src directory was out of scope (i.e. it's relative
1421 position to setup.py was ../src) which made things impossible to
1422 handle (see previous version of python/setup.py). Crossing fingers...
1424 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1425 * python/setup.py now works on Un*x. (harder than I thougth)
1426 * python/distutilsSwigCPlusPlus.py can now have include files
1427 among the list of sources.
1429 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1430 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1431 * modifications in MSVC projects
1433 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1434 * As stated by the first lines of Test/ExceptionAndPython/README, it
1435 looks like we can move back to original usage of exception within
1436 src/gdcm* and hence remove the errno stuff that was introduced
1437 as a quick and dirty fixture of this problem (added to the TODO).
1438 * Doc/Doxyfile configuration file for Doxygen and corresponding
1439 README file for usage added.
1440 * Test/testWrite.cxx added. This new test comes from a split of
1441 test.cxx that is now reverted to its original purpous i.e.
1442 testing the proper parsing of a Dicom related file.
1443 testWrite.cxx concentrates on testing the IO part of gdcm.
1444 * Test/bug1.cxx (containing a bug on WIn32) added.
1445 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1446 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1447 whose purpose is to publish the content of the TagNames of the
1448 Dicom public dictionnary were not accessible without an
1449 instance of class gdcmHeader.
1450 - those methods are now static methods of gdcmDictSet and hence
1451 require no instances at all to be invocated.
1452 - within gdcmDictSet this change required to change some method
1453 to class methods (i.e. are now static) among which SetDictPath
1454 (renamed to BuildDictPath) and LoadDefaultPubDict.
1455 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1456 the above changes by calling the new method classes of gdcmDictSet.
1457 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1458 the above to be effective.
1459 * python/gdcmPython: in order to wrap properly the above changes
1460 for Python, swig version now needs to be > 1.3.17.
1461 * python/gdcmPython/Makefile fixed to adapt itself to new
1462 configure/make shema introduced by Johan Montagnat (thanks for the
1463 contribution). Alas this Makefile cannot be turned into a proper
1464 Makefile.am without some heavy changes in the configure.in
1465 (for python dectection).
1466 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1467 now avoids publishing the empty entries.
1469 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1470 * python/setup.py : bug fix concerning install under windows
1471 ExtraPath reused :-P
1472 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1474 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1475 * Dicts/dicomV3.dic : remove double spaces !!!
1476 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1477 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1480 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1481 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1482 method. Doxygenation.
1483 * src/gdcm.h clean up of JPR spurious comments.
1485 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1486 * python/distutilsSwigCPlusPlus.py now properly collects the
1487 shadow classes generated by "swig -c++" (gdcm.py in our case)
1488 when using "python setup.py install".
1489 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1490 reexports the working classes.
1491 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1492 by the classical C errno scheme. This is to prevent an obscure
1493 behavior of the python wrappers when importing wxPython.wx prior
1494 to gdcmPython (which ended up in an abort call). An illustration
1495 of this oddity can be found in the Test/ExceptionAndPython
1496 subdir (see the README file). This problem probably due to
1497 an combination of g++ and dynamic loading.
1498 * added Test/ExceptionAndPython (see above)
1500 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1501 * Changed the layout of the python part to avoid bloating main
1502 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1503 i.e. the distutils arsenal. All the python related stuff is
1504 again in a python subdir, but the package itself is now in
1506 * setup.py was cleaned up:
1507 - pythonIncludePath removed
1508 - python setup.py bdist target is now functional.
1509 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1510 collision with other packages). gdcmPython/demo/*.py changed
1513 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1514 * python subdir moved to gdcmPython (preparation of distutils packaging).
1515 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1516 distutils installer is operational.
1517 * - gdcmPython/__init__.py now properly loads the swig generated
1518 shadow classes (from gdcm.py).
1519 - gdcmPython/demo/*.py changed to import the package gdcmPython
1520 instead of gdcmPython/demo/load.py.
1521 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1523 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1524 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1525 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1526 entries within the associated public Dicom dictionary resp. the same
1527 information but sorted by the fourth field (PAT, IMG, DIR) of the
1529 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1530 are now in the "???" group.
1531 - python/gdcm.i changed accordingly,
1532 - python/demo/printGroupedPublicDict.py added, that gives an example
1533 of the above new functionalities in Python.
1535 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1536 * src/gdcm.h, gdcmHeader.cxx:
1537 - historic references to glib's g_malloc and g_free (#defined)
1538 were definitively removed.
1539 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1540 * src/gdcmElValSet.cxx:
1541 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1542 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1543 - GetElValue(string) renamed to GetElValueByName.
1544 - Added GetElementByName(string).
1545 * src/gdcmHeader.cxx: added
1546 - GetPubElValRepByNumber(guint16, guint16)
1547 - GetPubElValRepByName(string)
1548 - GetShaElValRepByNumber(guint16, guint16)
1549 - GetShaElValRepByName(string)
1550 - GetShaElValByNumber(guint16, guint16)
1551 - GetShaElValRepByName(string)
1552 - GetElValRepByNumber(guint16, guint16)
1553 - GetElValRepByName(string)
1554 - GetElValByNumber(guint16, guint16)
1555 - GetElValRepByName(string)
1556 * Doc/requirements.txt added.
1558 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1559 * Test/Makefile building now depends on the one of libgdcm.so
1560 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1561 pixel data) aware which enables finding the address (offset) of
1562 the pixel data of JPEG encoded DICOM files. This leaves only a single
1563 file in the testSuite whose pixel data address (offset) is unknown.
1564 * python/testSuite.py changed accordingly.
1566 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1567 * VC++ has some strong limitations when working with the STL, as stated
1568 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1569 "Also note that some STL containers (map, set, queue, list, deque)
1570 cannot be exported. [...]
1571 Some STL classes contain nested classes. These classes can not
1573 This is caused by a designed limitation that once a template
1574 class is instantiated, it can not be re-instantiated and
1576 Since our usage of map<> is ubiquitous in gdcm, this "designed
1577 limitation" of VC++ is a pitfall.
1578 Hence the Python wrappers of gdcm cannot be incrementally linked
1579 against the c++ dynamic library. The dirty but only workaround is
1580 to forget about incremental link of dynamic libraries and to generate
1581 the Python wrappers library with the inclusions of the underlying C++
1583 The following modifications concern this matter on Win32/VC++:
1584 - wrapping python correct with standalone wrapped dll (don't use separate
1585 dll under windows !!!!)
1586 - python21_d debug mode enabled (ask Frog how to use it :-)
1587 - NO problem with having an STL member of class for example string in C++
1588 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1589 - Python test of dcmlib in Python is ok under windows on a large set
1591 * removed glib references
1592 * typedef's inserted in gdcm.i for correct swig type management
1594 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1595 * python/demo/*.py load.py extracted from test.py. Added explore.py
1596 that only displays required tags and testAll.py that parses all
1597 the files of the testsuite without using unittest.
1598 * python/testSuite.py other additional test on new files added.
1599 * Data/* new test files added accordingly to the testSuite.
1600 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1601 the vr in the file differs from the one of the dictionary.
1603 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1604 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1605 values, but limits itself to values which are below a user specified
1606 size (by default 1024 bytes).
1607 * python/gdcm.i : elements not loaded (because their size is above the
1608 user specified treshold) are exported with their TagKey as key of the
1609 python dictionary. This enables the testsuite to make some checks
1610 on the unloaded elements (since we have their offset and size).
1611 * python/testSuite.py
1612 - now tests for the existence and proper value of the pixel data
1613 - two new examples added.
1614 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1616 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1618 aware. See the strategy comments in gdcmHeader::FindeLength().
1619 * Test/test.cxx now accepts a filename as first argument.
1620 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1621 * python/testSuite.py changed to integrate test on above files.
1623 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1625 the vr was also RET.
1626 * python/testSuite.py more tests added.
1628 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1629 * python/testSuite.py unittest test suite added (uses Data)
1630 * Data/* dcm and acr files for the test suite.
1631 * glib dependance removed from un*x version. We now use ISO C99
1632 7.18 Integer types (see stdint.h)
1633 - python/Makefile, src/Makefile src/gdcm.h
1634 * src/ when an explicit vr (like dicom files) suddenly poped an
1635 implicit element we use to mark the underlying DictEntry of the
1636 concerned ElValue with "Implicit". This strategy was damageable
1637 too the public or provite dictionaries, since some of their vr
1638 would be changed. Since Header::FindLength heavily relies on the
1639 detection by Header::FindVR of falsely explicit elements, I
1640 added an extra ImplicitVr member to ElValue (boolean).
1641 The rest of the changes we the necessary adaptations.
1643 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1646 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1648 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1649 * Adaptation for porting to VC++:
1651 o forced to use std namespace (for string to be known)
1652 o all class use __declspec export style on WIN32
1653 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1654 (in stdlib.h on Win32 but in std:: for gcc)
1655 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1656 variable GDCM_DICT_PATH.
1657 * src/gdcmHeader.cxx verbose comments made discrete.
1659 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * python/gdcm.i: added a typemap that converts a C++ hashing table
1661 to native Python dictionary.
1662 * python/demo/test.py:
1663 - now uses the native dictionary for exploration of gdcmHeader.
1664 - takes an optional filename argument (the file to parse).
1665 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1666 PubElVals hashing table.
1667 * Dicts/dicomV3.dic removed error prone trailing spaces.
1669 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1670 * Python wrapping process moved away from src/Makefile to
1671 newly created python/Makefile (as well as gdcm.i)
1672 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1673 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1674 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1675 from the environement variable GDCM_DICT_PATH (when existing).
1676 * src/gdcmDict::GetTag bug fix.
1678 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1679 * Straightforward temporary fixes for swig to build the python wrappers.
1680 src/Makefile now has a python working entry [by working we mean
1681 that we can import de shadow classes without errors].
1683 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1684 * hashtest.cxx removed (since allready in Test)
1685 * src/gdcmlib.h renamed to src/gdcm.h
1686 * src/dcm.i renamed to src/gdcm.i
1687 * src/Makefile prepared for python wrapping
1689 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1690 * src/gdcmHeader.cxx :
1691 - Parsing of header is now separated from loading of element values
1692 (see gdcmHeader::LoadElements).
1693 - general clean up of hopefully all file access (creation of
1694 ReadInt16 and ReadInt32)
1696 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1697 * src/gdcmHeader.cxx :
1698 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1700 - SetLgrElem renamed to SetLength
1701 - GetLgrElem renamed to GetLength
1702 - ~gdcmHeader() made virtual to pesky warning messages at compile.
1703 * src/gdcmElValSet.cxx fixed both GetElValue methods
1704 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
1705 due to IdoDude was cleaned out.
1707 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1708 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
1709 concentrates on finding the value representation (when it exists).
1710 RecupLgr now only finds the element value length, and it avoids
1711 returning the unecessary skL (skipped length).
1712 Also, offsetCourant was simply removed (with taille_fich) since
1713 it was redundant with the File position internals (by using
1714 ftell and fseek). This also made skL (see above in RecupLgr) usage
1716 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
1717 on the libido specificities which are handled through class
1719 * Test/implicit_vr.dcm dicom v3 in implicit value representation
1722 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1723 * Truckload of changes. Parsing of header is barely functional
1724 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
1726 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1727 * src/gdcmHeader.cxx many addons of low level methods
1729 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1730 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
1731 and _IdDcmSWAP_LONG.
1733 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1734 * This corresponds to all the changes decided at the meeting of
1735 May 23 2002. Needless to say we are running late...