1 2004-06-14 Jean-Pierre Roux
3 - adding a constructor taking a gdcmDocEntry as an input param
4 - ReplaceOrCreateByNumber now returns :
5 a gdcmBinEntry * if a Binary (void *) value is passed as a param
6 a gdcmValEntry * if a string value is passed as a param
8 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
9 according to the param type (no longer sets a gdcmDocEntry)
10 - GetValEntryByNumber, GetBinEntryByNumber added
11 - NewValEntryByNumber and NewBinEntryByNumber added
13 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
15 - GetSQItemNumber and SetSQItemNumber added, to provide
16 a (relative) Item identier inside a given Sequence
17 \warning : some pb remaining around this number
19 - AddEntry now takes the Item Number as a param
21 - adding a constructor taking a gdcmDocEntry as an input param
24 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * Memory leak hunt with the following command:
26 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
27 --show-reachable=yes gdcmTests PrintDocument
28 It looks like many (all?) leaks are due to the STL (or a bad usage
29 of the STL. The lines producing the leaks now have a comment with
30 a "MEMORY LEAK" tag: you can retrieve them with
31 grep "MEMORY LEAK" src/*
32 Here are two typical examples which I can't help fixing:
38 name = test; //// <--- valgrind detects 960 bytes lost in
39 //// call to std::string::operator=(char const*)
40 name.clear(); //// Doesn't help !
48 std::cout << "Type a bunch of characters followed by RETURN: ";
49 getline(std::cin, line); //// <--- valgrind dectects a loss
50 //// of 1320 bytes in call to
51 /// std::basic_istream<>& std::getline<>
57 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * src/gdcmHeader.[cxx|h]:
59 - Predicates on the Transfer syntax (of the form Is[JPEF|RLE]*)
60 and related, moved away to gdcmDocument.
61 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
62 the corresponding protected accessors of inherited class
63 gdcmDocument, removed ! As a consequence gdcmFile had to be
64 declared friend of class gdcmDocument (see below).
65 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
66 - Clean up of undefined or unused methods.
67 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
68 account the changes to gdcmHeader.h).
70 - gdcmFile is now a friend class (in order to take into account the
71 changes to gdcmHeader.h).
72 - Predicates on the Transfer syntax (of the form Is[JPEF|RLE]*) added
73 (see changes to gdcmHeader.h).
74 - Accessors (reading on the form GetEntry*) are now public.
75 - Clean up of undefined or unused methods.
76 * src/gdcmDocument.cxx:
77 - adaptation to changes to gdcmDocument.h
78 - ::OpenFile now writes a verbose message when file cannot be opened.
79 - some std::string properly set to VRKey
80 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
81 references to gdcmDocument.
82 * Test/TestFindTags.cxx: changed accordingly to above changes.
83 * gdcmPython/testSuite.py: adapted to renaming of acr files in
84 cvs repository gdcmData.
86 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
88 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
89 conflicts with gdcmValEntry::voidArea.
90 * src/gdcmValEntry.cxx: unmatching comment wiped out.
91 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
92 Value representation between StringRepresentable and BinaryRepresentable.
93 * src/gdcmDocument.cxx:
94 - method ParseDES: proper indentation restored and usage of
95 gdcmVR::IsVROfGdcmStringRepresentable wired in.
96 - method LoadDocEntry: the fingerprint left in the SetValue() of
97 unloaded entries (length > MaxSizeLoadEntry) had curiously been
98 removed. Reverting to previous code segment with the proper
99 dynamic_cast< gdcmValEntry* >.
100 Note: this was (partially) breaking the python test suite
101 (gdcmPython/testSuite.py) that made usage of the above
102 fingerprint to check presence of "Pixel Data".
103 * src/gdcmDocEntry.h: coding style.
104 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
105 now taken into account.
106 * gdcmPython/gdcm.i: adaptation to the new internal representation
107 of gdcm (exit gdcmParser, hello gdcmDocument).
108 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
110 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
111 anymore, but instead prints the loaded Python dictionary.
112 * .... alas, the python testSuite is still broken.
114 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
117 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
118 * src/gdcmUtil.h : export methods
120 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
121 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
123 * Initial addition of automatic python testing
124 * Initial addition of automatic image comparison
126 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
128 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
130 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
132 * Test/ShowDicom.cxx : bug fix for msvc compilation
133 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
135 2004-05-04 Jean-Pierre Roux
136 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
137 new concepts (and new classes) :
138 a 'gdcmDocument' is composed of a set of Doc Entries, that are
139 - elementary gdcmDocEntries (former gdcmHeaderEntries)
140 - Sequence Doc Entries (gdcmSeqEntries)
141 a Sequence is composed of Items.
142 Each item is a set of Doc Entries (this is recursive)
143 The non uniqueness of the 'Dicom tag' is due to this recursivity
144 (never taken into account)
145 Our unability to add a new 'entry' in the header
146 at the proper location (neither in the H-Table (map or multimap),
147 nor in the Chained List is also due to this recursivity.
148 Don't try, right now, to use/modify/compile these new sources :
150 We just commit all the stuff, 'as is', in order not to loose it.
152 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
155 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
157 file prefix (SetFilePrefix)
159 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
160 * Add a new test: ShowDicom, for now this is just the c++ version of
161 checkRead.sh, later it will be able to compare the image read against a
163 * Replace the DEBUG on the stack with a global entry in cmake interface:
164 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
166 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
167 * Add an example subdir, with a real example on how to read + write a
170 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
171 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
172 * Doc/CMakeLists.txt: the main page is now properly differentiated
173 between the developper and user version.
174 * Doc/doxygen.config.in: dropped search related obsolete flags
175 * src/gdcmParser.h, gdcmHeader.h: doxygenation
177 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
178 * DEVELOPPER: added some helpfull comments for compile/test/install
181 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
182 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
183 src directory, now generated in the build dir.
184 2. Tests as mentionned smarter
186 4. Add a new method in gdcmDict that return the PubDict by name
187 this is interesting for 3rd party lib like ITK,
188 where we could set the institution name / patient name...
190 * ENH: 1. Now the test suite is working for real
191 2. All binaries are now output in the gdcm-bin directory
192 (this was not true before)
194 2004-04-28 Jean-Pierre Roux
195 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
196 SeQuence indented printing of Dicom Header.
197 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
198 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
199 Computation of SQDepthLevel is now part of gdcmHeader constructor
200 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
201 tree-like structure of a Dicom Header.
202 * FIX Test code cleaning
204 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
205 * ENH: Adding automatic testing
206 1. Need a DartConfig.cmake to submit to public
207 2. Add a test driver gdcmTest.cxx
208 3. gdcmTestMain, an helper for the main test driver gdcmTest
209 4. Files in Test don't have a main anymore, this becomes interesting
210 when we add more and more tests, thus dsw don't have to load
212 * ENH: Adding a GDCM_DATA_ROOT for testing
213 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
214 one file instead of seven + some small cleanup
216 2004-04-22 Jean-Pierre Roux
217 * ENH Minor changes to the Print() methods.
218 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
219 Header printing. Example given with :
220 > PrintHeader fileName 2 new
221 (SQ based tree-like structure still to be done for the Header ...)
223 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
224 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
225 1. I have added some unsigned where needed
226 2. Some function parameter not used -> (void)
227 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
228 4. g++ don't like character '\' in comment
229 5. #define jpeg_create_decompress jCreaDecompress
230 this really need to be fixed
231 6. virtualize destructor of gdcmObject ... leakage
232 7. sscanf(g->first.c_str(),"%x",&gr_bid);
233 this also really need to be fixed
234 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
235 remove compression file
236 (as we only do decompression, right ?)
237 * ENH: Change malloc/calloc/free with c++ equivalent
239 2004-04-21 Jean-Pierre Roux
240 * FIX gdcmHeaderHelper::GetXSpacing
241 when a single value is found (bug ?), xpacing is now
242 defaulted to yspacing
244 2004-04-19 Jean-Pierre Roux
245 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
246 * ENH add parameters :
247 bool exception_on_error = false,
248 bool enable_sequences = false,
249 bool ignore_shadow = false
250 to the gdcmFile constructors to be full gdcmParser compliant
251 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
252 to allow reading of PAPYRUS 3.0 files
254 2004-04-06 Jean-Pierre Roux
255 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
257 2004-04-02 Jean-Pierre Roux
258 * ADD : Test/checksequence.sh, for a general recap on SQ pb
259 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
260 for Philips spurious Tag fffe|0000 while rewritting Dicom files
262 2004-03-30 Jean-Pierre Roux
263 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
264 for ACR file, written out as DICOM files (hope so...)
266 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
268 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
269 moved to base class gdcmParser and only the specialisation is kept
271 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
272 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
273 already does the job.
274 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
275 (to be consistent with gdcmParser::WriteEntries).
277 2004-03-30 Benoit Regrain
278 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
279 upate of the object's instance. It's passed to 2 in the unfavorable
280 case : one in the ExecuteInformation, one in the ExecuteData
282 2004-03-29 Jean-Pierre Roux
283 * ENH : Check on file type to be written moved
284 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
285 * FIX : gdcmObject::ResetBoundaries now stops properly
286 when end-of-list is reached
287 : gdcmVersion modified (as Benoit Regrain asked)
289 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
290 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
291 * src/gdcmUtil.cxx: added forgotten iostream include.
292 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
293 equivalent to ExplicitVR in existing code).
295 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
296 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
297 now contains all the gdcmGlobal related code.
298 * minor coding style and doxygenation changes.
300 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
301 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
302 now contains all the Debug related code.
303 * minor clean-up of includes in src/*.cxx
304 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
305 CreateCleanString) removed.
306 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
307 * Doc/DoxyMainPageUser.txt added.
308 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
309 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
312 2004-03-24 Jean-Pierre Roux
313 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
315 2004-03-23 Jean-Pierre Roux
316 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
317 big endian made volumes
318 * ENH Now gdcmParser constructor and destructor are protected to forbid
319 end user to instanciate class gdcmParser
320 (only gdcmHeader and gdcmDicomDir are meaningfull)
322 2004-03-22 Benoit Regrain
323 * FIX : src/gdcmDicomDir.cxx : make windows compilable
324 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
325 gdcmSerie to gdcmDicomDirSerie
327 2004-03-19 Jean-Pierre Roux
328 * ENH Now the tree-like structure describing a DICOMDIR comming from
329 an already existing DICOMDIR file is consistent with
330 the home-made tree-like structure build ex-nihilo
331 or build from the files held (recursively) in a Directory
332 functions gdcmDicomDir::CheckBoundaries()
333 gdcmObject::SetBoundaries() added
335 2004-03-17 Jean-Pierre Roux
336 * REM (Eric Boix bug) : removal of meaningless
337 gdcmDicomDirImage::NewImage function.
338 * FIX now file names and directory name are written properly in the
340 * FIX now gdcmDicomDir constructor may be call without any trick
343 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
344 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
345 of gdcmDicomDirImage::NewImage as empty function.
347 2004-02-28 Jean-Pierre Roux
348 * ENH add gdcmDicomDir:NewPatient
349 add gdcmDicomDirPatient:NewStudy
350 add gdcmDicomDirStudy:NewSerie
351 add gdcmDicomDirSerie:NewImage
352 to allow making gdcDicomDir object.
353 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
354 (as opposite to the gdcmHeader chained list)
356 2004-02-11 Benoit Regrain
357 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
358 when using from python
360 2004-02-10 Benoit Regrain
361 * FIX : bug fix in the gdcmDirList for the recursivity in directories
362 * FIX : in gdcmDicomDir when the directory is empty
363 * ENH : add callback and methods to get the progression of dicomDir
366 2004-02-06 Jean-Pierre Roux
367 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
368 - GDCM_META added to gdcmDicomDirType
369 - class gdcmMeta created
370 * ENH : - A brief summary is now displayed at the beginning of
371 'testDicomDir' to help disaster magnitude estimation
372 * REM : Now useless Test/explDICOMDIR.cxx
374 2004-02-05 Benoit Regrain
375 * ENH : add methods in gdcmObject to get the hash table or the list of
377 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
378 * FIX : wrapping python for TagHeaderEntryHT
380 2004-02-04 Benoit Regrain
381 * FIX : even length for some strings when writting the dicom dir
382 * FIX : sort the images in the dicom dir
383 * FIX : Bug fix for python use of dicom dir
384 * ADD : a python demo
386 2004-02-04 Jean-Pierre Roux
387 * FIX : Final solution (?) for icone embedded images
388 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
389 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
390 add groups 6002, 6004, 6006, to allow 'clean' parsing of
391 gdcmData/gdcm-MR-SIEMENS-16.acr1
392 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
393 to make full checking easier
395 2004-02-04 Benoit Regrain
396 * FIX : WriteEntries : coding style & logic in parameters
397 * FIX : Set the elements to create the DicomDir in a dictionary file
399 2004-02-03 Benoit Regrain
400 * gdcmDirList : to parse a hard drive directory in recursive (or not)
401 * gdcmDicomDir : add the load of directory
402 * Bug fix and print add-on
404 2004-02-03 Jean-Pierre Roux
405 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
406 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
407 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
408 * FIX gdcmParser.cxx : 'group length' elements are now considered
409 as integers, even for shadow groups, when file is Implicit VR
411 2004-02-02 Jean-Pierre Roux
412 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
414 of the last synonym :-(
415 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
417 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
418 * FIX taking into account the possible 7fe0,0010 multiplicity
419 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
420 to allow removal of references to 7fe0,0010, to deal with
421 ACR-NEMA images, when 0028,0200 is meaningfull
423 2004-01-31 Jean-Pierre Roux
424 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
425 no longer writes 'Un' on disk
426 * FIX SQ elements with actual length are now dealt with corectly
427 * FIX gdcmFile::WriteBase make the difference, for color images, between
428 the length (for Palette expanded images)
429 and Raw Length (non expanded image + Palette)
430 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
431 (that broke Write). Replaced by UL.
432 Aware user will reload the field if he
433 thinks it's necesssary
435 2004-01-30 Jean-Pierre Roux
436 * gdcmParser::CheckSwap() now defaults the filetype to ACR
437 when 'dirty Acr' is found, to be compliant with the new
438 IsReadable() methods.
440 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
441 (no DOUBLE images in kosher DICOM,
442 but so usefull for people that miss them ;-)
444 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
445 DICOMDIR related utilities (not checked as Windoze compliant)
447 2004-01-28 Jean-Pierre Roux
448 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
450 2004-01-27 Jean-Pierre Roux
451 * gdcmParser constructor has a new boolean param,'ignore_shadow',
452 to allow skipping the shadow elements, to save memory space.
453 The TRUE value for this param has to be used
454 with a FALSE value for the 'enable_sequence' param.
455 ('public elements' may be embedded in 'shadow Sequences')
456 * gdcmHeader methods now deal with 'embedded icones images' in the header
457 (even when an 'icone image sequence' is announced by the
458 element (0x0088,0x0200), but there is NO icone at all ...
460 * gdcmHeader sometimes Image Location value doesn't follow
461 the supposed processor endianity (see gdcmData/cr172241.dcm).
464 * gdcmHeader add the method
465 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
466 to get *all* the Header Entries with the same tag.
467 GetHeaderEntrySameName is probabely *useless*
468 (no meaning : Name is *not* an identifier within the Dictionnary)
470 2004-01-26 Benoit Regrain
471 * Bug fix in the print of hexadecimal representations. Remove long fields
472 in the print and add a third level of print to print them
474 2004-01-23 Benoit Regrain
475 * Bug fix on field having a VR = 'UI'. Assume that is a string field
476 * Bug fix on test suite after remove the strip made on not string fields
477 * Split the IsReadable method between gdcmParser which test that the file
478 is dicom and gdcmHeader which test that it's an image file
480 2004-01-22 Benoit Regrain
481 * DicomDir : clean code, add methods, set variables in protected or private
482 * gdcmUtil : bug fix for the clean string method
484 2004-01-19 Benoit Regrain
485 * Add the use of shadow dictionaries
486 * bug fix and coding style
488 2004-01-19 Benoit Regrain
489 * src/gdcmFile.cxx : bug fix concerning the close of file
490 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
491 * Add the update of header entries using the shadow library
493 2004-01-19 Benoit Regrain
494 * removal of file gdcmHeader2.cxx
495 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
496 inheriting from gdcmParser. This split is to prepare the integration
498 * bug fix under python
500 2004-01-16 Jean-Pierre Roux
501 * REM removal of class gdcmHeaderEntrySet
502 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
503 * ADD add file gdcmHeader2.cxx
504 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
506 2004-01-15 Benoit Regrain
507 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
508 entries created while parsing the header. Thus, they will be destroyed
509 when the gdcmDictSet will be destroyed
510 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
513 2004-01-15 Benoit Regrain
514 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
515 made a fatal error because of the memory release at the end of program.
516 The problem was in vtkGdcmReader::ExecuteData where we were allocate
517 some memory and vtk seems to have some problems with that.
518 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
520 2004-01-14 Benoit Regrain
521 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
522 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
523 * src/*.[h|cxx] : make changes due to class name changes
524 * gdcmPython/demo/*.py : bug fix due to method names
526 2004-01-13 Benoit Regrain
527 * src/*.[h|cxx] : coding style
528 * vtk/*.[h|cxx] : coding style
530 2004-01-13 Benoit Regrain
531 * gdcmPython/testSuite.py : test the readable flag of file for tests
532 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
533 It's lied to the stl compilation by MSVC (windows, always windows...)
534 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
536 2004-01-12 Benoit Regrain
537 * src/*.h : add comments
538 * src/gdcmDictSet.h : set the method BuildDictPath in public
539 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
540 directly setted in the source code
541 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
544 2004-01-09 Benoit Regrain
545 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
546 * setup.py : use a reference to gdcmVERSION
548 2004-01-07 Benoit Regrain
549 * Modification to compile with the distutils.
552 2003-12-10 Benoit Regrain
553 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
554 can use a gdcmHeaderHelper to load datas
555 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
556 made in the source code
558 2003-12-10 Benoit Regrain
559 * Update Windows projects and .cvsignore files
561 2003-11-12 Jean-Pierre Roux
562 * ENH gdcmHeader constructor has one more parameter (default value : false)
563 that allows the user to 'go inside' the SeQuences only
565 gdcmElValSet:Print takes it into account
567 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
568 * ENH: Update gdcmPython/CMakeLists
569 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
570 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
572 2003-11-10 Jean-Pierre Roux
573 * FIX : gdcmHeader::LoadElements is now based
574 on the ListTag listElem member,
575 not longer on the TagElValueHT tagHt member
576 * ENH : PrintPubElVal shows (temporarily) both results,
577 with the tagHt member and the listElem member.
578 (it's easier to 'see' the problems when using Printheader)
580 * FIX : old private member LgrElem is now splitted into
581 ReadLength : Length actually found on disk (updated only
582 if bug fixing is necessary), for internal
584 UsableLength : Updated by FixFoundLength, to fix a bug
585 or to allow Parser going on.
586 Will allow to re-write a kosher header when a SeQuence
587 with a length (not 0000) is found
588 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
589 because gdcmElValSet::Add does not update ListElem
592 2003-11-07 Jean-Pierre Roux
593 * FIX misstyping in Transfert Syntax name table
594 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
595 when they have an actual length (not 0000 nor FFFFF)
596 (Nobody should care of it, but DICOMDIR explorers)
598 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
599 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
601 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
602 * ENH: vtkGdcmReader now supports LUT !
603 (vtkgdcmViewer for now is not able to use them though)
605 2003-11-05 Jean-Pierre Roux
606 * in testSuite.py : new files names for checking the package
607 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
608 that returns the pixel area size to the *aware* (vtk) user
609 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
611 2003-11-05 Benoit Regrain
612 * in testSuite.py : Modify the rules for checking the paths
613 : Explicit error messages
614 * in __init__.py : Related modif
616 2003-11-03 Jean-Pierre Roux
617 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
618 to be used by aware (vtk) users that want to manage
619 LUT (and no to turn the PALETTE image into an RGB pixels one)
620 * GetPixelType now returns 8U for 24 Bits images
621 (vtkGdcmReader compliant)
623 2003-10-31 Jean-Pierre Roux
624 * Removal of *all* gdcmData images and add them again
625 in order to loose the 'history' of un-anonymised images
627 2003-10-31 Jean-Pierre Roux
628 * RMV : removal of useless jBitsInJsample.h
629 for both 8 and 12 Bits JPEG Lossy Libraries
631 2003-10-31 Jean-Pierre Roux
632 * ENH : Add the functions gdcmFile::GetImageDataRaw
633 gdcmFile::GetImageDataIntoVectorRaw
634 that act as GetImageData and GetImageDataIntoVector
635 except the making of an RGB Plane from Gray Plane + LUT
636 Intended to aware (vtk) users who know how to manage
639 GetLUTRGBA return a R,G,B,A LUT if any
640 lgrTotaleRaw gives the 'Raw' length
641 GetImageDataRaw returns the gray Plane
642 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
643 (They stay Grey, just like with other Dicom viewers :-(
645 2003-10-30 Jean-Pierre Roux
646 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
648 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
649 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
650 being coherents dicom files.
652 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
653 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
655 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
656 * ENH: Two steps is necessary to please VC++ compiler...
657 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
658 * ENH: Add include dir to medcon lib
659 * FIX: only one function is being exported for now !
660 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
662 2003-10-29 Jean-Pierre Roux
663 * adding gdcmHeader::GetLUTRGBA
664 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
665 --> Mathieu, the modif u're waiting for is not yet committed
666 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
668 2003-10-27 Jean-Pierre Roux
669 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
670 00191113.dcm DermaColorLossLess.dcm
671 MxTwinLossLess.dcm RadBWLossLess.dcm
672 * ENH: For version prior to vtkImageViewer2 -r 1.19
673 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
675 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
676 * Removal of ido stuff in CMakeLists.txt
678 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
679 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
680 * FIX: remove a call to ->Modified ... see comments
681 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
683 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
684 * FIX: Problem with path for libvtkgdcmPython
685 * ENH: Try adding a search script for python site-package
686 * RMV: Remove some file from medcon lib that are not necessary
687 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
688 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
689 * FIX: More pragma disable fro VC++,
690 I don't think I break something as it is also disable in VTK/ITK.
691 But it fasten debug compilation time.
693 2003-10-23 Jean-Pierre Roux
694 * gdcm now deals with 16 Bits Run Length Encoded images
695 (they are compressed as 2 planes images,
696 one for the high Bytes, the other for low Bytes)
698 2003-10-22 Jean-Pierre Roux
699 * Now CheckRead takes into account :
700 - the bugged 'Leonardo' Siemens images
701 - the XA images, sent thru the burning VPRO station
702 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
705 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
706 * FIX: When copying a Makefile.am to CMakeLists.txt
707 one should remove the '\'
709 2003-10-22 Jean-Pierre Roux
710 * in gdcmData adding a bugged 'Leonardo' Siemens image
711 (wrong lengths in header)
712 OK with gdcm, KO with the other viewers :-)
713 * add a GE dlx XA image, thru the VEPRO burning station
716 2003-10-21 Jean-Pierre Roux
717 * in gdcmData add the checkvtkgdcmViewer.sh shell script
718 for a brutal checking of vtkgdcmViewer compliance
720 2003-10-21 Jean-Pierre Roux
721 * add the files for 'xmedcon' Jpeg Lossless library
722 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
724 2003-10-21 Jean-Pierre Roux
725 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
727 2003-10-21 Jean-Pierre Roux
728 * garbage Siemens 'Leonardo' images dealt with
729 (the patch is easy to remove)
730 * cosmetic changes to avoid warnings
732 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
733 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
734 no need to press 'r' now.
736 2003-10-20 Jean-Pierre Roux
737 * upgrade of checkRead.sh checkWrite.sh according
738 to new Jpeg Lossless decompressor
739 * add US.3405.1.dcm, a genuine RGB medical file ...
740 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
741 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
743 2003-10-15 Jean-Pierre Roux
744 * general anonymisation in gdcmData
745 * adding the 'color files' from
746 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
747 * adding some well knowed bugged-header images
748 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
749 waiting for their inclusion in Python testsuite
751 2003-10-15 Jean-Pierre Roux
752 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
753 no longer seg faults when file is not found
755 2003-10-14 Jean-Pierre Roux
756 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
759 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
760 * TODO: *.in file to genereate a UseGDCM later
762 2003-10-14 Jean-Pierre Roux
763 * Some supposed-to-be Dicom Images have no preamble.
764 OpenFile takes it into account
765 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
766 * Missing elements added in dicomV3.dic
767 (just to be affraid : have a look at
768 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
769 and do it again next year ;->
771 2003-10-13 Jean-Pierre Roux
772 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
773 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
774 But there are NOT. It's fixed !
776 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
777 * FIX: "jpeglib.h" was not found on VC++
778 * FIX: vtkgdcm was not being installed
780 2003-10-10 Jean-Pierre Roux
781 * ENH : OpenFile closes the file if it *really* doesn't look like
782 an ACR-NEMA / DICOM one.
783 * FIX : testWrite no longer writes an empty file if the source file
785 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
788 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
789 * FIX: CMake generate now documentation
790 * ENH: out of source doc build !
791 * ENH: Generate both user and dev documentation
792 * ENH: Should work on windows too
793 * ENH: Only one doxygen config.in file is needed
794 * FIX: make install should be ok now on ùnix plateform
795 * FIX: PATH to dictionary was wrong (missing /)
796 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
798 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
799 * vtkGdcmReader is now able to read rgb dicom file.
800 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
801 * added a gdcmViewer to vtk test, use mouse to control
802 window level & window width
804 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
805 * CMake-ification of gdcm, we have now two build system
806 * FIX: on cygwin Wsock32 doesn't exist
807 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
809 2003-10-06 Emanuel Ollart
810 * FIX : compilation process wad broken.
811 Changed gdcmViewer_sources to vtkgdcmViewer_sources
813 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
814 * change gdcmViewer -> vtkgdcmViewer
815 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
817 2003-10-06 Jean-Pierre Roux
818 * FIX :A few nasty patches to allow the reading of a lot of nasty images
819 ( e.g : well known GE images with a wrong elem length,
820 : Philips MRI Images with a wrong Huffman table)
821 * still to be done : allow the reading of bugged LEONARDO Siemens images
823 2003-10-03 Jean-Pierre Roux
824 * Odd length strings are padded with '\0' (not with spaces,
825 to remain compliant with already defined strings,
826 like Transfert Syntax UID and others)
828 2003-10-03 Jean-Pierre Roux
829 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
830 to allow displaying RGB images (not only by affim ;-)
832 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
833 * vtkGdcmReader is now able to read rgb dicom file.
834 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
836 2003-10-03 Jean-Pierre Roux
837 * A few nasty patches to allow the reading of a lot of nasty images
838 ( e.g : well known GE images with a wrong elem length,
839 : Philips MRI Images with a wrong Huffman table)
840 * still to be done : allow the reading of bugged LEONARDO Siemens images
842 2003-10-03 Jean-Pierre Roux
843 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
845 2003-10-03 Jean-Pierre Roux
846 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
847 to allow displaying RGB images (not only by affim ;-)
849 2003-10-03 Jean-Pierre Roux
850 * gdcmFile::GetImageDataIntoVector now
851 - deals with MultiFrames MultiFragments Run Length Encoded files
852 - deals with YcBcR (YBR_FULL) files
853 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
854 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
858 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
859 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
860 Two reasons: - clear things
861 - third parties acces gdcm through header files, so won't
862 suffer anymore VC++ complains
864 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
865 * add argv[1] in testvtkGdcmReader.cxx
868 2003-09-24 Jean-Pierre Roux
869 * The lines are now eigthy characters long.for
870 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
872 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
873 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
874 char* to std::string. Thus, the use of strdup becomes useless. (see
875 previous commis of Malaterre)
876 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
877 before the last Malaterre's commit.
879 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
880 * This commit should fix the Debug building under VC++, the problem
881 was mainly a mixture of debug and release lib being loaded at startup.
882 * I also remove a depency to a specific C function: strdup. Because I had
883 to force the link to msvcrtd (whereas strdup is in libc).
885 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
886 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
887 located in the gdcmCommon.h file. All use of reference of tha has been
888 changed to now use the variable GDCM_UNFOUND.
890 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
892 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
893 Dicom dictionary. The test suite can now be run again. Note:
894 I'm note very happy with the " (RET)" changes. I believe this
895 RETAINED comment should be dropped when parsing the dictionary.
898 - AUTHORS updated and now in alphabetical order
899 * Makefile.am now exports gdcm.dsw for Windoze users.
901 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
902 * cygwin complains about missing std:: in subdir Test/
904 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
905 * remove some methods that are now in gdcmHeaderHelper
907 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
908 * vtkGdcmReader set spacing and origin correctly
910 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
911 * Fix a few delete/delete[] mismatch
913 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
914 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
915 interpretation to data given by gdcmHeader. For instance there are
916 heuristics to get informations (look at different places).
917 * it also include a specific class: gdcmSerieHeaderHelper devoted to
918 sorting DICOM images based on different strategies.
919 * modified Makefiles accordingly.
921 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
922 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
923 when building in debug mode
924 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
925 src/win32/gdcmdll.dsp
926 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
928 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
929 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
932 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
933 * src/win32/libgdcmjpeg12.dsp was not dos format
934 * src/win32/libgdcmjpeg12.dsp :
935 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
936 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
938 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
939 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
941 * src/gdcmFile.cxx : bug fix in affectation type
942 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
943 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
944 * Modifs of MVSC projects to compile them. Not concerning 2 identic
945 symbols... future problem ?
947 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
948 * src/win32/libgdcmijpeg12.dsp was missing
949 * modified gdcm.dsw accordingly
951 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
952 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
954 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
955 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
956 commit of JPR (before his hollidays to facilitate our work).
957 * setup.py : bug fix in code. Modifications made while the last commit
958 of JPR. The code hasn't been tested before the commit... it's so
959 useless to make that (for best programmer that is JPR) !!!
961 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
962 * tagged the current version as Version0_3 (i.e. version 0.3)
964 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
965 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
966 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
967 * *.dsp : modifications to use new libgdcmijpeg8 library
968 * setup.py : bug fix on VTKPATH variable
969 * PACKAGER : adding all concerning windows
971 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
974 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
975 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
976 test suite reported error.
977 * PACKAGER file added (describes what a packager must do when
978 packaging a new release).
979 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
980 * configure.in: upgraded version number to 0.3.0
981 * fixing build of rpm (through rpm -ta):
982 - Doc/Makefile.am exports proper doxygen files
983 - src/jpeg/libijg8/Makefile.am exports the include files.
985 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
986 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
987 * src/gdcmHeader.h : formatting code
989 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
990 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
991 We were obtaining error message from vtk. Now, creation of file list
992 is made in an internal list to prevent this problem.
993 Bug fix when output is empty.
994 Bug fix in update of progress value. Previous commit for this was a bad
996 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
998 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
999 * src/gdcmHeader.h : added method to get the file name
1000 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1001 files. Added method to remove all files on the input
1002 Added FIXME comment concerning the bad parsing of header made by
1003 ExecuteInformation method (in ExecuteData method)
1005 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1006 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1007 when using make instal.
1008 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1009 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1011 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1012 * setup.py : adding include dir of jpeg lib to compile all sources
1013 * */Win32/*.dsp : JPR fix for windows compilation
1015 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1016 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1018 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1019 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1021 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * setup.py is again effective on un*x (takes into account the
1023 addon of the jpeg library)
1024 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1025 * Doc/Doxy* updated (includes above enhancements)
1026 * INSTALL now points to web documentation
1028 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1029 * src/gdcmHeader.h doesn't make unnecessary reference to
1031 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1033 * src/gdcm*.[cxx|h] :
1034 - to allow compilation with gcc 3.x
1035 -- clean up of STL usage (added explicit usage of std::)
1036 -- small fixes on exceptions.
1037 Note: linking not tested !
1038 - clean of doxygen comments to avoid warnings at documentation
1040 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1041 dependent convertion).
1043 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * Clean up of previous JPR garbage commit (not even commented in the
1046 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1047 - moved all jpeg related files from src to src/jpeg/libijg8, with
1048 addition/modification of Makefile.am and configure.in.
1049 - the testSuite is still brain damage (not guilty).
1051 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1052 * WrapVTK.py : modifications to get correctly vtk source files to
1054 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1055 (FileName -> Filename)
1057 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * vtk/vtkGdcmReader.[cxx/h]:
1059 - UpdateProgress method should now be effective
1060 - removed the limitation on having only images loaded (as opposed
1062 - when building a stack of images/volume, a lesser number of
1063 gdcmHeader and gdcmFile instances should be used (hopefully
1064 accelerating things).
1065 - when building a stack of images/volumes, files which are not
1066 loadable (wrong path-filename, wrong permissions on existing file,
1067 or file not parsable by gdcm) are replaced with a black image
1068 in the stack (for the caller to notice the problem).
1070 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1071 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1073 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1074 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1075 between standard library (std) and vtk library (problems are found
1076 under Windows... thanks Windows !)
1078 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1081 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1083 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1086 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1087 * When compiling with distutils (see setup.py) the C++ compiler is
1088 called with different flags than the default ones (with automake).
1089 In order to fix all those warning, I compiled gdcm with the command
1090 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1091 and went for warning fixes:
1092 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1093 up from unused variables.
1094 - vtk/vtkGdcmReader.cxx: potential bug fix.
1095 * src/gdcmHeader.h: Doxygen warning cleanup
1097 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * gdcmPython/gdcm.i:
1099 - typemaps correction to take into account the systematic replacement
1100 of "using namespace std" with std:: prefix e.g. std::list,
1101 std::string... (cf changes of 2003-05-21).
1102 - gdcmGlob global variable of type gdcmGlobal (defined in
1103 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1104 exported to Python a as cvar.
1105 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1106 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1107 gdcmDictSet.GetPubDictTagNames() and
1108 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1109 C++ static methods).
1110 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1111 with the above changes.
1113 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1114 * setup.py, manifest.in : bug fix under linux
1116 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1117 * Modification of setup.py to compile vtk part too. Then, we have 2
1118 wrappers which must work with same distutils. For that, we have a
1119 generic distutils in distusiltsWrapping.py ; with :
1120 - build_extWrap class to wrap generically all extensions,
1121 - ExtensionWrap base class for all wrapping extension that contains
1123 - Wrapper interface which wrap sources
1124 + In WrapSwig.py we have extension and wrapper for Swig
1125 + In WrapVTK.py we have extension and wrapper for VTK
1126 * MANIFEST.in : modifications to consider vtk directory and new python
1127 files for compilation
1129 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1130 * Added python wrappers of vtkGdcmReader vtk class (see the
1131 source in vtk/vtkGdcmReader.cxx) :
1132 - vtk/Makefile.am now builds a library
1133 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1134 python library (as opposed to _gdcm.so wich are the python
1135 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1136 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1138 - configure.in has an additional flag --enable-vtk that needs
1139 to be set to enable compilation of vtk related code, that is:
1140 + vtk/vtkGdcmReader.so and
1141 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1142 + gdcmPython/vtkgdcmPython.so (see above)
1143 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1144 be read when compressed or when HighBit + 1 != BitsStored),
1145 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1146 the usage of the python wrapper of vtkGdcmReader vtk class.
1147 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1148 * src/*.[h] all occurences of stl classes are now prefixed with
1149 std::, and all occurences of "using namespace std;" where removed.
1150 This is to avoid pollution of global namespace in included files.
1151 Apparently vtk does not avoid this pitfall: when using both
1152 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1153 collision of various stl members (principally cout...).
1154 * gdcmPython/testSuite.py now cleanly removes temprory generated
1156 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1157 comply with above changes)
1159 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1160 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1161 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1162 vtk data structure (an image Flip was required).
1163 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1164 * cosmetic changes in documentation.
1166 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1167 * src/gdcmHeader.cxx: the constructor no longer exits when an
1168 unexisting file is given as argument.
1169 * The subdirectory Data (containing all the images used for the
1170 test suite) is not part of this repository anymore. A new module
1171 containing those images is now available at
1172 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1173 with the name gdcmData.
1174 All the python scripts (including the package initialisation file
1175 gdcmPython/__init__.py) were adapated to take this change into
1176 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1178 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1179 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1180 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1181 demo of the usage of this class.
1182 Compilation of this vtk part is only done when using the --enable-vtk
1183 at configure (or autogen.sh) stage.
1185 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1186 * More memory link related corrections and documentation fixes.
1188 - maximum info is obtained with a command of the form:
1189 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1190 --show-reachable=yes PrintHeader
1191 - the remaining reachable blocks seem to come from the STL
1192 allocation scheme through the usage of map and list. It looks
1193 like this memory cannot be freed but it is not a memory leak
1194 (in fact further invocation to the STL would recollect the
1195 unused memory allthough it cannot explicitely be freed).
1196 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1197 of displaying an image parsed with gdcm and displayed with VTK.
1198 Note: some images don't seem to work e.g.
1199 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1200 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1201 Allthough this weakens the semantics, it is a ditch attempt to
1202 make gdcm more thread friendly.
1204 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1205 * Memory link hunt (by using valgrind through the command
1206 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1207 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1208 gdcmHeader::_dicom_vr.
1209 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1210 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1212 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1214 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1215 * src/Makefile.am now exports all the necessary include files at
1219 * UpdateGroupLength replaced by new one
1222 * UpdateGroupLength re-written using H-Table
1223 (named UpdateGroupLengthNew untill checks are over)
1225 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1226 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1227 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1229 - gdcmHeader::GetPubElValSet removed.
1230 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1231 UpdateGroupLength, WriteElements, Write.
1232 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1233 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1234 carried the same semantics.
1235 - src/gdcmHeaderIdo.cxx changed accordingly.
1236 - gdcmFile::WriteBase now regroups all the codes from previous
1237 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1238 - enum FileType moved to gdcmCommon.h
1239 * src/gdcmHeader.cxx AddDefault trashed
1240 * gdcmGetXSize added
1241 * getimageDataSize now calls gdcmGetXSize
1242 * Test/*.cxx changed to agree with above changes
1244 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1245 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1246 (to avoid double call by end user).
1247 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1248 by end user, since gdcmHeader::gdcmHeader now handles it.
1250 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1251 * gdcm/Doc many doxygen changes:
1252 - Doxyfile now has two different versions, DoxyfileUsers that generates
1253 the html.users end users oriented documentation and
1254 DoxyfileDeveloppers that generates the html.developper developper
1255 oriented documentation.
1256 - README changed accordingly
1257 - requirement.txt removed (old design info moved to TODO).
1258 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1259 DoxyMainPage.txt, DoxyPython.txt provide more information.
1260 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1261 be updated by simply regenerating the docs with doxygen and copying
1262 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1263 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1264 all the tests in the form "if (<map>.count() >1)" were removed.
1265 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1266 ill-formed documentation sections.
1267 * src/gdcmHeader.cxx: ditto
1269 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1270 * setup.py fixed for un*x (needed macro for stdint.h)
1271 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1272 un*ces with sh-utils test utility.
1273 * gdcmPython/demo/test.py renamed to PrintHeader.py
1274 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1275 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1276 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1277 * src/gdcm*.cxx JPR's bad inclusion fixed.
1279 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1280 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1281 * gdcmPython/demo/test.py changed accordingly.
1283 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1284 * gdcmPython/Makefile.am fixed linking against libstdc++
1285 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1286 * Swig subdir (historical tests of swig version 1.3.17++) removed
1287 * Test/testChangeEntete.cxx some lines commented out in order to make
1289 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1290 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1292 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1294 hence the user doesn't need this explicit call.
1295 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1296 i.e. LoadElements() call removed.
1297 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1298 - src/Makefile.am declares the proper flag for g++.
1299 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1300 for adding user defined new tags.
1301 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1302 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1303 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1305 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1306 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1307 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1308 src/Makefile.am : the project should properly compile and install
1309 with the autotools, included the python wrappers part.
1310 * gdcm.spec.in : added a spec file for RPM packaging.
1312 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1313 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1315 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1316 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1317 to exported to the environement (see gdcmPython/testSuite.py
1319 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1320 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1321 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1322 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1323 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1325 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1326 * gdcmPython/__init__.py doesn't crash anymore when running in
1327 in InstallMode or PreInstallMode but with an environement given
1328 value of GDCM_DICT_PATH.
1329 * src/gdcmDictSet.[cxx/h] coding style.
1331 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1332 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1333 * src/gdcm.h general comments moved to TODO, and README
1334 * src/gdcm.h should now be seen as a user commodity (including it
1335 should suffice to fully use gdcm). It is nowhere including within
1336 any of the kernel files src/*.cxx and src/*.h.
1338 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1339 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1340 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1342 * src/gdcm*.cxx only include their corresponding include file
1343 (as opposed to gdcm.h)
1344 * gdcmPython/gdcm.i changed accordingly
1345 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1346 the autogen.sh generated "make snapshot" command to work.
1347 * autogen.sh removed history related references to crea package.
1349 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1350 * distutilsSwigCPlusPlus.py work around some swig portability
1353 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1354 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1355 was done in a last ditch attempt to get setup.py _really_
1356 operationnal. The python/gdcmPython layaout add the advantage
1357 of hidding away the python related distutils specific files
1358 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1359 Alas, the src directory was out of scope (i.e. it's relative
1360 position to setup.py was ../src) which made things impossible to
1361 handle (see previous version of python/setup.py). Crossing fingers...
1363 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1364 * python/setup.py now works on Un*x. (harder than I thougth)
1365 * python/distutilsSwigCPlusPlus.py can now have include files
1366 among the list of sources.
1368 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1369 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1370 * modifications in MSVC projects
1372 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1373 * As stated by the first lines of Test/ExceptionAndPython/README, it
1374 looks like we can move back to original usage of exception within
1375 src/gdcm* and hence remove the errno stuff that was introduced
1376 as a quick and dirty fixture of this problem (added to the TODO).
1377 * Doc/Doxyfile configuration file for Doxygen and corresponding
1378 README file for usage added.
1379 * Test/testWrite.cxx added. This new test comes from a split of
1380 test.cxx that is now reverted to its original purpous i.e.
1381 testing the proper parsing of a Dicom related file.
1382 testWrite.cxx concentrates on testing the IO part of gdcm.
1383 * Test/bug1.cxx (containing a bug on WIn32) added.
1384 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1385 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1386 whose purpose is to publish the content of the TagNames of the
1387 Dicom public dictionnary were not accessible without an
1388 instance of class gdcmHeader.
1389 - those methods are now static methods of gdcmDictSet and hence
1390 require no instances at all to be invocated.
1391 - within gdcmDictSet this change required to change some method
1392 to class methods (i.e. are now static) among which SetDictPath
1393 (renamed to BuildDictPath) and LoadDefaultPubDict.
1394 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1395 the above changes by calling the new method classes of gdcmDictSet.
1396 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1397 the above to be effective.
1398 * python/gdcmPython: in order to wrap properly the above changes
1399 for Python, swig version now needs to be > 1.3.17.
1400 * python/gdcmPython/Makefile fixed to adapt itself to new
1401 configure/make shema introduced by Johan Montagnat (thanks for the
1402 contribution). Alas this Makefile cannot be turned into a proper
1403 Makefile.am without some heavy changes in the configure.in
1404 (for python dectection).
1405 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1406 now avoids publishing the empty entries.
1408 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1409 * python/setup.py : bug fix concerning install under windows
1410 ExtraPath reused :-P
1411 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1413 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1414 * Dicts/dicomV3.dic : remove double spaces !!!
1415 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1416 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1419 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1420 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1421 method. Doxygenation.
1422 * src/gdcm.h clean up of JPR spurious comments.
1424 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1425 * python/distutilsSwigCPlusPlus.py now properly collects the
1426 shadow classes generated by "swig -c++" (gdcm.py in our case)
1427 when using "python setup.py install".
1428 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1429 reexports the working classes.
1430 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1431 by the classical C errno scheme. This is to prevent an obscure
1432 behavior of the python wrappers when importing wxPython.wx prior
1433 to gdcmPython (which ended up in an abort call). An illustration
1434 of this oddity can be found in the Test/ExceptionAndPython
1435 subdir (see the README file). This problem probably due to
1436 an combination of g++ and dynamic loading.
1437 * added Test/ExceptionAndPython (see above)
1439 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * Changed the layout of the python part to avoid bloating main
1441 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1442 i.e. the distutils arsenal. All the python related stuff is
1443 again in a python subdir, but the package itself is now in
1445 * setup.py was cleaned up:
1446 - pythonIncludePath removed
1447 - python setup.py bdist target is now functional.
1448 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1449 collision with other packages). gdcmPython/demo/*.py changed
1452 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1453 * python subdir moved to gdcmPython (preparation of distutils packaging).
1454 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1455 distutils installer is operational.
1456 * - gdcmPython/__init__.py now properly loads the swig generated
1457 shadow classes (from gdcm.py).
1458 - gdcmPython/demo/*.py changed to import the package gdcmPython
1459 instead of gdcmPython/demo/load.py.
1460 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1462 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1463 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1464 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1465 entries within the associated public Dicom dictionary resp. the same
1466 information but sorted by the fourth field (PAT, IMG, DIR) of the
1468 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1469 are now in the "???" group.
1470 - python/gdcm.i changed accordingly,
1471 - python/demo/printGroupedPublicDict.py added, that gives an example
1472 of the above new functionalities in Python.
1474 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1475 * src/gdcm.h, gdcmHeader.cxx:
1476 - historic references to glib's g_malloc and g_free (#defined)
1477 were definitively removed.
1478 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1479 * src/gdcmElValSet.cxx:
1480 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1481 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1482 - GetElValue(string) renamed to GetElValueByName.
1483 - Added GetElementByName(string).
1484 * src/gdcmHeader.cxx: added
1485 - GetPubElValRepByNumber(guint16, guint16)
1486 - GetPubElValRepByName(string)
1487 - GetShaElValRepByNumber(guint16, guint16)
1488 - GetShaElValRepByName(string)
1489 - GetShaElValByNumber(guint16, guint16)
1490 - GetShaElValRepByName(string)
1491 - GetElValRepByNumber(guint16, guint16)
1492 - GetElValRepByName(string)
1493 - GetElValByNumber(guint16, guint16)
1494 - GetElValRepByName(string)
1495 * Doc/requirements.txt added.
1497 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1498 * Test/Makefile building now depends on the one of libgdcm.so
1499 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1500 pixel data) aware which enables finding the address (offset) of
1501 the pixel data of JPEG encoded DICOM files. This leaves only a single
1502 file in the testSuite whose pixel data address (offset) is unknown.
1503 * python/testSuite.py changed accordingly.
1505 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1506 * VC++ has some strong limitations when working with the STL, as stated
1507 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1508 "Also note that some STL containers (map, set, queue, list, deque)
1509 cannot be exported. [...]
1510 Some STL classes contain nested classes. These classes can not
1512 This is caused by a designed limitation that once a template
1513 class is instantiated, it can not be re-instantiated and
1515 Since our usage of map<> is ubiquitous in gdcm, this "designed
1516 limitation" of VC++ is a pitfall.
1517 Hence the Python wrappers of gdcm cannot be incrementally linked
1518 against the c++ dynamic library. The dirty but only workaround is
1519 to forget about incremental link of dynamic libraries and to generate
1520 the Python wrappers library with the inclusions of the underlying C++
1522 The following modifications concern this matter on Win32/VC++:
1523 - wrapping python correct with standalone wrapped dll (don't use separate
1524 dll under windows !!!!)
1525 - python21_d debug mode enabled (ask Frog how to use it :-)
1526 - NO problem with having an STL member of class for example string in C++
1527 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1528 - Python test of dcmlib in Python is ok under windows on a large set
1530 * removed glib references
1531 * typedef's inserted in gdcm.i for correct swig type management
1533 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * python/demo/*.py load.py extracted from test.py. Added explore.py
1535 that only displays required tags and testAll.py that parses all
1536 the files of the testsuite without using unittest.
1537 * python/testSuite.py other additional test on new files added.
1538 * Data/* new test files added accordingly to the testSuite.
1539 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1540 the vr in the file differs from the one of the dictionary.
1542 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1543 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1544 values, but limits itself to values which are below a user specified
1545 size (by default 1024 bytes).
1546 * python/gdcm.i : elements not loaded (because their size is above the
1547 user specified treshold) are exported with their TagKey as key of the
1548 python dictionary. This enables the testsuite to make some checks
1549 on the unloaded elements (since we have their offset and size).
1550 * python/testSuite.py
1551 - now tests for the existence and proper value of the pixel data
1552 - two new examples added.
1553 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1555 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1556 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1557 aware. See the strategy comments in gdcmHeader::FindeLength().
1558 * Test/test.cxx now accepts a filename as first argument.
1559 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1560 * python/testSuite.py changed to integrate test on above files.
1562 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1563 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1564 the vr was also RET.
1565 * python/testSuite.py more tests added.
1567 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1568 * python/testSuite.py unittest test suite added (uses Data)
1569 * Data/* dcm and acr files for the test suite.
1570 * glib dependance removed from un*x version. We now use ISO C99
1571 7.18 Integer types (see stdint.h)
1572 - python/Makefile, src/Makefile src/gdcm.h
1573 * src/ when an explicit vr (like dicom files) suddenly poped an
1574 implicit element we use to mark the underlying DictEntry of the
1575 concerned ElValue with "Implicit". This strategy was damageable
1576 too the public or provite dictionaries, since some of their vr
1577 would be changed. Since Header::FindLength heavily relies on the
1578 detection by Header::FindVR of falsely explicit elements, I
1579 added an extra ImplicitVr member to ElValue (boolean).
1580 The rest of the changes we the necessary adaptations.
1582 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1583 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1585 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1587 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1588 * Adaptation for porting to VC++:
1590 o forced to use std namespace (for string to be known)
1591 o all class use __declspec export style on WIN32
1592 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1593 (in stdlib.h on Win32 but in std:: for gcc)
1594 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1595 variable GDCM_DICT_PATH.
1596 * src/gdcmHeader.cxx verbose comments made discrete.
1598 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1599 * python/gdcm.i: added a typemap that converts a C++ hashing table
1600 to native Python dictionary.
1601 * python/demo/test.py:
1602 - now uses the native dictionary for exploration of gdcmHeader.
1603 - takes an optional filename argument (the file to parse).
1604 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1605 PubElVals hashing table.
1606 * Dicts/dicomV3.dic removed error prone trailing spaces.
1608 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1609 * Python wrapping process moved away from src/Makefile to
1610 newly created python/Makefile (as well as gdcm.i)
1611 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1612 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1613 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1614 from the environement variable GDCM_DICT_PATH (when existing).
1615 * src/gdcmDict::GetTag bug fix.
1617 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1618 * Straightforward temporary fixes for swig to build the python wrappers.
1619 src/Makefile now has a python working entry [by working we mean
1620 that we can import de shadow classes without errors].
1622 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1623 * hashtest.cxx removed (since allready in Test)
1624 * src/gdcmlib.h renamed to src/gdcm.h
1625 * src/dcm.i renamed to src/gdcm.i
1626 * src/Makefile prepared for python wrapping
1628 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1629 * src/gdcmHeader.cxx :
1630 - Parsing of header is now separated from loading of element values
1631 (see gdcmHeader::LoadElements).
1632 - general clean up of hopefully all file access (creation of
1633 ReadInt16 and ReadInt32)
1635 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1636 * src/gdcmHeader.cxx :
1637 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1639 - SetLgrElem renamed to SetLength
1640 - GetLgrElem renamed to GetLength
1641 - ~gdcmHeader() made virtual to pesky warning messages at compile.
1642 * src/gdcmElValSet.cxx fixed both GetElValue methods
1643 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
1644 due to IdoDude was cleaned out.
1646 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1647 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
1648 concentrates on finding the value representation (when it exists).
1649 RecupLgr now only finds the element value length, and it avoids
1650 returning the unecessary skL (skipped length).
1651 Also, offsetCourant was simply removed (with taille_fich) since
1652 it was redundant with the File position internals (by using
1653 ftell and fseek). This also made skL (see above in RecupLgr) usage
1655 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
1656 on the libido specificities which are handled through class
1658 * Test/implicit_vr.dcm dicom v3 in implicit value representation
1661 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1662 * Truckload of changes. Parsing of header is barely functional
1663 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
1665 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * src/gdcmHeader.cxx many addons of low level methods
1668 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1669 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
1670 and _IdDcmSWAP_LONG.
1672 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1673 * This corresponds to all the changes decided at the meeting of
1674 May 23 2002. Needless to say we are running late...