1 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
3 Rename Decompressed to Raw
4 * Use the API changes in gdcm::File.
5 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
8 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
10 each added entry in the header. Replace the 'Planes' field by the 'Number
13 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
15 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
17 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
19 At this time, this image isn't readable by e-film... waiting JPR help to
22 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
24 DocEntry. Now use methods of the Document !
26 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * Test/ShowDicomSeq.cxx : bug fix
29 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
31 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
32 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
33 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
35 * Test/TestCopyRescaleDicom.cxx : remove unused variable
36 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
37 containing found sequences
39 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
42 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
43 Some fields in BinEntry must be copied to not seg fault when making the :
44 gdcm::File *copy = new gdcm::File( copyH );
45 and tests are now made on good variables
47 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
49 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
51 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
52 * Add vtkGdcmWriter example and test
54 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * Test/TestUtil.cxx : reformat the source code
56 * vtk/vtkGdcmReader.cxx : remove and change prints
57 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
59 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
60 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
62 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
64 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
66 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
68 by an eof to prevent all bad read of the file... and in this case, the
71 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * Example/Volume2Dicom.cxx : comment unused variables
73 * Test/PrintDicomDir.cxx : comment unused variables
74 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
75 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
76 method that is redondant with AddEntry.
77 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
80 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * Bug fix due my last commit (compilation under Windows).
82 * Example/Volume2Dicom : bug fix in the file and reformatting source code
83 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
85 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
87 - Remove printf / sprintf
88 - include iostream AFTER gdcm so we don't get warnings
89 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
91 - Also remove tons of include from header files, hopefully this should
92 speeup the compilation time, since it was becoming a dog slow.
93 - Remove gdcm.h as it include way too many files and slow down compilation
94 (plus it is not up to date)
95 - remove 'using namespace std' this is BAD !
97 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * Remove memory leaks on the DicomDir
99 * Remove some useless datas in DicomDirObject
100 * Add usefull methods in SQItem, to be complient withe the ElementSet
102 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
105 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
107 future, with convertion)
108 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
109 and ImageDataSize values. Remove the method to get the PixelReadConverter
110 from the output of the class
112 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
115 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
117 and vtkErrorMacro use.
118 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
120 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
123 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
124 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
125 The string leaves only in the fonction. So when we make a .c_str(), we
126 get the pointeur on the first element, element that will be destroyed
127 immediately after thee instruction.
128 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
129 file has been opened : the test must be made on the content of the
130 pointer and not directly on the pointer !
133 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
135 the python part recompiles
137 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
139 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
140 X session is killed (for my computer... it seems to not be identic on
143 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
145 avoid problems (otherwise, the difference test between the visible image
146 and the reference is incorrect. If the reference is greater than the
147 screen resolution, it's produce errors).
148 Can be used for only one image. Can be used with a visible flag.
149 * vtk/vtkGdcmReader.cxx : remove commented codes.
150 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
151 under windows at compilation
152 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
154 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
156 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
158 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
159 tests on the image size X, Y, Z
161 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
163 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
164 between the class name and the file name
166 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/ : fix compilation warnings for the Write method (2 different
168 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
169 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
170 variable... create a static method in gdcm::Document to access to
171 this variable content.
173 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
175 file, to be accessed by other files (like gdcmFile). Remove commented
176 code. Move the change of the header to the gdcmFile, using the
178 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
179 To be sure of that (and simplify calls), the Write of the header now
180 gets a file name and not a file pointer (std::ifstream).
181 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
182 DocEntryArchive. Remove all open of the written file
184 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
187 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
189 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
191 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
192 some corresponding methods. Write correctly the file and check before
194 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
195 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
196 is now on RGB datas (as before my last commit
197 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
199 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
201 Add a print information of the type of the entry
202 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
203 It was in the gdcmFile, and all write have been regrouped
204 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
205 Write correctly all dicom files (in decompressed mode only at this time)
206 * Test/ : test on files are now made using Raw datas and not color datas if
208 * Example/PrintFile.cxx : add more printings
210 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
211 * Amelioration of code, remove some code copy. For the loading of
212 BinEntry (in gdcmDocument), add the test to verify if the file is already
215 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
217 remove a DocEntry in the header (push an empty DocEntry)
218 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
219 lines. Bug fix in the initialization of the PixelConvert and the
221 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
222 use in TestCopyDicom (now this test can run under windows... but fails)
223 * Test/TestCopyDicom.cxx : amelioration of the test :
224 - test the pixels written
225 - add test points to quickly find where is the error
226 - can set a file name input and output in arguments
227 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
228 amelioration of the test output
230 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
232 all replaced DocEntry's
233 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
234 Now, each needed DocEntry to modify is duplicated, modified and inserted
235 to the header using DocEntryArchive. Thus, after save, we can restore the
236 header initial state.
238 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
241 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
243 correct to copy it. The DictEntry is specified at the DocEntry creation,
244 then, it musn't change in the time.
245 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
246 header correctly. At this time, the change is only made for the first
247 level of the Document. In the future, it might consider sequences.
248 The change is made by replacing a DocEntry by an other that is created
249 outside the class. The old value is kept. When we restore the header
250 status, the added DocEntry is deleted and replaced by the old value.
251 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
252 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
253 set the write type to explicit VR, implicit VR or ACR. Add methods to set
254 the write mode to native, decompressed or RGB (but not used at this time)
256 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
258 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
260 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
262 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
264 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
265 set because already copied when copying the BinEntry's of the header
266 * Test/TestAllReadCompareDicom.cxx : remove warnings
268 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
269 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
270 Two problems appear when doing it :
271 - with the gdcmFile : when the GetImageData method is called, the pixels
272 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
273 datas (pixels). And each structure destruct the datas when it's
274 destructed. So we have two destructions for the same datas. To solve it,
275 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
276 datas or not. If it doesn't own datas, then they will not destroyed by
278 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
279 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
280 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
281 create a double destruction of the same DocEntry's. So, to solve it,
282 the TagHT is simply cleared and the DicomDir* elements are destroyed.
283 * TODO : add an entry concerning memory leaks in the DicomDir
285 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
287 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
290 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
292 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
293 after it have been deleted
295 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
296 * FIX: src/* fix the doxygen warnings.
297 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
298 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
299 was erroneously defined with a size of 15 instead of 16. [many thanks
300 to Jean Michel Rouet for pointing out this bug].
302 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
303 1. Finish merging JMR patch for writting DICOM from scratch
304 2. Fix -hopefully- bug with MONOCHROME and space vs null character
305 3. Use const ref when possible
306 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
307 5. A few more comments
308 6. CreateUniqueUID can now be called without parameter"
310 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
311 * ENH: Slightly bigger patch:
312 1. Getting toward full integration of JMR patch for writting dicom from scratch
313 2. Update Test to test part of this patch: CreateUniqueUID
314 3. File was not close properly in gdcmDict
315 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
316 5. Use of const ref instead of copy (speed issue)
317 6. Remove temporary (duplicate) string in TranslateToKey
318 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
319 8. Do not repeat virtual in subclasses
320 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
322 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
323 * Apply first patch toward better string comparison when dealing with broken
324 DICOM files. Essentially the string could be padded with a space instead
325 of a null character as defined by standard
327 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
328 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
329 because never used... and in the same time, that's remove some memory leaks
331 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
332 * src/gdcmFile.cxx : now delete the PixelConvert instance.
333 * In examples and tests : change the type of image data variables from void*
334 to uint8_t*. Remmove all delete on image data variables
336 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
337 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
338 Verify the file pointer value before open the file, and if it's not null,
339 a verbose message is generated.
340 Close correctly the file when the file isn't considered dicom-like. The
341 correctly close is a call to CloseFile.
342 When closing the file pointer, test if its not null to close the file.
343 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
344 file. For an uncompressed image, the copied datas correspond in the least
345 case to the image size (calculated) or the image size specified in the
346 header. A verbose is generated if these two size mismatch
348 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
350 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
351 break under windows (with msvc6 compilation).
353 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
355 compiling with MSVC6)
357 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * Bugs fix for the Windows build with VC6
359 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
360 needed (only for projects required VTK). If the VTK is included in all
361 projects, there is conflicts with the jpeg lib of vtk when compiling the
362 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
363 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
364 when compiling the gdcm_wrap.cxx file (created by the compilation of the
366 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
367 (like it's already made for the cout use). Otherwise, conflict with the
370 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
371 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
373 - comments on the DicomDir::Method related usage added.
374 - now that we use the namespace gdcm, a lot of internal classes do
375 NOT need to be wrapped anymore.
376 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
377 DicomDir::Method) new example added.
379 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
380 * Improve string manipulation. I now inforce the notion of 'DicomString'
381 A DicomString can contain as many \0 as they want
382 and it is *always* of even length.
383 We only support odd length for very rare case.
384 And in the near future this should be removed.
386 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
387 * /binary_write/ gdcm source. Now even on big endian we are writting
388 little endian. This should -heopfully- fix some tests
390 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
391 * Now the dictionary is compiled into gdcm lib. This is a default
392 behavior, thus any dic file specified is picked before failback to
393 the one comiled into lib
395 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
396 * Change internals for gdcmDict. Don't use any 'new' any more.
397 This should definitely solve any leak problem, and we should be
398 as fast as before, as long as don't modify too much the dictionary.
400 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
401 * STYLE: ivars should start with a capital letter.
402 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
403 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
405 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
406 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
407 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
408 new 2004 dictionaries added (thanks to JPR).
409 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
410 * CLEANUP_ROUND (15) for gdcmPixelConvert
411 - RLEFrame::NumberFragments is now of type unsigned int
412 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
413 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
416 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
417 * Initial work in gathering all transfer syntax accessors. clearly
418 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
419 ivars, but only one transfersyntax (class) ivar with equivalent method on
422 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
423 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
424 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
425 discussed (plus I didn't like having a 2000 lines patch not commited)
427 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
428 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
429 * CLEANUP_ROUND (14) for gdcmPixelConvert
430 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
431 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
432 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
434 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
435 anymore and hence avoids storing a copy of PixelConvert::Decompressed
436 into File::Pixel_Data.
438 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
439 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
440 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
441 * CLEANUP_ROUND (13) for gdcmPixelConvert
442 Substituted File::ParsePixelData() with PixelConvert::Print() new
444 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
445 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
446 method to those classes.
447 - src/gdcmFile.[cxx|h]:
448 -- Added a ::Print() method.
449 -- PixelConverter is now a reference instead of a member.
450 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
451 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
453 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
454 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
455 collaboration diagram and inheritance diagram should be generated with
457 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
458 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
459 pointlessly wrapped (see
460 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
461 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
462 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
463 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
464 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
465 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
466 -- File::Initialise: PixelConverter setup moved away to
467 PixelConverter::GrabInformationsFromHeader()
468 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
469 interpretation moved away to PixelConverter::BuildRGBImage()
471 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
472 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
473 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
475 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
476 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
477 displayed on Win32 when a brutal abort() occurs (because of uncatched
478 exception). See TODO new entry of this commit for more on this.
479 * TODO added new entry.
480 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
481 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
482 - HandleColor is no longer called from gdcmFile.cxx
483 - gdcmPixelConvert.cxx clean up on method arguments and internal
484 variable names for semantical coherence.
486 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
487 * Finished lossless transition, not only do we now read all lossless jpeg
488 images, without the need of the Cornwell lib, but we do read them properly now
489 * To reduce code (well to avoid code duplication), I defined a common place
490 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
491 redefine symbols. This is not prefect but this the best solution I found for a
492 compilation time jpeg option.
494 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
495 * Update jpeg ijg lib to support lossless jpeg implementation
496 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
498 * Also added a special copyright for dcmtk since we use their bugfixes.
501 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
502 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
503 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
504 matters, as stated in warning note at begining of %include section).
505 * src/gdcmDicomDir*.[cxx|h]: coding style
506 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
507 * src/gdcmJpeg8.cxx: doxygen fix.
508 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
509 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
510 from File:: to PixelConvert::.
512 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
513 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
514 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
515 - more code moved away from File:: to PixelConvert::
516 - fat setup of PixelConverter set in place in File::Initialise.
518 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
519 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
520 namespace at the file system level. So now you should convert your examples
522 gdcmHeader -> gdcm::Header
523 It would be nice if people keep in mind to no open the namespace, since it
524 allows compilation on broken plateform which were defining common symbol in
525 the standart namespace (like LP, Unknown ...)
527 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
528 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
529 The JPEG fragments are now parsed at the same stage than the RLE
530 information. All code related to JPEG is now in gdcmPixelConvert:
531 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
532 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
533 export a gdcmFile:: method. Those are simply global functions
534 (for the time being this is better than having them attach to
535 either gdcmFile:: or gdcmPixelConvert::).
536 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
537 and stores the result in a gdcmJPEGFragmentsInfo.
538 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
539 code (among other stuff) moved away from gdcmFile:; to
542 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
544 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
545 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
546 clean up of RLE related code.
547 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
548 - src/gdcmRLE.cxx removed
549 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
550 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
551 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
552 * CLEANUP_ROUND (9) for gdcmPixelConvert
553 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
554 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
555 away from gdcmFile:: to gdcmPixelConvert::.
557 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
559 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
560 This is because Parse7Fe0 used to parse the pixels to compute the
561 length. This task was passed over to FindDocEntryLengthOB() a long
562 time ago, EXCEPT I had forgotten the OW case...
563 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
564 we just recylce the code for parsing RLE fragments and computing
566 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
567 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
568 with the retired Parse7Fe0().
569 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
570 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
572 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
574 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
575 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
576 - src/CMakeLists.txt: alphabetic order reodering + new entries.
577 * CLEANUP_ROUND (4) for gdcmPixelConvert
578 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
579 to return an unused length.
581 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
582 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
583 this should be cleanner from the plane view. The iostream are erally a pain
584 to use to do simple stuff.
586 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
587 * Redo the compilation of the ijg jpeg library. Now only one source is
588 necesseray. No need to rename file by hand what so ever. CMake handle the
589 copying of the file within different directory, configure header file to
590 modify some symbol. The only addition made to ijg wasd a mangle table so
591 that symbol are different wether we are within 8bits or 12bits.
593 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
594 * Added documentation of vtkgdcmReader on Website:
595 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
596 with it's binary name).
597 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
598 the Website to be more complete.
599 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
600 doxygenated documentation.
601 - Doc/DoxyVtkGdcmReaderExamples.txt added
602 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
603 DoxyVtkGdmReaderExamples.html )
604 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
605 * CLEANUP_ROUND (3) for gdcmPixelConvert
606 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
608 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
609 * CLEANUP_ROUND (2) for gdcmPixelConvert
610 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
612 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * CLEANUP_ROUND for gdcmPixelConvert:
614 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
615 - src/gdcmPixelStuff[h|cxx] removed
616 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
617 - src/CMakeLists.txt changed accordingly
619 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
620 gdcmVersion.py moved to newly created ATTIC related
621 gdcmPython/SetupOldies/ directory.
622 * Autotools clean up:
623 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
624 - autogen.sh configure.in acinclude.m4 python.m4 removed
626 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
627 * src/*.cxx *.h Reference to License.htm fixed to License.html.
628 * Doc/CMakeLists.txt, doxygen.config.in: fix.
629 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
631 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * TODO updated with Mathieu suggestions. I proposed a template for
633 describing TODO entries and used it for new entries.
634 * Added Doc/Website/CodingStyle.html, Developpers.html,
635 DeveloppersPython.html, GdcmDataCvs.html and
636 DownloadVersion0_1.html, DownloadVersion0_3.html.
637 * Some Doc/*.txt Doxygen files (which do not really concern the
638 documentation itself, but the website) moved to html and
639 placed in directory Doc/Website:
640 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
641 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
642 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
643 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
644 * CMakeLists.txt changed accordingly.
645 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
646 DeveloppersPython.html
647 * INSTALL nows refers to Doc/Website/Installation.html
649 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * Added Doc/Website directory, that contains a first raw version
653 2004-09-23 Jean-Pierre Roux
654 * FIX In order not to be poluted any longer by casting problems,
655 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
656 we can now delete[] it safely
657 * VoidArea is now called BinArea (less confusing name),
658 and all the methods called ...VoidArea... are now ... BinArea...
659 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
661 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
662 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
663 clear) TagHT, which is an inherited member of gdcmElementSet. It is
664 up to the destructor of gdcmElementSet to clean up TagHt and it's
667 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * Test/CMakeLists.txt: update to follow gdcmData renamings.
669 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
671 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * ENH: added some utility method that builds a flat dictionnary
673 holding all the Dicom entries contained in the recursive structure
674 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
676 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
677 BuildFlatHashTable() that build a flat dictionary.
678 - src/gdcmElementSet.h: added a new private GetTag() accessor.
679 gdcmDocument is now a friend of gdcmElementSet.
680 - src/gdcmElementSet.cxx: clean up.
681 - Example/FlatHashTablePrint.cxx added.
682 - Example/CmakeLists.txt changed accordingly
684 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
685 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
686 moved away from gdcmDocEntrySet (since this class is an abstract class
687 acting like an interface). SQDepthLevel and BaseTagKey are now
689 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
690 and associated accessors. Doxygenation of the class.
691 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
693 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
694 Use SQDepthLevel accessor instead. ::Print() adapted.
695 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
696 - src/gdcmDocument.cxx changed accordingly.
698 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
699 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
700 - The following is the doxygen comment of the typedef declaration
701 of gdcmagKey in src/gdcmCommon.h:
702 gdcmTagKey is made to old an "universal" (as in URL, Universal
703 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
704 A dicom tag allways has a group and an element, but a set of tags
705 embeded in various (optionally nested) sequences and sharing
706 the same group and element all share the same (group, element)
707 "identifier". Hence the (group, element) cannot be used as an
708 identifier (in gdcm we shall refer to a "TagKey") of a tag.
709 In order to construct a proper tag identifier (i.e. a key) we
710 consider the following definition of a TagKey:
711 - let Group, Element be the string representation of the
712 group and element dicom tag members,
713 - let ItemNumber be the string representation of the integer
714 index of the considered item number of a sequence,
715 Let the key of a tag embeded in a sequence, noted SeqTag, be
717 /ItemNumber#Group|Element
718 where "/", "#" and "|" are characters acting as separators.
719 Then the general form of a gdcmTagKey is given by:
720 Group|Element<SeqTag>
721 where <SeqTag> means NO or many instances of SeqTag.
722 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
725 but the gdcmTagKey of a tag "embeded" is the first item of
726 a sequence, itself nested in the third item of a sequence is the
728 0004|1220/2#0008|0082/0#0008|0090
729 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
730 order to hold the new sequence compatible key. Previously, the
731 GetKey() method would look in the underlying gdcmDictEntry.
732 - src/gdcmDocEntry.cxx:
733 -- constructor now copies the underlying DictEntry key, in the local
735 -- ::Print: displays the member Key, instead of the (group, element).
736 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
737 - src/gdcmDocEntrySet.h:xi
738 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
739 -- now has a new BaseTagKey member.
741 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
742 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
744 This poses the problem with the semantics of the following lines
745 LoadEntryVoidArea(0x0028,0x1201); // R LUT
746 LoadEntryVoidArea(0x0028,0x1202); // G LUT
747 LoadEntryVoidArea(0x0028,0x1203); // B LUT
748 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
749 to the long FIXME note for what the problem is. Nevertheless in
750 order to get things working the dicom dictionary was altered !
751 Please fix things urgently...
752 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
753 information), see above note on moving the member VoidArea. Nevertheless
754 the following entries previously correctly set as US are now inproperly
756 0028 1201 OW IMG Red Palette Color Lookup Table Data
757 0028 1202 OW IMG Green Palette Color Lookup Table Data
758 0028 1203 OW IMG Blue Palette Color Lookup Table Data
759 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
760 of gdcmDocEntry moved to gdcmSeqEntry.
761 * src/gdcmSeqEntry.cxx: STYLE.
763 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
764 * Test/TestAllEntryVerify.cxx minor fix and added comments.
766 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * gdcmPython/testSuite.py: all the test suite in python is now moved
768 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
769 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
770 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
772 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
773 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
774 to avoid inclusion recursion until STL is reached.
775 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
776 mecanism. errno.h is not included in gdcm anymore.
777 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
778 (gdcmFormatError now inherits from gdcmFormatUnexpected).
780 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
781 gdcmData/TestAllEntryVerifyReference.txt
782 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
783 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
784 exception_on_error parameter.
785 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
786 - vtk/vtkGdcmReader.cxx changed accordingly,
787 - Example/*.cxx and Test/*.cxx changed accordingly.
789 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
790 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
791 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
792 enable_sequences removed from gdcmHeader constructor and dependencies.
793 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
794 * gdcmPython/demo/PrintHeader.py: dummy fix.
795 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
796 skip_shadow removed from gdcmHeader constructor and dependencies.
797 * Example/*.cxx and Test/*.cxx changed accordingly.
799 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
801 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
803 2004-07-21 Jean-Pierre Roux
804 * FIX Now, Parsing and Printing a DICOMDIR do work!
805 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
807 2004-07-20 Jean-Pierre Roux
808 * FIX Some brain damaged headers have Zero-Lenght fields
809 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
811 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
812 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
813 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
814 variable (instance of gdcmDebug) by a definition macro, and the instance
815 is now in static in the gdcmDebug class
816 * src/gdcmSQItem.h : (FIXME) remove an undefined method
817 * Test/PrintAllDocument.cxx : bug fix in the result of the test
819 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * WARNING: ctest now depends more tightly on gdcmData. You should
821 check out gdcmData properly for things to run smoothly...
822 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
823 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
824 we need the pixels not be loaded in order to use the ValEntry
825 that displays position and size).
826 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
827 This is a C++ based equivalent of gdcmPython/testSuite.py that should
828 be deprecated. If you have any doubts about the advantages of a
829 modern scripting language (read Python) versus grass root C++ (i.e.
830 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
831 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
832 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
833 Anyhow, consider documenting the gdcmData images in
834 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
836 * Test/CMakeLists.txt:
837 - now uses TestAllEntryVerify.cxx
838 - specific comments on oldACR00001.ima (now renamed in gdcmData
839 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
840 gdcmData/TestAllEntryVerifyReference.txt
843 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * src/*.[h|cxx] : typedef clean up
845 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
846 - TagKey renamed to gdcmTagKey (for external usage)
847 - VRKey renamed to gdcmVRKey (for external usage)
848 - removal of typedef duplication.
849 - Removed all unecessary inline keyword from class inline definitions.
850 - Some method|function(void) declarations replaced with method|function().
851 * src/jpeg/libijg12/jdhuff12.c:
852 - printf polluting ctest removed.
853 - TAB removal for comminting
855 - TestAllReadCompareDicom.cxx: added a test that compares all the
856 images in gdcmDataImages.h with corresponding images in
857 gdcmData/BaselineDicom/. When baseline images are not present
858 this test creates them.
859 Note: we need to validate each reference image, but before that
860 I'd like to rename them with a more explicit name...
861 - CMakeLists.txt: changed accordingly.
862 * Example/*.cxx: examples now only include gdcm.h (as opposed to
863 including each header needed).
865 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
866 * Test/*.cxx and Example/*.cxx: moved some examples away from the
867 test suite to the Example directory. Are concerned:
872 - TestWriteSimple.cxx
873 * Test/CMakeLists.txt: added some comments on reasons for black listing
874 image gdcmData/oldACR00001.ima
876 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * Test/CmakeList.txt: removed the following from black list (to be coherent
878 with removal from gdcmData):
879 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
880 - gdcm-MR-PHILIPS-16.dcm
882 Added the following because after last cvs update, they cause
883 ctest -R TestReadWriteReadCompare
885 - gdcm-MR-SIEMENS-16-1.acr
887 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
888 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
889 new comments in this file) we temporarily (sigh) move to a weaker
891 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
892 we don't need to black list the following images anymore:
893 - 8BitsUncompressedColor.dcm
895 - US-PAL-8-10x-echo.dcm
896 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
897 fixes and the beautified code ;-)
898 This fixes the bug introduced in version 1.42 (when beautifying)
899 that made the parsing of 8BitsRunLengthColor.dcm unproper.
900 Note: ctest was blind to this bug (this means we need to still
901 improve the test suite). The bug could be detected by using
902 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
904 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
905 and by displaying the (garbage) produced file temp.XDCM...
907 2004-06-29 Jean-Pierre Roux
908 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
909 - replace by uggly but working old code :-(
910 A lot of things should be OK again.
911 It's really urgent to have a test suite that *tests*,
912 to prevent Frog's beautifying sessions to break all the stuff
913 (twice, withing a fortnigh ...)
915 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
916 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
917 redundancy) to added Test/TestReadWriteReadCompare.cxx
918 * Test/CmakeList.txt: because the compare test of
919 Test/TestReadWriteReadCompare.cxx fails, the following images are
920 black listed: - 8BitsUncompressedColor.dcm
922 - US-PAL-8-10x-echo.dcm
923 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
924 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
925 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
926 and ad-hoc kludge. This kludge is now removed, and on encountering
927 such an image (OB field brain damaged) we set errno. Then in
928 ::FindDocLength() we "fix" the length as being ALL what remains
929 in the file (until EOF). We then proceed, hoping for the best...
930 This fixes a SegFault in ShowDicom when trying to write such an
932 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
933 (because TestWriteRead breaks on it, after a non conformal commit?).
934 ctest now runs properly, except for MakeDicomDir (which was allways
935 broken) and the Python related stuff (still not fixed).
937 2004-06-24 Jean-Pierre Roux
938 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
939 FIX : Test/TestReadWrite now iterates on all the file names
940 (instead of infinite loop)
941 ENH : Test/TestWriteRead now iterates on all the file names
943 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
946 2004-06-24 Jean-Pierre Roux
947 FIX : - now Write drops LUT Descriptors and LUTs (if any)
948 when SamplesPerPixel =3
949 - now Write is no longer confused by
950 'BitsAllocated = 12" and 'BitsStored=12"
951 - "UN" value representation Elements are now written correctly
952 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
953 ENH : - now gdcmHeader has its own Write methods
954 (in order to split the job that has not to be done
957 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
959 loop on the same image until memory went out.
960 Note: this means we still have gobs of memory loss in PrintDocument
961 * src/gdcmDocument.cxx: fixes problem on parsing on file
962 gdcmData/16BitsJpegLosslessGrayScale.dcm.
964 2004-06-24 Jean-Pierre Roux
965 FIX : Write - All the Sequences and Sequence Item are now written
966 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
967 is added a the end, when necessary.
968 - A lot of brain-damaged images, that were read correctly are
969 now written correctly
970 - length compatible BinEntry are now loaded correctly
971 (even for odd groups)
972 Note : only Explicit Value Representation was checked.
973 (question : is implicit VR really necessary for gdcm ?)
975 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
976 * DEVELOPPER: added a proposition of coding style.
977 * src/gdcmDocEntry.h: removed every inline declaration (for test of
980 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
982 Use the gdcmDocEntry::Print() and Write() instead.
983 * src/gdcmDocument.cxx: bug fix.
985 2004-06-22 Jean-Pierre Roux
986 FIX : gdcmDocument.cxx
987 - Now we do recognize the JpegLossLess format (there was a misstyping in
988 code 'beautyfication' :-(
989 - Now we automaticaticaly load the Luts, if any
991 2004-06-22 Jean-Pierre Roux
992 In order : to write Sequences, whatever their imbrication level,
993 : to allow user to create his own Sequences
994 a lot of modif where necessary (adding, moving, or virtualising methods)
996 WARNING : save your own sources *before* cvs up !
999 ADD virtual void Write(FILE *fp, FileType filetype);
1002 ADD virtual void Write(FILE *fp, FileType filetype);
1003 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1006 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1007 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1008 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1009 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1010 ADD std::string GetEntryByName(TagName name);
1011 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1013 std::string vr = "unkn",
1014 std::string fourth = "unkn",
1015 std::string name = "unkn");
1016 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1017 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1018 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1019 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1020 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1021 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1022 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1023 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1026 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1027 ADD virtual std::string GetEntryByName (TagName tagName);
1028 ADD virtual std::string GetEntryVRByName (TagName tagName);
1029 REM virtual bool Write(FILE *, FileType);
1030 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1031 FILE *_fp, FileType type);
1032 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1033 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1034 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1035 REM virtual std::string GetEntryByName (std::string tagName);
1036 REM virtual std::string GetEntryVRByName (std::string tagName);
1037 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1038 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1039 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1041 std::string vr = "unkn",
1042 std::string fourth = "unkn",
1043 std::string name = "unkn");
1044 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1045 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1046 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1047 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1050 ADD virtual void Write(FILE *fp, FileType filetype);
1053 ADD virtual void Write(FILE *fp,FileType filetype);
1056 ADD virtual void Write(FILE *fp, FileType filetype);
1057 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1058 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1059 REM std::string GetEntryByName(TagName name);
1062 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1064 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1065 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1066 The default constructor invoked by the line
1067 gdcmHeader *f1 = new gdcmHeader( header );
1068 was gdcmHeader::gdcmHeader(bool) instead of the expected
1069 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1070 Hence the parsing wasn't executed... See also below.
1071 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1072 as explicit constructor didn't do the trick to fix the above problem.
1073 Could anyone explain why ?
1074 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1075 properly calls gdcmValEntry::Print() (that was weed out from
1076 code related to gdcmBinEntry).
1078 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * In order to fix memory leaks:
1080 - Test/TestWriteSimple.cxx: added cleaning of free store through
1082 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1083 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1084 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1085 (through the call to ::AddDicomDirMeta()) or the destructor
1086 would crash when deleting uninitialized ::metaElems].
1087 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1088 - src/gdcmDocument.cxx:
1089 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1090 from dynamic stores.
1091 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1092 was causing memory leaks.
1093 - src/gdcmSQItem.cxx:
1094 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1095 cleanly handled with polymophism: sorry but my milage is low).
1096 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1097 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1098 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1099 This avoids SegFaulting.
1100 - src/gdcmSQItem.h: coding style.
1102 - Test/TestWriteSimple still severely sucks. The output image content
1103 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1104 damaged when displayed with vtkgdcmViewer.
1105 - on memory leaks: TestWriteSimple leaks really less (see entry
1106 of 2004-06-18 in Changelog file for the call to valgrind).
1107 - on segfaults: ctest now passes all the tests but one (no more
1109 * Erroneous leading white fix:
1110 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1111 white[s] (as opposed to from >> xxx, that removes it [them].
1112 - src/gdcmTS.cxx: ditto.
1113 - gdcmPython/testSuite.py: dirty related kludge removed.
1114 * src/*: remaining references to gdcmParser removed.
1115 * src/*[cxx|h]: added copy[way]left header.
1118 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * In order to fix writing of dicom files:
1120 - Test/TestWriteSimple.cxx: a simpler example of writing.
1121 - Test/CMakeLists.txt changed accordingly.
1122 - src/gdcmDocument.cxx:
1123 -- The destructor now recursilvely removes potential sequences.
1124 -- Bug fix in ::IsJPEG2000()
1125 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1126 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1128 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1129 to only declared) and build on top of
1130 ::GetDocEntryByNumber(guint16, guint16).
1131 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1132 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1133 for usage in destructor and treatement of promotion in
1134 ::ReplaceOrCreateByNumber().
1135 - src/gdcmSQItem.cxx: destructor should better handle his job.
1136 Test/TestWriteSimple now runs (or at least it DOES something).
1137 * We can now start hutting memory links. A good starting point is:
1138 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1139 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1140 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1142 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1143 * Valgrind note: after Mathieu Malaterre teached me how to read
1144 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1146 Using gcc, you can force the STL to use malloc and to free memory as
1147 soon as possible by globally disabling memory caching.
1148 With 3.2.2 and later, you should export the environment variable
1149 GLIBCPP_FORCE_NEW before running your program.
1150 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1151 simply vanish (it is still not clear to me, whether this means that
1152 STL std::string leaks or if valgrind believes it leaks...).
1153 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1154 running bin/gdcmTests makeDicomDir):
1155 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1156 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1158 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1159 SegFaulting (I drowned in DicomDir related code when trying to
1160 understand why the list is empty...).
1161 * src/gdcmDocument.h: first BSD license header try.
1162 * Doc/License.txt added.
1164 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1165 * src/gdcmDocument.[h|cxx]:
1166 - Clean up of the Transfer related predicates. They are now all based
1167 on new method isGivenTransferSyntax, that (should) handle properly
1168 the padding problem.
1169 - general clean up, simplification, and coding style.
1170 - Specific clean up of Parse7FE0() (umproperly named actually).
1171 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1173 2004-06-14 Jean-Pierre Roux
1175 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1176 - fix the display of SQItem ordinal number
1177 - add the GetSQItemByOrdinalNumber method
1178 - remove some useless never written private methods
1180 2004-06-14 Jean-Pierre Roux
1182 - adding a constructor taking a gdcmDocEntry as an input param
1183 - ReplaceOrCreateByNumber now returns :
1184 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1185 a gdcmValEntry * if a string value is passed as a param
1187 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1188 according to the param type (no longer sets a gdcmDocEntry)
1189 - GetValEntryByNumber, GetBinEntryByNumber added
1190 - NewValEntryByNumber and NewBinEntryByNumber added
1192 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1194 - GetSQItemNumber and SetSQItemNumber added, to provide
1195 a (relative) Item identier inside a given Sequence
1196 \warning : some pb remaining around this number
1198 - AddEntry now takes the Item Number as a param
1200 - adding a constructor taking a gdcmDocEntry as an input param
1202 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1203 * Memory leak hunt with the following command:
1204 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1205 --show-reachable=yes gdcmTests PrintDocument
1206 It looks like many (all?) leaks are due to the STL (or a bad usage
1207 of the STL. The lines producing the leaks now have a comment with
1208 a "MEMORY LEAK" tag: you can retrieve them with
1209 grep "MEMORY LEAK" src/*
1210 Here are two typical examples which I can't help fixing:
1215 char * test = "babo";
1216 name = test; //// <--- valgrind detects 960 bytes lost in
1217 //// call to std::string::operator=(char const*)
1218 name.clear(); //// Doesn't help !
1226 std::cout << "Type a bunch of characters followed by RETURN: ";
1227 getline(std::cin, line); //// <--- valgrind dectects a loss
1228 //// of 1320 bytes in call to
1229 /// std::basic_istream<>& std::getline<>
1235 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1236 * src/gdcmHeader.[cxx|h]:
1237 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1238 and related, moved away to gdcmDocument.
1239 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1240 the corresponding protected accessors of inherited class
1241 gdcmDocument, removed ! As a consequence gdcmFile had to be
1242 declared friend of class gdcmDocument (see below).
1243 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1244 - Clean up of undefined or unused methods.
1245 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1246 account the changes to gdcmHeader.h).
1247 * src/gdcmDocument.h:
1248 - gdcmFile is now a friend class (in order to take into account the
1249 changes to gdcmHeader.h).
1250 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1251 (see changes to gdcmHeader.h).
1252 - Accessors (reading on the form GetEntry*) are now public.
1253 - Clean up of undefined or unused methods.
1254 * src/gdcmDocument.cxx:
1255 - adaptation to changes to gdcmDocument.h
1256 - ::OpenFile now writes a verbose message when file cannot be opened.
1257 - some std::string properly set to VRKey
1258 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1259 references to gdcmDocument.
1260 * Test/TestFindTags.cxx: changed accordingly to above changes.
1261 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1262 cvs repository gdcmData.
1264 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1266 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1267 conflicts with gdcmValEntry::voidArea.
1268 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1269 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1270 Value representation between StringRepresentable and BinaryRepresentable.
1271 * src/gdcmDocument.cxx:
1272 - method ParseDES: proper indentation restored and usage of
1273 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1274 - method LoadDocEntry: the fingerprint left in the SetValue() of
1275 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1276 removed. Reverting to previous code segment with the proper
1277 dynamic_cast< gdcmValEntry* >.
1278 Note: this was (partially) breaking the python test suite
1279 (gdcmPython/testSuite.py) that made usage of the above
1280 fingerprint to check presence of "Pixel Data".
1281 * src/gdcmDocEntry.h: coding style.
1282 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1283 now taken into account.
1284 * gdcmPython/gdcm.i: adaptation to the new internal representation
1285 of gdcm (exit gdcmParser, hello gdcmDocument).
1286 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1288 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1289 anymore, but instead prints the loaded Python dictionary.
1290 * .... alas, the python testSuite is still broken.
1292 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1293 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1295 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1296 * src/gdcmUtil.h : export methods
1298 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1299 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1301 * Initial addition of automatic python testing
1302 * Initial addition of automatic image comparison
1304 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1305 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1306 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1308 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1309 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1310 * Test/ShowDicom.cxx : bug fix for msvc compilation
1311 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1313 2004-05-04 Jean-Pierre Roux
1314 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1315 new concepts (and new classes) :
1316 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1317 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1318 - Sequence Doc Entries (gdcmSeqEntries)
1319 a Sequence is composed of Items.
1320 Each item is a set of Doc Entries (this is recursive)
1321 The non uniqueness of the 'Dicom tag' is due to this recursivity
1322 (never taken into account)
1323 Our unability to add a new 'entry' in the header
1324 at the proper location (neither in the H-Table (map or multimap),
1325 nor in the Chained List is also due to this recursivity.
1326 Don't try, right now, to use/modify/compile these new sources :
1327 nothing is finished.
1328 We just commit all the stuff, 'as is', in order not to loose it.
1330 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1331 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1333 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1334 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1335 file prefix (SetFilePrefix)
1337 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1338 * Add a new test: ShowDicom, for now this is just the c++ version of
1339 checkRead.sh, later it will be able to compare the image read against a
1341 * Replace the DEBUG on the stack with a global entry in cmake interface:
1342 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1344 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1345 * Add an example subdir, with a real example on how to read + write a
1348 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1349 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1350 * Doc/CMakeLists.txt: the main page is now properly differentiated
1351 between the developper and user version.
1352 * Doc/doxygen.config.in: dropped search related obsolete flags
1353 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1355 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1356 * DEVELOPPER: added some helpfull comments for compile/test/install
1359 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1360 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1361 src directory, now generated in the build dir.
1362 2. Tests as mentionned smarter
1364 4. Add a new method in gdcmDict that return the PubDict by name
1365 this is interesting for 3rd party lib like ITK,
1366 where we could set the institution name / patient name...
1368 * ENH: 1. Now the test suite is working for real
1369 2. All binaries are now output in the gdcm-bin directory
1370 (this was not true before)
1372 2004-04-28 Jean-Pierre Roux
1373 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1374 SeQuence indented printing of Dicom Header.
1375 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1376 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1377 Computation of SQDepthLevel is now part of gdcmHeader constructor
1378 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1379 tree-like structure of a Dicom Header.
1380 * FIX Test code cleaning
1382 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1383 * ENH: Adding automatic testing
1384 1. Need a DartConfig.cmake to submit to public
1385 2. Add a test driver gdcmTest.cxx
1386 3. gdcmTestMain, an helper for the main test driver gdcmTest
1387 4. Files in Test don't have a main anymore, this becomes interesting
1388 when we add more and more tests, thus dsw don't have to load
1390 * ENH: Adding a GDCM_DATA_ROOT for testing
1391 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1392 one file instead of seven + some small cleanup
1394 2004-04-22 Jean-Pierre Roux
1395 * ENH Minor changes to the Print() methods.
1396 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1397 Header printing. Example given with :
1398 > PrintHeader fileName 2 new
1399 (SQ based tree-like structure still to be done for the Header ...)
1401 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1402 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1403 1. I have added some unsigned where needed
1404 2. Some function parameter not used -> (void)
1405 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1406 4. g++ don't like character '\' in comment
1407 5. #define jpeg_create_decompress jCreaDecompress
1408 this really need to be fixed
1409 6. virtualize destructor of gdcmObject ... leakage
1410 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1411 this also really need to be fixed
1412 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1413 remove compression file
1414 (as we only do decompression, right ?)
1415 * ENH: Change malloc/calloc/free with c++ equivalent
1417 2004-04-21 Jean-Pierre Roux
1418 * FIX gdcmHeaderHelper::GetXSpacing
1419 when a single value is found (bug ?), xpacing is now
1420 defaulted to yspacing
1422 2004-04-19 Jean-Pierre Roux
1423 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1424 * ENH add parameters :
1425 bool exception_on_error = false,
1426 bool enable_sequences = false,
1427 bool ignore_shadow = false
1428 to the gdcmFile constructors to be full gdcmParser compliant
1429 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1430 to allow reading of PAPYRUS 3.0 files
1432 2004-04-06 Jean-Pierre Roux
1433 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1435 2004-04-02 Jean-Pierre Roux
1436 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1437 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1438 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1440 2004-03-30 Jean-Pierre Roux
1441 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1442 for ACR file, written out as DICOM files (hope so...)
1444 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1445 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1446 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1447 moved to base class gdcmParser and only the specialisation is kept
1449 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1450 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1451 already does the job.
1452 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1453 (to be consistent with gdcmParser::WriteEntries).
1455 2004-03-30 Benoit Regrain
1456 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1457 upate of the object's instance. It's passed to 2 in the unfavorable
1458 case : one in the ExecuteInformation, one in the ExecuteData
1460 2004-03-29 Jean-Pierre Roux
1461 * ENH : Check on file type to be written moved
1462 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1463 * FIX : gdcmObject::ResetBoundaries now stops properly
1464 when end-of-list is reached
1465 : gdcmVersion modified (as Benoit Regrain asked)
1467 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1468 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1469 * src/gdcmUtil.cxx: added forgotten iostream include.
1470 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1471 equivalent to ExplicitVR in existing code).
1473 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1474 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1475 now contains all the gdcmGlobal related code.
1476 * minor coding style and doxygenation changes.
1478 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1479 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1480 now contains all the Debug related code.
1481 * minor clean-up of includes in src/*.cxx
1482 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1483 CreateCleanString) removed.
1484 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1485 * Doc/DoxyMainPageUser.txt added.
1486 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1487 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1488 src/gdcmDirList.cxx)
1490 2004-03-24 Jean-Pierre Roux
1491 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1493 2004-03-23 Jean-Pierre Roux
1494 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1495 big endian made volumes
1496 * ENH Now gdcmParser constructor and destructor are protected to forbid
1497 end user to instanciate class gdcmParser
1498 (only gdcmHeader and gdcmDicomDir are meaningfull)
1500 2004-03-22 Benoit Regrain
1501 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1502 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1503 gdcmSerie to gdcmDicomDirSerie
1505 2004-03-19 Jean-Pierre Roux
1506 * ENH Now the tree-like structure describing a DICOMDIR comming from
1507 an already existing DICOMDIR file is consistent with
1508 the home-made tree-like structure build ex-nihilo
1509 or build from the files held (recursively) in a Directory
1510 functions gdcmDicomDir::CheckBoundaries()
1511 gdcmObject::SetBoundaries() added
1513 2004-03-17 Jean-Pierre Roux
1514 * REM (Eric Boix bug) : removal of meaningless
1515 gdcmDicomDirImage::NewImage function.
1516 * FIX now file names and directory name are written properly in the
1518 * FIX now gdcmDicomDir constructor may be call without any trick
1521 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1522 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1523 of gdcmDicomDirImage::NewImage as empty function.
1525 2004-02-28 Jean-Pierre Roux
1526 * ENH add gdcmDicomDir:NewPatient
1527 add gdcmDicomDirPatient:NewStudy
1528 add gdcmDicomDirStudy:NewSerie
1529 add gdcmDicomDirSerie:NewImage
1530 to allow making gdcDicomDir object.
1531 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1532 (as opposite to the gdcmHeader chained list)
1534 2004-02-11 Benoit Regrain
1535 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1536 when using from python
1538 2004-02-10 Benoit Regrain
1539 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1540 * FIX : in gdcmDicomDir when the directory is empty
1541 * ENH : add callback and methods to get the progression of dicomDir
1544 2004-02-06 Jean-Pierre Roux
1545 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1546 - GDCM_META added to gdcmDicomDirType
1547 - class gdcmMeta created
1548 * ENH : - A brief summary is now displayed at the beginning of
1549 'testDicomDir' to help disaster magnitude estimation
1550 * REM : Now useless Test/explDICOMDIR.cxx
1552 2004-02-05 Benoit Regrain
1553 * ENH : add methods in gdcmObject to get the hash table or the list of
1555 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1556 * FIX : wrapping python for TagHeaderEntryHT
1558 2004-02-04 Benoit Regrain
1559 * FIX : even length for some strings when writting the dicom dir
1560 * FIX : sort the images in the dicom dir
1561 * FIX : Bug fix for python use of dicom dir
1562 * ADD : a python demo
1564 2004-02-04 Jean-Pierre Roux
1565 * FIX : Final solution (?) for icone embedded images
1566 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1567 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1568 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1569 gdcmData/gdcm-MR-SIEMENS-16.acr1
1570 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1571 to make full checking easier
1573 2004-02-04 Benoit Regrain
1574 * FIX : WriteEntries : coding style & logic in parameters
1575 * FIX : Set the elements to create the DicomDir in a dictionary file
1577 2004-02-03 Benoit Regrain
1578 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1579 * gdcmDicomDir : add the load of directory
1580 * Bug fix and print add-on
1582 2004-02-03 Jean-Pierre Roux
1583 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1584 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1585 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1586 * FIX gdcmParser.cxx : 'group length' elements are now considered
1587 as integers, even for shadow groups, when file is Implicit VR
1589 2004-02-02 Jean-Pierre Roux
1590 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1592 of the last synonym :-(
1593 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1595 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1596 * FIX taking into account the possible 7fe0,0010 multiplicity
1597 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1598 to allow removal of references to 7fe0,0010, to deal with
1599 ACR-NEMA images, when 0028,0200 is meaningfull
1601 2004-01-31 Jean-Pierre Roux
1602 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1603 no longer writes 'Un' on disk
1604 * FIX SQ elements with actual length are now dealt with corectly
1605 * FIX gdcmFile::WriteBase make the difference, for color images, between
1606 the length (for Palette expanded images)
1607 and Raw Length (non expanded image + Palette)
1608 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1609 (that broke Write). Replaced by UL.
1610 Aware user will reload the field if he
1611 thinks it's necesssary
1613 2004-01-30 Jean-Pierre Roux
1614 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1615 when 'dirty Acr' is found, to be compliant with the new
1616 IsReadable() methods.
1618 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1619 (no DOUBLE images in kosher DICOM,
1620 but so usefull for people that miss them ;-)
1622 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1623 DICOMDIR related utilities (not checked as Windoze compliant)
1625 2004-01-28 Jean-Pierre Roux
1626 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1628 2004-01-27 Jean-Pierre Roux
1629 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1630 to allow skipping the shadow elements, to save memory space.
1631 The TRUE value for this param has to be used
1632 with a FALSE value for the 'enable_sequence' param.
1633 ('public elements' may be embedded in 'shadow Sequences')
1634 * gdcmHeader methods now deal with 'embedded icones images' in the header
1635 (even when an 'icone image sequence' is announced by the
1636 element (0x0088,0x0200), but there is NO icone at all ...
1638 * gdcmHeader sometimes Image Location value doesn't follow
1639 the supposed processor endianity (see gdcmData/cr172241.dcm).
1642 * gdcmHeader add the method
1643 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1644 to get *all* the Header Entries with the same tag.
1645 GetHeaderEntrySameName is probabely *useless*
1646 (no meaning : Name is *not* an identifier within the Dictionnary)
1648 2004-01-26 Benoit Regrain
1649 * Bug fix in the print of hexadecimal representations. Remove long fields
1650 in the print and add a third level of print to print them
1652 2004-01-23 Benoit Regrain
1653 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1654 * Bug fix on test suite after remove the strip made on not string fields
1655 * Split the IsReadable method between gdcmParser which test that the file
1656 is dicom and gdcmHeader which test that it's an image file
1658 2004-01-22 Benoit Regrain
1659 * DicomDir : clean code, add methods, set variables in protected or private
1660 * gdcmUtil : bug fix for the clean string method
1662 2004-01-19 Benoit Regrain
1663 * Add the use of shadow dictionaries
1664 * bug fix and coding style
1666 2004-01-19 Benoit Regrain
1667 * src/gdcmFile.cxx : bug fix concerning the close of file
1668 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1669 * Add the update of header entries using the shadow library
1671 2004-01-19 Benoit Regrain
1672 * removal of file gdcmHeader2.cxx
1673 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1674 inheriting from gdcmParser. This split is to prepare the integration
1675 of dicom dir parsing
1676 * bug fix under python
1678 2004-01-16 Jean-Pierre Roux
1679 * REM removal of class gdcmHeaderEntrySet
1680 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1681 * ADD add file gdcmHeader2.cxx
1682 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1684 2004-01-15 Benoit Regrain
1685 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1686 entries created while parsing the header. Thus, they will be destroyed
1687 when the gdcmDictSet will be destroyed
1688 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1691 2004-01-15 Benoit Regrain
1692 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1693 made a fatal error because of the memory release at the end of program.
1694 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1695 some memory and vtk seems to have some problems with that.
1696 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1698 2004-01-14 Benoit Regrain
1699 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1700 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1701 * src/*.[h|cxx] : make changes due to class name changes
1702 * gdcmPython/demo/*.py : bug fix due to method names
1704 2004-01-13 Benoit Regrain
1705 * src/*.[h|cxx] : coding style
1706 * vtk/*.[h|cxx] : coding style
1708 2004-01-13 Benoit Regrain
1709 * gdcmPython/testSuite.py : test the readable flag of file for tests
1710 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1711 It's lied to the stl compilation by MSVC (windows, always windows...)
1712 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1714 2004-01-12 Benoit Regrain
1715 * src/*.h : add comments
1716 * src/gdcmDictSet.h : set the method BuildDictPath in public
1717 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1718 directly setted in the source code
1719 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1722 2004-01-09 Benoit Regrain
1723 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1724 * setup.py : use a reference to gdcmVERSION
1726 2004-01-07 Benoit Regrain
1727 * Modification to compile with the distutils.
1730 2003-12-10 Benoit Regrain
1731 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1732 can use a gdcmHeaderHelper to load datas
1733 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1734 made in the source code
1736 2003-12-10 Benoit Regrain
1737 * Update Windows projects and .cvsignore files
1739 2003-11-12 Jean-Pierre Roux
1740 * ENH gdcmHeader constructor has one more parameter (default value : false)
1741 that allows the user to 'go inside' the SeQuences only
1743 gdcmElValSet:Print takes it into account
1745 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1746 * ENH: Update gdcmPython/CMakeLists
1747 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1748 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1750 2003-11-10 Jean-Pierre Roux
1751 * FIX : gdcmHeader::LoadElements is now based
1752 on the ListTag listElem member,
1753 not longer on the TagElValueHT tagHt member
1754 * ENH : PrintPubElVal shows (temporarily) both results,
1755 with the tagHt member and the listElem member.
1756 (it's easier to 'see' the problems when using Printheader)
1758 * FIX : old private member LgrElem is now splitted into
1759 ReadLength : Length actually found on disk (updated only
1760 if bug fixing is necessary), for internal
1762 UsableLength : Updated by FixFoundLength, to fix a bug
1763 or to allow Parser going on.
1764 Will allow to re-write a kosher header when a SeQuence
1765 with a length (not 0000) is found
1766 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1767 because gdcmElValSet::Add does not update ListElem
1770 2003-11-07 Jean-Pierre Roux
1771 * FIX misstyping in Transfert Syntax name table
1772 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1773 when they have an actual length (not 0000 nor FFFFF)
1774 (Nobody should care of it, but DICOMDIR explorers)
1776 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1777 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1779 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1780 * ENH: vtkGdcmReader now supports LUT !
1781 (vtkgdcmViewer for now is not able to use them though)
1783 2003-11-05 Jean-Pierre Roux
1784 * in testSuite.py : new files names for checking the package
1785 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1786 that returns the pixel area size to the *aware* (vtk) user
1787 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1789 2003-11-05 Benoit Regrain
1790 * in testSuite.py : Modify the rules for checking the paths
1791 : Explicit error messages
1792 * in __init__.py : Related modif
1794 2003-11-03 Jean-Pierre Roux
1795 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1796 to be used by aware (vtk) users that want to manage
1797 LUT (and no to turn the PALETTE image into an RGB pixels one)
1798 * GetPixelType now returns 8U for 24 Bits images
1799 (vtkGdcmReader compliant)
1801 2003-10-31 Jean-Pierre Roux
1802 * Removal of *all* gdcmData images and add them again
1803 in order to loose the 'history' of un-anonymised images
1805 2003-10-31 Jean-Pierre Roux
1806 * RMV : removal of useless jBitsInJsample.h
1807 for both 8 and 12 Bits JPEG Lossy Libraries
1809 2003-10-31 Jean-Pierre Roux
1810 * ENH : Add the functions gdcmFile::GetImageDataRaw
1811 gdcmFile::GetImageDataIntoVectorRaw
1812 that act as GetImageData and GetImageDataIntoVector
1813 except the making of an RGB Plane from Gray Plane + LUT
1814 Intended to aware (vtk) users who know how to manage
1817 GetLUTRGBA return a R,G,B,A LUT if any
1818 lgrTotaleRaw gives the 'Raw' length
1819 GetImageDataRaw returns the gray Plane
1820 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1821 (They stay Grey, just like with other Dicom viewers :-(
1823 2003-10-30 Jean-Pierre Roux
1824 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1826 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1828 being coherents dicom files.
1830 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1831 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1833 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1834 * ENH: Two steps is necessary to please VC++ compiler...
1835 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1836 * ENH: Add include dir to medcon lib
1837 * FIX: only one function is being exported for now !
1838 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1840 2003-10-29 Jean-Pierre Roux
1841 * adding gdcmHeader::GetLUTRGBA
1842 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1843 --> Mathieu, the modif u're waiting for is not yet committed
1844 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1846 2003-10-27 Jean-Pierre Roux
1847 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1848 00191113.dcm DermaColorLossLess.dcm
1849 MxTwinLossLess.dcm RadBWLossLess.dcm
1850 * ENH: For version prior to vtkImageViewer2 -r 1.19
1851 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1853 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1854 * Removal of ido stuff in CMakeLists.txt
1856 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1857 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1858 * FIX: remove a call to ->Modified ... see comments
1859 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1861 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1862 * FIX: Problem with path for libvtkgdcmPython
1863 * ENH: Try adding a search script for python site-package
1864 * RMV: Remove some file from medcon lib that are not necessary
1865 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1866 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1867 * FIX: More pragma disable fro VC++,
1868 I don't think I break something as it is also disable in VTK/ITK.
1869 But it fasten debug compilation time.
1871 2003-10-23 Jean-Pierre Roux
1872 * gdcm now deals with 16 Bits Run Length Encoded images
1873 (they are compressed as 2 planes images,
1874 one for the high Bytes, the other for low Bytes)
1876 2003-10-22 Jean-Pierre Roux
1877 * Now CheckRead takes into account :
1878 - the bugged 'Leonardo' Siemens images
1879 - the XA images, sent thru the burning VPRO station
1880 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1883 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1884 * FIX: When copying a Makefile.am to CMakeLists.txt
1885 one should remove the '\'
1887 2003-10-22 Jean-Pierre Roux
1888 * in gdcmData adding a bugged 'Leonardo' Siemens image
1889 (wrong lengths in header)
1890 OK with gdcm, KO with the other viewers :-)
1891 * add a GE dlx XA image, thru the VEPRO burning station
1894 2003-10-21 Jean-Pierre Roux
1895 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1896 for a brutal checking of vtkgdcmViewer compliance
1898 2003-10-21 Jean-Pierre Roux
1899 * add the files for 'xmedcon' Jpeg Lossless library
1900 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1902 2003-10-21 Jean-Pierre Roux
1903 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1905 2003-10-21 Jean-Pierre Roux
1906 * garbage Siemens 'Leonardo' images dealt with
1907 (the patch is easy to remove)
1908 * cosmetic changes to avoid warnings
1910 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1911 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1912 no need to press 'r' now.
1914 2003-10-20 Jean-Pierre Roux
1915 * upgrade of checkRead.sh checkWrite.sh according
1916 to new Jpeg Lossless decompressor
1917 * add US.3405.1.dcm, a genuine RGB medical file ...
1918 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1919 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1921 2003-10-15 Jean-Pierre Roux
1922 * general anonymisation in gdcmData
1923 * adding the 'color files' from
1924 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1925 * adding some well knowed bugged-header images
1926 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1927 waiting for their inclusion in Python testsuite
1929 2003-10-15 Jean-Pierre Roux
1930 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1931 no longer seg faults when file is not found
1933 2003-10-14 Jean-Pierre Roux
1934 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1937 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1938 * TODO: *.in file to genereate a UseGDCM later
1940 2003-10-14 Jean-Pierre Roux
1941 * Some supposed-to-be Dicom Images have no preamble.
1942 OpenFile takes it into account
1943 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1944 * Missing elements added in dicomV3.dic
1945 (just to be affraid : have a look at
1946 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1947 and do it again next year ;->
1949 2003-10-13 Jean-Pierre Roux
1950 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1951 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1952 But there are NOT. It's fixed !
1954 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1955 * FIX: "jpeglib.h" was not found on VC++
1956 * FIX: vtkgdcm was not being installed
1958 2003-10-10 Jean-Pierre Roux
1959 * ENH : OpenFile closes the file if it *really* doesn't look like
1960 an ACR-NEMA / DICOM one.
1961 * FIX : testWrite no longer writes an empty file if the source file
1962 is not gdcm Readable
1963 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1966 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1967 * FIX: CMake generate now documentation
1968 * ENH: out of source doc build !
1969 * ENH: Generate both user and dev documentation
1970 * ENH: Should work on windows too
1971 * ENH: Only one doxygen config.in file is needed
1972 * FIX: make install should be ok now on ùnix plateform
1973 * FIX: PATH to dictionary was wrong (missing /)
1974 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1976 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1977 * vtkGdcmReader is now able to read rgb dicom file.
1978 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1979 * added a gdcmViewer to vtk test, use mouse to control
1980 window level & window width
1982 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1983 * CMake-ification of gdcm, we have now two build system
1984 * FIX: on cygwin Wsock32 doesn't exist
1985 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1987 2003-10-06 Emanuel Ollart
1988 * FIX : compilation process wad broken.
1989 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1991 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1992 * change gdcmViewer -> vtkgdcmViewer
1993 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1995 2003-10-06 Jean-Pierre Roux
1996 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1997 ( e.g : well known GE images with a wrong elem length,
1998 : Philips MRI Images with a wrong Huffman table)
1999 * still to be done : allow the reading of bugged LEONARDO Siemens images
2001 2003-10-03 Jean-Pierre Roux
2002 * Odd length strings are padded with '\0' (not with spaces,
2003 to remain compliant with already defined strings,
2004 like Transfert Syntax UID and others)
2006 2003-10-03 Jean-Pierre Roux
2007 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2008 to allow displaying RGB images (not only by affim ;-)
2010 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2011 * vtkGdcmReader is now able to read rgb dicom file.
2012 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2014 2003-10-03 Jean-Pierre Roux
2015 * A few nasty patches to allow the reading of a lot of nasty images
2016 ( e.g : well known GE images with a wrong elem length,
2017 : Philips MRI Images with a wrong Huffman table)
2018 * still to be done : allow the reading of bugged LEONARDO Siemens images
2020 2003-10-03 Jean-Pierre Roux
2021 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2023 2003-10-03 Jean-Pierre Roux
2024 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2025 to allow displaying RGB images (not only by affim ;-)
2027 2003-10-03 Jean-Pierre Roux
2028 * gdcmFile::GetImageDataIntoVector now
2029 - deals with MultiFrames MultiFragments Run Length Encoded files
2030 - deals with YcBcR (YBR_FULL) files
2031 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2032 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2034 (no sample found :-(
2036 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2037 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2038 Two reasons: - clear things
2039 - third parties acces gdcm through header files, so won't
2040 suffer anymore VC++ complains
2042 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2043 * add argv[1] in testvtkGdcmReader.cxx
2046 2003-09-24 Jean-Pierre Roux
2047 * The lines are now eigthy characters long.for
2048 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2050 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2051 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2052 char* to std::string. Thus, the use of strdup becomes useless. (see
2053 previous commis of Malaterre)
2054 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2055 before the last Malaterre's commit.
2057 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2058 * This commit should fix the Debug building under VC++, the problem
2059 was mainly a mixture of debug and release lib being loaded at startup.
2060 * I also remove a depency to a specific C function: strdup. Because I had
2061 to force the link to msvcrtd (whereas strdup is in libc).
2063 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2064 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2065 located in the gdcmCommon.h file. All use of reference of tha has been
2066 changed to now use the variable GDCM_UNFOUND.
2068 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2070 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2071 Dicom dictionary. The test suite can now be run again. Note:
2072 I'm note very happy with the " (RET)" changes. I believe this
2073 RETAINED comment should be dropped when parsing the dictionary.
2074 - PACKAGER corrected
2076 - AUTHORS updated and now in alphabetical order
2077 * Makefile.am now exports gdcm.dsw for Windoze users.
2079 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2080 * cygwin complains about missing std:: in subdir Test/
2082 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2083 * remove some methods that are now in gdcmHeaderHelper
2085 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2086 * vtkGdcmReader set spacing and origin correctly
2088 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2089 * Fix a few delete/delete[] mismatch
2091 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2092 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2093 interpretation to data given by gdcmHeader. For instance there are
2094 heuristics to get informations (look at different places).
2095 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2096 sorting DICOM images based on different strategies.
2097 * modified Makefiles accordingly.
2099 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2100 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2101 when building in debug mode
2102 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2103 src/win32/gdcmdll.dsp
2104 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2106 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2107 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2110 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2111 * src/win32/libgdcmjpeg12.dsp was not dos format
2112 * src/win32/libgdcmjpeg12.dsp :
2113 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2114 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2116 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2117 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2119 * src/gdcmFile.cxx : bug fix in affectation type
2120 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2121 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2122 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2123 symbols... future problem ?
2125 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2126 * src/win32/libgdcmijpeg12.dsp was missing
2127 * modified gdcm.dsw accordingly
2129 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2132 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2133 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2134 commit of JPR (before his hollidays to facilitate our work).
2135 * setup.py : bug fix in code. Modifications made while the last commit
2136 of JPR. The code hasn't been tested before the commit... it's so
2137 useless to make that (for best programmer that is JPR) !!!
2139 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2140 * tagged the current version as Version0_3 (i.e. version 0.3)
2142 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2143 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2144 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2145 * *.dsp : modifications to use new libgdcmijpeg8 library
2146 * setup.py : bug fix on VTKPATH variable
2147 * PACKAGER : adding all concerning windows
2149 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2150 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2152 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2153 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2154 test suite reported error.
2155 * PACKAGER file added (describes what a packager must do when
2156 packaging a new release).
2157 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2158 * configure.in: upgraded version number to 0.3.0
2159 * fixing build of rpm (through rpm -ta):
2160 - Doc/Makefile.am exports proper doxygen files
2161 - src/jpeg/libijg8/Makefile.am exports the include files.
2163 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2164 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2165 * src/gdcmHeader.h : formatting code
2167 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2168 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2169 We were obtaining error message from vtk. Now, creation of file list
2170 is made in an internal list to prevent this problem.
2171 Bug fix when output is empty.
2172 Bug fix in update of progress value. Previous commit for this was a bad
2174 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2176 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2177 * src/gdcmHeader.h : added method to get the file name
2178 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2179 files. Added method to remove all files on the input
2180 Added FIXME comment concerning the bad parsing of header made by
2181 ExecuteInformation method (in ExecuteData method)
2183 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2185 when using make instal.
2186 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2187 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2189 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2190 * setup.py : adding include dir of jpeg lib to compile all sources
2191 * */Win32/*.dsp : JPR fix for windows compilation
2193 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2194 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2196 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2197 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2199 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2200 * setup.py is again effective on un*x (takes into account the
2201 addon of the jpeg library)
2202 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2203 * Doc/Doxy* updated (includes above enhancements)
2204 * INSTALL now points to web documentation
2206 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2207 * src/gdcmHeader.h doesn't make unnecessary reference to
2209 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2211 * src/gdcm*.[cxx|h] :
2212 - to allow compilation with gcc 3.x
2213 -- clean up of STL usage (added explicit usage of std::)
2214 -- small fixes on exceptions.
2215 Note: linking not tested !
2216 - clean of doxygen comments to avoid warnings at documentation
2218 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2219 dependent convertion).
2221 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2222 * Clean up of previous JPR garbage commit (not even commented in the
2224 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2225 - moved all jpeg related files from src to src/jpeg/libijg8, with
2226 addition/modification of Makefile.am and configure.in.
2227 - the testSuite is still brain damage (not guilty).
2229 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2230 * WrapVTK.py : modifications to get correctly vtk source files to
2232 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2233 (FileName -> Filename)
2235 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2236 * vtk/vtkGdcmReader.[cxx/h]:
2237 - UpdateProgress method should now be effective
2238 - removed the limitation on having only images loaded (as opposed
2240 - when building a stack of images/volume, a lesser number of
2241 gdcmHeader and gdcmFile instances should be used (hopefully
2242 accelerating things).
2243 - when building a stack of images/volumes, files which are not
2244 loadable (wrong path-filename, wrong permissions on existing file,
2245 or file not parsable by gdcm) are replaced with a black image
2246 in the stack (for the caller to notice the problem).
2248 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2251 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2252 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2253 between standard library (std) and vtk library (problems are found
2254 under Windows... thanks Windows !)
2256 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2257 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2259 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2261 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2262 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2264 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2265 * When compiling with distutils (see setup.py) the C++ compiler is
2266 called with different flags than the default ones (with automake).
2267 In order to fix all those warning, I compiled gdcm with the command
2268 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2269 and went for warning fixes:
2270 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2271 up from unused variables.
2272 - vtk/vtkGdcmReader.cxx: potential bug fix.
2273 * src/gdcmHeader.h: Doxygen warning cleanup
2275 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2276 * gdcmPython/gdcm.i:
2277 - typemaps correction to take into account the systematic replacement
2278 of "using namespace std" with std:: prefix e.g. std::list,
2279 std::string... (cf changes of 2003-05-21).
2280 - gdcmGlob global variable of type gdcmGlobal (defined in
2281 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2282 exported to Python a as cvar.
2283 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2284 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2285 gdcmDictSet.GetPubDictTagNames() and
2286 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2287 C++ static methods).
2288 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2289 with the above changes.
2291 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2292 * setup.py, manifest.in : bug fix under linux
2294 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2295 * Modification of setup.py to compile vtk part too. Then, we have 2
2296 wrappers which must work with same distutils. For that, we have a
2297 generic distutils in distusiltsWrapping.py ; with :
2298 - build_extWrap class to wrap generically all extensions,
2299 - ExtensionWrap base class for all wrapping extension that contains
2301 - Wrapper interface which wrap sources
2302 + In WrapSwig.py we have extension and wrapper for Swig
2303 + In WrapVTK.py we have extension and wrapper for VTK
2304 * MANIFEST.in : modifications to consider vtk directory and new python
2305 files for compilation
2307 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2308 * Added python wrappers of vtkGdcmReader vtk class (see the
2309 source in vtk/vtkGdcmReader.cxx) :
2310 - vtk/Makefile.am now builds a library
2311 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2312 python library (as opposed to _gdcm.so wich are the python
2313 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2314 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2316 - configure.in has an additional flag --enable-vtk that needs
2317 to be set to enable compilation of vtk related code, that is:
2318 + vtk/vtkGdcmReader.so and
2319 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2320 + gdcmPython/vtkgdcmPython.so (see above)
2321 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2322 be read when compressed or when HighBit + 1 != BitsStored),
2323 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2324 the usage of the python wrapper of vtkGdcmReader vtk class.
2325 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2326 * src/*.[h] all occurences of stl classes are now prefixed with
2327 std::, and all occurences of "using namespace std;" where removed.
2328 This is to avoid pollution of global namespace in included files.
2329 Apparently vtk does not avoid this pitfall: when using both
2330 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2331 collision of various stl members (principally cout...).
2332 * gdcmPython/testSuite.py now cleanly removes temprory generated
2334 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2335 comply with above changes)
2337 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2338 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2339 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2340 vtk data structure (an image Flip was required).
2341 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2342 * cosmetic changes in documentation.
2344 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2345 * src/gdcmHeader.cxx: the constructor no longer exits when an
2346 unexisting file is given as argument.
2347 * The subdirectory Data (containing all the images used for the
2348 test suite) is not part of this repository anymore. A new module
2349 containing those images is now available at
2350 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2351 with the name gdcmData.
2352 All the python scripts (including the package initialisation file
2353 gdcmPython/__init__.py) were adapated to take this change into
2354 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2356 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2357 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2358 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2359 demo of the usage of this class.
2360 Compilation of this vtk part is only done when using the --enable-vtk
2361 at configure (or autogen.sh) stage.
2363 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2364 * More memory link related corrections and documentation fixes.
2366 - maximum info is obtained with a command of the form:
2367 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2368 --show-reachable=yes PrintHeader
2369 - the remaining reachable blocks seem to come from the STL
2370 allocation scheme through the usage of map and list. It looks
2371 like this memory cannot be freed but it is not a memory leak
2372 (in fact further invocation to the STL would recollect the
2373 unused memory allthough it cannot explicitely be freed).
2374 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2375 of displaying an image parsed with gdcm and displayed with VTK.
2376 Note: some images don't seem to work e.g.
2377 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2378 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2379 Allthough this weakens the semantics, it is a ditch attempt to
2380 make gdcm more thread friendly.
2382 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2383 * Memory link hunt (by using valgrind through the command
2384 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2385 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2386 gdcmHeader::_dicom_vr.
2387 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2388 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2390 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2392 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2393 * src/Makefile.am now exports all the necessary include files at
2397 * UpdateGroupLength replaced by new one
2400 * UpdateGroupLength re-written using H-Table
2401 (named UpdateGroupLengthNew untill checks are over)
2403 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2404 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2405 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2407 - gdcmHeader::GetPubElValSet removed.
2408 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2409 UpdateGroupLength, WriteElements, Write.
2410 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2411 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2412 carried the same semantics.
2413 - src/gdcmHeaderIdo.cxx changed accordingly.
2414 - gdcmFile::WriteBase now regroups all the codes from previous
2415 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2416 - enum FileType moved to gdcmCommon.h
2417 * src/gdcmHeader.cxx AddDefault trashed
2418 * gdcmGetXSize added
2419 * getimageDataSize now calls gdcmGetXSize
2420 * Test/*.cxx changed to agree with above changes
2422 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2423 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2424 (to avoid double call by end user).
2425 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2426 by end user, since gdcmHeader::gdcmHeader now handles it.
2428 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2429 * gdcm/Doc many doxygen changes:
2430 - Doxyfile now has two different versions, DoxyfileUsers that generates
2431 the html.users end users oriented documentation and
2432 DoxyfileDeveloppers that generates the html.developper developper
2433 oriented documentation.
2434 - README changed accordingly
2435 - requirement.txt removed (old design info moved to TODO).
2436 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2437 DoxyMainPage.txt, DoxyPython.txt provide more information.
2438 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2439 be updated by simply regenerating the docs with doxygen and copying
2440 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2441 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2442 all the tests in the form "if (<map>.count() >1)" were removed.
2443 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2444 ill-formed documentation sections.
2445 * src/gdcmHeader.cxx: ditto
2447 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * setup.py fixed for un*x (needed macro for stdint.h)
2449 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2450 un*ces with sh-utils test utility.
2451 * gdcmPython/demo/test.py renamed to PrintHeader.py
2452 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2453 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2454 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2455 * src/gdcm*.cxx JPR's bad inclusion fixed.
2457 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2459 * gdcmPython/demo/test.py changed accordingly.
2461 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * gdcmPython/Makefile.am fixed linking against libstdc++
2463 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2464 * Swig subdir (historical tests of swig version 1.3.17++) removed
2465 * Test/testChangeEntete.cxx some lines commented out in order to make
2467 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2468 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2470 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2472 hence the user doesn't need this explicit call.
2473 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2474 i.e. LoadElements() call removed.
2475 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2476 - src/Makefile.am declares the proper flag for g++.
2477 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2478 for adding user defined new tags.
2479 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2480 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2481 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2483 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2484 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2485 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2486 src/Makefile.am : the project should properly compile and install
2487 with the autotools, included the python wrappers part.
2488 * gdcm.spec.in : added a spec file for RPM packaging.
2490 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2491 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2493 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2494 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2495 to exported to the environement (see gdcmPython/testSuite.py
2497 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2498 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2499 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2500 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2501 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2503 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * gdcmPython/__init__.py doesn't crash anymore when running in
2505 in InstallMode or PreInstallMode but with an environement given
2506 value of GDCM_DICT_PATH.
2507 * src/gdcmDictSet.[cxx/h] coding style.
2509 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2510 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2511 * src/gdcm.h general comments moved to TODO, and README
2512 * src/gdcm.h should now be seen as a user commodity (including it
2513 should suffice to fully use gdcm). It is nowhere including within
2514 any of the kernel files src/*.cxx and src/*.h.
2516 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2518 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2520 * src/gdcm*.cxx only include their corresponding include file
2521 (as opposed to gdcm.h)
2522 * gdcmPython/gdcm.i changed accordingly
2523 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2524 the autogen.sh generated "make snapshot" command to work.
2525 * autogen.sh removed history related references to crea package.
2527 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2528 * distutilsSwigCPlusPlus.py work around some swig portability
2531 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2533 was done in a last ditch attempt to get setup.py _really_
2534 operationnal. The python/gdcmPython layaout add the advantage
2535 of hidding away the python related distutils specific files
2536 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2537 Alas, the src directory was out of scope (i.e. it's relative
2538 position to setup.py was ../src) which made things impossible to
2539 handle (see previous version of python/setup.py). Crossing fingers...
2541 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * python/setup.py now works on Un*x. (harder than I thougth)
2543 * python/distutilsSwigCPlusPlus.py can now have include files
2544 among the list of sources.
2546 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2547 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2548 * modifications in MSVC projects
2550 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2551 * As stated by the first lines of Test/ExceptionAndPython/README, it
2552 looks like we can move back to original usage of exception within
2553 src/gdcm* and hence remove the errno stuff that was introduced
2554 as a quick and dirty fixture of this problem (added to the TODO).
2555 * Doc/Doxyfile configuration file for Doxygen and corresponding
2556 README file for usage added.
2557 * Test/testWrite.cxx added. This new test comes from a split of
2558 test.cxx that is now reverted to its original purpous i.e.
2559 testing the proper parsing of a Dicom related file.
2560 testWrite.cxx concentrates on testing the IO part of gdcm.
2561 * Test/bug1.cxx (containing a bug on WIn32) added.
2562 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2563 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2564 whose purpose is to publish the content of the TagNames of the
2565 Dicom public dictionnary were not accessible without an
2566 instance of class gdcmHeader.
2567 - those methods are now static methods of gdcmDictSet and hence
2568 require no instances at all to be invocated.
2569 - within gdcmDictSet this change required to change some method
2570 to class methods (i.e. are now static) among which SetDictPath
2571 (renamed to BuildDictPath) and LoadDefaultPubDict.
2572 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2573 the above changes by calling the new method classes of gdcmDictSet.
2574 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2575 the above to be effective.
2576 * python/gdcmPython: in order to wrap properly the above changes
2577 for Python, swig version now needs to be > 1.3.17.
2578 * python/gdcmPython/Makefile fixed to adapt itself to new
2579 configure/make shema introduced by Johan Montagnat (thanks for the
2580 contribution). Alas this Makefile cannot be turned into a proper
2581 Makefile.am without some heavy changes in the configure.in
2582 (for python dectection).
2583 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2584 now avoids publishing the empty entries.
2586 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2587 * python/setup.py : bug fix concerning install under windows
2588 ExtraPath reused :-P
2589 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2591 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2592 * Dicts/dicomV3.dic : remove double spaces !!!
2593 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2594 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2597 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2599 method. Doxygenation.
2600 * src/gdcm.h clean up of JPR spurious comments.
2602 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2603 * python/distutilsSwigCPlusPlus.py now properly collects the
2604 shadow classes generated by "swig -c++" (gdcm.py in our case)
2605 when using "python setup.py install".
2606 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2607 reexports the working classes.
2608 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2609 by the classical C errno scheme. This is to prevent an obscure
2610 behavior of the python wrappers when importing wxPython.wx prior
2611 to gdcmPython (which ended up in an abort call). An illustration
2612 of this oddity can be found in the Test/ExceptionAndPython
2613 subdir (see the README file). This problem probably due to
2614 an combination of g++ and dynamic loading.
2615 * added Test/ExceptionAndPython (see above)
2617 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2618 * Changed the layout of the python part to avoid bloating main
2619 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2620 i.e. the distutils arsenal. All the python related stuff is
2621 again in a python subdir, but the package itself is now in
2623 * setup.py was cleaned up:
2624 - pythonIncludePath removed
2625 - python setup.py bdist target is now functional.
2626 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2627 collision with other packages). gdcmPython/demo/*.py changed
2630 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2631 * python subdir moved to gdcmPython (preparation of distutils packaging).
2632 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2633 distutils installer is operational.
2634 * - gdcmPython/__init__.py now properly loads the swig generated
2635 shadow classes (from gdcm.py).
2636 - gdcmPython/demo/*.py changed to import the package gdcmPython
2637 instead of gdcmPython/demo/load.py.
2638 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2640 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2642 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2643 entries within the associated public Dicom dictionary resp. the same
2644 information but sorted by the fourth field (PAT, IMG, DIR) of the
2646 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2647 are now in the "???" group.
2648 - python/gdcm.i changed accordingly,
2649 - python/demo/printGroupedPublicDict.py added, that gives an example
2650 of the above new functionalities in Python.
2652 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * src/gdcm.h, gdcmHeader.cxx:
2654 - historic references to glib's g_malloc and g_free (#defined)
2655 were definitively removed.
2656 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2657 * src/gdcmElValSet.cxx:
2658 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2659 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2660 - GetElValue(string) renamed to GetElValueByName.
2661 - Added GetElementByName(string).
2662 * src/gdcmHeader.cxx: added
2663 - GetPubElValRepByNumber(guint16, guint16)
2664 - GetPubElValRepByName(string)
2665 - GetShaElValRepByNumber(guint16, guint16)
2666 - GetShaElValRepByName(string)
2667 - GetShaElValByNumber(guint16, guint16)
2668 - GetShaElValRepByName(string)
2669 - GetElValRepByNumber(guint16, guint16)
2670 - GetElValRepByName(string)
2671 - GetElValByNumber(guint16, guint16)
2672 - GetElValRepByName(string)
2673 * Doc/requirements.txt added.
2675 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * Test/Makefile building now depends on the one of libgdcm.so
2677 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2678 pixel data) aware which enables finding the address (offset) of
2679 the pixel data of JPEG encoded DICOM files. This leaves only a single
2680 file in the testSuite whose pixel data address (offset) is unknown.
2681 * python/testSuite.py changed accordingly.
2683 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2684 * VC++ has some strong limitations when working with the STL, as stated
2685 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2686 "Also note that some STL containers (map, set, queue, list, deque)
2687 cannot be exported. [...]
2688 Some STL classes contain nested classes. These classes can not
2690 This is caused by a designed limitation that once a template
2691 class is instantiated, it can not be re-instantiated and
2693 Since our usage of map<> is ubiquitous in gdcm, this "designed
2694 limitation" of VC++ is a pitfall.
2695 Hence the Python wrappers of gdcm cannot be incrementally linked
2696 against the c++ dynamic library. The dirty but only workaround is
2697 to forget about incremental link of dynamic libraries and to generate
2698 the Python wrappers library with the inclusions of the underlying C++
2700 The following modifications concern this matter on Win32/VC++:
2701 - wrapping python correct with standalone wrapped dll (don't use separate
2702 dll under windows !!!!)
2703 - python21_d debug mode enabled (ask Frog how to use it :-)
2704 - NO problem with having an STL member of class for example string in C++
2705 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2706 - Python test of dcmlib in Python is ok under windows on a large set
2708 * removed glib references
2709 * typedef's inserted in gdcm.i for correct swig type management
2711 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2712 * python/demo/*.py load.py extracted from test.py. Added explore.py
2713 that only displays required tags and testAll.py that parses all
2714 the files of the testsuite without using unittest.
2715 * python/testSuite.py other additional test on new files added.
2716 * Data/* new test files added accordingly to the testSuite.
2717 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2718 the vr in the file differs from the one of the dictionary.
2720 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2722 values, but limits itself to values which are below a user specified
2723 size (by default 1024 bytes).
2724 * python/gdcm.i : elements not loaded (because their size is above the
2725 user specified treshold) are exported with their TagKey as key of the
2726 python dictionary. This enables the testsuite to make some checks
2727 on the unloaded elements (since we have their offset and size).
2728 * python/testSuite.py
2729 - now tests for the existence and proper value of the pixel data
2730 - two new examples added.
2731 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2733 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2735 aware. See the strategy comments in gdcmHeader::FindeLength().
2736 * Test/test.cxx now accepts a filename as first argument.
2737 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2738 * python/testSuite.py changed to integrate test on above files.
2740 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2742 the vr was also RET.
2743 * python/testSuite.py more tests added.
2745 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * python/testSuite.py unittest test suite added (uses Data)
2747 * Data/* dcm and acr files for the test suite.
2748 * glib dependance removed from un*x version. We now use ISO C99
2749 7.18 Integer types (see stdint.h)
2750 - python/Makefile, src/Makefile src/gdcm.h
2751 * src/ when an explicit vr (like dicom files) suddenly poped an
2752 implicit element we use to mark the underlying DictEntry of the
2753 concerned ElValue with "Implicit". This strategy was damageable
2754 too the public or provite dictionaries, since some of their vr
2755 would be changed. Since Header::FindLength heavily relies on the
2756 detection by Header::FindVR of falsely explicit elements, I
2757 added an extra ImplicitVr member to ElValue (boolean).
2758 The rest of the changes we the necessary adaptations.
2760 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2763 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2765 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * Adaptation for porting to VC++:
2768 o forced to use std namespace (for string to be known)
2769 o all class use __declspec export style on WIN32
2770 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2771 (in stdlib.h on Win32 but in std:: for gcc)
2772 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2773 variable GDCM_DICT_PATH.
2774 * src/gdcmHeader.cxx verbose comments made discrete.
2776 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * python/gdcm.i: added a typemap that converts a C++ hashing table
2778 to native Python dictionary.
2779 * python/demo/test.py:
2780 - now uses the native dictionary for exploration of gdcmHeader.
2781 - takes an optional filename argument (the file to parse).
2782 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2783 PubElVals hashing table.
2784 * Dicts/dicomV3.dic removed error prone trailing spaces.
2786 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * Python wrapping process moved away from src/Makefile to
2788 newly created python/Makefile (as well as gdcm.i)
2789 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2790 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2791 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2792 from the environement variable GDCM_DICT_PATH (when existing).
2793 * src/gdcmDict::GetTag bug fix.
2795 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2796 * Straightforward temporary fixes for swig to build the python wrappers.
2797 src/Makefile now has a python working entry [by working we mean
2798 that we can import de shadow classes without errors].
2800 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * hashtest.cxx removed (since allready in Test)
2802 * src/gdcmlib.h renamed to src/gdcm.h
2803 * src/dcm.i renamed to src/gdcm.i
2804 * src/Makefile prepared for python wrapping
2806 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * src/gdcmHeader.cxx :
2808 - Parsing of header is now separated from loading of element values
2809 (see gdcmHeader::LoadElements).
2810 - general clean up of hopefully all file access (creation of
2811 ReadInt16 and ReadInt32)
2813 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * src/gdcmHeader.cxx :
2815 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2817 - SetLgrElem renamed to SetLength
2818 - GetLgrElem renamed to GetLength
2819 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2820 * src/gdcmElValSet.cxx fixed both GetElValue methods
2821 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2822 due to IdoDude was cleaned out.
2824 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2825 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2826 concentrates on finding the value representation (when it exists).
2827 RecupLgr now only finds the element value length, and it avoids
2828 returning the unecessary skL (skipped length).
2829 Also, offsetCourant was simply removed (with taille_fich) since
2830 it was redundant with the File position internals (by using
2831 ftell and fseek). This also made skL (see above in RecupLgr) usage
2833 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2834 on the libido specificities which are handled through class
2836 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2839 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * Truckload of changes. Parsing of header is barely functional
2841 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2843 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2844 * src/gdcmHeader.cxx many addons of low level methods
2846 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2847 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2848 and _IdDcmSWAP_LONG.
2850 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2851 * This corresponds to all the changes decided at the meeting of
2852 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob