1 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/TestAllReadCompareDicom.cxx : test the existence of the directory
3 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
4 break under windows (with msvc6 compilation).
6 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
10 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Bugs fix for the Windows build with VC6
12 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
13 needed (only for projects required VTK). If the VTK is included in all
14 projects, there is conflicts with the jpeg lib of vtk when compiling the
15 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
16 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
17 when compiling the gdcm_wrap.cxx file (created by the compilation of the
19 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
20 (like it's already made for the cout use). Otherwise, conflict with the
23 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
24 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
26 - comments on the DicomDir::Method related usage added.
27 - now that we use the namespace gdcm, a lot of internal classes do
28 NOT need to be wrapped anymore.
29 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
30 DicomDir::Method) new example added.
32 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
33 * Improve string manipulation. I now inforce the notion of 'DicomString'
34 A DicomString can contain as many \0 as they want
35 and it is *always* of even length.
36 We only support odd length for very rare case.
37 And in the near future this should be removed.
39 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
40 * /binary_write/ gdcm source. Now even on big endian we are writting
41 little endian. This should -heopfully- fix some tests
43 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
44 * Now the dictionary is compiled into gdcm lib. This is a default
45 behavior, thus any dic file specified is picked before failback to
46 the one comiled into lib
48 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
49 * Change internals for gdcmDict. Don't use any 'new' any more.
50 This should definitely solve any leak problem, and we should be
51 as fast as before, as long as don't modify too much the dictionary.
53 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
54 * STYLE: ivars should start with a capital letter.
55 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
56 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
58 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
59 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
60 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
61 new 2004 dictionaries added (thanks to JPR).
62 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
63 * CLEANUP_ROUND (15) for gdcmPixelConvert
64 - RLEFrame::NumberFragments is now of type unsigned int
65 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
66 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
69 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
70 * Initial work in gathering all transfer syntax accessors. clearly
71 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
72 ivars, but only one transfersyntax (class) ivar with equivalent method on
75 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
76 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
77 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
78 discussed (plus I didn't like having a 2000 lines patch not commited)
80 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
81 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
82 * CLEANUP_ROUND (14) for gdcmPixelConvert
83 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
84 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
85 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
87 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
88 anymore and hence avoids storing a copy of PixelConvert::Decompressed
89 into File::Pixel_Data.
91 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
92 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
93 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
94 * CLEANUP_ROUND (13) for gdcmPixelConvert
95 Substituted File::ParsePixelData() with PixelConvert::Print() new
97 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
98 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
99 method to those classes.
100 - src/gdcmFile.[cxx|h]:
101 -- Added a ::Print() method.
102 -- PixelConverter is now a reference instead of a member.
103 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
104 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
106 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
108 collaboration diagram and inheritance diagram should be generated with
110 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
111 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
112 pointlessly wrapped (see
113 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
114 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
115 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
116 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
117 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
118 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
119 -- File::Initialise: PixelConverter setup moved away to
120 PixelConverter::GrabInformationsFromHeader()
121 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
122 interpretation moved away to PixelConverter::BuildRGBImage()
124 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
125 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
126 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
128 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
129 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
130 displayed on Win32 when a brutal abort() occurs (because of uncatched
131 exception). See TODO new entry of this commit for more on this.
132 * TODO added new entry.
133 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
134 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
135 - HandleColor is no longer called from gdcmFile.cxx
136 - gdcmPixelConvert.cxx clean up on method arguments and internal
137 variable names for semantical coherence.
139 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
140 * Finished lossless transition, not only do we now read all lossless jpeg
141 images, without the need of the Cornwell lib, but we do read them properly now
142 * To reduce code (well to avoid code duplication), I defined a common place
143 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
144 redefine symbols. This is not prefect but this the best solution I found for a
145 compilation time jpeg option.
147 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
148 * Update jpeg ijg lib to support lossless jpeg implementation
149 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
151 * Also added a special copyright for dcmtk since we use their bugfixes.
154 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
155 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
156 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
157 matters, as stated in warning note at begining of %include section).
158 * src/gdcmDicomDir*.[cxx|h]: coding style
159 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
160 * src/gdcmJpeg8.cxx: doxygen fix.
161 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
162 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
163 from File:: to PixelConvert::.
165 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
166 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
167 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
168 - more code moved away from File:: to PixelConvert::
169 - fat setup of PixelConverter set in place in File::Initialise.
171 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
172 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
173 namespace at the file system level. So now you should convert your examples
175 gdcmHeader -> gdcm::Header
176 It would be nice if people keep in mind to no open the namespace, since it
177 allows compilation on broken plateform which were defining common symbol in
178 the standart namespace (like LP, Unknown ...)
180 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
181 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
182 The JPEG fragments are now parsed at the same stage than the RLE
183 information. All code related to JPEG is now in gdcmPixelConvert:
184 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
185 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
186 export a gdcmFile:: method. Those are simply global functions
187 (for the time being this is better than having them attach to
188 either gdcmFile:: or gdcmPixelConvert::).
189 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
190 and stores the result in a gdcmJPEGFragmentsInfo.
191 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
192 code (among other stuff) moved away from gdcmFile:; to
195 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
196 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
197 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
198 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
199 clean up of RLE related code.
200 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
201 - src/gdcmRLE.cxx removed
202 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
203 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
204 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
205 * CLEANUP_ROUND (9) for gdcmPixelConvert
206 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
207 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
208 away from gdcmFile:: to gdcmPixelConvert::.
210 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
212 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
213 This is because Parse7Fe0 used to parse the pixels to compute the
214 length. This task was passed over to FindDocEntryLengthOB() a long
215 time ago, EXCEPT I had forgotten the OW case...
216 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
217 we just recylce the code for parsing RLE fragments and computing
219 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
220 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
221 with the retired Parse7Fe0().
222 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
223 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
225 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
226 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
227 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
228 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
229 - src/CMakeLists.txt: alphabetic order reodering + new entries.
230 * CLEANUP_ROUND (4) for gdcmPixelConvert
231 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
232 to return an unused length.
234 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
236 this should be cleanner from the plane view. The iostream are erally a pain
237 to use to do simple stuff.
239 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
240 * Redo the compilation of the ijg jpeg library. Now only one source is
241 necesseray. No need to rename file by hand what so ever. CMake handle the
242 copying of the file within different directory, configure header file to
243 modify some symbol. The only addition made to ijg wasd a mangle table so
244 that symbol are different wether we are within 8bits or 12bits.
246 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Added documentation of vtkgdcmReader on Website:
248 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
249 with it's binary name).
250 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
251 the Website to be more complete.
252 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
253 doxygenated documentation.
254 - Doc/DoxyVtkGdcmReaderExamples.txt added
255 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
256 DoxyVtkGdmReaderExamples.html )
257 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
258 * CLEANUP_ROUND (3) for gdcmPixelConvert
259 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
261 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
262 * CLEANUP_ROUND (2) for gdcmPixelConvert
263 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
265 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
266 * CLEANUP_ROUND for gdcmPixelConvert:
267 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
268 - src/gdcmPixelStuff[h|cxx] removed
269 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
270 - src/CMakeLists.txt changed accordingly
272 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
273 gdcmVersion.py moved to newly created ATTIC related
274 gdcmPython/SetupOldies/ directory.
275 * Autotools clean up:
276 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
277 - autogen.sh configure.in acinclude.m4 python.m4 removed
279 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
280 * src/*.cxx *.h Reference to License.htm fixed to License.html.
281 * Doc/CMakeLists.txt, doxygen.config.in: fix.
282 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
284 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * TODO updated with Mathieu suggestions. I proposed a template for
286 describing TODO entries and used it for new entries.
287 * Added Doc/Website/CodingStyle.html, Developpers.html,
288 DeveloppersPython.html, GdcmDataCvs.html and
289 DownloadVersion0_1.html, DownloadVersion0_3.html.
290 * Some Doc/*.txt Doxygen files (which do not really concern the
291 documentation itself, but the website) moved to html and
292 placed in directory Doc/Website:
293 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
294 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
295 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
296 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
297 * CMakeLists.txt changed accordingly.
298 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
299 DeveloppersPython.html
300 * INSTALL nows refers to Doc/Website/Installation.html
302 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * Added Doc/Website directory, that contains a first raw version
306 2004-09-23 Jean-Pierre Roux
307 * FIX In order not to be poluted any longer by casting problems,
308 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
309 we can now delete[] it safely
310 * VoidArea is now called BinArea (less confusing name),
311 and all the methods called ...VoidArea... are now ... BinArea...
312 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
314 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
316 clear) TagHT, which is an inherited member of gdcmElementSet. It is
317 up to the destructor of gdcmElementSet to clean up TagHt and it's
320 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * Test/CMakeLists.txt: update to follow gdcmData renamings.
322 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
324 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * ENH: added some utility method that builds a flat dictionnary
326 holding all the Dicom entries contained in the recursive structure
327 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
329 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
330 BuildFlatHashTable() that build a flat dictionary.
331 - src/gdcmElementSet.h: added a new private GetTag() accessor.
332 gdcmDocument is now a friend of gdcmElementSet.
333 - src/gdcmElementSet.cxx: clean up.
334 - Example/FlatHashTablePrint.cxx added.
335 - Example/CmakeLists.txt changed accordingly
337 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
339 moved away from gdcmDocEntrySet (since this class is an abstract class
340 acting like an interface). SQDepthLevel and BaseTagKey are now
342 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
343 and associated accessors. Doxygenation of the class.
344 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
346 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
347 Use SQDepthLevel accessor instead. ::Print() adapted.
348 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
349 - src/gdcmDocument.cxx changed accordingly.
351 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
353 - The following is the doxygen comment of the typedef declaration
354 of gdcmagKey in src/gdcmCommon.h:
355 gdcmTagKey is made to old an "universal" (as in URL, Universal
356 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
357 A dicom tag allways has a group and an element, but a set of tags
358 embeded in various (optionally nested) sequences and sharing
359 the same group and element all share the same (group, element)
360 "identifier". Hence the (group, element) cannot be used as an
361 identifier (in gdcm we shall refer to a "TagKey") of a tag.
362 In order to construct a proper tag identifier (i.e. a key) we
363 consider the following definition of a TagKey:
364 - let Group, Element be the string representation of the
365 group and element dicom tag members,
366 - let ItemNumber be the string representation of the integer
367 index of the considered item number of a sequence,
368 Let the key of a tag embeded in a sequence, noted SeqTag, be
370 /ItemNumber#Group|Element
371 where "/", "#" and "|" are characters acting as separators.
372 Then the general form of a gdcmTagKey is given by:
373 Group|Element<SeqTag>
374 where <SeqTag> means NO or many instances of SeqTag.
375 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
378 but the gdcmTagKey of a tag "embeded" is the first item of
379 a sequence, itself nested in the third item of a sequence is the
381 0004|1220/2#0008|0082/0#0008|0090
382 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
383 order to hold the new sequence compatible key. Previously, the
384 GetKey() method would look in the underlying gdcmDictEntry.
385 - src/gdcmDocEntry.cxx:
386 -- constructor now copies the underlying DictEntry key, in the local
388 -- ::Print: displays the member Key, instead of the (group, element).
389 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
390 - src/gdcmDocEntrySet.h:xi
391 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
392 -- now has a new BaseTagKey member.
394 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
395 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
397 This poses the problem with the semantics of the following lines
398 LoadEntryVoidArea(0x0028,0x1201); // R LUT
399 LoadEntryVoidArea(0x0028,0x1202); // G LUT
400 LoadEntryVoidArea(0x0028,0x1203); // B LUT
401 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
402 to the long FIXME note for what the problem is. Nevertheless in
403 order to get things working the dicom dictionary was altered !
404 Please fix things urgently...
405 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
406 information), see above note on moving the member VoidArea. Nevertheless
407 the following entries previously correctly set as US are now inproperly
409 0028 1201 OW IMG Red Palette Color Lookup Table Data
410 0028 1202 OW IMG Green Palette Color Lookup Table Data
411 0028 1203 OW IMG Blue Palette Color Lookup Table Data
412 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
413 of gdcmDocEntry moved to gdcmSeqEntry.
414 * src/gdcmSeqEntry.cxx: STYLE.
416 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
417 * Test/TestAllEntryVerify.cxx minor fix and added comments.
419 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
420 * gdcmPython/testSuite.py: all the test suite in python is now moved
421 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
422 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
423 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
425 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
427 to avoid inclusion recursion until STL is reached.
428 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
429 mecanism. errno.h is not included in gdcm anymore.
430 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
431 (gdcmFormatError now inherits from gdcmFormatUnexpected).
433 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
434 gdcmData/TestAllEntryVerifyReference.txt
435 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
436 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
437 exception_on_error parameter.
438 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
439 - vtk/vtkGdcmReader.cxx changed accordingly,
440 - Example/*.cxx and Test/*.cxx changed accordingly.
442 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
443 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
444 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
445 enable_sequences removed from gdcmHeader constructor and dependencies.
446 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
447 * gdcmPython/demo/PrintHeader.py: dummy fix.
448 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
449 skip_shadow removed from gdcmHeader constructor and dependencies.
450 * Example/*.cxx and Test/*.cxx changed accordingly.
452 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
454 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
456 2004-07-21 Jean-Pierre Roux
457 * FIX Now, Parsing and Printing a DICOMDIR do work!
458 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
460 2004-07-20 Jean-Pierre Roux
461 * FIX Some brain damaged headers have Zero-Lenght fields
462 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
464 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
465 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
466 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
467 variable (instance of gdcmDebug) by a definition macro, and the instance
468 is now in static in the gdcmDebug class
469 * src/gdcmSQItem.h : (FIXME) remove an undefined method
470 * Test/PrintAllDocument.cxx : bug fix in the result of the test
472 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
473 * WARNING: ctest now depends more tightly on gdcmData. You should
474 check out gdcmData properly for things to run smoothly...
475 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
476 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
477 we need the pixels not be loaded in order to use the ValEntry
478 that displays position and size).
479 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
480 This is a C++ based equivalent of gdcmPython/testSuite.py that should
481 be deprecated. If you have any doubts about the advantages of a
482 modern scripting language (read Python) versus grass root C++ (i.e.
483 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
484 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
485 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
486 Anyhow, consider documenting the gdcmData images in
487 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
489 * Test/CMakeLists.txt:
490 - now uses TestAllEntryVerify.cxx
491 - specific comments on oldACR00001.ima (now renamed in gdcmData
492 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
493 gdcmData/TestAllEntryVerifyReference.txt
496 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
497 * src/*.[h|cxx] : typedef clean up
498 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
499 - TagKey renamed to gdcmTagKey (for external usage)
500 - VRKey renamed to gdcmVRKey (for external usage)
501 - removal of typedef duplication.
502 - Removed all unecessary inline keyword from class inline definitions.
503 - Some method|function(void) declarations replaced with method|function().
504 * src/jpeg/libijg12/jdhuff12.c:
505 - printf polluting ctest removed.
506 - TAB removal for comminting
508 - TestAllReadCompareDicom.cxx: added a test that compares all the
509 images in gdcmDataImages.h with corresponding images in
510 gdcmData/BaselineDicom/. When baseline images are not present
511 this test creates them.
512 Note: we need to validate each reference image, but before that
513 I'd like to rename them with a more explicit name...
514 - CMakeLists.txt: changed accordingly.
515 * Example/*.cxx: examples now only include gdcm.h (as opposed to
516 including each header needed).
518 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
519 * Test/*.cxx and Example/*.cxx: moved some examples away from the
520 test suite to the Example directory. Are concerned:
525 - TestWriteSimple.cxx
526 * Test/CMakeLists.txt: added some comments on reasons for black listing
527 image gdcmData/oldACR00001.ima
529 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
530 * Test/CmakeList.txt: removed the following from black list (to be coherent
531 with removal from gdcmData):
532 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
533 - gdcm-MR-PHILIPS-16.dcm
535 Added the following because after last cvs update, they cause
536 ctest -R TestReadWriteReadCompare
538 - gdcm-MR-SIEMENS-16-1.acr
540 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
541 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
542 new comments in this file) we temporarily (sigh) move to a weaker
544 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
545 we don't need to black list the following images anymore:
546 - 8BitsUncompressedColor.dcm
548 - US-PAL-8-10x-echo.dcm
549 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
550 fixes and the beautified code ;-)
551 This fixes the bug introduced in version 1.42 (when beautifying)
552 that made the parsing of 8BitsRunLengthColor.dcm unproper.
553 Note: ctest was blind to this bug (this means we need to still
554 improve the test suite). The bug could be detected by using
555 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
557 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
558 and by displaying the (garbage) produced file temp.XDCM...
560 2004-06-29 Jean-Pierre Roux
561 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
562 - replace by uggly but working old code :-(
563 A lot of things should be OK again.
564 It's really urgent to have a test suite that *tests*,
565 to prevent Frog's beautifying sessions to break all the stuff
566 (twice, withing a fortnigh ...)
568 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
569 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
570 redundancy) to added Test/TestReadWriteReadCompare.cxx
571 * Test/CmakeList.txt: because the compare test of
572 Test/TestReadWriteReadCompare.cxx fails, the following images are
573 black listed: - 8BitsUncompressedColor.dcm
575 - US-PAL-8-10x-echo.dcm
576 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
577 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
578 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
579 and ad-hoc kludge. This kludge is now removed, and on encountering
580 such an image (OB field brain damaged) we set errno. Then in
581 ::FindDocLength() we "fix" the length as being ALL what remains
582 in the file (until EOF). We then proceed, hoping for the best...
583 This fixes a SegFault in ShowDicom when trying to write such an
585 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
586 (because TestWriteRead breaks on it, after a non conformal commit?).
587 ctest now runs properly, except for MakeDicomDir (which was allways
588 broken) and the Python related stuff (still not fixed).
590 2004-06-24 Jean-Pierre Roux
591 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
592 FIX : Test/TestReadWrite now iterates on all the file names
593 (instead of infinite loop)
594 ENH : Test/TestWriteRead now iterates on all the file names
596 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
597 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
599 2004-06-24 Jean-Pierre Roux
600 FIX : - now Write drops LUT Descriptors and LUTs (if any)
601 when SamplesPerPixel =3
602 - now Write is no longer confused by
603 'BitsAllocated = 12" and 'BitsStored=12"
604 - "UN" value representation Elements are now written correctly
605 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
606 ENH : - now gdcmHeader has its own Write methods
607 (in order to split the job that has not to be done
610 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
612 loop on the same image until memory went out.
613 Note: this means we still have gobs of memory loss in PrintDocument
614 * src/gdcmDocument.cxx: fixes problem on parsing on file
615 gdcmData/16BitsJpegLosslessGrayScale.dcm.
617 2004-06-24 Jean-Pierre Roux
618 FIX : Write - All the Sequences and Sequence Item are now written
619 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
620 is added a the end, when necessary.
621 - A lot of brain-damaged images, that were read correctly are
622 now written correctly
623 - length compatible BinEntry are now loaded correctly
624 (even for odd groups)
625 Note : only Explicit Value Representation was checked.
626 (question : is implicit VR really necessary for gdcm ?)
628 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
629 * DEVELOPPER: added a proposition of coding style.
630 * src/gdcmDocEntry.h: removed every inline declaration (for test of
633 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
635 Use the gdcmDocEntry::Print() and Write() instead.
636 * src/gdcmDocument.cxx: bug fix.
638 2004-06-22 Jean-Pierre Roux
639 FIX : gdcmDocument.cxx
640 - Now we do recognize the JpegLossLess format (there was a misstyping in
641 code 'beautyfication' :-(
642 - Now we automaticaticaly load the Luts, if any
644 2004-06-22 Jean-Pierre Roux
645 In order : to write Sequences, whatever their imbrication level,
646 : to allow user to create his own Sequences
647 a lot of modif where necessary (adding, moving, or virtualising methods)
649 WARNING : save your own sources *before* cvs up !
652 ADD virtual void Write(FILE *fp, FileType filetype);
655 ADD virtual void Write(FILE *fp, FileType filetype);
656 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
659 ADD virtual void Write (FILE *fp, FileType filetype)=0;
660 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
661 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
662 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
663 ADD std::string GetEntryByName(TagName name);
664 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
666 std::string vr = "unkn",
667 std::string fourth = "unkn",
668 std::string name = "unkn");
669 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
670 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
671 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
672 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
673 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
674 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
675 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
676 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
679 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
680 ADD virtual std::string GetEntryByName (TagName tagName);
681 ADD virtual std::string GetEntryVRByName (TagName tagName);
682 REM virtual bool Write(FILE *, FileType);
683 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
684 FILE *_fp, FileType type);
685 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
686 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
687 REM virtual bool WriteEntries(FILE *_fp,FileType type);
688 REM virtual std::string GetEntryByName (std::string tagName);
689 REM virtual std::string GetEntryVRByName (std::string tagName);
690 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
691 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
692 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
694 std::string vr = "unkn",
695 std::string fourth = "unkn",
696 std::string name = "unkn");
697 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
698 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
699 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
700 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
703 ADD virtual void Write(FILE *fp, FileType filetype);
706 ADD virtual void Write(FILE *fp,FileType filetype);
709 ADD virtual void Write(FILE *fp, FileType filetype);
710 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
711 REM std::string GetEntryByNumber(guint16 group, guint16 element);
712 REM std::string GetEntryByName(TagName name);
715 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
717 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
718 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
719 The default constructor invoked by the line
720 gdcmHeader *f1 = new gdcmHeader( header );
721 was gdcmHeader::gdcmHeader(bool) instead of the expected
722 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
723 Hence the parsing wasn't executed... See also below.
724 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
725 as explicit constructor didn't do the trick to fix the above problem.
726 Could anyone explain why ?
727 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
728 properly calls gdcmValEntry::Print() (that was weed out from
729 code related to gdcmBinEntry).
731 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
732 * In order to fix memory leaks:
733 - Test/TestWriteSimple.cxx: added cleaning of free store through
735 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
736 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
737 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
738 (through the call to ::AddDicomDirMeta()) or the destructor
739 would crash when deleting uninitialized ::metaElems].
740 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
741 - src/gdcmDocument.cxx:
742 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
744 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
745 was causing memory leaks.
746 - src/gdcmSQItem.cxx:
747 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
748 cleanly handled with polymophism: sorry but my milage is low).
749 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
750 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
751 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
752 This avoids SegFaulting.
753 - src/gdcmSQItem.h: coding style.
755 - Test/TestWriteSimple still severely sucks. The output image content
756 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
757 damaged when displayed with vtkgdcmViewer.
758 - on memory leaks: TestWriteSimple leaks really less (see entry
759 of 2004-06-18 in Changelog file for the call to valgrind).
760 - on segfaults: ctest now passes all the tests but one (no more
762 * Erroneous leading white fix:
763 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
764 white[s] (as opposed to from >> xxx, that removes it [them].
765 - src/gdcmTS.cxx: ditto.
766 - gdcmPython/testSuite.py: dirty related kludge removed.
767 * src/*: remaining references to gdcmParser removed.
768 * src/*[cxx|h]: added copy[way]left header.
771 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * In order to fix writing of dicom files:
773 - Test/TestWriteSimple.cxx: a simpler example of writing.
774 - Test/CMakeLists.txt changed accordingly.
775 - src/gdcmDocument.cxx:
776 -- The destructor now recursilvely removes potential sequences.
777 -- Bug fix in ::IsJPEG2000()
778 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
779 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
781 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
782 to only declared) and build on top of
783 ::GetDocEntryByNumber(guint16, guint16).
784 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
785 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
786 for usage in destructor and treatement of promotion in
787 ::ReplaceOrCreateByNumber().
788 - src/gdcmSQItem.cxx: destructor should better handle his job.
789 Test/TestWriteSimple now runs (or at least it DOES something).
790 * We can now start hutting memory links. A good starting point is:
791 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
792 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
793 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
795 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * Valgrind note: after Mathieu Malaterre teached me how to read
797 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
799 Using gcc, you can force the STL to use malloc and to free memory as
800 soon as possible by globally disabling memory caching.
801 With 3.2.2 and later, you should export the environment variable
802 GLIBCPP_FORCE_NEW before running your program.
803 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
804 simply vanish (it is still not clear to me, whether this means that
805 STL std::string leaks or if valgrind believes it leaks...).
806 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
807 running bin/gdcmTests makeDicomDir):
808 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
809 - Test/makeDicomDir.cxx now properly traps empty lists and returns
811 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
812 SegFaulting (I drowned in DicomDir related code when trying to
813 understand why the list is empty...).
814 * src/gdcmDocument.h: first BSD license header try.
815 * Doc/License.txt added.
817 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
818 * src/gdcmDocument.[h|cxx]:
819 - Clean up of the Transfer related predicates. They are now all based
820 on new method isGivenTransferSyntax, that (should) handle properly
822 - general clean up, simplification, and coding style.
823 - Specific clean up of Parse7FE0() (umproperly named actually).
824 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
826 2004-06-14 Jean-Pierre Roux
828 - fix the display of Sequence Delimitor (SQDepthLevel pb)
829 - fix the display of SQItem ordinal number
830 - add the GetSQItemByOrdinalNumber method
831 - remove some useless never written private methods
833 2004-06-14 Jean-Pierre Roux
835 - adding a constructor taking a gdcmDocEntry as an input param
836 - ReplaceOrCreateByNumber now returns :
837 a gdcmBinEntry * if a Binary (void *) value is passed as a param
838 a gdcmValEntry * if a string value is passed as a param
840 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
841 according to the param type (no longer sets a gdcmDocEntry)
842 - GetValEntryByNumber, GetBinEntryByNumber added
843 - NewValEntryByNumber and NewBinEntryByNumber added
845 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
847 - GetSQItemNumber and SetSQItemNumber added, to provide
848 a (relative) Item identier inside a given Sequence
849 \warning : some pb remaining around this number
851 - AddEntry now takes the Item Number as a param
853 - adding a constructor taking a gdcmDocEntry as an input param
855 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * Memory leak hunt with the following command:
857 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
858 --show-reachable=yes gdcmTests PrintDocument
859 It looks like many (all?) leaks are due to the STL (or a bad usage
860 of the STL. The lines producing the leaks now have a comment with
861 a "MEMORY LEAK" tag: you can retrieve them with
862 grep "MEMORY LEAK" src/*
863 Here are two typical examples which I can't help fixing:
868 char * test = "babo";
869 name = test; //// <--- valgrind detects 960 bytes lost in
870 //// call to std::string::operator=(char const*)
871 name.clear(); //// Doesn't help !
879 std::cout << "Type a bunch of characters followed by RETURN: ";
880 getline(std::cin, line); //// <--- valgrind dectects a loss
881 //// of 1320 bytes in call to
882 /// std::basic_istream<>& std::getline<>
888 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
889 * src/gdcmHeader.[cxx|h]:
890 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
891 and related, moved away to gdcmDocument.
892 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
893 the corresponding protected accessors of inherited class
894 gdcmDocument, removed ! As a consequence gdcmFile had to be
895 declared friend of class gdcmDocument (see below).
896 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
897 - Clean up of undefined or unused methods.
898 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
899 account the changes to gdcmHeader.h).
900 * src/gdcmDocument.h:
901 - gdcmFile is now a friend class (in order to take into account the
902 changes to gdcmHeader.h).
903 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
904 (see changes to gdcmHeader.h).
905 - Accessors (reading on the form GetEntry*) are now public.
906 - Clean up of undefined or unused methods.
907 * src/gdcmDocument.cxx:
908 - adaptation to changes to gdcmDocument.h
909 - ::OpenFile now writes a verbose message when file cannot be opened.
910 - some std::string properly set to VRKey
911 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
912 references to gdcmDocument.
913 * Test/TestFindTags.cxx: changed accordingly to above changes.
914 * gdcmPython/testSuite.py: adapted to renaming of acr files in
915 cvs repository gdcmData.
917 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
918 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
919 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
920 conflicts with gdcmValEntry::voidArea.
921 * src/gdcmValEntry.cxx: unmatching comment wiped out.
922 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
923 Value representation between StringRepresentable and BinaryRepresentable.
924 * src/gdcmDocument.cxx:
925 - method ParseDES: proper indentation restored and usage of
926 gdcmVR::IsVROfGdcmStringRepresentable wired in.
927 - method LoadDocEntry: the fingerprint left in the SetValue() of
928 unloaded entries (length > MaxSizeLoadEntry) had curiously been
929 removed. Reverting to previous code segment with the proper
930 dynamic_cast< gdcmValEntry* >.
931 Note: this was (partially) breaking the python test suite
932 (gdcmPython/testSuite.py) that made usage of the above
933 fingerprint to check presence of "Pixel Data".
934 * src/gdcmDocEntry.h: coding style.
935 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
936 now taken into account.
937 * gdcmPython/gdcm.i: adaptation to the new internal representation
938 of gdcm (exit gdcmParser, hello gdcmDocument).
939 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
941 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
942 anymore, but instead prints the loaded Python dictionary.
943 * .... alas, the python testSuite is still broken.
945 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
946 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
948 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
949 * src/gdcmUtil.h : export methods
951 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
952 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
954 * Initial addition of automatic python testing
955 * Initial addition of automatic image comparison
957 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
958 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
959 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
961 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
962 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
963 * Test/ShowDicom.cxx : bug fix for msvc compilation
964 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
966 2004-05-04 Jean-Pierre Roux
967 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
968 new concepts (and new classes) :
969 a 'gdcmDocument' is composed of a set of Doc Entries, that are
970 - elementary gdcmDocEntries (former gdcmHeaderEntries)
971 - Sequence Doc Entries (gdcmSeqEntries)
972 a Sequence is composed of Items.
973 Each item is a set of Doc Entries (this is recursive)
974 The non uniqueness of the 'Dicom tag' is due to this recursivity
975 (never taken into account)
976 Our unability to add a new 'entry' in the header
977 at the proper location (neither in the H-Table (map or multimap),
978 nor in the Chained List is also due to this recursivity.
979 Don't try, right now, to use/modify/compile these new sources :
981 We just commit all the stuff, 'as is', in order not to loose it.
983 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
984 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
986 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
987 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
988 file prefix (SetFilePrefix)
990 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
991 * Add a new test: ShowDicom, for now this is just the c++ version of
992 checkRead.sh, later it will be able to compare the image read against a
994 * Replace the DEBUG on the stack with a global entry in cmake interface:
995 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
997 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
998 * Add an example subdir, with a real example on how to read + write a
1001 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1002 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1003 * Doc/CMakeLists.txt: the main page is now properly differentiated
1004 between the developper and user version.
1005 * Doc/doxygen.config.in: dropped search related obsolete flags
1006 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1008 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1009 * DEVELOPPER: added some helpfull comments for compile/test/install
1012 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1013 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1014 src directory, now generated in the build dir.
1015 2. Tests as mentionned smarter
1017 4. Add a new method in gdcmDict that return the PubDict by name
1018 this is interesting for 3rd party lib like ITK,
1019 where we could set the institution name / patient name...
1021 * ENH: 1. Now the test suite is working for real
1022 2. All binaries are now output in the gdcm-bin directory
1023 (this was not true before)
1025 2004-04-28 Jean-Pierre Roux
1026 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1027 SeQuence indented printing of Dicom Header.
1028 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1029 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1030 Computation of SQDepthLevel is now part of gdcmHeader constructor
1031 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1032 tree-like structure of a Dicom Header.
1033 * FIX Test code cleaning
1035 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1036 * ENH: Adding automatic testing
1037 1. Need a DartConfig.cmake to submit to public
1038 2. Add a test driver gdcmTest.cxx
1039 3. gdcmTestMain, an helper for the main test driver gdcmTest
1040 4. Files in Test don't have a main anymore, this becomes interesting
1041 when we add more and more tests, thus dsw don't have to load
1043 * ENH: Adding a GDCM_DATA_ROOT for testing
1044 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1045 one file instead of seven + some small cleanup
1047 2004-04-22 Jean-Pierre Roux
1048 * ENH Minor changes to the Print() methods.
1049 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1050 Header printing. Example given with :
1051 > PrintHeader fileName 2 new
1052 (SQ based tree-like structure still to be done for the Header ...)
1054 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1055 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1056 1. I have added some unsigned where needed
1057 2. Some function parameter not used -> (void)
1058 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1059 4. g++ don't like character '\' in comment
1060 5. #define jpeg_create_decompress jCreaDecompress
1061 this really need to be fixed
1062 6. virtualize destructor of gdcmObject ... leakage
1063 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1064 this also really need to be fixed
1065 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1066 remove compression file
1067 (as we only do decompression, right ?)
1068 * ENH: Change malloc/calloc/free with c++ equivalent
1070 2004-04-21 Jean-Pierre Roux
1071 * FIX gdcmHeaderHelper::GetXSpacing
1072 when a single value is found (bug ?), xpacing is now
1073 defaulted to yspacing
1075 2004-04-19 Jean-Pierre Roux
1076 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1077 * ENH add parameters :
1078 bool exception_on_error = false,
1079 bool enable_sequences = false,
1080 bool ignore_shadow = false
1081 to the gdcmFile constructors to be full gdcmParser compliant
1082 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1083 to allow reading of PAPYRUS 3.0 files
1085 2004-04-06 Jean-Pierre Roux
1086 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1088 2004-04-02 Jean-Pierre Roux
1089 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1090 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1091 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1093 2004-03-30 Jean-Pierre Roux
1094 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1095 for ACR file, written out as DICOM files (hope so...)
1097 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1099 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1100 moved to base class gdcmParser and only the specialisation is kept
1102 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1103 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1104 already does the job.
1105 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1106 (to be consistent with gdcmParser::WriteEntries).
1108 2004-03-30 Benoit Regrain
1109 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1110 upate of the object's instance. It's passed to 2 in the unfavorable
1111 case : one in the ExecuteInformation, one in the ExecuteData
1113 2004-03-29 Jean-Pierre Roux
1114 * ENH : Check on file type to be written moved
1115 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1116 * FIX : gdcmObject::ResetBoundaries now stops properly
1117 when end-of-list is reached
1118 : gdcmVersion modified (as Benoit Regrain asked)
1120 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1122 * src/gdcmUtil.cxx: added forgotten iostream include.
1123 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1124 equivalent to ExplicitVR in existing code).
1126 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1127 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1128 now contains all the gdcmGlobal related code.
1129 * minor coding style and doxygenation changes.
1131 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1133 now contains all the Debug related code.
1134 * minor clean-up of includes in src/*.cxx
1135 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1136 CreateCleanString) removed.
1137 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1138 * Doc/DoxyMainPageUser.txt added.
1139 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1140 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1141 src/gdcmDirList.cxx)
1143 2004-03-24 Jean-Pierre Roux
1144 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1146 2004-03-23 Jean-Pierre Roux
1147 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1148 big endian made volumes
1149 * ENH Now gdcmParser constructor and destructor are protected to forbid
1150 end user to instanciate class gdcmParser
1151 (only gdcmHeader and gdcmDicomDir are meaningfull)
1153 2004-03-22 Benoit Regrain
1154 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1155 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1156 gdcmSerie to gdcmDicomDirSerie
1158 2004-03-19 Jean-Pierre Roux
1159 * ENH Now the tree-like structure describing a DICOMDIR comming from
1160 an already existing DICOMDIR file is consistent with
1161 the home-made tree-like structure build ex-nihilo
1162 or build from the files held (recursively) in a Directory
1163 functions gdcmDicomDir::CheckBoundaries()
1164 gdcmObject::SetBoundaries() added
1166 2004-03-17 Jean-Pierre Roux
1167 * REM (Eric Boix bug) : removal of meaningless
1168 gdcmDicomDirImage::NewImage function.
1169 * FIX now file names and directory name are written properly in the
1171 * FIX now gdcmDicomDir constructor may be call without any trick
1174 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1176 of gdcmDicomDirImage::NewImage as empty function.
1178 2004-02-28 Jean-Pierre Roux
1179 * ENH add gdcmDicomDir:NewPatient
1180 add gdcmDicomDirPatient:NewStudy
1181 add gdcmDicomDirStudy:NewSerie
1182 add gdcmDicomDirSerie:NewImage
1183 to allow making gdcDicomDir object.
1184 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1185 (as opposite to the gdcmHeader chained list)
1187 2004-02-11 Benoit Regrain
1188 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1189 when using from python
1191 2004-02-10 Benoit Regrain
1192 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1193 * FIX : in gdcmDicomDir when the directory is empty
1194 * ENH : add callback and methods to get the progression of dicomDir
1197 2004-02-06 Jean-Pierre Roux
1198 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1199 - GDCM_META added to gdcmDicomDirType
1200 - class gdcmMeta created
1201 * ENH : - A brief summary is now displayed at the beginning of
1202 'testDicomDir' to help disaster magnitude estimation
1203 * REM : Now useless Test/explDICOMDIR.cxx
1205 2004-02-05 Benoit Regrain
1206 * ENH : add methods in gdcmObject to get the hash table or the list of
1208 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1209 * FIX : wrapping python for TagHeaderEntryHT
1211 2004-02-04 Benoit Regrain
1212 * FIX : even length for some strings when writting the dicom dir
1213 * FIX : sort the images in the dicom dir
1214 * FIX : Bug fix for python use of dicom dir
1215 * ADD : a python demo
1217 2004-02-04 Jean-Pierre Roux
1218 * FIX : Final solution (?) for icone embedded images
1219 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1220 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1221 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1222 gdcmData/gdcm-MR-SIEMENS-16.acr1
1223 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1224 to make full checking easier
1226 2004-02-04 Benoit Regrain
1227 * FIX : WriteEntries : coding style & logic in parameters
1228 * FIX : Set the elements to create the DicomDir in a dictionary file
1230 2004-02-03 Benoit Regrain
1231 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1232 * gdcmDicomDir : add the load of directory
1233 * Bug fix and print add-on
1235 2004-02-03 Jean-Pierre Roux
1236 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1237 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1238 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1239 * FIX gdcmParser.cxx : 'group length' elements are now considered
1240 as integers, even for shadow groups, when file is Implicit VR
1242 2004-02-02 Jean-Pierre Roux
1243 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1245 of the last synonym :-(
1246 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1248 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1249 * FIX taking into account the possible 7fe0,0010 multiplicity
1250 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1251 to allow removal of references to 7fe0,0010, to deal with
1252 ACR-NEMA images, when 0028,0200 is meaningfull
1254 2004-01-31 Jean-Pierre Roux
1255 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1256 no longer writes 'Un' on disk
1257 * FIX SQ elements with actual length are now dealt with corectly
1258 * FIX gdcmFile::WriteBase make the difference, for color images, between
1259 the length (for Palette expanded images)
1260 and Raw Length (non expanded image + Palette)
1261 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1262 (that broke Write). Replaced by UL.
1263 Aware user will reload the field if he
1264 thinks it's necesssary
1266 2004-01-30 Jean-Pierre Roux
1267 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1268 when 'dirty Acr' is found, to be compliant with the new
1269 IsReadable() methods.
1271 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1272 (no DOUBLE images in kosher DICOM,
1273 but so usefull for people that miss them ;-)
1275 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1276 DICOMDIR related utilities (not checked as Windoze compliant)
1278 2004-01-28 Jean-Pierre Roux
1279 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1281 2004-01-27 Jean-Pierre Roux
1282 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1283 to allow skipping the shadow elements, to save memory space.
1284 The TRUE value for this param has to be used
1285 with a FALSE value for the 'enable_sequence' param.
1286 ('public elements' may be embedded in 'shadow Sequences')
1287 * gdcmHeader methods now deal with 'embedded icones images' in the header
1288 (even when an 'icone image sequence' is announced by the
1289 element (0x0088,0x0200), but there is NO icone at all ...
1291 * gdcmHeader sometimes Image Location value doesn't follow
1292 the supposed processor endianity (see gdcmData/cr172241.dcm).
1295 * gdcmHeader add the method
1296 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1297 to get *all* the Header Entries with the same tag.
1298 GetHeaderEntrySameName is probabely *useless*
1299 (no meaning : Name is *not* an identifier within the Dictionnary)
1301 2004-01-26 Benoit Regrain
1302 * Bug fix in the print of hexadecimal representations. Remove long fields
1303 in the print and add a third level of print to print them
1305 2004-01-23 Benoit Regrain
1306 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1307 * Bug fix on test suite after remove the strip made on not string fields
1308 * Split the IsReadable method between gdcmParser which test that the file
1309 is dicom and gdcmHeader which test that it's an image file
1311 2004-01-22 Benoit Regrain
1312 * DicomDir : clean code, add methods, set variables in protected or private
1313 * gdcmUtil : bug fix for the clean string method
1315 2004-01-19 Benoit Regrain
1316 * Add the use of shadow dictionaries
1317 * bug fix and coding style
1319 2004-01-19 Benoit Regrain
1320 * src/gdcmFile.cxx : bug fix concerning the close of file
1321 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1322 * Add the update of header entries using the shadow library
1324 2004-01-19 Benoit Regrain
1325 * removal of file gdcmHeader2.cxx
1326 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1327 inheriting from gdcmParser. This split is to prepare the integration
1328 of dicom dir parsing
1329 * bug fix under python
1331 2004-01-16 Jean-Pierre Roux
1332 * REM removal of class gdcmHeaderEntrySet
1333 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1334 * ADD add file gdcmHeader2.cxx
1335 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1337 2004-01-15 Benoit Regrain
1338 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1339 entries created while parsing the header. Thus, they will be destroyed
1340 when the gdcmDictSet will be destroyed
1341 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1344 2004-01-15 Benoit Regrain
1345 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1346 made a fatal error because of the memory release at the end of program.
1347 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1348 some memory and vtk seems to have some problems with that.
1349 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1351 2004-01-14 Benoit Regrain
1352 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1353 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1354 * src/*.[h|cxx] : make changes due to class name changes
1355 * gdcmPython/demo/*.py : bug fix due to method names
1357 2004-01-13 Benoit Regrain
1358 * src/*.[h|cxx] : coding style
1359 * vtk/*.[h|cxx] : coding style
1361 2004-01-13 Benoit Regrain
1362 * gdcmPython/testSuite.py : test the readable flag of file for tests
1363 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1364 It's lied to the stl compilation by MSVC (windows, always windows...)
1365 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1367 2004-01-12 Benoit Regrain
1368 * src/*.h : add comments
1369 * src/gdcmDictSet.h : set the method BuildDictPath in public
1370 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1371 directly setted in the source code
1372 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1375 2004-01-09 Benoit Regrain
1376 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1377 * setup.py : use a reference to gdcmVERSION
1379 2004-01-07 Benoit Regrain
1380 * Modification to compile with the distutils.
1383 2003-12-10 Benoit Regrain
1384 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1385 can use a gdcmHeaderHelper to load datas
1386 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1387 made in the source code
1389 2003-12-10 Benoit Regrain
1390 * Update Windows projects and .cvsignore files
1392 2003-11-12 Jean-Pierre Roux
1393 * ENH gdcmHeader constructor has one more parameter (default value : false)
1394 that allows the user to 'go inside' the SeQuences only
1396 gdcmElValSet:Print takes it into account
1398 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1399 * ENH: Update gdcmPython/CMakeLists
1400 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1401 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1403 2003-11-10 Jean-Pierre Roux
1404 * FIX : gdcmHeader::LoadElements is now based
1405 on the ListTag listElem member,
1406 not longer on the TagElValueHT tagHt member
1407 * ENH : PrintPubElVal shows (temporarily) both results,
1408 with the tagHt member and the listElem member.
1409 (it's easier to 'see' the problems when using Printheader)
1411 * FIX : old private member LgrElem is now splitted into
1412 ReadLength : Length actually found on disk (updated only
1413 if bug fixing is necessary), for internal
1415 UsableLength : Updated by FixFoundLength, to fix a bug
1416 or to allow Parser going on.
1417 Will allow to re-write a kosher header when a SeQuence
1418 with a length (not 0000) is found
1419 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1420 because gdcmElValSet::Add does not update ListElem
1423 2003-11-07 Jean-Pierre Roux
1424 * FIX misstyping in Transfert Syntax name table
1425 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1426 when they have an actual length (not 0000 nor FFFFF)
1427 (Nobody should care of it, but DICOMDIR explorers)
1429 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1430 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1432 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1433 * ENH: vtkGdcmReader now supports LUT !
1434 (vtkgdcmViewer for now is not able to use them though)
1436 2003-11-05 Jean-Pierre Roux
1437 * in testSuite.py : new files names for checking the package
1438 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1439 that returns the pixel area size to the *aware* (vtk) user
1440 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1442 2003-11-05 Benoit Regrain
1443 * in testSuite.py : Modify the rules for checking the paths
1444 : Explicit error messages
1445 * in __init__.py : Related modif
1447 2003-11-03 Jean-Pierre Roux
1448 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1449 to be used by aware (vtk) users that want to manage
1450 LUT (and no to turn the PALETTE image into an RGB pixels one)
1451 * GetPixelType now returns 8U for 24 Bits images
1452 (vtkGdcmReader compliant)
1454 2003-10-31 Jean-Pierre Roux
1455 * Removal of *all* gdcmData images and add them again
1456 in order to loose the 'history' of un-anonymised images
1458 2003-10-31 Jean-Pierre Roux
1459 * RMV : removal of useless jBitsInJsample.h
1460 for both 8 and 12 Bits JPEG Lossy Libraries
1462 2003-10-31 Jean-Pierre Roux
1463 * ENH : Add the functions gdcmFile::GetImageDataRaw
1464 gdcmFile::GetImageDataIntoVectorRaw
1465 that act as GetImageData and GetImageDataIntoVector
1466 except the making of an RGB Plane from Gray Plane + LUT
1467 Intended to aware (vtk) users who know how to manage
1470 GetLUTRGBA return a R,G,B,A LUT if any
1471 lgrTotaleRaw gives the 'Raw' length
1472 GetImageDataRaw returns the gray Plane
1473 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1474 (They stay Grey, just like with other Dicom viewers :-(
1476 2003-10-30 Jean-Pierre Roux
1477 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1479 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1480 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1481 being coherents dicom files.
1483 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1484 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1486 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1487 * ENH: Two steps is necessary to please VC++ compiler...
1488 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1489 * ENH: Add include dir to medcon lib
1490 * FIX: only one function is being exported for now !
1491 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1493 2003-10-29 Jean-Pierre Roux
1494 * adding gdcmHeader::GetLUTRGBA
1495 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1496 --> Mathieu, the modif u're waiting for is not yet committed
1497 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1499 2003-10-27 Jean-Pierre Roux
1500 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1501 00191113.dcm DermaColorLossLess.dcm
1502 MxTwinLossLess.dcm RadBWLossLess.dcm
1503 * ENH: For version prior to vtkImageViewer2 -r 1.19
1504 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1506 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1507 * Removal of ido stuff in CMakeLists.txt
1509 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1510 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1511 * FIX: remove a call to ->Modified ... see comments
1512 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1514 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1515 * FIX: Problem with path for libvtkgdcmPython
1516 * ENH: Try adding a search script for python site-package
1517 * RMV: Remove some file from medcon lib that are not necessary
1518 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1519 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1520 * FIX: More pragma disable fro VC++,
1521 I don't think I break something as it is also disable in VTK/ITK.
1522 But it fasten debug compilation time.
1524 2003-10-23 Jean-Pierre Roux
1525 * gdcm now deals with 16 Bits Run Length Encoded images
1526 (they are compressed as 2 planes images,
1527 one for the high Bytes, the other for low Bytes)
1529 2003-10-22 Jean-Pierre Roux
1530 * Now CheckRead takes into account :
1531 - the bugged 'Leonardo' Siemens images
1532 - the XA images, sent thru the burning VPRO station
1533 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1536 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1537 * FIX: When copying a Makefile.am to CMakeLists.txt
1538 one should remove the '\'
1540 2003-10-22 Jean-Pierre Roux
1541 * in gdcmData adding a bugged 'Leonardo' Siemens image
1542 (wrong lengths in header)
1543 OK with gdcm, KO with the other viewers :-)
1544 * add a GE dlx XA image, thru the VEPRO burning station
1547 2003-10-21 Jean-Pierre Roux
1548 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1549 for a brutal checking of vtkgdcmViewer compliance
1551 2003-10-21 Jean-Pierre Roux
1552 * add the files for 'xmedcon' Jpeg Lossless library
1553 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1555 2003-10-21 Jean-Pierre Roux
1556 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1558 2003-10-21 Jean-Pierre Roux
1559 * garbage Siemens 'Leonardo' images dealt with
1560 (the patch is easy to remove)
1561 * cosmetic changes to avoid warnings
1563 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1564 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1565 no need to press 'r' now.
1567 2003-10-20 Jean-Pierre Roux
1568 * upgrade of checkRead.sh checkWrite.sh according
1569 to new Jpeg Lossless decompressor
1570 * add US.3405.1.dcm, a genuine RGB medical file ...
1571 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1572 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1574 2003-10-15 Jean-Pierre Roux
1575 * general anonymisation in gdcmData
1576 * adding the 'color files' from
1577 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1578 * adding some well knowed bugged-header images
1579 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1580 waiting for their inclusion in Python testsuite
1582 2003-10-15 Jean-Pierre Roux
1583 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1584 no longer seg faults when file is not found
1586 2003-10-14 Jean-Pierre Roux
1587 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1590 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1591 * TODO: *.in file to genereate a UseGDCM later
1593 2003-10-14 Jean-Pierre Roux
1594 * Some supposed-to-be Dicom Images have no preamble.
1595 OpenFile takes it into account
1596 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1597 * Missing elements added in dicomV3.dic
1598 (just to be affraid : have a look at
1599 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1600 and do it again next year ;->
1602 2003-10-13 Jean-Pierre Roux
1603 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1604 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1605 But there are NOT. It's fixed !
1607 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1608 * FIX: "jpeglib.h" was not found on VC++
1609 * FIX: vtkgdcm was not being installed
1611 2003-10-10 Jean-Pierre Roux
1612 * ENH : OpenFile closes the file if it *really* doesn't look like
1613 an ACR-NEMA / DICOM one.
1614 * FIX : testWrite no longer writes an empty file if the source file
1615 is not gdcm Readable
1616 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1619 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1620 * FIX: CMake generate now documentation
1621 * ENH: out of source doc build !
1622 * ENH: Generate both user and dev documentation
1623 * ENH: Should work on windows too
1624 * ENH: Only one doxygen config.in file is needed
1625 * FIX: make install should be ok now on ùnix plateform
1626 * FIX: PATH to dictionary was wrong (missing /)
1627 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1629 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1630 * vtkGdcmReader is now able to read rgb dicom file.
1631 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1632 * added a gdcmViewer to vtk test, use mouse to control
1633 window level & window width
1635 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1636 * CMake-ification of gdcm, we have now two build system
1637 * FIX: on cygwin Wsock32 doesn't exist
1638 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1640 2003-10-06 Emanuel Ollart
1641 * FIX : compilation process wad broken.
1642 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1644 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1645 * change gdcmViewer -> vtkgdcmViewer
1646 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1648 2003-10-06 Jean-Pierre Roux
1649 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1650 ( e.g : well known GE images with a wrong elem length,
1651 : Philips MRI Images with a wrong Huffman table)
1652 * still to be done : allow the reading of bugged LEONARDO Siemens images
1654 2003-10-03 Jean-Pierre Roux
1655 * Odd length strings are padded with '\0' (not with spaces,
1656 to remain compliant with already defined strings,
1657 like Transfert Syntax UID and others)
1659 2003-10-03 Jean-Pierre Roux
1660 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1661 to allow displaying RGB images (not only by affim ;-)
1663 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1664 * vtkGdcmReader is now able to read rgb dicom file.
1665 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1667 2003-10-03 Jean-Pierre Roux
1668 * A few nasty patches to allow the reading of a lot of nasty images
1669 ( e.g : well known GE images with a wrong elem length,
1670 : Philips MRI Images with a wrong Huffman table)
1671 * still to be done : allow the reading of bugged LEONARDO Siemens images
1673 2003-10-03 Jean-Pierre Roux
1674 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1676 2003-10-03 Jean-Pierre Roux
1677 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1678 to allow displaying RGB images (not only by affim ;-)
1680 2003-10-03 Jean-Pierre Roux
1681 * gdcmFile::GetImageDataIntoVector now
1682 - deals with MultiFrames MultiFragments Run Length Encoded files
1683 - deals with YcBcR (YBR_FULL) files
1684 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1685 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1687 (no sample found :-(
1689 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1690 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1691 Two reasons: - clear things
1692 - third parties acces gdcm through header files, so won't
1693 suffer anymore VC++ complains
1695 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1696 * add argv[1] in testvtkGdcmReader.cxx
1699 2003-09-24 Jean-Pierre Roux
1700 * The lines are now eigthy characters long.for
1701 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1703 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1704 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1705 char* to std::string. Thus, the use of strdup becomes useless. (see
1706 previous commis of Malaterre)
1707 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1708 before the last Malaterre's commit.
1710 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1711 * This commit should fix the Debug building under VC++, the problem
1712 was mainly a mixture of debug and release lib being loaded at startup.
1713 * I also remove a depency to a specific C function: strdup. Because I had
1714 to force the link to msvcrtd (whereas strdup is in libc).
1716 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1717 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1718 located in the gdcmCommon.h file. All use of reference of tha has been
1719 changed to now use the variable GDCM_UNFOUND.
1721 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1723 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1724 Dicom dictionary. The test suite can now be run again. Note:
1725 I'm note very happy with the " (RET)" changes. I believe this
1726 RETAINED comment should be dropped when parsing the dictionary.
1727 - PACKAGER corrected
1729 - AUTHORS updated and now in alphabetical order
1730 * Makefile.am now exports gdcm.dsw for Windoze users.
1732 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1733 * cygwin complains about missing std:: in subdir Test/
1735 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1736 * remove some methods that are now in gdcmHeaderHelper
1738 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1739 * vtkGdcmReader set spacing and origin correctly
1741 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1742 * Fix a few delete/delete[] mismatch
1744 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1745 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1746 interpretation to data given by gdcmHeader. For instance there are
1747 heuristics to get informations (look at different places).
1748 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1749 sorting DICOM images based on different strategies.
1750 * modified Makefiles accordingly.
1752 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1753 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1754 when building in debug mode
1755 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1756 src/win32/gdcmdll.dsp
1757 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1759 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1760 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1763 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1764 * src/win32/libgdcmjpeg12.dsp was not dos format
1765 * src/win32/libgdcmjpeg12.dsp :
1766 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1767 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1769 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1770 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1772 * src/gdcmFile.cxx : bug fix in affectation type
1773 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1774 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1775 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1776 symbols... future problem ?
1778 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1779 * src/win32/libgdcmijpeg12.dsp was missing
1780 * modified gdcm.dsw accordingly
1782 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1783 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1785 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1786 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1787 commit of JPR (before his hollidays to facilitate our work).
1788 * setup.py : bug fix in code. Modifications made while the last commit
1789 of JPR. The code hasn't been tested before the commit... it's so
1790 useless to make that (for best programmer that is JPR) !!!
1792 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1793 * tagged the current version as Version0_3 (i.e. version 0.3)
1795 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1796 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1797 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1798 * *.dsp : modifications to use new libgdcmijpeg8 library
1799 * setup.py : bug fix on VTKPATH variable
1800 * PACKAGER : adding all concerning windows
1802 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1803 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1805 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1806 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1807 test suite reported error.
1808 * PACKAGER file added (describes what a packager must do when
1809 packaging a new release).
1810 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1811 * configure.in: upgraded version number to 0.3.0
1812 * fixing build of rpm (through rpm -ta):
1813 - Doc/Makefile.am exports proper doxygen files
1814 - src/jpeg/libijg8/Makefile.am exports the include files.
1816 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1817 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1818 * src/gdcmHeader.h : formatting code
1820 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1822 We were obtaining error message from vtk. Now, creation of file list
1823 is made in an internal list to prevent this problem.
1824 Bug fix when output is empty.
1825 Bug fix in update of progress value. Previous commit for this was a bad
1827 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1829 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1830 * src/gdcmHeader.h : added method to get the file name
1831 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1832 files. Added method to remove all files on the input
1833 Added FIXME comment concerning the bad parsing of header made by
1834 ExecuteInformation method (in ExecuteData method)
1836 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1837 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1838 when using make instal.
1839 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1840 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1842 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1843 * setup.py : adding include dir of jpeg lib to compile all sources
1844 * */Win32/*.dsp : JPR fix for windows compilation
1846 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1847 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1849 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1850 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1852 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1853 * setup.py is again effective on un*x (takes into account the
1854 addon of the jpeg library)
1855 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1856 * Doc/Doxy* updated (includes above enhancements)
1857 * INSTALL now points to web documentation
1859 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1860 * src/gdcmHeader.h doesn't make unnecessary reference to
1862 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1864 * src/gdcm*.[cxx|h] :
1865 - to allow compilation with gcc 3.x
1866 -- clean up of STL usage (added explicit usage of std::)
1867 -- small fixes on exceptions.
1868 Note: linking not tested !
1869 - clean of doxygen comments to avoid warnings at documentation
1871 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1872 dependent convertion).
1874 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1875 * Clean up of previous JPR garbage commit (not even commented in the
1877 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1878 - moved all jpeg related files from src to src/jpeg/libijg8, with
1879 addition/modification of Makefile.am and configure.in.
1880 - the testSuite is still brain damage (not guilty).
1882 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1883 * WrapVTK.py : modifications to get correctly vtk source files to
1885 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1886 (FileName -> Filename)
1888 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1889 * vtk/vtkGdcmReader.[cxx/h]:
1890 - UpdateProgress method should now be effective
1891 - removed the limitation on having only images loaded (as opposed
1893 - when building a stack of images/volume, a lesser number of
1894 gdcmHeader and gdcmFile instances should be used (hopefully
1895 accelerating things).
1896 - when building a stack of images/volumes, files which are not
1897 loadable (wrong path-filename, wrong permissions on existing file,
1898 or file not parsable by gdcm) are replaced with a black image
1899 in the stack (for the caller to notice the problem).
1901 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1904 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1905 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1906 between standard library (std) and vtk library (problems are found
1907 under Windows... thanks Windows !)
1909 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1912 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1914 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1915 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1917 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1918 * When compiling with distutils (see setup.py) the C++ compiler is
1919 called with different flags than the default ones (with automake).
1920 In order to fix all those warning, I compiled gdcm with the command
1921 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1922 and went for warning fixes:
1923 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1924 up from unused variables.
1925 - vtk/vtkGdcmReader.cxx: potential bug fix.
1926 * src/gdcmHeader.h: Doxygen warning cleanup
1928 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1929 * gdcmPython/gdcm.i:
1930 - typemaps correction to take into account the systematic replacement
1931 of "using namespace std" with std:: prefix e.g. std::list,
1932 std::string... (cf changes of 2003-05-21).
1933 - gdcmGlob global variable of type gdcmGlobal (defined in
1934 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1935 exported to Python a as cvar.
1936 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1937 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1938 gdcmDictSet.GetPubDictTagNames() and
1939 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1940 C++ static methods).
1941 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1942 with the above changes.
1944 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1945 * setup.py, manifest.in : bug fix under linux
1947 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1948 * Modification of setup.py to compile vtk part too. Then, we have 2
1949 wrappers which must work with same distutils. For that, we have a
1950 generic distutils in distusiltsWrapping.py ; with :
1951 - build_extWrap class to wrap generically all extensions,
1952 - ExtensionWrap base class for all wrapping extension that contains
1954 - Wrapper interface which wrap sources
1955 + In WrapSwig.py we have extension and wrapper for Swig
1956 + In WrapVTK.py we have extension and wrapper for VTK
1957 * MANIFEST.in : modifications to consider vtk directory and new python
1958 files for compilation
1960 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1961 * Added python wrappers of vtkGdcmReader vtk class (see the
1962 source in vtk/vtkGdcmReader.cxx) :
1963 - vtk/Makefile.am now builds a library
1964 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1965 python library (as opposed to _gdcm.so wich are the python
1966 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1967 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1969 - configure.in has an additional flag --enable-vtk that needs
1970 to be set to enable compilation of vtk related code, that is:
1971 + vtk/vtkGdcmReader.so and
1972 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1973 + gdcmPython/vtkgdcmPython.so (see above)
1974 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1975 be read when compressed or when HighBit + 1 != BitsStored),
1976 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1977 the usage of the python wrapper of vtkGdcmReader vtk class.
1978 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1979 * src/*.[h] all occurences of stl classes are now prefixed with
1980 std::, and all occurences of "using namespace std;" where removed.
1981 This is to avoid pollution of global namespace in included files.
1982 Apparently vtk does not avoid this pitfall: when using both
1983 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1984 collision of various stl members (principally cout...).
1985 * gdcmPython/testSuite.py now cleanly removes temprory generated
1987 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1988 comply with above changes)
1990 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1991 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1992 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1993 vtk data structure (an image Flip was required).
1994 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1995 * cosmetic changes in documentation.
1997 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1998 * src/gdcmHeader.cxx: the constructor no longer exits when an
1999 unexisting file is given as argument.
2000 * The subdirectory Data (containing all the images used for the
2001 test suite) is not part of this repository anymore. A new module
2002 containing those images is now available at
2003 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2004 with the name gdcmData.
2005 All the python scripts (including the package initialisation file
2006 gdcmPython/__init__.py) were adapated to take this change into
2007 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2009 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2010 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2011 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2012 demo of the usage of this class.
2013 Compilation of this vtk part is only done when using the --enable-vtk
2014 at configure (or autogen.sh) stage.
2016 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2017 * More memory link related corrections and documentation fixes.
2019 - maximum info is obtained with a command of the form:
2020 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2021 --show-reachable=yes PrintHeader
2022 - the remaining reachable blocks seem to come from the STL
2023 allocation scheme through the usage of map and list. It looks
2024 like this memory cannot be freed but it is not a memory leak
2025 (in fact further invocation to the STL would recollect the
2026 unused memory allthough it cannot explicitely be freed).
2027 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2028 of displaying an image parsed with gdcm and displayed with VTK.
2029 Note: some images don't seem to work e.g.
2030 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2031 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2032 Allthough this weakens the semantics, it is a ditch attempt to
2033 make gdcm more thread friendly.
2035 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2036 * Memory link hunt (by using valgrind through the command
2037 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2038 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2039 gdcmHeader::_dicom_vr.
2040 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2041 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2043 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2045 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2046 * src/Makefile.am now exports all the necessary include files at
2050 * UpdateGroupLength replaced by new one
2053 * UpdateGroupLength re-written using H-Table
2054 (named UpdateGroupLengthNew untill checks are over)
2056 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2057 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2058 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2060 - gdcmHeader::GetPubElValSet removed.
2061 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2062 UpdateGroupLength, WriteElements, Write.
2063 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2064 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2065 carried the same semantics.
2066 - src/gdcmHeaderIdo.cxx changed accordingly.
2067 - gdcmFile::WriteBase now regroups all the codes from previous
2068 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2069 - enum FileType moved to gdcmCommon.h
2070 * src/gdcmHeader.cxx AddDefault trashed
2071 * gdcmGetXSize added
2072 * getimageDataSize now calls gdcmGetXSize
2073 * Test/*.cxx changed to agree with above changes
2075 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2076 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2077 (to avoid double call by end user).
2078 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2079 by end user, since gdcmHeader::gdcmHeader now handles it.
2081 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2082 * gdcm/Doc many doxygen changes:
2083 - Doxyfile now has two different versions, DoxyfileUsers that generates
2084 the html.users end users oriented documentation and
2085 DoxyfileDeveloppers that generates the html.developper developper
2086 oriented documentation.
2087 - README changed accordingly
2088 - requirement.txt removed (old design info moved to TODO).
2089 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2090 DoxyMainPage.txt, DoxyPython.txt provide more information.
2091 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2092 be updated by simply regenerating the docs with doxygen and copying
2093 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2094 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2095 all the tests in the form "if (<map>.count() >1)" were removed.
2096 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2097 ill-formed documentation sections.
2098 * src/gdcmHeader.cxx: ditto
2100 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2101 * setup.py fixed for un*x (needed macro for stdint.h)
2102 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2103 un*ces with sh-utils test utility.
2104 * gdcmPython/demo/test.py renamed to PrintHeader.py
2105 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2106 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2107 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2108 * src/gdcm*.cxx JPR's bad inclusion fixed.
2110 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2112 * gdcmPython/demo/test.py changed accordingly.
2114 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2115 * gdcmPython/Makefile.am fixed linking against libstdc++
2116 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2117 * Swig subdir (historical tests of swig version 1.3.17++) removed
2118 * Test/testChangeEntete.cxx some lines commented out in order to make
2120 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2121 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2123 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2124 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2125 hence the user doesn't need this explicit call.
2126 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2127 i.e. LoadElements() call removed.
2128 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2129 - src/Makefile.am declares the proper flag for g++.
2130 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2131 for adding user defined new tags.
2132 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2133 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2134 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2136 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2137 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2138 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2139 src/Makefile.am : the project should properly compile and install
2140 with the autotools, included the python wrappers part.
2141 * gdcm.spec.in : added a spec file for RPM packaging.
2143 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2144 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2146 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2147 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2148 to exported to the environement (see gdcmPython/testSuite.py
2150 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2151 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2152 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2153 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2154 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2156 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * gdcmPython/__init__.py doesn't crash anymore when running in
2158 in InstallMode or PreInstallMode but with an environement given
2159 value of GDCM_DICT_PATH.
2160 * src/gdcmDictSet.[cxx/h] coding style.
2162 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2163 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2164 * src/gdcm.h general comments moved to TODO, and README
2165 * src/gdcm.h should now be seen as a user commodity (including it
2166 should suffice to fully use gdcm). It is nowhere including within
2167 any of the kernel files src/*.cxx and src/*.h.
2169 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2171 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2173 * src/gdcm*.cxx only include their corresponding include file
2174 (as opposed to gdcm.h)
2175 * gdcmPython/gdcm.i changed accordingly
2176 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2177 the autogen.sh generated "make snapshot" command to work.
2178 * autogen.sh removed history related references to crea package.
2180 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2181 * distutilsSwigCPlusPlus.py work around some swig portability
2184 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2185 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2186 was done in a last ditch attempt to get setup.py _really_
2187 operationnal. The python/gdcmPython layaout add the advantage
2188 of hidding away the python related distutils specific files
2189 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2190 Alas, the src directory was out of scope (i.e. it's relative
2191 position to setup.py was ../src) which made things impossible to
2192 handle (see previous version of python/setup.py). Crossing fingers...
2194 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * python/setup.py now works on Un*x. (harder than I thougth)
2196 * python/distutilsSwigCPlusPlus.py can now have include files
2197 among the list of sources.
2199 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2200 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2201 * modifications in MSVC projects
2203 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * As stated by the first lines of Test/ExceptionAndPython/README, it
2205 looks like we can move back to original usage of exception within
2206 src/gdcm* and hence remove the errno stuff that was introduced
2207 as a quick and dirty fixture of this problem (added to the TODO).
2208 * Doc/Doxyfile configuration file for Doxygen and corresponding
2209 README file for usage added.
2210 * Test/testWrite.cxx added. This new test comes from a split of
2211 test.cxx that is now reverted to its original purpous i.e.
2212 testing the proper parsing of a Dicom related file.
2213 testWrite.cxx concentrates on testing the IO part of gdcm.
2214 * Test/bug1.cxx (containing a bug on WIn32) added.
2215 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2216 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2217 whose purpose is to publish the content of the TagNames of the
2218 Dicom public dictionnary were not accessible without an
2219 instance of class gdcmHeader.
2220 - those methods are now static methods of gdcmDictSet and hence
2221 require no instances at all to be invocated.
2222 - within gdcmDictSet this change required to change some method
2223 to class methods (i.e. are now static) among which SetDictPath
2224 (renamed to BuildDictPath) and LoadDefaultPubDict.
2225 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2226 the above changes by calling the new method classes of gdcmDictSet.
2227 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2228 the above to be effective.
2229 * python/gdcmPython: in order to wrap properly the above changes
2230 for Python, swig version now needs to be > 1.3.17.
2231 * python/gdcmPython/Makefile fixed to adapt itself to new
2232 configure/make shema introduced by Johan Montagnat (thanks for the
2233 contribution). Alas this Makefile cannot be turned into a proper
2234 Makefile.am without some heavy changes in the configure.in
2235 (for python dectection).
2236 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2237 now avoids publishing the empty entries.
2239 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2240 * python/setup.py : bug fix concerning install under windows
2241 ExtraPath reused :-P
2242 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2244 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2245 * Dicts/dicomV3.dic : remove double spaces !!!
2246 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2247 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2250 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2251 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2252 method. Doxygenation.
2253 * src/gdcm.h clean up of JPR spurious comments.
2255 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2256 * python/distutilsSwigCPlusPlus.py now properly collects the
2257 shadow classes generated by "swig -c++" (gdcm.py in our case)
2258 when using "python setup.py install".
2259 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2260 reexports the working classes.
2261 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2262 by the classical C errno scheme. This is to prevent an obscure
2263 behavior of the python wrappers when importing wxPython.wx prior
2264 to gdcmPython (which ended up in an abort call). An illustration
2265 of this oddity can be found in the Test/ExceptionAndPython
2266 subdir (see the README file). This problem probably due to
2267 an combination of g++ and dynamic loading.
2268 * added Test/ExceptionAndPython (see above)
2270 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2271 * Changed the layout of the python part to avoid bloating main
2272 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2273 i.e. the distutils arsenal. All the python related stuff is
2274 again in a python subdir, but the package itself is now in
2276 * setup.py was cleaned up:
2277 - pythonIncludePath removed
2278 - python setup.py bdist target is now functional.
2279 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2280 collision with other packages). gdcmPython/demo/*.py changed
2283 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2284 * python subdir moved to gdcmPython (preparation of distutils packaging).
2285 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2286 distutils installer is operational.
2287 * - gdcmPython/__init__.py now properly loads the swig generated
2288 shadow classes (from gdcm.py).
2289 - gdcmPython/demo/*.py changed to import the package gdcmPython
2290 instead of gdcmPython/demo/load.py.
2291 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2293 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2294 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2295 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2296 entries within the associated public Dicom dictionary resp. the same
2297 information but sorted by the fourth field (PAT, IMG, DIR) of the
2299 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2300 are now in the "???" group.
2301 - python/gdcm.i changed accordingly,
2302 - python/demo/printGroupedPublicDict.py added, that gives an example
2303 of the above new functionalities in Python.
2305 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2306 * src/gdcm.h, gdcmHeader.cxx:
2307 - historic references to glib's g_malloc and g_free (#defined)
2308 were definitively removed.
2309 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2310 * src/gdcmElValSet.cxx:
2311 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2312 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2313 - GetElValue(string) renamed to GetElValueByName.
2314 - Added GetElementByName(string).
2315 * src/gdcmHeader.cxx: added
2316 - GetPubElValRepByNumber(guint16, guint16)
2317 - GetPubElValRepByName(string)
2318 - GetShaElValRepByNumber(guint16, guint16)
2319 - GetShaElValRepByName(string)
2320 - GetShaElValByNumber(guint16, guint16)
2321 - GetShaElValRepByName(string)
2322 - GetElValRepByNumber(guint16, guint16)
2323 - GetElValRepByName(string)
2324 - GetElValByNumber(guint16, guint16)
2325 - GetElValRepByName(string)
2326 * Doc/requirements.txt added.
2328 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * Test/Makefile building now depends on the one of libgdcm.so
2330 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2331 pixel data) aware which enables finding the address (offset) of
2332 the pixel data of JPEG encoded DICOM files. This leaves only a single
2333 file in the testSuite whose pixel data address (offset) is unknown.
2334 * python/testSuite.py changed accordingly.
2336 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2337 * VC++ has some strong limitations when working with the STL, as stated
2338 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2339 "Also note that some STL containers (map, set, queue, list, deque)
2340 cannot be exported. [...]
2341 Some STL classes contain nested classes. These classes can not
2343 This is caused by a designed limitation that once a template
2344 class is instantiated, it can not be re-instantiated and
2346 Since our usage of map<> is ubiquitous in gdcm, this "designed
2347 limitation" of VC++ is a pitfall.
2348 Hence the Python wrappers of gdcm cannot be incrementally linked
2349 against the c++ dynamic library. The dirty but only workaround is
2350 to forget about incremental link of dynamic libraries and to generate
2351 the Python wrappers library with the inclusions of the underlying C++
2353 The following modifications concern this matter on Win32/VC++:
2354 - wrapping python correct with standalone wrapped dll (don't use separate
2355 dll under windows !!!!)
2356 - python21_d debug mode enabled (ask Frog how to use it :-)
2357 - NO problem with having an STL member of class for example string in C++
2358 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2359 - Python test of dcmlib in Python is ok under windows on a large set
2361 * removed glib references
2362 * typedef's inserted in gdcm.i for correct swig type management
2364 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2365 * python/demo/*.py load.py extracted from test.py. Added explore.py
2366 that only displays required tags and testAll.py that parses all
2367 the files of the testsuite without using unittest.
2368 * python/testSuite.py other additional test on new files added.
2369 * Data/* new test files added accordingly to the testSuite.
2370 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2371 the vr in the file differs from the one of the dictionary.
2373 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2374 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2375 values, but limits itself to values which are below a user specified
2376 size (by default 1024 bytes).
2377 * python/gdcm.i : elements not loaded (because their size is above the
2378 user specified treshold) are exported with their TagKey as key of the
2379 python dictionary. This enables the testsuite to make some checks
2380 on the unloaded elements (since we have their offset and size).
2381 * python/testSuite.py
2382 - now tests for the existence and proper value of the pixel data
2383 - two new examples added.
2384 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2386 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2387 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2388 aware. See the strategy comments in gdcmHeader::FindeLength().
2389 * Test/test.cxx now accepts a filename as first argument.
2390 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2391 * python/testSuite.py changed to integrate test on above files.
2393 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2394 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2395 the vr was also RET.
2396 * python/testSuite.py more tests added.
2398 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * python/testSuite.py unittest test suite added (uses Data)
2400 * Data/* dcm and acr files for the test suite.
2401 * glib dependance removed from un*x version. We now use ISO C99
2402 7.18 Integer types (see stdint.h)
2403 - python/Makefile, src/Makefile src/gdcm.h
2404 * src/ when an explicit vr (like dicom files) suddenly poped an
2405 implicit element we use to mark the underlying DictEntry of the
2406 concerned ElValue with "Implicit". This strategy was damageable
2407 too the public or provite dictionaries, since some of their vr
2408 would be changed. Since Header::FindLength heavily relies on the
2409 detection by Header::FindVR of falsely explicit elements, I
2410 added an extra ImplicitVr member to ElValue (boolean).
2411 The rest of the changes we the necessary adaptations.
2413 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2416 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2418 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2419 * Adaptation for porting to VC++:
2421 o forced to use std namespace (for string to be known)
2422 o all class use __declspec export style on WIN32
2423 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2424 (in stdlib.h on Win32 but in std:: for gcc)
2425 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2426 variable GDCM_DICT_PATH.
2427 * src/gdcmHeader.cxx verbose comments made discrete.
2429 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * python/gdcm.i: added a typemap that converts a C++ hashing table
2431 to native Python dictionary.
2432 * python/demo/test.py:
2433 - now uses the native dictionary for exploration of gdcmHeader.
2434 - takes an optional filename argument (the file to parse).
2435 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2436 PubElVals hashing table.
2437 * Dicts/dicomV3.dic removed error prone trailing spaces.
2439 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * Python wrapping process moved away from src/Makefile to
2441 newly created python/Makefile (as well as gdcm.i)
2442 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2443 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2444 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2445 from the environement variable GDCM_DICT_PATH (when existing).
2446 * src/gdcmDict::GetTag bug fix.
2448 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2449 * Straightforward temporary fixes for swig to build the python wrappers.
2450 src/Makefile now has a python working entry [by working we mean
2451 that we can import de shadow classes without errors].
2453 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2454 * hashtest.cxx removed (since allready in Test)
2455 * src/gdcmlib.h renamed to src/gdcm.h
2456 * src/dcm.i renamed to src/gdcm.i
2457 * src/Makefile prepared for python wrapping
2459 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2460 * src/gdcmHeader.cxx :
2461 - Parsing of header is now separated from loading of element values
2462 (see gdcmHeader::LoadElements).
2463 - general clean up of hopefully all file access (creation of
2464 ReadInt16 and ReadInt32)
2466 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2467 * src/gdcmHeader.cxx :
2468 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2470 - SetLgrElem renamed to SetLength
2471 - GetLgrElem renamed to GetLength
2472 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2473 * src/gdcmElValSet.cxx fixed both GetElValue methods
2474 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2475 due to IdoDude was cleaned out.
2477 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2478 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2479 concentrates on finding the value representation (when it exists).
2480 RecupLgr now only finds the element value length, and it avoids
2481 returning the unecessary skL (skipped length).
2482 Also, offsetCourant was simply removed (with taille_fich) since
2483 it was redundant with the File position internals (by using
2484 ftell and fseek). This also made skL (see above in RecupLgr) usage
2486 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2487 on the libido specificities which are handled through class
2489 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2492 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2493 * Truckload of changes. Parsing of header is barely functional
2494 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2496 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2497 * src/gdcmHeader.cxx many addons of low level methods
2499 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2500 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2501 and _IdDcmSWAP_LONG.
2503 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * This corresponds to all the changes decided at the meeting of
2505 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob