1 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/ : fix compilation warnings for the Write method (2 different
3 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
4 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
5 variable... create a static method in gdcm::Document to access to
8 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
10 file, to be accessed by other files (like gdcmFile). Remove commented
11 code. Move the change of the header to the gdcmFile, using the
13 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
14 To be sure of that (and simplify calls), the Write of the header now
15 gets a file name and not a file pointer (std::ifstream).
16 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
17 DocEntryArchive. Remove all open of the written file
19 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
22 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
24 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
26 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
27 some corresponding methods. Write correctly the file and check before
29 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
30 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
31 is now on RGB datas (as before my last commit
32 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
34 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
36 Add a print information of the type of the entry
37 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
38 It was in the gdcmFile, and all write have been regrouped
39 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
40 Write correctly all dicom files (in decompressed mode only at this time)
41 * Test/ : test on files are now made using Raw datas and not color datas if
43 * Example/PrintFile.cxx : add more printings
45 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * Amelioration of code, remove some code copy. For the loading of
47 BinEntry (in gdcmDocument), add the test to verify if the file is already
50 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
52 remove a DocEntry in the header (push an empty DocEntry)
53 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
54 lines. Bug fix in the initialization of the PixelConvert and the
56 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
57 use in TestCopyDicom (now this test can run under windows... but fails)
58 * Test/TestCopyDicom.cxx : amelioration of the test :
59 - test the pixels written
60 - add test points to quickly find where is the error
61 - can set a file name input and output in arguments
62 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
63 amelioration of the test output
65 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
67 all replaced DocEntry's
68 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
69 Now, each needed DocEntry to modify is duplicated, modified and inserted
70 to the header using DocEntryArchive. Thus, after save, we can restore the
73 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
76 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
78 correct to copy it. The DictEntry is specified at the DocEntry creation,
79 then, it musn't change in the time.
80 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
81 header correctly. At this time, the change is only made for the first
82 level of the Document. In the future, it might consider sequences.
83 The change is made by replacing a DocEntry by an other that is created
84 outside the class. The old value is kept. When we restore the header
85 status, the added DocEntry is deleted and replaced by the old value.
86 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
87 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
88 set the write type to explicit VR, implicit VR or ACR. Add methods to set
89 the write mode to native, decompressed or RGB (but not used at this time)
91 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
93 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
95 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
97 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
99 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
100 set because already copied when copying the BinEntry's of the header
101 * Test/TestAllReadCompareDicom.cxx : remove warnings
103 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
105 Two problems appear when doing it :
106 - with the gdcmFile : when the GetImageData method is called, the pixels
107 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
108 datas (pixels). And each structure destruct the datas when it's
109 destructed. So we have two destructions for the same datas. To solve it,
110 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
111 datas or not. If it doesn't own datas, then they will not destroyed by
113 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
114 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
115 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
116 create a double destruction of the same DocEntry's. So, to solve it,
117 the TagHT is simply cleared and the DicomDir* elements are destroyed.
118 * TODO : add an entry concerning memory leaks in the DicomDir
120 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
122 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
125 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
127 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
128 after it have been deleted
130 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
131 * FIX: src/* fix the doxygen warnings.
132 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
133 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
134 was erroneously defined with a size of 15 instead of 16. [many thanks
135 to Jean Michel Rouet for pointing out this bug].
137 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
138 1. Finish merging JMR patch for writting DICOM from scratch
139 2. Fix -hopefully- bug with MONOCHROME and space vs null character
140 3. Use const ref when possible
141 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
142 5. A few more comments
143 6. CreateUniqueUID can now be called without parameter"
145 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
146 * ENH: Slightly bigger patch:
147 1. Getting toward full integration of JMR patch for writting dicom from scratch
148 2. Update Test to test part of this patch: CreateUniqueUID
149 3. File was not close properly in gdcmDict
150 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
151 5. Use of const ref instead of copy (speed issue)
152 6. Remove temporary (duplicate) string in TranslateToKey
153 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
154 8. Do not repeat virtual in subclasses
155 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
157 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
158 * Apply first patch toward better string comparison when dealing with broken
159 DICOM files. Essentially the string could be padded with a space instead
160 of a null character as defined by standard
162 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
164 because never used... and in the same time, that's remove some memory leaks
166 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/gdcmFile.cxx : now delete the PixelConvert instance.
168 * In examples and tests : change the type of image data variables from void*
169 to uint8_t*. Remmove all delete on image data variables
171 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
173 Verify the file pointer value before open the file, and if it's not null,
174 a verbose message is generated.
175 Close correctly the file when the file isn't considered dicom-like. The
176 correctly close is a call to CloseFile.
177 When closing the file pointer, test if its not null to close the file.
178 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
179 file. For an uncompressed image, the copied datas correspond in the least
180 case to the image size (calculated) or the image size specified in the
181 header. A verbose is generated if these two size mismatch
183 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
185 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
186 break under windows (with msvc6 compilation).
188 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
190 compiling with MSVC6)
192 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * Bugs fix for the Windows build with VC6
194 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
195 needed (only for projects required VTK). If the VTK is included in all
196 projects, there is conflicts with the jpeg lib of vtk when compiling the
197 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
198 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
199 when compiling the gdcm_wrap.cxx file (created by the compilation of the
201 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
202 (like it's already made for the cout use). Otherwise, conflict with the
205 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
206 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
208 - comments on the DicomDir::Method related usage added.
209 - now that we use the namespace gdcm, a lot of internal classes do
210 NOT need to be wrapped anymore.
211 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
212 DicomDir::Method) new example added.
214 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
215 * Improve string manipulation. I now inforce the notion of 'DicomString'
216 A DicomString can contain as many \0 as they want
217 and it is *always* of even length.
218 We only support odd length for very rare case.
219 And in the near future this should be removed.
221 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
222 * /binary_write/ gdcm source. Now even on big endian we are writting
223 little endian. This should -heopfully- fix some tests
225 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
226 * Now the dictionary is compiled into gdcm lib. This is a default
227 behavior, thus any dic file specified is picked before failback to
228 the one comiled into lib
230 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
231 * Change internals for gdcmDict. Don't use any 'new' any more.
232 This should definitely solve any leak problem, and we should be
233 as fast as before, as long as don't modify too much the dictionary.
235 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
236 * STYLE: ivars should start with a capital letter.
237 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
238 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
240 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
241 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
242 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
243 new 2004 dictionaries added (thanks to JPR).
244 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
245 * CLEANUP_ROUND (15) for gdcmPixelConvert
246 - RLEFrame::NumberFragments is now of type unsigned int
247 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
248 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
251 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
252 * Initial work in gathering all transfer syntax accessors. clearly
253 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
254 ivars, but only one transfersyntax (class) ivar with equivalent method on
257 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
259 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
260 discussed (plus I didn't like having a 2000 lines patch not commited)
262 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
263 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
264 * CLEANUP_ROUND (14) for gdcmPixelConvert
265 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
266 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
267 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
269 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
270 anymore and hence avoids storing a copy of PixelConvert::Decompressed
271 into File::Pixel_Data.
273 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
275 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
276 * CLEANUP_ROUND (13) for gdcmPixelConvert
277 Substituted File::ParsePixelData() with PixelConvert::Print() new
279 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
280 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
281 method to those classes.
282 - src/gdcmFile.[cxx|h]:
283 -- Added a ::Print() method.
284 -- PixelConverter is now a reference instead of a member.
285 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
286 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
288 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
289 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
290 collaboration diagram and inheritance diagram should be generated with
292 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
293 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
294 pointlessly wrapped (see
295 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
296 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
297 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
298 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
299 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
300 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
301 -- File::Initialise: PixelConverter setup moved away to
302 PixelConverter::GrabInformationsFromHeader()
303 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
304 interpretation moved away to PixelConverter::BuildRGBImage()
306 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
307 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
308 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
310 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
311 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
312 displayed on Win32 when a brutal abort() occurs (because of uncatched
313 exception). See TODO new entry of this commit for more on this.
314 * TODO added new entry.
315 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
316 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
317 - HandleColor is no longer called from gdcmFile.cxx
318 - gdcmPixelConvert.cxx clean up on method arguments and internal
319 variable names for semantical coherence.
321 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
322 * Finished lossless transition, not only do we now read all lossless jpeg
323 images, without the need of the Cornwell lib, but we do read them properly now
324 * To reduce code (well to avoid code duplication), I defined a common place
325 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
326 redefine symbols. This is not prefect but this the best solution I found for a
327 compilation time jpeg option.
329 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
330 * Update jpeg ijg lib to support lossless jpeg implementation
331 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
333 * Also added a special copyright for dcmtk since we use their bugfixes.
336 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
337 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
338 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
339 matters, as stated in warning note at begining of %include section).
340 * src/gdcmDicomDir*.[cxx|h]: coding style
341 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
342 * src/gdcmJpeg8.cxx: doxygen fix.
343 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
344 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
345 from File:: to PixelConvert::.
347 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
348 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
349 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
350 - more code moved away from File:: to PixelConvert::
351 - fat setup of PixelConverter set in place in File::Initialise.
353 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
354 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
355 namespace at the file system level. So now you should convert your examples
357 gdcmHeader -> gdcm::Header
358 It would be nice if people keep in mind to no open the namespace, since it
359 allows compilation on broken plateform which were defining common symbol in
360 the standart namespace (like LP, Unknown ...)
362 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
363 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
364 The JPEG fragments are now parsed at the same stage than the RLE
365 information. All code related to JPEG is now in gdcmPixelConvert:
366 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
367 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
368 export a gdcmFile:: method. Those are simply global functions
369 (for the time being this is better than having them attach to
370 either gdcmFile:: or gdcmPixelConvert::).
371 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
372 and stores the result in a gdcmJPEGFragmentsInfo.
373 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
374 code (among other stuff) moved away from gdcmFile:; to
377 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
379 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
380 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
381 clean up of RLE related code.
382 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
383 - src/gdcmRLE.cxx removed
384 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
385 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
386 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
387 * CLEANUP_ROUND (9) for gdcmPixelConvert
388 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
389 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
390 away from gdcmFile:: to gdcmPixelConvert::.
392 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
393 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
394 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
395 This is because Parse7Fe0 used to parse the pixels to compute the
396 length. This task was passed over to FindDocEntryLengthOB() a long
397 time ago, EXCEPT I had forgotten the OW case...
398 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
399 we just recylce the code for parsing RLE fragments and computing
401 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
402 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
403 with the retired Parse7Fe0().
404 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
405 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
407 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
408 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
409 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
410 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
411 - src/CMakeLists.txt: alphabetic order reodering + new entries.
412 * CLEANUP_ROUND (4) for gdcmPixelConvert
413 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
414 to return an unused length.
416 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
417 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
418 this should be cleanner from the plane view. The iostream are erally a pain
419 to use to do simple stuff.
421 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
422 * Redo the compilation of the ijg jpeg library. Now only one source is
423 necesseray. No need to rename file by hand what so ever. CMake handle the
424 copying of the file within different directory, configure header file to
425 modify some symbol. The only addition made to ijg wasd a mangle table so
426 that symbol are different wether we are within 8bits or 12bits.
428 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
429 * Added documentation of vtkgdcmReader on Website:
430 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
431 with it's binary name).
432 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
433 the Website to be more complete.
434 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
435 doxygenated documentation.
436 - Doc/DoxyVtkGdcmReaderExamples.txt added
437 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
438 DoxyVtkGdmReaderExamples.html )
439 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
440 * CLEANUP_ROUND (3) for gdcmPixelConvert
441 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
443 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
444 * CLEANUP_ROUND (2) for gdcmPixelConvert
445 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
447 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * CLEANUP_ROUND for gdcmPixelConvert:
449 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
450 - src/gdcmPixelStuff[h|cxx] removed
451 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
452 - src/CMakeLists.txt changed accordingly
454 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
455 gdcmVersion.py moved to newly created ATTIC related
456 gdcmPython/SetupOldies/ directory.
457 * Autotools clean up:
458 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
459 - autogen.sh configure.in acinclude.m4 python.m4 removed
461 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
462 * src/*.cxx *.h Reference to License.htm fixed to License.html.
463 * Doc/CMakeLists.txt, doxygen.config.in: fix.
464 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
466 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * TODO updated with Mathieu suggestions. I proposed a template for
468 describing TODO entries and used it for new entries.
469 * Added Doc/Website/CodingStyle.html, Developpers.html,
470 DeveloppersPython.html, GdcmDataCvs.html and
471 DownloadVersion0_1.html, DownloadVersion0_3.html.
472 * Some Doc/*.txt Doxygen files (which do not really concern the
473 documentation itself, but the website) moved to html and
474 placed in directory Doc/Website:
475 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
476 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
477 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
478 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
479 * CMakeLists.txt changed accordingly.
480 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
481 DeveloppersPython.html
482 * INSTALL nows refers to Doc/Website/Installation.html
484 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
485 * Added Doc/Website directory, that contains a first raw version
488 2004-09-23 Jean-Pierre Roux
489 * FIX In order not to be poluted any longer by casting problems,
490 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
491 we can now delete[] it safely
492 * VoidArea is now called BinArea (less confusing name),
493 and all the methods called ...VoidArea... are now ... BinArea...
494 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
496 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
497 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
498 clear) TagHT, which is an inherited member of gdcmElementSet. It is
499 up to the destructor of gdcmElementSet to clean up TagHt and it's
502 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
503 * Test/CMakeLists.txt: update to follow gdcmData renamings.
504 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
506 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
507 * ENH: added some utility method that builds a flat dictionnary
508 holding all the Dicom entries contained in the recursive structure
509 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
511 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
512 BuildFlatHashTable() that build a flat dictionary.
513 - src/gdcmElementSet.h: added a new private GetTag() accessor.
514 gdcmDocument is now a friend of gdcmElementSet.
515 - src/gdcmElementSet.cxx: clean up.
516 - Example/FlatHashTablePrint.cxx added.
517 - Example/CmakeLists.txt changed accordingly
519 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
520 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
521 moved away from gdcmDocEntrySet (since this class is an abstract class
522 acting like an interface). SQDepthLevel and BaseTagKey are now
524 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
525 and associated accessors. Doxygenation of the class.
526 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
528 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
529 Use SQDepthLevel accessor instead. ::Print() adapted.
530 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
531 - src/gdcmDocument.cxx changed accordingly.
533 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
534 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
535 - The following is the doxygen comment of the typedef declaration
536 of gdcmagKey in src/gdcmCommon.h:
537 gdcmTagKey is made to old an "universal" (as in URL, Universal
538 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
539 A dicom tag allways has a group and an element, but a set of tags
540 embeded in various (optionally nested) sequences and sharing
541 the same group and element all share the same (group, element)
542 "identifier". Hence the (group, element) cannot be used as an
543 identifier (in gdcm we shall refer to a "TagKey") of a tag.
544 In order to construct a proper tag identifier (i.e. a key) we
545 consider the following definition of a TagKey:
546 - let Group, Element be the string representation of the
547 group and element dicom tag members,
548 - let ItemNumber be the string representation of the integer
549 index of the considered item number of a sequence,
550 Let the key of a tag embeded in a sequence, noted SeqTag, be
552 /ItemNumber#Group|Element
553 where "/", "#" and "|" are characters acting as separators.
554 Then the general form of a gdcmTagKey is given by:
555 Group|Element<SeqTag>
556 where <SeqTag> means NO or many instances of SeqTag.
557 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
560 but the gdcmTagKey of a tag "embeded" is the first item of
561 a sequence, itself nested in the third item of a sequence is the
563 0004|1220/2#0008|0082/0#0008|0090
564 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
565 order to hold the new sequence compatible key. Previously, the
566 GetKey() method would look in the underlying gdcmDictEntry.
567 - src/gdcmDocEntry.cxx:
568 -- constructor now copies the underlying DictEntry key, in the local
570 -- ::Print: displays the member Key, instead of the (group, element).
571 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
572 - src/gdcmDocEntrySet.h:xi
573 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
574 -- now has a new BaseTagKey member.
576 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
577 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
579 This poses the problem with the semantics of the following lines
580 LoadEntryVoidArea(0x0028,0x1201); // R LUT
581 LoadEntryVoidArea(0x0028,0x1202); // G LUT
582 LoadEntryVoidArea(0x0028,0x1203); // B LUT
583 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
584 to the long FIXME note for what the problem is. Nevertheless in
585 order to get things working the dicom dictionary was altered !
586 Please fix things urgently...
587 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
588 information), see above note on moving the member VoidArea. Nevertheless
589 the following entries previously correctly set as US are now inproperly
591 0028 1201 OW IMG Red Palette Color Lookup Table Data
592 0028 1202 OW IMG Green Palette Color Lookup Table Data
593 0028 1203 OW IMG Blue Palette Color Lookup Table Data
594 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
595 of gdcmDocEntry moved to gdcmSeqEntry.
596 * src/gdcmSeqEntry.cxx: STYLE.
598 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
599 * Test/TestAllEntryVerify.cxx minor fix and added comments.
601 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
602 * gdcmPython/testSuite.py: all the test suite in python is now moved
603 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
604 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
605 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
607 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
608 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
609 to avoid inclusion recursion until STL is reached.
610 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
611 mecanism. errno.h is not included in gdcm anymore.
612 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
613 (gdcmFormatError now inherits from gdcmFormatUnexpected).
615 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
616 gdcmData/TestAllEntryVerifyReference.txt
617 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
618 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
619 exception_on_error parameter.
620 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
621 - vtk/vtkGdcmReader.cxx changed accordingly,
622 - Example/*.cxx and Test/*.cxx changed accordingly.
624 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
625 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
626 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
627 enable_sequences removed from gdcmHeader constructor and dependencies.
628 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
629 * gdcmPython/demo/PrintHeader.py: dummy fix.
630 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
631 skip_shadow removed from gdcmHeader constructor and dependencies.
632 * Example/*.cxx and Test/*.cxx changed accordingly.
634 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
636 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
638 2004-07-21 Jean-Pierre Roux
639 * FIX Now, Parsing and Printing a DICOMDIR do work!
640 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
642 2004-07-20 Jean-Pierre Roux
643 * FIX Some brain damaged headers have Zero-Lenght fields
644 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
646 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
648 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
649 variable (instance of gdcmDebug) by a definition macro, and the instance
650 is now in static in the gdcmDebug class
651 * src/gdcmSQItem.h : (FIXME) remove an undefined method
652 * Test/PrintAllDocument.cxx : bug fix in the result of the test
654 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
655 * WARNING: ctest now depends more tightly on gdcmData. You should
656 check out gdcmData properly for things to run smoothly...
657 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
658 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
659 we need the pixels not be loaded in order to use the ValEntry
660 that displays position and size).
661 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
662 This is a C++ based equivalent of gdcmPython/testSuite.py that should
663 be deprecated. If you have any doubts about the advantages of a
664 modern scripting language (read Python) versus grass root C++ (i.e.
665 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
666 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
667 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
668 Anyhow, consider documenting the gdcmData images in
669 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
671 * Test/CMakeLists.txt:
672 - now uses TestAllEntryVerify.cxx
673 - specific comments on oldACR00001.ima (now renamed in gdcmData
674 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
675 gdcmData/TestAllEntryVerifyReference.txt
678 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * src/*.[h|cxx] : typedef clean up
680 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
681 - TagKey renamed to gdcmTagKey (for external usage)
682 - VRKey renamed to gdcmVRKey (for external usage)
683 - removal of typedef duplication.
684 - Removed all unecessary inline keyword from class inline definitions.
685 - Some method|function(void) declarations replaced with method|function().
686 * src/jpeg/libijg12/jdhuff12.c:
687 - printf polluting ctest removed.
688 - TAB removal for comminting
690 - TestAllReadCompareDicom.cxx: added a test that compares all the
691 images in gdcmDataImages.h with corresponding images in
692 gdcmData/BaselineDicom/. When baseline images are not present
693 this test creates them.
694 Note: we need to validate each reference image, but before that
695 I'd like to rename them with a more explicit name...
696 - CMakeLists.txt: changed accordingly.
697 * Example/*.cxx: examples now only include gdcm.h (as opposed to
698 including each header needed).
700 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * Test/*.cxx and Example/*.cxx: moved some examples away from the
702 test suite to the Example directory. Are concerned:
707 - TestWriteSimple.cxx
708 * Test/CMakeLists.txt: added some comments on reasons for black listing
709 image gdcmData/oldACR00001.ima
711 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
712 * Test/CmakeList.txt: removed the following from black list (to be coherent
713 with removal from gdcmData):
714 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
715 - gdcm-MR-PHILIPS-16.dcm
717 Added the following because after last cvs update, they cause
718 ctest -R TestReadWriteReadCompare
720 - gdcm-MR-SIEMENS-16-1.acr
722 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
723 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
724 new comments in this file) we temporarily (sigh) move to a weaker
726 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
727 we don't need to black list the following images anymore:
728 - 8BitsUncompressedColor.dcm
730 - US-PAL-8-10x-echo.dcm
731 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
732 fixes and the beautified code ;-)
733 This fixes the bug introduced in version 1.42 (when beautifying)
734 that made the parsing of 8BitsRunLengthColor.dcm unproper.
735 Note: ctest was blind to this bug (this means we need to still
736 improve the test suite). The bug could be detected by using
737 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
739 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
740 and by displaying the (garbage) produced file temp.XDCM...
742 2004-06-29 Jean-Pierre Roux
743 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
744 - replace by uggly but working old code :-(
745 A lot of things should be OK again.
746 It's really urgent to have a test suite that *tests*,
747 to prevent Frog's beautifying sessions to break all the stuff
748 (twice, withing a fortnigh ...)
750 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
752 redundancy) to added Test/TestReadWriteReadCompare.cxx
753 * Test/CmakeList.txt: because the compare test of
754 Test/TestReadWriteReadCompare.cxx fails, the following images are
755 black listed: - 8BitsUncompressedColor.dcm
757 - US-PAL-8-10x-echo.dcm
758 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
759 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
760 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
761 and ad-hoc kludge. This kludge is now removed, and on encountering
762 such an image (OB field brain damaged) we set errno. Then in
763 ::FindDocLength() we "fix" the length as being ALL what remains
764 in the file (until EOF). We then proceed, hoping for the best...
765 This fixes a SegFault in ShowDicom when trying to write such an
767 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
768 (because TestWriteRead breaks on it, after a non conformal commit?).
769 ctest now runs properly, except for MakeDicomDir (which was allways
770 broken) and the Python related stuff (still not fixed).
772 2004-06-24 Jean-Pierre Roux
773 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
774 FIX : Test/TestReadWrite now iterates on all the file names
775 (instead of infinite loop)
776 ENH : Test/TestWriteRead now iterates on all the file names
778 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
779 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
781 2004-06-24 Jean-Pierre Roux
782 FIX : - now Write drops LUT Descriptors and LUTs (if any)
783 when SamplesPerPixel =3
784 - now Write is no longer confused by
785 'BitsAllocated = 12" and 'BitsStored=12"
786 - "UN" value representation Elements are now written correctly
787 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
788 ENH : - now gdcmHeader has its own Write methods
789 (in order to split the job that has not to be done
792 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
794 loop on the same image until memory went out.
795 Note: this means we still have gobs of memory loss in PrintDocument
796 * src/gdcmDocument.cxx: fixes problem on parsing on file
797 gdcmData/16BitsJpegLosslessGrayScale.dcm.
799 2004-06-24 Jean-Pierre Roux
800 FIX : Write - All the Sequences and Sequence Item are now written
801 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
802 is added a the end, when necessary.
803 - A lot of brain-damaged images, that were read correctly are
804 now written correctly
805 - length compatible BinEntry are now loaded correctly
806 (even for odd groups)
807 Note : only Explicit Value Representation was checked.
808 (question : is implicit VR really necessary for gdcm ?)
810 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * DEVELOPPER: added a proposition of coding style.
812 * src/gdcmDocEntry.h: removed every inline declaration (for test of
815 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
816 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
817 Use the gdcmDocEntry::Print() and Write() instead.
818 * src/gdcmDocument.cxx: bug fix.
820 2004-06-22 Jean-Pierre Roux
821 FIX : gdcmDocument.cxx
822 - Now we do recognize the JpegLossLess format (there was a misstyping in
823 code 'beautyfication' :-(
824 - Now we automaticaticaly load the Luts, if any
826 2004-06-22 Jean-Pierre Roux
827 In order : to write Sequences, whatever their imbrication level,
828 : to allow user to create his own Sequences
829 a lot of modif where necessary (adding, moving, or virtualising methods)
831 WARNING : save your own sources *before* cvs up !
834 ADD virtual void Write(FILE *fp, FileType filetype);
837 ADD virtual void Write(FILE *fp, FileType filetype);
838 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
841 ADD virtual void Write (FILE *fp, FileType filetype)=0;
842 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
843 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
844 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
845 ADD std::string GetEntryByName(TagName name);
846 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
848 std::string vr = "unkn",
849 std::string fourth = "unkn",
850 std::string name = "unkn");
851 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
852 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
853 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
854 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
855 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
856 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
857 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
858 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
861 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
862 ADD virtual std::string GetEntryByName (TagName tagName);
863 ADD virtual std::string GetEntryVRByName (TagName tagName);
864 REM virtual bool Write(FILE *, FileType);
865 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
866 FILE *_fp, FileType type);
867 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
868 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
869 REM virtual bool WriteEntries(FILE *_fp,FileType type);
870 REM virtual std::string GetEntryByName (std::string tagName);
871 REM virtual std::string GetEntryVRByName (std::string tagName);
872 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
873 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
874 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
876 std::string vr = "unkn",
877 std::string fourth = "unkn",
878 std::string name = "unkn");
879 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
880 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
881 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
882 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
885 ADD virtual void Write(FILE *fp, FileType filetype);
888 ADD virtual void Write(FILE *fp,FileType filetype);
891 ADD virtual void Write(FILE *fp, FileType filetype);
892 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
893 REM std::string GetEntryByNumber(guint16 group, guint16 element);
894 REM std::string GetEntryByName(TagName name);
897 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
899 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
901 The default constructor invoked by the line
902 gdcmHeader *f1 = new gdcmHeader( header );
903 was gdcmHeader::gdcmHeader(bool) instead of the expected
904 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
905 Hence the parsing wasn't executed... See also below.
906 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
907 as explicit constructor didn't do the trick to fix the above problem.
908 Could anyone explain why ?
909 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
910 properly calls gdcmValEntry::Print() (that was weed out from
911 code related to gdcmBinEntry).
913 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
914 * In order to fix memory leaks:
915 - Test/TestWriteSimple.cxx: added cleaning of free store through
917 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
918 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
919 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
920 (through the call to ::AddDicomDirMeta()) or the destructor
921 would crash when deleting uninitialized ::metaElems].
922 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
923 - src/gdcmDocument.cxx:
924 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
926 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
927 was causing memory leaks.
928 - src/gdcmSQItem.cxx:
929 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
930 cleanly handled with polymophism: sorry but my milage is low).
931 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
932 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
933 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
934 This avoids SegFaulting.
935 - src/gdcmSQItem.h: coding style.
937 - Test/TestWriteSimple still severely sucks. The output image content
938 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
939 damaged when displayed with vtkgdcmViewer.
940 - on memory leaks: TestWriteSimple leaks really less (see entry
941 of 2004-06-18 in Changelog file for the call to valgrind).
942 - on segfaults: ctest now passes all the tests but one (no more
944 * Erroneous leading white fix:
945 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
946 white[s] (as opposed to from >> xxx, that removes it [them].
947 - src/gdcmTS.cxx: ditto.
948 - gdcmPython/testSuite.py: dirty related kludge removed.
949 * src/*: remaining references to gdcmParser removed.
950 * src/*[cxx|h]: added copy[way]left header.
953 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * In order to fix writing of dicom files:
955 - Test/TestWriteSimple.cxx: a simpler example of writing.
956 - Test/CMakeLists.txt changed accordingly.
957 - src/gdcmDocument.cxx:
958 -- The destructor now recursilvely removes potential sequences.
959 -- Bug fix in ::IsJPEG2000()
960 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
961 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
963 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
964 to only declared) and build on top of
965 ::GetDocEntryByNumber(guint16, guint16).
966 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
967 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
968 for usage in destructor and treatement of promotion in
969 ::ReplaceOrCreateByNumber().
970 - src/gdcmSQItem.cxx: destructor should better handle his job.
971 Test/TestWriteSimple now runs (or at least it DOES something).
972 * We can now start hutting memory links. A good starting point is:
973 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
974 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
975 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
977 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
978 * Valgrind note: after Mathieu Malaterre teached me how to read
979 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
981 Using gcc, you can force the STL to use malloc and to free memory as
982 soon as possible by globally disabling memory caching.
983 With 3.2.2 and later, you should export the environment variable
984 GLIBCPP_FORCE_NEW before running your program.
985 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
986 simply vanish (it is still not clear to me, whether this means that
987 STL std::string leaks or if valgrind believes it leaks...).
988 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
989 running bin/gdcmTests makeDicomDir):
990 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
991 - Test/makeDicomDir.cxx now properly traps empty lists and returns
993 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
994 SegFaulting (I drowned in DicomDir related code when trying to
995 understand why the list is empty...).
996 * src/gdcmDocument.h: first BSD license header try.
997 * Doc/License.txt added.
999 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * src/gdcmDocument.[h|cxx]:
1001 - Clean up of the Transfer related predicates. They are now all based
1002 on new method isGivenTransferSyntax, that (should) handle properly
1003 the padding problem.
1004 - general clean up, simplification, and coding style.
1005 - Specific clean up of Parse7FE0() (umproperly named actually).
1006 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1008 2004-06-14 Jean-Pierre Roux
1010 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1011 - fix the display of SQItem ordinal number
1012 - add the GetSQItemByOrdinalNumber method
1013 - remove some useless never written private methods
1015 2004-06-14 Jean-Pierre Roux
1017 - adding a constructor taking a gdcmDocEntry as an input param
1018 - ReplaceOrCreateByNumber now returns :
1019 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1020 a gdcmValEntry * if a string value is passed as a param
1022 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1023 according to the param type (no longer sets a gdcmDocEntry)
1024 - GetValEntryByNumber, GetBinEntryByNumber added
1025 - NewValEntryByNumber and NewBinEntryByNumber added
1027 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1029 - GetSQItemNumber and SetSQItemNumber added, to provide
1030 a (relative) Item identier inside a given Sequence
1031 \warning : some pb remaining around this number
1033 - AddEntry now takes the Item Number as a param
1035 - adding a constructor taking a gdcmDocEntry as an input param
1037 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1038 * Memory leak hunt with the following command:
1039 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1040 --show-reachable=yes gdcmTests PrintDocument
1041 It looks like many (all?) leaks are due to the STL (or a bad usage
1042 of the STL. The lines producing the leaks now have a comment with
1043 a "MEMORY LEAK" tag: you can retrieve them with
1044 grep "MEMORY LEAK" src/*
1045 Here are two typical examples which I can't help fixing:
1050 char * test = "babo";
1051 name = test; //// <--- valgrind detects 960 bytes lost in
1052 //// call to std::string::operator=(char const*)
1053 name.clear(); //// Doesn't help !
1061 std::cout << "Type a bunch of characters followed by RETURN: ";
1062 getline(std::cin, line); //// <--- valgrind dectects a loss
1063 //// of 1320 bytes in call to
1064 /// std::basic_istream<>& std::getline<>
1070 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1071 * src/gdcmHeader.[cxx|h]:
1072 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1073 and related, moved away to gdcmDocument.
1074 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1075 the corresponding protected accessors of inherited class
1076 gdcmDocument, removed ! As a consequence gdcmFile had to be
1077 declared friend of class gdcmDocument (see below).
1078 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1079 - Clean up of undefined or unused methods.
1080 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1081 account the changes to gdcmHeader.h).
1082 * src/gdcmDocument.h:
1083 - gdcmFile is now a friend class (in order to take into account the
1084 changes to gdcmHeader.h).
1085 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1086 (see changes to gdcmHeader.h).
1087 - Accessors (reading on the form GetEntry*) are now public.
1088 - Clean up of undefined or unused methods.
1089 * src/gdcmDocument.cxx:
1090 - adaptation to changes to gdcmDocument.h
1091 - ::OpenFile now writes a verbose message when file cannot be opened.
1092 - some std::string properly set to VRKey
1093 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1094 references to gdcmDocument.
1095 * Test/TestFindTags.cxx: changed accordingly to above changes.
1096 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1097 cvs repository gdcmData.
1099 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1100 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1101 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1102 conflicts with gdcmValEntry::voidArea.
1103 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1104 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1105 Value representation between StringRepresentable and BinaryRepresentable.
1106 * src/gdcmDocument.cxx:
1107 - method ParseDES: proper indentation restored and usage of
1108 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1109 - method LoadDocEntry: the fingerprint left in the SetValue() of
1110 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1111 removed. Reverting to previous code segment with the proper
1112 dynamic_cast< gdcmValEntry* >.
1113 Note: this was (partially) breaking the python test suite
1114 (gdcmPython/testSuite.py) that made usage of the above
1115 fingerprint to check presence of "Pixel Data".
1116 * src/gdcmDocEntry.h: coding style.
1117 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1118 now taken into account.
1119 * gdcmPython/gdcm.i: adaptation to the new internal representation
1120 of gdcm (exit gdcmParser, hello gdcmDocument).
1121 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1123 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1124 anymore, but instead prints the loaded Python dictionary.
1125 * .... alas, the python testSuite is still broken.
1127 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1128 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1130 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1131 * src/gdcmUtil.h : export methods
1133 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1134 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1136 * Initial addition of automatic python testing
1137 * Initial addition of automatic image comparison
1139 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1140 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1141 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1143 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1144 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1145 * Test/ShowDicom.cxx : bug fix for msvc compilation
1146 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1148 2004-05-04 Jean-Pierre Roux
1149 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1150 new concepts (and new classes) :
1151 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1152 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1153 - Sequence Doc Entries (gdcmSeqEntries)
1154 a Sequence is composed of Items.
1155 Each item is a set of Doc Entries (this is recursive)
1156 The non uniqueness of the 'Dicom tag' is due to this recursivity
1157 (never taken into account)
1158 Our unability to add a new 'entry' in the header
1159 at the proper location (neither in the H-Table (map or multimap),
1160 nor in the Chained List is also due to this recursivity.
1161 Don't try, right now, to use/modify/compile these new sources :
1162 nothing is finished.
1163 We just commit all the stuff, 'as is', in order not to loose it.
1165 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1166 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1168 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1169 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1170 file prefix (SetFilePrefix)
1172 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1173 * Add a new test: ShowDicom, for now this is just the c++ version of
1174 checkRead.sh, later it will be able to compare the image read against a
1176 * Replace the DEBUG on the stack with a global entry in cmake interface:
1177 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1179 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1180 * Add an example subdir, with a real example on how to read + write a
1183 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1185 * Doc/CMakeLists.txt: the main page is now properly differentiated
1186 between the developper and user version.
1187 * Doc/doxygen.config.in: dropped search related obsolete flags
1188 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1190 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * DEVELOPPER: added some helpfull comments for compile/test/install
1194 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1195 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1196 src directory, now generated in the build dir.
1197 2. Tests as mentionned smarter
1199 4. Add a new method in gdcmDict that return the PubDict by name
1200 this is interesting for 3rd party lib like ITK,
1201 where we could set the institution name / patient name...
1203 * ENH: 1. Now the test suite is working for real
1204 2. All binaries are now output in the gdcm-bin directory
1205 (this was not true before)
1207 2004-04-28 Jean-Pierre Roux
1208 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1209 SeQuence indented printing of Dicom Header.
1210 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1211 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1212 Computation of SQDepthLevel is now part of gdcmHeader constructor
1213 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1214 tree-like structure of a Dicom Header.
1215 * FIX Test code cleaning
1217 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1218 * ENH: Adding automatic testing
1219 1. Need a DartConfig.cmake to submit to public
1220 2. Add a test driver gdcmTest.cxx
1221 3. gdcmTestMain, an helper for the main test driver gdcmTest
1222 4. Files in Test don't have a main anymore, this becomes interesting
1223 when we add more and more tests, thus dsw don't have to load
1225 * ENH: Adding a GDCM_DATA_ROOT for testing
1226 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1227 one file instead of seven + some small cleanup
1229 2004-04-22 Jean-Pierre Roux
1230 * ENH Minor changes to the Print() methods.
1231 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1232 Header printing. Example given with :
1233 > PrintHeader fileName 2 new
1234 (SQ based tree-like structure still to be done for the Header ...)
1236 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1237 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1238 1. I have added some unsigned where needed
1239 2. Some function parameter not used -> (void)
1240 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1241 4. g++ don't like character '\' in comment
1242 5. #define jpeg_create_decompress jCreaDecompress
1243 this really need to be fixed
1244 6. virtualize destructor of gdcmObject ... leakage
1245 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1246 this also really need to be fixed
1247 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1248 remove compression file
1249 (as we only do decompression, right ?)
1250 * ENH: Change malloc/calloc/free with c++ equivalent
1252 2004-04-21 Jean-Pierre Roux
1253 * FIX gdcmHeaderHelper::GetXSpacing
1254 when a single value is found (bug ?), xpacing is now
1255 defaulted to yspacing
1257 2004-04-19 Jean-Pierre Roux
1258 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1259 * ENH add parameters :
1260 bool exception_on_error = false,
1261 bool enable_sequences = false,
1262 bool ignore_shadow = false
1263 to the gdcmFile constructors to be full gdcmParser compliant
1264 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1265 to allow reading of PAPYRUS 3.0 files
1267 2004-04-06 Jean-Pierre Roux
1268 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1270 2004-04-02 Jean-Pierre Roux
1271 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1272 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1273 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1275 2004-03-30 Jean-Pierre Roux
1276 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1277 for ACR file, written out as DICOM files (hope so...)
1279 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1280 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1281 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1282 moved to base class gdcmParser and only the specialisation is kept
1284 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1285 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1286 already does the job.
1287 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1288 (to be consistent with gdcmParser::WriteEntries).
1290 2004-03-30 Benoit Regrain
1291 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1292 upate of the object's instance. It's passed to 2 in the unfavorable
1293 case : one in the ExecuteInformation, one in the ExecuteData
1295 2004-03-29 Jean-Pierre Roux
1296 * ENH : Check on file type to be written moved
1297 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1298 * FIX : gdcmObject::ResetBoundaries now stops properly
1299 when end-of-list is reached
1300 : gdcmVersion modified (as Benoit Regrain asked)
1302 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1304 * src/gdcmUtil.cxx: added forgotten iostream include.
1305 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1306 equivalent to ExplicitVR in existing code).
1308 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1309 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1310 now contains all the gdcmGlobal related code.
1311 * minor coding style and doxygenation changes.
1313 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1314 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1315 now contains all the Debug related code.
1316 * minor clean-up of includes in src/*.cxx
1317 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1318 CreateCleanString) removed.
1319 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1320 * Doc/DoxyMainPageUser.txt added.
1321 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1322 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1323 src/gdcmDirList.cxx)
1325 2004-03-24 Jean-Pierre Roux
1326 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1328 2004-03-23 Jean-Pierre Roux
1329 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1330 big endian made volumes
1331 * ENH Now gdcmParser constructor and destructor are protected to forbid
1332 end user to instanciate class gdcmParser
1333 (only gdcmHeader and gdcmDicomDir are meaningfull)
1335 2004-03-22 Benoit Regrain
1336 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1337 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1338 gdcmSerie to gdcmDicomDirSerie
1340 2004-03-19 Jean-Pierre Roux
1341 * ENH Now the tree-like structure describing a DICOMDIR comming from
1342 an already existing DICOMDIR file is consistent with
1343 the home-made tree-like structure build ex-nihilo
1344 or build from the files held (recursively) in a Directory
1345 functions gdcmDicomDir::CheckBoundaries()
1346 gdcmObject::SetBoundaries() added
1348 2004-03-17 Jean-Pierre Roux
1349 * REM (Eric Boix bug) : removal of meaningless
1350 gdcmDicomDirImage::NewImage function.
1351 * FIX now file names and directory name are written properly in the
1353 * FIX now gdcmDicomDir constructor may be call without any trick
1356 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1357 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1358 of gdcmDicomDirImage::NewImage as empty function.
1360 2004-02-28 Jean-Pierre Roux
1361 * ENH add gdcmDicomDir:NewPatient
1362 add gdcmDicomDirPatient:NewStudy
1363 add gdcmDicomDirStudy:NewSerie
1364 add gdcmDicomDirSerie:NewImage
1365 to allow making gdcDicomDir object.
1366 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1367 (as opposite to the gdcmHeader chained list)
1369 2004-02-11 Benoit Regrain
1370 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1371 when using from python
1373 2004-02-10 Benoit Regrain
1374 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1375 * FIX : in gdcmDicomDir when the directory is empty
1376 * ENH : add callback and methods to get the progression of dicomDir
1379 2004-02-06 Jean-Pierre Roux
1380 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1381 - GDCM_META added to gdcmDicomDirType
1382 - class gdcmMeta created
1383 * ENH : - A brief summary is now displayed at the beginning of
1384 'testDicomDir' to help disaster magnitude estimation
1385 * REM : Now useless Test/explDICOMDIR.cxx
1387 2004-02-05 Benoit Regrain
1388 * ENH : add methods in gdcmObject to get the hash table or the list of
1390 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1391 * FIX : wrapping python for TagHeaderEntryHT
1393 2004-02-04 Benoit Regrain
1394 * FIX : even length for some strings when writting the dicom dir
1395 * FIX : sort the images in the dicom dir
1396 * FIX : Bug fix for python use of dicom dir
1397 * ADD : a python demo
1399 2004-02-04 Jean-Pierre Roux
1400 * FIX : Final solution (?) for icone embedded images
1401 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1402 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1403 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1404 gdcmData/gdcm-MR-SIEMENS-16.acr1
1405 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1406 to make full checking easier
1408 2004-02-04 Benoit Regrain
1409 * FIX : WriteEntries : coding style & logic in parameters
1410 * FIX : Set the elements to create the DicomDir in a dictionary file
1412 2004-02-03 Benoit Regrain
1413 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1414 * gdcmDicomDir : add the load of directory
1415 * Bug fix and print add-on
1417 2004-02-03 Jean-Pierre Roux
1418 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1419 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1420 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1421 * FIX gdcmParser.cxx : 'group length' elements are now considered
1422 as integers, even for shadow groups, when file is Implicit VR
1424 2004-02-02 Jean-Pierre Roux
1425 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1427 of the last synonym :-(
1428 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1430 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1431 * FIX taking into account the possible 7fe0,0010 multiplicity
1432 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1433 to allow removal of references to 7fe0,0010, to deal with
1434 ACR-NEMA images, when 0028,0200 is meaningfull
1436 2004-01-31 Jean-Pierre Roux
1437 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1438 no longer writes 'Un' on disk
1439 * FIX SQ elements with actual length are now dealt with corectly
1440 * FIX gdcmFile::WriteBase make the difference, for color images, between
1441 the length (for Palette expanded images)
1442 and Raw Length (non expanded image + Palette)
1443 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1444 (that broke Write). Replaced by UL.
1445 Aware user will reload the field if he
1446 thinks it's necesssary
1448 2004-01-30 Jean-Pierre Roux
1449 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1450 when 'dirty Acr' is found, to be compliant with the new
1451 IsReadable() methods.
1453 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1454 (no DOUBLE images in kosher DICOM,
1455 but so usefull for people that miss them ;-)
1457 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1458 DICOMDIR related utilities (not checked as Windoze compliant)
1460 2004-01-28 Jean-Pierre Roux
1461 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1463 2004-01-27 Jean-Pierre Roux
1464 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1465 to allow skipping the shadow elements, to save memory space.
1466 The TRUE value for this param has to be used
1467 with a FALSE value for the 'enable_sequence' param.
1468 ('public elements' may be embedded in 'shadow Sequences')
1469 * gdcmHeader methods now deal with 'embedded icones images' in the header
1470 (even when an 'icone image sequence' is announced by the
1471 element (0x0088,0x0200), but there is NO icone at all ...
1473 * gdcmHeader sometimes Image Location value doesn't follow
1474 the supposed processor endianity (see gdcmData/cr172241.dcm).
1477 * gdcmHeader add the method
1478 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1479 to get *all* the Header Entries with the same tag.
1480 GetHeaderEntrySameName is probabely *useless*
1481 (no meaning : Name is *not* an identifier within the Dictionnary)
1483 2004-01-26 Benoit Regrain
1484 * Bug fix in the print of hexadecimal representations. Remove long fields
1485 in the print and add a third level of print to print them
1487 2004-01-23 Benoit Regrain
1488 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1489 * Bug fix on test suite after remove the strip made on not string fields
1490 * Split the IsReadable method between gdcmParser which test that the file
1491 is dicom and gdcmHeader which test that it's an image file
1493 2004-01-22 Benoit Regrain
1494 * DicomDir : clean code, add methods, set variables in protected or private
1495 * gdcmUtil : bug fix for the clean string method
1497 2004-01-19 Benoit Regrain
1498 * Add the use of shadow dictionaries
1499 * bug fix and coding style
1501 2004-01-19 Benoit Regrain
1502 * src/gdcmFile.cxx : bug fix concerning the close of file
1503 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1504 * Add the update of header entries using the shadow library
1506 2004-01-19 Benoit Regrain
1507 * removal of file gdcmHeader2.cxx
1508 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1509 inheriting from gdcmParser. This split is to prepare the integration
1510 of dicom dir parsing
1511 * bug fix under python
1513 2004-01-16 Jean-Pierre Roux
1514 * REM removal of class gdcmHeaderEntrySet
1515 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1516 * ADD add file gdcmHeader2.cxx
1517 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1519 2004-01-15 Benoit Regrain
1520 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1521 entries created while parsing the header. Thus, they will be destroyed
1522 when the gdcmDictSet will be destroyed
1523 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1526 2004-01-15 Benoit Regrain
1527 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1528 made a fatal error because of the memory release at the end of program.
1529 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1530 some memory and vtk seems to have some problems with that.
1531 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1533 2004-01-14 Benoit Regrain
1534 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1535 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1536 * src/*.[h|cxx] : make changes due to class name changes
1537 * gdcmPython/demo/*.py : bug fix due to method names
1539 2004-01-13 Benoit Regrain
1540 * src/*.[h|cxx] : coding style
1541 * vtk/*.[h|cxx] : coding style
1543 2004-01-13 Benoit Regrain
1544 * gdcmPython/testSuite.py : test the readable flag of file for tests
1545 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1546 It's lied to the stl compilation by MSVC (windows, always windows...)
1547 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1549 2004-01-12 Benoit Regrain
1550 * src/*.h : add comments
1551 * src/gdcmDictSet.h : set the method BuildDictPath in public
1552 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1553 directly setted in the source code
1554 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1557 2004-01-09 Benoit Regrain
1558 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1559 * setup.py : use a reference to gdcmVERSION
1561 2004-01-07 Benoit Regrain
1562 * Modification to compile with the distutils.
1565 2003-12-10 Benoit Regrain
1566 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1567 can use a gdcmHeaderHelper to load datas
1568 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1569 made in the source code
1571 2003-12-10 Benoit Regrain
1572 * Update Windows projects and .cvsignore files
1574 2003-11-12 Jean-Pierre Roux
1575 * ENH gdcmHeader constructor has one more parameter (default value : false)
1576 that allows the user to 'go inside' the SeQuences only
1578 gdcmElValSet:Print takes it into account
1580 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1581 * ENH: Update gdcmPython/CMakeLists
1582 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1583 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1585 2003-11-10 Jean-Pierre Roux
1586 * FIX : gdcmHeader::LoadElements is now based
1587 on the ListTag listElem member,
1588 not longer on the TagElValueHT tagHt member
1589 * ENH : PrintPubElVal shows (temporarily) both results,
1590 with the tagHt member and the listElem member.
1591 (it's easier to 'see' the problems when using Printheader)
1593 * FIX : old private member LgrElem is now splitted into
1594 ReadLength : Length actually found on disk (updated only
1595 if bug fixing is necessary), for internal
1597 UsableLength : Updated by FixFoundLength, to fix a bug
1598 or to allow Parser going on.
1599 Will allow to re-write a kosher header when a SeQuence
1600 with a length (not 0000) is found
1601 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1602 because gdcmElValSet::Add does not update ListElem
1605 2003-11-07 Jean-Pierre Roux
1606 * FIX misstyping in Transfert Syntax name table
1607 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1608 when they have an actual length (not 0000 nor FFFFF)
1609 (Nobody should care of it, but DICOMDIR explorers)
1611 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1614 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1615 * ENH: vtkGdcmReader now supports LUT !
1616 (vtkgdcmViewer for now is not able to use them though)
1618 2003-11-05 Jean-Pierre Roux
1619 * in testSuite.py : new files names for checking the package
1620 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1621 that returns the pixel area size to the *aware* (vtk) user
1622 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1624 2003-11-05 Benoit Regrain
1625 * in testSuite.py : Modify the rules for checking the paths
1626 : Explicit error messages
1627 * in __init__.py : Related modif
1629 2003-11-03 Jean-Pierre Roux
1630 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1631 to be used by aware (vtk) users that want to manage
1632 LUT (and no to turn the PALETTE image into an RGB pixels one)
1633 * GetPixelType now returns 8U for 24 Bits images
1634 (vtkGdcmReader compliant)
1636 2003-10-31 Jean-Pierre Roux
1637 * Removal of *all* gdcmData images and add them again
1638 in order to loose the 'history' of un-anonymised images
1640 2003-10-31 Jean-Pierre Roux
1641 * RMV : removal of useless jBitsInJsample.h
1642 for both 8 and 12 Bits JPEG Lossy Libraries
1644 2003-10-31 Jean-Pierre Roux
1645 * ENH : Add the functions gdcmFile::GetImageDataRaw
1646 gdcmFile::GetImageDataIntoVectorRaw
1647 that act as GetImageData and GetImageDataIntoVector
1648 except the making of an RGB Plane from Gray Plane + LUT
1649 Intended to aware (vtk) users who know how to manage
1652 GetLUTRGBA return a R,G,B,A LUT if any
1653 lgrTotaleRaw gives the 'Raw' length
1654 GetImageDataRaw returns the gray Plane
1655 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1656 (They stay Grey, just like with other Dicom viewers :-(
1658 2003-10-30 Jean-Pierre Roux
1659 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1661 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1662 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1663 being coherents dicom files.
1665 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1666 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1668 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1669 * ENH: Two steps is necessary to please VC++ compiler...
1670 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1671 * ENH: Add include dir to medcon lib
1672 * FIX: only one function is being exported for now !
1673 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1675 2003-10-29 Jean-Pierre Roux
1676 * adding gdcmHeader::GetLUTRGBA
1677 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1678 --> Mathieu, the modif u're waiting for is not yet committed
1679 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1681 2003-10-27 Jean-Pierre Roux
1682 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1683 00191113.dcm DermaColorLossLess.dcm
1684 MxTwinLossLess.dcm RadBWLossLess.dcm
1685 * ENH: For version prior to vtkImageViewer2 -r 1.19
1686 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1688 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1689 * Removal of ido stuff in CMakeLists.txt
1691 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1692 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1693 * FIX: remove a call to ->Modified ... see comments
1694 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1696 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1697 * FIX: Problem with path for libvtkgdcmPython
1698 * ENH: Try adding a search script for python site-package
1699 * RMV: Remove some file from medcon lib that are not necessary
1700 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1701 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1702 * FIX: More pragma disable fro VC++,
1703 I don't think I break something as it is also disable in VTK/ITK.
1704 But it fasten debug compilation time.
1706 2003-10-23 Jean-Pierre Roux
1707 * gdcm now deals with 16 Bits Run Length Encoded images
1708 (they are compressed as 2 planes images,
1709 one for the high Bytes, the other for low Bytes)
1711 2003-10-22 Jean-Pierre Roux
1712 * Now CheckRead takes into account :
1713 - the bugged 'Leonardo' Siemens images
1714 - the XA images, sent thru the burning VPRO station
1715 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1718 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1719 * FIX: When copying a Makefile.am to CMakeLists.txt
1720 one should remove the '\'
1722 2003-10-22 Jean-Pierre Roux
1723 * in gdcmData adding a bugged 'Leonardo' Siemens image
1724 (wrong lengths in header)
1725 OK with gdcm, KO with the other viewers :-)
1726 * add a GE dlx XA image, thru the VEPRO burning station
1729 2003-10-21 Jean-Pierre Roux
1730 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1731 for a brutal checking of vtkgdcmViewer compliance
1733 2003-10-21 Jean-Pierre Roux
1734 * add the files for 'xmedcon' Jpeg Lossless library
1735 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1737 2003-10-21 Jean-Pierre Roux
1738 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1740 2003-10-21 Jean-Pierre Roux
1741 * garbage Siemens 'Leonardo' images dealt with
1742 (the patch is easy to remove)
1743 * cosmetic changes to avoid warnings
1745 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1746 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1747 no need to press 'r' now.
1749 2003-10-20 Jean-Pierre Roux
1750 * upgrade of checkRead.sh checkWrite.sh according
1751 to new Jpeg Lossless decompressor
1752 * add US.3405.1.dcm, a genuine RGB medical file ...
1753 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1754 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1756 2003-10-15 Jean-Pierre Roux
1757 * general anonymisation in gdcmData
1758 * adding the 'color files' from
1759 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1760 * adding some well knowed bugged-header images
1761 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1762 waiting for their inclusion in Python testsuite
1764 2003-10-15 Jean-Pierre Roux
1765 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1766 no longer seg faults when file is not found
1768 2003-10-14 Jean-Pierre Roux
1769 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1772 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1773 * TODO: *.in file to genereate a UseGDCM later
1775 2003-10-14 Jean-Pierre Roux
1776 * Some supposed-to-be Dicom Images have no preamble.
1777 OpenFile takes it into account
1778 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1779 * Missing elements added in dicomV3.dic
1780 (just to be affraid : have a look at
1781 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1782 and do it again next year ;->
1784 2003-10-13 Jean-Pierre Roux
1785 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1786 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1787 But there are NOT. It's fixed !
1789 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1790 * FIX: "jpeglib.h" was not found on VC++
1791 * FIX: vtkgdcm was not being installed
1793 2003-10-10 Jean-Pierre Roux
1794 * ENH : OpenFile closes the file if it *really* doesn't look like
1795 an ACR-NEMA / DICOM one.
1796 * FIX : testWrite no longer writes an empty file if the source file
1797 is not gdcm Readable
1798 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1801 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * FIX: CMake generate now documentation
1803 * ENH: out of source doc build !
1804 * ENH: Generate both user and dev documentation
1805 * ENH: Should work on windows too
1806 * ENH: Only one doxygen config.in file is needed
1807 * FIX: make install should be ok now on ùnix plateform
1808 * FIX: PATH to dictionary was wrong (missing /)
1809 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1811 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1812 * vtkGdcmReader is now able to read rgb dicom file.
1813 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1814 * added a gdcmViewer to vtk test, use mouse to control
1815 window level & window width
1817 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1818 * CMake-ification of gdcm, we have now two build system
1819 * FIX: on cygwin Wsock32 doesn't exist
1820 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1822 2003-10-06 Emanuel Ollart
1823 * FIX : compilation process wad broken.
1824 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1826 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * change gdcmViewer -> vtkgdcmViewer
1828 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1830 2003-10-06 Jean-Pierre Roux
1831 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1832 ( e.g : well known GE images with a wrong elem length,
1833 : Philips MRI Images with a wrong Huffman table)
1834 * still to be done : allow the reading of bugged LEONARDO Siemens images
1836 2003-10-03 Jean-Pierre Roux
1837 * Odd length strings are padded with '\0' (not with spaces,
1838 to remain compliant with already defined strings,
1839 like Transfert Syntax UID and others)
1841 2003-10-03 Jean-Pierre Roux
1842 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1843 to allow displaying RGB images (not only by affim ;-)
1845 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * vtkGdcmReader is now able to read rgb dicom file.
1847 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1849 2003-10-03 Jean-Pierre Roux
1850 * A few nasty patches to allow the reading of a lot of nasty images
1851 ( e.g : well known GE images with a wrong elem length,
1852 : Philips MRI Images with a wrong Huffman table)
1853 * still to be done : allow the reading of bugged LEONARDO Siemens images
1855 2003-10-03 Jean-Pierre Roux
1856 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1858 2003-10-03 Jean-Pierre Roux
1859 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1860 to allow displaying RGB images (not only by affim ;-)
1862 2003-10-03 Jean-Pierre Roux
1863 * gdcmFile::GetImageDataIntoVector now
1864 - deals with MultiFrames MultiFragments Run Length Encoded files
1865 - deals with YcBcR (YBR_FULL) files
1866 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1867 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1869 (no sample found :-(
1871 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1872 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1873 Two reasons: - clear things
1874 - third parties acces gdcm through header files, so won't
1875 suffer anymore VC++ complains
1877 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1878 * add argv[1] in testvtkGdcmReader.cxx
1881 2003-09-24 Jean-Pierre Roux
1882 * The lines are now eigthy characters long.for
1883 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1885 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1886 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1887 char* to std::string. Thus, the use of strdup becomes useless. (see
1888 previous commis of Malaterre)
1889 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1890 before the last Malaterre's commit.
1892 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1893 * This commit should fix the Debug building under VC++, the problem
1894 was mainly a mixture of debug and release lib being loaded at startup.
1895 * I also remove a depency to a specific C function: strdup. Because I had
1896 to force the link to msvcrtd (whereas strdup is in libc).
1898 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1899 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1900 located in the gdcmCommon.h file. All use of reference of tha has been
1901 changed to now use the variable GDCM_UNFOUND.
1903 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1905 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1906 Dicom dictionary. The test suite can now be run again. Note:
1907 I'm note very happy with the " (RET)" changes. I believe this
1908 RETAINED comment should be dropped when parsing the dictionary.
1909 - PACKAGER corrected
1911 - AUTHORS updated and now in alphabetical order
1912 * Makefile.am now exports gdcm.dsw for Windoze users.
1914 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1915 * cygwin complains about missing std:: in subdir Test/
1917 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1918 * remove some methods that are now in gdcmHeaderHelper
1920 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1921 * vtkGdcmReader set spacing and origin correctly
1923 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1924 * Fix a few delete/delete[] mismatch
1926 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1927 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1928 interpretation to data given by gdcmHeader. For instance there are
1929 heuristics to get informations (look at different places).
1930 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1931 sorting DICOM images based on different strategies.
1932 * modified Makefiles accordingly.
1934 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1935 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1936 when building in debug mode
1937 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1938 src/win32/gdcmdll.dsp
1939 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1941 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1942 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1945 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1946 * src/win32/libgdcmjpeg12.dsp was not dos format
1947 * src/win32/libgdcmjpeg12.dsp :
1948 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1949 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1951 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1952 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1954 * src/gdcmFile.cxx : bug fix in affectation type
1955 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1956 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1957 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1958 symbols... future problem ?
1960 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1961 * src/win32/libgdcmijpeg12.dsp was missing
1962 * modified gdcm.dsw accordingly
1964 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1965 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1967 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1968 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1969 commit of JPR (before his hollidays to facilitate our work).
1970 * setup.py : bug fix in code. Modifications made while the last commit
1971 of JPR. The code hasn't been tested before the commit... it's so
1972 useless to make that (for best programmer that is JPR) !!!
1974 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1975 * tagged the current version as Version0_3 (i.e. version 0.3)
1977 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1978 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1979 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1980 * *.dsp : modifications to use new libgdcmijpeg8 library
1981 * setup.py : bug fix on VTKPATH variable
1982 * PACKAGER : adding all concerning windows
1984 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1985 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1987 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1988 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1989 test suite reported error.
1990 * PACKAGER file added (describes what a packager must do when
1991 packaging a new release).
1992 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1993 * configure.in: upgraded version number to 0.3.0
1994 * fixing build of rpm (through rpm -ta):
1995 - Doc/Makefile.am exports proper doxygen files
1996 - src/jpeg/libijg8/Makefile.am exports the include files.
1998 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1999 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2000 * src/gdcmHeader.h : formatting code
2002 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2003 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2004 We were obtaining error message from vtk. Now, creation of file list
2005 is made in an internal list to prevent this problem.
2006 Bug fix when output is empty.
2007 Bug fix in update of progress value. Previous commit for this was a bad
2009 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2011 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2012 * src/gdcmHeader.h : added method to get the file name
2013 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2014 files. Added method to remove all files on the input
2015 Added FIXME comment concerning the bad parsing of header made by
2016 ExecuteInformation method (in ExecuteData method)
2018 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2019 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2020 when using make instal.
2021 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2022 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2024 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2025 * setup.py : adding include dir of jpeg lib to compile all sources
2026 * */Win32/*.dsp : JPR fix for windows compilation
2028 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2029 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2031 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2032 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2034 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * setup.py is again effective on un*x (takes into account the
2036 addon of the jpeg library)
2037 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2038 * Doc/Doxy* updated (includes above enhancements)
2039 * INSTALL now points to web documentation
2041 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * src/gdcmHeader.h doesn't make unnecessary reference to
2044 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2046 * src/gdcm*.[cxx|h] :
2047 - to allow compilation with gcc 3.x
2048 -- clean up of STL usage (added explicit usage of std::)
2049 -- small fixes on exceptions.
2050 Note: linking not tested !
2051 - clean of doxygen comments to avoid warnings at documentation
2053 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2054 dependent convertion).
2056 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2057 * Clean up of previous JPR garbage commit (not even commented in the
2059 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2060 - moved all jpeg related files from src to src/jpeg/libijg8, with
2061 addition/modification of Makefile.am and configure.in.
2062 - the testSuite is still brain damage (not guilty).
2064 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2065 * WrapVTK.py : modifications to get correctly vtk source files to
2067 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2068 (FileName -> Filename)
2070 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2071 * vtk/vtkGdcmReader.[cxx/h]:
2072 - UpdateProgress method should now be effective
2073 - removed the limitation on having only images loaded (as opposed
2075 - when building a stack of images/volume, a lesser number of
2076 gdcmHeader and gdcmFile instances should be used (hopefully
2077 accelerating things).
2078 - when building a stack of images/volumes, files which are not
2079 loadable (wrong path-filename, wrong permissions on existing file,
2080 or file not parsable by gdcm) are replaced with a black image
2081 in the stack (for the caller to notice the problem).
2083 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2084 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2086 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2087 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2088 between standard library (std) and vtk library (problems are found
2089 under Windows... thanks Windows !)
2091 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2092 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2094 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2096 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2097 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2099 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2100 * When compiling with distutils (see setup.py) the C++ compiler is
2101 called with different flags than the default ones (with automake).
2102 In order to fix all those warning, I compiled gdcm with the command
2103 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2104 and went for warning fixes:
2105 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2106 up from unused variables.
2107 - vtk/vtkGdcmReader.cxx: potential bug fix.
2108 * src/gdcmHeader.h: Doxygen warning cleanup
2110 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * gdcmPython/gdcm.i:
2112 - typemaps correction to take into account the systematic replacement
2113 of "using namespace std" with std:: prefix e.g. std::list,
2114 std::string... (cf changes of 2003-05-21).
2115 - gdcmGlob global variable of type gdcmGlobal (defined in
2116 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2117 exported to Python a as cvar.
2118 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2119 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2120 gdcmDictSet.GetPubDictTagNames() and
2121 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2122 C++ static methods).
2123 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2124 with the above changes.
2126 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2127 * setup.py, manifest.in : bug fix under linux
2129 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2130 * Modification of setup.py to compile vtk part too. Then, we have 2
2131 wrappers which must work with same distutils. For that, we have a
2132 generic distutils in distusiltsWrapping.py ; with :
2133 - build_extWrap class to wrap generically all extensions,
2134 - ExtensionWrap base class for all wrapping extension that contains
2136 - Wrapper interface which wrap sources
2137 + In WrapSwig.py we have extension and wrapper for Swig
2138 + In WrapVTK.py we have extension and wrapper for VTK
2139 * MANIFEST.in : modifications to consider vtk directory and new python
2140 files for compilation
2142 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2143 * Added python wrappers of vtkGdcmReader vtk class (see the
2144 source in vtk/vtkGdcmReader.cxx) :
2145 - vtk/Makefile.am now builds a library
2146 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2147 python library (as opposed to _gdcm.so wich are the python
2148 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2149 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2151 - configure.in has an additional flag --enable-vtk that needs
2152 to be set to enable compilation of vtk related code, that is:
2153 + vtk/vtkGdcmReader.so and
2154 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2155 + gdcmPython/vtkgdcmPython.so (see above)
2156 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2157 be read when compressed or when HighBit + 1 != BitsStored),
2158 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2159 the usage of the python wrapper of vtkGdcmReader vtk class.
2160 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2161 * src/*.[h] all occurences of stl classes are now prefixed with
2162 std::, and all occurences of "using namespace std;" where removed.
2163 This is to avoid pollution of global namespace in included files.
2164 Apparently vtk does not avoid this pitfall: when using both
2165 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2166 collision of various stl members (principally cout...).
2167 * gdcmPython/testSuite.py now cleanly removes temprory generated
2169 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2170 comply with above changes)
2172 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2173 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2174 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2175 vtk data structure (an image Flip was required).
2176 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2177 * cosmetic changes in documentation.
2179 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2180 * src/gdcmHeader.cxx: the constructor no longer exits when an
2181 unexisting file is given as argument.
2182 * The subdirectory Data (containing all the images used for the
2183 test suite) is not part of this repository anymore. A new module
2184 containing those images is now available at
2185 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2186 with the name gdcmData.
2187 All the python scripts (including the package initialisation file
2188 gdcmPython/__init__.py) were adapated to take this change into
2189 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2191 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2192 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2193 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2194 demo of the usage of this class.
2195 Compilation of this vtk part is only done when using the --enable-vtk
2196 at configure (or autogen.sh) stage.
2198 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2199 * More memory link related corrections and documentation fixes.
2201 - maximum info is obtained with a command of the form:
2202 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2203 --show-reachable=yes PrintHeader
2204 - the remaining reachable blocks seem to come from the STL
2205 allocation scheme through the usage of map and list. It looks
2206 like this memory cannot be freed but it is not a memory leak
2207 (in fact further invocation to the STL would recollect the
2208 unused memory allthough it cannot explicitely be freed).
2209 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2210 of displaying an image parsed with gdcm and displayed with VTK.
2211 Note: some images don't seem to work e.g.
2212 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2213 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2214 Allthough this weakens the semantics, it is a ditch attempt to
2215 make gdcm more thread friendly.
2217 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2218 * Memory link hunt (by using valgrind through the command
2219 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2220 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2221 gdcmHeader::_dicom_vr.
2222 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2223 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2225 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2227 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2228 * src/Makefile.am now exports all the necessary include files at
2232 * UpdateGroupLength replaced by new one
2235 * UpdateGroupLength re-written using H-Table
2236 (named UpdateGroupLengthNew untill checks are over)
2238 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2239 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2240 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2242 - gdcmHeader::GetPubElValSet removed.
2243 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2244 UpdateGroupLength, WriteElements, Write.
2245 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2246 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2247 carried the same semantics.
2248 - src/gdcmHeaderIdo.cxx changed accordingly.
2249 - gdcmFile::WriteBase now regroups all the codes from previous
2250 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2251 - enum FileType moved to gdcmCommon.h
2252 * src/gdcmHeader.cxx AddDefault trashed
2253 * gdcmGetXSize added
2254 * getimageDataSize now calls gdcmGetXSize
2255 * Test/*.cxx changed to agree with above changes
2257 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2258 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2259 (to avoid double call by end user).
2260 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2261 by end user, since gdcmHeader::gdcmHeader now handles it.
2263 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2264 * gdcm/Doc many doxygen changes:
2265 - Doxyfile now has two different versions, DoxyfileUsers that generates
2266 the html.users end users oriented documentation and
2267 DoxyfileDeveloppers that generates the html.developper developper
2268 oriented documentation.
2269 - README changed accordingly
2270 - requirement.txt removed (old design info moved to TODO).
2271 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2272 DoxyMainPage.txt, DoxyPython.txt provide more information.
2273 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2274 be updated by simply regenerating the docs with doxygen and copying
2275 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2276 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2277 all the tests in the form "if (<map>.count() >1)" were removed.
2278 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2279 ill-formed documentation sections.
2280 * src/gdcmHeader.cxx: ditto
2282 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2283 * setup.py fixed for un*x (needed macro for stdint.h)
2284 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2285 un*ces with sh-utils test utility.
2286 * gdcmPython/demo/test.py renamed to PrintHeader.py
2287 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2288 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2289 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2290 * src/gdcm*.cxx JPR's bad inclusion fixed.
2292 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2293 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2294 * gdcmPython/demo/test.py changed accordingly.
2296 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2297 * gdcmPython/Makefile.am fixed linking against libstdc++
2298 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2299 * Swig subdir (historical tests of swig version 1.3.17++) removed
2300 * Test/testChangeEntete.cxx some lines commented out in order to make
2302 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2303 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2305 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2306 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2307 hence the user doesn't need this explicit call.
2308 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2309 i.e. LoadElements() call removed.
2310 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2311 - src/Makefile.am declares the proper flag for g++.
2312 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2313 for adding user defined new tags.
2314 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2315 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2316 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2318 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2319 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2320 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2321 src/Makefile.am : the project should properly compile and install
2322 with the autotools, included the python wrappers part.
2323 * gdcm.spec.in : added a spec file for RPM packaging.
2325 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2326 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2328 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2330 to exported to the environement (see gdcmPython/testSuite.py
2332 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2333 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2334 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2335 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2336 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2338 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2339 * gdcmPython/__init__.py doesn't crash anymore when running in
2340 in InstallMode or PreInstallMode but with an environement given
2341 value of GDCM_DICT_PATH.
2342 * src/gdcmDictSet.[cxx/h] coding style.
2344 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2345 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2346 * src/gdcm.h general comments moved to TODO, and README
2347 * src/gdcm.h should now be seen as a user commodity (including it
2348 should suffice to fully use gdcm). It is nowhere including within
2349 any of the kernel files src/*.cxx and src/*.h.
2351 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2353 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2355 * src/gdcm*.cxx only include their corresponding include file
2356 (as opposed to gdcm.h)
2357 * gdcmPython/gdcm.i changed accordingly
2358 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2359 the autogen.sh generated "make snapshot" command to work.
2360 * autogen.sh removed history related references to crea package.
2362 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2363 * distutilsSwigCPlusPlus.py work around some swig portability
2366 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2367 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2368 was done in a last ditch attempt to get setup.py _really_
2369 operationnal. The python/gdcmPython layaout add the advantage
2370 of hidding away the python related distutils specific files
2371 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2372 Alas, the src directory was out of scope (i.e. it's relative
2373 position to setup.py was ../src) which made things impossible to
2374 handle (see previous version of python/setup.py). Crossing fingers...
2376 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * python/setup.py now works on Un*x. (harder than I thougth)
2378 * python/distutilsSwigCPlusPlus.py can now have include files
2379 among the list of sources.
2381 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2382 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2383 * modifications in MSVC projects
2385 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * As stated by the first lines of Test/ExceptionAndPython/README, it
2387 looks like we can move back to original usage of exception within
2388 src/gdcm* and hence remove the errno stuff that was introduced
2389 as a quick and dirty fixture of this problem (added to the TODO).
2390 * Doc/Doxyfile configuration file for Doxygen and corresponding
2391 README file for usage added.
2392 * Test/testWrite.cxx added. This new test comes from a split of
2393 test.cxx that is now reverted to its original purpous i.e.
2394 testing the proper parsing of a Dicom related file.
2395 testWrite.cxx concentrates on testing the IO part of gdcm.
2396 * Test/bug1.cxx (containing a bug on WIn32) added.
2397 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2398 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2399 whose purpose is to publish the content of the TagNames of the
2400 Dicom public dictionnary were not accessible without an
2401 instance of class gdcmHeader.
2402 - those methods are now static methods of gdcmDictSet and hence
2403 require no instances at all to be invocated.
2404 - within gdcmDictSet this change required to change some method
2405 to class methods (i.e. are now static) among which SetDictPath
2406 (renamed to BuildDictPath) and LoadDefaultPubDict.
2407 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2408 the above changes by calling the new method classes of gdcmDictSet.
2409 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2410 the above to be effective.
2411 * python/gdcmPython: in order to wrap properly the above changes
2412 for Python, swig version now needs to be > 1.3.17.
2413 * python/gdcmPython/Makefile fixed to adapt itself to new
2414 configure/make shema introduced by Johan Montagnat (thanks for the
2415 contribution). Alas this Makefile cannot be turned into a proper
2416 Makefile.am without some heavy changes in the configure.in
2417 (for python dectection).
2418 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2419 now avoids publishing the empty entries.
2421 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2422 * python/setup.py : bug fix concerning install under windows
2423 ExtraPath reused :-P
2424 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2426 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2427 * Dicts/dicomV3.dic : remove double spaces !!!
2428 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2429 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2432 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2434 method. Doxygenation.
2435 * src/gdcm.h clean up of JPR spurious comments.
2437 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2438 * python/distutilsSwigCPlusPlus.py now properly collects the
2439 shadow classes generated by "swig -c++" (gdcm.py in our case)
2440 when using "python setup.py install".
2441 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2442 reexports the working classes.
2443 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2444 by the classical C errno scheme. This is to prevent an obscure
2445 behavior of the python wrappers when importing wxPython.wx prior
2446 to gdcmPython (which ended up in an abort call). An illustration
2447 of this oddity can be found in the Test/ExceptionAndPython
2448 subdir (see the README file). This problem probably due to
2449 an combination of g++ and dynamic loading.
2450 * added Test/ExceptionAndPython (see above)
2452 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * Changed the layout of the python part to avoid bloating main
2454 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2455 i.e. the distutils arsenal. All the python related stuff is
2456 again in a python subdir, but the package itself is now in
2458 * setup.py was cleaned up:
2459 - pythonIncludePath removed
2460 - python setup.py bdist target is now functional.
2461 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2462 collision with other packages). gdcmPython/demo/*.py changed
2465 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * python subdir moved to gdcmPython (preparation of distutils packaging).
2467 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2468 distutils installer is operational.
2469 * - gdcmPython/__init__.py now properly loads the swig generated
2470 shadow classes (from gdcm.py).
2471 - gdcmPython/demo/*.py changed to import the package gdcmPython
2472 instead of gdcmPython/demo/load.py.
2473 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2475 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2477 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2478 entries within the associated public Dicom dictionary resp. the same
2479 information but sorted by the fourth field (PAT, IMG, DIR) of the
2481 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2482 are now in the "???" group.
2483 - python/gdcm.i changed accordingly,
2484 - python/demo/printGroupedPublicDict.py added, that gives an example
2485 of the above new functionalities in Python.
2487 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2488 * src/gdcm.h, gdcmHeader.cxx:
2489 - historic references to glib's g_malloc and g_free (#defined)
2490 were definitively removed.
2491 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2492 * src/gdcmElValSet.cxx:
2493 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2494 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2495 - GetElValue(string) renamed to GetElValueByName.
2496 - Added GetElementByName(string).
2497 * src/gdcmHeader.cxx: added
2498 - GetPubElValRepByNumber(guint16, guint16)
2499 - GetPubElValRepByName(string)
2500 - GetShaElValRepByNumber(guint16, guint16)
2501 - GetShaElValRepByName(string)
2502 - GetShaElValByNumber(guint16, guint16)
2503 - GetShaElValRepByName(string)
2504 - GetElValRepByNumber(guint16, guint16)
2505 - GetElValRepByName(string)
2506 - GetElValByNumber(guint16, guint16)
2507 - GetElValRepByName(string)
2508 * Doc/requirements.txt added.
2510 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2511 * Test/Makefile building now depends on the one of libgdcm.so
2512 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2513 pixel data) aware which enables finding the address (offset) of
2514 the pixel data of JPEG encoded DICOM files. This leaves only a single
2515 file in the testSuite whose pixel data address (offset) is unknown.
2516 * python/testSuite.py changed accordingly.
2518 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2519 * VC++ has some strong limitations when working with the STL, as stated
2520 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2521 "Also note that some STL containers (map, set, queue, list, deque)
2522 cannot be exported. [...]
2523 Some STL classes contain nested classes. These classes can not
2525 This is caused by a designed limitation that once a template
2526 class is instantiated, it can not be re-instantiated and
2528 Since our usage of map<> is ubiquitous in gdcm, this "designed
2529 limitation" of VC++ is a pitfall.
2530 Hence the Python wrappers of gdcm cannot be incrementally linked
2531 against the c++ dynamic library. The dirty but only workaround is
2532 to forget about incremental link of dynamic libraries and to generate
2533 the Python wrappers library with the inclusions of the underlying C++
2535 The following modifications concern this matter on Win32/VC++:
2536 - wrapping python correct with standalone wrapped dll (don't use separate
2537 dll under windows !!!!)
2538 - python21_d debug mode enabled (ask Frog how to use it :-)
2539 - NO problem with having an STL member of class for example string in C++
2540 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2541 - Python test of dcmlib in Python is ok under windows on a large set
2543 * removed glib references
2544 * typedef's inserted in gdcm.i for correct swig type management
2546 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * python/demo/*.py load.py extracted from test.py. Added explore.py
2548 that only displays required tags and testAll.py that parses all
2549 the files of the testsuite without using unittest.
2550 * python/testSuite.py other additional test on new files added.
2551 * Data/* new test files added accordingly to the testSuite.
2552 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2553 the vr in the file differs from the one of the dictionary.
2555 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2556 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2557 values, but limits itself to values which are below a user specified
2558 size (by default 1024 bytes).
2559 * python/gdcm.i : elements not loaded (because their size is above the
2560 user specified treshold) are exported with their TagKey as key of the
2561 python dictionary. This enables the testsuite to make some checks
2562 on the unloaded elements (since we have their offset and size).
2563 * python/testSuite.py
2564 - now tests for the existence and proper value of the pixel data
2565 - two new examples added.
2566 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2568 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2569 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2570 aware. See the strategy comments in gdcmHeader::FindeLength().
2571 * Test/test.cxx now accepts a filename as first argument.
2572 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2573 * python/testSuite.py changed to integrate test on above files.
2575 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2576 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2577 the vr was also RET.
2578 * python/testSuite.py more tests added.
2580 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2581 * python/testSuite.py unittest test suite added (uses Data)
2582 * Data/* dcm and acr files for the test suite.
2583 * glib dependance removed from un*x version. We now use ISO C99
2584 7.18 Integer types (see stdint.h)
2585 - python/Makefile, src/Makefile src/gdcm.h
2586 * src/ when an explicit vr (like dicom files) suddenly poped an
2587 implicit element we use to mark the underlying DictEntry of the
2588 concerned ElValue with "Implicit". This strategy was damageable
2589 too the public or provite dictionaries, since some of their vr
2590 would be changed. Since Header::FindLength heavily relies on the
2591 detection by Header::FindVR of falsely explicit elements, I
2592 added an extra ImplicitVr member to ElValue (boolean).
2593 The rest of the changes we the necessary adaptations.
2595 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2598 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2600 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2601 * Adaptation for porting to VC++:
2603 o forced to use std namespace (for string to be known)
2604 o all class use __declspec export style on WIN32
2605 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2606 (in stdlib.h on Win32 but in std:: for gcc)
2607 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2608 variable GDCM_DICT_PATH.
2609 * src/gdcmHeader.cxx verbose comments made discrete.
2611 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2612 * python/gdcm.i: added a typemap that converts a C++ hashing table
2613 to native Python dictionary.
2614 * python/demo/test.py:
2615 - now uses the native dictionary for exploration of gdcmHeader.
2616 - takes an optional filename argument (the file to parse).
2617 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2618 PubElVals hashing table.
2619 * Dicts/dicomV3.dic removed error prone trailing spaces.
2621 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2622 * Python wrapping process moved away from src/Makefile to
2623 newly created python/Makefile (as well as gdcm.i)
2624 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2625 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2626 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2627 from the environement variable GDCM_DICT_PATH (when existing).
2628 * src/gdcmDict::GetTag bug fix.
2630 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2631 * Straightforward temporary fixes for swig to build the python wrappers.
2632 src/Makefile now has a python working entry [by working we mean
2633 that we can import de shadow classes without errors].
2635 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2636 * hashtest.cxx removed (since allready in Test)
2637 * src/gdcmlib.h renamed to src/gdcm.h
2638 * src/dcm.i renamed to src/gdcm.i
2639 * src/Makefile prepared for python wrapping
2641 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * src/gdcmHeader.cxx :
2643 - Parsing of header is now separated from loading of element values
2644 (see gdcmHeader::LoadElements).
2645 - general clean up of hopefully all file access (creation of
2646 ReadInt16 and ReadInt32)
2648 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2649 * src/gdcmHeader.cxx :
2650 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2652 - SetLgrElem renamed to SetLength
2653 - GetLgrElem renamed to GetLength
2654 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2655 * src/gdcmElValSet.cxx fixed both GetElValue methods
2656 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2657 due to IdoDude was cleaned out.
2659 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2661 concentrates on finding the value representation (when it exists).
2662 RecupLgr now only finds the element value length, and it avoids
2663 returning the unecessary skL (skipped length).
2664 Also, offsetCourant was simply removed (with taille_fich) since
2665 it was redundant with the File position internals (by using
2666 ftell and fseek). This also made skL (see above in RecupLgr) usage
2668 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2669 on the libido specificities which are handled through class
2671 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2674 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * Truckload of changes. Parsing of header is barely functional
2676 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2678 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2679 * src/gdcmHeader.cxx many addons of low level methods
2681 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2683 and _IdDcmSWAP_LONG.
2685 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * This corresponds to all the changes decided at the meeting of
2687 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob