1 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the datas
3 to read in the file... and only it ! Length is the efective length of the
4 datas in the DocEntry structure
6 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
7 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
8 And now use a static function call instead, with a global variable. i
9 This is much closer to the VTK approach. Hopefully should be bulletproof
10 and easier to use...hopefully
12 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
15 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
18 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
20 ValEntry, BinEntry, SeqEntry creation or replace
22 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
24 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
26 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
27 when specifying the VR
28 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
29 * src/gdcmDocEntry.cxx : amelioration of print
31 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr
32 * ADD : Add the method Util::IsCurrentProcessorBigEndian
33 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
34 * ADD Method Document::ComputeGroupLength
35 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
36 in order to allow further VR modification by user
37 * REM : removal of once-called method File::WriteBase
38 integration of its code in formerly one-line method File::Write
40 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
42 replace the different values "??", "Unkn", "Unknown".
43 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
44 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
45 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
46 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
48 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
51 * Set the gdcm::Base class to some Printable classes
53 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmFile.[h|cxx] : add the Print method
55 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
56 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
57 * src/gdcmDocument.h : remove the PrintLevel informations
58 * Example/PrintFile.cxx : use the new gdcm::File::Print
60 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
62 problems when compiling with the python wrapping
64 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
66 writting in ImplicitVR
68 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
69 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
70 JPEG decompression, especially when dicom frames are split into several
71 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
72 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
74 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * src/gdcmHeader.cxx : change the initialisation of default header.
76 Now, this header is readable by gdm, e-film, DicomWorks
78 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
80 Rename Decompressed to Raw
81 * Use the API changes in gdcm::File.
82 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
85 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
87 each added entry in the header. Replace the 'Planes' field by the 'Number
90 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
92 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
94 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
96 At this time, this image isn't readable by e-film... waiting JPR help to
99 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
101 DocEntry. Now use methods of the Document !
103 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * Test/ShowDicomSeq.cxx : bug fix
106 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
108 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
109 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
110 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
112 * Test/TestCopyRescaleDicom.cxx : remove unused variable
113 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
114 containing found sequences
116 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
119 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
120 Some fields in BinEntry must be copied to not seg fault when making the :
121 gdcm::File *copy = new gdcm::File( copyH );
122 and tests are now made on good variables
124 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
126 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
128 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
129 * Add vtkGdcmWriter example and test
131 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * Test/TestUtil.cxx : reformat the source code
133 * vtk/vtkGdcmReader.cxx : remove and change prints
134 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
136 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
137 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
139 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
141 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
143 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
145 by an eof to prevent all bad read of the file... and in this case, the
148 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * Example/Volume2Dicom.cxx : comment unused variables
150 * Test/PrintDicomDir.cxx : comment unused variables
151 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
152 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
153 method that is redondant with AddEntry.
154 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
157 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * Bug fix due my last commit (compilation under Windows).
159 * Example/Volume2Dicom : bug fix in the file and reformatting source code
160 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
162 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
164 - Remove printf / sprintf
165 - include iostream AFTER gdcm so we don't get warnings
166 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
168 - Also remove tons of include from header files, hopefully this should
169 speeup the compilation time, since it was becoming a dog slow.
170 - Remove gdcm.h as it include way too many files and slow down compilation
171 (plus it is not up to date)
172 - remove 'using namespace std' this is BAD !
174 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * Remove memory leaks on the DicomDir
176 * Remove some useless datas in DicomDirObject
177 * Add usefull methods in SQItem, to be complient withe the ElementSet
179 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
182 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
183 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
184 future, with convertion)
185 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
186 and ImageDataSize values. Remove the method to get the PixelReadConverter
187 from the output of the class
189 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
192 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
194 and vtkErrorMacro use.
195 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
197 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
200 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
201 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
202 The string leaves only in the fonction. So when we make a .c_str(), we
203 get the pointeur on the first element, element that will be destroyed
204 immediately after thee instruction.
205 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
206 file has been opened : the test must be made on the content of the
207 pointer and not directly on the pointer !
210 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
211 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
212 the python part recompiles
214 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
216 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
217 X session is killed (for my computer... it seems to not be identic on
220 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
222 avoid problems (otherwise, the difference test between the visible image
223 and the reference is incorrect. If the reference is greater than the
224 screen resolution, it's produce errors).
225 Can be used for only one image. Can be used with a visible flag.
226 * vtk/vtkGdcmReader.cxx : remove commented codes.
227 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
228 under windows at compilation
229 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
231 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
233 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
235 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
236 tests on the image size X, Y, Z
238 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
240 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
241 between the class name and the file name
243 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * src/ : fix compilation warnings for the Write method (2 different
245 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
246 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
247 variable... create a static method in gdcm::Document to access to
248 this variable content.
250 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
252 file, to be accessed by other files (like gdcmFile). Remove commented
253 code. Move the change of the header to the gdcmFile, using the
255 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
256 To be sure of that (and simplify calls), the Write of the header now
257 gets a file name and not a file pointer (std::ifstream).
258 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
259 DocEntryArchive. Remove all open of the written file
261 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
264 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
266 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
268 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
269 some corresponding methods. Write correctly the file and check before
271 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
272 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
273 is now on RGB datas (as before my last commit
274 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
276 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
278 Add a print information of the type of the entry
279 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
280 It was in the gdcmFile, and all write have been regrouped
281 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
282 Write correctly all dicom files (in decompressed mode only at this time)
283 * Test/ : test on files are now made using Raw datas and not color datas if
285 * Example/PrintFile.cxx : add more printings
287 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * Amelioration of code, remove some code copy. For the loading of
289 BinEntry (in gdcmDocument), add the test to verify if the file is already
292 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
294 remove a DocEntry in the header (push an empty DocEntry)
295 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
296 lines. Bug fix in the initialization of the PixelConvert and the
298 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
299 use in TestCopyDicom (now this test can run under windows... but fails)
300 * Test/TestCopyDicom.cxx : amelioration of the test :
301 - test the pixels written
302 - add test points to quickly find where is the error
303 - can set a file name input and output in arguments
304 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
305 amelioration of the test output
307 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
309 all replaced DocEntry's
310 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
311 Now, each needed DocEntry to modify is duplicated, modified and inserted
312 to the header using DocEntryArchive. Thus, after save, we can restore the
313 header initial state.
315 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
318 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
320 correct to copy it. The DictEntry is specified at the DocEntry creation,
321 then, it musn't change in the time.
322 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
323 header correctly. At this time, the change is only made for the first
324 level of the Document. In the future, it might consider sequences.
325 The change is made by replacing a DocEntry by an other that is created
326 outside the class. The old value is kept. When we restore the header
327 status, the added DocEntry is deleted and replaced by the old value.
328 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
329 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
330 set the write type to explicit VR, implicit VR or ACR. Add methods to set
331 the write mode to native, decompressed or RGB (but not used at this time)
333 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
334 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
335 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
337 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
339 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
341 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
342 set because already copied when copying the BinEntry's of the header
343 * Test/TestAllReadCompareDicom.cxx : remove warnings
345 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
347 Two problems appear when doing it :
348 - with the gdcmFile : when the GetImageData method is called, the pixels
349 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
350 datas (pixels). And each structure destruct the datas when it's
351 destructed. So we have two destructions for the same datas. To solve it,
352 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
353 datas or not. If it doesn't own datas, then they will not destroyed by
355 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
356 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
357 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
358 create a double destruction of the same DocEntry's. So, to solve it,
359 the TagHT is simply cleared and the DicomDir* elements are destroyed.
360 * TODO : add an entry concerning memory leaks in the DicomDir
362 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
364 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
367 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
369 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
370 after it have been deleted
372 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * FIX: src/* fix the doxygen warnings.
374 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
375 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
376 was erroneously defined with a size of 15 instead of 16. [many thanks
377 to Jean Michel Rouet for pointing out this bug].
379 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
380 1. Finish merging JMR patch for writting DICOM from scratch
381 2. Fix -hopefully- bug with MONOCHROME and space vs null character
382 3. Use const ref when possible
383 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
384 5. A few more comments
385 6. CreateUniqueUID can now be called without parameter"
387 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
388 * ENH: Slightly bigger patch:
389 1. Getting toward full integration of JMR patch for writting dicom from scratch
390 2. Update Test to test part of this patch: CreateUniqueUID
391 3. File was not close properly in gdcmDict
392 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
393 5. Use of const ref instead of copy (speed issue)
394 6. Remove temporary (duplicate) string in TranslateToKey
395 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
396 8. Do not repeat virtual in subclasses
397 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
399 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
400 * Apply first patch toward better string comparison when dealing with broken
401 DICOM files. Essentially the string could be padded with a space instead
402 of a null character as defined by standard
404 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
406 because never used... and in the same time, that's remove some memory leaks
408 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmFile.cxx : now delete the PixelConvert instance.
410 * In examples and tests : change the type of image data variables from void*
411 to uint8_t*. Remmove all delete on image data variables
413 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
415 Verify the file pointer value before open the file, and if it's not null,
416 a verbose message is generated.
417 Close correctly the file when the file isn't considered dicom-like. The
418 correctly close is a call to CloseFile.
419 When closing the file pointer, test if its not null to close the file.
420 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
421 file. For an uncompressed image, the copied datas correspond in the least
422 case to the image size (calculated) or the image size specified in the
423 header. A verbose is generated if these two size mismatch
425 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
427 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
428 break under windows (with msvc6 compilation).
430 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
431 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
432 compiling with MSVC6)
434 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
435 * Bugs fix for the Windows build with VC6
436 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
437 needed (only for projects required VTK). If the VTK is included in all
438 projects, there is conflicts with the jpeg lib of vtk when compiling the
439 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
440 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
441 when compiling the gdcm_wrap.cxx file (created by the compilation of the
443 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
444 (like it's already made for the cout use). Otherwise, conflict with the
447 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
450 - comments on the DicomDir::Method related usage added.
451 - now that we use the namespace gdcm, a lot of internal classes do
452 NOT need to be wrapped anymore.
453 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
454 DicomDir::Method) new example added.
456 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
457 * Improve string manipulation. I now inforce the notion of 'DicomString'
458 A DicomString can contain as many \0 as they want
459 and it is *always* of even length.
460 We only support odd length for very rare case.
461 And in the near future this should be removed.
463 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
464 * /binary_write/ gdcm source. Now even on big endian we are writting
465 little endian. This should -heopfully- fix some tests
467 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
468 * Now the dictionary is compiled into gdcm lib. This is a default
469 behavior, thus any dic file specified is picked before failback to
470 the one comiled into lib
472 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
473 * Change internals for gdcmDict. Don't use any 'new' any more.
474 This should definitely solve any leak problem, and we should be
475 as fast as before, as long as don't modify too much the dictionary.
477 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
478 * STYLE: ivars should start with a capital letter.
479 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
480 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
482 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
483 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
484 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
485 new 2004 dictionaries added (thanks to JPR).
486 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
487 * CLEANUP_ROUND (15) for gdcmPixelConvert
488 - RLEFrame::NumberFragments is now of type unsigned int
489 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
490 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
493 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
494 * Initial work in gathering all transfer syntax accessors. clearly
495 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
496 ivars, but only one transfersyntax (class) ivar with equivalent method on
499 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
500 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
501 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
502 discussed (plus I didn't like having a 2000 lines patch not commited)
504 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
505 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
506 * CLEANUP_ROUND (14) for gdcmPixelConvert
507 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
508 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
509 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
511 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
512 anymore and hence avoids storing a copy of PixelConvert::Decompressed
513 into File::Pixel_Data.
515 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
516 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
517 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
518 * CLEANUP_ROUND (13) for gdcmPixelConvert
519 Substituted File::ParsePixelData() with PixelConvert::Print() new
521 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
522 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
523 method to those classes.
524 - src/gdcmFile.[cxx|h]:
525 -- Added a ::Print() method.
526 -- PixelConverter is now a reference instead of a member.
527 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
528 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
530 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
532 collaboration diagram and inheritance diagram should be generated with
534 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
535 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
536 pointlessly wrapped (see
537 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
538 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
539 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
540 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
541 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
542 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
543 -- File::Initialise: PixelConverter setup moved away to
544 PixelConverter::GrabInformationsFromHeader()
545 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
546 interpretation moved away to PixelConverter::BuildRGBImage()
548 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
549 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
550 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
552 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
554 displayed on Win32 when a brutal abort() occurs (because of uncatched
555 exception). See TODO new entry of this commit for more on this.
556 * TODO added new entry.
557 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
558 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
559 - HandleColor is no longer called from gdcmFile.cxx
560 - gdcmPixelConvert.cxx clean up on method arguments and internal
561 variable names for semantical coherence.
563 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
564 * Finished lossless transition, not only do we now read all lossless jpeg
565 images, without the need of the Cornwell lib, but we do read them properly now
566 * To reduce code (well to avoid code duplication), I defined a common place
567 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
568 redefine symbols. This is not prefect but this the best solution I found for a
569 compilation time jpeg option.
571 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
572 * Update jpeg ijg lib to support lossless jpeg implementation
573 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
575 * Also added a special copyright for dcmtk since we use their bugfixes.
578 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
579 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
580 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
581 matters, as stated in warning note at begining of %include section).
582 * src/gdcmDicomDir*.[cxx|h]: coding style
583 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
584 * src/gdcmJpeg8.cxx: doxygen fix.
585 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
586 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
587 from File:: to PixelConvert::.
589 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
590 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
591 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
592 - more code moved away from File:: to PixelConvert::
593 - fat setup of PixelConverter set in place in File::Initialise.
595 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
596 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
597 namespace at the file system level. So now you should convert your examples
599 gdcmHeader -> gdcm::Header
600 It would be nice if people keep in mind to no open the namespace, since it
601 allows compilation on broken plateform which were defining common symbol in
602 the standart namespace (like LP, Unknown ...)
604 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
605 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
606 The JPEG fragments are now parsed at the same stage than the RLE
607 information. All code related to JPEG is now in gdcmPixelConvert:
608 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
609 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
610 export a gdcmFile:: method. Those are simply global functions
611 (for the time being this is better than having them attach to
612 either gdcmFile:: or gdcmPixelConvert::).
613 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
614 and stores the result in a gdcmJPEGFragmentsInfo.
615 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
616 code (among other stuff) moved away from gdcmFile:; to
619 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
621 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
622 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
623 clean up of RLE related code.
624 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
625 - src/gdcmRLE.cxx removed
626 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
627 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
628 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
629 * CLEANUP_ROUND (9) for gdcmPixelConvert
630 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
631 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
632 away from gdcmFile:: to gdcmPixelConvert::.
634 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
636 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
637 This is because Parse7Fe0 used to parse the pixels to compute the
638 length. This task was passed over to FindDocEntryLengthOB() a long
639 time ago, EXCEPT I had forgotten the OW case...
640 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
641 we just recylce the code for parsing RLE fragments and computing
643 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
644 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
645 with the retired Parse7Fe0().
646 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
647 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
649 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
651 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
652 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
653 - src/CMakeLists.txt: alphabetic order reodering + new entries.
654 * CLEANUP_ROUND (4) for gdcmPixelConvert
655 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
656 to return an unused length.
658 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
659 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
660 this should be cleanner from the plane view. The iostream are erally a pain
661 to use to do simple stuff.
663 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
664 * Redo the compilation of the ijg jpeg library. Now only one source is
665 necesseray. No need to rename file by hand what so ever. CMake handle the
666 copying of the file within different directory, configure header file to
667 modify some symbol. The only addition made to ijg wasd a mangle table so
668 that symbol are different wether we are within 8bits or 12bits.
670 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
671 * Added documentation of vtkgdcmReader on Website:
672 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
673 with it's binary name).
674 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
675 the Website to be more complete.
676 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
677 doxygenated documentation.
678 - Doc/DoxyVtkGdcmReaderExamples.txt added
679 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
680 DoxyVtkGdmReaderExamples.html )
681 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
682 * CLEANUP_ROUND (3) for gdcmPixelConvert
683 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
685 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * CLEANUP_ROUND (2) for gdcmPixelConvert
687 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
689 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
690 * CLEANUP_ROUND for gdcmPixelConvert:
691 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
692 - src/gdcmPixelStuff[h|cxx] removed
693 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
694 - src/CMakeLists.txt changed accordingly
696 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
697 gdcmVersion.py moved to newly created ATTIC related
698 gdcmPython/SetupOldies/ directory.
699 * Autotools clean up:
700 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
701 - autogen.sh configure.in acinclude.m4 python.m4 removed
703 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * src/*.cxx *.h Reference to License.htm fixed to License.html.
705 * Doc/CMakeLists.txt, doxygen.config.in: fix.
706 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
708 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * TODO updated with Mathieu suggestions. I proposed a template for
710 describing TODO entries and used it for new entries.
711 * Added Doc/Website/CodingStyle.html, Developpers.html,
712 DeveloppersPython.html, GdcmDataCvs.html and
713 DownloadVersion0_1.html, DownloadVersion0_3.html.
714 * Some Doc/*.txt Doxygen files (which do not really concern the
715 documentation itself, but the website) moved to html and
716 placed in directory Doc/Website:
717 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
718 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
719 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
720 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
721 * CMakeLists.txt changed accordingly.
722 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
723 DeveloppersPython.html
724 * INSTALL nows refers to Doc/Website/Installation.html
726 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
727 * Added Doc/Website directory, that contains a first raw version
730 2004-09-23 Jean-Pierre Roux
731 * FIX In order not to be poluted any longer by casting problems,
732 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
733 we can now delete[] it safely
734 * VoidArea is now called BinArea (less confusing name),
735 and all the methods called ...VoidArea... are now ... BinArea...
736 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
738 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
739 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
740 clear) TagHT, which is an inherited member of gdcmElementSet. It is
741 up to the destructor of gdcmElementSet to clean up TagHt and it's
744 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * Test/CMakeLists.txt: update to follow gdcmData renamings.
746 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
748 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
749 * ENH: added some utility method that builds a flat dictionnary
750 holding all the Dicom entries contained in the recursive structure
751 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
753 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
754 BuildFlatHashTable() that build a flat dictionary.
755 - src/gdcmElementSet.h: added a new private GetTag() accessor.
756 gdcmDocument is now a friend of gdcmElementSet.
757 - src/gdcmElementSet.cxx: clean up.
758 - Example/FlatHashTablePrint.cxx added.
759 - Example/CmakeLists.txt changed accordingly
761 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
763 moved away from gdcmDocEntrySet (since this class is an abstract class
764 acting like an interface). SQDepthLevel and BaseTagKey are now
766 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
767 and associated accessors. Doxygenation of the class.
768 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
770 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
771 Use SQDepthLevel accessor instead. ::Print() adapted.
772 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
773 - src/gdcmDocument.cxx changed accordingly.
775 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
776 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
777 - The following is the doxygen comment of the typedef declaration
778 of gdcmagKey in src/gdcmCommon.h:
779 gdcmTagKey is made to old an "universal" (as in URL, Universal
780 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
781 A dicom tag allways has a group and an element, but a set of tags
782 embeded in various (optionally nested) sequences and sharing
783 the same group and element all share the same (group, element)
784 "identifier". Hence the (group, element) cannot be used as an
785 identifier (in gdcm we shall refer to a "TagKey") of a tag.
786 In order to construct a proper tag identifier (i.e. a key) we
787 consider the following definition of a TagKey:
788 - let Group, Element be the string representation of the
789 group and element dicom tag members,
790 - let ItemNumber be the string representation of the integer
791 index of the considered item number of a sequence,
792 Let the key of a tag embeded in a sequence, noted SeqTag, be
794 /ItemNumber#Group|Element
795 where "/", "#" and "|" are characters acting as separators.
796 Then the general form of a gdcmTagKey is given by:
797 Group|Element<SeqTag>
798 where <SeqTag> means NO or many instances of SeqTag.
799 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
802 but the gdcmTagKey of a tag "embeded" is the first item of
803 a sequence, itself nested in the third item of a sequence is the
805 0004|1220/2#0008|0082/0#0008|0090
806 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
807 order to hold the new sequence compatible key. Previously, the
808 GetKey() method would look in the underlying gdcmDictEntry.
809 - src/gdcmDocEntry.cxx:
810 -- constructor now copies the underlying DictEntry key, in the local
812 -- ::Print: displays the member Key, instead of the (group, element).
813 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
814 - src/gdcmDocEntrySet.h:xi
815 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
816 -- now has a new BaseTagKey member.
818 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
819 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
821 This poses the problem with the semantics of the following lines
822 LoadEntryVoidArea(0x0028,0x1201); // R LUT
823 LoadEntryVoidArea(0x0028,0x1202); // G LUT
824 LoadEntryVoidArea(0x0028,0x1203); // B LUT
825 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
826 to the long FIXME note for what the problem is. Nevertheless in
827 order to get things working the dicom dictionary was altered !
828 Please fix things urgently...
829 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
830 information), see above note on moving the member VoidArea. Nevertheless
831 the following entries previously correctly set as US are now inproperly
833 0028 1201 OW IMG Red Palette Color Lookup Table Data
834 0028 1202 OW IMG Green Palette Color Lookup Table Data
835 0028 1203 OW IMG Blue Palette Color Lookup Table Data
836 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
837 of gdcmDocEntry moved to gdcmSeqEntry.
838 * src/gdcmSeqEntry.cxx: STYLE.
840 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
841 * Test/TestAllEntryVerify.cxx minor fix and added comments.
843 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * gdcmPython/testSuite.py: all the test suite in python is now moved
845 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
846 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
847 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
849 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
851 to avoid inclusion recursion until STL is reached.
852 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
853 mecanism. errno.h is not included in gdcm anymore.
854 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
855 (gdcmFormatError now inherits from gdcmFormatUnexpected).
857 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
858 gdcmData/TestAllEntryVerifyReference.txt
859 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
860 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
861 exception_on_error parameter.
862 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
863 - vtk/vtkGdcmReader.cxx changed accordingly,
864 - Example/*.cxx and Test/*.cxx changed accordingly.
866 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
868 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
869 enable_sequences removed from gdcmHeader constructor and dependencies.
870 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
871 * gdcmPython/demo/PrintHeader.py: dummy fix.
872 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
873 skip_shadow removed from gdcmHeader constructor and dependencies.
874 * Example/*.cxx and Test/*.cxx changed accordingly.
876 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
878 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
880 2004-07-21 Jean-Pierre Roux
881 * FIX Now, Parsing and Printing a DICOMDIR do work!
882 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
884 2004-07-20 Jean-Pierre Roux
885 * FIX Some brain damaged headers have Zero-Lenght fields
886 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
888 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
890 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
891 variable (instance of gdcmDebug) by a definition macro, and the instance
892 is now in static in the gdcmDebug class
893 * src/gdcmSQItem.h : (FIXME) remove an undefined method
894 * Test/PrintAllDocument.cxx : bug fix in the result of the test
896 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * WARNING: ctest now depends more tightly on gdcmData. You should
898 check out gdcmData properly for things to run smoothly...
899 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
900 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
901 we need the pixels not be loaded in order to use the ValEntry
902 that displays position and size).
903 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
904 This is a C++ based equivalent of gdcmPython/testSuite.py that should
905 be deprecated. If you have any doubts about the advantages of a
906 modern scripting language (read Python) versus grass root C++ (i.e.
907 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
908 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
909 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
910 Anyhow, consider documenting the gdcmData images in
911 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
913 * Test/CMakeLists.txt:
914 - now uses TestAllEntryVerify.cxx
915 - specific comments on oldACR00001.ima (now renamed in gdcmData
916 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
917 gdcmData/TestAllEntryVerifyReference.txt
920 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
921 * src/*.[h|cxx] : typedef clean up
922 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
923 - TagKey renamed to gdcmTagKey (for external usage)
924 - VRKey renamed to gdcmVRKey (for external usage)
925 - removal of typedef duplication.
926 - Removed all unecessary inline keyword from class inline definitions.
927 - Some method|function(void) declarations replaced with method|function().
928 * src/jpeg/libijg12/jdhuff12.c:
929 - printf polluting ctest removed.
930 - TAB removal for comminting
932 - TestAllReadCompareDicom.cxx: added a test that compares all the
933 images in gdcmDataImages.h with corresponding images in
934 gdcmData/BaselineDicom/. When baseline images are not present
935 this test creates them.
936 Note: we need to validate each reference image, but before that
937 I'd like to rename them with a more explicit name...
938 - CMakeLists.txt: changed accordingly.
939 * Example/*.cxx: examples now only include gdcm.h (as opposed to
940 including each header needed).
942 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
943 * Test/*.cxx and Example/*.cxx: moved some examples away from the
944 test suite to the Example directory. Are concerned:
949 - TestWriteSimple.cxx
950 * Test/CMakeLists.txt: added some comments on reasons for black listing
951 image gdcmData/oldACR00001.ima
953 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * Test/CmakeList.txt: removed the following from black list (to be coherent
955 with removal from gdcmData):
956 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
957 - gdcm-MR-PHILIPS-16.dcm
959 Added the following because after last cvs update, they cause
960 ctest -R TestReadWriteReadCompare
962 - gdcm-MR-SIEMENS-16-1.acr
964 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
965 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
966 new comments in this file) we temporarily (sigh) move to a weaker
968 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
969 we don't need to black list the following images anymore:
970 - 8BitsUncompressedColor.dcm
972 - US-PAL-8-10x-echo.dcm
973 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
974 fixes and the beautified code ;-)
975 This fixes the bug introduced in version 1.42 (when beautifying)
976 that made the parsing of 8BitsRunLengthColor.dcm unproper.
977 Note: ctest was blind to this bug (this means we need to still
978 improve the test suite). The bug could be detected by using
979 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
981 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
982 and by displaying the (garbage) produced file temp.XDCM...
984 2004-06-29 Jean-Pierre Roux
985 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
986 - replace by uggly but working old code :-(
987 A lot of things should be OK again.
988 It's really urgent to have a test suite that *tests*,
989 to prevent Frog's beautifying sessions to break all the stuff
990 (twice, withing a fortnigh ...)
992 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
994 redundancy) to added Test/TestReadWriteReadCompare.cxx
995 * Test/CmakeList.txt: because the compare test of
996 Test/TestReadWriteReadCompare.cxx fails, the following images are
997 black listed: - 8BitsUncompressedColor.dcm
999 - US-PAL-8-10x-echo.dcm
1000 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1001 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1002 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1003 and ad-hoc kludge. This kludge is now removed, and on encountering
1004 such an image (OB field brain damaged) we set errno. Then in
1005 ::FindDocLength() we "fix" the length as being ALL what remains
1006 in the file (until EOF). We then proceed, hoping for the best...
1007 This fixes a SegFault in ShowDicom when trying to write such an
1009 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1010 (because TestWriteRead breaks on it, after a non conformal commit?).
1011 ctest now runs properly, except for MakeDicomDir (which was allways
1012 broken) and the Python related stuff (still not fixed).
1014 2004-06-24 Jean-Pierre Roux
1015 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1016 FIX : Test/TestReadWrite now iterates on all the file names
1017 (instead of infinite loop)
1018 ENH : Test/TestWriteRead now iterates on all the file names
1020 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1021 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1023 2004-06-24 Jean-Pierre Roux
1024 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1025 when SamplesPerPixel =3
1026 - now Write is no longer confused by
1027 'BitsAllocated = 12" and 'BitsStored=12"
1028 - "UN" value representation Elements are now written correctly
1029 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1030 ENH : - now gdcmHeader has its own Write methods
1031 (in order to split the job that has not to be done
1034 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1035 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1036 loop on the same image until memory went out.
1037 Note: this means we still have gobs of memory loss in PrintDocument
1038 * src/gdcmDocument.cxx: fixes problem on parsing on file
1039 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1041 2004-06-24 Jean-Pierre Roux
1042 FIX : Write - All the Sequences and Sequence Item are now written
1043 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1044 is added a the end, when necessary.
1045 - A lot of brain-damaged images, that were read correctly are
1046 now written correctly
1047 - length compatible BinEntry are now loaded correctly
1048 (even for odd groups)
1049 Note : only Explicit Value Representation was checked.
1050 (question : is implicit VR really necessary for gdcm ?)
1052 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * DEVELOPPER: added a proposition of coding style.
1054 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1057 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1059 Use the gdcmDocEntry::Print() and Write() instead.
1060 * src/gdcmDocument.cxx: bug fix.
1062 2004-06-22 Jean-Pierre Roux
1063 FIX : gdcmDocument.cxx
1064 - Now we do recognize the JpegLossLess format (there was a misstyping in
1065 code 'beautyfication' :-(
1066 - Now we automaticaticaly load the Luts, if any
1068 2004-06-22 Jean-Pierre Roux
1069 In order : to write Sequences, whatever their imbrication level,
1070 : to allow user to create his own Sequences
1071 a lot of modif where necessary (adding, moving, or virtualising methods)
1073 WARNING : save your own sources *before* cvs up !
1076 ADD virtual void Write(FILE *fp, FileType filetype);
1079 ADD virtual void Write(FILE *fp, FileType filetype);
1080 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1083 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1084 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1085 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1086 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1087 ADD std::string GetEntryByName(TagName name);
1088 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1090 std::string vr = "unkn",
1091 std::string fourth = "unkn",
1092 std::string name = "unkn");
1093 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1094 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1095 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1096 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1097 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1098 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1099 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1100 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1103 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1104 ADD virtual std::string GetEntryByName (TagName tagName);
1105 ADD virtual std::string GetEntryVRByName (TagName tagName);
1106 REM virtual bool Write(FILE *, FileType);
1107 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1108 FILE *_fp, FileType type);
1109 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1110 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1111 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1112 REM virtual std::string GetEntryByName (std::string tagName);
1113 REM virtual std::string GetEntryVRByName (std::string tagName);
1114 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1115 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1116 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1118 std::string vr = "unkn",
1119 std::string fourth = "unkn",
1120 std::string name = "unkn");
1121 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1122 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1123 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1124 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1127 ADD virtual void Write(FILE *fp, FileType filetype);
1130 ADD virtual void Write(FILE *fp,FileType filetype);
1133 ADD virtual void Write(FILE *fp, FileType filetype);
1134 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1135 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1136 REM std::string GetEntryByName(TagName name);
1139 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1141 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1142 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1143 The default constructor invoked by the line
1144 gdcmHeader *f1 = new gdcmHeader( header );
1145 was gdcmHeader::gdcmHeader(bool) instead of the expected
1146 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1147 Hence the parsing wasn't executed... See also below.
1148 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1149 as explicit constructor didn't do the trick to fix the above problem.
1150 Could anyone explain why ?
1151 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1152 properly calls gdcmValEntry::Print() (that was weed out from
1153 code related to gdcmBinEntry).
1155 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1156 * In order to fix memory leaks:
1157 - Test/TestWriteSimple.cxx: added cleaning of free store through
1159 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1160 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1161 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1162 (through the call to ::AddDicomDirMeta()) or the destructor
1163 would crash when deleting uninitialized ::metaElems].
1164 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1165 - src/gdcmDocument.cxx:
1166 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1167 from dynamic stores.
1168 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1169 was causing memory leaks.
1170 - src/gdcmSQItem.cxx:
1171 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1172 cleanly handled with polymophism: sorry but my milage is low).
1173 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1174 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1175 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1176 This avoids SegFaulting.
1177 - src/gdcmSQItem.h: coding style.
1179 - Test/TestWriteSimple still severely sucks. The output image content
1180 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1181 damaged when displayed with vtkgdcmViewer.
1182 - on memory leaks: TestWriteSimple leaks really less (see entry
1183 of 2004-06-18 in Changelog file for the call to valgrind).
1184 - on segfaults: ctest now passes all the tests but one (no more
1186 * Erroneous leading white fix:
1187 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1188 white[s] (as opposed to from >> xxx, that removes it [them].
1189 - src/gdcmTS.cxx: ditto.
1190 - gdcmPython/testSuite.py: dirty related kludge removed.
1191 * src/*: remaining references to gdcmParser removed.
1192 * src/*[cxx|h]: added copy[way]left header.
1195 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * In order to fix writing of dicom files:
1197 - Test/TestWriteSimple.cxx: a simpler example of writing.
1198 - Test/CMakeLists.txt changed accordingly.
1199 - src/gdcmDocument.cxx:
1200 -- The destructor now recursilvely removes potential sequences.
1201 -- Bug fix in ::IsJPEG2000()
1202 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1203 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1205 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1206 to only declared) and build on top of
1207 ::GetDocEntryByNumber(guint16, guint16).
1208 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1209 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1210 for usage in destructor and treatement of promotion in
1211 ::ReplaceOrCreateByNumber().
1212 - src/gdcmSQItem.cxx: destructor should better handle his job.
1213 Test/TestWriteSimple now runs (or at least it DOES something).
1214 * We can now start hutting memory links. A good starting point is:
1215 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1216 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1217 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1219 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * Valgrind note: after Mathieu Malaterre teached me how to read
1221 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1223 Using gcc, you can force the STL to use malloc and to free memory as
1224 soon as possible by globally disabling memory caching.
1225 With 3.2.2 and later, you should export the environment variable
1226 GLIBCPP_FORCE_NEW before running your program.
1227 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1228 simply vanish (it is still not clear to me, whether this means that
1229 STL std::string leaks or if valgrind believes it leaks...).
1230 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1231 running bin/gdcmTests makeDicomDir):
1232 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1233 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1235 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1236 SegFaulting (I drowned in DicomDir related code when trying to
1237 understand why the list is empty...).
1238 * src/gdcmDocument.h: first BSD license header try.
1239 * Doc/License.txt added.
1241 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1242 * src/gdcmDocument.[h|cxx]:
1243 - Clean up of the Transfer related predicates. They are now all based
1244 on new method isGivenTransferSyntax, that (should) handle properly
1245 the padding problem.
1246 - general clean up, simplification, and coding style.
1247 - Specific clean up of Parse7FE0() (umproperly named actually).
1248 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1250 2004-06-14 Jean-Pierre Roux
1252 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1253 - fix the display of SQItem ordinal number
1254 - add the GetSQItemByOrdinalNumber method
1255 - remove some useless never written private methods
1257 2004-06-14 Jean-Pierre Roux
1259 - adding a constructor taking a gdcmDocEntry as an input param
1260 - ReplaceOrCreateByNumber now returns :
1261 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1262 a gdcmValEntry * if a string value is passed as a param
1264 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1265 according to the param type (no longer sets a gdcmDocEntry)
1266 - GetValEntryByNumber, GetBinEntryByNumber added
1267 - NewValEntryByNumber and NewBinEntryByNumber added
1269 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1271 - GetSQItemNumber and SetSQItemNumber added, to provide
1272 a (relative) Item identier inside a given Sequence
1273 \warning : some pb remaining around this number
1275 - AddEntry now takes the Item Number as a param
1277 - adding a constructor taking a gdcmDocEntry as an input param
1279 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1280 * Memory leak hunt with the following command:
1281 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1282 --show-reachable=yes gdcmTests PrintDocument
1283 It looks like many (all?) leaks are due to the STL (or a bad usage
1284 of the STL. The lines producing the leaks now have a comment with
1285 a "MEMORY LEAK" tag: you can retrieve them with
1286 grep "MEMORY LEAK" src/*
1287 Here are two typical examples which I can't help fixing:
1292 char * test = "babo";
1293 name = test; //// <--- valgrind detects 960 bytes lost in
1294 //// call to std::string::operator=(char const*)
1295 name.clear(); //// Doesn't help !
1303 std::cout << "Type a bunch of characters followed by RETURN: ";
1304 getline(std::cin, line); //// <--- valgrind dectects a loss
1305 //// of 1320 bytes in call to
1306 /// std::basic_istream<>& std::getline<>
1312 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1313 * src/gdcmHeader.[cxx|h]:
1314 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1315 and related, moved away to gdcmDocument.
1316 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1317 the corresponding protected accessors of inherited class
1318 gdcmDocument, removed ! As a consequence gdcmFile had to be
1319 declared friend of class gdcmDocument (see below).
1320 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1321 - Clean up of undefined or unused methods.
1322 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1323 account the changes to gdcmHeader.h).
1324 * src/gdcmDocument.h:
1325 - gdcmFile is now a friend class (in order to take into account the
1326 changes to gdcmHeader.h).
1327 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1328 (see changes to gdcmHeader.h).
1329 - Accessors (reading on the form GetEntry*) are now public.
1330 - Clean up of undefined or unused methods.
1331 * src/gdcmDocument.cxx:
1332 - adaptation to changes to gdcmDocument.h
1333 - ::OpenFile now writes a verbose message when file cannot be opened.
1334 - some std::string properly set to VRKey
1335 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1336 references to gdcmDocument.
1337 * Test/TestFindTags.cxx: changed accordingly to above changes.
1338 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1339 cvs repository gdcmData.
1341 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1342 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1343 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1344 conflicts with gdcmValEntry::voidArea.
1345 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1346 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1347 Value representation between StringRepresentable and BinaryRepresentable.
1348 * src/gdcmDocument.cxx:
1349 - method ParseDES: proper indentation restored and usage of
1350 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1351 - method LoadDocEntry: the fingerprint left in the SetValue() of
1352 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1353 removed. Reverting to previous code segment with the proper
1354 dynamic_cast< gdcmValEntry* >.
1355 Note: this was (partially) breaking the python test suite
1356 (gdcmPython/testSuite.py) that made usage of the above
1357 fingerprint to check presence of "Pixel Data".
1358 * src/gdcmDocEntry.h: coding style.
1359 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1360 now taken into account.
1361 * gdcmPython/gdcm.i: adaptation to the new internal representation
1362 of gdcm (exit gdcmParser, hello gdcmDocument).
1363 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1365 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1366 anymore, but instead prints the loaded Python dictionary.
1367 * .... alas, the python testSuite is still broken.
1369 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1370 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1372 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1373 * src/gdcmUtil.h : export methods
1375 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1376 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1378 * Initial addition of automatic python testing
1379 * Initial addition of automatic image comparison
1381 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1382 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1383 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1385 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1386 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1387 * Test/ShowDicom.cxx : bug fix for msvc compilation
1388 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1390 2004-05-04 Jean-Pierre Roux
1391 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1392 new concepts (and new classes) :
1393 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1394 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1395 - Sequence Doc Entries (gdcmSeqEntries)
1396 a Sequence is composed of Items.
1397 Each item is a set of Doc Entries (this is recursive)
1398 The non uniqueness of the 'Dicom tag' is due to this recursivity
1399 (never taken into account)
1400 Our unability to add a new 'entry' in the header
1401 at the proper location (neither in the H-Table (map or multimap),
1402 nor in the Chained List is also due to this recursivity.
1403 Don't try, right now, to use/modify/compile these new sources :
1404 nothing is finished.
1405 We just commit all the stuff, 'as is', in order not to loose it.
1407 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1408 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1410 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1411 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1412 file prefix (SetFilePrefix)
1414 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1415 * Add a new test: ShowDicom, for now this is just the c++ version of
1416 checkRead.sh, later it will be able to compare the image read against a
1418 * Replace the DEBUG on the stack with a global entry in cmake interface:
1419 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1421 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1422 * Add an example subdir, with a real example on how to read + write a
1425 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1426 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1427 * Doc/CMakeLists.txt: the main page is now properly differentiated
1428 between the developper and user version.
1429 * Doc/doxygen.config.in: dropped search related obsolete flags
1430 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1432 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1433 * DEVELOPPER: added some helpfull comments for compile/test/install
1436 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1437 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1438 src directory, now generated in the build dir.
1439 2. Tests as mentionned smarter
1441 4. Add a new method in gdcmDict that return the PubDict by name
1442 this is interesting for 3rd party lib like ITK,
1443 where we could set the institution name / patient name...
1445 * ENH: 1. Now the test suite is working for real
1446 2. All binaries are now output in the gdcm-bin directory
1447 (this was not true before)
1449 2004-04-28 Jean-Pierre Roux
1450 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1451 SeQuence indented printing of Dicom Header.
1452 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1453 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1454 Computation of SQDepthLevel is now part of gdcmHeader constructor
1455 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1456 tree-like structure of a Dicom Header.
1457 * FIX Test code cleaning
1459 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * ENH: Adding automatic testing
1461 1. Need a DartConfig.cmake to submit to public
1462 2. Add a test driver gdcmTest.cxx
1463 3. gdcmTestMain, an helper for the main test driver gdcmTest
1464 4. Files in Test don't have a main anymore, this becomes interesting
1465 when we add more and more tests, thus dsw don't have to load
1467 * ENH: Adding a GDCM_DATA_ROOT for testing
1468 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1469 one file instead of seven + some small cleanup
1471 2004-04-22 Jean-Pierre Roux
1472 * ENH Minor changes to the Print() methods.
1473 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1474 Header printing. Example given with :
1475 > PrintHeader fileName 2 new
1476 (SQ based tree-like structure still to be done for the Header ...)
1478 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1479 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1480 1. I have added some unsigned where needed
1481 2. Some function parameter not used -> (void)
1482 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1483 4. g++ don't like character '\' in comment
1484 5. #define jpeg_create_decompress jCreaDecompress
1485 this really need to be fixed
1486 6. virtualize destructor of gdcmObject ... leakage
1487 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1488 this also really need to be fixed
1489 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1490 remove compression file
1491 (as we only do decompression, right ?)
1492 * ENH: Change malloc/calloc/free with c++ equivalent
1494 2004-04-21 Jean-Pierre Roux
1495 * FIX gdcmHeaderHelper::GetXSpacing
1496 when a single value is found (bug ?), xpacing is now
1497 defaulted to yspacing
1499 2004-04-19 Jean-Pierre Roux
1500 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1501 * ENH add parameters :
1502 bool exception_on_error = false,
1503 bool enable_sequences = false,
1504 bool ignore_shadow = false
1505 to the gdcmFile constructors to be full gdcmParser compliant
1506 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1507 to allow reading of PAPYRUS 3.0 files
1509 2004-04-06 Jean-Pierre Roux
1510 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1512 2004-04-02 Jean-Pierre Roux
1513 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1514 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1515 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1517 2004-03-30 Jean-Pierre Roux
1518 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1519 for ACR file, written out as DICOM files (hope so...)
1521 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1522 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1523 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1524 moved to base class gdcmParser and only the specialisation is kept
1526 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1527 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1528 already does the job.
1529 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1530 (to be consistent with gdcmParser::WriteEntries).
1532 2004-03-30 Benoit Regrain
1533 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1534 upate of the object's instance. It's passed to 2 in the unfavorable
1535 case : one in the ExecuteInformation, one in the ExecuteData
1537 2004-03-29 Jean-Pierre Roux
1538 * ENH : Check on file type to be written moved
1539 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1540 * FIX : gdcmObject::ResetBoundaries now stops properly
1541 when end-of-list is reached
1542 : gdcmVersion modified (as Benoit Regrain asked)
1544 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1545 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1546 * src/gdcmUtil.cxx: added forgotten iostream include.
1547 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1548 equivalent to ExplicitVR in existing code).
1550 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1551 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1552 now contains all the gdcmGlobal related code.
1553 * minor coding style and doxygenation changes.
1555 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1556 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1557 now contains all the Debug related code.
1558 * minor clean-up of includes in src/*.cxx
1559 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1560 CreateCleanString) removed.
1561 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1562 * Doc/DoxyMainPageUser.txt added.
1563 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1564 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1565 src/gdcmDirList.cxx)
1567 2004-03-24 Jean-Pierre Roux
1568 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1570 2004-03-23 Jean-Pierre Roux
1571 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1572 big endian made volumes
1573 * ENH Now gdcmParser constructor and destructor are protected to forbid
1574 end user to instanciate class gdcmParser
1575 (only gdcmHeader and gdcmDicomDir are meaningfull)
1577 2004-03-22 Benoit Regrain
1578 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1579 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1580 gdcmSerie to gdcmDicomDirSerie
1582 2004-03-19 Jean-Pierre Roux
1583 * ENH Now the tree-like structure describing a DICOMDIR comming from
1584 an already existing DICOMDIR file is consistent with
1585 the home-made tree-like structure build ex-nihilo
1586 or build from the files held (recursively) in a Directory
1587 functions gdcmDicomDir::CheckBoundaries()
1588 gdcmObject::SetBoundaries() added
1590 2004-03-17 Jean-Pierre Roux
1591 * REM (Eric Boix bug) : removal of meaningless
1592 gdcmDicomDirImage::NewImage function.
1593 * FIX now file names and directory name are written properly in the
1595 * FIX now gdcmDicomDir constructor may be call without any trick
1598 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1599 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1600 of gdcmDicomDirImage::NewImage as empty function.
1602 2004-02-28 Jean-Pierre Roux
1603 * ENH add gdcmDicomDir:NewPatient
1604 add gdcmDicomDirPatient:NewStudy
1605 add gdcmDicomDirStudy:NewSerie
1606 add gdcmDicomDirSerie:NewImage
1607 to allow making gdcDicomDir object.
1608 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1609 (as opposite to the gdcmHeader chained list)
1611 2004-02-11 Benoit Regrain
1612 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1613 when using from python
1615 2004-02-10 Benoit Regrain
1616 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1617 * FIX : in gdcmDicomDir when the directory is empty
1618 * ENH : add callback and methods to get the progression of dicomDir
1621 2004-02-06 Jean-Pierre Roux
1622 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1623 - GDCM_META added to gdcmDicomDirType
1624 - class gdcmMeta created
1625 * ENH : - A brief summary is now displayed at the beginning of
1626 'testDicomDir' to help disaster magnitude estimation
1627 * REM : Now useless Test/explDICOMDIR.cxx
1629 2004-02-05 Benoit Regrain
1630 * ENH : add methods in gdcmObject to get the hash table or the list of
1632 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1633 * FIX : wrapping python for TagHeaderEntryHT
1635 2004-02-04 Benoit Regrain
1636 * FIX : even length for some strings when writting the dicom dir
1637 * FIX : sort the images in the dicom dir
1638 * FIX : Bug fix for python use of dicom dir
1639 * ADD : a python demo
1641 2004-02-04 Jean-Pierre Roux
1642 * FIX : Final solution (?) for icone embedded images
1643 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1644 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1645 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1646 gdcmData/gdcm-MR-SIEMENS-16.acr1
1647 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1648 to make full checking easier
1650 2004-02-04 Benoit Regrain
1651 * FIX : WriteEntries : coding style & logic in parameters
1652 * FIX : Set the elements to create the DicomDir in a dictionary file
1654 2004-02-03 Benoit Regrain
1655 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1656 * gdcmDicomDir : add the load of directory
1657 * Bug fix and print add-on
1659 2004-02-03 Jean-Pierre Roux
1660 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1661 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1662 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1663 * FIX gdcmParser.cxx : 'group length' elements are now considered
1664 as integers, even for shadow groups, when file is Implicit VR
1666 2004-02-02 Jean-Pierre Roux
1667 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1669 of the last synonym :-(
1670 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1672 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1673 * FIX taking into account the possible 7fe0,0010 multiplicity
1674 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1675 to allow removal of references to 7fe0,0010, to deal with
1676 ACR-NEMA images, when 0028,0200 is meaningfull
1678 2004-01-31 Jean-Pierre Roux
1679 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1680 no longer writes 'Un' on disk
1681 * FIX SQ elements with actual length are now dealt with corectly
1682 * FIX gdcmFile::WriteBase make the difference, for color images, between
1683 the length (for Palette expanded images)
1684 and Raw Length (non expanded image + Palette)
1685 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1686 (that broke Write). Replaced by UL.
1687 Aware user will reload the field if he
1688 thinks it's necesssary
1690 2004-01-30 Jean-Pierre Roux
1691 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1692 when 'dirty Acr' is found, to be compliant with the new
1693 IsReadable() methods.
1695 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1696 (no DOUBLE images in kosher DICOM,
1697 but so usefull for people that miss them ;-)
1699 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1700 DICOMDIR related utilities (not checked as Windoze compliant)
1702 2004-01-28 Jean-Pierre Roux
1703 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1705 2004-01-27 Jean-Pierre Roux
1706 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1707 to allow skipping the shadow elements, to save memory space.
1708 The TRUE value for this param has to be used
1709 with a FALSE value for the 'enable_sequence' param.
1710 ('public elements' may be embedded in 'shadow Sequences')
1711 * gdcmHeader methods now deal with 'embedded icones images' in the header
1712 (even when an 'icone image sequence' is announced by the
1713 element (0x0088,0x0200), but there is NO icone at all ...
1715 * gdcmHeader sometimes Image Location value doesn't follow
1716 the supposed processor endianity (see gdcmData/cr172241.dcm).
1719 * gdcmHeader add the method
1720 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1721 to get *all* the Header Entries with the same tag.
1722 GetHeaderEntrySameName is probabely *useless*
1723 (no meaning : Name is *not* an identifier within the Dictionnary)
1725 2004-01-26 Benoit Regrain
1726 * Bug fix in the print of hexadecimal representations. Remove long fields
1727 in the print and add a third level of print to print them
1729 2004-01-23 Benoit Regrain
1730 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1731 * Bug fix on test suite after remove the strip made on not string fields
1732 * Split the IsReadable method between gdcmParser which test that the file
1733 is dicom and gdcmHeader which test that it's an image file
1735 2004-01-22 Benoit Regrain
1736 * DicomDir : clean code, add methods, set variables in protected or private
1737 * gdcmUtil : bug fix for the clean string method
1739 2004-01-19 Benoit Regrain
1740 * Add the use of shadow dictionaries
1741 * bug fix and coding style
1743 2004-01-19 Benoit Regrain
1744 * src/gdcmFile.cxx : bug fix concerning the close of file
1745 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1746 * Add the update of header entries using the shadow library
1748 2004-01-19 Benoit Regrain
1749 * removal of file gdcmHeader2.cxx
1750 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1751 inheriting from gdcmParser. This split is to prepare the integration
1752 of dicom dir parsing
1753 * bug fix under python
1755 2004-01-16 Jean-Pierre Roux
1756 * REM removal of class gdcmHeaderEntrySet
1757 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1758 * ADD add file gdcmHeader2.cxx
1759 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1761 2004-01-15 Benoit Regrain
1762 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1763 entries created while parsing the header. Thus, they will be destroyed
1764 when the gdcmDictSet will be destroyed
1765 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1768 2004-01-15 Benoit Regrain
1769 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1770 made a fatal error because of the memory release at the end of program.
1771 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1772 some memory and vtk seems to have some problems with that.
1773 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1775 2004-01-14 Benoit Regrain
1776 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1777 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1778 * src/*.[h|cxx] : make changes due to class name changes
1779 * gdcmPython/demo/*.py : bug fix due to method names
1781 2004-01-13 Benoit Regrain
1782 * src/*.[h|cxx] : coding style
1783 * vtk/*.[h|cxx] : coding style
1785 2004-01-13 Benoit Regrain
1786 * gdcmPython/testSuite.py : test the readable flag of file for tests
1787 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1788 It's lied to the stl compilation by MSVC (windows, always windows...)
1789 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1791 2004-01-12 Benoit Regrain
1792 * src/*.h : add comments
1793 * src/gdcmDictSet.h : set the method BuildDictPath in public
1794 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1795 directly setted in the source code
1796 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1799 2004-01-09 Benoit Regrain
1800 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1801 * setup.py : use a reference to gdcmVERSION
1803 2004-01-07 Benoit Regrain
1804 * Modification to compile with the distutils.
1807 2003-12-10 Benoit Regrain
1808 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1809 can use a gdcmHeaderHelper to load datas
1810 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1811 made in the source code
1813 2003-12-10 Benoit Regrain
1814 * Update Windows projects and .cvsignore files
1816 2003-11-12 Jean-Pierre Roux
1817 * ENH gdcmHeader constructor has one more parameter (default value : false)
1818 that allows the user to 'go inside' the SeQuences only
1820 gdcmElValSet:Print takes it into account
1822 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * ENH: Update gdcmPython/CMakeLists
1824 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1825 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1827 2003-11-10 Jean-Pierre Roux
1828 * FIX : gdcmHeader::LoadElements is now based
1829 on the ListTag listElem member,
1830 not longer on the TagElValueHT tagHt member
1831 * ENH : PrintPubElVal shows (temporarily) both results,
1832 with the tagHt member and the listElem member.
1833 (it's easier to 'see' the problems when using Printheader)
1835 * FIX : old private member LgrElem is now splitted into
1836 ReadLength : Length actually found on disk (updated only
1837 if bug fixing is necessary), for internal
1839 UsableLength : Updated by FixFoundLength, to fix a bug
1840 or to allow Parser going on.
1841 Will allow to re-write a kosher header when a SeQuence
1842 with a length (not 0000) is found
1843 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1844 because gdcmElValSet::Add does not update ListElem
1847 2003-11-07 Jean-Pierre Roux
1848 * FIX misstyping in Transfert Syntax name table
1849 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1850 when they have an actual length (not 0000 nor FFFFF)
1851 (Nobody should care of it, but DICOMDIR explorers)
1853 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1854 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1856 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1857 * ENH: vtkGdcmReader now supports LUT !
1858 (vtkgdcmViewer for now is not able to use them though)
1860 2003-11-05 Jean-Pierre Roux
1861 * in testSuite.py : new files names for checking the package
1862 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1863 that returns the pixel area size to the *aware* (vtk) user
1864 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1866 2003-11-05 Benoit Regrain
1867 * in testSuite.py : Modify the rules for checking the paths
1868 : Explicit error messages
1869 * in __init__.py : Related modif
1871 2003-11-03 Jean-Pierre Roux
1872 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1873 to be used by aware (vtk) users that want to manage
1874 LUT (and no to turn the PALETTE image into an RGB pixels one)
1875 * GetPixelType now returns 8U for 24 Bits images
1876 (vtkGdcmReader compliant)
1878 2003-10-31 Jean-Pierre Roux
1879 * Removal of *all* gdcmData images and add them again
1880 in order to loose the 'history' of un-anonymised images
1882 2003-10-31 Jean-Pierre Roux
1883 * RMV : removal of useless jBitsInJsample.h
1884 for both 8 and 12 Bits JPEG Lossy Libraries
1886 2003-10-31 Jean-Pierre Roux
1887 * ENH : Add the functions gdcmFile::GetImageDataRaw
1888 gdcmFile::GetImageDataIntoVectorRaw
1889 that act as GetImageData and GetImageDataIntoVector
1890 except the making of an RGB Plane from Gray Plane + LUT
1891 Intended to aware (vtk) users who know how to manage
1894 GetLUTRGBA return a R,G,B,A LUT if any
1895 lgrTotaleRaw gives the 'Raw' length
1896 GetImageDataRaw returns the gray Plane
1897 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1898 (They stay Grey, just like with other Dicom viewers :-(
1900 2003-10-30 Jean-Pierre Roux
1901 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1903 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1904 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1905 being coherents dicom files.
1907 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1908 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1910 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1911 * ENH: Two steps is necessary to please VC++ compiler...
1912 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1913 * ENH: Add include dir to medcon lib
1914 * FIX: only one function is being exported for now !
1915 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1917 2003-10-29 Jean-Pierre Roux
1918 * adding gdcmHeader::GetLUTRGBA
1919 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1920 --> Mathieu, the modif u're waiting for is not yet committed
1921 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1923 2003-10-27 Jean-Pierre Roux
1924 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1925 00191113.dcm DermaColorLossLess.dcm
1926 MxTwinLossLess.dcm RadBWLossLess.dcm
1927 * ENH: For version prior to vtkImageViewer2 -r 1.19
1928 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1930 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * Removal of ido stuff in CMakeLists.txt
1933 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1934 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1935 * FIX: remove a call to ->Modified ... see comments
1936 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1938 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * FIX: Problem with path for libvtkgdcmPython
1940 * ENH: Try adding a search script for python site-package
1941 * RMV: Remove some file from medcon lib that are not necessary
1942 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1943 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1944 * FIX: More pragma disable fro VC++,
1945 I don't think I break something as it is also disable in VTK/ITK.
1946 But it fasten debug compilation time.
1948 2003-10-23 Jean-Pierre Roux
1949 * gdcm now deals with 16 Bits Run Length Encoded images
1950 (they are compressed as 2 planes images,
1951 one for the high Bytes, the other for low Bytes)
1953 2003-10-22 Jean-Pierre Roux
1954 * Now CheckRead takes into account :
1955 - the bugged 'Leonardo' Siemens images
1956 - the XA images, sent thru the burning VPRO station
1957 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1960 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1961 * FIX: When copying a Makefile.am to CMakeLists.txt
1962 one should remove the '\'
1964 2003-10-22 Jean-Pierre Roux
1965 * in gdcmData adding a bugged 'Leonardo' Siemens image
1966 (wrong lengths in header)
1967 OK with gdcm, KO with the other viewers :-)
1968 * add a GE dlx XA image, thru the VEPRO burning station
1971 2003-10-21 Jean-Pierre Roux
1972 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1973 for a brutal checking of vtkgdcmViewer compliance
1975 2003-10-21 Jean-Pierre Roux
1976 * add the files for 'xmedcon' Jpeg Lossless library
1977 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1979 2003-10-21 Jean-Pierre Roux
1980 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1982 2003-10-21 Jean-Pierre Roux
1983 * garbage Siemens 'Leonardo' images dealt with
1984 (the patch is easy to remove)
1985 * cosmetic changes to avoid warnings
1987 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1988 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1989 no need to press 'r' now.
1991 2003-10-20 Jean-Pierre Roux
1992 * upgrade of checkRead.sh checkWrite.sh according
1993 to new Jpeg Lossless decompressor
1994 * add US.3405.1.dcm, a genuine RGB medical file ...
1995 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1996 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1998 2003-10-15 Jean-Pierre Roux
1999 * general anonymisation in gdcmData
2000 * adding the 'color files' from
2001 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2002 * adding some well knowed bugged-header images
2003 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2004 waiting for their inclusion in Python testsuite
2006 2003-10-15 Jean-Pierre Roux
2007 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2008 no longer seg faults when file is not found
2010 2003-10-14 Jean-Pierre Roux
2011 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2014 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2015 * TODO: *.in file to genereate a UseGDCM later
2017 2003-10-14 Jean-Pierre Roux
2018 * Some supposed-to-be Dicom Images have no preamble.
2019 OpenFile takes it into account
2020 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2021 * Missing elements added in dicomV3.dic
2022 (just to be affraid : have a look at
2023 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2024 and do it again next year ;->
2026 2003-10-13 Jean-Pierre Roux
2027 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2028 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2029 But there are NOT. It's fixed !
2031 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2032 * FIX: "jpeglib.h" was not found on VC++
2033 * FIX: vtkgdcm was not being installed
2035 2003-10-10 Jean-Pierre Roux
2036 * ENH : OpenFile closes the file if it *really* doesn't look like
2037 an ACR-NEMA / DICOM one.
2038 * FIX : testWrite no longer writes an empty file if the source file
2039 is not gdcm Readable
2040 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2043 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2044 * FIX: CMake generate now documentation
2045 * ENH: out of source doc build !
2046 * ENH: Generate both user and dev documentation
2047 * ENH: Should work on windows too
2048 * ENH: Only one doxygen config.in file is needed
2049 * FIX: make install should be ok now on ùnix plateform
2050 * FIX: PATH to dictionary was wrong (missing /)
2051 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2053 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2054 * vtkGdcmReader is now able to read rgb dicom file.
2055 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2056 * added a gdcmViewer to vtk test, use mouse to control
2057 window level & window width
2059 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2060 * CMake-ification of gdcm, we have now two build system
2061 * FIX: on cygwin Wsock32 doesn't exist
2062 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2064 2003-10-06 Emanuel Ollart
2065 * FIX : compilation process wad broken.
2066 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2068 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2069 * change gdcmViewer -> vtkgdcmViewer
2070 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2072 2003-10-06 Jean-Pierre Roux
2073 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2074 ( e.g : well known GE images with a wrong elem length,
2075 : Philips MRI Images with a wrong Huffman table)
2076 * still to be done : allow the reading of bugged LEONARDO Siemens images
2078 2003-10-03 Jean-Pierre Roux
2079 * Odd length strings are padded with '\0' (not with spaces,
2080 to remain compliant with already defined strings,
2081 like Transfert Syntax UID and others)
2083 2003-10-03 Jean-Pierre Roux
2084 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2085 to allow displaying RGB images (not only by affim ;-)
2087 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2088 * vtkGdcmReader is now able to read rgb dicom file.
2089 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2091 2003-10-03 Jean-Pierre Roux
2092 * A few nasty patches to allow the reading of a lot of nasty images
2093 ( e.g : well known GE images with a wrong elem length,
2094 : Philips MRI Images with a wrong Huffman table)
2095 * still to be done : allow the reading of bugged LEONARDO Siemens images
2097 2003-10-03 Jean-Pierre Roux
2098 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2100 2003-10-03 Jean-Pierre Roux
2101 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2102 to allow displaying RGB images (not only by affim ;-)
2104 2003-10-03 Jean-Pierre Roux
2105 * gdcmFile::GetImageDataIntoVector now
2106 - deals with MultiFrames MultiFragments Run Length Encoded files
2107 - deals with YcBcR (YBR_FULL) files
2108 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2109 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2111 (no sample found :-(
2113 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2114 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2115 Two reasons: - clear things
2116 - third parties acces gdcm through header files, so won't
2117 suffer anymore VC++ complains
2119 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2120 * add argv[1] in testvtkGdcmReader.cxx
2123 2003-09-24 Jean-Pierre Roux
2124 * The lines are now eigthy characters long.for
2125 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2127 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2128 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2129 char* to std::string. Thus, the use of strdup becomes useless. (see
2130 previous commis of Malaterre)
2131 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2132 before the last Malaterre's commit.
2134 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2135 * This commit should fix the Debug building under VC++, the problem
2136 was mainly a mixture of debug and release lib being loaded at startup.
2137 * I also remove a depency to a specific C function: strdup. Because I had
2138 to force the link to msvcrtd (whereas strdup is in libc).
2140 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2141 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2142 located in the gdcmCommon.h file. All use of reference of tha has been
2143 changed to now use the variable GDCM_UNFOUND.
2145 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2147 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2148 Dicom dictionary. The test suite can now be run again. Note:
2149 I'm note very happy with the " (RET)" changes. I believe this
2150 RETAINED comment should be dropped when parsing the dictionary.
2151 - PACKAGER corrected
2153 - AUTHORS updated and now in alphabetical order
2154 * Makefile.am now exports gdcm.dsw for Windoze users.
2156 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2157 * cygwin complains about missing std:: in subdir Test/
2159 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2160 * remove some methods that are now in gdcmHeaderHelper
2162 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2163 * vtkGdcmReader set spacing and origin correctly
2165 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2166 * Fix a few delete/delete[] mismatch
2168 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2169 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2170 interpretation to data given by gdcmHeader. For instance there are
2171 heuristics to get informations (look at different places).
2172 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2173 sorting DICOM images based on different strategies.
2174 * modified Makefiles accordingly.
2176 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2177 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2178 when building in debug mode
2179 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2180 src/win32/gdcmdll.dsp
2181 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2183 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2184 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2187 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2188 * src/win32/libgdcmjpeg12.dsp was not dos format
2189 * src/win32/libgdcmjpeg12.dsp :
2190 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2191 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2193 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2194 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2196 * src/gdcmFile.cxx : bug fix in affectation type
2197 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2198 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2199 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2200 symbols... future problem ?
2202 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2203 * src/win32/libgdcmijpeg12.dsp was missing
2204 * modified gdcm.dsw accordingly
2206 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2207 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2209 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2210 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2211 commit of JPR (before his hollidays to facilitate our work).
2212 * setup.py : bug fix in code. Modifications made while the last commit
2213 of JPR. The code hasn't been tested before the commit... it's so
2214 useless to make that (for best programmer that is JPR) !!!
2216 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2217 * tagged the current version as Version0_3 (i.e. version 0.3)
2219 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2220 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2221 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2222 * *.dsp : modifications to use new libgdcmijpeg8 library
2223 * setup.py : bug fix on VTKPATH variable
2224 * PACKAGER : adding all concerning windows
2226 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2227 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2229 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2230 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2231 test suite reported error.
2232 * PACKAGER file added (describes what a packager must do when
2233 packaging a new release).
2234 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2235 * configure.in: upgraded version number to 0.3.0
2236 * fixing build of rpm (through rpm -ta):
2237 - Doc/Makefile.am exports proper doxygen files
2238 - src/jpeg/libijg8/Makefile.am exports the include files.
2240 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2241 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2242 * src/gdcmHeader.h : formatting code
2244 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2245 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2246 We were obtaining error message from vtk. Now, creation of file list
2247 is made in an internal list to prevent this problem.
2248 Bug fix when output is empty.
2249 Bug fix in update of progress value. Previous commit for this was a bad
2251 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2253 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2254 * src/gdcmHeader.h : added method to get the file name
2255 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2256 files. Added method to remove all files on the input
2257 Added FIXME comment concerning the bad parsing of header made by
2258 ExecuteInformation method (in ExecuteData method)
2260 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2262 when using make instal.
2263 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2264 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2266 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2267 * setup.py : adding include dir of jpeg lib to compile all sources
2268 * */Win32/*.dsp : JPR fix for windows compilation
2270 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2271 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2273 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2274 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2276 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * setup.py is again effective on un*x (takes into account the
2278 addon of the jpeg library)
2279 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2280 * Doc/Doxy* updated (includes above enhancements)
2281 * INSTALL now points to web documentation
2283 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2284 * src/gdcmHeader.h doesn't make unnecessary reference to
2286 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2288 * src/gdcm*.[cxx|h] :
2289 - to allow compilation with gcc 3.x
2290 -- clean up of STL usage (added explicit usage of std::)
2291 -- small fixes on exceptions.
2292 Note: linking not tested !
2293 - clean of doxygen comments to avoid warnings at documentation
2295 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2296 dependent convertion).
2298 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2299 * Clean up of previous JPR garbage commit (not even commented in the
2301 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2302 - moved all jpeg related files from src to src/jpeg/libijg8, with
2303 addition/modification of Makefile.am and configure.in.
2304 - the testSuite is still brain damage (not guilty).
2306 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2307 * WrapVTK.py : modifications to get correctly vtk source files to
2309 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2310 (FileName -> Filename)
2312 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * vtk/vtkGdcmReader.[cxx/h]:
2314 - UpdateProgress method should now be effective
2315 - removed the limitation on having only images loaded (as opposed
2317 - when building a stack of images/volume, a lesser number of
2318 gdcmHeader and gdcmFile instances should be used (hopefully
2319 accelerating things).
2320 - when building a stack of images/volumes, files which are not
2321 loadable (wrong path-filename, wrong permissions on existing file,
2322 or file not parsable by gdcm) are replaced with a black image
2323 in the stack (for the caller to notice the problem).
2325 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2326 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2328 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2329 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2330 between standard library (std) and vtk library (problems are found
2331 under Windows... thanks Windows !)
2333 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2334 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2336 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2338 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2339 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2341 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * When compiling with distutils (see setup.py) the C++ compiler is
2343 called with different flags than the default ones (with automake).
2344 In order to fix all those warning, I compiled gdcm with the command
2345 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2346 and went for warning fixes:
2347 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2348 up from unused variables.
2349 - vtk/vtkGdcmReader.cxx: potential bug fix.
2350 * src/gdcmHeader.h: Doxygen warning cleanup
2352 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2353 * gdcmPython/gdcm.i:
2354 - typemaps correction to take into account the systematic replacement
2355 of "using namespace std" with std:: prefix e.g. std::list,
2356 std::string... (cf changes of 2003-05-21).
2357 - gdcmGlob global variable of type gdcmGlobal (defined in
2358 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2359 exported to Python a as cvar.
2360 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2361 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2362 gdcmDictSet.GetPubDictTagNames() and
2363 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2364 C++ static methods).
2365 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2366 with the above changes.
2368 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2369 * setup.py, manifest.in : bug fix under linux
2371 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2372 * Modification of setup.py to compile vtk part too. Then, we have 2
2373 wrappers which must work with same distutils. For that, we have a
2374 generic distutils in distusiltsWrapping.py ; with :
2375 - build_extWrap class to wrap generically all extensions,
2376 - ExtensionWrap base class for all wrapping extension that contains
2378 - Wrapper interface which wrap sources
2379 + In WrapSwig.py we have extension and wrapper for Swig
2380 + In WrapVTK.py we have extension and wrapper for VTK
2381 * MANIFEST.in : modifications to consider vtk directory and new python
2382 files for compilation
2384 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2385 * Added python wrappers of vtkGdcmReader vtk class (see the
2386 source in vtk/vtkGdcmReader.cxx) :
2387 - vtk/Makefile.am now builds a library
2388 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2389 python library (as opposed to _gdcm.so wich are the python
2390 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2391 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2393 - configure.in has an additional flag --enable-vtk that needs
2394 to be set to enable compilation of vtk related code, that is:
2395 + vtk/vtkGdcmReader.so and
2396 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2397 + gdcmPython/vtkgdcmPython.so (see above)
2398 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2399 be read when compressed or when HighBit + 1 != BitsStored),
2400 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2401 the usage of the python wrapper of vtkGdcmReader vtk class.
2402 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2403 * src/*.[h] all occurences of stl classes are now prefixed with
2404 std::, and all occurences of "using namespace std;" where removed.
2405 This is to avoid pollution of global namespace in included files.
2406 Apparently vtk does not avoid this pitfall: when using both
2407 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2408 collision of various stl members (principally cout...).
2409 * gdcmPython/testSuite.py now cleanly removes temprory generated
2411 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2412 comply with above changes)
2414 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2415 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2416 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2417 vtk data structure (an image Flip was required).
2418 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2419 * cosmetic changes in documentation.
2421 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2422 * src/gdcmHeader.cxx: the constructor no longer exits when an
2423 unexisting file is given as argument.
2424 * The subdirectory Data (containing all the images used for the
2425 test suite) is not part of this repository anymore. A new module
2426 containing those images is now available at
2427 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2428 with the name gdcmData.
2429 All the python scripts (including the package initialisation file
2430 gdcmPython/__init__.py) were adapated to take this change into
2431 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2433 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2434 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2435 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2436 demo of the usage of this class.
2437 Compilation of this vtk part is only done when using the --enable-vtk
2438 at configure (or autogen.sh) stage.
2440 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2441 * More memory link related corrections and documentation fixes.
2443 - maximum info is obtained with a command of the form:
2444 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2445 --show-reachable=yes PrintHeader
2446 - the remaining reachable blocks seem to come from the STL
2447 allocation scheme through the usage of map and list. It looks
2448 like this memory cannot be freed but it is not a memory leak
2449 (in fact further invocation to the STL would recollect the
2450 unused memory allthough it cannot explicitely be freed).
2451 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2452 of displaying an image parsed with gdcm and displayed with VTK.
2453 Note: some images don't seem to work e.g.
2454 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2455 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2456 Allthough this weakens the semantics, it is a ditch attempt to
2457 make gdcm more thread friendly.
2459 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2460 * Memory link hunt (by using valgrind through the command
2461 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2462 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2463 gdcmHeader::_dicom_vr.
2464 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2465 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2467 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2469 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2470 * src/Makefile.am now exports all the necessary include files at
2474 * UpdateGroupLength replaced by new one
2477 * UpdateGroupLength re-written using H-Table
2478 (named UpdateGroupLengthNew untill checks are over)
2480 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2481 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2482 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2484 - gdcmHeader::GetPubElValSet removed.
2485 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2486 UpdateGroupLength, WriteElements, Write.
2487 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2488 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2489 carried the same semantics.
2490 - src/gdcmHeaderIdo.cxx changed accordingly.
2491 - gdcmFile::WriteBase now regroups all the codes from previous
2492 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2493 - enum FileType moved to gdcmCommon.h
2494 * src/gdcmHeader.cxx AddDefault trashed
2495 * gdcmGetXSize added
2496 * getimageDataSize now calls gdcmGetXSize
2497 * Test/*.cxx changed to agree with above changes
2499 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2500 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2501 (to avoid double call by end user).
2502 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2503 by end user, since gdcmHeader::gdcmHeader now handles it.
2505 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2506 * gdcm/Doc many doxygen changes:
2507 - Doxyfile now has two different versions, DoxyfileUsers that generates
2508 the html.users end users oriented documentation and
2509 DoxyfileDeveloppers that generates the html.developper developper
2510 oriented documentation.
2511 - README changed accordingly
2512 - requirement.txt removed (old design info moved to TODO).
2513 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2514 DoxyMainPage.txt, DoxyPython.txt provide more information.
2515 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2516 be updated by simply regenerating the docs with doxygen and copying
2517 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2518 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2519 all the tests in the form "if (<map>.count() >1)" were removed.
2520 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2521 ill-formed documentation sections.
2522 * src/gdcmHeader.cxx: ditto
2524 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2525 * setup.py fixed for un*x (needed macro for stdint.h)
2526 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2527 un*ces with sh-utils test utility.
2528 * gdcmPython/demo/test.py renamed to PrintHeader.py
2529 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2530 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2531 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2532 * src/gdcm*.cxx JPR's bad inclusion fixed.
2534 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2536 * gdcmPython/demo/test.py changed accordingly.
2538 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2539 * gdcmPython/Makefile.am fixed linking against libstdc++
2540 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2541 * Swig subdir (historical tests of swig version 1.3.17++) removed
2542 * Test/testChangeEntete.cxx some lines commented out in order to make
2544 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2545 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2547 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2549 hence the user doesn't need this explicit call.
2550 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2551 i.e. LoadElements() call removed.
2552 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2553 - src/Makefile.am declares the proper flag for g++.
2554 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2555 for adding user defined new tags.
2556 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2557 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2558 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2560 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2561 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2562 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2563 src/Makefile.am : the project should properly compile and install
2564 with the autotools, included the python wrappers part.
2565 * gdcm.spec.in : added a spec file for RPM packaging.
2567 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2568 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2570 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2571 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2572 to exported to the environement (see gdcmPython/testSuite.py
2574 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2575 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2576 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2577 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2578 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2580 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2581 * gdcmPython/__init__.py doesn't crash anymore when running in
2582 in InstallMode or PreInstallMode but with an environement given
2583 value of GDCM_DICT_PATH.
2584 * src/gdcmDictSet.[cxx/h] coding style.
2586 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2587 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2588 * src/gdcm.h general comments moved to TODO, and README
2589 * src/gdcm.h should now be seen as a user commodity (including it
2590 should suffice to fully use gdcm). It is nowhere including within
2591 any of the kernel files src/*.cxx and src/*.h.
2593 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2594 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2595 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2597 * src/gdcm*.cxx only include their corresponding include file
2598 (as opposed to gdcm.h)
2599 * gdcmPython/gdcm.i changed accordingly
2600 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2601 the autogen.sh generated "make snapshot" command to work.
2602 * autogen.sh removed history related references to crea package.
2604 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * distutilsSwigCPlusPlus.py work around some swig portability
2608 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2609 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2610 was done in a last ditch attempt to get setup.py _really_
2611 operationnal. The python/gdcmPython layaout add the advantage
2612 of hidding away the python related distutils specific files
2613 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2614 Alas, the src directory was out of scope (i.e. it's relative
2615 position to setup.py was ../src) which made things impossible to
2616 handle (see previous version of python/setup.py). Crossing fingers...
2618 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * python/setup.py now works on Un*x. (harder than I thougth)
2620 * python/distutilsSwigCPlusPlus.py can now have include files
2621 among the list of sources.
2623 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2624 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2625 * modifications in MSVC projects
2627 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2628 * As stated by the first lines of Test/ExceptionAndPython/README, it
2629 looks like we can move back to original usage of exception within
2630 src/gdcm* and hence remove the errno stuff that was introduced
2631 as a quick and dirty fixture of this problem (added to the TODO).
2632 * Doc/Doxyfile configuration file for Doxygen and corresponding
2633 README file for usage added.
2634 * Test/testWrite.cxx added. This new test comes from a split of
2635 test.cxx that is now reverted to its original purpous i.e.
2636 testing the proper parsing of a Dicom related file.
2637 testWrite.cxx concentrates on testing the IO part of gdcm.
2638 * Test/bug1.cxx (containing a bug on WIn32) added.
2639 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2640 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2641 whose purpose is to publish the content of the TagNames of the
2642 Dicom public dictionnary were not accessible without an
2643 instance of class gdcmHeader.
2644 - those methods are now static methods of gdcmDictSet and hence
2645 require no instances at all to be invocated.
2646 - within gdcmDictSet this change required to change some method
2647 to class methods (i.e. are now static) among which SetDictPath
2648 (renamed to BuildDictPath) and LoadDefaultPubDict.
2649 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2650 the above changes by calling the new method classes of gdcmDictSet.
2651 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2652 the above to be effective.
2653 * python/gdcmPython: in order to wrap properly the above changes
2654 for Python, swig version now needs to be > 1.3.17.
2655 * python/gdcmPython/Makefile fixed to adapt itself to new
2656 configure/make shema introduced by Johan Montagnat (thanks for the
2657 contribution). Alas this Makefile cannot be turned into a proper
2658 Makefile.am without some heavy changes in the configure.in
2659 (for python dectection).
2660 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2661 now avoids publishing the empty entries.
2663 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2664 * python/setup.py : bug fix concerning install under windows
2665 ExtraPath reused :-P
2666 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2668 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2669 * Dicts/dicomV3.dic : remove double spaces !!!
2670 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2671 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2674 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2676 method. Doxygenation.
2677 * src/gdcm.h clean up of JPR spurious comments.
2679 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2680 * python/distutilsSwigCPlusPlus.py now properly collects the
2681 shadow classes generated by "swig -c++" (gdcm.py in our case)
2682 when using "python setup.py install".
2683 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2684 reexports the working classes.
2685 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2686 by the classical C errno scheme. This is to prevent an obscure
2687 behavior of the python wrappers when importing wxPython.wx prior
2688 to gdcmPython (which ended up in an abort call). An illustration
2689 of this oddity can be found in the Test/ExceptionAndPython
2690 subdir (see the README file). This problem probably due to
2691 an combination of g++ and dynamic loading.
2692 * added Test/ExceptionAndPython (see above)
2694 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2695 * Changed the layout of the python part to avoid bloating main
2696 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2697 i.e. the distutils arsenal. All the python related stuff is
2698 again in a python subdir, but the package itself is now in
2700 * setup.py was cleaned up:
2701 - pythonIncludePath removed
2702 - python setup.py bdist target is now functional.
2703 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2704 collision with other packages). gdcmPython/demo/*.py changed
2707 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * python subdir moved to gdcmPython (preparation of distutils packaging).
2709 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2710 distutils installer is operational.
2711 * - gdcmPython/__init__.py now properly loads the swig generated
2712 shadow classes (from gdcm.py).
2713 - gdcmPython/demo/*.py changed to import the package gdcmPython
2714 instead of gdcmPython/demo/load.py.
2715 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2717 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2719 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2720 entries within the associated public Dicom dictionary resp. the same
2721 information but sorted by the fourth field (PAT, IMG, DIR) of the
2723 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2724 are now in the "???" group.
2725 - python/gdcm.i changed accordingly,
2726 - python/demo/printGroupedPublicDict.py added, that gives an example
2727 of the above new functionalities in Python.
2729 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2730 * src/gdcm.h, gdcmHeader.cxx:
2731 - historic references to glib's g_malloc and g_free (#defined)
2732 were definitively removed.
2733 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2734 * src/gdcmElValSet.cxx:
2735 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2736 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2737 - GetElValue(string) renamed to GetElValueByName.
2738 - Added GetElementByName(string).
2739 * src/gdcmHeader.cxx: added
2740 - GetPubElValRepByNumber(guint16, guint16)
2741 - GetPubElValRepByName(string)
2742 - GetShaElValRepByNumber(guint16, guint16)
2743 - GetShaElValRepByName(string)
2744 - GetShaElValByNumber(guint16, guint16)
2745 - GetShaElValRepByName(string)
2746 - GetElValRepByNumber(guint16, guint16)
2747 - GetElValRepByName(string)
2748 - GetElValByNumber(guint16, guint16)
2749 - GetElValRepByName(string)
2750 * Doc/requirements.txt added.
2752 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * Test/Makefile building now depends on the one of libgdcm.so
2754 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2755 pixel data) aware which enables finding the address (offset) of
2756 the pixel data of JPEG encoded DICOM files. This leaves only a single
2757 file in the testSuite whose pixel data address (offset) is unknown.
2758 * python/testSuite.py changed accordingly.
2760 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2761 * VC++ has some strong limitations when working with the STL, as stated
2762 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2763 "Also note that some STL containers (map, set, queue, list, deque)
2764 cannot be exported. [...]
2765 Some STL classes contain nested classes. These classes can not
2767 This is caused by a designed limitation that once a template
2768 class is instantiated, it can not be re-instantiated and
2770 Since our usage of map<> is ubiquitous in gdcm, this "designed
2771 limitation" of VC++ is a pitfall.
2772 Hence the Python wrappers of gdcm cannot be incrementally linked
2773 against the c++ dynamic library. The dirty but only workaround is
2774 to forget about incremental link of dynamic libraries and to generate
2775 the Python wrappers library with the inclusions of the underlying C++
2777 The following modifications concern this matter on Win32/VC++:
2778 - wrapping python correct with standalone wrapped dll (don't use separate
2779 dll under windows !!!!)
2780 - python21_d debug mode enabled (ask Frog how to use it :-)
2781 - NO problem with having an STL member of class for example string in C++
2782 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2783 - Python test of dcmlib in Python is ok under windows on a large set
2785 * removed glib references
2786 * typedef's inserted in gdcm.i for correct swig type management
2788 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2789 * python/demo/*.py load.py extracted from test.py. Added explore.py
2790 that only displays required tags and testAll.py that parses all
2791 the files of the testsuite without using unittest.
2792 * python/testSuite.py other additional test on new files added.
2793 * Data/* new test files added accordingly to the testSuite.
2794 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2795 the vr in the file differs from the one of the dictionary.
2797 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2798 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2799 values, but limits itself to values which are below a user specified
2800 size (by default 1024 bytes).
2801 * python/gdcm.i : elements not loaded (because their size is above the
2802 user specified treshold) are exported with their TagKey as key of the
2803 python dictionary. This enables the testsuite to make some checks
2804 on the unloaded elements (since we have their offset and size).
2805 * python/testSuite.py
2806 - now tests for the existence and proper value of the pixel data
2807 - two new examples added.
2808 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2810 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2811 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2812 aware. See the strategy comments in gdcmHeader::FindeLength().
2813 * Test/test.cxx now accepts a filename as first argument.
2814 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2815 * python/testSuite.py changed to integrate test on above files.
2817 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2819 the vr was also RET.
2820 * python/testSuite.py more tests added.
2822 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * python/testSuite.py unittest test suite added (uses Data)
2824 * Data/* dcm and acr files for the test suite.
2825 * glib dependance removed from un*x version. We now use ISO C99
2826 7.18 Integer types (see stdint.h)
2827 - python/Makefile, src/Makefile src/gdcm.h
2828 * src/ when an explicit vr (like dicom files) suddenly poped an
2829 implicit element we use to mark the underlying DictEntry of the
2830 concerned ElValue with "Implicit". This strategy was damageable
2831 too the public or provite dictionaries, since some of their vr
2832 would be changed. Since Header::FindLength heavily relies on the
2833 detection by Header::FindVR of falsely explicit elements, I
2834 added an extra ImplicitVr member to ElValue (boolean).
2835 The rest of the changes we the necessary adaptations.
2837 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2838 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2840 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2842 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2843 * Adaptation for porting to VC++:
2845 o forced to use std namespace (for string to be known)
2846 o all class use __declspec export style on WIN32
2847 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2848 (in stdlib.h on Win32 but in std:: for gcc)
2849 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2850 variable GDCM_DICT_PATH.
2851 * src/gdcmHeader.cxx verbose comments made discrete.
2853 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2854 * python/gdcm.i: added a typemap that converts a C++ hashing table
2855 to native Python dictionary.
2856 * python/demo/test.py:
2857 - now uses the native dictionary for exploration of gdcmHeader.
2858 - takes an optional filename argument (the file to parse).
2859 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2860 PubElVals hashing table.
2861 * Dicts/dicomV3.dic removed error prone trailing spaces.
2863 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * Python wrapping process moved away from src/Makefile to
2865 newly created python/Makefile (as well as gdcm.i)
2866 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2867 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2868 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2869 from the environement variable GDCM_DICT_PATH (when existing).
2870 * src/gdcmDict::GetTag bug fix.
2872 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2873 * Straightforward temporary fixes for swig to build the python wrappers.
2874 src/Makefile now has a python working entry [by working we mean
2875 that we can import de shadow classes without errors].
2877 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2878 * hashtest.cxx removed (since allready in Test)
2879 * src/gdcmlib.h renamed to src/gdcm.h
2880 * src/dcm.i renamed to src/gdcm.i
2881 * src/Makefile prepared for python wrapping
2883 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2884 * src/gdcmHeader.cxx :
2885 - Parsing of header is now separated from loading of element values
2886 (see gdcmHeader::LoadElements).
2887 - general clean up of hopefully all file access (creation of
2888 ReadInt16 and ReadInt32)
2890 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2891 * src/gdcmHeader.cxx :
2892 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2894 - SetLgrElem renamed to SetLength
2895 - GetLgrElem renamed to GetLength
2896 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2897 * src/gdcmElValSet.cxx fixed both GetElValue methods
2898 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2899 due to IdoDude was cleaned out.
2901 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2902 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2903 concentrates on finding the value representation (when it exists).
2904 RecupLgr now only finds the element value length, and it avoids
2905 returning the unecessary skL (skipped length).
2906 Also, offsetCourant was simply removed (with taille_fich) since
2907 it was redundant with the File position internals (by using
2908 ftell and fseek). This also made skL (see above in RecupLgr) usage
2910 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2911 on the libido specificities which are handled through class
2913 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2916 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2917 * Truckload of changes. Parsing of header is barely functional
2918 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2920 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2921 * src/gdcmHeader.cxx many addons of low level methods
2923 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2924 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2925 and _IdDcmSWAP_LONG.
2927 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2928 * This corresponds to all the changes decided at the meeting of
2929 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob