1 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * ENH: Slightly bigger patch:
3 1. Getting toward full integration of JMR patch for writting dicom from scratch
4 2. Update Test to test part of this patch: CreateUniqueUID
5 3. File was not close properly in gdcmDict
6 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
7 5. Use of const ref instead of copy (speed issue)
8 6. Remove temporary (duplicate) string in TranslateToKey
9 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
10 8. Do not repeat virtual in subclasses
11 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
13 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
14 * Apply first patch toward better string comparison when dealing with broken
15 DICOM files. Essentially the string could be padded with a space instead
16 of a null character as defined by standard
18 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
20 because never used... and in the same time, that's remove some memory leaks
22 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmFile.cxx : now delete the PixelConvert instance.
24 * In examples and tests : change the type of image data variables from void*
25 to uint8_t*. Remmove all delete on image data variables
27 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
29 Verify the file pointer value before open the file, and if it's not null,
30 a verbose message is generated.
31 Close correctly the file when the file isn't considered dicom-like. The
32 correctly close is a call to CloseFile.
33 When closing the file pointer, test if its not null to close the file.
34 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
35 file. For an uncompressed image, the copied datas correspond in the least
36 case to the image size (calculated) or the image size specified in the
37 header. A verbose is generated if these two size mismatch
39 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
41 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
42 break under windows (with msvc6 compilation).
44 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
48 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * Bugs fix for the Windows build with VC6
50 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
51 needed (only for projects required VTK). If the VTK is included in all
52 projects, there is conflicts with the jpeg lib of vtk when compiling the
53 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
54 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
55 when compiling the gdcm_wrap.cxx file (created by the compilation of the
57 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
58 (like it's already made for the cout use). Otherwise, conflict with the
61 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
62 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
64 - comments on the DicomDir::Method related usage added.
65 - now that we use the namespace gdcm, a lot of internal classes do
66 NOT need to be wrapped anymore.
67 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
68 DicomDir::Method) new example added.
70 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
71 * Improve string manipulation. I now inforce the notion of 'DicomString'
72 A DicomString can contain as many \0 as they want
73 and it is *always* of even length.
74 We only support odd length for very rare case.
75 And in the near future this should be removed.
77 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
78 * /binary_write/ gdcm source. Now even on big endian we are writting
79 little endian. This should -heopfully- fix some tests
81 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
82 * Now the dictionary is compiled into gdcm lib. This is a default
83 behavior, thus any dic file specified is picked before failback to
84 the one comiled into lib
86 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
87 * Change internals for gdcmDict. Don't use any 'new' any more.
88 This should definitely solve any leak problem, and we should be
89 as fast as before, as long as don't modify too much the dictionary.
91 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
92 * STYLE: ivars should start with a capital letter.
93 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
94 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
96 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
97 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
98 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
99 new 2004 dictionaries added (thanks to JPR).
100 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
101 * CLEANUP_ROUND (15) for gdcmPixelConvert
102 - RLEFrame::NumberFragments is now of type unsigned int
103 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
104 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
107 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * Initial work in gathering all transfer syntax accessors. clearly
109 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
110 ivars, but only one transfersyntax (class) ivar with equivalent method on
113 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
114 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
115 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
116 discussed (plus I didn't like having a 2000 lines patch not commited)
118 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
119 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
120 * CLEANUP_ROUND (14) for gdcmPixelConvert
121 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
122 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
123 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
125 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
126 anymore and hence avoids storing a copy of PixelConvert::Decompressed
127 into File::Pixel_Data.
129 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
130 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
131 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
132 * CLEANUP_ROUND (13) for gdcmPixelConvert
133 Substituted File::ParsePixelData() with PixelConvert::Print() new
135 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
136 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
137 method to those classes.
138 - src/gdcmFile.[cxx|h]:
139 -- Added a ::Print() method.
140 -- PixelConverter is now a reference instead of a member.
141 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
142 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
144 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
145 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
146 collaboration diagram and inheritance diagram should be generated with
148 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
149 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
150 pointlessly wrapped (see
151 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
152 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
153 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
154 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
155 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
156 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
157 -- File::Initialise: PixelConverter setup moved away to
158 PixelConverter::GrabInformationsFromHeader()
159 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
160 interpretation moved away to PixelConverter::BuildRGBImage()
162 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
163 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
164 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
166 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
167 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
168 displayed on Win32 when a brutal abort() occurs (because of uncatched
169 exception). See TODO new entry of this commit for more on this.
170 * TODO added new entry.
171 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
172 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
173 - HandleColor is no longer called from gdcmFile.cxx
174 - gdcmPixelConvert.cxx clean up on method arguments and internal
175 variable names for semantical coherence.
177 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
178 * Finished lossless transition, not only do we now read all lossless jpeg
179 images, without the need of the Cornwell lib, but we do read them properly now
180 * To reduce code (well to avoid code duplication), I defined a common place
181 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
182 redefine symbols. This is not prefect but this the best solution I found for a
183 compilation time jpeg option.
185 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
186 * Update jpeg ijg lib to support lossless jpeg implementation
187 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
189 * Also added a special copyright for dcmtk since we use their bugfixes.
192 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
193 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
194 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
195 matters, as stated in warning note at begining of %include section).
196 * src/gdcmDicomDir*.[cxx|h]: coding style
197 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
198 * src/gdcmJpeg8.cxx: doxygen fix.
199 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
200 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
201 from File:: to PixelConvert::.
203 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
204 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
205 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
206 - more code moved away from File:: to PixelConvert::
207 - fat setup of PixelConverter set in place in File::Initialise.
209 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
210 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
211 namespace at the file system level. So now you should convert your examples
213 gdcmHeader -> gdcm::Header
214 It would be nice if people keep in mind to no open the namespace, since it
215 allows compilation on broken plateform which were defining common symbol in
216 the standart namespace (like LP, Unknown ...)
218 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
219 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
220 The JPEG fragments are now parsed at the same stage than the RLE
221 information. All code related to JPEG is now in gdcmPixelConvert:
222 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
223 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
224 export a gdcmFile:: method. Those are simply global functions
225 (for the time being this is better than having them attach to
226 either gdcmFile:: or gdcmPixelConvert::).
227 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
228 and stores the result in a gdcmJPEGFragmentsInfo.
229 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
230 code (among other stuff) moved away from gdcmFile:; to
233 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
234 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
235 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
236 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
237 clean up of RLE related code.
238 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
239 - src/gdcmRLE.cxx removed
240 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
241 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
242 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
243 * CLEANUP_ROUND (9) for gdcmPixelConvert
244 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
245 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
246 away from gdcmFile:: to gdcmPixelConvert::.
248 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
249 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
250 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
251 This is because Parse7Fe0 used to parse the pixels to compute the
252 length. This task was passed over to FindDocEntryLengthOB() a long
253 time ago, EXCEPT I had forgotten the OW case...
254 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
255 we just recylce the code for parsing RLE fragments and computing
257 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
258 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
259 with the retired Parse7Fe0().
260 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
261 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
263 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
265 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
266 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
267 - src/CMakeLists.txt: alphabetic order reodering + new entries.
268 * CLEANUP_ROUND (4) for gdcmPixelConvert
269 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
270 to return an unused length.
272 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
273 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
274 this should be cleanner from the plane view. The iostream are erally a pain
275 to use to do simple stuff.
277 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
278 * Redo the compilation of the ijg jpeg library. Now only one source is
279 necesseray. No need to rename file by hand what so ever. CMake handle the
280 copying of the file within different directory, configure header file to
281 modify some symbol. The only addition made to ijg wasd a mangle table so
282 that symbol are different wether we are within 8bits or 12bits.
284 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * Added documentation of vtkgdcmReader on Website:
286 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
287 with it's binary name).
288 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
289 the Website to be more complete.
290 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
291 doxygenated documentation.
292 - Doc/DoxyVtkGdcmReaderExamples.txt added
293 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
294 DoxyVtkGdmReaderExamples.html )
295 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
296 * CLEANUP_ROUND (3) for gdcmPixelConvert
297 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
299 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * CLEANUP_ROUND (2) for gdcmPixelConvert
301 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
303 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
304 * CLEANUP_ROUND for gdcmPixelConvert:
305 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
306 - src/gdcmPixelStuff[h|cxx] removed
307 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
308 - src/CMakeLists.txt changed accordingly
310 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
311 gdcmVersion.py moved to newly created ATTIC related
312 gdcmPython/SetupOldies/ directory.
313 * Autotools clean up:
314 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
315 - autogen.sh configure.in acinclude.m4 python.m4 removed
317 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * src/*.cxx *.h Reference to License.htm fixed to License.html.
319 * Doc/CMakeLists.txt, doxygen.config.in: fix.
320 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
322 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
323 * TODO updated with Mathieu suggestions. I proposed a template for
324 describing TODO entries and used it for new entries.
325 * Added Doc/Website/CodingStyle.html, Developpers.html,
326 DeveloppersPython.html, GdcmDataCvs.html and
327 DownloadVersion0_1.html, DownloadVersion0_3.html.
328 * Some Doc/*.txt Doxygen files (which do not really concern the
329 documentation itself, but the website) moved to html and
330 placed in directory Doc/Website:
331 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
332 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
333 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
334 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
335 * CMakeLists.txt changed accordingly.
336 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
337 DeveloppersPython.html
338 * INSTALL nows refers to Doc/Website/Installation.html
340 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * Added Doc/Website directory, that contains a first raw version
344 2004-09-23 Jean-Pierre Roux
345 * FIX In order not to be poluted any longer by casting problems,
346 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
347 we can now delete[] it safely
348 * VoidArea is now called BinArea (less confusing name),
349 and all the methods called ...VoidArea... are now ... BinArea...
350 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
352 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
353 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
354 clear) TagHT, which is an inherited member of gdcmElementSet. It is
355 up to the destructor of gdcmElementSet to clean up TagHt and it's
358 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * Test/CMakeLists.txt: update to follow gdcmData renamings.
360 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
362 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
363 * ENH: added some utility method that builds a flat dictionnary
364 holding all the Dicom entries contained in the recursive structure
365 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
367 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
368 BuildFlatHashTable() that build a flat dictionary.
369 - src/gdcmElementSet.h: added a new private GetTag() accessor.
370 gdcmDocument is now a friend of gdcmElementSet.
371 - src/gdcmElementSet.cxx: clean up.
372 - Example/FlatHashTablePrint.cxx added.
373 - Example/CmakeLists.txt changed accordingly
375 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
376 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
377 moved away from gdcmDocEntrySet (since this class is an abstract class
378 acting like an interface). SQDepthLevel and BaseTagKey are now
380 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
381 and associated accessors. Doxygenation of the class.
382 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
384 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
385 Use SQDepthLevel accessor instead. ::Print() adapted.
386 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
387 - src/gdcmDocument.cxx changed accordingly.
389 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
390 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
391 - The following is the doxygen comment of the typedef declaration
392 of gdcmagKey in src/gdcmCommon.h:
393 gdcmTagKey is made to old an "universal" (as in URL, Universal
394 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
395 A dicom tag allways has a group and an element, but a set of tags
396 embeded in various (optionally nested) sequences and sharing
397 the same group and element all share the same (group, element)
398 "identifier". Hence the (group, element) cannot be used as an
399 identifier (in gdcm we shall refer to a "TagKey") of a tag.
400 In order to construct a proper tag identifier (i.e. a key) we
401 consider the following definition of a TagKey:
402 - let Group, Element be the string representation of the
403 group and element dicom tag members,
404 - let ItemNumber be the string representation of the integer
405 index of the considered item number of a sequence,
406 Let the key of a tag embeded in a sequence, noted SeqTag, be
408 /ItemNumber#Group|Element
409 where "/", "#" and "|" are characters acting as separators.
410 Then the general form of a gdcmTagKey is given by:
411 Group|Element<SeqTag>
412 where <SeqTag> means NO or many instances of SeqTag.
413 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
416 but the gdcmTagKey of a tag "embeded" is the first item of
417 a sequence, itself nested in the third item of a sequence is the
419 0004|1220/2#0008|0082/0#0008|0090
420 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
421 order to hold the new sequence compatible key. Previously, the
422 GetKey() method would look in the underlying gdcmDictEntry.
423 - src/gdcmDocEntry.cxx:
424 -- constructor now copies the underlying DictEntry key, in the local
426 -- ::Print: displays the member Key, instead of the (group, element).
427 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
428 - src/gdcmDocEntrySet.h:xi
429 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
430 -- now has a new BaseTagKey member.
432 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
433 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
435 This poses the problem with the semantics of the following lines
436 LoadEntryVoidArea(0x0028,0x1201); // R LUT
437 LoadEntryVoidArea(0x0028,0x1202); // G LUT
438 LoadEntryVoidArea(0x0028,0x1203); // B LUT
439 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
440 to the long FIXME note for what the problem is. Nevertheless in
441 order to get things working the dicom dictionary was altered !
442 Please fix things urgently...
443 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
444 information), see above note on moving the member VoidArea. Nevertheless
445 the following entries previously correctly set as US are now inproperly
447 0028 1201 OW IMG Red Palette Color Lookup Table Data
448 0028 1202 OW IMG Green Palette Color Lookup Table Data
449 0028 1203 OW IMG Blue Palette Color Lookup Table Data
450 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
451 of gdcmDocEntry moved to gdcmSeqEntry.
452 * src/gdcmSeqEntry.cxx: STYLE.
454 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
455 * Test/TestAllEntryVerify.cxx minor fix and added comments.
457 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * gdcmPython/testSuite.py: all the test suite in python is now moved
459 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
460 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
461 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
463 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
465 to avoid inclusion recursion until STL is reached.
466 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
467 mecanism. errno.h is not included in gdcm anymore.
468 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
469 (gdcmFormatError now inherits from gdcmFormatUnexpected).
471 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
472 gdcmData/TestAllEntryVerifyReference.txt
473 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
474 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
475 exception_on_error parameter.
476 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
477 - vtk/vtkGdcmReader.cxx changed accordingly,
478 - Example/*.cxx and Test/*.cxx changed accordingly.
480 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
481 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
482 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
483 enable_sequences removed from gdcmHeader constructor and dependencies.
484 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
485 * gdcmPython/demo/PrintHeader.py: dummy fix.
486 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
487 skip_shadow removed from gdcmHeader constructor and dependencies.
488 * Example/*.cxx and Test/*.cxx changed accordingly.
490 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
491 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
492 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
494 2004-07-21 Jean-Pierre Roux
495 * FIX Now, Parsing and Printing a DICOMDIR do work!
496 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
498 2004-07-20 Jean-Pierre Roux
499 * FIX Some brain damaged headers have Zero-Lenght fields
500 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
502 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
503 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
504 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
505 variable (instance of gdcmDebug) by a definition macro, and the instance
506 is now in static in the gdcmDebug class
507 * src/gdcmSQItem.h : (FIXME) remove an undefined method
508 * Test/PrintAllDocument.cxx : bug fix in the result of the test
510 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
511 * WARNING: ctest now depends more tightly on gdcmData. You should
512 check out gdcmData properly for things to run smoothly...
513 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
514 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
515 we need the pixels not be loaded in order to use the ValEntry
516 that displays position and size).
517 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
518 This is a C++ based equivalent of gdcmPython/testSuite.py that should
519 be deprecated. If you have any doubts about the advantages of a
520 modern scripting language (read Python) versus grass root C++ (i.e.
521 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
522 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
523 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
524 Anyhow, consider documenting the gdcmData images in
525 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
527 * Test/CMakeLists.txt:
528 - now uses TestAllEntryVerify.cxx
529 - specific comments on oldACR00001.ima (now renamed in gdcmData
530 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
531 gdcmData/TestAllEntryVerifyReference.txt
534 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
535 * src/*.[h|cxx] : typedef clean up
536 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
537 - TagKey renamed to gdcmTagKey (for external usage)
538 - VRKey renamed to gdcmVRKey (for external usage)
539 - removal of typedef duplication.
540 - Removed all unecessary inline keyword from class inline definitions.
541 - Some method|function(void) declarations replaced with method|function().
542 * src/jpeg/libijg12/jdhuff12.c:
543 - printf polluting ctest removed.
544 - TAB removal for comminting
546 - TestAllReadCompareDicom.cxx: added a test that compares all the
547 images in gdcmDataImages.h with corresponding images in
548 gdcmData/BaselineDicom/. When baseline images are not present
549 this test creates them.
550 Note: we need to validate each reference image, but before that
551 I'd like to rename them with a more explicit name...
552 - CMakeLists.txt: changed accordingly.
553 * Example/*.cxx: examples now only include gdcm.h (as opposed to
554 including each header needed).
556 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
557 * Test/*.cxx and Example/*.cxx: moved some examples away from the
558 test suite to the Example directory. Are concerned:
563 - TestWriteSimple.cxx
564 * Test/CMakeLists.txt: added some comments on reasons for black listing
565 image gdcmData/oldACR00001.ima
567 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * Test/CmakeList.txt: removed the following from black list (to be coherent
569 with removal from gdcmData):
570 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
571 - gdcm-MR-PHILIPS-16.dcm
573 Added the following because after last cvs update, they cause
574 ctest -R TestReadWriteReadCompare
576 - gdcm-MR-SIEMENS-16-1.acr
578 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
579 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
580 new comments in this file) we temporarily (sigh) move to a weaker
582 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
583 we don't need to black list the following images anymore:
584 - 8BitsUncompressedColor.dcm
586 - US-PAL-8-10x-echo.dcm
587 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
588 fixes and the beautified code ;-)
589 This fixes the bug introduced in version 1.42 (when beautifying)
590 that made the parsing of 8BitsRunLengthColor.dcm unproper.
591 Note: ctest was blind to this bug (this means we need to still
592 improve the test suite). The bug could be detected by using
593 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
595 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
596 and by displaying the (garbage) produced file temp.XDCM...
598 2004-06-29 Jean-Pierre Roux
599 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
600 - replace by uggly but working old code :-(
601 A lot of things should be OK again.
602 It's really urgent to have a test suite that *tests*,
603 to prevent Frog's beautifying sessions to break all the stuff
604 (twice, withing a fortnigh ...)
606 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
608 redundancy) to added Test/TestReadWriteReadCompare.cxx
609 * Test/CmakeList.txt: because the compare test of
610 Test/TestReadWriteReadCompare.cxx fails, the following images are
611 black listed: - 8BitsUncompressedColor.dcm
613 - US-PAL-8-10x-echo.dcm
614 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
615 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
616 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
617 and ad-hoc kludge. This kludge is now removed, and on encountering
618 such an image (OB field brain damaged) we set errno. Then in
619 ::FindDocLength() we "fix" the length as being ALL what remains
620 in the file (until EOF). We then proceed, hoping for the best...
621 This fixes a SegFault in ShowDicom when trying to write such an
623 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
624 (because TestWriteRead breaks on it, after a non conformal commit?).
625 ctest now runs properly, except for MakeDicomDir (which was allways
626 broken) and the Python related stuff (still not fixed).
628 2004-06-24 Jean-Pierre Roux
629 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
630 FIX : Test/TestReadWrite now iterates on all the file names
631 (instead of infinite loop)
632 ENH : Test/TestWriteRead now iterates on all the file names
634 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
637 2004-06-24 Jean-Pierre Roux
638 FIX : - now Write drops LUT Descriptors and LUTs (if any)
639 when SamplesPerPixel =3
640 - now Write is no longer confused by
641 'BitsAllocated = 12" and 'BitsStored=12"
642 - "UN" value representation Elements are now written correctly
643 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
644 ENH : - now gdcmHeader has its own Write methods
645 (in order to split the job that has not to be done
648 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
649 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
650 loop on the same image until memory went out.
651 Note: this means we still have gobs of memory loss in PrintDocument
652 * src/gdcmDocument.cxx: fixes problem on parsing on file
653 gdcmData/16BitsJpegLosslessGrayScale.dcm.
655 2004-06-24 Jean-Pierre Roux
656 FIX : Write - All the Sequences and Sequence Item are now written
657 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
658 is added a the end, when necessary.
659 - A lot of brain-damaged images, that were read correctly are
660 now written correctly
661 - length compatible BinEntry are now loaded correctly
662 (even for odd groups)
663 Note : only Explicit Value Representation was checked.
664 (question : is implicit VR really necessary for gdcm ?)
666 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
667 * DEVELOPPER: added a proposition of coding style.
668 * src/gdcmDocEntry.h: removed every inline declaration (for test of
671 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
673 Use the gdcmDocEntry::Print() and Write() instead.
674 * src/gdcmDocument.cxx: bug fix.
676 2004-06-22 Jean-Pierre Roux
677 FIX : gdcmDocument.cxx
678 - Now we do recognize the JpegLossLess format (there was a misstyping in
679 code 'beautyfication' :-(
680 - Now we automaticaticaly load the Luts, if any
682 2004-06-22 Jean-Pierre Roux
683 In order : to write Sequences, whatever their imbrication level,
684 : to allow user to create his own Sequences
685 a lot of modif where necessary (adding, moving, or virtualising methods)
687 WARNING : save your own sources *before* cvs up !
690 ADD virtual void Write(FILE *fp, FileType filetype);
693 ADD virtual void Write(FILE *fp, FileType filetype);
694 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
697 ADD virtual void Write (FILE *fp, FileType filetype)=0;
698 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
699 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
700 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
701 ADD std::string GetEntryByName(TagName name);
702 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
704 std::string vr = "unkn",
705 std::string fourth = "unkn",
706 std::string name = "unkn");
707 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
708 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
709 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
710 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
711 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
712 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
713 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
714 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
717 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
718 ADD virtual std::string GetEntryByName (TagName tagName);
719 ADD virtual std::string GetEntryVRByName (TagName tagName);
720 REM virtual bool Write(FILE *, FileType);
721 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
722 FILE *_fp, FileType type);
723 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
724 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
725 REM virtual bool WriteEntries(FILE *_fp,FileType type);
726 REM virtual std::string GetEntryByName (std::string tagName);
727 REM virtual std::string GetEntryVRByName (std::string tagName);
728 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
729 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
730 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
732 std::string vr = "unkn",
733 std::string fourth = "unkn",
734 std::string name = "unkn");
735 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
736 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
737 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
738 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
741 ADD virtual void Write(FILE *fp, FileType filetype);
744 ADD virtual void Write(FILE *fp,FileType filetype);
747 ADD virtual void Write(FILE *fp, FileType filetype);
748 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
749 REM std::string GetEntryByNumber(guint16 group, guint16 element);
750 REM std::string GetEntryByName(TagName name);
753 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
755 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
757 The default constructor invoked by the line
758 gdcmHeader *f1 = new gdcmHeader( header );
759 was gdcmHeader::gdcmHeader(bool) instead of the expected
760 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
761 Hence the parsing wasn't executed... See also below.
762 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
763 as explicit constructor didn't do the trick to fix the above problem.
764 Could anyone explain why ?
765 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
766 properly calls gdcmValEntry::Print() (that was weed out from
767 code related to gdcmBinEntry).
769 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
770 * In order to fix memory leaks:
771 - Test/TestWriteSimple.cxx: added cleaning of free store through
773 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
774 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
775 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
776 (through the call to ::AddDicomDirMeta()) or the destructor
777 would crash when deleting uninitialized ::metaElems].
778 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
779 - src/gdcmDocument.cxx:
780 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
782 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
783 was causing memory leaks.
784 - src/gdcmSQItem.cxx:
785 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
786 cleanly handled with polymophism: sorry but my milage is low).
787 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
788 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
789 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
790 This avoids SegFaulting.
791 - src/gdcmSQItem.h: coding style.
793 - Test/TestWriteSimple still severely sucks. The output image content
794 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
795 damaged when displayed with vtkgdcmViewer.
796 - on memory leaks: TestWriteSimple leaks really less (see entry
797 of 2004-06-18 in Changelog file for the call to valgrind).
798 - on segfaults: ctest now passes all the tests but one (no more
800 * Erroneous leading white fix:
801 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
802 white[s] (as opposed to from >> xxx, that removes it [them].
803 - src/gdcmTS.cxx: ditto.
804 - gdcmPython/testSuite.py: dirty related kludge removed.
805 * src/*: remaining references to gdcmParser removed.
806 * src/*[cxx|h]: added copy[way]left header.
809 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * In order to fix writing of dicom files:
811 - Test/TestWriteSimple.cxx: a simpler example of writing.
812 - Test/CMakeLists.txt changed accordingly.
813 - src/gdcmDocument.cxx:
814 -- The destructor now recursilvely removes potential sequences.
815 -- Bug fix in ::IsJPEG2000()
816 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
817 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
819 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
820 to only declared) and build on top of
821 ::GetDocEntryByNumber(guint16, guint16).
822 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
823 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
824 for usage in destructor and treatement of promotion in
825 ::ReplaceOrCreateByNumber().
826 - src/gdcmSQItem.cxx: destructor should better handle his job.
827 Test/TestWriteSimple now runs (or at least it DOES something).
828 * We can now start hutting memory links. A good starting point is:
829 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
830 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
831 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
833 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
834 * Valgrind note: after Mathieu Malaterre teached me how to read
835 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
837 Using gcc, you can force the STL to use malloc and to free memory as
838 soon as possible by globally disabling memory caching.
839 With 3.2.2 and later, you should export the environment variable
840 GLIBCPP_FORCE_NEW before running your program.
841 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
842 simply vanish (it is still not clear to me, whether this means that
843 STL std::string leaks or if valgrind believes it leaks...).
844 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
845 running bin/gdcmTests makeDicomDir):
846 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
847 - Test/makeDicomDir.cxx now properly traps empty lists and returns
849 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
850 SegFaulting (I drowned in DicomDir related code when trying to
851 understand why the list is empty...).
852 * src/gdcmDocument.h: first BSD license header try.
853 * Doc/License.txt added.
855 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * src/gdcmDocument.[h|cxx]:
857 - Clean up of the Transfer related predicates. They are now all based
858 on new method isGivenTransferSyntax, that (should) handle properly
860 - general clean up, simplification, and coding style.
861 - Specific clean up of Parse7FE0() (umproperly named actually).
862 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
864 2004-06-14 Jean-Pierre Roux
866 - fix the display of Sequence Delimitor (SQDepthLevel pb)
867 - fix the display of SQItem ordinal number
868 - add the GetSQItemByOrdinalNumber method
869 - remove some useless never written private methods
871 2004-06-14 Jean-Pierre Roux
873 - adding a constructor taking a gdcmDocEntry as an input param
874 - ReplaceOrCreateByNumber now returns :
875 a gdcmBinEntry * if a Binary (void *) value is passed as a param
876 a gdcmValEntry * if a string value is passed as a param
878 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
879 according to the param type (no longer sets a gdcmDocEntry)
880 - GetValEntryByNumber, GetBinEntryByNumber added
881 - NewValEntryByNumber and NewBinEntryByNumber added
883 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
885 - GetSQItemNumber and SetSQItemNumber added, to provide
886 a (relative) Item identier inside a given Sequence
887 \warning : some pb remaining around this number
889 - AddEntry now takes the Item Number as a param
891 - adding a constructor taking a gdcmDocEntry as an input param
893 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
894 * Memory leak hunt with the following command:
895 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
896 --show-reachable=yes gdcmTests PrintDocument
897 It looks like many (all?) leaks are due to the STL (or a bad usage
898 of the STL. The lines producing the leaks now have a comment with
899 a "MEMORY LEAK" tag: you can retrieve them with
900 grep "MEMORY LEAK" src/*
901 Here are two typical examples which I can't help fixing:
906 char * test = "babo";
907 name = test; //// <--- valgrind detects 960 bytes lost in
908 //// call to std::string::operator=(char const*)
909 name.clear(); //// Doesn't help !
917 std::cout << "Type a bunch of characters followed by RETURN: ";
918 getline(std::cin, line); //// <--- valgrind dectects a loss
919 //// of 1320 bytes in call to
920 /// std::basic_istream<>& std::getline<>
926 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
927 * src/gdcmHeader.[cxx|h]:
928 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
929 and related, moved away to gdcmDocument.
930 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
931 the corresponding protected accessors of inherited class
932 gdcmDocument, removed ! As a consequence gdcmFile had to be
933 declared friend of class gdcmDocument (see below).
934 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
935 - Clean up of undefined or unused methods.
936 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
937 account the changes to gdcmHeader.h).
938 * src/gdcmDocument.h:
939 - gdcmFile is now a friend class (in order to take into account the
940 changes to gdcmHeader.h).
941 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
942 (see changes to gdcmHeader.h).
943 - Accessors (reading on the form GetEntry*) are now public.
944 - Clean up of undefined or unused methods.
945 * src/gdcmDocument.cxx:
946 - adaptation to changes to gdcmDocument.h
947 - ::OpenFile now writes a verbose message when file cannot be opened.
948 - some std::string properly set to VRKey
949 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
950 references to gdcmDocument.
951 * Test/TestFindTags.cxx: changed accordingly to above changes.
952 * gdcmPython/testSuite.py: adapted to renaming of acr files in
953 cvs repository gdcmData.
955 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
956 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
957 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
958 conflicts with gdcmValEntry::voidArea.
959 * src/gdcmValEntry.cxx: unmatching comment wiped out.
960 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
961 Value representation between StringRepresentable and BinaryRepresentable.
962 * src/gdcmDocument.cxx:
963 - method ParseDES: proper indentation restored and usage of
964 gdcmVR::IsVROfGdcmStringRepresentable wired in.
965 - method LoadDocEntry: the fingerprint left in the SetValue() of
966 unloaded entries (length > MaxSizeLoadEntry) had curiously been
967 removed. Reverting to previous code segment with the proper
968 dynamic_cast< gdcmValEntry* >.
969 Note: this was (partially) breaking the python test suite
970 (gdcmPython/testSuite.py) that made usage of the above
971 fingerprint to check presence of "Pixel Data".
972 * src/gdcmDocEntry.h: coding style.
973 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
974 now taken into account.
975 * gdcmPython/gdcm.i: adaptation to the new internal representation
976 of gdcm (exit gdcmParser, hello gdcmDocument).
977 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
979 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
980 anymore, but instead prints the loaded Python dictionary.
981 * .... alas, the python testSuite is still broken.
983 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
984 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
986 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
987 * src/gdcmUtil.h : export methods
989 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
990 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
992 * Initial addition of automatic python testing
993 * Initial addition of automatic image comparison
995 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
996 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
997 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
999 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1000 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1001 * Test/ShowDicom.cxx : bug fix for msvc compilation
1002 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1004 2004-05-04 Jean-Pierre Roux
1005 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1006 new concepts (and new classes) :
1007 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1008 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1009 - Sequence Doc Entries (gdcmSeqEntries)
1010 a Sequence is composed of Items.
1011 Each item is a set of Doc Entries (this is recursive)
1012 The non uniqueness of the 'Dicom tag' is due to this recursivity
1013 (never taken into account)
1014 Our unability to add a new 'entry' in the header
1015 at the proper location (neither in the H-Table (map or multimap),
1016 nor in the Chained List is also due to this recursivity.
1017 Don't try, right now, to use/modify/compile these new sources :
1018 nothing is finished.
1019 We just commit all the stuff, 'as is', in order not to loose it.
1021 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1022 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1024 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1025 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1026 file prefix (SetFilePrefix)
1028 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1029 * Add a new test: ShowDicom, for now this is just the c++ version of
1030 checkRead.sh, later it will be able to compare the image read against a
1032 * Replace the DEBUG on the stack with a global entry in cmake interface:
1033 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1035 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1036 * Add an example subdir, with a real example on how to read + write a
1039 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1041 * Doc/CMakeLists.txt: the main page is now properly differentiated
1042 between the developper and user version.
1043 * Doc/doxygen.config.in: dropped search related obsolete flags
1044 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1046 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1047 * DEVELOPPER: added some helpfull comments for compile/test/install
1050 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1051 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1052 src directory, now generated in the build dir.
1053 2. Tests as mentionned smarter
1055 4. Add a new method in gdcmDict that return the PubDict by name
1056 this is interesting for 3rd party lib like ITK,
1057 where we could set the institution name / patient name...
1059 * ENH: 1. Now the test suite is working for real
1060 2. All binaries are now output in the gdcm-bin directory
1061 (this was not true before)
1063 2004-04-28 Jean-Pierre Roux
1064 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1065 SeQuence indented printing of Dicom Header.
1066 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1067 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1068 Computation of SQDepthLevel is now part of gdcmHeader constructor
1069 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1070 tree-like structure of a Dicom Header.
1071 * FIX Test code cleaning
1073 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1074 * ENH: Adding automatic testing
1075 1. Need a DartConfig.cmake to submit to public
1076 2. Add a test driver gdcmTest.cxx
1077 3. gdcmTestMain, an helper for the main test driver gdcmTest
1078 4. Files in Test don't have a main anymore, this becomes interesting
1079 when we add more and more tests, thus dsw don't have to load
1081 * ENH: Adding a GDCM_DATA_ROOT for testing
1082 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1083 one file instead of seven + some small cleanup
1085 2004-04-22 Jean-Pierre Roux
1086 * ENH Minor changes to the Print() methods.
1087 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1088 Header printing. Example given with :
1089 > PrintHeader fileName 2 new
1090 (SQ based tree-like structure still to be done for the Header ...)
1092 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1093 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1094 1. I have added some unsigned where needed
1095 2. Some function parameter not used -> (void)
1096 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1097 4. g++ don't like character '\' in comment
1098 5. #define jpeg_create_decompress jCreaDecompress
1099 this really need to be fixed
1100 6. virtualize destructor of gdcmObject ... leakage
1101 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1102 this also really need to be fixed
1103 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1104 remove compression file
1105 (as we only do decompression, right ?)
1106 * ENH: Change malloc/calloc/free with c++ equivalent
1108 2004-04-21 Jean-Pierre Roux
1109 * FIX gdcmHeaderHelper::GetXSpacing
1110 when a single value is found (bug ?), xpacing is now
1111 defaulted to yspacing
1113 2004-04-19 Jean-Pierre Roux
1114 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1115 * ENH add parameters :
1116 bool exception_on_error = false,
1117 bool enable_sequences = false,
1118 bool ignore_shadow = false
1119 to the gdcmFile constructors to be full gdcmParser compliant
1120 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1121 to allow reading of PAPYRUS 3.0 files
1123 2004-04-06 Jean-Pierre Roux
1124 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1126 2004-04-02 Jean-Pierre Roux
1127 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1128 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1129 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1131 2004-03-30 Jean-Pierre Roux
1132 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1133 for ACR file, written out as DICOM files (hope so...)
1135 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1136 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1137 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1138 moved to base class gdcmParser and only the specialisation is kept
1140 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1141 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1142 already does the job.
1143 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1144 (to be consistent with gdcmParser::WriteEntries).
1146 2004-03-30 Benoit Regrain
1147 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1148 upate of the object's instance. It's passed to 2 in the unfavorable
1149 case : one in the ExecuteInformation, one in the ExecuteData
1151 2004-03-29 Jean-Pierre Roux
1152 * ENH : Check on file type to be written moved
1153 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1154 * FIX : gdcmObject::ResetBoundaries now stops properly
1155 when end-of-list is reached
1156 : gdcmVersion modified (as Benoit Regrain asked)
1158 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1159 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1160 * src/gdcmUtil.cxx: added forgotten iostream include.
1161 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1162 equivalent to ExplicitVR in existing code).
1164 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1165 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1166 now contains all the gdcmGlobal related code.
1167 * minor coding style and doxygenation changes.
1169 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1170 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1171 now contains all the Debug related code.
1172 * minor clean-up of includes in src/*.cxx
1173 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1174 CreateCleanString) removed.
1175 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1176 * Doc/DoxyMainPageUser.txt added.
1177 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1178 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1179 src/gdcmDirList.cxx)
1181 2004-03-24 Jean-Pierre Roux
1182 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1184 2004-03-23 Jean-Pierre Roux
1185 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1186 big endian made volumes
1187 * ENH Now gdcmParser constructor and destructor are protected to forbid
1188 end user to instanciate class gdcmParser
1189 (only gdcmHeader and gdcmDicomDir are meaningfull)
1191 2004-03-22 Benoit Regrain
1192 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1193 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1194 gdcmSerie to gdcmDicomDirSerie
1196 2004-03-19 Jean-Pierre Roux
1197 * ENH Now the tree-like structure describing a DICOMDIR comming from
1198 an already existing DICOMDIR file is consistent with
1199 the home-made tree-like structure build ex-nihilo
1200 or build from the files held (recursively) in a Directory
1201 functions gdcmDicomDir::CheckBoundaries()
1202 gdcmObject::SetBoundaries() added
1204 2004-03-17 Jean-Pierre Roux
1205 * REM (Eric Boix bug) : removal of meaningless
1206 gdcmDicomDirImage::NewImage function.
1207 * FIX now file names and directory name are written properly in the
1209 * FIX now gdcmDicomDir constructor may be call without any trick
1212 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1214 of gdcmDicomDirImage::NewImage as empty function.
1216 2004-02-28 Jean-Pierre Roux
1217 * ENH add gdcmDicomDir:NewPatient
1218 add gdcmDicomDirPatient:NewStudy
1219 add gdcmDicomDirStudy:NewSerie
1220 add gdcmDicomDirSerie:NewImage
1221 to allow making gdcDicomDir object.
1222 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1223 (as opposite to the gdcmHeader chained list)
1225 2004-02-11 Benoit Regrain
1226 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1227 when using from python
1229 2004-02-10 Benoit Regrain
1230 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1231 * FIX : in gdcmDicomDir when the directory is empty
1232 * ENH : add callback and methods to get the progression of dicomDir
1235 2004-02-06 Jean-Pierre Roux
1236 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1237 - GDCM_META added to gdcmDicomDirType
1238 - class gdcmMeta created
1239 * ENH : - A brief summary is now displayed at the beginning of
1240 'testDicomDir' to help disaster magnitude estimation
1241 * REM : Now useless Test/explDICOMDIR.cxx
1243 2004-02-05 Benoit Regrain
1244 * ENH : add methods in gdcmObject to get the hash table or the list of
1246 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1247 * FIX : wrapping python for TagHeaderEntryHT
1249 2004-02-04 Benoit Regrain
1250 * FIX : even length for some strings when writting the dicom dir
1251 * FIX : sort the images in the dicom dir
1252 * FIX : Bug fix for python use of dicom dir
1253 * ADD : a python demo
1255 2004-02-04 Jean-Pierre Roux
1256 * FIX : Final solution (?) for icone embedded images
1257 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1258 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1259 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1260 gdcmData/gdcm-MR-SIEMENS-16.acr1
1261 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1262 to make full checking easier
1264 2004-02-04 Benoit Regrain
1265 * FIX : WriteEntries : coding style & logic in parameters
1266 * FIX : Set the elements to create the DicomDir in a dictionary file
1268 2004-02-03 Benoit Regrain
1269 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1270 * gdcmDicomDir : add the load of directory
1271 * Bug fix and print add-on
1273 2004-02-03 Jean-Pierre Roux
1274 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1275 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1276 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1277 * FIX gdcmParser.cxx : 'group length' elements are now considered
1278 as integers, even for shadow groups, when file is Implicit VR
1280 2004-02-02 Jean-Pierre Roux
1281 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1283 of the last synonym :-(
1284 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1286 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1287 * FIX taking into account the possible 7fe0,0010 multiplicity
1288 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1289 to allow removal of references to 7fe0,0010, to deal with
1290 ACR-NEMA images, when 0028,0200 is meaningfull
1292 2004-01-31 Jean-Pierre Roux
1293 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1294 no longer writes 'Un' on disk
1295 * FIX SQ elements with actual length are now dealt with corectly
1296 * FIX gdcmFile::WriteBase make the difference, for color images, between
1297 the length (for Palette expanded images)
1298 and Raw Length (non expanded image + Palette)
1299 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1300 (that broke Write). Replaced by UL.
1301 Aware user will reload the field if he
1302 thinks it's necesssary
1304 2004-01-30 Jean-Pierre Roux
1305 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1306 when 'dirty Acr' is found, to be compliant with the new
1307 IsReadable() methods.
1309 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1310 (no DOUBLE images in kosher DICOM,
1311 but so usefull for people that miss them ;-)
1313 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1314 DICOMDIR related utilities (not checked as Windoze compliant)
1316 2004-01-28 Jean-Pierre Roux
1317 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1319 2004-01-27 Jean-Pierre Roux
1320 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1321 to allow skipping the shadow elements, to save memory space.
1322 The TRUE value for this param has to be used
1323 with a FALSE value for the 'enable_sequence' param.
1324 ('public elements' may be embedded in 'shadow Sequences')
1325 * gdcmHeader methods now deal with 'embedded icones images' in the header
1326 (even when an 'icone image sequence' is announced by the
1327 element (0x0088,0x0200), but there is NO icone at all ...
1329 * gdcmHeader sometimes Image Location value doesn't follow
1330 the supposed processor endianity (see gdcmData/cr172241.dcm).
1333 * gdcmHeader add the method
1334 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1335 to get *all* the Header Entries with the same tag.
1336 GetHeaderEntrySameName is probabely *useless*
1337 (no meaning : Name is *not* an identifier within the Dictionnary)
1339 2004-01-26 Benoit Regrain
1340 * Bug fix in the print of hexadecimal representations. Remove long fields
1341 in the print and add a third level of print to print them
1343 2004-01-23 Benoit Regrain
1344 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1345 * Bug fix on test suite after remove the strip made on not string fields
1346 * Split the IsReadable method between gdcmParser which test that the file
1347 is dicom and gdcmHeader which test that it's an image file
1349 2004-01-22 Benoit Regrain
1350 * DicomDir : clean code, add methods, set variables in protected or private
1351 * gdcmUtil : bug fix for the clean string method
1353 2004-01-19 Benoit Regrain
1354 * Add the use of shadow dictionaries
1355 * bug fix and coding style
1357 2004-01-19 Benoit Regrain
1358 * src/gdcmFile.cxx : bug fix concerning the close of file
1359 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1360 * Add the update of header entries using the shadow library
1362 2004-01-19 Benoit Regrain
1363 * removal of file gdcmHeader2.cxx
1364 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1365 inheriting from gdcmParser. This split is to prepare the integration
1366 of dicom dir parsing
1367 * bug fix under python
1369 2004-01-16 Jean-Pierre Roux
1370 * REM removal of class gdcmHeaderEntrySet
1371 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1372 * ADD add file gdcmHeader2.cxx
1373 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1375 2004-01-15 Benoit Regrain
1376 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1377 entries created while parsing the header. Thus, they will be destroyed
1378 when the gdcmDictSet will be destroyed
1379 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1382 2004-01-15 Benoit Regrain
1383 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1384 made a fatal error because of the memory release at the end of program.
1385 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1386 some memory and vtk seems to have some problems with that.
1387 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1389 2004-01-14 Benoit Regrain
1390 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1391 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1392 * src/*.[h|cxx] : make changes due to class name changes
1393 * gdcmPython/demo/*.py : bug fix due to method names
1395 2004-01-13 Benoit Regrain
1396 * src/*.[h|cxx] : coding style
1397 * vtk/*.[h|cxx] : coding style
1399 2004-01-13 Benoit Regrain
1400 * gdcmPython/testSuite.py : test the readable flag of file for tests
1401 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1402 It's lied to the stl compilation by MSVC (windows, always windows...)
1403 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1405 2004-01-12 Benoit Regrain
1406 * src/*.h : add comments
1407 * src/gdcmDictSet.h : set the method BuildDictPath in public
1408 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1409 directly setted in the source code
1410 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1413 2004-01-09 Benoit Regrain
1414 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1415 * setup.py : use a reference to gdcmVERSION
1417 2004-01-07 Benoit Regrain
1418 * Modification to compile with the distutils.
1421 2003-12-10 Benoit Regrain
1422 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1423 can use a gdcmHeaderHelper to load datas
1424 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1425 made in the source code
1427 2003-12-10 Benoit Regrain
1428 * Update Windows projects and .cvsignore files
1430 2003-11-12 Jean-Pierre Roux
1431 * ENH gdcmHeader constructor has one more parameter (default value : false)
1432 that allows the user to 'go inside' the SeQuences only
1434 gdcmElValSet:Print takes it into account
1436 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1437 * ENH: Update gdcmPython/CMakeLists
1438 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1439 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1441 2003-11-10 Jean-Pierre Roux
1442 * FIX : gdcmHeader::LoadElements is now based
1443 on the ListTag listElem member,
1444 not longer on the TagElValueHT tagHt member
1445 * ENH : PrintPubElVal shows (temporarily) both results,
1446 with the tagHt member and the listElem member.
1447 (it's easier to 'see' the problems when using Printheader)
1449 * FIX : old private member LgrElem is now splitted into
1450 ReadLength : Length actually found on disk (updated only
1451 if bug fixing is necessary), for internal
1453 UsableLength : Updated by FixFoundLength, to fix a bug
1454 or to allow Parser going on.
1455 Will allow to re-write a kosher header when a SeQuence
1456 with a length (not 0000) is found
1457 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1458 because gdcmElValSet::Add does not update ListElem
1461 2003-11-07 Jean-Pierre Roux
1462 * FIX misstyping in Transfert Syntax name table
1463 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1464 when they have an actual length (not 0000 nor FFFFF)
1465 (Nobody should care of it, but DICOMDIR explorers)
1467 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1468 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1470 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1471 * ENH: vtkGdcmReader now supports LUT !
1472 (vtkgdcmViewer for now is not able to use them though)
1474 2003-11-05 Jean-Pierre Roux
1475 * in testSuite.py : new files names for checking the package
1476 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1477 that returns the pixel area size to the *aware* (vtk) user
1478 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1480 2003-11-05 Benoit Regrain
1481 * in testSuite.py : Modify the rules for checking the paths
1482 : Explicit error messages
1483 * in __init__.py : Related modif
1485 2003-11-03 Jean-Pierre Roux
1486 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1487 to be used by aware (vtk) users that want to manage
1488 LUT (and no to turn the PALETTE image into an RGB pixels one)
1489 * GetPixelType now returns 8U for 24 Bits images
1490 (vtkGdcmReader compliant)
1492 2003-10-31 Jean-Pierre Roux
1493 * Removal of *all* gdcmData images and add them again
1494 in order to loose the 'history' of un-anonymised images
1496 2003-10-31 Jean-Pierre Roux
1497 * RMV : removal of useless jBitsInJsample.h
1498 for both 8 and 12 Bits JPEG Lossy Libraries
1500 2003-10-31 Jean-Pierre Roux
1501 * ENH : Add the functions gdcmFile::GetImageDataRaw
1502 gdcmFile::GetImageDataIntoVectorRaw
1503 that act as GetImageData and GetImageDataIntoVector
1504 except the making of an RGB Plane from Gray Plane + LUT
1505 Intended to aware (vtk) users who know how to manage
1508 GetLUTRGBA return a R,G,B,A LUT if any
1509 lgrTotaleRaw gives the 'Raw' length
1510 GetImageDataRaw returns the gray Plane
1511 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1512 (They stay Grey, just like with other Dicom viewers :-(
1514 2003-10-30 Jean-Pierre Roux
1515 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1517 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1518 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1519 being coherents dicom files.
1521 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1522 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1524 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1525 * ENH: Two steps is necessary to please VC++ compiler...
1526 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1527 * ENH: Add include dir to medcon lib
1528 * FIX: only one function is being exported for now !
1529 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1531 2003-10-29 Jean-Pierre Roux
1532 * adding gdcmHeader::GetLUTRGBA
1533 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1534 --> Mathieu, the modif u're waiting for is not yet committed
1535 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1537 2003-10-27 Jean-Pierre Roux
1538 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1539 00191113.dcm DermaColorLossLess.dcm
1540 MxTwinLossLess.dcm RadBWLossLess.dcm
1541 * ENH: For version prior to vtkImageViewer2 -r 1.19
1542 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1544 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1545 * Removal of ido stuff in CMakeLists.txt
1547 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1548 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1549 * FIX: remove a call to ->Modified ... see comments
1550 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1552 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1553 * FIX: Problem with path for libvtkgdcmPython
1554 * ENH: Try adding a search script for python site-package
1555 * RMV: Remove some file from medcon lib that are not necessary
1556 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1557 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1558 * FIX: More pragma disable fro VC++,
1559 I don't think I break something as it is also disable in VTK/ITK.
1560 But it fasten debug compilation time.
1562 2003-10-23 Jean-Pierre Roux
1563 * gdcm now deals with 16 Bits Run Length Encoded images
1564 (they are compressed as 2 planes images,
1565 one for the high Bytes, the other for low Bytes)
1567 2003-10-22 Jean-Pierre Roux
1568 * Now CheckRead takes into account :
1569 - the bugged 'Leonardo' Siemens images
1570 - the XA images, sent thru the burning VPRO station
1571 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1574 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1575 * FIX: When copying a Makefile.am to CMakeLists.txt
1576 one should remove the '\'
1578 2003-10-22 Jean-Pierre Roux
1579 * in gdcmData adding a bugged 'Leonardo' Siemens image
1580 (wrong lengths in header)
1581 OK with gdcm, KO with the other viewers :-)
1582 * add a GE dlx XA image, thru the VEPRO burning station
1585 2003-10-21 Jean-Pierre Roux
1586 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1587 for a brutal checking of vtkgdcmViewer compliance
1589 2003-10-21 Jean-Pierre Roux
1590 * add the files for 'xmedcon' Jpeg Lossless library
1591 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1593 2003-10-21 Jean-Pierre Roux
1594 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1596 2003-10-21 Jean-Pierre Roux
1597 * garbage Siemens 'Leonardo' images dealt with
1598 (the patch is easy to remove)
1599 * cosmetic changes to avoid warnings
1601 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1602 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1603 no need to press 'r' now.
1605 2003-10-20 Jean-Pierre Roux
1606 * upgrade of checkRead.sh checkWrite.sh according
1607 to new Jpeg Lossless decompressor
1608 * add US.3405.1.dcm, a genuine RGB medical file ...
1609 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1610 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1612 2003-10-15 Jean-Pierre Roux
1613 * general anonymisation in gdcmData
1614 * adding the 'color files' from
1615 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1616 * adding some well knowed bugged-header images
1617 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1618 waiting for their inclusion in Python testsuite
1620 2003-10-15 Jean-Pierre Roux
1621 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1622 no longer seg faults when file is not found
1624 2003-10-14 Jean-Pierre Roux
1625 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1628 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1629 * TODO: *.in file to genereate a UseGDCM later
1631 2003-10-14 Jean-Pierre Roux
1632 * Some supposed-to-be Dicom Images have no preamble.
1633 OpenFile takes it into account
1634 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1635 * Missing elements added in dicomV3.dic
1636 (just to be affraid : have a look at
1637 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1638 and do it again next year ;->
1640 2003-10-13 Jean-Pierre Roux
1641 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1642 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1643 But there are NOT. It's fixed !
1645 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1646 * FIX: "jpeglib.h" was not found on VC++
1647 * FIX: vtkgdcm was not being installed
1649 2003-10-10 Jean-Pierre Roux
1650 * ENH : OpenFile closes the file if it *really* doesn't look like
1651 an ACR-NEMA / DICOM one.
1652 * FIX : testWrite no longer writes an empty file if the source file
1653 is not gdcm Readable
1654 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1657 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1658 * FIX: CMake generate now documentation
1659 * ENH: out of source doc build !
1660 * ENH: Generate both user and dev documentation
1661 * ENH: Should work on windows too
1662 * ENH: Only one doxygen config.in file is needed
1663 * FIX: make install should be ok now on ùnix plateform
1664 * FIX: PATH to dictionary was wrong (missing /)
1665 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1667 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1668 * vtkGdcmReader is now able to read rgb dicom file.
1669 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1670 * added a gdcmViewer to vtk test, use mouse to control
1671 window level & window width
1673 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * CMake-ification of gdcm, we have now two build system
1675 * FIX: on cygwin Wsock32 doesn't exist
1676 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1678 2003-10-06 Emanuel Ollart
1679 * FIX : compilation process wad broken.
1680 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1682 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1683 * change gdcmViewer -> vtkgdcmViewer
1684 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1686 2003-10-06 Jean-Pierre Roux
1687 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1688 ( e.g : well known GE images with a wrong elem length,
1689 : Philips MRI Images with a wrong Huffman table)
1690 * still to be done : allow the reading of bugged LEONARDO Siemens images
1692 2003-10-03 Jean-Pierre Roux
1693 * Odd length strings are padded with '\0' (not with spaces,
1694 to remain compliant with already defined strings,
1695 like Transfert Syntax UID and others)
1697 2003-10-03 Jean-Pierre Roux
1698 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1699 to allow displaying RGB images (not only by affim ;-)
1701 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * vtkGdcmReader is now able to read rgb dicom file.
1703 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1705 2003-10-03 Jean-Pierre Roux
1706 * A few nasty patches to allow the reading of a lot of nasty images
1707 ( e.g : well known GE images with a wrong elem length,
1708 : Philips MRI Images with a wrong Huffman table)
1709 * still to be done : allow the reading of bugged LEONARDO Siemens images
1711 2003-10-03 Jean-Pierre Roux
1712 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1714 2003-10-03 Jean-Pierre Roux
1715 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1716 to allow displaying RGB images (not only by affim ;-)
1718 2003-10-03 Jean-Pierre Roux
1719 * gdcmFile::GetImageDataIntoVector now
1720 - deals with MultiFrames MultiFragments Run Length Encoded files
1721 - deals with YcBcR (YBR_FULL) files
1722 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1723 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1725 (no sample found :-(
1727 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1728 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1729 Two reasons: - clear things
1730 - third parties acces gdcm through header files, so won't
1731 suffer anymore VC++ complains
1733 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1734 * add argv[1] in testvtkGdcmReader.cxx
1737 2003-09-24 Jean-Pierre Roux
1738 * The lines are now eigthy characters long.for
1739 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1741 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1742 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1743 char* to std::string. Thus, the use of strdup becomes useless. (see
1744 previous commis of Malaterre)
1745 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1746 before the last Malaterre's commit.
1748 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1749 * This commit should fix the Debug building under VC++, the problem
1750 was mainly a mixture of debug and release lib being loaded at startup.
1751 * I also remove a depency to a specific C function: strdup. Because I had
1752 to force the link to msvcrtd (whereas strdup is in libc).
1754 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1755 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1756 located in the gdcmCommon.h file. All use of reference of tha has been
1757 changed to now use the variable GDCM_UNFOUND.
1759 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1761 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1762 Dicom dictionary. The test suite can now be run again. Note:
1763 I'm note very happy with the " (RET)" changes. I believe this
1764 RETAINED comment should be dropped when parsing the dictionary.
1765 - PACKAGER corrected
1767 - AUTHORS updated and now in alphabetical order
1768 * Makefile.am now exports gdcm.dsw for Windoze users.
1770 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1771 * cygwin complains about missing std:: in subdir Test/
1773 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * remove some methods that are now in gdcmHeaderHelper
1776 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1777 * vtkGdcmReader set spacing and origin correctly
1779 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1780 * Fix a few delete/delete[] mismatch
1782 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1783 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1784 interpretation to data given by gdcmHeader. For instance there are
1785 heuristics to get informations (look at different places).
1786 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1787 sorting DICOM images based on different strategies.
1788 * modified Makefiles accordingly.
1790 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1791 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1792 when building in debug mode
1793 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1794 src/win32/gdcmdll.dsp
1795 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1797 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1798 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1801 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * src/win32/libgdcmjpeg12.dsp was not dos format
1803 * src/win32/libgdcmjpeg12.dsp :
1804 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1805 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1807 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1808 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1810 * src/gdcmFile.cxx : bug fix in affectation type
1811 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1812 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1813 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1814 symbols... future problem ?
1816 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1817 * src/win32/libgdcmijpeg12.dsp was missing
1818 * modified gdcm.dsw accordingly
1820 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1821 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1823 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1824 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1825 commit of JPR (before his hollidays to facilitate our work).
1826 * setup.py : bug fix in code. Modifications made while the last commit
1827 of JPR. The code hasn't been tested before the commit... it's so
1828 useless to make that (for best programmer that is JPR) !!!
1830 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1831 * tagged the current version as Version0_3 (i.e. version 0.3)
1833 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1834 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1835 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1836 * *.dsp : modifications to use new libgdcmijpeg8 library
1837 * setup.py : bug fix on VTKPATH variable
1838 * PACKAGER : adding all concerning windows
1840 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1843 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1844 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1845 test suite reported error.
1846 * PACKAGER file added (describes what a packager must do when
1847 packaging a new release).
1848 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1849 * configure.in: upgraded version number to 0.3.0
1850 * fixing build of rpm (through rpm -ta):
1851 - Doc/Makefile.am exports proper doxygen files
1852 - src/jpeg/libijg8/Makefile.am exports the include files.
1854 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1855 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1856 * src/gdcmHeader.h : formatting code
1858 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1859 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1860 We were obtaining error message from vtk. Now, creation of file list
1861 is made in an internal list to prevent this problem.
1862 Bug fix when output is empty.
1863 Bug fix in update of progress value. Previous commit for this was a bad
1865 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1867 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1868 * src/gdcmHeader.h : added method to get the file name
1869 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1870 files. Added method to remove all files on the input
1871 Added FIXME comment concerning the bad parsing of header made by
1872 ExecuteInformation method (in ExecuteData method)
1874 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1875 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1876 when using make instal.
1877 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1878 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1880 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1881 * setup.py : adding include dir of jpeg lib to compile all sources
1882 * */Win32/*.dsp : JPR fix for windows compilation
1884 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1885 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1887 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1888 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1890 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * setup.py is again effective on un*x (takes into account the
1892 addon of the jpeg library)
1893 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1894 * Doc/Doxy* updated (includes above enhancements)
1895 * INSTALL now points to web documentation
1897 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1898 * src/gdcmHeader.h doesn't make unnecessary reference to
1900 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1902 * src/gdcm*.[cxx|h] :
1903 - to allow compilation with gcc 3.x
1904 -- clean up of STL usage (added explicit usage of std::)
1905 -- small fixes on exceptions.
1906 Note: linking not tested !
1907 - clean of doxygen comments to avoid warnings at documentation
1909 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1910 dependent convertion).
1912 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1913 * Clean up of previous JPR garbage commit (not even commented in the
1915 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1916 - moved all jpeg related files from src to src/jpeg/libijg8, with
1917 addition/modification of Makefile.am and configure.in.
1918 - the testSuite is still brain damage (not guilty).
1920 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1921 * WrapVTK.py : modifications to get correctly vtk source files to
1923 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1924 (FileName -> Filename)
1926 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1927 * vtk/vtkGdcmReader.[cxx/h]:
1928 - UpdateProgress method should now be effective
1929 - removed the limitation on having only images loaded (as opposed
1931 - when building a stack of images/volume, a lesser number of
1932 gdcmHeader and gdcmFile instances should be used (hopefully
1933 accelerating things).
1934 - when building a stack of images/volumes, files which are not
1935 loadable (wrong path-filename, wrong permissions on existing file,
1936 or file not parsable by gdcm) are replaced with a black image
1937 in the stack (for the caller to notice the problem).
1939 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1940 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1942 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1943 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1944 between standard library (std) and vtk library (problems are found
1945 under Windows... thanks Windows !)
1947 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1950 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1952 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1953 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1955 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1956 * When compiling with distutils (see setup.py) the C++ compiler is
1957 called with different flags than the default ones (with automake).
1958 In order to fix all those warning, I compiled gdcm with the command
1959 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1960 and went for warning fixes:
1961 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1962 up from unused variables.
1963 - vtk/vtkGdcmReader.cxx: potential bug fix.
1964 * src/gdcmHeader.h: Doxygen warning cleanup
1966 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1967 * gdcmPython/gdcm.i:
1968 - typemaps correction to take into account the systematic replacement
1969 of "using namespace std" with std:: prefix e.g. std::list,
1970 std::string... (cf changes of 2003-05-21).
1971 - gdcmGlob global variable of type gdcmGlobal (defined in
1972 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1973 exported to Python a as cvar.
1974 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1975 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1976 gdcmDictSet.GetPubDictTagNames() and
1977 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1978 C++ static methods).
1979 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1980 with the above changes.
1982 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1983 * setup.py, manifest.in : bug fix under linux
1985 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1986 * Modification of setup.py to compile vtk part too. Then, we have 2
1987 wrappers which must work with same distutils. For that, we have a
1988 generic distutils in distusiltsWrapping.py ; with :
1989 - build_extWrap class to wrap generically all extensions,
1990 - ExtensionWrap base class for all wrapping extension that contains
1992 - Wrapper interface which wrap sources
1993 + In WrapSwig.py we have extension and wrapper for Swig
1994 + In WrapVTK.py we have extension and wrapper for VTK
1995 * MANIFEST.in : modifications to consider vtk directory and new python
1996 files for compilation
1998 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1999 * Added python wrappers of vtkGdcmReader vtk class (see the
2000 source in vtk/vtkGdcmReader.cxx) :
2001 - vtk/Makefile.am now builds a library
2002 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2003 python library (as opposed to _gdcm.so wich are the python
2004 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2005 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2007 - configure.in has an additional flag --enable-vtk that needs
2008 to be set to enable compilation of vtk related code, that is:
2009 + vtk/vtkGdcmReader.so and
2010 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2011 + gdcmPython/vtkgdcmPython.so (see above)
2012 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2013 be read when compressed or when HighBit + 1 != BitsStored),
2014 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2015 the usage of the python wrapper of vtkGdcmReader vtk class.
2016 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2017 * src/*.[h] all occurences of stl classes are now prefixed with
2018 std::, and all occurences of "using namespace std;" where removed.
2019 This is to avoid pollution of global namespace in included files.
2020 Apparently vtk does not avoid this pitfall: when using both
2021 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2022 collision of various stl members (principally cout...).
2023 * gdcmPython/testSuite.py now cleanly removes temprory generated
2025 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2026 comply with above changes)
2028 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2029 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2030 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2031 vtk data structure (an image Flip was required).
2032 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2033 * cosmetic changes in documentation.
2035 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2036 * src/gdcmHeader.cxx: the constructor no longer exits when an
2037 unexisting file is given as argument.
2038 * The subdirectory Data (containing all the images used for the
2039 test suite) is not part of this repository anymore. A new module
2040 containing those images is now available at
2041 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2042 with the name gdcmData.
2043 All the python scripts (including the package initialisation file
2044 gdcmPython/__init__.py) were adapated to take this change into
2045 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2047 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2048 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2049 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2050 demo of the usage of this class.
2051 Compilation of this vtk part is only done when using the --enable-vtk
2052 at configure (or autogen.sh) stage.
2054 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2055 * More memory link related corrections and documentation fixes.
2057 - maximum info is obtained with a command of the form:
2058 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2059 --show-reachable=yes PrintHeader
2060 - the remaining reachable blocks seem to come from the STL
2061 allocation scheme through the usage of map and list. It looks
2062 like this memory cannot be freed but it is not a memory leak
2063 (in fact further invocation to the STL would recollect the
2064 unused memory allthough it cannot explicitely be freed).
2065 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2066 of displaying an image parsed with gdcm and displayed with VTK.
2067 Note: some images don't seem to work e.g.
2068 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2069 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2070 Allthough this weakens the semantics, it is a ditch attempt to
2071 make gdcm more thread friendly.
2073 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2074 * Memory link hunt (by using valgrind through the command
2075 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2076 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2077 gdcmHeader::_dicom_vr.
2078 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2079 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2081 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2083 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2084 * src/Makefile.am now exports all the necessary include files at
2088 * UpdateGroupLength replaced by new one
2091 * UpdateGroupLength re-written using H-Table
2092 (named UpdateGroupLengthNew untill checks are over)
2094 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2095 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2096 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2098 - gdcmHeader::GetPubElValSet removed.
2099 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2100 UpdateGroupLength, WriteElements, Write.
2101 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2102 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2103 carried the same semantics.
2104 - src/gdcmHeaderIdo.cxx changed accordingly.
2105 - gdcmFile::WriteBase now regroups all the codes from previous
2106 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2107 - enum FileType moved to gdcmCommon.h
2108 * src/gdcmHeader.cxx AddDefault trashed
2109 * gdcmGetXSize added
2110 * getimageDataSize now calls gdcmGetXSize
2111 * Test/*.cxx changed to agree with above changes
2113 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2114 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2115 (to avoid double call by end user).
2116 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2117 by end user, since gdcmHeader::gdcmHeader now handles it.
2119 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2120 * gdcm/Doc many doxygen changes:
2121 - Doxyfile now has two different versions, DoxyfileUsers that generates
2122 the html.users end users oriented documentation and
2123 DoxyfileDeveloppers that generates the html.developper developper
2124 oriented documentation.
2125 - README changed accordingly
2126 - requirement.txt removed (old design info moved to TODO).
2127 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2128 DoxyMainPage.txt, DoxyPython.txt provide more information.
2129 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2130 be updated by simply regenerating the docs with doxygen and copying
2131 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2132 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2133 all the tests in the form "if (<map>.count() >1)" were removed.
2134 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2135 ill-formed documentation sections.
2136 * src/gdcmHeader.cxx: ditto
2138 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2139 * setup.py fixed for un*x (needed macro for stdint.h)
2140 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2141 un*ces with sh-utils test utility.
2142 * gdcmPython/demo/test.py renamed to PrintHeader.py
2143 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2144 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2145 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2146 * src/gdcm*.cxx JPR's bad inclusion fixed.
2148 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2149 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2150 * gdcmPython/demo/test.py changed accordingly.
2152 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2153 * gdcmPython/Makefile.am fixed linking against libstdc++
2154 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2155 * Swig subdir (historical tests of swig version 1.3.17++) removed
2156 * Test/testChangeEntete.cxx some lines commented out in order to make
2158 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2159 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2161 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2163 hence the user doesn't need this explicit call.
2164 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2165 i.e. LoadElements() call removed.
2166 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2167 - src/Makefile.am declares the proper flag for g++.
2168 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2169 for adding user defined new tags.
2170 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2171 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2172 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2174 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2175 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2176 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2177 src/Makefile.am : the project should properly compile and install
2178 with the autotools, included the python wrappers part.
2179 * gdcm.spec.in : added a spec file for RPM packaging.
2181 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2182 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2184 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2185 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2186 to exported to the environement (see gdcmPython/testSuite.py
2188 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2189 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2190 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2191 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2192 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2194 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * gdcmPython/__init__.py doesn't crash anymore when running in
2196 in InstallMode or PreInstallMode but with an environement given
2197 value of GDCM_DICT_PATH.
2198 * src/gdcmDictSet.[cxx/h] coding style.
2200 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2201 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2202 * src/gdcm.h general comments moved to TODO, and README
2203 * src/gdcm.h should now be seen as a user commodity (including it
2204 should suffice to fully use gdcm). It is nowhere including within
2205 any of the kernel files src/*.cxx and src/*.h.
2207 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2208 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2209 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2211 * src/gdcm*.cxx only include their corresponding include file
2212 (as opposed to gdcm.h)
2213 * gdcmPython/gdcm.i changed accordingly
2214 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2215 the autogen.sh generated "make snapshot" command to work.
2216 * autogen.sh removed history related references to crea package.
2218 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * distutilsSwigCPlusPlus.py work around some swig portability
2222 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2223 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2224 was done in a last ditch attempt to get setup.py _really_
2225 operationnal. The python/gdcmPython layaout add the advantage
2226 of hidding away the python related distutils specific files
2227 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2228 Alas, the src directory was out of scope (i.e. it's relative
2229 position to setup.py was ../src) which made things impossible to
2230 handle (see previous version of python/setup.py). Crossing fingers...
2232 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * python/setup.py now works on Un*x. (harder than I thougth)
2234 * python/distutilsSwigCPlusPlus.py can now have include files
2235 among the list of sources.
2237 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2238 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2239 * modifications in MSVC projects
2241 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2242 * As stated by the first lines of Test/ExceptionAndPython/README, it
2243 looks like we can move back to original usage of exception within
2244 src/gdcm* and hence remove the errno stuff that was introduced
2245 as a quick and dirty fixture of this problem (added to the TODO).
2246 * Doc/Doxyfile configuration file for Doxygen and corresponding
2247 README file for usage added.
2248 * Test/testWrite.cxx added. This new test comes from a split of
2249 test.cxx that is now reverted to its original purpous i.e.
2250 testing the proper parsing of a Dicom related file.
2251 testWrite.cxx concentrates on testing the IO part of gdcm.
2252 * Test/bug1.cxx (containing a bug on WIn32) added.
2253 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2254 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2255 whose purpose is to publish the content of the TagNames of the
2256 Dicom public dictionnary were not accessible without an
2257 instance of class gdcmHeader.
2258 - those methods are now static methods of gdcmDictSet and hence
2259 require no instances at all to be invocated.
2260 - within gdcmDictSet this change required to change some method
2261 to class methods (i.e. are now static) among which SetDictPath
2262 (renamed to BuildDictPath) and LoadDefaultPubDict.
2263 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2264 the above changes by calling the new method classes of gdcmDictSet.
2265 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2266 the above to be effective.
2267 * python/gdcmPython: in order to wrap properly the above changes
2268 for Python, swig version now needs to be > 1.3.17.
2269 * python/gdcmPython/Makefile fixed to adapt itself to new
2270 configure/make shema introduced by Johan Montagnat (thanks for the
2271 contribution). Alas this Makefile cannot be turned into a proper
2272 Makefile.am without some heavy changes in the configure.in
2273 (for python dectection).
2274 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2275 now avoids publishing the empty entries.
2277 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2278 * python/setup.py : bug fix concerning install under windows
2279 ExtraPath reused :-P
2280 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2282 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2283 * Dicts/dicomV3.dic : remove double spaces !!!
2284 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2285 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2288 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2289 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2290 method. Doxygenation.
2291 * src/gdcm.h clean up of JPR spurious comments.
2293 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2294 * python/distutilsSwigCPlusPlus.py now properly collects the
2295 shadow classes generated by "swig -c++" (gdcm.py in our case)
2296 when using "python setup.py install".
2297 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2298 reexports the working classes.
2299 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2300 by the classical C errno scheme. This is to prevent an obscure
2301 behavior of the python wrappers when importing wxPython.wx prior
2302 to gdcmPython (which ended up in an abort call). An illustration
2303 of this oddity can be found in the Test/ExceptionAndPython
2304 subdir (see the README file). This problem probably due to
2305 an combination of g++ and dynamic loading.
2306 * added Test/ExceptionAndPython (see above)
2308 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2309 * Changed the layout of the python part to avoid bloating main
2310 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2311 i.e. the distutils arsenal. All the python related stuff is
2312 again in a python subdir, but the package itself is now in
2314 * setup.py was cleaned up:
2315 - pythonIncludePath removed
2316 - python setup.py bdist target is now functional.
2317 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2318 collision with other packages). gdcmPython/demo/*.py changed
2321 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * python subdir moved to gdcmPython (preparation of distutils packaging).
2323 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2324 distutils installer is operational.
2325 * - gdcmPython/__init__.py now properly loads the swig generated
2326 shadow classes (from gdcm.py).
2327 - gdcmPython/demo/*.py changed to import the package gdcmPython
2328 instead of gdcmPython/demo/load.py.
2329 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2331 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2332 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2333 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2334 entries within the associated public Dicom dictionary resp. the same
2335 information but sorted by the fourth field (PAT, IMG, DIR) of the
2337 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2338 are now in the "???" group.
2339 - python/gdcm.i changed accordingly,
2340 - python/demo/printGroupedPublicDict.py added, that gives an example
2341 of the above new functionalities in Python.
2343 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * src/gdcm.h, gdcmHeader.cxx:
2345 - historic references to glib's g_malloc and g_free (#defined)
2346 were definitively removed.
2347 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2348 * src/gdcmElValSet.cxx:
2349 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2350 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2351 - GetElValue(string) renamed to GetElValueByName.
2352 - Added GetElementByName(string).
2353 * src/gdcmHeader.cxx: added
2354 - GetPubElValRepByNumber(guint16, guint16)
2355 - GetPubElValRepByName(string)
2356 - GetShaElValRepByNumber(guint16, guint16)
2357 - GetShaElValRepByName(string)
2358 - GetShaElValByNumber(guint16, guint16)
2359 - GetShaElValRepByName(string)
2360 - GetElValRepByNumber(guint16, guint16)
2361 - GetElValRepByName(string)
2362 - GetElValByNumber(guint16, guint16)
2363 - GetElValRepByName(string)
2364 * Doc/requirements.txt added.
2366 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2367 * Test/Makefile building now depends on the one of libgdcm.so
2368 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2369 pixel data) aware which enables finding the address (offset) of
2370 the pixel data of JPEG encoded DICOM files. This leaves only a single
2371 file in the testSuite whose pixel data address (offset) is unknown.
2372 * python/testSuite.py changed accordingly.
2374 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2375 * VC++ has some strong limitations when working with the STL, as stated
2376 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2377 "Also note that some STL containers (map, set, queue, list, deque)
2378 cannot be exported. [...]
2379 Some STL classes contain nested classes. These classes can not
2381 This is caused by a designed limitation that once a template
2382 class is instantiated, it can not be re-instantiated and
2384 Since our usage of map<> is ubiquitous in gdcm, this "designed
2385 limitation" of VC++ is a pitfall.
2386 Hence the Python wrappers of gdcm cannot be incrementally linked
2387 against the c++ dynamic library. The dirty but only workaround is
2388 to forget about incremental link of dynamic libraries and to generate
2389 the Python wrappers library with the inclusions of the underlying C++
2391 The following modifications concern this matter on Win32/VC++:
2392 - wrapping python correct with standalone wrapped dll (don't use separate
2393 dll under windows !!!!)
2394 - python21_d debug mode enabled (ask Frog how to use it :-)
2395 - NO problem with having an STL member of class for example string in C++
2396 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2397 - Python test of dcmlib in Python is ok under windows on a large set
2399 * removed glib references
2400 * typedef's inserted in gdcm.i for correct swig type management
2402 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2403 * python/demo/*.py load.py extracted from test.py. Added explore.py
2404 that only displays required tags and testAll.py that parses all
2405 the files of the testsuite without using unittest.
2406 * python/testSuite.py other additional test on new files added.
2407 * Data/* new test files added accordingly to the testSuite.
2408 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2409 the vr in the file differs from the one of the dictionary.
2411 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2412 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2413 values, but limits itself to values which are below a user specified
2414 size (by default 1024 bytes).
2415 * python/gdcm.i : elements not loaded (because their size is above the
2416 user specified treshold) are exported with their TagKey as key of the
2417 python dictionary. This enables the testsuite to make some checks
2418 on the unloaded elements (since we have their offset and size).
2419 * python/testSuite.py
2420 - now tests for the existence and proper value of the pixel data
2421 - two new examples added.
2422 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2424 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2426 aware. See the strategy comments in gdcmHeader::FindeLength().
2427 * Test/test.cxx now accepts a filename as first argument.
2428 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2429 * python/testSuite.py changed to integrate test on above files.
2431 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2433 the vr was also RET.
2434 * python/testSuite.py more tests added.
2436 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2437 * python/testSuite.py unittest test suite added (uses Data)
2438 * Data/* dcm and acr files for the test suite.
2439 * glib dependance removed from un*x version. We now use ISO C99
2440 7.18 Integer types (see stdint.h)
2441 - python/Makefile, src/Makefile src/gdcm.h
2442 * src/ when an explicit vr (like dicom files) suddenly poped an
2443 implicit element we use to mark the underlying DictEntry of the
2444 concerned ElValue with "Implicit". This strategy was damageable
2445 too the public or provite dictionaries, since some of their vr
2446 would be changed. Since Header::FindLength heavily relies on the
2447 detection by Header::FindVR of falsely explicit elements, I
2448 added an extra ImplicitVr member to ElValue (boolean).
2449 The rest of the changes we the necessary adaptations.
2451 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2454 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2456 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * Adaptation for porting to VC++:
2459 o forced to use std namespace (for string to be known)
2460 o all class use __declspec export style on WIN32
2461 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2462 (in stdlib.h on Win32 but in std:: for gcc)
2463 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2464 variable GDCM_DICT_PATH.
2465 * src/gdcmHeader.cxx verbose comments made discrete.
2467 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2468 * python/gdcm.i: added a typemap that converts a C++ hashing table
2469 to native Python dictionary.
2470 * python/demo/test.py:
2471 - now uses the native dictionary for exploration of gdcmHeader.
2472 - takes an optional filename argument (the file to parse).
2473 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2474 PubElVals hashing table.
2475 * Dicts/dicomV3.dic removed error prone trailing spaces.
2477 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2478 * Python wrapping process moved away from src/Makefile to
2479 newly created python/Makefile (as well as gdcm.i)
2480 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2481 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2482 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2483 from the environement variable GDCM_DICT_PATH (when existing).
2484 * src/gdcmDict::GetTag bug fix.
2486 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2487 * Straightforward temporary fixes for swig to build the python wrappers.
2488 src/Makefile now has a python working entry [by working we mean
2489 that we can import de shadow classes without errors].
2491 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * hashtest.cxx removed (since allready in Test)
2493 * src/gdcmlib.h renamed to src/gdcm.h
2494 * src/dcm.i renamed to src/gdcm.i
2495 * src/Makefile prepared for python wrapping
2497 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * src/gdcmHeader.cxx :
2499 - Parsing of header is now separated from loading of element values
2500 (see gdcmHeader::LoadElements).
2501 - general clean up of hopefully all file access (creation of
2502 ReadInt16 and ReadInt32)
2504 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2505 * src/gdcmHeader.cxx :
2506 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2508 - SetLgrElem renamed to SetLength
2509 - GetLgrElem renamed to GetLength
2510 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2511 * src/gdcmElValSet.cxx fixed both GetElValue methods
2512 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2513 due to IdoDude was cleaned out.
2515 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2516 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2517 concentrates on finding the value representation (when it exists).
2518 RecupLgr now only finds the element value length, and it avoids
2519 returning the unecessary skL (skipped length).
2520 Also, offsetCourant was simply removed (with taille_fich) since
2521 it was redundant with the File position internals (by using
2522 ftell and fseek). This also made skL (see above in RecupLgr) usage
2524 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2525 on the libido specificities which are handled through class
2527 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2530 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * Truckload of changes. Parsing of header is barely functional
2532 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2534 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * src/gdcmHeader.cxx many addons of low level methods
2537 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2538 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2539 and _IdDcmSWAP_LONG.
2541 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * This corresponds to all the changes decided at the meeting of
2543 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob