1 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
3 Verify the file pointer value before open the file, and if it's not null,
4 a verbose message is generated.
5 Close correctly the file when the file isn't considered dicom-like. The
6 correctly close is a call to CloseFile.
7 When closing the file pointer, test if its not null to close the file.
8 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
9 file. For an uncompressed image, the copied datas correspond in the least
10 case to the image size (calculated) or the image size specified in the
11 header. A verbose is generated if these two size mismatch
13 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
15 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
16 break under windows (with msvc6 compilation).
18 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
22 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * Bugs fix for the Windows build with VC6
24 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
25 needed (only for projects required VTK). If the VTK is included in all
26 projects, there is conflicts with the jpeg lib of vtk when compiling the
27 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
28 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
29 when compiling the gdcm_wrap.cxx file (created by the compilation of the
31 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
32 (like it's already made for the cout use). Otherwise, conflict with the
35 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
36 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
38 - comments on the DicomDir::Method related usage added.
39 - now that we use the namespace gdcm, a lot of internal classes do
40 NOT need to be wrapped anymore.
41 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
42 DicomDir::Method) new example added.
44 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
45 * Improve string manipulation. I now inforce the notion of 'DicomString'
46 A DicomString can contain as many \0 as they want
47 and it is *always* of even length.
48 We only support odd length for very rare case.
49 And in the near future this should be removed.
51 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
52 * /binary_write/ gdcm source. Now even on big endian we are writting
53 little endian. This should -heopfully- fix some tests
55 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
56 * Now the dictionary is compiled into gdcm lib. This is a default
57 behavior, thus any dic file specified is picked before failback to
58 the one comiled into lib
60 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * Change internals for gdcmDict. Don't use any 'new' any more.
62 This should definitely solve any leak problem, and we should be
63 as fast as before, as long as don't modify too much the dictionary.
65 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
66 * STYLE: ivars should start with a capital letter.
67 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
68 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
70 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
71 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
72 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
73 new 2004 dictionaries added (thanks to JPR).
74 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
75 * CLEANUP_ROUND (15) for gdcmPixelConvert
76 - RLEFrame::NumberFragments is now of type unsigned int
77 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
78 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
81 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
82 * Initial work in gathering all transfer syntax accessors. clearly
83 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
84 ivars, but only one transfersyntax (class) ivar with equivalent method on
87 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
88 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
89 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
90 discussed (plus I didn't like having a 2000 lines patch not commited)
92 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
93 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
94 * CLEANUP_ROUND (14) for gdcmPixelConvert
95 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
96 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
97 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
99 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
100 anymore and hence avoids storing a copy of PixelConvert::Decompressed
101 into File::Pixel_Data.
103 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
105 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
106 * CLEANUP_ROUND (13) for gdcmPixelConvert
107 Substituted File::ParsePixelData() with PixelConvert::Print() new
109 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
110 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
111 method to those classes.
112 - src/gdcmFile.[cxx|h]:
113 -- Added a ::Print() method.
114 -- PixelConverter is now a reference instead of a member.
115 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
116 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
118 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
119 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
120 collaboration diagram and inheritance diagram should be generated with
122 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
123 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
124 pointlessly wrapped (see
125 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
126 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
127 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
128 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
129 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
130 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
131 -- File::Initialise: PixelConverter setup moved away to
132 PixelConverter::GrabInformationsFromHeader()
133 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
134 interpretation moved away to PixelConverter::BuildRGBImage()
136 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
137 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
138 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
140 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
141 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
142 displayed on Win32 when a brutal abort() occurs (because of uncatched
143 exception). See TODO new entry of this commit for more on this.
144 * TODO added new entry.
145 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
146 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
147 - HandleColor is no longer called from gdcmFile.cxx
148 - gdcmPixelConvert.cxx clean up on method arguments and internal
149 variable names for semantical coherence.
151 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
152 * Finished lossless transition, not only do we now read all lossless jpeg
153 images, without the need of the Cornwell lib, but we do read them properly now
154 * To reduce code (well to avoid code duplication), I defined a common place
155 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
156 redefine symbols. This is not prefect but this the best solution I found for a
157 compilation time jpeg option.
159 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
160 * Update jpeg ijg lib to support lossless jpeg implementation
161 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
163 * Also added a special copyright for dcmtk since we use their bugfixes.
166 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
167 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
168 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
169 matters, as stated in warning note at begining of %include section).
170 * src/gdcmDicomDir*.[cxx|h]: coding style
171 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
172 * src/gdcmJpeg8.cxx: doxygen fix.
173 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
174 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
175 from File:: to PixelConvert::.
177 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
178 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
179 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
180 - more code moved away from File:: to PixelConvert::
181 - fat setup of PixelConverter set in place in File::Initialise.
183 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
184 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
185 namespace at the file system level. So now you should convert your examples
187 gdcmHeader -> gdcm::Header
188 It would be nice if people keep in mind to no open the namespace, since it
189 allows compilation on broken plateform which were defining common symbol in
190 the standart namespace (like LP, Unknown ...)
192 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
193 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
194 The JPEG fragments are now parsed at the same stage than the RLE
195 information. All code related to JPEG is now in gdcmPixelConvert:
196 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
197 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
198 export a gdcmFile:: method. Those are simply global functions
199 (for the time being this is better than having them attach to
200 either gdcmFile:: or gdcmPixelConvert::).
201 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
202 and stores the result in a gdcmJPEGFragmentsInfo.
203 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
204 code (among other stuff) moved away from gdcmFile:; to
207 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
208 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
209 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
210 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
211 clean up of RLE related code.
212 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
213 - src/gdcmRLE.cxx removed
214 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
215 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
216 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
217 * CLEANUP_ROUND (9) for gdcmPixelConvert
218 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
219 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
220 away from gdcmFile:: to gdcmPixelConvert::.
222 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
223 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
224 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
225 This is because Parse7Fe0 used to parse the pixels to compute the
226 length. This task was passed over to FindDocEntryLengthOB() a long
227 time ago, EXCEPT I had forgotten the OW case...
228 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
229 we just recylce the code for parsing RLE fragments and computing
231 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
232 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
233 with the retired Parse7Fe0().
234 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
235 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
237 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
238 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
239 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
240 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
241 - src/CMakeLists.txt: alphabetic order reodering + new entries.
242 * CLEANUP_ROUND (4) for gdcmPixelConvert
243 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
244 to return an unused length.
246 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
247 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
248 this should be cleanner from the plane view. The iostream are erally a pain
249 to use to do simple stuff.
251 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
252 * Redo the compilation of the ijg jpeg library. Now only one source is
253 necesseray. No need to rename file by hand what so ever. CMake handle the
254 copying of the file within different directory, configure header file to
255 modify some symbol. The only addition made to ijg wasd a mangle table so
256 that symbol are different wether we are within 8bits or 12bits.
258 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
259 * Added documentation of vtkgdcmReader on Website:
260 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
261 with it's binary name).
262 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
263 the Website to be more complete.
264 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
265 doxygenated documentation.
266 - Doc/DoxyVtkGdcmReaderExamples.txt added
267 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
268 DoxyVtkGdmReaderExamples.html )
269 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
270 * CLEANUP_ROUND (3) for gdcmPixelConvert
271 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
273 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * CLEANUP_ROUND (2) for gdcmPixelConvert
275 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
277 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
278 * CLEANUP_ROUND for gdcmPixelConvert:
279 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
280 - src/gdcmPixelStuff[h|cxx] removed
281 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
282 - src/CMakeLists.txt changed accordingly
284 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
285 gdcmVersion.py moved to newly created ATTIC related
286 gdcmPython/SetupOldies/ directory.
287 * Autotools clean up:
288 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
289 - autogen.sh configure.in acinclude.m4 python.m4 removed
291 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * src/*.cxx *.h Reference to License.htm fixed to License.html.
293 * Doc/CMakeLists.txt, doxygen.config.in: fix.
294 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
296 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
297 * TODO updated with Mathieu suggestions. I proposed a template for
298 describing TODO entries and used it for new entries.
299 * Added Doc/Website/CodingStyle.html, Developpers.html,
300 DeveloppersPython.html, GdcmDataCvs.html and
301 DownloadVersion0_1.html, DownloadVersion0_3.html.
302 * Some Doc/*.txt Doxygen files (which do not really concern the
303 documentation itself, but the website) moved to html and
304 placed in directory Doc/Website:
305 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
306 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
307 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
308 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
309 * CMakeLists.txt changed accordingly.
310 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
311 DeveloppersPython.html
312 * INSTALL nows refers to Doc/Website/Installation.html
314 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * Added Doc/Website directory, that contains a first raw version
318 2004-09-23 Jean-Pierre Roux
319 * FIX In order not to be poluted any longer by casting problems,
320 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
321 we can now delete[] it safely
322 * VoidArea is now called BinArea (less confusing name),
323 and all the methods called ...VoidArea... are now ... BinArea...
324 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
326 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
328 clear) TagHT, which is an inherited member of gdcmElementSet. It is
329 up to the destructor of gdcmElementSet to clean up TagHt and it's
332 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * Test/CMakeLists.txt: update to follow gdcmData renamings.
334 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
336 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
337 * ENH: added some utility method that builds a flat dictionnary
338 holding all the Dicom entries contained in the recursive structure
339 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
341 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
342 BuildFlatHashTable() that build a flat dictionary.
343 - src/gdcmElementSet.h: added a new private GetTag() accessor.
344 gdcmDocument is now a friend of gdcmElementSet.
345 - src/gdcmElementSet.cxx: clean up.
346 - Example/FlatHashTablePrint.cxx added.
347 - Example/CmakeLists.txt changed accordingly
349 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
350 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
351 moved away from gdcmDocEntrySet (since this class is an abstract class
352 acting like an interface). SQDepthLevel and BaseTagKey are now
354 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
355 and associated accessors. Doxygenation of the class.
356 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
358 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
359 Use SQDepthLevel accessor instead. ::Print() adapted.
360 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
361 - src/gdcmDocument.cxx changed accordingly.
363 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
364 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
365 - The following is the doxygen comment of the typedef declaration
366 of gdcmagKey in src/gdcmCommon.h:
367 gdcmTagKey is made to old an "universal" (as in URL, Universal
368 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
369 A dicom tag allways has a group and an element, but a set of tags
370 embeded in various (optionally nested) sequences and sharing
371 the same group and element all share the same (group, element)
372 "identifier". Hence the (group, element) cannot be used as an
373 identifier (in gdcm we shall refer to a "TagKey") of a tag.
374 In order to construct a proper tag identifier (i.e. a key) we
375 consider the following definition of a TagKey:
376 - let Group, Element be the string representation of the
377 group and element dicom tag members,
378 - let ItemNumber be the string representation of the integer
379 index of the considered item number of a sequence,
380 Let the key of a tag embeded in a sequence, noted SeqTag, be
382 /ItemNumber#Group|Element
383 where "/", "#" and "|" are characters acting as separators.
384 Then the general form of a gdcmTagKey is given by:
385 Group|Element<SeqTag>
386 where <SeqTag> means NO or many instances of SeqTag.
387 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
390 but the gdcmTagKey of a tag "embeded" is the first item of
391 a sequence, itself nested in the third item of a sequence is the
393 0004|1220/2#0008|0082/0#0008|0090
394 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
395 order to hold the new sequence compatible key. Previously, the
396 GetKey() method would look in the underlying gdcmDictEntry.
397 - src/gdcmDocEntry.cxx:
398 -- constructor now copies the underlying DictEntry key, in the local
400 -- ::Print: displays the member Key, instead of the (group, element).
401 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
402 - src/gdcmDocEntrySet.h:xi
403 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
404 -- now has a new BaseTagKey member.
406 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
407 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
409 This poses the problem with the semantics of the following lines
410 LoadEntryVoidArea(0x0028,0x1201); // R LUT
411 LoadEntryVoidArea(0x0028,0x1202); // G LUT
412 LoadEntryVoidArea(0x0028,0x1203); // B LUT
413 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
414 to the long FIXME note for what the problem is. Nevertheless in
415 order to get things working the dicom dictionary was altered !
416 Please fix things urgently...
417 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
418 information), see above note on moving the member VoidArea. Nevertheless
419 the following entries previously correctly set as US are now inproperly
421 0028 1201 OW IMG Red Palette Color Lookup Table Data
422 0028 1202 OW IMG Green Palette Color Lookup Table Data
423 0028 1203 OW IMG Blue Palette Color Lookup Table Data
424 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
425 of gdcmDocEntry moved to gdcmSeqEntry.
426 * src/gdcmSeqEntry.cxx: STYLE.
428 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
429 * Test/TestAllEntryVerify.cxx minor fix and added comments.
431 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * gdcmPython/testSuite.py: all the test suite in python is now moved
433 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
434 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
435 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
437 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
439 to avoid inclusion recursion until STL is reached.
440 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
441 mecanism. errno.h is not included in gdcm anymore.
442 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
443 (gdcmFormatError now inherits from gdcmFormatUnexpected).
445 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
446 gdcmData/TestAllEntryVerifyReference.txt
447 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
448 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
449 exception_on_error parameter.
450 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
451 - vtk/vtkGdcmReader.cxx changed accordingly,
452 - Example/*.cxx and Test/*.cxx changed accordingly.
454 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
455 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
456 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
457 enable_sequences removed from gdcmHeader constructor and dependencies.
458 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
459 * gdcmPython/demo/PrintHeader.py: dummy fix.
460 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
461 skip_shadow removed from gdcmHeader constructor and dependencies.
462 * Example/*.cxx and Test/*.cxx changed accordingly.
464 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
465 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
466 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
468 2004-07-21 Jean-Pierre Roux
469 * FIX Now, Parsing and Printing a DICOMDIR do work!
470 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
472 2004-07-20 Jean-Pierre Roux
473 * FIX Some brain damaged headers have Zero-Lenght fields
474 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
476 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
478 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
479 variable (instance of gdcmDebug) by a definition macro, and the instance
480 is now in static in the gdcmDebug class
481 * src/gdcmSQItem.h : (FIXME) remove an undefined method
482 * Test/PrintAllDocument.cxx : bug fix in the result of the test
484 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
485 * WARNING: ctest now depends more tightly on gdcmData. You should
486 check out gdcmData properly for things to run smoothly...
487 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
488 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
489 we need the pixels not be loaded in order to use the ValEntry
490 that displays position and size).
491 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
492 This is a C++ based equivalent of gdcmPython/testSuite.py that should
493 be deprecated. If you have any doubts about the advantages of a
494 modern scripting language (read Python) versus grass root C++ (i.e.
495 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
496 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
497 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
498 Anyhow, consider documenting the gdcmData images in
499 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
501 * Test/CMakeLists.txt:
502 - now uses TestAllEntryVerify.cxx
503 - specific comments on oldACR00001.ima (now renamed in gdcmData
504 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
505 gdcmData/TestAllEntryVerifyReference.txt
508 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
509 * src/*.[h|cxx] : typedef clean up
510 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
511 - TagKey renamed to gdcmTagKey (for external usage)
512 - VRKey renamed to gdcmVRKey (for external usage)
513 - removal of typedef duplication.
514 - Removed all unecessary inline keyword from class inline definitions.
515 - Some method|function(void) declarations replaced with method|function().
516 * src/jpeg/libijg12/jdhuff12.c:
517 - printf polluting ctest removed.
518 - TAB removal for comminting
520 - TestAllReadCompareDicom.cxx: added a test that compares all the
521 images in gdcmDataImages.h with corresponding images in
522 gdcmData/BaselineDicom/. When baseline images are not present
523 this test creates them.
524 Note: we need to validate each reference image, but before that
525 I'd like to rename them with a more explicit name...
526 - CMakeLists.txt: changed accordingly.
527 * Example/*.cxx: examples now only include gdcm.h (as opposed to
528 including each header needed).
530 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * Test/*.cxx and Example/*.cxx: moved some examples away from the
532 test suite to the Example directory. Are concerned:
537 - TestWriteSimple.cxx
538 * Test/CMakeLists.txt: added some comments on reasons for black listing
539 image gdcmData/oldACR00001.ima
541 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
542 * Test/CmakeList.txt: removed the following from black list (to be coherent
543 with removal from gdcmData):
544 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
545 - gdcm-MR-PHILIPS-16.dcm
547 Added the following because after last cvs update, they cause
548 ctest -R TestReadWriteReadCompare
550 - gdcm-MR-SIEMENS-16-1.acr
552 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
553 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
554 new comments in this file) we temporarily (sigh) move to a weaker
556 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
557 we don't need to black list the following images anymore:
558 - 8BitsUncompressedColor.dcm
560 - US-PAL-8-10x-echo.dcm
561 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
562 fixes and the beautified code ;-)
563 This fixes the bug introduced in version 1.42 (when beautifying)
564 that made the parsing of 8BitsRunLengthColor.dcm unproper.
565 Note: ctest was blind to this bug (this means we need to still
566 improve the test suite). The bug could be detected by using
567 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
569 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
570 and by displaying the (garbage) produced file temp.XDCM...
572 2004-06-29 Jean-Pierre Roux
573 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
574 - replace by uggly but working old code :-(
575 A lot of things should be OK again.
576 It's really urgent to have a test suite that *tests*,
577 to prevent Frog's beautifying sessions to break all the stuff
578 (twice, withing a fortnigh ...)
580 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
582 redundancy) to added Test/TestReadWriteReadCompare.cxx
583 * Test/CmakeList.txt: because the compare test of
584 Test/TestReadWriteReadCompare.cxx fails, the following images are
585 black listed: - 8BitsUncompressedColor.dcm
587 - US-PAL-8-10x-echo.dcm
588 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
589 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
590 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
591 and ad-hoc kludge. This kludge is now removed, and on encountering
592 such an image (OB field brain damaged) we set errno. Then in
593 ::FindDocLength() we "fix" the length as being ALL what remains
594 in the file (until EOF). We then proceed, hoping for the best...
595 This fixes a SegFault in ShowDicom when trying to write such an
597 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
598 (because TestWriteRead breaks on it, after a non conformal commit?).
599 ctest now runs properly, except for MakeDicomDir (which was allways
600 broken) and the Python related stuff (still not fixed).
602 2004-06-24 Jean-Pierre Roux
603 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
604 FIX : Test/TestReadWrite now iterates on all the file names
605 (instead of infinite loop)
606 ENH : Test/TestWriteRead now iterates on all the file names
608 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
609 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
611 2004-06-24 Jean-Pierre Roux
612 FIX : - now Write drops LUT Descriptors and LUTs (if any)
613 when SamplesPerPixel =3
614 - now Write is no longer confused by
615 'BitsAllocated = 12" and 'BitsStored=12"
616 - "UN" value representation Elements are now written correctly
617 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
618 ENH : - now gdcmHeader has its own Write methods
619 (in order to split the job that has not to be done
622 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
623 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
624 loop on the same image until memory went out.
625 Note: this means we still have gobs of memory loss in PrintDocument
626 * src/gdcmDocument.cxx: fixes problem on parsing on file
627 gdcmData/16BitsJpegLosslessGrayScale.dcm.
629 2004-06-24 Jean-Pierre Roux
630 FIX : Write - All the Sequences and Sequence Item are now written
631 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
632 is added a the end, when necessary.
633 - A lot of brain-damaged images, that were read correctly are
634 now written correctly
635 - length compatible BinEntry are now loaded correctly
636 (even for odd groups)
637 Note : only Explicit Value Representation was checked.
638 (question : is implicit VR really necessary for gdcm ?)
640 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
641 * DEVELOPPER: added a proposition of coding style.
642 * src/gdcmDocEntry.h: removed every inline declaration (for test of
645 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
647 Use the gdcmDocEntry::Print() and Write() instead.
648 * src/gdcmDocument.cxx: bug fix.
650 2004-06-22 Jean-Pierre Roux
651 FIX : gdcmDocument.cxx
652 - Now we do recognize the JpegLossLess format (there was a misstyping in
653 code 'beautyfication' :-(
654 - Now we automaticaticaly load the Luts, if any
656 2004-06-22 Jean-Pierre Roux
657 In order : to write Sequences, whatever their imbrication level,
658 : to allow user to create his own Sequences
659 a lot of modif where necessary (adding, moving, or virtualising methods)
661 WARNING : save your own sources *before* cvs up !
664 ADD virtual void Write(FILE *fp, FileType filetype);
667 ADD virtual void Write(FILE *fp, FileType filetype);
668 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
671 ADD virtual void Write (FILE *fp, FileType filetype)=0;
672 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
673 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
674 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
675 ADD std::string GetEntryByName(TagName name);
676 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
678 std::string vr = "unkn",
679 std::string fourth = "unkn",
680 std::string name = "unkn");
681 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
682 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
683 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
684 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
685 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
686 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
687 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
688 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
691 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
692 ADD virtual std::string GetEntryByName (TagName tagName);
693 ADD virtual std::string GetEntryVRByName (TagName tagName);
694 REM virtual bool Write(FILE *, FileType);
695 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
696 FILE *_fp, FileType type);
697 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
698 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
699 REM virtual bool WriteEntries(FILE *_fp,FileType type);
700 REM virtual std::string GetEntryByName (std::string tagName);
701 REM virtual std::string GetEntryVRByName (std::string tagName);
702 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
703 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
704 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
706 std::string vr = "unkn",
707 std::string fourth = "unkn",
708 std::string name = "unkn");
709 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
710 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
711 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
712 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
715 ADD virtual void Write(FILE *fp, FileType filetype);
718 ADD virtual void Write(FILE *fp,FileType filetype);
721 ADD virtual void Write(FILE *fp, FileType filetype);
722 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
723 REM std::string GetEntryByNumber(guint16 group, guint16 element);
724 REM std::string GetEntryByName(TagName name);
727 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
729 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
731 The default constructor invoked by the line
732 gdcmHeader *f1 = new gdcmHeader( header );
733 was gdcmHeader::gdcmHeader(bool) instead of the expected
734 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
735 Hence the parsing wasn't executed... See also below.
736 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
737 as explicit constructor didn't do the trick to fix the above problem.
738 Could anyone explain why ?
739 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
740 properly calls gdcmValEntry::Print() (that was weed out from
741 code related to gdcmBinEntry).
743 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * In order to fix memory leaks:
745 - Test/TestWriteSimple.cxx: added cleaning of free store through
747 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
748 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
749 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
750 (through the call to ::AddDicomDirMeta()) or the destructor
751 would crash when deleting uninitialized ::metaElems].
752 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
753 - src/gdcmDocument.cxx:
754 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
756 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
757 was causing memory leaks.
758 - src/gdcmSQItem.cxx:
759 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
760 cleanly handled with polymophism: sorry but my milage is low).
761 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
762 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
763 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
764 This avoids SegFaulting.
765 - src/gdcmSQItem.h: coding style.
767 - Test/TestWriteSimple still severely sucks. The output image content
768 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
769 damaged when displayed with vtkgdcmViewer.
770 - on memory leaks: TestWriteSimple leaks really less (see entry
771 of 2004-06-18 in Changelog file for the call to valgrind).
772 - on segfaults: ctest now passes all the tests but one (no more
774 * Erroneous leading white fix:
775 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
776 white[s] (as opposed to from >> xxx, that removes it [them].
777 - src/gdcmTS.cxx: ditto.
778 - gdcmPython/testSuite.py: dirty related kludge removed.
779 * src/*: remaining references to gdcmParser removed.
780 * src/*[cxx|h]: added copy[way]left header.
783 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
784 * In order to fix writing of dicom files:
785 - Test/TestWriteSimple.cxx: a simpler example of writing.
786 - Test/CMakeLists.txt changed accordingly.
787 - src/gdcmDocument.cxx:
788 -- The destructor now recursilvely removes potential sequences.
789 -- Bug fix in ::IsJPEG2000()
790 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
791 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
793 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
794 to only declared) and build on top of
795 ::GetDocEntryByNumber(guint16, guint16).
796 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
797 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
798 for usage in destructor and treatement of promotion in
799 ::ReplaceOrCreateByNumber().
800 - src/gdcmSQItem.cxx: destructor should better handle his job.
801 Test/TestWriteSimple now runs (or at least it DOES something).
802 * We can now start hutting memory links. A good starting point is:
803 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
804 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
805 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
807 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * Valgrind note: after Mathieu Malaterre teached me how to read
809 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
811 Using gcc, you can force the STL to use malloc and to free memory as
812 soon as possible by globally disabling memory caching.
813 With 3.2.2 and later, you should export the environment variable
814 GLIBCPP_FORCE_NEW before running your program.
815 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
816 simply vanish (it is still not clear to me, whether this means that
817 STL std::string leaks or if valgrind believes it leaks...).
818 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
819 running bin/gdcmTests makeDicomDir):
820 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
821 - Test/makeDicomDir.cxx now properly traps empty lists and returns
823 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
824 SegFaulting (I drowned in DicomDir related code when trying to
825 understand why the list is empty...).
826 * src/gdcmDocument.h: first BSD license header try.
827 * Doc/License.txt added.
829 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * src/gdcmDocument.[h|cxx]:
831 - Clean up of the Transfer related predicates. They are now all based
832 on new method isGivenTransferSyntax, that (should) handle properly
834 - general clean up, simplification, and coding style.
835 - Specific clean up of Parse7FE0() (umproperly named actually).
836 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
838 2004-06-14 Jean-Pierre Roux
840 - fix the display of Sequence Delimitor (SQDepthLevel pb)
841 - fix the display of SQItem ordinal number
842 - add the GetSQItemByOrdinalNumber method
843 - remove some useless never written private methods
845 2004-06-14 Jean-Pierre Roux
847 - adding a constructor taking a gdcmDocEntry as an input param
848 - ReplaceOrCreateByNumber now returns :
849 a gdcmBinEntry * if a Binary (void *) value is passed as a param
850 a gdcmValEntry * if a string value is passed as a param
852 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
853 according to the param type (no longer sets a gdcmDocEntry)
854 - GetValEntryByNumber, GetBinEntryByNumber added
855 - NewValEntryByNumber and NewBinEntryByNumber added
857 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
859 - GetSQItemNumber and SetSQItemNumber added, to provide
860 a (relative) Item identier inside a given Sequence
861 \warning : some pb remaining around this number
863 - AddEntry now takes the Item Number as a param
865 - adding a constructor taking a gdcmDocEntry as an input param
867 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
868 * Memory leak hunt with the following command:
869 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
870 --show-reachable=yes gdcmTests PrintDocument
871 It looks like many (all?) leaks are due to the STL (or a bad usage
872 of the STL. The lines producing the leaks now have a comment with
873 a "MEMORY LEAK" tag: you can retrieve them with
874 grep "MEMORY LEAK" src/*
875 Here are two typical examples which I can't help fixing:
880 char * test = "babo";
881 name = test; //// <--- valgrind detects 960 bytes lost in
882 //// call to std::string::operator=(char const*)
883 name.clear(); //// Doesn't help !
891 std::cout << "Type a bunch of characters followed by RETURN: ";
892 getline(std::cin, line); //// <--- valgrind dectects a loss
893 //// of 1320 bytes in call to
894 /// std::basic_istream<>& std::getline<>
900 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
901 * src/gdcmHeader.[cxx|h]:
902 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
903 and related, moved away to gdcmDocument.
904 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
905 the corresponding protected accessors of inherited class
906 gdcmDocument, removed ! As a consequence gdcmFile had to be
907 declared friend of class gdcmDocument (see below).
908 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
909 - Clean up of undefined or unused methods.
910 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
911 account the changes to gdcmHeader.h).
912 * src/gdcmDocument.h:
913 - gdcmFile is now a friend class (in order to take into account the
914 changes to gdcmHeader.h).
915 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
916 (see changes to gdcmHeader.h).
917 - Accessors (reading on the form GetEntry*) are now public.
918 - Clean up of undefined or unused methods.
919 * src/gdcmDocument.cxx:
920 - adaptation to changes to gdcmDocument.h
921 - ::OpenFile now writes a verbose message when file cannot be opened.
922 - some std::string properly set to VRKey
923 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
924 references to gdcmDocument.
925 * Test/TestFindTags.cxx: changed accordingly to above changes.
926 * gdcmPython/testSuite.py: adapted to renaming of acr files in
927 cvs repository gdcmData.
929 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
931 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
932 conflicts with gdcmValEntry::voidArea.
933 * src/gdcmValEntry.cxx: unmatching comment wiped out.
934 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
935 Value representation between StringRepresentable and BinaryRepresentable.
936 * src/gdcmDocument.cxx:
937 - method ParseDES: proper indentation restored and usage of
938 gdcmVR::IsVROfGdcmStringRepresentable wired in.
939 - method LoadDocEntry: the fingerprint left in the SetValue() of
940 unloaded entries (length > MaxSizeLoadEntry) had curiously been
941 removed. Reverting to previous code segment with the proper
942 dynamic_cast< gdcmValEntry* >.
943 Note: this was (partially) breaking the python test suite
944 (gdcmPython/testSuite.py) that made usage of the above
945 fingerprint to check presence of "Pixel Data".
946 * src/gdcmDocEntry.h: coding style.
947 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
948 now taken into account.
949 * gdcmPython/gdcm.i: adaptation to the new internal representation
950 of gdcm (exit gdcmParser, hello gdcmDocument).
951 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
953 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
954 anymore, but instead prints the loaded Python dictionary.
955 * .... alas, the python testSuite is still broken.
957 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
958 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
960 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
961 * src/gdcmUtil.h : export methods
963 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
964 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
966 * Initial addition of automatic python testing
967 * Initial addition of automatic image comparison
969 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
970 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
971 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
973 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
974 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
975 * Test/ShowDicom.cxx : bug fix for msvc compilation
976 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
978 2004-05-04 Jean-Pierre Roux
979 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
980 new concepts (and new classes) :
981 a 'gdcmDocument' is composed of a set of Doc Entries, that are
982 - elementary gdcmDocEntries (former gdcmHeaderEntries)
983 - Sequence Doc Entries (gdcmSeqEntries)
984 a Sequence is composed of Items.
985 Each item is a set of Doc Entries (this is recursive)
986 The non uniqueness of the 'Dicom tag' is due to this recursivity
987 (never taken into account)
988 Our unability to add a new 'entry' in the header
989 at the proper location (neither in the H-Table (map or multimap),
990 nor in the Chained List is also due to this recursivity.
991 Don't try, right now, to use/modify/compile these new sources :
993 We just commit all the stuff, 'as is', in order not to loose it.
995 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
996 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
998 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
999 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1000 file prefix (SetFilePrefix)
1002 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1003 * Add a new test: ShowDicom, for now this is just the c++ version of
1004 checkRead.sh, later it will be able to compare the image read against a
1006 * Replace the DEBUG on the stack with a global entry in cmake interface:
1007 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1009 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1010 * Add an example subdir, with a real example on how to read + write a
1013 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1015 * Doc/CMakeLists.txt: the main page is now properly differentiated
1016 between the developper and user version.
1017 * Doc/doxygen.config.in: dropped search related obsolete flags
1018 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1020 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1021 * DEVELOPPER: added some helpfull comments for compile/test/install
1024 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1025 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1026 src directory, now generated in the build dir.
1027 2. Tests as mentionned smarter
1029 4. Add a new method in gdcmDict that return the PubDict by name
1030 this is interesting for 3rd party lib like ITK,
1031 where we could set the institution name / patient name...
1033 * ENH: 1. Now the test suite is working for real
1034 2. All binaries are now output in the gdcm-bin directory
1035 (this was not true before)
1037 2004-04-28 Jean-Pierre Roux
1038 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1039 SeQuence indented printing of Dicom Header.
1040 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1041 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1042 Computation of SQDepthLevel is now part of gdcmHeader constructor
1043 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1044 tree-like structure of a Dicom Header.
1045 * FIX Test code cleaning
1047 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1048 * ENH: Adding automatic testing
1049 1. Need a DartConfig.cmake to submit to public
1050 2. Add a test driver gdcmTest.cxx
1051 3. gdcmTestMain, an helper for the main test driver gdcmTest
1052 4. Files in Test don't have a main anymore, this becomes interesting
1053 when we add more and more tests, thus dsw don't have to load
1055 * ENH: Adding a GDCM_DATA_ROOT for testing
1056 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1057 one file instead of seven + some small cleanup
1059 2004-04-22 Jean-Pierre Roux
1060 * ENH Minor changes to the Print() methods.
1061 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1062 Header printing. Example given with :
1063 > PrintHeader fileName 2 new
1064 (SQ based tree-like structure still to be done for the Header ...)
1066 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1067 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1068 1. I have added some unsigned where needed
1069 2. Some function parameter not used -> (void)
1070 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1071 4. g++ don't like character '\' in comment
1072 5. #define jpeg_create_decompress jCreaDecompress
1073 this really need to be fixed
1074 6. virtualize destructor of gdcmObject ... leakage
1075 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1076 this also really need to be fixed
1077 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1078 remove compression file
1079 (as we only do decompression, right ?)
1080 * ENH: Change malloc/calloc/free with c++ equivalent
1082 2004-04-21 Jean-Pierre Roux
1083 * FIX gdcmHeaderHelper::GetXSpacing
1084 when a single value is found (bug ?), xpacing is now
1085 defaulted to yspacing
1087 2004-04-19 Jean-Pierre Roux
1088 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1089 * ENH add parameters :
1090 bool exception_on_error = false,
1091 bool enable_sequences = false,
1092 bool ignore_shadow = false
1093 to the gdcmFile constructors to be full gdcmParser compliant
1094 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1095 to allow reading of PAPYRUS 3.0 files
1097 2004-04-06 Jean-Pierre Roux
1098 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1100 2004-04-02 Jean-Pierre Roux
1101 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1102 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1103 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1105 2004-03-30 Jean-Pierre Roux
1106 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1107 for ACR file, written out as DICOM files (hope so...)
1109 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1111 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1112 moved to base class gdcmParser and only the specialisation is kept
1114 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1115 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1116 already does the job.
1117 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1118 (to be consistent with gdcmParser::WriteEntries).
1120 2004-03-30 Benoit Regrain
1121 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1122 upate of the object's instance. It's passed to 2 in the unfavorable
1123 case : one in the ExecuteInformation, one in the ExecuteData
1125 2004-03-29 Jean-Pierre Roux
1126 * ENH : Check on file type to be written moved
1127 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1128 * FIX : gdcmObject::ResetBoundaries now stops properly
1129 when end-of-list is reached
1130 : gdcmVersion modified (as Benoit Regrain asked)
1132 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1134 * src/gdcmUtil.cxx: added forgotten iostream include.
1135 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1136 equivalent to ExplicitVR in existing code).
1138 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1139 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1140 now contains all the gdcmGlobal related code.
1141 * minor coding style and doxygenation changes.
1143 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1145 now contains all the Debug related code.
1146 * minor clean-up of includes in src/*.cxx
1147 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1148 CreateCleanString) removed.
1149 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1150 * Doc/DoxyMainPageUser.txt added.
1151 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1152 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1153 src/gdcmDirList.cxx)
1155 2004-03-24 Jean-Pierre Roux
1156 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1158 2004-03-23 Jean-Pierre Roux
1159 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1160 big endian made volumes
1161 * ENH Now gdcmParser constructor and destructor are protected to forbid
1162 end user to instanciate class gdcmParser
1163 (only gdcmHeader and gdcmDicomDir are meaningfull)
1165 2004-03-22 Benoit Regrain
1166 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1167 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1168 gdcmSerie to gdcmDicomDirSerie
1170 2004-03-19 Jean-Pierre Roux
1171 * ENH Now the tree-like structure describing a DICOMDIR comming from
1172 an already existing DICOMDIR file is consistent with
1173 the home-made tree-like structure build ex-nihilo
1174 or build from the files held (recursively) in a Directory
1175 functions gdcmDicomDir::CheckBoundaries()
1176 gdcmObject::SetBoundaries() added
1178 2004-03-17 Jean-Pierre Roux
1179 * REM (Eric Boix bug) : removal of meaningless
1180 gdcmDicomDirImage::NewImage function.
1181 * FIX now file names and directory name are written properly in the
1183 * FIX now gdcmDicomDir constructor may be call without any trick
1186 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1187 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1188 of gdcmDicomDirImage::NewImage as empty function.
1190 2004-02-28 Jean-Pierre Roux
1191 * ENH add gdcmDicomDir:NewPatient
1192 add gdcmDicomDirPatient:NewStudy
1193 add gdcmDicomDirStudy:NewSerie
1194 add gdcmDicomDirSerie:NewImage
1195 to allow making gdcDicomDir object.
1196 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1197 (as opposite to the gdcmHeader chained list)
1199 2004-02-11 Benoit Regrain
1200 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1201 when using from python
1203 2004-02-10 Benoit Regrain
1204 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1205 * FIX : in gdcmDicomDir when the directory is empty
1206 * ENH : add callback and methods to get the progression of dicomDir
1209 2004-02-06 Jean-Pierre Roux
1210 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1211 - GDCM_META added to gdcmDicomDirType
1212 - class gdcmMeta created
1213 * ENH : - A brief summary is now displayed at the beginning of
1214 'testDicomDir' to help disaster magnitude estimation
1215 * REM : Now useless Test/explDICOMDIR.cxx
1217 2004-02-05 Benoit Regrain
1218 * ENH : add methods in gdcmObject to get the hash table or the list of
1220 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1221 * FIX : wrapping python for TagHeaderEntryHT
1223 2004-02-04 Benoit Regrain
1224 * FIX : even length for some strings when writting the dicom dir
1225 * FIX : sort the images in the dicom dir
1226 * FIX : Bug fix for python use of dicom dir
1227 * ADD : a python demo
1229 2004-02-04 Jean-Pierre Roux
1230 * FIX : Final solution (?) for icone embedded images
1231 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1232 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1233 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1234 gdcmData/gdcm-MR-SIEMENS-16.acr1
1235 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1236 to make full checking easier
1238 2004-02-04 Benoit Regrain
1239 * FIX : WriteEntries : coding style & logic in parameters
1240 * FIX : Set the elements to create the DicomDir in a dictionary file
1242 2004-02-03 Benoit Regrain
1243 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1244 * gdcmDicomDir : add the load of directory
1245 * Bug fix and print add-on
1247 2004-02-03 Jean-Pierre Roux
1248 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1249 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1250 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1251 * FIX gdcmParser.cxx : 'group length' elements are now considered
1252 as integers, even for shadow groups, when file is Implicit VR
1254 2004-02-02 Jean-Pierre Roux
1255 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1257 of the last synonym :-(
1258 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1260 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1261 * FIX taking into account the possible 7fe0,0010 multiplicity
1262 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1263 to allow removal of references to 7fe0,0010, to deal with
1264 ACR-NEMA images, when 0028,0200 is meaningfull
1266 2004-01-31 Jean-Pierre Roux
1267 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1268 no longer writes 'Un' on disk
1269 * FIX SQ elements with actual length are now dealt with corectly
1270 * FIX gdcmFile::WriteBase make the difference, for color images, between
1271 the length (for Palette expanded images)
1272 and Raw Length (non expanded image + Palette)
1273 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1274 (that broke Write). Replaced by UL.
1275 Aware user will reload the field if he
1276 thinks it's necesssary
1278 2004-01-30 Jean-Pierre Roux
1279 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1280 when 'dirty Acr' is found, to be compliant with the new
1281 IsReadable() methods.
1283 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1284 (no DOUBLE images in kosher DICOM,
1285 but so usefull for people that miss them ;-)
1287 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1288 DICOMDIR related utilities (not checked as Windoze compliant)
1290 2004-01-28 Jean-Pierre Roux
1291 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1293 2004-01-27 Jean-Pierre Roux
1294 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1295 to allow skipping the shadow elements, to save memory space.
1296 The TRUE value for this param has to be used
1297 with a FALSE value for the 'enable_sequence' param.
1298 ('public elements' may be embedded in 'shadow Sequences')
1299 * gdcmHeader methods now deal with 'embedded icones images' in the header
1300 (even when an 'icone image sequence' is announced by the
1301 element (0x0088,0x0200), but there is NO icone at all ...
1303 * gdcmHeader sometimes Image Location value doesn't follow
1304 the supposed processor endianity (see gdcmData/cr172241.dcm).
1307 * gdcmHeader add the method
1308 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1309 to get *all* the Header Entries with the same tag.
1310 GetHeaderEntrySameName is probabely *useless*
1311 (no meaning : Name is *not* an identifier within the Dictionnary)
1313 2004-01-26 Benoit Regrain
1314 * Bug fix in the print of hexadecimal representations. Remove long fields
1315 in the print and add a third level of print to print them
1317 2004-01-23 Benoit Regrain
1318 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1319 * Bug fix on test suite after remove the strip made on not string fields
1320 * Split the IsReadable method between gdcmParser which test that the file
1321 is dicom and gdcmHeader which test that it's an image file
1323 2004-01-22 Benoit Regrain
1324 * DicomDir : clean code, add methods, set variables in protected or private
1325 * gdcmUtil : bug fix for the clean string method
1327 2004-01-19 Benoit Regrain
1328 * Add the use of shadow dictionaries
1329 * bug fix and coding style
1331 2004-01-19 Benoit Regrain
1332 * src/gdcmFile.cxx : bug fix concerning the close of file
1333 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1334 * Add the update of header entries using the shadow library
1336 2004-01-19 Benoit Regrain
1337 * removal of file gdcmHeader2.cxx
1338 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1339 inheriting from gdcmParser. This split is to prepare the integration
1340 of dicom dir parsing
1341 * bug fix under python
1343 2004-01-16 Jean-Pierre Roux
1344 * REM removal of class gdcmHeaderEntrySet
1345 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1346 * ADD add file gdcmHeader2.cxx
1347 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1349 2004-01-15 Benoit Regrain
1350 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1351 entries created while parsing the header. Thus, they will be destroyed
1352 when the gdcmDictSet will be destroyed
1353 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1356 2004-01-15 Benoit Regrain
1357 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1358 made a fatal error because of the memory release at the end of program.
1359 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1360 some memory and vtk seems to have some problems with that.
1361 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1363 2004-01-14 Benoit Regrain
1364 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1365 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1366 * src/*.[h|cxx] : make changes due to class name changes
1367 * gdcmPython/demo/*.py : bug fix due to method names
1369 2004-01-13 Benoit Regrain
1370 * src/*.[h|cxx] : coding style
1371 * vtk/*.[h|cxx] : coding style
1373 2004-01-13 Benoit Regrain
1374 * gdcmPython/testSuite.py : test the readable flag of file for tests
1375 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1376 It's lied to the stl compilation by MSVC (windows, always windows...)
1377 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1379 2004-01-12 Benoit Regrain
1380 * src/*.h : add comments
1381 * src/gdcmDictSet.h : set the method BuildDictPath in public
1382 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1383 directly setted in the source code
1384 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1387 2004-01-09 Benoit Regrain
1388 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1389 * setup.py : use a reference to gdcmVERSION
1391 2004-01-07 Benoit Regrain
1392 * Modification to compile with the distutils.
1395 2003-12-10 Benoit Regrain
1396 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1397 can use a gdcmHeaderHelper to load datas
1398 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1399 made in the source code
1401 2003-12-10 Benoit Regrain
1402 * Update Windows projects and .cvsignore files
1404 2003-11-12 Jean-Pierre Roux
1405 * ENH gdcmHeader constructor has one more parameter (default value : false)
1406 that allows the user to 'go inside' the SeQuences only
1408 gdcmElValSet:Print takes it into account
1410 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1411 * ENH: Update gdcmPython/CMakeLists
1412 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1413 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1415 2003-11-10 Jean-Pierre Roux
1416 * FIX : gdcmHeader::LoadElements is now based
1417 on the ListTag listElem member,
1418 not longer on the TagElValueHT tagHt member
1419 * ENH : PrintPubElVal shows (temporarily) both results,
1420 with the tagHt member and the listElem member.
1421 (it's easier to 'see' the problems when using Printheader)
1423 * FIX : old private member LgrElem is now splitted into
1424 ReadLength : Length actually found on disk (updated only
1425 if bug fixing is necessary), for internal
1427 UsableLength : Updated by FixFoundLength, to fix a bug
1428 or to allow Parser going on.
1429 Will allow to re-write a kosher header when a SeQuence
1430 with a length (not 0000) is found
1431 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1432 because gdcmElValSet::Add does not update ListElem
1435 2003-11-07 Jean-Pierre Roux
1436 * FIX misstyping in Transfert Syntax name table
1437 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1438 when they have an actual length (not 0000 nor FFFFF)
1439 (Nobody should care of it, but DICOMDIR explorers)
1441 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1442 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1444 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1445 * ENH: vtkGdcmReader now supports LUT !
1446 (vtkgdcmViewer for now is not able to use them though)
1448 2003-11-05 Jean-Pierre Roux
1449 * in testSuite.py : new files names for checking the package
1450 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1451 that returns the pixel area size to the *aware* (vtk) user
1452 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1454 2003-11-05 Benoit Regrain
1455 * in testSuite.py : Modify the rules for checking the paths
1456 : Explicit error messages
1457 * in __init__.py : Related modif
1459 2003-11-03 Jean-Pierre Roux
1460 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1461 to be used by aware (vtk) users that want to manage
1462 LUT (and no to turn the PALETTE image into an RGB pixels one)
1463 * GetPixelType now returns 8U for 24 Bits images
1464 (vtkGdcmReader compliant)
1466 2003-10-31 Jean-Pierre Roux
1467 * Removal of *all* gdcmData images and add them again
1468 in order to loose the 'history' of un-anonymised images
1470 2003-10-31 Jean-Pierre Roux
1471 * RMV : removal of useless jBitsInJsample.h
1472 for both 8 and 12 Bits JPEG Lossy Libraries
1474 2003-10-31 Jean-Pierre Roux
1475 * ENH : Add the functions gdcmFile::GetImageDataRaw
1476 gdcmFile::GetImageDataIntoVectorRaw
1477 that act as GetImageData and GetImageDataIntoVector
1478 except the making of an RGB Plane from Gray Plane + LUT
1479 Intended to aware (vtk) users who know how to manage
1482 GetLUTRGBA return a R,G,B,A LUT if any
1483 lgrTotaleRaw gives the 'Raw' length
1484 GetImageDataRaw returns the gray Plane
1485 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1486 (They stay Grey, just like with other Dicom viewers :-(
1488 2003-10-30 Jean-Pierre Roux
1489 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1491 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1492 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1493 being coherents dicom files.
1495 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1496 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1498 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1499 * ENH: Two steps is necessary to please VC++ compiler...
1500 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1501 * ENH: Add include dir to medcon lib
1502 * FIX: only one function is being exported for now !
1503 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1505 2003-10-29 Jean-Pierre Roux
1506 * adding gdcmHeader::GetLUTRGBA
1507 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1508 --> Mathieu, the modif u're waiting for is not yet committed
1509 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1511 2003-10-27 Jean-Pierre Roux
1512 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1513 00191113.dcm DermaColorLossLess.dcm
1514 MxTwinLossLess.dcm RadBWLossLess.dcm
1515 * ENH: For version prior to vtkImageViewer2 -r 1.19
1516 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1518 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1519 * Removal of ido stuff in CMakeLists.txt
1521 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1522 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1523 * FIX: remove a call to ->Modified ... see comments
1524 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1526 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1527 * FIX: Problem with path for libvtkgdcmPython
1528 * ENH: Try adding a search script for python site-package
1529 * RMV: Remove some file from medcon lib that are not necessary
1530 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1531 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1532 * FIX: More pragma disable fro VC++,
1533 I don't think I break something as it is also disable in VTK/ITK.
1534 But it fasten debug compilation time.
1536 2003-10-23 Jean-Pierre Roux
1537 * gdcm now deals with 16 Bits Run Length Encoded images
1538 (they are compressed as 2 planes images,
1539 one for the high Bytes, the other for low Bytes)
1541 2003-10-22 Jean-Pierre Roux
1542 * Now CheckRead takes into account :
1543 - the bugged 'Leonardo' Siemens images
1544 - the XA images, sent thru the burning VPRO station
1545 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1548 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1549 * FIX: When copying a Makefile.am to CMakeLists.txt
1550 one should remove the '\'
1552 2003-10-22 Jean-Pierre Roux
1553 * in gdcmData adding a bugged 'Leonardo' Siemens image
1554 (wrong lengths in header)
1555 OK with gdcm, KO with the other viewers :-)
1556 * add a GE dlx XA image, thru the VEPRO burning station
1559 2003-10-21 Jean-Pierre Roux
1560 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1561 for a brutal checking of vtkgdcmViewer compliance
1563 2003-10-21 Jean-Pierre Roux
1564 * add the files for 'xmedcon' Jpeg Lossless library
1565 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1567 2003-10-21 Jean-Pierre Roux
1568 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1570 2003-10-21 Jean-Pierre Roux
1571 * garbage Siemens 'Leonardo' images dealt with
1572 (the patch is easy to remove)
1573 * cosmetic changes to avoid warnings
1575 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1576 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1577 no need to press 'r' now.
1579 2003-10-20 Jean-Pierre Roux
1580 * upgrade of checkRead.sh checkWrite.sh according
1581 to new Jpeg Lossless decompressor
1582 * add US.3405.1.dcm, a genuine RGB medical file ...
1583 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1584 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1586 2003-10-15 Jean-Pierre Roux
1587 * general anonymisation in gdcmData
1588 * adding the 'color files' from
1589 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1590 * adding some well knowed bugged-header images
1591 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1592 waiting for their inclusion in Python testsuite
1594 2003-10-15 Jean-Pierre Roux
1595 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1596 no longer seg faults when file is not found
1598 2003-10-14 Jean-Pierre Roux
1599 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1602 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1603 * TODO: *.in file to genereate a UseGDCM later
1605 2003-10-14 Jean-Pierre Roux
1606 * Some supposed-to-be Dicom Images have no preamble.
1607 OpenFile takes it into account
1608 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1609 * Missing elements added in dicomV3.dic
1610 (just to be affraid : have a look at
1611 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1612 and do it again next year ;->
1614 2003-10-13 Jean-Pierre Roux
1615 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1616 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1617 But there are NOT. It's fixed !
1619 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1620 * FIX: "jpeglib.h" was not found on VC++
1621 * FIX: vtkgdcm was not being installed
1623 2003-10-10 Jean-Pierre Roux
1624 * ENH : OpenFile closes the file if it *really* doesn't look like
1625 an ACR-NEMA / DICOM one.
1626 * FIX : testWrite no longer writes an empty file if the source file
1627 is not gdcm Readable
1628 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1631 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1632 * FIX: CMake generate now documentation
1633 * ENH: out of source doc build !
1634 * ENH: Generate both user and dev documentation
1635 * ENH: Should work on windows too
1636 * ENH: Only one doxygen config.in file is needed
1637 * FIX: make install should be ok now on ùnix plateform
1638 * FIX: PATH to dictionary was wrong (missing /)
1639 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1641 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1642 * vtkGdcmReader is now able to read rgb dicom file.
1643 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1644 * added a gdcmViewer to vtk test, use mouse to control
1645 window level & window width
1647 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1648 * CMake-ification of gdcm, we have now two build system
1649 * FIX: on cygwin Wsock32 doesn't exist
1650 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1652 2003-10-06 Emanuel Ollart
1653 * FIX : compilation process wad broken.
1654 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1656 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1657 * change gdcmViewer -> vtkgdcmViewer
1658 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1660 2003-10-06 Jean-Pierre Roux
1661 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1662 ( e.g : well known GE images with a wrong elem length,
1663 : Philips MRI Images with a wrong Huffman table)
1664 * still to be done : allow the reading of bugged LEONARDO Siemens images
1666 2003-10-03 Jean-Pierre Roux
1667 * Odd length strings are padded with '\0' (not with spaces,
1668 to remain compliant with already defined strings,
1669 like Transfert Syntax UID and others)
1671 2003-10-03 Jean-Pierre Roux
1672 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1673 to allow displaying RGB images (not only by affim ;-)
1675 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * vtkGdcmReader is now able to read rgb dicom file.
1677 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1679 2003-10-03 Jean-Pierre Roux
1680 * A few nasty patches to allow the reading of a lot of nasty images
1681 ( e.g : well known GE images with a wrong elem length,
1682 : Philips MRI Images with a wrong Huffman table)
1683 * still to be done : allow the reading of bugged LEONARDO Siemens images
1685 2003-10-03 Jean-Pierre Roux
1686 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1688 2003-10-03 Jean-Pierre Roux
1689 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1690 to allow displaying RGB images (not only by affim ;-)
1692 2003-10-03 Jean-Pierre Roux
1693 * gdcmFile::GetImageDataIntoVector now
1694 - deals with MultiFrames MultiFragments Run Length Encoded files
1695 - deals with YcBcR (YBR_FULL) files
1696 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1697 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1699 (no sample found :-(
1701 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1703 Two reasons: - clear things
1704 - third parties acces gdcm through header files, so won't
1705 suffer anymore VC++ complains
1707 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1708 * add argv[1] in testvtkGdcmReader.cxx
1711 2003-09-24 Jean-Pierre Roux
1712 * The lines are now eigthy characters long.for
1713 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1715 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1716 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1717 char* to std::string. Thus, the use of strdup becomes useless. (see
1718 previous commis of Malaterre)
1719 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1720 before the last Malaterre's commit.
1722 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1723 * This commit should fix the Debug building under VC++, the problem
1724 was mainly a mixture of debug and release lib being loaded at startup.
1725 * I also remove a depency to a specific C function: strdup. Because I had
1726 to force the link to msvcrtd (whereas strdup is in libc).
1728 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1729 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1730 located in the gdcmCommon.h file. All use of reference of tha has been
1731 changed to now use the variable GDCM_UNFOUND.
1733 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1735 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1736 Dicom dictionary. The test suite can now be run again. Note:
1737 I'm note very happy with the " (RET)" changes. I believe this
1738 RETAINED comment should be dropped when parsing the dictionary.
1739 - PACKAGER corrected
1741 - AUTHORS updated and now in alphabetical order
1742 * Makefile.am now exports gdcm.dsw for Windoze users.
1744 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1745 * cygwin complains about missing std:: in subdir Test/
1747 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1748 * remove some methods that are now in gdcmHeaderHelper
1750 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1751 * vtkGdcmReader set spacing and origin correctly
1753 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1754 * Fix a few delete/delete[] mismatch
1756 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1757 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1758 interpretation to data given by gdcmHeader. For instance there are
1759 heuristics to get informations (look at different places).
1760 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1761 sorting DICOM images based on different strategies.
1762 * modified Makefiles accordingly.
1764 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1765 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1766 when building in debug mode
1767 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1768 src/win32/gdcmdll.dsp
1769 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1771 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1772 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1775 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1776 * src/win32/libgdcmjpeg12.dsp was not dos format
1777 * src/win32/libgdcmjpeg12.dsp :
1778 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1779 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1781 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1782 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1784 * src/gdcmFile.cxx : bug fix in affectation type
1785 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1786 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1787 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1788 symbols... future problem ?
1790 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1791 * src/win32/libgdcmijpeg12.dsp was missing
1792 * modified gdcm.dsw accordingly
1794 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1795 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1797 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1798 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1799 commit of JPR (before his hollidays to facilitate our work).
1800 * setup.py : bug fix in code. Modifications made while the last commit
1801 of JPR. The code hasn't been tested before the commit... it's so
1802 useless to make that (for best programmer that is JPR) !!!
1804 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1805 * tagged the current version as Version0_3 (i.e. version 0.3)
1807 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1808 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1809 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1810 * *.dsp : modifications to use new libgdcmijpeg8 library
1811 * setup.py : bug fix on VTKPATH variable
1812 * PACKAGER : adding all concerning windows
1814 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1815 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1817 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1818 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1819 test suite reported error.
1820 * PACKAGER file added (describes what a packager must do when
1821 packaging a new release).
1822 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1823 * configure.in: upgraded version number to 0.3.0
1824 * fixing build of rpm (through rpm -ta):
1825 - Doc/Makefile.am exports proper doxygen files
1826 - src/jpeg/libijg8/Makefile.am exports the include files.
1828 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1829 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1830 * src/gdcmHeader.h : formatting code
1832 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1833 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1834 We were obtaining error message from vtk. Now, creation of file list
1835 is made in an internal list to prevent this problem.
1836 Bug fix when output is empty.
1837 Bug fix in update of progress value. Previous commit for this was a bad
1839 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1841 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1842 * src/gdcmHeader.h : added method to get the file name
1843 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1844 files. Added method to remove all files on the input
1845 Added FIXME comment concerning the bad parsing of header made by
1846 ExecuteInformation method (in ExecuteData method)
1848 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1849 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1850 when using make instal.
1851 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1852 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1854 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1855 * setup.py : adding include dir of jpeg lib to compile all sources
1856 * */Win32/*.dsp : JPR fix for windows compilation
1858 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1859 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1861 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1862 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1864 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1865 * setup.py is again effective on un*x (takes into account the
1866 addon of the jpeg library)
1867 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1868 * Doc/Doxy* updated (includes above enhancements)
1869 * INSTALL now points to web documentation
1871 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1872 * src/gdcmHeader.h doesn't make unnecessary reference to
1874 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1876 * src/gdcm*.[cxx|h] :
1877 - to allow compilation with gcc 3.x
1878 -- clean up of STL usage (added explicit usage of std::)
1879 -- small fixes on exceptions.
1880 Note: linking not tested !
1881 - clean of doxygen comments to avoid warnings at documentation
1883 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1884 dependent convertion).
1886 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1887 * Clean up of previous JPR garbage commit (not even commented in the
1889 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1890 - moved all jpeg related files from src to src/jpeg/libijg8, with
1891 addition/modification of Makefile.am and configure.in.
1892 - the testSuite is still brain damage (not guilty).
1894 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1895 * WrapVTK.py : modifications to get correctly vtk source files to
1897 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1898 (FileName -> Filename)
1900 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1901 * vtk/vtkGdcmReader.[cxx/h]:
1902 - UpdateProgress method should now be effective
1903 - removed the limitation on having only images loaded (as opposed
1905 - when building a stack of images/volume, a lesser number of
1906 gdcmHeader and gdcmFile instances should be used (hopefully
1907 accelerating things).
1908 - when building a stack of images/volumes, files which are not
1909 loadable (wrong path-filename, wrong permissions on existing file,
1910 or file not parsable by gdcm) are replaced with a black image
1911 in the stack (for the caller to notice the problem).
1913 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1916 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1917 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1918 between standard library (std) and vtk library (problems are found
1919 under Windows... thanks Windows !)
1921 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1922 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1924 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1926 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1927 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1929 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1930 * When compiling with distutils (see setup.py) the C++ compiler is
1931 called with different flags than the default ones (with automake).
1932 In order to fix all those warning, I compiled gdcm with the command
1933 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1934 and went for warning fixes:
1935 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1936 up from unused variables.
1937 - vtk/vtkGdcmReader.cxx: potential bug fix.
1938 * src/gdcmHeader.h: Doxygen warning cleanup
1940 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1941 * gdcmPython/gdcm.i:
1942 - typemaps correction to take into account the systematic replacement
1943 of "using namespace std" with std:: prefix e.g. std::list,
1944 std::string... (cf changes of 2003-05-21).
1945 - gdcmGlob global variable of type gdcmGlobal (defined in
1946 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1947 exported to Python a as cvar.
1948 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1949 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1950 gdcmDictSet.GetPubDictTagNames() and
1951 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1952 C++ static methods).
1953 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1954 with the above changes.
1956 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1957 * setup.py, manifest.in : bug fix under linux
1959 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1960 * Modification of setup.py to compile vtk part too. Then, we have 2
1961 wrappers which must work with same distutils. For that, we have a
1962 generic distutils in distusiltsWrapping.py ; with :
1963 - build_extWrap class to wrap generically all extensions,
1964 - ExtensionWrap base class for all wrapping extension that contains
1966 - Wrapper interface which wrap sources
1967 + In WrapSwig.py we have extension and wrapper for Swig
1968 + In WrapVTK.py we have extension and wrapper for VTK
1969 * MANIFEST.in : modifications to consider vtk directory and new python
1970 files for compilation
1972 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1973 * Added python wrappers of vtkGdcmReader vtk class (see the
1974 source in vtk/vtkGdcmReader.cxx) :
1975 - vtk/Makefile.am now builds a library
1976 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1977 python library (as opposed to _gdcm.so wich are the python
1978 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1979 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1981 - configure.in has an additional flag --enable-vtk that needs
1982 to be set to enable compilation of vtk related code, that is:
1983 + vtk/vtkGdcmReader.so and
1984 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1985 + gdcmPython/vtkgdcmPython.so (see above)
1986 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1987 be read when compressed or when HighBit + 1 != BitsStored),
1988 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1989 the usage of the python wrapper of vtkGdcmReader vtk class.
1990 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1991 * src/*.[h] all occurences of stl classes are now prefixed with
1992 std::, and all occurences of "using namespace std;" where removed.
1993 This is to avoid pollution of global namespace in included files.
1994 Apparently vtk does not avoid this pitfall: when using both
1995 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1996 collision of various stl members (principally cout...).
1997 * gdcmPython/testSuite.py now cleanly removes temprory generated
1999 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2000 comply with above changes)
2002 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2003 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2004 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2005 vtk data structure (an image Flip was required).
2006 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2007 * cosmetic changes in documentation.
2009 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2010 * src/gdcmHeader.cxx: the constructor no longer exits when an
2011 unexisting file is given as argument.
2012 * The subdirectory Data (containing all the images used for the
2013 test suite) is not part of this repository anymore. A new module
2014 containing those images is now available at
2015 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2016 with the name gdcmData.
2017 All the python scripts (including the package initialisation file
2018 gdcmPython/__init__.py) were adapated to take this change into
2019 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2021 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2022 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2023 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2024 demo of the usage of this class.
2025 Compilation of this vtk part is only done when using the --enable-vtk
2026 at configure (or autogen.sh) stage.
2028 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2029 * More memory link related corrections and documentation fixes.
2031 - maximum info is obtained with a command of the form:
2032 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2033 --show-reachable=yes PrintHeader
2034 - the remaining reachable blocks seem to come from the STL
2035 allocation scheme through the usage of map and list. It looks
2036 like this memory cannot be freed but it is not a memory leak
2037 (in fact further invocation to the STL would recollect the
2038 unused memory allthough it cannot explicitely be freed).
2039 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2040 of displaying an image parsed with gdcm and displayed with VTK.
2041 Note: some images don't seem to work e.g.
2042 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2043 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2044 Allthough this weakens the semantics, it is a ditch attempt to
2045 make gdcm more thread friendly.
2047 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2048 * Memory link hunt (by using valgrind through the command
2049 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2050 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2051 gdcmHeader::_dicom_vr.
2052 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2053 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2055 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2057 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2058 * src/Makefile.am now exports all the necessary include files at
2062 * UpdateGroupLength replaced by new one
2065 * UpdateGroupLength re-written using H-Table
2066 (named UpdateGroupLengthNew untill checks are over)
2068 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2069 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2070 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2072 - gdcmHeader::GetPubElValSet removed.
2073 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2074 UpdateGroupLength, WriteElements, Write.
2075 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2076 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2077 carried the same semantics.
2078 - src/gdcmHeaderIdo.cxx changed accordingly.
2079 - gdcmFile::WriteBase now regroups all the codes from previous
2080 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2081 - enum FileType moved to gdcmCommon.h
2082 * src/gdcmHeader.cxx AddDefault trashed
2083 * gdcmGetXSize added
2084 * getimageDataSize now calls gdcmGetXSize
2085 * Test/*.cxx changed to agree with above changes
2087 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2088 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2089 (to avoid double call by end user).
2090 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2091 by end user, since gdcmHeader::gdcmHeader now handles it.
2093 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2094 * gdcm/Doc many doxygen changes:
2095 - Doxyfile now has two different versions, DoxyfileUsers that generates
2096 the html.users end users oriented documentation and
2097 DoxyfileDeveloppers that generates the html.developper developper
2098 oriented documentation.
2099 - README changed accordingly
2100 - requirement.txt removed (old design info moved to TODO).
2101 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2102 DoxyMainPage.txt, DoxyPython.txt provide more information.
2103 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2104 be updated by simply regenerating the docs with doxygen and copying
2105 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2106 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2107 all the tests in the form "if (<map>.count() >1)" were removed.
2108 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2109 ill-formed documentation sections.
2110 * src/gdcmHeader.cxx: ditto
2112 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2113 * setup.py fixed for un*x (needed macro for stdint.h)
2114 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2115 un*ces with sh-utils test utility.
2116 * gdcmPython/demo/test.py renamed to PrintHeader.py
2117 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2118 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2119 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2120 * src/gdcm*.cxx JPR's bad inclusion fixed.
2122 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2123 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2124 * gdcmPython/demo/test.py changed accordingly.
2126 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2127 * gdcmPython/Makefile.am fixed linking against libstdc++
2128 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2129 * Swig subdir (historical tests of swig version 1.3.17++) removed
2130 * Test/testChangeEntete.cxx some lines commented out in order to make
2132 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2133 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2135 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2136 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2137 hence the user doesn't need this explicit call.
2138 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2139 i.e. LoadElements() call removed.
2140 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2141 - src/Makefile.am declares the proper flag for g++.
2142 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2143 for adding user defined new tags.
2144 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2145 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2146 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2148 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2149 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2150 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2151 src/Makefile.am : the project should properly compile and install
2152 with the autotools, included the python wrappers part.
2153 * gdcm.spec.in : added a spec file for RPM packaging.
2155 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2156 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2158 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2159 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2160 to exported to the environement (see gdcmPython/testSuite.py
2162 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2163 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2164 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2165 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2166 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2168 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2169 * gdcmPython/__init__.py doesn't crash anymore when running in
2170 in InstallMode or PreInstallMode but with an environement given
2171 value of GDCM_DICT_PATH.
2172 * src/gdcmDictSet.[cxx/h] coding style.
2174 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2176 * src/gdcm.h general comments moved to TODO, and README
2177 * src/gdcm.h should now be seen as a user commodity (including it
2178 should suffice to fully use gdcm). It is nowhere including within
2179 any of the kernel files src/*.cxx and src/*.h.
2181 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2182 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2183 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2185 * src/gdcm*.cxx only include their corresponding include file
2186 (as opposed to gdcm.h)
2187 * gdcmPython/gdcm.i changed accordingly
2188 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2189 the autogen.sh generated "make snapshot" command to work.
2190 * autogen.sh removed history related references to crea package.
2192 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2193 * distutilsSwigCPlusPlus.py work around some swig portability
2196 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2197 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2198 was done in a last ditch attempt to get setup.py _really_
2199 operationnal. The python/gdcmPython layaout add the advantage
2200 of hidding away the python related distutils specific files
2201 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2202 Alas, the src directory was out of scope (i.e. it's relative
2203 position to setup.py was ../src) which made things impossible to
2204 handle (see previous version of python/setup.py). Crossing fingers...
2206 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2207 * python/setup.py now works on Un*x. (harder than I thougth)
2208 * python/distutilsSwigCPlusPlus.py can now have include files
2209 among the list of sources.
2211 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2212 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2213 * modifications in MSVC projects
2215 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * As stated by the first lines of Test/ExceptionAndPython/README, it
2217 looks like we can move back to original usage of exception within
2218 src/gdcm* and hence remove the errno stuff that was introduced
2219 as a quick and dirty fixture of this problem (added to the TODO).
2220 * Doc/Doxyfile configuration file for Doxygen and corresponding
2221 README file for usage added.
2222 * Test/testWrite.cxx added. This new test comes from a split of
2223 test.cxx that is now reverted to its original purpous i.e.
2224 testing the proper parsing of a Dicom related file.
2225 testWrite.cxx concentrates on testing the IO part of gdcm.
2226 * Test/bug1.cxx (containing a bug on WIn32) added.
2227 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2228 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2229 whose purpose is to publish the content of the TagNames of the
2230 Dicom public dictionnary were not accessible without an
2231 instance of class gdcmHeader.
2232 - those methods are now static methods of gdcmDictSet and hence
2233 require no instances at all to be invocated.
2234 - within gdcmDictSet this change required to change some method
2235 to class methods (i.e. are now static) among which SetDictPath
2236 (renamed to BuildDictPath) and LoadDefaultPubDict.
2237 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2238 the above changes by calling the new method classes of gdcmDictSet.
2239 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2240 the above to be effective.
2241 * python/gdcmPython: in order to wrap properly the above changes
2242 for Python, swig version now needs to be > 1.3.17.
2243 * python/gdcmPython/Makefile fixed to adapt itself to new
2244 configure/make shema introduced by Johan Montagnat (thanks for the
2245 contribution). Alas this Makefile cannot be turned into a proper
2246 Makefile.am without some heavy changes in the configure.in
2247 (for python dectection).
2248 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2249 now avoids publishing the empty entries.
2251 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2252 * python/setup.py : bug fix concerning install under windows
2253 ExtraPath reused :-P
2254 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2256 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2257 * Dicts/dicomV3.dic : remove double spaces !!!
2258 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2259 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2262 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2264 method. Doxygenation.
2265 * src/gdcm.h clean up of JPR spurious comments.
2267 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2268 * python/distutilsSwigCPlusPlus.py now properly collects the
2269 shadow classes generated by "swig -c++" (gdcm.py in our case)
2270 when using "python setup.py install".
2271 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2272 reexports the working classes.
2273 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2274 by the classical C errno scheme. This is to prevent an obscure
2275 behavior of the python wrappers when importing wxPython.wx prior
2276 to gdcmPython (which ended up in an abort call). An illustration
2277 of this oddity can be found in the Test/ExceptionAndPython
2278 subdir (see the README file). This problem probably due to
2279 an combination of g++ and dynamic loading.
2280 * added Test/ExceptionAndPython (see above)
2282 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2283 * Changed the layout of the python part to avoid bloating main
2284 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2285 i.e. the distutils arsenal. All the python related stuff is
2286 again in a python subdir, but the package itself is now in
2288 * setup.py was cleaned up:
2289 - pythonIncludePath removed
2290 - python setup.py bdist target is now functional.
2291 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2292 collision with other packages). gdcmPython/demo/*.py changed
2295 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * python subdir moved to gdcmPython (preparation of distutils packaging).
2297 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2298 distutils installer is operational.
2299 * - gdcmPython/__init__.py now properly loads the swig generated
2300 shadow classes (from gdcm.py).
2301 - gdcmPython/demo/*.py changed to import the package gdcmPython
2302 instead of gdcmPython/demo/load.py.
2303 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2305 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2306 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2307 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2308 entries within the associated public Dicom dictionary resp. the same
2309 information but sorted by the fourth field (PAT, IMG, DIR) of the
2311 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2312 are now in the "???" group.
2313 - python/gdcm.i changed accordingly,
2314 - python/demo/printGroupedPublicDict.py added, that gives an example
2315 of the above new functionalities in Python.
2317 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2318 * src/gdcm.h, gdcmHeader.cxx:
2319 - historic references to glib's g_malloc and g_free (#defined)
2320 were definitively removed.
2321 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2322 * src/gdcmElValSet.cxx:
2323 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2324 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2325 - GetElValue(string) renamed to GetElValueByName.
2326 - Added GetElementByName(string).
2327 * src/gdcmHeader.cxx: added
2328 - GetPubElValRepByNumber(guint16, guint16)
2329 - GetPubElValRepByName(string)
2330 - GetShaElValRepByNumber(guint16, guint16)
2331 - GetShaElValRepByName(string)
2332 - GetShaElValByNumber(guint16, guint16)
2333 - GetShaElValRepByName(string)
2334 - GetElValRepByNumber(guint16, guint16)
2335 - GetElValRepByName(string)
2336 - GetElValByNumber(guint16, guint16)
2337 - GetElValRepByName(string)
2338 * Doc/requirements.txt added.
2340 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2341 * Test/Makefile building now depends on the one of libgdcm.so
2342 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2343 pixel data) aware which enables finding the address (offset) of
2344 the pixel data of JPEG encoded DICOM files. This leaves only a single
2345 file in the testSuite whose pixel data address (offset) is unknown.
2346 * python/testSuite.py changed accordingly.
2348 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2349 * VC++ has some strong limitations when working with the STL, as stated
2350 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2351 "Also note that some STL containers (map, set, queue, list, deque)
2352 cannot be exported. [...]
2353 Some STL classes contain nested classes. These classes can not
2355 This is caused by a designed limitation that once a template
2356 class is instantiated, it can not be re-instantiated and
2358 Since our usage of map<> is ubiquitous in gdcm, this "designed
2359 limitation" of VC++ is a pitfall.
2360 Hence the Python wrappers of gdcm cannot be incrementally linked
2361 against the c++ dynamic library. The dirty but only workaround is
2362 to forget about incremental link of dynamic libraries and to generate
2363 the Python wrappers library with the inclusions of the underlying C++
2365 The following modifications concern this matter on Win32/VC++:
2366 - wrapping python correct with standalone wrapped dll (don't use separate
2367 dll under windows !!!!)
2368 - python21_d debug mode enabled (ask Frog how to use it :-)
2369 - NO problem with having an STL member of class for example string in C++
2370 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2371 - Python test of dcmlib in Python is ok under windows on a large set
2373 * removed glib references
2374 * typedef's inserted in gdcm.i for correct swig type management
2376 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * python/demo/*.py load.py extracted from test.py. Added explore.py
2378 that only displays required tags and testAll.py that parses all
2379 the files of the testsuite without using unittest.
2380 * python/testSuite.py other additional test on new files added.
2381 * Data/* new test files added accordingly to the testSuite.
2382 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2383 the vr in the file differs from the one of the dictionary.
2385 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2387 values, but limits itself to values which are below a user specified
2388 size (by default 1024 bytes).
2389 * python/gdcm.i : elements not loaded (because their size is above the
2390 user specified treshold) are exported with their TagKey as key of the
2391 python dictionary. This enables the testsuite to make some checks
2392 on the unloaded elements (since we have their offset and size).
2393 * python/testSuite.py
2394 - now tests for the existence and proper value of the pixel data
2395 - two new examples added.
2396 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2398 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2400 aware. See the strategy comments in gdcmHeader::FindeLength().
2401 * Test/test.cxx now accepts a filename as first argument.
2402 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2403 * python/testSuite.py changed to integrate test on above files.
2405 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2406 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2407 the vr was also RET.
2408 * python/testSuite.py more tests added.
2410 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * python/testSuite.py unittest test suite added (uses Data)
2412 * Data/* dcm and acr files for the test suite.
2413 * glib dependance removed from un*x version. We now use ISO C99
2414 7.18 Integer types (see stdint.h)
2415 - python/Makefile, src/Makefile src/gdcm.h
2416 * src/ when an explicit vr (like dicom files) suddenly poped an
2417 implicit element we use to mark the underlying DictEntry of the
2418 concerned ElValue with "Implicit". This strategy was damageable
2419 too the public or provite dictionaries, since some of their vr
2420 would be changed. Since Header::FindLength heavily relies on the
2421 detection by Header::FindVR of falsely explicit elements, I
2422 added an extra ImplicitVr member to ElValue (boolean).
2423 The rest of the changes we the necessary adaptations.
2425 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2428 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2430 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * Adaptation for porting to VC++:
2433 o forced to use std namespace (for string to be known)
2434 o all class use __declspec export style on WIN32
2435 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2436 (in stdlib.h on Win32 but in std:: for gcc)
2437 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2438 variable GDCM_DICT_PATH.
2439 * src/gdcmHeader.cxx verbose comments made discrete.
2441 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2442 * python/gdcm.i: added a typemap that converts a C++ hashing table
2443 to native Python dictionary.
2444 * python/demo/test.py:
2445 - now uses the native dictionary for exploration of gdcmHeader.
2446 - takes an optional filename argument (the file to parse).
2447 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2448 PubElVals hashing table.
2449 * Dicts/dicomV3.dic removed error prone trailing spaces.
2451 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * Python wrapping process moved away from src/Makefile to
2453 newly created python/Makefile (as well as gdcm.i)
2454 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2455 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2456 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2457 from the environement variable GDCM_DICT_PATH (when existing).
2458 * src/gdcmDict::GetTag bug fix.
2460 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2461 * Straightforward temporary fixes for swig to build the python wrappers.
2462 src/Makefile now has a python working entry [by working we mean
2463 that we can import de shadow classes without errors].
2465 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * hashtest.cxx removed (since allready in Test)
2467 * src/gdcmlib.h renamed to src/gdcm.h
2468 * src/dcm.i renamed to src/gdcm.i
2469 * src/Makefile prepared for python wrapping
2471 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2472 * src/gdcmHeader.cxx :
2473 - Parsing of header is now separated from loading of element values
2474 (see gdcmHeader::LoadElements).
2475 - general clean up of hopefully all file access (creation of
2476 ReadInt16 and ReadInt32)
2478 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * src/gdcmHeader.cxx :
2480 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2482 - SetLgrElem renamed to SetLength
2483 - GetLgrElem renamed to GetLength
2484 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2485 * src/gdcmElValSet.cxx fixed both GetElValue methods
2486 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2487 due to IdoDude was cleaned out.
2489 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2490 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2491 concentrates on finding the value representation (when it exists).
2492 RecupLgr now only finds the element value length, and it avoids
2493 returning the unecessary skL (skipped length).
2494 Also, offsetCourant was simply removed (with taille_fich) since
2495 it was redundant with the File position internals (by using
2496 ftell and fseek). This also made skL (see above in RecupLgr) usage
2498 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2499 on the libido specificities which are handled through class
2501 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2504 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2505 * Truckload of changes. Parsing of header is barely functional
2506 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2508 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * src/gdcmHeader.cxx many addons of low level methods
2511 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2512 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2513 and _IdDcmSWAP_LONG.
2515 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2516 * This corresponds to all the changes decided at the meeting of
2517 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob