1 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
3 replace the different values "??", "Unkn", "Unknown".
4 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
5 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
6 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
7 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
9 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
12 * Set the gdcm::Base class to some Printable classes
14 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * src/gdcmFile.[h|cxx] : add the Print method
16 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
17 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
18 * src/gdcmDocument.h : remove the PrintLevel informations
19 * Example/PrintFile.cxx : use the new gdcm::File::Print
21 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
23 problems when compiling with the python wrapping
25 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
27 writting in ImplicitVR
29 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
30 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
31 JPEG decompression, especially when dicom frames are split into several
32 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
33 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
35 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/gdcmHeader.cxx : change the initialisation of default header.
37 Now, this header is readable by gdm, e-film, DicomWorks
39 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
41 Rename Decompressed to Raw
42 * Use the API changes in gdcm::File.
43 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
46 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
48 each added entry in the header. Replace the 'Planes' field by the 'Number
51 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
53 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
55 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
57 At this time, this image isn't readable by e-film... waiting JPR help to
60 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
62 DocEntry. Now use methods of the Document !
64 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Test/ShowDicomSeq.cxx : bug fix
67 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
69 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
70 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
71 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
73 * Test/TestCopyRescaleDicom.cxx : remove unused variable
74 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
75 containing found sequences
77 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
80 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
81 Some fields in BinEntry must be copied to not seg fault when making the :
82 gdcm::File *copy = new gdcm::File( copyH );
83 and tests are now made on good variables
85 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
87 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
89 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
90 * Add vtkGdcmWriter example and test
92 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * Test/TestUtil.cxx : reformat the source code
94 * vtk/vtkGdcmReader.cxx : remove and change prints
95 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
97 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
98 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
100 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
102 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
104 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
106 by an eof to prevent all bad read of the file... and in this case, the
109 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * Example/Volume2Dicom.cxx : comment unused variables
111 * Test/PrintDicomDir.cxx : comment unused variables
112 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
113 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
114 method that is redondant with AddEntry.
115 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
118 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * Bug fix due my last commit (compilation under Windows).
120 * Example/Volume2Dicom : bug fix in the file and reformatting source code
121 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
123 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
125 - Remove printf / sprintf
126 - include iostream AFTER gdcm so we don't get warnings
127 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
129 - Also remove tons of include from header files, hopefully this should
130 speeup the compilation time, since it was becoming a dog slow.
131 - Remove gdcm.h as it include way too many files and slow down compilation
132 (plus it is not up to date)
133 - remove 'using namespace std' this is BAD !
135 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * Remove memory leaks on the DicomDir
137 * Remove some useless datas in DicomDirObject
138 * Add usefull methods in SQItem, to be complient withe the ElementSet
140 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
143 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
145 future, with convertion)
146 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
147 and ImageDataSize values. Remove the method to get the PixelReadConverter
148 from the output of the class
150 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
153 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
155 and vtkErrorMacro use.
156 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
158 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
161 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
162 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
163 The string leaves only in the fonction. So when we make a .c_str(), we
164 get the pointeur on the first element, element that will be destroyed
165 immediately after thee instruction.
166 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
167 file has been opened : the test must be made on the content of the
168 pointer and not directly on the pointer !
171 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
173 the python part recompiles
175 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
177 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
178 X session is killed (for my computer... it seems to not be identic on
181 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
183 avoid problems (otherwise, the difference test between the visible image
184 and the reference is incorrect. If the reference is greater than the
185 screen resolution, it's produce errors).
186 Can be used for only one image. Can be used with a visible flag.
187 * vtk/vtkGdcmReader.cxx : remove commented codes.
188 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
189 under windows at compilation
190 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
192 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
194 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
196 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
197 tests on the image size X, Y, Z
199 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
201 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
202 between the class name and the file name
204 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * src/ : fix compilation warnings for the Write method (2 different
206 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
207 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
208 variable... create a static method in gdcm::Document to access to
209 this variable content.
211 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
213 file, to be accessed by other files (like gdcmFile). Remove commented
214 code. Move the change of the header to the gdcmFile, using the
216 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
217 To be sure of that (and simplify calls), the Write of the header now
218 gets a file name and not a file pointer (std::ifstream).
219 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
220 DocEntryArchive. Remove all open of the written file
222 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
225 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
227 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
229 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
230 some corresponding methods. Write correctly the file and check before
232 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
233 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
234 is now on RGB datas (as before my last commit
235 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
237 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
238 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
239 Add a print information of the type of the entry
240 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
241 It was in the gdcmFile, and all write have been regrouped
242 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
243 Write correctly all dicom files (in decompressed mode only at this time)
244 * Test/ : test on files are now made using Raw datas and not color datas if
246 * Example/PrintFile.cxx : add more printings
248 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * Amelioration of code, remove some code copy. For the loading of
250 BinEntry (in gdcmDocument), add the test to verify if the file is already
253 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
255 remove a DocEntry in the header (push an empty DocEntry)
256 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
257 lines. Bug fix in the initialization of the PixelConvert and the
259 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
260 use in TestCopyDicom (now this test can run under windows... but fails)
261 * Test/TestCopyDicom.cxx : amelioration of the test :
262 - test the pixels written
263 - add test points to quickly find where is the error
264 - can set a file name input and output in arguments
265 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
266 amelioration of the test output
268 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
269 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
270 all replaced DocEntry's
271 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
272 Now, each needed DocEntry to modify is duplicated, modified and inserted
273 to the header using DocEntryArchive. Thus, after save, we can restore the
274 header initial state.
276 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
279 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
281 correct to copy it. The DictEntry is specified at the DocEntry creation,
282 then, it musn't change in the time.
283 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
284 header correctly. At this time, the change is only made for the first
285 level of the Document. In the future, it might consider sequences.
286 The change is made by replacing a DocEntry by an other that is created
287 outside the class. The old value is kept. When we restore the header
288 status, the added DocEntry is deleted and replaced by the old value.
289 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
290 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
291 set the write type to explicit VR, implicit VR or ACR. Add methods to set
292 the write mode to native, decompressed or RGB (but not used at this time)
294 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
296 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
298 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
299 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
300 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
302 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
303 set because already copied when copying the BinEntry's of the header
304 * Test/TestAllReadCompareDicom.cxx : remove warnings
306 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
308 Two problems appear when doing it :
309 - with the gdcmFile : when the GetImageData method is called, the pixels
310 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
311 datas (pixels). And each structure destruct the datas when it's
312 destructed. So we have two destructions for the same datas. To solve it,
313 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
314 datas or not. If it doesn't own datas, then they will not destroyed by
316 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
317 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
318 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
319 create a double destruction of the same DocEntry's. So, to solve it,
320 the TagHT is simply cleared and the DicomDir* elements are destroyed.
321 * TODO : add an entry concerning memory leaks in the DicomDir
323 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
325 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
328 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
330 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
331 after it have been deleted
333 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
334 * FIX: src/* fix the doxygen warnings.
335 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
336 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
337 was erroneously defined with a size of 15 instead of 16. [many thanks
338 to Jean Michel Rouet for pointing out this bug].
340 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
341 1. Finish merging JMR patch for writting DICOM from scratch
342 2. Fix -hopefully- bug with MONOCHROME and space vs null character
343 3. Use const ref when possible
344 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
345 5. A few more comments
346 6. CreateUniqueUID can now be called without parameter"
348 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
349 * ENH: Slightly bigger patch:
350 1. Getting toward full integration of JMR patch for writting dicom from scratch
351 2. Update Test to test part of this patch: CreateUniqueUID
352 3. File was not close properly in gdcmDict
353 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
354 5. Use of const ref instead of copy (speed issue)
355 6. Remove temporary (duplicate) string in TranslateToKey
356 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
357 8. Do not repeat virtual in subclasses
358 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
360 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
361 * Apply first patch toward better string comparison when dealing with broken
362 DICOM files. Essentially the string could be padded with a space instead
363 of a null character as defined by standard
365 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
366 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
367 because never used... and in the same time, that's remove some memory leaks
369 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
370 * src/gdcmFile.cxx : now delete the PixelConvert instance.
371 * In examples and tests : change the type of image data variables from void*
372 to uint8_t*. Remmove all delete on image data variables
374 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
376 Verify the file pointer value before open the file, and if it's not null,
377 a verbose message is generated.
378 Close correctly the file when the file isn't considered dicom-like. The
379 correctly close is a call to CloseFile.
380 When closing the file pointer, test if its not null to close the file.
381 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
382 file. For an uncompressed image, the copied datas correspond in the least
383 case to the image size (calculated) or the image size specified in the
384 header. A verbose is generated if these two size mismatch
386 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
387 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
388 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
389 break under windows (with msvc6 compilation).
391 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
393 compiling with MSVC6)
395 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * Bugs fix for the Windows build with VC6
397 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
398 needed (only for projects required VTK). If the VTK is included in all
399 projects, there is conflicts with the jpeg lib of vtk when compiling the
400 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
401 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
402 when compiling the gdcm_wrap.cxx file (created by the compilation of the
404 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
405 (like it's already made for the cout use). Otherwise, conflict with the
408 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
409 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
411 - comments on the DicomDir::Method related usage added.
412 - now that we use the namespace gdcm, a lot of internal classes do
413 NOT need to be wrapped anymore.
414 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
415 DicomDir::Method) new example added.
417 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
418 * Improve string manipulation. I now inforce the notion of 'DicomString'
419 A DicomString can contain as many \0 as they want
420 and it is *always* of even length.
421 We only support odd length for very rare case.
422 And in the near future this should be removed.
424 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
425 * /binary_write/ gdcm source. Now even on big endian we are writting
426 little endian. This should -heopfully- fix some tests
428 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
429 * Now the dictionary is compiled into gdcm lib. This is a default
430 behavior, thus any dic file specified is picked before failback to
431 the one comiled into lib
433 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
434 * Change internals for gdcmDict. Don't use any 'new' any more.
435 This should definitely solve any leak problem, and we should be
436 as fast as before, as long as don't modify too much the dictionary.
438 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
439 * STYLE: ivars should start with a capital letter.
440 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
441 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
443 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
444 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
445 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
446 new 2004 dictionaries added (thanks to JPR).
447 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
448 * CLEANUP_ROUND (15) for gdcmPixelConvert
449 - RLEFrame::NumberFragments is now of type unsigned int
450 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
451 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
454 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
455 * Initial work in gathering all transfer syntax accessors. clearly
456 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
457 ivars, but only one transfersyntax (class) ivar with equivalent method on
460 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
461 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
462 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
463 discussed (plus I didn't like having a 2000 lines patch not commited)
465 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
466 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
467 * CLEANUP_ROUND (14) for gdcmPixelConvert
468 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
469 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
470 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
472 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
473 anymore and hence avoids storing a copy of PixelConvert::Decompressed
474 into File::Pixel_Data.
476 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
478 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
479 * CLEANUP_ROUND (13) for gdcmPixelConvert
480 Substituted File::ParsePixelData() with PixelConvert::Print() new
482 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
483 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
484 method to those classes.
485 - src/gdcmFile.[cxx|h]:
486 -- Added a ::Print() method.
487 -- PixelConverter is now a reference instead of a member.
488 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
489 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
491 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
493 collaboration diagram and inheritance diagram should be generated with
495 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
496 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
497 pointlessly wrapped (see
498 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
499 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
500 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
501 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
502 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
503 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
504 -- File::Initialise: PixelConverter setup moved away to
505 PixelConverter::GrabInformationsFromHeader()
506 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
507 interpretation moved away to PixelConverter::BuildRGBImage()
509 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
510 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
511 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
513 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
515 displayed on Win32 when a brutal abort() occurs (because of uncatched
516 exception). See TODO new entry of this commit for more on this.
517 * TODO added new entry.
518 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
519 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
520 - HandleColor is no longer called from gdcmFile.cxx
521 - gdcmPixelConvert.cxx clean up on method arguments and internal
522 variable names for semantical coherence.
524 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
525 * Finished lossless transition, not only do we now read all lossless jpeg
526 images, without the need of the Cornwell lib, but we do read them properly now
527 * To reduce code (well to avoid code duplication), I defined a common place
528 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
529 redefine symbols. This is not prefect but this the best solution I found for a
530 compilation time jpeg option.
532 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
533 * Update jpeg ijg lib to support lossless jpeg implementation
534 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
536 * Also added a special copyright for dcmtk since we use their bugfixes.
539 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
540 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
541 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
542 matters, as stated in warning note at begining of %include section).
543 * src/gdcmDicomDir*.[cxx|h]: coding style
544 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
545 * src/gdcmJpeg8.cxx: doxygen fix.
546 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
547 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
548 from File:: to PixelConvert::.
550 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
551 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
552 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
553 - more code moved away from File:: to PixelConvert::
554 - fat setup of PixelConverter set in place in File::Initialise.
556 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
557 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
558 namespace at the file system level. So now you should convert your examples
560 gdcmHeader -> gdcm::Header
561 It would be nice if people keep in mind to no open the namespace, since it
562 allows compilation on broken plateform which were defining common symbol in
563 the standart namespace (like LP, Unknown ...)
565 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
567 The JPEG fragments are now parsed at the same stage than the RLE
568 information. All code related to JPEG is now in gdcmPixelConvert:
569 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
570 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
571 export a gdcmFile:: method. Those are simply global functions
572 (for the time being this is better than having them attach to
573 either gdcmFile:: or gdcmPixelConvert::).
574 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
575 and stores the result in a gdcmJPEGFragmentsInfo.
576 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
577 code (among other stuff) moved away from gdcmFile:; to
580 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
582 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
583 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
584 clean up of RLE related code.
585 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
586 - src/gdcmRLE.cxx removed
587 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
588 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
589 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
590 * CLEANUP_ROUND (9) for gdcmPixelConvert
591 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
592 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
593 away from gdcmFile:: to gdcmPixelConvert::.
595 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
596 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
597 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
598 This is because Parse7Fe0 used to parse the pixels to compute the
599 length. This task was passed over to FindDocEntryLengthOB() a long
600 time ago, EXCEPT I had forgotten the OW case...
601 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
602 we just recylce the code for parsing RLE fragments and computing
604 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
605 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
606 with the retired Parse7Fe0().
607 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
608 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
610 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
612 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
613 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
614 - src/CMakeLists.txt: alphabetic order reodering + new entries.
615 * CLEANUP_ROUND (4) for gdcmPixelConvert
616 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
617 to return an unused length.
619 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
620 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
621 this should be cleanner from the plane view. The iostream are erally a pain
622 to use to do simple stuff.
624 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
625 * Redo the compilation of the ijg jpeg library. Now only one source is
626 necesseray. No need to rename file by hand what so ever. CMake handle the
627 copying of the file within different directory, configure header file to
628 modify some symbol. The only addition made to ijg wasd a mangle table so
629 that symbol are different wether we are within 8bits or 12bits.
631 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * Added documentation of vtkgdcmReader on Website:
633 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
634 with it's binary name).
635 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
636 the Website to be more complete.
637 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
638 doxygenated documentation.
639 - Doc/DoxyVtkGdcmReaderExamples.txt added
640 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
641 DoxyVtkGdmReaderExamples.html )
642 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
643 * CLEANUP_ROUND (3) for gdcmPixelConvert
644 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
646 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
647 * CLEANUP_ROUND (2) for gdcmPixelConvert
648 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
650 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
651 * CLEANUP_ROUND for gdcmPixelConvert:
652 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
653 - src/gdcmPixelStuff[h|cxx] removed
654 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
655 - src/CMakeLists.txt changed accordingly
657 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
658 gdcmVersion.py moved to newly created ATTIC related
659 gdcmPython/SetupOldies/ directory.
660 * Autotools clean up:
661 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
662 - autogen.sh configure.in acinclude.m4 python.m4 removed
664 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
665 * src/*.cxx *.h Reference to License.htm fixed to License.html.
666 * Doc/CMakeLists.txt, doxygen.config.in: fix.
667 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
669 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
670 * TODO updated with Mathieu suggestions. I proposed a template for
671 describing TODO entries and used it for new entries.
672 * Added Doc/Website/CodingStyle.html, Developpers.html,
673 DeveloppersPython.html, GdcmDataCvs.html and
674 DownloadVersion0_1.html, DownloadVersion0_3.html.
675 * Some Doc/*.txt Doxygen files (which do not really concern the
676 documentation itself, but the website) moved to html and
677 placed in directory Doc/Website:
678 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
679 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
680 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
681 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
682 * CMakeLists.txt changed accordingly.
683 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
684 DeveloppersPython.html
685 * INSTALL nows refers to Doc/Website/Installation.html
687 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * Added Doc/Website directory, that contains a first raw version
691 2004-09-23 Jean-Pierre Roux
692 * FIX In order not to be poluted any longer by casting problems,
693 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
694 we can now delete[] it safely
695 * VoidArea is now called BinArea (less confusing name),
696 and all the methods called ...VoidArea... are now ... BinArea...
697 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
699 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
700 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
701 clear) TagHT, which is an inherited member of gdcmElementSet. It is
702 up to the destructor of gdcmElementSet to clean up TagHt and it's
705 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * Test/CMakeLists.txt: update to follow gdcmData renamings.
707 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
709 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * ENH: added some utility method that builds a flat dictionnary
711 holding all the Dicom entries contained in the recursive structure
712 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
714 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
715 BuildFlatHashTable() that build a flat dictionary.
716 - src/gdcmElementSet.h: added a new private GetTag() accessor.
717 gdcmDocument is now a friend of gdcmElementSet.
718 - src/gdcmElementSet.cxx: clean up.
719 - Example/FlatHashTablePrint.cxx added.
720 - Example/CmakeLists.txt changed accordingly
722 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
724 moved away from gdcmDocEntrySet (since this class is an abstract class
725 acting like an interface). SQDepthLevel and BaseTagKey are now
727 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
728 and associated accessors. Doxygenation of the class.
729 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
731 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
732 Use SQDepthLevel accessor instead. ::Print() adapted.
733 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
734 - src/gdcmDocument.cxx changed accordingly.
736 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
737 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
738 - The following is the doxygen comment of the typedef declaration
739 of gdcmagKey in src/gdcmCommon.h:
740 gdcmTagKey is made to old an "universal" (as in URL, Universal
741 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
742 A dicom tag allways has a group and an element, but a set of tags
743 embeded in various (optionally nested) sequences and sharing
744 the same group and element all share the same (group, element)
745 "identifier". Hence the (group, element) cannot be used as an
746 identifier (in gdcm we shall refer to a "TagKey") of a tag.
747 In order to construct a proper tag identifier (i.e. a key) we
748 consider the following definition of a TagKey:
749 - let Group, Element be the string representation of the
750 group and element dicom tag members,
751 - let ItemNumber be the string representation of the integer
752 index of the considered item number of a sequence,
753 Let the key of a tag embeded in a sequence, noted SeqTag, be
755 /ItemNumber#Group|Element
756 where "/", "#" and "|" are characters acting as separators.
757 Then the general form of a gdcmTagKey is given by:
758 Group|Element<SeqTag>
759 where <SeqTag> means NO or many instances of SeqTag.
760 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
763 but the gdcmTagKey of a tag "embeded" is the first item of
764 a sequence, itself nested in the third item of a sequence is the
766 0004|1220/2#0008|0082/0#0008|0090
767 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
768 order to hold the new sequence compatible key. Previously, the
769 GetKey() method would look in the underlying gdcmDictEntry.
770 - src/gdcmDocEntry.cxx:
771 -- constructor now copies the underlying DictEntry key, in the local
773 -- ::Print: displays the member Key, instead of the (group, element).
774 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
775 - src/gdcmDocEntrySet.h:xi
776 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
777 -- now has a new BaseTagKey member.
779 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
780 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
782 This poses the problem with the semantics of the following lines
783 LoadEntryVoidArea(0x0028,0x1201); // R LUT
784 LoadEntryVoidArea(0x0028,0x1202); // G LUT
785 LoadEntryVoidArea(0x0028,0x1203); // B LUT
786 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
787 to the long FIXME note for what the problem is. Nevertheless in
788 order to get things working the dicom dictionary was altered !
789 Please fix things urgently...
790 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
791 information), see above note on moving the member VoidArea. Nevertheless
792 the following entries previously correctly set as US are now inproperly
794 0028 1201 OW IMG Red Palette Color Lookup Table Data
795 0028 1202 OW IMG Green Palette Color Lookup Table Data
796 0028 1203 OW IMG Blue Palette Color Lookup Table Data
797 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
798 of gdcmDocEntry moved to gdcmSeqEntry.
799 * src/gdcmSeqEntry.cxx: STYLE.
801 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
802 * Test/TestAllEntryVerify.cxx minor fix and added comments.
804 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * gdcmPython/testSuite.py: all the test suite in python is now moved
806 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
807 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
808 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
810 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
812 to avoid inclusion recursion until STL is reached.
813 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
814 mecanism. errno.h is not included in gdcm anymore.
815 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
816 (gdcmFormatError now inherits from gdcmFormatUnexpected).
818 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
819 gdcmData/TestAllEntryVerifyReference.txt
820 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
821 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
822 exception_on_error parameter.
823 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
824 - vtk/vtkGdcmReader.cxx changed accordingly,
825 - Example/*.cxx and Test/*.cxx changed accordingly.
827 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
829 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
830 enable_sequences removed from gdcmHeader constructor and dependencies.
831 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
832 * gdcmPython/demo/PrintHeader.py: dummy fix.
833 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
834 skip_shadow removed from gdcmHeader constructor and dependencies.
835 * Example/*.cxx and Test/*.cxx changed accordingly.
837 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
839 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
841 2004-07-21 Jean-Pierre Roux
842 * FIX Now, Parsing and Printing a DICOMDIR do work!
843 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
845 2004-07-20 Jean-Pierre Roux
846 * FIX Some brain damaged headers have Zero-Lenght fields
847 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
849 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
850 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
851 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
852 variable (instance of gdcmDebug) by a definition macro, and the instance
853 is now in static in the gdcmDebug class
854 * src/gdcmSQItem.h : (FIXME) remove an undefined method
855 * Test/PrintAllDocument.cxx : bug fix in the result of the test
857 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
858 * WARNING: ctest now depends more tightly on gdcmData. You should
859 check out gdcmData properly for things to run smoothly...
860 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
861 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
862 we need the pixels not be loaded in order to use the ValEntry
863 that displays position and size).
864 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
865 This is a C++ based equivalent of gdcmPython/testSuite.py that should
866 be deprecated. If you have any doubts about the advantages of a
867 modern scripting language (read Python) versus grass root C++ (i.e.
868 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
869 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
870 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
871 Anyhow, consider documenting the gdcmData images in
872 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
874 * Test/CMakeLists.txt:
875 - now uses TestAllEntryVerify.cxx
876 - specific comments on oldACR00001.ima (now renamed in gdcmData
877 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
878 gdcmData/TestAllEntryVerifyReference.txt
881 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
882 * src/*.[h|cxx] : typedef clean up
883 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
884 - TagKey renamed to gdcmTagKey (for external usage)
885 - VRKey renamed to gdcmVRKey (for external usage)
886 - removal of typedef duplication.
887 - Removed all unecessary inline keyword from class inline definitions.
888 - Some method|function(void) declarations replaced with method|function().
889 * src/jpeg/libijg12/jdhuff12.c:
890 - printf polluting ctest removed.
891 - TAB removal for comminting
893 - TestAllReadCompareDicom.cxx: added a test that compares all the
894 images in gdcmDataImages.h with corresponding images in
895 gdcmData/BaselineDicom/. When baseline images are not present
896 this test creates them.
897 Note: we need to validate each reference image, but before that
898 I'd like to rename them with a more explicit name...
899 - CMakeLists.txt: changed accordingly.
900 * Example/*.cxx: examples now only include gdcm.h (as opposed to
901 including each header needed).
903 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
904 * Test/*.cxx and Example/*.cxx: moved some examples away from the
905 test suite to the Example directory. Are concerned:
910 - TestWriteSimple.cxx
911 * Test/CMakeLists.txt: added some comments on reasons for black listing
912 image gdcmData/oldACR00001.ima
914 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * Test/CmakeList.txt: removed the following from black list (to be coherent
916 with removal from gdcmData):
917 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
918 - gdcm-MR-PHILIPS-16.dcm
920 Added the following because after last cvs update, they cause
921 ctest -R TestReadWriteReadCompare
923 - gdcm-MR-SIEMENS-16-1.acr
925 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
926 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
927 new comments in this file) we temporarily (sigh) move to a weaker
929 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
930 we don't need to black list the following images anymore:
931 - 8BitsUncompressedColor.dcm
933 - US-PAL-8-10x-echo.dcm
934 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
935 fixes and the beautified code ;-)
936 This fixes the bug introduced in version 1.42 (when beautifying)
937 that made the parsing of 8BitsRunLengthColor.dcm unproper.
938 Note: ctest was blind to this bug (this means we need to still
939 improve the test suite). The bug could be detected by using
940 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
942 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
943 and by displaying the (garbage) produced file temp.XDCM...
945 2004-06-29 Jean-Pierre Roux
946 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
947 - replace by uggly but working old code :-(
948 A lot of things should be OK again.
949 It's really urgent to have a test suite that *tests*,
950 to prevent Frog's beautifying sessions to break all the stuff
951 (twice, withing a fortnigh ...)
953 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
955 redundancy) to added Test/TestReadWriteReadCompare.cxx
956 * Test/CmakeList.txt: because the compare test of
957 Test/TestReadWriteReadCompare.cxx fails, the following images are
958 black listed: - 8BitsUncompressedColor.dcm
960 - US-PAL-8-10x-echo.dcm
961 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
962 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
963 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
964 and ad-hoc kludge. This kludge is now removed, and on encountering
965 such an image (OB field brain damaged) we set errno. Then in
966 ::FindDocLength() we "fix" the length as being ALL what remains
967 in the file (until EOF). We then proceed, hoping for the best...
968 This fixes a SegFault in ShowDicom when trying to write such an
970 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
971 (because TestWriteRead breaks on it, after a non conformal commit?).
972 ctest now runs properly, except for MakeDicomDir (which was allways
973 broken) and the Python related stuff (still not fixed).
975 2004-06-24 Jean-Pierre Roux
976 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
977 FIX : Test/TestReadWrite now iterates on all the file names
978 (instead of infinite loop)
979 ENH : Test/TestWriteRead now iterates on all the file names
981 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
982 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
984 2004-06-24 Jean-Pierre Roux
985 FIX : - now Write drops LUT Descriptors and LUTs (if any)
986 when SamplesPerPixel =3
987 - now Write is no longer confused by
988 'BitsAllocated = 12" and 'BitsStored=12"
989 - "UN" value representation Elements are now written correctly
990 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
991 ENH : - now gdcmHeader has its own Write methods
992 (in order to split the job that has not to be done
995 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
996 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
997 loop on the same image until memory went out.
998 Note: this means we still have gobs of memory loss in PrintDocument
999 * src/gdcmDocument.cxx: fixes problem on parsing on file
1000 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1002 2004-06-24 Jean-Pierre Roux
1003 FIX : Write - All the Sequences and Sequence Item are now written
1004 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1005 is added a the end, when necessary.
1006 - A lot of brain-damaged images, that were read correctly are
1007 now written correctly
1008 - length compatible BinEntry are now loaded correctly
1009 (even for odd groups)
1010 Note : only Explicit Value Representation was checked.
1011 (question : is implicit VR really necessary for gdcm ?)
1013 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * DEVELOPPER: added a proposition of coding style.
1015 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1018 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1020 Use the gdcmDocEntry::Print() and Write() instead.
1021 * src/gdcmDocument.cxx: bug fix.
1023 2004-06-22 Jean-Pierre Roux
1024 FIX : gdcmDocument.cxx
1025 - Now we do recognize the JpegLossLess format (there was a misstyping in
1026 code 'beautyfication' :-(
1027 - Now we automaticaticaly load the Luts, if any
1029 2004-06-22 Jean-Pierre Roux
1030 In order : to write Sequences, whatever their imbrication level,
1031 : to allow user to create his own Sequences
1032 a lot of modif where necessary (adding, moving, or virtualising methods)
1034 WARNING : save your own sources *before* cvs up !
1037 ADD virtual void Write(FILE *fp, FileType filetype);
1040 ADD virtual void Write(FILE *fp, FileType filetype);
1041 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1044 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1045 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1046 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1047 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1048 ADD std::string GetEntryByName(TagName name);
1049 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1051 std::string vr = "unkn",
1052 std::string fourth = "unkn",
1053 std::string name = "unkn");
1054 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1055 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1056 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1057 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1058 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1059 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1060 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1061 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1064 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1065 ADD virtual std::string GetEntryByName (TagName tagName);
1066 ADD virtual std::string GetEntryVRByName (TagName tagName);
1067 REM virtual bool Write(FILE *, FileType);
1068 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1069 FILE *_fp, FileType type);
1070 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1071 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1072 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1073 REM virtual std::string GetEntryByName (std::string tagName);
1074 REM virtual std::string GetEntryVRByName (std::string tagName);
1075 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1076 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1077 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1079 std::string vr = "unkn",
1080 std::string fourth = "unkn",
1081 std::string name = "unkn");
1082 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1083 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1084 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1085 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1088 ADD virtual void Write(FILE *fp, FileType filetype);
1091 ADD virtual void Write(FILE *fp,FileType filetype);
1094 ADD virtual void Write(FILE *fp, FileType filetype);
1095 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1096 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1097 REM std::string GetEntryByName(TagName name);
1100 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1102 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1103 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1104 The default constructor invoked by the line
1105 gdcmHeader *f1 = new gdcmHeader( header );
1106 was gdcmHeader::gdcmHeader(bool) instead of the expected
1107 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1108 Hence the parsing wasn't executed... See also below.
1109 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1110 as explicit constructor didn't do the trick to fix the above problem.
1111 Could anyone explain why ?
1112 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1113 properly calls gdcmValEntry::Print() (that was weed out from
1114 code related to gdcmBinEntry).
1116 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * In order to fix memory leaks:
1118 - Test/TestWriteSimple.cxx: added cleaning of free store through
1120 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1121 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1122 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1123 (through the call to ::AddDicomDirMeta()) or the destructor
1124 would crash when deleting uninitialized ::metaElems].
1125 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1126 - src/gdcmDocument.cxx:
1127 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1128 from dynamic stores.
1129 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1130 was causing memory leaks.
1131 - src/gdcmSQItem.cxx:
1132 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1133 cleanly handled with polymophism: sorry but my milage is low).
1134 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1135 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1136 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1137 This avoids SegFaulting.
1138 - src/gdcmSQItem.h: coding style.
1140 - Test/TestWriteSimple still severely sucks. The output image content
1141 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1142 damaged when displayed with vtkgdcmViewer.
1143 - on memory leaks: TestWriteSimple leaks really less (see entry
1144 of 2004-06-18 in Changelog file for the call to valgrind).
1145 - on segfaults: ctest now passes all the tests but one (no more
1147 * Erroneous leading white fix:
1148 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1149 white[s] (as opposed to from >> xxx, that removes it [them].
1150 - src/gdcmTS.cxx: ditto.
1151 - gdcmPython/testSuite.py: dirty related kludge removed.
1152 * src/*: remaining references to gdcmParser removed.
1153 * src/*[cxx|h]: added copy[way]left header.
1156 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * In order to fix writing of dicom files:
1158 - Test/TestWriteSimple.cxx: a simpler example of writing.
1159 - Test/CMakeLists.txt changed accordingly.
1160 - src/gdcmDocument.cxx:
1161 -- The destructor now recursilvely removes potential sequences.
1162 -- Bug fix in ::IsJPEG2000()
1163 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1164 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1166 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1167 to only declared) and build on top of
1168 ::GetDocEntryByNumber(guint16, guint16).
1169 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1170 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1171 for usage in destructor and treatement of promotion in
1172 ::ReplaceOrCreateByNumber().
1173 - src/gdcmSQItem.cxx: destructor should better handle his job.
1174 Test/TestWriteSimple now runs (or at least it DOES something).
1175 * We can now start hutting memory links. A good starting point is:
1176 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1177 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1178 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1180 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1181 * Valgrind note: after Mathieu Malaterre teached me how to read
1182 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1184 Using gcc, you can force the STL to use malloc and to free memory as
1185 soon as possible by globally disabling memory caching.
1186 With 3.2.2 and later, you should export the environment variable
1187 GLIBCPP_FORCE_NEW before running your program.
1188 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1189 simply vanish (it is still not clear to me, whether this means that
1190 STL std::string leaks or if valgrind believes it leaks...).
1191 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1192 running bin/gdcmTests makeDicomDir):
1193 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1194 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1196 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1197 SegFaulting (I drowned in DicomDir related code when trying to
1198 understand why the list is empty...).
1199 * src/gdcmDocument.h: first BSD license header try.
1200 * Doc/License.txt added.
1202 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1203 * src/gdcmDocument.[h|cxx]:
1204 - Clean up of the Transfer related predicates. They are now all based
1205 on new method isGivenTransferSyntax, that (should) handle properly
1206 the padding problem.
1207 - general clean up, simplification, and coding style.
1208 - Specific clean up of Parse7FE0() (umproperly named actually).
1209 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1211 2004-06-14 Jean-Pierre Roux
1213 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1214 - fix the display of SQItem ordinal number
1215 - add the GetSQItemByOrdinalNumber method
1216 - remove some useless never written private methods
1218 2004-06-14 Jean-Pierre Roux
1220 - adding a constructor taking a gdcmDocEntry as an input param
1221 - ReplaceOrCreateByNumber now returns :
1222 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1223 a gdcmValEntry * if a string value is passed as a param
1225 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1226 according to the param type (no longer sets a gdcmDocEntry)
1227 - GetValEntryByNumber, GetBinEntryByNumber added
1228 - NewValEntryByNumber and NewBinEntryByNumber added
1230 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1232 - GetSQItemNumber and SetSQItemNumber added, to provide
1233 a (relative) Item identier inside a given Sequence
1234 \warning : some pb remaining around this number
1236 - AddEntry now takes the Item Number as a param
1238 - adding a constructor taking a gdcmDocEntry as an input param
1240 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1241 * Memory leak hunt with the following command:
1242 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1243 --show-reachable=yes gdcmTests PrintDocument
1244 It looks like many (all?) leaks are due to the STL (or a bad usage
1245 of the STL. The lines producing the leaks now have a comment with
1246 a "MEMORY LEAK" tag: you can retrieve them with
1247 grep "MEMORY LEAK" src/*
1248 Here are two typical examples which I can't help fixing:
1253 char * test = "babo";
1254 name = test; //// <--- valgrind detects 960 bytes lost in
1255 //// call to std::string::operator=(char const*)
1256 name.clear(); //// Doesn't help !
1264 std::cout << "Type a bunch of characters followed by RETURN: ";
1265 getline(std::cin, line); //// <--- valgrind dectects a loss
1266 //// of 1320 bytes in call to
1267 /// std::basic_istream<>& std::getline<>
1273 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1274 * src/gdcmHeader.[cxx|h]:
1275 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1276 and related, moved away to gdcmDocument.
1277 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1278 the corresponding protected accessors of inherited class
1279 gdcmDocument, removed ! As a consequence gdcmFile had to be
1280 declared friend of class gdcmDocument (see below).
1281 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1282 - Clean up of undefined or unused methods.
1283 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1284 account the changes to gdcmHeader.h).
1285 * src/gdcmDocument.h:
1286 - gdcmFile is now a friend class (in order to take into account the
1287 changes to gdcmHeader.h).
1288 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1289 (see changes to gdcmHeader.h).
1290 - Accessors (reading on the form GetEntry*) are now public.
1291 - Clean up of undefined or unused methods.
1292 * src/gdcmDocument.cxx:
1293 - adaptation to changes to gdcmDocument.h
1294 - ::OpenFile now writes a verbose message when file cannot be opened.
1295 - some std::string properly set to VRKey
1296 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1297 references to gdcmDocument.
1298 * Test/TestFindTags.cxx: changed accordingly to above changes.
1299 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1300 cvs repository gdcmData.
1302 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1304 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1305 conflicts with gdcmValEntry::voidArea.
1306 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1307 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1308 Value representation between StringRepresentable and BinaryRepresentable.
1309 * src/gdcmDocument.cxx:
1310 - method ParseDES: proper indentation restored and usage of
1311 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1312 - method LoadDocEntry: the fingerprint left in the SetValue() of
1313 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1314 removed. Reverting to previous code segment with the proper
1315 dynamic_cast< gdcmValEntry* >.
1316 Note: this was (partially) breaking the python test suite
1317 (gdcmPython/testSuite.py) that made usage of the above
1318 fingerprint to check presence of "Pixel Data".
1319 * src/gdcmDocEntry.h: coding style.
1320 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1321 now taken into account.
1322 * gdcmPython/gdcm.i: adaptation to the new internal representation
1323 of gdcm (exit gdcmParser, hello gdcmDocument).
1324 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1326 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1327 anymore, but instead prints the loaded Python dictionary.
1328 * .... alas, the python testSuite is still broken.
1330 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1331 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1333 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1334 * src/gdcmUtil.h : export methods
1336 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1337 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1339 * Initial addition of automatic python testing
1340 * Initial addition of automatic image comparison
1342 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1343 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1344 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1346 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1347 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1348 * Test/ShowDicom.cxx : bug fix for msvc compilation
1349 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1351 2004-05-04 Jean-Pierre Roux
1352 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1353 new concepts (and new classes) :
1354 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1355 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1356 - Sequence Doc Entries (gdcmSeqEntries)
1357 a Sequence is composed of Items.
1358 Each item is a set of Doc Entries (this is recursive)
1359 The non uniqueness of the 'Dicom tag' is due to this recursivity
1360 (never taken into account)
1361 Our unability to add a new 'entry' in the header
1362 at the proper location (neither in the H-Table (map or multimap),
1363 nor in the Chained List is also due to this recursivity.
1364 Don't try, right now, to use/modify/compile these new sources :
1365 nothing is finished.
1366 We just commit all the stuff, 'as is', in order not to loose it.
1368 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1369 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1371 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1372 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1373 file prefix (SetFilePrefix)
1375 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1376 * Add a new test: ShowDicom, for now this is just the c++ version of
1377 checkRead.sh, later it will be able to compare the image read against a
1379 * Replace the DEBUG on the stack with a global entry in cmake interface:
1380 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1382 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1383 * Add an example subdir, with a real example on how to read + write a
1386 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1387 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1388 * Doc/CMakeLists.txt: the main page is now properly differentiated
1389 between the developper and user version.
1390 * Doc/doxygen.config.in: dropped search related obsolete flags
1391 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1393 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1394 * DEVELOPPER: added some helpfull comments for compile/test/install
1397 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1398 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1399 src directory, now generated in the build dir.
1400 2. Tests as mentionned smarter
1402 4. Add a new method in gdcmDict that return the PubDict by name
1403 this is interesting for 3rd party lib like ITK,
1404 where we could set the institution name / patient name...
1406 * ENH: 1. Now the test suite is working for real
1407 2. All binaries are now output in the gdcm-bin directory
1408 (this was not true before)
1410 2004-04-28 Jean-Pierre Roux
1411 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1412 SeQuence indented printing of Dicom Header.
1413 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1414 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1415 Computation of SQDepthLevel is now part of gdcmHeader constructor
1416 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1417 tree-like structure of a Dicom Header.
1418 * FIX Test code cleaning
1420 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1421 * ENH: Adding automatic testing
1422 1. Need a DartConfig.cmake to submit to public
1423 2. Add a test driver gdcmTest.cxx
1424 3. gdcmTestMain, an helper for the main test driver gdcmTest
1425 4. Files in Test don't have a main anymore, this becomes interesting
1426 when we add more and more tests, thus dsw don't have to load
1428 * ENH: Adding a GDCM_DATA_ROOT for testing
1429 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1430 one file instead of seven + some small cleanup
1432 2004-04-22 Jean-Pierre Roux
1433 * ENH Minor changes to the Print() methods.
1434 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1435 Header printing. Example given with :
1436 > PrintHeader fileName 2 new
1437 (SQ based tree-like structure still to be done for the Header ...)
1439 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1440 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1441 1. I have added some unsigned where needed
1442 2. Some function parameter not used -> (void)
1443 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1444 4. g++ don't like character '\' in comment
1445 5. #define jpeg_create_decompress jCreaDecompress
1446 this really need to be fixed
1447 6. virtualize destructor of gdcmObject ... leakage
1448 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1449 this also really need to be fixed
1450 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1451 remove compression file
1452 (as we only do decompression, right ?)
1453 * ENH: Change malloc/calloc/free with c++ equivalent
1455 2004-04-21 Jean-Pierre Roux
1456 * FIX gdcmHeaderHelper::GetXSpacing
1457 when a single value is found (bug ?), xpacing is now
1458 defaulted to yspacing
1460 2004-04-19 Jean-Pierre Roux
1461 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1462 * ENH add parameters :
1463 bool exception_on_error = false,
1464 bool enable_sequences = false,
1465 bool ignore_shadow = false
1466 to the gdcmFile constructors to be full gdcmParser compliant
1467 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1468 to allow reading of PAPYRUS 3.0 files
1470 2004-04-06 Jean-Pierre Roux
1471 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1473 2004-04-02 Jean-Pierre Roux
1474 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1475 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1476 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1478 2004-03-30 Jean-Pierre Roux
1479 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1480 for ACR file, written out as DICOM files (hope so...)
1482 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1483 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1484 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1485 moved to base class gdcmParser and only the specialisation is kept
1487 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1488 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1489 already does the job.
1490 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1491 (to be consistent with gdcmParser::WriteEntries).
1493 2004-03-30 Benoit Regrain
1494 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1495 upate of the object's instance. It's passed to 2 in the unfavorable
1496 case : one in the ExecuteInformation, one in the ExecuteData
1498 2004-03-29 Jean-Pierre Roux
1499 * ENH : Check on file type to be written moved
1500 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1501 * FIX : gdcmObject::ResetBoundaries now stops properly
1502 when end-of-list is reached
1503 : gdcmVersion modified (as Benoit Regrain asked)
1505 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1506 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1507 * src/gdcmUtil.cxx: added forgotten iostream include.
1508 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1509 equivalent to ExplicitVR in existing code).
1511 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1512 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1513 now contains all the gdcmGlobal related code.
1514 * minor coding style and doxygenation changes.
1516 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1517 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1518 now contains all the Debug related code.
1519 * minor clean-up of includes in src/*.cxx
1520 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1521 CreateCleanString) removed.
1522 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1523 * Doc/DoxyMainPageUser.txt added.
1524 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1525 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1526 src/gdcmDirList.cxx)
1528 2004-03-24 Jean-Pierre Roux
1529 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1531 2004-03-23 Jean-Pierre Roux
1532 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1533 big endian made volumes
1534 * ENH Now gdcmParser constructor and destructor are protected to forbid
1535 end user to instanciate class gdcmParser
1536 (only gdcmHeader and gdcmDicomDir are meaningfull)
1538 2004-03-22 Benoit Regrain
1539 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1540 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1541 gdcmSerie to gdcmDicomDirSerie
1543 2004-03-19 Jean-Pierre Roux
1544 * ENH Now the tree-like structure describing a DICOMDIR comming from
1545 an already existing DICOMDIR file is consistent with
1546 the home-made tree-like structure build ex-nihilo
1547 or build from the files held (recursively) in a Directory
1548 functions gdcmDicomDir::CheckBoundaries()
1549 gdcmObject::SetBoundaries() added
1551 2004-03-17 Jean-Pierre Roux
1552 * REM (Eric Boix bug) : removal of meaningless
1553 gdcmDicomDirImage::NewImage function.
1554 * FIX now file names and directory name are written properly in the
1556 * FIX now gdcmDicomDir constructor may be call without any trick
1559 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1561 of gdcmDicomDirImage::NewImage as empty function.
1563 2004-02-28 Jean-Pierre Roux
1564 * ENH add gdcmDicomDir:NewPatient
1565 add gdcmDicomDirPatient:NewStudy
1566 add gdcmDicomDirStudy:NewSerie
1567 add gdcmDicomDirSerie:NewImage
1568 to allow making gdcDicomDir object.
1569 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1570 (as opposite to the gdcmHeader chained list)
1572 2004-02-11 Benoit Regrain
1573 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1574 when using from python
1576 2004-02-10 Benoit Regrain
1577 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1578 * FIX : in gdcmDicomDir when the directory is empty
1579 * ENH : add callback and methods to get the progression of dicomDir
1582 2004-02-06 Jean-Pierre Roux
1583 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1584 - GDCM_META added to gdcmDicomDirType
1585 - class gdcmMeta created
1586 * ENH : - A brief summary is now displayed at the beginning of
1587 'testDicomDir' to help disaster magnitude estimation
1588 * REM : Now useless Test/explDICOMDIR.cxx
1590 2004-02-05 Benoit Regrain
1591 * ENH : add methods in gdcmObject to get the hash table or the list of
1593 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1594 * FIX : wrapping python for TagHeaderEntryHT
1596 2004-02-04 Benoit Regrain
1597 * FIX : even length for some strings when writting the dicom dir
1598 * FIX : sort the images in the dicom dir
1599 * FIX : Bug fix for python use of dicom dir
1600 * ADD : a python demo
1602 2004-02-04 Jean-Pierre Roux
1603 * FIX : Final solution (?) for icone embedded images
1604 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1605 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1606 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1607 gdcmData/gdcm-MR-SIEMENS-16.acr1
1608 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1609 to make full checking easier
1611 2004-02-04 Benoit Regrain
1612 * FIX : WriteEntries : coding style & logic in parameters
1613 * FIX : Set the elements to create the DicomDir in a dictionary file
1615 2004-02-03 Benoit Regrain
1616 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1617 * gdcmDicomDir : add the load of directory
1618 * Bug fix and print add-on
1620 2004-02-03 Jean-Pierre Roux
1621 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1622 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1623 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1624 * FIX gdcmParser.cxx : 'group length' elements are now considered
1625 as integers, even for shadow groups, when file is Implicit VR
1627 2004-02-02 Jean-Pierre Roux
1628 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1630 of the last synonym :-(
1631 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1633 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1634 * FIX taking into account the possible 7fe0,0010 multiplicity
1635 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1636 to allow removal of references to 7fe0,0010, to deal with
1637 ACR-NEMA images, when 0028,0200 is meaningfull
1639 2004-01-31 Jean-Pierre Roux
1640 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1641 no longer writes 'Un' on disk
1642 * FIX SQ elements with actual length are now dealt with corectly
1643 * FIX gdcmFile::WriteBase make the difference, for color images, between
1644 the length (for Palette expanded images)
1645 and Raw Length (non expanded image + Palette)
1646 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1647 (that broke Write). Replaced by UL.
1648 Aware user will reload the field if he
1649 thinks it's necesssary
1651 2004-01-30 Jean-Pierre Roux
1652 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1653 when 'dirty Acr' is found, to be compliant with the new
1654 IsReadable() methods.
1656 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1657 (no DOUBLE images in kosher DICOM,
1658 but so usefull for people that miss them ;-)
1660 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1661 DICOMDIR related utilities (not checked as Windoze compliant)
1663 2004-01-28 Jean-Pierre Roux
1664 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1666 2004-01-27 Jean-Pierre Roux
1667 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1668 to allow skipping the shadow elements, to save memory space.
1669 The TRUE value for this param has to be used
1670 with a FALSE value for the 'enable_sequence' param.
1671 ('public elements' may be embedded in 'shadow Sequences')
1672 * gdcmHeader methods now deal with 'embedded icones images' in the header
1673 (even when an 'icone image sequence' is announced by the
1674 element (0x0088,0x0200), but there is NO icone at all ...
1676 * gdcmHeader sometimes Image Location value doesn't follow
1677 the supposed processor endianity (see gdcmData/cr172241.dcm).
1680 * gdcmHeader add the method
1681 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1682 to get *all* the Header Entries with the same tag.
1683 GetHeaderEntrySameName is probabely *useless*
1684 (no meaning : Name is *not* an identifier within the Dictionnary)
1686 2004-01-26 Benoit Regrain
1687 * Bug fix in the print of hexadecimal representations. Remove long fields
1688 in the print and add a third level of print to print them
1690 2004-01-23 Benoit Regrain
1691 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1692 * Bug fix on test suite after remove the strip made on not string fields
1693 * Split the IsReadable method between gdcmParser which test that the file
1694 is dicom and gdcmHeader which test that it's an image file
1696 2004-01-22 Benoit Regrain
1697 * DicomDir : clean code, add methods, set variables in protected or private
1698 * gdcmUtil : bug fix for the clean string method
1700 2004-01-19 Benoit Regrain
1701 * Add the use of shadow dictionaries
1702 * bug fix and coding style
1704 2004-01-19 Benoit Regrain
1705 * src/gdcmFile.cxx : bug fix concerning the close of file
1706 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1707 * Add the update of header entries using the shadow library
1709 2004-01-19 Benoit Regrain
1710 * removal of file gdcmHeader2.cxx
1711 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1712 inheriting from gdcmParser. This split is to prepare the integration
1713 of dicom dir parsing
1714 * bug fix under python
1716 2004-01-16 Jean-Pierre Roux
1717 * REM removal of class gdcmHeaderEntrySet
1718 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1719 * ADD add file gdcmHeader2.cxx
1720 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1722 2004-01-15 Benoit Regrain
1723 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1724 entries created while parsing the header. Thus, they will be destroyed
1725 when the gdcmDictSet will be destroyed
1726 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1729 2004-01-15 Benoit Regrain
1730 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1731 made a fatal error because of the memory release at the end of program.
1732 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1733 some memory and vtk seems to have some problems with that.
1734 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1736 2004-01-14 Benoit Regrain
1737 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1738 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1739 * src/*.[h|cxx] : make changes due to class name changes
1740 * gdcmPython/demo/*.py : bug fix due to method names
1742 2004-01-13 Benoit Regrain
1743 * src/*.[h|cxx] : coding style
1744 * vtk/*.[h|cxx] : coding style
1746 2004-01-13 Benoit Regrain
1747 * gdcmPython/testSuite.py : test the readable flag of file for tests
1748 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1749 It's lied to the stl compilation by MSVC (windows, always windows...)
1750 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1752 2004-01-12 Benoit Regrain
1753 * src/*.h : add comments
1754 * src/gdcmDictSet.h : set the method BuildDictPath in public
1755 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1756 directly setted in the source code
1757 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1760 2004-01-09 Benoit Regrain
1761 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1762 * setup.py : use a reference to gdcmVERSION
1764 2004-01-07 Benoit Regrain
1765 * Modification to compile with the distutils.
1768 2003-12-10 Benoit Regrain
1769 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1770 can use a gdcmHeaderHelper to load datas
1771 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1772 made in the source code
1774 2003-12-10 Benoit Regrain
1775 * Update Windows projects and .cvsignore files
1777 2003-11-12 Jean-Pierre Roux
1778 * ENH gdcmHeader constructor has one more parameter (default value : false)
1779 that allows the user to 'go inside' the SeQuences only
1781 gdcmElValSet:Print takes it into account
1783 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1784 * ENH: Update gdcmPython/CMakeLists
1785 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1786 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1788 2003-11-10 Jean-Pierre Roux
1789 * FIX : gdcmHeader::LoadElements is now based
1790 on the ListTag listElem member,
1791 not longer on the TagElValueHT tagHt member
1792 * ENH : PrintPubElVal shows (temporarily) both results,
1793 with the tagHt member and the listElem member.
1794 (it's easier to 'see' the problems when using Printheader)
1796 * FIX : old private member LgrElem is now splitted into
1797 ReadLength : Length actually found on disk (updated only
1798 if bug fixing is necessary), for internal
1800 UsableLength : Updated by FixFoundLength, to fix a bug
1801 or to allow Parser going on.
1802 Will allow to re-write a kosher header when a SeQuence
1803 with a length (not 0000) is found
1804 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1805 because gdcmElValSet::Add does not update ListElem
1808 2003-11-07 Jean-Pierre Roux
1809 * FIX misstyping in Transfert Syntax name table
1810 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1811 when they have an actual length (not 0000 nor FFFFF)
1812 (Nobody should care of it, but DICOMDIR explorers)
1814 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1815 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1817 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1818 * ENH: vtkGdcmReader now supports LUT !
1819 (vtkgdcmViewer for now is not able to use them though)
1821 2003-11-05 Jean-Pierre Roux
1822 * in testSuite.py : new files names for checking the package
1823 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1824 that returns the pixel area size to the *aware* (vtk) user
1825 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1827 2003-11-05 Benoit Regrain
1828 * in testSuite.py : Modify the rules for checking the paths
1829 : Explicit error messages
1830 * in __init__.py : Related modif
1832 2003-11-03 Jean-Pierre Roux
1833 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1834 to be used by aware (vtk) users that want to manage
1835 LUT (and no to turn the PALETTE image into an RGB pixels one)
1836 * GetPixelType now returns 8U for 24 Bits images
1837 (vtkGdcmReader compliant)
1839 2003-10-31 Jean-Pierre Roux
1840 * Removal of *all* gdcmData images and add them again
1841 in order to loose the 'history' of un-anonymised images
1843 2003-10-31 Jean-Pierre Roux
1844 * RMV : removal of useless jBitsInJsample.h
1845 for both 8 and 12 Bits JPEG Lossy Libraries
1847 2003-10-31 Jean-Pierre Roux
1848 * ENH : Add the functions gdcmFile::GetImageDataRaw
1849 gdcmFile::GetImageDataIntoVectorRaw
1850 that act as GetImageData and GetImageDataIntoVector
1851 except the making of an RGB Plane from Gray Plane + LUT
1852 Intended to aware (vtk) users who know how to manage
1855 GetLUTRGBA return a R,G,B,A LUT if any
1856 lgrTotaleRaw gives the 'Raw' length
1857 GetImageDataRaw returns the gray Plane
1858 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1859 (They stay Grey, just like with other Dicom viewers :-(
1861 2003-10-30 Jean-Pierre Roux
1862 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1864 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1865 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1866 being coherents dicom files.
1868 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1869 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1871 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1872 * ENH: Two steps is necessary to please VC++ compiler...
1873 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1874 * ENH: Add include dir to medcon lib
1875 * FIX: only one function is being exported for now !
1876 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1878 2003-10-29 Jean-Pierre Roux
1879 * adding gdcmHeader::GetLUTRGBA
1880 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1881 --> Mathieu, the modif u're waiting for is not yet committed
1882 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1884 2003-10-27 Jean-Pierre Roux
1885 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1886 00191113.dcm DermaColorLossLess.dcm
1887 MxTwinLossLess.dcm RadBWLossLess.dcm
1888 * ENH: For version prior to vtkImageViewer2 -r 1.19
1889 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1891 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * Removal of ido stuff in CMakeLists.txt
1894 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1896 * FIX: remove a call to ->Modified ... see comments
1897 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1899 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1900 * FIX: Problem with path for libvtkgdcmPython
1901 * ENH: Try adding a search script for python site-package
1902 * RMV: Remove some file from medcon lib that are not necessary
1903 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1904 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1905 * FIX: More pragma disable fro VC++,
1906 I don't think I break something as it is also disable in VTK/ITK.
1907 But it fasten debug compilation time.
1909 2003-10-23 Jean-Pierre Roux
1910 * gdcm now deals with 16 Bits Run Length Encoded images
1911 (they are compressed as 2 planes images,
1912 one for the high Bytes, the other for low Bytes)
1914 2003-10-22 Jean-Pierre Roux
1915 * Now CheckRead takes into account :
1916 - the bugged 'Leonardo' Siemens images
1917 - the XA images, sent thru the burning VPRO station
1918 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1921 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1922 * FIX: When copying a Makefile.am to CMakeLists.txt
1923 one should remove the '\'
1925 2003-10-22 Jean-Pierre Roux
1926 * in gdcmData adding a bugged 'Leonardo' Siemens image
1927 (wrong lengths in header)
1928 OK with gdcm, KO with the other viewers :-)
1929 * add a GE dlx XA image, thru the VEPRO burning station
1932 2003-10-21 Jean-Pierre Roux
1933 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1934 for a brutal checking of vtkgdcmViewer compliance
1936 2003-10-21 Jean-Pierre Roux
1937 * add the files for 'xmedcon' Jpeg Lossless library
1938 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1940 2003-10-21 Jean-Pierre Roux
1941 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1943 2003-10-21 Jean-Pierre Roux
1944 * garbage Siemens 'Leonardo' images dealt with
1945 (the patch is easy to remove)
1946 * cosmetic changes to avoid warnings
1948 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1949 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1950 no need to press 'r' now.
1952 2003-10-20 Jean-Pierre Roux
1953 * upgrade of checkRead.sh checkWrite.sh according
1954 to new Jpeg Lossless decompressor
1955 * add US.3405.1.dcm, a genuine RGB medical file ...
1956 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1957 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1959 2003-10-15 Jean-Pierre Roux
1960 * general anonymisation in gdcmData
1961 * adding the 'color files' from
1962 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1963 * adding some well knowed bugged-header images
1964 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1965 waiting for their inclusion in Python testsuite
1967 2003-10-15 Jean-Pierre Roux
1968 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1969 no longer seg faults when file is not found
1971 2003-10-14 Jean-Pierre Roux
1972 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1975 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1976 * TODO: *.in file to genereate a UseGDCM later
1978 2003-10-14 Jean-Pierre Roux
1979 * Some supposed-to-be Dicom Images have no preamble.
1980 OpenFile takes it into account
1981 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1982 * Missing elements added in dicomV3.dic
1983 (just to be affraid : have a look at
1984 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1985 and do it again next year ;->
1987 2003-10-13 Jean-Pierre Roux
1988 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1989 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1990 But there are NOT. It's fixed !
1992 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1993 * FIX: "jpeglib.h" was not found on VC++
1994 * FIX: vtkgdcm was not being installed
1996 2003-10-10 Jean-Pierre Roux
1997 * ENH : OpenFile closes the file if it *really* doesn't look like
1998 an ACR-NEMA / DICOM one.
1999 * FIX : testWrite no longer writes an empty file if the source file
2000 is not gdcm Readable
2001 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2004 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2005 * FIX: CMake generate now documentation
2006 * ENH: out of source doc build !
2007 * ENH: Generate both user and dev documentation
2008 * ENH: Should work on windows too
2009 * ENH: Only one doxygen config.in file is needed
2010 * FIX: make install should be ok now on ùnix plateform
2011 * FIX: PATH to dictionary was wrong (missing /)
2012 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2014 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2015 * vtkGdcmReader is now able to read rgb dicom file.
2016 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2017 * added a gdcmViewer to vtk test, use mouse to control
2018 window level & window width
2020 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * CMake-ification of gdcm, we have now two build system
2022 * FIX: on cygwin Wsock32 doesn't exist
2023 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2025 2003-10-06 Emanuel Ollart
2026 * FIX : compilation process wad broken.
2027 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2029 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * change gdcmViewer -> vtkgdcmViewer
2031 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2033 2003-10-06 Jean-Pierre Roux
2034 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2035 ( e.g : well known GE images with a wrong elem length,
2036 : Philips MRI Images with a wrong Huffman table)
2037 * still to be done : allow the reading of bugged LEONARDO Siemens images
2039 2003-10-03 Jean-Pierre Roux
2040 * Odd length strings are padded with '\0' (not with spaces,
2041 to remain compliant with already defined strings,
2042 like Transfert Syntax UID and others)
2044 2003-10-03 Jean-Pierre Roux
2045 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2046 to allow displaying RGB images (not only by affim ;-)
2048 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2049 * vtkGdcmReader is now able to read rgb dicom file.
2050 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2052 2003-10-03 Jean-Pierre Roux
2053 * A few nasty patches to allow the reading of a lot of nasty images
2054 ( e.g : well known GE images with a wrong elem length,
2055 : Philips MRI Images with a wrong Huffman table)
2056 * still to be done : allow the reading of bugged LEONARDO Siemens images
2058 2003-10-03 Jean-Pierre Roux
2059 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2061 2003-10-03 Jean-Pierre Roux
2062 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2063 to allow displaying RGB images (not only by affim ;-)
2065 2003-10-03 Jean-Pierre Roux
2066 * gdcmFile::GetImageDataIntoVector now
2067 - deals with MultiFrames MultiFragments Run Length Encoded files
2068 - deals with YcBcR (YBR_FULL) files
2069 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2070 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2072 (no sample found :-(
2074 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2075 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2076 Two reasons: - clear things
2077 - third parties acces gdcm through header files, so won't
2078 suffer anymore VC++ complains
2080 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2081 * add argv[1] in testvtkGdcmReader.cxx
2084 2003-09-24 Jean-Pierre Roux
2085 * The lines are now eigthy characters long.for
2086 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2088 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2089 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2090 char* to std::string. Thus, the use of strdup becomes useless. (see
2091 previous commis of Malaterre)
2092 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2093 before the last Malaterre's commit.
2095 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2096 * This commit should fix the Debug building under VC++, the problem
2097 was mainly a mixture of debug and release lib being loaded at startup.
2098 * I also remove a depency to a specific C function: strdup. Because I had
2099 to force the link to msvcrtd (whereas strdup is in libc).
2101 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2102 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2103 located in the gdcmCommon.h file. All use of reference of tha has been
2104 changed to now use the variable GDCM_UNFOUND.
2106 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2108 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2109 Dicom dictionary. The test suite can now be run again. Note:
2110 I'm note very happy with the " (RET)" changes. I believe this
2111 RETAINED comment should be dropped when parsing the dictionary.
2112 - PACKAGER corrected
2114 - AUTHORS updated and now in alphabetical order
2115 * Makefile.am now exports gdcm.dsw for Windoze users.
2117 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2118 * cygwin complains about missing std:: in subdir Test/
2120 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2121 * remove some methods that are now in gdcmHeaderHelper
2123 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2124 * vtkGdcmReader set spacing and origin correctly
2126 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2127 * Fix a few delete/delete[] mismatch
2129 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2131 interpretation to data given by gdcmHeader. For instance there are
2132 heuristics to get informations (look at different places).
2133 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2134 sorting DICOM images based on different strategies.
2135 * modified Makefiles accordingly.
2137 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2138 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2139 when building in debug mode
2140 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2141 src/win32/gdcmdll.dsp
2142 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2144 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2145 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2148 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2149 * src/win32/libgdcmjpeg12.dsp was not dos format
2150 * src/win32/libgdcmjpeg12.dsp :
2151 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2152 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2154 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2155 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2157 * src/gdcmFile.cxx : bug fix in affectation type
2158 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2159 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2160 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2161 symbols... future problem ?
2163 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2164 * src/win32/libgdcmijpeg12.dsp was missing
2165 * modified gdcm.dsw accordingly
2167 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2168 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2170 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2171 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2172 commit of JPR (before his hollidays to facilitate our work).
2173 * setup.py : bug fix in code. Modifications made while the last commit
2174 of JPR. The code hasn't been tested before the commit... it's so
2175 useless to make that (for best programmer that is JPR) !!!
2177 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * tagged the current version as Version0_3 (i.e. version 0.3)
2180 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2181 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2182 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2183 * *.dsp : modifications to use new libgdcmijpeg8 library
2184 * setup.py : bug fix on VTKPATH variable
2185 * PACKAGER : adding all concerning windows
2187 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2188 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2190 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2191 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2192 test suite reported error.
2193 * PACKAGER file added (describes what a packager must do when
2194 packaging a new release).
2195 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2196 * configure.in: upgraded version number to 0.3.0
2197 * fixing build of rpm (through rpm -ta):
2198 - Doc/Makefile.am exports proper doxygen files
2199 - src/jpeg/libijg8/Makefile.am exports the include files.
2201 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2202 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2203 * src/gdcmHeader.h : formatting code
2205 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2206 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2207 We were obtaining error message from vtk. Now, creation of file list
2208 is made in an internal list to prevent this problem.
2209 Bug fix when output is empty.
2210 Bug fix in update of progress value. Previous commit for this was a bad
2212 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2214 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2215 * src/gdcmHeader.h : added method to get the file name
2216 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2217 files. Added method to remove all files on the input
2218 Added FIXME comment concerning the bad parsing of header made by
2219 ExecuteInformation method (in ExecuteData method)
2221 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2222 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2223 when using make instal.
2224 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2225 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2227 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2228 * setup.py : adding include dir of jpeg lib to compile all sources
2229 * */Win32/*.dsp : JPR fix for windows compilation
2231 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2232 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2234 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2235 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2237 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2238 * setup.py is again effective on un*x (takes into account the
2239 addon of the jpeg library)
2240 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2241 * Doc/Doxy* updated (includes above enhancements)
2242 * INSTALL now points to web documentation
2244 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2245 * src/gdcmHeader.h doesn't make unnecessary reference to
2247 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2249 * src/gdcm*.[cxx|h] :
2250 - to allow compilation with gcc 3.x
2251 -- clean up of STL usage (added explicit usage of std::)
2252 -- small fixes on exceptions.
2253 Note: linking not tested !
2254 - clean of doxygen comments to avoid warnings at documentation
2256 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2257 dependent convertion).
2259 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2260 * Clean up of previous JPR garbage commit (not even commented in the
2262 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2263 - moved all jpeg related files from src to src/jpeg/libijg8, with
2264 addition/modification of Makefile.am and configure.in.
2265 - the testSuite is still brain damage (not guilty).
2267 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2268 * WrapVTK.py : modifications to get correctly vtk source files to
2270 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2271 (FileName -> Filename)
2273 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2274 * vtk/vtkGdcmReader.[cxx/h]:
2275 - UpdateProgress method should now be effective
2276 - removed the limitation on having only images loaded (as opposed
2278 - when building a stack of images/volume, a lesser number of
2279 gdcmHeader and gdcmFile instances should be used (hopefully
2280 accelerating things).
2281 - when building a stack of images/volumes, files which are not
2282 loadable (wrong path-filename, wrong permissions on existing file,
2283 or file not parsable by gdcm) are replaced with a black image
2284 in the stack (for the caller to notice the problem).
2286 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2289 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2290 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2291 between standard library (std) and vtk library (problems are found
2292 under Windows... thanks Windows !)
2294 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2295 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2297 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2299 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2300 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2302 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * When compiling with distutils (see setup.py) the C++ compiler is
2304 called with different flags than the default ones (with automake).
2305 In order to fix all those warning, I compiled gdcm with the command
2306 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2307 and went for warning fixes:
2308 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2309 up from unused variables.
2310 - vtk/vtkGdcmReader.cxx: potential bug fix.
2311 * src/gdcmHeader.h: Doxygen warning cleanup
2313 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * gdcmPython/gdcm.i:
2315 - typemaps correction to take into account the systematic replacement
2316 of "using namespace std" with std:: prefix e.g. std::list,
2317 std::string... (cf changes of 2003-05-21).
2318 - gdcmGlob global variable of type gdcmGlobal (defined in
2319 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2320 exported to Python a as cvar.
2321 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2322 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2323 gdcmDictSet.GetPubDictTagNames() and
2324 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2325 C++ static methods).
2326 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2327 with the above changes.
2329 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2330 * setup.py, manifest.in : bug fix under linux
2332 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2333 * Modification of setup.py to compile vtk part too. Then, we have 2
2334 wrappers which must work with same distutils. For that, we have a
2335 generic distutils in distusiltsWrapping.py ; with :
2336 - build_extWrap class to wrap generically all extensions,
2337 - ExtensionWrap base class for all wrapping extension that contains
2339 - Wrapper interface which wrap sources
2340 + In WrapSwig.py we have extension and wrapper for Swig
2341 + In WrapVTK.py we have extension and wrapper for VTK
2342 * MANIFEST.in : modifications to consider vtk directory and new python
2343 files for compilation
2345 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2346 * Added python wrappers of vtkGdcmReader vtk class (see the
2347 source in vtk/vtkGdcmReader.cxx) :
2348 - vtk/Makefile.am now builds a library
2349 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2350 python library (as opposed to _gdcm.so wich are the python
2351 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2352 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2354 - configure.in has an additional flag --enable-vtk that needs
2355 to be set to enable compilation of vtk related code, that is:
2356 + vtk/vtkGdcmReader.so and
2357 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2358 + gdcmPython/vtkgdcmPython.so (see above)
2359 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2360 be read when compressed or when HighBit + 1 != BitsStored),
2361 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2362 the usage of the python wrapper of vtkGdcmReader vtk class.
2363 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2364 * src/*.[h] all occurences of stl classes are now prefixed with
2365 std::, and all occurences of "using namespace std;" where removed.
2366 This is to avoid pollution of global namespace in included files.
2367 Apparently vtk does not avoid this pitfall: when using both
2368 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2369 collision of various stl members (principally cout...).
2370 * gdcmPython/testSuite.py now cleanly removes temprory generated
2372 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2373 comply with above changes)
2375 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2376 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2377 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2378 vtk data structure (an image Flip was required).
2379 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2380 * cosmetic changes in documentation.
2382 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2383 * src/gdcmHeader.cxx: the constructor no longer exits when an
2384 unexisting file is given as argument.
2385 * The subdirectory Data (containing all the images used for the
2386 test suite) is not part of this repository anymore. A new module
2387 containing those images is now available at
2388 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2389 with the name gdcmData.
2390 All the python scripts (including the package initialisation file
2391 gdcmPython/__init__.py) were adapated to take this change into
2392 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2394 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2395 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2396 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2397 demo of the usage of this class.
2398 Compilation of this vtk part is only done when using the --enable-vtk
2399 at configure (or autogen.sh) stage.
2401 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2402 * More memory link related corrections and documentation fixes.
2404 - maximum info is obtained with a command of the form:
2405 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2406 --show-reachable=yes PrintHeader
2407 - the remaining reachable blocks seem to come from the STL
2408 allocation scheme through the usage of map and list. It looks
2409 like this memory cannot be freed but it is not a memory leak
2410 (in fact further invocation to the STL would recollect the
2411 unused memory allthough it cannot explicitely be freed).
2412 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2413 of displaying an image parsed with gdcm and displayed with VTK.
2414 Note: some images don't seem to work e.g.
2415 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2416 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2417 Allthough this weakens the semantics, it is a ditch attempt to
2418 make gdcm more thread friendly.
2420 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2421 * Memory link hunt (by using valgrind through the command
2422 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2423 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2424 gdcmHeader::_dicom_vr.
2425 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2426 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2428 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2430 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2431 * src/Makefile.am now exports all the necessary include files at
2435 * UpdateGroupLength replaced by new one
2438 * UpdateGroupLength re-written using H-Table
2439 (named UpdateGroupLengthNew untill checks are over)
2441 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2442 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2443 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2445 - gdcmHeader::GetPubElValSet removed.
2446 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2447 UpdateGroupLength, WriteElements, Write.
2448 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2449 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2450 carried the same semantics.
2451 - src/gdcmHeaderIdo.cxx changed accordingly.
2452 - gdcmFile::WriteBase now regroups all the codes from previous
2453 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2454 - enum FileType moved to gdcmCommon.h
2455 * src/gdcmHeader.cxx AddDefault trashed
2456 * gdcmGetXSize added
2457 * getimageDataSize now calls gdcmGetXSize
2458 * Test/*.cxx changed to agree with above changes
2460 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2461 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2462 (to avoid double call by end user).
2463 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2464 by end user, since gdcmHeader::gdcmHeader now handles it.
2466 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2467 * gdcm/Doc many doxygen changes:
2468 - Doxyfile now has two different versions, DoxyfileUsers that generates
2469 the html.users end users oriented documentation and
2470 DoxyfileDeveloppers that generates the html.developper developper
2471 oriented documentation.
2472 - README changed accordingly
2473 - requirement.txt removed (old design info moved to TODO).
2474 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2475 DoxyMainPage.txt, DoxyPython.txt provide more information.
2476 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2477 be updated by simply regenerating the docs with doxygen and copying
2478 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2479 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2480 all the tests in the form "if (<map>.count() >1)" were removed.
2481 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2482 ill-formed documentation sections.
2483 * src/gdcmHeader.cxx: ditto
2485 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * setup.py fixed for un*x (needed macro for stdint.h)
2487 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2488 un*ces with sh-utils test utility.
2489 * gdcmPython/demo/test.py renamed to PrintHeader.py
2490 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2491 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2492 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2493 * src/gdcm*.cxx JPR's bad inclusion fixed.
2495 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2496 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2497 * gdcmPython/demo/test.py changed accordingly.
2499 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2500 * gdcmPython/Makefile.am fixed linking against libstdc++
2501 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2502 * Swig subdir (historical tests of swig version 1.3.17++) removed
2503 * Test/testChangeEntete.cxx some lines commented out in order to make
2505 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2506 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2508 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2510 hence the user doesn't need this explicit call.
2511 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2512 i.e. LoadElements() call removed.
2513 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2514 - src/Makefile.am declares the proper flag for g++.
2515 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2516 for adding user defined new tags.
2517 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2518 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2519 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2521 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2522 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2523 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2524 src/Makefile.am : the project should properly compile and install
2525 with the autotools, included the python wrappers part.
2526 * gdcm.spec.in : added a spec file for RPM packaging.
2528 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2529 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2531 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2533 to exported to the environement (see gdcmPython/testSuite.py
2535 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2536 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2537 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2538 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2539 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2541 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * gdcmPython/__init__.py doesn't crash anymore when running in
2543 in InstallMode or PreInstallMode but with an environement given
2544 value of GDCM_DICT_PATH.
2545 * src/gdcmDictSet.[cxx/h] coding style.
2547 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2549 * src/gdcm.h general comments moved to TODO, and README
2550 * src/gdcm.h should now be seen as a user commodity (including it
2551 should suffice to fully use gdcm). It is nowhere including within
2552 any of the kernel files src/*.cxx and src/*.h.
2554 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2555 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2556 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2558 * src/gdcm*.cxx only include their corresponding include file
2559 (as opposed to gdcm.h)
2560 * gdcmPython/gdcm.i changed accordingly
2561 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2562 the autogen.sh generated "make snapshot" command to work.
2563 * autogen.sh removed history related references to crea package.
2565 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * distutilsSwigCPlusPlus.py work around some swig portability
2569 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2571 was done in a last ditch attempt to get setup.py _really_
2572 operationnal. The python/gdcmPython layaout add the advantage
2573 of hidding away the python related distutils specific files
2574 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2575 Alas, the src directory was out of scope (i.e. it's relative
2576 position to setup.py was ../src) which made things impossible to
2577 handle (see previous version of python/setup.py). Crossing fingers...
2579 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2580 * python/setup.py now works on Un*x. (harder than I thougth)
2581 * python/distutilsSwigCPlusPlus.py can now have include files
2582 among the list of sources.
2584 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2585 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2586 * modifications in MSVC projects
2588 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * As stated by the first lines of Test/ExceptionAndPython/README, it
2590 looks like we can move back to original usage of exception within
2591 src/gdcm* and hence remove the errno stuff that was introduced
2592 as a quick and dirty fixture of this problem (added to the TODO).
2593 * Doc/Doxyfile configuration file for Doxygen and corresponding
2594 README file for usage added.
2595 * Test/testWrite.cxx added. This new test comes from a split of
2596 test.cxx that is now reverted to its original purpous i.e.
2597 testing the proper parsing of a Dicom related file.
2598 testWrite.cxx concentrates on testing the IO part of gdcm.
2599 * Test/bug1.cxx (containing a bug on WIn32) added.
2600 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2601 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2602 whose purpose is to publish the content of the TagNames of the
2603 Dicom public dictionnary were not accessible without an
2604 instance of class gdcmHeader.
2605 - those methods are now static methods of gdcmDictSet and hence
2606 require no instances at all to be invocated.
2607 - within gdcmDictSet this change required to change some method
2608 to class methods (i.e. are now static) among which SetDictPath
2609 (renamed to BuildDictPath) and LoadDefaultPubDict.
2610 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2611 the above changes by calling the new method classes of gdcmDictSet.
2612 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2613 the above to be effective.
2614 * python/gdcmPython: in order to wrap properly the above changes
2615 for Python, swig version now needs to be > 1.3.17.
2616 * python/gdcmPython/Makefile fixed to adapt itself to new
2617 configure/make shema introduced by Johan Montagnat (thanks for the
2618 contribution). Alas this Makefile cannot be turned into a proper
2619 Makefile.am without some heavy changes in the configure.in
2620 (for python dectection).
2621 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2622 now avoids publishing the empty entries.
2624 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2625 * python/setup.py : bug fix concerning install under windows
2626 ExtraPath reused :-P
2627 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2629 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2630 * Dicts/dicomV3.dic : remove double spaces !!!
2631 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2632 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2635 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2636 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2637 method. Doxygenation.
2638 * src/gdcm.h clean up of JPR spurious comments.
2640 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * python/distutilsSwigCPlusPlus.py now properly collects the
2642 shadow classes generated by "swig -c++" (gdcm.py in our case)
2643 when using "python setup.py install".
2644 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2645 reexports the working classes.
2646 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2647 by the classical C errno scheme. This is to prevent an obscure
2648 behavior of the python wrappers when importing wxPython.wx prior
2649 to gdcmPython (which ended up in an abort call). An illustration
2650 of this oddity can be found in the Test/ExceptionAndPython
2651 subdir (see the README file). This problem probably due to
2652 an combination of g++ and dynamic loading.
2653 * added Test/ExceptionAndPython (see above)
2655 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2656 * Changed the layout of the python part to avoid bloating main
2657 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2658 i.e. the distutils arsenal. All the python related stuff is
2659 again in a python subdir, but the package itself is now in
2661 * setup.py was cleaned up:
2662 - pythonIncludePath removed
2663 - python setup.py bdist target is now functional.
2664 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2665 collision with other packages). gdcmPython/demo/*.py changed
2668 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2669 * python subdir moved to gdcmPython (preparation of distutils packaging).
2670 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2671 distutils installer is operational.
2672 * - gdcmPython/__init__.py now properly loads the swig generated
2673 shadow classes (from gdcm.py).
2674 - gdcmPython/demo/*.py changed to import the package gdcmPython
2675 instead of gdcmPython/demo/load.py.
2676 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2678 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2679 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2680 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2681 entries within the associated public Dicom dictionary resp. the same
2682 information but sorted by the fourth field (PAT, IMG, DIR) of the
2684 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2685 are now in the "???" group.
2686 - python/gdcm.i changed accordingly,
2687 - python/demo/printGroupedPublicDict.py added, that gives an example
2688 of the above new functionalities in Python.
2690 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * src/gdcm.h, gdcmHeader.cxx:
2692 - historic references to glib's g_malloc and g_free (#defined)
2693 were definitively removed.
2694 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2695 * src/gdcmElValSet.cxx:
2696 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2697 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2698 - GetElValue(string) renamed to GetElValueByName.
2699 - Added GetElementByName(string).
2700 * src/gdcmHeader.cxx: added
2701 - GetPubElValRepByNumber(guint16, guint16)
2702 - GetPubElValRepByName(string)
2703 - GetShaElValRepByNumber(guint16, guint16)
2704 - GetShaElValRepByName(string)
2705 - GetShaElValByNumber(guint16, guint16)
2706 - GetShaElValRepByName(string)
2707 - GetElValRepByNumber(guint16, guint16)
2708 - GetElValRepByName(string)
2709 - GetElValByNumber(guint16, guint16)
2710 - GetElValRepByName(string)
2711 * Doc/requirements.txt added.
2713 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * Test/Makefile building now depends on the one of libgdcm.so
2715 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2716 pixel data) aware which enables finding the address (offset) of
2717 the pixel data of JPEG encoded DICOM files. This leaves only a single
2718 file in the testSuite whose pixel data address (offset) is unknown.
2719 * python/testSuite.py changed accordingly.
2721 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2722 * VC++ has some strong limitations when working with the STL, as stated
2723 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2724 "Also note that some STL containers (map, set, queue, list, deque)
2725 cannot be exported. [...]
2726 Some STL classes contain nested classes. These classes can not
2728 This is caused by a designed limitation that once a template
2729 class is instantiated, it can not be re-instantiated and
2731 Since our usage of map<> is ubiquitous in gdcm, this "designed
2732 limitation" of VC++ is a pitfall.
2733 Hence the Python wrappers of gdcm cannot be incrementally linked
2734 against the c++ dynamic library. The dirty but only workaround is
2735 to forget about incremental link of dynamic libraries and to generate
2736 the Python wrappers library with the inclusions of the underlying C++
2738 The following modifications concern this matter on Win32/VC++:
2739 - wrapping python correct with standalone wrapped dll (don't use separate
2740 dll under windows !!!!)
2741 - python21_d debug mode enabled (ask Frog how to use it :-)
2742 - NO problem with having an STL member of class for example string in C++
2743 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2744 - Python test of dcmlib in Python is ok under windows on a large set
2746 * removed glib references
2747 * typedef's inserted in gdcm.i for correct swig type management
2749 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * python/demo/*.py load.py extracted from test.py. Added explore.py
2751 that only displays required tags and testAll.py that parses all
2752 the files of the testsuite without using unittest.
2753 * python/testSuite.py other additional test on new files added.
2754 * Data/* new test files added accordingly to the testSuite.
2755 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2756 the vr in the file differs from the one of the dictionary.
2758 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2760 values, but limits itself to values which are below a user specified
2761 size (by default 1024 bytes).
2762 * python/gdcm.i : elements not loaded (because their size is above the
2763 user specified treshold) are exported with their TagKey as key of the
2764 python dictionary. This enables the testsuite to make some checks
2765 on the unloaded elements (since we have their offset and size).
2766 * python/testSuite.py
2767 - now tests for the existence and proper value of the pixel data
2768 - two new examples added.
2769 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2771 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2772 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2773 aware. See the strategy comments in gdcmHeader::FindeLength().
2774 * Test/test.cxx now accepts a filename as first argument.
2775 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2776 * python/testSuite.py changed to integrate test on above files.
2778 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2780 the vr was also RET.
2781 * python/testSuite.py more tests added.
2783 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * python/testSuite.py unittest test suite added (uses Data)
2785 * Data/* dcm and acr files for the test suite.
2786 * glib dependance removed from un*x version. We now use ISO C99
2787 7.18 Integer types (see stdint.h)
2788 - python/Makefile, src/Makefile src/gdcm.h
2789 * src/ when an explicit vr (like dicom files) suddenly poped an
2790 implicit element we use to mark the underlying DictEntry of the
2791 concerned ElValue with "Implicit". This strategy was damageable
2792 too the public or provite dictionaries, since some of their vr
2793 would be changed. Since Header::FindLength heavily relies on the
2794 detection by Header::FindVR of falsely explicit elements, I
2795 added an extra ImplicitVr member to ElValue (boolean).
2796 The rest of the changes we the necessary adaptations.
2798 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2799 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2801 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2803 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2804 * Adaptation for porting to VC++:
2806 o forced to use std namespace (for string to be known)
2807 o all class use __declspec export style on WIN32
2808 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2809 (in stdlib.h on Win32 but in std:: for gcc)
2810 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2811 variable GDCM_DICT_PATH.
2812 * src/gdcmHeader.cxx verbose comments made discrete.
2814 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2815 * python/gdcm.i: added a typemap that converts a C++ hashing table
2816 to native Python dictionary.
2817 * python/demo/test.py:
2818 - now uses the native dictionary for exploration of gdcmHeader.
2819 - takes an optional filename argument (the file to parse).
2820 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2821 PubElVals hashing table.
2822 * Dicts/dicomV3.dic removed error prone trailing spaces.
2824 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2825 * Python wrapping process moved away from src/Makefile to
2826 newly created python/Makefile (as well as gdcm.i)
2827 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2828 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2829 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2830 from the environement variable GDCM_DICT_PATH (when existing).
2831 * src/gdcmDict::GetTag bug fix.
2833 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2834 * Straightforward temporary fixes for swig to build the python wrappers.
2835 src/Makefile now has a python working entry [by working we mean
2836 that we can import de shadow classes without errors].
2838 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2839 * hashtest.cxx removed (since allready in Test)
2840 * src/gdcmlib.h renamed to src/gdcm.h
2841 * src/dcm.i renamed to src/gdcm.i
2842 * src/Makefile prepared for python wrapping
2844 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2845 * src/gdcmHeader.cxx :
2846 - Parsing of header is now separated from loading of element values
2847 (see gdcmHeader::LoadElements).
2848 - general clean up of hopefully all file access (creation of
2849 ReadInt16 and ReadInt32)
2851 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2852 * src/gdcmHeader.cxx :
2853 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2855 - SetLgrElem renamed to SetLength
2856 - GetLgrElem renamed to GetLength
2857 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2858 * src/gdcmElValSet.cxx fixed both GetElValue methods
2859 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2860 due to IdoDude was cleaned out.
2862 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2863 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2864 concentrates on finding the value representation (when it exists).
2865 RecupLgr now only finds the element value length, and it avoids
2866 returning the unecessary skL (skipped length).
2867 Also, offsetCourant was simply removed (with taille_fich) since
2868 it was redundant with the File position internals (by using
2869 ftell and fseek). This also made skL (see above in RecupLgr) usage
2871 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2872 on the libido specificities which are handled through class
2874 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2877 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2878 * Truckload of changes. Parsing of header is barely functional
2879 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2881 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2882 * src/gdcmHeader.cxx many addons of low level methods
2884 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2886 and _IdDcmSWAP_LONG.
2888 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2889 * This corresponds to all the changes decided at the meeting of
2890 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob