1 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
3 you debug/warning message just as c++ streams which make them very convinient
4 to use. Once this is stabilize I will change the ostringstrem to be
5 redirected to a file (ofstream).
6 * Properly support C99 extension: __FUNCTION__ which allow us to display
7 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
9 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
10 * Removal of useless and dangerous methods :
11 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
12 GetDocEntryByName, GetEntryByName, GetDictEntryByName
13 * Removal of usless methods :
14 Dict::PrintByName, Dict::GetDictEntryByName
15 * Commenting out of probabely useless methods :
16 Dict::GetDictEntryNames()
17 Dict::GetDictEntryNamesByCategory()
18 DictSet::GetPubDictEntryNames()
19 DictSet::GetPubDictEntryNamesByCategory()
20 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
21 * ENH : Use dicomTS.dic as described in 2004 version
22 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
23 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
24 Add Accessors on VM (Value Multiplicity), and VM related methods
25 * ADD : Add a list of 'Dicom Attribute types', as found in
26 http://medical.nema.org/dicom/2004/04_15PU.PDF
28 * ADD : Add dicomGroupNameAbbreviations.dic
29 should be used to write a method to replace the former
30 Dict::GetDictEntryNamesByCategory()
32 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
34 to read in the file... and only it ! Length is the efective length of the
35 data in the DocEntry structure
37 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
38 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
39 And now use a static function call instead, with a global variable. i
40 This is much closer to the VTK approach. Hopefully should be bulletproof
41 and easier to use...hopefully
43 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
44 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
46 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
49 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
51 ValEntry, BinEntry, SeqEntry creation or replace
53 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
55 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
57 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
58 when specifying the VR
59 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
60 * src/gdcmDocEntry.cxx : amelioration of print
62 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
63 * ADD : Add the method Util::IsCurrentProcessorBigEndian
64 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
65 * ADD Method Document::ComputeGroupLength
66 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
67 in order to allow further VR modification by user
68 * REM : removal of once-called method File::WriteBase
69 integration of its code in formerly one-line method File::Write
71 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
73 replace the different values "??", "Unkn", "Unknown".
74 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
75 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
76 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
77 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
79 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
82 * Set the gdcm::Base class to some Printable classes
84 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmFile.[h|cxx] : add the Print method
86 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
87 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
88 * src/gdcmDocument.h : remove the PrintLevel informations
89 * Example/PrintFile.cxx : use the new gdcm::File::Print
91 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
93 problems when compiling with the python wrapping
95 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
97 writting in ImplicitVR
99 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
100 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
101 JPEG decompression, especially when dicom frames are split into several
102 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
103 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
105 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmHeader.cxx : change the initialisation of default header.
107 Now, this header is readable by gdm, e-film, DicomWorks
109 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
111 Rename Decompressed to Raw
112 * Use the API changes in gdcm::File.
113 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
116 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
118 each added entry in the header. Replace the 'Planes' field by the 'Number
121 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
123 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
125 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
127 At this time, this image isn't readable by e-film... waiting JPR help to
130 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
132 DocEntry. Now use methods of the Document !
134 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * Test/ShowDicomSeq.cxx : bug fix
137 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
139 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
140 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
141 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
143 * Test/TestCopyRescaleDicom.cxx : remove unused variable
144 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
145 containing found sequences
147 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
150 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
151 Some fields in BinEntry must be copied to not seg fault when making the :
152 gdcm::File *copy = new gdcm::File( copyH );
153 and tests are now made on good variables
155 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
157 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
159 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
160 * Add vtkGdcmWriter example and test
162 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * Test/TestUtil.cxx : reformat the source code
164 * vtk/vtkGdcmReader.cxx : remove and change prints
165 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
167 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
168 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
170 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
172 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
174 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
176 by an eof to prevent all bad read of the file... and in this case, the
179 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * Example/Volume2Dicom.cxx : comment unused variables
181 * Test/PrintDicomDir.cxx : comment unused variables
182 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
183 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
184 method that is redondant with AddEntry.
185 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
188 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * Bug fix due my last commit (compilation under Windows).
190 * Example/Volume2Dicom : bug fix in the file and reformatting source code
191 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
193 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
195 - Remove printf / sprintf
196 - include iostream AFTER gdcm so we don't get warnings
197 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
199 - Also remove tons of include from header files, hopefully this should
200 speeup the compilation time, since it was becoming a dog slow.
201 - Remove gdcm.h as it include way too many files and slow down compilation
202 (plus it is not up to date)
203 - remove 'using namespace std' this is BAD !
205 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * Remove memory leaks on the DicomDir
207 * Remove some useless data in DicomDirObject
208 * Add usefull methods in SQItem, to be complient withe the ElementSet
210 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
211 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
213 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
215 future, with convertion)
216 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
217 and ImageDataSize values. Remove the method to get the PixelReadConverter
218 from the output of the class
220 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
223 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
225 and vtkErrorMacro use.
226 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
228 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
231 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
232 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
233 The string leaves only in the fonction. So when we make a .c_str(), we
234 get the pointeur on the first element, element that will be destroyed
235 immediately after thee instruction.
236 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
237 file has been opened : the test must be made on the content of the
238 pointer and not directly on the pointer !
241 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
243 the python part recompiles
245 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
247 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
248 X session is killed (for my computer... it seems to not be identic on
251 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
253 avoid problems (otherwise, the difference test between the visible image
254 and the reference is incorrect. If the reference is greater than the
255 screen resolution, it's produce errors).
256 Can be used for only one image. Can be used with a visible flag.
257 * vtk/vtkGdcmReader.cxx : remove commented codes.
258 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
259 under windows at compilation
260 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
262 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
264 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
266 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
267 tests on the image size X, Y, Z
269 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
271 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
272 between the class name and the file name
274 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/ : fix compilation warnings for the Write method (2 different
276 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
277 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
278 variable... create a static method in gdcm::Document to access to
279 this variable content.
281 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
283 file, to be accessed by other files (like gdcmFile). Remove commented
284 code. Move the change of the header to the gdcmFile, using the
286 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
287 To be sure of that (and simplify calls), the Write of the header now
288 gets a file name and not a file pointer (std::ifstream).
289 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
290 DocEntryArchive. Remove all open of the written file
292 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
295 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
297 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
299 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
300 some corresponding methods. Write correctly the file and check before
302 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
303 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
304 is now on RGB data (as before my last commit
305 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
307 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
309 Add a print information of the type of the entry
310 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
311 It was in the gdcmFile, and all write have been regrouped
312 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
313 Write correctly all dicom files (in decompressed mode only at this time)
314 * Test/ : test on files are now made using Raw data and not color data if
316 * Example/PrintFile.cxx : add more printings
318 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * Amelioration of code, remove some code copy. For the loading of
320 BinEntry (in gdcmDocument), add the test to verify if the file is already
323 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
325 remove a DocEntry in the header (push an empty DocEntry)
326 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
327 lines. Bug fix in the initialization of the PixelConvert and the
329 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
330 use in TestCopyDicom (now this test can run under windows... but fails)
331 * Test/TestCopyDicom.cxx : amelioration of the test :
332 - test the pixels written
333 - add test points to quickly find where is the error
334 - can set a file name input and output in arguments
335 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
336 amelioration of the test output
338 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
339 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
340 all replaced DocEntry's
341 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
342 Now, each needed DocEntry to modify is duplicated, modified and inserted
343 to the header using DocEntryArchive. Thus, after save, we can restore the
344 header initial state.
346 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
347 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
349 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
351 correct to copy it. The DictEntry is specified at the DocEntry creation,
352 then, it musn't change in the time.
353 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
354 header correctly. At this time, the change is only made for the first
355 level of the Document. In the future, it might consider sequences.
356 The change is made by replacing a DocEntry by an other that is created
357 outside the class. The old value is kept. When we restore the header
358 status, the added DocEntry is deleted and replaced by the old value.
359 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
360 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
361 set the write type to explicit VR, implicit VR or ACR. Add methods to set
362 the write mode to native, decompressed or RGB (but not used at this time)
364 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
365 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
366 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
368 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
369 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
370 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
372 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
373 set because already copied when copying the BinEntry's of the header
374 * Test/TestAllReadCompareDicom.cxx : remove warnings
376 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
377 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
378 Two problems appear when doing it :
379 - with the gdcmFile : when the GetImageData method is called, the pixels
380 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
381 data (pixels). And each structure destruct the data when it's
382 destructed. So we have two destructions for the same data. To solve it,
383 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
384 data or not. If it doesn't own data, then they will not destroyed by
386 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
387 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
388 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
389 create a double destruction of the same DocEntry's. So, to solve it,
390 the TagHT is simply cleared and the DicomDir* elements are destroyed.
391 * TODO : add an entry concerning memory leaks in the DicomDir
393 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
395 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
398 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
399 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
400 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
401 after it have been deleted
403 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
404 * FIX: src/* fix the doxygen warnings.
405 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
406 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
407 was erroneously defined with a size of 15 instead of 16. [many thanks
408 to Jean Michel Rouet for pointing out this bug].
410 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
411 1. Finish merging JMR patch for writting DICOM from scratch
412 2. Fix -hopefully- bug with MONOCHROME and space vs null character
413 3. Use const ref when possible
414 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
415 5. A few more comments
416 6. CreateUniqueUID can now be called without parameter"
418 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
419 * ENH: Slightly bigger patch:
420 1. Getting toward full integration of JMR patch for writting dicom from scratch
421 2. Update Test to test part of this patch: CreateUniqueUID
422 3. File was not close properly in gdcmDict
423 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
424 5. Use of const ref instead of copy (speed issue)
425 6. Remove temporary (duplicate) string in TranslateToKey
426 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
427 8. Do not repeat virtual in subclasses
428 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
430 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
431 * Apply first patch toward better string comparison when dealing with broken
432 DICOM files. Essentially the string could be padded with a space instead
433 of a null character as defined by standard
435 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
436 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
437 because never used... and in the same time, that's remove some memory leaks
439 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * src/gdcmFile.cxx : now delete the PixelConvert instance.
441 * In examples and tests : change the type of image data variables from void*
442 to uint8_t*. Remmove all delete on image data variables
444 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
445 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
446 Verify the file pointer value before open the file, and if it's not null,
447 a verbose message is generated.
448 Close correctly the file when the file isn't considered dicom-like. The
449 correctly close is a call to CloseFile.
450 When closing the file pointer, test if its not null to close the file.
451 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
452 file. For an uncompressed image, the copied data correspond in the least
453 case to the image size (calculated) or the image size specified in the
454 header. A verbose is generated if these two size mismatch
456 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
457 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
458 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
459 break under windows (with msvc6 compilation).
461 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
462 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
463 compiling with MSVC6)
465 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
466 * Bugs fix for the Windows build with VC6
467 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
468 needed (only for projects required VTK). If the VTK is included in all
469 projects, there is conflicts with the jpeg lib of vtk when compiling the
470 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
471 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
472 when compiling the gdcm_wrap.cxx file (created by the compilation of the
474 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
475 (like it's already made for the cout use). Otherwise, conflict with the
478 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
479 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
481 - comments on the DicomDir::Method related usage added.
482 - now that we use the namespace gdcm, a lot of internal classes do
483 NOT need to be wrapped anymore.
484 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
485 DicomDir::Method) new example added.
487 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
488 * Improve string manipulation. I now inforce the notion of 'DicomString'
489 A DicomString can contain as many \0 as they want
490 and it is *always* of even length.
491 We only support odd length for very rare case.
492 And in the near future this should be removed.
494 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
495 * /binary_write/ gdcm source. Now even on big endian we are writting
496 little endian. This should -heopfully- fix some tests
498 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
499 * Now the dictionary is compiled into gdcm lib. This is a default
500 behavior, thus any dic file specified is picked before failback to
501 the one comiled into lib
503 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
504 * Change internals for gdcmDict. Don't use any 'new' any more.
505 This should definitely solve any leak problem, and we should be
506 as fast as before, as long as don't modify too much the dictionary.
508 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
509 * STYLE: ivars should start with a capital letter.
510 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
511 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
513 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
515 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
516 new 2004 dictionaries added (thanks to JPR).
517 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
518 * CLEANUP_ROUND (15) for gdcmPixelConvert
519 - RLEFrame::NumberFragments is now of type unsigned int
520 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
521 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
524 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
525 * Initial work in gathering all transfer syntax accessors. clearly
526 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
527 ivars, but only one transfersyntax (class) ivar with equivalent method on
530 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
531 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
532 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
533 discussed (plus I didn't like having a 2000 lines patch not commited)
535 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
537 * CLEANUP_ROUND (14) for gdcmPixelConvert
538 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
539 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
540 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
542 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
543 anymore and hence avoids storing a copy of PixelConvert::Decompressed
544 into File::Pixel_Data.
546 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
547 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
548 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
549 * CLEANUP_ROUND (13) for gdcmPixelConvert
550 Substituted File::ParsePixelData() with PixelConvert::Print() new
552 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
553 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
554 method to those classes.
555 - src/gdcmFile.[cxx|h]:
556 -- Added a ::Print() method.
557 -- PixelConverter is now a reference instead of a member.
558 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
559 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
561 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
562 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
563 collaboration diagram and inheritance diagram should be generated with
565 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
566 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
567 pointlessly wrapped (see
568 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
569 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
570 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
571 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
572 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
573 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
574 -- File::Initialise: PixelConverter setup moved away to
575 PixelConverter::GrabInformationsFromHeader()
576 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
577 interpretation moved away to PixelConverter::BuildRGBImage()
579 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
580 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
581 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
583 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
585 displayed on Win32 when a brutal abort() occurs (because of uncatched
586 exception). See TODO new entry of this commit for more on this.
587 * TODO added new entry.
588 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
589 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
590 - HandleColor is no longer called from gdcmFile.cxx
591 - gdcmPixelConvert.cxx clean up on method arguments and internal
592 variable names for semantical coherence.
594 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
595 * Finished lossless transition, not only do we now read all lossless jpeg
596 images, without the need of the Cornwell lib, but we do read them properly now
597 * To reduce code (well to avoid code duplication), I defined a common place
598 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
599 redefine symbols. This is not prefect but this the best solution I found for a
600 compilation time jpeg option.
602 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
603 * Update jpeg ijg lib to support lossless jpeg implementation
604 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
606 * Also added a special copyright for dcmtk since we use their bugfixes.
609 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
610 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
611 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
612 matters, as stated in warning note at begining of %include section).
613 * src/gdcmDicomDir*.[cxx|h]: coding style
614 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
615 * src/gdcmJpeg8.cxx: doxygen fix.
616 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
617 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
618 from File:: to PixelConvert::.
620 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
621 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
622 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
623 - more code moved away from File:: to PixelConvert::
624 - fat setup of PixelConverter set in place in File::Initialise.
626 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
627 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
628 namespace at the file system level. So now you should convert your examples
630 gdcmHeader -> gdcm::Header
631 It would be nice if people keep in mind to no open the namespace, since it
632 allows compilation on broken plateform which were defining common symbol in
633 the standart namespace (like LP, Unknown ...)
635 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
636 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
637 The JPEG fragments are now parsed at the same stage than the RLE
638 information. All code related to JPEG is now in gdcmPixelConvert:
639 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
640 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
641 export a gdcmFile:: method. Those are simply global functions
642 (for the time being this is better than having them attach to
643 either gdcmFile:: or gdcmPixelConvert::).
644 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
645 and stores the result in a gdcmJPEGFragmentsInfo.
646 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
647 code (among other stuff) moved away from gdcmFile:; to
650 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
651 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
652 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
653 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
654 clean up of RLE related code.
655 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
656 - src/gdcmRLE.cxx removed
657 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
658 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
659 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
660 * CLEANUP_ROUND (9) for gdcmPixelConvert
661 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
662 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
663 away from gdcmFile:: to gdcmPixelConvert::.
665 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
667 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
668 This is because Parse7Fe0 used to parse the pixels to compute the
669 length. This task was passed over to FindDocEntryLengthOB() a long
670 time ago, EXCEPT I had forgotten the OW case...
671 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
672 we just recylce the code for parsing RLE fragments and computing
674 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
675 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
676 with the retired Parse7Fe0().
677 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
678 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
680 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
681 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
682 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
683 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
684 - src/CMakeLists.txt: alphabetic order reodering + new entries.
685 * CLEANUP_ROUND (4) for gdcmPixelConvert
686 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
687 to return an unused length.
689 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
690 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
691 this should be cleanner from the plane view. The iostream are erally a pain
692 to use to do simple stuff.
694 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
695 * Redo the compilation of the ijg jpeg library. Now only one source is
696 necesseray. No need to rename file by hand what so ever. CMake handle the
697 copying of the file within different directory, configure header file to
698 modify some symbol. The only addition made to ijg wasd a mangle table so
699 that symbol are different wether we are within 8bits or 12bits.
701 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
702 * Added documentation of vtkgdcmReader on Website:
703 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
704 with it's binary name).
705 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
706 the Website to be more complete.
707 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
708 doxygenated documentation.
709 - Doc/DoxyVtkGdcmReaderExamples.txt added
710 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
711 DoxyVtkGdmReaderExamples.html )
712 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
713 * CLEANUP_ROUND (3) for gdcmPixelConvert
714 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
716 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * CLEANUP_ROUND (2) for gdcmPixelConvert
718 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
720 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * CLEANUP_ROUND for gdcmPixelConvert:
722 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
723 - src/gdcmPixelStuff[h|cxx] removed
724 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
725 - src/CMakeLists.txt changed accordingly
727 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
728 gdcmVersion.py moved to newly created ATTIC related
729 gdcmPython/SetupOldies/ directory.
730 * Autotools clean up:
731 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
732 - autogen.sh configure.in acinclude.m4 python.m4 removed
734 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
735 * src/*.cxx *.h Reference to License.htm fixed to License.html.
736 * Doc/CMakeLists.txt, doxygen.config.in: fix.
737 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
739 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
740 * TODO updated with Mathieu suggestions. I proposed a template for
741 describing TODO entries and used it for new entries.
742 * Added Doc/Website/CodingStyle.html, Developpers.html,
743 DeveloppersPython.html, GdcmDataCvs.html and
744 DownloadVersion0_1.html, DownloadVersion0_3.html.
745 * Some Doc/*.txt Doxygen files (which do not really concern the
746 documentation itself, but the website) moved to html and
747 placed in directory Doc/Website:
748 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
749 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
750 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
751 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
752 * CMakeLists.txt changed accordingly.
753 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
754 DeveloppersPython.html
755 * INSTALL nows refers to Doc/Website/Installation.html
757 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
758 * Added Doc/Website directory, that contains a first raw version
761 2004-09-23 Jean-Pierre Roux
762 * FIX In order not to be poluted any longer by casting problems,
763 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
764 we can now delete[] it safely
765 * VoidArea is now called BinArea (less confusing name),
766 and all the methods called ...VoidArea... are now ... BinArea...
767 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
769 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
770 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
771 clear) TagHT, which is an inherited member of gdcmElementSet. It is
772 up to the destructor of gdcmElementSet to clean up TagHt and it's
775 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
776 * Test/CMakeLists.txt: update to follow gdcmData renamings.
777 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
779 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
780 * ENH: added some utility method that builds a flat dictionnary
781 holding all the Dicom entries contained in the recursive structure
782 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
784 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
785 BuildFlatHashTable() that build a flat dictionary.
786 - src/gdcmElementSet.h: added a new private GetTag() accessor.
787 gdcmDocument is now a friend of gdcmElementSet.
788 - src/gdcmElementSet.cxx: clean up.
789 - Example/FlatHashTablePrint.cxx added.
790 - Example/CmakeLists.txt changed accordingly
792 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
794 moved away from gdcmDocEntrySet (since this class is an abstract class
795 acting like an interface). SQDepthLevel and BaseTagKey are now
797 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
798 and associated accessors. Doxygenation of the class.
799 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
801 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
802 Use SQDepthLevel accessor instead. ::Print() adapted.
803 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
804 - src/gdcmDocument.cxx changed accordingly.
806 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
807 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
808 - The following is the doxygen comment of the typedef declaration
809 of gdcmagKey in src/gdcmCommon.h:
810 gdcmTagKey is made to old an "universal" (as in URL, Universal
811 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
812 A dicom tag allways has a group and an element, but a set of tags
813 embeded in various (optionally nested) sequences and sharing
814 the same group and element all share the same (group, element)
815 "identifier". Hence the (group, element) cannot be used as an
816 identifier (in gdcm we shall refer to a "TagKey") of a tag.
817 In order to construct a proper tag identifier (i.e. a key) we
818 consider the following definition of a TagKey:
819 - let Group, Element be the string representation of the
820 group and element dicom tag members,
821 - let ItemNumber be the string representation of the integer
822 index of the considered item number of a sequence,
823 Let the key of a tag embeded in a sequence, noted SeqTag, be
825 /ItemNumber#Group|Element
826 where "/", "#" and "|" are characters acting as separators.
827 Then the general form of a gdcmTagKey is given by:
828 Group|Element<SeqTag>
829 where <SeqTag> means NO or many instances of SeqTag.
830 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
833 but the gdcmTagKey of a tag "embeded" is the first item of
834 a sequence, itself nested in the third item of a sequence is the
836 0004|1220/2#0008|0082/0#0008|0090
837 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
838 order to hold the new sequence compatible key. Previously, the
839 GetKey() method would look in the underlying gdcmDictEntry.
840 - src/gdcmDocEntry.cxx:
841 -- constructor now copies the underlying DictEntry key, in the local
843 -- ::Print: displays the member Key, instead of the (group, element).
844 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
845 - src/gdcmDocEntrySet.h:xi
846 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
847 -- now has a new BaseTagKey member.
849 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
850 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
852 This poses the problem with the semantics of the following lines
853 LoadEntryVoidArea(0x0028,0x1201); // R LUT
854 LoadEntryVoidArea(0x0028,0x1202); // G LUT
855 LoadEntryVoidArea(0x0028,0x1203); // B LUT
856 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
857 to the long FIXME note for what the problem is. Nevertheless in
858 order to get things working the dicom dictionary was altered !
859 Please fix things urgently...
860 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
861 information), see above note on moving the member VoidArea. Nevertheless
862 the following entries previously correctly set as US are now inproperly
864 0028 1201 OW IMG Red Palette Color Lookup Table Data
865 0028 1202 OW IMG Green Palette Color Lookup Table Data
866 0028 1203 OW IMG Blue Palette Color Lookup Table Data
867 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
868 of gdcmDocEntry moved to gdcmSeqEntry.
869 * src/gdcmSeqEntry.cxx: STYLE.
871 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
872 * Test/TestAllEntryVerify.cxx minor fix and added comments.
874 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
875 * gdcmPython/testSuite.py: all the test suite in python is now moved
876 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
877 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
878 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
880 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
881 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
882 to avoid inclusion recursion until STL is reached.
883 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
884 mecanism. errno.h is not included in gdcm anymore.
885 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
886 (gdcmFormatError now inherits from gdcmFormatUnexpected).
888 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
889 gdcmData/TestAllEntryVerifyReference.txt
890 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
891 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
892 exception_on_error parameter.
893 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
894 - vtk/vtkGdcmReader.cxx changed accordingly,
895 - Example/*.cxx and Test/*.cxx changed accordingly.
897 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
898 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
899 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
900 enable_sequences removed from gdcmHeader constructor and dependencies.
901 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
902 * gdcmPython/demo/PrintHeader.py: dummy fix.
903 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
904 skip_shadow removed from gdcmHeader constructor and dependencies.
905 * Example/*.cxx and Test/*.cxx changed accordingly.
907 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
908 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
909 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
911 2004-07-21 Jean-Pierre Roux
912 * FIX Now, Parsing and Printing a DICOMDIR do work!
913 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
915 2004-07-20 Jean-Pierre Roux
916 * FIX Some brain damaged headers have Zero-Lenght fields
917 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
919 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
920 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
921 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
922 variable (instance of gdcmDebug) by a definition macro, and the instance
923 is now in static in the gdcmDebug class
924 * src/gdcmSQItem.h : (FIXME) remove an undefined method
925 * Test/PrintAllDocument.cxx : bug fix in the result of the test
927 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
928 * WARNING: ctest now depends more tightly on gdcmData. You should
929 check out gdcmData properly for things to run smoothly...
930 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
931 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
932 we need the pixels not be loaded in order to use the ValEntry
933 that displays position and size).
934 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
935 This is a C++ based equivalent of gdcmPython/testSuite.py that should
936 be deprecated. If you have any doubts about the advantages of a
937 modern scripting language (read Python) versus grass root C++ (i.e.
938 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
939 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
940 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
941 Anyhow, consider documenting the gdcmData images in
942 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
944 * Test/CMakeLists.txt:
945 - now uses TestAllEntryVerify.cxx
946 - specific comments on oldACR00001.ima (now renamed in gdcmData
947 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
948 gdcmData/TestAllEntryVerifyReference.txt
951 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
952 * src/*.[h|cxx] : typedef clean up
953 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
954 - TagKey renamed to gdcmTagKey (for external usage)
955 - VRKey renamed to gdcmVRKey (for external usage)
956 - removal of typedef duplication.
957 - Removed all unecessary inline keyword from class inline definitions.
958 - Some method|function(void) declarations replaced with method|function().
959 * src/jpeg/libijg12/jdhuff12.c:
960 - printf polluting ctest removed.
961 - TAB removal for comminting
963 - TestAllReadCompareDicom.cxx: added a test that compares all the
964 images in gdcmDataImages.h with corresponding images in
965 gdcmData/BaselineDicom/. When baseline images are not present
966 this test creates them.
967 Note: we need to validate each reference image, but before that
968 I'd like to rename them with a more explicit name...
969 - CMakeLists.txt: changed accordingly.
970 * Example/*.cxx: examples now only include gdcm.h (as opposed to
971 including each header needed).
973 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * Test/*.cxx and Example/*.cxx: moved some examples away from the
975 test suite to the Example directory. Are concerned:
980 - TestWriteSimple.cxx
981 * Test/CMakeLists.txt: added some comments on reasons for black listing
982 image gdcmData/oldACR00001.ima
984 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * Test/CmakeList.txt: removed the following from black list (to be coherent
986 with removal from gdcmData):
987 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
988 - gdcm-MR-PHILIPS-16.dcm
990 Added the following because after last cvs update, they cause
991 ctest -R TestReadWriteReadCompare
993 - gdcm-MR-SIEMENS-16-1.acr
995 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
996 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
997 new comments in this file) we temporarily (sigh) move to a weaker
999 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1000 we don't need to black list the following images anymore:
1001 - 8BitsUncompressedColor.dcm
1003 - US-PAL-8-10x-echo.dcm
1004 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1005 fixes and the beautified code ;-)
1006 This fixes the bug introduced in version 1.42 (when beautifying)
1007 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1008 Note: ctest was blind to this bug (this means we need to still
1009 improve the test suite). The bug could be detected by using
1010 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1012 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1013 and by displaying the (garbage) produced file temp.XDCM...
1015 2004-06-29 Jean-Pierre Roux
1016 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1017 - replace by uggly but working old code :-(
1018 A lot of things should be OK again.
1019 It's really urgent to have a test suite that *tests*,
1020 to prevent Frog's beautifying sessions to break all the stuff
1021 (twice, withing a fortnigh ...)
1023 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1024 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1025 redundancy) to added Test/TestReadWriteReadCompare.cxx
1026 * Test/CmakeList.txt: because the compare test of
1027 Test/TestReadWriteReadCompare.cxx fails, the following images are
1028 black listed: - 8BitsUncompressedColor.dcm
1030 - US-PAL-8-10x-echo.dcm
1031 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1032 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1033 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1034 and ad-hoc kludge. This kludge is now removed, and on encountering
1035 such an image (OB field brain damaged) we set errno. Then in
1036 ::FindDocLength() we "fix" the length as being ALL what remains
1037 in the file (until EOF). We then proceed, hoping for the best...
1038 This fixes a SegFault in ShowDicom when trying to write such an
1040 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1041 (because TestWriteRead breaks on it, after a non conformal commit?).
1042 ctest now runs properly, except for MakeDicomDir (which was allways
1043 broken) and the Python related stuff (still not fixed).
1045 2004-06-24 Jean-Pierre Roux
1046 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1047 FIX : Test/TestReadWrite now iterates on all the file names
1048 (instead of infinite loop)
1049 ENH : Test/TestWriteRead now iterates on all the file names
1051 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1052 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1054 2004-06-24 Jean-Pierre Roux
1055 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1056 when SamplesPerPixel =3
1057 - now Write is no longer confused by
1058 'BitsAllocated = 12" and 'BitsStored=12"
1059 - "UN" value representation Elements are now written correctly
1060 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1061 ENH : - now gdcmHeader has its own Write methods
1062 (in order to split the job that has not to be done
1065 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1066 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1067 loop on the same image until memory went out.
1068 Note: this means we still have gobs of memory loss in PrintDocument
1069 * src/gdcmDocument.cxx: fixes problem on parsing on file
1070 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1072 2004-06-24 Jean-Pierre Roux
1073 FIX : Write - All the Sequences and Sequence Item are now written
1074 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1075 is added a the end, when necessary.
1076 - A lot of brain-damaged images, that were read correctly are
1077 now written correctly
1078 - length compatible BinEntry are now loaded correctly
1079 (even for odd groups)
1080 Note : only Explicit Value Representation was checked.
1081 (question : is implicit VR really necessary for gdcm ?)
1083 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * DEVELOPPER: added a proposition of coding style.
1085 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1088 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1090 Use the gdcmDocEntry::Print() and Write() instead.
1091 * src/gdcmDocument.cxx: bug fix.
1093 2004-06-22 Jean-Pierre Roux
1094 FIX : gdcmDocument.cxx
1095 - Now we do recognize the JpegLossLess format (there was a misstyping in
1096 code 'beautyfication' :-(
1097 - Now we automaticaticaly load the Luts, if any
1099 2004-06-22 Jean-Pierre Roux
1100 In order : to write Sequences, whatever their imbrication level,
1101 : to allow user to create his own Sequences
1102 a lot of modif where necessary (adding, moving, or virtualising methods)
1104 WARNING : save your own sources *before* cvs up !
1107 ADD virtual void Write(FILE *fp, FileType filetype);
1110 ADD virtual void Write(FILE *fp, FileType filetype);
1111 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1114 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1115 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1116 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1117 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1118 ADD std::string GetEntryByName(TagName name);
1119 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1121 std::string vr = "unkn",
1122 std::string fourth = "unkn",
1123 std::string name = "unkn");
1124 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1125 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1126 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1127 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1128 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1129 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1130 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1131 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1134 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1135 ADD virtual std::string GetEntryByName (TagName tagName);
1136 ADD virtual std::string GetEntryVRByName (TagName tagName);
1137 REM virtual bool Write(FILE *, FileType);
1138 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1139 FILE *_fp, FileType type);
1140 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1141 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1142 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1143 REM virtual std::string GetEntryByName (std::string tagName);
1144 REM virtual std::string GetEntryVRByName (std::string tagName);
1145 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1146 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1147 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1149 std::string vr = "unkn",
1150 std::string fourth = "unkn",
1151 std::string name = "unkn");
1152 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1153 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1154 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1155 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1158 ADD virtual void Write(FILE *fp, FileType filetype);
1161 ADD virtual void Write(FILE *fp,FileType filetype);
1164 ADD virtual void Write(FILE *fp, FileType filetype);
1165 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1166 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1167 REM std::string GetEntryByName(TagName name);
1170 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1172 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1173 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1174 The default constructor invoked by the line
1175 gdcmHeader *f1 = new gdcmHeader( header );
1176 was gdcmHeader::gdcmHeader(bool) instead of the expected
1177 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1178 Hence the parsing wasn't executed... See also below.
1179 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1180 as explicit constructor didn't do the trick to fix the above problem.
1181 Could anyone explain why ?
1182 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1183 properly calls gdcmValEntry::Print() (that was weed out from
1184 code related to gdcmBinEntry).
1186 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1187 * In order to fix memory leaks:
1188 - Test/TestWriteSimple.cxx: added cleaning of free store through
1190 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1191 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1192 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1193 (through the call to ::AddDicomDirMeta()) or the destructor
1194 would crash when deleting uninitialized ::metaElems].
1195 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1196 - src/gdcmDocument.cxx:
1197 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1198 from dynamic stores.
1199 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1200 was causing memory leaks.
1201 - src/gdcmSQItem.cxx:
1202 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1203 cleanly handled with polymophism: sorry but my milage is low).
1204 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1205 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1206 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1207 This avoids SegFaulting.
1208 - src/gdcmSQItem.h: coding style.
1210 - Test/TestWriteSimple still severely sucks. The output image content
1211 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1212 damaged when displayed with vtkgdcmViewer.
1213 - on memory leaks: TestWriteSimple leaks really less (see entry
1214 of 2004-06-18 in Changelog file for the call to valgrind).
1215 - on segfaults: ctest now passes all the tests but one (no more
1217 * Erroneous leading white fix:
1218 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1219 white[s] (as opposed to from >> xxx, that removes it [them].
1220 - src/gdcmTS.cxx: ditto.
1221 - gdcmPython/testSuite.py: dirty related kludge removed.
1222 * src/*: remaining references to gdcmParser removed.
1223 * src/*[cxx|h]: added copy[way]left header.
1226 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1227 * In order to fix writing of dicom files:
1228 - Test/TestWriteSimple.cxx: a simpler example of writing.
1229 - Test/CMakeLists.txt changed accordingly.
1230 - src/gdcmDocument.cxx:
1231 -- The destructor now recursilvely removes potential sequences.
1232 -- Bug fix in ::IsJPEG2000()
1233 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1234 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1236 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1237 to only declared) and build on top of
1238 ::GetDocEntryByNumber(guint16, guint16).
1239 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1240 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1241 for usage in destructor and treatement of promotion in
1242 ::ReplaceOrCreateByNumber().
1243 - src/gdcmSQItem.cxx: destructor should better handle his job.
1244 Test/TestWriteSimple now runs (or at least it DOES something).
1245 * We can now start hutting memory links. A good starting point is:
1246 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1247 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1248 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1250 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1251 * Valgrind note: after Mathieu Malaterre teached me how to read
1252 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1254 Using gcc, you can force the STL to use malloc and to free memory as
1255 soon as possible by globally disabling memory caching.
1256 With 3.2.2 and later, you should export the environment variable
1257 GLIBCPP_FORCE_NEW before running your program.
1258 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1259 simply vanish (it is still not clear to me, whether this means that
1260 STL std::string leaks or if valgrind believes it leaks...).
1261 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1262 running bin/gdcmTests makeDicomDir):
1263 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1264 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1266 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1267 SegFaulting (I drowned in DicomDir related code when trying to
1268 understand why the list is empty...).
1269 * src/gdcmDocument.h: first BSD license header try.
1270 * Doc/License.txt added.
1272 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1273 * src/gdcmDocument.[h|cxx]:
1274 - Clean up of the Transfer related predicates. They are now all based
1275 on new method isGivenTransferSyntax, that (should) handle properly
1276 the padding problem.
1277 - general clean up, simplification, and coding style.
1278 - Specific clean up of Parse7FE0() (umproperly named actually).
1279 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1281 2004-06-14 Jean-Pierre Roux
1283 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1284 - fix the display of SQItem ordinal number
1285 - add the GetSQItemByOrdinalNumber method
1286 - remove some useless never written private methods
1288 2004-06-14 Jean-Pierre Roux
1290 - adding a constructor taking a gdcmDocEntry as an input param
1291 - ReplaceOrCreateByNumber now returns :
1292 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1293 a gdcmValEntry * if a string value is passed as a param
1295 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1296 according to the param type (no longer sets a gdcmDocEntry)
1297 - GetValEntryByNumber, GetBinEntryByNumber added
1298 - NewValEntryByNumber and NewBinEntryByNumber added
1300 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1302 - GetSQItemNumber and SetSQItemNumber added, to provide
1303 a (relative) Item identier inside a given Sequence
1304 \warning : some pb remaining around this number
1306 - AddEntry now takes the Item Number as a param
1308 - adding a constructor taking a gdcmDocEntry as an input param
1310 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * Memory leak hunt with the following command:
1312 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1313 --show-reachable=yes gdcmTests PrintDocument
1314 It looks like many (all?) leaks are due to the STL (or a bad usage
1315 of the STL. The lines producing the leaks now have a comment with
1316 a "MEMORY LEAK" tag: you can retrieve them with
1317 grep "MEMORY LEAK" src/*
1318 Here are two typical examples which I can't help fixing:
1323 char * test = "babo";
1324 name = test; //// <--- valgrind detects 960 bytes lost in
1325 //// call to std::string::operator=(char const*)
1326 name.clear(); //// Doesn't help !
1334 std::cout << "Type a bunch of characters followed by RETURN: ";
1335 getline(std::cin, line); //// <--- valgrind dectects a loss
1336 //// of 1320 bytes in call to
1337 /// std::basic_istream<>& std::getline<>
1343 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * src/gdcmHeader.[cxx|h]:
1345 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1346 and related, moved away to gdcmDocument.
1347 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1348 the corresponding protected accessors of inherited class
1349 gdcmDocument, removed ! As a consequence gdcmFile had to be
1350 declared friend of class gdcmDocument (see below).
1351 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1352 - Clean up of undefined or unused methods.
1353 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1354 account the changes to gdcmHeader.h).
1355 * src/gdcmDocument.h:
1356 - gdcmFile is now a friend class (in order to take into account the
1357 changes to gdcmHeader.h).
1358 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1359 (see changes to gdcmHeader.h).
1360 - Accessors (reading on the form GetEntry*) are now public.
1361 - Clean up of undefined or unused methods.
1362 * src/gdcmDocument.cxx:
1363 - adaptation to changes to gdcmDocument.h
1364 - ::OpenFile now writes a verbose message when file cannot be opened.
1365 - some std::string properly set to VRKey
1366 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1367 references to gdcmDocument.
1368 * Test/TestFindTags.cxx: changed accordingly to above changes.
1369 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1370 cvs repository gdcmData.
1372 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1373 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1374 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1375 conflicts with gdcmValEntry::voidArea.
1376 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1377 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1378 Value representation between StringRepresentable and BinaryRepresentable.
1379 * src/gdcmDocument.cxx:
1380 - method ParseDES: proper indentation restored and usage of
1381 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1382 - method LoadDocEntry: the fingerprint left in the SetValue() of
1383 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1384 removed. Reverting to previous code segment with the proper
1385 dynamic_cast< gdcmValEntry* >.
1386 Note: this was (partially) breaking the python test suite
1387 (gdcmPython/testSuite.py) that made usage of the above
1388 fingerprint to check presence of "Pixel Data".
1389 * src/gdcmDocEntry.h: coding style.
1390 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1391 now taken into account.
1392 * gdcmPython/gdcm.i: adaptation to the new internal representation
1393 of gdcm (exit gdcmParser, hello gdcmDocument).
1394 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1396 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1397 anymore, but instead prints the loaded Python dictionary.
1398 * .... alas, the python testSuite is still broken.
1400 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1401 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1403 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1404 * src/gdcmUtil.h : export methods
1406 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1407 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1409 * Initial addition of automatic python testing
1410 * Initial addition of automatic image comparison
1412 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1413 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1414 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1416 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1417 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1418 * Test/ShowDicom.cxx : bug fix for msvc compilation
1419 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1421 2004-05-04 Jean-Pierre Roux
1422 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1423 new concepts (and new classes) :
1424 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1425 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1426 - Sequence Doc Entries (gdcmSeqEntries)
1427 a Sequence is composed of Items.
1428 Each item is a set of Doc Entries (this is recursive)
1429 The non uniqueness of the 'Dicom tag' is due to this recursivity
1430 (never taken into account)
1431 Our unability to add a new 'entry' in the header
1432 at the proper location (neither in the H-Table (map or multimap),
1433 nor in the Chained List is also due to this recursivity.
1434 Don't try, right now, to use/modify/compile these new sources :
1435 nothing is finished.
1436 We just commit all the stuff, 'as is', in order not to loose it.
1438 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1439 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1441 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1442 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1443 file prefix (SetFilePrefix)
1445 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1446 * Add a new test: ShowDicom, for now this is just the c++ version of
1447 checkRead.sh, later it will be able to compare the image read against a
1449 * Replace the DEBUG on the stack with a global entry in cmake interface:
1450 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1452 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1453 * Add an example subdir, with a real example on how to read + write a
1456 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1458 * Doc/CMakeLists.txt: the main page is now properly differentiated
1459 between the developper and user version.
1460 * Doc/doxygen.config.in: dropped search related obsolete flags
1461 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1463 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1464 * DEVELOPPER: added some helpfull comments for compile/test/install
1467 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1468 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1469 src directory, now generated in the build dir.
1470 2. Tests as mentionned smarter
1472 4. Add a new method in gdcmDict that return the PubDict by name
1473 this is interesting for 3rd party lib like ITK,
1474 where we could set the institution name / patient name...
1476 * ENH: 1. Now the test suite is working for real
1477 2. All binaries are now output in the gdcm-bin directory
1478 (this was not true before)
1480 2004-04-28 Jean-Pierre Roux
1481 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1482 SeQuence indented printing of Dicom Header.
1483 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1484 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1485 Computation of SQDepthLevel is now part of gdcmHeader constructor
1486 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1487 tree-like structure of a Dicom Header.
1488 * FIX Test code cleaning
1490 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1491 * ENH: Adding automatic testing
1492 1. Need a DartConfig.cmake to submit to public
1493 2. Add a test driver gdcmTest.cxx
1494 3. gdcmTestMain, an helper for the main test driver gdcmTest
1495 4. Files in Test don't have a main anymore, this becomes interesting
1496 when we add more and more tests, thus dsw don't have to load
1498 * ENH: Adding a GDCM_DATA_ROOT for testing
1499 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1500 one file instead of seven + some small cleanup
1502 2004-04-22 Jean-Pierre Roux
1503 * ENH Minor changes to the Print() methods.
1504 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1505 Header printing. Example given with :
1506 > PrintHeader fileName 2 new
1507 (SQ based tree-like structure still to be done for the Header ...)
1509 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1510 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1511 1. I have added some unsigned where needed
1512 2. Some function parameter not used -> (void)
1513 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1514 4. g++ don't like character '\' in comment
1515 5. #define jpeg_create_decompress jCreaDecompress
1516 this really need to be fixed
1517 6. virtualize destructor of gdcmObject ... leakage
1518 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1519 this also really need to be fixed
1520 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1521 remove compression file
1522 (as we only do decompression, right ?)
1523 * ENH: Change malloc/calloc/free with c++ equivalent
1525 2004-04-21 Jean-Pierre Roux
1526 * FIX gdcmHeaderHelper::GetXSpacing
1527 when a single value is found (bug ?), xpacing is now
1528 defaulted to yspacing
1530 2004-04-19 Jean-Pierre Roux
1531 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1532 * ENH add parameters :
1533 bool exception_on_error = false,
1534 bool enable_sequences = false,
1535 bool ignore_shadow = false
1536 to the gdcmFile constructors to be full gdcmParser compliant
1537 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1538 to allow reading of PAPYRUS 3.0 files
1540 2004-04-06 Jean-Pierre Roux
1541 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1543 2004-04-02 Jean-Pierre Roux
1544 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1545 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1546 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1548 2004-03-30 Jean-Pierre Roux
1549 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1550 for ACR file, written out as DICOM files (hope so...)
1552 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1553 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1554 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1555 moved to base class gdcmParser and only the specialisation is kept
1557 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1558 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1559 already does the job.
1560 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1561 (to be consistent with gdcmParser::WriteEntries).
1563 2004-03-30 Benoit Regrain
1564 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1565 upate of the object's instance. It's passed to 2 in the unfavorable
1566 case : one in the ExecuteInformation, one in the ExecuteData
1568 2004-03-29 Jean-Pierre Roux
1569 * ENH : Check on file type to be written moved
1570 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1571 * FIX : gdcmObject::ResetBoundaries now stops properly
1572 when end-of-list is reached
1573 : gdcmVersion modified (as Benoit Regrain asked)
1575 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1576 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1577 * src/gdcmUtil.cxx: added forgotten iostream include.
1578 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1579 equivalent to ExplicitVR in existing code).
1581 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1582 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1583 now contains all the gdcmGlobal related code.
1584 * minor coding style and doxygenation changes.
1586 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1587 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1588 now contains all the Debug related code.
1589 * minor clean-up of includes in src/*.cxx
1590 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1591 CreateCleanString) removed.
1592 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1593 * Doc/DoxyMainPageUser.txt added.
1594 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1595 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1596 src/gdcmDirList.cxx)
1598 2004-03-24 Jean-Pierre Roux
1599 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1601 2004-03-23 Jean-Pierre Roux
1602 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1603 big endian made volumes
1604 * ENH Now gdcmParser constructor and destructor are protected to forbid
1605 end user to instanciate class gdcmParser
1606 (only gdcmHeader and gdcmDicomDir are meaningfull)
1608 2004-03-22 Benoit Regrain
1609 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1610 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1611 gdcmSerie to gdcmDicomDirSerie
1613 2004-03-19 Jean-Pierre Roux
1614 * ENH Now the tree-like structure describing a DICOMDIR comming from
1615 an already existing DICOMDIR file is consistent with
1616 the home-made tree-like structure build ex-nihilo
1617 or build from the files held (recursively) in a Directory
1618 functions gdcmDicomDir::CheckBoundaries()
1619 gdcmObject::SetBoundaries() added
1621 2004-03-17 Jean-Pierre Roux
1622 * REM (Eric Boix bug) : removal of meaningless
1623 gdcmDicomDirImage::NewImage function.
1624 * FIX now file names and directory name are written properly in the
1626 * FIX now gdcmDicomDir constructor may be call without any trick
1629 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1630 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1631 of gdcmDicomDirImage::NewImage as empty function.
1633 2004-02-28 Jean-Pierre Roux
1634 * ENH add gdcmDicomDir:NewPatient
1635 add gdcmDicomDirPatient:NewStudy
1636 add gdcmDicomDirStudy:NewSerie
1637 add gdcmDicomDirSerie:NewImage
1638 to allow making gdcDicomDir object.
1639 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1640 (as opposite to the gdcmHeader chained list)
1642 2004-02-11 Benoit Regrain
1643 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1644 when using from python
1646 2004-02-10 Benoit Regrain
1647 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1648 * FIX : in gdcmDicomDir when the directory is empty
1649 * ENH : add callback and methods to get the progression of dicomDir
1652 2004-02-06 Jean-Pierre Roux
1653 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1654 - GDCM_META added to gdcmDicomDirType
1655 - class gdcmMeta created
1656 * ENH : - A brief summary is now displayed at the beginning of
1657 'testDicomDir' to help disaster magnitude estimation
1658 * REM : Now useless Test/explDICOMDIR.cxx
1660 2004-02-05 Benoit Regrain
1661 * ENH : add methods in gdcmObject to get the hash table or the list of
1663 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1664 * FIX : wrapping python for TagHeaderEntryHT
1666 2004-02-04 Benoit Regrain
1667 * FIX : even length for some strings when writting the dicom dir
1668 * FIX : sort the images in the dicom dir
1669 * FIX : Bug fix for python use of dicom dir
1670 * ADD : a python demo
1672 2004-02-04 Jean-Pierre Roux
1673 * FIX : Final solution (?) for icone embedded images
1674 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1675 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1676 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1677 gdcmData/gdcm-MR-SIEMENS-16.acr1
1678 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1679 to make full checking easier
1681 2004-02-04 Benoit Regrain
1682 * FIX : WriteEntries : coding style & logic in parameters
1683 * FIX : Set the elements to create the DicomDir in a dictionary file
1685 2004-02-03 Benoit Regrain
1686 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1687 * gdcmDicomDir : add the load of directory
1688 * Bug fix and print add-on
1690 2004-02-03 Jean-Pierre Roux
1691 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1692 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1693 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1694 * FIX gdcmParser.cxx : 'group length' elements are now considered
1695 as integers, even for shadow groups, when file is Implicit VR
1697 2004-02-02 Jean-Pierre Roux
1698 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1700 of the last synonym :-(
1701 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1703 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1704 * FIX taking into account the possible 7fe0,0010 multiplicity
1705 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1706 to allow removal of references to 7fe0,0010, to deal with
1707 ACR-NEMA images, when 0028,0200 is meaningfull
1709 2004-01-31 Jean-Pierre Roux
1710 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1711 no longer writes 'Un' on disk
1712 * FIX SQ elements with actual length are now dealt with corectly
1713 * FIX gdcmFile::WriteBase make the difference, for color images, between
1714 the length (for Palette expanded images)
1715 and Raw Length (non expanded image + Palette)
1716 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1717 (that broke Write). Replaced by UL.
1718 Aware user will reload the field if he
1719 thinks it's necesssary
1721 2004-01-30 Jean-Pierre Roux
1722 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1723 when 'dirty Acr' is found, to be compliant with the new
1724 IsReadable() methods.
1726 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1727 (no DOUBLE images in kosher DICOM,
1728 but so usefull for people that miss them ;-)
1730 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1731 DICOMDIR related utilities (not checked as Windoze compliant)
1733 2004-01-28 Jean-Pierre Roux
1734 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1736 2004-01-27 Jean-Pierre Roux
1737 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1738 to allow skipping the shadow elements, to save memory space.
1739 The TRUE value for this param has to be used
1740 with a FALSE value for the 'enable_sequence' param.
1741 ('public elements' may be embedded in 'shadow Sequences')
1742 * gdcmHeader methods now deal with 'embedded icones images' in the header
1743 (even when an 'icone image sequence' is announced by the
1744 element (0x0088,0x0200), but there is NO icone at all ...
1746 * gdcmHeader sometimes Image Location value doesn't follow
1747 the supposed processor endianity (see gdcmData/cr172241.dcm).
1750 * gdcmHeader add the method
1751 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1752 to get *all* the Header Entries with the same tag.
1753 GetHeaderEntrySameName is probabely *useless*
1754 (no meaning : Name is *not* an identifier within the Dictionnary)
1756 2004-01-26 Benoit Regrain
1757 * Bug fix in the print of hexadecimal representations. Remove long fields
1758 in the print and add a third level of print to print them
1760 2004-01-23 Benoit Regrain
1761 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1762 * Bug fix on test suite after remove the strip made on not string fields
1763 * Split the IsReadable method between gdcmParser which test that the file
1764 is dicom and gdcmHeader which test that it's an image file
1766 2004-01-22 Benoit Regrain
1767 * DicomDir : clean code, add methods, set variables in protected or private
1768 * gdcmUtil : bug fix for the clean string method
1770 2004-01-19 Benoit Regrain
1771 * Add the use of shadow dictionaries
1772 * bug fix and coding style
1774 2004-01-19 Benoit Regrain
1775 * src/gdcmFile.cxx : bug fix concerning the close of file
1776 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1777 * Add the update of header entries using the shadow library
1779 2004-01-19 Benoit Regrain
1780 * removal of file gdcmHeader2.cxx
1781 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1782 inheriting from gdcmParser. This split is to prepare the integration
1783 of dicom dir parsing
1784 * bug fix under python
1786 2004-01-16 Jean-Pierre Roux
1787 * REM removal of class gdcmHeaderEntrySet
1788 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1789 * ADD add file gdcmHeader2.cxx
1790 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1792 2004-01-15 Benoit Regrain
1793 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1794 entries created while parsing the header. Thus, they will be destroyed
1795 when the gdcmDictSet will be destroyed
1796 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1799 2004-01-15 Benoit Regrain
1800 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1801 made a fatal error because of the memory release at the end of program.
1802 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1803 some memory and vtk seems to have some problems with that.
1804 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1806 2004-01-14 Benoit Regrain
1807 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1808 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1809 * src/*.[h|cxx] : make changes due to class name changes
1810 * gdcmPython/demo/*.py : bug fix due to method names
1812 2004-01-13 Benoit Regrain
1813 * src/*.[h|cxx] : coding style
1814 * vtk/*.[h|cxx] : coding style
1816 2004-01-13 Benoit Regrain
1817 * gdcmPython/testSuite.py : test the readable flag of file for tests
1818 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1819 It's lied to the stl compilation by MSVC (windows, always windows...)
1820 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1822 2004-01-12 Benoit Regrain
1823 * src/*.h : add comments
1824 * src/gdcmDictSet.h : set the method BuildDictPath in public
1825 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1826 directly setted in the source code
1827 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1830 2004-01-09 Benoit Regrain
1831 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1832 * setup.py : use a reference to gdcmVERSION
1834 2004-01-07 Benoit Regrain
1835 * Modification to compile with the distutils.
1838 2003-12-10 Benoit Regrain
1839 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1840 can use a gdcmHeaderHelper to load data
1841 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1842 made in the source code
1844 2003-12-10 Benoit Regrain
1845 * Update Windows projects and .cvsignore files
1847 2003-11-12 Jean-Pierre Roux
1848 * ENH gdcmHeader constructor has one more parameter (default value : false)
1849 that allows the user to 'go inside' the SeQuences only
1851 gdcmElValSet:Print takes it into account
1853 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1854 * ENH: Update gdcmPython/CMakeLists
1855 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1856 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1858 2003-11-10 Jean-Pierre Roux
1859 * FIX : gdcmHeader::LoadElements is now based
1860 on the ListTag listElem member,
1861 not longer on the TagElValueHT tagHt member
1862 * ENH : PrintPubElVal shows (temporarily) both results,
1863 with the tagHt member and the listElem member.
1864 (it's easier to 'see' the problems when using Printheader)
1866 * FIX : old private member LgrElem is now splitted into
1867 ReadLength : Length actually found on disk (updated only
1868 if bug fixing is necessary), for internal
1870 UsableLength : Updated by FixFoundLength, to fix a bug
1871 or to allow Parser going on.
1872 Will allow to re-write a kosher header when a SeQuence
1873 with a length (not 0000) is found
1874 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1875 because gdcmElValSet::Add does not update ListElem
1878 2003-11-07 Jean-Pierre Roux
1879 * FIX misstyping in Transfert Syntax name table
1880 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1881 when they have an actual length (not 0000 nor FFFFF)
1882 (Nobody should care of it, but DICOMDIR explorers)
1884 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1885 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1887 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * ENH: vtkGdcmReader now supports LUT !
1889 (vtkgdcmViewer for now is not able to use them though)
1891 2003-11-05 Jean-Pierre Roux
1892 * in testSuite.py : new files names for checking the package
1893 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1894 that returns the pixel area size to the *aware* (vtk) user
1895 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1897 2003-11-05 Benoit Regrain
1898 * in testSuite.py : Modify the rules for checking the paths
1899 : Explicit error messages
1900 * in __init__.py : Related modif
1902 2003-11-03 Jean-Pierre Roux
1903 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1904 to be used by aware (vtk) users that want to manage
1905 LUT (and no to turn the PALETTE image into an RGB pixels one)
1906 * GetPixelType now returns 8U for 24 Bits images
1907 (vtkGdcmReader compliant)
1909 2003-10-31 Jean-Pierre Roux
1910 * Removal of *all* gdcmData images and add them again
1911 in order to loose the 'history' of un-anonymised images
1913 2003-10-31 Jean-Pierre Roux
1914 * RMV : removal of useless jBitsInJsample.h
1915 for both 8 and 12 Bits JPEG Lossy Libraries
1917 2003-10-31 Jean-Pierre Roux
1918 * ENH : Add the functions gdcmFile::GetImageDataRaw
1919 gdcmFile::GetImageDataIntoVectorRaw
1920 that act as GetImageData and GetImageDataIntoVector
1921 except the making of an RGB Plane from Gray Plane + LUT
1922 Intended to aware (vtk) users who know how to manage
1925 GetLUTRGBA return a R,G,B,A LUT if any
1926 lgrTotaleRaw gives the 'Raw' length
1927 GetImageDataRaw returns the gray Plane
1928 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1929 (They stay Grey, just like with other Dicom viewers :-(
1931 2003-10-30 Jean-Pierre Roux
1932 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1934 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1935 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1936 being coherents dicom files.
1938 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1941 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1942 * ENH: Two steps is necessary to please VC++ compiler...
1943 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1944 * ENH: Add include dir to medcon lib
1945 * FIX: only one function is being exported for now !
1946 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1948 2003-10-29 Jean-Pierre Roux
1949 * adding gdcmHeader::GetLUTRGBA
1950 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1951 --> Mathieu, the modif u're waiting for is not yet committed
1952 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1954 2003-10-27 Jean-Pierre Roux
1955 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1956 00191113.dcm DermaColorLossLess.dcm
1957 MxTwinLossLess.dcm RadBWLossLess.dcm
1958 * ENH: For version prior to vtkImageViewer2 -r 1.19
1959 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1961 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1962 * Removal of ido stuff in CMakeLists.txt
1964 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1965 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1966 * FIX: remove a call to ->Modified ... see comments
1967 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1969 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1970 * FIX: Problem with path for libvtkgdcmPython
1971 * ENH: Try adding a search script for python site-package
1972 * RMV: Remove some file from medcon lib that are not necessary
1973 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1974 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1975 * FIX: More pragma disable fro VC++,
1976 I don't think I break something as it is also disable in VTK/ITK.
1977 But it fasten debug compilation time.
1979 2003-10-23 Jean-Pierre Roux
1980 * gdcm now deals with 16 Bits Run Length Encoded images
1981 (they are compressed as 2 planes images,
1982 one for the high Bytes, the other for low Bytes)
1984 2003-10-22 Jean-Pierre Roux
1985 * Now CheckRead takes into account :
1986 - the bugged 'Leonardo' Siemens images
1987 - the XA images, sent thru the burning VPRO station
1988 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1991 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1992 * FIX: When copying a Makefile.am to CMakeLists.txt
1993 one should remove the '\'
1995 2003-10-22 Jean-Pierre Roux
1996 * in gdcmData adding a bugged 'Leonardo' Siemens image
1997 (wrong lengths in header)
1998 OK with gdcm, KO with the other viewers :-)
1999 * add a GE dlx XA image, thru the VEPRO burning station
2002 2003-10-21 Jean-Pierre Roux
2003 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2004 for a brutal checking of vtkgdcmViewer compliance
2006 2003-10-21 Jean-Pierre Roux
2007 * add the files for 'xmedcon' Jpeg Lossless library
2008 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2010 2003-10-21 Jean-Pierre Roux
2011 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2013 2003-10-21 Jean-Pierre Roux
2014 * garbage Siemens 'Leonardo' images dealt with
2015 (the patch is easy to remove)
2016 * cosmetic changes to avoid warnings
2018 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2019 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2020 no need to press 'r' now.
2022 2003-10-20 Jean-Pierre Roux
2023 * upgrade of checkRead.sh checkWrite.sh according
2024 to new Jpeg Lossless decompressor
2025 * add US.3405.1.dcm, a genuine RGB medical file ...
2026 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2027 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2029 2003-10-15 Jean-Pierre Roux
2030 * general anonymisation in gdcmData
2031 * adding the 'color files' from
2032 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2033 * adding some well knowed bugged-header images
2034 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2035 waiting for their inclusion in Python testsuite
2037 2003-10-15 Jean-Pierre Roux
2038 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2039 no longer seg faults when file is not found
2041 2003-10-14 Jean-Pierre Roux
2042 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2045 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2046 * TODO: *.in file to genereate a UseGDCM later
2048 2003-10-14 Jean-Pierre Roux
2049 * Some supposed-to-be Dicom Images have no preamble.
2050 OpenFile takes it into account
2051 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2052 * Missing elements added in dicomV3.dic
2053 (just to be affraid : have a look at
2054 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2055 and do it again next year ;->
2057 2003-10-13 Jean-Pierre Roux
2058 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2059 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2060 But there are NOT. It's fixed !
2062 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2063 * FIX: "jpeglib.h" was not found on VC++
2064 * FIX: vtkgdcm was not being installed
2066 2003-10-10 Jean-Pierre Roux
2067 * ENH : OpenFile closes the file if it *really* doesn't look like
2068 an ACR-NEMA / DICOM one.
2069 * FIX : testWrite no longer writes an empty file if the source file
2070 is not gdcm Readable
2071 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2074 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2075 * FIX: CMake generate now documentation
2076 * ENH: out of source doc build !
2077 * ENH: Generate both user and dev documentation
2078 * ENH: Should work on windows too
2079 * ENH: Only one doxygen config.in file is needed
2080 * FIX: make install should be ok now on ùnix plateform
2081 * FIX: PATH to dictionary was wrong (missing /)
2082 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2084 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2085 * vtkGdcmReader is now able to read rgb dicom file.
2086 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2087 * added a gdcmViewer to vtk test, use mouse to control
2088 window level & window width
2090 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2091 * CMake-ification of gdcm, we have now two build system
2092 * FIX: on cygwin Wsock32 doesn't exist
2093 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2095 2003-10-06 Emanuel Ollart
2096 * FIX : compilation process wad broken.
2097 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2099 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2100 * change gdcmViewer -> vtkgdcmViewer
2101 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2103 2003-10-06 Jean-Pierre Roux
2104 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2105 ( e.g : well known GE images with a wrong elem length,
2106 : Philips MRI Images with a wrong Huffman table)
2107 * still to be done : allow the reading of bugged LEONARDO Siemens images
2109 2003-10-03 Jean-Pierre Roux
2110 * Odd length strings are padded with '\0' (not with spaces,
2111 to remain compliant with already defined strings,
2112 like Transfert Syntax UID and others)
2114 2003-10-03 Jean-Pierre Roux
2115 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2116 to allow displaying RGB images (not only by affim ;-)
2118 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2119 * vtkGdcmReader is now able to read rgb dicom file.
2120 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2122 2003-10-03 Jean-Pierre Roux
2123 * A few nasty patches to allow the reading of a lot of nasty images
2124 ( e.g : well known GE images with a wrong elem length,
2125 : Philips MRI Images with a wrong Huffman table)
2126 * still to be done : allow the reading of bugged LEONARDO Siemens images
2128 2003-10-03 Jean-Pierre Roux
2129 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2131 2003-10-03 Jean-Pierre Roux
2132 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2133 to allow displaying RGB images (not only by affim ;-)
2135 2003-10-03 Jean-Pierre Roux
2136 * gdcmFile::GetImageDataIntoVector now
2137 - deals with MultiFrames MultiFragments Run Length Encoded files
2138 - deals with YcBcR (YBR_FULL) files
2139 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2140 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2142 (no sample found :-(
2144 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2145 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2146 Two reasons: - clear things
2147 - third parties acces gdcm through header files, so won't
2148 suffer anymore VC++ complains
2150 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2151 * add argv[1] in testvtkGdcmReader.cxx
2154 2003-09-24 Jean-Pierre Roux
2155 * The lines are now eigthy characters long.for
2156 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2158 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2159 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2160 char* to std::string. Thus, the use of strdup becomes useless. (see
2161 previous commis of Malaterre)
2162 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2163 before the last Malaterre's commit.
2165 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2166 * This commit should fix the Debug building under VC++, the problem
2167 was mainly a mixture of debug and release lib being loaded at startup.
2168 * I also remove a depency to a specific C function: strdup. Because I had
2169 to force the link to msvcrtd (whereas strdup is in libc).
2171 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2172 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2173 located in the gdcmCommon.h file. All use of reference of tha has been
2174 changed to now use the variable GDCM_UNFOUND.
2176 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2178 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2179 Dicom dictionary. The test suite can now be run again. Note:
2180 I'm note very happy with the " (RET)" changes. I believe this
2181 RETAINED comment should be dropped when parsing the dictionary.
2182 - PACKAGER corrected
2184 - AUTHORS updated and now in alphabetical order
2185 * Makefile.am now exports gdcm.dsw for Windoze users.
2187 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2188 * cygwin complains about missing std:: in subdir Test/
2190 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2191 * remove some methods that are now in gdcmHeaderHelper
2193 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2194 * vtkGdcmReader set spacing and origin correctly
2196 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2197 * Fix a few delete/delete[] mismatch
2199 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2200 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2201 interpretation to data given by gdcmHeader. For instance there are
2202 heuristics to get informations (look at different places).
2203 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2204 sorting DICOM images based on different strategies.
2205 * modified Makefiles accordingly.
2207 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2208 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2209 when building in debug mode
2210 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2211 src/win32/gdcmdll.dsp
2212 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2214 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2215 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2218 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2219 * src/win32/libgdcmjpeg12.dsp was not dos format
2220 * src/win32/libgdcmjpeg12.dsp :
2221 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2222 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2224 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2225 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2227 * src/gdcmFile.cxx : bug fix in affectation type
2228 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2229 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2230 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2231 symbols... future problem ?
2233 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2234 * src/win32/libgdcmijpeg12.dsp was missing
2235 * modified gdcm.dsw accordingly
2237 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2238 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2240 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2241 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2242 commit of JPR (before his hollidays to facilitate our work).
2243 * setup.py : bug fix in code. Modifications made while the last commit
2244 of JPR. The code hasn't been tested before the commit... it's so
2245 useless to make that (for best programmer that is JPR) !!!
2247 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2248 * tagged the current version as Version0_3 (i.e. version 0.3)
2250 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2251 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2252 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2253 * *.dsp : modifications to use new libgdcmijpeg8 library
2254 * setup.py : bug fix on VTKPATH variable
2255 * PACKAGER : adding all concerning windows
2257 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2258 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2260 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2261 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2262 test suite reported error.
2263 * PACKAGER file added (describes what a packager must do when
2264 packaging a new release).
2265 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2266 * configure.in: upgraded version number to 0.3.0
2267 * fixing build of rpm (through rpm -ta):
2268 - Doc/Makefile.am exports proper doxygen files
2269 - src/jpeg/libijg8/Makefile.am exports the include files.
2271 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2272 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2273 * src/gdcmHeader.h : formatting code
2275 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2276 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2277 We were obtaining error message from vtk. Now, creation of file list
2278 is made in an internal list to prevent this problem.
2279 Bug fix when output is empty.
2280 Bug fix in update of progress value. Previous commit for this was a bad
2282 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2284 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2285 * src/gdcmHeader.h : added method to get the file name
2286 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2287 files. Added method to remove all files on the input
2288 Added FIXME comment concerning the bad parsing of header made by
2289 ExecuteInformation method (in ExecuteData method)
2291 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2292 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2293 when using make instal.
2294 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2295 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2297 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2298 * setup.py : adding include dir of jpeg lib to compile all sources
2299 * */Win32/*.dsp : JPR fix for windows compilation
2301 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2302 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2304 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2305 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2307 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2308 * setup.py is again effective on un*x (takes into account the
2309 addon of the jpeg library)
2310 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2311 * Doc/Doxy* updated (includes above enhancements)
2312 * INSTALL now points to web documentation
2314 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2315 * src/gdcmHeader.h doesn't make unnecessary reference to
2317 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2319 * src/gdcm*.[cxx|h] :
2320 - to allow compilation with gcc 3.x
2321 -- clean up of STL usage (added explicit usage of std::)
2322 -- small fixes on exceptions.
2323 Note: linking not tested !
2324 - clean of doxygen comments to avoid warnings at documentation
2326 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2327 dependent convertion).
2329 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2330 * Clean up of previous JPR garbage commit (not even commented in the
2332 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2333 - moved all jpeg related files from src to src/jpeg/libijg8, with
2334 addition/modification of Makefile.am and configure.in.
2335 - the testSuite is still brain damage (not guilty).
2337 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2338 * WrapVTK.py : modifications to get correctly vtk source files to
2340 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2341 (FileName -> Filename)
2343 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * vtk/vtkGdcmReader.[cxx/h]:
2345 - UpdateProgress method should now be effective
2346 - removed the limitation on having only images loaded (as opposed
2348 - when building a stack of images/volume, a lesser number of
2349 gdcmHeader and gdcmFile instances should be used (hopefully
2350 accelerating things).
2351 - when building a stack of images/volumes, files which are not
2352 loadable (wrong path-filename, wrong permissions on existing file,
2353 or file not parsable by gdcm) are replaced with a black image
2354 in the stack (for the caller to notice the problem).
2356 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2359 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2360 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2361 between standard library (std) and vtk library (problems are found
2362 under Windows... thanks Windows !)
2364 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2365 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2367 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2369 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2372 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2373 * When compiling with distutils (see setup.py) the C++ compiler is
2374 called with different flags than the default ones (with automake).
2375 In order to fix all those warning, I compiled gdcm with the command
2376 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2377 and went for warning fixes:
2378 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2379 up from unused variables.
2380 - vtk/vtkGdcmReader.cxx: potential bug fix.
2381 * src/gdcmHeader.h: Doxygen warning cleanup
2383 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2384 * gdcmPython/gdcm.i:
2385 - typemaps correction to take into account the systematic replacement
2386 of "using namespace std" with std:: prefix e.g. std::list,
2387 std::string... (cf changes of 2003-05-21).
2388 - gdcmGlob global variable of type gdcmGlobal (defined in
2389 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2390 exported to Python a as cvar.
2391 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2392 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2393 gdcmDictSet.GetPubDictTagNames() and
2394 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2395 C++ static methods).
2396 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2397 with the above changes.
2399 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2400 * setup.py, manifest.in : bug fix under linux
2402 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2403 * Modification of setup.py to compile vtk part too. Then, we have 2
2404 wrappers which must work with same distutils. For that, we have a
2405 generic distutils in distusiltsWrapping.py ; with :
2406 - build_extWrap class to wrap generically all extensions,
2407 - ExtensionWrap base class for all wrapping extension that contains
2409 - Wrapper interface which wrap sources
2410 + In WrapSwig.py we have extension and wrapper for Swig
2411 + In WrapVTK.py we have extension and wrapper for VTK
2412 * MANIFEST.in : modifications to consider vtk directory and new python
2413 files for compilation
2415 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2416 * Added python wrappers of vtkGdcmReader vtk class (see the
2417 source in vtk/vtkGdcmReader.cxx) :
2418 - vtk/Makefile.am now builds a library
2419 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2420 python library (as opposed to _gdcm.so wich are the python
2421 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2422 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2424 - configure.in has an additional flag --enable-vtk that needs
2425 to be set to enable compilation of vtk related code, that is:
2426 + vtk/vtkGdcmReader.so and
2427 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2428 + gdcmPython/vtkgdcmPython.so (see above)
2429 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2430 be read when compressed or when HighBit + 1 != BitsStored),
2431 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2432 the usage of the python wrapper of vtkGdcmReader vtk class.
2433 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2434 * src/*.[h] all occurences of stl classes are now prefixed with
2435 std::, and all occurences of "using namespace std;" where removed.
2436 This is to avoid pollution of global namespace in included files.
2437 Apparently vtk does not avoid this pitfall: when using both
2438 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2439 collision of various stl members (principally cout...).
2440 * gdcmPython/testSuite.py now cleanly removes temprory generated
2442 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2443 comply with above changes)
2445 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2446 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2447 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2448 vtk data structure (an image Flip was required).
2449 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2450 * cosmetic changes in documentation.
2452 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2453 * src/gdcmHeader.cxx: the constructor no longer exits when an
2454 unexisting file is given as argument.
2455 * The subdirectory Data (containing all the images used for the
2456 test suite) is not part of this repository anymore. A new module
2457 containing those images is now available at
2458 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2459 with the name gdcmData.
2460 All the python scripts (including the package initialisation file
2461 gdcmPython/__init__.py) were adapated to take this change into
2462 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2464 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2465 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2466 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2467 demo of the usage of this class.
2468 Compilation of this vtk part is only done when using the --enable-vtk
2469 at configure (or autogen.sh) stage.
2471 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2472 * More memory link related corrections and documentation fixes.
2474 - maximum info is obtained with a command of the form:
2475 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2476 --show-reachable=yes PrintHeader
2477 - the remaining reachable blocks seem to come from the STL
2478 allocation scheme through the usage of map and list. It looks
2479 like this memory cannot be freed but it is not a memory leak
2480 (in fact further invocation to the STL would recollect the
2481 unused memory allthough it cannot explicitely be freed).
2482 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2483 of displaying an image parsed with gdcm and displayed with VTK.
2484 Note: some images don't seem to work e.g.
2485 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2486 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2487 Allthough this weakens the semantics, it is a ditch attempt to
2488 make gdcm more thread friendly.
2490 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2491 * Memory link hunt (by using valgrind through the command
2492 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2493 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2494 gdcmHeader::_dicom_vr.
2495 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2496 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2498 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2500 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2501 * src/Makefile.am now exports all the necessary include files at
2505 * UpdateGroupLength replaced by new one
2508 * UpdateGroupLength re-written using H-Table
2509 (named UpdateGroupLengthNew untill checks are over)
2511 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2512 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2513 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2515 - gdcmHeader::GetPubElValSet removed.
2516 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2517 UpdateGroupLength, WriteElements, Write.
2518 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2519 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2520 carried the same semantics.
2521 - src/gdcmHeaderIdo.cxx changed accordingly.
2522 - gdcmFile::WriteBase now regroups all the codes from previous
2523 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2524 - enum FileType moved to gdcmCommon.h
2525 * src/gdcmHeader.cxx AddDefault trashed
2526 * gdcmGetXSize added
2527 * getimageDataSize now calls gdcmGetXSize
2528 * Test/*.cxx changed to agree with above changes
2530 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2532 (to avoid double call by end user).
2533 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2534 by end user, since gdcmHeader::gdcmHeader now handles it.
2536 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * gdcm/Doc many doxygen changes:
2538 - Doxyfile now has two different versions, DoxyfileUsers that generates
2539 the html.users end users oriented documentation and
2540 DoxyfileDeveloppers that generates the html.developper developper
2541 oriented documentation.
2542 - README changed accordingly
2543 - requirement.txt removed (old design info moved to TODO).
2544 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2545 DoxyMainPage.txt, DoxyPython.txt provide more information.
2546 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2547 be updated by simply regenerating the docs with doxygen and copying
2548 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2549 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2550 all the tests in the form "if (<map>.count() >1)" were removed.
2551 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2552 ill-formed documentation sections.
2553 * src/gdcmHeader.cxx: ditto
2555 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2556 * setup.py fixed for un*x (needed macro for stdint.h)
2557 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2558 un*ces with sh-utils test utility.
2559 * gdcmPython/demo/test.py renamed to PrintHeader.py
2560 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2561 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2562 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2563 * src/gdcm*.cxx JPR's bad inclusion fixed.
2565 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2567 * gdcmPython/demo/test.py changed accordingly.
2569 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * gdcmPython/Makefile.am fixed linking against libstdc++
2571 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2572 * Swig subdir (historical tests of swig version 1.3.17++) removed
2573 * Test/testChangeEntete.cxx some lines commented out in order to make
2575 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2576 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2578 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2580 hence the user doesn't need this explicit call.
2581 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2582 i.e. LoadElements() call removed.
2583 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2584 - src/Makefile.am declares the proper flag for g++.
2585 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2586 for adding user defined new tags.
2587 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2588 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2589 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2591 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2592 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2593 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2594 src/Makefile.am : the project should properly compile and install
2595 with the autotools, included the python wrappers part.
2596 * gdcm.spec.in : added a spec file for RPM packaging.
2598 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2599 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2601 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2602 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2603 to exported to the environement (see gdcmPython/testSuite.py
2605 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2606 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2607 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2608 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2609 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2611 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2612 * gdcmPython/__init__.py doesn't crash anymore when running in
2613 in InstallMode or PreInstallMode but with an environement given
2614 value of GDCM_DICT_PATH.
2615 * src/gdcmDictSet.[cxx/h] coding style.
2617 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2618 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2619 * src/gdcm.h general comments moved to TODO, and README
2620 * src/gdcm.h should now be seen as a user commodity (including it
2621 should suffice to fully use gdcm). It is nowhere including within
2622 any of the kernel files src/*.cxx and src/*.h.
2624 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2626 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2628 * src/gdcm*.cxx only include their corresponding include file
2629 (as opposed to gdcm.h)
2630 * gdcmPython/gdcm.i changed accordingly
2631 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2632 the autogen.sh generated "make snapshot" command to work.
2633 * autogen.sh removed history related references to crea package.
2635 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2636 * distutilsSwigCPlusPlus.py work around some swig portability
2639 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2640 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2641 was done in a last ditch attempt to get setup.py _really_
2642 operationnal. The python/gdcmPython layaout add the advantage
2643 of hidding away the python related distutils specific files
2644 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2645 Alas, the src directory was out of scope (i.e. it's relative
2646 position to setup.py was ../src) which made things impossible to
2647 handle (see previous version of python/setup.py). Crossing fingers...
2649 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2650 * python/setup.py now works on Un*x. (harder than I thougth)
2651 * python/distutilsSwigCPlusPlus.py can now have include files
2652 among the list of sources.
2654 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2655 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2656 * modifications in MSVC projects
2658 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2659 * As stated by the first lines of Test/ExceptionAndPython/README, it
2660 looks like we can move back to original usage of exception within
2661 src/gdcm* and hence remove the errno stuff that was introduced
2662 as a quick and dirty fixture of this problem (added to the TODO).
2663 * Doc/Doxyfile configuration file for Doxygen and corresponding
2664 README file for usage added.
2665 * Test/testWrite.cxx added. This new test comes from a split of
2666 test.cxx that is now reverted to its original purpous i.e.
2667 testing the proper parsing of a Dicom related file.
2668 testWrite.cxx concentrates on testing the IO part of gdcm.
2669 * Test/bug1.cxx (containing a bug on WIn32) added.
2670 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2671 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2672 whose purpose is to publish the content of the TagNames of the
2673 Dicom public dictionnary were not accessible without an
2674 instance of class gdcmHeader.
2675 - those methods are now static methods of gdcmDictSet and hence
2676 require no instances at all to be invocated.
2677 - within gdcmDictSet this change required to change some method
2678 to class methods (i.e. are now static) among which SetDictPath
2679 (renamed to BuildDictPath) and LoadDefaultPubDict.
2680 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2681 the above changes by calling the new method classes of gdcmDictSet.
2682 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2683 the above to be effective.
2684 * python/gdcmPython: in order to wrap properly the above changes
2685 for Python, swig version now needs to be > 1.3.17.
2686 * python/gdcmPython/Makefile fixed to adapt itself to new
2687 configure/make shema introduced by Johan Montagnat (thanks for the
2688 contribution). Alas this Makefile cannot be turned into a proper
2689 Makefile.am without some heavy changes in the configure.in
2690 (for python dectection).
2691 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2692 now avoids publishing the empty entries.
2694 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2695 * python/setup.py : bug fix concerning install under windows
2696 ExtraPath reused :-P
2697 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2699 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2700 * Dicts/dicomV3.dic : remove double spaces !!!
2701 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2702 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2705 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2707 method. Doxygenation.
2708 * src/gdcm.h clean up of JPR spurious comments.
2710 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2711 * python/distutilsSwigCPlusPlus.py now properly collects the
2712 shadow classes generated by "swig -c++" (gdcm.py in our case)
2713 when using "python setup.py install".
2714 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2715 reexports the working classes.
2716 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2717 by the classical C errno scheme. This is to prevent an obscure
2718 behavior of the python wrappers when importing wxPython.wx prior
2719 to gdcmPython (which ended up in an abort call). An illustration
2720 of this oddity can be found in the Test/ExceptionAndPython
2721 subdir (see the README file). This problem probably due to
2722 an combination of g++ and dynamic loading.
2723 * added Test/ExceptionAndPython (see above)
2725 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * Changed the layout of the python part to avoid bloating main
2727 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2728 i.e. the distutils arsenal. All the python related stuff is
2729 again in a python subdir, but the package itself is now in
2731 * setup.py was cleaned up:
2732 - pythonIncludePath removed
2733 - python setup.py bdist target is now functional.
2734 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2735 collision with other packages). gdcmPython/demo/*.py changed
2738 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * python subdir moved to gdcmPython (preparation of distutils packaging).
2740 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2741 distutils installer is operational.
2742 * - gdcmPython/__init__.py now properly loads the swig generated
2743 shadow classes (from gdcm.py).
2744 - gdcmPython/demo/*.py changed to import the package gdcmPython
2745 instead of gdcmPython/demo/load.py.
2746 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2748 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2750 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2751 entries within the associated public Dicom dictionary resp. the same
2752 information but sorted by the fourth field (PAT, IMG, DIR) of the
2754 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2755 are now in the "???" group.
2756 - python/gdcm.i changed accordingly,
2757 - python/demo/printGroupedPublicDict.py added, that gives an example
2758 of the above new functionalities in Python.
2760 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * src/gdcm.h, gdcmHeader.cxx:
2762 - historic references to glib's g_malloc and g_free (#defined)
2763 were definitively removed.
2764 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2765 * src/gdcmElValSet.cxx:
2766 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2767 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2768 - GetElValue(string) renamed to GetElValueByName.
2769 - Added GetElementByName(string).
2770 * src/gdcmHeader.cxx: added
2771 - GetPubElValRepByNumber(guint16, guint16)
2772 - GetPubElValRepByName(string)
2773 - GetShaElValRepByNumber(guint16, guint16)
2774 - GetShaElValRepByName(string)
2775 - GetShaElValByNumber(guint16, guint16)
2776 - GetShaElValRepByName(string)
2777 - GetElValRepByNumber(guint16, guint16)
2778 - GetElValRepByName(string)
2779 - GetElValByNumber(guint16, guint16)
2780 - GetElValRepByName(string)
2781 * Doc/requirements.txt added.
2783 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * Test/Makefile building now depends on the one of libgdcm.so
2785 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2786 pixel data) aware which enables finding the address (offset) of
2787 the pixel data of JPEG encoded DICOM files. This leaves only a single
2788 file in the testSuite whose pixel data address (offset) is unknown.
2789 * python/testSuite.py changed accordingly.
2791 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2792 * VC++ has some strong limitations when working with the STL, as stated
2793 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2794 "Also note that some STL containers (map, set, queue, list, deque)
2795 cannot be exported. [...]
2796 Some STL classes contain nested classes. These classes can not
2798 This is caused by a designed limitation that once a template
2799 class is instantiated, it can not be re-instantiated and
2801 Since our usage of map<> is ubiquitous in gdcm, this "designed
2802 limitation" of VC++ is a pitfall.
2803 Hence the Python wrappers of gdcm cannot be incrementally linked
2804 against the c++ dynamic library. The dirty but only workaround is
2805 to forget about incremental link of dynamic libraries and to generate
2806 the Python wrappers library with the inclusions of the underlying C++
2808 The following modifications concern this matter on Win32/VC++:
2809 - wrapping python correct with standalone wrapped dll (don't use separate
2810 dll under windows !!!!)
2811 - python21_d debug mode enabled (ask Frog how to use it :-)
2812 - NO problem with having an STL member of class for example string in C++
2813 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2814 - Python test of dcmlib in Python is ok under windows on a large set
2816 * removed glib references
2817 * typedef's inserted in gdcm.i for correct swig type management
2819 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2820 * python/demo/*.py load.py extracted from test.py. Added explore.py
2821 that only displays required tags and testAll.py that parses all
2822 the files of the testsuite without using unittest.
2823 * python/testSuite.py other additional test on new files added.
2824 * Data/* new test files added accordingly to the testSuite.
2825 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2826 the vr in the file differs from the one of the dictionary.
2828 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2829 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2830 values, but limits itself to values which are below a user specified
2831 size (by default 1024 bytes).
2832 * python/gdcm.i : elements not loaded (because their size is above the
2833 user specified treshold) are exported with their TagKey as key of the
2834 python dictionary. This enables the testsuite to make some checks
2835 on the unloaded elements (since we have their offset and size).
2836 * python/testSuite.py
2837 - now tests for the existence and proper value of the pixel data
2838 - two new examples added.
2839 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2841 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2842 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2843 aware. See the strategy comments in gdcmHeader::FindeLength().
2844 * Test/test.cxx now accepts a filename as first argument.
2845 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2846 * python/testSuite.py changed to integrate test on above files.
2848 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2849 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2850 the vr was also RET.
2851 * python/testSuite.py more tests added.
2853 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2854 * python/testSuite.py unittest test suite added (uses Data)
2855 * Data/* dcm and acr files for the test suite.
2856 * glib dependance removed from un*x version. We now use ISO C99
2857 7.18 Integer types (see stdint.h)
2858 - python/Makefile, src/Makefile src/gdcm.h
2859 * src/ when an explicit vr (like dicom files) suddenly poped an
2860 implicit element we use to mark the underlying DictEntry of the
2861 concerned ElValue with "Implicit". This strategy was damageable
2862 too the public or provite dictionaries, since some of their vr
2863 would be changed. Since Header::FindLength heavily relies on the
2864 detection by Header::FindVR of falsely explicit elements, I
2865 added an extra ImplicitVr member to ElValue (boolean).
2866 The rest of the changes we the necessary adaptations.
2868 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2869 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2871 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2873 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2874 * Adaptation for porting to VC++:
2876 o forced to use std namespace (for string to be known)
2877 o all class use __declspec export style on WIN32
2878 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2879 (in stdlib.h on Win32 but in std:: for gcc)
2880 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2881 variable GDCM_DICT_PATH.
2882 * src/gdcmHeader.cxx verbose comments made discrete.
2884 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * python/gdcm.i: added a typemap that converts a C++ hashing table
2886 to native Python dictionary.
2887 * python/demo/test.py:
2888 - now uses the native dictionary for exploration of gdcmHeader.
2889 - takes an optional filename argument (the file to parse).
2890 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2891 PubElVals hashing table.
2892 * Dicts/dicomV3.dic removed error prone trailing spaces.
2894 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2895 * Python wrapping process moved away from src/Makefile to
2896 newly created python/Makefile (as well as gdcm.i)
2897 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2898 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2899 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2900 from the environement variable GDCM_DICT_PATH (when existing).
2901 * src/gdcmDict::GetTag bug fix.
2903 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2904 * Straightforward temporary fixes for swig to build the python wrappers.
2905 src/Makefile now has a python working entry [by working we mean
2906 that we can import de shadow classes without errors].
2908 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2909 * hashtest.cxx removed (since allready in Test)
2910 * src/gdcmlib.h renamed to src/gdcm.h
2911 * src/dcm.i renamed to src/gdcm.i
2912 * src/Makefile prepared for python wrapping
2914 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2915 * src/gdcmHeader.cxx :
2916 - Parsing of header is now separated from loading of element values
2917 (see gdcmHeader::LoadElements).
2918 - general clean up of hopefully all file access (creation of
2919 ReadInt16 and ReadInt32)
2921 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2922 * src/gdcmHeader.cxx :
2923 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2925 - SetLgrElem renamed to SetLength
2926 - GetLgrElem renamed to GetLength
2927 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2928 * src/gdcmElValSet.cxx fixed both GetElValue methods
2929 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2930 due to IdoDude was cleaned out.
2932 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2933 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2934 concentrates on finding the value representation (when it exists).
2935 RecupLgr now only finds the element value length, and it avoids
2936 returning the unecessary skL (skipped length).
2937 Also, offsetCourant was simply removed (with taille_fich) since
2938 it was redundant with the File position internals (by using
2939 ftell and fseek). This also made skL (see above in RecupLgr) usage
2941 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2942 on the libido specificities which are handled through class
2944 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2947 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2948 * Truckload of changes. Parsing of header is barely functional
2949 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2951 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2952 * src/gdcmHeader.cxx many addons of low level methods
2954 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2955 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2956 and _IdDcmSWAP_LONG.
2958 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2959 * This corresponds to all the changes decided at the meeting of
2960 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob