1 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Initial work in gathering all transfer syntax accessors. clearly
3 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
4 ivars, but only one transfersyntax (class) ivar with equivalent method on
7 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
8 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
9 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
10 discussed (plus I didn't like having a 2000 lines patch not commited)
12 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
13 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
14 * CLEANUP_ROUND (14) for gdcmPixelConvert
15 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
16 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
17 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
19 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
20 anymore and hence avoids storing a copy of PixelConvert::Decompressed
21 into File::Pixel_Data.
23 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
24 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
25 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
26 * CLEANUP_ROUND (13) for gdcmPixelConvert
27 Substituted File::ParsePixelData() with PixelConvert::Print() new
29 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
30 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
31 method to those classes.
32 - src/gdcmFile.[cxx|h]:
33 -- Added a ::Print() method.
34 -- PixelConverter is now a reference instead of a member.
35 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
36 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
38 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
39 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
40 collaboration diagram and inheritance diagram should be generated with
42 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
43 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
44 pointlessly wrapped (see
45 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
46 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
47 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
48 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
49 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
50 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
51 -- File::Initialise: PixelConverter setup moved away to
52 PixelConverter::GrabInformationsFromHeader()
53 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
54 interpretation moved away to PixelConverter::BuildRGBImage()
56 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
57 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
58 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
60 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
61 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
62 displayed on Win32 when a brutal abort() occurs (because of uncatched
63 exception). See TODO new entry of this commit for more on this.
64 * TODO added new entry.
65 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
66 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
67 - HandleColor is no longer called from gdcmFile.cxx
68 - gdcmPixelConvert.cxx clean up on method arguments and internal
69 variable names for semantical coherence.
71 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
72 * Finished lossless transition, not only do we now read all lossless jpeg
73 images, without the need of the Cornwell lib, but we do read them properly now
74 * To reduce code (well to avoid code duplication), I defined a common place
75 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
76 redefine symbols. This is not prefect but this the best solution I found for a
77 compilation time jpeg option.
79 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
80 * Update jpeg ijg lib to support lossless jpeg implementation
81 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
83 * Also added a special copyright for dcmtk since we use their bugfixes.
86 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
88 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
89 matters, as stated in warning note at begining of %include section).
90 * src/gdcmDicomDir*.[cxx|h]: coding style
91 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
92 * src/gdcmJpeg8.cxx: doxygen fix.
93 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
94 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
95 from File:: to PixelConvert::.
97 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
99 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
100 - more code moved away from File:: to PixelConvert::
101 - fat setup of PixelConverter set in place in File::Initialise.
103 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
104 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
105 namespace at the file system level. So now you should convert your examples
107 gdcmHeader -> gdcm::Header
108 It would be nice if people keep in mind to no open the namespace, since it
109 allows compilation on broken plateform which were defining common symbol in
110 the standart namespace (like LP, Unknown ...)
112 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
113 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
114 The JPEG fragments are now parsed at the same stage than the RLE
115 information. All code related to JPEG is now in gdcmPixelConvert:
116 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
117 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
118 export a gdcmFile:: method. Those are simply global functions
119 (for the time being this is better than having them attach to
120 either gdcmFile:: or gdcmPixelConvert::).
121 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
122 and stores the result in a gdcmJPEGFragmentsInfo.
123 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
124 code (among other stuff) moved away from gdcmFile:; to
127 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
129 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
130 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
131 clean up of RLE related code.
132 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
133 - src/gdcmRLE.cxx removed
134 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
135 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
136 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
137 * CLEANUP_ROUND (9) for gdcmPixelConvert
138 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
139 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
140 away from gdcmFile:: to gdcmPixelConvert::.
142 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
143 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
144 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
145 This is because Parse7Fe0 used to parse the pixels to compute the
146 length. This task was passed over to FindDocEntryLengthOB() a long
147 time ago, EXCEPT I had forgotten the OW case...
148 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
149 we just recylce the code for parsing RLE fragments and computing
151 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
152 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
153 with the retired Parse7Fe0().
154 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
155 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
157 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
158 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
159 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
160 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
161 - src/CMakeLists.txt: alphabetic order reodering + new entries.
162 * CLEANUP_ROUND (4) for gdcmPixelConvert
163 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
164 to return an unused length.
166 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
167 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
168 this should be cleanner from the plane view. The iostream are erally a pain
169 to use to do simple stuff.
171 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
172 * Redo the compilation of the ijg jpeg library. Now only one source is
173 necesseray. No need to rename file by hand what so ever. CMake handle the
174 copying of the file within different directory, configure header file to
175 modify some symbol. The only addition made to ijg wasd a mangle table so
176 that symbol are different wether we are within 8bits or 12bits.
178 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
179 * Added documentation of vtkgdcmReader on Website:
180 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
181 with it's binary name).
182 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
183 the Website to be more complete.
184 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
185 doxygenated documentation.
186 - Doc/DoxyVtkGdcmReaderExamples.txt added
187 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
188 DoxyVtkGdmReaderExamples.html )
189 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
190 * CLEANUP_ROUND (3) for gdcmPixelConvert
191 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
193 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
194 * CLEANUP_ROUND (2) for gdcmPixelConvert
195 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
197 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
198 * CLEANUP_ROUND for gdcmPixelConvert:
199 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
200 - src/gdcmPixelStuff[h|cxx] removed
201 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
202 - src/CMakeLists.txt changed accordingly
204 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
205 gdcmVersion.py moved to newly created ATTIC related
206 gdcmPython/SetupOldies/ directory.
207 * Autotools clean up:
208 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
209 - autogen.sh configure.in acinclude.m4 python.m4 removed
211 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
212 * src/*.cxx *.h Reference to License.htm fixed to License.html.
213 * Doc/CMakeLists.txt, doxygen.config.in: fix.
214 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
216 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * TODO updated with Mathieu suggestions. I proposed a template for
218 describing TODO entries and used it for new entries.
219 * Added Doc/Website/CodingStyle.html, Developpers.html,
220 DeveloppersPython.html, GdcmDataCvs.html and
221 DownloadVersion0_1.html, DownloadVersion0_3.html.
222 * Some Doc/*.txt Doxygen files (which do not really concern the
223 documentation itself, but the website) moved to html and
224 placed in directory Doc/Website:
225 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
226 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
227 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
228 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
229 * CMakeLists.txt changed accordingly.
230 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
231 DeveloppersPython.html
232 * INSTALL nows refers to Doc/Website/Installation.html
234 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * Added Doc/Website directory, that contains a first raw version
238 2004-09-23 Jean-Pierre Roux
239 * FIX In order not to be poluted any longer by casting problems,
240 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
241 we can now delete[] it safely
242 * VoidArea is now called BinArea (less confusing name),
243 and all the methods called ...VoidArea... are now ... BinArea...
244 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
246 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
248 clear) TagHT, which is an inherited member of gdcmElementSet. It is
249 up to the destructor of gdcmElementSet to clean up TagHt and it's
252 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
253 * Test/CMakeLists.txt: update to follow gdcmData renamings.
254 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
256 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
257 * ENH: added some utility method that builds a flat dictionnary
258 holding all the Dicom entries contained in the recursive structure
259 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
261 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
262 BuildFlatHashTable() that build a flat dictionary.
263 - src/gdcmElementSet.h: added a new private GetTag() accessor.
264 gdcmDocument is now a friend of gdcmElementSet.
265 - src/gdcmElementSet.cxx: clean up.
266 - Example/FlatHashTablePrint.cxx added.
267 - Example/CmakeLists.txt changed accordingly
269 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
270 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
271 moved away from gdcmDocEntrySet (since this class is an abstract class
272 acting like an interface). SQDepthLevel and BaseTagKey are now
274 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
275 and associated accessors. Doxygenation of the class.
276 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
278 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
279 Use SQDepthLevel accessor instead. ::Print() adapted.
280 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
281 - src/gdcmDocument.cxx changed accordingly.
283 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
285 - The following is the doxygen comment of the typedef declaration
286 of gdcmagKey in src/gdcmCommon.h:
287 gdcmTagKey is made to old an "universal" (as in URL, Universal
288 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
289 A dicom tag allways has a group and an element, but a set of tags
290 embeded in various (optionally nested) sequences and sharing
291 the same group and element all share the same (group, element)
292 "identifier". Hence the (group, element) cannot be used as an
293 identifier (in gdcm we shall refer to a "TagKey") of a tag.
294 In order to construct a proper tag identifier (i.e. a key) we
295 consider the following definition of a TagKey:
296 - let Group, Element be the string representation of the
297 group and element dicom tag members,
298 - let ItemNumber be the string representation of the integer
299 index of the considered item number of a sequence,
300 Let the key of a tag embeded in a sequence, noted SeqTag, be
302 /ItemNumber#Group|Element
303 where "/", "#" and "|" are characters acting as separators.
304 Then the general form of a gdcmTagKey is given by:
305 Group|Element<SeqTag>
306 where <SeqTag> means NO or many instances of SeqTag.
307 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
310 but the gdcmTagKey of a tag "embeded" is the first item of
311 a sequence, itself nested in the third item of a sequence is the
313 0004|1220/2#0008|0082/0#0008|0090
314 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
315 order to hold the new sequence compatible key. Previously, the
316 GetKey() method would look in the underlying gdcmDictEntry.
317 - src/gdcmDocEntry.cxx:
318 -- constructor now copies the underlying DictEntry key, in the local
320 -- ::Print: displays the member Key, instead of the (group, element).
321 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
322 - src/gdcmDocEntrySet.h:xi
323 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
324 -- now has a new BaseTagKey member.
326 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
327 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
329 This poses the problem with the semantics of the following lines
330 LoadEntryVoidArea(0x0028,0x1201); // R LUT
331 LoadEntryVoidArea(0x0028,0x1202); // G LUT
332 LoadEntryVoidArea(0x0028,0x1203); // B LUT
333 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
334 to the long FIXME note for what the problem is. Nevertheless in
335 order to get things working the dicom dictionary was altered !
336 Please fix things urgently...
337 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
338 information), see above note on moving the member VoidArea. Nevertheless
339 the following entries previously correctly set as US are now inproperly
341 0028 1201 OW IMG Red Palette Color Lookup Table Data
342 0028 1202 OW IMG Green Palette Color Lookup Table Data
343 0028 1203 OW IMG Blue Palette Color Lookup Table Data
344 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
345 of gdcmDocEntry moved to gdcmSeqEntry.
346 * src/gdcmSeqEntry.cxx: STYLE.
348 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
349 * Test/TestAllEntryVerify.cxx minor fix and added comments.
351 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * gdcmPython/testSuite.py: all the test suite in python is now moved
353 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
354 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
355 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
357 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
358 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
359 to avoid inclusion recursion until STL is reached.
360 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
361 mecanism. errno.h is not included in gdcm anymore.
362 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
363 (gdcmFormatError now inherits from gdcmFormatUnexpected).
365 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
366 gdcmData/TestAllEntryVerifyReference.txt
367 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
368 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
369 exception_on_error parameter.
370 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
371 - vtk/vtkGdcmReader.cxx changed accordingly,
372 - Example/*.cxx and Test/*.cxx changed accordingly.
374 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
376 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
377 enable_sequences removed from gdcmHeader constructor and dependencies.
378 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
379 * gdcmPython/demo/PrintHeader.py: dummy fix.
380 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
381 skip_shadow removed from gdcmHeader constructor and dependencies.
382 * Example/*.cxx and Test/*.cxx changed accordingly.
384 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
385 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
386 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
388 2004-07-21 Jean-Pierre Roux
389 * FIX Now, Parsing and Printing a DICOMDIR do work!
390 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
392 2004-07-20 Jean-Pierre Roux
393 * FIX Some brain damaged headers have Zero-Lenght fields
394 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
396 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
397 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
398 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
399 variable (instance of gdcmDebug) by a definition macro, and the instance
400 is now in static in the gdcmDebug class
401 * src/gdcmSQItem.h : (FIXME) remove an undefined method
402 * Test/PrintAllDocument.cxx : bug fix in the result of the test
404 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * WARNING: ctest now depends more tightly on gdcmData. You should
406 check out gdcmData properly for things to run smoothly...
407 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
408 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
409 we need the pixels not be loaded in order to use the ValEntry
410 that displays position and size).
411 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
412 This is a C++ based equivalent of gdcmPython/testSuite.py that should
413 be deprecated. If you have any doubts about the advantages of a
414 modern scripting language (read Python) versus grass root C++ (i.e.
415 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
416 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
417 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
418 Anyhow, consider documenting the gdcmData images in
419 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
421 * Test/CMakeLists.txt:
422 - now uses TestAllEntryVerify.cxx
423 - specific comments on oldACR00001.ima (now renamed in gdcmData
424 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
425 gdcmData/TestAllEntryVerifyReference.txt
428 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
429 * src/*.[h|cxx] : typedef clean up
430 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
431 - TagKey renamed to gdcmTagKey (for external usage)
432 - VRKey renamed to gdcmVRKey (for external usage)
433 - removal of typedef duplication.
434 - Removed all unecessary inline keyword from class inline definitions.
435 - Some method|function(void) declarations replaced with method|function().
436 * src/jpeg/libijg12/jdhuff12.c:
437 - printf polluting ctest removed.
438 - TAB removal for comminting
440 - TestAllReadCompareDicom.cxx: added a test that compares all the
441 images in gdcmDataImages.h with corresponding images in
442 gdcmData/BaselineDicom/. When baseline images are not present
443 this test creates them.
444 Note: we need to validate each reference image, but before that
445 I'd like to rename them with a more explicit name...
446 - CMakeLists.txt: changed accordingly.
447 * Example/*.cxx: examples now only include gdcm.h (as opposed to
448 including each header needed).
450 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
451 * Test/*.cxx and Example/*.cxx: moved some examples away from the
452 test suite to the Example directory. Are concerned:
457 - TestWriteSimple.cxx
458 * Test/CMakeLists.txt: added some comments on reasons for black listing
459 image gdcmData/oldACR00001.ima
461 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
462 * Test/CmakeList.txt: removed the following from black list (to be coherent
463 with removal from gdcmData):
464 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
465 - gdcm-MR-PHILIPS-16.dcm
467 Added the following because after last cvs update, they cause
468 ctest -R TestReadWriteReadCompare
470 - gdcm-MR-SIEMENS-16-1.acr
472 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
473 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
474 new comments in this file) we temporarily (sigh) move to a weaker
476 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
477 we don't need to black list the following images anymore:
478 - 8BitsUncompressedColor.dcm
480 - US-PAL-8-10x-echo.dcm
481 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
482 fixes and the beautified code ;-)
483 This fixes the bug introduced in version 1.42 (when beautifying)
484 that made the parsing of 8BitsRunLengthColor.dcm unproper.
485 Note: ctest was blind to this bug (this means we need to still
486 improve the test suite). The bug could be detected by using
487 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
489 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
490 and by displaying the (garbage) produced file temp.XDCM...
492 2004-06-29 Jean-Pierre Roux
493 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
494 - replace by uggly but working old code :-(
495 A lot of things should be OK again.
496 It's really urgent to have a test suite that *tests*,
497 to prevent Frog's beautifying sessions to break all the stuff
498 (twice, withing a fortnigh ...)
500 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
501 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
502 redundancy) to added Test/TestReadWriteReadCompare.cxx
503 * Test/CmakeList.txt: because the compare test of
504 Test/TestReadWriteReadCompare.cxx fails, the following images are
505 black listed: - 8BitsUncompressedColor.dcm
507 - US-PAL-8-10x-echo.dcm
508 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
509 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
510 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
511 and ad-hoc kludge. This kludge is now removed, and on encountering
512 such an image (OB field brain damaged) we set errno. Then in
513 ::FindDocLength() we "fix" the length as being ALL what remains
514 in the file (until EOF). We then proceed, hoping for the best...
515 This fixes a SegFault in ShowDicom when trying to write such an
517 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
518 (because TestWriteRead breaks on it, after a non conformal commit?).
519 ctest now runs properly, except for MakeDicomDir (which was allways
520 broken) and the Python related stuff (still not fixed).
522 2004-06-24 Jean-Pierre Roux
523 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
524 FIX : Test/TestReadWrite now iterates on all the file names
525 (instead of infinite loop)
526 ENH : Test/TestWriteRead now iterates on all the file names
528 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
529 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
531 2004-06-24 Jean-Pierre Roux
532 FIX : - now Write drops LUT Descriptors and LUTs (if any)
533 when SamplesPerPixel =3
534 - now Write is no longer confused by
535 'BitsAllocated = 12" and 'BitsStored=12"
536 - "UN" value representation Elements are now written correctly
537 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
538 ENH : - now gdcmHeader has its own Write methods
539 (in order to split the job that has not to be done
542 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
544 loop on the same image until memory went out.
545 Note: this means we still have gobs of memory loss in PrintDocument
546 * src/gdcmDocument.cxx: fixes problem on parsing on file
547 gdcmData/16BitsJpegLosslessGrayScale.dcm.
549 2004-06-24 Jean-Pierre Roux
550 FIX : Write - All the Sequences and Sequence Item are now written
551 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
552 is added a the end, when necessary.
553 - A lot of brain-damaged images, that were read correctly are
554 now written correctly
555 - length compatible BinEntry are now loaded correctly
556 (even for odd groups)
557 Note : only Explicit Value Representation was checked.
558 (question : is implicit VR really necessary for gdcm ?)
560 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
561 * DEVELOPPER: added a proposition of coding style.
562 * src/gdcmDocEntry.h: removed every inline declaration (for test of
565 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
567 Use the gdcmDocEntry::Print() and Write() instead.
568 * src/gdcmDocument.cxx: bug fix.
570 2004-06-22 Jean-Pierre Roux
571 FIX : gdcmDocument.cxx
572 - Now we do recognize the JpegLossLess format (there was a misstyping in
573 code 'beautyfication' :-(
574 - Now we automaticaticaly load the Luts, if any
576 2004-06-22 Jean-Pierre Roux
577 In order : to write Sequences, whatever their imbrication level,
578 : to allow user to create his own Sequences
579 a lot of modif where necessary (adding, moving, or virtualising methods)
581 WARNING : save your own sources *before* cvs up !
584 ADD virtual void Write(FILE *fp, FileType filetype);
587 ADD virtual void Write(FILE *fp, FileType filetype);
588 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
591 ADD virtual void Write (FILE *fp, FileType filetype)=0;
592 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
593 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
594 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
595 ADD std::string GetEntryByName(TagName name);
596 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
598 std::string vr = "unkn",
599 std::string fourth = "unkn",
600 std::string name = "unkn");
601 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
602 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
603 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
604 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
605 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
606 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
607 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
608 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
611 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
612 ADD virtual std::string GetEntryByName (TagName tagName);
613 ADD virtual std::string GetEntryVRByName (TagName tagName);
614 REM virtual bool Write(FILE *, FileType);
615 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
616 FILE *_fp, FileType type);
617 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
618 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
619 REM virtual bool WriteEntries(FILE *_fp,FileType type);
620 REM virtual std::string GetEntryByName (std::string tagName);
621 REM virtual std::string GetEntryVRByName (std::string tagName);
622 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
623 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
624 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
626 std::string vr = "unkn",
627 std::string fourth = "unkn",
628 std::string name = "unkn");
629 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
630 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
631 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
632 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
635 ADD virtual void Write(FILE *fp, FileType filetype);
638 ADD virtual void Write(FILE *fp,FileType filetype);
641 ADD virtual void Write(FILE *fp, FileType filetype);
642 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
643 REM std::string GetEntryByNumber(guint16 group, guint16 element);
644 REM std::string GetEntryByName(TagName name);
647 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
649 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
651 The default constructor invoked by the line
652 gdcmHeader *f1 = new gdcmHeader( header );
653 was gdcmHeader::gdcmHeader(bool) instead of the expected
654 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
655 Hence the parsing wasn't executed... See also below.
656 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
657 as explicit constructor didn't do the trick to fix the above problem.
658 Could anyone explain why ?
659 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
660 properly calls gdcmValEntry::Print() (that was weed out from
661 code related to gdcmBinEntry).
663 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
664 * In order to fix memory leaks:
665 - Test/TestWriteSimple.cxx: added cleaning of free store through
667 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
668 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
669 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
670 (through the call to ::AddDicomDirMeta()) or the destructor
671 would crash when deleting uninitialized ::metaElems].
672 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
673 - src/gdcmDocument.cxx:
674 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
676 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
677 was causing memory leaks.
678 - src/gdcmSQItem.cxx:
679 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
680 cleanly handled with polymophism: sorry but my milage is low).
681 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
682 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
683 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
684 This avoids SegFaulting.
685 - src/gdcmSQItem.h: coding style.
687 - Test/TestWriteSimple still severely sucks. The output image content
688 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
689 damaged when displayed with vtkgdcmViewer.
690 - on memory leaks: TestWriteSimple leaks really less (see entry
691 of 2004-06-18 in Changelog file for the call to valgrind).
692 - on segfaults: ctest now passes all the tests but one (no more
694 * Erroneous leading white fix:
695 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
696 white[s] (as opposed to from >> xxx, that removes it [them].
697 - src/gdcmTS.cxx: ditto.
698 - gdcmPython/testSuite.py: dirty related kludge removed.
699 * src/*: remaining references to gdcmParser removed.
700 * src/*[cxx|h]: added copy[way]left header.
703 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * In order to fix writing of dicom files:
705 - Test/TestWriteSimple.cxx: a simpler example of writing.
706 - Test/CMakeLists.txt changed accordingly.
707 - src/gdcmDocument.cxx:
708 -- The destructor now recursilvely removes potential sequences.
709 -- Bug fix in ::IsJPEG2000()
710 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
711 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
713 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
714 to only declared) and build on top of
715 ::GetDocEntryByNumber(guint16, guint16).
716 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
717 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
718 for usage in destructor and treatement of promotion in
719 ::ReplaceOrCreateByNumber().
720 - src/gdcmSQItem.cxx: destructor should better handle his job.
721 Test/TestWriteSimple now runs (or at least it DOES something).
722 * We can now start hutting memory links. A good starting point is:
723 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
724 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
725 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
727 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
728 * Valgrind note: after Mathieu Malaterre teached me how to read
729 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
731 Using gcc, you can force the STL to use malloc and to free memory as
732 soon as possible by globally disabling memory caching.
733 With 3.2.2 and later, you should export the environment variable
734 GLIBCPP_FORCE_NEW before running your program.
735 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
736 simply vanish (it is still not clear to me, whether this means that
737 STL std::string leaks or if valgrind believes it leaks...).
738 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
739 running bin/gdcmTests makeDicomDir):
740 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
741 - Test/makeDicomDir.cxx now properly traps empty lists and returns
743 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
744 SegFaulting (I drowned in DicomDir related code when trying to
745 understand why the list is empty...).
746 * src/gdcmDocument.h: first BSD license header try.
747 * Doc/License.txt added.
749 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
750 * src/gdcmDocument.[h|cxx]:
751 - Clean up of the Transfer related predicates. They are now all based
752 on new method isGivenTransferSyntax, that (should) handle properly
754 - general clean up, simplification, and coding style.
755 - Specific clean up of Parse7FE0() (umproperly named actually).
756 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
758 2004-06-14 Jean-Pierre Roux
760 - fix the display of Sequence Delimitor (SQDepthLevel pb)
761 - fix the display of SQItem ordinal number
762 - add the GetSQItemByOrdinalNumber method
763 - remove some useless never written private methods
765 2004-06-14 Jean-Pierre Roux
767 - adding a constructor taking a gdcmDocEntry as an input param
768 - ReplaceOrCreateByNumber now returns :
769 a gdcmBinEntry * if a Binary (void *) value is passed as a param
770 a gdcmValEntry * if a string value is passed as a param
772 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
773 according to the param type (no longer sets a gdcmDocEntry)
774 - GetValEntryByNumber, GetBinEntryByNumber added
775 - NewValEntryByNumber and NewBinEntryByNumber added
777 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
779 - GetSQItemNumber and SetSQItemNumber added, to provide
780 a (relative) Item identier inside a given Sequence
781 \warning : some pb remaining around this number
783 - AddEntry now takes the Item Number as a param
785 - adding a constructor taking a gdcmDocEntry as an input param
787 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
788 * Memory leak hunt with the following command:
789 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
790 --show-reachable=yes gdcmTests PrintDocument
791 It looks like many (all?) leaks are due to the STL (or a bad usage
792 of the STL. The lines producing the leaks now have a comment with
793 a "MEMORY LEAK" tag: you can retrieve them with
794 grep "MEMORY LEAK" src/*
795 Here are two typical examples which I can't help fixing:
800 char * test = "babo";
801 name = test; //// <--- valgrind detects 960 bytes lost in
802 //// call to std::string::operator=(char const*)
803 name.clear(); //// Doesn't help !
811 std::cout << "Type a bunch of characters followed by RETURN: ";
812 getline(std::cin, line); //// <--- valgrind dectects a loss
813 //// of 1320 bytes in call to
814 /// std::basic_istream<>& std::getline<>
820 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
821 * src/gdcmHeader.[cxx|h]:
822 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
823 and related, moved away to gdcmDocument.
824 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
825 the corresponding protected accessors of inherited class
826 gdcmDocument, removed ! As a consequence gdcmFile had to be
827 declared friend of class gdcmDocument (see below).
828 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
829 - Clean up of undefined or unused methods.
830 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
831 account the changes to gdcmHeader.h).
832 * src/gdcmDocument.h:
833 - gdcmFile is now a friend class (in order to take into account the
834 changes to gdcmHeader.h).
835 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
836 (see changes to gdcmHeader.h).
837 - Accessors (reading on the form GetEntry*) are now public.
838 - Clean up of undefined or unused methods.
839 * src/gdcmDocument.cxx:
840 - adaptation to changes to gdcmDocument.h
841 - ::OpenFile now writes a verbose message when file cannot be opened.
842 - some std::string properly set to VRKey
843 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
844 references to gdcmDocument.
845 * Test/TestFindTags.cxx: changed accordingly to above changes.
846 * gdcmPython/testSuite.py: adapted to renaming of acr files in
847 cvs repository gdcmData.
849 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
851 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
852 conflicts with gdcmValEntry::voidArea.
853 * src/gdcmValEntry.cxx: unmatching comment wiped out.
854 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
855 Value representation between StringRepresentable and BinaryRepresentable.
856 * src/gdcmDocument.cxx:
857 - method ParseDES: proper indentation restored and usage of
858 gdcmVR::IsVROfGdcmStringRepresentable wired in.
859 - method LoadDocEntry: the fingerprint left in the SetValue() of
860 unloaded entries (length > MaxSizeLoadEntry) had curiously been
861 removed. Reverting to previous code segment with the proper
862 dynamic_cast< gdcmValEntry* >.
863 Note: this was (partially) breaking the python test suite
864 (gdcmPython/testSuite.py) that made usage of the above
865 fingerprint to check presence of "Pixel Data".
866 * src/gdcmDocEntry.h: coding style.
867 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
868 now taken into account.
869 * gdcmPython/gdcm.i: adaptation to the new internal representation
870 of gdcm (exit gdcmParser, hello gdcmDocument).
871 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
873 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
874 anymore, but instead prints the loaded Python dictionary.
875 * .... alas, the python testSuite is still broken.
877 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
878 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
880 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
881 * src/gdcmUtil.h : export methods
883 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
884 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
886 * Initial addition of automatic python testing
887 * Initial addition of automatic image comparison
889 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
890 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
891 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
893 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
894 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
895 * Test/ShowDicom.cxx : bug fix for msvc compilation
896 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
898 2004-05-04 Jean-Pierre Roux
899 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
900 new concepts (and new classes) :
901 a 'gdcmDocument' is composed of a set of Doc Entries, that are
902 - elementary gdcmDocEntries (former gdcmHeaderEntries)
903 - Sequence Doc Entries (gdcmSeqEntries)
904 a Sequence is composed of Items.
905 Each item is a set of Doc Entries (this is recursive)
906 The non uniqueness of the 'Dicom tag' is due to this recursivity
907 (never taken into account)
908 Our unability to add a new 'entry' in the header
909 at the proper location (neither in the H-Table (map or multimap),
910 nor in the Chained List is also due to this recursivity.
911 Don't try, right now, to use/modify/compile these new sources :
913 We just commit all the stuff, 'as is', in order not to loose it.
915 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
916 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
918 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
919 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
920 file prefix (SetFilePrefix)
922 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
923 * Add a new test: ShowDicom, for now this is just the c++ version of
924 checkRead.sh, later it will be able to compare the image read against a
926 * Replace the DEBUG on the stack with a global entry in cmake interface:
927 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
929 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
930 * Add an example subdir, with a real example on how to read + write a
933 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
934 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
935 * Doc/CMakeLists.txt: the main page is now properly differentiated
936 between the developper and user version.
937 * Doc/doxygen.config.in: dropped search related obsolete flags
938 * src/gdcmParser.h, gdcmHeader.h: doxygenation
940 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
941 * DEVELOPPER: added some helpfull comments for compile/test/install
944 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
945 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
946 src directory, now generated in the build dir.
947 2. Tests as mentionned smarter
949 4. Add a new method in gdcmDict that return the PubDict by name
950 this is interesting for 3rd party lib like ITK,
951 where we could set the institution name / patient name...
953 * ENH: 1. Now the test suite is working for real
954 2. All binaries are now output in the gdcm-bin directory
955 (this was not true before)
957 2004-04-28 Jean-Pierre Roux
958 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
959 SeQuence indented printing of Dicom Header.
960 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
961 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
962 Computation of SQDepthLevel is now part of gdcmHeader constructor
963 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
964 tree-like structure of a Dicom Header.
965 * FIX Test code cleaning
967 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
968 * ENH: Adding automatic testing
969 1. Need a DartConfig.cmake to submit to public
970 2. Add a test driver gdcmTest.cxx
971 3. gdcmTestMain, an helper for the main test driver gdcmTest
972 4. Files in Test don't have a main anymore, this becomes interesting
973 when we add more and more tests, thus dsw don't have to load
975 * ENH: Adding a GDCM_DATA_ROOT for testing
976 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
977 one file instead of seven + some small cleanup
979 2004-04-22 Jean-Pierre Roux
980 * ENH Minor changes to the Print() methods.
981 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
982 Header printing. Example given with :
983 > PrintHeader fileName 2 new
984 (SQ based tree-like structure still to be done for the Header ...)
986 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
987 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
988 1. I have added some unsigned where needed
989 2. Some function parameter not used -> (void)
990 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
991 4. g++ don't like character '\' in comment
992 5. #define jpeg_create_decompress jCreaDecompress
993 this really need to be fixed
994 6. virtualize destructor of gdcmObject ... leakage
995 7. sscanf(g->first.c_str(),"%x",&gr_bid);
996 this also really need to be fixed
997 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
998 remove compression file
999 (as we only do decompression, right ?)
1000 * ENH: Change malloc/calloc/free with c++ equivalent
1002 2004-04-21 Jean-Pierre Roux
1003 * FIX gdcmHeaderHelper::GetXSpacing
1004 when a single value is found (bug ?), xpacing is now
1005 defaulted to yspacing
1007 2004-04-19 Jean-Pierre Roux
1008 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1009 * ENH add parameters :
1010 bool exception_on_error = false,
1011 bool enable_sequences = false,
1012 bool ignore_shadow = false
1013 to the gdcmFile constructors to be full gdcmParser compliant
1014 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1015 to allow reading of PAPYRUS 3.0 files
1017 2004-04-06 Jean-Pierre Roux
1018 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1020 2004-04-02 Jean-Pierre Roux
1021 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1022 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1023 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1025 2004-03-30 Jean-Pierre Roux
1026 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1027 for ACR file, written out as DICOM files (hope so...)
1029 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1031 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1032 moved to base class gdcmParser and only the specialisation is kept
1034 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1035 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1036 already does the job.
1037 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1038 (to be consistent with gdcmParser::WriteEntries).
1040 2004-03-30 Benoit Regrain
1041 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1042 upate of the object's instance. It's passed to 2 in the unfavorable
1043 case : one in the ExecuteInformation, one in the ExecuteData
1045 2004-03-29 Jean-Pierre Roux
1046 * ENH : Check on file type to be written moved
1047 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1048 * FIX : gdcmObject::ResetBoundaries now stops properly
1049 when end-of-list is reached
1050 : gdcmVersion modified (as Benoit Regrain asked)
1052 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1054 * src/gdcmUtil.cxx: added forgotten iostream include.
1055 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1056 equivalent to ExplicitVR in existing code).
1058 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1060 now contains all the gdcmGlobal related code.
1061 * minor coding style and doxygenation changes.
1063 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1065 now contains all the Debug related code.
1066 * minor clean-up of includes in src/*.cxx
1067 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1068 CreateCleanString) removed.
1069 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1070 * Doc/DoxyMainPageUser.txt added.
1071 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1072 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1073 src/gdcmDirList.cxx)
1075 2004-03-24 Jean-Pierre Roux
1076 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1078 2004-03-23 Jean-Pierre Roux
1079 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1080 big endian made volumes
1081 * ENH Now gdcmParser constructor and destructor are protected to forbid
1082 end user to instanciate class gdcmParser
1083 (only gdcmHeader and gdcmDicomDir are meaningfull)
1085 2004-03-22 Benoit Regrain
1086 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1087 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1088 gdcmSerie to gdcmDicomDirSerie
1090 2004-03-19 Jean-Pierre Roux
1091 * ENH Now the tree-like structure describing a DICOMDIR comming from
1092 an already existing DICOMDIR file is consistent with
1093 the home-made tree-like structure build ex-nihilo
1094 or build from the files held (recursively) in a Directory
1095 functions gdcmDicomDir::CheckBoundaries()
1096 gdcmObject::SetBoundaries() added
1098 2004-03-17 Jean-Pierre Roux
1099 * REM (Eric Boix bug) : removal of meaningless
1100 gdcmDicomDirImage::NewImage function.
1101 * FIX now file names and directory name are written properly in the
1103 * FIX now gdcmDicomDir constructor may be call without any trick
1106 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1107 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1108 of gdcmDicomDirImage::NewImage as empty function.
1110 2004-02-28 Jean-Pierre Roux
1111 * ENH add gdcmDicomDir:NewPatient
1112 add gdcmDicomDirPatient:NewStudy
1113 add gdcmDicomDirStudy:NewSerie
1114 add gdcmDicomDirSerie:NewImage
1115 to allow making gdcDicomDir object.
1116 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1117 (as opposite to the gdcmHeader chained list)
1119 2004-02-11 Benoit Regrain
1120 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1121 when using from python
1123 2004-02-10 Benoit Regrain
1124 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1125 * FIX : in gdcmDicomDir when the directory is empty
1126 * ENH : add callback and methods to get the progression of dicomDir
1129 2004-02-06 Jean-Pierre Roux
1130 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1131 - GDCM_META added to gdcmDicomDirType
1132 - class gdcmMeta created
1133 * ENH : - A brief summary is now displayed at the beginning of
1134 'testDicomDir' to help disaster magnitude estimation
1135 * REM : Now useless Test/explDICOMDIR.cxx
1137 2004-02-05 Benoit Regrain
1138 * ENH : add methods in gdcmObject to get the hash table or the list of
1140 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1141 * FIX : wrapping python for TagHeaderEntryHT
1143 2004-02-04 Benoit Regrain
1144 * FIX : even length for some strings when writting the dicom dir
1145 * FIX : sort the images in the dicom dir
1146 * FIX : Bug fix for python use of dicom dir
1147 * ADD : a python demo
1149 2004-02-04 Jean-Pierre Roux
1150 * FIX : Final solution (?) for icone embedded images
1151 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1152 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1153 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1154 gdcmData/gdcm-MR-SIEMENS-16.acr1
1155 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1156 to make full checking easier
1158 2004-02-04 Benoit Regrain
1159 * FIX : WriteEntries : coding style & logic in parameters
1160 * FIX : Set the elements to create the DicomDir in a dictionary file
1162 2004-02-03 Benoit Regrain
1163 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1164 * gdcmDicomDir : add the load of directory
1165 * Bug fix and print add-on
1167 2004-02-03 Jean-Pierre Roux
1168 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1169 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1170 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1171 * FIX gdcmParser.cxx : 'group length' elements are now considered
1172 as integers, even for shadow groups, when file is Implicit VR
1174 2004-02-02 Jean-Pierre Roux
1175 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1177 of the last synonym :-(
1178 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1180 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1181 * FIX taking into account the possible 7fe0,0010 multiplicity
1182 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1183 to allow removal of references to 7fe0,0010, to deal with
1184 ACR-NEMA images, when 0028,0200 is meaningfull
1186 2004-01-31 Jean-Pierre Roux
1187 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1188 no longer writes 'Un' on disk
1189 * FIX SQ elements with actual length are now dealt with corectly
1190 * FIX gdcmFile::WriteBase make the difference, for color images, between
1191 the length (for Palette expanded images)
1192 and Raw Length (non expanded image + Palette)
1193 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1194 (that broke Write). Replaced by UL.
1195 Aware user will reload the field if he
1196 thinks it's necesssary
1198 2004-01-30 Jean-Pierre Roux
1199 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1200 when 'dirty Acr' is found, to be compliant with the new
1201 IsReadable() methods.
1203 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1204 (no DOUBLE images in kosher DICOM,
1205 but so usefull for people that miss them ;-)
1207 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1208 DICOMDIR related utilities (not checked as Windoze compliant)
1210 2004-01-28 Jean-Pierre Roux
1211 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1213 2004-01-27 Jean-Pierre Roux
1214 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1215 to allow skipping the shadow elements, to save memory space.
1216 The TRUE value for this param has to be used
1217 with a FALSE value for the 'enable_sequence' param.
1218 ('public elements' may be embedded in 'shadow Sequences')
1219 * gdcmHeader methods now deal with 'embedded icones images' in the header
1220 (even when an 'icone image sequence' is announced by the
1221 element (0x0088,0x0200), but there is NO icone at all ...
1223 * gdcmHeader sometimes Image Location value doesn't follow
1224 the supposed processor endianity (see gdcmData/cr172241.dcm).
1227 * gdcmHeader add the method
1228 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1229 to get *all* the Header Entries with the same tag.
1230 GetHeaderEntrySameName is probabely *useless*
1231 (no meaning : Name is *not* an identifier within the Dictionnary)
1233 2004-01-26 Benoit Regrain
1234 * Bug fix in the print of hexadecimal representations. Remove long fields
1235 in the print and add a third level of print to print them
1237 2004-01-23 Benoit Regrain
1238 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1239 * Bug fix on test suite after remove the strip made on not string fields
1240 * Split the IsReadable method between gdcmParser which test that the file
1241 is dicom and gdcmHeader which test that it's an image file
1243 2004-01-22 Benoit Regrain
1244 * DicomDir : clean code, add methods, set variables in protected or private
1245 * gdcmUtil : bug fix for the clean string method
1247 2004-01-19 Benoit Regrain
1248 * Add the use of shadow dictionaries
1249 * bug fix and coding style
1251 2004-01-19 Benoit Regrain
1252 * src/gdcmFile.cxx : bug fix concerning the close of file
1253 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1254 * Add the update of header entries using the shadow library
1256 2004-01-19 Benoit Regrain
1257 * removal of file gdcmHeader2.cxx
1258 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1259 inheriting from gdcmParser. This split is to prepare the integration
1260 of dicom dir parsing
1261 * bug fix under python
1263 2004-01-16 Jean-Pierre Roux
1264 * REM removal of class gdcmHeaderEntrySet
1265 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1266 * ADD add file gdcmHeader2.cxx
1267 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1269 2004-01-15 Benoit Regrain
1270 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1271 entries created while parsing the header. Thus, they will be destroyed
1272 when the gdcmDictSet will be destroyed
1273 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1276 2004-01-15 Benoit Regrain
1277 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1278 made a fatal error because of the memory release at the end of program.
1279 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1280 some memory and vtk seems to have some problems with that.
1281 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1283 2004-01-14 Benoit Regrain
1284 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1285 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1286 * src/*.[h|cxx] : make changes due to class name changes
1287 * gdcmPython/demo/*.py : bug fix due to method names
1289 2004-01-13 Benoit Regrain
1290 * src/*.[h|cxx] : coding style
1291 * vtk/*.[h|cxx] : coding style
1293 2004-01-13 Benoit Regrain
1294 * gdcmPython/testSuite.py : test the readable flag of file for tests
1295 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1296 It's lied to the stl compilation by MSVC (windows, always windows...)
1297 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1299 2004-01-12 Benoit Regrain
1300 * src/*.h : add comments
1301 * src/gdcmDictSet.h : set the method BuildDictPath in public
1302 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1303 directly setted in the source code
1304 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1307 2004-01-09 Benoit Regrain
1308 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1309 * setup.py : use a reference to gdcmVERSION
1311 2004-01-07 Benoit Regrain
1312 * Modification to compile with the distutils.
1315 2003-12-10 Benoit Regrain
1316 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1317 can use a gdcmHeaderHelper to load datas
1318 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1319 made in the source code
1321 2003-12-10 Benoit Regrain
1322 * Update Windows projects and .cvsignore files
1324 2003-11-12 Jean-Pierre Roux
1325 * ENH gdcmHeader constructor has one more parameter (default value : false)
1326 that allows the user to 'go inside' the SeQuences only
1328 gdcmElValSet:Print takes it into account
1330 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1331 * ENH: Update gdcmPython/CMakeLists
1332 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1333 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1335 2003-11-10 Jean-Pierre Roux
1336 * FIX : gdcmHeader::LoadElements is now based
1337 on the ListTag listElem member,
1338 not longer on the TagElValueHT tagHt member
1339 * ENH : PrintPubElVal shows (temporarily) both results,
1340 with the tagHt member and the listElem member.
1341 (it's easier to 'see' the problems when using Printheader)
1343 * FIX : old private member LgrElem is now splitted into
1344 ReadLength : Length actually found on disk (updated only
1345 if bug fixing is necessary), for internal
1347 UsableLength : Updated by FixFoundLength, to fix a bug
1348 or to allow Parser going on.
1349 Will allow to re-write a kosher header when a SeQuence
1350 with a length (not 0000) is found
1351 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1352 because gdcmElValSet::Add does not update ListElem
1355 2003-11-07 Jean-Pierre Roux
1356 * FIX misstyping in Transfert Syntax name table
1357 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1358 when they have an actual length (not 0000 nor FFFFF)
1359 (Nobody should care of it, but DICOMDIR explorers)
1361 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1362 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1364 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1365 * ENH: vtkGdcmReader now supports LUT !
1366 (vtkgdcmViewer for now is not able to use them though)
1368 2003-11-05 Jean-Pierre Roux
1369 * in testSuite.py : new files names for checking the package
1370 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1371 that returns the pixel area size to the *aware* (vtk) user
1372 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1374 2003-11-05 Benoit Regrain
1375 * in testSuite.py : Modify the rules for checking the paths
1376 : Explicit error messages
1377 * in __init__.py : Related modif
1379 2003-11-03 Jean-Pierre Roux
1380 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1381 to be used by aware (vtk) users that want to manage
1382 LUT (and no to turn the PALETTE image into an RGB pixels one)
1383 * GetPixelType now returns 8U for 24 Bits images
1384 (vtkGdcmReader compliant)
1386 2003-10-31 Jean-Pierre Roux
1387 * Removal of *all* gdcmData images and add them again
1388 in order to loose the 'history' of un-anonymised images
1390 2003-10-31 Jean-Pierre Roux
1391 * RMV : removal of useless jBitsInJsample.h
1392 for both 8 and 12 Bits JPEG Lossy Libraries
1394 2003-10-31 Jean-Pierre Roux
1395 * ENH : Add the functions gdcmFile::GetImageDataRaw
1396 gdcmFile::GetImageDataIntoVectorRaw
1397 that act as GetImageData and GetImageDataIntoVector
1398 except the making of an RGB Plane from Gray Plane + LUT
1399 Intended to aware (vtk) users who know how to manage
1402 GetLUTRGBA return a R,G,B,A LUT if any
1403 lgrTotaleRaw gives the 'Raw' length
1404 GetImageDataRaw returns the gray Plane
1405 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1406 (They stay Grey, just like with other Dicom viewers :-(
1408 2003-10-30 Jean-Pierre Roux
1409 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1411 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1412 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1413 being coherents dicom files.
1415 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1416 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1418 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1419 * ENH: Two steps is necessary to please VC++ compiler...
1420 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1421 * ENH: Add include dir to medcon lib
1422 * FIX: only one function is being exported for now !
1423 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1425 2003-10-29 Jean-Pierre Roux
1426 * adding gdcmHeader::GetLUTRGBA
1427 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1428 --> Mathieu, the modif u're waiting for is not yet committed
1429 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1431 2003-10-27 Jean-Pierre Roux
1432 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1433 00191113.dcm DermaColorLossLess.dcm
1434 MxTwinLossLess.dcm RadBWLossLess.dcm
1435 * ENH: For version prior to vtkImageViewer2 -r 1.19
1436 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1438 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1439 * Removal of ido stuff in CMakeLists.txt
1441 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1442 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1443 * FIX: remove a call to ->Modified ... see comments
1444 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1446 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1447 * FIX: Problem with path for libvtkgdcmPython
1448 * ENH: Try adding a search script for python site-package
1449 * RMV: Remove some file from medcon lib that are not necessary
1450 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1451 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1452 * FIX: More pragma disable fro VC++,
1453 I don't think I break something as it is also disable in VTK/ITK.
1454 But it fasten debug compilation time.
1456 2003-10-23 Jean-Pierre Roux
1457 * gdcm now deals with 16 Bits Run Length Encoded images
1458 (they are compressed as 2 planes images,
1459 one for the high Bytes, the other for low Bytes)
1461 2003-10-22 Jean-Pierre Roux
1462 * Now CheckRead takes into account :
1463 - the bugged 'Leonardo' Siemens images
1464 - the XA images, sent thru the burning VPRO station
1465 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1468 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1469 * FIX: When copying a Makefile.am to CMakeLists.txt
1470 one should remove the '\'
1472 2003-10-22 Jean-Pierre Roux
1473 * in gdcmData adding a bugged 'Leonardo' Siemens image
1474 (wrong lengths in header)
1475 OK with gdcm, KO with the other viewers :-)
1476 * add a GE dlx XA image, thru the VEPRO burning station
1479 2003-10-21 Jean-Pierre Roux
1480 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1481 for a brutal checking of vtkgdcmViewer compliance
1483 2003-10-21 Jean-Pierre Roux
1484 * add the files for 'xmedcon' Jpeg Lossless library
1485 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1487 2003-10-21 Jean-Pierre Roux
1488 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1490 2003-10-21 Jean-Pierre Roux
1491 * garbage Siemens 'Leonardo' images dealt with
1492 (the patch is easy to remove)
1493 * cosmetic changes to avoid warnings
1495 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1496 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1497 no need to press 'r' now.
1499 2003-10-20 Jean-Pierre Roux
1500 * upgrade of checkRead.sh checkWrite.sh according
1501 to new Jpeg Lossless decompressor
1502 * add US.3405.1.dcm, a genuine RGB medical file ...
1503 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1504 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1506 2003-10-15 Jean-Pierre Roux
1507 * general anonymisation in gdcmData
1508 * adding the 'color files' from
1509 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1510 * adding some well knowed bugged-header images
1511 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1512 waiting for their inclusion in Python testsuite
1514 2003-10-15 Jean-Pierre Roux
1515 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1516 no longer seg faults when file is not found
1518 2003-10-14 Jean-Pierre Roux
1519 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1522 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1523 * TODO: *.in file to genereate a UseGDCM later
1525 2003-10-14 Jean-Pierre Roux
1526 * Some supposed-to-be Dicom Images have no preamble.
1527 OpenFile takes it into account
1528 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1529 * Missing elements added in dicomV3.dic
1530 (just to be affraid : have a look at
1531 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1532 and do it again next year ;->
1534 2003-10-13 Jean-Pierre Roux
1535 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1536 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1537 But there are NOT. It's fixed !
1539 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1540 * FIX: "jpeglib.h" was not found on VC++
1541 * FIX: vtkgdcm was not being installed
1543 2003-10-10 Jean-Pierre Roux
1544 * ENH : OpenFile closes the file if it *really* doesn't look like
1545 an ACR-NEMA / DICOM one.
1546 * FIX : testWrite no longer writes an empty file if the source file
1547 is not gdcm Readable
1548 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1551 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1552 * FIX: CMake generate now documentation
1553 * ENH: out of source doc build !
1554 * ENH: Generate both user and dev documentation
1555 * ENH: Should work on windows too
1556 * ENH: Only one doxygen config.in file is needed
1557 * FIX: make install should be ok now on ùnix plateform
1558 * FIX: PATH to dictionary was wrong (missing /)
1559 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1561 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1562 * vtkGdcmReader is now able to read rgb dicom file.
1563 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1564 * added a gdcmViewer to vtk test, use mouse to control
1565 window level & window width
1567 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1568 * CMake-ification of gdcm, we have now two build system
1569 * FIX: on cygwin Wsock32 doesn't exist
1570 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1572 2003-10-06 Emanuel Ollart
1573 * FIX : compilation process wad broken.
1574 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1576 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1577 * change gdcmViewer -> vtkgdcmViewer
1578 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1580 2003-10-06 Jean-Pierre Roux
1581 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1582 ( e.g : well known GE images with a wrong elem length,
1583 : Philips MRI Images with a wrong Huffman table)
1584 * still to be done : allow the reading of bugged LEONARDO Siemens images
1586 2003-10-03 Jean-Pierre Roux
1587 * Odd length strings are padded with '\0' (not with spaces,
1588 to remain compliant with already defined strings,
1589 like Transfert Syntax UID and others)
1591 2003-10-03 Jean-Pierre Roux
1592 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1593 to allow displaying RGB images (not only by affim ;-)
1595 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1596 * vtkGdcmReader is now able to read rgb dicom file.
1597 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1599 2003-10-03 Jean-Pierre Roux
1600 * A few nasty patches to allow the reading of a lot of nasty images
1601 ( e.g : well known GE images with a wrong elem length,
1602 : Philips MRI Images with a wrong Huffman table)
1603 * still to be done : allow the reading of bugged LEONARDO Siemens images
1605 2003-10-03 Jean-Pierre Roux
1606 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1608 2003-10-03 Jean-Pierre Roux
1609 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1610 to allow displaying RGB images (not only by affim ;-)
1612 2003-10-03 Jean-Pierre Roux
1613 * gdcmFile::GetImageDataIntoVector now
1614 - deals with MultiFrames MultiFragments Run Length Encoded files
1615 - deals with YcBcR (YBR_FULL) files
1616 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1617 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1619 (no sample found :-(
1621 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1622 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1623 Two reasons: - clear things
1624 - third parties acces gdcm through header files, so won't
1625 suffer anymore VC++ complains
1627 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1628 * add argv[1] in testvtkGdcmReader.cxx
1631 2003-09-24 Jean-Pierre Roux
1632 * The lines are now eigthy characters long.for
1633 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1635 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1636 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1637 char* to std::string. Thus, the use of strdup becomes useless. (see
1638 previous commis of Malaterre)
1639 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1640 before the last Malaterre's commit.
1642 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1643 * This commit should fix the Debug building under VC++, the problem
1644 was mainly a mixture of debug and release lib being loaded at startup.
1645 * I also remove a depency to a specific C function: strdup. Because I had
1646 to force the link to msvcrtd (whereas strdup is in libc).
1648 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1649 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1650 located in the gdcmCommon.h file. All use of reference of tha has been
1651 changed to now use the variable GDCM_UNFOUND.
1653 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1655 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1656 Dicom dictionary. The test suite can now be run again. Note:
1657 I'm note very happy with the " (RET)" changes. I believe this
1658 RETAINED comment should be dropped when parsing the dictionary.
1659 - PACKAGER corrected
1661 - AUTHORS updated and now in alphabetical order
1662 * Makefile.am now exports gdcm.dsw for Windoze users.
1664 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1665 * cygwin complains about missing std:: in subdir Test/
1667 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1668 * remove some methods that are now in gdcmHeaderHelper
1670 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1671 * vtkGdcmReader set spacing and origin correctly
1673 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1674 * Fix a few delete/delete[] mismatch
1676 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1677 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1678 interpretation to data given by gdcmHeader. For instance there are
1679 heuristics to get informations (look at different places).
1680 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1681 sorting DICOM images based on different strategies.
1682 * modified Makefiles accordingly.
1684 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1686 when building in debug mode
1687 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1688 src/win32/gdcmdll.dsp
1689 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1691 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1692 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1695 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1696 * src/win32/libgdcmjpeg12.dsp was not dos format
1697 * src/win32/libgdcmjpeg12.dsp :
1698 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1699 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1701 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1702 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1704 * src/gdcmFile.cxx : bug fix in affectation type
1705 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1706 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1707 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1708 symbols... future problem ?
1710 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1711 * src/win32/libgdcmijpeg12.dsp was missing
1712 * modified gdcm.dsw accordingly
1714 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1715 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1717 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1718 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1719 commit of JPR (before his hollidays to facilitate our work).
1720 * setup.py : bug fix in code. Modifications made while the last commit
1721 of JPR. The code hasn't been tested before the commit... it's so
1722 useless to make that (for best programmer that is JPR) !!!
1724 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1725 * tagged the current version as Version0_3 (i.e. version 0.3)
1727 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1728 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1729 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1730 * *.dsp : modifications to use new libgdcmijpeg8 library
1731 * setup.py : bug fix on VTKPATH variable
1732 * PACKAGER : adding all concerning windows
1734 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1735 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1737 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1738 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1739 test suite reported error.
1740 * PACKAGER file added (describes what a packager must do when
1741 packaging a new release).
1742 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1743 * configure.in: upgraded version number to 0.3.0
1744 * fixing build of rpm (through rpm -ta):
1745 - Doc/Makefile.am exports proper doxygen files
1746 - src/jpeg/libijg8/Makefile.am exports the include files.
1748 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1749 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1750 * src/gdcmHeader.h : formatting code
1752 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1753 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1754 We were obtaining error message from vtk. Now, creation of file list
1755 is made in an internal list to prevent this problem.
1756 Bug fix when output is empty.
1757 Bug fix in update of progress value. Previous commit for this was a bad
1759 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1761 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1762 * src/gdcmHeader.h : added method to get the file name
1763 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1764 files. Added method to remove all files on the input
1765 Added FIXME comment concerning the bad parsing of header made by
1766 ExecuteInformation method (in ExecuteData method)
1768 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1769 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1770 when using make instal.
1771 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1772 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1774 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1775 * setup.py : adding include dir of jpeg lib to compile all sources
1776 * */Win32/*.dsp : JPR fix for windows compilation
1778 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1779 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1781 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1782 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1784 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1785 * setup.py is again effective on un*x (takes into account the
1786 addon of the jpeg library)
1787 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1788 * Doc/Doxy* updated (includes above enhancements)
1789 * INSTALL now points to web documentation
1791 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1792 * src/gdcmHeader.h doesn't make unnecessary reference to
1794 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1796 * src/gdcm*.[cxx|h] :
1797 - to allow compilation with gcc 3.x
1798 -- clean up of STL usage (added explicit usage of std::)
1799 -- small fixes on exceptions.
1800 Note: linking not tested !
1801 - clean of doxygen comments to avoid warnings at documentation
1803 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1804 dependent convertion).
1806 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1807 * Clean up of previous JPR garbage commit (not even commented in the
1809 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1810 - moved all jpeg related files from src to src/jpeg/libijg8, with
1811 addition/modification of Makefile.am and configure.in.
1812 - the testSuite is still brain damage (not guilty).
1814 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1815 * WrapVTK.py : modifications to get correctly vtk source files to
1817 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1818 (FileName -> Filename)
1820 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1821 * vtk/vtkGdcmReader.[cxx/h]:
1822 - UpdateProgress method should now be effective
1823 - removed the limitation on having only images loaded (as opposed
1825 - when building a stack of images/volume, a lesser number of
1826 gdcmHeader and gdcmFile instances should be used (hopefully
1827 accelerating things).
1828 - when building a stack of images/volumes, files which are not
1829 loadable (wrong path-filename, wrong permissions on existing file,
1830 or file not parsable by gdcm) are replaced with a black image
1831 in the stack (for the caller to notice the problem).
1833 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1834 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1836 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1837 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1838 between standard library (std) and vtk library (problems are found
1839 under Windows... thanks Windows !)
1841 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1842 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1844 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1846 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1847 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1849 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1850 * When compiling with distutils (see setup.py) the C++ compiler is
1851 called with different flags than the default ones (with automake).
1852 In order to fix all those warning, I compiled gdcm with the command
1853 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1854 and went for warning fixes:
1855 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1856 up from unused variables.
1857 - vtk/vtkGdcmReader.cxx: potential bug fix.
1858 * src/gdcmHeader.h: Doxygen warning cleanup
1860 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1861 * gdcmPython/gdcm.i:
1862 - typemaps correction to take into account the systematic replacement
1863 of "using namespace std" with std:: prefix e.g. std::list,
1864 std::string... (cf changes of 2003-05-21).
1865 - gdcmGlob global variable of type gdcmGlobal (defined in
1866 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1867 exported to Python a as cvar.
1868 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1869 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1870 gdcmDictSet.GetPubDictTagNames() and
1871 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1872 C++ static methods).
1873 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1874 with the above changes.
1876 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1877 * setup.py, manifest.in : bug fix under linux
1879 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1880 * Modification of setup.py to compile vtk part too. Then, we have 2
1881 wrappers which must work with same distutils. For that, we have a
1882 generic distutils in distusiltsWrapping.py ; with :
1883 - build_extWrap class to wrap generically all extensions,
1884 - ExtensionWrap base class for all wrapping extension that contains
1886 - Wrapper interface which wrap sources
1887 + In WrapSwig.py we have extension and wrapper for Swig
1888 + In WrapVTK.py we have extension and wrapper for VTK
1889 * MANIFEST.in : modifications to consider vtk directory and new python
1890 files for compilation
1892 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1893 * Added python wrappers of vtkGdcmReader vtk class (see the
1894 source in vtk/vtkGdcmReader.cxx) :
1895 - vtk/Makefile.am now builds a library
1896 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1897 python library (as opposed to _gdcm.so wich are the python
1898 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1899 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1901 - configure.in has an additional flag --enable-vtk that needs
1902 to be set to enable compilation of vtk related code, that is:
1903 + vtk/vtkGdcmReader.so and
1904 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1905 + gdcmPython/vtkgdcmPython.so (see above)
1906 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1907 be read when compressed or when HighBit + 1 != BitsStored),
1908 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1909 the usage of the python wrapper of vtkGdcmReader vtk class.
1910 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1911 * src/*.[h] all occurences of stl classes are now prefixed with
1912 std::, and all occurences of "using namespace std;" where removed.
1913 This is to avoid pollution of global namespace in included files.
1914 Apparently vtk does not avoid this pitfall: when using both
1915 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1916 collision of various stl members (principally cout...).
1917 * gdcmPython/testSuite.py now cleanly removes temprory generated
1919 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1920 comply with above changes)
1922 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1923 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1924 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1925 vtk data structure (an image Flip was required).
1926 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1927 * cosmetic changes in documentation.
1929 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1930 * src/gdcmHeader.cxx: the constructor no longer exits when an
1931 unexisting file is given as argument.
1932 * The subdirectory Data (containing all the images used for the
1933 test suite) is not part of this repository anymore. A new module
1934 containing those images is now available at
1935 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1936 with the name gdcmData.
1937 All the python scripts (including the package initialisation file
1938 gdcmPython/__init__.py) were adapated to take this change into
1939 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1941 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1942 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1943 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1944 demo of the usage of this class.
1945 Compilation of this vtk part is only done when using the --enable-vtk
1946 at configure (or autogen.sh) stage.
1948 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1949 * More memory link related corrections and documentation fixes.
1951 - maximum info is obtained with a command of the form:
1952 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1953 --show-reachable=yes PrintHeader
1954 - the remaining reachable blocks seem to come from the STL
1955 allocation scheme through the usage of map and list. It looks
1956 like this memory cannot be freed but it is not a memory leak
1957 (in fact further invocation to the STL would recollect the
1958 unused memory allthough it cannot explicitely be freed).
1959 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1960 of displaying an image parsed with gdcm and displayed with VTK.
1961 Note: some images don't seem to work e.g.
1962 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1963 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1964 Allthough this weakens the semantics, it is a ditch attempt to
1965 make gdcm more thread friendly.
1967 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1968 * Memory link hunt (by using valgrind through the command
1969 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1970 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1971 gdcmHeader::_dicom_vr.
1972 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1973 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1975 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1977 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1978 * src/Makefile.am now exports all the necessary include files at
1982 * UpdateGroupLength replaced by new one
1985 * UpdateGroupLength re-written using H-Table
1986 (named UpdateGroupLengthNew untill checks are over)
1988 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1989 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1990 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1992 - gdcmHeader::GetPubElValSet removed.
1993 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1994 UpdateGroupLength, WriteElements, Write.
1995 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1996 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1997 carried the same semantics.
1998 - src/gdcmHeaderIdo.cxx changed accordingly.
1999 - gdcmFile::WriteBase now regroups all the codes from previous
2000 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2001 - enum FileType moved to gdcmCommon.h
2002 * src/gdcmHeader.cxx AddDefault trashed
2003 * gdcmGetXSize added
2004 * getimageDataSize now calls gdcmGetXSize
2005 * Test/*.cxx changed to agree with above changes
2007 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2008 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2009 (to avoid double call by end user).
2010 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2011 by end user, since gdcmHeader::gdcmHeader now handles it.
2013 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2014 * gdcm/Doc many doxygen changes:
2015 - Doxyfile now has two different versions, DoxyfileUsers that generates
2016 the html.users end users oriented documentation and
2017 DoxyfileDeveloppers that generates the html.developper developper
2018 oriented documentation.
2019 - README changed accordingly
2020 - requirement.txt removed (old design info moved to TODO).
2021 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2022 DoxyMainPage.txt, DoxyPython.txt provide more information.
2023 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2024 be updated by simply regenerating the docs with doxygen and copying
2025 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2026 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2027 all the tests in the form "if (<map>.count() >1)" were removed.
2028 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2029 ill-formed documentation sections.
2030 * src/gdcmHeader.cxx: ditto
2032 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2033 * setup.py fixed for un*x (needed macro for stdint.h)
2034 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2035 un*ces with sh-utils test utility.
2036 * gdcmPython/demo/test.py renamed to PrintHeader.py
2037 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2038 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2039 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2040 * src/gdcm*.cxx JPR's bad inclusion fixed.
2042 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2043 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2044 * gdcmPython/demo/test.py changed accordingly.
2046 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2047 * gdcmPython/Makefile.am fixed linking against libstdc++
2048 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2049 * Swig subdir (historical tests of swig version 1.3.17++) removed
2050 * Test/testChangeEntete.cxx some lines commented out in order to make
2052 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2053 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2055 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2056 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2057 hence the user doesn't need this explicit call.
2058 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2059 i.e. LoadElements() call removed.
2060 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2061 - src/Makefile.am declares the proper flag for g++.
2062 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2063 for adding user defined new tags.
2064 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2065 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2066 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2068 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2069 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2070 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2071 src/Makefile.am : the project should properly compile and install
2072 with the autotools, included the python wrappers part.
2073 * gdcm.spec.in : added a spec file for RPM packaging.
2075 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2076 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2078 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2079 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2080 to exported to the environement (see gdcmPython/testSuite.py
2082 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2083 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2084 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2085 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2086 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2088 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * gdcmPython/__init__.py doesn't crash anymore when running in
2090 in InstallMode or PreInstallMode but with an environement given
2091 value of GDCM_DICT_PATH.
2092 * src/gdcmDictSet.[cxx/h] coding style.
2094 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2095 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2096 * src/gdcm.h general comments moved to TODO, and README
2097 * src/gdcm.h should now be seen as a user commodity (including it
2098 should suffice to fully use gdcm). It is nowhere including within
2099 any of the kernel files src/*.cxx and src/*.h.
2101 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2103 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2105 * src/gdcm*.cxx only include their corresponding include file
2106 (as opposed to gdcm.h)
2107 * gdcmPython/gdcm.i changed accordingly
2108 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2109 the autogen.sh generated "make snapshot" command to work.
2110 * autogen.sh removed history related references to crea package.
2112 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2113 * distutilsSwigCPlusPlus.py work around some swig portability
2116 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2117 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2118 was done in a last ditch attempt to get setup.py _really_
2119 operationnal. The python/gdcmPython layaout add the advantage
2120 of hidding away the python related distutils specific files
2121 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2122 Alas, the src directory was out of scope (i.e. it's relative
2123 position to setup.py was ../src) which made things impossible to
2124 handle (see previous version of python/setup.py). Crossing fingers...
2126 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2127 * python/setup.py now works on Un*x. (harder than I thougth)
2128 * python/distutilsSwigCPlusPlus.py can now have include files
2129 among the list of sources.
2131 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2132 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2133 * modifications in MSVC projects
2135 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2136 * As stated by the first lines of Test/ExceptionAndPython/README, it
2137 looks like we can move back to original usage of exception within
2138 src/gdcm* and hence remove the errno stuff that was introduced
2139 as a quick and dirty fixture of this problem (added to the TODO).
2140 * Doc/Doxyfile configuration file for Doxygen and corresponding
2141 README file for usage added.
2142 * Test/testWrite.cxx added. This new test comes from a split of
2143 test.cxx that is now reverted to its original purpous i.e.
2144 testing the proper parsing of a Dicom related file.
2145 testWrite.cxx concentrates on testing the IO part of gdcm.
2146 * Test/bug1.cxx (containing a bug on WIn32) added.
2147 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2148 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2149 whose purpose is to publish the content of the TagNames of the
2150 Dicom public dictionnary were not accessible without an
2151 instance of class gdcmHeader.
2152 - those methods are now static methods of gdcmDictSet and hence
2153 require no instances at all to be invocated.
2154 - within gdcmDictSet this change required to change some method
2155 to class methods (i.e. are now static) among which SetDictPath
2156 (renamed to BuildDictPath) and LoadDefaultPubDict.
2157 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2158 the above changes by calling the new method classes of gdcmDictSet.
2159 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2160 the above to be effective.
2161 * python/gdcmPython: in order to wrap properly the above changes
2162 for Python, swig version now needs to be > 1.3.17.
2163 * python/gdcmPython/Makefile fixed to adapt itself to new
2164 configure/make shema introduced by Johan Montagnat (thanks for the
2165 contribution). Alas this Makefile cannot be turned into a proper
2166 Makefile.am without some heavy changes in the configure.in
2167 (for python dectection).
2168 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2169 now avoids publishing the empty entries.
2171 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2172 * python/setup.py : bug fix concerning install under windows
2173 ExtraPath reused :-P
2174 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2176 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2177 * Dicts/dicomV3.dic : remove double spaces !!!
2178 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2179 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2182 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2184 method. Doxygenation.
2185 * src/gdcm.h clean up of JPR spurious comments.
2187 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2188 * python/distutilsSwigCPlusPlus.py now properly collects the
2189 shadow classes generated by "swig -c++" (gdcm.py in our case)
2190 when using "python setup.py install".
2191 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2192 reexports the working classes.
2193 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2194 by the classical C errno scheme. This is to prevent an obscure
2195 behavior of the python wrappers when importing wxPython.wx prior
2196 to gdcmPython (which ended up in an abort call). An illustration
2197 of this oddity can be found in the Test/ExceptionAndPython
2198 subdir (see the README file). This problem probably due to
2199 an combination of g++ and dynamic loading.
2200 * added Test/ExceptionAndPython (see above)
2202 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2203 * Changed the layout of the python part to avoid bloating main
2204 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2205 i.e. the distutils arsenal. All the python related stuff is
2206 again in a python subdir, but the package itself is now in
2208 * setup.py was cleaned up:
2209 - pythonIncludePath removed
2210 - python setup.py bdist target is now functional.
2211 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2212 collision with other packages). gdcmPython/demo/*.py changed
2215 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * python subdir moved to gdcmPython (preparation of distutils packaging).
2217 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2218 distutils installer is operational.
2219 * - gdcmPython/__init__.py now properly loads the swig generated
2220 shadow classes (from gdcm.py).
2221 - gdcmPython/demo/*.py changed to import the package gdcmPython
2222 instead of gdcmPython/demo/load.py.
2223 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2225 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2226 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2227 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2228 entries within the associated public Dicom dictionary resp. the same
2229 information but sorted by the fourth field (PAT, IMG, DIR) of the
2231 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2232 are now in the "???" group.
2233 - python/gdcm.i changed accordingly,
2234 - python/demo/printGroupedPublicDict.py added, that gives an example
2235 of the above new functionalities in Python.
2237 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2238 * src/gdcm.h, gdcmHeader.cxx:
2239 - historic references to glib's g_malloc and g_free (#defined)
2240 were definitively removed.
2241 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2242 * src/gdcmElValSet.cxx:
2243 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2244 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2245 - GetElValue(string) renamed to GetElValueByName.
2246 - Added GetElementByName(string).
2247 * src/gdcmHeader.cxx: added
2248 - GetPubElValRepByNumber(guint16, guint16)
2249 - GetPubElValRepByName(string)
2250 - GetShaElValRepByNumber(guint16, guint16)
2251 - GetShaElValRepByName(string)
2252 - GetShaElValByNumber(guint16, guint16)
2253 - GetShaElValRepByName(string)
2254 - GetElValRepByNumber(guint16, guint16)
2255 - GetElValRepByName(string)
2256 - GetElValByNumber(guint16, guint16)
2257 - GetElValRepByName(string)
2258 * Doc/requirements.txt added.
2260 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * Test/Makefile building now depends on the one of libgdcm.so
2262 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2263 pixel data) aware which enables finding the address (offset) of
2264 the pixel data of JPEG encoded DICOM files. This leaves only a single
2265 file in the testSuite whose pixel data address (offset) is unknown.
2266 * python/testSuite.py changed accordingly.
2268 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2269 * VC++ has some strong limitations when working with the STL, as stated
2270 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2271 "Also note that some STL containers (map, set, queue, list, deque)
2272 cannot be exported. [...]
2273 Some STL classes contain nested classes. These classes can not
2275 This is caused by a designed limitation that once a template
2276 class is instantiated, it can not be re-instantiated and
2278 Since our usage of map<> is ubiquitous in gdcm, this "designed
2279 limitation" of VC++ is a pitfall.
2280 Hence the Python wrappers of gdcm cannot be incrementally linked
2281 against the c++ dynamic library. The dirty but only workaround is
2282 to forget about incremental link of dynamic libraries and to generate
2283 the Python wrappers library with the inclusions of the underlying C++
2285 The following modifications concern this matter on Win32/VC++:
2286 - wrapping python correct with standalone wrapped dll (don't use separate
2287 dll under windows !!!!)
2288 - python21_d debug mode enabled (ask Frog how to use it :-)
2289 - NO problem with having an STL member of class for example string in C++
2290 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2291 - Python test of dcmlib in Python is ok under windows on a large set
2293 * removed glib references
2294 * typedef's inserted in gdcm.i for correct swig type management
2296 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2297 * python/demo/*.py load.py extracted from test.py. Added explore.py
2298 that only displays required tags and testAll.py that parses all
2299 the files of the testsuite without using unittest.
2300 * python/testSuite.py other additional test on new files added.
2301 * Data/* new test files added accordingly to the testSuite.
2302 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2303 the vr in the file differs from the one of the dictionary.
2305 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2306 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2307 values, but limits itself to values which are below a user specified
2308 size (by default 1024 bytes).
2309 * python/gdcm.i : elements not loaded (because their size is above the
2310 user specified treshold) are exported with their TagKey as key of the
2311 python dictionary. This enables the testsuite to make some checks
2312 on the unloaded elements (since we have their offset and size).
2313 * python/testSuite.py
2314 - now tests for the existence and proper value of the pixel data
2315 - two new examples added.
2316 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2318 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2319 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2320 aware. See the strategy comments in gdcmHeader::FindeLength().
2321 * Test/test.cxx now accepts a filename as first argument.
2322 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2323 * python/testSuite.py changed to integrate test on above files.
2325 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2326 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2327 the vr was also RET.
2328 * python/testSuite.py more tests added.
2330 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2331 * python/testSuite.py unittest test suite added (uses Data)
2332 * Data/* dcm and acr files for the test suite.
2333 * glib dependance removed from un*x version. We now use ISO C99
2334 7.18 Integer types (see stdint.h)
2335 - python/Makefile, src/Makefile src/gdcm.h
2336 * src/ when an explicit vr (like dicom files) suddenly poped an
2337 implicit element we use to mark the underlying DictEntry of the
2338 concerned ElValue with "Implicit". This strategy was damageable
2339 too the public or provite dictionaries, since some of their vr
2340 would be changed. Since Header::FindLength heavily relies on the
2341 detection by Header::FindVR of falsely explicit elements, I
2342 added an extra ImplicitVr member to ElValue (boolean).
2343 The rest of the changes we the necessary adaptations.
2345 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2346 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2348 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2350 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * Adaptation for porting to VC++:
2353 o forced to use std namespace (for string to be known)
2354 o all class use __declspec export style on WIN32
2355 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2356 (in stdlib.h on Win32 but in std:: for gcc)
2357 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2358 variable GDCM_DICT_PATH.
2359 * src/gdcmHeader.cxx verbose comments made discrete.
2361 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * python/gdcm.i: added a typemap that converts a C++ hashing table
2363 to native Python dictionary.
2364 * python/demo/test.py:
2365 - now uses the native dictionary for exploration of gdcmHeader.
2366 - takes an optional filename argument (the file to parse).
2367 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2368 PubElVals hashing table.
2369 * Dicts/dicomV3.dic removed error prone trailing spaces.
2371 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * Python wrapping process moved away from src/Makefile to
2373 newly created python/Makefile (as well as gdcm.i)
2374 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2375 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2376 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2377 from the environement variable GDCM_DICT_PATH (when existing).
2378 * src/gdcmDict::GetTag bug fix.
2380 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2381 * Straightforward temporary fixes for swig to build the python wrappers.
2382 src/Makefile now has a python working entry [by working we mean
2383 that we can import de shadow classes without errors].
2385 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * hashtest.cxx removed (since allready in Test)
2387 * src/gdcmlib.h renamed to src/gdcm.h
2388 * src/dcm.i renamed to src/gdcm.i
2389 * src/Makefile prepared for python wrapping
2391 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2392 * src/gdcmHeader.cxx :
2393 - Parsing of header is now separated from loading of element values
2394 (see gdcmHeader::LoadElements).
2395 - general clean up of hopefully all file access (creation of
2396 ReadInt16 and ReadInt32)
2398 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * src/gdcmHeader.cxx :
2400 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2402 - SetLgrElem renamed to SetLength
2403 - GetLgrElem renamed to GetLength
2404 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2405 * src/gdcmElValSet.cxx fixed both GetElValue methods
2406 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2407 due to IdoDude was cleaned out.
2409 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2410 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2411 concentrates on finding the value representation (when it exists).
2412 RecupLgr now only finds the element value length, and it avoids
2413 returning the unecessary skL (skipped length).
2414 Also, offsetCourant was simply removed (with taille_fich) since
2415 it was redundant with the File position internals (by using
2416 ftell and fseek). This also made skL (see above in RecupLgr) usage
2418 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2419 on the libido specificities which are handled through class
2421 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2424 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * Truckload of changes. Parsing of header is barely functional
2426 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2428 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2429 * src/gdcmHeader.cxx many addons of low level methods
2431 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2433 and _IdDcmSWAP_LONG.
2435 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * This corresponds to all the changes decided at the meeting of
2437 May 23 2002. Needless to say we are running late...