1 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
3 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
4 tests on the image size X, Y, Z
6 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
8 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
9 between the class name and the file name
11 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * src/ : fix compilation warnings for the Write method (2 different
13 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
14 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
15 variable... create a static method in gdcm::Document to access to
16 this variable content.
18 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
20 file, to be accessed by other files (like gdcmFile). Remove commented
21 code. Move the change of the header to the gdcmFile, using the
23 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
24 To be sure of that (and simplify calls), the Write of the header now
25 gets a file name and not a file pointer (std::ifstream).
26 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
27 DocEntryArchive. Remove all open of the written file
29 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
32 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
34 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
36 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
37 some corresponding methods. Write correctly the file and check before
39 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
40 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
41 is now on RGB datas (as before my last commit
42 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
44 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
46 Add a print information of the type of the entry
47 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
48 It was in the gdcmFile, and all write have been regrouped
49 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
50 Write correctly all dicom files (in decompressed mode only at this time)
51 * Test/ : test on files are now made using Raw datas and not color datas if
53 * Example/PrintFile.cxx : add more printings
55 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Amelioration of code, remove some code copy. For the loading of
57 BinEntry (in gdcmDocument), add the test to verify if the file is already
60 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
62 remove a DocEntry in the header (push an empty DocEntry)
63 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
64 lines. Bug fix in the initialization of the PixelConvert and the
66 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
67 use in TestCopyDicom (now this test can run under windows... but fails)
68 * Test/TestCopyDicom.cxx : amelioration of the test :
69 - test the pixels written
70 - add test points to quickly find where is the error
71 - can set a file name input and output in arguments
72 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
73 amelioration of the test output
75 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
76 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
77 all replaced DocEntry's
78 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
79 Now, each needed DocEntry to modify is duplicated, modified and inserted
80 to the header using DocEntryArchive. Thus, after save, we can restore the
83 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
86 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
88 correct to copy it. The DictEntry is specified at the DocEntry creation,
89 then, it musn't change in the time.
90 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
91 header correctly. At this time, the change is only made for the first
92 level of the Document. In the future, it might consider sequences.
93 The change is made by replacing a DocEntry by an other that is created
94 outside the class. The old value is kept. When we restore the header
95 status, the added DocEntry is deleted and replaced by the old value.
96 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
97 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
98 set the write type to explicit VR, implicit VR or ACR. Add methods to set
99 the write mode to native, decompressed or RGB (but not used at this time)
101 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
103 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
105 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
107 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
109 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
110 set because already copied when copying the BinEntry's of the header
111 * Test/TestAllReadCompareDicom.cxx : remove warnings
113 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
115 Two problems appear when doing it :
116 - with the gdcmFile : when the GetImageData method is called, the pixels
117 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
118 datas (pixels). And each structure destruct the datas when it's
119 destructed. So we have two destructions for the same datas. To solve it,
120 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
121 datas or not. If it doesn't own datas, then they will not destroyed by
123 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
124 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
125 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
126 create a double destruction of the same DocEntry's. So, to solve it,
127 the TagHT is simply cleared and the DicomDir* elements are destroyed.
128 * TODO : add an entry concerning memory leaks in the DicomDir
130 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
132 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
135 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
137 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
138 after it have been deleted
140 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
141 * FIX: src/* fix the doxygen warnings.
142 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
143 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
144 was erroneously defined with a size of 15 instead of 16. [many thanks
145 to Jean Michel Rouet for pointing out this bug].
147 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
148 1. Finish merging JMR patch for writting DICOM from scratch
149 2. Fix -hopefully- bug with MONOCHROME and space vs null character
150 3. Use const ref when possible
151 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
152 5. A few more comments
153 6. CreateUniqueUID can now be called without parameter"
155 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
156 * ENH: Slightly bigger patch:
157 1. Getting toward full integration of JMR patch for writting dicom from scratch
158 2. Update Test to test part of this patch: CreateUniqueUID
159 3. File was not close properly in gdcmDict
160 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
161 5. Use of const ref instead of copy (speed issue)
162 6. Remove temporary (duplicate) string in TranslateToKey
163 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
164 8. Do not repeat virtual in subclasses
165 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
167 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
168 * Apply first patch toward better string comparison when dealing with broken
169 DICOM files. Essentially the string could be padded with a space instead
170 of a null character as defined by standard
172 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
174 because never used... and in the same time, that's remove some memory leaks
176 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/gdcmFile.cxx : now delete the PixelConvert instance.
178 * In examples and tests : change the type of image data variables from void*
179 to uint8_t*. Remmove all delete on image data variables
181 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
183 Verify the file pointer value before open the file, and if it's not null,
184 a verbose message is generated.
185 Close correctly the file when the file isn't considered dicom-like. The
186 correctly close is a call to CloseFile.
187 When closing the file pointer, test if its not null to close the file.
188 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
189 file. For an uncompressed image, the copied datas correspond in the least
190 case to the image size (calculated) or the image size specified in the
191 header. A verbose is generated if these two size mismatch
193 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
195 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
196 break under windows (with msvc6 compilation).
198 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
200 compiling with MSVC6)
202 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * Bugs fix for the Windows build with VC6
204 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
205 needed (only for projects required VTK). If the VTK is included in all
206 projects, there is conflicts with the jpeg lib of vtk when compiling the
207 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
208 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
209 when compiling the gdcm_wrap.cxx file (created by the compilation of the
211 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
212 (like it's already made for the cout use). Otherwise, conflict with the
215 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
216 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
218 - comments on the DicomDir::Method related usage added.
219 - now that we use the namespace gdcm, a lot of internal classes do
220 NOT need to be wrapped anymore.
221 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
222 DicomDir::Method) new example added.
224 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
225 * Improve string manipulation. I now inforce the notion of 'DicomString'
226 A DicomString can contain as many \0 as they want
227 and it is *always* of even length.
228 We only support odd length for very rare case.
229 And in the near future this should be removed.
231 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
232 * /binary_write/ gdcm source. Now even on big endian we are writting
233 little endian. This should -heopfully- fix some tests
235 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
236 * Now the dictionary is compiled into gdcm lib. This is a default
237 behavior, thus any dic file specified is picked before failback to
238 the one comiled into lib
240 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
241 * Change internals for gdcmDict. Don't use any 'new' any more.
242 This should definitely solve any leak problem, and we should be
243 as fast as before, as long as don't modify too much the dictionary.
245 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
246 * STYLE: ivars should start with a capital letter.
247 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
248 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
250 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
251 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
252 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
253 new 2004 dictionaries added (thanks to JPR).
254 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
255 * CLEANUP_ROUND (15) for gdcmPixelConvert
256 - RLEFrame::NumberFragments is now of type unsigned int
257 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
258 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
261 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
262 * Initial work in gathering all transfer syntax accessors. clearly
263 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
264 ivars, but only one transfersyntax (class) ivar with equivalent method on
267 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
268 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
269 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
270 discussed (plus I didn't like having a 2000 lines patch not commited)
272 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
274 * CLEANUP_ROUND (14) for gdcmPixelConvert
275 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
276 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
277 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
279 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
280 anymore and hence avoids storing a copy of PixelConvert::Decompressed
281 into File::Pixel_Data.
283 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
285 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
286 * CLEANUP_ROUND (13) for gdcmPixelConvert
287 Substituted File::ParsePixelData() with PixelConvert::Print() new
289 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
290 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
291 method to those classes.
292 - src/gdcmFile.[cxx|h]:
293 -- Added a ::Print() method.
294 -- PixelConverter is now a reference instead of a member.
295 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
296 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
298 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
300 collaboration diagram and inheritance diagram should be generated with
302 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
303 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
304 pointlessly wrapped (see
305 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
306 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
307 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
308 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
309 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
310 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
311 -- File::Initialise: PixelConverter setup moved away to
312 PixelConverter::GrabInformationsFromHeader()
313 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
314 interpretation moved away to PixelConverter::BuildRGBImage()
316 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
317 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
318 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
320 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
322 displayed on Win32 when a brutal abort() occurs (because of uncatched
323 exception). See TODO new entry of this commit for more on this.
324 * TODO added new entry.
325 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
326 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
327 - HandleColor is no longer called from gdcmFile.cxx
328 - gdcmPixelConvert.cxx clean up on method arguments and internal
329 variable names for semantical coherence.
331 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
332 * Finished lossless transition, not only do we now read all lossless jpeg
333 images, without the need of the Cornwell lib, but we do read them properly now
334 * To reduce code (well to avoid code duplication), I defined a common place
335 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
336 redefine symbols. This is not prefect but this the best solution I found for a
337 compilation time jpeg option.
339 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
340 * Update jpeg ijg lib to support lossless jpeg implementation
341 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
343 * Also added a special copyright for dcmtk since we use their bugfixes.
346 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
347 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
348 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
349 matters, as stated in warning note at begining of %include section).
350 * src/gdcmDicomDir*.[cxx|h]: coding style
351 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
352 * src/gdcmJpeg8.cxx: doxygen fix.
353 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
354 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
355 from File:: to PixelConvert::.
357 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
358 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
359 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
360 - more code moved away from File:: to PixelConvert::
361 - fat setup of PixelConverter set in place in File::Initialise.
363 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
364 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
365 namespace at the file system level. So now you should convert your examples
367 gdcmHeader -> gdcm::Header
368 It would be nice if people keep in mind to no open the namespace, since it
369 allows compilation on broken plateform which were defining common symbol in
370 the standart namespace (like LP, Unknown ...)
372 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
374 The JPEG fragments are now parsed at the same stage than the RLE
375 information. All code related to JPEG is now in gdcmPixelConvert:
376 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
377 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
378 export a gdcmFile:: method. Those are simply global functions
379 (for the time being this is better than having them attach to
380 either gdcmFile:: or gdcmPixelConvert::).
381 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
382 and stores the result in a gdcmJPEGFragmentsInfo.
383 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
384 code (among other stuff) moved away from gdcmFile:; to
387 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
388 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
389 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
390 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
391 clean up of RLE related code.
392 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
393 - src/gdcmRLE.cxx removed
394 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
395 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
396 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
397 * CLEANUP_ROUND (9) for gdcmPixelConvert
398 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
399 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
400 away from gdcmFile:: to gdcmPixelConvert::.
402 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
403 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
404 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
405 This is because Parse7Fe0 used to parse the pixels to compute the
406 length. This task was passed over to FindDocEntryLengthOB() a long
407 time ago, EXCEPT I had forgotten the OW case...
408 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
409 we just recylce the code for parsing RLE fragments and computing
411 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
412 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
413 with the retired Parse7Fe0().
414 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
415 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
417 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
419 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
420 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
421 - src/CMakeLists.txt: alphabetic order reodering + new entries.
422 * CLEANUP_ROUND (4) for gdcmPixelConvert
423 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
424 to return an unused length.
426 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
427 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
428 this should be cleanner from the plane view. The iostream are erally a pain
429 to use to do simple stuff.
431 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
432 * Redo the compilation of the ijg jpeg library. Now only one source is
433 necesseray. No need to rename file by hand what so ever. CMake handle the
434 copying of the file within different directory, configure header file to
435 modify some symbol. The only addition made to ijg wasd a mangle table so
436 that symbol are different wether we are within 8bits or 12bits.
438 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
439 * Added documentation of vtkgdcmReader on Website:
440 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
441 with it's binary name).
442 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
443 the Website to be more complete.
444 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
445 doxygenated documentation.
446 - Doc/DoxyVtkGdcmReaderExamples.txt added
447 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
448 DoxyVtkGdmReaderExamples.html )
449 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
450 * CLEANUP_ROUND (3) for gdcmPixelConvert
451 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
453 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
454 * CLEANUP_ROUND (2) for gdcmPixelConvert
455 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
457 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * CLEANUP_ROUND for gdcmPixelConvert:
459 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
460 - src/gdcmPixelStuff[h|cxx] removed
461 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
462 - src/CMakeLists.txt changed accordingly
464 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
465 gdcmVersion.py moved to newly created ATTIC related
466 gdcmPython/SetupOldies/ directory.
467 * Autotools clean up:
468 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
469 - autogen.sh configure.in acinclude.m4 python.m4 removed
471 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * src/*.cxx *.h Reference to License.htm fixed to License.html.
473 * Doc/CMakeLists.txt, doxygen.config.in: fix.
474 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
476 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * TODO updated with Mathieu suggestions. I proposed a template for
478 describing TODO entries and used it for new entries.
479 * Added Doc/Website/CodingStyle.html, Developpers.html,
480 DeveloppersPython.html, GdcmDataCvs.html and
481 DownloadVersion0_1.html, DownloadVersion0_3.html.
482 * Some Doc/*.txt Doxygen files (which do not really concern the
483 documentation itself, but the website) moved to html and
484 placed in directory Doc/Website:
485 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
486 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
487 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
488 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
489 * CMakeLists.txt changed accordingly.
490 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
491 DeveloppersPython.html
492 * INSTALL nows refers to Doc/Website/Installation.html
494 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
495 * Added Doc/Website directory, that contains a first raw version
498 2004-09-23 Jean-Pierre Roux
499 * FIX In order not to be poluted any longer by casting problems,
500 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
501 we can now delete[] it safely
502 * VoidArea is now called BinArea (less confusing name),
503 and all the methods called ...VoidArea... are now ... BinArea...
504 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
506 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
507 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
508 clear) TagHT, which is an inherited member of gdcmElementSet. It is
509 up to the destructor of gdcmElementSet to clean up TagHt and it's
512 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
513 * Test/CMakeLists.txt: update to follow gdcmData renamings.
514 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
516 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * ENH: added some utility method that builds a flat dictionnary
518 holding all the Dicom entries contained in the recursive structure
519 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
521 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
522 BuildFlatHashTable() that build a flat dictionary.
523 - src/gdcmElementSet.h: added a new private GetTag() accessor.
524 gdcmDocument is now a friend of gdcmElementSet.
525 - src/gdcmElementSet.cxx: clean up.
526 - Example/FlatHashTablePrint.cxx added.
527 - Example/CmakeLists.txt changed accordingly
529 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
530 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
531 moved away from gdcmDocEntrySet (since this class is an abstract class
532 acting like an interface). SQDepthLevel and BaseTagKey are now
534 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
535 and associated accessors. Doxygenation of the class.
536 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
538 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
539 Use SQDepthLevel accessor instead. ::Print() adapted.
540 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
541 - src/gdcmDocument.cxx changed accordingly.
543 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
544 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
545 - The following is the doxygen comment of the typedef declaration
546 of gdcmagKey in src/gdcmCommon.h:
547 gdcmTagKey is made to old an "universal" (as in URL, Universal
548 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
549 A dicom tag allways has a group and an element, but a set of tags
550 embeded in various (optionally nested) sequences and sharing
551 the same group and element all share the same (group, element)
552 "identifier". Hence the (group, element) cannot be used as an
553 identifier (in gdcm we shall refer to a "TagKey") of a tag.
554 In order to construct a proper tag identifier (i.e. a key) we
555 consider the following definition of a TagKey:
556 - let Group, Element be the string representation of the
557 group and element dicom tag members,
558 - let ItemNumber be the string representation of the integer
559 index of the considered item number of a sequence,
560 Let the key of a tag embeded in a sequence, noted SeqTag, be
562 /ItemNumber#Group|Element
563 where "/", "#" and "|" are characters acting as separators.
564 Then the general form of a gdcmTagKey is given by:
565 Group|Element<SeqTag>
566 where <SeqTag> means NO or many instances of SeqTag.
567 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
570 but the gdcmTagKey of a tag "embeded" is the first item of
571 a sequence, itself nested in the third item of a sequence is the
573 0004|1220/2#0008|0082/0#0008|0090
574 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
575 order to hold the new sequence compatible key. Previously, the
576 GetKey() method would look in the underlying gdcmDictEntry.
577 - src/gdcmDocEntry.cxx:
578 -- constructor now copies the underlying DictEntry key, in the local
580 -- ::Print: displays the member Key, instead of the (group, element).
581 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
582 - src/gdcmDocEntrySet.h:xi
583 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
584 -- now has a new BaseTagKey member.
586 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
587 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
589 This poses the problem with the semantics of the following lines
590 LoadEntryVoidArea(0x0028,0x1201); // R LUT
591 LoadEntryVoidArea(0x0028,0x1202); // G LUT
592 LoadEntryVoidArea(0x0028,0x1203); // B LUT
593 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
594 to the long FIXME note for what the problem is. Nevertheless in
595 order to get things working the dicom dictionary was altered !
596 Please fix things urgently...
597 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
598 information), see above note on moving the member VoidArea. Nevertheless
599 the following entries previously correctly set as US are now inproperly
601 0028 1201 OW IMG Red Palette Color Lookup Table Data
602 0028 1202 OW IMG Green Palette Color Lookup Table Data
603 0028 1203 OW IMG Blue Palette Color Lookup Table Data
604 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
605 of gdcmDocEntry moved to gdcmSeqEntry.
606 * src/gdcmSeqEntry.cxx: STYLE.
608 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
609 * Test/TestAllEntryVerify.cxx minor fix and added comments.
611 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
612 * gdcmPython/testSuite.py: all the test suite in python is now moved
613 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
614 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
615 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
617 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
619 to avoid inclusion recursion until STL is reached.
620 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
621 mecanism. errno.h is not included in gdcm anymore.
622 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
623 (gdcmFormatError now inherits from gdcmFormatUnexpected).
625 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
626 gdcmData/TestAllEntryVerifyReference.txt
627 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
628 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
629 exception_on_error parameter.
630 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
631 - vtk/vtkGdcmReader.cxx changed accordingly,
632 - Example/*.cxx and Test/*.cxx changed accordingly.
634 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
636 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
637 enable_sequences removed from gdcmHeader constructor and dependencies.
638 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
639 * gdcmPython/demo/PrintHeader.py: dummy fix.
640 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
641 skip_shadow removed from gdcmHeader constructor and dependencies.
642 * Example/*.cxx and Test/*.cxx changed accordingly.
644 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
645 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
646 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
648 2004-07-21 Jean-Pierre Roux
649 * FIX Now, Parsing and Printing a DICOMDIR do work!
650 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
652 2004-07-20 Jean-Pierre Roux
653 * FIX Some brain damaged headers have Zero-Lenght fields
654 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
656 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
658 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
659 variable (instance of gdcmDebug) by a definition macro, and the instance
660 is now in static in the gdcmDebug class
661 * src/gdcmSQItem.h : (FIXME) remove an undefined method
662 * Test/PrintAllDocument.cxx : bug fix in the result of the test
664 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
665 * WARNING: ctest now depends more tightly on gdcmData. You should
666 check out gdcmData properly for things to run smoothly...
667 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
668 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
669 we need the pixels not be loaded in order to use the ValEntry
670 that displays position and size).
671 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
672 This is a C++ based equivalent of gdcmPython/testSuite.py that should
673 be deprecated. If you have any doubts about the advantages of a
674 modern scripting language (read Python) versus grass root C++ (i.e.
675 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
676 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
677 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
678 Anyhow, consider documenting the gdcmData images in
679 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
681 * Test/CMakeLists.txt:
682 - now uses TestAllEntryVerify.cxx
683 - specific comments on oldACR00001.ima (now renamed in gdcmData
684 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
685 gdcmData/TestAllEntryVerifyReference.txt
688 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * src/*.[h|cxx] : typedef clean up
690 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
691 - TagKey renamed to gdcmTagKey (for external usage)
692 - VRKey renamed to gdcmVRKey (for external usage)
693 - removal of typedef duplication.
694 - Removed all unecessary inline keyword from class inline definitions.
695 - Some method|function(void) declarations replaced with method|function().
696 * src/jpeg/libijg12/jdhuff12.c:
697 - printf polluting ctest removed.
698 - TAB removal for comminting
700 - TestAllReadCompareDicom.cxx: added a test that compares all the
701 images in gdcmDataImages.h with corresponding images in
702 gdcmData/BaselineDicom/. When baseline images are not present
703 this test creates them.
704 Note: we need to validate each reference image, but before that
705 I'd like to rename them with a more explicit name...
706 - CMakeLists.txt: changed accordingly.
707 * Example/*.cxx: examples now only include gdcm.h (as opposed to
708 including each header needed).
710 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
711 * Test/*.cxx and Example/*.cxx: moved some examples away from the
712 test suite to the Example directory. Are concerned:
717 - TestWriteSimple.cxx
718 * Test/CMakeLists.txt: added some comments on reasons for black listing
719 image gdcmData/oldACR00001.ima
721 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
722 * Test/CmakeList.txt: removed the following from black list (to be coherent
723 with removal from gdcmData):
724 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
725 - gdcm-MR-PHILIPS-16.dcm
727 Added the following because after last cvs update, they cause
728 ctest -R TestReadWriteReadCompare
730 - gdcm-MR-SIEMENS-16-1.acr
732 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
733 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
734 new comments in this file) we temporarily (sigh) move to a weaker
736 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
737 we don't need to black list the following images anymore:
738 - 8BitsUncompressedColor.dcm
740 - US-PAL-8-10x-echo.dcm
741 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
742 fixes and the beautified code ;-)
743 This fixes the bug introduced in version 1.42 (when beautifying)
744 that made the parsing of 8BitsRunLengthColor.dcm unproper.
745 Note: ctest was blind to this bug (this means we need to still
746 improve the test suite). The bug could be detected by using
747 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
749 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
750 and by displaying the (garbage) produced file temp.XDCM...
752 2004-06-29 Jean-Pierre Roux
753 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
754 - replace by uggly but working old code :-(
755 A lot of things should be OK again.
756 It's really urgent to have a test suite that *tests*,
757 to prevent Frog's beautifying sessions to break all the stuff
758 (twice, withing a fortnigh ...)
760 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
761 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
762 redundancy) to added Test/TestReadWriteReadCompare.cxx
763 * Test/CmakeList.txt: because the compare test of
764 Test/TestReadWriteReadCompare.cxx fails, the following images are
765 black listed: - 8BitsUncompressedColor.dcm
767 - US-PAL-8-10x-echo.dcm
768 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
769 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
770 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
771 and ad-hoc kludge. This kludge is now removed, and on encountering
772 such an image (OB field brain damaged) we set errno. Then in
773 ::FindDocLength() we "fix" the length as being ALL what remains
774 in the file (until EOF). We then proceed, hoping for the best...
775 This fixes a SegFault in ShowDicom when trying to write such an
777 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
778 (because TestWriteRead breaks on it, after a non conformal commit?).
779 ctest now runs properly, except for MakeDicomDir (which was allways
780 broken) and the Python related stuff (still not fixed).
782 2004-06-24 Jean-Pierre Roux
783 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
784 FIX : Test/TestReadWrite now iterates on all the file names
785 (instead of infinite loop)
786 ENH : Test/TestWriteRead now iterates on all the file names
788 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
789 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
791 2004-06-24 Jean-Pierre Roux
792 FIX : - now Write drops LUT Descriptors and LUTs (if any)
793 when SamplesPerPixel =3
794 - now Write is no longer confused by
795 'BitsAllocated = 12" and 'BitsStored=12"
796 - "UN" value representation Elements are now written correctly
797 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
798 ENH : - now gdcmHeader has its own Write methods
799 (in order to split the job that has not to be done
802 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
803 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
804 loop on the same image until memory went out.
805 Note: this means we still have gobs of memory loss in PrintDocument
806 * src/gdcmDocument.cxx: fixes problem on parsing on file
807 gdcmData/16BitsJpegLosslessGrayScale.dcm.
809 2004-06-24 Jean-Pierre Roux
810 FIX : Write - All the Sequences and Sequence Item are now written
811 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
812 is added a the end, when necessary.
813 - A lot of brain-damaged images, that were read correctly are
814 now written correctly
815 - length compatible BinEntry are now loaded correctly
816 (even for odd groups)
817 Note : only Explicit Value Representation was checked.
818 (question : is implicit VR really necessary for gdcm ?)
820 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
821 * DEVELOPPER: added a proposition of coding style.
822 * src/gdcmDocEntry.h: removed every inline declaration (for test of
825 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
827 Use the gdcmDocEntry::Print() and Write() instead.
828 * src/gdcmDocument.cxx: bug fix.
830 2004-06-22 Jean-Pierre Roux
831 FIX : gdcmDocument.cxx
832 - Now we do recognize the JpegLossLess format (there was a misstyping in
833 code 'beautyfication' :-(
834 - Now we automaticaticaly load the Luts, if any
836 2004-06-22 Jean-Pierre Roux
837 In order : to write Sequences, whatever their imbrication level,
838 : to allow user to create his own Sequences
839 a lot of modif where necessary (adding, moving, or virtualising methods)
841 WARNING : save your own sources *before* cvs up !
844 ADD virtual void Write(FILE *fp, FileType filetype);
847 ADD virtual void Write(FILE *fp, FileType filetype);
848 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
851 ADD virtual void Write (FILE *fp, FileType filetype)=0;
852 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
853 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
854 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
855 ADD std::string GetEntryByName(TagName name);
856 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
858 std::string vr = "unkn",
859 std::string fourth = "unkn",
860 std::string name = "unkn");
861 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
862 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
863 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
864 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
865 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
866 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
867 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
868 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
871 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
872 ADD virtual std::string GetEntryByName (TagName tagName);
873 ADD virtual std::string GetEntryVRByName (TagName tagName);
874 REM virtual bool Write(FILE *, FileType);
875 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
876 FILE *_fp, FileType type);
877 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
878 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
879 REM virtual bool WriteEntries(FILE *_fp,FileType type);
880 REM virtual std::string GetEntryByName (std::string tagName);
881 REM virtual std::string GetEntryVRByName (std::string tagName);
882 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
883 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
884 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
886 std::string vr = "unkn",
887 std::string fourth = "unkn",
888 std::string name = "unkn");
889 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
890 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
891 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
892 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
895 ADD virtual void Write(FILE *fp, FileType filetype);
898 ADD virtual void Write(FILE *fp,FileType filetype);
901 ADD virtual void Write(FILE *fp, FileType filetype);
902 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
903 REM std::string GetEntryByNumber(guint16 group, guint16 element);
904 REM std::string GetEntryByName(TagName name);
907 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
909 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
910 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
911 The default constructor invoked by the line
912 gdcmHeader *f1 = new gdcmHeader( header );
913 was gdcmHeader::gdcmHeader(bool) instead of the expected
914 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
915 Hence the parsing wasn't executed... See also below.
916 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
917 as explicit constructor didn't do the trick to fix the above problem.
918 Could anyone explain why ?
919 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
920 properly calls gdcmValEntry::Print() (that was weed out from
921 code related to gdcmBinEntry).
923 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
924 * In order to fix memory leaks:
925 - Test/TestWriteSimple.cxx: added cleaning of free store through
927 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
928 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
929 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
930 (through the call to ::AddDicomDirMeta()) or the destructor
931 would crash when deleting uninitialized ::metaElems].
932 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
933 - src/gdcmDocument.cxx:
934 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
936 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
937 was causing memory leaks.
938 - src/gdcmSQItem.cxx:
939 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
940 cleanly handled with polymophism: sorry but my milage is low).
941 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
942 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
943 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
944 This avoids SegFaulting.
945 - src/gdcmSQItem.h: coding style.
947 - Test/TestWriteSimple still severely sucks. The output image content
948 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
949 damaged when displayed with vtkgdcmViewer.
950 - on memory leaks: TestWriteSimple leaks really less (see entry
951 of 2004-06-18 in Changelog file for the call to valgrind).
952 - on segfaults: ctest now passes all the tests but one (no more
954 * Erroneous leading white fix:
955 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
956 white[s] (as opposed to from >> xxx, that removes it [them].
957 - src/gdcmTS.cxx: ditto.
958 - gdcmPython/testSuite.py: dirty related kludge removed.
959 * src/*: remaining references to gdcmParser removed.
960 * src/*[cxx|h]: added copy[way]left header.
963 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * In order to fix writing of dicom files:
965 - Test/TestWriteSimple.cxx: a simpler example of writing.
966 - Test/CMakeLists.txt changed accordingly.
967 - src/gdcmDocument.cxx:
968 -- The destructor now recursilvely removes potential sequences.
969 -- Bug fix in ::IsJPEG2000()
970 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
971 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
973 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
974 to only declared) and build on top of
975 ::GetDocEntryByNumber(guint16, guint16).
976 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
977 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
978 for usage in destructor and treatement of promotion in
979 ::ReplaceOrCreateByNumber().
980 - src/gdcmSQItem.cxx: destructor should better handle his job.
981 Test/TestWriteSimple now runs (or at least it DOES something).
982 * We can now start hutting memory links. A good starting point is:
983 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
984 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
985 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
987 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
988 * Valgrind note: after Mathieu Malaterre teached me how to read
989 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
991 Using gcc, you can force the STL to use malloc and to free memory as
992 soon as possible by globally disabling memory caching.
993 With 3.2.2 and later, you should export the environment variable
994 GLIBCPP_FORCE_NEW before running your program.
995 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
996 simply vanish (it is still not clear to me, whether this means that
997 STL std::string leaks or if valgrind believes it leaks...).
998 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
999 running bin/gdcmTests makeDicomDir):
1000 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1001 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1003 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1004 SegFaulting (I drowned in DicomDir related code when trying to
1005 understand why the list is empty...).
1006 * src/gdcmDocument.h: first BSD license header try.
1007 * Doc/License.txt added.
1009 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1010 * src/gdcmDocument.[h|cxx]:
1011 - Clean up of the Transfer related predicates. They are now all based
1012 on new method isGivenTransferSyntax, that (should) handle properly
1013 the padding problem.
1014 - general clean up, simplification, and coding style.
1015 - Specific clean up of Parse7FE0() (umproperly named actually).
1016 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1018 2004-06-14 Jean-Pierre Roux
1020 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1021 - fix the display of SQItem ordinal number
1022 - add the GetSQItemByOrdinalNumber method
1023 - remove some useless never written private methods
1025 2004-06-14 Jean-Pierre Roux
1027 - adding a constructor taking a gdcmDocEntry as an input param
1028 - ReplaceOrCreateByNumber now returns :
1029 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1030 a gdcmValEntry * if a string value is passed as a param
1032 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1033 according to the param type (no longer sets a gdcmDocEntry)
1034 - GetValEntryByNumber, GetBinEntryByNumber added
1035 - NewValEntryByNumber and NewBinEntryByNumber added
1037 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1039 - GetSQItemNumber and SetSQItemNumber added, to provide
1040 a (relative) Item identier inside a given Sequence
1041 \warning : some pb remaining around this number
1043 - AddEntry now takes the Item Number as a param
1045 - adding a constructor taking a gdcmDocEntry as an input param
1047 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * Memory leak hunt with the following command:
1049 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1050 --show-reachable=yes gdcmTests PrintDocument
1051 It looks like many (all?) leaks are due to the STL (or a bad usage
1052 of the STL. The lines producing the leaks now have a comment with
1053 a "MEMORY LEAK" tag: you can retrieve them with
1054 grep "MEMORY LEAK" src/*
1055 Here are two typical examples which I can't help fixing:
1060 char * test = "babo";
1061 name = test; //// <--- valgrind detects 960 bytes lost in
1062 //// call to std::string::operator=(char const*)
1063 name.clear(); //// Doesn't help !
1071 std::cout << "Type a bunch of characters followed by RETURN: ";
1072 getline(std::cin, line); //// <--- valgrind dectects a loss
1073 //// of 1320 bytes in call to
1074 /// std::basic_istream<>& std::getline<>
1080 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * src/gdcmHeader.[cxx|h]:
1082 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1083 and related, moved away to gdcmDocument.
1084 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1085 the corresponding protected accessors of inherited class
1086 gdcmDocument, removed ! As a consequence gdcmFile had to be
1087 declared friend of class gdcmDocument (see below).
1088 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1089 - Clean up of undefined or unused methods.
1090 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1091 account the changes to gdcmHeader.h).
1092 * src/gdcmDocument.h:
1093 - gdcmFile is now a friend class (in order to take into account the
1094 changes to gdcmHeader.h).
1095 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1096 (see changes to gdcmHeader.h).
1097 - Accessors (reading on the form GetEntry*) are now public.
1098 - Clean up of undefined or unused methods.
1099 * src/gdcmDocument.cxx:
1100 - adaptation to changes to gdcmDocument.h
1101 - ::OpenFile now writes a verbose message when file cannot be opened.
1102 - some std::string properly set to VRKey
1103 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1104 references to gdcmDocument.
1105 * Test/TestFindTags.cxx: changed accordingly to above changes.
1106 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1107 cvs repository gdcmData.
1109 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1110 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1111 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1112 conflicts with gdcmValEntry::voidArea.
1113 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1114 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1115 Value representation between StringRepresentable and BinaryRepresentable.
1116 * src/gdcmDocument.cxx:
1117 - method ParseDES: proper indentation restored and usage of
1118 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1119 - method LoadDocEntry: the fingerprint left in the SetValue() of
1120 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1121 removed. Reverting to previous code segment with the proper
1122 dynamic_cast< gdcmValEntry* >.
1123 Note: this was (partially) breaking the python test suite
1124 (gdcmPython/testSuite.py) that made usage of the above
1125 fingerprint to check presence of "Pixel Data".
1126 * src/gdcmDocEntry.h: coding style.
1127 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1128 now taken into account.
1129 * gdcmPython/gdcm.i: adaptation to the new internal representation
1130 of gdcm (exit gdcmParser, hello gdcmDocument).
1131 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1133 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1134 anymore, but instead prints the loaded Python dictionary.
1135 * .... alas, the python testSuite is still broken.
1137 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1138 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1140 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1141 * src/gdcmUtil.h : export methods
1143 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1144 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1146 * Initial addition of automatic python testing
1147 * Initial addition of automatic image comparison
1149 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1150 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1151 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1153 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1154 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1155 * Test/ShowDicom.cxx : bug fix for msvc compilation
1156 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1158 2004-05-04 Jean-Pierre Roux
1159 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1160 new concepts (and new classes) :
1161 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1162 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1163 - Sequence Doc Entries (gdcmSeqEntries)
1164 a Sequence is composed of Items.
1165 Each item is a set of Doc Entries (this is recursive)
1166 The non uniqueness of the 'Dicom tag' is due to this recursivity
1167 (never taken into account)
1168 Our unability to add a new 'entry' in the header
1169 at the proper location (neither in the H-Table (map or multimap),
1170 nor in the Chained List is also due to this recursivity.
1171 Don't try, right now, to use/modify/compile these new sources :
1172 nothing is finished.
1173 We just commit all the stuff, 'as is', in order not to loose it.
1175 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1176 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1178 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1179 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1180 file prefix (SetFilePrefix)
1182 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1183 * Add a new test: ShowDicom, for now this is just the c++ version of
1184 checkRead.sh, later it will be able to compare the image read against a
1186 * Replace the DEBUG on the stack with a global entry in cmake interface:
1187 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1189 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1190 * Add an example subdir, with a real example on how to read + write a
1193 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1194 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1195 * Doc/CMakeLists.txt: the main page is now properly differentiated
1196 between the developper and user version.
1197 * Doc/doxygen.config.in: dropped search related obsolete flags
1198 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1200 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1201 * DEVELOPPER: added some helpfull comments for compile/test/install
1204 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1205 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1206 src directory, now generated in the build dir.
1207 2. Tests as mentionned smarter
1209 4. Add a new method in gdcmDict that return the PubDict by name
1210 this is interesting for 3rd party lib like ITK,
1211 where we could set the institution name / patient name...
1213 * ENH: 1. Now the test suite is working for real
1214 2. All binaries are now output in the gdcm-bin directory
1215 (this was not true before)
1217 2004-04-28 Jean-Pierre Roux
1218 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1219 SeQuence indented printing of Dicom Header.
1220 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1221 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1222 Computation of SQDepthLevel is now part of gdcmHeader constructor
1223 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1224 tree-like structure of a Dicom Header.
1225 * FIX Test code cleaning
1227 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1228 * ENH: Adding automatic testing
1229 1. Need a DartConfig.cmake to submit to public
1230 2. Add a test driver gdcmTest.cxx
1231 3. gdcmTestMain, an helper for the main test driver gdcmTest
1232 4. Files in Test don't have a main anymore, this becomes interesting
1233 when we add more and more tests, thus dsw don't have to load
1235 * ENH: Adding a GDCM_DATA_ROOT for testing
1236 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1237 one file instead of seven + some small cleanup
1239 2004-04-22 Jean-Pierre Roux
1240 * ENH Minor changes to the Print() methods.
1241 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1242 Header printing. Example given with :
1243 > PrintHeader fileName 2 new
1244 (SQ based tree-like structure still to be done for the Header ...)
1246 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1247 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1248 1. I have added some unsigned where needed
1249 2. Some function parameter not used -> (void)
1250 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1251 4. g++ don't like character '\' in comment
1252 5. #define jpeg_create_decompress jCreaDecompress
1253 this really need to be fixed
1254 6. virtualize destructor of gdcmObject ... leakage
1255 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1256 this also really need to be fixed
1257 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1258 remove compression file
1259 (as we only do decompression, right ?)
1260 * ENH: Change malloc/calloc/free with c++ equivalent
1262 2004-04-21 Jean-Pierre Roux
1263 * FIX gdcmHeaderHelper::GetXSpacing
1264 when a single value is found (bug ?), xpacing is now
1265 defaulted to yspacing
1267 2004-04-19 Jean-Pierre Roux
1268 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1269 * ENH add parameters :
1270 bool exception_on_error = false,
1271 bool enable_sequences = false,
1272 bool ignore_shadow = false
1273 to the gdcmFile constructors to be full gdcmParser compliant
1274 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1275 to allow reading of PAPYRUS 3.0 files
1277 2004-04-06 Jean-Pierre Roux
1278 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1280 2004-04-02 Jean-Pierre Roux
1281 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1282 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1283 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1285 2004-03-30 Jean-Pierre Roux
1286 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1287 for ACR file, written out as DICOM files (hope so...)
1289 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1290 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1291 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1292 moved to base class gdcmParser and only the specialisation is kept
1294 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1295 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1296 already does the job.
1297 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1298 (to be consistent with gdcmParser::WriteEntries).
1300 2004-03-30 Benoit Regrain
1301 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1302 upate of the object's instance. It's passed to 2 in the unfavorable
1303 case : one in the ExecuteInformation, one in the ExecuteData
1305 2004-03-29 Jean-Pierre Roux
1306 * ENH : Check on file type to be written moved
1307 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1308 * FIX : gdcmObject::ResetBoundaries now stops properly
1309 when end-of-list is reached
1310 : gdcmVersion modified (as Benoit Regrain asked)
1312 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1313 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1314 * src/gdcmUtil.cxx: added forgotten iostream include.
1315 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1316 equivalent to ExplicitVR in existing code).
1318 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1319 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1320 now contains all the gdcmGlobal related code.
1321 * minor coding style and doxygenation changes.
1323 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1324 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1325 now contains all the Debug related code.
1326 * minor clean-up of includes in src/*.cxx
1327 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1328 CreateCleanString) removed.
1329 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1330 * Doc/DoxyMainPageUser.txt added.
1331 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1332 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1333 src/gdcmDirList.cxx)
1335 2004-03-24 Jean-Pierre Roux
1336 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1338 2004-03-23 Jean-Pierre Roux
1339 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1340 big endian made volumes
1341 * ENH Now gdcmParser constructor and destructor are protected to forbid
1342 end user to instanciate class gdcmParser
1343 (only gdcmHeader and gdcmDicomDir are meaningfull)
1345 2004-03-22 Benoit Regrain
1346 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1347 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1348 gdcmSerie to gdcmDicomDirSerie
1350 2004-03-19 Jean-Pierre Roux
1351 * ENH Now the tree-like structure describing a DICOMDIR comming from
1352 an already existing DICOMDIR file is consistent with
1353 the home-made tree-like structure build ex-nihilo
1354 or build from the files held (recursively) in a Directory
1355 functions gdcmDicomDir::CheckBoundaries()
1356 gdcmObject::SetBoundaries() added
1358 2004-03-17 Jean-Pierre Roux
1359 * REM (Eric Boix bug) : removal of meaningless
1360 gdcmDicomDirImage::NewImage function.
1361 * FIX now file names and directory name are written properly in the
1363 * FIX now gdcmDicomDir constructor may be call without any trick
1366 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1368 of gdcmDicomDirImage::NewImage as empty function.
1370 2004-02-28 Jean-Pierre Roux
1371 * ENH add gdcmDicomDir:NewPatient
1372 add gdcmDicomDirPatient:NewStudy
1373 add gdcmDicomDirStudy:NewSerie
1374 add gdcmDicomDirSerie:NewImage
1375 to allow making gdcDicomDir object.
1376 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1377 (as opposite to the gdcmHeader chained list)
1379 2004-02-11 Benoit Regrain
1380 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1381 when using from python
1383 2004-02-10 Benoit Regrain
1384 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1385 * FIX : in gdcmDicomDir when the directory is empty
1386 * ENH : add callback and methods to get the progression of dicomDir
1389 2004-02-06 Jean-Pierre Roux
1390 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1391 - GDCM_META added to gdcmDicomDirType
1392 - class gdcmMeta created
1393 * ENH : - A brief summary is now displayed at the beginning of
1394 'testDicomDir' to help disaster magnitude estimation
1395 * REM : Now useless Test/explDICOMDIR.cxx
1397 2004-02-05 Benoit Regrain
1398 * ENH : add methods in gdcmObject to get the hash table or the list of
1400 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1401 * FIX : wrapping python for TagHeaderEntryHT
1403 2004-02-04 Benoit Regrain
1404 * FIX : even length for some strings when writting the dicom dir
1405 * FIX : sort the images in the dicom dir
1406 * FIX : Bug fix for python use of dicom dir
1407 * ADD : a python demo
1409 2004-02-04 Jean-Pierre Roux
1410 * FIX : Final solution (?) for icone embedded images
1411 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1412 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1413 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1414 gdcmData/gdcm-MR-SIEMENS-16.acr1
1415 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1416 to make full checking easier
1418 2004-02-04 Benoit Regrain
1419 * FIX : WriteEntries : coding style & logic in parameters
1420 * FIX : Set the elements to create the DicomDir in a dictionary file
1422 2004-02-03 Benoit Regrain
1423 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1424 * gdcmDicomDir : add the load of directory
1425 * Bug fix and print add-on
1427 2004-02-03 Jean-Pierre Roux
1428 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1429 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1430 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1431 * FIX gdcmParser.cxx : 'group length' elements are now considered
1432 as integers, even for shadow groups, when file is Implicit VR
1434 2004-02-02 Jean-Pierre Roux
1435 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1437 of the last synonym :-(
1438 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1440 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1441 * FIX taking into account the possible 7fe0,0010 multiplicity
1442 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1443 to allow removal of references to 7fe0,0010, to deal with
1444 ACR-NEMA images, when 0028,0200 is meaningfull
1446 2004-01-31 Jean-Pierre Roux
1447 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1448 no longer writes 'Un' on disk
1449 * FIX SQ elements with actual length are now dealt with corectly
1450 * FIX gdcmFile::WriteBase make the difference, for color images, between
1451 the length (for Palette expanded images)
1452 and Raw Length (non expanded image + Palette)
1453 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1454 (that broke Write). Replaced by UL.
1455 Aware user will reload the field if he
1456 thinks it's necesssary
1458 2004-01-30 Jean-Pierre Roux
1459 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1460 when 'dirty Acr' is found, to be compliant with the new
1461 IsReadable() methods.
1463 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1464 (no DOUBLE images in kosher DICOM,
1465 but so usefull for people that miss them ;-)
1467 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1468 DICOMDIR related utilities (not checked as Windoze compliant)
1470 2004-01-28 Jean-Pierre Roux
1471 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1473 2004-01-27 Jean-Pierre Roux
1474 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1475 to allow skipping the shadow elements, to save memory space.
1476 The TRUE value for this param has to be used
1477 with a FALSE value for the 'enable_sequence' param.
1478 ('public elements' may be embedded in 'shadow Sequences')
1479 * gdcmHeader methods now deal with 'embedded icones images' in the header
1480 (even when an 'icone image sequence' is announced by the
1481 element (0x0088,0x0200), but there is NO icone at all ...
1483 * gdcmHeader sometimes Image Location value doesn't follow
1484 the supposed processor endianity (see gdcmData/cr172241.dcm).
1487 * gdcmHeader add the method
1488 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1489 to get *all* the Header Entries with the same tag.
1490 GetHeaderEntrySameName is probabely *useless*
1491 (no meaning : Name is *not* an identifier within the Dictionnary)
1493 2004-01-26 Benoit Regrain
1494 * Bug fix in the print of hexadecimal representations. Remove long fields
1495 in the print and add a third level of print to print them
1497 2004-01-23 Benoit Regrain
1498 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1499 * Bug fix on test suite after remove the strip made on not string fields
1500 * Split the IsReadable method between gdcmParser which test that the file
1501 is dicom and gdcmHeader which test that it's an image file
1503 2004-01-22 Benoit Regrain
1504 * DicomDir : clean code, add methods, set variables in protected or private
1505 * gdcmUtil : bug fix for the clean string method
1507 2004-01-19 Benoit Regrain
1508 * Add the use of shadow dictionaries
1509 * bug fix and coding style
1511 2004-01-19 Benoit Regrain
1512 * src/gdcmFile.cxx : bug fix concerning the close of file
1513 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1514 * Add the update of header entries using the shadow library
1516 2004-01-19 Benoit Regrain
1517 * removal of file gdcmHeader2.cxx
1518 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1519 inheriting from gdcmParser. This split is to prepare the integration
1520 of dicom dir parsing
1521 * bug fix under python
1523 2004-01-16 Jean-Pierre Roux
1524 * REM removal of class gdcmHeaderEntrySet
1525 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1526 * ADD add file gdcmHeader2.cxx
1527 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1529 2004-01-15 Benoit Regrain
1530 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1531 entries created while parsing the header. Thus, they will be destroyed
1532 when the gdcmDictSet will be destroyed
1533 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1536 2004-01-15 Benoit Regrain
1537 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1538 made a fatal error because of the memory release at the end of program.
1539 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1540 some memory and vtk seems to have some problems with that.
1541 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1543 2004-01-14 Benoit Regrain
1544 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1545 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1546 * src/*.[h|cxx] : make changes due to class name changes
1547 * gdcmPython/demo/*.py : bug fix due to method names
1549 2004-01-13 Benoit Regrain
1550 * src/*.[h|cxx] : coding style
1551 * vtk/*.[h|cxx] : coding style
1553 2004-01-13 Benoit Regrain
1554 * gdcmPython/testSuite.py : test the readable flag of file for tests
1555 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1556 It's lied to the stl compilation by MSVC (windows, always windows...)
1557 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1559 2004-01-12 Benoit Regrain
1560 * src/*.h : add comments
1561 * src/gdcmDictSet.h : set the method BuildDictPath in public
1562 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1563 directly setted in the source code
1564 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1567 2004-01-09 Benoit Regrain
1568 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1569 * setup.py : use a reference to gdcmVERSION
1571 2004-01-07 Benoit Regrain
1572 * Modification to compile with the distutils.
1575 2003-12-10 Benoit Regrain
1576 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1577 can use a gdcmHeaderHelper to load datas
1578 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1579 made in the source code
1581 2003-12-10 Benoit Regrain
1582 * Update Windows projects and .cvsignore files
1584 2003-11-12 Jean-Pierre Roux
1585 * ENH gdcmHeader constructor has one more parameter (default value : false)
1586 that allows the user to 'go inside' the SeQuences only
1588 gdcmElValSet:Print takes it into account
1590 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1591 * ENH: Update gdcmPython/CMakeLists
1592 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1593 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1595 2003-11-10 Jean-Pierre Roux
1596 * FIX : gdcmHeader::LoadElements is now based
1597 on the ListTag listElem member,
1598 not longer on the TagElValueHT tagHt member
1599 * ENH : PrintPubElVal shows (temporarily) both results,
1600 with the tagHt member and the listElem member.
1601 (it's easier to 'see' the problems when using Printheader)
1603 * FIX : old private member LgrElem is now splitted into
1604 ReadLength : Length actually found on disk (updated only
1605 if bug fixing is necessary), for internal
1607 UsableLength : Updated by FixFoundLength, to fix a bug
1608 or to allow Parser going on.
1609 Will allow to re-write a kosher header when a SeQuence
1610 with a length (not 0000) is found
1611 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1612 because gdcmElValSet::Add does not update ListElem
1615 2003-11-07 Jean-Pierre Roux
1616 * FIX misstyping in Transfert Syntax name table
1617 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1618 when they have an actual length (not 0000 nor FFFFF)
1619 (Nobody should care of it, but DICOMDIR explorers)
1621 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1622 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1624 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1625 * ENH: vtkGdcmReader now supports LUT !
1626 (vtkgdcmViewer for now is not able to use them though)
1628 2003-11-05 Jean-Pierre Roux
1629 * in testSuite.py : new files names for checking the package
1630 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1631 that returns the pixel area size to the *aware* (vtk) user
1632 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1634 2003-11-05 Benoit Regrain
1635 * in testSuite.py : Modify the rules for checking the paths
1636 : Explicit error messages
1637 * in __init__.py : Related modif
1639 2003-11-03 Jean-Pierre Roux
1640 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1641 to be used by aware (vtk) users that want to manage
1642 LUT (and no to turn the PALETTE image into an RGB pixels one)
1643 * GetPixelType now returns 8U for 24 Bits images
1644 (vtkGdcmReader compliant)
1646 2003-10-31 Jean-Pierre Roux
1647 * Removal of *all* gdcmData images and add them again
1648 in order to loose the 'history' of un-anonymised images
1650 2003-10-31 Jean-Pierre Roux
1651 * RMV : removal of useless jBitsInJsample.h
1652 for both 8 and 12 Bits JPEG Lossy Libraries
1654 2003-10-31 Jean-Pierre Roux
1655 * ENH : Add the functions gdcmFile::GetImageDataRaw
1656 gdcmFile::GetImageDataIntoVectorRaw
1657 that act as GetImageData and GetImageDataIntoVector
1658 except the making of an RGB Plane from Gray Plane + LUT
1659 Intended to aware (vtk) users who know how to manage
1662 GetLUTRGBA return a R,G,B,A LUT if any
1663 lgrTotaleRaw gives the 'Raw' length
1664 GetImageDataRaw returns the gray Plane
1665 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1666 (They stay Grey, just like with other Dicom viewers :-(
1668 2003-10-30 Jean-Pierre Roux
1669 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1671 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1672 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1673 being coherents dicom files.
1675 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1678 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1679 * ENH: Two steps is necessary to please VC++ compiler...
1680 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1681 * ENH: Add include dir to medcon lib
1682 * FIX: only one function is being exported for now !
1683 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1685 2003-10-29 Jean-Pierre Roux
1686 * adding gdcmHeader::GetLUTRGBA
1687 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1688 --> Mathieu, the modif u're waiting for is not yet committed
1689 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1691 2003-10-27 Jean-Pierre Roux
1692 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1693 00191113.dcm DermaColorLossLess.dcm
1694 MxTwinLossLess.dcm RadBWLossLess.dcm
1695 * ENH: For version prior to vtkImageViewer2 -r 1.19
1696 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1698 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1699 * Removal of ido stuff in CMakeLists.txt
1701 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1703 * FIX: remove a call to ->Modified ... see comments
1704 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1706 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1707 * FIX: Problem with path for libvtkgdcmPython
1708 * ENH: Try adding a search script for python site-package
1709 * RMV: Remove some file from medcon lib that are not necessary
1710 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1711 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1712 * FIX: More pragma disable fro VC++,
1713 I don't think I break something as it is also disable in VTK/ITK.
1714 But it fasten debug compilation time.
1716 2003-10-23 Jean-Pierre Roux
1717 * gdcm now deals with 16 Bits Run Length Encoded images
1718 (they are compressed as 2 planes images,
1719 one for the high Bytes, the other for low Bytes)
1721 2003-10-22 Jean-Pierre Roux
1722 * Now CheckRead takes into account :
1723 - the bugged 'Leonardo' Siemens images
1724 - the XA images, sent thru the burning VPRO station
1725 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1728 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1729 * FIX: When copying a Makefile.am to CMakeLists.txt
1730 one should remove the '\'
1732 2003-10-22 Jean-Pierre Roux
1733 * in gdcmData adding a bugged 'Leonardo' Siemens image
1734 (wrong lengths in header)
1735 OK with gdcm, KO with the other viewers :-)
1736 * add a GE dlx XA image, thru the VEPRO burning station
1739 2003-10-21 Jean-Pierre Roux
1740 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1741 for a brutal checking of vtkgdcmViewer compliance
1743 2003-10-21 Jean-Pierre Roux
1744 * add the files for 'xmedcon' Jpeg Lossless library
1745 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1747 2003-10-21 Jean-Pierre Roux
1748 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1750 2003-10-21 Jean-Pierre Roux
1751 * garbage Siemens 'Leonardo' images dealt with
1752 (the patch is easy to remove)
1753 * cosmetic changes to avoid warnings
1755 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1756 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1757 no need to press 'r' now.
1759 2003-10-20 Jean-Pierre Roux
1760 * upgrade of checkRead.sh checkWrite.sh according
1761 to new Jpeg Lossless decompressor
1762 * add US.3405.1.dcm, a genuine RGB medical file ...
1763 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1764 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1766 2003-10-15 Jean-Pierre Roux
1767 * general anonymisation in gdcmData
1768 * adding the 'color files' from
1769 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1770 * adding some well knowed bugged-header images
1771 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1772 waiting for their inclusion in Python testsuite
1774 2003-10-15 Jean-Pierre Roux
1775 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1776 no longer seg faults when file is not found
1778 2003-10-14 Jean-Pierre Roux
1779 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1782 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1783 * TODO: *.in file to genereate a UseGDCM later
1785 2003-10-14 Jean-Pierre Roux
1786 * Some supposed-to-be Dicom Images have no preamble.
1787 OpenFile takes it into account
1788 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1789 * Missing elements added in dicomV3.dic
1790 (just to be affraid : have a look at
1791 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1792 and do it again next year ;->
1794 2003-10-13 Jean-Pierre Roux
1795 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1796 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1797 But there are NOT. It's fixed !
1799 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1800 * FIX: "jpeglib.h" was not found on VC++
1801 * FIX: vtkgdcm was not being installed
1803 2003-10-10 Jean-Pierre Roux
1804 * ENH : OpenFile closes the file if it *really* doesn't look like
1805 an ACR-NEMA / DICOM one.
1806 * FIX : testWrite no longer writes an empty file if the source file
1807 is not gdcm Readable
1808 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1811 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1812 * FIX: CMake generate now documentation
1813 * ENH: out of source doc build !
1814 * ENH: Generate both user and dev documentation
1815 * ENH: Should work on windows too
1816 * ENH: Only one doxygen config.in file is needed
1817 * FIX: make install should be ok now on ùnix plateform
1818 * FIX: PATH to dictionary was wrong (missing /)
1819 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1821 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1822 * vtkGdcmReader is now able to read rgb dicom file.
1823 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1824 * added a gdcmViewer to vtk test, use mouse to control
1825 window level & window width
1827 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1828 * CMake-ification of gdcm, we have now two build system
1829 * FIX: on cygwin Wsock32 doesn't exist
1830 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1832 2003-10-06 Emanuel Ollart
1833 * FIX : compilation process wad broken.
1834 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1836 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1837 * change gdcmViewer -> vtkgdcmViewer
1838 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1840 2003-10-06 Jean-Pierre Roux
1841 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1842 ( e.g : well known GE images with a wrong elem length,
1843 : Philips MRI Images with a wrong Huffman table)
1844 * still to be done : allow the reading of bugged LEONARDO Siemens images
1846 2003-10-03 Jean-Pierre Roux
1847 * Odd length strings are padded with '\0' (not with spaces,
1848 to remain compliant with already defined strings,
1849 like Transfert Syntax UID and others)
1851 2003-10-03 Jean-Pierre Roux
1852 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1853 to allow displaying RGB images (not only by affim ;-)
1855 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1856 * vtkGdcmReader is now able to read rgb dicom file.
1857 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1859 2003-10-03 Jean-Pierre Roux
1860 * A few nasty patches to allow the reading of a lot of nasty images
1861 ( e.g : well known GE images with a wrong elem length,
1862 : Philips MRI Images with a wrong Huffman table)
1863 * still to be done : allow the reading of bugged LEONARDO Siemens images
1865 2003-10-03 Jean-Pierre Roux
1866 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1868 2003-10-03 Jean-Pierre Roux
1869 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1870 to allow displaying RGB images (not only by affim ;-)
1872 2003-10-03 Jean-Pierre Roux
1873 * gdcmFile::GetImageDataIntoVector now
1874 - deals with MultiFrames MultiFragments Run Length Encoded files
1875 - deals with YcBcR (YBR_FULL) files
1876 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1877 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1879 (no sample found :-(
1881 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1882 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1883 Two reasons: - clear things
1884 - third parties acces gdcm through header files, so won't
1885 suffer anymore VC++ complains
1887 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * add argv[1] in testvtkGdcmReader.cxx
1891 2003-09-24 Jean-Pierre Roux
1892 * The lines are now eigthy characters long.for
1893 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1895 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1897 char* to std::string. Thus, the use of strdup becomes useless. (see
1898 previous commis of Malaterre)
1899 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1900 before the last Malaterre's commit.
1902 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1903 * This commit should fix the Debug building under VC++, the problem
1904 was mainly a mixture of debug and release lib being loaded at startup.
1905 * I also remove a depency to a specific C function: strdup. Because I had
1906 to force the link to msvcrtd (whereas strdup is in libc).
1908 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1909 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1910 located in the gdcmCommon.h file. All use of reference of tha has been
1911 changed to now use the variable GDCM_UNFOUND.
1913 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1915 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1916 Dicom dictionary. The test suite can now be run again. Note:
1917 I'm note very happy with the " (RET)" changes. I believe this
1918 RETAINED comment should be dropped when parsing the dictionary.
1919 - PACKAGER corrected
1921 - AUTHORS updated and now in alphabetical order
1922 * Makefile.am now exports gdcm.dsw for Windoze users.
1924 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1925 * cygwin complains about missing std:: in subdir Test/
1927 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1928 * remove some methods that are now in gdcmHeaderHelper
1930 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * vtkGdcmReader set spacing and origin correctly
1933 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1934 * Fix a few delete/delete[] mismatch
1936 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1937 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1938 interpretation to data given by gdcmHeader. For instance there are
1939 heuristics to get informations (look at different places).
1940 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1941 sorting DICOM images based on different strategies.
1942 * modified Makefiles accordingly.
1944 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1945 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1946 when building in debug mode
1947 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1948 src/win32/gdcmdll.dsp
1949 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1951 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1952 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1955 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1956 * src/win32/libgdcmjpeg12.dsp was not dos format
1957 * src/win32/libgdcmjpeg12.dsp :
1958 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1959 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1961 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1962 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1964 * src/gdcmFile.cxx : bug fix in affectation type
1965 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1966 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1967 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1968 symbols... future problem ?
1970 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1971 * src/win32/libgdcmijpeg12.dsp was missing
1972 * modified gdcm.dsw accordingly
1974 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1975 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1977 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1978 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1979 commit of JPR (before his hollidays to facilitate our work).
1980 * setup.py : bug fix in code. Modifications made while the last commit
1981 of JPR. The code hasn't been tested before the commit... it's so
1982 useless to make that (for best programmer that is JPR) !!!
1984 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1985 * tagged the current version as Version0_3 (i.e. version 0.3)
1987 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1988 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1989 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1990 * *.dsp : modifications to use new libgdcmijpeg8 library
1991 * setup.py : bug fix on VTKPATH variable
1992 * PACKAGER : adding all concerning windows
1994 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1995 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1997 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1998 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1999 test suite reported error.
2000 * PACKAGER file added (describes what a packager must do when
2001 packaging a new release).
2002 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2003 * configure.in: upgraded version number to 0.3.0
2004 * fixing build of rpm (through rpm -ta):
2005 - Doc/Makefile.am exports proper doxygen files
2006 - src/jpeg/libijg8/Makefile.am exports the include files.
2008 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2009 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2010 * src/gdcmHeader.h : formatting code
2012 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2013 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2014 We were obtaining error message from vtk. Now, creation of file list
2015 is made in an internal list to prevent this problem.
2016 Bug fix when output is empty.
2017 Bug fix in update of progress value. Previous commit for this was a bad
2019 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2021 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2022 * src/gdcmHeader.h : added method to get the file name
2023 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2024 files. Added method to remove all files on the input
2025 Added FIXME comment concerning the bad parsing of header made by
2026 ExecuteInformation method (in ExecuteData method)
2028 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2029 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2030 when using make instal.
2031 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2032 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2034 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2035 * setup.py : adding include dir of jpeg lib to compile all sources
2036 * */Win32/*.dsp : JPR fix for windows compilation
2038 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2039 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2041 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2042 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2044 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * setup.py is again effective on un*x (takes into account the
2046 addon of the jpeg library)
2047 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2048 * Doc/Doxy* updated (includes above enhancements)
2049 * INSTALL now points to web documentation
2051 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2052 * src/gdcmHeader.h doesn't make unnecessary reference to
2054 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2056 * src/gdcm*.[cxx|h] :
2057 - to allow compilation with gcc 3.x
2058 -- clean up of STL usage (added explicit usage of std::)
2059 -- small fixes on exceptions.
2060 Note: linking not tested !
2061 - clean of doxygen comments to avoid warnings at documentation
2063 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2064 dependent convertion).
2066 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * Clean up of previous JPR garbage commit (not even commented in the
2069 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2070 - moved all jpeg related files from src to src/jpeg/libijg8, with
2071 addition/modification of Makefile.am and configure.in.
2072 - the testSuite is still brain damage (not guilty).
2074 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2075 * WrapVTK.py : modifications to get correctly vtk source files to
2077 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2078 (FileName -> Filename)
2080 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2081 * vtk/vtkGdcmReader.[cxx/h]:
2082 - UpdateProgress method should now be effective
2083 - removed the limitation on having only images loaded (as opposed
2085 - when building a stack of images/volume, a lesser number of
2086 gdcmHeader and gdcmFile instances should be used (hopefully
2087 accelerating things).
2088 - when building a stack of images/volumes, files which are not
2089 loadable (wrong path-filename, wrong permissions on existing file,
2090 or file not parsable by gdcm) are replaced with a black image
2091 in the stack (for the caller to notice the problem).
2093 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2094 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2096 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2097 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2098 between standard library (std) and vtk library (problems are found
2099 under Windows... thanks Windows !)
2101 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2104 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2106 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2107 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2109 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2110 * When compiling with distutils (see setup.py) the C++ compiler is
2111 called with different flags than the default ones (with automake).
2112 In order to fix all those warning, I compiled gdcm with the command
2113 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2114 and went for warning fixes:
2115 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2116 up from unused variables.
2117 - vtk/vtkGdcmReader.cxx: potential bug fix.
2118 * src/gdcmHeader.h: Doxygen warning cleanup
2120 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * gdcmPython/gdcm.i:
2122 - typemaps correction to take into account the systematic replacement
2123 of "using namespace std" with std:: prefix e.g. std::list,
2124 std::string... (cf changes of 2003-05-21).
2125 - gdcmGlob global variable of type gdcmGlobal (defined in
2126 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2127 exported to Python a as cvar.
2128 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2129 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2130 gdcmDictSet.GetPubDictTagNames() and
2131 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2132 C++ static methods).
2133 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2134 with the above changes.
2136 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2137 * setup.py, manifest.in : bug fix under linux
2139 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2140 * Modification of setup.py to compile vtk part too. Then, we have 2
2141 wrappers which must work with same distutils. For that, we have a
2142 generic distutils in distusiltsWrapping.py ; with :
2143 - build_extWrap class to wrap generically all extensions,
2144 - ExtensionWrap base class for all wrapping extension that contains
2146 - Wrapper interface which wrap sources
2147 + In WrapSwig.py we have extension and wrapper for Swig
2148 + In WrapVTK.py we have extension and wrapper for VTK
2149 * MANIFEST.in : modifications to consider vtk directory and new python
2150 files for compilation
2152 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2153 * Added python wrappers of vtkGdcmReader vtk class (see the
2154 source in vtk/vtkGdcmReader.cxx) :
2155 - vtk/Makefile.am now builds a library
2156 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2157 python library (as opposed to _gdcm.so wich are the python
2158 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2159 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2161 - configure.in has an additional flag --enable-vtk that needs
2162 to be set to enable compilation of vtk related code, that is:
2163 + vtk/vtkGdcmReader.so and
2164 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2165 + gdcmPython/vtkgdcmPython.so (see above)
2166 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2167 be read when compressed or when HighBit + 1 != BitsStored),
2168 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2169 the usage of the python wrapper of vtkGdcmReader vtk class.
2170 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2171 * src/*.[h] all occurences of stl classes are now prefixed with
2172 std::, and all occurences of "using namespace std;" where removed.
2173 This is to avoid pollution of global namespace in included files.
2174 Apparently vtk does not avoid this pitfall: when using both
2175 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2176 collision of various stl members (principally cout...).
2177 * gdcmPython/testSuite.py now cleanly removes temprory generated
2179 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2180 comply with above changes)
2182 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2183 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2184 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2185 vtk data structure (an image Flip was required).
2186 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2187 * cosmetic changes in documentation.
2189 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2190 * src/gdcmHeader.cxx: the constructor no longer exits when an
2191 unexisting file is given as argument.
2192 * The subdirectory Data (containing all the images used for the
2193 test suite) is not part of this repository anymore. A new module
2194 containing those images is now available at
2195 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2196 with the name gdcmData.
2197 All the python scripts (including the package initialisation file
2198 gdcmPython/__init__.py) were adapated to take this change into
2199 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2201 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2202 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2203 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2204 demo of the usage of this class.
2205 Compilation of this vtk part is only done when using the --enable-vtk
2206 at configure (or autogen.sh) stage.
2208 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2209 * More memory link related corrections and documentation fixes.
2211 - maximum info is obtained with a command of the form:
2212 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2213 --show-reachable=yes PrintHeader
2214 - the remaining reachable blocks seem to come from the STL
2215 allocation scheme through the usage of map and list. It looks
2216 like this memory cannot be freed but it is not a memory leak
2217 (in fact further invocation to the STL would recollect the
2218 unused memory allthough it cannot explicitely be freed).
2219 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2220 of displaying an image parsed with gdcm and displayed with VTK.
2221 Note: some images don't seem to work e.g.
2222 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2223 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2224 Allthough this weakens the semantics, it is a ditch attempt to
2225 make gdcm more thread friendly.
2227 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2228 * Memory link hunt (by using valgrind through the command
2229 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2230 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2231 gdcmHeader::_dicom_vr.
2232 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2233 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2235 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2237 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2238 * src/Makefile.am now exports all the necessary include files at
2242 * UpdateGroupLength replaced by new one
2245 * UpdateGroupLength re-written using H-Table
2246 (named UpdateGroupLengthNew untill checks are over)
2248 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2249 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2250 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2252 - gdcmHeader::GetPubElValSet removed.
2253 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2254 UpdateGroupLength, WriteElements, Write.
2255 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2256 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2257 carried the same semantics.
2258 - src/gdcmHeaderIdo.cxx changed accordingly.
2259 - gdcmFile::WriteBase now regroups all the codes from previous
2260 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2261 - enum FileType moved to gdcmCommon.h
2262 * src/gdcmHeader.cxx AddDefault trashed
2263 * gdcmGetXSize added
2264 * getimageDataSize now calls gdcmGetXSize
2265 * Test/*.cxx changed to agree with above changes
2267 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2268 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2269 (to avoid double call by end user).
2270 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2271 by end user, since gdcmHeader::gdcmHeader now handles it.
2273 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2274 * gdcm/Doc many doxygen changes:
2275 - Doxyfile now has two different versions, DoxyfileUsers that generates
2276 the html.users end users oriented documentation and
2277 DoxyfileDeveloppers that generates the html.developper developper
2278 oriented documentation.
2279 - README changed accordingly
2280 - requirement.txt removed (old design info moved to TODO).
2281 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2282 DoxyMainPage.txt, DoxyPython.txt provide more information.
2283 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2284 be updated by simply regenerating the docs with doxygen and copying
2285 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2286 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2287 all the tests in the form "if (<map>.count() >1)" were removed.
2288 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2289 ill-formed documentation sections.
2290 * src/gdcmHeader.cxx: ditto
2292 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2293 * setup.py fixed for un*x (needed macro for stdint.h)
2294 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2295 un*ces with sh-utils test utility.
2296 * gdcmPython/demo/test.py renamed to PrintHeader.py
2297 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2298 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2299 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2300 * src/gdcm*.cxx JPR's bad inclusion fixed.
2302 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2304 * gdcmPython/demo/test.py changed accordingly.
2306 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2307 * gdcmPython/Makefile.am fixed linking against libstdc++
2308 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2309 * Swig subdir (historical tests of swig version 1.3.17++) removed
2310 * Test/testChangeEntete.cxx some lines commented out in order to make
2312 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2313 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2315 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2316 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2317 hence the user doesn't need this explicit call.
2318 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2319 i.e. LoadElements() call removed.
2320 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2321 - src/Makefile.am declares the proper flag for g++.
2322 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2323 for adding user defined new tags.
2324 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2325 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2326 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2328 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2329 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2330 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2331 src/Makefile.am : the project should properly compile and install
2332 with the autotools, included the python wrappers part.
2333 * gdcm.spec.in : added a spec file for RPM packaging.
2335 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2336 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2338 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2339 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2340 to exported to the environement (see gdcmPython/testSuite.py
2342 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2343 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2344 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2345 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2346 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2348 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2349 * gdcmPython/__init__.py doesn't crash anymore when running in
2350 in InstallMode or PreInstallMode but with an environement given
2351 value of GDCM_DICT_PATH.
2352 * src/gdcmDictSet.[cxx/h] coding style.
2354 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2355 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2356 * src/gdcm.h general comments moved to TODO, and README
2357 * src/gdcm.h should now be seen as a user commodity (including it
2358 should suffice to fully use gdcm). It is nowhere including within
2359 any of the kernel files src/*.cxx and src/*.h.
2361 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2363 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2365 * src/gdcm*.cxx only include their corresponding include file
2366 (as opposed to gdcm.h)
2367 * gdcmPython/gdcm.i changed accordingly
2368 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2369 the autogen.sh generated "make snapshot" command to work.
2370 * autogen.sh removed history related references to crea package.
2372 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2373 * distutilsSwigCPlusPlus.py work around some swig portability
2376 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2378 was done in a last ditch attempt to get setup.py _really_
2379 operationnal. The python/gdcmPython layaout add the advantage
2380 of hidding away the python related distutils specific files
2381 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2382 Alas, the src directory was out of scope (i.e. it's relative
2383 position to setup.py was ../src) which made things impossible to
2384 handle (see previous version of python/setup.py). Crossing fingers...
2386 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2387 * python/setup.py now works on Un*x. (harder than I thougth)
2388 * python/distutilsSwigCPlusPlus.py can now have include files
2389 among the list of sources.
2391 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2392 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2393 * modifications in MSVC projects
2395 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2396 * As stated by the first lines of Test/ExceptionAndPython/README, it
2397 looks like we can move back to original usage of exception within
2398 src/gdcm* and hence remove the errno stuff that was introduced
2399 as a quick and dirty fixture of this problem (added to the TODO).
2400 * Doc/Doxyfile configuration file for Doxygen and corresponding
2401 README file for usage added.
2402 * Test/testWrite.cxx added. This new test comes from a split of
2403 test.cxx that is now reverted to its original purpous i.e.
2404 testing the proper parsing of a Dicom related file.
2405 testWrite.cxx concentrates on testing the IO part of gdcm.
2406 * Test/bug1.cxx (containing a bug on WIn32) added.
2407 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2408 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2409 whose purpose is to publish the content of the TagNames of the
2410 Dicom public dictionnary were not accessible without an
2411 instance of class gdcmHeader.
2412 - those methods are now static methods of gdcmDictSet and hence
2413 require no instances at all to be invocated.
2414 - within gdcmDictSet this change required to change some method
2415 to class methods (i.e. are now static) among which SetDictPath
2416 (renamed to BuildDictPath) and LoadDefaultPubDict.
2417 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2418 the above changes by calling the new method classes of gdcmDictSet.
2419 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2420 the above to be effective.
2421 * python/gdcmPython: in order to wrap properly the above changes
2422 for Python, swig version now needs to be > 1.3.17.
2423 * python/gdcmPython/Makefile fixed to adapt itself to new
2424 configure/make shema introduced by Johan Montagnat (thanks for the
2425 contribution). Alas this Makefile cannot be turned into a proper
2426 Makefile.am without some heavy changes in the configure.in
2427 (for python dectection).
2428 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2429 now avoids publishing the empty entries.
2431 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2432 * python/setup.py : bug fix concerning install under windows
2433 ExtraPath reused :-P
2434 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2436 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2437 * Dicts/dicomV3.dic : remove double spaces !!!
2438 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2439 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2442 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2444 method. Doxygenation.
2445 * src/gdcm.h clean up of JPR spurious comments.
2447 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * python/distutilsSwigCPlusPlus.py now properly collects the
2449 shadow classes generated by "swig -c++" (gdcm.py in our case)
2450 when using "python setup.py install".
2451 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2452 reexports the working classes.
2453 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2454 by the classical C errno scheme. This is to prevent an obscure
2455 behavior of the python wrappers when importing wxPython.wx prior
2456 to gdcmPython (which ended up in an abort call). An illustration
2457 of this oddity can be found in the Test/ExceptionAndPython
2458 subdir (see the README file). This problem probably due to
2459 an combination of g++ and dynamic loading.
2460 * added Test/ExceptionAndPython (see above)
2462 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2463 * Changed the layout of the python part to avoid bloating main
2464 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2465 i.e. the distutils arsenal. All the python related stuff is
2466 again in a python subdir, but the package itself is now in
2468 * setup.py was cleaned up:
2469 - pythonIncludePath removed
2470 - python setup.py bdist target is now functional.
2471 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2472 collision with other packages). gdcmPython/demo/*.py changed
2475 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * python subdir moved to gdcmPython (preparation of distutils packaging).
2477 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2478 distutils installer is operational.
2479 * - gdcmPython/__init__.py now properly loads the swig generated
2480 shadow classes (from gdcm.py).
2481 - gdcmPython/demo/*.py changed to import the package gdcmPython
2482 instead of gdcmPython/demo/load.py.
2483 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2485 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2487 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2488 entries within the associated public Dicom dictionary resp. the same
2489 information but sorted by the fourth field (PAT, IMG, DIR) of the
2491 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2492 are now in the "???" group.
2493 - python/gdcm.i changed accordingly,
2494 - python/demo/printGroupedPublicDict.py added, that gives an example
2495 of the above new functionalities in Python.
2497 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * src/gdcm.h, gdcmHeader.cxx:
2499 - historic references to glib's g_malloc and g_free (#defined)
2500 were definitively removed.
2501 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2502 * src/gdcmElValSet.cxx:
2503 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2504 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2505 - GetElValue(string) renamed to GetElValueByName.
2506 - Added GetElementByName(string).
2507 * src/gdcmHeader.cxx: added
2508 - GetPubElValRepByNumber(guint16, guint16)
2509 - GetPubElValRepByName(string)
2510 - GetShaElValRepByNumber(guint16, guint16)
2511 - GetShaElValRepByName(string)
2512 - GetShaElValByNumber(guint16, guint16)
2513 - GetShaElValRepByName(string)
2514 - GetElValRepByNumber(guint16, guint16)
2515 - GetElValRepByName(string)
2516 - GetElValByNumber(guint16, guint16)
2517 - GetElValRepByName(string)
2518 * Doc/requirements.txt added.
2520 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * Test/Makefile building now depends on the one of libgdcm.so
2522 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2523 pixel data) aware which enables finding the address (offset) of
2524 the pixel data of JPEG encoded DICOM files. This leaves only a single
2525 file in the testSuite whose pixel data address (offset) is unknown.
2526 * python/testSuite.py changed accordingly.
2528 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2529 * VC++ has some strong limitations when working with the STL, as stated
2530 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2531 "Also note that some STL containers (map, set, queue, list, deque)
2532 cannot be exported. [...]
2533 Some STL classes contain nested classes. These classes can not
2535 This is caused by a designed limitation that once a template
2536 class is instantiated, it can not be re-instantiated and
2538 Since our usage of map<> is ubiquitous in gdcm, this "designed
2539 limitation" of VC++ is a pitfall.
2540 Hence the Python wrappers of gdcm cannot be incrementally linked
2541 against the c++ dynamic library. The dirty but only workaround is
2542 to forget about incremental link of dynamic libraries and to generate
2543 the Python wrappers library with the inclusions of the underlying C++
2545 The following modifications concern this matter on Win32/VC++:
2546 - wrapping python correct with standalone wrapped dll (don't use separate
2547 dll under windows !!!!)
2548 - python21_d debug mode enabled (ask Frog how to use it :-)
2549 - NO problem with having an STL member of class for example string in C++
2550 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2551 - Python test of dcmlib in Python is ok under windows on a large set
2553 * removed glib references
2554 * typedef's inserted in gdcm.i for correct swig type management
2556 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * python/demo/*.py load.py extracted from test.py. Added explore.py
2558 that only displays required tags and testAll.py that parses all
2559 the files of the testsuite without using unittest.
2560 * python/testSuite.py other additional test on new files added.
2561 * Data/* new test files added accordingly to the testSuite.
2562 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2563 the vr in the file differs from the one of the dictionary.
2565 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2567 values, but limits itself to values which are below a user specified
2568 size (by default 1024 bytes).
2569 * python/gdcm.i : elements not loaded (because their size is above the
2570 user specified treshold) are exported with their TagKey as key of the
2571 python dictionary. This enables the testsuite to make some checks
2572 on the unloaded elements (since we have their offset and size).
2573 * python/testSuite.py
2574 - now tests for the existence and proper value of the pixel data
2575 - two new examples added.
2576 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2578 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2580 aware. See the strategy comments in gdcmHeader::FindeLength().
2581 * Test/test.cxx now accepts a filename as first argument.
2582 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2583 * python/testSuite.py changed to integrate test on above files.
2585 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2586 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2587 the vr was also RET.
2588 * python/testSuite.py more tests added.
2590 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2591 * python/testSuite.py unittest test suite added (uses Data)
2592 * Data/* dcm and acr files for the test suite.
2593 * glib dependance removed from un*x version. We now use ISO C99
2594 7.18 Integer types (see stdint.h)
2595 - python/Makefile, src/Makefile src/gdcm.h
2596 * src/ when an explicit vr (like dicom files) suddenly poped an
2597 implicit element we use to mark the underlying DictEntry of the
2598 concerned ElValue with "Implicit". This strategy was damageable
2599 too the public or provite dictionaries, since some of their vr
2600 would be changed. Since Header::FindLength heavily relies on the
2601 detection by Header::FindVR of falsely explicit elements, I
2602 added an extra ImplicitVr member to ElValue (boolean).
2603 The rest of the changes we the necessary adaptations.
2605 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2606 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2608 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2610 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * Adaptation for porting to VC++:
2613 o forced to use std namespace (for string to be known)
2614 o all class use __declspec export style on WIN32
2615 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2616 (in stdlib.h on Win32 but in std:: for gcc)
2617 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2618 variable GDCM_DICT_PATH.
2619 * src/gdcmHeader.cxx verbose comments made discrete.
2621 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2622 * python/gdcm.i: added a typemap that converts a C++ hashing table
2623 to native Python dictionary.
2624 * python/demo/test.py:
2625 - now uses the native dictionary for exploration of gdcmHeader.
2626 - takes an optional filename argument (the file to parse).
2627 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2628 PubElVals hashing table.
2629 * Dicts/dicomV3.dic removed error prone trailing spaces.
2631 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * Python wrapping process moved away from src/Makefile to
2633 newly created python/Makefile (as well as gdcm.i)
2634 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2635 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2636 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2637 from the environement variable GDCM_DICT_PATH (when existing).
2638 * src/gdcmDict::GetTag bug fix.
2640 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * Straightforward temporary fixes for swig to build the python wrappers.
2642 src/Makefile now has a python working entry [by working we mean
2643 that we can import de shadow classes without errors].
2645 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2646 * hashtest.cxx removed (since allready in Test)
2647 * src/gdcmlib.h renamed to src/gdcm.h
2648 * src/dcm.i renamed to src/gdcm.i
2649 * src/Makefile prepared for python wrapping
2651 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2652 * src/gdcmHeader.cxx :
2653 - Parsing of header is now separated from loading of element values
2654 (see gdcmHeader::LoadElements).
2655 - general clean up of hopefully all file access (creation of
2656 ReadInt16 and ReadInt32)
2658 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2659 * src/gdcmHeader.cxx :
2660 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2662 - SetLgrElem renamed to SetLength
2663 - GetLgrElem renamed to GetLength
2664 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2665 * src/gdcmElValSet.cxx fixed both GetElValue methods
2666 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2667 due to IdoDude was cleaned out.
2669 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2671 concentrates on finding the value representation (when it exists).
2672 RecupLgr now only finds the element value length, and it avoids
2673 returning the unecessary skL (skipped length).
2674 Also, offsetCourant was simply removed (with taille_fich) since
2675 it was redundant with the File position internals (by using
2676 ftell and fseek). This also made skL (see above in RecupLgr) usage
2678 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2679 on the libido specificities which are handled through class
2681 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2684 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * Truckload of changes. Parsing of header is barely functional
2686 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2688 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2689 * src/gdcmHeader.cxx many addons of low level methods
2691 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2692 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2693 and _IdDcmSWAP_LONG.
2695 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * This corresponds to all the changes decided at the meeting of
2697 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob