1 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
4 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
6 ValEntry, BinEntry, SeqEntry creation or replace
8 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
10 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
12 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
13 when specifying the VR
14 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
15 * src/gdcmDocEntry.cxx : amelioration of print
17 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr
18 * ADD : Add the method Util::IsCurrentProcessorBigEndian
19 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
20 * ADD Method Document::ComputeGroupLength
21 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
22 in order to allow further VR modification by user
23 * REM : removal of once-called method File::WriteBase
24 integration of its code in formerly one-line method File::Write
26 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
28 replace the different values "??", "Unkn", "Unknown".
29 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
30 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
31 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
32 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
34 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
37 * Set the gdcm::Base class to some Printable classes
39 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmFile.[h|cxx] : add the Print method
41 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
42 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
43 * src/gdcmDocument.h : remove the PrintLevel informations
44 * Example/PrintFile.cxx : use the new gdcm::File::Print
46 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
48 problems when compiling with the python wrapping
50 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
52 writting in ImplicitVR
54 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
55 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
56 JPEG decompression, especially when dicom frames are split into several
57 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
58 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
60 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmHeader.cxx : change the initialisation of default header.
62 Now, this header is readable by gdm, e-film, DicomWorks
64 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
66 Rename Decompressed to Raw
67 * Use the API changes in gdcm::File.
68 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
71 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
73 each added entry in the header. Replace the 'Planes' field by the 'Number
76 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
78 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
80 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
82 At this time, this image isn't readable by e-film... waiting JPR help to
85 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
87 DocEntry. Now use methods of the Document !
89 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * Test/ShowDicomSeq.cxx : bug fix
92 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
94 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
95 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
96 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
98 * Test/TestCopyRescaleDicom.cxx : remove unused variable
99 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
100 containing found sequences
102 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
105 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
106 Some fields in BinEntry must be copied to not seg fault when making the :
107 gdcm::File *copy = new gdcm::File( copyH );
108 and tests are now made on good variables
110 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
112 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
114 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
115 * Add vtkGdcmWriter example and test
117 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * Test/TestUtil.cxx : reformat the source code
119 * vtk/vtkGdcmReader.cxx : remove and change prints
120 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
122 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
123 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
125 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
127 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
129 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
131 by an eof to prevent all bad read of the file... and in this case, the
134 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * Example/Volume2Dicom.cxx : comment unused variables
136 * Test/PrintDicomDir.cxx : comment unused variables
137 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
138 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
139 method that is redondant with AddEntry.
140 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
143 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * Bug fix due my last commit (compilation under Windows).
145 * Example/Volume2Dicom : bug fix in the file and reformatting source code
146 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
148 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
150 - Remove printf / sprintf
151 - include iostream AFTER gdcm so we don't get warnings
152 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
154 - Also remove tons of include from header files, hopefully this should
155 speeup the compilation time, since it was becoming a dog slow.
156 - Remove gdcm.h as it include way too many files and slow down compilation
157 (plus it is not up to date)
158 - remove 'using namespace std' this is BAD !
160 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * Remove memory leaks on the DicomDir
162 * Remove some useless datas in DicomDirObject
163 * Add usefull methods in SQItem, to be complient withe the ElementSet
165 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
168 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
170 future, with convertion)
171 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
172 and ImageDataSize values. Remove the method to get the PixelReadConverter
173 from the output of the class
175 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
178 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
180 and vtkErrorMacro use.
181 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
183 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
186 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
187 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
188 The string leaves only in the fonction. So when we make a .c_str(), we
189 get the pointeur on the first element, element that will be destroyed
190 immediately after thee instruction.
191 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
192 file has been opened : the test must be made on the content of the
193 pointer and not directly on the pointer !
196 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
198 the python part recompiles
200 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
202 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
203 X session is killed (for my computer... it seems to not be identic on
206 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
208 avoid problems (otherwise, the difference test between the visible image
209 and the reference is incorrect. If the reference is greater than the
210 screen resolution, it's produce errors).
211 Can be used for only one image. Can be used with a visible flag.
212 * vtk/vtkGdcmReader.cxx : remove commented codes.
213 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
214 under windows at compilation
215 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
217 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
219 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
221 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
222 tests on the image size X, Y, Z
224 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
225 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
226 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
227 between the class name and the file name
229 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/ : fix compilation warnings for the Write method (2 different
231 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
232 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
233 variable... create a static method in gdcm::Document to access to
234 this variable content.
236 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
237 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
238 file, to be accessed by other files (like gdcmFile). Remove commented
239 code. Move the change of the header to the gdcmFile, using the
241 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
242 To be sure of that (and simplify calls), the Write of the header now
243 gets a file name and not a file pointer (std::ifstream).
244 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
245 DocEntryArchive. Remove all open of the written file
247 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
250 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
252 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
254 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
255 some corresponding methods. Write correctly the file and check before
257 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
258 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
259 is now on RGB datas (as before my last commit
260 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
262 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
264 Add a print information of the type of the entry
265 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
266 It was in the gdcmFile, and all write have been regrouped
267 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
268 Write correctly all dicom files (in decompressed mode only at this time)
269 * Test/ : test on files are now made using Raw datas and not color datas if
271 * Example/PrintFile.cxx : add more printings
273 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * Amelioration of code, remove some code copy. For the loading of
275 BinEntry (in gdcmDocument), add the test to verify if the file is already
278 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
280 remove a DocEntry in the header (push an empty DocEntry)
281 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
282 lines. Bug fix in the initialization of the PixelConvert and the
284 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
285 use in TestCopyDicom (now this test can run under windows... but fails)
286 * Test/TestCopyDicom.cxx : amelioration of the test :
287 - test the pixels written
288 - add test points to quickly find where is the error
289 - can set a file name input and output in arguments
290 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
291 amelioration of the test output
293 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
295 all replaced DocEntry's
296 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
297 Now, each needed DocEntry to modify is duplicated, modified and inserted
298 to the header using DocEntryArchive. Thus, after save, we can restore the
299 header initial state.
301 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
304 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
306 correct to copy it. The DictEntry is specified at the DocEntry creation,
307 then, it musn't change in the time.
308 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
309 header correctly. At this time, the change is only made for the first
310 level of the Document. In the future, it might consider sequences.
311 The change is made by replacing a DocEntry by an other that is created
312 outside the class. The old value is kept. When we restore the header
313 status, the added DocEntry is deleted and replaced by the old value.
314 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
315 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
316 set the write type to explicit VR, implicit VR or ACR. Add methods to set
317 the write mode to native, decompressed or RGB (but not used at this time)
319 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
321 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
323 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
325 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
327 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
328 set because already copied when copying the BinEntry's of the header
329 * Test/TestAllReadCompareDicom.cxx : remove warnings
331 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
332 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
333 Two problems appear when doing it :
334 - with the gdcmFile : when the GetImageData method is called, the pixels
335 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
336 datas (pixels). And each structure destruct the datas when it's
337 destructed. So we have two destructions for the same datas. To solve it,
338 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
339 datas or not. If it doesn't own datas, then they will not destroyed by
341 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
342 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
343 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
344 create a double destruction of the same DocEntry's. So, to solve it,
345 the TagHT is simply cleared and the DicomDir* elements are destroyed.
346 * TODO : add an entry concerning memory leaks in the DicomDir
348 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
349 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
350 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
353 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
355 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
356 after it have been deleted
358 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * FIX: src/* fix the doxygen warnings.
360 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
361 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
362 was erroneously defined with a size of 15 instead of 16. [many thanks
363 to Jean Michel Rouet for pointing out this bug].
365 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
366 1. Finish merging JMR patch for writting DICOM from scratch
367 2. Fix -hopefully- bug with MONOCHROME and space vs null character
368 3. Use const ref when possible
369 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
370 5. A few more comments
371 6. CreateUniqueUID can now be called without parameter"
373 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
374 * ENH: Slightly bigger patch:
375 1. Getting toward full integration of JMR patch for writting dicom from scratch
376 2. Update Test to test part of this patch: CreateUniqueUID
377 3. File was not close properly in gdcmDict
378 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
379 5. Use of const ref instead of copy (speed issue)
380 6. Remove temporary (duplicate) string in TranslateToKey
381 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
382 8. Do not repeat virtual in subclasses
383 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
385 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
386 * Apply first patch toward better string comparison when dealing with broken
387 DICOM files. Essentially the string could be padded with a space instead
388 of a null character as defined by standard
390 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
392 because never used... and in the same time, that's remove some memory leaks
394 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
395 * src/gdcmFile.cxx : now delete the PixelConvert instance.
396 * In examples and tests : change the type of image data variables from void*
397 to uint8_t*. Remmove all delete on image data variables
399 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
400 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
401 Verify the file pointer value before open the file, and if it's not null,
402 a verbose message is generated.
403 Close correctly the file when the file isn't considered dicom-like. The
404 correctly close is a call to CloseFile.
405 When closing the file pointer, test if its not null to close the file.
406 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
407 file. For an uncompressed image, the copied datas correspond in the least
408 case to the image size (calculated) or the image size specified in the
409 header. A verbose is generated if these two size mismatch
411 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
412 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
413 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
414 break under windows (with msvc6 compilation).
416 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
417 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
418 compiling with MSVC6)
420 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * Bugs fix for the Windows build with VC6
422 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
423 needed (only for projects required VTK). If the VTK is included in all
424 projects, there is conflicts with the jpeg lib of vtk when compiling the
425 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
426 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
427 when compiling the gdcm_wrap.cxx file (created by the compilation of the
429 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
430 (like it's already made for the cout use). Otherwise, conflict with the
433 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
434 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
436 - comments on the DicomDir::Method related usage added.
437 - now that we use the namespace gdcm, a lot of internal classes do
438 NOT need to be wrapped anymore.
439 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
440 DicomDir::Method) new example added.
442 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
443 * Improve string manipulation. I now inforce the notion of 'DicomString'
444 A DicomString can contain as many \0 as they want
445 and it is *always* of even length.
446 We only support odd length for very rare case.
447 And in the near future this should be removed.
449 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
450 * /binary_write/ gdcm source. Now even on big endian we are writting
451 little endian. This should -heopfully- fix some tests
453 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
454 * Now the dictionary is compiled into gdcm lib. This is a default
455 behavior, thus any dic file specified is picked before failback to
456 the one comiled into lib
458 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
459 * Change internals for gdcmDict. Don't use any 'new' any more.
460 This should definitely solve any leak problem, and we should be
461 as fast as before, as long as don't modify too much the dictionary.
463 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
464 * STYLE: ivars should start with a capital letter.
465 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
466 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
468 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
469 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
470 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
471 new 2004 dictionaries added (thanks to JPR).
472 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
473 * CLEANUP_ROUND (15) for gdcmPixelConvert
474 - RLEFrame::NumberFragments is now of type unsigned int
475 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
476 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
479 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
480 * Initial work in gathering all transfer syntax accessors. clearly
481 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
482 ivars, but only one transfersyntax (class) ivar with equivalent method on
485 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
486 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
487 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
488 discussed (plus I didn't like having a 2000 lines patch not commited)
490 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
491 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
492 * CLEANUP_ROUND (14) for gdcmPixelConvert
493 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
494 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
495 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
497 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
498 anymore and hence avoids storing a copy of PixelConvert::Decompressed
499 into File::Pixel_Data.
501 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
502 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
503 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
504 * CLEANUP_ROUND (13) for gdcmPixelConvert
505 Substituted File::ParsePixelData() with PixelConvert::Print() new
507 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
508 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
509 method to those classes.
510 - src/gdcmFile.[cxx|h]:
511 -- Added a ::Print() method.
512 -- PixelConverter is now a reference instead of a member.
513 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
514 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
516 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
518 collaboration diagram and inheritance diagram should be generated with
520 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
521 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
522 pointlessly wrapped (see
523 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
524 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
525 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
526 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
527 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
528 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
529 -- File::Initialise: PixelConverter setup moved away to
530 PixelConverter::GrabInformationsFromHeader()
531 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
532 interpretation moved away to PixelConverter::BuildRGBImage()
534 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
535 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
536 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
538 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
540 displayed on Win32 when a brutal abort() occurs (because of uncatched
541 exception). See TODO new entry of this commit for more on this.
542 * TODO added new entry.
543 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
544 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
545 - HandleColor is no longer called from gdcmFile.cxx
546 - gdcmPixelConvert.cxx clean up on method arguments and internal
547 variable names for semantical coherence.
549 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
550 * Finished lossless transition, not only do we now read all lossless jpeg
551 images, without the need of the Cornwell lib, but we do read them properly now
552 * To reduce code (well to avoid code duplication), I defined a common place
553 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
554 redefine symbols. This is not prefect but this the best solution I found for a
555 compilation time jpeg option.
557 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
558 * Update jpeg ijg lib to support lossless jpeg implementation
559 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
561 * Also added a special copyright for dcmtk since we use their bugfixes.
564 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
565 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
566 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
567 matters, as stated in warning note at begining of %include section).
568 * src/gdcmDicomDir*.[cxx|h]: coding style
569 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
570 * src/gdcmJpeg8.cxx: doxygen fix.
571 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
572 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
573 from File:: to PixelConvert::.
575 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
576 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
577 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
578 - more code moved away from File:: to PixelConvert::
579 - fat setup of PixelConverter set in place in File::Initialise.
581 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
582 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
583 namespace at the file system level. So now you should convert your examples
585 gdcmHeader -> gdcm::Header
586 It would be nice if people keep in mind to no open the namespace, since it
587 allows compilation on broken plateform which were defining common symbol in
588 the standart namespace (like LP, Unknown ...)
590 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
592 The JPEG fragments are now parsed at the same stage than the RLE
593 information. All code related to JPEG is now in gdcmPixelConvert:
594 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
595 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
596 export a gdcmFile:: method. Those are simply global functions
597 (for the time being this is better than having them attach to
598 either gdcmFile:: or gdcmPixelConvert::).
599 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
600 and stores the result in a gdcmJPEGFragmentsInfo.
601 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
602 code (among other stuff) moved away from gdcmFile:; to
605 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
607 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
608 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
609 clean up of RLE related code.
610 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
611 - src/gdcmRLE.cxx removed
612 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
613 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
614 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
615 * CLEANUP_ROUND (9) for gdcmPixelConvert
616 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
617 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
618 away from gdcmFile:: to gdcmPixelConvert::.
620 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
621 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
622 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
623 This is because Parse7Fe0 used to parse the pixels to compute the
624 length. This task was passed over to FindDocEntryLengthOB() a long
625 time ago, EXCEPT I had forgotten the OW case...
626 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
627 we just recylce the code for parsing RLE fragments and computing
629 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
630 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
631 with the retired Parse7Fe0().
632 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
633 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
635 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
636 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
637 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
638 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
639 - src/CMakeLists.txt: alphabetic order reodering + new entries.
640 * CLEANUP_ROUND (4) for gdcmPixelConvert
641 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
642 to return an unused length.
644 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
645 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
646 this should be cleanner from the plane view. The iostream are erally a pain
647 to use to do simple stuff.
649 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
650 * Redo the compilation of the ijg jpeg library. Now only one source is
651 necesseray. No need to rename file by hand what so ever. CMake handle the
652 copying of the file within different directory, configure header file to
653 modify some symbol. The only addition made to ijg wasd a mangle table so
654 that symbol are different wether we are within 8bits or 12bits.
656 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * Added documentation of vtkgdcmReader on Website:
658 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
659 with it's binary name).
660 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
661 the Website to be more complete.
662 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
663 doxygenated documentation.
664 - Doc/DoxyVtkGdcmReaderExamples.txt added
665 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
666 DoxyVtkGdmReaderExamples.html )
667 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
668 * CLEANUP_ROUND (3) for gdcmPixelConvert
669 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
671 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * CLEANUP_ROUND (2) for gdcmPixelConvert
673 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
675 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * CLEANUP_ROUND for gdcmPixelConvert:
677 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
678 - src/gdcmPixelStuff[h|cxx] removed
679 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
680 - src/CMakeLists.txt changed accordingly
682 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
683 gdcmVersion.py moved to newly created ATTIC related
684 gdcmPython/SetupOldies/ directory.
685 * Autotools clean up:
686 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
687 - autogen.sh configure.in acinclude.m4 python.m4 removed
689 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
690 * src/*.cxx *.h Reference to License.htm fixed to License.html.
691 * Doc/CMakeLists.txt, doxygen.config.in: fix.
692 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
694 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * TODO updated with Mathieu suggestions. I proposed a template for
696 describing TODO entries and used it for new entries.
697 * Added Doc/Website/CodingStyle.html, Developpers.html,
698 DeveloppersPython.html, GdcmDataCvs.html and
699 DownloadVersion0_1.html, DownloadVersion0_3.html.
700 * Some Doc/*.txt Doxygen files (which do not really concern the
701 documentation itself, but the website) moved to html and
702 placed in directory Doc/Website:
703 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
704 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
705 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
706 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
707 * CMakeLists.txt changed accordingly.
708 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
709 DeveloppersPython.html
710 * INSTALL nows refers to Doc/Website/Installation.html
712 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
713 * Added Doc/Website directory, that contains a first raw version
716 2004-09-23 Jean-Pierre Roux
717 * FIX In order not to be poluted any longer by casting problems,
718 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
719 we can now delete[] it safely
720 * VoidArea is now called BinArea (less confusing name),
721 and all the methods called ...VoidArea... are now ... BinArea...
722 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
724 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
726 clear) TagHT, which is an inherited member of gdcmElementSet. It is
727 up to the destructor of gdcmElementSet to clean up TagHt and it's
730 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
731 * Test/CMakeLists.txt: update to follow gdcmData renamings.
732 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
734 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
735 * ENH: added some utility method that builds a flat dictionnary
736 holding all the Dicom entries contained in the recursive structure
737 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
739 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
740 BuildFlatHashTable() that build a flat dictionary.
741 - src/gdcmElementSet.h: added a new private GetTag() accessor.
742 gdcmDocument is now a friend of gdcmElementSet.
743 - src/gdcmElementSet.cxx: clean up.
744 - Example/FlatHashTablePrint.cxx added.
745 - Example/CmakeLists.txt changed accordingly
747 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
748 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
749 moved away from gdcmDocEntrySet (since this class is an abstract class
750 acting like an interface). SQDepthLevel and BaseTagKey are now
752 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
753 and associated accessors. Doxygenation of the class.
754 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
756 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
757 Use SQDepthLevel accessor instead. ::Print() adapted.
758 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
759 - src/gdcmDocument.cxx changed accordingly.
761 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
763 - The following is the doxygen comment of the typedef declaration
764 of gdcmagKey in src/gdcmCommon.h:
765 gdcmTagKey is made to old an "universal" (as in URL, Universal
766 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
767 A dicom tag allways has a group and an element, but a set of tags
768 embeded in various (optionally nested) sequences and sharing
769 the same group and element all share the same (group, element)
770 "identifier". Hence the (group, element) cannot be used as an
771 identifier (in gdcm we shall refer to a "TagKey") of a tag.
772 In order to construct a proper tag identifier (i.e. a key) we
773 consider the following definition of a TagKey:
774 - let Group, Element be the string representation of the
775 group and element dicom tag members,
776 - let ItemNumber be the string representation of the integer
777 index of the considered item number of a sequence,
778 Let the key of a tag embeded in a sequence, noted SeqTag, be
780 /ItemNumber#Group|Element
781 where "/", "#" and "|" are characters acting as separators.
782 Then the general form of a gdcmTagKey is given by:
783 Group|Element<SeqTag>
784 where <SeqTag> means NO or many instances of SeqTag.
785 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
788 but the gdcmTagKey of a tag "embeded" is the first item of
789 a sequence, itself nested in the third item of a sequence is the
791 0004|1220/2#0008|0082/0#0008|0090
792 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
793 order to hold the new sequence compatible key. Previously, the
794 GetKey() method would look in the underlying gdcmDictEntry.
795 - src/gdcmDocEntry.cxx:
796 -- constructor now copies the underlying DictEntry key, in the local
798 -- ::Print: displays the member Key, instead of the (group, element).
799 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
800 - src/gdcmDocEntrySet.h:xi
801 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
802 -- now has a new BaseTagKey member.
804 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
805 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
807 This poses the problem with the semantics of the following lines
808 LoadEntryVoidArea(0x0028,0x1201); // R LUT
809 LoadEntryVoidArea(0x0028,0x1202); // G LUT
810 LoadEntryVoidArea(0x0028,0x1203); // B LUT
811 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
812 to the long FIXME note for what the problem is. Nevertheless in
813 order to get things working the dicom dictionary was altered !
814 Please fix things urgently...
815 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
816 information), see above note on moving the member VoidArea. Nevertheless
817 the following entries previously correctly set as US are now inproperly
819 0028 1201 OW IMG Red Palette Color Lookup Table Data
820 0028 1202 OW IMG Green Palette Color Lookup Table Data
821 0028 1203 OW IMG Blue Palette Color Lookup Table Data
822 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
823 of gdcmDocEntry moved to gdcmSeqEntry.
824 * src/gdcmSeqEntry.cxx: STYLE.
826 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
827 * Test/TestAllEntryVerify.cxx minor fix and added comments.
829 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * gdcmPython/testSuite.py: all the test suite in python is now moved
831 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
832 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
833 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
835 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
837 to avoid inclusion recursion until STL is reached.
838 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
839 mecanism. errno.h is not included in gdcm anymore.
840 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
841 (gdcmFormatError now inherits from gdcmFormatUnexpected).
843 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
844 gdcmData/TestAllEntryVerifyReference.txt
845 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
846 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
847 exception_on_error parameter.
848 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
849 - vtk/vtkGdcmReader.cxx changed accordingly,
850 - Example/*.cxx and Test/*.cxx changed accordingly.
852 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
853 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
854 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
855 enable_sequences removed from gdcmHeader constructor and dependencies.
856 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
857 * gdcmPython/demo/PrintHeader.py: dummy fix.
858 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
859 skip_shadow removed from gdcmHeader constructor and dependencies.
860 * Example/*.cxx and Test/*.cxx changed accordingly.
862 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
863 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
864 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
866 2004-07-21 Jean-Pierre Roux
867 * FIX Now, Parsing and Printing a DICOMDIR do work!
868 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
870 2004-07-20 Jean-Pierre Roux
871 * FIX Some brain damaged headers have Zero-Lenght fields
872 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
874 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
875 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
876 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
877 variable (instance of gdcmDebug) by a definition macro, and the instance
878 is now in static in the gdcmDebug class
879 * src/gdcmSQItem.h : (FIXME) remove an undefined method
880 * Test/PrintAllDocument.cxx : bug fix in the result of the test
882 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
883 * WARNING: ctest now depends more tightly on gdcmData. You should
884 check out gdcmData properly for things to run smoothly...
885 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
886 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
887 we need the pixels not be loaded in order to use the ValEntry
888 that displays position and size).
889 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
890 This is a C++ based equivalent of gdcmPython/testSuite.py that should
891 be deprecated. If you have any doubts about the advantages of a
892 modern scripting language (read Python) versus grass root C++ (i.e.
893 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
894 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
895 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
896 Anyhow, consider documenting the gdcmData images in
897 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
899 * Test/CMakeLists.txt:
900 - now uses TestAllEntryVerify.cxx
901 - specific comments on oldACR00001.ima (now renamed in gdcmData
902 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
903 gdcmData/TestAllEntryVerifyReference.txt
906 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
907 * src/*.[h|cxx] : typedef clean up
908 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
909 - TagKey renamed to gdcmTagKey (for external usage)
910 - VRKey renamed to gdcmVRKey (for external usage)
911 - removal of typedef duplication.
912 - Removed all unecessary inline keyword from class inline definitions.
913 - Some method|function(void) declarations replaced with method|function().
914 * src/jpeg/libijg12/jdhuff12.c:
915 - printf polluting ctest removed.
916 - TAB removal for comminting
918 - TestAllReadCompareDicom.cxx: added a test that compares all the
919 images in gdcmDataImages.h with corresponding images in
920 gdcmData/BaselineDicom/. When baseline images are not present
921 this test creates them.
922 Note: we need to validate each reference image, but before that
923 I'd like to rename them with a more explicit name...
924 - CMakeLists.txt: changed accordingly.
925 * Example/*.cxx: examples now only include gdcm.h (as opposed to
926 including each header needed).
928 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
929 * Test/*.cxx and Example/*.cxx: moved some examples away from the
930 test suite to the Example directory. Are concerned:
935 - TestWriteSimple.cxx
936 * Test/CMakeLists.txt: added some comments on reasons for black listing
937 image gdcmData/oldACR00001.ima
939 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
940 * Test/CmakeList.txt: removed the following from black list (to be coherent
941 with removal from gdcmData):
942 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
943 - gdcm-MR-PHILIPS-16.dcm
945 Added the following because after last cvs update, they cause
946 ctest -R TestReadWriteReadCompare
948 - gdcm-MR-SIEMENS-16-1.acr
950 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
951 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
952 new comments in this file) we temporarily (sigh) move to a weaker
954 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
955 we don't need to black list the following images anymore:
956 - 8BitsUncompressedColor.dcm
958 - US-PAL-8-10x-echo.dcm
959 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
960 fixes and the beautified code ;-)
961 This fixes the bug introduced in version 1.42 (when beautifying)
962 that made the parsing of 8BitsRunLengthColor.dcm unproper.
963 Note: ctest was blind to this bug (this means we need to still
964 improve the test suite). The bug could be detected by using
965 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
967 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
968 and by displaying the (garbage) produced file temp.XDCM...
970 2004-06-29 Jean-Pierre Roux
971 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
972 - replace by uggly but working old code :-(
973 A lot of things should be OK again.
974 It's really urgent to have a test suite that *tests*,
975 to prevent Frog's beautifying sessions to break all the stuff
976 (twice, withing a fortnigh ...)
978 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
979 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
980 redundancy) to added Test/TestReadWriteReadCompare.cxx
981 * Test/CmakeList.txt: because the compare test of
982 Test/TestReadWriteReadCompare.cxx fails, the following images are
983 black listed: - 8BitsUncompressedColor.dcm
985 - US-PAL-8-10x-echo.dcm
986 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
987 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
988 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
989 and ad-hoc kludge. This kludge is now removed, and on encountering
990 such an image (OB field brain damaged) we set errno. Then in
991 ::FindDocLength() we "fix" the length as being ALL what remains
992 in the file (until EOF). We then proceed, hoping for the best...
993 This fixes a SegFault in ShowDicom when trying to write such an
995 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
996 (because TestWriteRead breaks on it, after a non conformal commit?).
997 ctest now runs properly, except for MakeDicomDir (which was allways
998 broken) and the Python related stuff (still not fixed).
1000 2004-06-24 Jean-Pierre Roux
1001 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1002 FIX : Test/TestReadWrite now iterates on all the file names
1003 (instead of infinite loop)
1004 ENH : Test/TestWriteRead now iterates on all the file names
1006 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1007 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1009 2004-06-24 Jean-Pierre Roux
1010 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1011 when SamplesPerPixel =3
1012 - now Write is no longer confused by
1013 'BitsAllocated = 12" and 'BitsStored=12"
1014 - "UN" value representation Elements are now written correctly
1015 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1016 ENH : - now gdcmHeader has its own Write methods
1017 (in order to split the job that has not to be done
1020 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1021 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1022 loop on the same image until memory went out.
1023 Note: this means we still have gobs of memory loss in PrintDocument
1024 * src/gdcmDocument.cxx: fixes problem on parsing on file
1025 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1027 2004-06-24 Jean-Pierre Roux
1028 FIX : Write - All the Sequences and Sequence Item are now written
1029 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1030 is added a the end, when necessary.
1031 - A lot of brain-damaged images, that were read correctly are
1032 now written correctly
1033 - length compatible BinEntry are now loaded correctly
1034 (even for odd groups)
1035 Note : only Explicit Value Representation was checked.
1036 (question : is implicit VR really necessary for gdcm ?)
1038 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1039 * DEVELOPPER: added a proposition of coding style.
1040 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1043 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1045 Use the gdcmDocEntry::Print() and Write() instead.
1046 * src/gdcmDocument.cxx: bug fix.
1048 2004-06-22 Jean-Pierre Roux
1049 FIX : gdcmDocument.cxx
1050 - Now we do recognize the JpegLossLess format (there was a misstyping in
1051 code 'beautyfication' :-(
1052 - Now we automaticaticaly load the Luts, if any
1054 2004-06-22 Jean-Pierre Roux
1055 In order : to write Sequences, whatever their imbrication level,
1056 : to allow user to create his own Sequences
1057 a lot of modif where necessary (adding, moving, or virtualising methods)
1059 WARNING : save your own sources *before* cvs up !
1062 ADD virtual void Write(FILE *fp, FileType filetype);
1065 ADD virtual void Write(FILE *fp, FileType filetype);
1066 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1069 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1070 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1071 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1072 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1073 ADD std::string GetEntryByName(TagName name);
1074 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1076 std::string vr = "unkn",
1077 std::string fourth = "unkn",
1078 std::string name = "unkn");
1079 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1080 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1081 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1082 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1083 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1084 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1085 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1086 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1089 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1090 ADD virtual std::string GetEntryByName (TagName tagName);
1091 ADD virtual std::string GetEntryVRByName (TagName tagName);
1092 REM virtual bool Write(FILE *, FileType);
1093 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1094 FILE *_fp, FileType type);
1095 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1096 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1097 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1098 REM virtual std::string GetEntryByName (std::string tagName);
1099 REM virtual std::string GetEntryVRByName (std::string tagName);
1100 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1101 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1102 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1104 std::string vr = "unkn",
1105 std::string fourth = "unkn",
1106 std::string name = "unkn");
1107 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1108 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1109 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1110 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1113 ADD virtual void Write(FILE *fp, FileType filetype);
1116 ADD virtual void Write(FILE *fp,FileType filetype);
1119 ADD virtual void Write(FILE *fp, FileType filetype);
1120 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1121 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1122 REM std::string GetEntryByName(TagName name);
1125 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1127 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1128 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1129 The default constructor invoked by the line
1130 gdcmHeader *f1 = new gdcmHeader( header );
1131 was gdcmHeader::gdcmHeader(bool) instead of the expected
1132 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1133 Hence the parsing wasn't executed... See also below.
1134 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1135 as explicit constructor didn't do the trick to fix the above problem.
1136 Could anyone explain why ?
1137 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1138 properly calls gdcmValEntry::Print() (that was weed out from
1139 code related to gdcmBinEntry).
1141 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1142 * In order to fix memory leaks:
1143 - Test/TestWriteSimple.cxx: added cleaning of free store through
1145 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1146 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1147 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1148 (through the call to ::AddDicomDirMeta()) or the destructor
1149 would crash when deleting uninitialized ::metaElems].
1150 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1151 - src/gdcmDocument.cxx:
1152 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1153 from dynamic stores.
1154 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1155 was causing memory leaks.
1156 - src/gdcmSQItem.cxx:
1157 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1158 cleanly handled with polymophism: sorry but my milage is low).
1159 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1160 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1161 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1162 This avoids SegFaulting.
1163 - src/gdcmSQItem.h: coding style.
1165 - Test/TestWriteSimple still severely sucks. The output image content
1166 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1167 damaged when displayed with vtkgdcmViewer.
1168 - on memory leaks: TestWriteSimple leaks really less (see entry
1169 of 2004-06-18 in Changelog file for the call to valgrind).
1170 - on segfaults: ctest now passes all the tests but one (no more
1172 * Erroneous leading white fix:
1173 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1174 white[s] (as opposed to from >> xxx, that removes it [them].
1175 - src/gdcmTS.cxx: ditto.
1176 - gdcmPython/testSuite.py: dirty related kludge removed.
1177 * src/*: remaining references to gdcmParser removed.
1178 * src/*[cxx|h]: added copy[way]left header.
1181 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1182 * In order to fix writing of dicom files:
1183 - Test/TestWriteSimple.cxx: a simpler example of writing.
1184 - Test/CMakeLists.txt changed accordingly.
1185 - src/gdcmDocument.cxx:
1186 -- The destructor now recursilvely removes potential sequences.
1187 -- Bug fix in ::IsJPEG2000()
1188 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1189 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1191 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1192 to only declared) and build on top of
1193 ::GetDocEntryByNumber(guint16, guint16).
1194 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1195 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1196 for usage in destructor and treatement of promotion in
1197 ::ReplaceOrCreateByNumber().
1198 - src/gdcmSQItem.cxx: destructor should better handle his job.
1199 Test/TestWriteSimple now runs (or at least it DOES something).
1200 * We can now start hutting memory links. A good starting point is:
1201 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1202 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1203 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1205 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1206 * Valgrind note: after Mathieu Malaterre teached me how to read
1207 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1209 Using gcc, you can force the STL to use malloc and to free memory as
1210 soon as possible by globally disabling memory caching.
1211 With 3.2.2 and later, you should export the environment variable
1212 GLIBCPP_FORCE_NEW before running your program.
1213 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1214 simply vanish (it is still not clear to me, whether this means that
1215 STL std::string leaks or if valgrind believes it leaks...).
1216 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1217 running bin/gdcmTests makeDicomDir):
1218 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1219 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1221 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1222 SegFaulting (I drowned in DicomDir related code when trying to
1223 understand why the list is empty...).
1224 * src/gdcmDocument.h: first BSD license header try.
1225 * Doc/License.txt added.
1227 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * src/gdcmDocument.[h|cxx]:
1229 - Clean up of the Transfer related predicates. They are now all based
1230 on new method isGivenTransferSyntax, that (should) handle properly
1231 the padding problem.
1232 - general clean up, simplification, and coding style.
1233 - Specific clean up of Parse7FE0() (umproperly named actually).
1234 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1236 2004-06-14 Jean-Pierre Roux
1238 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1239 - fix the display of SQItem ordinal number
1240 - add the GetSQItemByOrdinalNumber method
1241 - remove some useless never written private methods
1243 2004-06-14 Jean-Pierre Roux
1245 - adding a constructor taking a gdcmDocEntry as an input param
1246 - ReplaceOrCreateByNumber now returns :
1247 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1248 a gdcmValEntry * if a string value is passed as a param
1250 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1251 according to the param type (no longer sets a gdcmDocEntry)
1252 - GetValEntryByNumber, GetBinEntryByNumber added
1253 - NewValEntryByNumber and NewBinEntryByNumber added
1255 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1257 - GetSQItemNumber and SetSQItemNumber added, to provide
1258 a (relative) Item identier inside a given Sequence
1259 \warning : some pb remaining around this number
1261 - AddEntry now takes the Item Number as a param
1263 - adding a constructor taking a gdcmDocEntry as an input param
1265 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1266 * Memory leak hunt with the following command:
1267 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1268 --show-reachable=yes gdcmTests PrintDocument
1269 It looks like many (all?) leaks are due to the STL (or a bad usage
1270 of the STL. The lines producing the leaks now have a comment with
1271 a "MEMORY LEAK" tag: you can retrieve them with
1272 grep "MEMORY LEAK" src/*
1273 Here are two typical examples which I can't help fixing:
1278 char * test = "babo";
1279 name = test; //// <--- valgrind detects 960 bytes lost in
1280 //// call to std::string::operator=(char const*)
1281 name.clear(); //// Doesn't help !
1289 std::cout << "Type a bunch of characters followed by RETURN: ";
1290 getline(std::cin, line); //// <--- valgrind dectects a loss
1291 //// of 1320 bytes in call to
1292 /// std::basic_istream<>& std::getline<>
1298 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1299 * src/gdcmHeader.[cxx|h]:
1300 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1301 and related, moved away to gdcmDocument.
1302 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1303 the corresponding protected accessors of inherited class
1304 gdcmDocument, removed ! As a consequence gdcmFile had to be
1305 declared friend of class gdcmDocument (see below).
1306 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1307 - Clean up of undefined or unused methods.
1308 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1309 account the changes to gdcmHeader.h).
1310 * src/gdcmDocument.h:
1311 - gdcmFile is now a friend class (in order to take into account the
1312 changes to gdcmHeader.h).
1313 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1314 (see changes to gdcmHeader.h).
1315 - Accessors (reading on the form GetEntry*) are now public.
1316 - Clean up of undefined or unused methods.
1317 * src/gdcmDocument.cxx:
1318 - adaptation to changes to gdcmDocument.h
1319 - ::OpenFile now writes a verbose message when file cannot be opened.
1320 - some std::string properly set to VRKey
1321 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1322 references to gdcmDocument.
1323 * Test/TestFindTags.cxx: changed accordingly to above changes.
1324 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1325 cvs repository gdcmData.
1327 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1328 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1329 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1330 conflicts with gdcmValEntry::voidArea.
1331 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1332 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1333 Value representation between StringRepresentable and BinaryRepresentable.
1334 * src/gdcmDocument.cxx:
1335 - method ParseDES: proper indentation restored and usage of
1336 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1337 - method LoadDocEntry: the fingerprint left in the SetValue() of
1338 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1339 removed. Reverting to previous code segment with the proper
1340 dynamic_cast< gdcmValEntry* >.
1341 Note: this was (partially) breaking the python test suite
1342 (gdcmPython/testSuite.py) that made usage of the above
1343 fingerprint to check presence of "Pixel Data".
1344 * src/gdcmDocEntry.h: coding style.
1345 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1346 now taken into account.
1347 * gdcmPython/gdcm.i: adaptation to the new internal representation
1348 of gdcm (exit gdcmParser, hello gdcmDocument).
1349 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1351 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1352 anymore, but instead prints the loaded Python dictionary.
1353 * .... alas, the python testSuite is still broken.
1355 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1356 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1358 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1359 * src/gdcmUtil.h : export methods
1361 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1362 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1364 * Initial addition of automatic python testing
1365 * Initial addition of automatic image comparison
1367 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1368 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1369 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1371 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1372 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1373 * Test/ShowDicom.cxx : bug fix for msvc compilation
1374 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1376 2004-05-04 Jean-Pierre Roux
1377 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1378 new concepts (and new classes) :
1379 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1380 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1381 - Sequence Doc Entries (gdcmSeqEntries)
1382 a Sequence is composed of Items.
1383 Each item is a set of Doc Entries (this is recursive)
1384 The non uniqueness of the 'Dicom tag' is due to this recursivity
1385 (never taken into account)
1386 Our unability to add a new 'entry' in the header
1387 at the proper location (neither in the H-Table (map or multimap),
1388 nor in the Chained List is also due to this recursivity.
1389 Don't try, right now, to use/modify/compile these new sources :
1390 nothing is finished.
1391 We just commit all the stuff, 'as is', in order not to loose it.
1393 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1394 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1396 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1397 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1398 file prefix (SetFilePrefix)
1400 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1401 * Add a new test: ShowDicom, for now this is just the c++ version of
1402 checkRead.sh, later it will be able to compare the image read against a
1404 * Replace the DEBUG on the stack with a global entry in cmake interface:
1405 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1407 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1408 * Add an example subdir, with a real example on how to read + write a
1411 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1412 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1413 * Doc/CMakeLists.txt: the main page is now properly differentiated
1414 between the developper and user version.
1415 * Doc/doxygen.config.in: dropped search related obsolete flags
1416 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1418 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1419 * DEVELOPPER: added some helpfull comments for compile/test/install
1422 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1423 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1424 src directory, now generated in the build dir.
1425 2. Tests as mentionned smarter
1427 4. Add a new method in gdcmDict that return the PubDict by name
1428 this is interesting for 3rd party lib like ITK,
1429 where we could set the institution name / patient name...
1431 * ENH: 1. Now the test suite is working for real
1432 2. All binaries are now output in the gdcm-bin directory
1433 (this was not true before)
1435 2004-04-28 Jean-Pierre Roux
1436 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1437 SeQuence indented printing of Dicom Header.
1438 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1439 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1440 Computation of SQDepthLevel is now part of gdcmHeader constructor
1441 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1442 tree-like structure of a Dicom Header.
1443 * FIX Test code cleaning
1445 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1446 * ENH: Adding automatic testing
1447 1. Need a DartConfig.cmake to submit to public
1448 2. Add a test driver gdcmTest.cxx
1449 3. gdcmTestMain, an helper for the main test driver gdcmTest
1450 4. Files in Test don't have a main anymore, this becomes interesting
1451 when we add more and more tests, thus dsw don't have to load
1453 * ENH: Adding a GDCM_DATA_ROOT for testing
1454 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1455 one file instead of seven + some small cleanup
1457 2004-04-22 Jean-Pierre Roux
1458 * ENH Minor changes to the Print() methods.
1459 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1460 Header printing. Example given with :
1461 > PrintHeader fileName 2 new
1462 (SQ based tree-like structure still to be done for the Header ...)
1464 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1465 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1466 1. I have added some unsigned where needed
1467 2. Some function parameter not used -> (void)
1468 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1469 4. g++ don't like character '\' in comment
1470 5. #define jpeg_create_decompress jCreaDecompress
1471 this really need to be fixed
1472 6. virtualize destructor of gdcmObject ... leakage
1473 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1474 this also really need to be fixed
1475 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1476 remove compression file
1477 (as we only do decompression, right ?)
1478 * ENH: Change malloc/calloc/free with c++ equivalent
1480 2004-04-21 Jean-Pierre Roux
1481 * FIX gdcmHeaderHelper::GetXSpacing
1482 when a single value is found (bug ?), xpacing is now
1483 defaulted to yspacing
1485 2004-04-19 Jean-Pierre Roux
1486 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1487 * ENH add parameters :
1488 bool exception_on_error = false,
1489 bool enable_sequences = false,
1490 bool ignore_shadow = false
1491 to the gdcmFile constructors to be full gdcmParser compliant
1492 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1493 to allow reading of PAPYRUS 3.0 files
1495 2004-04-06 Jean-Pierre Roux
1496 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1498 2004-04-02 Jean-Pierre Roux
1499 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1500 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1501 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1503 2004-03-30 Jean-Pierre Roux
1504 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1505 for ACR file, written out as DICOM files (hope so...)
1507 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1508 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1509 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1510 moved to base class gdcmParser and only the specialisation is kept
1512 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1513 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1514 already does the job.
1515 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1516 (to be consistent with gdcmParser::WriteEntries).
1518 2004-03-30 Benoit Regrain
1519 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1520 upate of the object's instance. It's passed to 2 in the unfavorable
1521 case : one in the ExecuteInformation, one in the ExecuteData
1523 2004-03-29 Jean-Pierre Roux
1524 * ENH : Check on file type to be written moved
1525 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1526 * FIX : gdcmObject::ResetBoundaries now stops properly
1527 when end-of-list is reached
1528 : gdcmVersion modified (as Benoit Regrain asked)
1530 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1531 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1532 * src/gdcmUtil.cxx: added forgotten iostream include.
1533 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1534 equivalent to ExplicitVR in existing code).
1536 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1537 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1538 now contains all the gdcmGlobal related code.
1539 * minor coding style and doxygenation changes.
1541 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1542 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1543 now contains all the Debug related code.
1544 * minor clean-up of includes in src/*.cxx
1545 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1546 CreateCleanString) removed.
1547 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1548 * Doc/DoxyMainPageUser.txt added.
1549 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1550 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1551 src/gdcmDirList.cxx)
1553 2004-03-24 Jean-Pierre Roux
1554 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1556 2004-03-23 Jean-Pierre Roux
1557 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1558 big endian made volumes
1559 * ENH Now gdcmParser constructor and destructor are protected to forbid
1560 end user to instanciate class gdcmParser
1561 (only gdcmHeader and gdcmDicomDir are meaningfull)
1563 2004-03-22 Benoit Regrain
1564 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1565 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1566 gdcmSerie to gdcmDicomDirSerie
1568 2004-03-19 Jean-Pierre Roux
1569 * ENH Now the tree-like structure describing a DICOMDIR comming from
1570 an already existing DICOMDIR file is consistent with
1571 the home-made tree-like structure build ex-nihilo
1572 or build from the files held (recursively) in a Directory
1573 functions gdcmDicomDir::CheckBoundaries()
1574 gdcmObject::SetBoundaries() added
1576 2004-03-17 Jean-Pierre Roux
1577 * REM (Eric Boix bug) : removal of meaningless
1578 gdcmDicomDirImage::NewImage function.
1579 * FIX now file names and directory name are written properly in the
1581 * FIX now gdcmDicomDir constructor may be call without any trick
1584 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1585 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1586 of gdcmDicomDirImage::NewImage as empty function.
1588 2004-02-28 Jean-Pierre Roux
1589 * ENH add gdcmDicomDir:NewPatient
1590 add gdcmDicomDirPatient:NewStudy
1591 add gdcmDicomDirStudy:NewSerie
1592 add gdcmDicomDirSerie:NewImage
1593 to allow making gdcDicomDir object.
1594 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1595 (as opposite to the gdcmHeader chained list)
1597 2004-02-11 Benoit Regrain
1598 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1599 when using from python
1601 2004-02-10 Benoit Regrain
1602 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1603 * FIX : in gdcmDicomDir when the directory is empty
1604 * ENH : add callback and methods to get the progression of dicomDir
1607 2004-02-06 Jean-Pierre Roux
1608 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1609 - GDCM_META added to gdcmDicomDirType
1610 - class gdcmMeta created
1611 * ENH : - A brief summary is now displayed at the beginning of
1612 'testDicomDir' to help disaster magnitude estimation
1613 * REM : Now useless Test/explDICOMDIR.cxx
1615 2004-02-05 Benoit Regrain
1616 * ENH : add methods in gdcmObject to get the hash table or the list of
1618 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1619 * FIX : wrapping python for TagHeaderEntryHT
1621 2004-02-04 Benoit Regrain
1622 * FIX : even length for some strings when writting the dicom dir
1623 * FIX : sort the images in the dicom dir
1624 * FIX : Bug fix for python use of dicom dir
1625 * ADD : a python demo
1627 2004-02-04 Jean-Pierre Roux
1628 * FIX : Final solution (?) for icone embedded images
1629 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1630 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1631 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1632 gdcmData/gdcm-MR-SIEMENS-16.acr1
1633 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1634 to make full checking easier
1636 2004-02-04 Benoit Regrain
1637 * FIX : WriteEntries : coding style & logic in parameters
1638 * FIX : Set the elements to create the DicomDir in a dictionary file
1640 2004-02-03 Benoit Regrain
1641 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1642 * gdcmDicomDir : add the load of directory
1643 * Bug fix and print add-on
1645 2004-02-03 Jean-Pierre Roux
1646 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1647 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1648 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1649 * FIX gdcmParser.cxx : 'group length' elements are now considered
1650 as integers, even for shadow groups, when file is Implicit VR
1652 2004-02-02 Jean-Pierre Roux
1653 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1655 of the last synonym :-(
1656 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1658 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1659 * FIX taking into account the possible 7fe0,0010 multiplicity
1660 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1661 to allow removal of references to 7fe0,0010, to deal with
1662 ACR-NEMA images, when 0028,0200 is meaningfull
1664 2004-01-31 Jean-Pierre Roux
1665 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1666 no longer writes 'Un' on disk
1667 * FIX SQ elements with actual length are now dealt with corectly
1668 * FIX gdcmFile::WriteBase make the difference, for color images, between
1669 the length (for Palette expanded images)
1670 and Raw Length (non expanded image + Palette)
1671 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1672 (that broke Write). Replaced by UL.
1673 Aware user will reload the field if he
1674 thinks it's necesssary
1676 2004-01-30 Jean-Pierre Roux
1677 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1678 when 'dirty Acr' is found, to be compliant with the new
1679 IsReadable() methods.
1681 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1682 (no DOUBLE images in kosher DICOM,
1683 but so usefull for people that miss them ;-)
1685 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1686 DICOMDIR related utilities (not checked as Windoze compliant)
1688 2004-01-28 Jean-Pierre Roux
1689 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1691 2004-01-27 Jean-Pierre Roux
1692 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1693 to allow skipping the shadow elements, to save memory space.
1694 The TRUE value for this param has to be used
1695 with a FALSE value for the 'enable_sequence' param.
1696 ('public elements' may be embedded in 'shadow Sequences')
1697 * gdcmHeader methods now deal with 'embedded icones images' in the header
1698 (even when an 'icone image sequence' is announced by the
1699 element (0x0088,0x0200), but there is NO icone at all ...
1701 * gdcmHeader sometimes Image Location value doesn't follow
1702 the supposed processor endianity (see gdcmData/cr172241.dcm).
1705 * gdcmHeader add the method
1706 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1707 to get *all* the Header Entries with the same tag.
1708 GetHeaderEntrySameName is probabely *useless*
1709 (no meaning : Name is *not* an identifier within the Dictionnary)
1711 2004-01-26 Benoit Regrain
1712 * Bug fix in the print of hexadecimal representations. Remove long fields
1713 in the print and add a third level of print to print them
1715 2004-01-23 Benoit Regrain
1716 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1717 * Bug fix on test suite after remove the strip made on not string fields
1718 * Split the IsReadable method between gdcmParser which test that the file
1719 is dicom and gdcmHeader which test that it's an image file
1721 2004-01-22 Benoit Regrain
1722 * DicomDir : clean code, add methods, set variables in protected or private
1723 * gdcmUtil : bug fix for the clean string method
1725 2004-01-19 Benoit Regrain
1726 * Add the use of shadow dictionaries
1727 * bug fix and coding style
1729 2004-01-19 Benoit Regrain
1730 * src/gdcmFile.cxx : bug fix concerning the close of file
1731 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1732 * Add the update of header entries using the shadow library
1734 2004-01-19 Benoit Regrain
1735 * removal of file gdcmHeader2.cxx
1736 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1737 inheriting from gdcmParser. This split is to prepare the integration
1738 of dicom dir parsing
1739 * bug fix under python
1741 2004-01-16 Jean-Pierre Roux
1742 * REM removal of class gdcmHeaderEntrySet
1743 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1744 * ADD add file gdcmHeader2.cxx
1745 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1747 2004-01-15 Benoit Regrain
1748 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1749 entries created while parsing the header. Thus, they will be destroyed
1750 when the gdcmDictSet will be destroyed
1751 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1754 2004-01-15 Benoit Regrain
1755 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1756 made a fatal error because of the memory release at the end of program.
1757 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1758 some memory and vtk seems to have some problems with that.
1759 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1761 2004-01-14 Benoit Regrain
1762 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1763 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1764 * src/*.[h|cxx] : make changes due to class name changes
1765 * gdcmPython/demo/*.py : bug fix due to method names
1767 2004-01-13 Benoit Regrain
1768 * src/*.[h|cxx] : coding style
1769 * vtk/*.[h|cxx] : coding style
1771 2004-01-13 Benoit Regrain
1772 * gdcmPython/testSuite.py : test the readable flag of file for tests
1773 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1774 It's lied to the stl compilation by MSVC (windows, always windows...)
1775 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1777 2004-01-12 Benoit Regrain
1778 * src/*.h : add comments
1779 * src/gdcmDictSet.h : set the method BuildDictPath in public
1780 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1781 directly setted in the source code
1782 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1785 2004-01-09 Benoit Regrain
1786 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1787 * setup.py : use a reference to gdcmVERSION
1789 2004-01-07 Benoit Regrain
1790 * Modification to compile with the distutils.
1793 2003-12-10 Benoit Regrain
1794 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1795 can use a gdcmHeaderHelper to load datas
1796 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1797 made in the source code
1799 2003-12-10 Benoit Regrain
1800 * Update Windows projects and .cvsignore files
1802 2003-11-12 Jean-Pierre Roux
1803 * ENH gdcmHeader constructor has one more parameter (default value : false)
1804 that allows the user to 'go inside' the SeQuences only
1806 gdcmElValSet:Print takes it into account
1808 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1809 * ENH: Update gdcmPython/CMakeLists
1810 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1811 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1813 2003-11-10 Jean-Pierre Roux
1814 * FIX : gdcmHeader::LoadElements is now based
1815 on the ListTag listElem member,
1816 not longer on the TagElValueHT tagHt member
1817 * ENH : PrintPubElVal shows (temporarily) both results,
1818 with the tagHt member and the listElem member.
1819 (it's easier to 'see' the problems when using Printheader)
1821 * FIX : old private member LgrElem is now splitted into
1822 ReadLength : Length actually found on disk (updated only
1823 if bug fixing is necessary), for internal
1825 UsableLength : Updated by FixFoundLength, to fix a bug
1826 or to allow Parser going on.
1827 Will allow to re-write a kosher header when a SeQuence
1828 with a length (not 0000) is found
1829 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1830 because gdcmElValSet::Add does not update ListElem
1833 2003-11-07 Jean-Pierre Roux
1834 * FIX misstyping in Transfert Syntax name table
1835 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1836 when they have an actual length (not 0000 nor FFFFF)
1837 (Nobody should care of it, but DICOMDIR explorers)
1839 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1840 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1842 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * ENH: vtkGdcmReader now supports LUT !
1844 (vtkgdcmViewer for now is not able to use them though)
1846 2003-11-05 Jean-Pierre Roux
1847 * in testSuite.py : new files names for checking the package
1848 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1849 that returns the pixel area size to the *aware* (vtk) user
1850 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1852 2003-11-05 Benoit Regrain
1853 * in testSuite.py : Modify the rules for checking the paths
1854 : Explicit error messages
1855 * in __init__.py : Related modif
1857 2003-11-03 Jean-Pierre Roux
1858 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1859 to be used by aware (vtk) users that want to manage
1860 LUT (and no to turn the PALETTE image into an RGB pixels one)
1861 * GetPixelType now returns 8U for 24 Bits images
1862 (vtkGdcmReader compliant)
1864 2003-10-31 Jean-Pierre Roux
1865 * Removal of *all* gdcmData images and add them again
1866 in order to loose the 'history' of un-anonymised images
1868 2003-10-31 Jean-Pierre Roux
1869 * RMV : removal of useless jBitsInJsample.h
1870 for both 8 and 12 Bits JPEG Lossy Libraries
1872 2003-10-31 Jean-Pierre Roux
1873 * ENH : Add the functions gdcmFile::GetImageDataRaw
1874 gdcmFile::GetImageDataIntoVectorRaw
1875 that act as GetImageData and GetImageDataIntoVector
1876 except the making of an RGB Plane from Gray Plane + LUT
1877 Intended to aware (vtk) users who know how to manage
1880 GetLUTRGBA return a R,G,B,A LUT if any
1881 lgrTotaleRaw gives the 'Raw' length
1882 GetImageDataRaw returns the gray Plane
1883 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1884 (They stay Grey, just like with other Dicom viewers :-(
1886 2003-10-30 Jean-Pierre Roux
1887 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1889 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1890 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1891 being coherents dicom files.
1893 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1894 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1896 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1897 * ENH: Two steps is necessary to please VC++ compiler...
1898 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1899 * ENH: Add include dir to medcon lib
1900 * FIX: only one function is being exported for now !
1901 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1903 2003-10-29 Jean-Pierre Roux
1904 * adding gdcmHeader::GetLUTRGBA
1905 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1906 --> Mathieu, the modif u're waiting for is not yet committed
1907 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1909 2003-10-27 Jean-Pierre Roux
1910 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1911 00191113.dcm DermaColorLossLess.dcm
1912 MxTwinLossLess.dcm RadBWLossLess.dcm
1913 * ENH: For version prior to vtkImageViewer2 -r 1.19
1914 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1916 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1917 * Removal of ido stuff in CMakeLists.txt
1919 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1920 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1921 * FIX: remove a call to ->Modified ... see comments
1922 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1924 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1925 * FIX: Problem with path for libvtkgdcmPython
1926 * ENH: Try adding a search script for python site-package
1927 * RMV: Remove some file from medcon lib that are not necessary
1928 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1929 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1930 * FIX: More pragma disable fro VC++,
1931 I don't think I break something as it is also disable in VTK/ITK.
1932 But it fasten debug compilation time.
1934 2003-10-23 Jean-Pierre Roux
1935 * gdcm now deals with 16 Bits Run Length Encoded images
1936 (they are compressed as 2 planes images,
1937 one for the high Bytes, the other for low Bytes)
1939 2003-10-22 Jean-Pierre Roux
1940 * Now CheckRead takes into account :
1941 - the bugged 'Leonardo' Siemens images
1942 - the XA images, sent thru the burning VPRO station
1943 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1946 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1947 * FIX: When copying a Makefile.am to CMakeLists.txt
1948 one should remove the '\'
1950 2003-10-22 Jean-Pierre Roux
1951 * in gdcmData adding a bugged 'Leonardo' Siemens image
1952 (wrong lengths in header)
1953 OK with gdcm, KO with the other viewers :-)
1954 * add a GE dlx XA image, thru the VEPRO burning station
1957 2003-10-21 Jean-Pierre Roux
1958 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1959 for a brutal checking of vtkgdcmViewer compliance
1961 2003-10-21 Jean-Pierre Roux
1962 * add the files for 'xmedcon' Jpeg Lossless library
1963 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1965 2003-10-21 Jean-Pierre Roux
1966 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1968 2003-10-21 Jean-Pierre Roux
1969 * garbage Siemens 'Leonardo' images dealt with
1970 (the patch is easy to remove)
1971 * cosmetic changes to avoid warnings
1973 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1974 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1975 no need to press 'r' now.
1977 2003-10-20 Jean-Pierre Roux
1978 * upgrade of checkRead.sh checkWrite.sh according
1979 to new Jpeg Lossless decompressor
1980 * add US.3405.1.dcm, a genuine RGB medical file ...
1981 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1982 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1984 2003-10-15 Jean-Pierre Roux
1985 * general anonymisation in gdcmData
1986 * adding the 'color files' from
1987 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1988 * adding some well knowed bugged-header images
1989 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1990 waiting for their inclusion in Python testsuite
1992 2003-10-15 Jean-Pierre Roux
1993 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1994 no longer seg faults when file is not found
1996 2003-10-14 Jean-Pierre Roux
1997 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2000 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2001 * TODO: *.in file to genereate a UseGDCM later
2003 2003-10-14 Jean-Pierre Roux
2004 * Some supposed-to-be Dicom Images have no preamble.
2005 OpenFile takes it into account
2006 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2007 * Missing elements added in dicomV3.dic
2008 (just to be affraid : have a look at
2009 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2010 and do it again next year ;->
2012 2003-10-13 Jean-Pierre Roux
2013 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2014 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2015 But there are NOT. It's fixed !
2017 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2018 * FIX: "jpeglib.h" was not found on VC++
2019 * FIX: vtkgdcm was not being installed
2021 2003-10-10 Jean-Pierre Roux
2022 * ENH : OpenFile closes the file if it *really* doesn't look like
2023 an ACR-NEMA / DICOM one.
2024 * FIX : testWrite no longer writes an empty file if the source file
2025 is not gdcm Readable
2026 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2029 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * FIX: CMake generate now documentation
2031 * ENH: out of source doc build !
2032 * ENH: Generate both user and dev documentation
2033 * ENH: Should work on windows too
2034 * ENH: Only one doxygen config.in file is needed
2035 * FIX: make install should be ok now on ùnix plateform
2036 * FIX: PATH to dictionary was wrong (missing /)
2037 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2039 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2040 * vtkGdcmReader is now able to read rgb dicom file.
2041 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2042 * added a gdcmViewer to vtk test, use mouse to control
2043 window level & window width
2045 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2046 * CMake-ification of gdcm, we have now two build system
2047 * FIX: on cygwin Wsock32 doesn't exist
2048 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2050 2003-10-06 Emanuel Ollart
2051 * FIX : compilation process wad broken.
2052 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2054 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2055 * change gdcmViewer -> vtkgdcmViewer
2056 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2058 2003-10-06 Jean-Pierre Roux
2059 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2060 ( e.g : well known GE images with a wrong elem length,
2061 : Philips MRI Images with a wrong Huffman table)
2062 * still to be done : allow the reading of bugged LEONARDO Siemens images
2064 2003-10-03 Jean-Pierre Roux
2065 * Odd length strings are padded with '\0' (not with spaces,
2066 to remain compliant with already defined strings,
2067 like Transfert Syntax UID and others)
2069 2003-10-03 Jean-Pierre Roux
2070 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2071 to allow displaying RGB images (not only by affim ;-)
2073 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2074 * vtkGdcmReader is now able to read rgb dicom file.
2075 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2077 2003-10-03 Jean-Pierre Roux
2078 * A few nasty patches to allow the reading of a lot of nasty images
2079 ( e.g : well known GE images with a wrong elem length,
2080 : Philips MRI Images with a wrong Huffman table)
2081 * still to be done : allow the reading of bugged LEONARDO Siemens images
2083 2003-10-03 Jean-Pierre Roux
2084 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2086 2003-10-03 Jean-Pierre Roux
2087 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2088 to allow displaying RGB images (not only by affim ;-)
2090 2003-10-03 Jean-Pierre Roux
2091 * gdcmFile::GetImageDataIntoVector now
2092 - deals with MultiFrames MultiFragments Run Length Encoded files
2093 - deals with YcBcR (YBR_FULL) files
2094 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2095 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2097 (no sample found :-(
2099 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2100 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2101 Two reasons: - clear things
2102 - third parties acces gdcm through header files, so won't
2103 suffer anymore VC++ complains
2105 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2106 * add argv[1] in testvtkGdcmReader.cxx
2109 2003-09-24 Jean-Pierre Roux
2110 * The lines are now eigthy characters long.for
2111 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2113 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2114 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2115 char* to std::string. Thus, the use of strdup becomes useless. (see
2116 previous commis of Malaterre)
2117 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2118 before the last Malaterre's commit.
2120 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2121 * This commit should fix the Debug building under VC++, the problem
2122 was mainly a mixture of debug and release lib being loaded at startup.
2123 * I also remove a depency to a specific C function: strdup. Because I had
2124 to force the link to msvcrtd (whereas strdup is in libc).
2126 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2127 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2128 located in the gdcmCommon.h file. All use of reference of tha has been
2129 changed to now use the variable GDCM_UNFOUND.
2131 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2133 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2134 Dicom dictionary. The test suite can now be run again. Note:
2135 I'm note very happy with the " (RET)" changes. I believe this
2136 RETAINED comment should be dropped when parsing the dictionary.
2137 - PACKAGER corrected
2139 - AUTHORS updated and now in alphabetical order
2140 * Makefile.am now exports gdcm.dsw for Windoze users.
2142 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2143 * cygwin complains about missing std:: in subdir Test/
2145 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2146 * remove some methods that are now in gdcmHeaderHelper
2148 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2149 * vtkGdcmReader set spacing and origin correctly
2151 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * Fix a few delete/delete[] mismatch
2154 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2155 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2156 interpretation to data given by gdcmHeader. For instance there are
2157 heuristics to get informations (look at different places).
2158 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2159 sorting DICOM images based on different strategies.
2160 * modified Makefiles accordingly.
2162 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2163 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2164 when building in debug mode
2165 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2166 src/win32/gdcmdll.dsp
2167 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2169 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2170 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2173 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2174 * src/win32/libgdcmjpeg12.dsp was not dos format
2175 * src/win32/libgdcmjpeg12.dsp :
2176 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2177 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2179 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2180 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2182 * src/gdcmFile.cxx : bug fix in affectation type
2183 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2184 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2185 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2186 symbols... future problem ?
2188 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2189 * src/win32/libgdcmijpeg12.dsp was missing
2190 * modified gdcm.dsw accordingly
2192 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2193 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2195 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2196 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2197 commit of JPR (before his hollidays to facilitate our work).
2198 * setup.py : bug fix in code. Modifications made while the last commit
2199 of JPR. The code hasn't been tested before the commit... it's so
2200 useless to make that (for best programmer that is JPR) !!!
2202 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2203 * tagged the current version as Version0_3 (i.e. version 0.3)
2205 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2206 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2207 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2208 * *.dsp : modifications to use new libgdcmijpeg8 library
2209 * setup.py : bug fix on VTKPATH variable
2210 * PACKAGER : adding all concerning windows
2212 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2213 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2215 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2216 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2217 test suite reported error.
2218 * PACKAGER file added (describes what a packager must do when
2219 packaging a new release).
2220 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2221 * configure.in: upgraded version number to 0.3.0
2222 * fixing build of rpm (through rpm -ta):
2223 - Doc/Makefile.am exports proper doxygen files
2224 - src/jpeg/libijg8/Makefile.am exports the include files.
2226 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2227 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2228 * src/gdcmHeader.h : formatting code
2230 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2231 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2232 We were obtaining error message from vtk. Now, creation of file list
2233 is made in an internal list to prevent this problem.
2234 Bug fix when output is empty.
2235 Bug fix in update of progress value. Previous commit for this was a bad
2237 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2239 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2240 * src/gdcmHeader.h : added method to get the file name
2241 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2242 files. Added method to remove all files on the input
2243 Added FIXME comment concerning the bad parsing of header made by
2244 ExecuteInformation method (in ExecuteData method)
2246 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2247 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2248 when using make instal.
2249 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2250 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2252 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2253 * setup.py : adding include dir of jpeg lib to compile all sources
2254 * */Win32/*.dsp : JPR fix for windows compilation
2256 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2257 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2259 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2260 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2262 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * setup.py is again effective on un*x (takes into account the
2264 addon of the jpeg library)
2265 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2266 * Doc/Doxy* updated (includes above enhancements)
2267 * INSTALL now points to web documentation
2269 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2270 * src/gdcmHeader.h doesn't make unnecessary reference to
2272 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2274 * src/gdcm*.[cxx|h] :
2275 - to allow compilation with gcc 3.x
2276 -- clean up of STL usage (added explicit usage of std::)
2277 -- small fixes on exceptions.
2278 Note: linking not tested !
2279 - clean of doxygen comments to avoid warnings at documentation
2281 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2282 dependent convertion).
2284 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2285 * Clean up of previous JPR garbage commit (not even commented in the
2287 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2288 - moved all jpeg related files from src to src/jpeg/libijg8, with
2289 addition/modification of Makefile.am and configure.in.
2290 - the testSuite is still brain damage (not guilty).
2292 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2293 * WrapVTK.py : modifications to get correctly vtk source files to
2295 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2296 (FileName -> Filename)
2298 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2299 * vtk/vtkGdcmReader.[cxx/h]:
2300 - UpdateProgress method should now be effective
2301 - removed the limitation on having only images loaded (as opposed
2303 - when building a stack of images/volume, a lesser number of
2304 gdcmHeader and gdcmFile instances should be used (hopefully
2305 accelerating things).
2306 - when building a stack of images/volumes, files which are not
2307 loadable (wrong path-filename, wrong permissions on existing file,
2308 or file not parsable by gdcm) are replaced with a black image
2309 in the stack (for the caller to notice the problem).
2311 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2312 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2314 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2315 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2316 between standard library (std) and vtk library (problems are found
2317 under Windows... thanks Windows !)
2319 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2320 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2322 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2324 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2325 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2327 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2328 * When compiling with distutils (see setup.py) the C++ compiler is
2329 called with different flags than the default ones (with automake).
2330 In order to fix all those warning, I compiled gdcm with the command
2331 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2332 and went for warning fixes:
2333 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2334 up from unused variables.
2335 - vtk/vtkGdcmReader.cxx: potential bug fix.
2336 * src/gdcmHeader.h: Doxygen warning cleanup
2338 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2339 * gdcmPython/gdcm.i:
2340 - typemaps correction to take into account the systematic replacement
2341 of "using namespace std" with std:: prefix e.g. std::list,
2342 std::string... (cf changes of 2003-05-21).
2343 - gdcmGlob global variable of type gdcmGlobal (defined in
2344 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2345 exported to Python a as cvar.
2346 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2347 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2348 gdcmDictSet.GetPubDictTagNames() and
2349 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2350 C++ static methods).
2351 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2352 with the above changes.
2354 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2355 * setup.py, manifest.in : bug fix under linux
2357 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2358 * Modification of setup.py to compile vtk part too. Then, we have 2
2359 wrappers which must work with same distutils. For that, we have a
2360 generic distutils in distusiltsWrapping.py ; with :
2361 - build_extWrap class to wrap generically all extensions,
2362 - ExtensionWrap base class for all wrapping extension that contains
2364 - Wrapper interface which wrap sources
2365 + In WrapSwig.py we have extension and wrapper for Swig
2366 + In WrapVTK.py we have extension and wrapper for VTK
2367 * MANIFEST.in : modifications to consider vtk directory and new python
2368 files for compilation
2370 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2371 * Added python wrappers of vtkGdcmReader vtk class (see the
2372 source in vtk/vtkGdcmReader.cxx) :
2373 - vtk/Makefile.am now builds a library
2374 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2375 python library (as opposed to _gdcm.so wich are the python
2376 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2377 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2379 - configure.in has an additional flag --enable-vtk that needs
2380 to be set to enable compilation of vtk related code, that is:
2381 + vtk/vtkGdcmReader.so and
2382 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2383 + gdcmPython/vtkgdcmPython.so (see above)
2384 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2385 be read when compressed or when HighBit + 1 != BitsStored),
2386 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2387 the usage of the python wrapper of vtkGdcmReader vtk class.
2388 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2389 * src/*.[h] all occurences of stl classes are now prefixed with
2390 std::, and all occurences of "using namespace std;" where removed.
2391 This is to avoid pollution of global namespace in included files.
2392 Apparently vtk does not avoid this pitfall: when using both
2393 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2394 collision of various stl members (principally cout...).
2395 * gdcmPython/testSuite.py now cleanly removes temprory generated
2397 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2398 comply with above changes)
2400 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2401 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2402 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2403 vtk data structure (an image Flip was required).
2404 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2405 * cosmetic changes in documentation.
2407 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2408 * src/gdcmHeader.cxx: the constructor no longer exits when an
2409 unexisting file is given as argument.
2410 * The subdirectory Data (containing all the images used for the
2411 test suite) is not part of this repository anymore. A new module
2412 containing those images is now available at
2413 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2414 with the name gdcmData.
2415 All the python scripts (including the package initialisation file
2416 gdcmPython/__init__.py) were adapated to take this change into
2417 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2419 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2420 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2421 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2422 demo of the usage of this class.
2423 Compilation of this vtk part is only done when using the --enable-vtk
2424 at configure (or autogen.sh) stage.
2426 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2427 * More memory link related corrections and documentation fixes.
2429 - maximum info is obtained with a command of the form:
2430 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2431 --show-reachable=yes PrintHeader
2432 - the remaining reachable blocks seem to come from the STL
2433 allocation scheme through the usage of map and list. It looks
2434 like this memory cannot be freed but it is not a memory leak
2435 (in fact further invocation to the STL would recollect the
2436 unused memory allthough it cannot explicitely be freed).
2437 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2438 of displaying an image parsed with gdcm and displayed with VTK.
2439 Note: some images don't seem to work e.g.
2440 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2441 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2442 Allthough this weakens the semantics, it is a ditch attempt to
2443 make gdcm more thread friendly.
2445 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2446 * Memory link hunt (by using valgrind through the command
2447 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2448 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2449 gdcmHeader::_dicom_vr.
2450 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2451 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2453 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2455 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2456 * src/Makefile.am now exports all the necessary include files at
2460 * UpdateGroupLength replaced by new one
2463 * UpdateGroupLength re-written using H-Table
2464 (named UpdateGroupLengthNew untill checks are over)
2466 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2467 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2468 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2470 - gdcmHeader::GetPubElValSet removed.
2471 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2472 UpdateGroupLength, WriteElements, Write.
2473 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2474 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2475 carried the same semantics.
2476 - src/gdcmHeaderIdo.cxx changed accordingly.
2477 - gdcmFile::WriteBase now regroups all the codes from previous
2478 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2479 - enum FileType moved to gdcmCommon.h
2480 * src/gdcmHeader.cxx AddDefault trashed
2481 * gdcmGetXSize added
2482 * getimageDataSize now calls gdcmGetXSize
2483 * Test/*.cxx changed to agree with above changes
2485 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2487 (to avoid double call by end user).
2488 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2489 by end user, since gdcmHeader::gdcmHeader now handles it.
2491 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * gdcm/Doc many doxygen changes:
2493 - Doxyfile now has two different versions, DoxyfileUsers that generates
2494 the html.users end users oriented documentation and
2495 DoxyfileDeveloppers that generates the html.developper developper
2496 oriented documentation.
2497 - README changed accordingly
2498 - requirement.txt removed (old design info moved to TODO).
2499 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2500 DoxyMainPage.txt, DoxyPython.txt provide more information.
2501 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2502 be updated by simply regenerating the docs with doxygen and copying
2503 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2504 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2505 all the tests in the form "if (<map>.count() >1)" were removed.
2506 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2507 ill-formed documentation sections.
2508 * src/gdcmHeader.cxx: ditto
2510 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2511 * setup.py fixed for un*x (needed macro for stdint.h)
2512 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2513 un*ces with sh-utils test utility.
2514 * gdcmPython/demo/test.py renamed to PrintHeader.py
2515 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2516 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2517 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2518 * src/gdcm*.cxx JPR's bad inclusion fixed.
2520 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2522 * gdcmPython/demo/test.py changed accordingly.
2524 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2525 * gdcmPython/Makefile.am fixed linking against libstdc++
2526 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2527 * Swig subdir (historical tests of swig version 1.3.17++) removed
2528 * Test/testChangeEntete.cxx some lines commented out in order to make
2530 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2531 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2533 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2534 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2535 hence the user doesn't need this explicit call.
2536 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2537 i.e. LoadElements() call removed.
2538 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2539 - src/Makefile.am declares the proper flag for g++.
2540 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2541 for adding user defined new tags.
2542 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2543 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2544 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2546 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2547 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2548 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2549 src/Makefile.am : the project should properly compile and install
2550 with the autotools, included the python wrappers part.
2551 * gdcm.spec.in : added a spec file for RPM packaging.
2553 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2554 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2556 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2558 to exported to the environement (see gdcmPython/testSuite.py
2560 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2561 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2562 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2563 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2564 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2566 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * gdcmPython/__init__.py doesn't crash anymore when running in
2568 in InstallMode or PreInstallMode but with an environement given
2569 value of GDCM_DICT_PATH.
2570 * src/gdcmDictSet.[cxx/h] coding style.
2572 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2574 * src/gdcm.h general comments moved to TODO, and README
2575 * src/gdcm.h should now be seen as a user commodity (including it
2576 should suffice to fully use gdcm). It is nowhere including within
2577 any of the kernel files src/*.cxx and src/*.h.
2579 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2580 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2581 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2583 * src/gdcm*.cxx only include their corresponding include file
2584 (as opposed to gdcm.h)
2585 * gdcmPython/gdcm.i changed accordingly
2586 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2587 the autogen.sh generated "make snapshot" command to work.
2588 * autogen.sh removed history related references to crea package.
2590 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2591 * distutilsSwigCPlusPlus.py work around some swig portability
2594 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2595 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2596 was done in a last ditch attempt to get setup.py _really_
2597 operationnal. The python/gdcmPython layaout add the advantage
2598 of hidding away the python related distutils specific files
2599 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2600 Alas, the src directory was out of scope (i.e. it's relative
2601 position to setup.py was ../src) which made things impossible to
2602 handle (see previous version of python/setup.py). Crossing fingers...
2604 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * python/setup.py now works on Un*x. (harder than I thougth)
2606 * python/distutilsSwigCPlusPlus.py can now have include files
2607 among the list of sources.
2609 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2610 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2611 * modifications in MSVC projects
2613 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2614 * As stated by the first lines of Test/ExceptionAndPython/README, it
2615 looks like we can move back to original usage of exception within
2616 src/gdcm* and hence remove the errno stuff that was introduced
2617 as a quick and dirty fixture of this problem (added to the TODO).
2618 * Doc/Doxyfile configuration file for Doxygen and corresponding
2619 README file for usage added.
2620 * Test/testWrite.cxx added. This new test comes from a split of
2621 test.cxx that is now reverted to its original purpous i.e.
2622 testing the proper parsing of a Dicom related file.
2623 testWrite.cxx concentrates on testing the IO part of gdcm.
2624 * Test/bug1.cxx (containing a bug on WIn32) added.
2625 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2626 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2627 whose purpose is to publish the content of the TagNames of the
2628 Dicom public dictionnary were not accessible without an
2629 instance of class gdcmHeader.
2630 - those methods are now static methods of gdcmDictSet and hence
2631 require no instances at all to be invocated.
2632 - within gdcmDictSet this change required to change some method
2633 to class methods (i.e. are now static) among which SetDictPath
2634 (renamed to BuildDictPath) and LoadDefaultPubDict.
2635 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2636 the above changes by calling the new method classes of gdcmDictSet.
2637 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2638 the above to be effective.
2639 * python/gdcmPython: in order to wrap properly the above changes
2640 for Python, swig version now needs to be > 1.3.17.
2641 * python/gdcmPython/Makefile fixed to adapt itself to new
2642 configure/make shema introduced by Johan Montagnat (thanks for the
2643 contribution). Alas this Makefile cannot be turned into a proper
2644 Makefile.am without some heavy changes in the configure.in
2645 (for python dectection).
2646 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2647 now avoids publishing the empty entries.
2649 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2650 * python/setup.py : bug fix concerning install under windows
2651 ExtraPath reused :-P
2652 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2654 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2655 * Dicts/dicomV3.dic : remove double spaces !!!
2656 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2657 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2660 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2661 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2662 method. Doxygenation.
2663 * src/gdcm.h clean up of JPR spurious comments.
2665 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * python/distutilsSwigCPlusPlus.py now properly collects the
2667 shadow classes generated by "swig -c++" (gdcm.py in our case)
2668 when using "python setup.py install".
2669 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2670 reexports the working classes.
2671 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2672 by the classical C errno scheme. This is to prevent an obscure
2673 behavior of the python wrappers when importing wxPython.wx prior
2674 to gdcmPython (which ended up in an abort call). An illustration
2675 of this oddity can be found in the Test/ExceptionAndPython
2676 subdir (see the README file). This problem probably due to
2677 an combination of g++ and dynamic loading.
2678 * added Test/ExceptionAndPython (see above)
2680 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * Changed the layout of the python part to avoid bloating main
2682 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2683 i.e. the distutils arsenal. All the python related stuff is
2684 again in a python subdir, but the package itself is now in
2686 * setup.py was cleaned up:
2687 - pythonIncludePath removed
2688 - python setup.py bdist target is now functional.
2689 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2690 collision with other packages). gdcmPython/demo/*.py changed
2693 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2694 * python subdir moved to gdcmPython (preparation of distutils packaging).
2695 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2696 distutils installer is operational.
2697 * - gdcmPython/__init__.py now properly loads the swig generated
2698 shadow classes (from gdcm.py).
2699 - gdcmPython/demo/*.py changed to import the package gdcmPython
2700 instead of gdcmPython/demo/load.py.
2701 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2703 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2704 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2705 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2706 entries within the associated public Dicom dictionary resp. the same
2707 information but sorted by the fourth field (PAT, IMG, DIR) of the
2709 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2710 are now in the "???" group.
2711 - python/gdcm.i changed accordingly,
2712 - python/demo/printGroupedPublicDict.py added, that gives an example
2713 of the above new functionalities in Python.
2715 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * src/gdcm.h, gdcmHeader.cxx:
2717 - historic references to glib's g_malloc and g_free (#defined)
2718 were definitively removed.
2719 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2720 * src/gdcmElValSet.cxx:
2721 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2722 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2723 - GetElValue(string) renamed to GetElValueByName.
2724 - Added GetElementByName(string).
2725 * src/gdcmHeader.cxx: added
2726 - GetPubElValRepByNumber(guint16, guint16)
2727 - GetPubElValRepByName(string)
2728 - GetShaElValRepByNumber(guint16, guint16)
2729 - GetShaElValRepByName(string)
2730 - GetShaElValByNumber(guint16, guint16)
2731 - GetShaElValRepByName(string)
2732 - GetElValRepByNumber(guint16, guint16)
2733 - GetElValRepByName(string)
2734 - GetElValByNumber(guint16, guint16)
2735 - GetElValRepByName(string)
2736 * Doc/requirements.txt added.
2738 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * Test/Makefile building now depends on the one of libgdcm.so
2740 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2741 pixel data) aware which enables finding the address (offset) of
2742 the pixel data of JPEG encoded DICOM files. This leaves only a single
2743 file in the testSuite whose pixel data address (offset) is unknown.
2744 * python/testSuite.py changed accordingly.
2746 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2747 * VC++ has some strong limitations when working with the STL, as stated
2748 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2749 "Also note that some STL containers (map, set, queue, list, deque)
2750 cannot be exported. [...]
2751 Some STL classes contain nested classes. These classes can not
2753 This is caused by a designed limitation that once a template
2754 class is instantiated, it can not be re-instantiated and
2756 Since our usage of map<> is ubiquitous in gdcm, this "designed
2757 limitation" of VC++ is a pitfall.
2758 Hence the Python wrappers of gdcm cannot be incrementally linked
2759 against the c++ dynamic library. The dirty but only workaround is
2760 to forget about incremental link of dynamic libraries and to generate
2761 the Python wrappers library with the inclusions of the underlying C++
2763 The following modifications concern this matter on Win32/VC++:
2764 - wrapping python correct with standalone wrapped dll (don't use separate
2765 dll under windows !!!!)
2766 - python21_d debug mode enabled (ask Frog how to use it :-)
2767 - NO problem with having an STL member of class for example string in C++
2768 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2769 - Python test of dcmlib in Python is ok under windows on a large set
2771 * removed glib references
2772 * typedef's inserted in gdcm.i for correct swig type management
2774 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * python/demo/*.py load.py extracted from test.py. Added explore.py
2776 that only displays required tags and testAll.py that parses all
2777 the files of the testsuite without using unittest.
2778 * python/testSuite.py other additional test on new files added.
2779 * Data/* new test files added accordingly to the testSuite.
2780 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2781 the vr in the file differs from the one of the dictionary.
2783 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2785 values, but limits itself to values which are below a user specified
2786 size (by default 1024 bytes).
2787 * python/gdcm.i : elements not loaded (because their size is above the
2788 user specified treshold) are exported with their TagKey as key of the
2789 python dictionary. This enables the testsuite to make some checks
2790 on the unloaded elements (since we have their offset and size).
2791 * python/testSuite.py
2792 - now tests for the existence and proper value of the pixel data
2793 - two new examples added.
2794 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2796 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2797 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2798 aware. See the strategy comments in gdcmHeader::FindeLength().
2799 * Test/test.cxx now accepts a filename as first argument.
2800 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2801 * python/testSuite.py changed to integrate test on above files.
2803 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2804 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2805 the vr was also RET.
2806 * python/testSuite.py more tests added.
2808 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * python/testSuite.py unittest test suite added (uses Data)
2810 * Data/* dcm and acr files for the test suite.
2811 * glib dependance removed from un*x version. We now use ISO C99
2812 7.18 Integer types (see stdint.h)
2813 - python/Makefile, src/Makefile src/gdcm.h
2814 * src/ when an explicit vr (like dicom files) suddenly poped an
2815 implicit element we use to mark the underlying DictEntry of the
2816 concerned ElValue with "Implicit". This strategy was damageable
2817 too the public or provite dictionaries, since some of their vr
2818 would be changed. Since Header::FindLength heavily relies on the
2819 detection by Header::FindVR of falsely explicit elements, I
2820 added an extra ImplicitVr member to ElValue (boolean).
2821 The rest of the changes we the necessary adaptations.
2823 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2824 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2826 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2828 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2829 * Adaptation for porting to VC++:
2831 o forced to use std namespace (for string to be known)
2832 o all class use __declspec export style on WIN32
2833 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2834 (in stdlib.h on Win32 but in std:: for gcc)
2835 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2836 variable GDCM_DICT_PATH.
2837 * src/gdcmHeader.cxx verbose comments made discrete.
2839 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * python/gdcm.i: added a typemap that converts a C++ hashing table
2841 to native Python dictionary.
2842 * python/demo/test.py:
2843 - now uses the native dictionary for exploration of gdcmHeader.
2844 - takes an optional filename argument (the file to parse).
2845 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2846 PubElVals hashing table.
2847 * Dicts/dicomV3.dic removed error prone trailing spaces.
2849 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * Python wrapping process moved away from src/Makefile to
2851 newly created python/Makefile (as well as gdcm.i)
2852 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2853 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2854 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2855 from the environement variable GDCM_DICT_PATH (when existing).
2856 * src/gdcmDict::GetTag bug fix.
2858 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2859 * Straightforward temporary fixes for swig to build the python wrappers.
2860 src/Makefile now has a python working entry [by working we mean
2861 that we can import de shadow classes without errors].
2863 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * hashtest.cxx removed (since allready in Test)
2865 * src/gdcmlib.h renamed to src/gdcm.h
2866 * src/dcm.i renamed to src/gdcm.i
2867 * src/Makefile prepared for python wrapping
2869 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2870 * src/gdcmHeader.cxx :
2871 - Parsing of header is now separated from loading of element values
2872 (see gdcmHeader::LoadElements).
2873 - general clean up of hopefully all file access (creation of
2874 ReadInt16 and ReadInt32)
2876 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2877 * src/gdcmHeader.cxx :
2878 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2880 - SetLgrElem renamed to SetLength
2881 - GetLgrElem renamed to GetLength
2882 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2883 * src/gdcmElValSet.cxx fixed both GetElValue methods
2884 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2885 due to IdoDude was cleaned out.
2887 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2888 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2889 concentrates on finding the value representation (when it exists).
2890 RecupLgr now only finds the element value length, and it avoids
2891 returning the unecessary skL (skipped length).
2892 Also, offsetCourant was simply removed (with taille_fich) since
2893 it was redundant with the File position internals (by using
2894 ftell and fseek). This also made skL (see above in RecupLgr) usage
2896 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2897 on the libido specificities which are handled through class
2899 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2902 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2903 * Truckload of changes. Parsing of header is barely functional
2904 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2906 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2907 * src/gdcmHeader.cxx many addons of low level methods
2909 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2910 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2911 and _IdDcmSWAP_LONG.
2913 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2914 * This corresponds to all the changes decided at the meeting of
2915 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob