1 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
3 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
4 between the class name and the file name
6 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/ : fix compilation warnings for the Write method (2 different
8 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
9 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
10 variable... create a static method in gdcm::Document to access to
11 this variable content.
13 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
15 file, to be accessed by other files (like gdcmFile). Remove commented
16 code. Move the change of the header to the gdcmFile, using the
18 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
19 To be sure of that (and simplify calls), the Write of the header now
20 gets a file name and not a file pointer (std::ifstream).
21 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
22 DocEntryArchive. Remove all open of the written file
24 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
27 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
29 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
31 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
32 some corresponding methods. Write correctly the file and check before
34 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
35 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
36 is now on RGB datas (as before my last commit
37 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
39 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
41 Add a print information of the type of the entry
42 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
43 It was in the gdcmFile, and all write have been regrouped
44 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
45 Write correctly all dicom files (in decompressed mode only at this time)
46 * Test/ : test on files are now made using Raw datas and not color datas if
48 * Example/PrintFile.cxx : add more printings
50 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * Amelioration of code, remove some code copy. For the loading of
52 BinEntry (in gdcmDocument), add the test to verify if the file is already
55 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
57 remove a DocEntry in the header (push an empty DocEntry)
58 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
59 lines. Bug fix in the initialization of the PixelConvert and the
61 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
62 use in TestCopyDicom (now this test can run under windows... but fails)
63 * Test/TestCopyDicom.cxx : amelioration of the test :
64 - test the pixels written
65 - add test points to quickly find where is the error
66 - can set a file name input and output in arguments
67 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
68 amelioration of the test output
70 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
72 all replaced DocEntry's
73 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
74 Now, each needed DocEntry to modify is duplicated, modified and inserted
75 to the header using DocEntryArchive. Thus, after save, we can restore the
78 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
81 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
83 correct to copy it. The DictEntry is specified at the DocEntry creation,
84 then, it musn't change in the time.
85 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
86 header correctly. At this time, the change is only made for the first
87 level of the Document. In the future, it might consider sequences.
88 The change is made by replacing a DocEntry by an other that is created
89 outside the class. The old value is kept. When we restore the header
90 status, the added DocEntry is deleted and replaced by the old value.
91 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
92 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
93 set the write type to explicit VR, implicit VR or ACR. Add methods to set
94 the write mode to native, decompressed or RGB (but not used at this time)
96 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
98 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
100 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
102 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
104 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
105 set because already copied when copying the BinEntry's of the header
106 * Test/TestAllReadCompareDicom.cxx : remove warnings
108 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
110 Two problems appear when doing it :
111 - with the gdcmFile : when the GetImageData method is called, the pixels
112 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
113 datas (pixels). And each structure destruct the datas when it's
114 destructed. So we have two destructions for the same datas. To solve it,
115 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
116 datas or not. If it doesn't own datas, then they will not destroyed by
118 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
119 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
120 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
121 create a double destruction of the same DocEntry's. So, to solve it,
122 the TagHT is simply cleared and the DicomDir* elements are destroyed.
123 * TODO : add an entry concerning memory leaks in the DicomDir
125 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
127 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
130 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
132 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
133 after it have been deleted
135 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
136 * FIX: src/* fix the doxygen warnings.
137 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
138 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
139 was erroneously defined with a size of 15 instead of 16. [many thanks
140 to Jean Michel Rouet for pointing out this bug].
142 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
143 1. Finish merging JMR patch for writting DICOM from scratch
144 2. Fix -hopefully- bug with MONOCHROME and space vs null character
145 3. Use const ref when possible
146 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
147 5. A few more comments
148 6. CreateUniqueUID can now be called without parameter"
150 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
151 * ENH: Slightly bigger patch:
152 1. Getting toward full integration of JMR patch for writting dicom from scratch
153 2. Update Test to test part of this patch: CreateUniqueUID
154 3. File was not close properly in gdcmDict
155 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
156 5. Use of const ref instead of copy (speed issue)
157 6. Remove temporary (duplicate) string in TranslateToKey
158 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
159 8. Do not repeat virtual in subclasses
160 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
162 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
163 * Apply first patch toward better string comparison when dealing with broken
164 DICOM files. Essentially the string could be padded with a space instead
165 of a null character as defined by standard
167 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
169 because never used... and in the same time, that's remove some memory leaks
171 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmFile.cxx : now delete the PixelConvert instance.
173 * In examples and tests : change the type of image data variables from void*
174 to uint8_t*. Remmove all delete on image data variables
176 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
178 Verify the file pointer value before open the file, and if it's not null,
179 a verbose message is generated.
180 Close correctly the file when the file isn't considered dicom-like. The
181 correctly close is a call to CloseFile.
182 When closing the file pointer, test if its not null to close the file.
183 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
184 file. For an uncompressed image, the copied datas correspond in the least
185 case to the image size (calculated) or the image size specified in the
186 header. A verbose is generated if these two size mismatch
188 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
190 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
191 break under windows (with msvc6 compilation).
193 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
195 compiling with MSVC6)
197 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * Bugs fix for the Windows build with VC6
199 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
200 needed (only for projects required VTK). If the VTK is included in all
201 projects, there is conflicts with the jpeg lib of vtk when compiling the
202 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
203 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
204 when compiling the gdcm_wrap.cxx file (created by the compilation of the
206 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
207 (like it's already made for the cout use). Otherwise, conflict with the
210 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
213 - comments on the DicomDir::Method related usage added.
214 - now that we use the namespace gdcm, a lot of internal classes do
215 NOT need to be wrapped anymore.
216 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
217 DicomDir::Method) new example added.
219 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
220 * Improve string manipulation. I now inforce the notion of 'DicomString'
221 A DicomString can contain as many \0 as they want
222 and it is *always* of even length.
223 We only support odd length for very rare case.
224 And in the near future this should be removed.
226 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
227 * /binary_write/ gdcm source. Now even on big endian we are writting
228 little endian. This should -heopfully- fix some tests
230 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
231 * Now the dictionary is compiled into gdcm lib. This is a default
232 behavior, thus any dic file specified is picked before failback to
233 the one comiled into lib
235 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
236 * Change internals for gdcmDict. Don't use any 'new' any more.
237 This should definitely solve any leak problem, and we should be
238 as fast as before, as long as don't modify too much the dictionary.
240 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
241 * STYLE: ivars should start with a capital letter.
242 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
243 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
245 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
246 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
247 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
248 new 2004 dictionaries added (thanks to JPR).
249 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
250 * CLEANUP_ROUND (15) for gdcmPixelConvert
251 - RLEFrame::NumberFragments is now of type unsigned int
252 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
253 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
256 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
257 * Initial work in gathering all transfer syntax accessors. clearly
258 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
259 ivars, but only one transfersyntax (class) ivar with equivalent method on
262 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
263 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
264 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
265 discussed (plus I didn't like having a 2000 lines patch not commited)
267 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
268 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
269 * CLEANUP_ROUND (14) for gdcmPixelConvert
270 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
271 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
272 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
274 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
275 anymore and hence avoids storing a copy of PixelConvert::Decompressed
276 into File::Pixel_Data.
278 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
279 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
280 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
281 * CLEANUP_ROUND (13) for gdcmPixelConvert
282 Substituted File::ParsePixelData() with PixelConvert::Print() new
284 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
285 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
286 method to those classes.
287 - src/gdcmFile.[cxx|h]:
288 -- Added a ::Print() method.
289 -- PixelConverter is now a reference instead of a member.
290 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
291 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
293 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
295 collaboration diagram and inheritance diagram should be generated with
297 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
298 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
299 pointlessly wrapped (see
300 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
301 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
302 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
303 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
304 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
305 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
306 -- File::Initialise: PixelConverter setup moved away to
307 PixelConverter::GrabInformationsFromHeader()
308 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
309 interpretation moved away to PixelConverter::BuildRGBImage()
311 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
312 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
313 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
315 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
316 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
317 displayed on Win32 when a brutal abort() occurs (because of uncatched
318 exception). See TODO new entry of this commit for more on this.
319 * TODO added new entry.
320 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
321 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
322 - HandleColor is no longer called from gdcmFile.cxx
323 - gdcmPixelConvert.cxx clean up on method arguments and internal
324 variable names for semantical coherence.
326 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Finished lossless transition, not only do we now read all lossless jpeg
328 images, without the need of the Cornwell lib, but we do read them properly now
329 * To reduce code (well to avoid code duplication), I defined a common place
330 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
331 redefine symbols. This is not prefect but this the best solution I found for a
332 compilation time jpeg option.
334 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
335 * Update jpeg ijg lib to support lossless jpeg implementation
336 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
338 * Also added a special copyright for dcmtk since we use their bugfixes.
341 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
342 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
343 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
344 matters, as stated in warning note at begining of %include section).
345 * src/gdcmDicomDir*.[cxx|h]: coding style
346 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
347 * src/gdcmJpeg8.cxx: doxygen fix.
348 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
349 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
350 from File:: to PixelConvert::.
352 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
353 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
354 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
355 - more code moved away from File:: to PixelConvert::
356 - fat setup of PixelConverter set in place in File::Initialise.
358 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
359 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
360 namespace at the file system level. So now you should convert your examples
362 gdcmHeader -> gdcm::Header
363 It would be nice if people keep in mind to no open the namespace, since it
364 allows compilation on broken plateform which were defining common symbol in
365 the standart namespace (like LP, Unknown ...)
367 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
368 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
369 The JPEG fragments are now parsed at the same stage than the RLE
370 information. All code related to JPEG is now in gdcmPixelConvert:
371 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
372 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
373 export a gdcmFile:: method. Those are simply global functions
374 (for the time being this is better than having them attach to
375 either gdcmFile:: or gdcmPixelConvert::).
376 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
377 and stores the result in a gdcmJPEGFragmentsInfo.
378 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
379 code (among other stuff) moved away from gdcmFile:; to
382 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
383 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
384 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
385 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
386 clean up of RLE related code.
387 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
388 - src/gdcmRLE.cxx removed
389 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
390 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
391 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
392 * CLEANUP_ROUND (9) for gdcmPixelConvert
393 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
394 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
395 away from gdcmFile:: to gdcmPixelConvert::.
397 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
398 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
399 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
400 This is because Parse7Fe0 used to parse the pixels to compute the
401 length. This task was passed over to FindDocEntryLengthOB() a long
402 time ago, EXCEPT I had forgotten the OW case...
403 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
404 we just recylce the code for parsing RLE fragments and computing
406 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
407 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
408 with the retired Parse7Fe0().
409 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
410 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
412 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
413 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
414 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
415 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
416 - src/CMakeLists.txt: alphabetic order reodering + new entries.
417 * CLEANUP_ROUND (4) for gdcmPixelConvert
418 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
419 to return an unused length.
421 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
422 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
423 this should be cleanner from the plane view. The iostream are erally a pain
424 to use to do simple stuff.
426 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
427 * Redo the compilation of the ijg jpeg library. Now only one source is
428 necesseray. No need to rename file by hand what so ever. CMake handle the
429 copying of the file within different directory, configure header file to
430 modify some symbol. The only addition made to ijg wasd a mangle table so
431 that symbol are different wether we are within 8bits or 12bits.
433 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
434 * Added documentation of vtkgdcmReader on Website:
435 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
436 with it's binary name).
437 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
438 the Website to be more complete.
439 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
440 doxygenated documentation.
441 - Doc/DoxyVtkGdcmReaderExamples.txt added
442 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
443 DoxyVtkGdmReaderExamples.html )
444 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
445 * CLEANUP_ROUND (3) for gdcmPixelConvert
446 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
448 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
449 * CLEANUP_ROUND (2) for gdcmPixelConvert
450 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
452 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * CLEANUP_ROUND for gdcmPixelConvert:
454 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
455 - src/gdcmPixelStuff[h|cxx] removed
456 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
457 - src/CMakeLists.txt changed accordingly
459 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
460 gdcmVersion.py moved to newly created ATTIC related
461 gdcmPython/SetupOldies/ directory.
462 * Autotools clean up:
463 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
464 - autogen.sh configure.in acinclude.m4 python.m4 removed
466 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * src/*.cxx *.h Reference to License.htm fixed to License.html.
468 * Doc/CMakeLists.txt, doxygen.config.in: fix.
469 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
471 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * TODO updated with Mathieu suggestions. I proposed a template for
473 describing TODO entries and used it for new entries.
474 * Added Doc/Website/CodingStyle.html, Developpers.html,
475 DeveloppersPython.html, GdcmDataCvs.html and
476 DownloadVersion0_1.html, DownloadVersion0_3.html.
477 * Some Doc/*.txt Doxygen files (which do not really concern the
478 documentation itself, but the website) moved to html and
479 placed in directory Doc/Website:
480 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
481 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
482 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
483 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
484 * CMakeLists.txt changed accordingly.
485 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
486 DeveloppersPython.html
487 * INSTALL nows refers to Doc/Website/Installation.html
489 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * Added Doc/Website directory, that contains a first raw version
493 2004-09-23 Jean-Pierre Roux
494 * FIX In order not to be poluted any longer by casting problems,
495 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
496 we can now delete[] it safely
497 * VoidArea is now called BinArea (less confusing name),
498 and all the methods called ...VoidArea... are now ... BinArea...
499 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
501 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
502 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
503 clear) TagHT, which is an inherited member of gdcmElementSet. It is
504 up to the destructor of gdcmElementSet to clean up TagHt and it's
507 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
508 * Test/CMakeLists.txt: update to follow gdcmData renamings.
509 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
511 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * ENH: added some utility method that builds a flat dictionnary
513 holding all the Dicom entries contained in the recursive structure
514 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
516 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
517 BuildFlatHashTable() that build a flat dictionary.
518 - src/gdcmElementSet.h: added a new private GetTag() accessor.
519 gdcmDocument is now a friend of gdcmElementSet.
520 - src/gdcmElementSet.cxx: clean up.
521 - Example/FlatHashTablePrint.cxx added.
522 - Example/CmakeLists.txt changed accordingly
524 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
525 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
526 moved away from gdcmDocEntrySet (since this class is an abstract class
527 acting like an interface). SQDepthLevel and BaseTagKey are now
529 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
530 and associated accessors. Doxygenation of the class.
531 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
533 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
534 Use SQDepthLevel accessor instead. ::Print() adapted.
535 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
536 - src/gdcmDocument.cxx changed accordingly.
538 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
540 - The following is the doxygen comment of the typedef declaration
541 of gdcmagKey in src/gdcmCommon.h:
542 gdcmTagKey is made to old an "universal" (as in URL, Universal
543 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
544 A dicom tag allways has a group and an element, but a set of tags
545 embeded in various (optionally nested) sequences and sharing
546 the same group and element all share the same (group, element)
547 "identifier". Hence the (group, element) cannot be used as an
548 identifier (in gdcm we shall refer to a "TagKey") of a tag.
549 In order to construct a proper tag identifier (i.e. a key) we
550 consider the following definition of a TagKey:
551 - let Group, Element be the string representation of the
552 group and element dicom tag members,
553 - let ItemNumber be the string representation of the integer
554 index of the considered item number of a sequence,
555 Let the key of a tag embeded in a sequence, noted SeqTag, be
557 /ItemNumber#Group|Element
558 where "/", "#" and "|" are characters acting as separators.
559 Then the general form of a gdcmTagKey is given by:
560 Group|Element<SeqTag>
561 where <SeqTag> means NO or many instances of SeqTag.
562 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
565 but the gdcmTagKey of a tag "embeded" is the first item of
566 a sequence, itself nested in the third item of a sequence is the
568 0004|1220/2#0008|0082/0#0008|0090
569 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
570 order to hold the new sequence compatible key. Previously, the
571 GetKey() method would look in the underlying gdcmDictEntry.
572 - src/gdcmDocEntry.cxx:
573 -- constructor now copies the underlying DictEntry key, in the local
575 -- ::Print: displays the member Key, instead of the (group, element).
576 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
577 - src/gdcmDocEntrySet.h:xi
578 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
579 -- now has a new BaseTagKey member.
581 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
582 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
584 This poses the problem with the semantics of the following lines
585 LoadEntryVoidArea(0x0028,0x1201); // R LUT
586 LoadEntryVoidArea(0x0028,0x1202); // G LUT
587 LoadEntryVoidArea(0x0028,0x1203); // B LUT
588 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
589 to the long FIXME note for what the problem is. Nevertheless in
590 order to get things working the dicom dictionary was altered !
591 Please fix things urgently...
592 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
593 information), see above note on moving the member VoidArea. Nevertheless
594 the following entries previously correctly set as US are now inproperly
596 0028 1201 OW IMG Red Palette Color Lookup Table Data
597 0028 1202 OW IMG Green Palette Color Lookup Table Data
598 0028 1203 OW IMG Blue Palette Color Lookup Table Data
599 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
600 of gdcmDocEntry moved to gdcmSeqEntry.
601 * src/gdcmSeqEntry.cxx: STYLE.
603 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
604 * Test/TestAllEntryVerify.cxx minor fix and added comments.
606 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * gdcmPython/testSuite.py: all the test suite in python is now moved
608 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
609 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
610 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
612 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
614 to avoid inclusion recursion until STL is reached.
615 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
616 mecanism. errno.h is not included in gdcm anymore.
617 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
618 (gdcmFormatError now inherits from gdcmFormatUnexpected).
620 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
621 gdcmData/TestAllEntryVerifyReference.txt
622 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
623 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
624 exception_on_error parameter.
625 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
626 - vtk/vtkGdcmReader.cxx changed accordingly,
627 - Example/*.cxx and Test/*.cxx changed accordingly.
629 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
630 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
631 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
632 enable_sequences removed from gdcmHeader constructor and dependencies.
633 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
634 * gdcmPython/demo/PrintHeader.py: dummy fix.
635 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
636 skip_shadow removed from gdcmHeader constructor and dependencies.
637 * Example/*.cxx and Test/*.cxx changed accordingly.
639 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
640 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
641 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
643 2004-07-21 Jean-Pierre Roux
644 * FIX Now, Parsing and Printing a DICOMDIR do work!
645 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
647 2004-07-20 Jean-Pierre Roux
648 * FIX Some brain damaged headers have Zero-Lenght fields
649 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
651 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
653 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
654 variable (instance of gdcmDebug) by a definition macro, and the instance
655 is now in static in the gdcmDebug class
656 * src/gdcmSQItem.h : (FIXME) remove an undefined method
657 * Test/PrintAllDocument.cxx : bug fix in the result of the test
659 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * WARNING: ctest now depends more tightly on gdcmData. You should
661 check out gdcmData properly for things to run smoothly...
662 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
663 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
664 we need the pixels not be loaded in order to use the ValEntry
665 that displays position and size).
666 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
667 This is a C++ based equivalent of gdcmPython/testSuite.py that should
668 be deprecated. If you have any doubts about the advantages of a
669 modern scripting language (read Python) versus grass root C++ (i.e.
670 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
671 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
672 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
673 Anyhow, consider documenting the gdcmData images in
674 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
676 * Test/CMakeLists.txt:
677 - now uses TestAllEntryVerify.cxx
678 - specific comments on oldACR00001.ima (now renamed in gdcmData
679 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
680 gdcmData/TestAllEntryVerifyReference.txt
683 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
684 * src/*.[h|cxx] : typedef clean up
685 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
686 - TagKey renamed to gdcmTagKey (for external usage)
687 - VRKey renamed to gdcmVRKey (for external usage)
688 - removal of typedef duplication.
689 - Removed all unecessary inline keyword from class inline definitions.
690 - Some method|function(void) declarations replaced with method|function().
691 * src/jpeg/libijg12/jdhuff12.c:
692 - printf polluting ctest removed.
693 - TAB removal for comminting
695 - TestAllReadCompareDicom.cxx: added a test that compares all the
696 images in gdcmDataImages.h with corresponding images in
697 gdcmData/BaselineDicom/. When baseline images are not present
698 this test creates them.
699 Note: we need to validate each reference image, but before that
700 I'd like to rename them with a more explicit name...
701 - CMakeLists.txt: changed accordingly.
702 * Example/*.cxx: examples now only include gdcm.h (as opposed to
703 including each header needed).
705 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * Test/*.cxx and Example/*.cxx: moved some examples away from the
707 test suite to the Example directory. Are concerned:
712 - TestWriteSimple.cxx
713 * Test/CMakeLists.txt: added some comments on reasons for black listing
714 image gdcmData/oldACR00001.ima
716 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * Test/CmakeList.txt: removed the following from black list (to be coherent
718 with removal from gdcmData):
719 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
720 - gdcm-MR-PHILIPS-16.dcm
722 Added the following because after last cvs update, they cause
723 ctest -R TestReadWriteReadCompare
725 - gdcm-MR-SIEMENS-16-1.acr
727 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
728 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
729 new comments in this file) we temporarily (sigh) move to a weaker
731 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
732 we don't need to black list the following images anymore:
733 - 8BitsUncompressedColor.dcm
735 - US-PAL-8-10x-echo.dcm
736 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
737 fixes and the beautified code ;-)
738 This fixes the bug introduced in version 1.42 (when beautifying)
739 that made the parsing of 8BitsRunLengthColor.dcm unproper.
740 Note: ctest was blind to this bug (this means we need to still
741 improve the test suite). The bug could be detected by using
742 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
744 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
745 and by displaying the (garbage) produced file temp.XDCM...
747 2004-06-29 Jean-Pierre Roux
748 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
749 - replace by uggly but working old code :-(
750 A lot of things should be OK again.
751 It's really urgent to have a test suite that *tests*,
752 to prevent Frog's beautifying sessions to break all the stuff
753 (twice, withing a fortnigh ...)
755 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
757 redundancy) to added Test/TestReadWriteReadCompare.cxx
758 * Test/CmakeList.txt: because the compare test of
759 Test/TestReadWriteReadCompare.cxx fails, the following images are
760 black listed: - 8BitsUncompressedColor.dcm
762 - US-PAL-8-10x-echo.dcm
763 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
764 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
765 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
766 and ad-hoc kludge. This kludge is now removed, and on encountering
767 such an image (OB field brain damaged) we set errno. Then in
768 ::FindDocLength() we "fix" the length as being ALL what remains
769 in the file (until EOF). We then proceed, hoping for the best...
770 This fixes a SegFault in ShowDicom when trying to write such an
772 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
773 (because TestWriteRead breaks on it, after a non conformal commit?).
774 ctest now runs properly, except for MakeDicomDir (which was allways
775 broken) and the Python related stuff (still not fixed).
777 2004-06-24 Jean-Pierre Roux
778 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
779 FIX : Test/TestReadWrite now iterates on all the file names
780 (instead of infinite loop)
781 ENH : Test/TestWriteRead now iterates on all the file names
783 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
784 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
786 2004-06-24 Jean-Pierre Roux
787 FIX : - now Write drops LUT Descriptors and LUTs (if any)
788 when SamplesPerPixel =3
789 - now Write is no longer confused by
790 'BitsAllocated = 12" and 'BitsStored=12"
791 - "UN" value representation Elements are now written correctly
792 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
793 ENH : - now gdcmHeader has its own Write methods
794 (in order to split the job that has not to be done
797 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
799 loop on the same image until memory went out.
800 Note: this means we still have gobs of memory loss in PrintDocument
801 * src/gdcmDocument.cxx: fixes problem on parsing on file
802 gdcmData/16BitsJpegLosslessGrayScale.dcm.
804 2004-06-24 Jean-Pierre Roux
805 FIX : Write - All the Sequences and Sequence Item are now written
806 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
807 is added a the end, when necessary.
808 - A lot of brain-damaged images, that were read correctly are
809 now written correctly
810 - length compatible BinEntry are now loaded correctly
811 (even for odd groups)
812 Note : only Explicit Value Representation was checked.
813 (question : is implicit VR really necessary for gdcm ?)
815 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
816 * DEVELOPPER: added a proposition of coding style.
817 * src/gdcmDocEntry.h: removed every inline declaration (for test of
820 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
821 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
822 Use the gdcmDocEntry::Print() and Write() instead.
823 * src/gdcmDocument.cxx: bug fix.
825 2004-06-22 Jean-Pierre Roux
826 FIX : gdcmDocument.cxx
827 - Now we do recognize the JpegLossLess format (there was a misstyping in
828 code 'beautyfication' :-(
829 - Now we automaticaticaly load the Luts, if any
831 2004-06-22 Jean-Pierre Roux
832 In order : to write Sequences, whatever their imbrication level,
833 : to allow user to create his own Sequences
834 a lot of modif where necessary (adding, moving, or virtualising methods)
836 WARNING : save your own sources *before* cvs up !
839 ADD virtual void Write(FILE *fp, FileType filetype);
842 ADD virtual void Write(FILE *fp, FileType filetype);
843 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
846 ADD virtual void Write (FILE *fp, FileType filetype)=0;
847 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
848 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
849 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
850 ADD std::string GetEntryByName(TagName name);
851 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
853 std::string vr = "unkn",
854 std::string fourth = "unkn",
855 std::string name = "unkn");
856 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
857 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
858 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
859 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
860 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
861 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
862 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
863 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
866 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
867 ADD virtual std::string GetEntryByName (TagName tagName);
868 ADD virtual std::string GetEntryVRByName (TagName tagName);
869 REM virtual bool Write(FILE *, FileType);
870 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
871 FILE *_fp, FileType type);
872 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
873 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
874 REM virtual bool WriteEntries(FILE *_fp,FileType type);
875 REM virtual std::string GetEntryByName (std::string tagName);
876 REM virtual std::string GetEntryVRByName (std::string tagName);
877 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
878 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
879 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
881 std::string vr = "unkn",
882 std::string fourth = "unkn",
883 std::string name = "unkn");
884 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
885 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
886 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
887 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
890 ADD virtual void Write(FILE *fp, FileType filetype);
893 ADD virtual void Write(FILE *fp,FileType filetype);
896 ADD virtual void Write(FILE *fp, FileType filetype);
897 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
898 REM std::string GetEntryByNumber(guint16 group, guint16 element);
899 REM std::string GetEntryByName(TagName name);
902 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
904 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
905 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
906 The default constructor invoked by the line
907 gdcmHeader *f1 = new gdcmHeader( header );
908 was gdcmHeader::gdcmHeader(bool) instead of the expected
909 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
910 Hence the parsing wasn't executed... See also below.
911 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
912 as explicit constructor didn't do the trick to fix the above problem.
913 Could anyone explain why ?
914 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
915 properly calls gdcmValEntry::Print() (that was weed out from
916 code related to gdcmBinEntry).
918 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
919 * In order to fix memory leaks:
920 - Test/TestWriteSimple.cxx: added cleaning of free store through
922 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
923 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
924 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
925 (through the call to ::AddDicomDirMeta()) or the destructor
926 would crash when deleting uninitialized ::metaElems].
927 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
928 - src/gdcmDocument.cxx:
929 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
931 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
932 was causing memory leaks.
933 - src/gdcmSQItem.cxx:
934 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
935 cleanly handled with polymophism: sorry but my milage is low).
936 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
937 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
938 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
939 This avoids SegFaulting.
940 - src/gdcmSQItem.h: coding style.
942 - Test/TestWriteSimple still severely sucks. The output image content
943 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
944 damaged when displayed with vtkgdcmViewer.
945 - on memory leaks: TestWriteSimple leaks really less (see entry
946 of 2004-06-18 in Changelog file for the call to valgrind).
947 - on segfaults: ctest now passes all the tests but one (no more
949 * Erroneous leading white fix:
950 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
951 white[s] (as opposed to from >> xxx, that removes it [them].
952 - src/gdcmTS.cxx: ditto.
953 - gdcmPython/testSuite.py: dirty related kludge removed.
954 * src/*: remaining references to gdcmParser removed.
955 * src/*[cxx|h]: added copy[way]left header.
958 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
959 * In order to fix writing of dicom files:
960 - Test/TestWriteSimple.cxx: a simpler example of writing.
961 - Test/CMakeLists.txt changed accordingly.
962 - src/gdcmDocument.cxx:
963 -- The destructor now recursilvely removes potential sequences.
964 -- Bug fix in ::IsJPEG2000()
965 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
966 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
968 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
969 to only declared) and build on top of
970 ::GetDocEntryByNumber(guint16, guint16).
971 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
972 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
973 for usage in destructor and treatement of promotion in
974 ::ReplaceOrCreateByNumber().
975 - src/gdcmSQItem.cxx: destructor should better handle his job.
976 Test/TestWriteSimple now runs (or at least it DOES something).
977 * We can now start hutting memory links. A good starting point is:
978 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
979 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
980 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
982 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * Valgrind note: after Mathieu Malaterre teached me how to read
984 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
986 Using gcc, you can force the STL to use malloc and to free memory as
987 soon as possible by globally disabling memory caching.
988 With 3.2.2 and later, you should export the environment variable
989 GLIBCPP_FORCE_NEW before running your program.
990 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
991 simply vanish (it is still not clear to me, whether this means that
992 STL std::string leaks or if valgrind believes it leaks...).
993 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
994 running bin/gdcmTests makeDicomDir):
995 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
996 - Test/makeDicomDir.cxx now properly traps empty lists and returns
998 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
999 SegFaulting (I drowned in DicomDir related code when trying to
1000 understand why the list is empty...).
1001 * src/gdcmDocument.h: first BSD license header try.
1002 * Doc/License.txt added.
1004 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1005 * src/gdcmDocument.[h|cxx]:
1006 - Clean up of the Transfer related predicates. They are now all based
1007 on new method isGivenTransferSyntax, that (should) handle properly
1008 the padding problem.
1009 - general clean up, simplification, and coding style.
1010 - Specific clean up of Parse7FE0() (umproperly named actually).
1011 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1013 2004-06-14 Jean-Pierre Roux
1015 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1016 - fix the display of SQItem ordinal number
1017 - add the GetSQItemByOrdinalNumber method
1018 - remove some useless never written private methods
1020 2004-06-14 Jean-Pierre Roux
1022 - adding a constructor taking a gdcmDocEntry as an input param
1023 - ReplaceOrCreateByNumber now returns :
1024 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1025 a gdcmValEntry * if a string value is passed as a param
1027 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1028 according to the param type (no longer sets a gdcmDocEntry)
1029 - GetValEntryByNumber, GetBinEntryByNumber added
1030 - NewValEntryByNumber and NewBinEntryByNumber added
1032 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1034 - GetSQItemNumber and SetSQItemNumber added, to provide
1035 a (relative) Item identier inside a given Sequence
1036 \warning : some pb remaining around this number
1038 - AddEntry now takes the Item Number as a param
1040 - adding a constructor taking a gdcmDocEntry as an input param
1042 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1043 * Memory leak hunt with the following command:
1044 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1045 --show-reachable=yes gdcmTests PrintDocument
1046 It looks like many (all?) leaks are due to the STL (or a bad usage
1047 of the STL. The lines producing the leaks now have a comment with
1048 a "MEMORY LEAK" tag: you can retrieve them with
1049 grep "MEMORY LEAK" src/*
1050 Here are two typical examples which I can't help fixing:
1055 char * test = "babo";
1056 name = test; //// <--- valgrind detects 960 bytes lost in
1057 //// call to std::string::operator=(char const*)
1058 name.clear(); //// Doesn't help !
1066 std::cout << "Type a bunch of characters followed by RETURN: ";
1067 getline(std::cin, line); //// <--- valgrind dectects a loss
1068 //// of 1320 bytes in call to
1069 /// std::basic_istream<>& std::getline<>
1075 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * src/gdcmHeader.[cxx|h]:
1077 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1078 and related, moved away to gdcmDocument.
1079 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1080 the corresponding protected accessors of inherited class
1081 gdcmDocument, removed ! As a consequence gdcmFile had to be
1082 declared friend of class gdcmDocument (see below).
1083 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1084 - Clean up of undefined or unused methods.
1085 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1086 account the changes to gdcmHeader.h).
1087 * src/gdcmDocument.h:
1088 - gdcmFile is now a friend class (in order to take into account the
1089 changes to gdcmHeader.h).
1090 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1091 (see changes to gdcmHeader.h).
1092 - Accessors (reading on the form GetEntry*) are now public.
1093 - Clean up of undefined or unused methods.
1094 * src/gdcmDocument.cxx:
1095 - adaptation to changes to gdcmDocument.h
1096 - ::OpenFile now writes a verbose message when file cannot be opened.
1097 - some std::string properly set to VRKey
1098 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1099 references to gdcmDocument.
1100 * Test/TestFindTags.cxx: changed accordingly to above changes.
1101 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1102 cvs repository gdcmData.
1104 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1105 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1106 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1107 conflicts with gdcmValEntry::voidArea.
1108 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1109 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1110 Value representation between StringRepresentable and BinaryRepresentable.
1111 * src/gdcmDocument.cxx:
1112 - method ParseDES: proper indentation restored and usage of
1113 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1114 - method LoadDocEntry: the fingerprint left in the SetValue() of
1115 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1116 removed. Reverting to previous code segment with the proper
1117 dynamic_cast< gdcmValEntry* >.
1118 Note: this was (partially) breaking the python test suite
1119 (gdcmPython/testSuite.py) that made usage of the above
1120 fingerprint to check presence of "Pixel Data".
1121 * src/gdcmDocEntry.h: coding style.
1122 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1123 now taken into account.
1124 * gdcmPython/gdcm.i: adaptation to the new internal representation
1125 of gdcm (exit gdcmParser, hello gdcmDocument).
1126 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1128 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1129 anymore, but instead prints the loaded Python dictionary.
1130 * .... alas, the python testSuite is still broken.
1132 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1133 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1135 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1136 * src/gdcmUtil.h : export methods
1138 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1139 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1141 * Initial addition of automatic python testing
1142 * Initial addition of automatic image comparison
1144 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1145 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1146 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1148 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1149 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1150 * Test/ShowDicom.cxx : bug fix for msvc compilation
1151 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1153 2004-05-04 Jean-Pierre Roux
1154 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1155 new concepts (and new classes) :
1156 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1157 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1158 - Sequence Doc Entries (gdcmSeqEntries)
1159 a Sequence is composed of Items.
1160 Each item is a set of Doc Entries (this is recursive)
1161 The non uniqueness of the 'Dicom tag' is due to this recursivity
1162 (never taken into account)
1163 Our unability to add a new 'entry' in the header
1164 at the proper location (neither in the H-Table (map or multimap),
1165 nor in the Chained List is also due to this recursivity.
1166 Don't try, right now, to use/modify/compile these new sources :
1167 nothing is finished.
1168 We just commit all the stuff, 'as is', in order not to loose it.
1170 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1171 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1173 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1174 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1175 file prefix (SetFilePrefix)
1177 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1178 * Add a new test: ShowDicom, for now this is just the c++ version of
1179 checkRead.sh, later it will be able to compare the image read against a
1181 * Replace the DEBUG on the stack with a global entry in cmake interface:
1182 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1184 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1185 * Add an example subdir, with a real example on how to read + write a
1188 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1189 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1190 * Doc/CMakeLists.txt: the main page is now properly differentiated
1191 between the developper and user version.
1192 * Doc/doxygen.config.in: dropped search related obsolete flags
1193 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1195 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1196 * DEVELOPPER: added some helpfull comments for compile/test/install
1199 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1200 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1201 src directory, now generated in the build dir.
1202 2. Tests as mentionned smarter
1204 4. Add a new method in gdcmDict that return the PubDict by name
1205 this is interesting for 3rd party lib like ITK,
1206 where we could set the institution name / patient name...
1208 * ENH: 1. Now the test suite is working for real
1209 2. All binaries are now output in the gdcm-bin directory
1210 (this was not true before)
1212 2004-04-28 Jean-Pierre Roux
1213 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1214 SeQuence indented printing of Dicom Header.
1215 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1216 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1217 Computation of SQDepthLevel is now part of gdcmHeader constructor
1218 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1219 tree-like structure of a Dicom Header.
1220 * FIX Test code cleaning
1222 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1223 * ENH: Adding automatic testing
1224 1. Need a DartConfig.cmake to submit to public
1225 2. Add a test driver gdcmTest.cxx
1226 3. gdcmTestMain, an helper for the main test driver gdcmTest
1227 4. Files in Test don't have a main anymore, this becomes interesting
1228 when we add more and more tests, thus dsw don't have to load
1230 * ENH: Adding a GDCM_DATA_ROOT for testing
1231 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1232 one file instead of seven + some small cleanup
1234 2004-04-22 Jean-Pierre Roux
1235 * ENH Minor changes to the Print() methods.
1236 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1237 Header printing. Example given with :
1238 > PrintHeader fileName 2 new
1239 (SQ based tree-like structure still to be done for the Header ...)
1241 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1242 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1243 1. I have added some unsigned where needed
1244 2. Some function parameter not used -> (void)
1245 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1246 4. g++ don't like character '\' in comment
1247 5. #define jpeg_create_decompress jCreaDecompress
1248 this really need to be fixed
1249 6. virtualize destructor of gdcmObject ... leakage
1250 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1251 this also really need to be fixed
1252 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1253 remove compression file
1254 (as we only do decompression, right ?)
1255 * ENH: Change malloc/calloc/free with c++ equivalent
1257 2004-04-21 Jean-Pierre Roux
1258 * FIX gdcmHeaderHelper::GetXSpacing
1259 when a single value is found (bug ?), xpacing is now
1260 defaulted to yspacing
1262 2004-04-19 Jean-Pierre Roux
1263 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1264 * ENH add parameters :
1265 bool exception_on_error = false,
1266 bool enable_sequences = false,
1267 bool ignore_shadow = false
1268 to the gdcmFile constructors to be full gdcmParser compliant
1269 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1270 to allow reading of PAPYRUS 3.0 files
1272 2004-04-06 Jean-Pierre Roux
1273 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1275 2004-04-02 Jean-Pierre Roux
1276 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1277 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1278 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1280 2004-03-30 Jean-Pierre Roux
1281 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1282 for ACR file, written out as DICOM files (hope so...)
1284 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1285 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1286 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1287 moved to base class gdcmParser and only the specialisation is kept
1289 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1290 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1291 already does the job.
1292 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1293 (to be consistent with gdcmParser::WriteEntries).
1295 2004-03-30 Benoit Regrain
1296 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1297 upate of the object's instance. It's passed to 2 in the unfavorable
1298 case : one in the ExecuteInformation, one in the ExecuteData
1300 2004-03-29 Jean-Pierre Roux
1301 * ENH : Check on file type to be written moved
1302 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1303 * FIX : gdcmObject::ResetBoundaries now stops properly
1304 when end-of-list is reached
1305 : gdcmVersion modified (as Benoit Regrain asked)
1307 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1308 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1309 * src/gdcmUtil.cxx: added forgotten iostream include.
1310 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1311 equivalent to ExplicitVR in existing code).
1313 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1314 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1315 now contains all the gdcmGlobal related code.
1316 * minor coding style and doxygenation changes.
1318 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1319 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1320 now contains all the Debug related code.
1321 * minor clean-up of includes in src/*.cxx
1322 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1323 CreateCleanString) removed.
1324 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1325 * Doc/DoxyMainPageUser.txt added.
1326 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1327 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1328 src/gdcmDirList.cxx)
1330 2004-03-24 Jean-Pierre Roux
1331 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1333 2004-03-23 Jean-Pierre Roux
1334 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1335 big endian made volumes
1336 * ENH Now gdcmParser constructor and destructor are protected to forbid
1337 end user to instanciate class gdcmParser
1338 (only gdcmHeader and gdcmDicomDir are meaningfull)
1340 2004-03-22 Benoit Regrain
1341 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1342 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1343 gdcmSerie to gdcmDicomDirSerie
1345 2004-03-19 Jean-Pierre Roux
1346 * ENH Now the tree-like structure describing a DICOMDIR comming from
1347 an already existing DICOMDIR file is consistent with
1348 the home-made tree-like structure build ex-nihilo
1349 or build from the files held (recursively) in a Directory
1350 functions gdcmDicomDir::CheckBoundaries()
1351 gdcmObject::SetBoundaries() added
1353 2004-03-17 Jean-Pierre Roux
1354 * REM (Eric Boix bug) : removal of meaningless
1355 gdcmDicomDirImage::NewImage function.
1356 * FIX now file names and directory name are written properly in the
1358 * FIX now gdcmDicomDir constructor may be call without any trick
1361 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1362 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1363 of gdcmDicomDirImage::NewImage as empty function.
1365 2004-02-28 Jean-Pierre Roux
1366 * ENH add gdcmDicomDir:NewPatient
1367 add gdcmDicomDirPatient:NewStudy
1368 add gdcmDicomDirStudy:NewSerie
1369 add gdcmDicomDirSerie:NewImage
1370 to allow making gdcDicomDir object.
1371 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1372 (as opposite to the gdcmHeader chained list)
1374 2004-02-11 Benoit Regrain
1375 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1376 when using from python
1378 2004-02-10 Benoit Regrain
1379 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1380 * FIX : in gdcmDicomDir when the directory is empty
1381 * ENH : add callback and methods to get the progression of dicomDir
1384 2004-02-06 Jean-Pierre Roux
1385 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1386 - GDCM_META added to gdcmDicomDirType
1387 - class gdcmMeta created
1388 * ENH : - A brief summary is now displayed at the beginning of
1389 'testDicomDir' to help disaster magnitude estimation
1390 * REM : Now useless Test/explDICOMDIR.cxx
1392 2004-02-05 Benoit Regrain
1393 * ENH : add methods in gdcmObject to get the hash table or the list of
1395 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1396 * FIX : wrapping python for TagHeaderEntryHT
1398 2004-02-04 Benoit Regrain
1399 * FIX : even length for some strings when writting the dicom dir
1400 * FIX : sort the images in the dicom dir
1401 * FIX : Bug fix for python use of dicom dir
1402 * ADD : a python demo
1404 2004-02-04 Jean-Pierre Roux
1405 * FIX : Final solution (?) for icone embedded images
1406 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1407 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1408 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1409 gdcmData/gdcm-MR-SIEMENS-16.acr1
1410 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1411 to make full checking easier
1413 2004-02-04 Benoit Regrain
1414 * FIX : WriteEntries : coding style & logic in parameters
1415 * FIX : Set the elements to create the DicomDir in a dictionary file
1417 2004-02-03 Benoit Regrain
1418 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1419 * gdcmDicomDir : add the load of directory
1420 * Bug fix and print add-on
1422 2004-02-03 Jean-Pierre Roux
1423 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1424 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1425 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1426 * FIX gdcmParser.cxx : 'group length' elements are now considered
1427 as integers, even for shadow groups, when file is Implicit VR
1429 2004-02-02 Jean-Pierre Roux
1430 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1432 of the last synonym :-(
1433 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1435 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1436 * FIX taking into account the possible 7fe0,0010 multiplicity
1437 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1438 to allow removal of references to 7fe0,0010, to deal with
1439 ACR-NEMA images, when 0028,0200 is meaningfull
1441 2004-01-31 Jean-Pierre Roux
1442 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1443 no longer writes 'Un' on disk
1444 * FIX SQ elements with actual length are now dealt with corectly
1445 * FIX gdcmFile::WriteBase make the difference, for color images, between
1446 the length (for Palette expanded images)
1447 and Raw Length (non expanded image + Palette)
1448 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1449 (that broke Write). Replaced by UL.
1450 Aware user will reload the field if he
1451 thinks it's necesssary
1453 2004-01-30 Jean-Pierre Roux
1454 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1455 when 'dirty Acr' is found, to be compliant with the new
1456 IsReadable() methods.
1458 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1459 (no DOUBLE images in kosher DICOM,
1460 but so usefull for people that miss them ;-)
1462 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1463 DICOMDIR related utilities (not checked as Windoze compliant)
1465 2004-01-28 Jean-Pierre Roux
1466 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1468 2004-01-27 Jean-Pierre Roux
1469 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1470 to allow skipping the shadow elements, to save memory space.
1471 The TRUE value for this param has to be used
1472 with a FALSE value for the 'enable_sequence' param.
1473 ('public elements' may be embedded in 'shadow Sequences')
1474 * gdcmHeader methods now deal with 'embedded icones images' in the header
1475 (even when an 'icone image sequence' is announced by the
1476 element (0x0088,0x0200), but there is NO icone at all ...
1478 * gdcmHeader sometimes Image Location value doesn't follow
1479 the supposed processor endianity (see gdcmData/cr172241.dcm).
1482 * gdcmHeader add the method
1483 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1484 to get *all* the Header Entries with the same tag.
1485 GetHeaderEntrySameName is probabely *useless*
1486 (no meaning : Name is *not* an identifier within the Dictionnary)
1488 2004-01-26 Benoit Regrain
1489 * Bug fix in the print of hexadecimal representations. Remove long fields
1490 in the print and add a third level of print to print them
1492 2004-01-23 Benoit Regrain
1493 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1494 * Bug fix on test suite after remove the strip made on not string fields
1495 * Split the IsReadable method between gdcmParser which test that the file
1496 is dicom and gdcmHeader which test that it's an image file
1498 2004-01-22 Benoit Regrain
1499 * DicomDir : clean code, add methods, set variables in protected or private
1500 * gdcmUtil : bug fix for the clean string method
1502 2004-01-19 Benoit Regrain
1503 * Add the use of shadow dictionaries
1504 * bug fix and coding style
1506 2004-01-19 Benoit Regrain
1507 * src/gdcmFile.cxx : bug fix concerning the close of file
1508 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1509 * Add the update of header entries using the shadow library
1511 2004-01-19 Benoit Regrain
1512 * removal of file gdcmHeader2.cxx
1513 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1514 inheriting from gdcmParser. This split is to prepare the integration
1515 of dicom dir parsing
1516 * bug fix under python
1518 2004-01-16 Jean-Pierre Roux
1519 * REM removal of class gdcmHeaderEntrySet
1520 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1521 * ADD add file gdcmHeader2.cxx
1522 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1524 2004-01-15 Benoit Regrain
1525 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1526 entries created while parsing the header. Thus, they will be destroyed
1527 when the gdcmDictSet will be destroyed
1528 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1531 2004-01-15 Benoit Regrain
1532 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1533 made a fatal error because of the memory release at the end of program.
1534 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1535 some memory and vtk seems to have some problems with that.
1536 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1538 2004-01-14 Benoit Regrain
1539 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1540 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1541 * src/*.[h|cxx] : make changes due to class name changes
1542 * gdcmPython/demo/*.py : bug fix due to method names
1544 2004-01-13 Benoit Regrain
1545 * src/*.[h|cxx] : coding style
1546 * vtk/*.[h|cxx] : coding style
1548 2004-01-13 Benoit Regrain
1549 * gdcmPython/testSuite.py : test the readable flag of file for tests
1550 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1551 It's lied to the stl compilation by MSVC (windows, always windows...)
1552 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1554 2004-01-12 Benoit Regrain
1555 * src/*.h : add comments
1556 * src/gdcmDictSet.h : set the method BuildDictPath in public
1557 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1558 directly setted in the source code
1559 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1562 2004-01-09 Benoit Regrain
1563 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1564 * setup.py : use a reference to gdcmVERSION
1566 2004-01-07 Benoit Regrain
1567 * Modification to compile with the distutils.
1570 2003-12-10 Benoit Regrain
1571 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1572 can use a gdcmHeaderHelper to load datas
1573 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1574 made in the source code
1576 2003-12-10 Benoit Regrain
1577 * Update Windows projects and .cvsignore files
1579 2003-11-12 Jean-Pierre Roux
1580 * ENH gdcmHeader constructor has one more parameter (default value : false)
1581 that allows the user to 'go inside' the SeQuences only
1583 gdcmElValSet:Print takes it into account
1585 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1586 * ENH: Update gdcmPython/CMakeLists
1587 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1588 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1590 2003-11-10 Jean-Pierre Roux
1591 * FIX : gdcmHeader::LoadElements is now based
1592 on the ListTag listElem member,
1593 not longer on the TagElValueHT tagHt member
1594 * ENH : PrintPubElVal shows (temporarily) both results,
1595 with the tagHt member and the listElem member.
1596 (it's easier to 'see' the problems when using Printheader)
1598 * FIX : old private member LgrElem is now splitted into
1599 ReadLength : Length actually found on disk (updated only
1600 if bug fixing is necessary), for internal
1602 UsableLength : Updated by FixFoundLength, to fix a bug
1603 or to allow Parser going on.
1604 Will allow to re-write a kosher header when a SeQuence
1605 with a length (not 0000) is found
1606 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1607 because gdcmElValSet::Add does not update ListElem
1610 2003-11-07 Jean-Pierre Roux
1611 * FIX misstyping in Transfert Syntax name table
1612 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1613 when they have an actual length (not 0000 nor FFFFF)
1614 (Nobody should care of it, but DICOMDIR explorers)
1616 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1617 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1619 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1620 * ENH: vtkGdcmReader now supports LUT !
1621 (vtkgdcmViewer for now is not able to use them though)
1623 2003-11-05 Jean-Pierre Roux
1624 * in testSuite.py : new files names for checking the package
1625 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1626 that returns the pixel area size to the *aware* (vtk) user
1627 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1629 2003-11-05 Benoit Regrain
1630 * in testSuite.py : Modify the rules for checking the paths
1631 : Explicit error messages
1632 * in __init__.py : Related modif
1634 2003-11-03 Jean-Pierre Roux
1635 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1636 to be used by aware (vtk) users that want to manage
1637 LUT (and no to turn the PALETTE image into an RGB pixels one)
1638 * GetPixelType now returns 8U for 24 Bits images
1639 (vtkGdcmReader compliant)
1641 2003-10-31 Jean-Pierre Roux
1642 * Removal of *all* gdcmData images and add them again
1643 in order to loose the 'history' of un-anonymised images
1645 2003-10-31 Jean-Pierre Roux
1646 * RMV : removal of useless jBitsInJsample.h
1647 for both 8 and 12 Bits JPEG Lossy Libraries
1649 2003-10-31 Jean-Pierre Roux
1650 * ENH : Add the functions gdcmFile::GetImageDataRaw
1651 gdcmFile::GetImageDataIntoVectorRaw
1652 that act as GetImageData and GetImageDataIntoVector
1653 except the making of an RGB Plane from Gray Plane + LUT
1654 Intended to aware (vtk) users who know how to manage
1657 GetLUTRGBA return a R,G,B,A LUT if any
1658 lgrTotaleRaw gives the 'Raw' length
1659 GetImageDataRaw returns the gray Plane
1660 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1661 (They stay Grey, just like with other Dicom viewers :-(
1663 2003-10-30 Jean-Pierre Roux
1664 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1666 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1667 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1668 being coherents dicom files.
1670 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1671 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1673 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1674 * ENH: Two steps is necessary to please VC++ compiler...
1675 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1676 * ENH: Add include dir to medcon lib
1677 * FIX: only one function is being exported for now !
1678 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1680 2003-10-29 Jean-Pierre Roux
1681 * adding gdcmHeader::GetLUTRGBA
1682 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1683 --> Mathieu, the modif u're waiting for is not yet committed
1684 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1686 2003-10-27 Jean-Pierre Roux
1687 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1688 00191113.dcm DermaColorLossLess.dcm
1689 MxTwinLossLess.dcm RadBWLossLess.dcm
1690 * ENH: For version prior to vtkImageViewer2 -r 1.19
1691 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1693 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1694 * Removal of ido stuff in CMakeLists.txt
1696 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1697 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1698 * FIX: remove a call to ->Modified ... see comments
1699 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1701 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * FIX: Problem with path for libvtkgdcmPython
1703 * ENH: Try adding a search script for python site-package
1704 * RMV: Remove some file from medcon lib that are not necessary
1705 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1706 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1707 * FIX: More pragma disable fro VC++,
1708 I don't think I break something as it is also disable in VTK/ITK.
1709 But it fasten debug compilation time.
1711 2003-10-23 Jean-Pierre Roux
1712 * gdcm now deals with 16 Bits Run Length Encoded images
1713 (they are compressed as 2 planes images,
1714 one for the high Bytes, the other for low Bytes)
1716 2003-10-22 Jean-Pierre Roux
1717 * Now CheckRead takes into account :
1718 - the bugged 'Leonardo' Siemens images
1719 - the XA images, sent thru the burning VPRO station
1720 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1723 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1724 * FIX: When copying a Makefile.am to CMakeLists.txt
1725 one should remove the '\'
1727 2003-10-22 Jean-Pierre Roux
1728 * in gdcmData adding a bugged 'Leonardo' Siemens image
1729 (wrong lengths in header)
1730 OK with gdcm, KO with the other viewers :-)
1731 * add a GE dlx XA image, thru the VEPRO burning station
1734 2003-10-21 Jean-Pierre Roux
1735 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1736 for a brutal checking of vtkgdcmViewer compliance
1738 2003-10-21 Jean-Pierre Roux
1739 * add the files for 'xmedcon' Jpeg Lossless library
1740 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1742 2003-10-21 Jean-Pierre Roux
1743 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1745 2003-10-21 Jean-Pierre Roux
1746 * garbage Siemens 'Leonardo' images dealt with
1747 (the patch is easy to remove)
1748 * cosmetic changes to avoid warnings
1750 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1751 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1752 no need to press 'r' now.
1754 2003-10-20 Jean-Pierre Roux
1755 * upgrade of checkRead.sh checkWrite.sh according
1756 to new Jpeg Lossless decompressor
1757 * add US.3405.1.dcm, a genuine RGB medical file ...
1758 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1759 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1761 2003-10-15 Jean-Pierre Roux
1762 * general anonymisation in gdcmData
1763 * adding the 'color files' from
1764 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1765 * adding some well knowed bugged-header images
1766 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1767 waiting for their inclusion in Python testsuite
1769 2003-10-15 Jean-Pierre Roux
1770 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1771 no longer seg faults when file is not found
1773 2003-10-14 Jean-Pierre Roux
1774 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1777 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1778 * TODO: *.in file to genereate a UseGDCM later
1780 2003-10-14 Jean-Pierre Roux
1781 * Some supposed-to-be Dicom Images have no preamble.
1782 OpenFile takes it into account
1783 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1784 * Missing elements added in dicomV3.dic
1785 (just to be affraid : have a look at
1786 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1787 and do it again next year ;->
1789 2003-10-13 Jean-Pierre Roux
1790 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1791 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1792 But there are NOT. It's fixed !
1794 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1795 * FIX: "jpeglib.h" was not found on VC++
1796 * FIX: vtkgdcm was not being installed
1798 2003-10-10 Jean-Pierre Roux
1799 * ENH : OpenFile closes the file if it *really* doesn't look like
1800 an ACR-NEMA / DICOM one.
1801 * FIX : testWrite no longer writes an empty file if the source file
1802 is not gdcm Readable
1803 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1806 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1807 * FIX: CMake generate now documentation
1808 * ENH: out of source doc build !
1809 * ENH: Generate both user and dev documentation
1810 * ENH: Should work on windows too
1811 * ENH: Only one doxygen config.in file is needed
1812 * FIX: make install should be ok now on ùnix plateform
1813 * FIX: PATH to dictionary was wrong (missing /)
1814 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1816 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1817 * vtkGdcmReader is now able to read rgb dicom file.
1818 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1819 * added a gdcmViewer to vtk test, use mouse to control
1820 window level & window width
1822 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * CMake-ification of gdcm, we have now two build system
1824 * FIX: on cygwin Wsock32 doesn't exist
1825 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1827 2003-10-06 Emanuel Ollart
1828 * FIX : compilation process wad broken.
1829 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1831 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1832 * change gdcmViewer -> vtkgdcmViewer
1833 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1835 2003-10-06 Jean-Pierre Roux
1836 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1837 ( e.g : well known GE images with a wrong elem length,
1838 : Philips MRI Images with a wrong Huffman table)
1839 * still to be done : allow the reading of bugged LEONARDO Siemens images
1841 2003-10-03 Jean-Pierre Roux
1842 * Odd length strings are padded with '\0' (not with spaces,
1843 to remain compliant with already defined strings,
1844 like Transfert Syntax UID and others)
1846 2003-10-03 Jean-Pierre Roux
1847 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1848 to allow displaying RGB images (not only by affim ;-)
1850 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1851 * vtkGdcmReader is now able to read rgb dicom file.
1852 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1854 2003-10-03 Jean-Pierre Roux
1855 * A few nasty patches to allow the reading of a lot of nasty images
1856 ( e.g : well known GE images with a wrong elem length,
1857 : Philips MRI Images with a wrong Huffman table)
1858 * still to be done : allow the reading of bugged LEONARDO Siemens images
1860 2003-10-03 Jean-Pierre Roux
1861 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1863 2003-10-03 Jean-Pierre Roux
1864 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1865 to allow displaying RGB images (not only by affim ;-)
1867 2003-10-03 Jean-Pierre Roux
1868 * gdcmFile::GetImageDataIntoVector now
1869 - deals with MultiFrames MultiFragments Run Length Encoded files
1870 - deals with YcBcR (YBR_FULL) files
1871 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1872 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1874 (no sample found :-(
1876 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1877 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1878 Two reasons: - clear things
1879 - third parties acces gdcm through header files, so won't
1880 suffer anymore VC++ complains
1882 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1883 * add argv[1] in testvtkGdcmReader.cxx
1886 2003-09-24 Jean-Pierre Roux
1887 * The lines are now eigthy characters long.for
1888 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1890 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1891 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1892 char* to std::string. Thus, the use of strdup becomes useless. (see
1893 previous commis of Malaterre)
1894 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1895 before the last Malaterre's commit.
1897 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1898 * This commit should fix the Debug building under VC++, the problem
1899 was mainly a mixture of debug and release lib being loaded at startup.
1900 * I also remove a depency to a specific C function: strdup. Because I had
1901 to force the link to msvcrtd (whereas strdup is in libc).
1903 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1904 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1905 located in the gdcmCommon.h file. All use of reference of tha has been
1906 changed to now use the variable GDCM_UNFOUND.
1908 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1910 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1911 Dicom dictionary. The test suite can now be run again. Note:
1912 I'm note very happy with the " (RET)" changes. I believe this
1913 RETAINED comment should be dropped when parsing the dictionary.
1914 - PACKAGER corrected
1916 - AUTHORS updated and now in alphabetical order
1917 * Makefile.am now exports gdcm.dsw for Windoze users.
1919 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1920 * cygwin complains about missing std:: in subdir Test/
1922 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1923 * remove some methods that are now in gdcmHeaderHelper
1925 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * vtkGdcmReader set spacing and origin correctly
1928 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1929 * Fix a few delete/delete[] mismatch
1931 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1932 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1933 interpretation to data given by gdcmHeader. For instance there are
1934 heuristics to get informations (look at different places).
1935 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1936 sorting DICOM images based on different strategies.
1937 * modified Makefiles accordingly.
1939 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1940 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1941 when building in debug mode
1942 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1943 src/win32/gdcmdll.dsp
1944 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1946 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1947 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1950 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1951 * src/win32/libgdcmjpeg12.dsp was not dos format
1952 * src/win32/libgdcmjpeg12.dsp :
1953 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1954 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1956 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1957 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1959 * src/gdcmFile.cxx : bug fix in affectation type
1960 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1961 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1962 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1963 symbols... future problem ?
1965 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1966 * src/win32/libgdcmijpeg12.dsp was missing
1967 * modified gdcm.dsw accordingly
1969 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1970 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1972 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1973 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1974 commit of JPR (before his hollidays to facilitate our work).
1975 * setup.py : bug fix in code. Modifications made while the last commit
1976 of JPR. The code hasn't been tested before the commit... it's so
1977 useless to make that (for best programmer that is JPR) !!!
1979 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1980 * tagged the current version as Version0_3 (i.e. version 0.3)
1982 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1983 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1984 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1985 * *.dsp : modifications to use new libgdcmijpeg8 library
1986 * setup.py : bug fix on VTKPATH variable
1987 * PACKAGER : adding all concerning windows
1989 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1990 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1992 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1993 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1994 test suite reported error.
1995 * PACKAGER file added (describes what a packager must do when
1996 packaging a new release).
1997 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1998 * configure.in: upgraded version number to 0.3.0
1999 * fixing build of rpm (through rpm -ta):
2000 - Doc/Makefile.am exports proper doxygen files
2001 - src/jpeg/libijg8/Makefile.am exports the include files.
2003 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2004 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2005 * src/gdcmHeader.h : formatting code
2007 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2008 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2009 We were obtaining error message from vtk. Now, creation of file list
2010 is made in an internal list to prevent this problem.
2011 Bug fix when output is empty.
2012 Bug fix in update of progress value. Previous commit for this was a bad
2014 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2016 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2017 * src/gdcmHeader.h : added method to get the file name
2018 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2019 files. Added method to remove all files on the input
2020 Added FIXME comment concerning the bad parsing of header made by
2021 ExecuteInformation method (in ExecuteData method)
2023 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2024 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2025 when using make instal.
2026 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2027 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2029 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2030 * setup.py : adding include dir of jpeg lib to compile all sources
2031 * */Win32/*.dsp : JPR fix for windows compilation
2033 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2034 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2036 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2037 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2039 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2040 * setup.py is again effective on un*x (takes into account the
2041 addon of the jpeg library)
2042 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2043 * Doc/Doxy* updated (includes above enhancements)
2044 * INSTALL now points to web documentation
2046 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2047 * src/gdcmHeader.h doesn't make unnecessary reference to
2049 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2051 * src/gdcm*.[cxx|h] :
2052 - to allow compilation with gcc 3.x
2053 -- clean up of STL usage (added explicit usage of std::)
2054 -- small fixes on exceptions.
2055 Note: linking not tested !
2056 - clean of doxygen comments to avoid warnings at documentation
2058 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2059 dependent convertion).
2061 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2062 * Clean up of previous JPR garbage commit (not even commented in the
2064 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2065 - moved all jpeg related files from src to src/jpeg/libijg8, with
2066 addition/modification of Makefile.am and configure.in.
2067 - the testSuite is still brain damage (not guilty).
2069 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2070 * WrapVTK.py : modifications to get correctly vtk source files to
2072 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2073 (FileName -> Filename)
2075 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2076 * vtk/vtkGdcmReader.[cxx/h]:
2077 - UpdateProgress method should now be effective
2078 - removed the limitation on having only images loaded (as opposed
2080 - when building a stack of images/volume, a lesser number of
2081 gdcmHeader and gdcmFile instances should be used (hopefully
2082 accelerating things).
2083 - when building a stack of images/volumes, files which are not
2084 loadable (wrong path-filename, wrong permissions on existing file,
2085 or file not parsable by gdcm) are replaced with a black image
2086 in the stack (for the caller to notice the problem).
2088 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2091 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2092 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2093 between standard library (std) and vtk library (problems are found
2094 under Windows... thanks Windows !)
2096 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2097 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2099 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2101 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2104 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2105 * When compiling with distutils (see setup.py) the C++ compiler is
2106 called with different flags than the default ones (with automake).
2107 In order to fix all those warning, I compiled gdcm with the command
2108 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2109 and went for warning fixes:
2110 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2111 up from unused variables.
2112 - vtk/vtkGdcmReader.cxx: potential bug fix.
2113 * src/gdcmHeader.h: Doxygen warning cleanup
2115 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2116 * gdcmPython/gdcm.i:
2117 - typemaps correction to take into account the systematic replacement
2118 of "using namespace std" with std:: prefix e.g. std::list,
2119 std::string... (cf changes of 2003-05-21).
2120 - gdcmGlob global variable of type gdcmGlobal (defined in
2121 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2122 exported to Python a as cvar.
2123 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2124 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2125 gdcmDictSet.GetPubDictTagNames() and
2126 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2127 C++ static methods).
2128 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2129 with the above changes.
2131 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2132 * setup.py, manifest.in : bug fix under linux
2134 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2135 * Modification of setup.py to compile vtk part too. Then, we have 2
2136 wrappers which must work with same distutils. For that, we have a
2137 generic distutils in distusiltsWrapping.py ; with :
2138 - build_extWrap class to wrap generically all extensions,
2139 - ExtensionWrap base class for all wrapping extension that contains
2141 - Wrapper interface which wrap sources
2142 + In WrapSwig.py we have extension and wrapper for Swig
2143 + In WrapVTK.py we have extension and wrapper for VTK
2144 * MANIFEST.in : modifications to consider vtk directory and new python
2145 files for compilation
2147 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2148 * Added python wrappers of vtkGdcmReader vtk class (see the
2149 source in vtk/vtkGdcmReader.cxx) :
2150 - vtk/Makefile.am now builds a library
2151 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2152 python library (as opposed to _gdcm.so wich are the python
2153 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2154 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2156 - configure.in has an additional flag --enable-vtk that needs
2157 to be set to enable compilation of vtk related code, that is:
2158 + vtk/vtkGdcmReader.so and
2159 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2160 + gdcmPython/vtkgdcmPython.so (see above)
2161 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2162 be read when compressed or when HighBit + 1 != BitsStored),
2163 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2164 the usage of the python wrapper of vtkGdcmReader vtk class.
2165 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2166 * src/*.[h] all occurences of stl classes are now prefixed with
2167 std::, and all occurences of "using namespace std;" where removed.
2168 This is to avoid pollution of global namespace in included files.
2169 Apparently vtk does not avoid this pitfall: when using both
2170 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2171 collision of various stl members (principally cout...).
2172 * gdcmPython/testSuite.py now cleanly removes temprory generated
2174 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2175 comply with above changes)
2177 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2178 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2179 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2180 vtk data structure (an image Flip was required).
2181 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2182 * cosmetic changes in documentation.
2184 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2185 * src/gdcmHeader.cxx: the constructor no longer exits when an
2186 unexisting file is given as argument.
2187 * The subdirectory Data (containing all the images used for the
2188 test suite) is not part of this repository anymore. A new module
2189 containing those images is now available at
2190 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2191 with the name gdcmData.
2192 All the python scripts (including the package initialisation file
2193 gdcmPython/__init__.py) were adapated to take this change into
2194 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2196 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2197 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2198 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2199 demo of the usage of this class.
2200 Compilation of this vtk part is only done when using the --enable-vtk
2201 at configure (or autogen.sh) stage.
2203 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2204 * More memory link related corrections and documentation fixes.
2206 - maximum info is obtained with a command of the form:
2207 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2208 --show-reachable=yes PrintHeader
2209 - the remaining reachable blocks seem to come from the STL
2210 allocation scheme through the usage of map and list. It looks
2211 like this memory cannot be freed but it is not a memory leak
2212 (in fact further invocation to the STL would recollect the
2213 unused memory allthough it cannot explicitely be freed).
2214 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2215 of displaying an image parsed with gdcm and displayed with VTK.
2216 Note: some images don't seem to work e.g.
2217 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2218 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2219 Allthough this weakens the semantics, it is a ditch attempt to
2220 make gdcm more thread friendly.
2222 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2223 * Memory link hunt (by using valgrind through the command
2224 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2225 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2226 gdcmHeader::_dicom_vr.
2227 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2228 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2230 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2232 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2233 * src/Makefile.am now exports all the necessary include files at
2237 * UpdateGroupLength replaced by new one
2240 * UpdateGroupLength re-written using H-Table
2241 (named UpdateGroupLengthNew untill checks are over)
2243 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2244 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2245 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2247 - gdcmHeader::GetPubElValSet removed.
2248 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2249 UpdateGroupLength, WriteElements, Write.
2250 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2251 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2252 carried the same semantics.
2253 - src/gdcmHeaderIdo.cxx changed accordingly.
2254 - gdcmFile::WriteBase now regroups all the codes from previous
2255 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2256 - enum FileType moved to gdcmCommon.h
2257 * src/gdcmHeader.cxx AddDefault trashed
2258 * gdcmGetXSize added
2259 * getimageDataSize now calls gdcmGetXSize
2260 * Test/*.cxx changed to agree with above changes
2262 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2264 (to avoid double call by end user).
2265 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2266 by end user, since gdcmHeader::gdcmHeader now handles it.
2268 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2269 * gdcm/Doc many doxygen changes:
2270 - Doxyfile now has two different versions, DoxyfileUsers that generates
2271 the html.users end users oriented documentation and
2272 DoxyfileDeveloppers that generates the html.developper developper
2273 oriented documentation.
2274 - README changed accordingly
2275 - requirement.txt removed (old design info moved to TODO).
2276 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2277 DoxyMainPage.txt, DoxyPython.txt provide more information.
2278 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2279 be updated by simply regenerating the docs with doxygen and copying
2280 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2281 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2282 all the tests in the form "if (<map>.count() >1)" were removed.
2283 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2284 ill-formed documentation sections.
2285 * src/gdcmHeader.cxx: ditto
2287 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2288 * setup.py fixed for un*x (needed macro for stdint.h)
2289 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2290 un*ces with sh-utils test utility.
2291 * gdcmPython/demo/test.py renamed to PrintHeader.py
2292 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2293 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2294 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2295 * src/gdcm*.cxx JPR's bad inclusion fixed.
2297 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2298 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2299 * gdcmPython/demo/test.py changed accordingly.
2301 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2302 * gdcmPython/Makefile.am fixed linking against libstdc++
2303 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2304 * Swig subdir (historical tests of swig version 1.3.17++) removed
2305 * Test/testChangeEntete.cxx some lines commented out in order to make
2307 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2308 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2310 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2311 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2312 hence the user doesn't need this explicit call.
2313 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2314 i.e. LoadElements() call removed.
2315 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2316 - src/Makefile.am declares the proper flag for g++.
2317 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2318 for adding user defined new tags.
2319 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2320 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2321 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2323 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2324 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2325 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2326 src/Makefile.am : the project should properly compile and install
2327 with the autotools, included the python wrappers part.
2328 * gdcm.spec.in : added a spec file for RPM packaging.
2330 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2331 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2333 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2334 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2335 to exported to the environement (see gdcmPython/testSuite.py
2337 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2338 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2339 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2340 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2341 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2343 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * gdcmPython/__init__.py doesn't crash anymore when running in
2345 in InstallMode or PreInstallMode but with an environement given
2346 value of GDCM_DICT_PATH.
2347 * src/gdcmDictSet.[cxx/h] coding style.
2349 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2350 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2351 * src/gdcm.h general comments moved to TODO, and README
2352 * src/gdcm.h should now be seen as a user commodity (including it
2353 should suffice to fully use gdcm). It is nowhere including within
2354 any of the kernel files src/*.cxx and src/*.h.
2356 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2358 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2360 * src/gdcm*.cxx only include their corresponding include file
2361 (as opposed to gdcm.h)
2362 * gdcmPython/gdcm.i changed accordingly
2363 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2364 the autogen.sh generated "make snapshot" command to work.
2365 * autogen.sh removed history related references to crea package.
2367 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * distutilsSwigCPlusPlus.py work around some swig portability
2371 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2373 was done in a last ditch attempt to get setup.py _really_
2374 operationnal. The python/gdcmPython layaout add the advantage
2375 of hidding away the python related distutils specific files
2376 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2377 Alas, the src directory was out of scope (i.e. it's relative
2378 position to setup.py was ../src) which made things impossible to
2379 handle (see previous version of python/setup.py). Crossing fingers...
2381 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * python/setup.py now works on Un*x. (harder than I thougth)
2383 * python/distutilsSwigCPlusPlus.py can now have include files
2384 among the list of sources.
2386 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2387 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2388 * modifications in MSVC projects
2390 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * As stated by the first lines of Test/ExceptionAndPython/README, it
2392 looks like we can move back to original usage of exception within
2393 src/gdcm* and hence remove the errno stuff that was introduced
2394 as a quick and dirty fixture of this problem (added to the TODO).
2395 * Doc/Doxyfile configuration file for Doxygen and corresponding
2396 README file for usage added.
2397 * Test/testWrite.cxx added. This new test comes from a split of
2398 test.cxx that is now reverted to its original purpous i.e.
2399 testing the proper parsing of a Dicom related file.
2400 testWrite.cxx concentrates on testing the IO part of gdcm.
2401 * Test/bug1.cxx (containing a bug on WIn32) added.
2402 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2403 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2404 whose purpose is to publish the content of the TagNames of the
2405 Dicom public dictionnary were not accessible without an
2406 instance of class gdcmHeader.
2407 - those methods are now static methods of gdcmDictSet and hence
2408 require no instances at all to be invocated.
2409 - within gdcmDictSet this change required to change some method
2410 to class methods (i.e. are now static) among which SetDictPath
2411 (renamed to BuildDictPath) and LoadDefaultPubDict.
2412 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2413 the above changes by calling the new method classes of gdcmDictSet.
2414 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2415 the above to be effective.
2416 * python/gdcmPython: in order to wrap properly the above changes
2417 for Python, swig version now needs to be > 1.3.17.
2418 * python/gdcmPython/Makefile fixed to adapt itself to new
2419 configure/make shema introduced by Johan Montagnat (thanks for the
2420 contribution). Alas this Makefile cannot be turned into a proper
2421 Makefile.am without some heavy changes in the configure.in
2422 (for python dectection).
2423 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2424 now avoids publishing the empty entries.
2426 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2427 * python/setup.py : bug fix concerning install under windows
2428 ExtraPath reused :-P
2429 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2431 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2432 * Dicts/dicomV3.dic : remove double spaces !!!
2433 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2434 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2437 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2438 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2439 method. Doxygenation.
2440 * src/gdcm.h clean up of JPR spurious comments.
2442 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * python/distutilsSwigCPlusPlus.py now properly collects the
2444 shadow classes generated by "swig -c++" (gdcm.py in our case)
2445 when using "python setup.py install".
2446 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2447 reexports the working classes.
2448 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2449 by the classical C errno scheme. This is to prevent an obscure
2450 behavior of the python wrappers when importing wxPython.wx prior
2451 to gdcmPython (which ended up in an abort call). An illustration
2452 of this oddity can be found in the Test/ExceptionAndPython
2453 subdir (see the README file). This problem probably due to
2454 an combination of g++ and dynamic loading.
2455 * added Test/ExceptionAndPython (see above)
2457 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * Changed the layout of the python part to avoid bloating main
2459 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2460 i.e. the distutils arsenal. All the python related stuff is
2461 again in a python subdir, but the package itself is now in
2463 * setup.py was cleaned up:
2464 - pythonIncludePath removed
2465 - python setup.py bdist target is now functional.
2466 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2467 collision with other packages). gdcmPython/demo/*.py changed
2470 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * python subdir moved to gdcmPython (preparation of distutils packaging).
2472 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2473 distutils installer is operational.
2474 * - gdcmPython/__init__.py now properly loads the swig generated
2475 shadow classes (from gdcm.py).
2476 - gdcmPython/demo/*.py changed to import the package gdcmPython
2477 instead of gdcmPython/demo/load.py.
2478 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2480 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2481 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2482 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2483 entries within the associated public Dicom dictionary resp. the same
2484 information but sorted by the fourth field (PAT, IMG, DIR) of the
2486 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2487 are now in the "???" group.
2488 - python/gdcm.i changed accordingly,
2489 - python/demo/printGroupedPublicDict.py added, that gives an example
2490 of the above new functionalities in Python.
2492 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2493 * src/gdcm.h, gdcmHeader.cxx:
2494 - historic references to glib's g_malloc and g_free (#defined)
2495 were definitively removed.
2496 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2497 * src/gdcmElValSet.cxx:
2498 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2499 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2500 - GetElValue(string) renamed to GetElValueByName.
2501 - Added GetElementByName(string).
2502 * src/gdcmHeader.cxx: added
2503 - GetPubElValRepByNumber(guint16, guint16)
2504 - GetPubElValRepByName(string)
2505 - GetShaElValRepByNumber(guint16, guint16)
2506 - GetShaElValRepByName(string)
2507 - GetShaElValByNumber(guint16, guint16)
2508 - GetShaElValRepByName(string)
2509 - GetElValRepByNumber(guint16, guint16)
2510 - GetElValRepByName(string)
2511 - GetElValByNumber(guint16, guint16)
2512 - GetElValRepByName(string)
2513 * Doc/requirements.txt added.
2515 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2516 * Test/Makefile building now depends on the one of libgdcm.so
2517 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2518 pixel data) aware which enables finding the address (offset) of
2519 the pixel data of JPEG encoded DICOM files. This leaves only a single
2520 file in the testSuite whose pixel data address (offset) is unknown.
2521 * python/testSuite.py changed accordingly.
2523 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2524 * VC++ has some strong limitations when working with the STL, as stated
2525 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2526 "Also note that some STL containers (map, set, queue, list, deque)
2527 cannot be exported. [...]
2528 Some STL classes contain nested classes. These classes can not
2530 This is caused by a designed limitation that once a template
2531 class is instantiated, it can not be re-instantiated and
2533 Since our usage of map<> is ubiquitous in gdcm, this "designed
2534 limitation" of VC++ is a pitfall.
2535 Hence the Python wrappers of gdcm cannot be incrementally linked
2536 against the c++ dynamic library. The dirty but only workaround is
2537 to forget about incremental link of dynamic libraries and to generate
2538 the Python wrappers library with the inclusions of the underlying C++
2540 The following modifications concern this matter on Win32/VC++:
2541 - wrapping python correct with standalone wrapped dll (don't use separate
2542 dll under windows !!!!)
2543 - python21_d debug mode enabled (ask Frog how to use it :-)
2544 - NO problem with having an STL member of class for example string in C++
2545 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2546 - Python test of dcmlib in Python is ok under windows on a large set
2548 * removed glib references
2549 * typedef's inserted in gdcm.i for correct swig type management
2551 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * python/demo/*.py load.py extracted from test.py. Added explore.py
2553 that only displays required tags and testAll.py that parses all
2554 the files of the testsuite without using unittest.
2555 * python/testSuite.py other additional test on new files added.
2556 * Data/* new test files added accordingly to the testSuite.
2557 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2558 the vr in the file differs from the one of the dictionary.
2560 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2562 values, but limits itself to values which are below a user specified
2563 size (by default 1024 bytes).
2564 * python/gdcm.i : elements not loaded (because their size is above the
2565 user specified treshold) are exported with their TagKey as key of the
2566 python dictionary. This enables the testsuite to make some checks
2567 on the unloaded elements (since we have their offset and size).
2568 * python/testSuite.py
2569 - now tests for the existence and proper value of the pixel data
2570 - two new examples added.
2571 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2573 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2574 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2575 aware. See the strategy comments in gdcmHeader::FindeLength().
2576 * Test/test.cxx now accepts a filename as first argument.
2577 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2578 * python/testSuite.py changed to integrate test on above files.
2580 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2581 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2582 the vr was also RET.
2583 * python/testSuite.py more tests added.
2585 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2586 * python/testSuite.py unittest test suite added (uses Data)
2587 * Data/* dcm and acr files for the test suite.
2588 * glib dependance removed from un*x version. We now use ISO C99
2589 7.18 Integer types (see stdint.h)
2590 - python/Makefile, src/Makefile src/gdcm.h
2591 * src/ when an explicit vr (like dicom files) suddenly poped an
2592 implicit element we use to mark the underlying DictEntry of the
2593 concerned ElValue with "Implicit". This strategy was damageable
2594 too the public or provite dictionaries, since some of their vr
2595 would be changed. Since Header::FindLength heavily relies on the
2596 detection by Header::FindVR of falsely explicit elements, I
2597 added an extra ImplicitVr member to ElValue (boolean).
2598 The rest of the changes we the necessary adaptations.
2600 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2601 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2603 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2605 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2606 * Adaptation for porting to VC++:
2608 o forced to use std namespace (for string to be known)
2609 o all class use __declspec export style on WIN32
2610 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2611 (in stdlib.h on Win32 but in std:: for gcc)
2612 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2613 variable GDCM_DICT_PATH.
2614 * src/gdcmHeader.cxx verbose comments made discrete.
2616 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * python/gdcm.i: added a typemap that converts a C++ hashing table
2618 to native Python dictionary.
2619 * python/demo/test.py:
2620 - now uses the native dictionary for exploration of gdcmHeader.
2621 - takes an optional filename argument (the file to parse).
2622 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2623 PubElVals hashing table.
2624 * Dicts/dicomV3.dic removed error prone trailing spaces.
2626 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2627 * Python wrapping process moved away from src/Makefile to
2628 newly created python/Makefile (as well as gdcm.i)
2629 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2630 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2631 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2632 from the environement variable GDCM_DICT_PATH (when existing).
2633 * src/gdcmDict::GetTag bug fix.
2635 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2636 * Straightforward temporary fixes for swig to build the python wrappers.
2637 src/Makefile now has a python working entry [by working we mean
2638 that we can import de shadow classes without errors].
2640 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * hashtest.cxx removed (since allready in Test)
2642 * src/gdcmlib.h renamed to src/gdcm.h
2643 * src/dcm.i renamed to src/gdcm.i
2644 * src/Makefile prepared for python wrapping
2646 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2647 * src/gdcmHeader.cxx :
2648 - Parsing of header is now separated from loading of element values
2649 (see gdcmHeader::LoadElements).
2650 - general clean up of hopefully all file access (creation of
2651 ReadInt16 and ReadInt32)
2653 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2654 * src/gdcmHeader.cxx :
2655 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2657 - SetLgrElem renamed to SetLength
2658 - GetLgrElem renamed to GetLength
2659 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2660 * src/gdcmElValSet.cxx fixed both GetElValue methods
2661 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2662 due to IdoDude was cleaned out.
2664 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2665 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2666 concentrates on finding the value representation (when it exists).
2667 RecupLgr now only finds the element value length, and it avoids
2668 returning the unecessary skL (skipped length).
2669 Also, offsetCourant was simply removed (with taille_fich) since
2670 it was redundant with the File position internals (by using
2671 ftell and fseek). This also made skL (see above in RecupLgr) usage
2673 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2674 on the libido specificities which are handled through class
2676 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2679 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2680 * Truckload of changes. Parsing of header is barely functional
2681 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2683 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2684 * src/gdcmHeader.cxx many addons of low level methods
2686 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2687 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2688 and _IdDcmSWAP_LONG.
2690 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * This corresponds to all the changes decided at the meeting of
2692 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob