1 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
3 to avoid inclusion recursion until STL is reached.
4 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
5 mecanism. errno.h is not included in gdcm anymore.
6 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
7 (gdcmFormatError now inherits from gdcmFormatUnexpected).
10 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
11 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
12 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
13 enable_sequences removed from gdcmHeader constructor and dependencies.
14 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
15 * gdcmPython/demo/PrintHeader.py: dummy fix.
16 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
17 skip_shadow removed from gdcmHeader constructor and dependencies.
18 * Example/*.cxx and Test/*.cxx changed accordingly.
20 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
21 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
22 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
24 2004-07-21 Jean-Pierre Roux
25 * FIX Now, Parsing and Printing a DICOMDIR do work!
26 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
28 2004-07-20 Jean-Pierre Roux
29 * FIX Some brain damaged headers have Zero-Lenght fields
30 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
32 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
34 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
35 variable (instance of gdcmDebug) by a definition macro, and the instance
36 is now in static in the gdcmDebug class
37 * src/gdcmSQItem.h : (FIXME) remove an undefined method
38 * Test/PrintAllDocument.cxx : bug fix in the result of the test
40 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
41 * WARNING: ctest now depends more tightly on gdcmData. You should
42 check out gdcmData properly for things to run smoothly...
43 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
44 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
45 we need the pixels not be loaded in order to use the ValEntry
46 that displays position and size).
47 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
48 This is a C++ based equivalent of gdcmPython/testSuite.py that should
49 be deprecated. If you have any doubts about the advantages of a
50 modern scripting language (read Python) versus grass root C++ (i.e.
51 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
52 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
53 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
54 Anyhow, consider documenting the gdcmData images in
55 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
57 * Test/CMakeLists.txt:
58 - now uses TestAllEntryVerify.cxx
59 - specific comments on oldACR00001.ima (now renamed in gdcmData
60 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
61 gdcmData/TestAllEntryVerifyReference.txt
64 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
65 * src/*.[h|cxx] : typedef clean up
66 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
67 - TagKey renamed to gdcmTagKey (for external usage)
68 - VRKey renamed to gdcmVRKey (for external usage)
69 - removal of typedef duplication.
70 - Removed all unecessary inline keyword from class inline definitions.
71 - Some method|function(void) declarations replaced with method|function().
72 * src/jpeg/libijg12/jdhuff12.c:
73 - printf polluting ctest removed.
74 - TAB removal for comminting
76 - TestAllReadCompareDicom.cxx: added a test that compares all the
77 images in gdcmDataImages.h with corresponding images in
78 gdcmData/BaselineDicom/. When baseline images are not present
79 this test creates them.
80 Note: we need to validate each reference image, but before that
81 I'd like to rename them with a more explicit name...
82 - CMakeLists.txt: changed accordingly.
83 * Example/*.cxx: examples now only include gdcm.h (as opposed to
84 including each header needed).
86 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * Test/*.cxx and Example/*.cxx: moved some examples away from the
88 test suite to the Example directory. Are concerned:
94 * Test/CMakeLists.txt: added some comments on reasons for black listing
95 image gdcmData/oldACR00001.ima
97 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * Test/CmakeList.txt: removed the following from black list (to be coherent
99 with removal from gdcmData):
100 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
101 - gdcm-MR-PHILIPS-16.dcm
103 Added the following because after last cvs update, they cause
104 ctest -R TestReadWriteReadCompare
106 - gdcm-MR-SIEMENS-16-1.acr
108 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
109 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
110 new comments in this file) we temporarily (sigh) move to a weaker
112 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
113 we don't need to black list the following images anymore:
114 - 8BitsUncompressedColor.dcm
116 - US-PAL-8-10x-echo.dcm
117 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
118 fixes and the beautified code ;-)
119 This fixes the bug introduced in version 1.42 (when beautifying)
120 that made the parsing of 8BitsRunLengthColor.dcm unproper.
121 Note: ctest was blind to this bug (this means we need to still
122 improve the test suite). The bug could be detected by using
123 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
125 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
126 and by displaying the (garbage) produced file temp.XDCM...
128 2004-06-29 Jean-Pierre Roux
129 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
130 - replace by uggly but working old code :-(
131 A lot of things should be OK again.
132 It's really urgent to have a test suite that *tests*,
133 to prevent Frog's beautifying sessions to break all the stuff
134 (twice, withing a fortnigh ...)
136 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
137 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
138 redundancy) to added Test/TestReadWriteReadCompare.cxx
139 * Test/CmakeList.txt: because the compare test of
140 Test/TestReadWriteReadCompare.cxx fails, the following images are
141 black listed: - 8BitsUncompressedColor.dcm
143 - US-PAL-8-10x-echo.dcm
144 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
145 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
146 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
147 and ad-hoc kludge. This kludge is now removed, and on encountering
148 such an image (OB field brain damaged) we set errno. Then in
149 ::FindDocLength() we "fix" the length as being ALL what remains
150 in the file (until EOF). We then proceed, hoping for the best...
151 This fixes a SegFault in ShowDicom when trying to write such an
153 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
154 (because TestWriteRead breaks on it, after a non conformal commit?).
155 ctest now runs properly, except for MakeDicomDir (which was allways
156 broken) and the Python related stuff (still not fixed).
158 2004-06-24 Jean-Pierre Roux
159 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
160 FIX : Test/TestReadWrite now iterates on all the file names
161 (instead of infinite loop)
162 ENH : Test/TestWriteRead now iterates on all the file names
164 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
165 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
167 2004-06-24 Jean-Pierre Roux
168 FIX : - now Write drops LUT Descriptors and LUTs (if any)
169 when SamplesPerPixel =3
170 - now Write is no longer confused by
171 'BitsAllocated = 12" and 'BitsStored=12"
172 - "UN" value representation Elements are now written correctly
173 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
174 ENH : - now gdcmHeader has its own Write methods
175 (in order to split the job that has not to be done
178 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
179 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
180 loop on the same image until memory went out.
181 Note: this means we still have gobs of memory loss in PrintDocument
182 * src/gdcmDocument.cxx: fixes problem on parsing on file
183 gdcmData/16BitsJpegLosslessGrayScale.dcm.
185 2004-06-24 Jean-Pierre Roux
186 FIX : Write - All the Sequences and Sequence Item are now written
187 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
188 is added a the end, when necessary.
189 - A lot of brain-damaged images, that were read correctly are
190 now written correctly
191 - length compatible BinEntry are now loaded correctly
192 (even for odd groups)
193 Note : only Explicit Value Representation was checked.
194 (question : is implicit VR really necessary for gdcm ?)
196 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
197 * DEVELOPPER: added a proposition of coding style.
198 * src/gdcmDocEntry.h: removed every inline declaration (for test of
201 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
202 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
203 Use the gdcmDocEntry::Print() and Write() instead.
204 * src/gdcmDocument.cxx: bug fix.
206 2004-06-22 Jean-Pierre Roux
207 FIX : gdcmDocument.cxx
208 - Now we do recognize the JpegLossLess format (there was a misstyping in
209 code 'beautyfication' :-(
210 - Now we automaticaticaly load the Luts, if any
212 2004-06-22 Jean-Pierre Roux
213 In order : to write Sequences, whatever their imbrication level,
214 : to allow user to create his own Sequences
215 a lot of modif where necessary (adding, moving, or virtualising methods)
217 WARNING : save your own sources *before* cvs up !
220 ADD virtual void Write(FILE *fp, FileType filetype);
223 ADD virtual void Write(FILE *fp, FileType filetype);
224 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
227 ADD virtual void Write (FILE *fp, FileType filetype)=0;
228 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
229 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
230 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
231 ADD std::string GetEntryByName(TagName name);
232 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
234 std::string vr = "unkn",
235 std::string fourth = "unkn",
236 std::string name = "unkn");
237 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
238 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
239 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
240 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
241 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
242 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
243 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
244 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
247 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
248 ADD virtual std::string GetEntryByName (TagName tagName);
249 ADD virtual std::string GetEntryVRByName (TagName tagName);
250 REM virtual bool Write(FILE *, FileType);
251 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
252 FILE *_fp, FileType type);
253 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
254 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
255 REM virtual bool WriteEntries(FILE *_fp,FileType type);
256 REM virtual std::string GetEntryByName (std::string tagName);
257 REM virtual std::string GetEntryVRByName (std::string tagName);
258 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
259 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
260 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
262 std::string vr = "unkn",
263 std::string fourth = "unkn",
264 std::string name = "unkn");
265 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
266 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
267 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
268 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
271 ADD virtual void Write(FILE *fp, FileType filetype);
274 ADD virtual void Write(FILE *fp,FileType filetype);
277 ADD virtual void Write(FILE *fp, FileType filetype);
278 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
279 REM std::string GetEntryByNumber(guint16 group, guint16 element);
280 REM std::string GetEntryByName(TagName name);
283 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
285 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
286 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
287 The default constructor invoked by the line
288 gdcmHeader *f1 = new gdcmHeader( header );
289 was gdcmHeader::gdcmHeader(bool) instead of the expected
290 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
291 Hence the parsing wasn't executed... See also below.
292 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
293 as explicit constructor didn't do the trick to fix the above problem.
294 Could anyone explain why ?
295 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
296 properly calls gdcmValEntry::Print() (that was weed out from
297 code related to gdcmBinEntry).
299 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * In order to fix memory leaks:
301 - Test/TestWriteSimple.cxx: added cleaning of free store through
303 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
304 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
305 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
306 (through the call to ::AddDicomDirMeta()) or the destructor
307 would crash when deleting uninitialized ::metaElems].
308 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
309 - src/gdcmDocument.cxx:
310 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
312 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
313 was causing memory leaks.
314 - src/gdcmSQItem.cxx:
315 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
316 cleanly handled with polymophism: sorry but my milage is low).
317 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
318 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
319 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
320 This avoids SegFaulting.
321 - src/gdcmSQItem.h: coding style.
323 - Test/TestWriteSimple still severely sucks. The output image content
324 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
325 damaged when displayed with vtkgdcmViewer.
326 - on memory leaks: TestWriteSimple leaks really less (see entry
327 of 2004-06-18 in Changelog file for the call to valgrind).
328 - on segfaults: ctest now passes all the tests but one (no more
330 * Erroneous leading white fix:
331 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
332 white[s] (as opposed to from >> xxx, that removes it [them].
333 - src/gdcmTS.cxx: ditto.
334 - gdcmPython/testSuite.py: dirty related kludge removed.
335 * src/*: remaining references to gdcmParser removed.
336 * src/*[cxx|h]: added copy[way]left header.
339 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
340 * In order to fix writing of dicom files:
341 - Test/TestWriteSimple.cxx: a simpler example of writing.
342 - Test/CMakeLists.txt changed accordingly.
343 - src/gdcmDocument.cxx:
344 -- The destructor now recursilvely removes potential sequences.
345 -- Bug fix in ::IsJPEG2000()
346 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
347 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
349 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
350 to only declared) and build on top of
351 ::GetDocEntryByNumber(guint16, guint16).
352 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
353 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
354 for usage in destructor and treatement of promotion in
355 ::ReplaceOrCreateByNumber().
356 - src/gdcmSQItem.cxx: destructor should better handle his job.
357 Test/TestWriteSimple now runs (or at least it DOES something).
358 * We can now start hutting memory links. A good starting point is:
359 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
360 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
361 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
363 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
364 * Valgrind note: after Mathieu Malaterre teached me how to read
365 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
367 Using gcc, you can force the STL to use malloc and to free memory as
368 soon as possible by globally disabling memory caching.
369 With 3.2.2 and later, you should export the environment variable
370 GLIBCPP_FORCE_NEW before running your program.
371 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
372 simply vanish (it is still not clear to me, whether this means that
373 STL std::string leaks or if valgrind believes it leaks...).
374 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
375 running bin/gdcmTests makeDicomDir):
376 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
377 - Test/makeDicomDir.cxx now properly traps empty lists and returns
379 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
380 SegFaulting (I drowned in DicomDir related code when trying to
381 understand why the list is empty...).
382 * src/gdcmDocument.h: first BSD license header try.
383 * Doc/License.txt added.
385 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * src/gdcmDocument.[h|cxx]:
387 - Clean up of the Transfer related predicates. They are now all based
388 on new method isGivenTransferSyntax, that (should) handle properly
390 - general clean up, simplification, and coding style.
391 - Specific clean up of Parse7FE0() (umproperly named actually).
392 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
394 2004-06-14 Jean-Pierre Roux
396 - fix the display of Sequence Delimitor (SQDepthLevel pb)
397 - fix the display of SQItem ordinal number
398 - add the GetSQItemByOrdinalNumber method
399 - remove some useless never written private methods
401 2004-06-14 Jean-Pierre Roux
403 - adding a constructor taking a gdcmDocEntry as an input param
404 - ReplaceOrCreateByNumber now returns :
405 a gdcmBinEntry * if a Binary (void *) value is passed as a param
406 a gdcmValEntry * if a string value is passed as a param
408 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
409 according to the param type (no longer sets a gdcmDocEntry)
410 - GetValEntryByNumber, GetBinEntryByNumber added
411 - NewValEntryByNumber and NewBinEntryByNumber added
413 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
415 - GetSQItemNumber and SetSQItemNumber added, to provide
416 a (relative) Item identier inside a given Sequence
417 \warning : some pb remaining around this number
419 - AddEntry now takes the Item Number as a param
421 - adding a constructor taking a gdcmDocEntry as an input param
423 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
424 * Memory leak hunt with the following command:
425 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
426 --show-reachable=yes gdcmTests PrintDocument
427 It looks like many (all?) leaks are due to the STL (or a bad usage
428 of the STL. The lines producing the leaks now have a comment with
429 a "MEMORY LEAK" tag: you can retrieve them with
430 grep "MEMORY LEAK" src/*
431 Here are two typical examples which I can't help fixing:
436 char * test = "babo";
437 name = test; //// <--- valgrind detects 960 bytes lost in
438 //// call to std::string::operator=(char const*)
439 name.clear(); //// Doesn't help !
447 std::cout << "Type a bunch of characters followed by RETURN: ";
448 getline(std::cin, line); //// <--- valgrind dectects a loss
449 //// of 1320 bytes in call to
450 /// std::basic_istream<>& std::getline<>
456 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
457 * src/gdcmHeader.[cxx|h]:
458 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
459 and related, moved away to gdcmDocument.
460 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
461 the corresponding protected accessors of inherited class
462 gdcmDocument, removed ! As a consequence gdcmFile had to be
463 declared friend of class gdcmDocument (see below).
464 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
465 - Clean up of undefined or unused methods.
466 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
467 account the changes to gdcmHeader.h).
468 * src/gdcmDocument.h:
469 - gdcmFile is now a friend class (in order to take into account the
470 changes to gdcmHeader.h).
471 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
472 (see changes to gdcmHeader.h).
473 - Accessors (reading on the form GetEntry*) are now public.
474 - Clean up of undefined or unused methods.
475 * src/gdcmDocument.cxx:
476 - adaptation to changes to gdcmDocument.h
477 - ::OpenFile now writes a verbose message when file cannot be opened.
478 - some std::string properly set to VRKey
479 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
480 references to gdcmDocument.
481 * Test/TestFindTags.cxx: changed accordingly to above changes.
482 * gdcmPython/testSuite.py: adapted to renaming of acr files in
483 cvs repository gdcmData.
485 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
486 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
487 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
488 conflicts with gdcmValEntry::voidArea.
489 * src/gdcmValEntry.cxx: unmatching comment wiped out.
490 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
491 Value representation between StringRepresentable and BinaryRepresentable.
492 * src/gdcmDocument.cxx:
493 - method ParseDES: proper indentation restored and usage of
494 gdcmVR::IsVROfGdcmStringRepresentable wired in.
495 - method LoadDocEntry: the fingerprint left in the SetValue() of
496 unloaded entries (length > MaxSizeLoadEntry) had curiously been
497 removed. Reverting to previous code segment with the proper
498 dynamic_cast< gdcmValEntry* >.
499 Note: this was (partially) breaking the python test suite
500 (gdcmPython/testSuite.py) that made usage of the above
501 fingerprint to check presence of "Pixel Data".
502 * src/gdcmDocEntry.h: coding style.
503 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
504 now taken into account.
505 * gdcmPython/gdcm.i: adaptation to the new internal representation
506 of gdcm (exit gdcmParser, hello gdcmDocument).
507 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
509 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
510 anymore, but instead prints the loaded Python dictionary.
511 * .... alas, the python testSuite is still broken.
513 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
516 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
517 * src/gdcmUtil.h : export methods
519 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
520 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
522 * Initial addition of automatic python testing
523 * Initial addition of automatic image comparison
525 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
526 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
527 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
529 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
530 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
531 * Test/ShowDicom.cxx : bug fix for msvc compilation
532 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
534 2004-05-04 Jean-Pierre Roux
535 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
536 new concepts (and new classes) :
537 a 'gdcmDocument' is composed of a set of Doc Entries, that are
538 - elementary gdcmDocEntries (former gdcmHeaderEntries)
539 - Sequence Doc Entries (gdcmSeqEntries)
540 a Sequence is composed of Items.
541 Each item is a set of Doc Entries (this is recursive)
542 The non uniqueness of the 'Dicom tag' is due to this recursivity
543 (never taken into account)
544 Our unability to add a new 'entry' in the header
545 at the proper location (neither in the H-Table (map or multimap),
546 nor in the Chained List is also due to this recursivity.
547 Don't try, right now, to use/modify/compile these new sources :
549 We just commit all the stuff, 'as is', in order not to loose it.
551 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
554 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
555 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
556 file prefix (SetFilePrefix)
558 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
559 * Add a new test: ShowDicom, for now this is just the c++ version of
560 checkRead.sh, later it will be able to compare the image read against a
562 * Replace the DEBUG on the stack with a global entry in cmake interface:
563 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
565 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
566 * Add an example subdir, with a real example on how to read + write a
569 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
570 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
571 * Doc/CMakeLists.txt: the main page is now properly differentiated
572 between the developper and user version.
573 * Doc/doxygen.config.in: dropped search related obsolete flags
574 * src/gdcmParser.h, gdcmHeader.h: doxygenation
576 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
577 * DEVELOPPER: added some helpfull comments for compile/test/install
580 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
581 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
582 src directory, now generated in the build dir.
583 2. Tests as mentionned smarter
585 4. Add a new method in gdcmDict that return the PubDict by name
586 this is interesting for 3rd party lib like ITK,
587 where we could set the institution name / patient name...
589 * ENH: 1. Now the test suite is working for real
590 2. All binaries are now output in the gdcm-bin directory
591 (this was not true before)
593 2004-04-28 Jean-Pierre Roux
594 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
595 SeQuence indented printing of Dicom Header.
596 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
597 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
598 Computation of SQDepthLevel is now part of gdcmHeader constructor
599 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
600 tree-like structure of a Dicom Header.
601 * FIX Test code cleaning
603 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
604 * ENH: Adding automatic testing
605 1. Need a DartConfig.cmake to submit to public
606 2. Add a test driver gdcmTest.cxx
607 3. gdcmTestMain, an helper for the main test driver gdcmTest
608 4. Files in Test don't have a main anymore, this becomes interesting
609 when we add more and more tests, thus dsw don't have to load
611 * ENH: Adding a GDCM_DATA_ROOT for testing
612 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
613 one file instead of seven + some small cleanup
615 2004-04-22 Jean-Pierre Roux
616 * ENH Minor changes to the Print() methods.
617 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
618 Header printing. Example given with :
619 > PrintHeader fileName 2 new
620 (SQ based tree-like structure still to be done for the Header ...)
622 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
623 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
624 1. I have added some unsigned where needed
625 2. Some function parameter not used -> (void)
626 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
627 4. g++ don't like character '\' in comment
628 5. #define jpeg_create_decompress jCreaDecompress
629 this really need to be fixed
630 6. virtualize destructor of gdcmObject ... leakage
631 7. sscanf(g->first.c_str(),"%x",&gr_bid);
632 this also really need to be fixed
633 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
634 remove compression file
635 (as we only do decompression, right ?)
636 * ENH: Change malloc/calloc/free with c++ equivalent
638 2004-04-21 Jean-Pierre Roux
639 * FIX gdcmHeaderHelper::GetXSpacing
640 when a single value is found (bug ?), xpacing is now
641 defaulted to yspacing
643 2004-04-19 Jean-Pierre Roux
644 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
645 * ENH add parameters :
646 bool exception_on_error = false,
647 bool enable_sequences = false,
648 bool ignore_shadow = false
649 to the gdcmFile constructors to be full gdcmParser compliant
650 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
651 to allow reading of PAPYRUS 3.0 files
653 2004-04-06 Jean-Pierre Roux
654 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
656 2004-04-02 Jean-Pierre Roux
657 * ADD : Test/checksequence.sh, for a general recap on SQ pb
658 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
659 for Philips spurious Tag fffe|0000 while rewritting Dicom files
661 2004-03-30 Jean-Pierre Roux
662 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
663 for ACR file, written out as DICOM files (hope so...)
665 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
667 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
668 moved to base class gdcmParser and only the specialisation is kept
670 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
671 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
672 already does the job.
673 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
674 (to be consistent with gdcmParser::WriteEntries).
676 2004-03-30 Benoit Regrain
677 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
678 upate of the object's instance. It's passed to 2 in the unfavorable
679 case : one in the ExecuteInformation, one in the ExecuteData
681 2004-03-29 Jean-Pierre Roux
682 * ENH : Check on file type to be written moved
683 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
684 * FIX : gdcmObject::ResetBoundaries now stops properly
685 when end-of-list is reached
686 : gdcmVersion modified (as Benoit Regrain asked)
688 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
690 * src/gdcmUtil.cxx: added forgotten iostream include.
691 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
692 equivalent to ExplicitVR in existing code).
694 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
696 now contains all the gdcmGlobal related code.
697 * minor coding style and doxygenation changes.
699 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
700 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
701 now contains all the Debug related code.
702 * minor clean-up of includes in src/*.cxx
703 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
704 CreateCleanString) removed.
705 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
706 * Doc/DoxyMainPageUser.txt added.
707 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
708 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
711 2004-03-24 Jean-Pierre Roux
712 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
714 2004-03-23 Jean-Pierre Roux
715 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
716 big endian made volumes
717 * ENH Now gdcmParser constructor and destructor are protected to forbid
718 end user to instanciate class gdcmParser
719 (only gdcmHeader and gdcmDicomDir are meaningfull)
721 2004-03-22 Benoit Regrain
722 * FIX : src/gdcmDicomDir.cxx : make windows compilable
723 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
724 gdcmSerie to gdcmDicomDirSerie
726 2004-03-19 Jean-Pierre Roux
727 * ENH Now the tree-like structure describing a DICOMDIR comming from
728 an already existing DICOMDIR file is consistent with
729 the home-made tree-like structure build ex-nihilo
730 or build from the files held (recursively) in a Directory
731 functions gdcmDicomDir::CheckBoundaries()
732 gdcmObject::SetBoundaries() added
734 2004-03-17 Jean-Pierre Roux
735 * REM (Eric Boix bug) : removal of meaningless
736 gdcmDicomDirImage::NewImage function.
737 * FIX now file names and directory name are written properly in the
739 * FIX now gdcmDicomDir constructor may be call without any trick
742 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
743 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
744 of gdcmDicomDirImage::NewImage as empty function.
746 2004-02-28 Jean-Pierre Roux
747 * ENH add gdcmDicomDir:NewPatient
748 add gdcmDicomDirPatient:NewStudy
749 add gdcmDicomDirStudy:NewSerie
750 add gdcmDicomDirSerie:NewImage
751 to allow making gdcDicomDir object.
752 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
753 (as opposite to the gdcmHeader chained list)
755 2004-02-11 Benoit Regrain
756 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
757 when using from python
759 2004-02-10 Benoit Regrain
760 * FIX : bug fix in the gdcmDirList for the recursivity in directories
761 * FIX : in gdcmDicomDir when the directory is empty
762 * ENH : add callback and methods to get the progression of dicomDir
765 2004-02-06 Jean-Pierre Roux
766 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
767 - GDCM_META added to gdcmDicomDirType
768 - class gdcmMeta created
769 * ENH : - A brief summary is now displayed at the beginning of
770 'testDicomDir' to help disaster magnitude estimation
771 * REM : Now useless Test/explDICOMDIR.cxx
773 2004-02-05 Benoit Regrain
774 * ENH : add methods in gdcmObject to get the hash table or the list of
776 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
777 * FIX : wrapping python for TagHeaderEntryHT
779 2004-02-04 Benoit Regrain
780 * FIX : even length for some strings when writting the dicom dir
781 * FIX : sort the images in the dicom dir
782 * FIX : Bug fix for python use of dicom dir
783 * ADD : a python demo
785 2004-02-04 Jean-Pierre Roux
786 * FIX : Final solution (?) for icone embedded images
787 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
788 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
789 add groups 6002, 6004, 6006, to allow 'clean' parsing of
790 gdcmData/gdcm-MR-SIEMENS-16.acr1
791 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
792 to make full checking easier
794 2004-02-04 Benoit Regrain
795 * FIX : WriteEntries : coding style & logic in parameters
796 * FIX : Set the elements to create the DicomDir in a dictionary file
798 2004-02-03 Benoit Regrain
799 * gdcmDirList : to parse a hard drive directory in recursive (or not)
800 * gdcmDicomDir : add the load of directory
801 * Bug fix and print add-on
803 2004-02-03 Jean-Pierre Roux
804 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
805 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
806 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
807 * FIX gdcmParser.cxx : 'group length' elements are now considered
808 as integers, even for shadow groups, when file is Implicit VR
810 2004-02-02 Jean-Pierre Roux
811 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
813 of the last synonym :-(
814 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
816 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
817 * FIX taking into account the possible 7fe0,0010 multiplicity
818 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
819 to allow removal of references to 7fe0,0010, to deal with
820 ACR-NEMA images, when 0028,0200 is meaningfull
822 2004-01-31 Jean-Pierre Roux
823 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
824 no longer writes 'Un' on disk
825 * FIX SQ elements with actual length are now dealt with corectly
826 * FIX gdcmFile::WriteBase make the difference, for color images, between
827 the length (for Palette expanded images)
828 and Raw Length (non expanded image + Palette)
829 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
830 (that broke Write). Replaced by UL.
831 Aware user will reload the field if he
832 thinks it's necesssary
834 2004-01-30 Jean-Pierre Roux
835 * gdcmParser::CheckSwap() now defaults the filetype to ACR
836 when 'dirty Acr' is found, to be compliant with the new
837 IsReadable() methods.
839 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
840 (no DOUBLE images in kosher DICOM,
841 but so usefull for people that miss them ;-)
843 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
844 DICOMDIR related utilities (not checked as Windoze compliant)
846 2004-01-28 Jean-Pierre Roux
847 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
849 2004-01-27 Jean-Pierre Roux
850 * gdcmParser constructor has a new boolean param,'ignore_shadow',
851 to allow skipping the shadow elements, to save memory space.
852 The TRUE value for this param has to be used
853 with a FALSE value for the 'enable_sequence' param.
854 ('public elements' may be embedded in 'shadow Sequences')
855 * gdcmHeader methods now deal with 'embedded icones images' in the header
856 (even when an 'icone image sequence' is announced by the
857 element (0x0088,0x0200), but there is NO icone at all ...
859 * gdcmHeader sometimes Image Location value doesn't follow
860 the supposed processor endianity (see gdcmData/cr172241.dcm).
863 * gdcmHeader add the method
864 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
865 to get *all* the Header Entries with the same tag.
866 GetHeaderEntrySameName is probabely *useless*
867 (no meaning : Name is *not* an identifier within the Dictionnary)
869 2004-01-26 Benoit Regrain
870 * Bug fix in the print of hexadecimal representations. Remove long fields
871 in the print and add a third level of print to print them
873 2004-01-23 Benoit Regrain
874 * Bug fix on field having a VR = 'UI'. Assume that is a string field
875 * Bug fix on test suite after remove the strip made on not string fields
876 * Split the IsReadable method between gdcmParser which test that the file
877 is dicom and gdcmHeader which test that it's an image file
879 2004-01-22 Benoit Regrain
880 * DicomDir : clean code, add methods, set variables in protected or private
881 * gdcmUtil : bug fix for the clean string method
883 2004-01-19 Benoit Regrain
884 * Add the use of shadow dictionaries
885 * bug fix and coding style
887 2004-01-19 Benoit Regrain
888 * src/gdcmFile.cxx : bug fix concerning the close of file
889 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
890 * Add the update of header entries using the shadow library
892 2004-01-19 Benoit Regrain
893 * removal of file gdcmHeader2.cxx
894 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
895 inheriting from gdcmParser. This split is to prepare the integration
897 * bug fix under python
899 2004-01-16 Jean-Pierre Roux
900 * REM removal of class gdcmHeaderEntrySet
901 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
902 * ADD add file gdcmHeader2.cxx
903 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
905 2004-01-15 Benoit Regrain
906 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
907 entries created while parsing the header. Thus, they will be destroyed
908 when the gdcmDictSet will be destroyed
909 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
912 2004-01-15 Benoit Regrain
913 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
914 made a fatal error because of the memory release at the end of program.
915 The problem was in vtkGdcmReader::ExecuteData where we were allocate
916 some memory and vtk seems to have some problems with that.
917 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
919 2004-01-14 Benoit Regrain
920 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
921 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
922 * src/*.[h|cxx] : make changes due to class name changes
923 * gdcmPython/demo/*.py : bug fix due to method names
925 2004-01-13 Benoit Regrain
926 * src/*.[h|cxx] : coding style
927 * vtk/*.[h|cxx] : coding style
929 2004-01-13 Benoit Regrain
930 * gdcmPython/testSuite.py : test the readable flag of file for tests
931 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
932 It's lied to the stl compilation by MSVC (windows, always windows...)
933 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
935 2004-01-12 Benoit Regrain
936 * src/*.h : add comments
937 * src/gdcmDictSet.h : set the method BuildDictPath in public
938 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
939 directly setted in the source code
940 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
943 2004-01-09 Benoit Regrain
944 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
945 * setup.py : use a reference to gdcmVERSION
947 2004-01-07 Benoit Regrain
948 * Modification to compile with the distutils.
951 2003-12-10 Benoit Regrain
952 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
953 can use a gdcmHeaderHelper to load datas
954 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
955 made in the source code
957 2003-12-10 Benoit Regrain
958 * Update Windows projects and .cvsignore files
960 2003-11-12 Jean-Pierre Roux
961 * ENH gdcmHeader constructor has one more parameter (default value : false)
962 that allows the user to 'go inside' the SeQuences only
964 gdcmElValSet:Print takes it into account
966 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
967 * ENH: Update gdcmPython/CMakeLists
968 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
969 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
971 2003-11-10 Jean-Pierre Roux
972 * FIX : gdcmHeader::LoadElements is now based
973 on the ListTag listElem member,
974 not longer on the TagElValueHT tagHt member
975 * ENH : PrintPubElVal shows (temporarily) both results,
976 with the tagHt member and the listElem member.
977 (it's easier to 'see' the problems when using Printheader)
979 * FIX : old private member LgrElem is now splitted into
980 ReadLength : Length actually found on disk (updated only
981 if bug fixing is necessary), for internal
983 UsableLength : Updated by FixFoundLength, to fix a bug
984 or to allow Parser going on.
985 Will allow to re-write a kosher header when a SeQuence
986 with a length (not 0000) is found
987 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
988 because gdcmElValSet::Add does not update ListElem
991 2003-11-07 Jean-Pierre Roux
992 * FIX misstyping in Transfert Syntax name table
993 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
994 when they have an actual length (not 0000 nor FFFFF)
995 (Nobody should care of it, but DICOMDIR explorers)
997 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
998 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1000 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1001 * ENH: vtkGdcmReader now supports LUT !
1002 (vtkgdcmViewer for now is not able to use them though)
1004 2003-11-05 Jean-Pierre Roux
1005 * in testSuite.py : new files names for checking the package
1006 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1007 that returns the pixel area size to the *aware* (vtk) user
1008 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1010 2003-11-05 Benoit Regrain
1011 * in testSuite.py : Modify the rules for checking the paths
1012 : Explicit error messages
1013 * in __init__.py : Related modif
1015 2003-11-03 Jean-Pierre Roux
1016 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1017 to be used by aware (vtk) users that want to manage
1018 LUT (and no to turn the PALETTE image into an RGB pixels one)
1019 * GetPixelType now returns 8U for 24 Bits images
1020 (vtkGdcmReader compliant)
1022 2003-10-31 Jean-Pierre Roux
1023 * Removal of *all* gdcmData images and add them again
1024 in order to loose the 'history' of un-anonymised images
1026 2003-10-31 Jean-Pierre Roux
1027 * RMV : removal of useless jBitsInJsample.h
1028 for both 8 and 12 Bits JPEG Lossy Libraries
1030 2003-10-31 Jean-Pierre Roux
1031 * ENH : Add the functions gdcmFile::GetImageDataRaw
1032 gdcmFile::GetImageDataIntoVectorRaw
1033 that act as GetImageData and GetImageDataIntoVector
1034 except the making of an RGB Plane from Gray Plane + LUT
1035 Intended to aware (vtk) users who know how to manage
1038 GetLUTRGBA return a R,G,B,A LUT if any
1039 lgrTotaleRaw gives the 'Raw' length
1040 GetImageDataRaw returns the gray Plane
1041 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1042 (They stay Grey, just like with other Dicom viewers :-(
1044 2003-10-30 Jean-Pierre Roux
1045 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1047 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1048 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1049 being coherents dicom files.
1051 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1052 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1054 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1055 * ENH: Two steps is necessary to please VC++ compiler...
1056 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1057 * ENH: Add include dir to medcon lib
1058 * FIX: only one function is being exported for now !
1059 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1061 2003-10-29 Jean-Pierre Roux
1062 * adding gdcmHeader::GetLUTRGBA
1063 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1064 --> Mathieu, the modif u're waiting for is not yet committed
1065 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1067 2003-10-27 Jean-Pierre Roux
1068 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1069 00191113.dcm DermaColorLossLess.dcm
1070 MxTwinLossLess.dcm RadBWLossLess.dcm
1071 * ENH: For version prior to vtkImageViewer2 -r 1.19
1072 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1074 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1075 * Removal of ido stuff in CMakeLists.txt
1077 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1078 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1079 * FIX: remove a call to ->Modified ... see comments
1080 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1082 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1083 * FIX: Problem with path for libvtkgdcmPython
1084 * ENH: Try adding a search script for python site-package
1085 * RMV: Remove some file from medcon lib that are not necessary
1086 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1087 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1088 * FIX: More pragma disable fro VC++,
1089 I don't think I break something as it is also disable in VTK/ITK.
1090 But it fasten debug compilation time.
1092 2003-10-23 Jean-Pierre Roux
1093 * gdcm now deals with 16 Bits Run Length Encoded images
1094 (they are compressed as 2 planes images,
1095 one for the high Bytes, the other for low Bytes)
1097 2003-10-22 Jean-Pierre Roux
1098 * Now CheckRead takes into account :
1099 - the bugged 'Leonardo' Siemens images
1100 - the XA images, sent thru the burning VPRO station
1101 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1104 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1105 * FIX: When copying a Makefile.am to CMakeLists.txt
1106 one should remove the '\'
1108 2003-10-22 Jean-Pierre Roux
1109 * in gdcmData adding a bugged 'Leonardo' Siemens image
1110 (wrong lengths in header)
1111 OK with gdcm, KO with the other viewers :-)
1112 * add a GE dlx XA image, thru the VEPRO burning station
1115 2003-10-21 Jean-Pierre Roux
1116 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1117 for a brutal checking of vtkgdcmViewer compliance
1119 2003-10-21 Jean-Pierre Roux
1120 * add the files for 'xmedcon' Jpeg Lossless library
1121 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1123 2003-10-21 Jean-Pierre Roux
1124 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1126 2003-10-21 Jean-Pierre Roux
1127 * garbage Siemens 'Leonardo' images dealt with
1128 (the patch is easy to remove)
1129 * cosmetic changes to avoid warnings
1131 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1132 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1133 no need to press 'r' now.
1135 2003-10-20 Jean-Pierre Roux
1136 * upgrade of checkRead.sh checkWrite.sh according
1137 to new Jpeg Lossless decompressor
1138 * add US.3405.1.dcm, a genuine RGB medical file ...
1139 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1140 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1142 2003-10-15 Jean-Pierre Roux
1143 * general anonymisation in gdcmData
1144 * adding the 'color files' from
1145 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1146 * adding some well knowed bugged-header images
1147 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1148 waiting for their inclusion in Python testsuite
1150 2003-10-15 Jean-Pierre Roux
1151 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1152 no longer seg faults when file is not found
1154 2003-10-14 Jean-Pierre Roux
1155 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1158 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1159 * TODO: *.in file to genereate a UseGDCM later
1161 2003-10-14 Jean-Pierre Roux
1162 * Some supposed-to-be Dicom Images have no preamble.
1163 OpenFile takes it into account
1164 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1165 * Missing elements added in dicomV3.dic
1166 (just to be affraid : have a look at
1167 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1168 and do it again next year ;->
1170 2003-10-13 Jean-Pierre Roux
1171 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1172 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1173 But there are NOT. It's fixed !
1175 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1176 * FIX: "jpeglib.h" was not found on VC++
1177 * FIX: vtkgdcm was not being installed
1179 2003-10-10 Jean-Pierre Roux
1180 * ENH : OpenFile closes the file if it *really* doesn't look like
1181 an ACR-NEMA / DICOM one.
1182 * FIX : testWrite no longer writes an empty file if the source file
1183 is not gdcm Readable
1184 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1187 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1188 * FIX: CMake generate now documentation
1189 * ENH: out of source doc build !
1190 * ENH: Generate both user and dev documentation
1191 * ENH: Should work on windows too
1192 * ENH: Only one doxygen config.in file is needed
1193 * FIX: make install should be ok now on ùnix plateform
1194 * FIX: PATH to dictionary was wrong (missing /)
1195 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1197 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1198 * vtkGdcmReader is now able to read rgb dicom file.
1199 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1200 * added a gdcmViewer to vtk test, use mouse to control
1201 window level & window width
1203 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1204 * CMake-ification of gdcm, we have now two build system
1205 * FIX: on cygwin Wsock32 doesn't exist
1206 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1208 2003-10-06 Emanuel Ollart
1209 * FIX : compilation process wad broken.
1210 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1212 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1213 * change gdcmViewer -> vtkgdcmViewer
1214 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1216 2003-10-06 Jean-Pierre Roux
1217 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1218 ( e.g : well known GE images with a wrong elem length,
1219 : Philips MRI Images with a wrong Huffman table)
1220 * still to be done : allow the reading of bugged LEONARDO Siemens images
1222 2003-10-03 Jean-Pierre Roux
1223 * Odd length strings are padded with '\0' (not with spaces,
1224 to remain compliant with already defined strings,
1225 like Transfert Syntax UID and others)
1227 2003-10-03 Jean-Pierre Roux
1228 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1229 to allow displaying RGB images (not only by affim ;-)
1231 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1232 * vtkGdcmReader is now able to read rgb dicom file.
1233 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1235 2003-10-03 Jean-Pierre Roux
1236 * A few nasty patches to allow the reading of a lot of nasty images
1237 ( e.g : well known GE images with a wrong elem length,
1238 : Philips MRI Images with a wrong Huffman table)
1239 * still to be done : allow the reading of bugged LEONARDO Siemens images
1241 2003-10-03 Jean-Pierre Roux
1242 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1244 2003-10-03 Jean-Pierre Roux
1245 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1246 to allow displaying RGB images (not only by affim ;-)
1248 2003-10-03 Jean-Pierre Roux
1249 * gdcmFile::GetImageDataIntoVector now
1250 - deals with MultiFrames MultiFragments Run Length Encoded files
1251 - deals with YcBcR (YBR_FULL) files
1252 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1253 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1255 (no sample found :-(
1257 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1258 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1259 Two reasons: - clear things
1260 - third parties acces gdcm through header files, so won't
1261 suffer anymore VC++ complains
1263 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1264 * add argv[1] in testvtkGdcmReader.cxx
1267 2003-09-24 Jean-Pierre Roux
1268 * The lines are now eigthy characters long.for
1269 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1271 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1272 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1273 char* to std::string. Thus, the use of strdup becomes useless. (see
1274 previous commis of Malaterre)
1275 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1276 before the last Malaterre's commit.
1278 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1279 * This commit should fix the Debug building under VC++, the problem
1280 was mainly a mixture of debug and release lib being loaded at startup.
1281 * I also remove a depency to a specific C function: strdup. Because I had
1282 to force the link to msvcrtd (whereas strdup is in libc).
1284 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1285 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1286 located in the gdcmCommon.h file. All use of reference of tha has been
1287 changed to now use the variable GDCM_UNFOUND.
1289 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1291 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1292 Dicom dictionary. The test suite can now be run again. Note:
1293 I'm note very happy with the " (RET)" changes. I believe this
1294 RETAINED comment should be dropped when parsing the dictionary.
1295 - PACKAGER corrected
1297 - AUTHORS updated and now in alphabetical order
1298 * Makefile.am now exports gdcm.dsw for Windoze users.
1300 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 * cygwin complains about missing std:: in subdir Test/
1303 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1304 * remove some methods that are now in gdcmHeaderHelper
1306 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1307 * vtkGdcmReader set spacing and origin correctly
1309 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1310 * Fix a few delete/delete[] mismatch
1312 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1313 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1314 interpretation to data given by gdcmHeader. For instance there are
1315 heuristics to get informations (look at different places).
1316 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1317 sorting DICOM images based on different strategies.
1318 * modified Makefiles accordingly.
1320 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1321 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1322 when building in debug mode
1323 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1324 src/win32/gdcmdll.dsp
1325 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1327 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1328 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1331 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1332 * src/win32/libgdcmjpeg12.dsp was not dos format
1333 * src/win32/libgdcmjpeg12.dsp :
1334 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1335 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1337 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1338 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1340 * src/gdcmFile.cxx : bug fix in affectation type
1341 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1342 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1343 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1344 symbols... future problem ?
1346 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1347 * src/win32/libgdcmijpeg12.dsp was missing
1348 * modified gdcm.dsw accordingly
1350 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1351 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1353 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1354 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1355 commit of JPR (before his hollidays to facilitate our work).
1356 * setup.py : bug fix in code. Modifications made while the last commit
1357 of JPR. The code hasn't been tested before the commit... it's so
1358 useless to make that (for best programmer that is JPR) !!!
1360 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1361 * tagged the current version as Version0_3 (i.e. version 0.3)
1363 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1364 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1365 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1366 * *.dsp : modifications to use new libgdcmijpeg8 library
1367 * setup.py : bug fix on VTKPATH variable
1368 * PACKAGER : adding all concerning windows
1370 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1371 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1373 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1374 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1375 test suite reported error.
1376 * PACKAGER file added (describes what a packager must do when
1377 packaging a new release).
1378 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1379 * configure.in: upgraded version number to 0.3.0
1380 * fixing build of rpm (through rpm -ta):
1381 - Doc/Makefile.am exports proper doxygen files
1382 - src/jpeg/libijg8/Makefile.am exports the include files.
1384 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1385 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1386 * src/gdcmHeader.h : formatting code
1388 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1389 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1390 We were obtaining error message from vtk. Now, creation of file list
1391 is made in an internal list to prevent this problem.
1392 Bug fix when output is empty.
1393 Bug fix in update of progress value. Previous commit for this was a bad
1395 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1397 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1398 * src/gdcmHeader.h : added method to get the file name
1399 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1400 files. Added method to remove all files on the input
1401 Added FIXME comment concerning the bad parsing of header made by
1402 ExecuteInformation method (in ExecuteData method)
1404 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1405 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1406 when using make instal.
1407 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1408 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1410 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1411 * setup.py : adding include dir of jpeg lib to compile all sources
1412 * */Win32/*.dsp : JPR fix for windows compilation
1414 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1415 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1417 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1418 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1420 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1421 * setup.py is again effective on un*x (takes into account the
1422 addon of the jpeg library)
1423 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1424 * Doc/Doxy* updated (includes above enhancements)
1425 * INSTALL now points to web documentation
1427 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1428 * src/gdcmHeader.h doesn't make unnecessary reference to
1430 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1432 * src/gdcm*.[cxx|h] :
1433 - to allow compilation with gcc 3.x
1434 -- clean up of STL usage (added explicit usage of std::)
1435 -- small fixes on exceptions.
1436 Note: linking not tested !
1437 - clean of doxygen comments to avoid warnings at documentation
1439 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1440 dependent convertion).
1442 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * Clean up of previous JPR garbage commit (not even commented in the
1445 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1446 - moved all jpeg related files from src to src/jpeg/libijg8, with
1447 addition/modification of Makefile.am and configure.in.
1448 - the testSuite is still brain damage (not guilty).
1450 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1451 * WrapVTK.py : modifications to get correctly vtk source files to
1453 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1454 (FileName -> Filename)
1456 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * vtk/vtkGdcmReader.[cxx/h]:
1458 - UpdateProgress method should now be effective
1459 - removed the limitation on having only images loaded (as opposed
1461 - when building a stack of images/volume, a lesser number of
1462 gdcmHeader and gdcmFile instances should be used (hopefully
1463 accelerating things).
1464 - when building a stack of images/volumes, files which are not
1465 loadable (wrong path-filename, wrong permissions on existing file,
1466 or file not parsable by gdcm) are replaced with a black image
1467 in the stack (for the caller to notice the problem).
1469 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1470 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1472 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1473 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1474 between standard library (std) and vtk library (problems are found
1475 under Windows... thanks Windows !)
1477 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1480 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1482 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1483 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1485 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1486 * When compiling with distutils (see setup.py) the C++ compiler is
1487 called with different flags than the default ones (with automake).
1488 In order to fix all those warning, I compiled gdcm with the command
1489 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1490 and went for warning fixes:
1491 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1492 up from unused variables.
1493 - vtk/vtkGdcmReader.cxx: potential bug fix.
1494 * src/gdcmHeader.h: Doxygen warning cleanup
1496 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1497 * gdcmPython/gdcm.i:
1498 - typemaps correction to take into account the systematic replacement
1499 of "using namespace std" with std:: prefix e.g. std::list,
1500 std::string... (cf changes of 2003-05-21).
1501 - gdcmGlob global variable of type gdcmGlobal (defined in
1502 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1503 exported to Python a as cvar.
1504 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1505 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1506 gdcmDictSet.GetPubDictTagNames() and
1507 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1508 C++ static methods).
1509 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1510 with the above changes.
1512 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1513 * setup.py, manifest.in : bug fix under linux
1515 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1516 * Modification of setup.py to compile vtk part too. Then, we have 2
1517 wrappers which must work with same distutils. For that, we have a
1518 generic distutils in distusiltsWrapping.py ; with :
1519 - build_extWrap class to wrap generically all extensions,
1520 - ExtensionWrap base class for all wrapping extension that contains
1522 - Wrapper interface which wrap sources
1523 + In WrapSwig.py we have extension and wrapper for Swig
1524 + In WrapVTK.py we have extension and wrapper for VTK
1525 * MANIFEST.in : modifications to consider vtk directory and new python
1526 files for compilation
1528 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1529 * Added python wrappers of vtkGdcmReader vtk class (see the
1530 source in vtk/vtkGdcmReader.cxx) :
1531 - vtk/Makefile.am now builds a library
1532 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1533 python library (as opposed to _gdcm.so wich are the python
1534 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1535 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1537 - configure.in has an additional flag --enable-vtk that needs
1538 to be set to enable compilation of vtk related code, that is:
1539 + vtk/vtkGdcmReader.so and
1540 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1541 + gdcmPython/vtkgdcmPython.so (see above)
1542 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1543 be read when compressed or when HighBit + 1 != BitsStored),
1544 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1545 the usage of the python wrapper of vtkGdcmReader vtk class.
1546 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1547 * src/*.[h] all occurences of stl classes are now prefixed with
1548 std::, and all occurences of "using namespace std;" where removed.
1549 This is to avoid pollution of global namespace in included files.
1550 Apparently vtk does not avoid this pitfall: when using both
1551 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1552 collision of various stl members (principally cout...).
1553 * gdcmPython/testSuite.py now cleanly removes temprory generated
1555 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1556 comply with above changes)
1558 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1559 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1560 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1561 vtk data structure (an image Flip was required).
1562 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1563 * cosmetic changes in documentation.
1565 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1566 * src/gdcmHeader.cxx: the constructor no longer exits when an
1567 unexisting file is given as argument.
1568 * The subdirectory Data (containing all the images used for the
1569 test suite) is not part of this repository anymore. A new module
1570 containing those images is now available at
1571 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1572 with the name gdcmData.
1573 All the python scripts (including the package initialisation file
1574 gdcmPython/__init__.py) were adapated to take this change into
1575 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1577 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1578 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1579 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1580 demo of the usage of this class.
1581 Compilation of this vtk part is only done when using the --enable-vtk
1582 at configure (or autogen.sh) stage.
1584 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1585 * More memory link related corrections and documentation fixes.
1587 - maximum info is obtained with a command of the form:
1588 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1589 --show-reachable=yes PrintHeader
1590 - the remaining reachable blocks seem to come from the STL
1591 allocation scheme through the usage of map and list. It looks
1592 like this memory cannot be freed but it is not a memory leak
1593 (in fact further invocation to the STL would recollect the
1594 unused memory allthough it cannot explicitely be freed).
1595 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1596 of displaying an image parsed with gdcm and displayed with VTK.
1597 Note: some images don't seem to work e.g.
1598 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1599 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1600 Allthough this weakens the semantics, it is a ditch attempt to
1601 make gdcm more thread friendly.
1603 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1604 * Memory link hunt (by using valgrind through the command
1605 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1606 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1607 gdcmHeader::_dicom_vr.
1608 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1609 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1611 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1613 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1614 * src/Makefile.am now exports all the necessary include files at
1618 * UpdateGroupLength replaced by new one
1621 * UpdateGroupLength re-written using H-Table
1622 (named UpdateGroupLengthNew untill checks are over)
1624 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1625 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1626 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1628 - gdcmHeader::GetPubElValSet removed.
1629 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1630 UpdateGroupLength, WriteElements, Write.
1631 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1632 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1633 carried the same semantics.
1634 - src/gdcmHeaderIdo.cxx changed accordingly.
1635 - gdcmFile::WriteBase now regroups all the codes from previous
1636 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1637 - enum FileType moved to gdcmCommon.h
1638 * src/gdcmHeader.cxx AddDefault trashed
1639 * gdcmGetXSize added
1640 * getimageDataSize now calls gdcmGetXSize
1641 * Test/*.cxx changed to agree with above changes
1643 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1645 (to avoid double call by end user).
1646 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1647 by end user, since gdcmHeader::gdcmHeader now handles it.
1649 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * gdcm/Doc many doxygen changes:
1651 - Doxyfile now has two different versions, DoxyfileUsers that generates
1652 the html.users end users oriented documentation and
1653 DoxyfileDeveloppers that generates the html.developper developper
1654 oriented documentation.
1655 - README changed accordingly
1656 - requirement.txt removed (old design info moved to TODO).
1657 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1658 DoxyMainPage.txt, DoxyPython.txt provide more information.
1659 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1660 be updated by simply regenerating the docs with doxygen and copying
1661 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1662 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1663 all the tests in the form "if (<map>.count() >1)" were removed.
1664 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1665 ill-formed documentation sections.
1666 * src/gdcmHeader.cxx: ditto
1668 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1669 * setup.py fixed for un*x (needed macro for stdint.h)
1670 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1671 un*ces with sh-utils test utility.
1672 * gdcmPython/demo/test.py renamed to PrintHeader.py
1673 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1674 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1675 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1676 * src/gdcm*.cxx JPR's bad inclusion fixed.
1678 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1679 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1680 * gdcmPython/demo/test.py changed accordingly.
1682 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1683 * gdcmPython/Makefile.am fixed linking against libstdc++
1684 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1685 * Swig subdir (historical tests of swig version 1.3.17++) removed
1686 * Test/testChangeEntete.cxx some lines commented out in order to make
1688 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1689 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1691 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1692 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1693 hence the user doesn't need this explicit call.
1694 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1695 i.e. LoadElements() call removed.
1696 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1697 - src/Makefile.am declares the proper flag for g++.
1698 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1699 for adding user defined new tags.
1700 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1701 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1702 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1704 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1705 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1706 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1707 src/Makefile.am : the project should properly compile and install
1708 with the autotools, included the python wrappers part.
1709 * gdcm.spec.in : added a spec file for RPM packaging.
1711 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1712 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1714 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1715 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1716 to exported to the environement (see gdcmPython/testSuite.py
1718 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1719 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1720 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1721 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1722 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1724 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1725 * gdcmPython/__init__.py doesn't crash anymore when running in
1726 in InstallMode or PreInstallMode but with an environement given
1727 value of GDCM_DICT_PATH.
1728 * src/gdcmDictSet.[cxx/h] coding style.
1730 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1731 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1732 * src/gdcm.h general comments moved to TODO, and README
1733 * src/gdcm.h should now be seen as a user commodity (including it
1734 should suffice to fully use gdcm). It is nowhere including within
1735 any of the kernel files src/*.cxx and src/*.h.
1737 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1738 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1739 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1741 * src/gdcm*.cxx only include their corresponding include file
1742 (as opposed to gdcm.h)
1743 * gdcmPython/gdcm.i changed accordingly
1744 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1745 the autogen.sh generated "make snapshot" command to work.
1746 * autogen.sh removed history related references to crea package.
1748 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1749 * distutilsSwigCPlusPlus.py work around some swig portability
1752 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1753 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1754 was done in a last ditch attempt to get setup.py _really_
1755 operationnal. The python/gdcmPython layaout add the advantage
1756 of hidding away the python related distutils specific files
1757 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1758 Alas, the src directory was out of scope (i.e. it's relative
1759 position to setup.py was ../src) which made things impossible to
1760 handle (see previous version of python/setup.py). Crossing fingers...
1762 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1763 * python/setup.py now works on Un*x. (harder than I thougth)
1764 * python/distutilsSwigCPlusPlus.py can now have include files
1765 among the list of sources.
1767 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1768 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1769 * modifications in MSVC projects
1771 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1772 * As stated by the first lines of Test/ExceptionAndPython/README, it
1773 looks like we can move back to original usage of exception within
1774 src/gdcm* and hence remove the errno stuff that was introduced
1775 as a quick and dirty fixture of this problem (added to the TODO).
1776 * Doc/Doxyfile configuration file for Doxygen and corresponding
1777 README file for usage added.
1778 * Test/testWrite.cxx added. This new test comes from a split of
1779 test.cxx that is now reverted to its original purpous i.e.
1780 testing the proper parsing of a Dicom related file.
1781 testWrite.cxx concentrates on testing the IO part of gdcm.
1782 * Test/bug1.cxx (containing a bug on WIn32) added.
1783 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1784 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1785 whose purpose is to publish the content of the TagNames of the
1786 Dicom public dictionnary were not accessible without an
1787 instance of class gdcmHeader.
1788 - those methods are now static methods of gdcmDictSet and hence
1789 require no instances at all to be invocated.
1790 - within gdcmDictSet this change required to change some method
1791 to class methods (i.e. are now static) among which SetDictPath
1792 (renamed to BuildDictPath) and LoadDefaultPubDict.
1793 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1794 the above changes by calling the new method classes of gdcmDictSet.
1795 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1796 the above to be effective.
1797 * python/gdcmPython: in order to wrap properly the above changes
1798 for Python, swig version now needs to be > 1.3.17.
1799 * python/gdcmPython/Makefile fixed to adapt itself to new
1800 configure/make shema introduced by Johan Montagnat (thanks for the
1801 contribution). Alas this Makefile cannot be turned into a proper
1802 Makefile.am without some heavy changes in the configure.in
1803 (for python dectection).
1804 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1805 now avoids publishing the empty entries.
1807 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1808 * python/setup.py : bug fix concerning install under windows
1809 ExtraPath reused :-P
1810 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1812 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1813 * Dicts/dicomV3.dic : remove double spaces !!!
1814 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1815 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1818 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1819 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1820 method. Doxygenation.
1821 * src/gdcm.h clean up of JPR spurious comments.
1823 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1824 * python/distutilsSwigCPlusPlus.py now properly collects the
1825 shadow classes generated by "swig -c++" (gdcm.py in our case)
1826 when using "python setup.py install".
1827 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1828 reexports the working classes.
1829 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1830 by the classical C errno scheme. This is to prevent an obscure
1831 behavior of the python wrappers when importing wxPython.wx prior
1832 to gdcmPython (which ended up in an abort call). An illustration
1833 of this oddity can be found in the Test/ExceptionAndPython
1834 subdir (see the README file). This problem probably due to
1835 an combination of g++ and dynamic loading.
1836 * added Test/ExceptionAndPython (see above)
1838 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * Changed the layout of the python part to avoid bloating main
1840 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1841 i.e. the distutils arsenal. All the python related stuff is
1842 again in a python subdir, but the package itself is now in
1844 * setup.py was cleaned up:
1845 - pythonIncludePath removed
1846 - python setup.py bdist target is now functional.
1847 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1848 collision with other packages). gdcmPython/demo/*.py changed
1851 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1852 * python subdir moved to gdcmPython (preparation of distutils packaging).
1853 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1854 distutils installer is operational.
1855 * - gdcmPython/__init__.py now properly loads the swig generated
1856 shadow classes (from gdcm.py).
1857 - gdcmPython/demo/*.py changed to import the package gdcmPython
1858 instead of gdcmPython/demo/load.py.
1859 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1861 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1863 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1864 entries within the associated public Dicom dictionary resp. the same
1865 information but sorted by the fourth field (PAT, IMG, DIR) of the
1867 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1868 are now in the "???" group.
1869 - python/gdcm.i changed accordingly,
1870 - python/demo/printGroupedPublicDict.py added, that gives an example
1871 of the above new functionalities in Python.
1873 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1874 * src/gdcm.h, gdcmHeader.cxx:
1875 - historic references to glib's g_malloc and g_free (#defined)
1876 were definitively removed.
1877 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1878 * src/gdcmElValSet.cxx:
1879 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1880 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1881 - GetElValue(string) renamed to GetElValueByName.
1882 - Added GetElementByName(string).
1883 * src/gdcmHeader.cxx: added
1884 - GetPubElValRepByNumber(guint16, guint16)
1885 - GetPubElValRepByName(string)
1886 - GetShaElValRepByNumber(guint16, guint16)
1887 - GetShaElValRepByName(string)
1888 - GetShaElValByNumber(guint16, guint16)
1889 - GetShaElValRepByName(string)
1890 - GetElValRepByNumber(guint16, guint16)
1891 - GetElValRepByName(string)
1892 - GetElValByNumber(guint16, guint16)
1893 - GetElValRepByName(string)
1894 * Doc/requirements.txt added.
1896 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1897 * Test/Makefile building now depends on the one of libgdcm.so
1898 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1899 pixel data) aware which enables finding the address (offset) of
1900 the pixel data of JPEG encoded DICOM files. This leaves only a single
1901 file in the testSuite whose pixel data address (offset) is unknown.
1902 * python/testSuite.py changed accordingly.
1904 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1905 * VC++ has some strong limitations when working with the STL, as stated
1906 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1907 "Also note that some STL containers (map, set, queue, list, deque)
1908 cannot be exported. [...]
1909 Some STL classes contain nested classes. These classes can not
1911 This is caused by a designed limitation that once a template
1912 class is instantiated, it can not be re-instantiated and
1914 Since our usage of map<> is ubiquitous in gdcm, this "designed
1915 limitation" of VC++ is a pitfall.
1916 Hence the Python wrappers of gdcm cannot be incrementally linked
1917 against the c++ dynamic library. The dirty but only workaround is
1918 to forget about incremental link of dynamic libraries and to generate
1919 the Python wrappers library with the inclusions of the underlying C++
1921 The following modifications concern this matter on Win32/VC++:
1922 - wrapping python correct with standalone wrapped dll (don't use separate
1923 dll under windows !!!!)
1924 - python21_d debug mode enabled (ask Frog how to use it :-)
1925 - NO problem with having an STL member of class for example string in C++
1926 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1927 - Python test of dcmlib in Python is ok under windows on a large set
1929 * removed glib references
1930 * typedef's inserted in gdcm.i for correct swig type management
1932 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1933 * python/demo/*.py load.py extracted from test.py. Added explore.py
1934 that only displays required tags and testAll.py that parses all
1935 the files of the testsuite without using unittest.
1936 * python/testSuite.py other additional test on new files added.
1937 * Data/* new test files added accordingly to the testSuite.
1938 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1939 the vr in the file differs from the one of the dictionary.
1941 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1942 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1943 values, but limits itself to values which are below a user specified
1944 size (by default 1024 bytes).
1945 * python/gdcm.i : elements not loaded (because their size is above the
1946 user specified treshold) are exported with their TagKey as key of the
1947 python dictionary. This enables the testsuite to make some checks
1948 on the unloaded elements (since we have their offset and size).
1949 * python/testSuite.py
1950 - now tests for the existence and proper value of the pixel data
1951 - two new examples added.
1952 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1954 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1956 aware. See the strategy comments in gdcmHeader::FindeLength().
1957 * Test/test.cxx now accepts a filename as first argument.
1958 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1959 * python/testSuite.py changed to integrate test on above files.
1961 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1962 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1963 the vr was also RET.
1964 * python/testSuite.py more tests added.
1966 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1967 * python/testSuite.py unittest test suite added (uses Data)
1968 * Data/* dcm and acr files for the test suite.
1969 * glib dependance removed from un*x version. We now use ISO C99
1970 7.18 Integer types (see stdint.h)
1971 - python/Makefile, src/Makefile src/gdcm.h
1972 * src/ when an explicit vr (like dicom files) suddenly poped an
1973 implicit element we use to mark the underlying DictEntry of the
1974 concerned ElValue with "Implicit". This strategy was damageable
1975 too the public or provite dictionaries, since some of their vr
1976 would be changed. Since Header::FindLength heavily relies on the
1977 detection by Header::FindVR of falsely explicit elements, I
1978 added an extra ImplicitVr member to ElValue (boolean).
1979 The rest of the changes we the necessary adaptations.
1981 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1982 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1984 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1986 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1987 * Adaptation for porting to VC++:
1989 o forced to use std namespace (for string to be known)
1990 o all class use __declspec export style on WIN32
1991 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1992 (in stdlib.h on Win32 but in std:: for gcc)
1993 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1994 variable GDCM_DICT_PATH.
1995 * src/gdcmHeader.cxx verbose comments made discrete.
1997 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1998 * python/gdcm.i: added a typemap that converts a C++ hashing table
1999 to native Python dictionary.
2000 * python/demo/test.py:
2001 - now uses the native dictionary for exploration of gdcmHeader.
2002 - takes an optional filename argument (the file to parse).
2003 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2004 PubElVals hashing table.
2005 * Dicts/dicomV3.dic removed error prone trailing spaces.
2007 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2008 * Python wrapping process moved away from src/Makefile to
2009 newly created python/Makefile (as well as gdcm.i)
2010 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2011 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2012 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2013 from the environement variable GDCM_DICT_PATH (when existing).
2014 * src/gdcmDict::GetTag bug fix.
2016 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2017 * Straightforward temporary fixes for swig to build the python wrappers.
2018 src/Makefile now has a python working entry [by working we mean
2019 that we can import de shadow classes without errors].
2021 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2022 * hashtest.cxx removed (since allready in Test)
2023 * src/gdcmlib.h renamed to src/gdcm.h
2024 * src/dcm.i renamed to src/gdcm.i
2025 * src/Makefile prepared for python wrapping
2027 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2028 * src/gdcmHeader.cxx :
2029 - Parsing of header is now separated from loading of element values
2030 (see gdcmHeader::LoadElements).
2031 - general clean up of hopefully all file access (creation of
2032 ReadInt16 and ReadInt32)
2034 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * src/gdcmHeader.cxx :
2036 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2038 - SetLgrElem renamed to SetLength
2039 - GetLgrElem renamed to GetLength
2040 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2041 * src/gdcmElValSet.cxx fixed both GetElValue methods
2042 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2043 due to IdoDude was cleaned out.
2045 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2046 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2047 concentrates on finding the value representation (when it exists).
2048 RecupLgr now only finds the element value length, and it avoids
2049 returning the unecessary skL (skipped length).
2050 Also, offsetCourant was simply removed (with taille_fich) since
2051 it was redundant with the File position internals (by using
2052 ftell and fseek). This also made skL (see above in RecupLgr) usage
2054 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2055 on the libido specificities which are handled through class
2057 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2060 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2061 * Truckload of changes. Parsing of header is barely functional
2062 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2064 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2065 * src/gdcmHeader.cxx many addons of low level methods
2067 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2069 and _IdDcmSWAP_LONG.
2071 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2072 * This corresponds to all the changes decided at the meeting of
2073 May 23 2002. Needless to say we are running late...