1 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
3 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
5 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
6 set because already copied when copying the BinEntry's of the header
7 * Test/TestAllReadCompareDicom.cxx : remove warnings
9 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
11 Two problems appear when doing it :
12 - with the gdcmFile : when the GetImageData method is called, the pixels
13 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
14 datas (pixels). And each structure destruct the datas when it's
15 destructed. So we have two destructions for the same datas. To solve it,
16 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
17 datas or not. If it doesn't own datas, then they will not destroyed by
19 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
20 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
21 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
22 create a double destruction of the same DocEntry's. So, to solve it,
23 the TagHT is simply cleared and the DicomDir* elements are destroyed.
24 * TODO : add an entry concerning memory leaks in the DicomDir
26 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
28 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
31 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
33 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
34 after it have been deleted
36 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
37 * FIX: src/* fix the doxygen warnings.
38 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
39 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
40 was erroneously defined with a size of 15 instead of 16. [many thanks
41 to Jean Michel Rouet for pointing out this bug].
43 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
44 1. Finish merging JMR patch for writting DICOM from scratch
45 2. Fix -hopefully- bug with MONOCHROME and space vs null character
46 3. Use const ref when possible
47 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
48 5. A few more comments
49 6. CreateUniqueUID can now be called without parameter"
51 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
52 * ENH: Slightly bigger patch:
53 1. Getting toward full integration of JMR patch for writting dicom from scratch
54 2. Update Test to test part of this patch: CreateUniqueUID
55 3. File was not close properly in gdcmDict
56 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
57 5. Use of const ref instead of copy (speed issue)
58 6. Remove temporary (duplicate) string in TranslateToKey
59 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
60 8. Do not repeat virtual in subclasses
61 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
63 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
64 * Apply first patch toward better string comparison when dealing with broken
65 DICOM files. Essentially the string could be padded with a space instead
66 of a null character as defined by standard
68 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
70 because never used... and in the same time, that's remove some memory leaks
72 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmFile.cxx : now delete the PixelConvert instance.
74 * In examples and tests : change the type of image data variables from void*
75 to uint8_t*. Remmove all delete on image data variables
77 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
79 Verify the file pointer value before open the file, and if it's not null,
80 a verbose message is generated.
81 Close correctly the file when the file isn't considered dicom-like. The
82 correctly close is a call to CloseFile.
83 When closing the file pointer, test if its not null to close the file.
84 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
85 file. For an uncompressed image, the copied datas correspond in the least
86 case to the image size (calculated) or the image size specified in the
87 header. A verbose is generated if these two size mismatch
89 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
91 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
92 break under windows (with msvc6 compilation).
94 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
98 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * Bugs fix for the Windows build with VC6
100 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
101 needed (only for projects required VTK). If the VTK is included in all
102 projects, there is conflicts with the jpeg lib of vtk when compiling the
103 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
104 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
105 when compiling the gdcm_wrap.cxx file (created by the compilation of the
107 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
108 (like it's already made for the cout use). Otherwise, conflict with the
111 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
112 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
114 - comments on the DicomDir::Method related usage added.
115 - now that we use the namespace gdcm, a lot of internal classes do
116 NOT need to be wrapped anymore.
117 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
118 DicomDir::Method) new example added.
120 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
121 * Improve string manipulation. I now inforce the notion of 'DicomString'
122 A DicomString can contain as many \0 as they want
123 and it is *always* of even length.
124 We only support odd length for very rare case.
125 And in the near future this should be removed.
127 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
128 * /binary_write/ gdcm source. Now even on big endian we are writting
129 little endian. This should -heopfully- fix some tests
131 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
132 * Now the dictionary is compiled into gdcm lib. This is a default
133 behavior, thus any dic file specified is picked before failback to
134 the one comiled into lib
136 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
137 * Change internals for gdcmDict. Don't use any 'new' any more.
138 This should definitely solve any leak problem, and we should be
139 as fast as before, as long as don't modify too much the dictionary.
141 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
142 * STYLE: ivars should start with a capital letter.
143 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
144 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
146 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
147 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
148 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
149 new 2004 dictionaries added (thanks to JPR).
150 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
151 * CLEANUP_ROUND (15) for gdcmPixelConvert
152 - RLEFrame::NumberFragments is now of type unsigned int
153 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
154 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
157 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
158 * Initial work in gathering all transfer syntax accessors. clearly
159 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
160 ivars, but only one transfersyntax (class) ivar with equivalent method on
163 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
164 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
165 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
166 discussed (plus I didn't like having a 2000 lines patch not commited)
168 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
169 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
170 * CLEANUP_ROUND (14) for gdcmPixelConvert
171 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
172 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
173 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
175 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
176 anymore and hence avoids storing a copy of PixelConvert::Decompressed
177 into File::Pixel_Data.
179 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
180 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
181 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
182 * CLEANUP_ROUND (13) for gdcmPixelConvert
183 Substituted File::ParsePixelData() with PixelConvert::Print() new
185 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
186 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
187 method to those classes.
188 - src/gdcmFile.[cxx|h]:
189 -- Added a ::Print() method.
190 -- PixelConverter is now a reference instead of a member.
191 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
192 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
194 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
195 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
196 collaboration diagram and inheritance diagram should be generated with
198 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
199 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
200 pointlessly wrapped (see
201 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
202 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
203 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
204 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
205 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
206 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
207 -- File::Initialise: PixelConverter setup moved away to
208 PixelConverter::GrabInformationsFromHeader()
209 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
210 interpretation moved away to PixelConverter::BuildRGBImage()
212 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
213 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
214 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
216 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
218 displayed on Win32 when a brutal abort() occurs (because of uncatched
219 exception). See TODO new entry of this commit for more on this.
220 * TODO added new entry.
221 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
222 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
223 - HandleColor is no longer called from gdcmFile.cxx
224 - gdcmPixelConvert.cxx clean up on method arguments and internal
225 variable names for semantical coherence.
227 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
228 * Finished lossless transition, not only do we now read all lossless jpeg
229 images, without the need of the Cornwell lib, but we do read them properly now
230 * To reduce code (well to avoid code duplication), I defined a common place
231 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
232 redefine symbols. This is not prefect but this the best solution I found for a
233 compilation time jpeg option.
235 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
236 * Update jpeg ijg lib to support lossless jpeg implementation
237 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
239 * Also added a special copyright for dcmtk since we use their bugfixes.
242 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
243 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
244 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
245 matters, as stated in warning note at begining of %include section).
246 * src/gdcmDicomDir*.[cxx|h]: coding style
247 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
248 * src/gdcmJpeg8.cxx: doxygen fix.
249 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
250 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
251 from File:: to PixelConvert::.
253 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
254 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
255 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
256 - more code moved away from File:: to PixelConvert::
257 - fat setup of PixelConverter set in place in File::Initialise.
259 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
260 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
261 namespace at the file system level. So now you should convert your examples
263 gdcmHeader -> gdcm::Header
264 It would be nice if people keep in mind to no open the namespace, since it
265 allows compilation on broken plateform which were defining common symbol in
266 the standart namespace (like LP, Unknown ...)
268 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
269 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
270 The JPEG fragments are now parsed at the same stage than the RLE
271 information. All code related to JPEG is now in gdcmPixelConvert:
272 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
273 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
274 export a gdcmFile:: method. Those are simply global functions
275 (for the time being this is better than having them attach to
276 either gdcmFile:: or gdcmPixelConvert::).
277 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
278 and stores the result in a gdcmJPEGFragmentsInfo.
279 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
280 code (among other stuff) moved away from gdcmFile:; to
283 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
285 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
286 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
287 clean up of RLE related code.
288 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
289 - src/gdcmRLE.cxx removed
290 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
291 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
292 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
293 * CLEANUP_ROUND (9) for gdcmPixelConvert
294 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
295 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
296 away from gdcmFile:: to gdcmPixelConvert::.
298 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
300 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
301 This is because Parse7Fe0 used to parse the pixels to compute the
302 length. This task was passed over to FindDocEntryLengthOB() a long
303 time ago, EXCEPT I had forgotten the OW case...
304 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
305 we just recylce the code for parsing RLE fragments and computing
307 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
308 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
309 with the retired Parse7Fe0().
310 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
311 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
313 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
315 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
316 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
317 - src/CMakeLists.txt: alphabetic order reodering + new entries.
318 * CLEANUP_ROUND (4) for gdcmPixelConvert
319 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
320 to return an unused length.
322 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
323 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
324 this should be cleanner from the plane view. The iostream are erally a pain
325 to use to do simple stuff.
327 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
328 * Redo the compilation of the ijg jpeg library. Now only one source is
329 necesseray. No need to rename file by hand what so ever. CMake handle the
330 copying of the file within different directory, configure header file to
331 modify some symbol. The only addition made to ijg wasd a mangle table so
332 that symbol are different wether we are within 8bits or 12bits.
334 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
335 * Added documentation of vtkgdcmReader on Website:
336 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
337 with it's binary name).
338 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
339 the Website to be more complete.
340 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
341 doxygenated documentation.
342 - Doc/DoxyVtkGdcmReaderExamples.txt added
343 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
344 DoxyVtkGdmReaderExamples.html )
345 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
346 * CLEANUP_ROUND (3) for gdcmPixelConvert
347 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
349 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
350 * CLEANUP_ROUND (2) for gdcmPixelConvert
351 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
353 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
354 * CLEANUP_ROUND for gdcmPixelConvert:
355 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
356 - src/gdcmPixelStuff[h|cxx] removed
357 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
358 - src/CMakeLists.txt changed accordingly
360 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
361 gdcmVersion.py moved to newly created ATTIC related
362 gdcmPython/SetupOldies/ directory.
363 * Autotools clean up:
364 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
365 - autogen.sh configure.in acinclude.m4 python.m4 removed
367 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
368 * src/*.cxx *.h Reference to License.htm fixed to License.html.
369 * Doc/CMakeLists.txt, doxygen.config.in: fix.
370 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
372 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * TODO updated with Mathieu suggestions. I proposed a template for
374 describing TODO entries and used it for new entries.
375 * Added Doc/Website/CodingStyle.html, Developpers.html,
376 DeveloppersPython.html, GdcmDataCvs.html and
377 DownloadVersion0_1.html, DownloadVersion0_3.html.
378 * Some Doc/*.txt Doxygen files (which do not really concern the
379 documentation itself, but the website) moved to html and
380 placed in directory Doc/Website:
381 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
382 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
383 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
384 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
385 * CMakeLists.txt changed accordingly.
386 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
387 DeveloppersPython.html
388 * INSTALL nows refers to Doc/Website/Installation.html
390 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
391 * Added Doc/Website directory, that contains a first raw version
394 2004-09-23 Jean-Pierre Roux
395 * FIX In order not to be poluted any longer by casting problems,
396 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
397 we can now delete[] it safely
398 * VoidArea is now called BinArea (less confusing name),
399 and all the methods called ...VoidArea... are now ... BinArea...
400 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
402 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
403 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
404 clear) TagHT, which is an inherited member of gdcmElementSet. It is
405 up to the destructor of gdcmElementSet to clean up TagHt and it's
408 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
409 * Test/CMakeLists.txt: update to follow gdcmData renamings.
410 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
412 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
413 * ENH: added some utility method that builds a flat dictionnary
414 holding all the Dicom entries contained in the recursive structure
415 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
417 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
418 BuildFlatHashTable() that build a flat dictionary.
419 - src/gdcmElementSet.h: added a new private GetTag() accessor.
420 gdcmDocument is now a friend of gdcmElementSet.
421 - src/gdcmElementSet.cxx: clean up.
422 - Example/FlatHashTablePrint.cxx added.
423 - Example/CmakeLists.txt changed accordingly
425 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
427 moved away from gdcmDocEntrySet (since this class is an abstract class
428 acting like an interface). SQDepthLevel and BaseTagKey are now
430 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
431 and associated accessors. Doxygenation of the class.
432 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
434 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
435 Use SQDepthLevel accessor instead. ::Print() adapted.
436 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
437 - src/gdcmDocument.cxx changed accordingly.
439 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
440 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
441 - The following is the doxygen comment of the typedef declaration
442 of gdcmagKey in src/gdcmCommon.h:
443 gdcmTagKey is made to old an "universal" (as in URL, Universal
444 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
445 A dicom tag allways has a group and an element, but a set of tags
446 embeded in various (optionally nested) sequences and sharing
447 the same group and element all share the same (group, element)
448 "identifier". Hence the (group, element) cannot be used as an
449 identifier (in gdcm we shall refer to a "TagKey") of a tag.
450 In order to construct a proper tag identifier (i.e. a key) we
451 consider the following definition of a TagKey:
452 - let Group, Element be the string representation of the
453 group and element dicom tag members,
454 - let ItemNumber be the string representation of the integer
455 index of the considered item number of a sequence,
456 Let the key of a tag embeded in a sequence, noted SeqTag, be
458 /ItemNumber#Group|Element
459 where "/", "#" and "|" are characters acting as separators.
460 Then the general form of a gdcmTagKey is given by:
461 Group|Element<SeqTag>
462 where <SeqTag> means NO or many instances of SeqTag.
463 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
466 but the gdcmTagKey of a tag "embeded" is the first item of
467 a sequence, itself nested in the third item of a sequence is the
469 0004|1220/2#0008|0082/0#0008|0090
470 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
471 order to hold the new sequence compatible key. Previously, the
472 GetKey() method would look in the underlying gdcmDictEntry.
473 - src/gdcmDocEntry.cxx:
474 -- constructor now copies the underlying DictEntry key, in the local
476 -- ::Print: displays the member Key, instead of the (group, element).
477 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
478 - src/gdcmDocEntrySet.h:xi
479 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
480 -- now has a new BaseTagKey member.
482 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
483 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
485 This poses the problem with the semantics of the following lines
486 LoadEntryVoidArea(0x0028,0x1201); // R LUT
487 LoadEntryVoidArea(0x0028,0x1202); // G LUT
488 LoadEntryVoidArea(0x0028,0x1203); // B LUT
489 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
490 to the long FIXME note for what the problem is. Nevertheless in
491 order to get things working the dicom dictionary was altered !
492 Please fix things urgently...
493 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
494 information), see above note on moving the member VoidArea. Nevertheless
495 the following entries previously correctly set as US are now inproperly
497 0028 1201 OW IMG Red Palette Color Lookup Table Data
498 0028 1202 OW IMG Green Palette Color Lookup Table Data
499 0028 1203 OW IMG Blue Palette Color Lookup Table Data
500 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
501 of gdcmDocEntry moved to gdcmSeqEntry.
502 * src/gdcmSeqEntry.cxx: STYLE.
504 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
505 * Test/TestAllEntryVerify.cxx minor fix and added comments.
507 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
508 * gdcmPython/testSuite.py: all the test suite in python is now moved
509 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
510 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
511 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
513 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
515 to avoid inclusion recursion until STL is reached.
516 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
517 mecanism. errno.h is not included in gdcm anymore.
518 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
519 (gdcmFormatError now inherits from gdcmFormatUnexpected).
521 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
522 gdcmData/TestAllEntryVerifyReference.txt
523 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
524 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
525 exception_on_error parameter.
526 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
527 - vtk/vtkGdcmReader.cxx changed accordingly,
528 - Example/*.cxx and Test/*.cxx changed accordingly.
530 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
532 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
533 enable_sequences removed from gdcmHeader constructor and dependencies.
534 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
535 * gdcmPython/demo/PrintHeader.py: dummy fix.
536 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
537 skip_shadow removed from gdcmHeader constructor and dependencies.
538 * Example/*.cxx and Test/*.cxx changed accordingly.
540 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
541 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
542 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
544 2004-07-21 Jean-Pierre Roux
545 * FIX Now, Parsing and Printing a DICOMDIR do work!
546 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
548 2004-07-20 Jean-Pierre Roux
549 * FIX Some brain damaged headers have Zero-Lenght fields
550 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
552 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
553 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
554 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
555 variable (instance of gdcmDebug) by a definition macro, and the instance
556 is now in static in the gdcmDebug class
557 * src/gdcmSQItem.h : (FIXME) remove an undefined method
558 * Test/PrintAllDocument.cxx : bug fix in the result of the test
560 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
561 * WARNING: ctest now depends more tightly on gdcmData. You should
562 check out gdcmData properly for things to run smoothly...
563 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
564 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
565 we need the pixels not be loaded in order to use the ValEntry
566 that displays position and size).
567 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
568 This is a C++ based equivalent of gdcmPython/testSuite.py that should
569 be deprecated. If you have any doubts about the advantages of a
570 modern scripting language (read Python) versus grass root C++ (i.e.
571 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
572 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
573 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
574 Anyhow, consider documenting the gdcmData images in
575 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
577 * Test/CMakeLists.txt:
578 - now uses TestAllEntryVerify.cxx
579 - specific comments on oldACR00001.ima (now renamed in gdcmData
580 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
581 gdcmData/TestAllEntryVerifyReference.txt
584 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * src/*.[h|cxx] : typedef clean up
586 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
587 - TagKey renamed to gdcmTagKey (for external usage)
588 - VRKey renamed to gdcmVRKey (for external usage)
589 - removal of typedef duplication.
590 - Removed all unecessary inline keyword from class inline definitions.
591 - Some method|function(void) declarations replaced with method|function().
592 * src/jpeg/libijg12/jdhuff12.c:
593 - printf polluting ctest removed.
594 - TAB removal for comminting
596 - TestAllReadCompareDicom.cxx: added a test that compares all the
597 images in gdcmDataImages.h with corresponding images in
598 gdcmData/BaselineDicom/. When baseline images are not present
599 this test creates them.
600 Note: we need to validate each reference image, but before that
601 I'd like to rename them with a more explicit name...
602 - CMakeLists.txt: changed accordingly.
603 * Example/*.cxx: examples now only include gdcm.h (as opposed to
604 including each header needed).
606 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * Test/*.cxx and Example/*.cxx: moved some examples away from the
608 test suite to the Example directory. Are concerned:
613 - TestWriteSimple.cxx
614 * Test/CMakeLists.txt: added some comments on reasons for black listing
615 image gdcmData/oldACR00001.ima
617 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * Test/CmakeList.txt: removed the following from black list (to be coherent
619 with removal from gdcmData):
620 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
621 - gdcm-MR-PHILIPS-16.dcm
623 Added the following because after last cvs update, they cause
624 ctest -R TestReadWriteReadCompare
626 - gdcm-MR-SIEMENS-16-1.acr
628 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
629 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
630 new comments in this file) we temporarily (sigh) move to a weaker
632 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
633 we don't need to black list the following images anymore:
634 - 8BitsUncompressedColor.dcm
636 - US-PAL-8-10x-echo.dcm
637 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
638 fixes and the beautified code ;-)
639 This fixes the bug introduced in version 1.42 (when beautifying)
640 that made the parsing of 8BitsRunLengthColor.dcm unproper.
641 Note: ctest was blind to this bug (this means we need to still
642 improve the test suite). The bug could be detected by using
643 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
645 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
646 and by displaying the (garbage) produced file temp.XDCM...
648 2004-06-29 Jean-Pierre Roux
649 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
650 - replace by uggly but working old code :-(
651 A lot of things should be OK again.
652 It's really urgent to have a test suite that *tests*,
653 to prevent Frog's beautifying sessions to break all the stuff
654 (twice, withing a fortnigh ...)
656 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
658 redundancy) to added Test/TestReadWriteReadCompare.cxx
659 * Test/CmakeList.txt: because the compare test of
660 Test/TestReadWriteReadCompare.cxx fails, the following images are
661 black listed: - 8BitsUncompressedColor.dcm
663 - US-PAL-8-10x-echo.dcm
664 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
665 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
666 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
667 and ad-hoc kludge. This kludge is now removed, and on encountering
668 such an image (OB field brain damaged) we set errno. Then in
669 ::FindDocLength() we "fix" the length as being ALL what remains
670 in the file (until EOF). We then proceed, hoping for the best...
671 This fixes a SegFault in ShowDicom when trying to write such an
673 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
674 (because TestWriteRead breaks on it, after a non conformal commit?).
675 ctest now runs properly, except for MakeDicomDir (which was allways
676 broken) and the Python related stuff (still not fixed).
678 2004-06-24 Jean-Pierre Roux
679 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
680 FIX : Test/TestReadWrite now iterates on all the file names
681 (instead of infinite loop)
682 ENH : Test/TestWriteRead now iterates on all the file names
684 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
685 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
687 2004-06-24 Jean-Pierre Roux
688 FIX : - now Write drops LUT Descriptors and LUTs (if any)
689 when SamplesPerPixel =3
690 - now Write is no longer confused by
691 'BitsAllocated = 12" and 'BitsStored=12"
692 - "UN" value representation Elements are now written correctly
693 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
694 ENH : - now gdcmHeader has its own Write methods
695 (in order to split the job that has not to be done
698 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
699 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
700 loop on the same image until memory went out.
701 Note: this means we still have gobs of memory loss in PrintDocument
702 * src/gdcmDocument.cxx: fixes problem on parsing on file
703 gdcmData/16BitsJpegLosslessGrayScale.dcm.
705 2004-06-24 Jean-Pierre Roux
706 FIX : Write - All the Sequences and Sequence Item are now written
707 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
708 is added a the end, when necessary.
709 - A lot of brain-damaged images, that were read correctly are
710 now written correctly
711 - length compatible BinEntry are now loaded correctly
712 (even for odd groups)
713 Note : only Explicit Value Representation was checked.
714 (question : is implicit VR really necessary for gdcm ?)
716 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * DEVELOPPER: added a proposition of coding style.
718 * src/gdcmDocEntry.h: removed every inline declaration (for test of
721 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
722 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
723 Use the gdcmDocEntry::Print() and Write() instead.
724 * src/gdcmDocument.cxx: bug fix.
726 2004-06-22 Jean-Pierre Roux
727 FIX : gdcmDocument.cxx
728 - Now we do recognize the JpegLossLess format (there was a misstyping in
729 code 'beautyfication' :-(
730 - Now we automaticaticaly load the Luts, if any
732 2004-06-22 Jean-Pierre Roux
733 In order : to write Sequences, whatever their imbrication level,
734 : to allow user to create his own Sequences
735 a lot of modif where necessary (adding, moving, or virtualising methods)
737 WARNING : save your own sources *before* cvs up !
740 ADD virtual void Write(FILE *fp, FileType filetype);
743 ADD virtual void Write(FILE *fp, FileType filetype);
744 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
747 ADD virtual void Write (FILE *fp, FileType filetype)=0;
748 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
749 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
750 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
751 ADD std::string GetEntryByName(TagName name);
752 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
754 std::string vr = "unkn",
755 std::string fourth = "unkn",
756 std::string name = "unkn");
757 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
758 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
759 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
760 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
761 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
762 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
763 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
764 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
767 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
768 ADD virtual std::string GetEntryByName (TagName tagName);
769 ADD virtual std::string GetEntryVRByName (TagName tagName);
770 REM virtual bool Write(FILE *, FileType);
771 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
772 FILE *_fp, FileType type);
773 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
774 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
775 REM virtual bool WriteEntries(FILE *_fp,FileType type);
776 REM virtual std::string GetEntryByName (std::string tagName);
777 REM virtual std::string GetEntryVRByName (std::string tagName);
778 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
779 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
780 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
782 std::string vr = "unkn",
783 std::string fourth = "unkn",
784 std::string name = "unkn");
785 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
786 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
787 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
788 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
791 ADD virtual void Write(FILE *fp, FileType filetype);
794 ADD virtual void Write(FILE *fp,FileType filetype);
797 ADD virtual void Write(FILE *fp, FileType filetype);
798 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
799 REM std::string GetEntryByNumber(guint16 group, guint16 element);
800 REM std::string GetEntryByName(TagName name);
803 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
805 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
806 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
807 The default constructor invoked by the line
808 gdcmHeader *f1 = new gdcmHeader( header );
809 was gdcmHeader::gdcmHeader(bool) instead of the expected
810 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
811 Hence the parsing wasn't executed... See also below.
812 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
813 as explicit constructor didn't do the trick to fix the above problem.
814 Could anyone explain why ?
815 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
816 properly calls gdcmValEntry::Print() (that was weed out from
817 code related to gdcmBinEntry).
819 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * In order to fix memory leaks:
821 - Test/TestWriteSimple.cxx: added cleaning of free store through
823 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
824 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
825 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
826 (through the call to ::AddDicomDirMeta()) or the destructor
827 would crash when deleting uninitialized ::metaElems].
828 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
829 - src/gdcmDocument.cxx:
830 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
832 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
833 was causing memory leaks.
834 - src/gdcmSQItem.cxx:
835 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
836 cleanly handled with polymophism: sorry but my milage is low).
837 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
838 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
839 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
840 This avoids SegFaulting.
841 - src/gdcmSQItem.h: coding style.
843 - Test/TestWriteSimple still severely sucks. The output image content
844 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
845 damaged when displayed with vtkgdcmViewer.
846 - on memory leaks: TestWriteSimple leaks really less (see entry
847 of 2004-06-18 in Changelog file for the call to valgrind).
848 - on segfaults: ctest now passes all the tests but one (no more
850 * Erroneous leading white fix:
851 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
852 white[s] (as opposed to from >> xxx, that removes it [them].
853 - src/gdcmTS.cxx: ditto.
854 - gdcmPython/testSuite.py: dirty related kludge removed.
855 * src/*: remaining references to gdcmParser removed.
856 * src/*[cxx|h]: added copy[way]left header.
859 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
860 * In order to fix writing of dicom files:
861 - Test/TestWriteSimple.cxx: a simpler example of writing.
862 - Test/CMakeLists.txt changed accordingly.
863 - src/gdcmDocument.cxx:
864 -- The destructor now recursilvely removes potential sequences.
865 -- Bug fix in ::IsJPEG2000()
866 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
867 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
869 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
870 to only declared) and build on top of
871 ::GetDocEntryByNumber(guint16, guint16).
872 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
873 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
874 for usage in destructor and treatement of promotion in
875 ::ReplaceOrCreateByNumber().
876 - src/gdcmSQItem.cxx: destructor should better handle his job.
877 Test/TestWriteSimple now runs (or at least it DOES something).
878 * We can now start hutting memory links. A good starting point is:
879 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
880 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
881 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
883 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
884 * Valgrind note: after Mathieu Malaterre teached me how to read
885 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
887 Using gcc, you can force the STL to use malloc and to free memory as
888 soon as possible by globally disabling memory caching.
889 With 3.2.2 and later, you should export the environment variable
890 GLIBCPP_FORCE_NEW before running your program.
891 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
892 simply vanish (it is still not clear to me, whether this means that
893 STL std::string leaks or if valgrind believes it leaks...).
894 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
895 running bin/gdcmTests makeDicomDir):
896 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
897 - Test/makeDicomDir.cxx now properly traps empty lists and returns
899 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
900 SegFaulting (I drowned in DicomDir related code when trying to
901 understand why the list is empty...).
902 * src/gdcmDocument.h: first BSD license header try.
903 * Doc/License.txt added.
905 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * src/gdcmDocument.[h|cxx]:
907 - Clean up of the Transfer related predicates. They are now all based
908 on new method isGivenTransferSyntax, that (should) handle properly
910 - general clean up, simplification, and coding style.
911 - Specific clean up of Parse7FE0() (umproperly named actually).
912 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
914 2004-06-14 Jean-Pierre Roux
916 - fix the display of Sequence Delimitor (SQDepthLevel pb)
917 - fix the display of SQItem ordinal number
918 - add the GetSQItemByOrdinalNumber method
919 - remove some useless never written private methods
921 2004-06-14 Jean-Pierre Roux
923 - adding a constructor taking a gdcmDocEntry as an input param
924 - ReplaceOrCreateByNumber now returns :
925 a gdcmBinEntry * if a Binary (void *) value is passed as a param
926 a gdcmValEntry * if a string value is passed as a param
928 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
929 according to the param type (no longer sets a gdcmDocEntry)
930 - GetValEntryByNumber, GetBinEntryByNumber added
931 - NewValEntryByNumber and NewBinEntryByNumber added
933 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
935 - GetSQItemNumber and SetSQItemNumber added, to provide
936 a (relative) Item identier inside a given Sequence
937 \warning : some pb remaining around this number
939 - AddEntry now takes the Item Number as a param
941 - adding a constructor taking a gdcmDocEntry as an input param
943 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * Memory leak hunt with the following command:
945 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
946 --show-reachable=yes gdcmTests PrintDocument
947 It looks like many (all?) leaks are due to the STL (or a bad usage
948 of the STL. The lines producing the leaks now have a comment with
949 a "MEMORY LEAK" tag: you can retrieve them with
950 grep "MEMORY LEAK" src/*
951 Here are two typical examples which I can't help fixing:
956 char * test = "babo";
957 name = test; //// <--- valgrind detects 960 bytes lost in
958 //// call to std::string::operator=(char const*)
959 name.clear(); //// Doesn't help !
967 std::cout << "Type a bunch of characters followed by RETURN: ";
968 getline(std::cin, line); //// <--- valgrind dectects a loss
969 //// of 1320 bytes in call to
970 /// std::basic_istream<>& std::getline<>
976 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * src/gdcmHeader.[cxx|h]:
978 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
979 and related, moved away to gdcmDocument.
980 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
981 the corresponding protected accessors of inherited class
982 gdcmDocument, removed ! As a consequence gdcmFile had to be
983 declared friend of class gdcmDocument (see below).
984 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
985 - Clean up of undefined or unused methods.
986 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
987 account the changes to gdcmHeader.h).
988 * src/gdcmDocument.h:
989 - gdcmFile is now a friend class (in order to take into account the
990 changes to gdcmHeader.h).
991 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
992 (see changes to gdcmHeader.h).
993 - Accessors (reading on the form GetEntry*) are now public.
994 - Clean up of undefined or unused methods.
995 * src/gdcmDocument.cxx:
996 - adaptation to changes to gdcmDocument.h
997 - ::OpenFile now writes a verbose message when file cannot be opened.
998 - some std::string properly set to VRKey
999 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1000 references to gdcmDocument.
1001 * Test/TestFindTags.cxx: changed accordingly to above changes.
1002 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1003 cvs repository gdcmData.
1005 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1006 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1007 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1008 conflicts with gdcmValEntry::voidArea.
1009 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1010 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1011 Value representation between StringRepresentable and BinaryRepresentable.
1012 * src/gdcmDocument.cxx:
1013 - method ParseDES: proper indentation restored and usage of
1014 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1015 - method LoadDocEntry: the fingerprint left in the SetValue() of
1016 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1017 removed. Reverting to previous code segment with the proper
1018 dynamic_cast< gdcmValEntry* >.
1019 Note: this was (partially) breaking the python test suite
1020 (gdcmPython/testSuite.py) that made usage of the above
1021 fingerprint to check presence of "Pixel Data".
1022 * src/gdcmDocEntry.h: coding style.
1023 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1024 now taken into account.
1025 * gdcmPython/gdcm.i: adaptation to the new internal representation
1026 of gdcm (exit gdcmParser, hello gdcmDocument).
1027 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1029 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1030 anymore, but instead prints the loaded Python dictionary.
1031 * .... alas, the python testSuite is still broken.
1033 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1034 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1036 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1037 * src/gdcmUtil.h : export methods
1039 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1040 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1042 * Initial addition of automatic python testing
1043 * Initial addition of automatic image comparison
1045 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1046 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1047 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1049 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1050 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1051 * Test/ShowDicom.cxx : bug fix for msvc compilation
1052 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1054 2004-05-04 Jean-Pierre Roux
1055 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1056 new concepts (and new classes) :
1057 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1058 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1059 - Sequence Doc Entries (gdcmSeqEntries)
1060 a Sequence is composed of Items.
1061 Each item is a set of Doc Entries (this is recursive)
1062 The non uniqueness of the 'Dicom tag' is due to this recursivity
1063 (never taken into account)
1064 Our unability to add a new 'entry' in the header
1065 at the proper location (neither in the H-Table (map or multimap),
1066 nor in the Chained List is also due to this recursivity.
1067 Don't try, right now, to use/modify/compile these new sources :
1068 nothing is finished.
1069 We just commit all the stuff, 'as is', in order not to loose it.
1071 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1072 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1074 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1075 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1076 file prefix (SetFilePrefix)
1078 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1079 * Add a new test: ShowDicom, for now this is just the c++ version of
1080 checkRead.sh, later it will be able to compare the image read against a
1082 * Replace the DEBUG on the stack with a global entry in cmake interface:
1083 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1085 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1086 * Add an example subdir, with a real example on how to read + write a
1089 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1091 * Doc/CMakeLists.txt: the main page is now properly differentiated
1092 between the developper and user version.
1093 * Doc/doxygen.config.in: dropped search related obsolete flags
1094 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1096 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1097 * DEVELOPPER: added some helpfull comments for compile/test/install
1100 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1101 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1102 src directory, now generated in the build dir.
1103 2. Tests as mentionned smarter
1105 4. Add a new method in gdcmDict that return the PubDict by name
1106 this is interesting for 3rd party lib like ITK,
1107 where we could set the institution name / patient name...
1109 * ENH: 1. Now the test suite is working for real
1110 2. All binaries are now output in the gdcm-bin directory
1111 (this was not true before)
1113 2004-04-28 Jean-Pierre Roux
1114 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1115 SeQuence indented printing of Dicom Header.
1116 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1117 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1118 Computation of SQDepthLevel is now part of gdcmHeader constructor
1119 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1120 tree-like structure of a Dicom Header.
1121 * FIX Test code cleaning
1123 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1124 * ENH: Adding automatic testing
1125 1. Need a DartConfig.cmake to submit to public
1126 2. Add a test driver gdcmTest.cxx
1127 3. gdcmTestMain, an helper for the main test driver gdcmTest
1128 4. Files in Test don't have a main anymore, this becomes interesting
1129 when we add more and more tests, thus dsw don't have to load
1131 * ENH: Adding a GDCM_DATA_ROOT for testing
1132 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1133 one file instead of seven + some small cleanup
1135 2004-04-22 Jean-Pierre Roux
1136 * ENH Minor changes to the Print() methods.
1137 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1138 Header printing. Example given with :
1139 > PrintHeader fileName 2 new
1140 (SQ based tree-like structure still to be done for the Header ...)
1142 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1143 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1144 1. I have added some unsigned where needed
1145 2. Some function parameter not used -> (void)
1146 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1147 4. g++ don't like character '\' in comment
1148 5. #define jpeg_create_decompress jCreaDecompress
1149 this really need to be fixed
1150 6. virtualize destructor of gdcmObject ... leakage
1151 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1152 this also really need to be fixed
1153 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1154 remove compression file
1155 (as we only do decompression, right ?)
1156 * ENH: Change malloc/calloc/free with c++ equivalent
1158 2004-04-21 Jean-Pierre Roux
1159 * FIX gdcmHeaderHelper::GetXSpacing
1160 when a single value is found (bug ?), xpacing is now
1161 defaulted to yspacing
1163 2004-04-19 Jean-Pierre Roux
1164 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1165 * ENH add parameters :
1166 bool exception_on_error = false,
1167 bool enable_sequences = false,
1168 bool ignore_shadow = false
1169 to the gdcmFile constructors to be full gdcmParser compliant
1170 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1171 to allow reading of PAPYRUS 3.0 files
1173 2004-04-06 Jean-Pierre Roux
1174 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1176 2004-04-02 Jean-Pierre Roux
1177 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1178 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1179 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1181 2004-03-30 Jean-Pierre Roux
1182 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1183 for ACR file, written out as DICOM files (hope so...)
1185 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1186 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1187 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1188 moved to base class gdcmParser and only the specialisation is kept
1190 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1191 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1192 already does the job.
1193 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1194 (to be consistent with gdcmParser::WriteEntries).
1196 2004-03-30 Benoit Regrain
1197 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1198 upate of the object's instance. It's passed to 2 in the unfavorable
1199 case : one in the ExecuteInformation, one in the ExecuteData
1201 2004-03-29 Jean-Pierre Roux
1202 * ENH : Check on file type to be written moved
1203 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1204 * FIX : gdcmObject::ResetBoundaries now stops properly
1205 when end-of-list is reached
1206 : gdcmVersion modified (as Benoit Regrain asked)
1208 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1209 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1210 * src/gdcmUtil.cxx: added forgotten iostream include.
1211 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1212 equivalent to ExplicitVR in existing code).
1214 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1215 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1216 now contains all the gdcmGlobal related code.
1217 * minor coding style and doxygenation changes.
1219 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1221 now contains all the Debug related code.
1222 * minor clean-up of includes in src/*.cxx
1223 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1224 CreateCleanString) removed.
1225 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1226 * Doc/DoxyMainPageUser.txt added.
1227 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1228 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1229 src/gdcmDirList.cxx)
1231 2004-03-24 Jean-Pierre Roux
1232 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1234 2004-03-23 Jean-Pierre Roux
1235 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1236 big endian made volumes
1237 * ENH Now gdcmParser constructor and destructor are protected to forbid
1238 end user to instanciate class gdcmParser
1239 (only gdcmHeader and gdcmDicomDir are meaningfull)
1241 2004-03-22 Benoit Regrain
1242 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1243 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1244 gdcmSerie to gdcmDicomDirSerie
1246 2004-03-19 Jean-Pierre Roux
1247 * ENH Now the tree-like structure describing a DICOMDIR comming from
1248 an already existing DICOMDIR file is consistent with
1249 the home-made tree-like structure build ex-nihilo
1250 or build from the files held (recursively) in a Directory
1251 functions gdcmDicomDir::CheckBoundaries()
1252 gdcmObject::SetBoundaries() added
1254 2004-03-17 Jean-Pierre Roux
1255 * REM (Eric Boix bug) : removal of meaningless
1256 gdcmDicomDirImage::NewImage function.
1257 * FIX now file names and directory name are written properly in the
1259 * FIX now gdcmDicomDir constructor may be call without any trick
1262 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1263 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1264 of gdcmDicomDirImage::NewImage as empty function.
1266 2004-02-28 Jean-Pierre Roux
1267 * ENH add gdcmDicomDir:NewPatient
1268 add gdcmDicomDirPatient:NewStudy
1269 add gdcmDicomDirStudy:NewSerie
1270 add gdcmDicomDirSerie:NewImage
1271 to allow making gdcDicomDir object.
1272 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1273 (as opposite to the gdcmHeader chained list)
1275 2004-02-11 Benoit Regrain
1276 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1277 when using from python
1279 2004-02-10 Benoit Regrain
1280 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1281 * FIX : in gdcmDicomDir when the directory is empty
1282 * ENH : add callback and methods to get the progression of dicomDir
1285 2004-02-06 Jean-Pierre Roux
1286 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1287 - GDCM_META added to gdcmDicomDirType
1288 - class gdcmMeta created
1289 * ENH : - A brief summary is now displayed at the beginning of
1290 'testDicomDir' to help disaster magnitude estimation
1291 * REM : Now useless Test/explDICOMDIR.cxx
1293 2004-02-05 Benoit Regrain
1294 * ENH : add methods in gdcmObject to get the hash table or the list of
1296 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1297 * FIX : wrapping python for TagHeaderEntryHT
1299 2004-02-04 Benoit Regrain
1300 * FIX : even length for some strings when writting the dicom dir
1301 * FIX : sort the images in the dicom dir
1302 * FIX : Bug fix for python use of dicom dir
1303 * ADD : a python demo
1305 2004-02-04 Jean-Pierre Roux
1306 * FIX : Final solution (?) for icone embedded images
1307 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1308 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1309 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1310 gdcmData/gdcm-MR-SIEMENS-16.acr1
1311 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1312 to make full checking easier
1314 2004-02-04 Benoit Regrain
1315 * FIX : WriteEntries : coding style & logic in parameters
1316 * FIX : Set the elements to create the DicomDir in a dictionary file
1318 2004-02-03 Benoit Regrain
1319 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1320 * gdcmDicomDir : add the load of directory
1321 * Bug fix and print add-on
1323 2004-02-03 Jean-Pierre Roux
1324 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1325 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1326 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1327 * FIX gdcmParser.cxx : 'group length' elements are now considered
1328 as integers, even for shadow groups, when file is Implicit VR
1330 2004-02-02 Jean-Pierre Roux
1331 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1333 of the last synonym :-(
1334 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1336 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1337 * FIX taking into account the possible 7fe0,0010 multiplicity
1338 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1339 to allow removal of references to 7fe0,0010, to deal with
1340 ACR-NEMA images, when 0028,0200 is meaningfull
1342 2004-01-31 Jean-Pierre Roux
1343 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1344 no longer writes 'Un' on disk
1345 * FIX SQ elements with actual length are now dealt with corectly
1346 * FIX gdcmFile::WriteBase make the difference, for color images, between
1347 the length (for Palette expanded images)
1348 and Raw Length (non expanded image + Palette)
1349 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1350 (that broke Write). Replaced by UL.
1351 Aware user will reload the field if he
1352 thinks it's necesssary
1354 2004-01-30 Jean-Pierre Roux
1355 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1356 when 'dirty Acr' is found, to be compliant with the new
1357 IsReadable() methods.
1359 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1360 (no DOUBLE images in kosher DICOM,
1361 but so usefull for people that miss them ;-)
1363 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1364 DICOMDIR related utilities (not checked as Windoze compliant)
1366 2004-01-28 Jean-Pierre Roux
1367 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1369 2004-01-27 Jean-Pierre Roux
1370 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1371 to allow skipping the shadow elements, to save memory space.
1372 The TRUE value for this param has to be used
1373 with a FALSE value for the 'enable_sequence' param.
1374 ('public elements' may be embedded in 'shadow Sequences')
1375 * gdcmHeader methods now deal with 'embedded icones images' in the header
1376 (even when an 'icone image sequence' is announced by the
1377 element (0x0088,0x0200), but there is NO icone at all ...
1379 * gdcmHeader sometimes Image Location value doesn't follow
1380 the supposed processor endianity (see gdcmData/cr172241.dcm).
1383 * gdcmHeader add the method
1384 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1385 to get *all* the Header Entries with the same tag.
1386 GetHeaderEntrySameName is probabely *useless*
1387 (no meaning : Name is *not* an identifier within the Dictionnary)
1389 2004-01-26 Benoit Regrain
1390 * Bug fix in the print of hexadecimal representations. Remove long fields
1391 in the print and add a third level of print to print them
1393 2004-01-23 Benoit Regrain
1394 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1395 * Bug fix on test suite after remove the strip made on not string fields
1396 * Split the IsReadable method between gdcmParser which test that the file
1397 is dicom and gdcmHeader which test that it's an image file
1399 2004-01-22 Benoit Regrain
1400 * DicomDir : clean code, add methods, set variables in protected or private
1401 * gdcmUtil : bug fix for the clean string method
1403 2004-01-19 Benoit Regrain
1404 * Add the use of shadow dictionaries
1405 * bug fix and coding style
1407 2004-01-19 Benoit Regrain
1408 * src/gdcmFile.cxx : bug fix concerning the close of file
1409 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1410 * Add the update of header entries using the shadow library
1412 2004-01-19 Benoit Regrain
1413 * removal of file gdcmHeader2.cxx
1414 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1415 inheriting from gdcmParser. This split is to prepare the integration
1416 of dicom dir parsing
1417 * bug fix under python
1419 2004-01-16 Jean-Pierre Roux
1420 * REM removal of class gdcmHeaderEntrySet
1421 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1422 * ADD add file gdcmHeader2.cxx
1423 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1425 2004-01-15 Benoit Regrain
1426 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1427 entries created while parsing the header. Thus, they will be destroyed
1428 when the gdcmDictSet will be destroyed
1429 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1432 2004-01-15 Benoit Regrain
1433 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1434 made a fatal error because of the memory release at the end of program.
1435 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1436 some memory and vtk seems to have some problems with that.
1437 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1439 2004-01-14 Benoit Regrain
1440 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1441 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1442 * src/*.[h|cxx] : make changes due to class name changes
1443 * gdcmPython/demo/*.py : bug fix due to method names
1445 2004-01-13 Benoit Regrain
1446 * src/*.[h|cxx] : coding style
1447 * vtk/*.[h|cxx] : coding style
1449 2004-01-13 Benoit Regrain
1450 * gdcmPython/testSuite.py : test the readable flag of file for tests
1451 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1452 It's lied to the stl compilation by MSVC (windows, always windows...)
1453 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1455 2004-01-12 Benoit Regrain
1456 * src/*.h : add comments
1457 * src/gdcmDictSet.h : set the method BuildDictPath in public
1458 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1459 directly setted in the source code
1460 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1463 2004-01-09 Benoit Regrain
1464 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1465 * setup.py : use a reference to gdcmVERSION
1467 2004-01-07 Benoit Regrain
1468 * Modification to compile with the distutils.
1471 2003-12-10 Benoit Regrain
1472 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1473 can use a gdcmHeaderHelper to load datas
1474 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1475 made in the source code
1477 2003-12-10 Benoit Regrain
1478 * Update Windows projects and .cvsignore files
1480 2003-11-12 Jean-Pierre Roux
1481 * ENH gdcmHeader constructor has one more parameter (default value : false)
1482 that allows the user to 'go inside' the SeQuences only
1484 gdcmElValSet:Print takes it into account
1486 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1487 * ENH: Update gdcmPython/CMakeLists
1488 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1489 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1491 2003-11-10 Jean-Pierre Roux
1492 * FIX : gdcmHeader::LoadElements is now based
1493 on the ListTag listElem member,
1494 not longer on the TagElValueHT tagHt member
1495 * ENH : PrintPubElVal shows (temporarily) both results,
1496 with the tagHt member and the listElem member.
1497 (it's easier to 'see' the problems when using Printheader)
1499 * FIX : old private member LgrElem is now splitted into
1500 ReadLength : Length actually found on disk (updated only
1501 if bug fixing is necessary), for internal
1503 UsableLength : Updated by FixFoundLength, to fix a bug
1504 or to allow Parser going on.
1505 Will allow to re-write a kosher header when a SeQuence
1506 with a length (not 0000) is found
1507 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1508 because gdcmElValSet::Add does not update ListElem
1511 2003-11-07 Jean-Pierre Roux
1512 * FIX misstyping in Transfert Syntax name table
1513 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1514 when they have an actual length (not 0000 nor FFFFF)
1515 (Nobody should care of it, but DICOMDIR explorers)
1517 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1518 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1520 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1521 * ENH: vtkGdcmReader now supports LUT !
1522 (vtkgdcmViewer for now is not able to use them though)
1524 2003-11-05 Jean-Pierre Roux
1525 * in testSuite.py : new files names for checking the package
1526 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1527 that returns the pixel area size to the *aware* (vtk) user
1528 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1530 2003-11-05 Benoit Regrain
1531 * in testSuite.py : Modify the rules for checking the paths
1532 : Explicit error messages
1533 * in __init__.py : Related modif
1535 2003-11-03 Jean-Pierre Roux
1536 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1537 to be used by aware (vtk) users that want to manage
1538 LUT (and no to turn the PALETTE image into an RGB pixels one)
1539 * GetPixelType now returns 8U for 24 Bits images
1540 (vtkGdcmReader compliant)
1542 2003-10-31 Jean-Pierre Roux
1543 * Removal of *all* gdcmData images and add them again
1544 in order to loose the 'history' of un-anonymised images
1546 2003-10-31 Jean-Pierre Roux
1547 * RMV : removal of useless jBitsInJsample.h
1548 for both 8 and 12 Bits JPEG Lossy Libraries
1550 2003-10-31 Jean-Pierre Roux
1551 * ENH : Add the functions gdcmFile::GetImageDataRaw
1552 gdcmFile::GetImageDataIntoVectorRaw
1553 that act as GetImageData and GetImageDataIntoVector
1554 except the making of an RGB Plane from Gray Plane + LUT
1555 Intended to aware (vtk) users who know how to manage
1558 GetLUTRGBA return a R,G,B,A LUT if any
1559 lgrTotaleRaw gives the 'Raw' length
1560 GetImageDataRaw returns the gray Plane
1561 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1562 (They stay Grey, just like with other Dicom viewers :-(
1564 2003-10-30 Jean-Pierre Roux
1565 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1567 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1568 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1569 being coherents dicom files.
1571 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1572 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1574 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1575 * ENH: Two steps is necessary to please VC++ compiler...
1576 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1577 * ENH: Add include dir to medcon lib
1578 * FIX: only one function is being exported for now !
1579 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1581 2003-10-29 Jean-Pierre Roux
1582 * adding gdcmHeader::GetLUTRGBA
1583 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1584 --> Mathieu, the modif u're waiting for is not yet committed
1585 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1587 2003-10-27 Jean-Pierre Roux
1588 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1589 00191113.dcm DermaColorLossLess.dcm
1590 MxTwinLossLess.dcm RadBWLossLess.dcm
1591 * ENH: For version prior to vtkImageViewer2 -r 1.19
1592 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1594 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1595 * Removal of ido stuff in CMakeLists.txt
1597 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1598 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1599 * FIX: remove a call to ->Modified ... see comments
1600 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1602 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1603 * FIX: Problem with path for libvtkgdcmPython
1604 * ENH: Try adding a search script for python site-package
1605 * RMV: Remove some file from medcon lib that are not necessary
1606 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1607 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1608 * FIX: More pragma disable fro VC++,
1609 I don't think I break something as it is also disable in VTK/ITK.
1610 But it fasten debug compilation time.
1612 2003-10-23 Jean-Pierre Roux
1613 * gdcm now deals with 16 Bits Run Length Encoded images
1614 (they are compressed as 2 planes images,
1615 one for the high Bytes, the other for low Bytes)
1617 2003-10-22 Jean-Pierre Roux
1618 * Now CheckRead takes into account :
1619 - the bugged 'Leonardo' Siemens images
1620 - the XA images, sent thru the burning VPRO station
1621 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1624 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1625 * FIX: When copying a Makefile.am to CMakeLists.txt
1626 one should remove the '\'
1628 2003-10-22 Jean-Pierre Roux
1629 * in gdcmData adding a bugged 'Leonardo' Siemens image
1630 (wrong lengths in header)
1631 OK with gdcm, KO with the other viewers :-)
1632 * add a GE dlx XA image, thru the VEPRO burning station
1635 2003-10-21 Jean-Pierre Roux
1636 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1637 for a brutal checking of vtkgdcmViewer compliance
1639 2003-10-21 Jean-Pierre Roux
1640 * add the files for 'xmedcon' Jpeg Lossless library
1641 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1643 2003-10-21 Jean-Pierre Roux
1644 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1646 2003-10-21 Jean-Pierre Roux
1647 * garbage Siemens 'Leonardo' images dealt with
1648 (the patch is easy to remove)
1649 * cosmetic changes to avoid warnings
1651 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1652 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1653 no need to press 'r' now.
1655 2003-10-20 Jean-Pierre Roux
1656 * upgrade of checkRead.sh checkWrite.sh according
1657 to new Jpeg Lossless decompressor
1658 * add US.3405.1.dcm, a genuine RGB medical file ...
1659 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1660 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1662 2003-10-15 Jean-Pierre Roux
1663 * general anonymisation in gdcmData
1664 * adding the 'color files' from
1665 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1666 * adding some well knowed bugged-header images
1667 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1668 waiting for their inclusion in Python testsuite
1670 2003-10-15 Jean-Pierre Roux
1671 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1672 no longer seg faults when file is not found
1674 2003-10-14 Jean-Pierre Roux
1675 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1678 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1679 * TODO: *.in file to genereate a UseGDCM later
1681 2003-10-14 Jean-Pierre Roux
1682 * Some supposed-to-be Dicom Images have no preamble.
1683 OpenFile takes it into account
1684 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1685 * Missing elements added in dicomV3.dic
1686 (just to be affraid : have a look at
1687 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1688 and do it again next year ;->
1690 2003-10-13 Jean-Pierre Roux
1691 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1692 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1693 But there are NOT. It's fixed !
1695 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1696 * FIX: "jpeglib.h" was not found on VC++
1697 * FIX: vtkgdcm was not being installed
1699 2003-10-10 Jean-Pierre Roux
1700 * ENH : OpenFile closes the file if it *really* doesn't look like
1701 an ACR-NEMA / DICOM one.
1702 * FIX : testWrite no longer writes an empty file if the source file
1703 is not gdcm Readable
1704 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1707 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1708 * FIX: CMake generate now documentation
1709 * ENH: out of source doc build !
1710 * ENH: Generate both user and dev documentation
1711 * ENH: Should work on windows too
1712 * ENH: Only one doxygen config.in file is needed
1713 * FIX: make install should be ok now on ùnix plateform
1714 * FIX: PATH to dictionary was wrong (missing /)
1715 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1717 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1718 * vtkGdcmReader is now able to read rgb dicom file.
1719 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1720 * added a gdcmViewer to vtk test, use mouse to control
1721 window level & window width
1723 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1724 * CMake-ification of gdcm, we have now two build system
1725 * FIX: on cygwin Wsock32 doesn't exist
1726 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1728 2003-10-06 Emanuel Ollart
1729 * FIX : compilation process wad broken.
1730 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1732 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1733 * change gdcmViewer -> vtkgdcmViewer
1734 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1736 2003-10-06 Jean-Pierre Roux
1737 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1738 ( e.g : well known GE images with a wrong elem length,
1739 : Philips MRI Images with a wrong Huffman table)
1740 * still to be done : allow the reading of bugged LEONARDO Siemens images
1742 2003-10-03 Jean-Pierre Roux
1743 * Odd length strings are padded with '\0' (not with spaces,
1744 to remain compliant with already defined strings,
1745 like Transfert Syntax UID and others)
1747 2003-10-03 Jean-Pierre Roux
1748 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1749 to allow displaying RGB images (not only by affim ;-)
1751 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1752 * vtkGdcmReader is now able to read rgb dicom file.
1753 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1755 2003-10-03 Jean-Pierre Roux
1756 * A few nasty patches to allow the reading of a lot of nasty images
1757 ( e.g : well known GE images with a wrong elem length,
1758 : Philips MRI Images with a wrong Huffman table)
1759 * still to be done : allow the reading of bugged LEONARDO Siemens images
1761 2003-10-03 Jean-Pierre Roux
1762 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1764 2003-10-03 Jean-Pierre Roux
1765 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1766 to allow displaying RGB images (not only by affim ;-)
1768 2003-10-03 Jean-Pierre Roux
1769 * gdcmFile::GetImageDataIntoVector now
1770 - deals with MultiFrames MultiFragments Run Length Encoded files
1771 - deals with YcBcR (YBR_FULL) files
1772 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1773 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1775 (no sample found :-(
1777 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1778 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1779 Two reasons: - clear things
1780 - third parties acces gdcm through header files, so won't
1781 suffer anymore VC++ complains
1783 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1784 * add argv[1] in testvtkGdcmReader.cxx
1787 2003-09-24 Jean-Pierre Roux
1788 * The lines are now eigthy characters long.for
1789 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1791 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1792 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1793 char* to std::string. Thus, the use of strdup becomes useless. (see
1794 previous commis of Malaterre)
1795 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1796 before the last Malaterre's commit.
1798 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1799 * This commit should fix the Debug building under VC++, the problem
1800 was mainly a mixture of debug and release lib being loaded at startup.
1801 * I also remove a depency to a specific C function: strdup. Because I had
1802 to force the link to msvcrtd (whereas strdup is in libc).
1804 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1805 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1806 located in the gdcmCommon.h file. All use of reference of tha has been
1807 changed to now use the variable GDCM_UNFOUND.
1809 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1811 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1812 Dicom dictionary. The test suite can now be run again. Note:
1813 I'm note very happy with the " (RET)" changes. I believe this
1814 RETAINED comment should be dropped when parsing the dictionary.
1815 - PACKAGER corrected
1817 - AUTHORS updated and now in alphabetical order
1818 * Makefile.am now exports gdcm.dsw for Windoze users.
1820 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1821 * cygwin complains about missing std:: in subdir Test/
1823 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * remove some methods that are now in gdcmHeaderHelper
1826 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * vtkGdcmReader set spacing and origin correctly
1829 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1830 * Fix a few delete/delete[] mismatch
1832 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1833 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1834 interpretation to data given by gdcmHeader. For instance there are
1835 heuristics to get informations (look at different places).
1836 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1837 sorting DICOM images based on different strategies.
1838 * modified Makefiles accordingly.
1840 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1842 when building in debug mode
1843 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1844 src/win32/gdcmdll.dsp
1845 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1847 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1848 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1851 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1852 * src/win32/libgdcmjpeg12.dsp was not dos format
1853 * src/win32/libgdcmjpeg12.dsp :
1854 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1855 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1857 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1858 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1860 * src/gdcmFile.cxx : bug fix in affectation type
1861 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1862 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1863 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1864 symbols... future problem ?
1866 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1867 * src/win32/libgdcmijpeg12.dsp was missing
1868 * modified gdcm.dsw accordingly
1870 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1873 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1874 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1875 commit of JPR (before his hollidays to facilitate our work).
1876 * setup.py : bug fix in code. Modifications made while the last commit
1877 of JPR. The code hasn't been tested before the commit... it's so
1878 useless to make that (for best programmer that is JPR) !!!
1880 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1881 * tagged the current version as Version0_3 (i.e. version 0.3)
1883 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1884 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1885 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1886 * *.dsp : modifications to use new libgdcmijpeg8 library
1887 * setup.py : bug fix on VTKPATH variable
1888 * PACKAGER : adding all concerning windows
1890 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1893 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1894 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1895 test suite reported error.
1896 * PACKAGER file added (describes what a packager must do when
1897 packaging a new release).
1898 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1899 * configure.in: upgraded version number to 0.3.0
1900 * fixing build of rpm (through rpm -ta):
1901 - Doc/Makefile.am exports proper doxygen files
1902 - src/jpeg/libijg8/Makefile.am exports the include files.
1904 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1905 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1906 * src/gdcmHeader.h : formatting code
1908 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1909 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1910 We were obtaining error message from vtk. Now, creation of file list
1911 is made in an internal list to prevent this problem.
1912 Bug fix when output is empty.
1913 Bug fix in update of progress value. Previous commit for this was a bad
1915 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1917 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1918 * src/gdcmHeader.h : added method to get the file name
1919 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1920 files. Added method to remove all files on the input
1921 Added FIXME comment concerning the bad parsing of header made by
1922 ExecuteInformation method (in ExecuteData method)
1924 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1925 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1926 when using make instal.
1927 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1928 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1930 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1931 * setup.py : adding include dir of jpeg lib to compile all sources
1932 * */Win32/*.dsp : JPR fix for windows compilation
1934 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1935 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1937 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1938 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1940 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1941 * setup.py is again effective on un*x (takes into account the
1942 addon of the jpeg library)
1943 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1944 * Doc/Doxy* updated (includes above enhancements)
1945 * INSTALL now points to web documentation
1947 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * src/gdcmHeader.h doesn't make unnecessary reference to
1950 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1952 * src/gdcm*.[cxx|h] :
1953 - to allow compilation with gcc 3.x
1954 -- clean up of STL usage (added explicit usage of std::)
1955 -- small fixes on exceptions.
1956 Note: linking not tested !
1957 - clean of doxygen comments to avoid warnings at documentation
1959 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1960 dependent convertion).
1962 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1963 * Clean up of previous JPR garbage commit (not even commented in the
1965 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1966 - moved all jpeg related files from src to src/jpeg/libijg8, with
1967 addition/modification of Makefile.am and configure.in.
1968 - the testSuite is still brain damage (not guilty).
1970 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1971 * WrapVTK.py : modifications to get correctly vtk source files to
1973 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1974 (FileName -> Filename)
1976 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1977 * vtk/vtkGdcmReader.[cxx/h]:
1978 - UpdateProgress method should now be effective
1979 - removed the limitation on having only images loaded (as opposed
1981 - when building a stack of images/volume, a lesser number of
1982 gdcmHeader and gdcmFile instances should be used (hopefully
1983 accelerating things).
1984 - when building a stack of images/volumes, files which are not
1985 loadable (wrong path-filename, wrong permissions on existing file,
1986 or file not parsable by gdcm) are replaced with a black image
1987 in the stack (for the caller to notice the problem).
1989 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1990 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1992 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1993 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1994 between standard library (std) and vtk library (problems are found
1995 under Windows... thanks Windows !)
1997 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1998 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2000 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2002 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2003 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2005 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * When compiling with distutils (see setup.py) the C++ compiler is
2007 called with different flags than the default ones (with automake).
2008 In order to fix all those warning, I compiled gdcm with the command
2009 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2010 and went for warning fixes:
2011 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2012 up from unused variables.
2013 - vtk/vtkGdcmReader.cxx: potential bug fix.
2014 * src/gdcmHeader.h: Doxygen warning cleanup
2016 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2017 * gdcmPython/gdcm.i:
2018 - typemaps correction to take into account the systematic replacement
2019 of "using namespace std" with std:: prefix e.g. std::list,
2020 std::string... (cf changes of 2003-05-21).
2021 - gdcmGlob global variable of type gdcmGlobal (defined in
2022 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2023 exported to Python a as cvar.
2024 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2025 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2026 gdcmDictSet.GetPubDictTagNames() and
2027 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2028 C++ static methods).
2029 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2030 with the above changes.
2032 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2033 * setup.py, manifest.in : bug fix under linux
2035 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2036 * Modification of setup.py to compile vtk part too. Then, we have 2
2037 wrappers which must work with same distutils. For that, we have a
2038 generic distutils in distusiltsWrapping.py ; with :
2039 - build_extWrap class to wrap generically all extensions,
2040 - ExtensionWrap base class for all wrapping extension that contains
2042 - Wrapper interface which wrap sources
2043 + In WrapSwig.py we have extension and wrapper for Swig
2044 + In WrapVTK.py we have extension and wrapper for VTK
2045 * MANIFEST.in : modifications to consider vtk directory and new python
2046 files for compilation
2048 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2049 * Added python wrappers of vtkGdcmReader vtk class (see the
2050 source in vtk/vtkGdcmReader.cxx) :
2051 - vtk/Makefile.am now builds a library
2052 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2053 python library (as opposed to _gdcm.so wich are the python
2054 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2055 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2057 - configure.in has an additional flag --enable-vtk that needs
2058 to be set to enable compilation of vtk related code, that is:
2059 + vtk/vtkGdcmReader.so and
2060 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2061 + gdcmPython/vtkgdcmPython.so (see above)
2062 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2063 be read when compressed or when HighBit + 1 != BitsStored),
2064 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2065 the usage of the python wrapper of vtkGdcmReader vtk class.
2066 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2067 * src/*.[h] all occurences of stl classes are now prefixed with
2068 std::, and all occurences of "using namespace std;" where removed.
2069 This is to avoid pollution of global namespace in included files.
2070 Apparently vtk does not avoid this pitfall: when using both
2071 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2072 collision of various stl members (principally cout...).
2073 * gdcmPython/testSuite.py now cleanly removes temprory generated
2075 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2076 comply with above changes)
2078 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2079 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2080 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2081 vtk data structure (an image Flip was required).
2082 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2083 * cosmetic changes in documentation.
2085 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2086 * src/gdcmHeader.cxx: the constructor no longer exits when an
2087 unexisting file is given as argument.
2088 * The subdirectory Data (containing all the images used for the
2089 test suite) is not part of this repository anymore. A new module
2090 containing those images is now available at
2091 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2092 with the name gdcmData.
2093 All the python scripts (including the package initialisation file
2094 gdcmPython/__init__.py) were adapated to take this change into
2095 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2097 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2098 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2099 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2100 demo of the usage of this class.
2101 Compilation of this vtk part is only done when using the --enable-vtk
2102 at configure (or autogen.sh) stage.
2104 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2105 * More memory link related corrections and documentation fixes.
2107 - maximum info is obtained with a command of the form:
2108 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2109 --show-reachable=yes PrintHeader
2110 - the remaining reachable blocks seem to come from the STL
2111 allocation scheme through the usage of map and list. It looks
2112 like this memory cannot be freed but it is not a memory leak
2113 (in fact further invocation to the STL would recollect the
2114 unused memory allthough it cannot explicitely be freed).
2115 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2116 of displaying an image parsed with gdcm and displayed with VTK.
2117 Note: some images don't seem to work e.g.
2118 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2119 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2120 Allthough this weakens the semantics, it is a ditch attempt to
2121 make gdcm more thread friendly.
2123 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2124 * Memory link hunt (by using valgrind through the command
2125 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2126 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2127 gdcmHeader::_dicom_vr.
2128 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2129 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2131 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2133 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2134 * src/Makefile.am now exports all the necessary include files at
2138 * UpdateGroupLength replaced by new one
2141 * UpdateGroupLength re-written using H-Table
2142 (named UpdateGroupLengthNew untill checks are over)
2144 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2145 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2146 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2148 - gdcmHeader::GetPubElValSet removed.
2149 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2150 UpdateGroupLength, WriteElements, Write.
2151 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2152 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2153 carried the same semantics.
2154 - src/gdcmHeaderIdo.cxx changed accordingly.
2155 - gdcmFile::WriteBase now regroups all the codes from previous
2156 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2157 - enum FileType moved to gdcmCommon.h
2158 * src/gdcmHeader.cxx AddDefault trashed
2159 * gdcmGetXSize added
2160 * getimageDataSize now calls gdcmGetXSize
2161 * Test/*.cxx changed to agree with above changes
2163 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2165 (to avoid double call by end user).
2166 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2167 by end user, since gdcmHeader::gdcmHeader now handles it.
2169 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * gdcm/Doc many doxygen changes:
2171 - Doxyfile now has two different versions, DoxyfileUsers that generates
2172 the html.users end users oriented documentation and
2173 DoxyfileDeveloppers that generates the html.developper developper
2174 oriented documentation.
2175 - README changed accordingly
2176 - requirement.txt removed (old design info moved to TODO).
2177 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2178 DoxyMainPage.txt, DoxyPython.txt provide more information.
2179 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2180 be updated by simply regenerating the docs with doxygen and copying
2181 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2182 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2183 all the tests in the form "if (<map>.count() >1)" were removed.
2184 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2185 ill-formed documentation sections.
2186 * src/gdcmHeader.cxx: ditto
2188 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2189 * setup.py fixed for un*x (needed macro for stdint.h)
2190 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2191 un*ces with sh-utils test utility.
2192 * gdcmPython/demo/test.py renamed to PrintHeader.py
2193 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2194 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2195 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2196 * src/gdcm*.cxx JPR's bad inclusion fixed.
2198 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2199 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2200 * gdcmPython/demo/test.py changed accordingly.
2202 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2203 * gdcmPython/Makefile.am fixed linking against libstdc++
2204 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2205 * Swig subdir (historical tests of swig version 1.3.17++) removed
2206 * Test/testChangeEntete.cxx some lines commented out in order to make
2208 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2209 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2211 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2213 hence the user doesn't need this explicit call.
2214 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2215 i.e. LoadElements() call removed.
2216 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2217 - src/Makefile.am declares the proper flag for g++.
2218 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2219 for adding user defined new tags.
2220 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2221 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2222 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2224 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2225 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2226 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2227 src/Makefile.am : the project should properly compile and install
2228 with the autotools, included the python wrappers part.
2229 * gdcm.spec.in : added a spec file for RPM packaging.
2231 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2232 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2234 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2235 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2236 to exported to the environement (see gdcmPython/testSuite.py
2238 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2239 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2240 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2241 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2242 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2244 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2245 * gdcmPython/__init__.py doesn't crash anymore when running in
2246 in InstallMode or PreInstallMode but with an environement given
2247 value of GDCM_DICT_PATH.
2248 * src/gdcmDictSet.[cxx/h] coding style.
2250 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2251 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2252 * src/gdcm.h general comments moved to TODO, and README
2253 * src/gdcm.h should now be seen as a user commodity (including it
2254 should suffice to fully use gdcm). It is nowhere including within
2255 any of the kernel files src/*.cxx and src/*.h.
2257 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2258 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2259 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2261 * src/gdcm*.cxx only include their corresponding include file
2262 (as opposed to gdcm.h)
2263 * gdcmPython/gdcm.i changed accordingly
2264 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2265 the autogen.sh generated "make snapshot" command to work.
2266 * autogen.sh removed history related references to crea package.
2268 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2269 * distutilsSwigCPlusPlus.py work around some swig portability
2272 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2273 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2274 was done in a last ditch attempt to get setup.py _really_
2275 operationnal. The python/gdcmPython layaout add the advantage
2276 of hidding away the python related distutils specific files
2277 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2278 Alas, the src directory was out of scope (i.e. it's relative
2279 position to setup.py was ../src) which made things impossible to
2280 handle (see previous version of python/setup.py). Crossing fingers...
2282 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2283 * python/setup.py now works on Un*x. (harder than I thougth)
2284 * python/distutilsSwigCPlusPlus.py can now have include files
2285 among the list of sources.
2287 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2288 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2289 * modifications in MSVC projects
2291 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2292 * As stated by the first lines of Test/ExceptionAndPython/README, it
2293 looks like we can move back to original usage of exception within
2294 src/gdcm* and hence remove the errno stuff that was introduced
2295 as a quick and dirty fixture of this problem (added to the TODO).
2296 * Doc/Doxyfile configuration file for Doxygen and corresponding
2297 README file for usage added.
2298 * Test/testWrite.cxx added. This new test comes from a split of
2299 test.cxx that is now reverted to its original purpous i.e.
2300 testing the proper parsing of a Dicom related file.
2301 testWrite.cxx concentrates on testing the IO part of gdcm.
2302 * Test/bug1.cxx (containing a bug on WIn32) added.
2303 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2304 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2305 whose purpose is to publish the content of the TagNames of the
2306 Dicom public dictionnary were not accessible without an
2307 instance of class gdcmHeader.
2308 - those methods are now static methods of gdcmDictSet and hence
2309 require no instances at all to be invocated.
2310 - within gdcmDictSet this change required to change some method
2311 to class methods (i.e. are now static) among which SetDictPath
2312 (renamed to BuildDictPath) and LoadDefaultPubDict.
2313 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2314 the above changes by calling the new method classes of gdcmDictSet.
2315 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2316 the above to be effective.
2317 * python/gdcmPython: in order to wrap properly the above changes
2318 for Python, swig version now needs to be > 1.3.17.
2319 * python/gdcmPython/Makefile fixed to adapt itself to new
2320 configure/make shema introduced by Johan Montagnat (thanks for the
2321 contribution). Alas this Makefile cannot be turned into a proper
2322 Makefile.am without some heavy changes in the configure.in
2323 (for python dectection).
2324 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2325 now avoids publishing the empty entries.
2327 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2328 * python/setup.py : bug fix concerning install under windows
2329 ExtraPath reused :-P
2330 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2332 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2333 * Dicts/dicomV3.dic : remove double spaces !!!
2334 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2335 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2338 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2339 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2340 method. Doxygenation.
2341 * src/gdcm.h clean up of JPR spurious comments.
2343 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * python/distutilsSwigCPlusPlus.py now properly collects the
2345 shadow classes generated by "swig -c++" (gdcm.py in our case)
2346 when using "python setup.py install".
2347 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2348 reexports the working classes.
2349 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2350 by the classical C errno scheme. This is to prevent an obscure
2351 behavior of the python wrappers when importing wxPython.wx prior
2352 to gdcmPython (which ended up in an abort call). An illustration
2353 of this oddity can be found in the Test/ExceptionAndPython
2354 subdir (see the README file). This problem probably due to
2355 an combination of g++ and dynamic loading.
2356 * added Test/ExceptionAndPython (see above)
2358 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2359 * Changed the layout of the python part to avoid bloating main
2360 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2361 i.e. the distutils arsenal. All the python related stuff is
2362 again in a python subdir, but the package itself is now in
2364 * setup.py was cleaned up:
2365 - pythonIncludePath removed
2366 - python setup.py bdist target is now functional.
2367 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2368 collision with other packages). gdcmPython/demo/*.py changed
2371 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2372 * python subdir moved to gdcmPython (preparation of distutils packaging).
2373 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2374 distutils installer is operational.
2375 * - gdcmPython/__init__.py now properly loads the swig generated
2376 shadow classes (from gdcm.py).
2377 - gdcmPython/demo/*.py changed to import the package gdcmPython
2378 instead of gdcmPython/demo/load.py.
2379 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2381 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2383 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2384 entries within the associated public Dicom dictionary resp. the same
2385 information but sorted by the fourth field (PAT, IMG, DIR) of the
2387 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2388 are now in the "???" group.
2389 - python/gdcm.i changed accordingly,
2390 - python/demo/printGroupedPublicDict.py added, that gives an example
2391 of the above new functionalities in Python.
2393 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2394 * src/gdcm.h, gdcmHeader.cxx:
2395 - historic references to glib's g_malloc and g_free (#defined)
2396 were definitively removed.
2397 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2398 * src/gdcmElValSet.cxx:
2399 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2400 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2401 - GetElValue(string) renamed to GetElValueByName.
2402 - Added GetElementByName(string).
2403 * src/gdcmHeader.cxx: added
2404 - GetPubElValRepByNumber(guint16, guint16)
2405 - GetPubElValRepByName(string)
2406 - GetShaElValRepByNumber(guint16, guint16)
2407 - GetShaElValRepByName(string)
2408 - GetShaElValByNumber(guint16, guint16)
2409 - GetShaElValRepByName(string)
2410 - GetElValRepByNumber(guint16, guint16)
2411 - GetElValRepByName(string)
2412 - GetElValByNumber(guint16, guint16)
2413 - GetElValRepByName(string)
2414 * Doc/requirements.txt added.
2416 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2417 * Test/Makefile building now depends on the one of libgdcm.so
2418 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2419 pixel data) aware which enables finding the address (offset) of
2420 the pixel data of JPEG encoded DICOM files. This leaves only a single
2421 file in the testSuite whose pixel data address (offset) is unknown.
2422 * python/testSuite.py changed accordingly.
2424 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2425 * VC++ has some strong limitations when working with the STL, as stated
2426 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2427 "Also note that some STL containers (map, set, queue, list, deque)
2428 cannot be exported. [...]
2429 Some STL classes contain nested classes. These classes can not
2431 This is caused by a designed limitation that once a template
2432 class is instantiated, it can not be re-instantiated and
2434 Since our usage of map<> is ubiquitous in gdcm, this "designed
2435 limitation" of VC++ is a pitfall.
2436 Hence the Python wrappers of gdcm cannot be incrementally linked
2437 against the c++ dynamic library. The dirty but only workaround is
2438 to forget about incremental link of dynamic libraries and to generate
2439 the Python wrappers library with the inclusions of the underlying C++
2441 The following modifications concern this matter on Win32/VC++:
2442 - wrapping python correct with standalone wrapped dll (don't use separate
2443 dll under windows !!!!)
2444 - python21_d debug mode enabled (ask Frog how to use it :-)
2445 - NO problem with having an STL member of class for example string in C++
2446 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2447 - Python test of dcmlib in Python is ok under windows on a large set
2449 * removed glib references
2450 * typedef's inserted in gdcm.i for correct swig type management
2452 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * python/demo/*.py load.py extracted from test.py. Added explore.py
2454 that only displays required tags and testAll.py that parses all
2455 the files of the testsuite without using unittest.
2456 * python/testSuite.py other additional test on new files added.
2457 * Data/* new test files added accordingly to the testSuite.
2458 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2459 the vr in the file differs from the one of the dictionary.
2461 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2463 values, but limits itself to values which are below a user specified
2464 size (by default 1024 bytes).
2465 * python/gdcm.i : elements not loaded (because their size is above the
2466 user specified treshold) are exported with their TagKey as key of the
2467 python dictionary. This enables the testsuite to make some checks
2468 on the unloaded elements (since we have their offset and size).
2469 * python/testSuite.py
2470 - now tests for the existence and proper value of the pixel data
2471 - two new examples added.
2472 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2474 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2476 aware. See the strategy comments in gdcmHeader::FindeLength().
2477 * Test/test.cxx now accepts a filename as first argument.
2478 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2479 * python/testSuite.py changed to integrate test on above files.
2481 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2483 the vr was also RET.
2484 * python/testSuite.py more tests added.
2486 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2487 * python/testSuite.py unittest test suite added (uses Data)
2488 * Data/* dcm and acr files for the test suite.
2489 * glib dependance removed from un*x version. We now use ISO C99
2490 7.18 Integer types (see stdint.h)
2491 - python/Makefile, src/Makefile src/gdcm.h
2492 * src/ when an explicit vr (like dicom files) suddenly poped an
2493 implicit element we use to mark the underlying DictEntry of the
2494 concerned ElValue with "Implicit". This strategy was damageable
2495 too the public or provite dictionaries, since some of their vr
2496 would be changed. Since Header::FindLength heavily relies on the
2497 detection by Header::FindVR of falsely explicit elements, I
2498 added an extra ImplicitVr member to ElValue (boolean).
2499 The rest of the changes we the necessary adaptations.
2501 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2502 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2504 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2506 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2507 * Adaptation for porting to VC++:
2509 o forced to use std namespace (for string to be known)
2510 o all class use __declspec export style on WIN32
2511 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2512 (in stdlib.h on Win32 but in std:: for gcc)
2513 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2514 variable GDCM_DICT_PATH.
2515 * src/gdcmHeader.cxx verbose comments made discrete.
2517 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2518 * python/gdcm.i: added a typemap that converts a C++ hashing table
2519 to native Python dictionary.
2520 * python/demo/test.py:
2521 - now uses the native dictionary for exploration of gdcmHeader.
2522 - takes an optional filename argument (the file to parse).
2523 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2524 PubElVals hashing table.
2525 * Dicts/dicomV3.dic removed error prone trailing spaces.
2527 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2528 * Python wrapping process moved away from src/Makefile to
2529 newly created python/Makefile (as well as gdcm.i)
2530 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2531 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2532 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2533 from the environement variable GDCM_DICT_PATH (when existing).
2534 * src/gdcmDict::GetTag bug fix.
2536 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * Straightforward temporary fixes for swig to build the python wrappers.
2538 src/Makefile now has a python working entry [by working we mean
2539 that we can import de shadow classes without errors].
2541 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * hashtest.cxx removed (since allready in Test)
2543 * src/gdcmlib.h renamed to src/gdcm.h
2544 * src/dcm.i renamed to src/gdcm.i
2545 * src/Makefile prepared for python wrapping
2547 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * src/gdcmHeader.cxx :
2549 - Parsing of header is now separated from loading of element values
2550 (see gdcmHeader::LoadElements).
2551 - general clean up of hopefully all file access (creation of
2552 ReadInt16 and ReadInt32)
2554 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2555 * src/gdcmHeader.cxx :
2556 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2558 - SetLgrElem renamed to SetLength
2559 - GetLgrElem renamed to GetLength
2560 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2561 * src/gdcmElValSet.cxx fixed both GetElValue methods
2562 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2563 due to IdoDude was cleaned out.
2565 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2567 concentrates on finding the value representation (when it exists).
2568 RecupLgr now only finds the element value length, and it avoids
2569 returning the unecessary skL (skipped length).
2570 Also, offsetCourant was simply removed (with taille_fich) since
2571 it was redundant with the File position internals (by using
2572 ftell and fseek). This also made skL (see above in RecupLgr) usage
2574 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2575 on the libido specificities which are handled through class
2577 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2580 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2581 * Truckload of changes. Parsing of header is barely functional
2582 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2584 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2585 * src/gdcmHeader.cxx many addons of low level methods
2587 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2588 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2589 and _IdDcmSWAP_LONG.
2591 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2592 * This corresponds to all the changes decided at the meeting of
2593 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob