1 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
3 - Remove printf / sprintf
4 - include iostream AFTER gdcm so we don't get warnings
5 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm source
6 - Also remove tons of include from header files, hopefully this should speeup the compilation time, since it was becoming a dog slow.
7 - Remove gdcm.h as it include way too many files and slow down compilation (plus it is not up to date)
8 - remove 'using namespace std' this is BAD !
10 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Remove memory leaks on the DicomDir
12 * Remove some useless datas in DicomDirObject
13 * Add usefull methods in SQItem, to be complient withe the ElementSet
15 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
18 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
20 future, with convertion)
21 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
22 and ImageDataSize values. Remove the method to get the PixelReadConverter
23 from the output of the class
25 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
28 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
30 and vtkErrorMacro use.
31 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
33 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
36 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
37 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
38 The string leaves only in the fonction. So when we make a .c_str(), we
39 get the pointeur on the first element, element that will be destroyed
40 immediately after thee instruction.
41 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
42 file has been opened : the test must be made on the content of the
43 pointer and not directly on the pointer !
46 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
48 the python part recompiles
50 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
52 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
53 X session is killed (for my computer... it seems to not be identic on
56 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
58 avoid problems (otherwise, the difference test between the visible image
59 and the reference is incorrect. If the reference is greater than the
60 screen resolution, it's produce errors).
61 Can be used for only one image. Can be used with a visible flag.
62 * vtk/vtkGdcmReader.cxx : remove commented codes.
63 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
64 under windows at compilation
65 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
67 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
69 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
71 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
72 tests on the image size X, Y, Z
74 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
76 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
77 between the class name and the file name
79 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * src/ : fix compilation warnings for the Write method (2 different
81 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
82 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
83 variable... create a static method in gdcm::Document to access to
84 this variable content.
86 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
88 file, to be accessed by other files (like gdcmFile). Remove commented
89 code. Move the change of the header to the gdcmFile, using the
91 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
92 To be sure of that (and simplify calls), the Write of the header now
93 gets a file name and not a file pointer (std::ifstream).
94 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
95 DocEntryArchive. Remove all open of the written file
97 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
100 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
102 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
104 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
105 some corresponding methods. Write correctly the file and check before
107 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
108 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
109 is now on RGB datas (as before my last commit
110 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
112 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
114 Add a print information of the type of the entry
115 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
116 It was in the gdcmFile, and all write have been regrouped
117 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
118 Write correctly all dicom files (in decompressed mode only at this time)
119 * Test/ : test on files are now made using Raw datas and not color datas if
121 * Example/PrintFile.cxx : add more printings
123 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * Amelioration of code, remove some code copy. For the loading of
125 BinEntry (in gdcmDocument), add the test to verify if the file is already
128 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
130 remove a DocEntry in the header (push an empty DocEntry)
131 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
132 lines. Bug fix in the initialization of the PixelConvert and the
134 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
135 use in TestCopyDicom (now this test can run under windows... but fails)
136 * Test/TestCopyDicom.cxx : amelioration of the test :
137 - test the pixels written
138 - add test points to quickly find where is the error
139 - can set a file name input and output in arguments
140 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
141 amelioration of the test output
143 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
145 all replaced DocEntry's
146 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
147 Now, each needed DocEntry to modify is duplicated, modified and inserted
148 to the header using DocEntryArchive. Thus, after save, we can restore the
149 header initial state.
151 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
154 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
156 correct to copy it. The DictEntry is specified at the DocEntry creation,
157 then, it musn't change in the time.
158 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
159 header correctly. At this time, the change is only made for the first
160 level of the Document. In the future, it might consider sequences.
161 The change is made by replacing a DocEntry by an other that is created
162 outside the class. The old value is kept. When we restore the header
163 status, the added DocEntry is deleted and replaced by the old value.
164 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
165 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
166 set the write type to explicit VR, implicit VR or ACR. Add methods to set
167 the write mode to native, decompressed or RGB (but not used at this time)
169 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
171 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
173 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
175 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
177 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
178 set because already copied when copying the BinEntry's of the header
179 * Test/TestAllReadCompareDicom.cxx : remove warnings
181 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
183 Two problems appear when doing it :
184 - with the gdcmFile : when the GetImageData method is called, the pixels
185 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
186 datas (pixels). And each structure destruct the datas when it's
187 destructed. So we have two destructions for the same datas. To solve it,
188 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
189 datas or not. If it doesn't own datas, then they will not destroyed by
191 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
192 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
193 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
194 create a double destruction of the same DocEntry's. So, to solve it,
195 the TagHT is simply cleared and the DicomDir* elements are destroyed.
196 * TODO : add an entry concerning memory leaks in the DicomDir
198 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
200 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
203 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
205 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
206 after it have been deleted
208 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
209 * FIX: src/* fix the doxygen warnings.
210 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
211 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
212 was erroneously defined with a size of 15 instead of 16. [many thanks
213 to Jean Michel Rouet for pointing out this bug].
215 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
216 1. Finish merging JMR patch for writting DICOM from scratch
217 2. Fix -hopefully- bug with MONOCHROME and space vs null character
218 3. Use const ref when possible
219 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
220 5. A few more comments
221 6. CreateUniqueUID can now be called without parameter"
223 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
224 * ENH: Slightly bigger patch:
225 1. Getting toward full integration of JMR patch for writting dicom from scratch
226 2. Update Test to test part of this patch: CreateUniqueUID
227 3. File was not close properly in gdcmDict
228 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
229 5. Use of const ref instead of copy (speed issue)
230 6. Remove temporary (duplicate) string in TranslateToKey
231 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
232 8. Do not repeat virtual in subclasses
233 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
235 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
236 * Apply first patch toward better string comparison when dealing with broken
237 DICOM files. Essentially the string could be padded with a space instead
238 of a null character as defined by standard
240 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
242 because never used... and in the same time, that's remove some memory leaks
244 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmFile.cxx : now delete the PixelConvert instance.
246 * In examples and tests : change the type of image data variables from void*
247 to uint8_t*. Remmove all delete on image data variables
249 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
251 Verify the file pointer value before open the file, and if it's not null,
252 a verbose message is generated.
253 Close correctly the file when the file isn't considered dicom-like. The
254 correctly close is a call to CloseFile.
255 When closing the file pointer, test if its not null to close the file.
256 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
257 file. For an uncompressed image, the copied datas correspond in the least
258 case to the image size (calculated) or the image size specified in the
259 header. A verbose is generated if these two size mismatch
261 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
263 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
264 break under windows (with msvc6 compilation).
266 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
268 compiling with MSVC6)
270 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * Bugs fix for the Windows build with VC6
272 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
273 needed (only for projects required VTK). If the VTK is included in all
274 projects, there is conflicts with the jpeg lib of vtk when compiling the
275 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
276 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
277 when compiling the gdcm_wrap.cxx file (created by the compilation of the
279 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
280 (like it's already made for the cout use). Otherwise, conflict with the
283 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
286 - comments on the DicomDir::Method related usage added.
287 - now that we use the namespace gdcm, a lot of internal classes do
288 NOT need to be wrapped anymore.
289 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
290 DicomDir::Method) new example added.
292 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
293 * Improve string manipulation. I now inforce the notion of 'DicomString'
294 A DicomString can contain as many \0 as they want
295 and it is *always* of even length.
296 We only support odd length for very rare case.
297 And in the near future this should be removed.
299 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * /binary_write/ gdcm source. Now even on big endian we are writting
301 little endian. This should -heopfully- fix some tests
303 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
304 * Now the dictionary is compiled into gdcm lib. This is a default
305 behavior, thus any dic file specified is picked before failback to
306 the one comiled into lib
308 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
309 * Change internals for gdcmDict. Don't use any 'new' any more.
310 This should definitely solve any leak problem, and we should be
311 as fast as before, as long as don't modify too much the dictionary.
313 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
314 * STYLE: ivars should start with a capital letter.
315 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
316 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
318 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
319 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
320 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
321 new 2004 dictionaries added (thanks to JPR).
322 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
323 * CLEANUP_ROUND (15) for gdcmPixelConvert
324 - RLEFrame::NumberFragments is now of type unsigned int
325 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
326 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
329 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
330 * Initial work in gathering all transfer syntax accessors. clearly
331 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
332 ivars, but only one transfersyntax (class) ivar with equivalent method on
335 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
336 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
337 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
338 discussed (plus I didn't like having a 2000 lines patch not commited)
340 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
342 * CLEANUP_ROUND (14) for gdcmPixelConvert
343 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
344 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
345 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
347 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
348 anymore and hence avoids storing a copy of PixelConvert::Decompressed
349 into File::Pixel_Data.
351 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
353 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
354 * CLEANUP_ROUND (13) for gdcmPixelConvert
355 Substituted File::ParsePixelData() with PixelConvert::Print() new
357 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
358 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
359 method to those classes.
360 - src/gdcmFile.[cxx|h]:
361 -- Added a ::Print() method.
362 -- PixelConverter is now a reference instead of a member.
363 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
364 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
366 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
367 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
368 collaboration diagram and inheritance diagram should be generated with
370 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
371 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
372 pointlessly wrapped (see
373 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
374 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
375 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
376 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
377 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
378 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
379 -- File::Initialise: PixelConverter setup moved away to
380 PixelConverter::GrabInformationsFromHeader()
381 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
382 interpretation moved away to PixelConverter::BuildRGBImage()
384 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
385 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
386 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
388 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
389 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
390 displayed on Win32 when a brutal abort() occurs (because of uncatched
391 exception). See TODO new entry of this commit for more on this.
392 * TODO added new entry.
393 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
394 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
395 - HandleColor is no longer called from gdcmFile.cxx
396 - gdcmPixelConvert.cxx clean up on method arguments and internal
397 variable names for semantical coherence.
399 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
400 * Finished lossless transition, not only do we now read all lossless jpeg
401 images, without the need of the Cornwell lib, but we do read them properly now
402 * To reduce code (well to avoid code duplication), I defined a common place
403 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
404 redefine symbols. This is not prefect but this the best solution I found for a
405 compilation time jpeg option.
407 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
408 * Update jpeg ijg lib to support lossless jpeg implementation
409 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
411 * Also added a special copyright for dcmtk since we use their bugfixes.
414 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
415 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
416 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
417 matters, as stated in warning note at begining of %include section).
418 * src/gdcmDicomDir*.[cxx|h]: coding style
419 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
420 * src/gdcmJpeg8.cxx: doxygen fix.
421 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
422 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
423 from File:: to PixelConvert::.
425 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
427 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
428 - more code moved away from File:: to PixelConvert::
429 - fat setup of PixelConverter set in place in File::Initialise.
431 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
432 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
433 namespace at the file system level. So now you should convert your examples
435 gdcmHeader -> gdcm::Header
436 It would be nice if people keep in mind to no open the namespace, since it
437 allows compilation on broken plateform which were defining common symbol in
438 the standart namespace (like LP, Unknown ...)
440 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
441 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
442 The JPEG fragments are now parsed at the same stage than the RLE
443 information. All code related to JPEG is now in gdcmPixelConvert:
444 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
445 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
446 export a gdcmFile:: method. Those are simply global functions
447 (for the time being this is better than having them attach to
448 either gdcmFile:: or gdcmPixelConvert::).
449 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
450 and stores the result in a gdcmJPEGFragmentsInfo.
451 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
452 code (among other stuff) moved away from gdcmFile:; to
455 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
456 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
457 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
458 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
459 clean up of RLE related code.
460 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
461 - src/gdcmRLE.cxx removed
462 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
463 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
464 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
465 * CLEANUP_ROUND (9) for gdcmPixelConvert
466 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
467 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
468 away from gdcmFile:: to gdcmPixelConvert::.
470 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
471 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
472 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
473 This is because Parse7Fe0 used to parse the pixels to compute the
474 length. This task was passed over to FindDocEntryLengthOB() a long
475 time ago, EXCEPT I had forgotten the OW case...
476 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
477 we just recylce the code for parsing RLE fragments and computing
479 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
480 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
481 with the retired Parse7Fe0().
482 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
483 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
485 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
486 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
487 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
488 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
489 - src/CMakeLists.txt: alphabetic order reodering + new entries.
490 * CLEANUP_ROUND (4) for gdcmPixelConvert
491 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
492 to return an unused length.
494 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
495 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
496 this should be cleanner from the plane view. The iostream are erally a pain
497 to use to do simple stuff.
499 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
500 * Redo the compilation of the ijg jpeg library. Now only one source is
501 necesseray. No need to rename file by hand what so ever. CMake handle the
502 copying of the file within different directory, configure header file to
503 modify some symbol. The only addition made to ijg wasd a mangle table so
504 that symbol are different wether we are within 8bits or 12bits.
506 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
507 * Added documentation of vtkgdcmReader on Website:
508 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
509 with it's binary name).
510 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
511 the Website to be more complete.
512 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
513 doxygenated documentation.
514 - Doc/DoxyVtkGdcmReaderExamples.txt added
515 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
516 DoxyVtkGdmReaderExamples.html )
517 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
518 * CLEANUP_ROUND (3) for gdcmPixelConvert
519 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
521 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
522 * CLEANUP_ROUND (2) for gdcmPixelConvert
523 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
525 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
526 * CLEANUP_ROUND for gdcmPixelConvert:
527 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
528 - src/gdcmPixelStuff[h|cxx] removed
529 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
530 - src/CMakeLists.txt changed accordingly
532 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
533 gdcmVersion.py moved to newly created ATTIC related
534 gdcmPython/SetupOldies/ directory.
535 * Autotools clean up:
536 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
537 - autogen.sh configure.in acinclude.m4 python.m4 removed
539 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
540 * src/*.cxx *.h Reference to License.htm fixed to License.html.
541 * Doc/CMakeLists.txt, doxygen.config.in: fix.
542 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
544 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
545 * TODO updated with Mathieu suggestions. I proposed a template for
546 describing TODO entries and used it for new entries.
547 * Added Doc/Website/CodingStyle.html, Developpers.html,
548 DeveloppersPython.html, GdcmDataCvs.html and
549 DownloadVersion0_1.html, DownloadVersion0_3.html.
550 * Some Doc/*.txt Doxygen files (which do not really concern the
551 documentation itself, but the website) moved to html and
552 placed in directory Doc/Website:
553 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
554 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
555 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
556 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
557 * CMakeLists.txt changed accordingly.
558 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
559 DeveloppersPython.html
560 * INSTALL nows refers to Doc/Website/Installation.html
562 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
563 * Added Doc/Website directory, that contains a first raw version
566 2004-09-23 Jean-Pierre Roux
567 * FIX In order not to be poluted any longer by casting problems,
568 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
569 we can now delete[] it safely
570 * VoidArea is now called BinArea (less confusing name),
571 and all the methods called ...VoidArea... are now ... BinArea...
572 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
574 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
575 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
576 clear) TagHT, which is an inherited member of gdcmElementSet. It is
577 up to the destructor of gdcmElementSet to clean up TagHt and it's
580 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * Test/CMakeLists.txt: update to follow gdcmData renamings.
582 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
584 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * ENH: added some utility method that builds a flat dictionnary
586 holding all the Dicom entries contained in the recursive structure
587 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
589 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
590 BuildFlatHashTable() that build a flat dictionary.
591 - src/gdcmElementSet.h: added a new private GetTag() accessor.
592 gdcmDocument is now a friend of gdcmElementSet.
593 - src/gdcmElementSet.cxx: clean up.
594 - Example/FlatHashTablePrint.cxx added.
595 - Example/CmakeLists.txt changed accordingly
597 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
599 moved away from gdcmDocEntrySet (since this class is an abstract class
600 acting like an interface). SQDepthLevel and BaseTagKey are now
602 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
603 and associated accessors. Doxygenation of the class.
604 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
606 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
607 Use SQDepthLevel accessor instead. ::Print() adapted.
608 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
609 - src/gdcmDocument.cxx changed accordingly.
611 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
612 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
613 - The following is the doxygen comment of the typedef declaration
614 of gdcmagKey in src/gdcmCommon.h:
615 gdcmTagKey is made to old an "universal" (as in URL, Universal
616 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
617 A dicom tag allways has a group and an element, but a set of tags
618 embeded in various (optionally nested) sequences and sharing
619 the same group and element all share the same (group, element)
620 "identifier". Hence the (group, element) cannot be used as an
621 identifier (in gdcm we shall refer to a "TagKey") of a tag.
622 In order to construct a proper tag identifier (i.e. a key) we
623 consider the following definition of a TagKey:
624 - let Group, Element be the string representation of the
625 group and element dicom tag members,
626 - let ItemNumber be the string representation of the integer
627 index of the considered item number of a sequence,
628 Let the key of a tag embeded in a sequence, noted SeqTag, be
630 /ItemNumber#Group|Element
631 where "/", "#" and "|" are characters acting as separators.
632 Then the general form of a gdcmTagKey is given by:
633 Group|Element<SeqTag>
634 where <SeqTag> means NO or many instances of SeqTag.
635 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
638 but the gdcmTagKey of a tag "embeded" is the first item of
639 a sequence, itself nested in the third item of a sequence is the
641 0004|1220/2#0008|0082/0#0008|0090
642 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
643 order to hold the new sequence compatible key. Previously, the
644 GetKey() method would look in the underlying gdcmDictEntry.
645 - src/gdcmDocEntry.cxx:
646 -- constructor now copies the underlying DictEntry key, in the local
648 -- ::Print: displays the member Key, instead of the (group, element).
649 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
650 - src/gdcmDocEntrySet.h:xi
651 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
652 -- now has a new BaseTagKey member.
654 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
655 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
657 This poses the problem with the semantics of the following lines
658 LoadEntryVoidArea(0x0028,0x1201); // R LUT
659 LoadEntryVoidArea(0x0028,0x1202); // G LUT
660 LoadEntryVoidArea(0x0028,0x1203); // B LUT
661 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
662 to the long FIXME note for what the problem is. Nevertheless in
663 order to get things working the dicom dictionary was altered !
664 Please fix things urgently...
665 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
666 information), see above note on moving the member VoidArea. Nevertheless
667 the following entries previously correctly set as US are now inproperly
669 0028 1201 OW IMG Red Palette Color Lookup Table Data
670 0028 1202 OW IMG Green Palette Color Lookup Table Data
671 0028 1203 OW IMG Blue Palette Color Lookup Table Data
672 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
673 of gdcmDocEntry moved to gdcmSeqEntry.
674 * src/gdcmSeqEntry.cxx: STYLE.
676 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
677 * Test/TestAllEntryVerify.cxx minor fix and added comments.
679 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * gdcmPython/testSuite.py: all the test suite in python is now moved
681 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
682 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
683 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
685 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
687 to avoid inclusion recursion until STL is reached.
688 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
689 mecanism. errno.h is not included in gdcm anymore.
690 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
691 (gdcmFormatError now inherits from gdcmFormatUnexpected).
693 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
694 gdcmData/TestAllEntryVerifyReference.txt
695 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
696 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
697 exception_on_error parameter.
698 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
699 - vtk/vtkGdcmReader.cxx changed accordingly,
700 - Example/*.cxx and Test/*.cxx changed accordingly.
702 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
704 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
705 enable_sequences removed from gdcmHeader constructor and dependencies.
706 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
707 * gdcmPython/demo/PrintHeader.py: dummy fix.
708 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
709 skip_shadow removed from gdcmHeader constructor and dependencies.
710 * Example/*.cxx and Test/*.cxx changed accordingly.
712 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
713 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
714 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
716 2004-07-21 Jean-Pierre Roux
717 * FIX Now, Parsing and Printing a DICOMDIR do work!
718 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
720 2004-07-20 Jean-Pierre Roux
721 * FIX Some brain damaged headers have Zero-Lenght fields
722 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
724 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
725 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
726 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
727 variable (instance of gdcmDebug) by a definition macro, and the instance
728 is now in static in the gdcmDebug class
729 * src/gdcmSQItem.h : (FIXME) remove an undefined method
730 * Test/PrintAllDocument.cxx : bug fix in the result of the test
732 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
733 * WARNING: ctest now depends more tightly on gdcmData. You should
734 check out gdcmData properly for things to run smoothly...
735 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
736 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
737 we need the pixels not be loaded in order to use the ValEntry
738 that displays position and size).
739 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
740 This is a C++ based equivalent of gdcmPython/testSuite.py that should
741 be deprecated. If you have any doubts about the advantages of a
742 modern scripting language (read Python) versus grass root C++ (i.e.
743 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
744 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
745 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
746 Anyhow, consider documenting the gdcmData images in
747 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
749 * Test/CMakeLists.txt:
750 - now uses TestAllEntryVerify.cxx
751 - specific comments on oldACR00001.ima (now renamed in gdcmData
752 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
753 gdcmData/TestAllEntryVerifyReference.txt
756 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
757 * src/*.[h|cxx] : typedef clean up
758 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
759 - TagKey renamed to gdcmTagKey (for external usage)
760 - VRKey renamed to gdcmVRKey (for external usage)
761 - removal of typedef duplication.
762 - Removed all unecessary inline keyword from class inline definitions.
763 - Some method|function(void) declarations replaced with method|function().
764 * src/jpeg/libijg12/jdhuff12.c:
765 - printf polluting ctest removed.
766 - TAB removal for comminting
768 - TestAllReadCompareDicom.cxx: added a test that compares all the
769 images in gdcmDataImages.h with corresponding images in
770 gdcmData/BaselineDicom/. When baseline images are not present
771 this test creates them.
772 Note: we need to validate each reference image, but before that
773 I'd like to rename them with a more explicit name...
774 - CMakeLists.txt: changed accordingly.
775 * Example/*.cxx: examples now only include gdcm.h (as opposed to
776 including each header needed).
778 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
779 * Test/*.cxx and Example/*.cxx: moved some examples away from the
780 test suite to the Example directory. Are concerned:
785 - TestWriteSimple.cxx
786 * Test/CMakeLists.txt: added some comments on reasons for black listing
787 image gdcmData/oldACR00001.ima
789 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
790 * Test/CmakeList.txt: removed the following from black list (to be coherent
791 with removal from gdcmData):
792 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
793 - gdcm-MR-PHILIPS-16.dcm
795 Added the following because after last cvs update, they cause
796 ctest -R TestReadWriteReadCompare
798 - gdcm-MR-SIEMENS-16-1.acr
800 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
801 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
802 new comments in this file) we temporarily (sigh) move to a weaker
804 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
805 we don't need to black list the following images anymore:
806 - 8BitsUncompressedColor.dcm
808 - US-PAL-8-10x-echo.dcm
809 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
810 fixes and the beautified code ;-)
811 This fixes the bug introduced in version 1.42 (when beautifying)
812 that made the parsing of 8BitsRunLengthColor.dcm unproper.
813 Note: ctest was blind to this bug (this means we need to still
814 improve the test suite). The bug could be detected by using
815 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
817 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
818 and by displaying the (garbage) produced file temp.XDCM...
820 2004-06-29 Jean-Pierre Roux
821 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
822 - replace by uggly but working old code :-(
823 A lot of things should be OK again.
824 It's really urgent to have a test suite that *tests*,
825 to prevent Frog's beautifying sessions to break all the stuff
826 (twice, withing a fortnigh ...)
828 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
829 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
830 redundancy) to added Test/TestReadWriteReadCompare.cxx
831 * Test/CmakeList.txt: because the compare test of
832 Test/TestReadWriteReadCompare.cxx fails, the following images are
833 black listed: - 8BitsUncompressedColor.dcm
835 - US-PAL-8-10x-echo.dcm
836 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
837 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
838 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
839 and ad-hoc kludge. This kludge is now removed, and on encountering
840 such an image (OB field brain damaged) we set errno. Then in
841 ::FindDocLength() we "fix" the length as being ALL what remains
842 in the file (until EOF). We then proceed, hoping for the best...
843 This fixes a SegFault in ShowDicom when trying to write such an
845 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
846 (because TestWriteRead breaks on it, after a non conformal commit?).
847 ctest now runs properly, except for MakeDicomDir (which was allways
848 broken) and the Python related stuff (still not fixed).
850 2004-06-24 Jean-Pierre Roux
851 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
852 FIX : Test/TestReadWrite now iterates on all the file names
853 (instead of infinite loop)
854 ENH : Test/TestWriteRead now iterates on all the file names
856 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
857 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
859 2004-06-24 Jean-Pierre Roux
860 FIX : - now Write drops LUT Descriptors and LUTs (if any)
861 when SamplesPerPixel =3
862 - now Write is no longer confused by
863 'BitsAllocated = 12" and 'BitsStored=12"
864 - "UN" value representation Elements are now written correctly
865 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
866 ENH : - now gdcmHeader has its own Write methods
867 (in order to split the job that has not to be done
870 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
871 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
872 loop on the same image until memory went out.
873 Note: this means we still have gobs of memory loss in PrintDocument
874 * src/gdcmDocument.cxx: fixes problem on parsing on file
875 gdcmData/16BitsJpegLosslessGrayScale.dcm.
877 2004-06-24 Jean-Pierre Roux
878 FIX : Write - All the Sequences and Sequence Item are now written
879 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
880 is added a the end, when necessary.
881 - A lot of brain-damaged images, that were read correctly are
882 now written correctly
883 - length compatible BinEntry are now loaded correctly
884 (even for odd groups)
885 Note : only Explicit Value Representation was checked.
886 (question : is implicit VR really necessary for gdcm ?)
888 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
889 * DEVELOPPER: added a proposition of coding style.
890 * src/gdcmDocEntry.h: removed every inline declaration (for test of
893 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
894 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
895 Use the gdcmDocEntry::Print() and Write() instead.
896 * src/gdcmDocument.cxx: bug fix.
898 2004-06-22 Jean-Pierre Roux
899 FIX : gdcmDocument.cxx
900 - Now we do recognize the JpegLossLess format (there was a misstyping in
901 code 'beautyfication' :-(
902 - Now we automaticaticaly load the Luts, if any
904 2004-06-22 Jean-Pierre Roux
905 In order : to write Sequences, whatever their imbrication level,
906 : to allow user to create his own Sequences
907 a lot of modif where necessary (adding, moving, or virtualising methods)
909 WARNING : save your own sources *before* cvs up !
912 ADD virtual void Write(FILE *fp, FileType filetype);
915 ADD virtual void Write(FILE *fp, FileType filetype);
916 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
919 ADD virtual void Write (FILE *fp, FileType filetype)=0;
920 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
921 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
922 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
923 ADD std::string GetEntryByName(TagName name);
924 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
926 std::string vr = "unkn",
927 std::string fourth = "unkn",
928 std::string name = "unkn");
929 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
930 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
931 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
932 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
933 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
934 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
935 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
936 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
939 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
940 ADD virtual std::string GetEntryByName (TagName tagName);
941 ADD virtual std::string GetEntryVRByName (TagName tagName);
942 REM virtual bool Write(FILE *, FileType);
943 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
944 FILE *_fp, FileType type);
945 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
946 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
947 REM virtual bool WriteEntries(FILE *_fp,FileType type);
948 REM virtual std::string GetEntryByName (std::string tagName);
949 REM virtual std::string GetEntryVRByName (std::string tagName);
950 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
951 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
952 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
954 std::string vr = "unkn",
955 std::string fourth = "unkn",
956 std::string name = "unkn");
957 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
958 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
959 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
960 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
963 ADD virtual void Write(FILE *fp, FileType filetype);
966 ADD virtual void Write(FILE *fp,FileType filetype);
969 ADD virtual void Write(FILE *fp, FileType filetype);
970 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
971 REM std::string GetEntryByNumber(guint16 group, guint16 element);
972 REM std::string GetEntryByName(TagName name);
975 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
977 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
978 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
979 The default constructor invoked by the line
980 gdcmHeader *f1 = new gdcmHeader( header );
981 was gdcmHeader::gdcmHeader(bool) instead of the expected
982 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
983 Hence the parsing wasn't executed... See also below.
984 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
985 as explicit constructor didn't do the trick to fix the above problem.
986 Could anyone explain why ?
987 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
988 properly calls gdcmValEntry::Print() (that was weed out from
989 code related to gdcmBinEntry).
991 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
992 * In order to fix memory leaks:
993 - Test/TestWriteSimple.cxx: added cleaning of free store through
995 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
996 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
997 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
998 (through the call to ::AddDicomDirMeta()) or the destructor
999 would crash when deleting uninitialized ::metaElems].
1000 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1001 - src/gdcmDocument.cxx:
1002 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1003 from dynamic stores.
1004 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1005 was causing memory leaks.
1006 - src/gdcmSQItem.cxx:
1007 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1008 cleanly handled with polymophism: sorry but my milage is low).
1009 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1010 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1011 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1012 This avoids SegFaulting.
1013 - src/gdcmSQItem.h: coding style.
1015 - Test/TestWriteSimple still severely sucks. The output image content
1016 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1017 damaged when displayed with vtkgdcmViewer.
1018 - on memory leaks: TestWriteSimple leaks really less (see entry
1019 of 2004-06-18 in Changelog file for the call to valgrind).
1020 - on segfaults: ctest now passes all the tests but one (no more
1022 * Erroneous leading white fix:
1023 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1024 white[s] (as opposed to from >> xxx, that removes it [them].
1025 - src/gdcmTS.cxx: ditto.
1026 - gdcmPython/testSuite.py: dirty related kludge removed.
1027 * src/*: remaining references to gdcmParser removed.
1028 * src/*[cxx|h]: added copy[way]left header.
1031 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1032 * In order to fix writing of dicom files:
1033 - Test/TestWriteSimple.cxx: a simpler example of writing.
1034 - Test/CMakeLists.txt changed accordingly.
1035 - src/gdcmDocument.cxx:
1036 -- The destructor now recursilvely removes potential sequences.
1037 -- Bug fix in ::IsJPEG2000()
1038 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1039 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1041 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1042 to only declared) and build on top of
1043 ::GetDocEntryByNumber(guint16, guint16).
1044 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1045 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1046 for usage in destructor and treatement of promotion in
1047 ::ReplaceOrCreateByNumber().
1048 - src/gdcmSQItem.cxx: destructor should better handle his job.
1049 Test/TestWriteSimple now runs (or at least it DOES something).
1050 * We can now start hutting memory links. A good starting point is:
1051 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1052 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1053 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1055 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1056 * Valgrind note: after Mathieu Malaterre teached me how to read
1057 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1059 Using gcc, you can force the STL to use malloc and to free memory as
1060 soon as possible by globally disabling memory caching.
1061 With 3.2.2 and later, you should export the environment variable
1062 GLIBCPP_FORCE_NEW before running your program.
1063 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1064 simply vanish (it is still not clear to me, whether this means that
1065 STL std::string leaks or if valgrind believes it leaks...).
1066 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1067 running bin/gdcmTests makeDicomDir):
1068 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1069 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1071 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1072 SegFaulting (I drowned in DicomDir related code when trying to
1073 understand why the list is empty...).
1074 * src/gdcmDocument.h: first BSD license header try.
1075 * Doc/License.txt added.
1077 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1078 * src/gdcmDocument.[h|cxx]:
1079 - Clean up of the Transfer related predicates. They are now all based
1080 on new method isGivenTransferSyntax, that (should) handle properly
1081 the padding problem.
1082 - general clean up, simplification, and coding style.
1083 - Specific clean up of Parse7FE0() (umproperly named actually).
1084 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1086 2004-06-14 Jean-Pierre Roux
1088 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1089 - fix the display of SQItem ordinal number
1090 - add the GetSQItemByOrdinalNumber method
1091 - remove some useless never written private methods
1093 2004-06-14 Jean-Pierre Roux
1095 - adding a constructor taking a gdcmDocEntry as an input param
1096 - ReplaceOrCreateByNumber now returns :
1097 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1098 a gdcmValEntry * if a string value is passed as a param
1100 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1101 according to the param type (no longer sets a gdcmDocEntry)
1102 - GetValEntryByNumber, GetBinEntryByNumber added
1103 - NewValEntryByNumber and NewBinEntryByNumber added
1105 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1107 - GetSQItemNumber and SetSQItemNumber added, to provide
1108 a (relative) Item identier inside a given Sequence
1109 \warning : some pb remaining around this number
1111 - AddEntry now takes the Item Number as a param
1113 - adding a constructor taking a gdcmDocEntry as an input param
1115 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1116 * Memory leak hunt with the following command:
1117 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1118 --show-reachable=yes gdcmTests PrintDocument
1119 It looks like many (all?) leaks are due to the STL (or a bad usage
1120 of the STL. The lines producing the leaks now have a comment with
1121 a "MEMORY LEAK" tag: you can retrieve them with
1122 grep "MEMORY LEAK" src/*
1123 Here are two typical examples which I can't help fixing:
1128 char * test = "babo";
1129 name = test; //// <--- valgrind detects 960 bytes lost in
1130 //// call to std::string::operator=(char const*)
1131 name.clear(); //// Doesn't help !
1139 std::cout << "Type a bunch of characters followed by RETURN: ";
1140 getline(std::cin, line); //// <--- valgrind dectects a loss
1141 //// of 1320 bytes in call to
1142 /// std::basic_istream<>& std::getline<>
1148 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1149 * src/gdcmHeader.[cxx|h]:
1150 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1151 and related, moved away to gdcmDocument.
1152 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1153 the corresponding protected accessors of inherited class
1154 gdcmDocument, removed ! As a consequence gdcmFile had to be
1155 declared friend of class gdcmDocument (see below).
1156 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1157 - Clean up of undefined or unused methods.
1158 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1159 account the changes to gdcmHeader.h).
1160 * src/gdcmDocument.h:
1161 - gdcmFile is now a friend class (in order to take into account the
1162 changes to gdcmHeader.h).
1163 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1164 (see changes to gdcmHeader.h).
1165 - Accessors (reading on the form GetEntry*) are now public.
1166 - Clean up of undefined or unused methods.
1167 * src/gdcmDocument.cxx:
1168 - adaptation to changes to gdcmDocument.h
1169 - ::OpenFile now writes a verbose message when file cannot be opened.
1170 - some std::string properly set to VRKey
1171 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1172 references to gdcmDocument.
1173 * Test/TestFindTags.cxx: changed accordingly to above changes.
1174 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1175 cvs repository gdcmData.
1177 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1178 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1179 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1180 conflicts with gdcmValEntry::voidArea.
1181 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1182 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1183 Value representation between StringRepresentable and BinaryRepresentable.
1184 * src/gdcmDocument.cxx:
1185 - method ParseDES: proper indentation restored and usage of
1186 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1187 - method LoadDocEntry: the fingerprint left in the SetValue() of
1188 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1189 removed. Reverting to previous code segment with the proper
1190 dynamic_cast< gdcmValEntry* >.
1191 Note: this was (partially) breaking the python test suite
1192 (gdcmPython/testSuite.py) that made usage of the above
1193 fingerprint to check presence of "Pixel Data".
1194 * src/gdcmDocEntry.h: coding style.
1195 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1196 now taken into account.
1197 * gdcmPython/gdcm.i: adaptation to the new internal representation
1198 of gdcm (exit gdcmParser, hello gdcmDocument).
1199 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1201 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1202 anymore, but instead prints the loaded Python dictionary.
1203 * .... alas, the python testSuite is still broken.
1205 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1206 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1208 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1209 * src/gdcmUtil.h : export methods
1211 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1212 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1214 * Initial addition of automatic python testing
1215 * Initial addition of automatic image comparison
1217 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1218 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1219 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1221 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1222 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1223 * Test/ShowDicom.cxx : bug fix for msvc compilation
1224 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1226 2004-05-04 Jean-Pierre Roux
1227 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1228 new concepts (and new classes) :
1229 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1230 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1231 - Sequence Doc Entries (gdcmSeqEntries)
1232 a Sequence is composed of Items.
1233 Each item is a set of Doc Entries (this is recursive)
1234 The non uniqueness of the 'Dicom tag' is due to this recursivity
1235 (never taken into account)
1236 Our unability to add a new 'entry' in the header
1237 at the proper location (neither in the H-Table (map or multimap),
1238 nor in the Chained List is also due to this recursivity.
1239 Don't try, right now, to use/modify/compile these new sources :
1240 nothing is finished.
1241 We just commit all the stuff, 'as is', in order not to loose it.
1243 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1244 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1246 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1247 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1248 file prefix (SetFilePrefix)
1250 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1251 * Add a new test: ShowDicom, for now this is just the c++ version of
1252 checkRead.sh, later it will be able to compare the image read against a
1254 * Replace the DEBUG on the stack with a global entry in cmake interface:
1255 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1257 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1258 * Add an example subdir, with a real example on how to read + write a
1261 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1262 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1263 * Doc/CMakeLists.txt: the main page is now properly differentiated
1264 between the developper and user version.
1265 * Doc/doxygen.config.in: dropped search related obsolete flags
1266 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1268 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * DEVELOPPER: added some helpfull comments for compile/test/install
1272 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1273 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1274 src directory, now generated in the build dir.
1275 2. Tests as mentionned smarter
1277 4. Add a new method in gdcmDict that return the PubDict by name
1278 this is interesting for 3rd party lib like ITK,
1279 where we could set the institution name / patient name...
1281 * ENH: 1. Now the test suite is working for real
1282 2. All binaries are now output in the gdcm-bin directory
1283 (this was not true before)
1285 2004-04-28 Jean-Pierre Roux
1286 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1287 SeQuence indented printing of Dicom Header.
1288 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1289 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1290 Computation of SQDepthLevel is now part of gdcmHeader constructor
1291 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1292 tree-like structure of a Dicom Header.
1293 * FIX Test code cleaning
1295 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1296 * ENH: Adding automatic testing
1297 1. Need a DartConfig.cmake to submit to public
1298 2. Add a test driver gdcmTest.cxx
1299 3. gdcmTestMain, an helper for the main test driver gdcmTest
1300 4. Files in Test don't have a main anymore, this becomes interesting
1301 when we add more and more tests, thus dsw don't have to load
1303 * ENH: Adding a GDCM_DATA_ROOT for testing
1304 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1305 one file instead of seven + some small cleanup
1307 2004-04-22 Jean-Pierre Roux
1308 * ENH Minor changes to the Print() methods.
1309 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1310 Header printing. Example given with :
1311 > PrintHeader fileName 2 new
1312 (SQ based tree-like structure still to be done for the Header ...)
1314 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1315 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1316 1. I have added some unsigned where needed
1317 2. Some function parameter not used -> (void)
1318 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1319 4. g++ don't like character '\' in comment
1320 5. #define jpeg_create_decompress jCreaDecompress
1321 this really need to be fixed
1322 6. virtualize destructor of gdcmObject ... leakage
1323 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1324 this also really need to be fixed
1325 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1326 remove compression file
1327 (as we only do decompression, right ?)
1328 * ENH: Change malloc/calloc/free with c++ equivalent
1330 2004-04-21 Jean-Pierre Roux
1331 * FIX gdcmHeaderHelper::GetXSpacing
1332 when a single value is found (bug ?), xpacing is now
1333 defaulted to yspacing
1335 2004-04-19 Jean-Pierre Roux
1336 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1337 * ENH add parameters :
1338 bool exception_on_error = false,
1339 bool enable_sequences = false,
1340 bool ignore_shadow = false
1341 to the gdcmFile constructors to be full gdcmParser compliant
1342 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1343 to allow reading of PAPYRUS 3.0 files
1345 2004-04-06 Jean-Pierre Roux
1346 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1348 2004-04-02 Jean-Pierre Roux
1349 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1350 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1351 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1353 2004-03-30 Jean-Pierre Roux
1354 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1355 for ACR file, written out as DICOM files (hope so...)
1357 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1358 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1359 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1360 moved to base class gdcmParser and only the specialisation is kept
1362 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1363 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1364 already does the job.
1365 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1366 (to be consistent with gdcmParser::WriteEntries).
1368 2004-03-30 Benoit Regrain
1369 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1370 upate of the object's instance. It's passed to 2 in the unfavorable
1371 case : one in the ExecuteInformation, one in the ExecuteData
1373 2004-03-29 Jean-Pierre Roux
1374 * ENH : Check on file type to be written moved
1375 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1376 * FIX : gdcmObject::ResetBoundaries now stops properly
1377 when end-of-list is reached
1378 : gdcmVersion modified (as Benoit Regrain asked)
1380 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1381 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1382 * src/gdcmUtil.cxx: added forgotten iostream include.
1383 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1384 equivalent to ExplicitVR in existing code).
1386 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1387 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1388 now contains all the gdcmGlobal related code.
1389 * minor coding style and doxygenation changes.
1391 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1392 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1393 now contains all the Debug related code.
1394 * minor clean-up of includes in src/*.cxx
1395 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1396 CreateCleanString) removed.
1397 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1398 * Doc/DoxyMainPageUser.txt added.
1399 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1400 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1401 src/gdcmDirList.cxx)
1403 2004-03-24 Jean-Pierre Roux
1404 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1406 2004-03-23 Jean-Pierre Roux
1407 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1408 big endian made volumes
1409 * ENH Now gdcmParser constructor and destructor are protected to forbid
1410 end user to instanciate class gdcmParser
1411 (only gdcmHeader and gdcmDicomDir are meaningfull)
1413 2004-03-22 Benoit Regrain
1414 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1415 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1416 gdcmSerie to gdcmDicomDirSerie
1418 2004-03-19 Jean-Pierre Roux
1419 * ENH Now the tree-like structure describing a DICOMDIR comming from
1420 an already existing DICOMDIR file is consistent with
1421 the home-made tree-like structure build ex-nihilo
1422 or build from the files held (recursively) in a Directory
1423 functions gdcmDicomDir::CheckBoundaries()
1424 gdcmObject::SetBoundaries() added
1426 2004-03-17 Jean-Pierre Roux
1427 * REM (Eric Boix bug) : removal of meaningless
1428 gdcmDicomDirImage::NewImage function.
1429 * FIX now file names and directory name are written properly in the
1431 * FIX now gdcmDicomDir constructor may be call without any trick
1434 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1435 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1436 of gdcmDicomDirImage::NewImage as empty function.
1438 2004-02-28 Jean-Pierre Roux
1439 * ENH add gdcmDicomDir:NewPatient
1440 add gdcmDicomDirPatient:NewStudy
1441 add gdcmDicomDirStudy:NewSerie
1442 add gdcmDicomDirSerie:NewImage
1443 to allow making gdcDicomDir object.
1444 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1445 (as opposite to the gdcmHeader chained list)
1447 2004-02-11 Benoit Regrain
1448 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1449 when using from python
1451 2004-02-10 Benoit Regrain
1452 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1453 * FIX : in gdcmDicomDir when the directory is empty
1454 * ENH : add callback and methods to get the progression of dicomDir
1457 2004-02-06 Jean-Pierre Roux
1458 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1459 - GDCM_META added to gdcmDicomDirType
1460 - class gdcmMeta created
1461 * ENH : - A brief summary is now displayed at the beginning of
1462 'testDicomDir' to help disaster magnitude estimation
1463 * REM : Now useless Test/explDICOMDIR.cxx
1465 2004-02-05 Benoit Regrain
1466 * ENH : add methods in gdcmObject to get the hash table or the list of
1468 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1469 * FIX : wrapping python for TagHeaderEntryHT
1471 2004-02-04 Benoit Regrain
1472 * FIX : even length for some strings when writting the dicom dir
1473 * FIX : sort the images in the dicom dir
1474 * FIX : Bug fix for python use of dicom dir
1475 * ADD : a python demo
1477 2004-02-04 Jean-Pierre Roux
1478 * FIX : Final solution (?) for icone embedded images
1479 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1480 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1481 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1482 gdcmData/gdcm-MR-SIEMENS-16.acr1
1483 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1484 to make full checking easier
1486 2004-02-04 Benoit Regrain
1487 * FIX : WriteEntries : coding style & logic in parameters
1488 * FIX : Set the elements to create the DicomDir in a dictionary file
1490 2004-02-03 Benoit Regrain
1491 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1492 * gdcmDicomDir : add the load of directory
1493 * Bug fix and print add-on
1495 2004-02-03 Jean-Pierre Roux
1496 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1497 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1498 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1499 * FIX gdcmParser.cxx : 'group length' elements are now considered
1500 as integers, even for shadow groups, when file is Implicit VR
1502 2004-02-02 Jean-Pierre Roux
1503 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1505 of the last synonym :-(
1506 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1508 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1509 * FIX taking into account the possible 7fe0,0010 multiplicity
1510 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1511 to allow removal of references to 7fe0,0010, to deal with
1512 ACR-NEMA images, when 0028,0200 is meaningfull
1514 2004-01-31 Jean-Pierre Roux
1515 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1516 no longer writes 'Un' on disk
1517 * FIX SQ elements with actual length are now dealt with corectly
1518 * FIX gdcmFile::WriteBase make the difference, for color images, between
1519 the length (for Palette expanded images)
1520 and Raw Length (non expanded image + Palette)
1521 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1522 (that broke Write). Replaced by UL.
1523 Aware user will reload the field if he
1524 thinks it's necesssary
1526 2004-01-30 Jean-Pierre Roux
1527 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1528 when 'dirty Acr' is found, to be compliant with the new
1529 IsReadable() methods.
1531 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1532 (no DOUBLE images in kosher DICOM,
1533 but so usefull for people that miss them ;-)
1535 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1536 DICOMDIR related utilities (not checked as Windoze compliant)
1538 2004-01-28 Jean-Pierre Roux
1539 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1541 2004-01-27 Jean-Pierre Roux
1542 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1543 to allow skipping the shadow elements, to save memory space.
1544 The TRUE value for this param has to be used
1545 with a FALSE value for the 'enable_sequence' param.
1546 ('public elements' may be embedded in 'shadow Sequences')
1547 * gdcmHeader methods now deal with 'embedded icones images' in the header
1548 (even when an 'icone image sequence' is announced by the
1549 element (0x0088,0x0200), but there is NO icone at all ...
1551 * gdcmHeader sometimes Image Location value doesn't follow
1552 the supposed processor endianity (see gdcmData/cr172241.dcm).
1555 * gdcmHeader add the method
1556 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1557 to get *all* the Header Entries with the same tag.
1558 GetHeaderEntrySameName is probabely *useless*
1559 (no meaning : Name is *not* an identifier within the Dictionnary)
1561 2004-01-26 Benoit Regrain
1562 * Bug fix in the print of hexadecimal representations. Remove long fields
1563 in the print and add a third level of print to print them
1565 2004-01-23 Benoit Regrain
1566 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1567 * Bug fix on test suite after remove the strip made on not string fields
1568 * Split the IsReadable method between gdcmParser which test that the file
1569 is dicom and gdcmHeader which test that it's an image file
1571 2004-01-22 Benoit Regrain
1572 * DicomDir : clean code, add methods, set variables in protected or private
1573 * gdcmUtil : bug fix for the clean string method
1575 2004-01-19 Benoit Regrain
1576 * Add the use of shadow dictionaries
1577 * bug fix and coding style
1579 2004-01-19 Benoit Regrain
1580 * src/gdcmFile.cxx : bug fix concerning the close of file
1581 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1582 * Add the update of header entries using the shadow library
1584 2004-01-19 Benoit Regrain
1585 * removal of file gdcmHeader2.cxx
1586 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1587 inheriting from gdcmParser. This split is to prepare the integration
1588 of dicom dir parsing
1589 * bug fix under python
1591 2004-01-16 Jean-Pierre Roux
1592 * REM removal of class gdcmHeaderEntrySet
1593 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1594 * ADD add file gdcmHeader2.cxx
1595 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1597 2004-01-15 Benoit Regrain
1598 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1599 entries created while parsing the header. Thus, they will be destroyed
1600 when the gdcmDictSet will be destroyed
1601 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1604 2004-01-15 Benoit Regrain
1605 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1606 made a fatal error because of the memory release at the end of program.
1607 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1608 some memory and vtk seems to have some problems with that.
1609 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1611 2004-01-14 Benoit Regrain
1612 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1613 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1614 * src/*.[h|cxx] : make changes due to class name changes
1615 * gdcmPython/demo/*.py : bug fix due to method names
1617 2004-01-13 Benoit Regrain
1618 * src/*.[h|cxx] : coding style
1619 * vtk/*.[h|cxx] : coding style
1621 2004-01-13 Benoit Regrain
1622 * gdcmPython/testSuite.py : test the readable flag of file for tests
1623 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1624 It's lied to the stl compilation by MSVC (windows, always windows...)
1625 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1627 2004-01-12 Benoit Regrain
1628 * src/*.h : add comments
1629 * src/gdcmDictSet.h : set the method BuildDictPath in public
1630 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1631 directly setted in the source code
1632 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1635 2004-01-09 Benoit Regrain
1636 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1637 * setup.py : use a reference to gdcmVERSION
1639 2004-01-07 Benoit Regrain
1640 * Modification to compile with the distutils.
1643 2003-12-10 Benoit Regrain
1644 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1645 can use a gdcmHeaderHelper to load datas
1646 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1647 made in the source code
1649 2003-12-10 Benoit Regrain
1650 * Update Windows projects and .cvsignore files
1652 2003-11-12 Jean-Pierre Roux
1653 * ENH gdcmHeader constructor has one more parameter (default value : false)
1654 that allows the user to 'go inside' the SeQuences only
1656 gdcmElValSet:Print takes it into account
1658 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * ENH: Update gdcmPython/CMakeLists
1660 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1661 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1663 2003-11-10 Jean-Pierre Roux
1664 * FIX : gdcmHeader::LoadElements is now based
1665 on the ListTag listElem member,
1666 not longer on the TagElValueHT tagHt member
1667 * ENH : PrintPubElVal shows (temporarily) both results,
1668 with the tagHt member and the listElem member.
1669 (it's easier to 'see' the problems when using Printheader)
1671 * FIX : old private member LgrElem is now splitted into
1672 ReadLength : Length actually found on disk (updated only
1673 if bug fixing is necessary), for internal
1675 UsableLength : Updated by FixFoundLength, to fix a bug
1676 or to allow Parser going on.
1677 Will allow to re-write a kosher header when a SeQuence
1678 with a length (not 0000) is found
1679 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1680 because gdcmElValSet::Add does not update ListElem
1683 2003-11-07 Jean-Pierre Roux
1684 * FIX misstyping in Transfert Syntax name table
1685 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1686 when they have an actual length (not 0000 nor FFFFF)
1687 (Nobody should care of it, but DICOMDIR explorers)
1689 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1690 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1692 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1693 * ENH: vtkGdcmReader now supports LUT !
1694 (vtkgdcmViewer for now is not able to use them though)
1696 2003-11-05 Jean-Pierre Roux
1697 * in testSuite.py : new files names for checking the package
1698 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1699 that returns the pixel area size to the *aware* (vtk) user
1700 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1702 2003-11-05 Benoit Regrain
1703 * in testSuite.py : Modify the rules for checking the paths
1704 : Explicit error messages
1705 * in __init__.py : Related modif
1707 2003-11-03 Jean-Pierre Roux
1708 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1709 to be used by aware (vtk) users that want to manage
1710 LUT (and no to turn the PALETTE image into an RGB pixels one)
1711 * GetPixelType now returns 8U for 24 Bits images
1712 (vtkGdcmReader compliant)
1714 2003-10-31 Jean-Pierre Roux
1715 * Removal of *all* gdcmData images and add them again
1716 in order to loose the 'history' of un-anonymised images
1718 2003-10-31 Jean-Pierre Roux
1719 * RMV : removal of useless jBitsInJsample.h
1720 for both 8 and 12 Bits JPEG Lossy Libraries
1722 2003-10-31 Jean-Pierre Roux
1723 * ENH : Add the functions gdcmFile::GetImageDataRaw
1724 gdcmFile::GetImageDataIntoVectorRaw
1725 that act as GetImageData and GetImageDataIntoVector
1726 except the making of an RGB Plane from Gray Plane + LUT
1727 Intended to aware (vtk) users who know how to manage
1730 GetLUTRGBA return a R,G,B,A LUT if any
1731 lgrTotaleRaw gives the 'Raw' length
1732 GetImageDataRaw returns the gray Plane
1733 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1734 (They stay Grey, just like with other Dicom viewers :-(
1736 2003-10-30 Jean-Pierre Roux
1737 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1739 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1740 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1741 being coherents dicom files.
1743 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1744 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1746 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1747 * ENH: Two steps is necessary to please VC++ compiler...
1748 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1749 * ENH: Add include dir to medcon lib
1750 * FIX: only one function is being exported for now !
1751 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1753 2003-10-29 Jean-Pierre Roux
1754 * adding gdcmHeader::GetLUTRGBA
1755 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1756 --> Mathieu, the modif u're waiting for is not yet committed
1757 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1759 2003-10-27 Jean-Pierre Roux
1760 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1761 00191113.dcm DermaColorLossLess.dcm
1762 MxTwinLossLess.dcm RadBWLossLess.dcm
1763 * ENH: For version prior to vtkImageViewer2 -r 1.19
1764 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1766 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1767 * Removal of ido stuff in CMakeLists.txt
1769 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1771 * FIX: remove a call to ->Modified ... see comments
1772 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1774 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1775 * FIX: Problem with path for libvtkgdcmPython
1776 * ENH: Try adding a search script for python site-package
1777 * RMV: Remove some file from medcon lib that are not necessary
1778 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1779 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1780 * FIX: More pragma disable fro VC++,
1781 I don't think I break something as it is also disable in VTK/ITK.
1782 But it fasten debug compilation time.
1784 2003-10-23 Jean-Pierre Roux
1785 * gdcm now deals with 16 Bits Run Length Encoded images
1786 (they are compressed as 2 planes images,
1787 one for the high Bytes, the other for low Bytes)
1789 2003-10-22 Jean-Pierre Roux
1790 * Now CheckRead takes into account :
1791 - the bugged 'Leonardo' Siemens images
1792 - the XA images, sent thru the burning VPRO station
1793 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1796 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1797 * FIX: When copying a Makefile.am to CMakeLists.txt
1798 one should remove the '\'
1800 2003-10-22 Jean-Pierre Roux
1801 * in gdcmData adding a bugged 'Leonardo' Siemens image
1802 (wrong lengths in header)
1803 OK with gdcm, KO with the other viewers :-)
1804 * add a GE dlx XA image, thru the VEPRO burning station
1807 2003-10-21 Jean-Pierre Roux
1808 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1809 for a brutal checking of vtkgdcmViewer compliance
1811 2003-10-21 Jean-Pierre Roux
1812 * add the files for 'xmedcon' Jpeg Lossless library
1813 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1815 2003-10-21 Jean-Pierre Roux
1816 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1818 2003-10-21 Jean-Pierre Roux
1819 * garbage Siemens 'Leonardo' images dealt with
1820 (the patch is easy to remove)
1821 * cosmetic changes to avoid warnings
1823 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1825 no need to press 'r' now.
1827 2003-10-20 Jean-Pierre Roux
1828 * upgrade of checkRead.sh checkWrite.sh according
1829 to new Jpeg Lossless decompressor
1830 * add US.3405.1.dcm, a genuine RGB medical file ...
1831 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1832 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1834 2003-10-15 Jean-Pierre Roux
1835 * general anonymisation in gdcmData
1836 * adding the 'color files' from
1837 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1838 * adding some well knowed bugged-header images
1839 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1840 waiting for their inclusion in Python testsuite
1842 2003-10-15 Jean-Pierre Roux
1843 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1844 no longer seg faults when file is not found
1846 2003-10-14 Jean-Pierre Roux
1847 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1850 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1851 * TODO: *.in file to genereate a UseGDCM later
1853 2003-10-14 Jean-Pierre Roux
1854 * Some supposed-to-be Dicom Images have no preamble.
1855 OpenFile takes it into account
1856 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1857 * Missing elements added in dicomV3.dic
1858 (just to be affraid : have a look at
1859 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1860 and do it again next year ;->
1862 2003-10-13 Jean-Pierre Roux
1863 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1864 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1865 But there are NOT. It's fixed !
1867 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1868 * FIX: "jpeglib.h" was not found on VC++
1869 * FIX: vtkgdcm was not being installed
1871 2003-10-10 Jean-Pierre Roux
1872 * ENH : OpenFile closes the file if it *really* doesn't look like
1873 an ACR-NEMA / DICOM one.
1874 * FIX : testWrite no longer writes an empty file if the source file
1875 is not gdcm Readable
1876 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1879 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1880 * FIX: CMake generate now documentation
1881 * ENH: out of source doc build !
1882 * ENH: Generate both user and dev documentation
1883 * ENH: Should work on windows too
1884 * ENH: Only one doxygen config.in file is needed
1885 * FIX: make install should be ok now on ùnix plateform
1886 * FIX: PATH to dictionary was wrong (missing /)
1887 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1889 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1890 * vtkGdcmReader is now able to read rgb dicom file.
1891 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1892 * added a gdcmViewer to vtk test, use mouse to control
1893 window level & window width
1895 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1896 * CMake-ification of gdcm, we have now two build system
1897 * FIX: on cygwin Wsock32 doesn't exist
1898 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1900 2003-10-06 Emanuel Ollart
1901 * FIX : compilation process wad broken.
1902 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1904 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1905 * change gdcmViewer -> vtkgdcmViewer
1906 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1908 2003-10-06 Jean-Pierre Roux
1909 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1910 ( e.g : well known GE images with a wrong elem length,
1911 : Philips MRI Images with a wrong Huffman table)
1912 * still to be done : allow the reading of bugged LEONARDO Siemens images
1914 2003-10-03 Jean-Pierre Roux
1915 * Odd length strings are padded with '\0' (not with spaces,
1916 to remain compliant with already defined strings,
1917 like Transfert Syntax UID and others)
1919 2003-10-03 Jean-Pierre Roux
1920 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1921 to allow displaying RGB images (not only by affim ;-)
1923 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1924 * vtkGdcmReader is now able to read rgb dicom file.
1925 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1927 2003-10-03 Jean-Pierre Roux
1928 * A few nasty patches to allow the reading of a lot of nasty images
1929 ( e.g : well known GE images with a wrong elem length,
1930 : Philips MRI Images with a wrong Huffman table)
1931 * still to be done : allow the reading of bugged LEONARDO Siemens images
1933 2003-10-03 Jean-Pierre Roux
1934 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1936 2003-10-03 Jean-Pierre Roux
1937 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1938 to allow displaying RGB images (not only by affim ;-)
1940 2003-10-03 Jean-Pierre Roux
1941 * gdcmFile::GetImageDataIntoVector now
1942 - deals with MultiFrames MultiFragments Run Length Encoded files
1943 - deals with YcBcR (YBR_FULL) files
1944 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1945 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1947 (no sample found :-(
1949 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1950 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1951 Two reasons: - clear things
1952 - third parties acces gdcm through header files, so won't
1953 suffer anymore VC++ complains
1955 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1956 * add argv[1] in testvtkGdcmReader.cxx
1959 2003-09-24 Jean-Pierre Roux
1960 * The lines are now eigthy characters long.for
1961 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1963 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1964 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1965 char* to std::string. Thus, the use of strdup becomes useless. (see
1966 previous commis of Malaterre)
1967 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1968 before the last Malaterre's commit.
1970 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1971 * This commit should fix the Debug building under VC++, the problem
1972 was mainly a mixture of debug and release lib being loaded at startup.
1973 * I also remove a depency to a specific C function: strdup. Because I had
1974 to force the link to msvcrtd (whereas strdup is in libc).
1976 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1977 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1978 located in the gdcmCommon.h file. All use of reference of tha has been
1979 changed to now use the variable GDCM_UNFOUND.
1981 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1983 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1984 Dicom dictionary. The test suite can now be run again. Note:
1985 I'm note very happy with the " (RET)" changes. I believe this
1986 RETAINED comment should be dropped when parsing the dictionary.
1987 - PACKAGER corrected
1989 - AUTHORS updated and now in alphabetical order
1990 * Makefile.am now exports gdcm.dsw for Windoze users.
1992 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1993 * cygwin complains about missing std:: in subdir Test/
1995 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1996 * remove some methods that are now in gdcmHeaderHelper
1998 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1999 * vtkGdcmReader set spacing and origin correctly
2001 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2002 * Fix a few delete/delete[] mismatch
2004 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2005 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2006 interpretation to data given by gdcmHeader. For instance there are
2007 heuristics to get informations (look at different places).
2008 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2009 sorting DICOM images based on different strategies.
2010 * modified Makefiles accordingly.
2012 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2013 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2014 when building in debug mode
2015 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2016 src/win32/gdcmdll.dsp
2017 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2019 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2020 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2023 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2024 * src/win32/libgdcmjpeg12.dsp was not dos format
2025 * src/win32/libgdcmjpeg12.dsp :
2026 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2027 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2029 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2030 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2032 * src/gdcmFile.cxx : bug fix in affectation type
2033 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2034 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2035 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2036 symbols... future problem ?
2038 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2039 * src/win32/libgdcmijpeg12.dsp was missing
2040 * modified gdcm.dsw accordingly
2042 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2043 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2045 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2046 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2047 commit of JPR (before his hollidays to facilitate our work).
2048 * setup.py : bug fix in code. Modifications made while the last commit
2049 of JPR. The code hasn't been tested before the commit... it's so
2050 useless to make that (for best programmer that is JPR) !!!
2052 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2053 * tagged the current version as Version0_3 (i.e. version 0.3)
2055 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2056 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2057 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2058 * *.dsp : modifications to use new libgdcmijpeg8 library
2059 * setup.py : bug fix on VTKPATH variable
2060 * PACKAGER : adding all concerning windows
2062 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2065 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2066 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2067 test suite reported error.
2068 * PACKAGER file added (describes what a packager must do when
2069 packaging a new release).
2070 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2071 * configure.in: upgraded version number to 0.3.0
2072 * fixing build of rpm (through rpm -ta):
2073 - Doc/Makefile.am exports proper doxygen files
2074 - src/jpeg/libijg8/Makefile.am exports the include files.
2076 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2077 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2078 * src/gdcmHeader.h : formatting code
2080 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2081 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2082 We were obtaining error message from vtk. Now, creation of file list
2083 is made in an internal list to prevent this problem.
2084 Bug fix when output is empty.
2085 Bug fix in update of progress value. Previous commit for this was a bad
2087 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2089 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2090 * src/gdcmHeader.h : added method to get the file name
2091 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2092 files. Added method to remove all files on the input
2093 Added FIXME comment concerning the bad parsing of header made by
2094 ExecuteInformation method (in ExecuteData method)
2096 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2097 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2098 when using make instal.
2099 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2100 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2102 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2103 * setup.py : adding include dir of jpeg lib to compile all sources
2104 * */Win32/*.dsp : JPR fix for windows compilation
2106 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2107 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2109 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2110 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2112 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2113 * setup.py is again effective on un*x (takes into account the
2114 addon of the jpeg library)
2115 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2116 * Doc/Doxy* updated (includes above enhancements)
2117 * INSTALL now points to web documentation
2119 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2120 * src/gdcmHeader.h doesn't make unnecessary reference to
2122 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2124 * src/gdcm*.[cxx|h] :
2125 - to allow compilation with gcc 3.x
2126 -- clean up of STL usage (added explicit usage of std::)
2127 -- small fixes on exceptions.
2128 Note: linking not tested !
2129 - clean of doxygen comments to avoid warnings at documentation
2131 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2132 dependent convertion).
2134 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * Clean up of previous JPR garbage commit (not even commented in the
2137 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2138 - moved all jpeg related files from src to src/jpeg/libijg8, with
2139 addition/modification of Makefile.am and configure.in.
2140 - the testSuite is still brain damage (not guilty).
2142 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2143 * WrapVTK.py : modifications to get correctly vtk source files to
2145 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2146 (FileName -> Filename)
2148 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2149 * vtk/vtkGdcmReader.[cxx/h]:
2150 - UpdateProgress method should now be effective
2151 - removed the limitation on having only images loaded (as opposed
2153 - when building a stack of images/volume, a lesser number of
2154 gdcmHeader and gdcmFile instances should be used (hopefully
2155 accelerating things).
2156 - when building a stack of images/volumes, files which are not
2157 loadable (wrong path-filename, wrong permissions on existing file,
2158 or file not parsable by gdcm) are replaced with a black image
2159 in the stack (for the caller to notice the problem).
2161 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2164 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2165 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2166 between standard library (std) and vtk library (problems are found
2167 under Windows... thanks Windows !)
2169 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2172 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2174 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2177 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * When compiling with distutils (see setup.py) the C++ compiler is
2179 called with different flags than the default ones (with automake).
2180 In order to fix all those warning, I compiled gdcm with the command
2181 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2182 and went for warning fixes:
2183 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2184 up from unused variables.
2185 - vtk/vtkGdcmReader.cxx: potential bug fix.
2186 * src/gdcmHeader.h: Doxygen warning cleanup
2188 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2189 * gdcmPython/gdcm.i:
2190 - typemaps correction to take into account the systematic replacement
2191 of "using namespace std" with std:: prefix e.g. std::list,
2192 std::string... (cf changes of 2003-05-21).
2193 - gdcmGlob global variable of type gdcmGlobal (defined in
2194 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2195 exported to Python a as cvar.
2196 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2197 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2198 gdcmDictSet.GetPubDictTagNames() and
2199 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2200 C++ static methods).
2201 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2202 with the above changes.
2204 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2205 * setup.py, manifest.in : bug fix under linux
2207 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2208 * Modification of setup.py to compile vtk part too. Then, we have 2
2209 wrappers which must work with same distutils. For that, we have a
2210 generic distutils in distusiltsWrapping.py ; with :
2211 - build_extWrap class to wrap generically all extensions,
2212 - ExtensionWrap base class for all wrapping extension that contains
2214 - Wrapper interface which wrap sources
2215 + In WrapSwig.py we have extension and wrapper for Swig
2216 + In WrapVTK.py we have extension and wrapper for VTK
2217 * MANIFEST.in : modifications to consider vtk directory and new python
2218 files for compilation
2220 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2221 * Added python wrappers of vtkGdcmReader vtk class (see the
2222 source in vtk/vtkGdcmReader.cxx) :
2223 - vtk/Makefile.am now builds a library
2224 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2225 python library (as opposed to _gdcm.so wich are the python
2226 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2227 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2229 - configure.in has an additional flag --enable-vtk that needs
2230 to be set to enable compilation of vtk related code, that is:
2231 + vtk/vtkGdcmReader.so and
2232 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2233 + gdcmPython/vtkgdcmPython.so (see above)
2234 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2235 be read when compressed or when HighBit + 1 != BitsStored),
2236 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2237 the usage of the python wrapper of vtkGdcmReader vtk class.
2238 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2239 * src/*.[h] all occurences of stl classes are now prefixed with
2240 std::, and all occurences of "using namespace std;" where removed.
2241 This is to avoid pollution of global namespace in included files.
2242 Apparently vtk does not avoid this pitfall: when using both
2243 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2244 collision of various stl members (principally cout...).
2245 * gdcmPython/testSuite.py now cleanly removes temprory generated
2247 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2248 comply with above changes)
2250 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2251 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2252 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2253 vtk data structure (an image Flip was required).
2254 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2255 * cosmetic changes in documentation.
2257 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2258 * src/gdcmHeader.cxx: the constructor no longer exits when an
2259 unexisting file is given as argument.
2260 * The subdirectory Data (containing all the images used for the
2261 test suite) is not part of this repository anymore. A new module
2262 containing those images is now available at
2263 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2264 with the name gdcmData.
2265 All the python scripts (including the package initialisation file
2266 gdcmPython/__init__.py) were adapated to take this change into
2267 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2269 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2270 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2271 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2272 demo of the usage of this class.
2273 Compilation of this vtk part is only done when using the --enable-vtk
2274 at configure (or autogen.sh) stage.
2276 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2277 * More memory link related corrections and documentation fixes.
2279 - maximum info is obtained with a command of the form:
2280 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2281 --show-reachable=yes PrintHeader
2282 - the remaining reachable blocks seem to come from the STL
2283 allocation scheme through the usage of map and list. It looks
2284 like this memory cannot be freed but it is not a memory leak
2285 (in fact further invocation to the STL would recollect the
2286 unused memory allthough it cannot explicitely be freed).
2287 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2288 of displaying an image parsed with gdcm and displayed with VTK.
2289 Note: some images don't seem to work e.g.
2290 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2291 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2292 Allthough this weakens the semantics, it is a ditch attempt to
2293 make gdcm more thread friendly.
2295 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2296 * Memory link hunt (by using valgrind through the command
2297 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2298 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2299 gdcmHeader::_dicom_vr.
2300 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2301 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2303 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2305 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2306 * src/Makefile.am now exports all the necessary include files at
2310 * UpdateGroupLength replaced by new one
2313 * UpdateGroupLength re-written using H-Table
2314 (named UpdateGroupLengthNew untill checks are over)
2316 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2317 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2318 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2320 - gdcmHeader::GetPubElValSet removed.
2321 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2322 UpdateGroupLength, WriteElements, Write.
2323 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2324 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2325 carried the same semantics.
2326 - src/gdcmHeaderIdo.cxx changed accordingly.
2327 - gdcmFile::WriteBase now regroups all the codes from previous
2328 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2329 - enum FileType moved to gdcmCommon.h
2330 * src/gdcmHeader.cxx AddDefault trashed
2331 * gdcmGetXSize added
2332 * getimageDataSize now calls gdcmGetXSize
2333 * Test/*.cxx changed to agree with above changes
2335 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2336 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2337 (to avoid double call by end user).
2338 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2339 by end user, since gdcmHeader::gdcmHeader now handles it.
2341 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * gdcm/Doc many doxygen changes:
2343 - Doxyfile now has two different versions, DoxyfileUsers that generates
2344 the html.users end users oriented documentation and
2345 DoxyfileDeveloppers that generates the html.developper developper
2346 oriented documentation.
2347 - README changed accordingly
2348 - requirement.txt removed (old design info moved to TODO).
2349 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2350 DoxyMainPage.txt, DoxyPython.txt provide more information.
2351 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2352 be updated by simply regenerating the docs with doxygen and copying
2353 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2354 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2355 all the tests in the form "if (<map>.count() >1)" were removed.
2356 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2357 ill-formed documentation sections.
2358 * src/gdcmHeader.cxx: ditto
2360 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2361 * setup.py fixed for un*x (needed macro for stdint.h)
2362 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2363 un*ces with sh-utils test utility.
2364 * gdcmPython/demo/test.py renamed to PrintHeader.py
2365 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2366 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2367 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2368 * src/gdcm*.cxx JPR's bad inclusion fixed.
2370 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2371 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2372 * gdcmPython/demo/test.py changed accordingly.
2374 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * gdcmPython/Makefile.am fixed linking against libstdc++
2376 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2377 * Swig subdir (historical tests of swig version 1.3.17++) removed
2378 * Test/testChangeEntete.cxx some lines commented out in order to make
2380 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2381 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2383 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2384 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2385 hence the user doesn't need this explicit call.
2386 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2387 i.e. LoadElements() call removed.
2388 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2389 - src/Makefile.am declares the proper flag for g++.
2390 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2391 for adding user defined new tags.
2392 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2393 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2394 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2396 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2397 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2398 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2399 src/Makefile.am : the project should properly compile and install
2400 with the autotools, included the python wrappers part.
2401 * gdcm.spec.in : added a spec file for RPM packaging.
2403 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2404 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2406 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2407 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2408 to exported to the environement (see gdcmPython/testSuite.py
2410 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2411 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2412 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2413 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2414 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2416 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2417 * gdcmPython/__init__.py doesn't crash anymore when running in
2418 in InstallMode or PreInstallMode but with an environement given
2419 value of GDCM_DICT_PATH.
2420 * src/gdcmDictSet.[cxx/h] coding style.
2422 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2423 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2424 * src/gdcm.h general comments moved to TODO, and README
2425 * src/gdcm.h should now be seen as a user commodity (including it
2426 should suffice to fully use gdcm). It is nowhere including within
2427 any of the kernel files src/*.cxx and src/*.h.
2429 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2431 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2433 * src/gdcm*.cxx only include their corresponding include file
2434 (as opposed to gdcm.h)
2435 * gdcmPython/gdcm.i changed accordingly
2436 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2437 the autogen.sh generated "make snapshot" command to work.
2438 * autogen.sh removed history related references to crea package.
2440 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * distutilsSwigCPlusPlus.py work around some swig portability
2444 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2446 was done in a last ditch attempt to get setup.py _really_
2447 operationnal. The python/gdcmPython layaout add the advantage
2448 of hidding away the python related distutils specific files
2449 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2450 Alas, the src directory was out of scope (i.e. it's relative
2451 position to setup.py was ../src) which made things impossible to
2452 handle (see previous version of python/setup.py). Crossing fingers...
2454 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2455 * python/setup.py now works on Un*x. (harder than I thougth)
2456 * python/distutilsSwigCPlusPlus.py can now have include files
2457 among the list of sources.
2459 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2460 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2461 * modifications in MSVC projects
2463 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2464 * As stated by the first lines of Test/ExceptionAndPython/README, it
2465 looks like we can move back to original usage of exception within
2466 src/gdcm* and hence remove the errno stuff that was introduced
2467 as a quick and dirty fixture of this problem (added to the TODO).
2468 * Doc/Doxyfile configuration file for Doxygen and corresponding
2469 README file for usage added.
2470 * Test/testWrite.cxx added. This new test comes from a split of
2471 test.cxx that is now reverted to its original purpous i.e.
2472 testing the proper parsing of a Dicom related file.
2473 testWrite.cxx concentrates on testing the IO part of gdcm.
2474 * Test/bug1.cxx (containing a bug on WIn32) added.
2475 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2476 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2477 whose purpose is to publish the content of the TagNames of the
2478 Dicom public dictionnary were not accessible without an
2479 instance of class gdcmHeader.
2480 - those methods are now static methods of gdcmDictSet and hence
2481 require no instances at all to be invocated.
2482 - within gdcmDictSet this change required to change some method
2483 to class methods (i.e. are now static) among which SetDictPath
2484 (renamed to BuildDictPath) and LoadDefaultPubDict.
2485 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2486 the above changes by calling the new method classes of gdcmDictSet.
2487 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2488 the above to be effective.
2489 * python/gdcmPython: in order to wrap properly the above changes
2490 for Python, swig version now needs to be > 1.3.17.
2491 * python/gdcmPython/Makefile fixed to adapt itself to new
2492 configure/make shema introduced by Johan Montagnat (thanks for the
2493 contribution). Alas this Makefile cannot be turned into a proper
2494 Makefile.am without some heavy changes in the configure.in
2495 (for python dectection).
2496 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2497 now avoids publishing the empty entries.
2499 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2500 * python/setup.py : bug fix concerning install under windows
2501 ExtraPath reused :-P
2502 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2504 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2505 * Dicts/dicomV3.dic : remove double spaces !!!
2506 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2507 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2510 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2511 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2512 method. Doxygenation.
2513 * src/gdcm.h clean up of JPR spurious comments.
2515 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2516 * python/distutilsSwigCPlusPlus.py now properly collects the
2517 shadow classes generated by "swig -c++" (gdcm.py in our case)
2518 when using "python setup.py install".
2519 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2520 reexports the working classes.
2521 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2522 by the classical C errno scheme. This is to prevent an obscure
2523 behavior of the python wrappers when importing wxPython.wx prior
2524 to gdcmPython (which ended up in an abort call). An illustration
2525 of this oddity can be found in the Test/ExceptionAndPython
2526 subdir (see the README file). This problem probably due to
2527 an combination of g++ and dynamic loading.
2528 * added Test/ExceptionAndPython (see above)
2530 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * Changed the layout of the python part to avoid bloating main
2532 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2533 i.e. the distutils arsenal. All the python related stuff is
2534 again in a python subdir, but the package itself is now in
2536 * setup.py was cleaned up:
2537 - pythonIncludePath removed
2538 - python setup.py bdist target is now functional.
2539 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2540 collision with other packages). gdcmPython/demo/*.py changed
2543 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * python subdir moved to gdcmPython (preparation of distutils packaging).
2545 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2546 distutils installer is operational.
2547 * - gdcmPython/__init__.py now properly loads the swig generated
2548 shadow classes (from gdcm.py).
2549 - gdcmPython/demo/*.py changed to import the package gdcmPython
2550 instead of gdcmPython/demo/load.py.
2551 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2553 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2554 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2555 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2556 entries within the associated public Dicom dictionary resp. the same
2557 information but sorted by the fourth field (PAT, IMG, DIR) of the
2559 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2560 are now in the "???" group.
2561 - python/gdcm.i changed accordingly,
2562 - python/demo/printGroupedPublicDict.py added, that gives an example
2563 of the above new functionalities in Python.
2565 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * src/gdcm.h, gdcmHeader.cxx:
2567 - historic references to glib's g_malloc and g_free (#defined)
2568 were definitively removed.
2569 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2570 * src/gdcmElValSet.cxx:
2571 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2572 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2573 - GetElValue(string) renamed to GetElValueByName.
2574 - Added GetElementByName(string).
2575 * src/gdcmHeader.cxx: added
2576 - GetPubElValRepByNumber(guint16, guint16)
2577 - GetPubElValRepByName(string)
2578 - GetShaElValRepByNumber(guint16, guint16)
2579 - GetShaElValRepByName(string)
2580 - GetShaElValByNumber(guint16, guint16)
2581 - GetShaElValRepByName(string)
2582 - GetElValRepByNumber(guint16, guint16)
2583 - GetElValRepByName(string)
2584 - GetElValByNumber(guint16, guint16)
2585 - GetElValRepByName(string)
2586 * Doc/requirements.txt added.
2588 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * Test/Makefile building now depends on the one of libgdcm.so
2590 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2591 pixel data) aware which enables finding the address (offset) of
2592 the pixel data of JPEG encoded DICOM files. This leaves only a single
2593 file in the testSuite whose pixel data address (offset) is unknown.
2594 * python/testSuite.py changed accordingly.
2596 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2597 * VC++ has some strong limitations when working with the STL, as stated
2598 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2599 "Also note that some STL containers (map, set, queue, list, deque)
2600 cannot be exported. [...]
2601 Some STL classes contain nested classes. These classes can not
2603 This is caused by a designed limitation that once a template
2604 class is instantiated, it can not be re-instantiated and
2606 Since our usage of map<> is ubiquitous in gdcm, this "designed
2607 limitation" of VC++ is a pitfall.
2608 Hence the Python wrappers of gdcm cannot be incrementally linked
2609 against the c++ dynamic library. The dirty but only workaround is
2610 to forget about incremental link of dynamic libraries and to generate
2611 the Python wrappers library with the inclusions of the underlying C++
2613 The following modifications concern this matter on Win32/VC++:
2614 - wrapping python correct with standalone wrapped dll (don't use separate
2615 dll under windows !!!!)
2616 - python21_d debug mode enabled (ask Frog how to use it :-)
2617 - NO problem with having an STL member of class for example string in C++
2618 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2619 - Python test of dcmlib in Python is ok under windows on a large set
2621 * removed glib references
2622 * typedef's inserted in gdcm.i for correct swig type management
2624 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * python/demo/*.py load.py extracted from test.py. Added explore.py
2626 that only displays required tags and testAll.py that parses all
2627 the files of the testsuite without using unittest.
2628 * python/testSuite.py other additional test on new files added.
2629 * Data/* new test files added accordingly to the testSuite.
2630 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2631 the vr in the file differs from the one of the dictionary.
2633 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2634 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2635 values, but limits itself to values which are below a user specified
2636 size (by default 1024 bytes).
2637 * python/gdcm.i : elements not loaded (because their size is above the
2638 user specified treshold) are exported with their TagKey as key of the
2639 python dictionary. This enables the testsuite to make some checks
2640 on the unloaded elements (since we have their offset and size).
2641 * python/testSuite.py
2642 - now tests for the existence and proper value of the pixel data
2643 - two new examples added.
2644 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2646 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2647 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2648 aware. See the strategy comments in gdcmHeader::FindeLength().
2649 * Test/test.cxx now accepts a filename as first argument.
2650 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2651 * python/testSuite.py changed to integrate test on above files.
2653 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2654 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2655 the vr was also RET.
2656 * python/testSuite.py more tests added.
2658 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2659 * python/testSuite.py unittest test suite added (uses Data)
2660 * Data/* dcm and acr files for the test suite.
2661 * glib dependance removed from un*x version. We now use ISO C99
2662 7.18 Integer types (see stdint.h)
2663 - python/Makefile, src/Makefile src/gdcm.h
2664 * src/ when an explicit vr (like dicom files) suddenly poped an
2665 implicit element we use to mark the underlying DictEntry of the
2666 concerned ElValue with "Implicit". This strategy was damageable
2667 too the public or provite dictionaries, since some of their vr
2668 would be changed. Since Header::FindLength heavily relies on the
2669 detection by Header::FindVR of falsely explicit elements, I
2670 added an extra ImplicitVr member to ElValue (boolean).
2671 The rest of the changes we the necessary adaptations.
2673 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2676 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2678 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2679 * Adaptation for porting to VC++:
2681 o forced to use std namespace (for string to be known)
2682 o all class use __declspec export style on WIN32
2683 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2684 (in stdlib.h on Win32 but in std:: for gcc)
2685 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2686 variable GDCM_DICT_PATH.
2687 * src/gdcmHeader.cxx verbose comments made discrete.
2689 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2690 * python/gdcm.i: added a typemap that converts a C++ hashing table
2691 to native Python dictionary.
2692 * python/demo/test.py:
2693 - now uses the native dictionary for exploration of gdcmHeader.
2694 - takes an optional filename argument (the file to parse).
2695 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2696 PubElVals hashing table.
2697 * Dicts/dicomV3.dic removed error prone trailing spaces.
2699 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * Python wrapping process moved away from src/Makefile to
2701 newly created python/Makefile (as well as gdcm.i)
2702 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2703 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2704 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2705 from the environement variable GDCM_DICT_PATH (when existing).
2706 * src/gdcmDict::GetTag bug fix.
2708 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * Straightforward temporary fixes for swig to build the python wrappers.
2710 src/Makefile now has a python working entry [by working we mean
2711 that we can import de shadow classes without errors].
2713 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * hashtest.cxx removed (since allready in Test)
2715 * src/gdcmlib.h renamed to src/gdcm.h
2716 * src/dcm.i renamed to src/gdcm.i
2717 * src/Makefile prepared for python wrapping
2719 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2720 * src/gdcmHeader.cxx :
2721 - Parsing of header is now separated from loading of element values
2722 (see gdcmHeader::LoadElements).
2723 - general clean up of hopefully all file access (creation of
2724 ReadInt16 and ReadInt32)
2726 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2727 * src/gdcmHeader.cxx :
2728 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2730 - SetLgrElem renamed to SetLength
2731 - GetLgrElem renamed to GetLength
2732 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2733 * src/gdcmElValSet.cxx fixed both GetElValue methods
2734 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2735 due to IdoDude was cleaned out.
2737 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2738 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2739 concentrates on finding the value representation (when it exists).
2740 RecupLgr now only finds the element value length, and it avoids
2741 returning the unecessary skL (skipped length).
2742 Also, offsetCourant was simply removed (with taille_fich) since
2743 it was redundant with the File position internals (by using
2744 ftell and fseek). This also made skL (see above in RecupLgr) usage
2746 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2747 on the libido specificities which are handled through class
2749 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2752 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * Truckload of changes. Parsing of header is barely functional
2754 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2756 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2757 * src/gdcmHeader.cxx many addons of low level methods
2759 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2761 and _IdDcmSWAP_LONG.
2763 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * This corresponds to all the changes decided at the meeting of
2765 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob