1 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * FIX: src/* fix the doxygen warnings.
4 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
5 1. Finish merging JMR patch for writting DICOM from scratch
6 2. Fix -hopefully- bug with MONOCHROME and space vs null character
7 3. Use const ref when possible
8 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
10 6. CreateUniqueUID can now be called without parameter"
12 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
13 * ENH: Slightly bigger patch:
14 1. Getting toward full integration of JMR patch for writting dicom from scratch
15 2. Update Test to test part of this patch: CreateUniqueUID
16 3. File was not close properly in gdcmDict
17 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
18 5. Use of const ref instead of copy (speed issue)
19 6. Remove temporary (duplicate) string in TranslateToKey
20 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
21 8. Do not repeat virtual in subclasses
22 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
24 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
25 * Apply first patch toward better string comparison when dealing with broken
26 DICOM files. Essentially the string could be padded with a space instead
27 of a null character as defined by standard
29 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
31 because never used... and in the same time, that's remove some memory leaks
33 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * src/gdcmFile.cxx : now delete the PixelConvert instance.
35 * In examples and tests : change the type of image data variables from void*
36 to uint8_t*. Remmove all delete on image data variables
38 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
40 Verify the file pointer value before open the file, and if it's not null,
41 a verbose message is generated.
42 Close correctly the file when the file isn't considered dicom-like. The
43 correctly close is a call to CloseFile.
44 When closing the file pointer, test if its not null to close the file.
45 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
46 file. For an uncompressed image, the copied datas correspond in the least
47 case to the image size (calculated) or the image size specified in the
48 header. A verbose is generated if these two size mismatch
50 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
52 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
53 break under windows (with msvc6 compilation).
55 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
59 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Bugs fix for the Windows build with VC6
61 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
62 needed (only for projects required VTK). If the VTK is included in all
63 projects, there is conflicts with the jpeg lib of vtk when compiling the
64 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
65 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
66 when compiling the gdcm_wrap.cxx file (created by the compilation of the
68 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
69 (like it's already made for the cout use). Otherwise, conflict with the
72 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
75 - comments on the DicomDir::Method related usage added.
76 - now that we use the namespace gdcm, a lot of internal classes do
77 NOT need to be wrapped anymore.
78 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
79 DicomDir::Method) new example added.
81 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
82 * Improve string manipulation. I now inforce the notion of 'DicomString'
83 A DicomString can contain as many \0 as they want
84 and it is *always* of even length.
85 We only support odd length for very rare case.
86 And in the near future this should be removed.
88 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
89 * /binary_write/ gdcm source. Now even on big endian we are writting
90 little endian. This should -heopfully- fix some tests
92 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
93 * Now the dictionary is compiled into gdcm lib. This is a default
94 behavior, thus any dic file specified is picked before failback to
95 the one comiled into lib
97 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
98 * Change internals for gdcmDict. Don't use any 'new' any more.
99 This should definitely solve any leak problem, and we should be
100 as fast as before, as long as don't modify too much the dictionary.
102 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
103 * STYLE: ivars should start with a capital letter.
104 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
105 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
107 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
108 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
109 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
110 new 2004 dictionaries added (thanks to JPR).
111 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
112 * CLEANUP_ROUND (15) for gdcmPixelConvert
113 - RLEFrame::NumberFragments is now of type unsigned int
114 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
115 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
118 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
119 * Initial work in gathering all transfer syntax accessors. clearly
120 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
121 ivars, but only one transfersyntax (class) ivar with equivalent method on
124 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
125 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
126 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
127 discussed (plus I didn't like having a 2000 lines patch not commited)
129 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
130 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
131 * CLEANUP_ROUND (14) for gdcmPixelConvert
132 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
133 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
134 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
136 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
137 anymore and hence avoids storing a copy of PixelConvert::Decompressed
138 into File::Pixel_Data.
140 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
141 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
142 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
143 * CLEANUP_ROUND (13) for gdcmPixelConvert
144 Substituted File::ParsePixelData() with PixelConvert::Print() new
146 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
147 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
148 method to those classes.
149 - src/gdcmFile.[cxx|h]:
150 -- Added a ::Print() method.
151 -- PixelConverter is now a reference instead of a member.
152 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
153 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
155 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
156 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
157 collaboration diagram and inheritance diagram should be generated with
159 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
160 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
161 pointlessly wrapped (see
162 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
163 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
164 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
165 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
166 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
167 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
168 -- File::Initialise: PixelConverter setup moved away to
169 PixelConverter::GrabInformationsFromHeader()
170 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
171 interpretation moved away to PixelConverter::BuildRGBImage()
173 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
174 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
175 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
177 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
178 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
179 displayed on Win32 when a brutal abort() occurs (because of uncatched
180 exception). See TODO new entry of this commit for more on this.
181 * TODO added new entry.
182 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
183 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
184 - HandleColor is no longer called from gdcmFile.cxx
185 - gdcmPixelConvert.cxx clean up on method arguments and internal
186 variable names for semantical coherence.
188 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
189 * Finished lossless transition, not only do we now read all lossless jpeg
190 images, without the need of the Cornwell lib, but we do read them properly now
191 * To reduce code (well to avoid code duplication), I defined a common place
192 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
193 redefine symbols. This is not prefect but this the best solution I found for a
194 compilation time jpeg option.
196 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
197 * Update jpeg ijg lib to support lossless jpeg implementation
198 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
200 * Also added a special copyright for dcmtk since we use their bugfixes.
203 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
204 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
205 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
206 matters, as stated in warning note at begining of %include section).
207 * src/gdcmDicomDir*.[cxx|h]: coding style
208 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
209 * src/gdcmJpeg8.cxx: doxygen fix.
210 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
211 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
212 from File:: to PixelConvert::.
214 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
215 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
216 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
217 - more code moved away from File:: to PixelConvert::
218 - fat setup of PixelConverter set in place in File::Initialise.
220 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
221 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
222 namespace at the file system level. So now you should convert your examples
224 gdcmHeader -> gdcm::Header
225 It would be nice if people keep in mind to no open the namespace, since it
226 allows compilation on broken plateform which were defining common symbol in
227 the standart namespace (like LP, Unknown ...)
229 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
230 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
231 The JPEG fragments are now parsed at the same stage than the RLE
232 information. All code related to JPEG is now in gdcmPixelConvert:
233 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
234 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
235 export a gdcmFile:: method. Those are simply global functions
236 (for the time being this is better than having them attach to
237 either gdcmFile:: or gdcmPixelConvert::).
238 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
239 and stores the result in a gdcmJPEGFragmentsInfo.
240 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
241 code (among other stuff) moved away from gdcmFile:; to
244 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
245 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
246 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
247 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
248 clean up of RLE related code.
249 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
250 - src/gdcmRLE.cxx removed
251 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
252 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
253 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
254 * CLEANUP_ROUND (9) for gdcmPixelConvert
255 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
256 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
257 away from gdcmFile:: to gdcmPixelConvert::.
259 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
260 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
261 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
262 This is because Parse7Fe0 used to parse the pixels to compute the
263 length. This task was passed over to FindDocEntryLengthOB() a long
264 time ago, EXCEPT I had forgotten the OW case...
265 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
266 we just recylce the code for parsing RLE fragments and computing
268 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
269 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
270 with the retired Parse7Fe0().
271 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
272 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
274 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
276 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
277 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
278 - src/CMakeLists.txt: alphabetic order reodering + new entries.
279 * CLEANUP_ROUND (4) for gdcmPixelConvert
280 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
281 to return an unused length.
283 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
284 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
285 this should be cleanner from the plane view. The iostream are erally a pain
286 to use to do simple stuff.
288 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
289 * Redo the compilation of the ijg jpeg library. Now only one source is
290 necesseray. No need to rename file by hand what so ever. CMake handle the
291 copying of the file within different directory, configure header file to
292 modify some symbol. The only addition made to ijg wasd a mangle table so
293 that symbol are different wether we are within 8bits or 12bits.
295 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
296 * Added documentation of vtkgdcmReader on Website:
297 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
298 with it's binary name).
299 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
300 the Website to be more complete.
301 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
302 doxygenated documentation.
303 - Doc/DoxyVtkGdcmReaderExamples.txt added
304 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
305 DoxyVtkGdmReaderExamples.html )
306 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
307 * CLEANUP_ROUND (3) for gdcmPixelConvert
308 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
310 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
311 * CLEANUP_ROUND (2) for gdcmPixelConvert
312 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
314 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * CLEANUP_ROUND for gdcmPixelConvert:
316 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
317 - src/gdcmPixelStuff[h|cxx] removed
318 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
319 - src/CMakeLists.txt changed accordingly
321 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
322 gdcmVersion.py moved to newly created ATTIC related
323 gdcmPython/SetupOldies/ directory.
324 * Autotools clean up:
325 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
326 - autogen.sh configure.in acinclude.m4 python.m4 removed
328 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
329 * src/*.cxx *.h Reference to License.htm fixed to License.html.
330 * Doc/CMakeLists.txt, doxygen.config.in: fix.
331 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
333 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
334 * TODO updated with Mathieu suggestions. I proposed a template for
335 describing TODO entries and used it for new entries.
336 * Added Doc/Website/CodingStyle.html, Developpers.html,
337 DeveloppersPython.html, GdcmDataCvs.html and
338 DownloadVersion0_1.html, DownloadVersion0_3.html.
339 * Some Doc/*.txt Doxygen files (which do not really concern the
340 documentation itself, but the website) moved to html and
341 placed in directory Doc/Website:
342 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
343 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
344 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
345 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
346 * CMakeLists.txt changed accordingly.
347 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
348 DeveloppersPython.html
349 * INSTALL nows refers to Doc/Website/Installation.html
351 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * Added Doc/Website directory, that contains a first raw version
355 2004-09-23 Jean-Pierre Roux
356 * FIX In order not to be poluted any longer by casting problems,
357 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
358 we can now delete[] it safely
359 * VoidArea is now called BinArea (less confusing name),
360 and all the methods called ...VoidArea... are now ... BinArea...
361 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
363 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
364 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
365 clear) TagHT, which is an inherited member of gdcmElementSet. It is
366 up to the destructor of gdcmElementSet to clean up TagHt and it's
369 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
370 * Test/CMakeLists.txt: update to follow gdcmData renamings.
371 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
373 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * ENH: added some utility method that builds a flat dictionnary
375 holding all the Dicom entries contained in the recursive structure
376 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
378 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
379 BuildFlatHashTable() that build a flat dictionary.
380 - src/gdcmElementSet.h: added a new private GetTag() accessor.
381 gdcmDocument is now a friend of gdcmElementSet.
382 - src/gdcmElementSet.cxx: clean up.
383 - Example/FlatHashTablePrint.cxx added.
384 - Example/CmakeLists.txt changed accordingly
386 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
387 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
388 moved away from gdcmDocEntrySet (since this class is an abstract class
389 acting like an interface). SQDepthLevel and BaseTagKey are now
391 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
392 and associated accessors. Doxygenation of the class.
393 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
395 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
396 Use SQDepthLevel accessor instead. ::Print() adapted.
397 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
398 - src/gdcmDocument.cxx changed accordingly.
400 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
402 - The following is the doxygen comment of the typedef declaration
403 of gdcmagKey in src/gdcmCommon.h:
404 gdcmTagKey is made to old an "universal" (as in URL, Universal
405 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
406 A dicom tag allways has a group and an element, but a set of tags
407 embeded in various (optionally nested) sequences and sharing
408 the same group and element all share the same (group, element)
409 "identifier". Hence the (group, element) cannot be used as an
410 identifier (in gdcm we shall refer to a "TagKey") of a tag.
411 In order to construct a proper tag identifier (i.e. a key) we
412 consider the following definition of a TagKey:
413 - let Group, Element be the string representation of the
414 group and element dicom tag members,
415 - let ItemNumber be the string representation of the integer
416 index of the considered item number of a sequence,
417 Let the key of a tag embeded in a sequence, noted SeqTag, be
419 /ItemNumber#Group|Element
420 where "/", "#" and "|" are characters acting as separators.
421 Then the general form of a gdcmTagKey is given by:
422 Group|Element<SeqTag>
423 where <SeqTag> means NO or many instances of SeqTag.
424 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
427 but the gdcmTagKey of a tag "embeded" is the first item of
428 a sequence, itself nested in the third item of a sequence is the
430 0004|1220/2#0008|0082/0#0008|0090
431 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
432 order to hold the new sequence compatible key. Previously, the
433 GetKey() method would look in the underlying gdcmDictEntry.
434 - src/gdcmDocEntry.cxx:
435 -- constructor now copies the underlying DictEntry key, in the local
437 -- ::Print: displays the member Key, instead of the (group, element).
438 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
439 - src/gdcmDocEntrySet.h:xi
440 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
441 -- now has a new BaseTagKey member.
443 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
444 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
446 This poses the problem with the semantics of the following lines
447 LoadEntryVoidArea(0x0028,0x1201); // R LUT
448 LoadEntryVoidArea(0x0028,0x1202); // G LUT
449 LoadEntryVoidArea(0x0028,0x1203); // B LUT
450 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
451 to the long FIXME note for what the problem is. Nevertheless in
452 order to get things working the dicom dictionary was altered !
453 Please fix things urgently...
454 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
455 information), see above note on moving the member VoidArea. Nevertheless
456 the following entries previously correctly set as US are now inproperly
458 0028 1201 OW IMG Red Palette Color Lookup Table Data
459 0028 1202 OW IMG Green Palette Color Lookup Table Data
460 0028 1203 OW IMG Blue Palette Color Lookup Table Data
461 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
462 of gdcmDocEntry moved to gdcmSeqEntry.
463 * src/gdcmSeqEntry.cxx: STYLE.
465 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
466 * Test/TestAllEntryVerify.cxx minor fix and added comments.
468 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
469 * gdcmPython/testSuite.py: all the test suite in python is now moved
470 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
471 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
472 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
474 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
475 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
476 to avoid inclusion recursion until STL is reached.
477 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
478 mecanism. errno.h is not included in gdcm anymore.
479 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
480 (gdcmFormatError now inherits from gdcmFormatUnexpected).
482 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
483 gdcmData/TestAllEntryVerifyReference.txt
484 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
485 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
486 exception_on_error parameter.
487 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
488 - vtk/vtkGdcmReader.cxx changed accordingly,
489 - Example/*.cxx and Test/*.cxx changed accordingly.
491 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
493 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
494 enable_sequences removed from gdcmHeader constructor and dependencies.
495 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
496 * gdcmPython/demo/PrintHeader.py: dummy fix.
497 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
498 skip_shadow removed from gdcmHeader constructor and dependencies.
499 * Example/*.cxx and Test/*.cxx changed accordingly.
501 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
502 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
503 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
505 2004-07-21 Jean-Pierre Roux
506 * FIX Now, Parsing and Printing a DICOMDIR do work!
507 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
509 2004-07-20 Jean-Pierre Roux
510 * FIX Some brain damaged headers have Zero-Lenght fields
511 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
513 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
515 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
516 variable (instance of gdcmDebug) by a definition macro, and the instance
517 is now in static in the gdcmDebug class
518 * src/gdcmSQItem.h : (FIXME) remove an undefined method
519 * Test/PrintAllDocument.cxx : bug fix in the result of the test
521 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
522 * WARNING: ctest now depends more tightly on gdcmData. You should
523 check out gdcmData properly for things to run smoothly...
524 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
525 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
526 we need the pixels not be loaded in order to use the ValEntry
527 that displays position and size).
528 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
529 This is a C++ based equivalent of gdcmPython/testSuite.py that should
530 be deprecated. If you have any doubts about the advantages of a
531 modern scripting language (read Python) versus grass root C++ (i.e.
532 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
533 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
534 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
535 Anyhow, consider documenting the gdcmData images in
536 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
538 * Test/CMakeLists.txt:
539 - now uses TestAllEntryVerify.cxx
540 - specific comments on oldACR00001.ima (now renamed in gdcmData
541 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
542 gdcmData/TestAllEntryVerifyReference.txt
545 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
546 * src/*.[h|cxx] : typedef clean up
547 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
548 - TagKey renamed to gdcmTagKey (for external usage)
549 - VRKey renamed to gdcmVRKey (for external usage)
550 - removal of typedef duplication.
551 - Removed all unecessary inline keyword from class inline definitions.
552 - Some method|function(void) declarations replaced with method|function().
553 * src/jpeg/libijg12/jdhuff12.c:
554 - printf polluting ctest removed.
555 - TAB removal for comminting
557 - TestAllReadCompareDicom.cxx: added a test that compares all the
558 images in gdcmDataImages.h with corresponding images in
559 gdcmData/BaselineDicom/. When baseline images are not present
560 this test creates them.
561 Note: we need to validate each reference image, but before that
562 I'd like to rename them with a more explicit name...
563 - CMakeLists.txt: changed accordingly.
564 * Example/*.cxx: examples now only include gdcm.h (as opposed to
565 including each header needed).
567 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * Test/*.cxx and Example/*.cxx: moved some examples away from the
569 test suite to the Example directory. Are concerned:
574 - TestWriteSimple.cxx
575 * Test/CMakeLists.txt: added some comments on reasons for black listing
576 image gdcmData/oldACR00001.ima
578 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
579 * Test/CmakeList.txt: removed the following from black list (to be coherent
580 with removal from gdcmData):
581 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
582 - gdcm-MR-PHILIPS-16.dcm
584 Added the following because after last cvs update, they cause
585 ctest -R TestReadWriteReadCompare
587 - gdcm-MR-SIEMENS-16-1.acr
589 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
590 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
591 new comments in this file) we temporarily (sigh) move to a weaker
593 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
594 we don't need to black list the following images anymore:
595 - 8BitsUncompressedColor.dcm
597 - US-PAL-8-10x-echo.dcm
598 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
599 fixes and the beautified code ;-)
600 This fixes the bug introduced in version 1.42 (when beautifying)
601 that made the parsing of 8BitsRunLengthColor.dcm unproper.
602 Note: ctest was blind to this bug (this means we need to still
603 improve the test suite). The bug could be detected by using
604 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
606 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
607 and by displaying the (garbage) produced file temp.XDCM...
609 2004-06-29 Jean-Pierre Roux
610 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
611 - replace by uggly but working old code :-(
612 A lot of things should be OK again.
613 It's really urgent to have a test suite that *tests*,
614 to prevent Frog's beautifying sessions to break all the stuff
615 (twice, withing a fortnigh ...)
617 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
619 redundancy) to added Test/TestReadWriteReadCompare.cxx
620 * Test/CmakeList.txt: because the compare test of
621 Test/TestReadWriteReadCompare.cxx fails, the following images are
622 black listed: - 8BitsUncompressedColor.dcm
624 - US-PAL-8-10x-echo.dcm
625 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
626 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
627 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
628 and ad-hoc kludge. This kludge is now removed, and on encountering
629 such an image (OB field brain damaged) we set errno. Then in
630 ::FindDocLength() we "fix" the length as being ALL what remains
631 in the file (until EOF). We then proceed, hoping for the best...
632 This fixes a SegFault in ShowDicom when trying to write such an
634 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
635 (because TestWriteRead breaks on it, after a non conformal commit?).
636 ctest now runs properly, except for MakeDicomDir (which was allways
637 broken) and the Python related stuff (still not fixed).
639 2004-06-24 Jean-Pierre Roux
640 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
641 FIX : Test/TestReadWrite now iterates on all the file names
642 (instead of infinite loop)
643 ENH : Test/TestWriteRead now iterates on all the file names
645 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
648 2004-06-24 Jean-Pierre Roux
649 FIX : - now Write drops LUT Descriptors and LUTs (if any)
650 when SamplesPerPixel =3
651 - now Write is no longer confused by
652 'BitsAllocated = 12" and 'BitsStored=12"
653 - "UN" value representation Elements are now written correctly
654 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
655 ENH : - now gdcmHeader has its own Write methods
656 (in order to split the job that has not to be done
659 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
661 loop on the same image until memory went out.
662 Note: this means we still have gobs of memory loss in PrintDocument
663 * src/gdcmDocument.cxx: fixes problem on parsing on file
664 gdcmData/16BitsJpegLosslessGrayScale.dcm.
666 2004-06-24 Jean-Pierre Roux
667 FIX : Write - All the Sequences and Sequence Item are now written
668 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
669 is added a the end, when necessary.
670 - A lot of brain-damaged images, that were read correctly are
671 now written correctly
672 - length compatible BinEntry are now loaded correctly
673 (even for odd groups)
674 Note : only Explicit Value Representation was checked.
675 (question : is implicit VR really necessary for gdcm ?)
677 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
678 * DEVELOPPER: added a proposition of coding style.
679 * src/gdcmDocEntry.h: removed every inline declaration (for test of
682 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
684 Use the gdcmDocEntry::Print() and Write() instead.
685 * src/gdcmDocument.cxx: bug fix.
687 2004-06-22 Jean-Pierre Roux
688 FIX : gdcmDocument.cxx
689 - Now we do recognize the JpegLossLess format (there was a misstyping in
690 code 'beautyfication' :-(
691 - Now we automaticaticaly load the Luts, if any
693 2004-06-22 Jean-Pierre Roux
694 In order : to write Sequences, whatever their imbrication level,
695 : to allow user to create his own Sequences
696 a lot of modif where necessary (adding, moving, or virtualising methods)
698 WARNING : save your own sources *before* cvs up !
701 ADD virtual void Write(FILE *fp, FileType filetype);
704 ADD virtual void Write(FILE *fp, FileType filetype);
705 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
708 ADD virtual void Write (FILE *fp, FileType filetype)=0;
709 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
710 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
711 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
712 ADD std::string GetEntryByName(TagName name);
713 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
715 std::string vr = "unkn",
716 std::string fourth = "unkn",
717 std::string name = "unkn");
718 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
719 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
720 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
721 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
722 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
723 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
724 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
725 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
728 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
729 ADD virtual std::string GetEntryByName (TagName tagName);
730 ADD virtual std::string GetEntryVRByName (TagName tagName);
731 REM virtual bool Write(FILE *, FileType);
732 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
733 FILE *_fp, FileType type);
734 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
735 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
736 REM virtual bool WriteEntries(FILE *_fp,FileType type);
737 REM virtual std::string GetEntryByName (std::string tagName);
738 REM virtual std::string GetEntryVRByName (std::string tagName);
739 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
740 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
741 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
743 std::string vr = "unkn",
744 std::string fourth = "unkn",
745 std::string name = "unkn");
746 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
747 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
748 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
749 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
752 ADD virtual void Write(FILE *fp, FileType filetype);
755 ADD virtual void Write(FILE *fp,FileType filetype);
758 ADD virtual void Write(FILE *fp, FileType filetype);
759 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
760 REM std::string GetEntryByNumber(guint16 group, guint16 element);
761 REM std::string GetEntryByName(TagName name);
764 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
766 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
768 The default constructor invoked by the line
769 gdcmHeader *f1 = new gdcmHeader( header );
770 was gdcmHeader::gdcmHeader(bool) instead of the expected
771 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
772 Hence the parsing wasn't executed... See also below.
773 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
774 as explicit constructor didn't do the trick to fix the above problem.
775 Could anyone explain why ?
776 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
777 properly calls gdcmValEntry::Print() (that was weed out from
778 code related to gdcmBinEntry).
780 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * In order to fix memory leaks:
782 - Test/TestWriteSimple.cxx: added cleaning of free store through
784 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
785 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
786 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
787 (through the call to ::AddDicomDirMeta()) or the destructor
788 would crash when deleting uninitialized ::metaElems].
789 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
790 - src/gdcmDocument.cxx:
791 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
793 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
794 was causing memory leaks.
795 - src/gdcmSQItem.cxx:
796 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
797 cleanly handled with polymophism: sorry but my milage is low).
798 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
799 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
800 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
801 This avoids SegFaulting.
802 - src/gdcmSQItem.h: coding style.
804 - Test/TestWriteSimple still severely sucks. The output image content
805 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
806 damaged when displayed with vtkgdcmViewer.
807 - on memory leaks: TestWriteSimple leaks really less (see entry
808 of 2004-06-18 in Changelog file for the call to valgrind).
809 - on segfaults: ctest now passes all the tests but one (no more
811 * Erroneous leading white fix:
812 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
813 white[s] (as opposed to from >> xxx, that removes it [them].
814 - src/gdcmTS.cxx: ditto.
815 - gdcmPython/testSuite.py: dirty related kludge removed.
816 * src/*: remaining references to gdcmParser removed.
817 * src/*[cxx|h]: added copy[way]left header.
820 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
821 * In order to fix writing of dicom files:
822 - Test/TestWriteSimple.cxx: a simpler example of writing.
823 - Test/CMakeLists.txt changed accordingly.
824 - src/gdcmDocument.cxx:
825 -- The destructor now recursilvely removes potential sequences.
826 -- Bug fix in ::IsJPEG2000()
827 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
828 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
830 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
831 to only declared) and build on top of
832 ::GetDocEntryByNumber(guint16, guint16).
833 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
834 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
835 for usage in destructor and treatement of promotion in
836 ::ReplaceOrCreateByNumber().
837 - src/gdcmSQItem.cxx: destructor should better handle his job.
838 Test/TestWriteSimple now runs (or at least it DOES something).
839 * We can now start hutting memory links. A good starting point is:
840 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
841 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
842 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
844 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * Valgrind note: after Mathieu Malaterre teached me how to read
846 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
848 Using gcc, you can force the STL to use malloc and to free memory as
849 soon as possible by globally disabling memory caching.
850 With 3.2.2 and later, you should export the environment variable
851 GLIBCPP_FORCE_NEW before running your program.
852 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
853 simply vanish (it is still not clear to me, whether this means that
854 STL std::string leaks or if valgrind believes it leaks...).
855 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
856 running bin/gdcmTests makeDicomDir):
857 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
858 - Test/makeDicomDir.cxx now properly traps empty lists and returns
860 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
861 SegFaulting (I drowned in DicomDir related code when trying to
862 understand why the list is empty...).
863 * src/gdcmDocument.h: first BSD license header try.
864 * Doc/License.txt added.
866 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * src/gdcmDocument.[h|cxx]:
868 - Clean up of the Transfer related predicates. They are now all based
869 on new method isGivenTransferSyntax, that (should) handle properly
871 - general clean up, simplification, and coding style.
872 - Specific clean up of Parse7FE0() (umproperly named actually).
873 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
875 2004-06-14 Jean-Pierre Roux
877 - fix the display of Sequence Delimitor (SQDepthLevel pb)
878 - fix the display of SQItem ordinal number
879 - add the GetSQItemByOrdinalNumber method
880 - remove some useless never written private methods
882 2004-06-14 Jean-Pierre Roux
884 - adding a constructor taking a gdcmDocEntry as an input param
885 - ReplaceOrCreateByNumber now returns :
886 a gdcmBinEntry * if a Binary (void *) value is passed as a param
887 a gdcmValEntry * if a string value is passed as a param
889 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
890 according to the param type (no longer sets a gdcmDocEntry)
891 - GetValEntryByNumber, GetBinEntryByNumber added
892 - NewValEntryByNumber and NewBinEntryByNumber added
894 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
896 - GetSQItemNumber and SetSQItemNumber added, to provide
897 a (relative) Item identier inside a given Sequence
898 \warning : some pb remaining around this number
900 - AddEntry now takes the Item Number as a param
902 - adding a constructor taking a gdcmDocEntry as an input param
904 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
905 * Memory leak hunt with the following command:
906 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
907 --show-reachable=yes gdcmTests PrintDocument
908 It looks like many (all?) leaks are due to the STL (or a bad usage
909 of the STL. The lines producing the leaks now have a comment with
910 a "MEMORY LEAK" tag: you can retrieve them with
911 grep "MEMORY LEAK" src/*
912 Here are two typical examples which I can't help fixing:
917 char * test = "babo";
918 name = test; //// <--- valgrind detects 960 bytes lost in
919 //// call to std::string::operator=(char const*)
920 name.clear(); //// Doesn't help !
928 std::cout << "Type a bunch of characters followed by RETURN: ";
929 getline(std::cin, line); //// <--- valgrind dectects a loss
930 //// of 1320 bytes in call to
931 /// std::basic_istream<>& std::getline<>
937 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
938 * src/gdcmHeader.[cxx|h]:
939 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
940 and related, moved away to gdcmDocument.
941 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
942 the corresponding protected accessors of inherited class
943 gdcmDocument, removed ! As a consequence gdcmFile had to be
944 declared friend of class gdcmDocument (see below).
945 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
946 - Clean up of undefined or unused methods.
947 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
948 account the changes to gdcmHeader.h).
949 * src/gdcmDocument.h:
950 - gdcmFile is now a friend class (in order to take into account the
951 changes to gdcmHeader.h).
952 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
953 (see changes to gdcmHeader.h).
954 - Accessors (reading on the form GetEntry*) are now public.
955 - Clean up of undefined or unused methods.
956 * src/gdcmDocument.cxx:
957 - adaptation to changes to gdcmDocument.h
958 - ::OpenFile now writes a verbose message when file cannot be opened.
959 - some std::string properly set to VRKey
960 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
961 references to gdcmDocument.
962 * Test/TestFindTags.cxx: changed accordingly to above changes.
963 * gdcmPython/testSuite.py: adapted to renaming of acr files in
964 cvs repository gdcmData.
966 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
968 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
969 conflicts with gdcmValEntry::voidArea.
970 * src/gdcmValEntry.cxx: unmatching comment wiped out.
971 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
972 Value representation between StringRepresentable and BinaryRepresentable.
973 * src/gdcmDocument.cxx:
974 - method ParseDES: proper indentation restored and usage of
975 gdcmVR::IsVROfGdcmStringRepresentable wired in.
976 - method LoadDocEntry: the fingerprint left in the SetValue() of
977 unloaded entries (length > MaxSizeLoadEntry) had curiously been
978 removed. Reverting to previous code segment with the proper
979 dynamic_cast< gdcmValEntry* >.
980 Note: this was (partially) breaking the python test suite
981 (gdcmPython/testSuite.py) that made usage of the above
982 fingerprint to check presence of "Pixel Data".
983 * src/gdcmDocEntry.h: coding style.
984 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
985 now taken into account.
986 * gdcmPython/gdcm.i: adaptation to the new internal representation
987 of gdcm (exit gdcmParser, hello gdcmDocument).
988 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
990 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
991 anymore, but instead prints the loaded Python dictionary.
992 * .... alas, the python testSuite is still broken.
994 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
995 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
997 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
998 * src/gdcmUtil.h : export methods
1000 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1001 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1003 * Initial addition of automatic python testing
1004 * Initial addition of automatic image comparison
1006 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1007 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1008 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1010 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1011 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1012 * Test/ShowDicom.cxx : bug fix for msvc compilation
1013 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1015 2004-05-04 Jean-Pierre Roux
1016 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1017 new concepts (and new classes) :
1018 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1019 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1020 - Sequence Doc Entries (gdcmSeqEntries)
1021 a Sequence is composed of Items.
1022 Each item is a set of Doc Entries (this is recursive)
1023 The non uniqueness of the 'Dicom tag' is due to this recursivity
1024 (never taken into account)
1025 Our unability to add a new 'entry' in the header
1026 at the proper location (neither in the H-Table (map or multimap),
1027 nor in the Chained List is also due to this recursivity.
1028 Don't try, right now, to use/modify/compile these new sources :
1029 nothing is finished.
1030 We just commit all the stuff, 'as is', in order not to loose it.
1032 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1033 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1035 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1036 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1037 file prefix (SetFilePrefix)
1039 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1040 * Add a new test: ShowDicom, for now this is just the c++ version of
1041 checkRead.sh, later it will be able to compare the image read against a
1043 * Replace the DEBUG on the stack with a global entry in cmake interface:
1044 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1046 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1047 * Add an example subdir, with a real example on how to read + write a
1050 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1051 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1052 * Doc/CMakeLists.txt: the main page is now properly differentiated
1053 between the developper and user version.
1054 * Doc/doxygen.config.in: dropped search related obsolete flags
1055 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1057 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * DEVELOPPER: added some helpfull comments for compile/test/install
1061 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1062 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1063 src directory, now generated in the build dir.
1064 2. Tests as mentionned smarter
1066 4. Add a new method in gdcmDict that return the PubDict by name
1067 this is interesting for 3rd party lib like ITK,
1068 where we could set the institution name / patient name...
1070 * ENH: 1. Now the test suite is working for real
1071 2. All binaries are now output in the gdcm-bin directory
1072 (this was not true before)
1074 2004-04-28 Jean-Pierre Roux
1075 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1076 SeQuence indented printing of Dicom Header.
1077 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1078 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1079 Computation of SQDepthLevel is now part of gdcmHeader constructor
1080 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1081 tree-like structure of a Dicom Header.
1082 * FIX Test code cleaning
1084 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1085 * ENH: Adding automatic testing
1086 1. Need a DartConfig.cmake to submit to public
1087 2. Add a test driver gdcmTest.cxx
1088 3. gdcmTestMain, an helper for the main test driver gdcmTest
1089 4. Files in Test don't have a main anymore, this becomes interesting
1090 when we add more and more tests, thus dsw don't have to load
1092 * ENH: Adding a GDCM_DATA_ROOT for testing
1093 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1094 one file instead of seven + some small cleanup
1096 2004-04-22 Jean-Pierre Roux
1097 * ENH Minor changes to the Print() methods.
1098 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1099 Header printing. Example given with :
1100 > PrintHeader fileName 2 new
1101 (SQ based tree-like structure still to be done for the Header ...)
1103 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1104 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1105 1. I have added some unsigned where needed
1106 2. Some function parameter not used -> (void)
1107 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1108 4. g++ don't like character '\' in comment
1109 5. #define jpeg_create_decompress jCreaDecompress
1110 this really need to be fixed
1111 6. virtualize destructor of gdcmObject ... leakage
1112 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1113 this also really need to be fixed
1114 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1115 remove compression file
1116 (as we only do decompression, right ?)
1117 * ENH: Change malloc/calloc/free with c++ equivalent
1119 2004-04-21 Jean-Pierre Roux
1120 * FIX gdcmHeaderHelper::GetXSpacing
1121 when a single value is found (bug ?), xpacing is now
1122 defaulted to yspacing
1124 2004-04-19 Jean-Pierre Roux
1125 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1126 * ENH add parameters :
1127 bool exception_on_error = false,
1128 bool enable_sequences = false,
1129 bool ignore_shadow = false
1130 to the gdcmFile constructors to be full gdcmParser compliant
1131 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1132 to allow reading of PAPYRUS 3.0 files
1134 2004-04-06 Jean-Pierre Roux
1135 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1137 2004-04-02 Jean-Pierre Roux
1138 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1139 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1140 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1142 2004-03-30 Jean-Pierre Roux
1143 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1144 for ACR file, written out as DICOM files (hope so...)
1146 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1148 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1149 moved to base class gdcmParser and only the specialisation is kept
1151 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1152 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1153 already does the job.
1154 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1155 (to be consistent with gdcmParser::WriteEntries).
1157 2004-03-30 Benoit Regrain
1158 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1159 upate of the object's instance. It's passed to 2 in the unfavorable
1160 case : one in the ExecuteInformation, one in the ExecuteData
1162 2004-03-29 Jean-Pierre Roux
1163 * ENH : Check on file type to be written moved
1164 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1165 * FIX : gdcmObject::ResetBoundaries now stops properly
1166 when end-of-list is reached
1167 : gdcmVersion modified (as Benoit Regrain asked)
1169 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1170 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1171 * src/gdcmUtil.cxx: added forgotten iostream include.
1172 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1173 equivalent to ExplicitVR in existing code).
1175 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1176 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1177 now contains all the gdcmGlobal related code.
1178 * minor coding style and doxygenation changes.
1180 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1181 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1182 now contains all the Debug related code.
1183 * minor clean-up of includes in src/*.cxx
1184 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1185 CreateCleanString) removed.
1186 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1187 * Doc/DoxyMainPageUser.txt added.
1188 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1189 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1190 src/gdcmDirList.cxx)
1192 2004-03-24 Jean-Pierre Roux
1193 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1195 2004-03-23 Jean-Pierre Roux
1196 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1197 big endian made volumes
1198 * ENH Now gdcmParser constructor and destructor are protected to forbid
1199 end user to instanciate class gdcmParser
1200 (only gdcmHeader and gdcmDicomDir are meaningfull)
1202 2004-03-22 Benoit Regrain
1203 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1204 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1205 gdcmSerie to gdcmDicomDirSerie
1207 2004-03-19 Jean-Pierre Roux
1208 * ENH Now the tree-like structure describing a DICOMDIR comming from
1209 an already existing DICOMDIR file is consistent with
1210 the home-made tree-like structure build ex-nihilo
1211 or build from the files held (recursively) in a Directory
1212 functions gdcmDicomDir::CheckBoundaries()
1213 gdcmObject::SetBoundaries() added
1215 2004-03-17 Jean-Pierre Roux
1216 * REM (Eric Boix bug) : removal of meaningless
1217 gdcmDicomDirImage::NewImage function.
1218 * FIX now file names and directory name are written properly in the
1220 * FIX now gdcmDicomDir constructor may be call without any trick
1223 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1225 of gdcmDicomDirImage::NewImage as empty function.
1227 2004-02-28 Jean-Pierre Roux
1228 * ENH add gdcmDicomDir:NewPatient
1229 add gdcmDicomDirPatient:NewStudy
1230 add gdcmDicomDirStudy:NewSerie
1231 add gdcmDicomDirSerie:NewImage
1232 to allow making gdcDicomDir object.
1233 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1234 (as opposite to the gdcmHeader chained list)
1236 2004-02-11 Benoit Regrain
1237 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1238 when using from python
1240 2004-02-10 Benoit Regrain
1241 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1242 * FIX : in gdcmDicomDir when the directory is empty
1243 * ENH : add callback and methods to get the progression of dicomDir
1246 2004-02-06 Jean-Pierre Roux
1247 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1248 - GDCM_META added to gdcmDicomDirType
1249 - class gdcmMeta created
1250 * ENH : - A brief summary is now displayed at the beginning of
1251 'testDicomDir' to help disaster magnitude estimation
1252 * REM : Now useless Test/explDICOMDIR.cxx
1254 2004-02-05 Benoit Regrain
1255 * ENH : add methods in gdcmObject to get the hash table or the list of
1257 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1258 * FIX : wrapping python for TagHeaderEntryHT
1260 2004-02-04 Benoit Regrain
1261 * FIX : even length for some strings when writting the dicom dir
1262 * FIX : sort the images in the dicom dir
1263 * FIX : Bug fix for python use of dicom dir
1264 * ADD : a python demo
1266 2004-02-04 Jean-Pierre Roux
1267 * FIX : Final solution (?) for icone embedded images
1268 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1269 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1270 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1271 gdcmData/gdcm-MR-SIEMENS-16.acr1
1272 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1273 to make full checking easier
1275 2004-02-04 Benoit Regrain
1276 * FIX : WriteEntries : coding style & logic in parameters
1277 * FIX : Set the elements to create the DicomDir in a dictionary file
1279 2004-02-03 Benoit Regrain
1280 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1281 * gdcmDicomDir : add the load of directory
1282 * Bug fix and print add-on
1284 2004-02-03 Jean-Pierre Roux
1285 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1286 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1287 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1288 * FIX gdcmParser.cxx : 'group length' elements are now considered
1289 as integers, even for shadow groups, when file is Implicit VR
1291 2004-02-02 Jean-Pierre Roux
1292 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1294 of the last synonym :-(
1295 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1297 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1298 * FIX taking into account the possible 7fe0,0010 multiplicity
1299 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1300 to allow removal of references to 7fe0,0010, to deal with
1301 ACR-NEMA images, when 0028,0200 is meaningfull
1303 2004-01-31 Jean-Pierre Roux
1304 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1305 no longer writes 'Un' on disk
1306 * FIX SQ elements with actual length are now dealt with corectly
1307 * FIX gdcmFile::WriteBase make the difference, for color images, between
1308 the length (for Palette expanded images)
1309 and Raw Length (non expanded image + Palette)
1310 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1311 (that broke Write). Replaced by UL.
1312 Aware user will reload the field if he
1313 thinks it's necesssary
1315 2004-01-30 Jean-Pierre Roux
1316 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1317 when 'dirty Acr' is found, to be compliant with the new
1318 IsReadable() methods.
1320 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1321 (no DOUBLE images in kosher DICOM,
1322 but so usefull for people that miss them ;-)
1324 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1325 DICOMDIR related utilities (not checked as Windoze compliant)
1327 2004-01-28 Jean-Pierre Roux
1328 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1330 2004-01-27 Jean-Pierre Roux
1331 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1332 to allow skipping the shadow elements, to save memory space.
1333 The TRUE value for this param has to be used
1334 with a FALSE value for the 'enable_sequence' param.
1335 ('public elements' may be embedded in 'shadow Sequences')
1336 * gdcmHeader methods now deal with 'embedded icones images' in the header
1337 (even when an 'icone image sequence' is announced by the
1338 element (0x0088,0x0200), but there is NO icone at all ...
1340 * gdcmHeader sometimes Image Location value doesn't follow
1341 the supposed processor endianity (see gdcmData/cr172241.dcm).
1344 * gdcmHeader add the method
1345 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1346 to get *all* the Header Entries with the same tag.
1347 GetHeaderEntrySameName is probabely *useless*
1348 (no meaning : Name is *not* an identifier within the Dictionnary)
1350 2004-01-26 Benoit Regrain
1351 * Bug fix in the print of hexadecimal representations. Remove long fields
1352 in the print and add a third level of print to print them
1354 2004-01-23 Benoit Regrain
1355 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1356 * Bug fix on test suite after remove the strip made on not string fields
1357 * Split the IsReadable method between gdcmParser which test that the file
1358 is dicom and gdcmHeader which test that it's an image file
1360 2004-01-22 Benoit Regrain
1361 * DicomDir : clean code, add methods, set variables in protected or private
1362 * gdcmUtil : bug fix for the clean string method
1364 2004-01-19 Benoit Regrain
1365 * Add the use of shadow dictionaries
1366 * bug fix and coding style
1368 2004-01-19 Benoit Regrain
1369 * src/gdcmFile.cxx : bug fix concerning the close of file
1370 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1371 * Add the update of header entries using the shadow library
1373 2004-01-19 Benoit Regrain
1374 * removal of file gdcmHeader2.cxx
1375 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1376 inheriting from gdcmParser. This split is to prepare the integration
1377 of dicom dir parsing
1378 * bug fix under python
1380 2004-01-16 Jean-Pierre Roux
1381 * REM removal of class gdcmHeaderEntrySet
1382 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1383 * ADD add file gdcmHeader2.cxx
1384 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1386 2004-01-15 Benoit Regrain
1387 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1388 entries created while parsing the header. Thus, they will be destroyed
1389 when the gdcmDictSet will be destroyed
1390 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1393 2004-01-15 Benoit Regrain
1394 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1395 made a fatal error because of the memory release at the end of program.
1396 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1397 some memory and vtk seems to have some problems with that.
1398 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1400 2004-01-14 Benoit Regrain
1401 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1402 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1403 * src/*.[h|cxx] : make changes due to class name changes
1404 * gdcmPython/demo/*.py : bug fix due to method names
1406 2004-01-13 Benoit Regrain
1407 * src/*.[h|cxx] : coding style
1408 * vtk/*.[h|cxx] : coding style
1410 2004-01-13 Benoit Regrain
1411 * gdcmPython/testSuite.py : test the readable flag of file for tests
1412 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1413 It's lied to the stl compilation by MSVC (windows, always windows...)
1414 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1416 2004-01-12 Benoit Regrain
1417 * src/*.h : add comments
1418 * src/gdcmDictSet.h : set the method BuildDictPath in public
1419 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1420 directly setted in the source code
1421 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1424 2004-01-09 Benoit Regrain
1425 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1426 * setup.py : use a reference to gdcmVERSION
1428 2004-01-07 Benoit Regrain
1429 * Modification to compile with the distutils.
1432 2003-12-10 Benoit Regrain
1433 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1434 can use a gdcmHeaderHelper to load datas
1435 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1436 made in the source code
1438 2003-12-10 Benoit Regrain
1439 * Update Windows projects and .cvsignore files
1441 2003-11-12 Jean-Pierre Roux
1442 * ENH gdcmHeader constructor has one more parameter (default value : false)
1443 that allows the user to 'go inside' the SeQuences only
1445 gdcmElValSet:Print takes it into account
1447 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1448 * ENH: Update gdcmPython/CMakeLists
1449 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1450 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1452 2003-11-10 Jean-Pierre Roux
1453 * FIX : gdcmHeader::LoadElements is now based
1454 on the ListTag listElem member,
1455 not longer on the TagElValueHT tagHt member
1456 * ENH : PrintPubElVal shows (temporarily) both results,
1457 with the tagHt member and the listElem member.
1458 (it's easier to 'see' the problems when using Printheader)
1460 * FIX : old private member LgrElem is now splitted into
1461 ReadLength : Length actually found on disk (updated only
1462 if bug fixing is necessary), for internal
1464 UsableLength : Updated by FixFoundLength, to fix a bug
1465 or to allow Parser going on.
1466 Will allow to re-write a kosher header when a SeQuence
1467 with a length (not 0000) is found
1468 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1469 because gdcmElValSet::Add does not update ListElem
1472 2003-11-07 Jean-Pierre Roux
1473 * FIX misstyping in Transfert Syntax name table
1474 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1475 when they have an actual length (not 0000 nor FFFFF)
1476 (Nobody should care of it, but DICOMDIR explorers)
1478 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1479 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1481 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1482 * ENH: vtkGdcmReader now supports LUT !
1483 (vtkgdcmViewer for now is not able to use them though)
1485 2003-11-05 Jean-Pierre Roux
1486 * in testSuite.py : new files names for checking the package
1487 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1488 that returns the pixel area size to the *aware* (vtk) user
1489 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1491 2003-11-05 Benoit Regrain
1492 * in testSuite.py : Modify the rules for checking the paths
1493 : Explicit error messages
1494 * in __init__.py : Related modif
1496 2003-11-03 Jean-Pierre Roux
1497 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1498 to be used by aware (vtk) users that want to manage
1499 LUT (and no to turn the PALETTE image into an RGB pixels one)
1500 * GetPixelType now returns 8U for 24 Bits images
1501 (vtkGdcmReader compliant)
1503 2003-10-31 Jean-Pierre Roux
1504 * Removal of *all* gdcmData images and add them again
1505 in order to loose the 'history' of un-anonymised images
1507 2003-10-31 Jean-Pierre Roux
1508 * RMV : removal of useless jBitsInJsample.h
1509 for both 8 and 12 Bits JPEG Lossy Libraries
1511 2003-10-31 Jean-Pierre Roux
1512 * ENH : Add the functions gdcmFile::GetImageDataRaw
1513 gdcmFile::GetImageDataIntoVectorRaw
1514 that act as GetImageData and GetImageDataIntoVector
1515 except the making of an RGB Plane from Gray Plane + LUT
1516 Intended to aware (vtk) users who know how to manage
1519 GetLUTRGBA return a R,G,B,A LUT if any
1520 lgrTotaleRaw gives the 'Raw' length
1521 GetImageDataRaw returns the gray Plane
1522 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1523 (They stay Grey, just like with other Dicom viewers :-(
1525 2003-10-30 Jean-Pierre Roux
1526 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1528 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1529 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1530 being coherents dicom files.
1532 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1533 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1535 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1536 * ENH: Two steps is necessary to please VC++ compiler...
1537 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1538 * ENH: Add include dir to medcon lib
1539 * FIX: only one function is being exported for now !
1540 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1542 2003-10-29 Jean-Pierre Roux
1543 * adding gdcmHeader::GetLUTRGBA
1544 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1545 --> Mathieu, the modif u're waiting for is not yet committed
1546 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1548 2003-10-27 Jean-Pierre Roux
1549 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1550 00191113.dcm DermaColorLossLess.dcm
1551 MxTwinLossLess.dcm RadBWLossLess.dcm
1552 * ENH: For version prior to vtkImageViewer2 -r 1.19
1553 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1555 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1556 * Removal of ido stuff in CMakeLists.txt
1558 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1559 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1560 * FIX: remove a call to ->Modified ... see comments
1561 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1563 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1564 * FIX: Problem with path for libvtkgdcmPython
1565 * ENH: Try adding a search script for python site-package
1566 * RMV: Remove some file from medcon lib that are not necessary
1567 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1568 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1569 * FIX: More pragma disable fro VC++,
1570 I don't think I break something as it is also disable in VTK/ITK.
1571 But it fasten debug compilation time.
1573 2003-10-23 Jean-Pierre Roux
1574 * gdcm now deals with 16 Bits Run Length Encoded images
1575 (they are compressed as 2 planes images,
1576 one for the high Bytes, the other for low Bytes)
1578 2003-10-22 Jean-Pierre Roux
1579 * Now CheckRead takes into account :
1580 - the bugged 'Leonardo' Siemens images
1581 - the XA images, sent thru the burning VPRO station
1582 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1585 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1586 * FIX: When copying a Makefile.am to CMakeLists.txt
1587 one should remove the '\'
1589 2003-10-22 Jean-Pierre Roux
1590 * in gdcmData adding a bugged 'Leonardo' Siemens image
1591 (wrong lengths in header)
1592 OK with gdcm, KO with the other viewers :-)
1593 * add a GE dlx XA image, thru the VEPRO burning station
1596 2003-10-21 Jean-Pierre Roux
1597 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1598 for a brutal checking of vtkgdcmViewer compliance
1600 2003-10-21 Jean-Pierre Roux
1601 * add the files for 'xmedcon' Jpeg Lossless library
1602 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1604 2003-10-21 Jean-Pierre Roux
1605 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1607 2003-10-21 Jean-Pierre Roux
1608 * garbage Siemens 'Leonardo' images dealt with
1609 (the patch is easy to remove)
1610 * cosmetic changes to avoid warnings
1612 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1613 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1614 no need to press 'r' now.
1616 2003-10-20 Jean-Pierre Roux
1617 * upgrade of checkRead.sh checkWrite.sh according
1618 to new Jpeg Lossless decompressor
1619 * add US.3405.1.dcm, a genuine RGB medical file ...
1620 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1621 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1623 2003-10-15 Jean-Pierre Roux
1624 * general anonymisation in gdcmData
1625 * adding the 'color files' from
1626 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1627 * adding some well knowed bugged-header images
1628 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1629 waiting for their inclusion in Python testsuite
1631 2003-10-15 Jean-Pierre Roux
1632 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1633 no longer seg faults when file is not found
1635 2003-10-14 Jean-Pierre Roux
1636 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1639 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1640 * TODO: *.in file to genereate a UseGDCM later
1642 2003-10-14 Jean-Pierre Roux
1643 * Some supposed-to-be Dicom Images have no preamble.
1644 OpenFile takes it into account
1645 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1646 * Missing elements added in dicomV3.dic
1647 (just to be affraid : have a look at
1648 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1649 and do it again next year ;->
1651 2003-10-13 Jean-Pierre Roux
1652 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1653 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1654 But there are NOT. It's fixed !
1656 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1657 * FIX: "jpeglib.h" was not found on VC++
1658 * FIX: vtkgdcm was not being installed
1660 2003-10-10 Jean-Pierre Roux
1661 * ENH : OpenFile closes the file if it *really* doesn't look like
1662 an ACR-NEMA / DICOM one.
1663 * FIX : testWrite no longer writes an empty file if the source file
1664 is not gdcm Readable
1665 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1668 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1669 * FIX: CMake generate now documentation
1670 * ENH: out of source doc build !
1671 * ENH: Generate both user and dev documentation
1672 * ENH: Should work on windows too
1673 * ENH: Only one doxygen config.in file is needed
1674 * FIX: make install should be ok now on ùnix plateform
1675 * FIX: PATH to dictionary was wrong (missing /)
1676 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1678 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1679 * vtkGdcmReader is now able to read rgb dicom file.
1680 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1681 * added a gdcmViewer to vtk test, use mouse to control
1682 window level & window width
1684 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * CMake-ification of gdcm, we have now two build system
1686 * FIX: on cygwin Wsock32 doesn't exist
1687 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1689 2003-10-06 Emanuel Ollart
1690 * FIX : compilation process wad broken.
1691 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1693 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1694 * change gdcmViewer -> vtkgdcmViewer
1695 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1697 2003-10-06 Jean-Pierre Roux
1698 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1699 ( e.g : well known GE images with a wrong elem length,
1700 : Philips MRI Images with a wrong Huffman table)
1701 * still to be done : allow the reading of bugged LEONARDO Siemens images
1703 2003-10-03 Jean-Pierre Roux
1704 * Odd length strings are padded with '\0' (not with spaces,
1705 to remain compliant with already defined strings,
1706 like Transfert Syntax UID and others)
1708 2003-10-03 Jean-Pierre Roux
1709 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1710 to allow displaying RGB images (not only by affim ;-)
1712 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1713 * vtkGdcmReader is now able to read rgb dicom file.
1714 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1716 2003-10-03 Jean-Pierre Roux
1717 * A few nasty patches to allow the reading of a lot of nasty images
1718 ( e.g : well known GE images with a wrong elem length,
1719 : Philips MRI Images with a wrong Huffman table)
1720 * still to be done : allow the reading of bugged LEONARDO Siemens images
1722 2003-10-03 Jean-Pierre Roux
1723 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1725 2003-10-03 Jean-Pierre Roux
1726 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1727 to allow displaying RGB images (not only by affim ;-)
1729 2003-10-03 Jean-Pierre Roux
1730 * gdcmFile::GetImageDataIntoVector now
1731 - deals with MultiFrames MultiFragments Run Length Encoded files
1732 - deals with YcBcR (YBR_FULL) files
1733 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1734 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1736 (no sample found :-(
1738 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1739 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1740 Two reasons: - clear things
1741 - third parties acces gdcm through header files, so won't
1742 suffer anymore VC++ complains
1744 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1745 * add argv[1] in testvtkGdcmReader.cxx
1748 2003-09-24 Jean-Pierre Roux
1749 * The lines are now eigthy characters long.for
1750 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1752 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1753 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1754 char* to std::string. Thus, the use of strdup becomes useless. (see
1755 previous commis of Malaterre)
1756 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1757 before the last Malaterre's commit.
1759 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1760 * This commit should fix the Debug building under VC++, the problem
1761 was mainly a mixture of debug and release lib being loaded at startup.
1762 * I also remove a depency to a specific C function: strdup. Because I had
1763 to force the link to msvcrtd (whereas strdup is in libc).
1765 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1766 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1767 located in the gdcmCommon.h file. All use of reference of tha has been
1768 changed to now use the variable GDCM_UNFOUND.
1770 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1772 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1773 Dicom dictionary. The test suite can now be run again. Note:
1774 I'm note very happy with the " (RET)" changes. I believe this
1775 RETAINED comment should be dropped when parsing the dictionary.
1776 - PACKAGER corrected
1778 - AUTHORS updated and now in alphabetical order
1779 * Makefile.am now exports gdcm.dsw for Windoze users.
1781 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1782 * cygwin complains about missing std:: in subdir Test/
1784 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1785 * remove some methods that are now in gdcmHeaderHelper
1787 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1788 * vtkGdcmReader set spacing and origin correctly
1790 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1791 * Fix a few delete/delete[] mismatch
1793 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1794 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1795 interpretation to data given by gdcmHeader. For instance there are
1796 heuristics to get informations (look at different places).
1797 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1798 sorting DICOM images based on different strategies.
1799 * modified Makefiles accordingly.
1801 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1803 when building in debug mode
1804 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1805 src/win32/gdcmdll.dsp
1806 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1808 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1809 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1812 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1813 * src/win32/libgdcmjpeg12.dsp was not dos format
1814 * src/win32/libgdcmjpeg12.dsp :
1815 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1816 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1818 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1819 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1821 * src/gdcmFile.cxx : bug fix in affectation type
1822 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1823 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1824 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1825 symbols... future problem ?
1827 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1828 * src/win32/libgdcmijpeg12.dsp was missing
1829 * modified gdcm.dsw accordingly
1831 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1832 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1834 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1835 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1836 commit of JPR (before his hollidays to facilitate our work).
1837 * setup.py : bug fix in code. Modifications made while the last commit
1838 of JPR. The code hasn't been tested before the commit... it's so
1839 useless to make that (for best programmer that is JPR) !!!
1841 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1842 * tagged the current version as Version0_3 (i.e. version 0.3)
1844 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1845 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1846 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1847 * *.dsp : modifications to use new libgdcmijpeg8 library
1848 * setup.py : bug fix on VTKPATH variable
1849 * PACKAGER : adding all concerning windows
1851 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1852 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1854 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1855 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1856 test suite reported error.
1857 * PACKAGER file added (describes what a packager must do when
1858 packaging a new release).
1859 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1860 * configure.in: upgraded version number to 0.3.0
1861 * fixing build of rpm (through rpm -ta):
1862 - Doc/Makefile.am exports proper doxygen files
1863 - src/jpeg/libijg8/Makefile.am exports the include files.
1865 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1866 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1867 * src/gdcmHeader.h : formatting code
1869 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1870 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1871 We were obtaining error message from vtk. Now, creation of file list
1872 is made in an internal list to prevent this problem.
1873 Bug fix when output is empty.
1874 Bug fix in update of progress value. Previous commit for this was a bad
1876 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1878 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1879 * src/gdcmHeader.h : added method to get the file name
1880 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1881 files. Added method to remove all files on the input
1882 Added FIXME comment concerning the bad parsing of header made by
1883 ExecuteInformation method (in ExecuteData method)
1885 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1886 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1887 when using make instal.
1888 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1889 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1891 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1892 * setup.py : adding include dir of jpeg lib to compile all sources
1893 * */Win32/*.dsp : JPR fix for windows compilation
1895 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1898 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1899 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1901 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * setup.py is again effective on un*x (takes into account the
1903 addon of the jpeg library)
1904 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1905 * Doc/Doxy* updated (includes above enhancements)
1906 * INSTALL now points to web documentation
1908 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1909 * src/gdcmHeader.h doesn't make unnecessary reference to
1911 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1913 * src/gdcm*.[cxx|h] :
1914 - to allow compilation with gcc 3.x
1915 -- clean up of STL usage (added explicit usage of std::)
1916 -- small fixes on exceptions.
1917 Note: linking not tested !
1918 - clean of doxygen comments to avoid warnings at documentation
1920 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1921 dependent convertion).
1923 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1924 * Clean up of previous JPR garbage commit (not even commented in the
1926 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1927 - moved all jpeg related files from src to src/jpeg/libijg8, with
1928 addition/modification of Makefile.am and configure.in.
1929 - the testSuite is still brain damage (not guilty).
1931 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1932 * WrapVTK.py : modifications to get correctly vtk source files to
1934 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1935 (FileName -> Filename)
1937 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1938 * vtk/vtkGdcmReader.[cxx/h]:
1939 - UpdateProgress method should now be effective
1940 - removed the limitation on having only images loaded (as opposed
1942 - when building a stack of images/volume, a lesser number of
1943 gdcmHeader and gdcmFile instances should be used (hopefully
1944 accelerating things).
1945 - when building a stack of images/volumes, files which are not
1946 loadable (wrong path-filename, wrong permissions on existing file,
1947 or file not parsable by gdcm) are replaced with a black image
1948 in the stack (for the caller to notice the problem).
1950 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1953 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1954 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1955 between standard library (std) and vtk library (problems are found
1956 under Windows... thanks Windows !)
1958 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1961 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1963 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1964 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1966 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1967 * When compiling with distutils (see setup.py) the C++ compiler is
1968 called with different flags than the default ones (with automake).
1969 In order to fix all those warning, I compiled gdcm with the command
1970 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1971 and went for warning fixes:
1972 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1973 up from unused variables.
1974 - vtk/vtkGdcmReader.cxx: potential bug fix.
1975 * src/gdcmHeader.h: Doxygen warning cleanup
1977 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * gdcmPython/gdcm.i:
1979 - typemaps correction to take into account the systematic replacement
1980 of "using namespace std" with std:: prefix e.g. std::list,
1981 std::string... (cf changes of 2003-05-21).
1982 - gdcmGlob global variable of type gdcmGlobal (defined in
1983 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1984 exported to Python a as cvar.
1985 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1986 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1987 gdcmDictSet.GetPubDictTagNames() and
1988 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1989 C++ static methods).
1990 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1991 with the above changes.
1993 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1994 * setup.py, manifest.in : bug fix under linux
1996 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1997 * Modification of setup.py to compile vtk part too. Then, we have 2
1998 wrappers which must work with same distutils. For that, we have a
1999 generic distutils in distusiltsWrapping.py ; with :
2000 - build_extWrap class to wrap generically all extensions,
2001 - ExtensionWrap base class for all wrapping extension that contains
2003 - Wrapper interface which wrap sources
2004 + In WrapSwig.py we have extension and wrapper for Swig
2005 + In WrapVTK.py we have extension and wrapper for VTK
2006 * MANIFEST.in : modifications to consider vtk directory and new python
2007 files for compilation
2009 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2010 * Added python wrappers of vtkGdcmReader vtk class (see the
2011 source in vtk/vtkGdcmReader.cxx) :
2012 - vtk/Makefile.am now builds a library
2013 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2014 python library (as opposed to _gdcm.so wich are the python
2015 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2016 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2018 - configure.in has an additional flag --enable-vtk that needs
2019 to be set to enable compilation of vtk related code, that is:
2020 + vtk/vtkGdcmReader.so and
2021 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2022 + gdcmPython/vtkgdcmPython.so (see above)
2023 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2024 be read when compressed or when HighBit + 1 != BitsStored),
2025 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2026 the usage of the python wrapper of vtkGdcmReader vtk class.
2027 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2028 * src/*.[h] all occurences of stl classes are now prefixed with
2029 std::, and all occurences of "using namespace std;" where removed.
2030 This is to avoid pollution of global namespace in included files.
2031 Apparently vtk does not avoid this pitfall: when using both
2032 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2033 collision of various stl members (principally cout...).
2034 * gdcmPython/testSuite.py now cleanly removes temprory generated
2036 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2037 comply with above changes)
2039 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2040 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2041 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2042 vtk data structure (an image Flip was required).
2043 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2044 * cosmetic changes in documentation.
2046 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2047 * src/gdcmHeader.cxx: the constructor no longer exits when an
2048 unexisting file is given as argument.
2049 * The subdirectory Data (containing all the images used for the
2050 test suite) is not part of this repository anymore. A new module
2051 containing those images is now available at
2052 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2053 with the name gdcmData.
2054 All the python scripts (including the package initialisation file
2055 gdcmPython/__init__.py) were adapated to take this change into
2056 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2058 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2059 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2060 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2061 demo of the usage of this class.
2062 Compilation of this vtk part is only done when using the --enable-vtk
2063 at configure (or autogen.sh) stage.
2065 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2066 * More memory link related corrections and documentation fixes.
2068 - maximum info is obtained with a command of the form:
2069 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2070 --show-reachable=yes PrintHeader
2071 - the remaining reachable blocks seem to come from the STL
2072 allocation scheme through the usage of map and list. It looks
2073 like this memory cannot be freed but it is not a memory leak
2074 (in fact further invocation to the STL would recollect the
2075 unused memory allthough it cannot explicitely be freed).
2076 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2077 of displaying an image parsed with gdcm and displayed with VTK.
2078 Note: some images don't seem to work e.g.
2079 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2080 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2081 Allthough this weakens the semantics, it is a ditch attempt to
2082 make gdcm more thread friendly.
2084 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2085 * Memory link hunt (by using valgrind through the command
2086 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2087 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2088 gdcmHeader::_dicom_vr.
2089 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2090 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2092 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2094 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2095 * src/Makefile.am now exports all the necessary include files at
2099 * UpdateGroupLength replaced by new one
2102 * UpdateGroupLength re-written using H-Table
2103 (named UpdateGroupLengthNew untill checks are over)
2105 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2106 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2107 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2109 - gdcmHeader::GetPubElValSet removed.
2110 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2111 UpdateGroupLength, WriteElements, Write.
2112 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2113 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2114 carried the same semantics.
2115 - src/gdcmHeaderIdo.cxx changed accordingly.
2116 - gdcmFile::WriteBase now regroups all the codes from previous
2117 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2118 - enum FileType moved to gdcmCommon.h
2119 * src/gdcmHeader.cxx AddDefault trashed
2120 * gdcmGetXSize added
2121 * getimageDataSize now calls gdcmGetXSize
2122 * Test/*.cxx changed to agree with above changes
2124 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2126 (to avoid double call by end user).
2127 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2128 by end user, since gdcmHeader::gdcmHeader now handles it.
2130 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2131 * gdcm/Doc many doxygen changes:
2132 - Doxyfile now has two different versions, DoxyfileUsers that generates
2133 the html.users end users oriented documentation and
2134 DoxyfileDeveloppers that generates the html.developper developper
2135 oriented documentation.
2136 - README changed accordingly
2137 - requirement.txt removed (old design info moved to TODO).
2138 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2139 DoxyMainPage.txt, DoxyPython.txt provide more information.
2140 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2141 be updated by simply regenerating the docs with doxygen and copying
2142 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2143 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2144 all the tests in the form "if (<map>.count() >1)" were removed.
2145 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2146 ill-formed documentation sections.
2147 * src/gdcmHeader.cxx: ditto
2149 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2150 * setup.py fixed for un*x (needed macro for stdint.h)
2151 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2152 un*ces with sh-utils test utility.
2153 * gdcmPython/demo/test.py renamed to PrintHeader.py
2154 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2155 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2156 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2157 * src/gdcm*.cxx JPR's bad inclusion fixed.
2159 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2160 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2161 * gdcmPython/demo/test.py changed accordingly.
2163 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * gdcmPython/Makefile.am fixed linking against libstdc++
2165 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2166 * Swig subdir (historical tests of swig version 1.3.17++) removed
2167 * Test/testChangeEntete.cxx some lines commented out in order to make
2169 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2170 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2172 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2173 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2174 hence the user doesn't need this explicit call.
2175 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2176 i.e. LoadElements() call removed.
2177 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2178 - src/Makefile.am declares the proper flag for g++.
2179 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2180 for adding user defined new tags.
2181 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2182 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2183 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2185 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2186 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2187 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2188 src/Makefile.am : the project should properly compile and install
2189 with the autotools, included the python wrappers part.
2190 * gdcm.spec.in : added a spec file for RPM packaging.
2192 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2193 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2195 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2196 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2197 to exported to the environement (see gdcmPython/testSuite.py
2199 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2200 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2201 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2202 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2203 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2205 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2206 * gdcmPython/__init__.py doesn't crash anymore when running in
2207 in InstallMode or PreInstallMode but with an environement given
2208 value of GDCM_DICT_PATH.
2209 * src/gdcmDictSet.[cxx/h] coding style.
2211 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2213 * src/gdcm.h general comments moved to TODO, and README
2214 * src/gdcm.h should now be seen as a user commodity (including it
2215 should suffice to fully use gdcm). It is nowhere including within
2216 any of the kernel files src/*.cxx and src/*.h.
2218 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2220 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2222 * src/gdcm*.cxx only include their corresponding include file
2223 (as opposed to gdcm.h)
2224 * gdcmPython/gdcm.i changed accordingly
2225 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2226 the autogen.sh generated "make snapshot" command to work.
2227 * autogen.sh removed history related references to crea package.
2229 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2230 * distutilsSwigCPlusPlus.py work around some swig portability
2233 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2234 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2235 was done in a last ditch attempt to get setup.py _really_
2236 operationnal. The python/gdcmPython layaout add the advantage
2237 of hidding away the python related distutils specific files
2238 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2239 Alas, the src directory was out of scope (i.e. it's relative
2240 position to setup.py was ../src) which made things impossible to
2241 handle (see previous version of python/setup.py). Crossing fingers...
2243 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2244 * python/setup.py now works on Un*x. (harder than I thougth)
2245 * python/distutilsSwigCPlusPlus.py can now have include files
2246 among the list of sources.
2248 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2249 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2250 * modifications in MSVC projects
2252 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2253 * As stated by the first lines of Test/ExceptionAndPython/README, it
2254 looks like we can move back to original usage of exception within
2255 src/gdcm* and hence remove the errno stuff that was introduced
2256 as a quick and dirty fixture of this problem (added to the TODO).
2257 * Doc/Doxyfile configuration file for Doxygen and corresponding
2258 README file for usage added.
2259 * Test/testWrite.cxx added. This new test comes from a split of
2260 test.cxx that is now reverted to its original purpous i.e.
2261 testing the proper parsing of a Dicom related file.
2262 testWrite.cxx concentrates on testing the IO part of gdcm.
2263 * Test/bug1.cxx (containing a bug on WIn32) added.
2264 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2265 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2266 whose purpose is to publish the content of the TagNames of the
2267 Dicom public dictionnary were not accessible without an
2268 instance of class gdcmHeader.
2269 - those methods are now static methods of gdcmDictSet and hence
2270 require no instances at all to be invocated.
2271 - within gdcmDictSet this change required to change some method
2272 to class methods (i.e. are now static) among which SetDictPath
2273 (renamed to BuildDictPath) and LoadDefaultPubDict.
2274 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2275 the above changes by calling the new method classes of gdcmDictSet.
2276 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2277 the above to be effective.
2278 * python/gdcmPython: in order to wrap properly the above changes
2279 for Python, swig version now needs to be > 1.3.17.
2280 * python/gdcmPython/Makefile fixed to adapt itself to new
2281 configure/make shema introduced by Johan Montagnat (thanks for the
2282 contribution). Alas this Makefile cannot be turned into a proper
2283 Makefile.am without some heavy changes in the configure.in
2284 (for python dectection).
2285 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2286 now avoids publishing the empty entries.
2288 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2289 * python/setup.py : bug fix concerning install under windows
2290 ExtraPath reused :-P
2291 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2293 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2294 * Dicts/dicomV3.dic : remove double spaces !!!
2295 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2296 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2299 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2300 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2301 method. Doxygenation.
2302 * src/gdcm.h clean up of JPR spurious comments.
2304 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2305 * python/distutilsSwigCPlusPlus.py now properly collects the
2306 shadow classes generated by "swig -c++" (gdcm.py in our case)
2307 when using "python setup.py install".
2308 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2309 reexports the working classes.
2310 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2311 by the classical C errno scheme. This is to prevent an obscure
2312 behavior of the python wrappers when importing wxPython.wx prior
2313 to gdcmPython (which ended up in an abort call). An illustration
2314 of this oddity can be found in the Test/ExceptionAndPython
2315 subdir (see the README file). This problem probably due to
2316 an combination of g++ and dynamic loading.
2317 * added Test/ExceptionAndPython (see above)
2319 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2320 * Changed the layout of the python part to avoid bloating main
2321 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2322 i.e. the distutils arsenal. All the python related stuff is
2323 again in a python subdir, but the package itself is now in
2325 * setup.py was cleaned up:
2326 - pythonIncludePath removed
2327 - python setup.py bdist target is now functional.
2328 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2329 collision with other packages). gdcmPython/demo/*.py changed
2332 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2333 * python subdir moved to gdcmPython (preparation of distutils packaging).
2334 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2335 distutils installer is operational.
2336 * - gdcmPython/__init__.py now properly loads the swig generated
2337 shadow classes (from gdcm.py).
2338 - gdcmPython/demo/*.py changed to import the package gdcmPython
2339 instead of gdcmPython/demo/load.py.
2340 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2342 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2344 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2345 entries within the associated public Dicom dictionary resp. the same
2346 information but sorted by the fourth field (PAT, IMG, DIR) of the
2348 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2349 are now in the "???" group.
2350 - python/gdcm.i changed accordingly,
2351 - python/demo/printGroupedPublicDict.py added, that gives an example
2352 of the above new functionalities in Python.
2354 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2355 * src/gdcm.h, gdcmHeader.cxx:
2356 - historic references to glib's g_malloc and g_free (#defined)
2357 were definitively removed.
2358 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2359 * src/gdcmElValSet.cxx:
2360 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2361 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2362 - GetElValue(string) renamed to GetElValueByName.
2363 - Added GetElementByName(string).
2364 * src/gdcmHeader.cxx: added
2365 - GetPubElValRepByNumber(guint16, guint16)
2366 - GetPubElValRepByName(string)
2367 - GetShaElValRepByNumber(guint16, guint16)
2368 - GetShaElValRepByName(string)
2369 - GetShaElValByNumber(guint16, guint16)
2370 - GetShaElValRepByName(string)
2371 - GetElValRepByNumber(guint16, guint16)
2372 - GetElValRepByName(string)
2373 - GetElValByNumber(guint16, guint16)
2374 - GetElValRepByName(string)
2375 * Doc/requirements.txt added.
2377 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * Test/Makefile building now depends on the one of libgdcm.so
2379 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2380 pixel data) aware which enables finding the address (offset) of
2381 the pixel data of JPEG encoded DICOM files. This leaves only a single
2382 file in the testSuite whose pixel data address (offset) is unknown.
2383 * python/testSuite.py changed accordingly.
2385 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2386 * VC++ has some strong limitations when working with the STL, as stated
2387 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2388 "Also note that some STL containers (map, set, queue, list, deque)
2389 cannot be exported. [...]
2390 Some STL classes contain nested classes. These classes can not
2392 This is caused by a designed limitation that once a template
2393 class is instantiated, it can not be re-instantiated and
2395 Since our usage of map<> is ubiquitous in gdcm, this "designed
2396 limitation" of VC++ is a pitfall.
2397 Hence the Python wrappers of gdcm cannot be incrementally linked
2398 against the c++ dynamic library. The dirty but only workaround is
2399 to forget about incremental link of dynamic libraries and to generate
2400 the Python wrappers library with the inclusions of the underlying C++
2402 The following modifications concern this matter on Win32/VC++:
2403 - wrapping python correct with standalone wrapped dll (don't use separate
2404 dll under windows !!!!)
2405 - python21_d debug mode enabled (ask Frog how to use it :-)
2406 - NO problem with having an STL member of class for example string in C++
2407 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2408 - Python test of dcmlib in Python is ok under windows on a large set
2410 * removed glib references
2411 * typedef's inserted in gdcm.i for correct swig type management
2413 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * python/demo/*.py load.py extracted from test.py. Added explore.py
2415 that only displays required tags and testAll.py that parses all
2416 the files of the testsuite without using unittest.
2417 * python/testSuite.py other additional test on new files added.
2418 * Data/* new test files added accordingly to the testSuite.
2419 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2420 the vr in the file differs from the one of the dictionary.
2422 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2423 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2424 values, but limits itself to values which are below a user specified
2425 size (by default 1024 bytes).
2426 * python/gdcm.i : elements not loaded (because their size is above the
2427 user specified treshold) are exported with their TagKey as key of the
2428 python dictionary. This enables the testsuite to make some checks
2429 on the unloaded elements (since we have their offset and size).
2430 * python/testSuite.py
2431 - now tests for the existence and proper value of the pixel data
2432 - two new examples added.
2433 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2435 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2437 aware. See the strategy comments in gdcmHeader::FindeLength().
2438 * Test/test.cxx now accepts a filename as first argument.
2439 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2440 * python/testSuite.py changed to integrate test on above files.
2442 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2444 the vr was also RET.
2445 * python/testSuite.py more tests added.
2447 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * python/testSuite.py unittest test suite added (uses Data)
2449 * Data/* dcm and acr files for the test suite.
2450 * glib dependance removed from un*x version. We now use ISO C99
2451 7.18 Integer types (see stdint.h)
2452 - python/Makefile, src/Makefile src/gdcm.h
2453 * src/ when an explicit vr (like dicom files) suddenly poped an
2454 implicit element we use to mark the underlying DictEntry of the
2455 concerned ElValue with "Implicit". This strategy was damageable
2456 too the public or provite dictionaries, since some of their vr
2457 would be changed. Since Header::FindLength heavily relies on the
2458 detection by Header::FindVR of falsely explicit elements, I
2459 added an extra ImplicitVr member to ElValue (boolean).
2460 The rest of the changes we the necessary adaptations.
2462 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2463 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2465 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2467 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2468 * Adaptation for porting to VC++:
2470 o forced to use std namespace (for string to be known)
2471 o all class use __declspec export style on WIN32
2472 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2473 (in stdlib.h on Win32 but in std:: for gcc)
2474 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2475 variable GDCM_DICT_PATH.
2476 * src/gdcmHeader.cxx verbose comments made discrete.
2478 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * python/gdcm.i: added a typemap that converts a C++ hashing table
2480 to native Python dictionary.
2481 * python/demo/test.py:
2482 - now uses the native dictionary for exploration of gdcmHeader.
2483 - takes an optional filename argument (the file to parse).
2484 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2485 PubElVals hashing table.
2486 * Dicts/dicomV3.dic removed error prone trailing spaces.
2488 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * Python wrapping process moved away from src/Makefile to
2490 newly created python/Makefile (as well as gdcm.i)
2491 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2492 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2493 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2494 from the environement variable GDCM_DICT_PATH (when existing).
2495 * src/gdcmDict::GetTag bug fix.
2497 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * Straightforward temporary fixes for swig to build the python wrappers.
2499 src/Makefile now has a python working entry [by working we mean
2500 that we can import de shadow classes without errors].
2502 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2503 * hashtest.cxx removed (since allready in Test)
2504 * src/gdcmlib.h renamed to src/gdcm.h
2505 * src/dcm.i renamed to src/gdcm.i
2506 * src/Makefile prepared for python wrapping
2508 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2509 * src/gdcmHeader.cxx :
2510 - Parsing of header is now separated from loading of element values
2511 (see gdcmHeader::LoadElements).
2512 - general clean up of hopefully all file access (creation of
2513 ReadInt16 and ReadInt32)
2515 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2516 * src/gdcmHeader.cxx :
2517 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2519 - SetLgrElem renamed to SetLength
2520 - GetLgrElem renamed to GetLength
2521 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2522 * src/gdcmElValSet.cxx fixed both GetElValue methods
2523 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2524 due to IdoDude was cleaned out.
2526 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2527 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2528 concentrates on finding the value representation (when it exists).
2529 RecupLgr now only finds the element value length, and it avoids
2530 returning the unecessary skL (skipped length).
2531 Also, offsetCourant was simply removed (with taille_fich) since
2532 it was redundant with the File position internals (by using
2533 ftell and fseek). This also made skL (see above in RecupLgr) usage
2535 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2536 on the libido specificities which are handled through class
2538 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2541 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * Truckload of changes. Parsing of header is barely functional
2543 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2545 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2546 * src/gdcmHeader.cxx many addons of low level methods
2548 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2549 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2550 and _IdDcmSWAP_LONG.
2552 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2553 * This corresponds to all the changes decided at the meeting of
2554 May 23 2002. Needless to say we are running late...