1 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * distutilsSwigCPlusPlus.py work around some swig portability
5 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
6 * Eventually, python/gdcmPython was renamed to gdcmPython. This
7 was done in a last ditch attempt to get setup.py _really_
8 operationnal. The python/gdcmPython layaout add the advantage
9 of hidding away the python related distutils specific files
10 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
11 Alas, the src directory was out of scope (i.e. it's relative
12 position to setup.py was ../src) which made things impossible to
13 handle (see previous version of python/setup.py). Crossing fingers...
15 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
16 * python/setup.py now works on Un*x. (harder than I thougth)
17 * python/distutilsSwigCPlusPlus.py can now have include files
18 among the list of sources.
20 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
22 * modifications in MSVC projects
24 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * As stated by the first lines of Test/ExceptionAndPython/README, it
26 looks like we can move back to original usage of exception within
27 src/gdcm* and hence remove the errno stuff that was introduced
28 as a quick and dirty fixture of this problem (added to the TODO).
29 * Doc/Doxyfile configuration file for Doxygen and corresponding
30 README file for usage added.
31 * Test/testWrite.cxx added. This new test comes from a split of
32 test.cxx that is now reverted to its original purpous i.e.
33 testing the proper parsing of a Dicom related file.
34 testWrite.cxx concentrates on testing the IO part of gdcm.
35 * Test/bug1.cxx (containing a bug on WIn32) added.
36 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
37 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
38 whose purpose is to publish the content of the TagNames of the
39 Dicom public dictionnary were not accessible without an
40 instance of class gdcmHeader.
41 - those methods are now static methods of gdcmDictSet and hence
42 require no instances at all to be invocated.
43 - within gdcmDictSet this change required to change some method
44 to class methods (i.e. are now static) among which SetDictPath
45 (renamed to BuildDictPath) and LoadDefaultPubDict.
46 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
47 the above changes by calling the new method classes of gdcmDictSet.
48 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
49 the above to be effective.
50 * python/gdcmPython: in order to wrap properly the above changes
51 for Python, swig version now needs to be > 1.3.17.
52 * python/gdcmPython/Makefile fixed to adapt itself to new
53 configure/make shema introduced by Johan Montagnat (thanks for the
54 contribution). Alas this Makefile cannot be turned into a proper
55 Makefile.am without some heavy changes in the configure.in
56 (for python dectection).
57 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
58 now avoids publishing the empty entries.
60 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * python/setup.py : bug fix concerning install under windows
63 * gdcm.dsw : bug fix concerning path for libraries for python !!!
65 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * Dicts/dicomV3.dic : remove double spaces !!!
67 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
68 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
71 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
72 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
74 * src/gdcm.h clean up of JPR spurious comments.
76 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
77 * python/distutilsSwigCPlusPlus.py now properly collects the
78 shadow classes generated by "swig -c++" (gdcm.py in our case)
79 when using "python setup.py install".
80 * python/gdcmPython/__init__.py imports gdcm.py and only manually
81 reexports the working classes.
82 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
83 by the classical C errno scheme. This is to prevent an obscure
84 behavior of the python wrappers when importing wxPython.wx prior
85 to gdcmPython (which ended up in an abort call). An illustration
86 of this oddity can be found in the Test/ExceptionAndPython
87 subdir (see the README file). This problem probably due to
88 an combination of g++ and dynamic loading.
89 * added Test/ExceptionAndPython (see above)
91 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
92 * Changed the layout of the python part to avoid bloating main
93 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
94 i.e. the distutils arsenal. All the python related stuff is
95 again in a python subdir, but the package itself is now in
97 * setup.py was cleaned up:
98 - pythonIncludePath removed
99 - python setup.py bdist target is now functional.
100 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
101 collision with other packages). gdcmPython/demo/*.py changed
103 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * python subdir moved to gdcmPython (preparation of distutils packaging).
105 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
106 distutils installer is operational.
107 * - gdcmPython/__init__.py now properly loads the swig generated
108 shadow classes (from gdcm.py).
109 - gdcmPython/demo/*.py changed to import the package gdcmPython
110 instead of gdcmPython/demo/load.py.
111 - gdcmPython/testSuite.py changed to import the package gdcmPython.
114 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
115 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
116 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
117 entries within the associated public Dicom dictionary resp. the same
118 information but sorted by the fourth field (PAT, IMG, DIR) of the
120 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
121 are now in the "???" group.
122 - python/gdcm.i changed accordingly,
123 - python/demo/printGroupedPublicDict.py added, that gives an example
124 of the above new functionalities in Python.
126 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
127 * src/gdcm.h, gdcmHeader.cxx:
128 - historic references to glib's g_malloc and g_free (#defined)
129 were definitively removed.
130 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
131 * src/gdcmElValSet.cxx:
132 - GetElement(guint32, guint32) renamed to GetElementByNumber.
133 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
134 - GetElValue(string) renamed to GetElValueByName.
135 - Added GetElementByName(string).
136 * src/gdcmHeader.cxx: added
137 - GetPubElValRepByNumber(guint16, guint16)
138 - GetPubElValRepByName(string)
139 - GetShaElValRepByNumber(guint16, guint16)
140 - GetShaElValRepByName(string)
141 - GetShaElValByNumber(guint16, guint16)
142 - GetShaElValRepByName(string)
143 - GetElValRepByNumber(guint16, guint16)
144 - GetElValRepByName(string)
145 - GetElValByNumber(guint16, guint16)
146 - GetElValRepByName(string)
147 * Doc/requirements.txt added.
149 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
150 * Test/Makefile building now depends on the one of libgdcm.so
151 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
152 pixel data) aware which enables finding the address (offset) of
153 the pixel data of JPEG encoded DICOM files. This leaves only a single
154 file in the testSuite whose pixel data address (offset) is unknown.
155 * python/testSuite.py changed accordingly.
157 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
158 * VC++ has some strong limitations when working with the STL, as stated
159 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
160 "Also note that some STL containers (map, set, queue, list, deque)
161 cannot be exported. [...]
162 Some STL classes contain nested classes. These classes can not
164 This is caused by a designed limitation that once a template
165 class is instantiated, it can not be re-instantiated and
167 Since our usage of map<> is ubiquitous in gdcm, this "designed
168 limitation" of VC++ is a pitfall.
169 Hence the Python wrappers of gdcm cannot be incrementally linked
170 against the c++ dynamic library. The dirty but only workaround is
171 to forget about incremental link of dynamic libraries and to generate
172 the Python wrappers library with the inclusions of the underlying C++
174 The following modifications concern this matter on Win32/VC++:
175 - wrapping python correct with standalone wrapped dll (don't use separate
176 dll under windows !!!!)
177 - python21_d debug mode enabled (ask Frog how to use it :-)
178 - NO problem with having an STL member of class for example string in C++
179 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
180 - Python test of dcmlib in Python is ok under windows on a large set
182 * removed glib references
183 * typedef's inserted in gdcm.i for correct swig type management
185 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
186 * python/demo/*.py load.py extracted from test.py. Added explore.py
187 that only displays required tags and testAll.py that parses all
188 the files of the testsuite without using unittest.
189 * python/testSuite.py other additional test on new files added.
190 * Data/* new test files added accordingly to the testSuite.
191 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
192 the vr in the file differs from the one of the dictionary.
194 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
195 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
196 values, but limits itself to values which are below a user specified
197 size (by default 1024 bytes).
198 * python/gdcm.i : elements not loaded (because their size is above the
199 user specified treshold) are exported with their TagKey as key of the
200 python dictionary. This enables the testsuite to make some checks
201 on the unloaded elements (since we have their offset and size).
202 * python/testSuite.py
203 - now tests for the existence and proper value of the pixel data
204 - two new examples added.
205 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
207 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
208 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
209 aware. See the strategy comments in gdcmHeader::FindeLength().
210 * Test/test.cxx now accepts a filename as first argument.
211 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
212 * python/testSuite.py changed to integrate test on above files.
214 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
215 * Dicts/dicomV3.dic removed all the trailing (RET) when the
217 * python/testSuite.py more tests added.
219 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
220 * python/testSuite.py unittest test suite added (uses Data)
221 * Data/* dcm and acr files for the test suite.
222 * glib dependance removed from un*x version. We now use ISO C99
223 7.18 Integer types (see stdint.h)
224 - python/Makefile, src/Makefile src/gdcm.h
225 * src/ when an explicit vr (like dicom files) suddenly poped an
226 implicit element we use to mark the underlying DictEntry of the
227 concerned ElValue with "Implicit". This strategy was damageable
228 too the public or provite dictionaries, since some of their vr
229 would be changed. Since Header::FindLength heavily relies on the
230 detection by Header::FindVR of falsely explicit elements, I
231 added an extra ImplicitVr member to ElValue (boolean).
232 The rest of the changes we the necessary adaptations.
234 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
237 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
239 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
240 * Adaptation for porting to VC++:
242 o forced to use std namespace (for string to be known)
243 o all class use __declspec export style on WIN32
244 - src/gdcmUtil.cxx new Exit method that wraps the exit call
245 (in stdlib.h on Win32 but in std:: for gcc)
246 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
247 variable GDCM_DICT_PATH.
248 * src/gdcmHeader.cxx verbose comments made discrete.
250 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
251 * python/gdcm.i: added a typemap that converts a C++ hashing table
252 to native Python dictionary.
253 * python/demo/test.py:
254 - now uses the native dictionary for exploration of gdcmHeader.
255 - takes an optional filename argument (the file to parse).
256 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
257 PubElVals hashing table.
258 * Dicts/dicomV3.dic removed error prone trailing spaces.
260 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * Python wrapping process moved away from src/Makefile to
262 newly created python/Makefile (as well as gdcm.i)
263 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
264 * src/gdcmHeader::FindLength only looks for current vr when necessary.
265 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
266 from the environement variable GDCM_DICT_PATH (when existing).
267 * src/gdcmDict::GetTag bug fix.
269 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
270 * Straightforward temporary fixes for swig to build the python wrappers.
271 src/Makefile now has a python working entry [by working we mean
272 that we can import de shadow classes without errors].
274 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * hashtest.cxx removed (since allready in Test)
276 * src/gdcmlib.h renamed to src/gdcm.h
277 * src/dcm.i renamed to src/gdcm.i
278 * src/Makefile prepared for python wrapping
280 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
281 * src/gdcmHeader.cxx :
282 - Parsing of header is now separated from loading of element values
283 (see gdcmHeader::LoadElements).
284 - general clean up of hopefully all file access (creation of
285 ReadInt16 and ReadInt32)
287 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * src/gdcmHeader.cxx :
289 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
291 - SetLgrElem renamed to SetLength
292 - GetLgrElem renamed to GetLength
293 - ~gdcmHeader() made virtual to pesky warning messages at compile.
294 * src/gdcmElValSet.cxx fixed both GetElValue methods
295 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
296 due to IdoDude was cleaned out.
298 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
300 concentrates on finding the value representation (when it exists).
301 RecupLgr now only finds the element value length, and it avoids
302 returning the unecessary skL (skipped length).
303 Also, offsetCourant was simply removed (with taille_fich) since
304 it was redundant with the File position internals (by using
305 ftell and fseek). This also made skL (see above in RecupLgr) usage
307 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
308 on the libido specificities which are handled through class
310 * Test/implicit_vr.dcm dicom v3 in implicit value representation
313 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * Truckload of changes. Parsing of header is barely functional
315 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
317 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * src/gdcmHeader.cxx many addons of low level methods
320 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
324 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * This corresponds to all the changes decided at the meeting of
326 May 23 2002. Needless to say we are running late...