1 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
3 remove a DocEntry in the header (push an empty DocEntry)
4 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
5 lines. Bug fix in the initialization of the PixelConvert and the
7 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
8 use in TestCopyDicom (now this test can run under windows... but fails)
9 * Test/TestCopyDicom.cxx : amelioration of the test :
10 - test the pixels written
11 - add test points to quickly find where is the error
12 - can set a file name input and output in arguments
13 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
14 amelioration of the test output
16 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
18 all replaced DocEntry's
19 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
20 Now, each needed DocEntry to modify is duplicated, modified and inserted
21 to the header using DocEntryArchive. Thus, after save, we can restore the
24 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
27 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
29 correct to copy it. The DictEntry is specified at the DocEntry creation,
30 then, it musn't change in the time.
31 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
32 header correctly. At this time, the change is only made for the first
33 level of the Document. In the future, it might consider sequences.
34 The change is made by replacing a DocEntry by an other that is created
35 outside the class. The old value is kept. When we restore the header
36 status, the added DocEntry is deleted and replaced by the old value.
37 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
38 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
39 set the write type to explicit VR, implicit VR or ACR. Add methods to set
40 the write mode to native, decompressed or RGB (but not used at this time)
42 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
44 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
46 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
48 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
50 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
51 set because already copied when copying the BinEntry's of the header
52 * Test/TestAllReadCompareDicom.cxx : remove warnings
54 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
56 Two problems appear when doing it :
57 - with the gdcmFile : when the GetImageData method is called, the pixels
58 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
59 datas (pixels). And each structure destruct the datas when it's
60 destructed. So we have two destructions for the same datas. To solve it,
61 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
62 datas or not. If it doesn't own datas, then they will not destroyed by
64 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
65 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
66 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
67 create a double destruction of the same DocEntry's. So, to solve it,
68 the TagHT is simply cleared and the DicomDir* elements are destroyed.
69 * TODO : add an entry concerning memory leaks in the DicomDir
71 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
73 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
76 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
78 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
79 after it have been deleted
81 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
82 * FIX: src/* fix the doxygen warnings.
83 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
84 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
85 was erroneously defined with a size of 15 instead of 16. [many thanks
86 to Jean Michel Rouet for pointing out this bug].
88 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
89 1. Finish merging JMR patch for writting DICOM from scratch
90 2. Fix -hopefully- bug with MONOCHROME and space vs null character
91 3. Use const ref when possible
92 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
93 5. A few more comments
94 6. CreateUniqueUID can now be called without parameter"
96 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
97 * ENH: Slightly bigger patch:
98 1. Getting toward full integration of JMR patch for writting dicom from scratch
99 2. Update Test to test part of this patch: CreateUniqueUID
100 3. File was not close properly in gdcmDict
101 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
102 5. Use of const ref instead of copy (speed issue)
103 6. Remove temporary (duplicate) string in TranslateToKey
104 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
105 8. Do not repeat virtual in subclasses
106 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
108 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
109 * Apply first patch toward better string comparison when dealing with broken
110 DICOM files. Essentially the string could be padded with a space instead
111 of a null character as defined by standard
113 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
115 because never used... and in the same time, that's remove some memory leaks
117 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * src/gdcmFile.cxx : now delete the PixelConvert instance.
119 * In examples and tests : change the type of image data variables from void*
120 to uint8_t*. Remmove all delete on image data variables
122 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
124 Verify the file pointer value before open the file, and if it's not null,
125 a verbose message is generated.
126 Close correctly the file when the file isn't considered dicom-like. The
127 correctly close is a call to CloseFile.
128 When closing the file pointer, test if its not null to close the file.
129 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
130 file. For an uncompressed image, the copied datas correspond in the least
131 case to the image size (calculated) or the image size specified in the
132 header. A verbose is generated if these two size mismatch
134 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
136 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
137 break under windows (with msvc6 compilation).
139 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
141 compiling with MSVC6)
143 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * Bugs fix for the Windows build with VC6
145 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
146 needed (only for projects required VTK). If the VTK is included in all
147 projects, there is conflicts with the jpeg lib of vtk when compiling the
148 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
149 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
150 when compiling the gdcm_wrap.cxx file (created by the compilation of the
152 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
153 (like it's already made for the cout use). Otherwise, conflict with the
156 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
159 - comments on the DicomDir::Method related usage added.
160 - now that we use the namespace gdcm, a lot of internal classes do
161 NOT need to be wrapped anymore.
162 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
163 DicomDir::Method) new example added.
165 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
166 * Improve string manipulation. I now inforce the notion of 'DicomString'
167 A DicomString can contain as many \0 as they want
168 and it is *always* of even length.
169 We only support odd length for very rare case.
170 And in the near future this should be removed.
172 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
173 * /binary_write/ gdcm source. Now even on big endian we are writting
174 little endian. This should -heopfully- fix some tests
176 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
177 * Now the dictionary is compiled into gdcm lib. This is a default
178 behavior, thus any dic file specified is picked before failback to
179 the one comiled into lib
181 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
182 * Change internals for gdcmDict. Don't use any 'new' any more.
183 This should definitely solve any leak problem, and we should be
184 as fast as before, as long as don't modify too much the dictionary.
186 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
187 * STYLE: ivars should start with a capital letter.
188 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
189 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
191 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
193 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
194 new 2004 dictionaries added (thanks to JPR).
195 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
196 * CLEANUP_ROUND (15) for gdcmPixelConvert
197 - RLEFrame::NumberFragments is now of type unsigned int
198 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
199 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
202 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
203 * Initial work in gathering all transfer syntax accessors. clearly
204 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
205 ivars, but only one transfersyntax (class) ivar with equivalent method on
208 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
209 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
210 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
211 discussed (plus I didn't like having a 2000 lines patch not commited)
213 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
215 * CLEANUP_ROUND (14) for gdcmPixelConvert
216 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
217 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
218 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
220 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
221 anymore and hence avoids storing a copy of PixelConvert::Decompressed
222 into File::Pixel_Data.
224 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
226 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
227 * CLEANUP_ROUND (13) for gdcmPixelConvert
228 Substituted File::ParsePixelData() with PixelConvert::Print() new
230 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
231 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
232 method to those classes.
233 - src/gdcmFile.[cxx|h]:
234 -- Added a ::Print() method.
235 -- PixelConverter is now a reference instead of a member.
236 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
237 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
239 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
240 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
241 collaboration diagram and inheritance diagram should be generated with
243 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
244 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
245 pointlessly wrapped (see
246 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
247 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
248 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
249 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
250 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
251 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
252 -- File::Initialise: PixelConverter setup moved away to
253 PixelConverter::GrabInformationsFromHeader()
254 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
255 interpretation moved away to PixelConverter::BuildRGBImage()
257 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
259 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
261 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
262 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
263 displayed on Win32 when a brutal abort() occurs (because of uncatched
264 exception). See TODO new entry of this commit for more on this.
265 * TODO added new entry.
266 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
267 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
268 - HandleColor is no longer called from gdcmFile.cxx
269 - gdcmPixelConvert.cxx clean up on method arguments and internal
270 variable names for semantical coherence.
272 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
273 * Finished lossless transition, not only do we now read all lossless jpeg
274 images, without the need of the Cornwell lib, but we do read them properly now
275 * To reduce code (well to avoid code duplication), I defined a common place
276 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
277 redefine symbols. This is not prefect but this the best solution I found for a
278 compilation time jpeg option.
280 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
281 * Update jpeg ijg lib to support lossless jpeg implementation
282 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
284 * Also added a special copyright for dcmtk since we use their bugfixes.
287 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
289 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
290 matters, as stated in warning note at begining of %include section).
291 * src/gdcmDicomDir*.[cxx|h]: coding style
292 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
293 * src/gdcmJpeg8.cxx: doxygen fix.
294 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
295 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
296 from File:: to PixelConvert::.
298 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
299 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
300 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
301 - more code moved away from File:: to PixelConvert::
302 - fat setup of PixelConverter set in place in File::Initialise.
304 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
305 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
306 namespace at the file system level. So now you should convert your examples
308 gdcmHeader -> gdcm::Header
309 It would be nice if people keep in mind to no open the namespace, since it
310 allows compilation on broken plateform which were defining common symbol in
311 the standart namespace (like LP, Unknown ...)
313 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
315 The JPEG fragments are now parsed at the same stage than the RLE
316 information. All code related to JPEG is now in gdcmPixelConvert:
317 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
318 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
319 export a gdcmFile:: method. Those are simply global functions
320 (for the time being this is better than having them attach to
321 either gdcmFile:: or gdcmPixelConvert::).
322 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
323 and stores the result in a gdcmJPEGFragmentsInfo.
324 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
325 code (among other stuff) moved away from gdcmFile:; to
328 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
329 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
330 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
331 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
332 clean up of RLE related code.
333 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
334 - src/gdcmRLE.cxx removed
335 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
336 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
337 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
338 * CLEANUP_ROUND (9) for gdcmPixelConvert
339 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
340 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
341 away from gdcmFile:: to gdcmPixelConvert::.
343 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
344 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
345 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
346 This is because Parse7Fe0 used to parse the pixels to compute the
347 length. This task was passed over to FindDocEntryLengthOB() a long
348 time ago, EXCEPT I had forgotten the OW case...
349 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
350 we just recylce the code for parsing RLE fragments and computing
352 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
353 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
354 with the retired Parse7Fe0().
355 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
356 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
358 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
360 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
361 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
362 - src/CMakeLists.txt: alphabetic order reodering + new entries.
363 * CLEANUP_ROUND (4) for gdcmPixelConvert
364 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
365 to return an unused length.
367 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
368 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
369 this should be cleanner from the plane view. The iostream are erally a pain
370 to use to do simple stuff.
372 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
373 * Redo the compilation of the ijg jpeg library. Now only one source is
374 necesseray. No need to rename file by hand what so ever. CMake handle the
375 copying of the file within different directory, configure header file to
376 modify some symbol. The only addition made to ijg wasd a mangle table so
377 that symbol are different wether we are within 8bits or 12bits.
379 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
380 * Added documentation of vtkgdcmReader on Website:
381 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
382 with it's binary name).
383 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
384 the Website to be more complete.
385 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
386 doxygenated documentation.
387 - Doc/DoxyVtkGdcmReaderExamples.txt added
388 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
389 DoxyVtkGdmReaderExamples.html )
390 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
391 * CLEANUP_ROUND (3) for gdcmPixelConvert
392 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
394 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
395 * CLEANUP_ROUND (2) for gdcmPixelConvert
396 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
398 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
399 * CLEANUP_ROUND for gdcmPixelConvert:
400 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
401 - src/gdcmPixelStuff[h|cxx] removed
402 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
403 - src/CMakeLists.txt changed accordingly
405 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
406 gdcmVersion.py moved to newly created ATTIC related
407 gdcmPython/SetupOldies/ directory.
408 * Autotools clean up:
409 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
410 - autogen.sh configure.in acinclude.m4 python.m4 removed
412 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
413 * src/*.cxx *.h Reference to License.htm fixed to License.html.
414 * Doc/CMakeLists.txt, doxygen.config.in: fix.
415 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
417 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * TODO updated with Mathieu suggestions. I proposed a template for
419 describing TODO entries and used it for new entries.
420 * Added Doc/Website/CodingStyle.html, Developpers.html,
421 DeveloppersPython.html, GdcmDataCvs.html and
422 DownloadVersion0_1.html, DownloadVersion0_3.html.
423 * Some Doc/*.txt Doxygen files (which do not really concern the
424 documentation itself, but the website) moved to html and
425 placed in directory Doc/Website:
426 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
427 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
428 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
429 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
430 * CMakeLists.txt changed accordingly.
431 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
432 DeveloppersPython.html
433 * INSTALL nows refers to Doc/Website/Installation.html
435 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
436 * Added Doc/Website directory, that contains a first raw version
439 2004-09-23 Jean-Pierre Roux
440 * FIX In order not to be poluted any longer by casting problems,
441 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
442 we can now delete[] it safely
443 * VoidArea is now called BinArea (less confusing name),
444 and all the methods called ...VoidArea... are now ... BinArea...
445 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
447 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
449 clear) TagHT, which is an inherited member of gdcmElementSet. It is
450 up to the destructor of gdcmElementSet to clean up TagHt and it's
453 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
454 * Test/CMakeLists.txt: update to follow gdcmData renamings.
455 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
457 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
458 * ENH: added some utility method that builds a flat dictionnary
459 holding all the Dicom entries contained in the recursive structure
460 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
462 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
463 BuildFlatHashTable() that build a flat dictionary.
464 - src/gdcmElementSet.h: added a new private GetTag() accessor.
465 gdcmDocument is now a friend of gdcmElementSet.
466 - src/gdcmElementSet.cxx: clean up.
467 - Example/FlatHashTablePrint.cxx added.
468 - Example/CmakeLists.txt changed accordingly
470 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
471 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
472 moved away from gdcmDocEntrySet (since this class is an abstract class
473 acting like an interface). SQDepthLevel and BaseTagKey are now
475 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
476 and associated accessors. Doxygenation of the class.
477 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
479 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
480 Use SQDepthLevel accessor instead. ::Print() adapted.
481 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
482 - src/gdcmDocument.cxx changed accordingly.
484 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
485 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
486 - The following is the doxygen comment of the typedef declaration
487 of gdcmagKey in src/gdcmCommon.h:
488 gdcmTagKey is made to old an "universal" (as in URL, Universal
489 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
490 A dicom tag allways has a group and an element, but a set of tags
491 embeded in various (optionally nested) sequences and sharing
492 the same group and element all share the same (group, element)
493 "identifier". Hence the (group, element) cannot be used as an
494 identifier (in gdcm we shall refer to a "TagKey") of a tag.
495 In order to construct a proper tag identifier (i.e. a key) we
496 consider the following definition of a TagKey:
497 - let Group, Element be the string representation of the
498 group and element dicom tag members,
499 - let ItemNumber be the string representation of the integer
500 index of the considered item number of a sequence,
501 Let the key of a tag embeded in a sequence, noted SeqTag, be
503 /ItemNumber#Group|Element
504 where "/", "#" and "|" are characters acting as separators.
505 Then the general form of a gdcmTagKey is given by:
506 Group|Element<SeqTag>
507 where <SeqTag> means NO or many instances of SeqTag.
508 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
511 but the gdcmTagKey of a tag "embeded" is the first item of
512 a sequence, itself nested in the third item of a sequence is the
514 0004|1220/2#0008|0082/0#0008|0090
515 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
516 order to hold the new sequence compatible key. Previously, the
517 GetKey() method would look in the underlying gdcmDictEntry.
518 - src/gdcmDocEntry.cxx:
519 -- constructor now copies the underlying DictEntry key, in the local
521 -- ::Print: displays the member Key, instead of the (group, element).
522 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
523 - src/gdcmDocEntrySet.h:xi
524 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
525 -- now has a new BaseTagKey member.
527 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
528 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
530 This poses the problem with the semantics of the following lines
531 LoadEntryVoidArea(0x0028,0x1201); // R LUT
532 LoadEntryVoidArea(0x0028,0x1202); // G LUT
533 LoadEntryVoidArea(0x0028,0x1203); // B LUT
534 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
535 to the long FIXME note for what the problem is. Nevertheless in
536 order to get things working the dicom dictionary was altered !
537 Please fix things urgently...
538 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
539 information), see above note on moving the member VoidArea. Nevertheless
540 the following entries previously correctly set as US are now inproperly
542 0028 1201 OW IMG Red Palette Color Lookup Table Data
543 0028 1202 OW IMG Green Palette Color Lookup Table Data
544 0028 1203 OW IMG Blue Palette Color Lookup Table Data
545 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
546 of gdcmDocEntry moved to gdcmSeqEntry.
547 * src/gdcmSeqEntry.cxx: STYLE.
549 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
550 * Test/TestAllEntryVerify.cxx minor fix and added comments.
552 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * gdcmPython/testSuite.py: all the test suite in python is now moved
554 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
555 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
556 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
558 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
559 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
560 to avoid inclusion recursion until STL is reached.
561 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
562 mecanism. errno.h is not included in gdcm anymore.
563 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
564 (gdcmFormatError now inherits from gdcmFormatUnexpected).
566 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
567 gdcmData/TestAllEntryVerifyReference.txt
568 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
569 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
570 exception_on_error parameter.
571 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
572 - vtk/vtkGdcmReader.cxx changed accordingly,
573 - Example/*.cxx and Test/*.cxx changed accordingly.
575 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
576 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
577 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
578 enable_sequences removed from gdcmHeader constructor and dependencies.
579 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
580 * gdcmPython/demo/PrintHeader.py: dummy fix.
581 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
582 skip_shadow removed from gdcmHeader constructor and dependencies.
583 * Example/*.cxx and Test/*.cxx changed accordingly.
585 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
586 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
587 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
589 2004-07-21 Jean-Pierre Roux
590 * FIX Now, Parsing and Printing a DICOMDIR do work!
591 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
593 2004-07-20 Jean-Pierre Roux
594 * FIX Some brain damaged headers have Zero-Lenght fields
595 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
597 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
599 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
600 variable (instance of gdcmDebug) by a definition macro, and the instance
601 is now in static in the gdcmDebug class
602 * src/gdcmSQItem.h : (FIXME) remove an undefined method
603 * Test/PrintAllDocument.cxx : bug fix in the result of the test
605 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * WARNING: ctest now depends more tightly on gdcmData. You should
607 check out gdcmData properly for things to run smoothly...
608 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
609 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
610 we need the pixels not be loaded in order to use the ValEntry
611 that displays position and size).
612 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
613 This is a C++ based equivalent of gdcmPython/testSuite.py that should
614 be deprecated. If you have any doubts about the advantages of a
615 modern scripting language (read Python) versus grass root C++ (i.e.
616 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
617 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
618 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
619 Anyhow, consider documenting the gdcmData images in
620 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
622 * Test/CMakeLists.txt:
623 - now uses TestAllEntryVerify.cxx
624 - specific comments on oldACR00001.ima (now renamed in gdcmData
625 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
626 gdcmData/TestAllEntryVerifyReference.txt
629 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
630 * src/*.[h|cxx] : typedef clean up
631 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
632 - TagKey renamed to gdcmTagKey (for external usage)
633 - VRKey renamed to gdcmVRKey (for external usage)
634 - removal of typedef duplication.
635 - Removed all unecessary inline keyword from class inline definitions.
636 - Some method|function(void) declarations replaced with method|function().
637 * src/jpeg/libijg12/jdhuff12.c:
638 - printf polluting ctest removed.
639 - TAB removal for comminting
641 - TestAllReadCompareDicom.cxx: added a test that compares all the
642 images in gdcmDataImages.h with corresponding images in
643 gdcmData/BaselineDicom/. When baseline images are not present
644 this test creates them.
645 Note: we need to validate each reference image, but before that
646 I'd like to rename them with a more explicit name...
647 - CMakeLists.txt: changed accordingly.
648 * Example/*.cxx: examples now only include gdcm.h (as opposed to
649 including each header needed).
651 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
652 * Test/*.cxx and Example/*.cxx: moved some examples away from the
653 test suite to the Example directory. Are concerned:
658 - TestWriteSimple.cxx
659 * Test/CMakeLists.txt: added some comments on reasons for black listing
660 image gdcmData/oldACR00001.ima
662 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
663 * Test/CmakeList.txt: removed the following from black list (to be coherent
664 with removal from gdcmData):
665 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
666 - gdcm-MR-PHILIPS-16.dcm
668 Added the following because after last cvs update, they cause
669 ctest -R TestReadWriteReadCompare
671 - gdcm-MR-SIEMENS-16-1.acr
673 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
674 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
675 new comments in this file) we temporarily (sigh) move to a weaker
677 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
678 we don't need to black list the following images anymore:
679 - 8BitsUncompressedColor.dcm
681 - US-PAL-8-10x-echo.dcm
682 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
683 fixes and the beautified code ;-)
684 This fixes the bug introduced in version 1.42 (when beautifying)
685 that made the parsing of 8BitsRunLengthColor.dcm unproper.
686 Note: ctest was blind to this bug (this means we need to still
687 improve the test suite). The bug could be detected by using
688 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
690 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
691 and by displaying the (garbage) produced file temp.XDCM...
693 2004-06-29 Jean-Pierre Roux
694 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
695 - replace by uggly but working old code :-(
696 A lot of things should be OK again.
697 It's really urgent to have a test suite that *tests*,
698 to prevent Frog's beautifying sessions to break all the stuff
699 (twice, withing a fortnigh ...)
701 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
702 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
703 redundancy) to added Test/TestReadWriteReadCompare.cxx
704 * Test/CmakeList.txt: because the compare test of
705 Test/TestReadWriteReadCompare.cxx fails, the following images are
706 black listed: - 8BitsUncompressedColor.dcm
708 - US-PAL-8-10x-echo.dcm
709 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
710 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
711 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
712 and ad-hoc kludge. This kludge is now removed, and on encountering
713 such an image (OB field brain damaged) we set errno. Then in
714 ::FindDocLength() we "fix" the length as being ALL what remains
715 in the file (until EOF). We then proceed, hoping for the best...
716 This fixes a SegFault in ShowDicom when trying to write such an
718 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
719 (because TestWriteRead breaks on it, after a non conformal commit?).
720 ctest now runs properly, except for MakeDicomDir (which was allways
721 broken) and the Python related stuff (still not fixed).
723 2004-06-24 Jean-Pierre Roux
724 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
725 FIX : Test/TestReadWrite now iterates on all the file names
726 (instead of infinite loop)
727 ENH : Test/TestWriteRead now iterates on all the file names
729 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
730 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
732 2004-06-24 Jean-Pierre Roux
733 FIX : - now Write drops LUT Descriptors and LUTs (if any)
734 when SamplesPerPixel =3
735 - now Write is no longer confused by
736 'BitsAllocated = 12" and 'BitsStored=12"
737 - "UN" value representation Elements are now written correctly
738 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
739 ENH : - now gdcmHeader has its own Write methods
740 (in order to split the job that has not to be done
743 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
745 loop on the same image until memory went out.
746 Note: this means we still have gobs of memory loss in PrintDocument
747 * src/gdcmDocument.cxx: fixes problem on parsing on file
748 gdcmData/16BitsJpegLosslessGrayScale.dcm.
750 2004-06-24 Jean-Pierre Roux
751 FIX : Write - All the Sequences and Sequence Item are now written
752 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
753 is added a the end, when necessary.
754 - A lot of brain-damaged images, that were read correctly are
755 now written correctly
756 - length compatible BinEntry are now loaded correctly
757 (even for odd groups)
758 Note : only Explicit Value Representation was checked.
759 (question : is implicit VR really necessary for gdcm ?)
761 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * DEVELOPPER: added a proposition of coding style.
763 * src/gdcmDocEntry.h: removed every inline declaration (for test of
766 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
768 Use the gdcmDocEntry::Print() and Write() instead.
769 * src/gdcmDocument.cxx: bug fix.
771 2004-06-22 Jean-Pierre Roux
772 FIX : gdcmDocument.cxx
773 - Now we do recognize the JpegLossLess format (there was a misstyping in
774 code 'beautyfication' :-(
775 - Now we automaticaticaly load the Luts, if any
777 2004-06-22 Jean-Pierre Roux
778 In order : to write Sequences, whatever their imbrication level,
779 : to allow user to create his own Sequences
780 a lot of modif where necessary (adding, moving, or virtualising methods)
782 WARNING : save your own sources *before* cvs up !
785 ADD virtual void Write(FILE *fp, FileType filetype);
788 ADD virtual void Write(FILE *fp, FileType filetype);
789 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
792 ADD virtual void Write (FILE *fp, FileType filetype)=0;
793 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
794 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
795 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
796 ADD std::string GetEntryByName(TagName name);
797 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
799 std::string vr = "unkn",
800 std::string fourth = "unkn",
801 std::string name = "unkn");
802 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
803 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
804 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
805 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
806 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
807 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
808 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
809 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
812 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
813 ADD virtual std::string GetEntryByName (TagName tagName);
814 ADD virtual std::string GetEntryVRByName (TagName tagName);
815 REM virtual bool Write(FILE *, FileType);
816 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
817 FILE *_fp, FileType type);
818 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
819 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
820 REM virtual bool WriteEntries(FILE *_fp,FileType type);
821 REM virtual std::string GetEntryByName (std::string tagName);
822 REM virtual std::string GetEntryVRByName (std::string tagName);
823 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
824 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
825 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
827 std::string vr = "unkn",
828 std::string fourth = "unkn",
829 std::string name = "unkn");
830 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
831 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
832 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
833 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
836 ADD virtual void Write(FILE *fp, FileType filetype);
839 ADD virtual void Write(FILE *fp,FileType filetype);
842 ADD virtual void Write(FILE *fp, FileType filetype);
843 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
844 REM std::string GetEntryByNumber(guint16 group, guint16 element);
845 REM std::string GetEntryByName(TagName name);
848 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
850 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
851 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
852 The default constructor invoked by the line
853 gdcmHeader *f1 = new gdcmHeader( header );
854 was gdcmHeader::gdcmHeader(bool) instead of the expected
855 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
856 Hence the parsing wasn't executed... See also below.
857 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
858 as explicit constructor didn't do the trick to fix the above problem.
859 Could anyone explain why ?
860 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
861 properly calls gdcmValEntry::Print() (that was weed out from
862 code related to gdcmBinEntry).
864 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
865 * In order to fix memory leaks:
866 - Test/TestWriteSimple.cxx: added cleaning of free store through
868 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
869 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
870 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
871 (through the call to ::AddDicomDirMeta()) or the destructor
872 would crash when deleting uninitialized ::metaElems].
873 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
874 - src/gdcmDocument.cxx:
875 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
877 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
878 was causing memory leaks.
879 - src/gdcmSQItem.cxx:
880 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
881 cleanly handled with polymophism: sorry but my milage is low).
882 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
883 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
884 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
885 This avoids SegFaulting.
886 - src/gdcmSQItem.h: coding style.
888 - Test/TestWriteSimple still severely sucks. The output image content
889 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
890 damaged when displayed with vtkgdcmViewer.
891 - on memory leaks: TestWriteSimple leaks really less (see entry
892 of 2004-06-18 in Changelog file for the call to valgrind).
893 - on segfaults: ctest now passes all the tests but one (no more
895 * Erroneous leading white fix:
896 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
897 white[s] (as opposed to from >> xxx, that removes it [them].
898 - src/gdcmTS.cxx: ditto.
899 - gdcmPython/testSuite.py: dirty related kludge removed.
900 * src/*: remaining references to gdcmParser removed.
901 * src/*[cxx|h]: added copy[way]left header.
904 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
905 * In order to fix writing of dicom files:
906 - Test/TestWriteSimple.cxx: a simpler example of writing.
907 - Test/CMakeLists.txt changed accordingly.
908 - src/gdcmDocument.cxx:
909 -- The destructor now recursilvely removes potential sequences.
910 -- Bug fix in ::IsJPEG2000()
911 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
912 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
914 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
915 to only declared) and build on top of
916 ::GetDocEntryByNumber(guint16, guint16).
917 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
918 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
919 for usage in destructor and treatement of promotion in
920 ::ReplaceOrCreateByNumber().
921 - src/gdcmSQItem.cxx: destructor should better handle his job.
922 Test/TestWriteSimple now runs (or at least it DOES something).
923 * We can now start hutting memory links. A good starting point is:
924 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
925 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
926 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
928 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
929 * Valgrind note: after Mathieu Malaterre teached me how to read
930 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
932 Using gcc, you can force the STL to use malloc and to free memory as
933 soon as possible by globally disabling memory caching.
934 With 3.2.2 and later, you should export the environment variable
935 GLIBCPP_FORCE_NEW before running your program.
936 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
937 simply vanish (it is still not clear to me, whether this means that
938 STL std::string leaks or if valgrind believes it leaks...).
939 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
940 running bin/gdcmTests makeDicomDir):
941 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
942 - Test/makeDicomDir.cxx now properly traps empty lists and returns
944 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
945 SegFaulting (I drowned in DicomDir related code when trying to
946 understand why the list is empty...).
947 * src/gdcmDocument.h: first BSD license header try.
948 * Doc/License.txt added.
950 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * src/gdcmDocument.[h|cxx]:
952 - Clean up of the Transfer related predicates. They are now all based
953 on new method isGivenTransferSyntax, that (should) handle properly
955 - general clean up, simplification, and coding style.
956 - Specific clean up of Parse7FE0() (umproperly named actually).
957 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
959 2004-06-14 Jean-Pierre Roux
961 - fix the display of Sequence Delimitor (SQDepthLevel pb)
962 - fix the display of SQItem ordinal number
963 - add the GetSQItemByOrdinalNumber method
964 - remove some useless never written private methods
966 2004-06-14 Jean-Pierre Roux
968 - adding a constructor taking a gdcmDocEntry as an input param
969 - ReplaceOrCreateByNumber now returns :
970 a gdcmBinEntry * if a Binary (void *) value is passed as a param
971 a gdcmValEntry * if a string value is passed as a param
973 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
974 according to the param type (no longer sets a gdcmDocEntry)
975 - GetValEntryByNumber, GetBinEntryByNumber added
976 - NewValEntryByNumber and NewBinEntryByNumber added
978 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
980 - GetSQItemNumber and SetSQItemNumber added, to provide
981 a (relative) Item identier inside a given Sequence
982 \warning : some pb remaining around this number
984 - AddEntry now takes the Item Number as a param
986 - adding a constructor taking a gdcmDocEntry as an input param
988 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
989 * Memory leak hunt with the following command:
990 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
991 --show-reachable=yes gdcmTests PrintDocument
992 It looks like many (all?) leaks are due to the STL (or a bad usage
993 of the STL. The lines producing the leaks now have a comment with
994 a "MEMORY LEAK" tag: you can retrieve them with
995 grep "MEMORY LEAK" src/*
996 Here are two typical examples which I can't help fixing:
1001 char * test = "babo";
1002 name = test; //// <--- valgrind detects 960 bytes lost in
1003 //// call to std::string::operator=(char const*)
1004 name.clear(); //// Doesn't help !
1012 std::cout << "Type a bunch of characters followed by RETURN: ";
1013 getline(std::cin, line); //// <--- valgrind dectects a loss
1014 //// of 1320 bytes in call to
1015 /// std::basic_istream<>& std::getline<>
1021 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * src/gdcmHeader.[cxx|h]:
1023 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1024 and related, moved away to gdcmDocument.
1025 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1026 the corresponding protected accessors of inherited class
1027 gdcmDocument, removed ! As a consequence gdcmFile had to be
1028 declared friend of class gdcmDocument (see below).
1029 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1030 - Clean up of undefined or unused methods.
1031 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1032 account the changes to gdcmHeader.h).
1033 * src/gdcmDocument.h:
1034 - gdcmFile is now a friend class (in order to take into account the
1035 changes to gdcmHeader.h).
1036 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1037 (see changes to gdcmHeader.h).
1038 - Accessors (reading on the form GetEntry*) are now public.
1039 - Clean up of undefined or unused methods.
1040 * src/gdcmDocument.cxx:
1041 - adaptation to changes to gdcmDocument.h
1042 - ::OpenFile now writes a verbose message when file cannot be opened.
1043 - some std::string properly set to VRKey
1044 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1045 references to gdcmDocument.
1046 * Test/TestFindTags.cxx: changed accordingly to above changes.
1047 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1048 cvs repository gdcmData.
1050 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1051 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1052 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1053 conflicts with gdcmValEntry::voidArea.
1054 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1055 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1056 Value representation between StringRepresentable and BinaryRepresentable.
1057 * src/gdcmDocument.cxx:
1058 - method ParseDES: proper indentation restored and usage of
1059 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1060 - method LoadDocEntry: the fingerprint left in the SetValue() of
1061 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1062 removed. Reverting to previous code segment with the proper
1063 dynamic_cast< gdcmValEntry* >.
1064 Note: this was (partially) breaking the python test suite
1065 (gdcmPython/testSuite.py) that made usage of the above
1066 fingerprint to check presence of "Pixel Data".
1067 * src/gdcmDocEntry.h: coding style.
1068 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1069 now taken into account.
1070 * gdcmPython/gdcm.i: adaptation to the new internal representation
1071 of gdcm (exit gdcmParser, hello gdcmDocument).
1072 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1074 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1075 anymore, but instead prints the loaded Python dictionary.
1076 * .... alas, the python testSuite is still broken.
1078 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1079 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1081 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1082 * src/gdcmUtil.h : export methods
1084 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1085 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1087 * Initial addition of automatic python testing
1088 * Initial addition of automatic image comparison
1090 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1091 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1092 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1094 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1095 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1096 * Test/ShowDicom.cxx : bug fix for msvc compilation
1097 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1099 2004-05-04 Jean-Pierre Roux
1100 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1101 new concepts (and new classes) :
1102 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1103 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1104 - Sequence Doc Entries (gdcmSeqEntries)
1105 a Sequence is composed of Items.
1106 Each item is a set of Doc Entries (this is recursive)
1107 The non uniqueness of the 'Dicom tag' is due to this recursivity
1108 (never taken into account)
1109 Our unability to add a new 'entry' in the header
1110 at the proper location (neither in the H-Table (map or multimap),
1111 nor in the Chained List is also due to this recursivity.
1112 Don't try, right now, to use/modify/compile these new sources :
1113 nothing is finished.
1114 We just commit all the stuff, 'as is', in order not to loose it.
1116 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1117 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1119 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1120 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1121 file prefix (SetFilePrefix)
1123 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1124 * Add a new test: ShowDicom, for now this is just the c++ version of
1125 checkRead.sh, later it will be able to compare the image read against a
1127 * Replace the DEBUG on the stack with a global entry in cmake interface:
1128 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1130 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1131 * Add an example subdir, with a real example on how to read + write a
1134 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1135 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1136 * Doc/CMakeLists.txt: the main page is now properly differentiated
1137 between the developper and user version.
1138 * Doc/doxygen.config.in: dropped search related obsolete flags
1139 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1141 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1142 * DEVELOPPER: added some helpfull comments for compile/test/install
1145 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1146 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1147 src directory, now generated in the build dir.
1148 2. Tests as mentionned smarter
1150 4. Add a new method in gdcmDict that return the PubDict by name
1151 this is interesting for 3rd party lib like ITK,
1152 where we could set the institution name / patient name...
1154 * ENH: 1. Now the test suite is working for real
1155 2. All binaries are now output in the gdcm-bin directory
1156 (this was not true before)
1158 2004-04-28 Jean-Pierre Roux
1159 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1160 SeQuence indented printing of Dicom Header.
1161 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1162 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1163 Computation of SQDepthLevel is now part of gdcmHeader constructor
1164 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1165 tree-like structure of a Dicom Header.
1166 * FIX Test code cleaning
1168 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1169 * ENH: Adding automatic testing
1170 1. Need a DartConfig.cmake to submit to public
1171 2. Add a test driver gdcmTest.cxx
1172 3. gdcmTestMain, an helper for the main test driver gdcmTest
1173 4. Files in Test don't have a main anymore, this becomes interesting
1174 when we add more and more tests, thus dsw don't have to load
1176 * ENH: Adding a GDCM_DATA_ROOT for testing
1177 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1178 one file instead of seven + some small cleanup
1180 2004-04-22 Jean-Pierre Roux
1181 * ENH Minor changes to the Print() methods.
1182 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1183 Header printing. Example given with :
1184 > PrintHeader fileName 2 new
1185 (SQ based tree-like structure still to be done for the Header ...)
1187 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1188 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1189 1. I have added some unsigned where needed
1190 2. Some function parameter not used -> (void)
1191 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1192 4. g++ don't like character '\' in comment
1193 5. #define jpeg_create_decompress jCreaDecompress
1194 this really need to be fixed
1195 6. virtualize destructor of gdcmObject ... leakage
1196 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1197 this also really need to be fixed
1198 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1199 remove compression file
1200 (as we only do decompression, right ?)
1201 * ENH: Change malloc/calloc/free with c++ equivalent
1203 2004-04-21 Jean-Pierre Roux
1204 * FIX gdcmHeaderHelper::GetXSpacing
1205 when a single value is found (bug ?), xpacing is now
1206 defaulted to yspacing
1208 2004-04-19 Jean-Pierre Roux
1209 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1210 * ENH add parameters :
1211 bool exception_on_error = false,
1212 bool enable_sequences = false,
1213 bool ignore_shadow = false
1214 to the gdcmFile constructors to be full gdcmParser compliant
1215 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1216 to allow reading of PAPYRUS 3.0 files
1218 2004-04-06 Jean-Pierre Roux
1219 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1221 2004-04-02 Jean-Pierre Roux
1222 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1223 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1224 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1226 2004-03-30 Jean-Pierre Roux
1227 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1228 for ACR file, written out as DICOM files (hope so...)
1230 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1231 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1232 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1233 moved to base class gdcmParser and only the specialisation is kept
1235 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1236 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1237 already does the job.
1238 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1239 (to be consistent with gdcmParser::WriteEntries).
1241 2004-03-30 Benoit Regrain
1242 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1243 upate of the object's instance. It's passed to 2 in the unfavorable
1244 case : one in the ExecuteInformation, one in the ExecuteData
1246 2004-03-29 Jean-Pierre Roux
1247 * ENH : Check on file type to be written moved
1248 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1249 * FIX : gdcmObject::ResetBoundaries now stops properly
1250 when end-of-list is reached
1251 : gdcmVersion modified (as Benoit Regrain asked)
1253 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1254 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1255 * src/gdcmUtil.cxx: added forgotten iostream include.
1256 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1257 equivalent to ExplicitVR in existing code).
1259 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1260 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1261 now contains all the gdcmGlobal related code.
1262 * minor coding style and doxygenation changes.
1264 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1266 now contains all the Debug related code.
1267 * minor clean-up of includes in src/*.cxx
1268 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1269 CreateCleanString) removed.
1270 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1271 * Doc/DoxyMainPageUser.txt added.
1272 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1273 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1274 src/gdcmDirList.cxx)
1276 2004-03-24 Jean-Pierre Roux
1277 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1279 2004-03-23 Jean-Pierre Roux
1280 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1281 big endian made volumes
1282 * ENH Now gdcmParser constructor and destructor are protected to forbid
1283 end user to instanciate class gdcmParser
1284 (only gdcmHeader and gdcmDicomDir are meaningfull)
1286 2004-03-22 Benoit Regrain
1287 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1288 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1289 gdcmSerie to gdcmDicomDirSerie
1291 2004-03-19 Jean-Pierre Roux
1292 * ENH Now the tree-like structure describing a DICOMDIR comming from
1293 an already existing DICOMDIR file is consistent with
1294 the home-made tree-like structure build ex-nihilo
1295 or build from the files held (recursively) in a Directory
1296 functions gdcmDicomDir::CheckBoundaries()
1297 gdcmObject::SetBoundaries() added
1299 2004-03-17 Jean-Pierre Roux
1300 * REM (Eric Boix bug) : removal of meaningless
1301 gdcmDicomDirImage::NewImage function.
1302 * FIX now file names and directory name are written properly in the
1304 * FIX now gdcmDicomDir constructor may be call without any trick
1307 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1308 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1309 of gdcmDicomDirImage::NewImage as empty function.
1311 2004-02-28 Jean-Pierre Roux
1312 * ENH add gdcmDicomDir:NewPatient
1313 add gdcmDicomDirPatient:NewStudy
1314 add gdcmDicomDirStudy:NewSerie
1315 add gdcmDicomDirSerie:NewImage
1316 to allow making gdcDicomDir object.
1317 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1318 (as opposite to the gdcmHeader chained list)
1320 2004-02-11 Benoit Regrain
1321 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1322 when using from python
1324 2004-02-10 Benoit Regrain
1325 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1326 * FIX : in gdcmDicomDir when the directory is empty
1327 * ENH : add callback and methods to get the progression of dicomDir
1330 2004-02-06 Jean-Pierre Roux
1331 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1332 - GDCM_META added to gdcmDicomDirType
1333 - class gdcmMeta created
1334 * ENH : - A brief summary is now displayed at the beginning of
1335 'testDicomDir' to help disaster magnitude estimation
1336 * REM : Now useless Test/explDICOMDIR.cxx
1338 2004-02-05 Benoit Regrain
1339 * ENH : add methods in gdcmObject to get the hash table or the list of
1341 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1342 * FIX : wrapping python for TagHeaderEntryHT
1344 2004-02-04 Benoit Regrain
1345 * FIX : even length for some strings when writting the dicom dir
1346 * FIX : sort the images in the dicom dir
1347 * FIX : Bug fix for python use of dicom dir
1348 * ADD : a python demo
1350 2004-02-04 Jean-Pierre Roux
1351 * FIX : Final solution (?) for icone embedded images
1352 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1353 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1354 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1355 gdcmData/gdcm-MR-SIEMENS-16.acr1
1356 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1357 to make full checking easier
1359 2004-02-04 Benoit Regrain
1360 * FIX : WriteEntries : coding style & logic in parameters
1361 * FIX : Set the elements to create the DicomDir in a dictionary file
1363 2004-02-03 Benoit Regrain
1364 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1365 * gdcmDicomDir : add the load of directory
1366 * Bug fix and print add-on
1368 2004-02-03 Jean-Pierre Roux
1369 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1370 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1371 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1372 * FIX gdcmParser.cxx : 'group length' elements are now considered
1373 as integers, even for shadow groups, when file is Implicit VR
1375 2004-02-02 Jean-Pierre Roux
1376 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1378 of the last synonym :-(
1379 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1381 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1382 * FIX taking into account the possible 7fe0,0010 multiplicity
1383 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1384 to allow removal of references to 7fe0,0010, to deal with
1385 ACR-NEMA images, when 0028,0200 is meaningfull
1387 2004-01-31 Jean-Pierre Roux
1388 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1389 no longer writes 'Un' on disk
1390 * FIX SQ elements with actual length are now dealt with corectly
1391 * FIX gdcmFile::WriteBase make the difference, for color images, between
1392 the length (for Palette expanded images)
1393 and Raw Length (non expanded image + Palette)
1394 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1395 (that broke Write). Replaced by UL.
1396 Aware user will reload the field if he
1397 thinks it's necesssary
1399 2004-01-30 Jean-Pierre Roux
1400 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1401 when 'dirty Acr' is found, to be compliant with the new
1402 IsReadable() methods.
1404 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1405 (no DOUBLE images in kosher DICOM,
1406 but so usefull for people that miss them ;-)
1408 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1409 DICOMDIR related utilities (not checked as Windoze compliant)
1411 2004-01-28 Jean-Pierre Roux
1412 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1414 2004-01-27 Jean-Pierre Roux
1415 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1416 to allow skipping the shadow elements, to save memory space.
1417 The TRUE value for this param has to be used
1418 with a FALSE value for the 'enable_sequence' param.
1419 ('public elements' may be embedded in 'shadow Sequences')
1420 * gdcmHeader methods now deal with 'embedded icones images' in the header
1421 (even when an 'icone image sequence' is announced by the
1422 element (0x0088,0x0200), but there is NO icone at all ...
1424 * gdcmHeader sometimes Image Location value doesn't follow
1425 the supposed processor endianity (see gdcmData/cr172241.dcm).
1428 * gdcmHeader add the method
1429 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1430 to get *all* the Header Entries with the same tag.
1431 GetHeaderEntrySameName is probabely *useless*
1432 (no meaning : Name is *not* an identifier within the Dictionnary)
1434 2004-01-26 Benoit Regrain
1435 * Bug fix in the print of hexadecimal representations. Remove long fields
1436 in the print and add a third level of print to print them
1438 2004-01-23 Benoit Regrain
1439 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1440 * Bug fix on test suite after remove the strip made on not string fields
1441 * Split the IsReadable method between gdcmParser which test that the file
1442 is dicom and gdcmHeader which test that it's an image file
1444 2004-01-22 Benoit Regrain
1445 * DicomDir : clean code, add methods, set variables in protected or private
1446 * gdcmUtil : bug fix for the clean string method
1448 2004-01-19 Benoit Regrain
1449 * Add the use of shadow dictionaries
1450 * bug fix and coding style
1452 2004-01-19 Benoit Regrain
1453 * src/gdcmFile.cxx : bug fix concerning the close of file
1454 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1455 * Add the update of header entries using the shadow library
1457 2004-01-19 Benoit Regrain
1458 * removal of file gdcmHeader2.cxx
1459 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1460 inheriting from gdcmParser. This split is to prepare the integration
1461 of dicom dir parsing
1462 * bug fix under python
1464 2004-01-16 Jean-Pierre Roux
1465 * REM removal of class gdcmHeaderEntrySet
1466 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1467 * ADD add file gdcmHeader2.cxx
1468 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1470 2004-01-15 Benoit Regrain
1471 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1472 entries created while parsing the header. Thus, they will be destroyed
1473 when the gdcmDictSet will be destroyed
1474 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1477 2004-01-15 Benoit Regrain
1478 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1479 made a fatal error because of the memory release at the end of program.
1480 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1481 some memory and vtk seems to have some problems with that.
1482 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1484 2004-01-14 Benoit Regrain
1485 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1486 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1487 * src/*.[h|cxx] : make changes due to class name changes
1488 * gdcmPython/demo/*.py : bug fix due to method names
1490 2004-01-13 Benoit Regrain
1491 * src/*.[h|cxx] : coding style
1492 * vtk/*.[h|cxx] : coding style
1494 2004-01-13 Benoit Regrain
1495 * gdcmPython/testSuite.py : test the readable flag of file for tests
1496 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1497 It's lied to the stl compilation by MSVC (windows, always windows...)
1498 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1500 2004-01-12 Benoit Regrain
1501 * src/*.h : add comments
1502 * src/gdcmDictSet.h : set the method BuildDictPath in public
1503 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1504 directly setted in the source code
1505 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1508 2004-01-09 Benoit Regrain
1509 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1510 * setup.py : use a reference to gdcmVERSION
1512 2004-01-07 Benoit Regrain
1513 * Modification to compile with the distutils.
1516 2003-12-10 Benoit Regrain
1517 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1518 can use a gdcmHeaderHelper to load datas
1519 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1520 made in the source code
1522 2003-12-10 Benoit Regrain
1523 * Update Windows projects and .cvsignore files
1525 2003-11-12 Jean-Pierre Roux
1526 * ENH gdcmHeader constructor has one more parameter (default value : false)
1527 that allows the user to 'go inside' the SeQuences only
1529 gdcmElValSet:Print takes it into account
1531 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1532 * ENH: Update gdcmPython/CMakeLists
1533 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1534 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1536 2003-11-10 Jean-Pierre Roux
1537 * FIX : gdcmHeader::LoadElements is now based
1538 on the ListTag listElem member,
1539 not longer on the TagElValueHT tagHt member
1540 * ENH : PrintPubElVal shows (temporarily) both results,
1541 with the tagHt member and the listElem member.
1542 (it's easier to 'see' the problems when using Printheader)
1544 * FIX : old private member LgrElem is now splitted into
1545 ReadLength : Length actually found on disk (updated only
1546 if bug fixing is necessary), for internal
1548 UsableLength : Updated by FixFoundLength, to fix a bug
1549 or to allow Parser going on.
1550 Will allow to re-write a kosher header when a SeQuence
1551 with a length (not 0000) is found
1552 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1553 because gdcmElValSet::Add does not update ListElem
1556 2003-11-07 Jean-Pierre Roux
1557 * FIX misstyping in Transfert Syntax name table
1558 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1559 when they have an actual length (not 0000 nor FFFFF)
1560 (Nobody should care of it, but DICOMDIR explorers)
1562 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1563 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1565 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1566 * ENH: vtkGdcmReader now supports LUT !
1567 (vtkgdcmViewer for now is not able to use them though)
1569 2003-11-05 Jean-Pierre Roux
1570 * in testSuite.py : new files names for checking the package
1571 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1572 that returns the pixel area size to the *aware* (vtk) user
1573 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1575 2003-11-05 Benoit Regrain
1576 * in testSuite.py : Modify the rules for checking the paths
1577 : Explicit error messages
1578 * in __init__.py : Related modif
1580 2003-11-03 Jean-Pierre Roux
1581 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1582 to be used by aware (vtk) users that want to manage
1583 LUT (and no to turn the PALETTE image into an RGB pixels one)
1584 * GetPixelType now returns 8U for 24 Bits images
1585 (vtkGdcmReader compliant)
1587 2003-10-31 Jean-Pierre Roux
1588 * Removal of *all* gdcmData images and add them again
1589 in order to loose the 'history' of un-anonymised images
1591 2003-10-31 Jean-Pierre Roux
1592 * RMV : removal of useless jBitsInJsample.h
1593 for both 8 and 12 Bits JPEG Lossy Libraries
1595 2003-10-31 Jean-Pierre Roux
1596 * ENH : Add the functions gdcmFile::GetImageDataRaw
1597 gdcmFile::GetImageDataIntoVectorRaw
1598 that act as GetImageData and GetImageDataIntoVector
1599 except the making of an RGB Plane from Gray Plane + LUT
1600 Intended to aware (vtk) users who know how to manage
1603 GetLUTRGBA return a R,G,B,A LUT if any
1604 lgrTotaleRaw gives the 'Raw' length
1605 GetImageDataRaw returns the gray Plane
1606 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1607 (They stay Grey, just like with other Dicom viewers :-(
1609 2003-10-30 Jean-Pierre Roux
1610 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1612 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1613 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1614 being coherents dicom files.
1616 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1617 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1619 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1620 * ENH: Two steps is necessary to please VC++ compiler...
1621 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1622 * ENH: Add include dir to medcon lib
1623 * FIX: only one function is being exported for now !
1624 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1626 2003-10-29 Jean-Pierre Roux
1627 * adding gdcmHeader::GetLUTRGBA
1628 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1629 --> Mathieu, the modif u're waiting for is not yet committed
1630 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1632 2003-10-27 Jean-Pierre Roux
1633 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1634 00191113.dcm DermaColorLossLess.dcm
1635 MxTwinLossLess.dcm RadBWLossLess.dcm
1636 * ENH: For version prior to vtkImageViewer2 -r 1.19
1637 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1639 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1640 * Removal of ido stuff in CMakeLists.txt
1642 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1643 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1644 * FIX: remove a call to ->Modified ... see comments
1645 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1647 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1648 * FIX: Problem with path for libvtkgdcmPython
1649 * ENH: Try adding a search script for python site-package
1650 * RMV: Remove some file from medcon lib that are not necessary
1651 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1652 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1653 * FIX: More pragma disable fro VC++,
1654 I don't think I break something as it is also disable in VTK/ITK.
1655 But it fasten debug compilation time.
1657 2003-10-23 Jean-Pierre Roux
1658 * gdcm now deals with 16 Bits Run Length Encoded images
1659 (they are compressed as 2 planes images,
1660 one for the high Bytes, the other for low Bytes)
1662 2003-10-22 Jean-Pierre Roux
1663 * Now CheckRead takes into account :
1664 - the bugged 'Leonardo' Siemens images
1665 - the XA images, sent thru the burning VPRO station
1666 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1669 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1670 * FIX: When copying a Makefile.am to CMakeLists.txt
1671 one should remove the '\'
1673 2003-10-22 Jean-Pierre Roux
1674 * in gdcmData adding a bugged 'Leonardo' Siemens image
1675 (wrong lengths in header)
1676 OK with gdcm, KO with the other viewers :-)
1677 * add a GE dlx XA image, thru the VEPRO burning station
1680 2003-10-21 Jean-Pierre Roux
1681 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1682 for a brutal checking of vtkgdcmViewer compliance
1684 2003-10-21 Jean-Pierre Roux
1685 * add the files for 'xmedcon' Jpeg Lossless library
1686 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1688 2003-10-21 Jean-Pierre Roux
1689 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1691 2003-10-21 Jean-Pierre Roux
1692 * garbage Siemens 'Leonardo' images dealt with
1693 (the patch is easy to remove)
1694 * cosmetic changes to avoid warnings
1696 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1697 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1698 no need to press 'r' now.
1700 2003-10-20 Jean-Pierre Roux
1701 * upgrade of checkRead.sh checkWrite.sh according
1702 to new Jpeg Lossless decompressor
1703 * add US.3405.1.dcm, a genuine RGB medical file ...
1704 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1705 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1707 2003-10-15 Jean-Pierre Roux
1708 * general anonymisation in gdcmData
1709 * adding the 'color files' from
1710 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1711 * adding some well knowed bugged-header images
1712 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1713 waiting for their inclusion in Python testsuite
1715 2003-10-15 Jean-Pierre Roux
1716 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1717 no longer seg faults when file is not found
1719 2003-10-14 Jean-Pierre Roux
1720 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1723 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1724 * TODO: *.in file to genereate a UseGDCM later
1726 2003-10-14 Jean-Pierre Roux
1727 * Some supposed-to-be Dicom Images have no preamble.
1728 OpenFile takes it into account
1729 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1730 * Missing elements added in dicomV3.dic
1731 (just to be affraid : have a look at
1732 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1733 and do it again next year ;->
1735 2003-10-13 Jean-Pierre Roux
1736 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1737 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1738 But there are NOT. It's fixed !
1740 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1741 * FIX: "jpeglib.h" was not found on VC++
1742 * FIX: vtkgdcm was not being installed
1744 2003-10-10 Jean-Pierre Roux
1745 * ENH : OpenFile closes the file if it *really* doesn't look like
1746 an ACR-NEMA / DICOM one.
1747 * FIX : testWrite no longer writes an empty file if the source file
1748 is not gdcm Readable
1749 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1752 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1753 * FIX: CMake generate now documentation
1754 * ENH: out of source doc build !
1755 * ENH: Generate both user and dev documentation
1756 * ENH: Should work on windows too
1757 * ENH: Only one doxygen config.in file is needed
1758 * FIX: make install should be ok now on ùnix plateform
1759 * FIX: PATH to dictionary was wrong (missing /)
1760 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1762 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1763 * vtkGdcmReader is now able to read rgb dicom file.
1764 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1765 * added a gdcmViewer to vtk test, use mouse to control
1766 window level & window width
1768 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1769 * CMake-ification of gdcm, we have now two build system
1770 * FIX: on cygwin Wsock32 doesn't exist
1771 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1773 2003-10-06 Emanuel Ollart
1774 * FIX : compilation process wad broken.
1775 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1777 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1778 * change gdcmViewer -> vtkgdcmViewer
1779 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1781 2003-10-06 Jean-Pierre Roux
1782 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1783 ( e.g : well known GE images with a wrong elem length,
1784 : Philips MRI Images with a wrong Huffman table)
1785 * still to be done : allow the reading of bugged LEONARDO Siemens images
1787 2003-10-03 Jean-Pierre Roux
1788 * Odd length strings are padded with '\0' (not with spaces,
1789 to remain compliant with already defined strings,
1790 like Transfert Syntax UID and others)
1792 2003-10-03 Jean-Pierre Roux
1793 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1794 to allow displaying RGB images (not only by affim ;-)
1796 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1797 * vtkGdcmReader is now able to read rgb dicom file.
1798 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1800 2003-10-03 Jean-Pierre Roux
1801 * A few nasty patches to allow the reading of a lot of nasty images
1802 ( e.g : well known GE images with a wrong elem length,
1803 : Philips MRI Images with a wrong Huffman table)
1804 * still to be done : allow the reading of bugged LEONARDO Siemens images
1806 2003-10-03 Jean-Pierre Roux
1807 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1809 2003-10-03 Jean-Pierre Roux
1810 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1811 to allow displaying RGB images (not only by affim ;-)
1813 2003-10-03 Jean-Pierre Roux
1814 * gdcmFile::GetImageDataIntoVector now
1815 - deals with MultiFrames MultiFragments Run Length Encoded files
1816 - deals with YcBcR (YBR_FULL) files
1817 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1818 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1820 (no sample found :-(
1822 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1824 Two reasons: - clear things
1825 - third parties acces gdcm through header files, so won't
1826 suffer anymore VC++ complains
1828 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1829 * add argv[1] in testvtkGdcmReader.cxx
1832 2003-09-24 Jean-Pierre Roux
1833 * The lines are now eigthy characters long.for
1834 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1836 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1837 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1838 char* to std::string. Thus, the use of strdup becomes useless. (see
1839 previous commis of Malaterre)
1840 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1841 before the last Malaterre's commit.
1843 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1844 * This commit should fix the Debug building under VC++, the problem
1845 was mainly a mixture of debug and release lib being loaded at startup.
1846 * I also remove a depency to a specific C function: strdup. Because I had
1847 to force the link to msvcrtd (whereas strdup is in libc).
1849 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1850 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1851 located in the gdcmCommon.h file. All use of reference of tha has been
1852 changed to now use the variable GDCM_UNFOUND.
1854 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1856 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1857 Dicom dictionary. The test suite can now be run again. Note:
1858 I'm note very happy with the " (RET)" changes. I believe this
1859 RETAINED comment should be dropped when parsing the dictionary.
1860 - PACKAGER corrected
1862 - AUTHORS updated and now in alphabetical order
1863 * Makefile.am now exports gdcm.dsw for Windoze users.
1865 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1866 * cygwin complains about missing std:: in subdir Test/
1868 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1869 * remove some methods that are now in gdcmHeaderHelper
1871 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1872 * vtkGdcmReader set spacing and origin correctly
1874 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1875 * Fix a few delete/delete[] mismatch
1877 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1878 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1879 interpretation to data given by gdcmHeader. For instance there are
1880 heuristics to get informations (look at different places).
1881 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1882 sorting DICOM images based on different strategies.
1883 * modified Makefiles accordingly.
1885 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1886 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1887 when building in debug mode
1888 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1889 src/win32/gdcmdll.dsp
1890 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1892 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1893 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1896 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1897 * src/win32/libgdcmjpeg12.dsp was not dos format
1898 * src/win32/libgdcmjpeg12.dsp :
1899 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1900 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1902 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1903 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1905 * src/gdcmFile.cxx : bug fix in affectation type
1906 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1907 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1908 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1909 symbols... future problem ?
1911 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1912 * src/win32/libgdcmijpeg12.dsp was missing
1913 * modified gdcm.dsw accordingly
1915 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1916 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1918 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1919 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1920 commit of JPR (before his hollidays to facilitate our work).
1921 * setup.py : bug fix in code. Modifications made while the last commit
1922 of JPR. The code hasn't been tested before the commit... it's so
1923 useless to make that (for best programmer that is JPR) !!!
1925 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1926 * tagged the current version as Version0_3 (i.e. version 0.3)
1928 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1929 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1930 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1931 * *.dsp : modifications to use new libgdcmijpeg8 library
1932 * setup.py : bug fix on VTKPATH variable
1933 * PACKAGER : adding all concerning windows
1935 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1938 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1939 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1940 test suite reported error.
1941 * PACKAGER file added (describes what a packager must do when
1942 packaging a new release).
1943 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1944 * configure.in: upgraded version number to 0.3.0
1945 * fixing build of rpm (through rpm -ta):
1946 - Doc/Makefile.am exports proper doxygen files
1947 - src/jpeg/libijg8/Makefile.am exports the include files.
1949 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1950 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1951 * src/gdcmHeader.h : formatting code
1953 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1954 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1955 We were obtaining error message from vtk. Now, creation of file list
1956 is made in an internal list to prevent this problem.
1957 Bug fix when output is empty.
1958 Bug fix in update of progress value. Previous commit for this was a bad
1960 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1962 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1963 * src/gdcmHeader.h : added method to get the file name
1964 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1965 files. Added method to remove all files on the input
1966 Added FIXME comment concerning the bad parsing of header made by
1967 ExecuteInformation method (in ExecuteData method)
1969 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1970 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1971 when using make instal.
1972 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1973 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1975 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1976 * setup.py : adding include dir of jpeg lib to compile all sources
1977 * */Win32/*.dsp : JPR fix for windows compilation
1979 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1980 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1982 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1983 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1985 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * setup.py is again effective on un*x (takes into account the
1987 addon of the jpeg library)
1988 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1989 * Doc/Doxy* updated (includes above enhancements)
1990 * INSTALL now points to web documentation
1992 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1993 * src/gdcmHeader.h doesn't make unnecessary reference to
1995 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1997 * src/gdcm*.[cxx|h] :
1998 - to allow compilation with gcc 3.x
1999 -- clean up of STL usage (added explicit usage of std::)
2000 -- small fixes on exceptions.
2001 Note: linking not tested !
2002 - clean of doxygen comments to avoid warnings at documentation
2004 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2005 dependent convertion).
2007 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2008 * Clean up of previous JPR garbage commit (not even commented in the
2010 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2011 - moved all jpeg related files from src to src/jpeg/libijg8, with
2012 addition/modification of Makefile.am and configure.in.
2013 - the testSuite is still brain damage (not guilty).
2015 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2016 * WrapVTK.py : modifications to get correctly vtk source files to
2018 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2019 (FileName -> Filename)
2021 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2022 * vtk/vtkGdcmReader.[cxx/h]:
2023 - UpdateProgress method should now be effective
2024 - removed the limitation on having only images loaded (as opposed
2026 - when building a stack of images/volume, a lesser number of
2027 gdcmHeader and gdcmFile instances should be used (hopefully
2028 accelerating things).
2029 - when building a stack of images/volumes, files which are not
2030 loadable (wrong path-filename, wrong permissions on existing file,
2031 or file not parsable by gdcm) are replaced with a black image
2032 in the stack (for the caller to notice the problem).
2034 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2037 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2038 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2039 between standard library (std) and vtk library (problems are found
2040 under Windows... thanks Windows !)
2042 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2043 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2045 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2047 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2048 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2050 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2051 * When compiling with distutils (see setup.py) the C++ compiler is
2052 called with different flags than the default ones (with automake).
2053 In order to fix all those warning, I compiled gdcm with the command
2054 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2055 and went for warning fixes:
2056 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2057 up from unused variables.
2058 - vtk/vtkGdcmReader.cxx: potential bug fix.
2059 * src/gdcmHeader.h: Doxygen warning cleanup
2061 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2062 * gdcmPython/gdcm.i:
2063 - typemaps correction to take into account the systematic replacement
2064 of "using namespace std" with std:: prefix e.g. std::list,
2065 std::string... (cf changes of 2003-05-21).
2066 - gdcmGlob global variable of type gdcmGlobal (defined in
2067 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2068 exported to Python a as cvar.
2069 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2070 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2071 gdcmDictSet.GetPubDictTagNames() and
2072 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2073 C++ static methods).
2074 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2075 with the above changes.
2077 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2078 * setup.py, manifest.in : bug fix under linux
2080 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2081 * Modification of setup.py to compile vtk part too. Then, we have 2
2082 wrappers which must work with same distutils. For that, we have a
2083 generic distutils in distusiltsWrapping.py ; with :
2084 - build_extWrap class to wrap generically all extensions,
2085 - ExtensionWrap base class for all wrapping extension that contains
2087 - Wrapper interface which wrap sources
2088 + In WrapSwig.py we have extension and wrapper for Swig
2089 + In WrapVTK.py we have extension and wrapper for VTK
2090 * MANIFEST.in : modifications to consider vtk directory and new python
2091 files for compilation
2093 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2094 * Added python wrappers of vtkGdcmReader vtk class (see the
2095 source in vtk/vtkGdcmReader.cxx) :
2096 - vtk/Makefile.am now builds a library
2097 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2098 python library (as opposed to _gdcm.so wich are the python
2099 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2100 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2102 - configure.in has an additional flag --enable-vtk that needs
2103 to be set to enable compilation of vtk related code, that is:
2104 + vtk/vtkGdcmReader.so and
2105 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2106 + gdcmPython/vtkgdcmPython.so (see above)
2107 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2108 be read when compressed or when HighBit + 1 != BitsStored),
2109 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2110 the usage of the python wrapper of vtkGdcmReader vtk class.
2111 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2112 * src/*.[h] all occurences of stl classes are now prefixed with
2113 std::, and all occurences of "using namespace std;" where removed.
2114 This is to avoid pollution of global namespace in included files.
2115 Apparently vtk does not avoid this pitfall: when using both
2116 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2117 collision of various stl members (principally cout...).
2118 * gdcmPython/testSuite.py now cleanly removes temprory generated
2120 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2121 comply with above changes)
2123 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2124 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2125 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2126 vtk data structure (an image Flip was required).
2127 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2128 * cosmetic changes in documentation.
2130 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2131 * src/gdcmHeader.cxx: the constructor no longer exits when an
2132 unexisting file is given as argument.
2133 * The subdirectory Data (containing all the images used for the
2134 test suite) is not part of this repository anymore. A new module
2135 containing those images is now available at
2136 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2137 with the name gdcmData.
2138 All the python scripts (including the package initialisation file
2139 gdcmPython/__init__.py) were adapated to take this change into
2140 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2142 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2143 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2144 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2145 demo of the usage of this class.
2146 Compilation of this vtk part is only done when using the --enable-vtk
2147 at configure (or autogen.sh) stage.
2149 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2150 * More memory link related corrections and documentation fixes.
2152 - maximum info is obtained with a command of the form:
2153 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2154 --show-reachable=yes PrintHeader
2155 - the remaining reachable blocks seem to come from the STL
2156 allocation scheme through the usage of map and list. It looks
2157 like this memory cannot be freed but it is not a memory leak
2158 (in fact further invocation to the STL would recollect the
2159 unused memory allthough it cannot explicitely be freed).
2160 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2161 of displaying an image parsed with gdcm and displayed with VTK.
2162 Note: some images don't seem to work e.g.
2163 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2164 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2165 Allthough this weakens the semantics, it is a ditch attempt to
2166 make gdcm more thread friendly.
2168 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2169 * Memory link hunt (by using valgrind through the command
2170 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2171 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2172 gdcmHeader::_dicom_vr.
2173 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2174 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2176 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2178 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2179 * src/Makefile.am now exports all the necessary include files at
2183 * UpdateGroupLength replaced by new one
2186 * UpdateGroupLength re-written using H-Table
2187 (named UpdateGroupLengthNew untill checks are over)
2189 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2190 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2191 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2193 - gdcmHeader::GetPubElValSet removed.
2194 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2195 UpdateGroupLength, WriteElements, Write.
2196 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2197 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2198 carried the same semantics.
2199 - src/gdcmHeaderIdo.cxx changed accordingly.
2200 - gdcmFile::WriteBase now regroups all the codes from previous
2201 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2202 - enum FileType moved to gdcmCommon.h
2203 * src/gdcmHeader.cxx AddDefault trashed
2204 * gdcmGetXSize added
2205 * getimageDataSize now calls gdcmGetXSize
2206 * Test/*.cxx changed to agree with above changes
2208 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2209 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2210 (to avoid double call by end user).
2211 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2212 by end user, since gdcmHeader::gdcmHeader now handles it.
2214 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * gdcm/Doc many doxygen changes:
2216 - Doxyfile now has two different versions, DoxyfileUsers that generates
2217 the html.users end users oriented documentation and
2218 DoxyfileDeveloppers that generates the html.developper developper
2219 oriented documentation.
2220 - README changed accordingly
2221 - requirement.txt removed (old design info moved to TODO).
2222 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2223 DoxyMainPage.txt, DoxyPython.txt provide more information.
2224 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2225 be updated by simply regenerating the docs with doxygen and copying
2226 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2227 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2228 all the tests in the form "if (<map>.count() >1)" were removed.
2229 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2230 ill-formed documentation sections.
2231 * src/gdcmHeader.cxx: ditto
2233 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2234 * setup.py fixed for un*x (needed macro for stdint.h)
2235 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2236 un*ces with sh-utils test utility.
2237 * gdcmPython/demo/test.py renamed to PrintHeader.py
2238 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2239 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2240 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2241 * src/gdcm*.cxx JPR's bad inclusion fixed.
2243 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2244 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2245 * gdcmPython/demo/test.py changed accordingly.
2247 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2248 * gdcmPython/Makefile.am fixed linking against libstdc++
2249 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2250 * Swig subdir (historical tests of swig version 1.3.17++) removed
2251 * Test/testChangeEntete.cxx some lines commented out in order to make
2253 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2254 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2256 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2257 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2258 hence the user doesn't need this explicit call.
2259 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2260 i.e. LoadElements() call removed.
2261 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2262 - src/Makefile.am declares the proper flag for g++.
2263 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2264 for adding user defined new tags.
2265 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2266 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2267 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2269 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2270 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2271 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2272 src/Makefile.am : the project should properly compile and install
2273 with the autotools, included the python wrappers part.
2274 * gdcm.spec.in : added a spec file for RPM packaging.
2276 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2277 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2279 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2280 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2281 to exported to the environement (see gdcmPython/testSuite.py
2283 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2284 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2285 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2286 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2287 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2289 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2290 * gdcmPython/__init__.py doesn't crash anymore when running in
2291 in InstallMode or PreInstallMode but with an environement given
2292 value of GDCM_DICT_PATH.
2293 * src/gdcmDictSet.[cxx/h] coding style.
2295 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2297 * src/gdcm.h general comments moved to TODO, and README
2298 * src/gdcm.h should now be seen as a user commodity (including it
2299 should suffice to fully use gdcm). It is nowhere including within
2300 any of the kernel files src/*.cxx and src/*.h.
2302 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2304 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2306 * src/gdcm*.cxx only include their corresponding include file
2307 (as opposed to gdcm.h)
2308 * gdcmPython/gdcm.i changed accordingly
2309 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2310 the autogen.sh generated "make snapshot" command to work.
2311 * autogen.sh removed history related references to crea package.
2313 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * distutilsSwigCPlusPlus.py work around some swig portability
2317 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2318 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2319 was done in a last ditch attempt to get setup.py _really_
2320 operationnal. The python/gdcmPython layaout add the advantage
2321 of hidding away the python related distutils specific files
2322 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2323 Alas, the src directory was out of scope (i.e. it's relative
2324 position to setup.py was ../src) which made things impossible to
2325 handle (see previous version of python/setup.py). Crossing fingers...
2327 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2328 * python/setup.py now works on Un*x. (harder than I thougth)
2329 * python/distutilsSwigCPlusPlus.py can now have include files
2330 among the list of sources.
2332 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2333 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2334 * modifications in MSVC projects
2336 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2337 * As stated by the first lines of Test/ExceptionAndPython/README, it
2338 looks like we can move back to original usage of exception within
2339 src/gdcm* and hence remove the errno stuff that was introduced
2340 as a quick and dirty fixture of this problem (added to the TODO).
2341 * Doc/Doxyfile configuration file for Doxygen and corresponding
2342 README file for usage added.
2343 * Test/testWrite.cxx added. This new test comes from a split of
2344 test.cxx that is now reverted to its original purpous i.e.
2345 testing the proper parsing of a Dicom related file.
2346 testWrite.cxx concentrates on testing the IO part of gdcm.
2347 * Test/bug1.cxx (containing a bug on WIn32) added.
2348 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2349 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2350 whose purpose is to publish the content of the TagNames of the
2351 Dicom public dictionnary were not accessible without an
2352 instance of class gdcmHeader.
2353 - those methods are now static methods of gdcmDictSet and hence
2354 require no instances at all to be invocated.
2355 - within gdcmDictSet this change required to change some method
2356 to class methods (i.e. are now static) among which SetDictPath
2357 (renamed to BuildDictPath) and LoadDefaultPubDict.
2358 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2359 the above changes by calling the new method classes of gdcmDictSet.
2360 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2361 the above to be effective.
2362 * python/gdcmPython: in order to wrap properly the above changes
2363 for Python, swig version now needs to be > 1.3.17.
2364 * python/gdcmPython/Makefile fixed to adapt itself to new
2365 configure/make shema introduced by Johan Montagnat (thanks for the
2366 contribution). Alas this Makefile cannot be turned into a proper
2367 Makefile.am without some heavy changes in the configure.in
2368 (for python dectection).
2369 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2370 now avoids publishing the empty entries.
2372 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2373 * python/setup.py : bug fix concerning install under windows
2374 ExtraPath reused :-P
2375 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2377 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2378 * Dicts/dicomV3.dic : remove double spaces !!!
2379 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2380 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2383 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2384 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2385 method. Doxygenation.
2386 * src/gdcm.h clean up of JPR spurious comments.
2388 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2389 * python/distutilsSwigCPlusPlus.py now properly collects the
2390 shadow classes generated by "swig -c++" (gdcm.py in our case)
2391 when using "python setup.py install".
2392 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2393 reexports the working classes.
2394 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2395 by the classical C errno scheme. This is to prevent an obscure
2396 behavior of the python wrappers when importing wxPython.wx prior
2397 to gdcmPython (which ended up in an abort call). An illustration
2398 of this oddity can be found in the Test/ExceptionAndPython
2399 subdir (see the README file). This problem probably due to
2400 an combination of g++ and dynamic loading.
2401 * added Test/ExceptionAndPython (see above)
2403 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2404 * Changed the layout of the python part to avoid bloating main
2405 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2406 i.e. the distutils arsenal. All the python related stuff is
2407 again in a python subdir, but the package itself is now in
2409 * setup.py was cleaned up:
2410 - pythonIncludePath removed
2411 - python setup.py bdist target is now functional.
2412 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2413 collision with other packages). gdcmPython/demo/*.py changed
2416 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2417 * python subdir moved to gdcmPython (preparation of distutils packaging).
2418 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2419 distutils installer is operational.
2420 * - gdcmPython/__init__.py now properly loads the swig generated
2421 shadow classes (from gdcm.py).
2422 - gdcmPython/demo/*.py changed to import the package gdcmPython
2423 instead of gdcmPython/demo/load.py.
2424 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2426 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2427 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2428 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2429 entries within the associated public Dicom dictionary resp. the same
2430 information but sorted by the fourth field (PAT, IMG, DIR) of the
2432 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2433 are now in the "???" group.
2434 - python/gdcm.i changed accordingly,
2435 - python/demo/printGroupedPublicDict.py added, that gives an example
2436 of the above new functionalities in Python.
2438 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2439 * src/gdcm.h, gdcmHeader.cxx:
2440 - historic references to glib's g_malloc and g_free (#defined)
2441 were definitively removed.
2442 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2443 * src/gdcmElValSet.cxx:
2444 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2445 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2446 - GetElValue(string) renamed to GetElValueByName.
2447 - Added GetElementByName(string).
2448 * src/gdcmHeader.cxx: added
2449 - GetPubElValRepByNumber(guint16, guint16)
2450 - GetPubElValRepByName(string)
2451 - GetShaElValRepByNumber(guint16, guint16)
2452 - GetShaElValRepByName(string)
2453 - GetShaElValByNumber(guint16, guint16)
2454 - GetShaElValRepByName(string)
2455 - GetElValRepByNumber(guint16, guint16)
2456 - GetElValRepByName(string)
2457 - GetElValByNumber(guint16, guint16)
2458 - GetElValRepByName(string)
2459 * Doc/requirements.txt added.
2461 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * Test/Makefile building now depends on the one of libgdcm.so
2463 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2464 pixel data) aware which enables finding the address (offset) of
2465 the pixel data of JPEG encoded DICOM files. This leaves only a single
2466 file in the testSuite whose pixel data address (offset) is unknown.
2467 * python/testSuite.py changed accordingly.
2469 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2470 * VC++ has some strong limitations when working with the STL, as stated
2471 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2472 "Also note that some STL containers (map, set, queue, list, deque)
2473 cannot be exported. [...]
2474 Some STL classes contain nested classes. These classes can not
2476 This is caused by a designed limitation that once a template
2477 class is instantiated, it can not be re-instantiated and
2479 Since our usage of map<> is ubiquitous in gdcm, this "designed
2480 limitation" of VC++ is a pitfall.
2481 Hence the Python wrappers of gdcm cannot be incrementally linked
2482 against the c++ dynamic library. The dirty but only workaround is
2483 to forget about incremental link of dynamic libraries and to generate
2484 the Python wrappers library with the inclusions of the underlying C++
2486 The following modifications concern this matter on Win32/VC++:
2487 - wrapping python correct with standalone wrapped dll (don't use separate
2488 dll under windows !!!!)
2489 - python21_d debug mode enabled (ask Frog how to use it :-)
2490 - NO problem with having an STL member of class for example string in C++
2491 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2492 - Python test of dcmlib in Python is ok under windows on a large set
2494 * removed glib references
2495 * typedef's inserted in gdcm.i for correct swig type management
2497 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * python/demo/*.py load.py extracted from test.py. Added explore.py
2499 that only displays required tags and testAll.py that parses all
2500 the files of the testsuite without using unittest.
2501 * python/testSuite.py other additional test on new files added.
2502 * Data/* new test files added accordingly to the testSuite.
2503 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2504 the vr in the file differs from the one of the dictionary.
2506 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2507 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2508 values, but limits itself to values which are below a user specified
2509 size (by default 1024 bytes).
2510 * python/gdcm.i : elements not loaded (because their size is above the
2511 user specified treshold) are exported with their TagKey as key of the
2512 python dictionary. This enables the testsuite to make some checks
2513 on the unloaded elements (since we have their offset and size).
2514 * python/testSuite.py
2515 - now tests for the existence and proper value of the pixel data
2516 - two new examples added.
2517 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2519 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2521 aware. See the strategy comments in gdcmHeader::FindeLength().
2522 * Test/test.cxx now accepts a filename as first argument.
2523 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2524 * python/testSuite.py changed to integrate test on above files.
2526 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2527 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2528 the vr was also RET.
2529 * python/testSuite.py more tests added.
2531 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * python/testSuite.py unittest test suite added (uses Data)
2533 * Data/* dcm and acr files for the test suite.
2534 * glib dependance removed from un*x version. We now use ISO C99
2535 7.18 Integer types (see stdint.h)
2536 - python/Makefile, src/Makefile src/gdcm.h
2537 * src/ when an explicit vr (like dicom files) suddenly poped an
2538 implicit element we use to mark the underlying DictEntry of the
2539 concerned ElValue with "Implicit". This strategy was damageable
2540 too the public or provite dictionaries, since some of their vr
2541 would be changed. Since Header::FindLength heavily relies on the
2542 detection by Header::FindVR of falsely explicit elements, I
2543 added an extra ImplicitVr member to ElValue (boolean).
2544 The rest of the changes we the necessary adaptations.
2546 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2549 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2551 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * Adaptation for porting to VC++:
2554 o forced to use std namespace (for string to be known)
2555 o all class use __declspec export style on WIN32
2556 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2557 (in stdlib.h on Win32 but in std:: for gcc)
2558 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2559 variable GDCM_DICT_PATH.
2560 * src/gdcmHeader.cxx verbose comments made discrete.
2562 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2563 * python/gdcm.i: added a typemap that converts a C++ hashing table
2564 to native Python dictionary.
2565 * python/demo/test.py:
2566 - now uses the native dictionary for exploration of gdcmHeader.
2567 - takes an optional filename argument (the file to parse).
2568 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2569 PubElVals hashing table.
2570 * Dicts/dicomV3.dic removed error prone trailing spaces.
2572 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * Python wrapping process moved away from src/Makefile to
2574 newly created python/Makefile (as well as gdcm.i)
2575 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2576 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2577 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2578 from the environement variable GDCM_DICT_PATH (when existing).
2579 * src/gdcmDict::GetTag bug fix.
2581 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2582 * Straightforward temporary fixes for swig to build the python wrappers.
2583 src/Makefile now has a python working entry [by working we mean
2584 that we can import de shadow classes without errors].
2586 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2587 * hashtest.cxx removed (since allready in Test)
2588 * src/gdcmlib.h renamed to src/gdcm.h
2589 * src/dcm.i renamed to src/gdcm.i
2590 * src/Makefile prepared for python wrapping
2592 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * src/gdcmHeader.cxx :
2594 - Parsing of header is now separated from loading of element values
2595 (see gdcmHeader::LoadElements).
2596 - general clean up of hopefully all file access (creation of
2597 ReadInt16 and ReadInt32)
2599 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * src/gdcmHeader.cxx :
2601 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2603 - SetLgrElem renamed to SetLength
2604 - GetLgrElem renamed to GetLength
2605 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2606 * src/gdcmElValSet.cxx fixed both GetElValue methods
2607 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2608 due to IdoDude was cleaned out.
2610 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2612 concentrates on finding the value representation (when it exists).
2613 RecupLgr now only finds the element value length, and it avoids
2614 returning the unecessary skL (skipped length).
2615 Also, offsetCourant was simply removed (with taille_fich) since
2616 it was redundant with the File position internals (by using
2617 ftell and fseek). This also made skL (see above in RecupLgr) usage
2619 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2620 on the libido specificities which are handled through class
2622 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2625 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2626 * Truckload of changes. Parsing of header is barely functional
2627 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2629 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * src/gdcmHeader.cxx many addons of low level methods
2632 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2634 and _IdDcmSWAP_LONG.
2636 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2637 * This corresponds to all the changes decided at the meeting of
2638 May 23 2002. Needless to say we are running late...