1 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
5 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
6 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
7 JPEG decompression, especially when dicom frames are split into several
8 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
9 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
11 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * src/gdcmHeader.cxx : change the initialisation of default header.
13 Now, this header is readable by gdm, e-film, DicomWorks
15 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
17 Rename Decompressed to Raw
18 * Use the API changes in gdcm::File.
19 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
22 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
24 each added entry in the header. Replace the 'Planes' field by the 'Number
27 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
29 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
31 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
33 At this time, this image isn't readable by e-film... waiting JPR help to
36 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
38 DocEntry. Now use methods of the Document !
40 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * Test/ShowDicomSeq.cxx : bug fix
43 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
45 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
46 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
47 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
49 * Test/TestCopyRescaleDicom.cxx : remove unused variable
50 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
51 containing found sequences
53 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
56 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
57 Some fields in BinEntry must be copied to not seg fault when making the :
58 gdcm::File *copy = new gdcm::File( copyH );
59 and tests are now made on good variables
61 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
63 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
65 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
66 * Add vtkGdcmWriter example and test
68 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * Test/TestUtil.cxx : reformat the source code
70 * vtk/vtkGdcmReader.cxx : remove and change prints
71 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
73 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
74 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
76 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
78 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
80 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
82 by an eof to prevent all bad read of the file... and in this case, the
85 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * Example/Volume2Dicom.cxx : comment unused variables
87 * Test/PrintDicomDir.cxx : comment unused variables
88 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
89 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
90 method that is redondant with AddEntry.
91 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
94 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * Bug fix due my last commit (compilation under Windows).
96 * Example/Volume2Dicom : bug fix in the file and reformatting source code
97 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
99 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
101 - Remove printf / sprintf
102 - include iostream AFTER gdcm so we don't get warnings
103 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
105 - Also remove tons of include from header files, hopefully this should
106 speeup the compilation time, since it was becoming a dog slow.
107 - Remove gdcm.h as it include way too many files and slow down compilation
108 (plus it is not up to date)
109 - remove 'using namespace std' this is BAD !
111 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * Remove memory leaks on the DicomDir
113 * Remove some useless datas in DicomDirObject
114 * Add usefull methods in SQItem, to be complient withe the ElementSet
116 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
119 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
121 future, with convertion)
122 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
123 and ImageDataSize values. Remove the method to get the PixelReadConverter
124 from the output of the class
126 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
129 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
131 and vtkErrorMacro use.
132 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
134 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
137 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
138 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
139 The string leaves only in the fonction. So when we make a .c_str(), we
140 get the pointeur on the first element, element that will be destroyed
141 immediately after thee instruction.
142 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
143 file has been opened : the test must be made on the content of the
144 pointer and not directly on the pointer !
147 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
149 the python part recompiles
151 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
153 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
154 X session is killed (for my computer... it seems to not be identic on
157 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
159 avoid problems (otherwise, the difference test between the visible image
160 and the reference is incorrect. If the reference is greater than the
161 screen resolution, it's produce errors).
162 Can be used for only one image. Can be used with a visible flag.
163 * vtk/vtkGdcmReader.cxx : remove commented codes.
164 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
165 under windows at compilation
166 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
168 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
170 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
171 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
172 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
173 tests on the image size X, Y, Z
175 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
177 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
178 between the class name and the file name
180 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * src/ : fix compilation warnings for the Write method (2 different
182 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
183 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
184 variable... create a static method in gdcm::Document to access to
185 this variable content.
187 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
189 file, to be accessed by other files (like gdcmFile). Remove commented
190 code. Move the change of the header to the gdcmFile, using the
192 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
193 To be sure of that (and simplify calls), the Write of the header now
194 gets a file name and not a file pointer (std::ifstream).
195 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
196 DocEntryArchive. Remove all open of the written file
198 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
201 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
203 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
205 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
206 some corresponding methods. Write correctly the file and check before
208 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
209 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
210 is now on RGB datas (as before my last commit
211 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
213 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
215 Add a print information of the type of the entry
216 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
217 It was in the gdcmFile, and all write have been regrouped
218 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
219 Write correctly all dicom files (in decompressed mode only at this time)
220 * Test/ : test on files are now made using Raw datas and not color datas if
222 * Example/PrintFile.cxx : add more printings
224 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
225 * Amelioration of code, remove some code copy. For the loading of
226 BinEntry (in gdcmDocument), add the test to verify if the file is already
229 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
231 remove a DocEntry in the header (push an empty DocEntry)
232 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
233 lines. Bug fix in the initialization of the PixelConvert and the
235 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
236 use in TestCopyDicom (now this test can run under windows... but fails)
237 * Test/TestCopyDicom.cxx : amelioration of the test :
238 - test the pixels written
239 - add test points to quickly find where is the error
240 - can set a file name input and output in arguments
241 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
242 amelioration of the test output
244 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
246 all replaced DocEntry's
247 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
248 Now, each needed DocEntry to modify is duplicated, modified and inserted
249 to the header using DocEntryArchive. Thus, after save, we can restore the
250 header initial state.
252 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
255 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
257 correct to copy it. The DictEntry is specified at the DocEntry creation,
258 then, it musn't change in the time.
259 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
260 header correctly. At this time, the change is only made for the first
261 level of the Document. In the future, it might consider sequences.
262 The change is made by replacing a DocEntry by an other that is created
263 outside the class. The old value is kept. When we restore the header
264 status, the added DocEntry is deleted and replaced by the old value.
265 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
266 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
267 set the write type to explicit VR, implicit VR or ACR. Add methods to set
268 the write mode to native, decompressed or RGB (but not used at this time)
270 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
272 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
274 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
276 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
278 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
279 set because already copied when copying the BinEntry's of the header
280 * Test/TestAllReadCompareDicom.cxx : remove warnings
282 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
284 Two problems appear when doing it :
285 - with the gdcmFile : when the GetImageData method is called, the pixels
286 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
287 datas (pixels). And each structure destruct the datas when it's
288 destructed. So we have two destructions for the same datas. To solve it,
289 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
290 datas or not. If it doesn't own datas, then they will not destroyed by
292 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
293 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
294 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
295 create a double destruction of the same DocEntry's. So, to solve it,
296 the TagHT is simply cleared and the DicomDir* elements are destroyed.
297 * TODO : add an entry concerning memory leaks in the DicomDir
299 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
301 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
304 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
306 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
307 after it have been deleted
309 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * FIX: src/* fix the doxygen warnings.
311 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
312 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
313 was erroneously defined with a size of 15 instead of 16. [many thanks
314 to Jean Michel Rouet for pointing out this bug].
316 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
317 1. Finish merging JMR patch for writting DICOM from scratch
318 2. Fix -hopefully- bug with MONOCHROME and space vs null character
319 3. Use const ref when possible
320 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
321 5. A few more comments
322 6. CreateUniqueUID can now be called without parameter"
324 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
325 * ENH: Slightly bigger patch:
326 1. Getting toward full integration of JMR patch for writting dicom from scratch
327 2. Update Test to test part of this patch: CreateUniqueUID
328 3. File was not close properly in gdcmDict
329 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
330 5. Use of const ref instead of copy (speed issue)
331 6. Remove temporary (duplicate) string in TranslateToKey
332 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
333 8. Do not repeat virtual in subclasses
334 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
336 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
337 * Apply first patch toward better string comparison when dealing with broken
338 DICOM files. Essentially the string could be padded with a space instead
339 of a null character as defined by standard
341 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
343 because never used... and in the same time, that's remove some memory leaks
345 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * src/gdcmFile.cxx : now delete the PixelConvert instance.
347 * In examples and tests : change the type of image data variables from void*
348 to uint8_t*. Remmove all delete on image data variables
350 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
351 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
352 Verify the file pointer value before open the file, and if it's not null,
353 a verbose message is generated.
354 Close correctly the file when the file isn't considered dicom-like. The
355 correctly close is a call to CloseFile.
356 When closing the file pointer, test if its not null to close the file.
357 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
358 file. For an uncompressed image, the copied datas correspond in the least
359 case to the image size (calculated) or the image size specified in the
360 header. A verbose is generated if these two size mismatch
362 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
364 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
365 break under windows (with msvc6 compilation).
367 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
369 compiling with MSVC6)
371 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * Bugs fix for the Windows build with VC6
373 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
374 needed (only for projects required VTK). If the VTK is included in all
375 projects, there is conflicts with the jpeg lib of vtk when compiling the
376 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
377 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
378 when compiling the gdcm_wrap.cxx file (created by the compilation of the
380 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
381 (like it's already made for the cout use). Otherwise, conflict with the
384 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
385 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
387 - comments on the DicomDir::Method related usage added.
388 - now that we use the namespace gdcm, a lot of internal classes do
389 NOT need to be wrapped anymore.
390 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
391 DicomDir::Method) new example added.
393 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
394 * Improve string manipulation. I now inforce the notion of 'DicomString'
395 A DicomString can contain as many \0 as they want
396 and it is *always* of even length.
397 We only support odd length for very rare case.
398 And in the near future this should be removed.
400 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
401 * /binary_write/ gdcm source. Now even on big endian we are writting
402 little endian. This should -heopfully- fix some tests
404 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
405 * Now the dictionary is compiled into gdcm lib. This is a default
406 behavior, thus any dic file specified is picked before failback to
407 the one comiled into lib
409 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
410 * Change internals for gdcmDict. Don't use any 'new' any more.
411 This should definitely solve any leak problem, and we should be
412 as fast as before, as long as don't modify too much the dictionary.
414 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
415 * STYLE: ivars should start with a capital letter.
416 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
417 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
419 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
420 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
421 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
422 new 2004 dictionaries added (thanks to JPR).
423 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
424 * CLEANUP_ROUND (15) for gdcmPixelConvert
425 - RLEFrame::NumberFragments is now of type unsigned int
426 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
427 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
430 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
431 * Initial work in gathering all transfer syntax accessors. clearly
432 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
433 ivars, but only one transfersyntax (class) ivar with equivalent method on
436 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
437 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
438 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
439 discussed (plus I didn't like having a 2000 lines patch not commited)
441 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
442 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
443 * CLEANUP_ROUND (14) for gdcmPixelConvert
444 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
445 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
446 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
448 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
449 anymore and hence avoids storing a copy of PixelConvert::Decompressed
450 into File::Pixel_Data.
452 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
454 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
455 * CLEANUP_ROUND (13) for gdcmPixelConvert
456 Substituted File::ParsePixelData() with PixelConvert::Print() new
458 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
459 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
460 method to those classes.
461 - src/gdcmFile.[cxx|h]:
462 -- Added a ::Print() method.
463 -- PixelConverter is now a reference instead of a member.
464 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
465 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
467 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
468 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
469 collaboration diagram and inheritance diagram should be generated with
471 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
472 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
473 pointlessly wrapped (see
474 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
475 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
476 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
477 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
478 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
479 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
480 -- File::Initialise: PixelConverter setup moved away to
481 PixelConverter::GrabInformationsFromHeader()
482 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
483 interpretation moved away to PixelConverter::BuildRGBImage()
485 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
486 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
487 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
489 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
491 displayed on Win32 when a brutal abort() occurs (because of uncatched
492 exception). See TODO new entry of this commit for more on this.
493 * TODO added new entry.
494 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
495 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
496 - HandleColor is no longer called from gdcmFile.cxx
497 - gdcmPixelConvert.cxx clean up on method arguments and internal
498 variable names for semantical coherence.
500 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
501 * Finished lossless transition, not only do we now read all lossless jpeg
502 images, without the need of the Cornwell lib, but we do read them properly now
503 * To reduce code (well to avoid code duplication), I defined a common place
504 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
505 redefine symbols. This is not prefect but this the best solution I found for a
506 compilation time jpeg option.
508 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
509 * Update jpeg ijg lib to support lossless jpeg implementation
510 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
512 * Also added a special copyright for dcmtk since we use their bugfixes.
515 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
516 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
517 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
518 matters, as stated in warning note at begining of %include section).
519 * src/gdcmDicomDir*.[cxx|h]: coding style
520 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
521 * src/gdcmJpeg8.cxx: doxygen fix.
522 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
523 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
524 from File:: to PixelConvert::.
526 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
528 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
529 - more code moved away from File:: to PixelConvert::
530 - fat setup of PixelConverter set in place in File::Initialise.
532 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
533 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
534 namespace at the file system level. So now you should convert your examples
536 gdcmHeader -> gdcm::Header
537 It would be nice if people keep in mind to no open the namespace, since it
538 allows compilation on broken plateform which were defining common symbol in
539 the standart namespace (like LP, Unknown ...)
541 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
542 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
543 The JPEG fragments are now parsed at the same stage than the RLE
544 information. All code related to JPEG is now in gdcmPixelConvert:
545 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
546 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
547 export a gdcmFile:: method. Those are simply global functions
548 (for the time being this is better than having them attach to
549 either gdcmFile:: or gdcmPixelConvert::).
550 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
551 and stores the result in a gdcmJPEGFragmentsInfo.
552 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
553 code (among other stuff) moved away from gdcmFile:; to
556 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
557 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
558 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
559 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
560 clean up of RLE related code.
561 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
562 - src/gdcmRLE.cxx removed
563 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
564 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
565 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
566 * CLEANUP_ROUND (9) for gdcmPixelConvert
567 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
568 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
569 away from gdcmFile:: to gdcmPixelConvert::.
571 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
572 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
573 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
574 This is because Parse7Fe0 used to parse the pixels to compute the
575 length. This task was passed over to FindDocEntryLengthOB() a long
576 time ago, EXCEPT I had forgotten the OW case...
577 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
578 we just recylce the code for parsing RLE fragments and computing
580 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
581 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
582 with the retired Parse7Fe0().
583 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
584 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
586 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
587 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
588 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
589 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
590 - src/CMakeLists.txt: alphabetic order reodering + new entries.
591 * CLEANUP_ROUND (4) for gdcmPixelConvert
592 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
593 to return an unused length.
595 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
596 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
597 this should be cleanner from the plane view. The iostream are erally a pain
598 to use to do simple stuff.
600 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
601 * Redo the compilation of the ijg jpeg library. Now only one source is
602 necesseray. No need to rename file by hand what so ever. CMake handle the
603 copying of the file within different directory, configure header file to
604 modify some symbol. The only addition made to ijg wasd a mangle table so
605 that symbol are different wether we are within 8bits or 12bits.
607 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
608 * Added documentation of vtkgdcmReader on Website:
609 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
610 with it's binary name).
611 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
612 the Website to be more complete.
613 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
614 doxygenated documentation.
615 - Doc/DoxyVtkGdcmReaderExamples.txt added
616 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
617 DoxyVtkGdmReaderExamples.html )
618 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
619 * CLEANUP_ROUND (3) for gdcmPixelConvert
620 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
622 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
623 * CLEANUP_ROUND (2) for gdcmPixelConvert
624 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
626 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
627 * CLEANUP_ROUND for gdcmPixelConvert:
628 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
629 - src/gdcmPixelStuff[h|cxx] removed
630 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
631 - src/CMakeLists.txt changed accordingly
633 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
634 gdcmVersion.py moved to newly created ATTIC related
635 gdcmPython/SetupOldies/ directory.
636 * Autotools clean up:
637 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
638 - autogen.sh configure.in acinclude.m4 python.m4 removed
640 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
641 * src/*.cxx *.h Reference to License.htm fixed to License.html.
642 * Doc/CMakeLists.txt, doxygen.config.in: fix.
643 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
645 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * TODO updated with Mathieu suggestions. I proposed a template for
647 describing TODO entries and used it for new entries.
648 * Added Doc/Website/CodingStyle.html, Developpers.html,
649 DeveloppersPython.html, GdcmDataCvs.html and
650 DownloadVersion0_1.html, DownloadVersion0_3.html.
651 * Some Doc/*.txt Doxygen files (which do not really concern the
652 documentation itself, but the website) moved to html and
653 placed in directory Doc/Website:
654 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
655 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
656 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
657 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
658 * CMakeLists.txt changed accordingly.
659 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
660 DeveloppersPython.html
661 * INSTALL nows refers to Doc/Website/Installation.html
663 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
664 * Added Doc/Website directory, that contains a first raw version
667 2004-09-23 Jean-Pierre Roux
668 * FIX In order not to be poluted any longer by casting problems,
669 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
670 we can now delete[] it safely
671 * VoidArea is now called BinArea (less confusing name),
672 and all the methods called ...VoidArea... are now ... BinArea...
673 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
675 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
677 clear) TagHT, which is an inherited member of gdcmElementSet. It is
678 up to the destructor of gdcmElementSet to clean up TagHt and it's
681 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
682 * Test/CMakeLists.txt: update to follow gdcmData renamings.
683 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
685 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * ENH: added some utility method that builds a flat dictionnary
687 holding all the Dicom entries contained in the recursive structure
688 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
690 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
691 BuildFlatHashTable() that build a flat dictionary.
692 - src/gdcmElementSet.h: added a new private GetTag() accessor.
693 gdcmDocument is now a friend of gdcmElementSet.
694 - src/gdcmElementSet.cxx: clean up.
695 - Example/FlatHashTablePrint.cxx added.
696 - Example/CmakeLists.txt changed accordingly
698 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
699 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
700 moved away from gdcmDocEntrySet (since this class is an abstract class
701 acting like an interface). SQDepthLevel and BaseTagKey are now
703 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
704 and associated accessors. Doxygenation of the class.
705 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
707 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
708 Use SQDepthLevel accessor instead. ::Print() adapted.
709 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
710 - src/gdcmDocument.cxx changed accordingly.
712 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
713 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
714 - The following is the doxygen comment of the typedef declaration
715 of gdcmagKey in src/gdcmCommon.h:
716 gdcmTagKey is made to old an "universal" (as in URL, Universal
717 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
718 A dicom tag allways has a group and an element, but a set of tags
719 embeded in various (optionally nested) sequences and sharing
720 the same group and element all share the same (group, element)
721 "identifier". Hence the (group, element) cannot be used as an
722 identifier (in gdcm we shall refer to a "TagKey") of a tag.
723 In order to construct a proper tag identifier (i.e. a key) we
724 consider the following definition of a TagKey:
725 - let Group, Element be the string representation of the
726 group and element dicom tag members,
727 - let ItemNumber be the string representation of the integer
728 index of the considered item number of a sequence,
729 Let the key of a tag embeded in a sequence, noted SeqTag, be
731 /ItemNumber#Group|Element
732 where "/", "#" and "|" are characters acting as separators.
733 Then the general form of a gdcmTagKey is given by:
734 Group|Element<SeqTag>
735 where <SeqTag> means NO or many instances of SeqTag.
736 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
739 but the gdcmTagKey of a tag "embeded" is the first item of
740 a sequence, itself nested in the third item of a sequence is the
742 0004|1220/2#0008|0082/0#0008|0090
743 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
744 order to hold the new sequence compatible key. Previously, the
745 GetKey() method would look in the underlying gdcmDictEntry.
746 - src/gdcmDocEntry.cxx:
747 -- constructor now copies the underlying DictEntry key, in the local
749 -- ::Print: displays the member Key, instead of the (group, element).
750 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
751 - src/gdcmDocEntrySet.h:xi
752 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
753 -- now has a new BaseTagKey member.
755 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
756 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
758 This poses the problem with the semantics of the following lines
759 LoadEntryVoidArea(0x0028,0x1201); // R LUT
760 LoadEntryVoidArea(0x0028,0x1202); // G LUT
761 LoadEntryVoidArea(0x0028,0x1203); // B LUT
762 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
763 to the long FIXME note for what the problem is. Nevertheless in
764 order to get things working the dicom dictionary was altered !
765 Please fix things urgently...
766 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
767 information), see above note on moving the member VoidArea. Nevertheless
768 the following entries previously correctly set as US are now inproperly
770 0028 1201 OW IMG Red Palette Color Lookup Table Data
771 0028 1202 OW IMG Green Palette Color Lookup Table Data
772 0028 1203 OW IMG Blue Palette Color Lookup Table Data
773 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
774 of gdcmDocEntry moved to gdcmSeqEntry.
775 * src/gdcmSeqEntry.cxx: STYLE.
777 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * Test/TestAllEntryVerify.cxx minor fix and added comments.
780 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
781 * gdcmPython/testSuite.py: all the test suite in python is now moved
782 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
783 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
784 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
786 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
787 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
788 to avoid inclusion recursion until STL is reached.
789 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
790 mecanism. errno.h is not included in gdcm anymore.
791 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
792 (gdcmFormatError now inherits from gdcmFormatUnexpected).
794 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
795 gdcmData/TestAllEntryVerifyReference.txt
796 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
797 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
798 exception_on_error parameter.
799 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
800 - vtk/vtkGdcmReader.cxx changed accordingly,
801 - Example/*.cxx and Test/*.cxx changed accordingly.
803 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
805 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
806 enable_sequences removed from gdcmHeader constructor and dependencies.
807 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
808 * gdcmPython/demo/PrintHeader.py: dummy fix.
809 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
810 skip_shadow removed from gdcmHeader constructor and dependencies.
811 * Example/*.cxx and Test/*.cxx changed accordingly.
813 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
815 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
817 2004-07-21 Jean-Pierre Roux
818 * FIX Now, Parsing and Printing a DICOMDIR do work!
819 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
821 2004-07-20 Jean-Pierre Roux
822 * FIX Some brain damaged headers have Zero-Lenght fields
823 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
825 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
826 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
827 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
828 variable (instance of gdcmDebug) by a definition macro, and the instance
829 is now in static in the gdcmDebug class
830 * src/gdcmSQItem.h : (FIXME) remove an undefined method
831 * Test/PrintAllDocument.cxx : bug fix in the result of the test
833 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
834 * WARNING: ctest now depends more tightly on gdcmData. You should
835 check out gdcmData properly for things to run smoothly...
836 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
837 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
838 we need the pixels not be loaded in order to use the ValEntry
839 that displays position and size).
840 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
841 This is a C++ based equivalent of gdcmPython/testSuite.py that should
842 be deprecated. If you have any doubts about the advantages of a
843 modern scripting language (read Python) versus grass root C++ (i.e.
844 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
845 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
846 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
847 Anyhow, consider documenting the gdcmData images in
848 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
850 * Test/CMakeLists.txt:
851 - now uses TestAllEntryVerify.cxx
852 - specific comments on oldACR00001.ima (now renamed in gdcmData
853 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
854 gdcmData/TestAllEntryVerifyReference.txt
857 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
858 * src/*.[h|cxx] : typedef clean up
859 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
860 - TagKey renamed to gdcmTagKey (for external usage)
861 - VRKey renamed to gdcmVRKey (for external usage)
862 - removal of typedef duplication.
863 - Removed all unecessary inline keyword from class inline definitions.
864 - Some method|function(void) declarations replaced with method|function().
865 * src/jpeg/libijg12/jdhuff12.c:
866 - printf polluting ctest removed.
867 - TAB removal for comminting
869 - TestAllReadCompareDicom.cxx: added a test that compares all the
870 images in gdcmDataImages.h with corresponding images in
871 gdcmData/BaselineDicom/. When baseline images are not present
872 this test creates them.
873 Note: we need to validate each reference image, but before that
874 I'd like to rename them with a more explicit name...
875 - CMakeLists.txt: changed accordingly.
876 * Example/*.cxx: examples now only include gdcm.h (as opposed to
877 including each header needed).
879 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * Test/*.cxx and Example/*.cxx: moved some examples away from the
881 test suite to the Example directory. Are concerned:
886 - TestWriteSimple.cxx
887 * Test/CMakeLists.txt: added some comments on reasons for black listing
888 image gdcmData/oldACR00001.ima
890 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * Test/CmakeList.txt: removed the following from black list (to be coherent
892 with removal from gdcmData):
893 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
894 - gdcm-MR-PHILIPS-16.dcm
896 Added the following because after last cvs update, they cause
897 ctest -R TestReadWriteReadCompare
899 - gdcm-MR-SIEMENS-16-1.acr
901 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
902 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
903 new comments in this file) we temporarily (sigh) move to a weaker
905 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
906 we don't need to black list the following images anymore:
907 - 8BitsUncompressedColor.dcm
909 - US-PAL-8-10x-echo.dcm
910 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
911 fixes and the beautified code ;-)
912 This fixes the bug introduced in version 1.42 (when beautifying)
913 that made the parsing of 8BitsRunLengthColor.dcm unproper.
914 Note: ctest was blind to this bug (this means we need to still
915 improve the test suite). The bug could be detected by using
916 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
918 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
919 and by displaying the (garbage) produced file temp.XDCM...
921 2004-06-29 Jean-Pierre Roux
922 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
923 - replace by uggly but working old code :-(
924 A lot of things should be OK again.
925 It's really urgent to have a test suite that *tests*,
926 to prevent Frog's beautifying sessions to break all the stuff
927 (twice, withing a fortnigh ...)
929 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
931 redundancy) to added Test/TestReadWriteReadCompare.cxx
932 * Test/CmakeList.txt: because the compare test of
933 Test/TestReadWriteReadCompare.cxx fails, the following images are
934 black listed: - 8BitsUncompressedColor.dcm
936 - US-PAL-8-10x-echo.dcm
937 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
938 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
939 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
940 and ad-hoc kludge. This kludge is now removed, and on encountering
941 such an image (OB field brain damaged) we set errno. Then in
942 ::FindDocLength() we "fix" the length as being ALL what remains
943 in the file (until EOF). We then proceed, hoping for the best...
944 This fixes a SegFault in ShowDicom when trying to write such an
946 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
947 (because TestWriteRead breaks on it, after a non conformal commit?).
948 ctest now runs properly, except for MakeDicomDir (which was allways
949 broken) and the Python related stuff (still not fixed).
951 2004-06-24 Jean-Pierre Roux
952 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
953 FIX : Test/TestReadWrite now iterates on all the file names
954 (instead of infinite loop)
955 ENH : Test/TestWriteRead now iterates on all the file names
957 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
958 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
960 2004-06-24 Jean-Pierre Roux
961 FIX : - now Write drops LUT Descriptors and LUTs (if any)
962 when SamplesPerPixel =3
963 - now Write is no longer confused by
964 'BitsAllocated = 12" and 'BitsStored=12"
965 - "UN" value representation Elements are now written correctly
966 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
967 ENH : - now gdcmHeader has its own Write methods
968 (in order to split the job that has not to be done
971 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
973 loop on the same image until memory went out.
974 Note: this means we still have gobs of memory loss in PrintDocument
975 * src/gdcmDocument.cxx: fixes problem on parsing on file
976 gdcmData/16BitsJpegLosslessGrayScale.dcm.
978 2004-06-24 Jean-Pierre Roux
979 FIX : Write - All the Sequences and Sequence Item are now written
980 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
981 is added a the end, when necessary.
982 - A lot of brain-damaged images, that were read correctly are
983 now written correctly
984 - length compatible BinEntry are now loaded correctly
985 (even for odd groups)
986 Note : only Explicit Value Representation was checked.
987 (question : is implicit VR really necessary for gdcm ?)
989 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
990 * DEVELOPPER: added a proposition of coding style.
991 * src/gdcmDocEntry.h: removed every inline declaration (for test of
994 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
995 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
996 Use the gdcmDocEntry::Print() and Write() instead.
997 * src/gdcmDocument.cxx: bug fix.
999 2004-06-22 Jean-Pierre Roux
1000 FIX : gdcmDocument.cxx
1001 - Now we do recognize the JpegLossLess format (there was a misstyping in
1002 code 'beautyfication' :-(
1003 - Now we automaticaticaly load the Luts, if any
1005 2004-06-22 Jean-Pierre Roux
1006 In order : to write Sequences, whatever their imbrication level,
1007 : to allow user to create his own Sequences
1008 a lot of modif where necessary (adding, moving, or virtualising methods)
1010 WARNING : save your own sources *before* cvs up !
1013 ADD virtual void Write(FILE *fp, FileType filetype);
1016 ADD virtual void Write(FILE *fp, FileType filetype);
1017 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1020 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1021 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1022 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1023 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1024 ADD std::string GetEntryByName(TagName name);
1025 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1027 std::string vr = "unkn",
1028 std::string fourth = "unkn",
1029 std::string name = "unkn");
1030 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1031 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1032 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1033 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1034 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1035 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1036 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1037 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1040 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1041 ADD virtual std::string GetEntryByName (TagName tagName);
1042 ADD virtual std::string GetEntryVRByName (TagName tagName);
1043 REM virtual bool Write(FILE *, FileType);
1044 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1045 FILE *_fp, FileType type);
1046 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1047 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1048 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1049 REM virtual std::string GetEntryByName (std::string tagName);
1050 REM virtual std::string GetEntryVRByName (std::string tagName);
1051 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1052 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1053 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1055 std::string vr = "unkn",
1056 std::string fourth = "unkn",
1057 std::string name = "unkn");
1058 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1059 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1060 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1061 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1064 ADD virtual void Write(FILE *fp, FileType filetype);
1067 ADD virtual void Write(FILE *fp,FileType filetype);
1070 ADD virtual void Write(FILE *fp, FileType filetype);
1071 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1072 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1073 REM std::string GetEntryByName(TagName name);
1076 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1078 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1080 The default constructor invoked by the line
1081 gdcmHeader *f1 = new gdcmHeader( header );
1082 was gdcmHeader::gdcmHeader(bool) instead of the expected
1083 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1084 Hence the parsing wasn't executed... See also below.
1085 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1086 as explicit constructor didn't do the trick to fix the above problem.
1087 Could anyone explain why ?
1088 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1089 properly calls gdcmValEntry::Print() (that was weed out from
1090 code related to gdcmBinEntry).
1092 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1093 * In order to fix memory leaks:
1094 - Test/TestWriteSimple.cxx: added cleaning of free store through
1096 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1097 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1098 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1099 (through the call to ::AddDicomDirMeta()) or the destructor
1100 would crash when deleting uninitialized ::metaElems].
1101 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1102 - src/gdcmDocument.cxx:
1103 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1104 from dynamic stores.
1105 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1106 was causing memory leaks.
1107 - src/gdcmSQItem.cxx:
1108 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1109 cleanly handled with polymophism: sorry but my milage is low).
1110 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1111 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1112 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1113 This avoids SegFaulting.
1114 - src/gdcmSQItem.h: coding style.
1116 - Test/TestWriteSimple still severely sucks. The output image content
1117 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1118 damaged when displayed with vtkgdcmViewer.
1119 - on memory leaks: TestWriteSimple leaks really less (see entry
1120 of 2004-06-18 in Changelog file for the call to valgrind).
1121 - on segfaults: ctest now passes all the tests but one (no more
1123 * Erroneous leading white fix:
1124 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1125 white[s] (as opposed to from >> xxx, that removes it [them].
1126 - src/gdcmTS.cxx: ditto.
1127 - gdcmPython/testSuite.py: dirty related kludge removed.
1128 * src/*: remaining references to gdcmParser removed.
1129 * src/*[cxx|h]: added copy[way]left header.
1132 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * In order to fix writing of dicom files:
1134 - Test/TestWriteSimple.cxx: a simpler example of writing.
1135 - Test/CMakeLists.txt changed accordingly.
1136 - src/gdcmDocument.cxx:
1137 -- The destructor now recursilvely removes potential sequences.
1138 -- Bug fix in ::IsJPEG2000()
1139 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1140 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1142 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1143 to only declared) and build on top of
1144 ::GetDocEntryByNumber(guint16, guint16).
1145 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1146 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1147 for usage in destructor and treatement of promotion in
1148 ::ReplaceOrCreateByNumber().
1149 - src/gdcmSQItem.cxx: destructor should better handle his job.
1150 Test/TestWriteSimple now runs (or at least it DOES something).
1151 * We can now start hutting memory links. A good starting point is:
1152 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1153 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1154 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1156 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * Valgrind note: after Mathieu Malaterre teached me how to read
1158 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1160 Using gcc, you can force the STL to use malloc and to free memory as
1161 soon as possible by globally disabling memory caching.
1162 With 3.2.2 and later, you should export the environment variable
1163 GLIBCPP_FORCE_NEW before running your program.
1164 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1165 simply vanish (it is still not clear to me, whether this means that
1166 STL std::string leaks or if valgrind believes it leaks...).
1167 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1168 running bin/gdcmTests makeDicomDir):
1169 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1170 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1172 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1173 SegFaulting (I drowned in DicomDir related code when trying to
1174 understand why the list is empty...).
1175 * src/gdcmDocument.h: first BSD license header try.
1176 * Doc/License.txt added.
1178 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * src/gdcmDocument.[h|cxx]:
1180 - Clean up of the Transfer related predicates. They are now all based
1181 on new method isGivenTransferSyntax, that (should) handle properly
1182 the padding problem.
1183 - general clean up, simplification, and coding style.
1184 - Specific clean up of Parse7FE0() (umproperly named actually).
1185 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1187 2004-06-14 Jean-Pierre Roux
1189 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1190 - fix the display of SQItem ordinal number
1191 - add the GetSQItemByOrdinalNumber method
1192 - remove some useless never written private methods
1194 2004-06-14 Jean-Pierre Roux
1196 - adding a constructor taking a gdcmDocEntry as an input param
1197 - ReplaceOrCreateByNumber now returns :
1198 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1199 a gdcmValEntry * if a string value is passed as a param
1201 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1202 according to the param type (no longer sets a gdcmDocEntry)
1203 - GetValEntryByNumber, GetBinEntryByNumber added
1204 - NewValEntryByNumber and NewBinEntryByNumber added
1206 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1208 - GetSQItemNumber and SetSQItemNumber added, to provide
1209 a (relative) Item identier inside a given Sequence
1210 \warning : some pb remaining around this number
1212 - AddEntry now takes the Item Number as a param
1214 - adding a constructor taking a gdcmDocEntry as an input param
1216 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1217 * Memory leak hunt with the following command:
1218 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1219 --show-reachable=yes gdcmTests PrintDocument
1220 It looks like many (all?) leaks are due to the STL (or a bad usage
1221 of the STL. The lines producing the leaks now have a comment with
1222 a "MEMORY LEAK" tag: you can retrieve them with
1223 grep "MEMORY LEAK" src/*
1224 Here are two typical examples which I can't help fixing:
1229 char * test = "babo";
1230 name = test; //// <--- valgrind detects 960 bytes lost in
1231 //// call to std::string::operator=(char const*)
1232 name.clear(); //// Doesn't help !
1240 std::cout << "Type a bunch of characters followed by RETURN: ";
1241 getline(std::cin, line); //// <--- valgrind dectects a loss
1242 //// of 1320 bytes in call to
1243 /// std::basic_istream<>& std::getline<>
1249 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1250 * src/gdcmHeader.[cxx|h]:
1251 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1252 and related, moved away to gdcmDocument.
1253 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1254 the corresponding protected accessors of inherited class
1255 gdcmDocument, removed ! As a consequence gdcmFile had to be
1256 declared friend of class gdcmDocument (see below).
1257 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1258 - Clean up of undefined or unused methods.
1259 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1260 account the changes to gdcmHeader.h).
1261 * src/gdcmDocument.h:
1262 - gdcmFile is now a friend class (in order to take into account the
1263 changes to gdcmHeader.h).
1264 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1265 (see changes to gdcmHeader.h).
1266 - Accessors (reading on the form GetEntry*) are now public.
1267 - Clean up of undefined or unused methods.
1268 * src/gdcmDocument.cxx:
1269 - adaptation to changes to gdcmDocument.h
1270 - ::OpenFile now writes a verbose message when file cannot be opened.
1271 - some std::string properly set to VRKey
1272 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1273 references to gdcmDocument.
1274 * Test/TestFindTags.cxx: changed accordingly to above changes.
1275 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1276 cvs repository gdcmData.
1278 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1279 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1280 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1281 conflicts with gdcmValEntry::voidArea.
1282 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1283 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1284 Value representation between StringRepresentable and BinaryRepresentable.
1285 * src/gdcmDocument.cxx:
1286 - method ParseDES: proper indentation restored and usage of
1287 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1288 - method LoadDocEntry: the fingerprint left in the SetValue() of
1289 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1290 removed. Reverting to previous code segment with the proper
1291 dynamic_cast< gdcmValEntry* >.
1292 Note: this was (partially) breaking the python test suite
1293 (gdcmPython/testSuite.py) that made usage of the above
1294 fingerprint to check presence of "Pixel Data".
1295 * src/gdcmDocEntry.h: coding style.
1296 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1297 now taken into account.
1298 * gdcmPython/gdcm.i: adaptation to the new internal representation
1299 of gdcm (exit gdcmParser, hello gdcmDocument).
1300 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1302 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1303 anymore, but instead prints the loaded Python dictionary.
1304 * .... alas, the python testSuite is still broken.
1306 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1307 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1309 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1310 * src/gdcmUtil.h : export methods
1312 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1313 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1315 * Initial addition of automatic python testing
1316 * Initial addition of automatic image comparison
1318 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1319 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1320 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1322 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1323 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1324 * Test/ShowDicom.cxx : bug fix for msvc compilation
1325 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1327 2004-05-04 Jean-Pierre Roux
1328 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1329 new concepts (and new classes) :
1330 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1331 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1332 - Sequence Doc Entries (gdcmSeqEntries)
1333 a Sequence is composed of Items.
1334 Each item is a set of Doc Entries (this is recursive)
1335 The non uniqueness of the 'Dicom tag' is due to this recursivity
1336 (never taken into account)
1337 Our unability to add a new 'entry' in the header
1338 at the proper location (neither in the H-Table (map or multimap),
1339 nor in the Chained List is also due to this recursivity.
1340 Don't try, right now, to use/modify/compile these new sources :
1341 nothing is finished.
1342 We just commit all the stuff, 'as is', in order not to loose it.
1344 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1345 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1347 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1348 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1349 file prefix (SetFilePrefix)
1351 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1352 * Add a new test: ShowDicom, for now this is just the c++ version of
1353 checkRead.sh, later it will be able to compare the image read against a
1355 * Replace the DEBUG on the stack with a global entry in cmake interface:
1356 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1358 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1359 * Add an example subdir, with a real example on how to read + write a
1362 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1364 * Doc/CMakeLists.txt: the main page is now properly differentiated
1365 between the developper and user version.
1366 * Doc/doxygen.config.in: dropped search related obsolete flags
1367 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1369 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1370 * DEVELOPPER: added some helpfull comments for compile/test/install
1373 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1374 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1375 src directory, now generated in the build dir.
1376 2. Tests as mentionned smarter
1378 4. Add a new method in gdcmDict that return the PubDict by name
1379 this is interesting for 3rd party lib like ITK,
1380 where we could set the institution name / patient name...
1382 * ENH: 1. Now the test suite is working for real
1383 2. All binaries are now output in the gdcm-bin directory
1384 (this was not true before)
1386 2004-04-28 Jean-Pierre Roux
1387 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1388 SeQuence indented printing of Dicom Header.
1389 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1390 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1391 Computation of SQDepthLevel is now part of gdcmHeader constructor
1392 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1393 tree-like structure of a Dicom Header.
1394 * FIX Test code cleaning
1396 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1397 * ENH: Adding automatic testing
1398 1. Need a DartConfig.cmake to submit to public
1399 2. Add a test driver gdcmTest.cxx
1400 3. gdcmTestMain, an helper for the main test driver gdcmTest
1401 4. Files in Test don't have a main anymore, this becomes interesting
1402 when we add more and more tests, thus dsw don't have to load
1404 * ENH: Adding a GDCM_DATA_ROOT for testing
1405 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1406 one file instead of seven + some small cleanup
1408 2004-04-22 Jean-Pierre Roux
1409 * ENH Minor changes to the Print() methods.
1410 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1411 Header printing. Example given with :
1412 > PrintHeader fileName 2 new
1413 (SQ based tree-like structure still to be done for the Header ...)
1415 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1416 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1417 1. I have added some unsigned where needed
1418 2. Some function parameter not used -> (void)
1419 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1420 4. g++ don't like character '\' in comment
1421 5. #define jpeg_create_decompress jCreaDecompress
1422 this really need to be fixed
1423 6. virtualize destructor of gdcmObject ... leakage
1424 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1425 this also really need to be fixed
1426 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1427 remove compression file
1428 (as we only do decompression, right ?)
1429 * ENH: Change malloc/calloc/free with c++ equivalent
1431 2004-04-21 Jean-Pierre Roux
1432 * FIX gdcmHeaderHelper::GetXSpacing
1433 when a single value is found (bug ?), xpacing is now
1434 defaulted to yspacing
1436 2004-04-19 Jean-Pierre Roux
1437 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1438 * ENH add parameters :
1439 bool exception_on_error = false,
1440 bool enable_sequences = false,
1441 bool ignore_shadow = false
1442 to the gdcmFile constructors to be full gdcmParser compliant
1443 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1444 to allow reading of PAPYRUS 3.0 files
1446 2004-04-06 Jean-Pierre Roux
1447 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1449 2004-04-02 Jean-Pierre Roux
1450 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1451 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1452 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1454 2004-03-30 Jean-Pierre Roux
1455 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1456 for ACR file, written out as DICOM files (hope so...)
1458 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1459 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1460 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1461 moved to base class gdcmParser and only the specialisation is kept
1463 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1464 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1465 already does the job.
1466 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1467 (to be consistent with gdcmParser::WriteEntries).
1469 2004-03-30 Benoit Regrain
1470 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1471 upate of the object's instance. It's passed to 2 in the unfavorable
1472 case : one in the ExecuteInformation, one in the ExecuteData
1474 2004-03-29 Jean-Pierre Roux
1475 * ENH : Check on file type to be written moved
1476 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1477 * FIX : gdcmObject::ResetBoundaries now stops properly
1478 when end-of-list is reached
1479 : gdcmVersion modified (as Benoit Regrain asked)
1481 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1482 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1483 * src/gdcmUtil.cxx: added forgotten iostream include.
1484 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1485 equivalent to ExplicitVR in existing code).
1487 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1488 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1489 now contains all the gdcmGlobal related code.
1490 * minor coding style and doxygenation changes.
1492 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1493 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1494 now contains all the Debug related code.
1495 * minor clean-up of includes in src/*.cxx
1496 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1497 CreateCleanString) removed.
1498 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1499 * Doc/DoxyMainPageUser.txt added.
1500 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1501 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1502 src/gdcmDirList.cxx)
1504 2004-03-24 Jean-Pierre Roux
1505 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1507 2004-03-23 Jean-Pierre Roux
1508 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1509 big endian made volumes
1510 * ENH Now gdcmParser constructor and destructor are protected to forbid
1511 end user to instanciate class gdcmParser
1512 (only gdcmHeader and gdcmDicomDir are meaningfull)
1514 2004-03-22 Benoit Regrain
1515 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1516 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1517 gdcmSerie to gdcmDicomDirSerie
1519 2004-03-19 Jean-Pierre Roux
1520 * ENH Now the tree-like structure describing a DICOMDIR comming from
1521 an already existing DICOMDIR file is consistent with
1522 the home-made tree-like structure build ex-nihilo
1523 or build from the files held (recursively) in a Directory
1524 functions gdcmDicomDir::CheckBoundaries()
1525 gdcmObject::SetBoundaries() added
1527 2004-03-17 Jean-Pierre Roux
1528 * REM (Eric Boix bug) : removal of meaningless
1529 gdcmDicomDirImage::NewImage function.
1530 * FIX now file names and directory name are written properly in the
1532 * FIX now gdcmDicomDir constructor may be call without any trick
1535 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1536 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1537 of gdcmDicomDirImage::NewImage as empty function.
1539 2004-02-28 Jean-Pierre Roux
1540 * ENH add gdcmDicomDir:NewPatient
1541 add gdcmDicomDirPatient:NewStudy
1542 add gdcmDicomDirStudy:NewSerie
1543 add gdcmDicomDirSerie:NewImage
1544 to allow making gdcDicomDir object.
1545 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1546 (as opposite to the gdcmHeader chained list)
1548 2004-02-11 Benoit Regrain
1549 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1550 when using from python
1552 2004-02-10 Benoit Regrain
1553 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1554 * FIX : in gdcmDicomDir when the directory is empty
1555 * ENH : add callback and methods to get the progression of dicomDir
1558 2004-02-06 Jean-Pierre Roux
1559 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1560 - GDCM_META added to gdcmDicomDirType
1561 - class gdcmMeta created
1562 * ENH : - A brief summary is now displayed at the beginning of
1563 'testDicomDir' to help disaster magnitude estimation
1564 * REM : Now useless Test/explDICOMDIR.cxx
1566 2004-02-05 Benoit Regrain
1567 * ENH : add methods in gdcmObject to get the hash table or the list of
1569 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1570 * FIX : wrapping python for TagHeaderEntryHT
1572 2004-02-04 Benoit Regrain
1573 * FIX : even length for some strings when writting the dicom dir
1574 * FIX : sort the images in the dicom dir
1575 * FIX : Bug fix for python use of dicom dir
1576 * ADD : a python demo
1578 2004-02-04 Jean-Pierre Roux
1579 * FIX : Final solution (?) for icone embedded images
1580 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1581 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1582 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1583 gdcmData/gdcm-MR-SIEMENS-16.acr1
1584 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1585 to make full checking easier
1587 2004-02-04 Benoit Regrain
1588 * FIX : WriteEntries : coding style & logic in parameters
1589 * FIX : Set the elements to create the DicomDir in a dictionary file
1591 2004-02-03 Benoit Regrain
1592 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1593 * gdcmDicomDir : add the load of directory
1594 * Bug fix and print add-on
1596 2004-02-03 Jean-Pierre Roux
1597 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1598 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1599 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1600 * FIX gdcmParser.cxx : 'group length' elements are now considered
1601 as integers, even for shadow groups, when file is Implicit VR
1603 2004-02-02 Jean-Pierre Roux
1604 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1606 of the last synonym :-(
1607 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1609 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1610 * FIX taking into account the possible 7fe0,0010 multiplicity
1611 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1612 to allow removal of references to 7fe0,0010, to deal with
1613 ACR-NEMA images, when 0028,0200 is meaningfull
1615 2004-01-31 Jean-Pierre Roux
1616 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1617 no longer writes 'Un' on disk
1618 * FIX SQ elements with actual length are now dealt with corectly
1619 * FIX gdcmFile::WriteBase make the difference, for color images, between
1620 the length (for Palette expanded images)
1621 and Raw Length (non expanded image + Palette)
1622 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1623 (that broke Write). Replaced by UL.
1624 Aware user will reload the field if he
1625 thinks it's necesssary
1627 2004-01-30 Jean-Pierre Roux
1628 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1629 when 'dirty Acr' is found, to be compliant with the new
1630 IsReadable() methods.
1632 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1633 (no DOUBLE images in kosher DICOM,
1634 but so usefull for people that miss them ;-)
1636 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1637 DICOMDIR related utilities (not checked as Windoze compliant)
1639 2004-01-28 Jean-Pierre Roux
1640 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1642 2004-01-27 Jean-Pierre Roux
1643 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1644 to allow skipping the shadow elements, to save memory space.
1645 The TRUE value for this param has to be used
1646 with a FALSE value for the 'enable_sequence' param.
1647 ('public elements' may be embedded in 'shadow Sequences')
1648 * gdcmHeader methods now deal with 'embedded icones images' in the header
1649 (even when an 'icone image sequence' is announced by the
1650 element (0x0088,0x0200), but there is NO icone at all ...
1652 * gdcmHeader sometimes Image Location value doesn't follow
1653 the supposed processor endianity (see gdcmData/cr172241.dcm).
1656 * gdcmHeader add the method
1657 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1658 to get *all* the Header Entries with the same tag.
1659 GetHeaderEntrySameName is probabely *useless*
1660 (no meaning : Name is *not* an identifier within the Dictionnary)
1662 2004-01-26 Benoit Regrain
1663 * Bug fix in the print of hexadecimal representations. Remove long fields
1664 in the print and add a third level of print to print them
1666 2004-01-23 Benoit Regrain
1667 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1668 * Bug fix on test suite after remove the strip made on not string fields
1669 * Split the IsReadable method between gdcmParser which test that the file
1670 is dicom and gdcmHeader which test that it's an image file
1672 2004-01-22 Benoit Regrain
1673 * DicomDir : clean code, add methods, set variables in protected or private
1674 * gdcmUtil : bug fix for the clean string method
1676 2004-01-19 Benoit Regrain
1677 * Add the use of shadow dictionaries
1678 * bug fix and coding style
1680 2004-01-19 Benoit Regrain
1681 * src/gdcmFile.cxx : bug fix concerning the close of file
1682 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1683 * Add the update of header entries using the shadow library
1685 2004-01-19 Benoit Regrain
1686 * removal of file gdcmHeader2.cxx
1687 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1688 inheriting from gdcmParser. This split is to prepare the integration
1689 of dicom dir parsing
1690 * bug fix under python
1692 2004-01-16 Jean-Pierre Roux
1693 * REM removal of class gdcmHeaderEntrySet
1694 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1695 * ADD add file gdcmHeader2.cxx
1696 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1698 2004-01-15 Benoit Regrain
1699 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1700 entries created while parsing the header. Thus, they will be destroyed
1701 when the gdcmDictSet will be destroyed
1702 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1705 2004-01-15 Benoit Regrain
1706 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1707 made a fatal error because of the memory release at the end of program.
1708 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1709 some memory and vtk seems to have some problems with that.
1710 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1712 2004-01-14 Benoit Regrain
1713 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1714 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1715 * src/*.[h|cxx] : make changes due to class name changes
1716 * gdcmPython/demo/*.py : bug fix due to method names
1718 2004-01-13 Benoit Regrain
1719 * src/*.[h|cxx] : coding style
1720 * vtk/*.[h|cxx] : coding style
1722 2004-01-13 Benoit Regrain
1723 * gdcmPython/testSuite.py : test the readable flag of file for tests
1724 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1725 It's lied to the stl compilation by MSVC (windows, always windows...)
1726 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1728 2004-01-12 Benoit Regrain
1729 * src/*.h : add comments
1730 * src/gdcmDictSet.h : set the method BuildDictPath in public
1731 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1732 directly setted in the source code
1733 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1736 2004-01-09 Benoit Regrain
1737 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1738 * setup.py : use a reference to gdcmVERSION
1740 2004-01-07 Benoit Regrain
1741 * Modification to compile with the distutils.
1744 2003-12-10 Benoit Regrain
1745 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1746 can use a gdcmHeaderHelper to load datas
1747 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1748 made in the source code
1750 2003-12-10 Benoit Regrain
1751 * Update Windows projects and .cvsignore files
1753 2003-11-12 Jean-Pierre Roux
1754 * ENH gdcmHeader constructor has one more parameter (default value : false)
1755 that allows the user to 'go inside' the SeQuences only
1757 gdcmElValSet:Print takes it into account
1759 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1760 * ENH: Update gdcmPython/CMakeLists
1761 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1762 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1764 2003-11-10 Jean-Pierre Roux
1765 * FIX : gdcmHeader::LoadElements is now based
1766 on the ListTag listElem member,
1767 not longer on the TagElValueHT tagHt member
1768 * ENH : PrintPubElVal shows (temporarily) both results,
1769 with the tagHt member and the listElem member.
1770 (it's easier to 'see' the problems when using Printheader)
1772 * FIX : old private member LgrElem is now splitted into
1773 ReadLength : Length actually found on disk (updated only
1774 if bug fixing is necessary), for internal
1776 UsableLength : Updated by FixFoundLength, to fix a bug
1777 or to allow Parser going on.
1778 Will allow to re-write a kosher header when a SeQuence
1779 with a length (not 0000) is found
1780 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1781 because gdcmElValSet::Add does not update ListElem
1784 2003-11-07 Jean-Pierre Roux
1785 * FIX misstyping in Transfert Syntax name table
1786 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1787 when they have an actual length (not 0000 nor FFFFF)
1788 (Nobody should care of it, but DICOMDIR explorers)
1790 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1791 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1793 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1794 * ENH: vtkGdcmReader now supports LUT !
1795 (vtkgdcmViewer for now is not able to use them though)
1797 2003-11-05 Jean-Pierre Roux
1798 * in testSuite.py : new files names for checking the package
1799 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1800 that returns the pixel area size to the *aware* (vtk) user
1801 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1803 2003-11-05 Benoit Regrain
1804 * in testSuite.py : Modify the rules for checking the paths
1805 : Explicit error messages
1806 * in __init__.py : Related modif
1808 2003-11-03 Jean-Pierre Roux
1809 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1810 to be used by aware (vtk) users that want to manage
1811 LUT (and no to turn the PALETTE image into an RGB pixels one)
1812 * GetPixelType now returns 8U for 24 Bits images
1813 (vtkGdcmReader compliant)
1815 2003-10-31 Jean-Pierre Roux
1816 * Removal of *all* gdcmData images and add them again
1817 in order to loose the 'history' of un-anonymised images
1819 2003-10-31 Jean-Pierre Roux
1820 * RMV : removal of useless jBitsInJsample.h
1821 for both 8 and 12 Bits JPEG Lossy Libraries
1823 2003-10-31 Jean-Pierre Roux
1824 * ENH : Add the functions gdcmFile::GetImageDataRaw
1825 gdcmFile::GetImageDataIntoVectorRaw
1826 that act as GetImageData and GetImageDataIntoVector
1827 except the making of an RGB Plane from Gray Plane + LUT
1828 Intended to aware (vtk) users who know how to manage
1831 GetLUTRGBA return a R,G,B,A LUT if any
1832 lgrTotaleRaw gives the 'Raw' length
1833 GetImageDataRaw returns the gray Plane
1834 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1835 (They stay Grey, just like with other Dicom viewers :-(
1837 2003-10-30 Jean-Pierre Roux
1838 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1840 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1842 being coherents dicom files.
1844 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1845 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1847 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1848 * ENH: Two steps is necessary to please VC++ compiler...
1849 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1850 * ENH: Add include dir to medcon lib
1851 * FIX: only one function is being exported for now !
1852 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1854 2003-10-29 Jean-Pierre Roux
1855 * adding gdcmHeader::GetLUTRGBA
1856 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1857 --> Mathieu, the modif u're waiting for is not yet committed
1858 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1860 2003-10-27 Jean-Pierre Roux
1861 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1862 00191113.dcm DermaColorLossLess.dcm
1863 MxTwinLossLess.dcm RadBWLossLess.dcm
1864 * ENH: For version prior to vtkImageViewer2 -r 1.19
1865 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1867 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1868 * Removal of ido stuff in CMakeLists.txt
1870 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1872 * FIX: remove a call to ->Modified ... see comments
1873 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1875 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1876 * FIX: Problem with path for libvtkgdcmPython
1877 * ENH: Try adding a search script for python site-package
1878 * RMV: Remove some file from medcon lib that are not necessary
1879 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1880 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1881 * FIX: More pragma disable fro VC++,
1882 I don't think I break something as it is also disable in VTK/ITK.
1883 But it fasten debug compilation time.
1885 2003-10-23 Jean-Pierre Roux
1886 * gdcm now deals with 16 Bits Run Length Encoded images
1887 (they are compressed as 2 planes images,
1888 one for the high Bytes, the other for low Bytes)
1890 2003-10-22 Jean-Pierre Roux
1891 * Now CheckRead takes into account :
1892 - the bugged 'Leonardo' Siemens images
1893 - the XA images, sent thru the burning VPRO station
1894 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1897 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1898 * FIX: When copying a Makefile.am to CMakeLists.txt
1899 one should remove the '\'
1901 2003-10-22 Jean-Pierre Roux
1902 * in gdcmData adding a bugged 'Leonardo' Siemens image
1903 (wrong lengths in header)
1904 OK with gdcm, KO with the other viewers :-)
1905 * add a GE dlx XA image, thru the VEPRO burning station
1908 2003-10-21 Jean-Pierre Roux
1909 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1910 for a brutal checking of vtkgdcmViewer compliance
1912 2003-10-21 Jean-Pierre Roux
1913 * add the files for 'xmedcon' Jpeg Lossless library
1914 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1916 2003-10-21 Jean-Pierre Roux
1917 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1919 2003-10-21 Jean-Pierre Roux
1920 * garbage Siemens 'Leonardo' images dealt with
1921 (the patch is easy to remove)
1922 * cosmetic changes to avoid warnings
1924 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1925 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1926 no need to press 'r' now.
1928 2003-10-20 Jean-Pierre Roux
1929 * upgrade of checkRead.sh checkWrite.sh according
1930 to new Jpeg Lossless decompressor
1931 * add US.3405.1.dcm, a genuine RGB medical file ...
1932 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1933 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1935 2003-10-15 Jean-Pierre Roux
1936 * general anonymisation in gdcmData
1937 * adding the 'color files' from
1938 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1939 * adding some well knowed bugged-header images
1940 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1941 waiting for their inclusion in Python testsuite
1943 2003-10-15 Jean-Pierre Roux
1944 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1945 no longer seg faults when file is not found
1947 2003-10-14 Jean-Pierre Roux
1948 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1951 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1952 * TODO: *.in file to genereate a UseGDCM later
1954 2003-10-14 Jean-Pierre Roux
1955 * Some supposed-to-be Dicom Images have no preamble.
1956 OpenFile takes it into account
1957 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1958 * Missing elements added in dicomV3.dic
1959 (just to be affraid : have a look at
1960 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1961 and do it again next year ;->
1963 2003-10-13 Jean-Pierre Roux
1964 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1965 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1966 But there are NOT. It's fixed !
1968 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1969 * FIX: "jpeglib.h" was not found on VC++
1970 * FIX: vtkgdcm was not being installed
1972 2003-10-10 Jean-Pierre Roux
1973 * ENH : OpenFile closes the file if it *really* doesn't look like
1974 an ACR-NEMA / DICOM one.
1975 * FIX : testWrite no longer writes an empty file if the source file
1976 is not gdcm Readable
1977 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1980 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1981 * FIX: CMake generate now documentation
1982 * ENH: out of source doc build !
1983 * ENH: Generate both user and dev documentation
1984 * ENH: Should work on windows too
1985 * ENH: Only one doxygen config.in file is needed
1986 * FIX: make install should be ok now on ùnix plateform
1987 * FIX: PATH to dictionary was wrong (missing /)
1988 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1990 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1991 * vtkGdcmReader is now able to read rgb dicom file.
1992 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1993 * added a gdcmViewer to vtk test, use mouse to control
1994 window level & window width
1996 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1997 * CMake-ification of gdcm, we have now two build system
1998 * FIX: on cygwin Wsock32 doesn't exist
1999 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2001 2003-10-06 Emanuel Ollart
2002 * FIX : compilation process wad broken.
2003 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2005 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2006 * change gdcmViewer -> vtkgdcmViewer
2007 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2009 2003-10-06 Jean-Pierre Roux
2010 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2011 ( e.g : well known GE images with a wrong elem length,
2012 : Philips MRI Images with a wrong Huffman table)
2013 * still to be done : allow the reading of bugged LEONARDO Siemens images
2015 2003-10-03 Jean-Pierre Roux
2016 * Odd length strings are padded with '\0' (not with spaces,
2017 to remain compliant with already defined strings,
2018 like Transfert Syntax UID and others)
2020 2003-10-03 Jean-Pierre Roux
2021 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2022 to allow displaying RGB images (not only by affim ;-)
2024 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2025 * vtkGdcmReader is now able to read rgb dicom file.
2026 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2028 2003-10-03 Jean-Pierre Roux
2029 * A few nasty patches to allow the reading of a lot of nasty images
2030 ( e.g : well known GE images with a wrong elem length,
2031 : Philips MRI Images with a wrong Huffman table)
2032 * still to be done : allow the reading of bugged LEONARDO Siemens images
2034 2003-10-03 Jean-Pierre Roux
2035 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2037 2003-10-03 Jean-Pierre Roux
2038 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2039 to allow displaying RGB images (not only by affim ;-)
2041 2003-10-03 Jean-Pierre Roux
2042 * gdcmFile::GetImageDataIntoVector now
2043 - deals with MultiFrames MultiFragments Run Length Encoded files
2044 - deals with YcBcR (YBR_FULL) files
2045 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2046 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2048 (no sample found :-(
2050 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2051 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2052 Two reasons: - clear things
2053 - third parties acces gdcm through header files, so won't
2054 suffer anymore VC++ complains
2056 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2057 * add argv[1] in testvtkGdcmReader.cxx
2060 2003-09-24 Jean-Pierre Roux
2061 * The lines are now eigthy characters long.for
2062 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2064 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2065 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2066 char* to std::string. Thus, the use of strdup becomes useless. (see
2067 previous commis of Malaterre)
2068 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2069 before the last Malaterre's commit.
2071 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2072 * This commit should fix the Debug building under VC++, the problem
2073 was mainly a mixture of debug and release lib being loaded at startup.
2074 * I also remove a depency to a specific C function: strdup. Because I had
2075 to force the link to msvcrtd (whereas strdup is in libc).
2077 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2078 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2079 located in the gdcmCommon.h file. All use of reference of tha has been
2080 changed to now use the variable GDCM_UNFOUND.
2082 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2084 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2085 Dicom dictionary. The test suite can now be run again. Note:
2086 I'm note very happy with the " (RET)" changes. I believe this
2087 RETAINED comment should be dropped when parsing the dictionary.
2088 - PACKAGER corrected
2090 - AUTHORS updated and now in alphabetical order
2091 * Makefile.am now exports gdcm.dsw for Windoze users.
2093 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2094 * cygwin complains about missing std:: in subdir Test/
2096 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2097 * remove some methods that are now in gdcmHeaderHelper
2099 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2100 * vtkGdcmReader set spacing and origin correctly
2102 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2103 * Fix a few delete/delete[] mismatch
2105 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2106 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2107 interpretation to data given by gdcmHeader. For instance there are
2108 heuristics to get informations (look at different places).
2109 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2110 sorting DICOM images based on different strategies.
2111 * modified Makefiles accordingly.
2113 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2114 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2115 when building in debug mode
2116 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2117 src/win32/gdcmdll.dsp
2118 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2120 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2121 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2124 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2125 * src/win32/libgdcmjpeg12.dsp was not dos format
2126 * src/win32/libgdcmjpeg12.dsp :
2127 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2128 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2130 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2131 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2133 * src/gdcmFile.cxx : bug fix in affectation type
2134 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2135 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2136 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2137 symbols... future problem ?
2139 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2140 * src/win32/libgdcmijpeg12.dsp was missing
2141 * modified gdcm.dsw accordingly
2143 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2144 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2146 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2147 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2148 commit of JPR (before his hollidays to facilitate our work).
2149 * setup.py : bug fix in code. Modifications made while the last commit
2150 of JPR. The code hasn't been tested before the commit... it's so
2151 useless to make that (for best programmer that is JPR) !!!
2153 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * tagged the current version as Version0_3 (i.e. version 0.3)
2156 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2157 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2158 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2159 * *.dsp : modifications to use new libgdcmijpeg8 library
2160 * setup.py : bug fix on VTKPATH variable
2161 * PACKAGER : adding all concerning windows
2163 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2166 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2167 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2168 test suite reported error.
2169 * PACKAGER file added (describes what a packager must do when
2170 packaging a new release).
2171 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2172 * configure.in: upgraded version number to 0.3.0
2173 * fixing build of rpm (through rpm -ta):
2174 - Doc/Makefile.am exports proper doxygen files
2175 - src/jpeg/libijg8/Makefile.am exports the include files.
2177 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2178 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2179 * src/gdcmHeader.h : formatting code
2181 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2182 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2183 We were obtaining error message from vtk. Now, creation of file list
2184 is made in an internal list to prevent this problem.
2185 Bug fix when output is empty.
2186 Bug fix in update of progress value. Previous commit for this was a bad
2188 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2190 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2191 * src/gdcmHeader.h : added method to get the file name
2192 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2193 files. Added method to remove all files on the input
2194 Added FIXME comment concerning the bad parsing of header made by
2195 ExecuteInformation method (in ExecuteData method)
2197 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2198 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2199 when using make instal.
2200 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2201 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2203 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2204 * setup.py : adding include dir of jpeg lib to compile all sources
2205 * */Win32/*.dsp : JPR fix for windows compilation
2207 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2208 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2210 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2211 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2213 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2214 * setup.py is again effective on un*x (takes into account the
2215 addon of the jpeg library)
2216 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2217 * Doc/Doxy* updated (includes above enhancements)
2218 * INSTALL now points to web documentation
2220 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * src/gdcmHeader.h doesn't make unnecessary reference to
2223 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2225 * src/gdcm*.[cxx|h] :
2226 - to allow compilation with gcc 3.x
2227 -- clean up of STL usage (added explicit usage of std::)
2228 -- small fixes on exceptions.
2229 Note: linking not tested !
2230 - clean of doxygen comments to avoid warnings at documentation
2232 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2233 dependent convertion).
2235 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2236 * Clean up of previous JPR garbage commit (not even commented in the
2238 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2239 - moved all jpeg related files from src to src/jpeg/libijg8, with
2240 addition/modification of Makefile.am and configure.in.
2241 - the testSuite is still brain damage (not guilty).
2243 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2244 * WrapVTK.py : modifications to get correctly vtk source files to
2246 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2247 (FileName -> Filename)
2249 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * vtk/vtkGdcmReader.[cxx/h]:
2251 - UpdateProgress method should now be effective
2252 - removed the limitation on having only images loaded (as opposed
2254 - when building a stack of images/volume, a lesser number of
2255 gdcmHeader and gdcmFile instances should be used (hopefully
2256 accelerating things).
2257 - when building a stack of images/volumes, files which are not
2258 loadable (wrong path-filename, wrong permissions on existing file,
2259 or file not parsable by gdcm) are replaced with a black image
2260 in the stack (for the caller to notice the problem).
2262 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2265 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2266 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2267 between standard library (std) and vtk library (problems are found
2268 under Windows... thanks Windows !)
2270 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2271 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2273 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2275 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2276 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2278 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2279 * When compiling with distutils (see setup.py) the C++ compiler is
2280 called with different flags than the default ones (with automake).
2281 In order to fix all those warning, I compiled gdcm with the command
2282 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2283 and went for warning fixes:
2284 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2285 up from unused variables.
2286 - vtk/vtkGdcmReader.cxx: potential bug fix.
2287 * src/gdcmHeader.h: Doxygen warning cleanup
2289 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2290 * gdcmPython/gdcm.i:
2291 - typemaps correction to take into account the systematic replacement
2292 of "using namespace std" with std:: prefix e.g. std::list,
2293 std::string... (cf changes of 2003-05-21).
2294 - gdcmGlob global variable of type gdcmGlobal (defined in
2295 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2296 exported to Python a as cvar.
2297 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2298 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2299 gdcmDictSet.GetPubDictTagNames() and
2300 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2301 C++ static methods).
2302 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2303 with the above changes.
2305 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2306 * setup.py, manifest.in : bug fix under linux
2308 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2309 * Modification of setup.py to compile vtk part too. Then, we have 2
2310 wrappers which must work with same distutils. For that, we have a
2311 generic distutils in distusiltsWrapping.py ; with :
2312 - build_extWrap class to wrap generically all extensions,
2313 - ExtensionWrap base class for all wrapping extension that contains
2315 - Wrapper interface which wrap sources
2316 + In WrapSwig.py we have extension and wrapper for Swig
2317 + In WrapVTK.py we have extension and wrapper for VTK
2318 * MANIFEST.in : modifications to consider vtk directory and new python
2319 files for compilation
2321 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2322 * Added python wrappers of vtkGdcmReader vtk class (see the
2323 source in vtk/vtkGdcmReader.cxx) :
2324 - vtk/Makefile.am now builds a library
2325 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2326 python library (as opposed to _gdcm.so wich are the python
2327 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2328 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2330 - configure.in has an additional flag --enable-vtk that needs
2331 to be set to enable compilation of vtk related code, that is:
2332 + vtk/vtkGdcmReader.so and
2333 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2334 + gdcmPython/vtkgdcmPython.so (see above)
2335 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2336 be read when compressed or when HighBit + 1 != BitsStored),
2337 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2338 the usage of the python wrapper of vtkGdcmReader vtk class.
2339 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2340 * src/*.[h] all occurences of stl classes are now prefixed with
2341 std::, and all occurences of "using namespace std;" where removed.
2342 This is to avoid pollution of global namespace in included files.
2343 Apparently vtk does not avoid this pitfall: when using both
2344 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2345 collision of various stl members (principally cout...).
2346 * gdcmPython/testSuite.py now cleanly removes temprory generated
2348 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2349 comply with above changes)
2351 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2352 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2353 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2354 vtk data structure (an image Flip was required).
2355 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2356 * cosmetic changes in documentation.
2358 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2359 * src/gdcmHeader.cxx: the constructor no longer exits when an
2360 unexisting file is given as argument.
2361 * The subdirectory Data (containing all the images used for the
2362 test suite) is not part of this repository anymore. A new module
2363 containing those images is now available at
2364 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2365 with the name gdcmData.
2366 All the python scripts (including the package initialisation file
2367 gdcmPython/__init__.py) were adapated to take this change into
2368 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2370 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2371 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2372 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2373 demo of the usage of this class.
2374 Compilation of this vtk part is only done when using the --enable-vtk
2375 at configure (or autogen.sh) stage.
2377 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2378 * More memory link related corrections and documentation fixes.
2380 - maximum info is obtained with a command of the form:
2381 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2382 --show-reachable=yes PrintHeader
2383 - the remaining reachable blocks seem to come from the STL
2384 allocation scheme through the usage of map and list. It looks
2385 like this memory cannot be freed but it is not a memory leak
2386 (in fact further invocation to the STL would recollect the
2387 unused memory allthough it cannot explicitely be freed).
2388 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2389 of displaying an image parsed with gdcm and displayed with VTK.
2390 Note: some images don't seem to work e.g.
2391 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2392 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2393 Allthough this weakens the semantics, it is a ditch attempt to
2394 make gdcm more thread friendly.
2396 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2397 * Memory link hunt (by using valgrind through the command
2398 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2399 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2400 gdcmHeader::_dicom_vr.
2401 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2402 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2404 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2406 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2407 * src/Makefile.am now exports all the necessary include files at
2411 * UpdateGroupLength replaced by new one
2414 * UpdateGroupLength re-written using H-Table
2415 (named UpdateGroupLengthNew untill checks are over)
2417 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2418 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2419 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2421 - gdcmHeader::GetPubElValSet removed.
2422 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2423 UpdateGroupLength, WriteElements, Write.
2424 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2425 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2426 carried the same semantics.
2427 - src/gdcmHeaderIdo.cxx changed accordingly.
2428 - gdcmFile::WriteBase now regroups all the codes from previous
2429 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2430 - enum FileType moved to gdcmCommon.h
2431 * src/gdcmHeader.cxx AddDefault trashed
2432 * gdcmGetXSize added
2433 * getimageDataSize now calls gdcmGetXSize
2434 * Test/*.cxx changed to agree with above changes
2436 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2437 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2438 (to avoid double call by end user).
2439 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2440 by end user, since gdcmHeader::gdcmHeader now handles it.
2442 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * gdcm/Doc many doxygen changes:
2444 - Doxyfile now has two different versions, DoxyfileUsers that generates
2445 the html.users end users oriented documentation and
2446 DoxyfileDeveloppers that generates the html.developper developper
2447 oriented documentation.
2448 - README changed accordingly
2449 - requirement.txt removed (old design info moved to TODO).
2450 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2451 DoxyMainPage.txt, DoxyPython.txt provide more information.
2452 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2453 be updated by simply regenerating the docs with doxygen and copying
2454 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2455 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2456 all the tests in the form "if (<map>.count() >1)" were removed.
2457 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2458 ill-formed documentation sections.
2459 * src/gdcmHeader.cxx: ditto
2461 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * setup.py fixed for un*x (needed macro for stdint.h)
2463 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2464 un*ces with sh-utils test utility.
2465 * gdcmPython/demo/test.py renamed to PrintHeader.py
2466 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2467 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2468 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2469 * src/gdcm*.cxx JPR's bad inclusion fixed.
2471 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2472 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2473 * gdcmPython/demo/test.py changed accordingly.
2475 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * gdcmPython/Makefile.am fixed linking against libstdc++
2477 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2478 * Swig subdir (historical tests of swig version 1.3.17++) removed
2479 * Test/testChangeEntete.cxx some lines commented out in order to make
2481 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2482 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2484 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2485 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2486 hence the user doesn't need this explicit call.
2487 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2488 i.e. LoadElements() call removed.
2489 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2490 - src/Makefile.am declares the proper flag for g++.
2491 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2492 for adding user defined new tags.
2493 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2494 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2495 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2497 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2498 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2499 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2500 src/Makefile.am : the project should properly compile and install
2501 with the autotools, included the python wrappers part.
2502 * gdcm.spec.in : added a spec file for RPM packaging.
2504 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2505 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2507 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2509 to exported to the environement (see gdcmPython/testSuite.py
2511 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2512 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2513 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2514 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2515 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2517 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2518 * gdcmPython/__init__.py doesn't crash anymore when running in
2519 in InstallMode or PreInstallMode but with an environement given
2520 value of GDCM_DICT_PATH.
2521 * src/gdcmDictSet.[cxx/h] coding style.
2523 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2525 * src/gdcm.h general comments moved to TODO, and README
2526 * src/gdcm.h should now be seen as a user commodity (including it
2527 should suffice to fully use gdcm). It is nowhere including within
2528 any of the kernel files src/*.cxx and src/*.h.
2530 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2532 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2534 * src/gdcm*.cxx only include their corresponding include file
2535 (as opposed to gdcm.h)
2536 * gdcmPython/gdcm.i changed accordingly
2537 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2538 the autogen.sh generated "make snapshot" command to work.
2539 * autogen.sh removed history related references to crea package.
2541 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * distutilsSwigCPlusPlus.py work around some swig portability
2545 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2546 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2547 was done in a last ditch attempt to get setup.py _really_
2548 operationnal. The python/gdcmPython layaout add the advantage
2549 of hidding away the python related distutils specific files
2550 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2551 Alas, the src directory was out of scope (i.e. it's relative
2552 position to setup.py was ../src) which made things impossible to
2553 handle (see previous version of python/setup.py). Crossing fingers...
2555 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2556 * python/setup.py now works on Un*x. (harder than I thougth)
2557 * python/distutilsSwigCPlusPlus.py can now have include files
2558 among the list of sources.
2560 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2561 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2562 * modifications in MSVC projects
2564 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2565 * As stated by the first lines of Test/ExceptionAndPython/README, it
2566 looks like we can move back to original usage of exception within
2567 src/gdcm* and hence remove the errno stuff that was introduced
2568 as a quick and dirty fixture of this problem (added to the TODO).
2569 * Doc/Doxyfile configuration file for Doxygen and corresponding
2570 README file for usage added.
2571 * Test/testWrite.cxx added. This new test comes from a split of
2572 test.cxx that is now reverted to its original purpous i.e.
2573 testing the proper parsing of a Dicom related file.
2574 testWrite.cxx concentrates on testing the IO part of gdcm.
2575 * Test/bug1.cxx (containing a bug on WIn32) added.
2576 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2577 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2578 whose purpose is to publish the content of the TagNames of the
2579 Dicom public dictionnary were not accessible without an
2580 instance of class gdcmHeader.
2581 - those methods are now static methods of gdcmDictSet and hence
2582 require no instances at all to be invocated.
2583 - within gdcmDictSet this change required to change some method
2584 to class methods (i.e. are now static) among which SetDictPath
2585 (renamed to BuildDictPath) and LoadDefaultPubDict.
2586 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2587 the above changes by calling the new method classes of gdcmDictSet.
2588 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2589 the above to be effective.
2590 * python/gdcmPython: in order to wrap properly the above changes
2591 for Python, swig version now needs to be > 1.3.17.
2592 * python/gdcmPython/Makefile fixed to adapt itself to new
2593 configure/make shema introduced by Johan Montagnat (thanks for the
2594 contribution). Alas this Makefile cannot be turned into a proper
2595 Makefile.am without some heavy changes in the configure.in
2596 (for python dectection).
2597 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2598 now avoids publishing the empty entries.
2600 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2601 * python/setup.py : bug fix concerning install under windows
2602 ExtraPath reused :-P
2603 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2605 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2606 * Dicts/dicomV3.dic : remove double spaces !!!
2607 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2608 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2611 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2612 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2613 method. Doxygenation.
2614 * src/gdcm.h clean up of JPR spurious comments.
2616 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * python/distutilsSwigCPlusPlus.py now properly collects the
2618 shadow classes generated by "swig -c++" (gdcm.py in our case)
2619 when using "python setup.py install".
2620 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2621 reexports the working classes.
2622 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2623 by the classical C errno scheme. This is to prevent an obscure
2624 behavior of the python wrappers when importing wxPython.wx prior
2625 to gdcmPython (which ended up in an abort call). An illustration
2626 of this oddity can be found in the Test/ExceptionAndPython
2627 subdir (see the README file). This problem probably due to
2628 an combination of g++ and dynamic loading.
2629 * added Test/ExceptionAndPython (see above)
2631 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * Changed the layout of the python part to avoid bloating main
2633 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2634 i.e. the distutils arsenal. All the python related stuff is
2635 again in a python subdir, but the package itself is now in
2637 * setup.py was cleaned up:
2638 - pythonIncludePath removed
2639 - python setup.py bdist target is now functional.
2640 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2641 collision with other packages). gdcmPython/demo/*.py changed
2644 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * python subdir moved to gdcmPython (preparation of distutils packaging).
2646 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2647 distutils installer is operational.
2648 * - gdcmPython/__init__.py now properly loads the swig generated
2649 shadow classes (from gdcm.py).
2650 - gdcmPython/demo/*.py changed to import the package gdcmPython
2651 instead of gdcmPython/demo/load.py.
2652 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2654 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2655 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2656 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2657 entries within the associated public Dicom dictionary resp. the same
2658 information but sorted by the fourth field (PAT, IMG, DIR) of the
2660 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2661 are now in the "???" group.
2662 - python/gdcm.i changed accordingly,
2663 - python/demo/printGroupedPublicDict.py added, that gives an example
2664 of the above new functionalities in Python.
2666 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2667 * src/gdcm.h, gdcmHeader.cxx:
2668 - historic references to glib's g_malloc and g_free (#defined)
2669 were definitively removed.
2670 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2671 * src/gdcmElValSet.cxx:
2672 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2673 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2674 - GetElValue(string) renamed to GetElValueByName.
2675 - Added GetElementByName(string).
2676 * src/gdcmHeader.cxx: added
2677 - GetPubElValRepByNumber(guint16, guint16)
2678 - GetPubElValRepByName(string)
2679 - GetShaElValRepByNumber(guint16, guint16)
2680 - GetShaElValRepByName(string)
2681 - GetShaElValByNumber(guint16, guint16)
2682 - GetShaElValRepByName(string)
2683 - GetElValRepByNumber(guint16, guint16)
2684 - GetElValRepByName(string)
2685 - GetElValByNumber(guint16, guint16)
2686 - GetElValRepByName(string)
2687 * Doc/requirements.txt added.
2689 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2690 * Test/Makefile building now depends on the one of libgdcm.so
2691 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2692 pixel data) aware which enables finding the address (offset) of
2693 the pixel data of JPEG encoded DICOM files. This leaves only a single
2694 file in the testSuite whose pixel data address (offset) is unknown.
2695 * python/testSuite.py changed accordingly.
2697 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2698 * VC++ has some strong limitations when working with the STL, as stated
2699 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2700 "Also note that some STL containers (map, set, queue, list, deque)
2701 cannot be exported. [...]
2702 Some STL classes contain nested classes. These classes can not
2704 This is caused by a designed limitation that once a template
2705 class is instantiated, it can not be re-instantiated and
2707 Since our usage of map<> is ubiquitous in gdcm, this "designed
2708 limitation" of VC++ is a pitfall.
2709 Hence the Python wrappers of gdcm cannot be incrementally linked
2710 against the c++ dynamic library. The dirty but only workaround is
2711 to forget about incremental link of dynamic libraries and to generate
2712 the Python wrappers library with the inclusions of the underlying C++
2714 The following modifications concern this matter on Win32/VC++:
2715 - wrapping python correct with standalone wrapped dll (don't use separate
2716 dll under windows !!!!)
2717 - python21_d debug mode enabled (ask Frog how to use it :-)
2718 - NO problem with having an STL member of class for example string in C++
2719 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2720 - Python test of dcmlib in Python is ok under windows on a large set
2722 * removed glib references
2723 * typedef's inserted in gdcm.i for correct swig type management
2725 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2726 * python/demo/*.py load.py extracted from test.py. Added explore.py
2727 that only displays required tags and testAll.py that parses all
2728 the files of the testsuite without using unittest.
2729 * python/testSuite.py other additional test on new files added.
2730 * Data/* new test files added accordingly to the testSuite.
2731 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2732 the vr in the file differs from the one of the dictionary.
2734 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2735 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2736 values, but limits itself to values which are below a user specified
2737 size (by default 1024 bytes).
2738 * python/gdcm.i : elements not loaded (because their size is above the
2739 user specified treshold) are exported with their TagKey as key of the
2740 python dictionary. This enables the testsuite to make some checks
2741 on the unloaded elements (since we have their offset and size).
2742 * python/testSuite.py
2743 - now tests for the existence and proper value of the pixel data
2744 - two new examples added.
2745 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2747 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2748 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2749 aware. See the strategy comments in gdcmHeader::FindeLength().
2750 * Test/test.cxx now accepts a filename as first argument.
2751 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2752 * python/testSuite.py changed to integrate test on above files.
2754 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2755 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2756 the vr was also RET.
2757 * python/testSuite.py more tests added.
2759 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * python/testSuite.py unittest test suite added (uses Data)
2761 * Data/* dcm and acr files for the test suite.
2762 * glib dependance removed from un*x version. We now use ISO C99
2763 7.18 Integer types (see stdint.h)
2764 - python/Makefile, src/Makefile src/gdcm.h
2765 * src/ when an explicit vr (like dicom files) suddenly poped an
2766 implicit element we use to mark the underlying DictEntry of the
2767 concerned ElValue with "Implicit". This strategy was damageable
2768 too the public or provite dictionaries, since some of their vr
2769 would be changed. Since Header::FindLength heavily relies on the
2770 detection by Header::FindVR of falsely explicit elements, I
2771 added an extra ImplicitVr member to ElValue (boolean).
2772 The rest of the changes we the necessary adaptations.
2774 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2777 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2779 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * Adaptation for porting to VC++:
2782 o forced to use std namespace (for string to be known)
2783 o all class use __declspec export style on WIN32
2784 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2785 (in stdlib.h on Win32 but in std:: for gcc)
2786 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2787 variable GDCM_DICT_PATH.
2788 * src/gdcmHeader.cxx verbose comments made discrete.
2790 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * python/gdcm.i: added a typemap that converts a C++ hashing table
2792 to native Python dictionary.
2793 * python/demo/test.py:
2794 - now uses the native dictionary for exploration of gdcmHeader.
2795 - takes an optional filename argument (the file to parse).
2796 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2797 PubElVals hashing table.
2798 * Dicts/dicomV3.dic removed error prone trailing spaces.
2800 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * Python wrapping process moved away from src/Makefile to
2802 newly created python/Makefile (as well as gdcm.i)
2803 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2804 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2805 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2806 from the environement variable GDCM_DICT_PATH (when existing).
2807 * src/gdcmDict::GetTag bug fix.
2809 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2810 * Straightforward temporary fixes for swig to build the python wrappers.
2811 src/Makefile now has a python working entry [by working we mean
2812 that we can import de shadow classes without errors].
2814 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2815 * hashtest.cxx removed (since allready in Test)
2816 * src/gdcmlib.h renamed to src/gdcm.h
2817 * src/dcm.i renamed to src/gdcm.i
2818 * src/Makefile prepared for python wrapping
2820 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2821 * src/gdcmHeader.cxx :
2822 - Parsing of header is now separated from loading of element values
2823 (see gdcmHeader::LoadElements).
2824 - general clean up of hopefully all file access (creation of
2825 ReadInt16 and ReadInt32)
2827 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * src/gdcmHeader.cxx :
2829 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2831 - SetLgrElem renamed to SetLength
2832 - GetLgrElem renamed to GetLength
2833 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2834 * src/gdcmElValSet.cxx fixed both GetElValue methods
2835 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2836 due to IdoDude was cleaned out.
2838 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2839 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2840 concentrates on finding the value representation (when it exists).
2841 RecupLgr now only finds the element value length, and it avoids
2842 returning the unecessary skL (skipped length).
2843 Also, offsetCourant was simply removed (with taille_fich) since
2844 it was redundant with the File position internals (by using
2845 ftell and fseek). This also made skL (see above in RecupLgr) usage
2847 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2848 on the libido specificities which are handled through class
2850 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2853 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2854 * Truckload of changes. Parsing of header is barely functional
2855 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2857 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2858 * src/gdcmHeader.cxx many addons of low level methods
2860 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2862 and _IdDcmSWAP_LONG.
2864 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2865 * This corresponds to all the changes decided at the meeting of
2866 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob