1 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
3 Add a print information of the type of the entry
4 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
5 It was in the gdcmFile, and all write have been regrouped
6 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
7 Write correctly all dicom files (in decompressed mode only at this time)
8 * Test/ : test on files are now made using Raw datas and not color datas if
10 * Example/PrintFile.cxx : add more printings
12 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * Amelioration of code, remove some code copy. For the loading of
14 BinEntry (in gdcmDocument), add the test to verify if the file is already
17 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
19 remove a DocEntry in the header (push an empty DocEntry)
20 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
21 lines. Bug fix in the initialization of the PixelConvert and the
23 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
24 use in TestCopyDicom (now this test can run under windows... but fails)
25 * Test/TestCopyDicom.cxx : amelioration of the test :
26 - test the pixels written
27 - add test points to quickly find where is the error
28 - can set a file name input and output in arguments
29 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
30 amelioration of the test output
32 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
34 all replaced DocEntry's
35 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
36 Now, each needed DocEntry to modify is duplicated, modified and inserted
37 to the header using DocEntryArchive. Thus, after save, we can restore the
40 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
43 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
45 correct to copy it. The DictEntry is specified at the DocEntry creation,
46 then, it musn't change in the time.
47 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
48 header correctly. At this time, the change is only made for the first
49 level of the Document. In the future, it might consider sequences.
50 The change is made by replacing a DocEntry by an other that is created
51 outside the class. The old value is kept. When we restore the header
52 status, the added DocEntry is deleted and replaced by the old value.
53 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
54 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
55 set the write type to explicit VR, implicit VR or ACR. Add methods to set
56 the write mode to native, decompressed or RGB (but not used at this time)
58 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
59 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
60 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
62 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
64 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
66 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
67 set because already copied when copying the BinEntry's of the header
68 * Test/TestAllReadCompareDicom.cxx : remove warnings
70 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
72 Two problems appear when doing it :
73 - with the gdcmFile : when the GetImageData method is called, the pixels
74 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
75 datas (pixels). And each structure destruct the datas when it's
76 destructed. So we have two destructions for the same datas. To solve it,
77 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
78 datas or not. If it doesn't own datas, then they will not destroyed by
80 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
81 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
82 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
83 create a double destruction of the same DocEntry's. So, to solve it,
84 the TagHT is simply cleared and the DicomDir* elements are destroyed.
85 * TODO : add an entry concerning memory leaks in the DicomDir
87 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
89 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
92 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
94 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
95 after it have been deleted
97 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * FIX: src/* fix the doxygen warnings.
99 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
100 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
101 was erroneously defined with a size of 15 instead of 16. [many thanks
102 to Jean Michel Rouet for pointing out this bug].
104 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
105 1. Finish merging JMR patch for writting DICOM from scratch
106 2. Fix -hopefully- bug with MONOCHROME and space vs null character
107 3. Use const ref when possible
108 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
109 5. A few more comments
110 6. CreateUniqueUID can now be called without parameter"
112 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
113 * ENH: Slightly bigger patch:
114 1. Getting toward full integration of JMR patch for writting dicom from scratch
115 2. Update Test to test part of this patch: CreateUniqueUID
116 3. File was not close properly in gdcmDict
117 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
118 5. Use of const ref instead of copy (speed issue)
119 6. Remove temporary (duplicate) string in TranslateToKey
120 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
121 8. Do not repeat virtual in subclasses
122 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
124 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
125 * Apply first patch toward better string comparison when dealing with broken
126 DICOM files. Essentially the string could be padded with a space instead
127 of a null character as defined by standard
129 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
131 because never used... and in the same time, that's remove some memory leaks
133 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/gdcmFile.cxx : now delete the PixelConvert instance.
135 * In examples and tests : change the type of image data variables from void*
136 to uint8_t*. Remmove all delete on image data variables
138 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
140 Verify the file pointer value before open the file, and if it's not null,
141 a verbose message is generated.
142 Close correctly the file when the file isn't considered dicom-like. The
143 correctly close is a call to CloseFile.
144 When closing the file pointer, test if its not null to close the file.
145 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
146 file. For an uncompressed image, the copied datas correspond in the least
147 case to the image size (calculated) or the image size specified in the
148 header. A verbose is generated if these two size mismatch
150 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
152 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
153 break under windows (with msvc6 compilation).
155 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
157 compiling with MSVC6)
159 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * Bugs fix for the Windows build with VC6
161 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
162 needed (only for projects required VTK). If the VTK is included in all
163 projects, there is conflicts with the jpeg lib of vtk when compiling the
164 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
165 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
166 when compiling the gdcm_wrap.cxx file (created by the compilation of the
168 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
169 (like it's already made for the cout use). Otherwise, conflict with the
172 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
173 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
175 - comments on the DicomDir::Method related usage added.
176 - now that we use the namespace gdcm, a lot of internal classes do
177 NOT need to be wrapped anymore.
178 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
179 DicomDir::Method) new example added.
181 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
182 * Improve string manipulation. I now inforce the notion of 'DicomString'
183 A DicomString can contain as many \0 as they want
184 and it is *always* of even length.
185 We only support odd length for very rare case.
186 And in the near future this should be removed.
188 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
189 * /binary_write/ gdcm source. Now even on big endian we are writting
190 little endian. This should -heopfully- fix some tests
192 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
193 * Now the dictionary is compiled into gdcm lib. This is a default
194 behavior, thus any dic file specified is picked before failback to
195 the one comiled into lib
197 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
198 * Change internals for gdcmDict. Don't use any 'new' any more.
199 This should definitely solve any leak problem, and we should be
200 as fast as before, as long as don't modify too much the dictionary.
202 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
203 * STYLE: ivars should start with a capital letter.
204 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
205 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
207 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
208 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
209 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
210 new 2004 dictionaries added (thanks to JPR).
211 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
212 * CLEANUP_ROUND (15) for gdcmPixelConvert
213 - RLEFrame::NumberFragments is now of type unsigned int
214 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
215 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
218 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
219 * Initial work in gathering all transfer syntax accessors. clearly
220 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
221 ivars, but only one transfersyntax (class) ivar with equivalent method on
224 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
225 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
226 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
227 discussed (plus I didn't like having a 2000 lines patch not commited)
229 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
230 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
231 * CLEANUP_ROUND (14) for gdcmPixelConvert
232 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
233 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
234 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
236 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
237 anymore and hence avoids storing a copy of PixelConvert::Decompressed
238 into File::Pixel_Data.
240 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
241 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
242 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
243 * CLEANUP_ROUND (13) for gdcmPixelConvert
244 Substituted File::ParsePixelData() with PixelConvert::Print() new
246 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
247 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
248 method to those classes.
249 - src/gdcmFile.[cxx|h]:
250 -- Added a ::Print() method.
251 -- PixelConverter is now a reference instead of a member.
252 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
253 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
255 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
256 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
257 collaboration diagram and inheritance diagram should be generated with
259 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
260 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
261 pointlessly wrapped (see
262 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
263 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
264 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
265 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
266 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
267 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
268 -- File::Initialise: PixelConverter setup moved away to
269 PixelConverter::GrabInformationsFromHeader()
270 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
271 interpretation moved away to PixelConverter::BuildRGBImage()
273 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
274 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
275 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
277 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
278 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
279 displayed on Win32 when a brutal abort() occurs (because of uncatched
280 exception). See TODO new entry of this commit for more on this.
281 * TODO added new entry.
282 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
283 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
284 - HandleColor is no longer called from gdcmFile.cxx
285 - gdcmPixelConvert.cxx clean up on method arguments and internal
286 variable names for semantical coherence.
288 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
289 * Finished lossless transition, not only do we now read all lossless jpeg
290 images, without the need of the Cornwell lib, but we do read them properly now
291 * To reduce code (well to avoid code duplication), I defined a common place
292 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
293 redefine symbols. This is not prefect but this the best solution I found for a
294 compilation time jpeg option.
296 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
297 * Update jpeg ijg lib to support lossless jpeg implementation
298 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
300 * Also added a special copyright for dcmtk since we use their bugfixes.
303 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
304 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
305 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
306 matters, as stated in warning note at begining of %include section).
307 * src/gdcmDicomDir*.[cxx|h]: coding style
308 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
309 * src/gdcmJpeg8.cxx: doxygen fix.
310 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
311 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
312 from File:: to PixelConvert::.
314 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
316 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
317 - more code moved away from File:: to PixelConvert::
318 - fat setup of PixelConverter set in place in File::Initialise.
320 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
322 namespace at the file system level. So now you should convert your examples
324 gdcmHeader -> gdcm::Header
325 It would be nice if people keep in mind to no open the namespace, since it
326 allows compilation on broken plateform which were defining common symbol in
327 the standart namespace (like LP, Unknown ...)
329 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
330 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
331 The JPEG fragments are now parsed at the same stage than the RLE
332 information. All code related to JPEG is now in gdcmPixelConvert:
333 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
334 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
335 export a gdcmFile:: method. Those are simply global functions
336 (for the time being this is better than having them attach to
337 either gdcmFile:: or gdcmPixelConvert::).
338 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
339 and stores the result in a gdcmJPEGFragmentsInfo.
340 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
341 code (among other stuff) moved away from gdcmFile:; to
344 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
345 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
346 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
347 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
348 clean up of RLE related code.
349 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
350 - src/gdcmRLE.cxx removed
351 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
352 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
353 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
354 * CLEANUP_ROUND (9) for gdcmPixelConvert
355 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
356 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
357 away from gdcmFile:: to gdcmPixelConvert::.
359 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
360 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
361 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
362 This is because Parse7Fe0 used to parse the pixels to compute the
363 length. This task was passed over to FindDocEntryLengthOB() a long
364 time ago, EXCEPT I had forgotten the OW case...
365 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
366 we just recylce the code for parsing RLE fragments and computing
368 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
369 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
370 with the retired Parse7Fe0().
371 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
372 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
374 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
376 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
377 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
378 - src/CMakeLists.txt: alphabetic order reodering + new entries.
379 * CLEANUP_ROUND (4) for gdcmPixelConvert
380 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
381 to return an unused length.
383 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
384 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
385 this should be cleanner from the plane view. The iostream are erally a pain
386 to use to do simple stuff.
388 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
389 * Redo the compilation of the ijg jpeg library. Now only one source is
390 necesseray. No need to rename file by hand what so ever. CMake handle the
391 copying of the file within different directory, configure header file to
392 modify some symbol. The only addition made to ijg wasd a mangle table so
393 that symbol are different wether we are within 8bits or 12bits.
395 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * Added documentation of vtkgdcmReader on Website:
397 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
398 with it's binary name).
399 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
400 the Website to be more complete.
401 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
402 doxygenated documentation.
403 - Doc/DoxyVtkGdcmReaderExamples.txt added
404 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
405 DoxyVtkGdmReaderExamples.html )
406 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
407 * CLEANUP_ROUND (3) for gdcmPixelConvert
408 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
410 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * CLEANUP_ROUND (2) for gdcmPixelConvert
412 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
414 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
415 * CLEANUP_ROUND for gdcmPixelConvert:
416 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
417 - src/gdcmPixelStuff[h|cxx] removed
418 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
419 - src/CMakeLists.txt changed accordingly
421 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
422 gdcmVersion.py moved to newly created ATTIC related
423 gdcmPython/SetupOldies/ directory.
424 * Autotools clean up:
425 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
426 - autogen.sh configure.in acinclude.m4 python.m4 removed
428 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
429 * src/*.cxx *.h Reference to License.htm fixed to License.html.
430 * Doc/CMakeLists.txt, doxygen.config.in: fix.
431 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
433 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
434 * TODO updated with Mathieu suggestions. I proposed a template for
435 describing TODO entries and used it for new entries.
436 * Added Doc/Website/CodingStyle.html, Developpers.html,
437 DeveloppersPython.html, GdcmDataCvs.html and
438 DownloadVersion0_1.html, DownloadVersion0_3.html.
439 * Some Doc/*.txt Doxygen files (which do not really concern the
440 documentation itself, but the website) moved to html and
441 placed in directory Doc/Website:
442 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
443 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
444 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
445 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
446 * CMakeLists.txt changed accordingly.
447 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
448 DeveloppersPython.html
449 * INSTALL nows refers to Doc/Website/Installation.html
451 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
452 * Added Doc/Website directory, that contains a first raw version
455 2004-09-23 Jean-Pierre Roux
456 * FIX In order not to be poluted any longer by casting problems,
457 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
458 we can now delete[] it safely
459 * VoidArea is now called BinArea (less confusing name),
460 and all the methods called ...VoidArea... are now ... BinArea...
461 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
463 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
465 clear) TagHT, which is an inherited member of gdcmElementSet. It is
466 up to the destructor of gdcmElementSet to clean up TagHt and it's
469 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * Test/CMakeLists.txt: update to follow gdcmData renamings.
471 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
473 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
474 * ENH: added some utility method that builds a flat dictionnary
475 holding all the Dicom entries contained in the recursive structure
476 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
478 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
479 BuildFlatHashTable() that build a flat dictionary.
480 - src/gdcmElementSet.h: added a new private GetTag() accessor.
481 gdcmDocument is now a friend of gdcmElementSet.
482 - src/gdcmElementSet.cxx: clean up.
483 - Example/FlatHashTablePrint.cxx added.
484 - Example/CmakeLists.txt changed accordingly
486 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
487 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
488 moved away from gdcmDocEntrySet (since this class is an abstract class
489 acting like an interface). SQDepthLevel and BaseTagKey are now
491 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
492 and associated accessors. Doxygenation of the class.
493 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
495 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
496 Use SQDepthLevel accessor instead. ::Print() adapted.
497 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
498 - src/gdcmDocument.cxx changed accordingly.
500 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
501 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
502 - The following is the doxygen comment of the typedef declaration
503 of gdcmagKey in src/gdcmCommon.h:
504 gdcmTagKey is made to old an "universal" (as in URL, Universal
505 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
506 A dicom tag allways has a group and an element, but a set of tags
507 embeded in various (optionally nested) sequences and sharing
508 the same group and element all share the same (group, element)
509 "identifier". Hence the (group, element) cannot be used as an
510 identifier (in gdcm we shall refer to a "TagKey") of a tag.
511 In order to construct a proper tag identifier (i.e. a key) we
512 consider the following definition of a TagKey:
513 - let Group, Element be the string representation of the
514 group and element dicom tag members,
515 - let ItemNumber be the string representation of the integer
516 index of the considered item number of a sequence,
517 Let the key of a tag embeded in a sequence, noted SeqTag, be
519 /ItemNumber#Group|Element
520 where "/", "#" and "|" are characters acting as separators.
521 Then the general form of a gdcmTagKey is given by:
522 Group|Element<SeqTag>
523 where <SeqTag> means NO or many instances of SeqTag.
524 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
527 but the gdcmTagKey of a tag "embeded" is the first item of
528 a sequence, itself nested in the third item of a sequence is the
530 0004|1220/2#0008|0082/0#0008|0090
531 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
532 order to hold the new sequence compatible key. Previously, the
533 GetKey() method would look in the underlying gdcmDictEntry.
534 - src/gdcmDocEntry.cxx:
535 -- constructor now copies the underlying DictEntry key, in the local
537 -- ::Print: displays the member Key, instead of the (group, element).
538 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
539 - src/gdcmDocEntrySet.h:xi
540 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
541 -- now has a new BaseTagKey member.
543 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
544 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
546 This poses the problem with the semantics of the following lines
547 LoadEntryVoidArea(0x0028,0x1201); // R LUT
548 LoadEntryVoidArea(0x0028,0x1202); // G LUT
549 LoadEntryVoidArea(0x0028,0x1203); // B LUT
550 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
551 to the long FIXME note for what the problem is. Nevertheless in
552 order to get things working the dicom dictionary was altered !
553 Please fix things urgently...
554 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
555 information), see above note on moving the member VoidArea. Nevertheless
556 the following entries previously correctly set as US are now inproperly
558 0028 1201 OW IMG Red Palette Color Lookup Table Data
559 0028 1202 OW IMG Green Palette Color Lookup Table Data
560 0028 1203 OW IMG Blue Palette Color Lookup Table Data
561 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
562 of gdcmDocEntry moved to gdcmSeqEntry.
563 * src/gdcmSeqEntry.cxx: STYLE.
565 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * Test/TestAllEntryVerify.cxx minor fix and added comments.
568 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
569 * gdcmPython/testSuite.py: all the test suite in python is now moved
570 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
571 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
572 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
574 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
575 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
576 to avoid inclusion recursion until STL is reached.
577 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
578 mecanism. errno.h is not included in gdcm anymore.
579 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
580 (gdcmFormatError now inherits from gdcmFormatUnexpected).
582 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
583 gdcmData/TestAllEntryVerifyReference.txt
584 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
585 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
586 exception_on_error parameter.
587 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
588 - vtk/vtkGdcmReader.cxx changed accordingly,
589 - Example/*.cxx and Test/*.cxx changed accordingly.
591 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
593 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
594 enable_sequences removed from gdcmHeader constructor and dependencies.
595 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
596 * gdcmPython/demo/PrintHeader.py: dummy fix.
597 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
598 skip_shadow removed from gdcmHeader constructor and dependencies.
599 * Example/*.cxx and Test/*.cxx changed accordingly.
601 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
602 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
603 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
605 2004-07-21 Jean-Pierre Roux
606 * FIX Now, Parsing and Printing a DICOMDIR do work!
607 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
609 2004-07-20 Jean-Pierre Roux
610 * FIX Some brain damaged headers have Zero-Lenght fields
611 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
613 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
614 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
615 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
616 variable (instance of gdcmDebug) by a definition macro, and the instance
617 is now in static in the gdcmDebug class
618 * src/gdcmSQItem.h : (FIXME) remove an undefined method
619 * Test/PrintAllDocument.cxx : bug fix in the result of the test
621 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
622 * WARNING: ctest now depends more tightly on gdcmData. You should
623 check out gdcmData properly for things to run smoothly...
624 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
625 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
626 we need the pixels not be loaded in order to use the ValEntry
627 that displays position and size).
628 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
629 This is a C++ based equivalent of gdcmPython/testSuite.py that should
630 be deprecated. If you have any doubts about the advantages of a
631 modern scripting language (read Python) versus grass root C++ (i.e.
632 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
633 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
634 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
635 Anyhow, consider documenting the gdcmData images in
636 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
638 * Test/CMakeLists.txt:
639 - now uses TestAllEntryVerify.cxx
640 - specific comments on oldACR00001.ima (now renamed in gdcmData
641 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
642 gdcmData/TestAllEntryVerifyReference.txt
645 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * src/*.[h|cxx] : typedef clean up
647 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
648 - TagKey renamed to gdcmTagKey (for external usage)
649 - VRKey renamed to gdcmVRKey (for external usage)
650 - removal of typedef duplication.
651 - Removed all unecessary inline keyword from class inline definitions.
652 - Some method|function(void) declarations replaced with method|function().
653 * src/jpeg/libijg12/jdhuff12.c:
654 - printf polluting ctest removed.
655 - TAB removal for comminting
657 - TestAllReadCompareDicom.cxx: added a test that compares all the
658 images in gdcmDataImages.h with corresponding images in
659 gdcmData/BaselineDicom/. When baseline images are not present
660 this test creates them.
661 Note: we need to validate each reference image, but before that
662 I'd like to rename them with a more explicit name...
663 - CMakeLists.txt: changed accordingly.
664 * Example/*.cxx: examples now only include gdcm.h (as opposed to
665 including each header needed).
667 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * Test/*.cxx and Example/*.cxx: moved some examples away from the
669 test suite to the Example directory. Are concerned:
674 - TestWriteSimple.cxx
675 * Test/CMakeLists.txt: added some comments on reasons for black listing
676 image gdcmData/oldACR00001.ima
678 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * Test/CmakeList.txt: removed the following from black list (to be coherent
680 with removal from gdcmData):
681 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
682 - gdcm-MR-PHILIPS-16.dcm
684 Added the following because after last cvs update, they cause
685 ctest -R TestReadWriteReadCompare
687 - gdcm-MR-SIEMENS-16-1.acr
689 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
690 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
691 new comments in this file) we temporarily (sigh) move to a weaker
693 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
694 we don't need to black list the following images anymore:
695 - 8BitsUncompressedColor.dcm
697 - US-PAL-8-10x-echo.dcm
698 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
699 fixes and the beautified code ;-)
700 This fixes the bug introduced in version 1.42 (when beautifying)
701 that made the parsing of 8BitsRunLengthColor.dcm unproper.
702 Note: ctest was blind to this bug (this means we need to still
703 improve the test suite). The bug could be detected by using
704 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
706 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
707 and by displaying the (garbage) produced file temp.XDCM...
709 2004-06-29 Jean-Pierre Roux
710 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
711 - replace by uggly but working old code :-(
712 A lot of things should be OK again.
713 It's really urgent to have a test suite that *tests*,
714 to prevent Frog's beautifying sessions to break all the stuff
715 (twice, withing a fortnigh ...)
717 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
718 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
719 redundancy) to added Test/TestReadWriteReadCompare.cxx
720 * Test/CmakeList.txt: because the compare test of
721 Test/TestReadWriteReadCompare.cxx fails, the following images are
722 black listed: - 8BitsUncompressedColor.dcm
724 - US-PAL-8-10x-echo.dcm
725 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
726 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
727 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
728 and ad-hoc kludge. This kludge is now removed, and on encountering
729 such an image (OB field brain damaged) we set errno. Then in
730 ::FindDocLength() we "fix" the length as being ALL what remains
731 in the file (until EOF). We then proceed, hoping for the best...
732 This fixes a SegFault in ShowDicom when trying to write such an
734 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
735 (because TestWriteRead breaks on it, after a non conformal commit?).
736 ctest now runs properly, except for MakeDicomDir (which was allways
737 broken) and the Python related stuff (still not fixed).
739 2004-06-24 Jean-Pierre Roux
740 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
741 FIX : Test/TestReadWrite now iterates on all the file names
742 (instead of infinite loop)
743 ENH : Test/TestWriteRead now iterates on all the file names
745 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
746 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
748 2004-06-24 Jean-Pierre Roux
749 FIX : - now Write drops LUT Descriptors and LUTs (if any)
750 when SamplesPerPixel =3
751 - now Write is no longer confused by
752 'BitsAllocated = 12" and 'BitsStored=12"
753 - "UN" value representation Elements are now written correctly
754 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
755 ENH : - now gdcmHeader has its own Write methods
756 (in order to split the job that has not to be done
759 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
760 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
761 loop on the same image until memory went out.
762 Note: this means we still have gobs of memory loss in PrintDocument
763 * src/gdcmDocument.cxx: fixes problem on parsing on file
764 gdcmData/16BitsJpegLosslessGrayScale.dcm.
766 2004-06-24 Jean-Pierre Roux
767 FIX : Write - All the Sequences and Sequence Item are now written
768 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
769 is added a the end, when necessary.
770 - A lot of brain-damaged images, that were read correctly are
771 now written correctly
772 - length compatible BinEntry are now loaded correctly
773 (even for odd groups)
774 Note : only Explicit Value Representation was checked.
775 (question : is implicit VR really necessary for gdcm ?)
777 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * DEVELOPPER: added a proposition of coding style.
779 * src/gdcmDocEntry.h: removed every inline declaration (for test of
782 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
783 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
784 Use the gdcmDocEntry::Print() and Write() instead.
785 * src/gdcmDocument.cxx: bug fix.
787 2004-06-22 Jean-Pierre Roux
788 FIX : gdcmDocument.cxx
789 - Now we do recognize the JpegLossLess format (there was a misstyping in
790 code 'beautyfication' :-(
791 - Now we automaticaticaly load the Luts, if any
793 2004-06-22 Jean-Pierre Roux
794 In order : to write Sequences, whatever their imbrication level,
795 : to allow user to create his own Sequences
796 a lot of modif where necessary (adding, moving, or virtualising methods)
798 WARNING : save your own sources *before* cvs up !
801 ADD virtual void Write(FILE *fp, FileType filetype);
804 ADD virtual void Write(FILE *fp, FileType filetype);
805 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
808 ADD virtual void Write (FILE *fp, FileType filetype)=0;
809 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
810 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
811 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
812 ADD std::string GetEntryByName(TagName name);
813 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
815 std::string vr = "unkn",
816 std::string fourth = "unkn",
817 std::string name = "unkn");
818 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
819 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
820 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
821 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
822 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
823 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
824 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
825 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
828 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
829 ADD virtual std::string GetEntryByName (TagName tagName);
830 ADD virtual std::string GetEntryVRByName (TagName tagName);
831 REM virtual bool Write(FILE *, FileType);
832 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
833 FILE *_fp, FileType type);
834 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
835 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
836 REM virtual bool WriteEntries(FILE *_fp,FileType type);
837 REM virtual std::string GetEntryByName (std::string tagName);
838 REM virtual std::string GetEntryVRByName (std::string tagName);
839 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
840 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
841 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
843 std::string vr = "unkn",
844 std::string fourth = "unkn",
845 std::string name = "unkn");
846 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
847 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
848 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
849 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
852 ADD virtual void Write(FILE *fp, FileType filetype);
855 ADD virtual void Write(FILE *fp,FileType filetype);
858 ADD virtual void Write(FILE *fp, FileType filetype);
859 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
860 REM std::string GetEntryByNumber(guint16 group, guint16 element);
861 REM std::string GetEntryByName(TagName name);
864 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
866 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
868 The default constructor invoked by the line
869 gdcmHeader *f1 = new gdcmHeader( header );
870 was gdcmHeader::gdcmHeader(bool) instead of the expected
871 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
872 Hence the parsing wasn't executed... See also below.
873 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
874 as explicit constructor didn't do the trick to fix the above problem.
875 Could anyone explain why ?
876 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
877 properly calls gdcmValEntry::Print() (that was weed out from
878 code related to gdcmBinEntry).
880 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
881 * In order to fix memory leaks:
882 - Test/TestWriteSimple.cxx: added cleaning of free store through
884 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
885 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
886 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
887 (through the call to ::AddDicomDirMeta()) or the destructor
888 would crash when deleting uninitialized ::metaElems].
889 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
890 - src/gdcmDocument.cxx:
891 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
893 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
894 was causing memory leaks.
895 - src/gdcmSQItem.cxx:
896 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
897 cleanly handled with polymophism: sorry but my milage is low).
898 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
899 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
900 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
901 This avoids SegFaulting.
902 - src/gdcmSQItem.h: coding style.
904 - Test/TestWriteSimple still severely sucks. The output image content
905 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
906 damaged when displayed with vtkgdcmViewer.
907 - on memory leaks: TestWriteSimple leaks really less (see entry
908 of 2004-06-18 in Changelog file for the call to valgrind).
909 - on segfaults: ctest now passes all the tests but one (no more
911 * Erroneous leading white fix:
912 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
913 white[s] (as opposed to from >> xxx, that removes it [them].
914 - src/gdcmTS.cxx: ditto.
915 - gdcmPython/testSuite.py: dirty related kludge removed.
916 * src/*: remaining references to gdcmParser removed.
917 * src/*[cxx|h]: added copy[way]left header.
920 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
921 * In order to fix writing of dicom files:
922 - Test/TestWriteSimple.cxx: a simpler example of writing.
923 - Test/CMakeLists.txt changed accordingly.
924 - src/gdcmDocument.cxx:
925 -- The destructor now recursilvely removes potential sequences.
926 -- Bug fix in ::IsJPEG2000()
927 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
928 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
930 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
931 to only declared) and build on top of
932 ::GetDocEntryByNumber(guint16, guint16).
933 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
934 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
935 for usage in destructor and treatement of promotion in
936 ::ReplaceOrCreateByNumber().
937 - src/gdcmSQItem.cxx: destructor should better handle his job.
938 Test/TestWriteSimple now runs (or at least it DOES something).
939 * We can now start hutting memory links. A good starting point is:
940 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
941 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
942 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
944 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
945 * Valgrind note: after Mathieu Malaterre teached me how to read
946 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
948 Using gcc, you can force the STL to use malloc and to free memory as
949 soon as possible by globally disabling memory caching.
950 With 3.2.2 and later, you should export the environment variable
951 GLIBCPP_FORCE_NEW before running your program.
952 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
953 simply vanish (it is still not clear to me, whether this means that
954 STL std::string leaks or if valgrind believes it leaks...).
955 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
956 running bin/gdcmTests makeDicomDir):
957 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
958 - Test/makeDicomDir.cxx now properly traps empty lists and returns
960 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
961 SegFaulting (I drowned in DicomDir related code when trying to
962 understand why the list is empty...).
963 * src/gdcmDocument.h: first BSD license header try.
964 * Doc/License.txt added.
966 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
967 * src/gdcmDocument.[h|cxx]:
968 - Clean up of the Transfer related predicates. They are now all based
969 on new method isGivenTransferSyntax, that (should) handle properly
971 - general clean up, simplification, and coding style.
972 - Specific clean up of Parse7FE0() (umproperly named actually).
973 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
975 2004-06-14 Jean-Pierre Roux
977 - fix the display of Sequence Delimitor (SQDepthLevel pb)
978 - fix the display of SQItem ordinal number
979 - add the GetSQItemByOrdinalNumber method
980 - remove some useless never written private methods
982 2004-06-14 Jean-Pierre Roux
984 - adding a constructor taking a gdcmDocEntry as an input param
985 - ReplaceOrCreateByNumber now returns :
986 a gdcmBinEntry * if a Binary (void *) value is passed as a param
987 a gdcmValEntry * if a string value is passed as a param
989 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
990 according to the param type (no longer sets a gdcmDocEntry)
991 - GetValEntryByNumber, GetBinEntryByNumber added
992 - NewValEntryByNumber and NewBinEntryByNumber added
994 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
996 - GetSQItemNumber and SetSQItemNumber added, to provide
997 a (relative) Item identier inside a given Sequence
998 \warning : some pb remaining around this number
1000 - AddEntry now takes the Item Number as a param
1002 - adding a constructor taking a gdcmDocEntry as an input param
1004 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1005 * Memory leak hunt with the following command:
1006 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1007 --show-reachable=yes gdcmTests PrintDocument
1008 It looks like many (all?) leaks are due to the STL (or a bad usage
1009 of the STL. The lines producing the leaks now have a comment with
1010 a "MEMORY LEAK" tag: you can retrieve them with
1011 grep "MEMORY LEAK" src/*
1012 Here are two typical examples which I can't help fixing:
1017 char * test = "babo";
1018 name = test; //// <--- valgrind detects 960 bytes lost in
1019 //// call to std::string::operator=(char const*)
1020 name.clear(); //// Doesn't help !
1028 std::cout << "Type a bunch of characters followed by RETURN: ";
1029 getline(std::cin, line); //// <--- valgrind dectects a loss
1030 //// of 1320 bytes in call to
1031 /// std::basic_istream<>& std::getline<>
1037 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1038 * src/gdcmHeader.[cxx|h]:
1039 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1040 and related, moved away to gdcmDocument.
1041 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1042 the corresponding protected accessors of inherited class
1043 gdcmDocument, removed ! As a consequence gdcmFile had to be
1044 declared friend of class gdcmDocument (see below).
1045 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1046 - Clean up of undefined or unused methods.
1047 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1048 account the changes to gdcmHeader.h).
1049 * src/gdcmDocument.h:
1050 - gdcmFile is now a friend class (in order to take into account the
1051 changes to gdcmHeader.h).
1052 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1053 (see changes to gdcmHeader.h).
1054 - Accessors (reading on the form GetEntry*) are now public.
1055 - Clean up of undefined or unused methods.
1056 * src/gdcmDocument.cxx:
1057 - adaptation to changes to gdcmDocument.h
1058 - ::OpenFile now writes a verbose message when file cannot be opened.
1059 - some std::string properly set to VRKey
1060 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1061 references to gdcmDocument.
1062 * Test/TestFindTags.cxx: changed accordingly to above changes.
1063 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1064 cvs repository gdcmData.
1066 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1068 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1069 conflicts with gdcmValEntry::voidArea.
1070 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1071 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1072 Value representation between StringRepresentable and BinaryRepresentable.
1073 * src/gdcmDocument.cxx:
1074 - method ParseDES: proper indentation restored and usage of
1075 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1076 - method LoadDocEntry: the fingerprint left in the SetValue() of
1077 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1078 removed. Reverting to previous code segment with the proper
1079 dynamic_cast< gdcmValEntry* >.
1080 Note: this was (partially) breaking the python test suite
1081 (gdcmPython/testSuite.py) that made usage of the above
1082 fingerprint to check presence of "Pixel Data".
1083 * src/gdcmDocEntry.h: coding style.
1084 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1085 now taken into account.
1086 * gdcmPython/gdcm.i: adaptation to the new internal representation
1087 of gdcm (exit gdcmParser, hello gdcmDocument).
1088 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1090 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1091 anymore, but instead prints the loaded Python dictionary.
1092 * .... alas, the python testSuite is still broken.
1094 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1095 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1097 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1098 * src/gdcmUtil.h : export methods
1100 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1101 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1103 * Initial addition of automatic python testing
1104 * Initial addition of automatic image comparison
1106 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1107 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1108 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1110 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1111 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1112 * Test/ShowDicom.cxx : bug fix for msvc compilation
1113 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1115 2004-05-04 Jean-Pierre Roux
1116 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1117 new concepts (and new classes) :
1118 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1119 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1120 - Sequence Doc Entries (gdcmSeqEntries)
1121 a Sequence is composed of Items.
1122 Each item is a set of Doc Entries (this is recursive)
1123 The non uniqueness of the 'Dicom tag' is due to this recursivity
1124 (never taken into account)
1125 Our unability to add a new 'entry' in the header
1126 at the proper location (neither in the H-Table (map or multimap),
1127 nor in the Chained List is also due to this recursivity.
1128 Don't try, right now, to use/modify/compile these new sources :
1129 nothing is finished.
1130 We just commit all the stuff, 'as is', in order not to loose it.
1132 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1133 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1135 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1136 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1137 file prefix (SetFilePrefix)
1139 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1140 * Add a new test: ShowDicom, for now this is just the c++ version of
1141 checkRead.sh, later it will be able to compare the image read against a
1143 * Replace the DEBUG on the stack with a global entry in cmake interface:
1144 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1146 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1147 * Add an example subdir, with a real example on how to read + write a
1150 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1152 * Doc/CMakeLists.txt: the main page is now properly differentiated
1153 between the developper and user version.
1154 * Doc/doxygen.config.in: dropped search related obsolete flags
1155 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1157 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * DEVELOPPER: added some helpfull comments for compile/test/install
1161 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1162 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1163 src directory, now generated in the build dir.
1164 2. Tests as mentionned smarter
1166 4. Add a new method in gdcmDict that return the PubDict by name
1167 this is interesting for 3rd party lib like ITK,
1168 where we could set the institution name / patient name...
1170 * ENH: 1. Now the test suite is working for real
1171 2. All binaries are now output in the gdcm-bin directory
1172 (this was not true before)
1174 2004-04-28 Jean-Pierre Roux
1175 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1176 SeQuence indented printing of Dicom Header.
1177 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1178 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1179 Computation of SQDepthLevel is now part of gdcmHeader constructor
1180 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1181 tree-like structure of a Dicom Header.
1182 * FIX Test code cleaning
1184 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1185 * ENH: Adding automatic testing
1186 1. Need a DartConfig.cmake to submit to public
1187 2. Add a test driver gdcmTest.cxx
1188 3. gdcmTestMain, an helper for the main test driver gdcmTest
1189 4. Files in Test don't have a main anymore, this becomes interesting
1190 when we add more and more tests, thus dsw don't have to load
1192 * ENH: Adding a GDCM_DATA_ROOT for testing
1193 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1194 one file instead of seven + some small cleanup
1196 2004-04-22 Jean-Pierre Roux
1197 * ENH Minor changes to the Print() methods.
1198 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1199 Header printing. Example given with :
1200 > PrintHeader fileName 2 new
1201 (SQ based tree-like structure still to be done for the Header ...)
1203 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1204 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1205 1. I have added some unsigned where needed
1206 2. Some function parameter not used -> (void)
1207 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1208 4. g++ don't like character '\' in comment
1209 5. #define jpeg_create_decompress jCreaDecompress
1210 this really need to be fixed
1211 6. virtualize destructor of gdcmObject ... leakage
1212 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1213 this also really need to be fixed
1214 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1215 remove compression file
1216 (as we only do decompression, right ?)
1217 * ENH: Change malloc/calloc/free with c++ equivalent
1219 2004-04-21 Jean-Pierre Roux
1220 * FIX gdcmHeaderHelper::GetXSpacing
1221 when a single value is found (bug ?), xpacing is now
1222 defaulted to yspacing
1224 2004-04-19 Jean-Pierre Roux
1225 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1226 * ENH add parameters :
1227 bool exception_on_error = false,
1228 bool enable_sequences = false,
1229 bool ignore_shadow = false
1230 to the gdcmFile constructors to be full gdcmParser compliant
1231 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1232 to allow reading of PAPYRUS 3.0 files
1234 2004-04-06 Jean-Pierre Roux
1235 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1237 2004-04-02 Jean-Pierre Roux
1238 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1239 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1240 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1242 2004-03-30 Jean-Pierre Roux
1243 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1244 for ACR file, written out as DICOM files (hope so...)
1246 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1247 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1248 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1249 moved to base class gdcmParser and only the specialisation is kept
1251 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1252 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1253 already does the job.
1254 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1255 (to be consistent with gdcmParser::WriteEntries).
1257 2004-03-30 Benoit Regrain
1258 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1259 upate of the object's instance. It's passed to 2 in the unfavorable
1260 case : one in the ExecuteInformation, one in the ExecuteData
1262 2004-03-29 Jean-Pierre Roux
1263 * ENH : Check on file type to be written moved
1264 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1265 * FIX : gdcmObject::ResetBoundaries now stops properly
1266 when end-of-list is reached
1267 : gdcmVersion modified (as Benoit Regrain asked)
1269 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1270 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1271 * src/gdcmUtil.cxx: added forgotten iostream include.
1272 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1273 equivalent to ExplicitVR in existing code).
1275 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1276 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1277 now contains all the gdcmGlobal related code.
1278 * minor coding style and doxygenation changes.
1280 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1281 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1282 now contains all the Debug related code.
1283 * minor clean-up of includes in src/*.cxx
1284 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1285 CreateCleanString) removed.
1286 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1287 * Doc/DoxyMainPageUser.txt added.
1288 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1289 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1290 src/gdcmDirList.cxx)
1292 2004-03-24 Jean-Pierre Roux
1293 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1295 2004-03-23 Jean-Pierre Roux
1296 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1297 big endian made volumes
1298 * ENH Now gdcmParser constructor and destructor are protected to forbid
1299 end user to instanciate class gdcmParser
1300 (only gdcmHeader and gdcmDicomDir are meaningfull)
1302 2004-03-22 Benoit Regrain
1303 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1304 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1305 gdcmSerie to gdcmDicomDirSerie
1307 2004-03-19 Jean-Pierre Roux
1308 * ENH Now the tree-like structure describing a DICOMDIR comming from
1309 an already existing DICOMDIR file is consistent with
1310 the home-made tree-like structure build ex-nihilo
1311 or build from the files held (recursively) in a Directory
1312 functions gdcmDicomDir::CheckBoundaries()
1313 gdcmObject::SetBoundaries() added
1315 2004-03-17 Jean-Pierre Roux
1316 * REM (Eric Boix bug) : removal of meaningless
1317 gdcmDicomDirImage::NewImage function.
1318 * FIX now file names and directory name are written properly in the
1320 * FIX now gdcmDicomDir constructor may be call without any trick
1323 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1324 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1325 of gdcmDicomDirImage::NewImage as empty function.
1327 2004-02-28 Jean-Pierre Roux
1328 * ENH add gdcmDicomDir:NewPatient
1329 add gdcmDicomDirPatient:NewStudy
1330 add gdcmDicomDirStudy:NewSerie
1331 add gdcmDicomDirSerie:NewImage
1332 to allow making gdcDicomDir object.
1333 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1334 (as opposite to the gdcmHeader chained list)
1336 2004-02-11 Benoit Regrain
1337 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1338 when using from python
1340 2004-02-10 Benoit Regrain
1341 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1342 * FIX : in gdcmDicomDir when the directory is empty
1343 * ENH : add callback and methods to get the progression of dicomDir
1346 2004-02-06 Jean-Pierre Roux
1347 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1348 - GDCM_META added to gdcmDicomDirType
1349 - class gdcmMeta created
1350 * ENH : - A brief summary is now displayed at the beginning of
1351 'testDicomDir' to help disaster magnitude estimation
1352 * REM : Now useless Test/explDICOMDIR.cxx
1354 2004-02-05 Benoit Regrain
1355 * ENH : add methods in gdcmObject to get the hash table or the list of
1357 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1358 * FIX : wrapping python for TagHeaderEntryHT
1360 2004-02-04 Benoit Regrain
1361 * FIX : even length for some strings when writting the dicom dir
1362 * FIX : sort the images in the dicom dir
1363 * FIX : Bug fix for python use of dicom dir
1364 * ADD : a python demo
1366 2004-02-04 Jean-Pierre Roux
1367 * FIX : Final solution (?) for icone embedded images
1368 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1369 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1370 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1371 gdcmData/gdcm-MR-SIEMENS-16.acr1
1372 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1373 to make full checking easier
1375 2004-02-04 Benoit Regrain
1376 * FIX : WriteEntries : coding style & logic in parameters
1377 * FIX : Set the elements to create the DicomDir in a dictionary file
1379 2004-02-03 Benoit Regrain
1380 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1381 * gdcmDicomDir : add the load of directory
1382 * Bug fix and print add-on
1384 2004-02-03 Jean-Pierre Roux
1385 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1386 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1387 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1388 * FIX gdcmParser.cxx : 'group length' elements are now considered
1389 as integers, even for shadow groups, when file is Implicit VR
1391 2004-02-02 Jean-Pierre Roux
1392 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1394 of the last synonym :-(
1395 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1397 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1398 * FIX taking into account the possible 7fe0,0010 multiplicity
1399 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1400 to allow removal of references to 7fe0,0010, to deal with
1401 ACR-NEMA images, when 0028,0200 is meaningfull
1403 2004-01-31 Jean-Pierre Roux
1404 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1405 no longer writes 'Un' on disk
1406 * FIX SQ elements with actual length are now dealt with corectly
1407 * FIX gdcmFile::WriteBase make the difference, for color images, between
1408 the length (for Palette expanded images)
1409 and Raw Length (non expanded image + Palette)
1410 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1411 (that broke Write). Replaced by UL.
1412 Aware user will reload the field if he
1413 thinks it's necesssary
1415 2004-01-30 Jean-Pierre Roux
1416 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1417 when 'dirty Acr' is found, to be compliant with the new
1418 IsReadable() methods.
1420 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1421 (no DOUBLE images in kosher DICOM,
1422 but so usefull for people that miss them ;-)
1424 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1425 DICOMDIR related utilities (not checked as Windoze compliant)
1427 2004-01-28 Jean-Pierre Roux
1428 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1430 2004-01-27 Jean-Pierre Roux
1431 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1432 to allow skipping the shadow elements, to save memory space.
1433 The TRUE value for this param has to be used
1434 with a FALSE value for the 'enable_sequence' param.
1435 ('public elements' may be embedded in 'shadow Sequences')
1436 * gdcmHeader methods now deal with 'embedded icones images' in the header
1437 (even when an 'icone image sequence' is announced by the
1438 element (0x0088,0x0200), but there is NO icone at all ...
1440 * gdcmHeader sometimes Image Location value doesn't follow
1441 the supposed processor endianity (see gdcmData/cr172241.dcm).
1444 * gdcmHeader add the method
1445 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1446 to get *all* the Header Entries with the same tag.
1447 GetHeaderEntrySameName is probabely *useless*
1448 (no meaning : Name is *not* an identifier within the Dictionnary)
1450 2004-01-26 Benoit Regrain
1451 * Bug fix in the print of hexadecimal representations. Remove long fields
1452 in the print and add a third level of print to print them
1454 2004-01-23 Benoit Regrain
1455 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1456 * Bug fix on test suite after remove the strip made on not string fields
1457 * Split the IsReadable method between gdcmParser which test that the file
1458 is dicom and gdcmHeader which test that it's an image file
1460 2004-01-22 Benoit Regrain
1461 * DicomDir : clean code, add methods, set variables in protected or private
1462 * gdcmUtil : bug fix for the clean string method
1464 2004-01-19 Benoit Regrain
1465 * Add the use of shadow dictionaries
1466 * bug fix and coding style
1468 2004-01-19 Benoit Regrain
1469 * src/gdcmFile.cxx : bug fix concerning the close of file
1470 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1471 * Add the update of header entries using the shadow library
1473 2004-01-19 Benoit Regrain
1474 * removal of file gdcmHeader2.cxx
1475 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1476 inheriting from gdcmParser. This split is to prepare the integration
1477 of dicom dir parsing
1478 * bug fix under python
1480 2004-01-16 Jean-Pierre Roux
1481 * REM removal of class gdcmHeaderEntrySet
1482 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1483 * ADD add file gdcmHeader2.cxx
1484 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1486 2004-01-15 Benoit Regrain
1487 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1488 entries created while parsing the header. Thus, they will be destroyed
1489 when the gdcmDictSet will be destroyed
1490 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1493 2004-01-15 Benoit Regrain
1494 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1495 made a fatal error because of the memory release at the end of program.
1496 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1497 some memory and vtk seems to have some problems with that.
1498 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1500 2004-01-14 Benoit Regrain
1501 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1502 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1503 * src/*.[h|cxx] : make changes due to class name changes
1504 * gdcmPython/demo/*.py : bug fix due to method names
1506 2004-01-13 Benoit Regrain
1507 * src/*.[h|cxx] : coding style
1508 * vtk/*.[h|cxx] : coding style
1510 2004-01-13 Benoit Regrain
1511 * gdcmPython/testSuite.py : test the readable flag of file for tests
1512 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1513 It's lied to the stl compilation by MSVC (windows, always windows...)
1514 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1516 2004-01-12 Benoit Regrain
1517 * src/*.h : add comments
1518 * src/gdcmDictSet.h : set the method BuildDictPath in public
1519 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1520 directly setted in the source code
1521 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1524 2004-01-09 Benoit Regrain
1525 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1526 * setup.py : use a reference to gdcmVERSION
1528 2004-01-07 Benoit Regrain
1529 * Modification to compile with the distutils.
1532 2003-12-10 Benoit Regrain
1533 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1534 can use a gdcmHeaderHelper to load datas
1535 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1536 made in the source code
1538 2003-12-10 Benoit Regrain
1539 * Update Windows projects and .cvsignore files
1541 2003-11-12 Jean-Pierre Roux
1542 * ENH gdcmHeader constructor has one more parameter (default value : false)
1543 that allows the user to 'go inside' the SeQuences only
1545 gdcmElValSet:Print takes it into account
1547 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1548 * ENH: Update gdcmPython/CMakeLists
1549 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1550 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1552 2003-11-10 Jean-Pierre Roux
1553 * FIX : gdcmHeader::LoadElements is now based
1554 on the ListTag listElem member,
1555 not longer on the TagElValueHT tagHt member
1556 * ENH : PrintPubElVal shows (temporarily) both results,
1557 with the tagHt member and the listElem member.
1558 (it's easier to 'see' the problems when using Printheader)
1560 * FIX : old private member LgrElem is now splitted into
1561 ReadLength : Length actually found on disk (updated only
1562 if bug fixing is necessary), for internal
1564 UsableLength : Updated by FixFoundLength, to fix a bug
1565 or to allow Parser going on.
1566 Will allow to re-write a kosher header when a SeQuence
1567 with a length (not 0000) is found
1568 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1569 because gdcmElValSet::Add does not update ListElem
1572 2003-11-07 Jean-Pierre Roux
1573 * FIX misstyping in Transfert Syntax name table
1574 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1575 when they have an actual length (not 0000 nor FFFFF)
1576 (Nobody should care of it, but DICOMDIR explorers)
1578 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1579 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1581 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1582 * ENH: vtkGdcmReader now supports LUT !
1583 (vtkgdcmViewer for now is not able to use them though)
1585 2003-11-05 Jean-Pierre Roux
1586 * in testSuite.py : new files names for checking the package
1587 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1588 that returns the pixel area size to the *aware* (vtk) user
1589 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1591 2003-11-05 Benoit Regrain
1592 * in testSuite.py : Modify the rules for checking the paths
1593 : Explicit error messages
1594 * in __init__.py : Related modif
1596 2003-11-03 Jean-Pierre Roux
1597 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1598 to be used by aware (vtk) users that want to manage
1599 LUT (and no to turn the PALETTE image into an RGB pixels one)
1600 * GetPixelType now returns 8U for 24 Bits images
1601 (vtkGdcmReader compliant)
1603 2003-10-31 Jean-Pierre Roux
1604 * Removal of *all* gdcmData images and add them again
1605 in order to loose the 'history' of un-anonymised images
1607 2003-10-31 Jean-Pierre Roux
1608 * RMV : removal of useless jBitsInJsample.h
1609 for both 8 and 12 Bits JPEG Lossy Libraries
1611 2003-10-31 Jean-Pierre Roux
1612 * ENH : Add the functions gdcmFile::GetImageDataRaw
1613 gdcmFile::GetImageDataIntoVectorRaw
1614 that act as GetImageData and GetImageDataIntoVector
1615 except the making of an RGB Plane from Gray Plane + LUT
1616 Intended to aware (vtk) users who know how to manage
1619 GetLUTRGBA return a R,G,B,A LUT if any
1620 lgrTotaleRaw gives the 'Raw' length
1621 GetImageDataRaw returns the gray Plane
1622 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1623 (They stay Grey, just like with other Dicom viewers :-(
1625 2003-10-30 Jean-Pierre Roux
1626 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1628 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1629 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1630 being coherents dicom files.
1632 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1633 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1635 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1636 * ENH: Two steps is necessary to please VC++ compiler...
1637 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1638 * ENH: Add include dir to medcon lib
1639 * FIX: only one function is being exported for now !
1640 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1642 2003-10-29 Jean-Pierre Roux
1643 * adding gdcmHeader::GetLUTRGBA
1644 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1645 --> Mathieu, the modif u're waiting for is not yet committed
1646 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1648 2003-10-27 Jean-Pierre Roux
1649 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1650 00191113.dcm DermaColorLossLess.dcm
1651 MxTwinLossLess.dcm RadBWLossLess.dcm
1652 * ENH: For version prior to vtkImageViewer2 -r 1.19
1653 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1655 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1656 * Removal of ido stuff in CMakeLists.txt
1658 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1660 * FIX: remove a call to ->Modified ... see comments
1661 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1663 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1664 * FIX: Problem with path for libvtkgdcmPython
1665 * ENH: Try adding a search script for python site-package
1666 * RMV: Remove some file from medcon lib that are not necessary
1667 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1668 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1669 * FIX: More pragma disable fro VC++,
1670 I don't think I break something as it is also disable in VTK/ITK.
1671 But it fasten debug compilation time.
1673 2003-10-23 Jean-Pierre Roux
1674 * gdcm now deals with 16 Bits Run Length Encoded images
1675 (they are compressed as 2 planes images,
1676 one for the high Bytes, the other for low Bytes)
1678 2003-10-22 Jean-Pierre Roux
1679 * Now CheckRead takes into account :
1680 - the bugged 'Leonardo' Siemens images
1681 - the XA images, sent thru the burning VPRO station
1682 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1685 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1686 * FIX: When copying a Makefile.am to CMakeLists.txt
1687 one should remove the '\'
1689 2003-10-22 Jean-Pierre Roux
1690 * in gdcmData adding a bugged 'Leonardo' Siemens image
1691 (wrong lengths in header)
1692 OK with gdcm, KO with the other viewers :-)
1693 * add a GE dlx XA image, thru the VEPRO burning station
1696 2003-10-21 Jean-Pierre Roux
1697 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1698 for a brutal checking of vtkgdcmViewer compliance
1700 2003-10-21 Jean-Pierre Roux
1701 * add the files for 'xmedcon' Jpeg Lossless library
1702 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1704 2003-10-21 Jean-Pierre Roux
1705 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1707 2003-10-21 Jean-Pierre Roux
1708 * garbage Siemens 'Leonardo' images dealt with
1709 (the patch is easy to remove)
1710 * cosmetic changes to avoid warnings
1712 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1713 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1714 no need to press 'r' now.
1716 2003-10-20 Jean-Pierre Roux
1717 * upgrade of checkRead.sh checkWrite.sh according
1718 to new Jpeg Lossless decompressor
1719 * add US.3405.1.dcm, a genuine RGB medical file ...
1720 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1721 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1723 2003-10-15 Jean-Pierre Roux
1724 * general anonymisation in gdcmData
1725 * adding the 'color files' from
1726 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1727 * adding some well knowed bugged-header images
1728 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1729 waiting for their inclusion in Python testsuite
1731 2003-10-15 Jean-Pierre Roux
1732 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1733 no longer seg faults when file is not found
1735 2003-10-14 Jean-Pierre Roux
1736 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1739 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1740 * TODO: *.in file to genereate a UseGDCM later
1742 2003-10-14 Jean-Pierre Roux
1743 * Some supposed-to-be Dicom Images have no preamble.
1744 OpenFile takes it into account
1745 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1746 * Missing elements added in dicomV3.dic
1747 (just to be affraid : have a look at
1748 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1749 and do it again next year ;->
1751 2003-10-13 Jean-Pierre Roux
1752 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1753 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1754 But there are NOT. It's fixed !
1756 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1757 * FIX: "jpeglib.h" was not found on VC++
1758 * FIX: vtkgdcm was not being installed
1760 2003-10-10 Jean-Pierre Roux
1761 * ENH : OpenFile closes the file if it *really* doesn't look like
1762 an ACR-NEMA / DICOM one.
1763 * FIX : testWrite no longer writes an empty file if the source file
1764 is not gdcm Readable
1765 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1768 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1769 * FIX: CMake generate now documentation
1770 * ENH: out of source doc build !
1771 * ENH: Generate both user and dev documentation
1772 * ENH: Should work on windows too
1773 * ENH: Only one doxygen config.in file is needed
1774 * FIX: make install should be ok now on ùnix plateform
1775 * FIX: PATH to dictionary was wrong (missing /)
1776 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1778 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1779 * vtkGdcmReader is now able to read rgb dicom file.
1780 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1781 * added a gdcmViewer to vtk test, use mouse to control
1782 window level & window width
1784 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1785 * CMake-ification of gdcm, we have now two build system
1786 * FIX: on cygwin Wsock32 doesn't exist
1787 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1789 2003-10-06 Emanuel Ollart
1790 * FIX : compilation process wad broken.
1791 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1793 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1794 * change gdcmViewer -> vtkgdcmViewer
1795 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1797 2003-10-06 Jean-Pierre Roux
1798 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1799 ( e.g : well known GE images with a wrong elem length,
1800 : Philips MRI Images with a wrong Huffman table)
1801 * still to be done : allow the reading of bugged LEONARDO Siemens images
1803 2003-10-03 Jean-Pierre Roux
1804 * Odd length strings are padded with '\0' (not with spaces,
1805 to remain compliant with already defined strings,
1806 like Transfert Syntax UID and others)
1808 2003-10-03 Jean-Pierre Roux
1809 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1810 to allow displaying RGB images (not only by affim ;-)
1812 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1813 * vtkGdcmReader is now able to read rgb dicom file.
1814 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1816 2003-10-03 Jean-Pierre Roux
1817 * A few nasty patches to allow the reading of a lot of nasty images
1818 ( e.g : well known GE images with a wrong elem length,
1819 : Philips MRI Images with a wrong Huffman table)
1820 * still to be done : allow the reading of bugged LEONARDO Siemens images
1822 2003-10-03 Jean-Pierre Roux
1823 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1825 2003-10-03 Jean-Pierre Roux
1826 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1827 to allow displaying RGB images (not only by affim ;-)
1829 2003-10-03 Jean-Pierre Roux
1830 * gdcmFile::GetImageDataIntoVector now
1831 - deals with MultiFrames MultiFragments Run Length Encoded files
1832 - deals with YcBcR (YBR_FULL) files
1833 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1834 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1836 (no sample found :-(
1838 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1839 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1840 Two reasons: - clear things
1841 - third parties acces gdcm through header files, so won't
1842 suffer anymore VC++ complains
1844 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1845 * add argv[1] in testvtkGdcmReader.cxx
1848 2003-09-24 Jean-Pierre Roux
1849 * The lines are now eigthy characters long.for
1850 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1852 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1853 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1854 char* to std::string. Thus, the use of strdup becomes useless. (see
1855 previous commis of Malaterre)
1856 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1857 before the last Malaterre's commit.
1859 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1860 * This commit should fix the Debug building under VC++, the problem
1861 was mainly a mixture of debug and release lib being loaded at startup.
1862 * I also remove a depency to a specific C function: strdup. Because I had
1863 to force the link to msvcrtd (whereas strdup is in libc).
1865 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1866 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1867 located in the gdcmCommon.h file. All use of reference of tha has been
1868 changed to now use the variable GDCM_UNFOUND.
1870 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1872 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1873 Dicom dictionary. The test suite can now be run again. Note:
1874 I'm note very happy with the " (RET)" changes. I believe this
1875 RETAINED comment should be dropped when parsing the dictionary.
1876 - PACKAGER corrected
1878 - AUTHORS updated and now in alphabetical order
1879 * Makefile.am now exports gdcm.dsw for Windoze users.
1881 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1882 * cygwin complains about missing std:: in subdir Test/
1884 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1885 * remove some methods that are now in gdcmHeaderHelper
1887 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1888 * vtkGdcmReader set spacing and origin correctly
1890 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1891 * Fix a few delete/delete[] mismatch
1893 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1894 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1895 interpretation to data given by gdcmHeader. For instance there are
1896 heuristics to get informations (look at different places).
1897 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1898 sorting DICOM images based on different strategies.
1899 * modified Makefiles accordingly.
1901 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1902 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1903 when building in debug mode
1904 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1905 src/win32/gdcmdll.dsp
1906 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1908 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1909 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1912 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1913 * src/win32/libgdcmjpeg12.dsp was not dos format
1914 * src/win32/libgdcmjpeg12.dsp :
1915 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1916 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1918 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1919 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1921 * src/gdcmFile.cxx : bug fix in affectation type
1922 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1923 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1924 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1925 symbols... future problem ?
1927 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1928 * src/win32/libgdcmijpeg12.dsp was missing
1929 * modified gdcm.dsw accordingly
1931 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1932 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1934 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1935 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1936 commit of JPR (before his hollidays to facilitate our work).
1937 * setup.py : bug fix in code. Modifications made while the last commit
1938 of JPR. The code hasn't been tested before the commit... it's so
1939 useless to make that (for best programmer that is JPR) !!!
1941 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1942 * tagged the current version as Version0_3 (i.e. version 0.3)
1944 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1945 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1946 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1947 * *.dsp : modifications to use new libgdcmijpeg8 library
1948 * setup.py : bug fix on VTKPATH variable
1949 * PACKAGER : adding all concerning windows
1951 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1952 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1954 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1955 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1956 test suite reported error.
1957 * PACKAGER file added (describes what a packager must do when
1958 packaging a new release).
1959 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1960 * configure.in: upgraded version number to 0.3.0
1961 * fixing build of rpm (through rpm -ta):
1962 - Doc/Makefile.am exports proper doxygen files
1963 - src/jpeg/libijg8/Makefile.am exports the include files.
1965 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1966 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1967 * src/gdcmHeader.h : formatting code
1969 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1970 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1971 We were obtaining error message from vtk. Now, creation of file list
1972 is made in an internal list to prevent this problem.
1973 Bug fix when output is empty.
1974 Bug fix in update of progress value. Previous commit for this was a bad
1976 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1978 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1979 * src/gdcmHeader.h : added method to get the file name
1980 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1981 files. Added method to remove all files on the input
1982 Added FIXME comment concerning the bad parsing of header made by
1983 ExecuteInformation method (in ExecuteData method)
1985 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1987 when using make instal.
1988 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1989 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1991 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1992 * setup.py : adding include dir of jpeg lib to compile all sources
1993 * */Win32/*.dsp : JPR fix for windows compilation
1995 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1996 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1998 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1999 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2001 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2002 * setup.py is again effective on un*x (takes into account the
2003 addon of the jpeg library)
2004 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2005 * Doc/Doxy* updated (includes above enhancements)
2006 * INSTALL now points to web documentation
2008 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * src/gdcmHeader.h doesn't make unnecessary reference to
2011 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2013 * src/gdcm*.[cxx|h] :
2014 - to allow compilation with gcc 3.x
2015 -- clean up of STL usage (added explicit usage of std::)
2016 -- small fixes on exceptions.
2017 Note: linking not tested !
2018 - clean of doxygen comments to avoid warnings at documentation
2020 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2021 dependent convertion).
2023 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2024 * Clean up of previous JPR garbage commit (not even commented in the
2026 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2027 - moved all jpeg related files from src to src/jpeg/libijg8, with
2028 addition/modification of Makefile.am and configure.in.
2029 - the testSuite is still brain damage (not guilty).
2031 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2032 * WrapVTK.py : modifications to get correctly vtk source files to
2034 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2035 (FileName -> Filename)
2037 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2038 * vtk/vtkGdcmReader.[cxx/h]:
2039 - UpdateProgress method should now be effective
2040 - removed the limitation on having only images loaded (as opposed
2042 - when building a stack of images/volume, a lesser number of
2043 gdcmHeader and gdcmFile instances should be used (hopefully
2044 accelerating things).
2045 - when building a stack of images/volumes, files which are not
2046 loadable (wrong path-filename, wrong permissions on existing file,
2047 or file not parsable by gdcm) are replaced with a black image
2048 in the stack (for the caller to notice the problem).
2050 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2051 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2053 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2054 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2055 between standard library (std) and vtk library (problems are found
2056 under Windows... thanks Windows !)
2058 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2059 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2061 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2063 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2064 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2066 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * When compiling with distutils (see setup.py) the C++ compiler is
2068 called with different flags than the default ones (with automake).
2069 In order to fix all those warning, I compiled gdcm with the command
2070 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2071 and went for warning fixes:
2072 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2073 up from unused variables.
2074 - vtk/vtkGdcmReader.cxx: potential bug fix.
2075 * src/gdcmHeader.h: Doxygen warning cleanup
2077 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2078 * gdcmPython/gdcm.i:
2079 - typemaps correction to take into account the systematic replacement
2080 of "using namespace std" with std:: prefix e.g. std::list,
2081 std::string... (cf changes of 2003-05-21).
2082 - gdcmGlob global variable of type gdcmGlobal (defined in
2083 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2084 exported to Python a as cvar.
2085 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2086 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2087 gdcmDictSet.GetPubDictTagNames() and
2088 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2089 C++ static methods).
2090 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2091 with the above changes.
2093 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2094 * setup.py, manifest.in : bug fix under linux
2096 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2097 * Modification of setup.py to compile vtk part too. Then, we have 2
2098 wrappers which must work with same distutils. For that, we have a
2099 generic distutils in distusiltsWrapping.py ; with :
2100 - build_extWrap class to wrap generically all extensions,
2101 - ExtensionWrap base class for all wrapping extension that contains
2103 - Wrapper interface which wrap sources
2104 + In WrapSwig.py we have extension and wrapper for Swig
2105 + In WrapVTK.py we have extension and wrapper for VTK
2106 * MANIFEST.in : modifications to consider vtk directory and new python
2107 files for compilation
2109 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2110 * Added python wrappers of vtkGdcmReader vtk class (see the
2111 source in vtk/vtkGdcmReader.cxx) :
2112 - vtk/Makefile.am now builds a library
2113 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2114 python library (as opposed to _gdcm.so wich are the python
2115 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2116 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2118 - configure.in has an additional flag --enable-vtk that needs
2119 to be set to enable compilation of vtk related code, that is:
2120 + vtk/vtkGdcmReader.so and
2121 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2122 + gdcmPython/vtkgdcmPython.so (see above)
2123 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2124 be read when compressed or when HighBit + 1 != BitsStored),
2125 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2126 the usage of the python wrapper of vtkGdcmReader vtk class.
2127 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2128 * src/*.[h] all occurences of stl classes are now prefixed with
2129 std::, and all occurences of "using namespace std;" where removed.
2130 This is to avoid pollution of global namespace in included files.
2131 Apparently vtk does not avoid this pitfall: when using both
2132 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2133 collision of various stl members (principally cout...).
2134 * gdcmPython/testSuite.py now cleanly removes temprory generated
2136 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2137 comply with above changes)
2139 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2140 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2141 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2142 vtk data structure (an image Flip was required).
2143 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2144 * cosmetic changes in documentation.
2146 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2147 * src/gdcmHeader.cxx: the constructor no longer exits when an
2148 unexisting file is given as argument.
2149 * The subdirectory Data (containing all the images used for the
2150 test suite) is not part of this repository anymore. A new module
2151 containing those images is now available at
2152 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2153 with the name gdcmData.
2154 All the python scripts (including the package initialisation file
2155 gdcmPython/__init__.py) were adapated to take this change into
2156 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2158 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2159 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2160 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2161 demo of the usage of this class.
2162 Compilation of this vtk part is only done when using the --enable-vtk
2163 at configure (or autogen.sh) stage.
2165 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2166 * More memory link related corrections and documentation fixes.
2168 - maximum info is obtained with a command of the form:
2169 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2170 --show-reachable=yes PrintHeader
2171 - the remaining reachable blocks seem to come from the STL
2172 allocation scheme through the usage of map and list. It looks
2173 like this memory cannot be freed but it is not a memory leak
2174 (in fact further invocation to the STL would recollect the
2175 unused memory allthough it cannot explicitely be freed).
2176 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2177 of displaying an image parsed with gdcm and displayed with VTK.
2178 Note: some images don't seem to work e.g.
2179 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2180 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2181 Allthough this weakens the semantics, it is a ditch attempt to
2182 make gdcm more thread friendly.
2184 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2185 * Memory link hunt (by using valgrind through the command
2186 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2187 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2188 gdcmHeader::_dicom_vr.
2189 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2190 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2192 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2194 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2195 * src/Makefile.am now exports all the necessary include files at
2199 * UpdateGroupLength replaced by new one
2202 * UpdateGroupLength re-written using H-Table
2203 (named UpdateGroupLengthNew untill checks are over)
2205 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2206 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2207 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2209 - gdcmHeader::GetPubElValSet removed.
2210 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2211 UpdateGroupLength, WriteElements, Write.
2212 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2213 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2214 carried the same semantics.
2215 - src/gdcmHeaderIdo.cxx changed accordingly.
2216 - gdcmFile::WriteBase now regroups all the codes from previous
2217 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2218 - enum FileType moved to gdcmCommon.h
2219 * src/gdcmHeader.cxx AddDefault trashed
2220 * gdcmGetXSize added
2221 * getimageDataSize now calls gdcmGetXSize
2222 * Test/*.cxx changed to agree with above changes
2224 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2225 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2226 (to avoid double call by end user).
2227 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2228 by end user, since gdcmHeader::gdcmHeader now handles it.
2230 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2231 * gdcm/Doc many doxygen changes:
2232 - Doxyfile now has two different versions, DoxyfileUsers that generates
2233 the html.users end users oriented documentation and
2234 DoxyfileDeveloppers that generates the html.developper developper
2235 oriented documentation.
2236 - README changed accordingly
2237 - requirement.txt removed (old design info moved to TODO).
2238 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2239 DoxyMainPage.txt, DoxyPython.txt provide more information.
2240 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2241 be updated by simply regenerating the docs with doxygen and copying
2242 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2243 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2244 all the tests in the form "if (<map>.count() >1)" were removed.
2245 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2246 ill-formed documentation sections.
2247 * src/gdcmHeader.cxx: ditto
2249 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * setup.py fixed for un*x (needed macro for stdint.h)
2251 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2252 un*ces with sh-utils test utility.
2253 * gdcmPython/demo/test.py renamed to PrintHeader.py
2254 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2255 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2256 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2257 * src/gdcm*.cxx JPR's bad inclusion fixed.
2259 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2260 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2261 * gdcmPython/demo/test.py changed accordingly.
2263 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2264 * gdcmPython/Makefile.am fixed linking against libstdc++
2265 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2266 * Swig subdir (historical tests of swig version 1.3.17++) removed
2267 * Test/testChangeEntete.cxx some lines commented out in order to make
2269 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2270 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2272 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2273 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2274 hence the user doesn't need this explicit call.
2275 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2276 i.e. LoadElements() call removed.
2277 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2278 - src/Makefile.am declares the proper flag for g++.
2279 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2280 for adding user defined new tags.
2281 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2282 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2283 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2285 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2286 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2287 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2288 src/Makefile.am : the project should properly compile and install
2289 with the autotools, included the python wrappers part.
2290 * gdcm.spec.in : added a spec file for RPM packaging.
2292 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2293 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2295 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2297 to exported to the environement (see gdcmPython/testSuite.py
2299 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2300 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2301 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2302 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2303 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2305 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2306 * gdcmPython/__init__.py doesn't crash anymore when running in
2307 in InstallMode or PreInstallMode but with an environement given
2308 value of GDCM_DICT_PATH.
2309 * src/gdcmDictSet.[cxx/h] coding style.
2311 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2312 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2313 * src/gdcm.h general comments moved to TODO, and README
2314 * src/gdcm.h should now be seen as a user commodity (including it
2315 should suffice to fully use gdcm). It is nowhere including within
2316 any of the kernel files src/*.cxx and src/*.h.
2318 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2319 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2320 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2322 * src/gdcm*.cxx only include their corresponding include file
2323 (as opposed to gdcm.h)
2324 * gdcmPython/gdcm.i changed accordingly
2325 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2326 the autogen.sh generated "make snapshot" command to work.
2327 * autogen.sh removed history related references to crea package.
2329 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2330 * distutilsSwigCPlusPlus.py work around some swig portability
2333 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2334 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2335 was done in a last ditch attempt to get setup.py _really_
2336 operationnal. The python/gdcmPython layaout add the advantage
2337 of hidding away the python related distutils specific files
2338 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2339 Alas, the src directory was out of scope (i.e. it's relative
2340 position to setup.py was ../src) which made things impossible to
2341 handle (see previous version of python/setup.py). Crossing fingers...
2343 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * python/setup.py now works on Un*x. (harder than I thougth)
2345 * python/distutilsSwigCPlusPlus.py can now have include files
2346 among the list of sources.
2348 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2349 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2350 * modifications in MSVC projects
2352 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2353 * As stated by the first lines of Test/ExceptionAndPython/README, it
2354 looks like we can move back to original usage of exception within
2355 src/gdcm* and hence remove the errno stuff that was introduced
2356 as a quick and dirty fixture of this problem (added to the TODO).
2357 * Doc/Doxyfile configuration file for Doxygen and corresponding
2358 README file for usage added.
2359 * Test/testWrite.cxx added. This new test comes from a split of
2360 test.cxx that is now reverted to its original purpous i.e.
2361 testing the proper parsing of a Dicom related file.
2362 testWrite.cxx concentrates on testing the IO part of gdcm.
2363 * Test/bug1.cxx (containing a bug on WIn32) added.
2364 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2365 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2366 whose purpose is to publish the content of the TagNames of the
2367 Dicom public dictionnary were not accessible without an
2368 instance of class gdcmHeader.
2369 - those methods are now static methods of gdcmDictSet and hence
2370 require no instances at all to be invocated.
2371 - within gdcmDictSet this change required to change some method
2372 to class methods (i.e. are now static) among which SetDictPath
2373 (renamed to BuildDictPath) and LoadDefaultPubDict.
2374 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2375 the above changes by calling the new method classes of gdcmDictSet.
2376 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2377 the above to be effective.
2378 * python/gdcmPython: in order to wrap properly the above changes
2379 for Python, swig version now needs to be > 1.3.17.
2380 * python/gdcmPython/Makefile fixed to adapt itself to new
2381 configure/make shema introduced by Johan Montagnat (thanks for the
2382 contribution). Alas this Makefile cannot be turned into a proper
2383 Makefile.am without some heavy changes in the configure.in
2384 (for python dectection).
2385 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2386 now avoids publishing the empty entries.
2388 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2389 * python/setup.py : bug fix concerning install under windows
2390 ExtraPath reused :-P
2391 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2393 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2394 * Dicts/dicomV3.dic : remove double spaces !!!
2395 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2396 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2399 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2401 method. Doxygenation.
2402 * src/gdcm.h clean up of JPR spurious comments.
2404 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2405 * python/distutilsSwigCPlusPlus.py now properly collects the
2406 shadow classes generated by "swig -c++" (gdcm.py in our case)
2407 when using "python setup.py install".
2408 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2409 reexports the working classes.
2410 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2411 by the classical C errno scheme. This is to prevent an obscure
2412 behavior of the python wrappers when importing wxPython.wx prior
2413 to gdcmPython (which ended up in an abort call). An illustration
2414 of this oddity can be found in the Test/ExceptionAndPython
2415 subdir (see the README file). This problem probably due to
2416 an combination of g++ and dynamic loading.
2417 * added Test/ExceptionAndPython (see above)
2419 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * Changed the layout of the python part to avoid bloating main
2421 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2422 i.e. the distutils arsenal. All the python related stuff is
2423 again in a python subdir, but the package itself is now in
2425 * setup.py was cleaned up:
2426 - pythonIncludePath removed
2427 - python setup.py bdist target is now functional.
2428 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2429 collision with other packages). gdcmPython/demo/*.py changed
2432 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * python subdir moved to gdcmPython (preparation of distutils packaging).
2434 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2435 distutils installer is operational.
2436 * - gdcmPython/__init__.py now properly loads the swig generated
2437 shadow classes (from gdcm.py).
2438 - gdcmPython/demo/*.py changed to import the package gdcmPython
2439 instead of gdcmPython/demo/load.py.
2440 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2442 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2443 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2444 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2445 entries within the associated public Dicom dictionary resp. the same
2446 information but sorted by the fourth field (PAT, IMG, DIR) of the
2448 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2449 are now in the "???" group.
2450 - python/gdcm.i changed accordingly,
2451 - python/demo/printGroupedPublicDict.py added, that gives an example
2452 of the above new functionalities in Python.
2454 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2455 * src/gdcm.h, gdcmHeader.cxx:
2456 - historic references to glib's g_malloc and g_free (#defined)
2457 were definitively removed.
2458 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2459 * src/gdcmElValSet.cxx:
2460 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2461 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2462 - GetElValue(string) renamed to GetElValueByName.
2463 - Added GetElementByName(string).
2464 * src/gdcmHeader.cxx: added
2465 - GetPubElValRepByNumber(guint16, guint16)
2466 - GetPubElValRepByName(string)
2467 - GetShaElValRepByNumber(guint16, guint16)
2468 - GetShaElValRepByName(string)
2469 - GetShaElValByNumber(guint16, guint16)
2470 - GetShaElValRepByName(string)
2471 - GetElValRepByNumber(guint16, guint16)
2472 - GetElValRepByName(string)
2473 - GetElValByNumber(guint16, guint16)
2474 - GetElValRepByName(string)
2475 * Doc/requirements.txt added.
2477 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2478 * Test/Makefile building now depends on the one of libgdcm.so
2479 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2480 pixel data) aware which enables finding the address (offset) of
2481 the pixel data of JPEG encoded DICOM files. This leaves only a single
2482 file in the testSuite whose pixel data address (offset) is unknown.
2483 * python/testSuite.py changed accordingly.
2485 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2486 * VC++ has some strong limitations when working with the STL, as stated
2487 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2488 "Also note that some STL containers (map, set, queue, list, deque)
2489 cannot be exported. [...]
2490 Some STL classes contain nested classes. These classes can not
2492 This is caused by a designed limitation that once a template
2493 class is instantiated, it can not be re-instantiated and
2495 Since our usage of map<> is ubiquitous in gdcm, this "designed
2496 limitation" of VC++ is a pitfall.
2497 Hence the Python wrappers of gdcm cannot be incrementally linked
2498 against the c++ dynamic library. The dirty but only workaround is
2499 to forget about incremental link of dynamic libraries and to generate
2500 the Python wrappers library with the inclusions of the underlying C++
2502 The following modifications concern this matter on Win32/VC++:
2503 - wrapping python correct with standalone wrapped dll (don't use separate
2504 dll under windows !!!!)
2505 - python21_d debug mode enabled (ask Frog how to use it :-)
2506 - NO problem with having an STL member of class for example string in C++
2507 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2508 - Python test of dcmlib in Python is ok under windows on a large set
2510 * removed glib references
2511 * typedef's inserted in gdcm.i for correct swig type management
2513 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * python/demo/*.py load.py extracted from test.py. Added explore.py
2515 that only displays required tags and testAll.py that parses all
2516 the files of the testsuite without using unittest.
2517 * python/testSuite.py other additional test on new files added.
2518 * Data/* new test files added accordingly to the testSuite.
2519 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2520 the vr in the file differs from the one of the dictionary.
2522 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2523 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2524 values, but limits itself to values which are below a user specified
2525 size (by default 1024 bytes).
2526 * python/gdcm.i : elements not loaded (because their size is above the
2527 user specified treshold) are exported with their TagKey as key of the
2528 python dictionary. This enables the testsuite to make some checks
2529 on the unloaded elements (since we have their offset and size).
2530 * python/testSuite.py
2531 - now tests for the existence and proper value of the pixel data
2532 - two new examples added.
2533 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2535 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2536 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2537 aware. See the strategy comments in gdcmHeader::FindeLength().
2538 * Test/test.cxx now accepts a filename as first argument.
2539 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2540 * python/testSuite.py changed to integrate test on above files.
2542 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2543 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2544 the vr was also RET.
2545 * python/testSuite.py more tests added.
2547 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * python/testSuite.py unittest test suite added (uses Data)
2549 * Data/* dcm and acr files for the test suite.
2550 * glib dependance removed from un*x version. We now use ISO C99
2551 7.18 Integer types (see stdint.h)
2552 - python/Makefile, src/Makefile src/gdcm.h
2553 * src/ when an explicit vr (like dicom files) suddenly poped an
2554 implicit element we use to mark the underlying DictEntry of the
2555 concerned ElValue with "Implicit". This strategy was damageable
2556 too the public or provite dictionaries, since some of their vr
2557 would be changed. Since Header::FindLength heavily relies on the
2558 detection by Header::FindVR of falsely explicit elements, I
2559 added an extra ImplicitVr member to ElValue (boolean).
2560 The rest of the changes we the necessary adaptations.
2562 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2563 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2565 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2567 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2568 * Adaptation for porting to VC++:
2570 o forced to use std namespace (for string to be known)
2571 o all class use __declspec export style on WIN32
2572 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2573 (in stdlib.h on Win32 but in std:: for gcc)
2574 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2575 variable GDCM_DICT_PATH.
2576 * src/gdcmHeader.cxx verbose comments made discrete.
2578 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * python/gdcm.i: added a typemap that converts a C++ hashing table
2580 to native Python dictionary.
2581 * python/demo/test.py:
2582 - now uses the native dictionary for exploration of gdcmHeader.
2583 - takes an optional filename argument (the file to parse).
2584 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2585 PubElVals hashing table.
2586 * Dicts/dicomV3.dic removed error prone trailing spaces.
2588 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * Python wrapping process moved away from src/Makefile to
2590 newly created python/Makefile (as well as gdcm.i)
2591 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2592 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2593 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2594 from the environement variable GDCM_DICT_PATH (when existing).
2595 * src/gdcmDict::GetTag bug fix.
2597 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * Straightforward temporary fixes for swig to build the python wrappers.
2599 src/Makefile now has a python working entry [by working we mean
2600 that we can import de shadow classes without errors].
2602 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2603 * hashtest.cxx removed (since allready in Test)
2604 * src/gdcmlib.h renamed to src/gdcm.h
2605 * src/dcm.i renamed to src/gdcm.i
2606 * src/Makefile prepared for python wrapping
2608 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2609 * src/gdcmHeader.cxx :
2610 - Parsing of header is now separated from loading of element values
2611 (see gdcmHeader::LoadElements).
2612 - general clean up of hopefully all file access (creation of
2613 ReadInt16 and ReadInt32)
2615 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2616 * src/gdcmHeader.cxx :
2617 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2619 - SetLgrElem renamed to SetLength
2620 - GetLgrElem renamed to GetLength
2621 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2622 * src/gdcmElValSet.cxx fixed both GetElValue methods
2623 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2624 due to IdoDude was cleaned out.
2626 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2627 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2628 concentrates on finding the value representation (when it exists).
2629 RecupLgr now only finds the element value length, and it avoids
2630 returning the unecessary skL (skipped length).
2631 Also, offsetCourant was simply removed (with taille_fich) since
2632 it was redundant with the File position internals (by using
2633 ftell and fseek). This also made skL (see above in RecupLgr) usage
2635 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2636 on the libido specificities which are handled through class
2638 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2641 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * Truckload of changes. Parsing of header is barely functional
2643 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2645 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2646 * src/gdcmHeader.cxx many addons of low level methods
2648 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2649 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2650 and _IdDcmSWAP_LONG.
2652 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2653 * This corresponds to all the changes decided at the meeting of
2654 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob