1 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3 to exported to the environement (see gdcmPython/testSuite.py
5 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
6 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
7 ElValue class renamed to gdcmElValue for obvious consistency reasons.
8 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
9 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
11 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
12 * gdcmPython/__init__.py doesn't crash anymore when running in
13 in InstallMode or PreInstallMode but with an environement given
14 value of GDCM_DICT_PATH.
15 * src/gdcmDictSet.[cxx/h] coding style.
17 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
18 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
19 * src/gdcm.h general comments moved to TODO, and README
20 * src/gdcm.h should now be seen as a user commodity (including it
21 should suffice to fully use gdcm). It is nowhere including within
22 any of the kernel files src/*.cxx and src/*.h.
24 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
26 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
28 * src/gdcm*.cxx only include their corresponding include file
29 (as opposed to gdcm.h)
30 * gdcmPython/gdcm.i changed accordingly
31 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
32 the autogen.sh generated "make snapshot" command to work.
33 * autogen.sh removed history related references to crea package.
35 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
36 * distutilsSwigCPlusPlus.py work around some swig portability
39 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
40 * Eventually, python/gdcmPython was renamed to gdcmPython. This
41 was done in a last ditch attempt to get setup.py _really_
42 operationnal. The python/gdcmPython layaout add the advantage
43 of hidding away the python related distutils specific files
44 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
45 Alas, the src directory was out of scope (i.e. it's relative
46 position to setup.py was ../src) which made things impossible to
47 handle (see previous version of python/setup.py). Crossing fingers...
49 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * python/setup.py now works on Un*x. (harder than I thougth)
51 * python/distutilsSwigCPlusPlus.py can now have include files
52 among the list of sources.
54 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
56 * modifications in MSVC projects
58 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
59 * As stated by the first lines of Test/ExceptionAndPython/README, it
60 looks like we can move back to original usage of exception within
61 src/gdcm* and hence remove the errno stuff that was introduced
62 as a quick and dirty fixture of this problem (added to the TODO).
63 * Doc/Doxyfile configuration file for Doxygen and corresponding
64 README file for usage added.
65 * Test/testWrite.cxx added. This new test comes from a split of
66 test.cxx that is now reverted to its original purpous i.e.
67 testing the proper parsing of a Dicom related file.
68 testWrite.cxx concentrates on testing the IO part of gdcm.
69 * Test/bug1.cxx (containing a bug on WIn32) added.
70 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
71 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
72 whose purpose is to publish the content of the TagNames of the
73 Dicom public dictionnary were not accessible without an
74 instance of class gdcmHeader.
75 - those methods are now static methods of gdcmDictSet and hence
76 require no instances at all to be invocated.
77 - within gdcmDictSet this change required to change some method
78 to class methods (i.e. are now static) among which SetDictPath
79 (renamed to BuildDictPath) and LoadDefaultPubDict.
80 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
81 the above changes by calling the new method classes of gdcmDictSet.
82 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
83 the above to be effective.
84 * python/gdcmPython: in order to wrap properly the above changes
85 for Python, swig version now needs to be > 1.3.17.
86 * python/gdcmPython/Makefile fixed to adapt itself to new
87 configure/make shema introduced by Johan Montagnat (thanks for the
88 contribution). Alas this Makefile cannot be turned into a proper
89 Makefile.am without some heavy changes in the configure.in
90 (for python dectection).
91 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
92 now avoids publishing the empty entries.
94 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * python/setup.py : bug fix concerning install under windows
97 * gdcm.dsw : bug fix concerning path for libraries for python !!!
99 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * Dicts/dicomV3.dic : remove double spaces !!!
101 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
102 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
105 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
106 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
107 method. Doxygenation.
108 * src/gdcm.h clean up of JPR spurious comments.
110 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
111 * python/distutilsSwigCPlusPlus.py now properly collects the
112 shadow classes generated by "swig -c++" (gdcm.py in our case)
113 when using "python setup.py install".
114 * python/gdcmPython/__init__.py imports gdcm.py and only manually
115 reexports the working classes.
116 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
117 by the classical C errno scheme. This is to prevent an obscure
118 behavior of the python wrappers when importing wxPython.wx prior
119 to gdcmPython (which ended up in an abort call). An illustration
120 of this oddity can be found in the Test/ExceptionAndPython
121 subdir (see the README file). This problem probably due to
122 an combination of g++ and dynamic loading.
123 * added Test/ExceptionAndPython (see above)
125 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
126 * Changed the layout of the python part to avoid bloating main
127 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
128 i.e. the distutils arsenal. All the python related stuff is
129 again in a python subdir, but the package itself is now in
131 * setup.py was cleaned up:
132 - pythonIncludePath removed
133 - python setup.py bdist target is now functional.
134 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
135 collision with other packages). gdcmPython/demo/*.py changed
137 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
138 * python subdir moved to gdcmPython (preparation of distutils packaging).
139 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
140 distutils installer is operational.
141 * - gdcmPython/__init__.py now properly loads the swig generated
142 shadow classes (from gdcm.py).
143 - gdcmPython/demo/*.py changed to import the package gdcmPython
144 instead of gdcmPython/demo/load.py.
145 - gdcmPython/testSuite.py changed to import the package gdcmPython.
148 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
149 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
150 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
151 entries within the associated public Dicom dictionary resp. the same
152 information but sorted by the fourth field (PAT, IMG, DIR) of the
154 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
155 are now in the "???" group.
156 - python/gdcm.i changed accordingly,
157 - python/demo/printGroupedPublicDict.py added, that gives an example
158 of the above new functionalities in Python.
160 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
161 * src/gdcm.h, gdcmHeader.cxx:
162 - historic references to glib's g_malloc and g_free (#defined)
163 were definitively removed.
164 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
165 * src/gdcmElValSet.cxx:
166 - GetElement(guint32, guint32) renamed to GetElementByNumber.
167 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
168 - GetElValue(string) renamed to GetElValueByName.
169 - Added GetElementByName(string).
170 * src/gdcmHeader.cxx: added
171 - GetPubElValRepByNumber(guint16, guint16)
172 - GetPubElValRepByName(string)
173 - GetShaElValRepByNumber(guint16, guint16)
174 - GetShaElValRepByName(string)
175 - GetShaElValByNumber(guint16, guint16)
176 - GetShaElValRepByName(string)
177 - GetElValRepByNumber(guint16, guint16)
178 - GetElValRepByName(string)
179 - GetElValByNumber(guint16, guint16)
180 - GetElValRepByName(string)
181 * Doc/requirements.txt added.
183 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
184 * Test/Makefile building now depends on the one of libgdcm.so
185 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
186 pixel data) aware which enables finding the address (offset) of
187 the pixel data of JPEG encoded DICOM files. This leaves only a single
188 file in the testSuite whose pixel data address (offset) is unknown.
189 * python/testSuite.py changed accordingly.
191 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
192 * VC++ has some strong limitations when working with the STL, as stated
193 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
194 "Also note that some STL containers (map, set, queue, list, deque)
195 cannot be exported. [...]
196 Some STL classes contain nested classes. These classes can not
198 This is caused by a designed limitation that once a template
199 class is instantiated, it can not be re-instantiated and
201 Since our usage of map<> is ubiquitous in gdcm, this "designed
202 limitation" of VC++ is a pitfall.
203 Hence the Python wrappers of gdcm cannot be incrementally linked
204 against the c++ dynamic library. The dirty but only workaround is
205 to forget about incremental link of dynamic libraries and to generate
206 the Python wrappers library with the inclusions of the underlying C++
208 The following modifications concern this matter on Win32/VC++:
209 - wrapping python correct with standalone wrapped dll (don't use separate
210 dll under windows !!!!)
211 - python21_d debug mode enabled (ask Frog how to use it :-)
212 - NO problem with having an STL member of class for example string in C++
213 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
214 - Python test of dcmlib in Python is ok under windows on a large set
216 * removed glib references
217 * typedef's inserted in gdcm.i for correct swig type management
219 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
220 * python/demo/*.py load.py extracted from test.py. Added explore.py
221 that only displays required tags and testAll.py that parses all
222 the files of the testsuite without using unittest.
223 * python/testSuite.py other additional test on new files added.
224 * Data/* new test files added accordingly to the testSuite.
225 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
226 the vr in the file differs from the one of the dictionary.
228 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
229 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
230 values, but limits itself to values which are below a user specified
231 size (by default 1024 bytes).
232 * python/gdcm.i : elements not loaded (because their size is above the
233 user specified treshold) are exported with their TagKey as key of the
234 python dictionary. This enables the testsuite to make some checks
235 on the unloaded elements (since we have their offset and size).
236 * python/testSuite.py
237 - now tests for the existence and proper value of the pixel data
238 - two new examples added.
239 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
241 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
242 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
243 aware. See the strategy comments in gdcmHeader::FindeLength().
244 * Test/test.cxx now accepts a filename as first argument.
245 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
246 * python/testSuite.py changed to integrate test on above files.
248 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
249 * Dicts/dicomV3.dic removed all the trailing (RET) when the
251 * python/testSuite.py more tests added.
253 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
254 * python/testSuite.py unittest test suite added (uses Data)
255 * Data/* dcm and acr files for the test suite.
256 * glib dependance removed from un*x version. We now use ISO C99
257 7.18 Integer types (see stdint.h)
258 - python/Makefile, src/Makefile src/gdcm.h
259 * src/ when an explicit vr (like dicom files) suddenly poped an
260 implicit element we use to mark the underlying DictEntry of the
261 concerned ElValue with "Implicit". This strategy was damageable
262 too the public or provite dictionaries, since some of their vr
263 would be changed. Since Header::FindLength heavily relies on the
264 detection by Header::FindVR of falsely explicit elements, I
265 added an extra ImplicitVr member to ElValue (boolean).
266 The rest of the changes we the necessary adaptations.
268 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
269 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
271 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
273 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * Adaptation for porting to VC++:
276 o forced to use std namespace (for string to be known)
277 o all class use __declspec export style on WIN32
278 - src/gdcmUtil.cxx new Exit method that wraps the exit call
279 (in stdlib.h on Win32 but in std:: for gcc)
280 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
281 variable GDCM_DICT_PATH.
282 * src/gdcmHeader.cxx verbose comments made discrete.
284 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * python/gdcm.i: added a typemap that converts a C++ hashing table
286 to native Python dictionary.
287 * python/demo/test.py:
288 - now uses the native dictionary for exploration of gdcmHeader.
289 - takes an optional filename argument (the file to parse).
290 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
291 PubElVals hashing table.
292 * Dicts/dicomV3.dic removed error prone trailing spaces.
294 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
295 * Python wrapping process moved away from src/Makefile to
296 newly created python/Makefile (as well as gdcm.i)
297 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
298 * src/gdcmHeader::FindLength only looks for current vr when necessary.
299 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
300 from the environement variable GDCM_DICT_PATH (when existing).
301 * src/gdcmDict::GetTag bug fix.
303 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
304 * Straightforward temporary fixes for swig to build the python wrappers.
305 src/Makefile now has a python working entry [by working we mean
306 that we can import de shadow classes without errors].
308 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
309 * hashtest.cxx removed (since allready in Test)
310 * src/gdcmlib.h renamed to src/gdcm.h
311 * src/dcm.i renamed to src/gdcm.i
312 * src/Makefile prepared for python wrapping
314 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * src/gdcmHeader.cxx :
316 - Parsing of header is now separated from loading of element values
317 (see gdcmHeader::LoadElements).
318 - general clean up of hopefully all file access (creation of
319 ReadInt16 and ReadInt32)
321 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
322 * src/gdcmHeader.cxx :
323 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
325 - SetLgrElem renamed to SetLength
326 - GetLgrElem renamed to GetLength
327 - ~gdcmHeader() made virtual to pesky warning messages at compile.
328 * src/gdcmElValSet.cxx fixed both GetElValue methods
329 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
330 due to IdoDude was cleaned out.
332 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
334 concentrates on finding the value representation (when it exists).
335 RecupLgr now only finds the element value length, and it avoids
336 returning the unecessary skL (skipped length).
337 Also, offsetCourant was simply removed (with taille_fich) since
338 it was redundant with the File position internals (by using
339 ftell and fseek). This also made skL (see above in RecupLgr) usage
341 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
342 on the libido specificities which are handled through class
344 * Test/implicit_vr.dcm dicom v3 in implicit value representation
347 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
348 * Truckload of changes. Parsing of header is barely functional
349 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
351 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * src/gdcmHeader.cxx many addons of low level methods
354 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
358 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * This corresponds to all the changes decided at the meeting of
360 May 23 2002. Needless to say we are running late...