1 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
3 you debug/warning message just as c++ streams which make them very convinient
4 to use. Once this is stabilize I will change the ostringstrem to be
5 redirected to a file (ofstream).
7 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
8 * Removal of useless and dangerous methods :
9 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
10 GetDocEntryByName, GetEntryByName, GetDictEntryByName
11 * Removal of usless methods :
12 Dict::PrintByName, Dict::GetDictEntryByName
13 * Commenting out of probabely useless methods :
14 Dict::GetDictEntryNames()
15 Dict::GetDictEntryNamesByCategory()
16 DictSet::GetPubDictEntryNames()
17 DictSet::GetPubDictEntryNamesByCategory()
18 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
19 * ENH : Use dicomTS.dic as described in 2004 version
20 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
21 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
22 Add Accessors on VM (Value Multiplicity), and VM related methods
23 * ADD : Add a list of 'Dicom Attribute types', as found in
24 http://medical.nema.org/dicom/2004/04_15PU.PDF
26 * ADD : Add dicomGroupNameAbbreviations.dic
27 should be used to write a method to replace the former
28 Dict::GetDictEntryNamesByCategory()
30 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
32 to read in the file... and only it ! Length is the efective length of the
33 data in the DocEntry structure
35 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
36 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
37 And now use a static function call instead, with a global variable. i
38 This is much closer to the VTK approach. Hopefully should be bulletproof
39 and easier to use...hopefully
41 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
42 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
44 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
47 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
49 ValEntry, BinEntry, SeqEntry creation or replace
51 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
53 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
55 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
56 when specifying the VR
57 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
58 * src/gdcmDocEntry.cxx : amelioration of print
60 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
61 * ADD : Add the method Util::IsCurrentProcessorBigEndian
62 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
63 * ADD Method Document::ComputeGroupLength
64 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
65 in order to allow further VR modification by user
66 * REM : removal of once-called method File::WriteBase
67 integration of its code in formerly one-line method File::Write
69 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
71 replace the different values "??", "Unkn", "Unknown".
72 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
73 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
74 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
75 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
77 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
80 * Set the gdcm::Base class to some Printable classes
82 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * src/gdcmFile.[h|cxx] : add the Print method
84 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
85 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
86 * src/gdcmDocument.h : remove the PrintLevel informations
87 * Example/PrintFile.cxx : use the new gdcm::File::Print
89 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
91 problems when compiling with the python wrapping
93 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
94 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
95 writting in ImplicitVR
97 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
98 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
99 JPEG decompression, especially when dicom frames are split into several
100 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
101 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
103 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/gdcmHeader.cxx : change the initialisation of default header.
105 Now, this header is readable by gdm, e-film, DicomWorks
107 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
109 Rename Decompressed to Raw
110 * Use the API changes in gdcm::File.
111 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
114 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
116 each added entry in the header. Replace the 'Planes' field by the 'Number
119 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
121 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
123 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
125 At this time, this image isn't readable by e-film... waiting JPR help to
128 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
130 DocEntry. Now use methods of the Document !
132 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * Test/ShowDicomSeq.cxx : bug fix
135 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
137 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
138 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
139 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
141 * Test/TestCopyRescaleDicom.cxx : remove unused variable
142 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
143 containing found sequences
145 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
148 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
149 Some fields in BinEntry must be copied to not seg fault when making the :
150 gdcm::File *copy = new gdcm::File( copyH );
151 and tests are now made on good variables
153 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
155 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
157 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
158 * Add vtkGdcmWriter example and test
160 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * Test/TestUtil.cxx : reformat the source code
162 * vtk/vtkGdcmReader.cxx : remove and change prints
163 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
165 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
166 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
168 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
170 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
172 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
174 by an eof to prevent all bad read of the file... and in this case, the
177 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * Example/Volume2Dicom.cxx : comment unused variables
179 * Test/PrintDicomDir.cxx : comment unused variables
180 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
181 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
182 method that is redondant with AddEntry.
183 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
186 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * Bug fix due my last commit (compilation under Windows).
188 * Example/Volume2Dicom : bug fix in the file and reformatting source code
189 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
191 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
193 - Remove printf / sprintf
194 - include iostream AFTER gdcm so we don't get warnings
195 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
197 - Also remove tons of include from header files, hopefully this should
198 speeup the compilation time, since it was becoming a dog slow.
199 - Remove gdcm.h as it include way too many files and slow down compilation
200 (plus it is not up to date)
201 - remove 'using namespace std' this is BAD !
203 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * Remove memory leaks on the DicomDir
205 * Remove some useless datas in DicomDirObject
206 * Add usefull methods in SQItem, to be complient withe the ElementSet
208 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
211 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
213 future, with convertion)
214 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
215 and ImageDataSize values. Remove the method to get the PixelReadConverter
216 from the output of the class
218 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
221 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
223 and vtkErrorMacro use.
224 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
226 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
229 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
230 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
231 The string leaves only in the fonction. So when we make a .c_str(), we
232 get the pointeur on the first element, element that will be destroyed
233 immediately after thee instruction.
234 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
235 file has been opened : the test must be made on the content of the
236 pointer and not directly on the pointer !
239 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
241 the python part recompiles
243 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
245 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
246 X session is killed (for my computer... it seems to not be identic on
249 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
250 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
251 avoid problems (otherwise, the difference test between the visible image
252 and the reference is incorrect. If the reference is greater than the
253 screen resolution, it's produce errors).
254 Can be used for only one image. Can be used with a visible flag.
255 * vtk/vtkGdcmReader.cxx : remove commented codes.
256 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
257 under windows at compilation
258 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
260 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
262 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
264 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
265 tests on the image size X, Y, Z
267 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
268 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
269 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
270 between the class name and the file name
272 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
273 * src/ : fix compilation warnings for the Write method (2 different
274 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
275 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
276 variable... create a static method in gdcm::Document to access to
277 this variable content.
279 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
281 file, to be accessed by other files (like gdcmFile). Remove commented
282 code. Move the change of the header to the gdcmFile, using the
284 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
285 To be sure of that (and simplify calls), the Write of the header now
286 gets a file name and not a file pointer (std::ifstream).
287 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
288 DocEntryArchive. Remove all open of the written file
290 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
293 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
295 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
297 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
298 some corresponding methods. Write correctly the file and check before
300 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
301 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
302 is now on RGB datas (as before my last commit
303 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
305 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
306 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
307 Add a print information of the type of the entry
308 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
309 It was in the gdcmFile, and all write have been regrouped
310 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
311 Write correctly all dicom files (in decompressed mode only at this time)
312 * Test/ : test on files are now made using Raw datas and not color datas if
314 * Example/PrintFile.cxx : add more printings
316 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * Amelioration of code, remove some code copy. For the loading of
318 BinEntry (in gdcmDocument), add the test to verify if the file is already
321 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
322 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
323 remove a DocEntry in the header (push an empty DocEntry)
324 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
325 lines. Bug fix in the initialization of the PixelConvert and the
327 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
328 use in TestCopyDicom (now this test can run under windows... but fails)
329 * Test/TestCopyDicom.cxx : amelioration of the test :
330 - test the pixels written
331 - add test points to quickly find where is the error
332 - can set a file name input and output in arguments
333 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
334 amelioration of the test output
336 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
337 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
338 all replaced DocEntry's
339 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
340 Now, each needed DocEntry to modify is duplicated, modified and inserted
341 to the header using DocEntryArchive. Thus, after save, we can restore the
342 header initial state.
344 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
347 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
348 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
349 correct to copy it. The DictEntry is specified at the DocEntry creation,
350 then, it musn't change in the time.
351 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
352 header correctly. At this time, the change is only made for the first
353 level of the Document. In the future, it might consider sequences.
354 The change is made by replacing a DocEntry by an other that is created
355 outside the class. The old value is kept. When we restore the header
356 status, the added DocEntry is deleted and replaced by the old value.
357 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
358 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
359 set the write type to explicit VR, implicit VR or ACR. Add methods to set
360 the write mode to native, decompressed or RGB (but not used at this time)
362 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
364 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
366 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
368 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
370 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
371 set because already copied when copying the BinEntry's of the header
372 * Test/TestAllReadCompareDicom.cxx : remove warnings
374 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
375 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
376 Two problems appear when doing it :
377 - with the gdcmFile : when the GetImageData method is called, the pixels
378 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
379 datas (pixels). And each structure destruct the datas when it's
380 destructed. So we have two destructions for the same datas. To solve it,
381 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
382 datas or not. If it doesn't own datas, then they will not destroyed by
384 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
385 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
386 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
387 create a double destruction of the same DocEntry's. So, to solve it,
388 the TagHT is simply cleared and the DicomDir* elements are destroyed.
389 * TODO : add an entry concerning memory leaks in the DicomDir
391 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
393 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
396 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
397 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
398 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
399 after it have been deleted
401 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
402 * FIX: src/* fix the doxygen warnings.
403 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
404 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
405 was erroneously defined with a size of 15 instead of 16. [many thanks
406 to Jean Michel Rouet for pointing out this bug].
408 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
409 1. Finish merging JMR patch for writting DICOM from scratch
410 2. Fix -hopefully- bug with MONOCHROME and space vs null character
411 3. Use const ref when possible
412 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
413 5. A few more comments
414 6. CreateUniqueUID can now be called without parameter"
416 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
417 * ENH: Slightly bigger patch:
418 1. Getting toward full integration of JMR patch for writting dicom from scratch
419 2. Update Test to test part of this patch: CreateUniqueUID
420 3. File was not close properly in gdcmDict
421 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
422 5. Use of const ref instead of copy (speed issue)
423 6. Remove temporary (duplicate) string in TranslateToKey
424 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
425 8. Do not repeat virtual in subclasses
426 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
428 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
429 * Apply first patch toward better string comparison when dealing with broken
430 DICOM files. Essentially the string could be padded with a space instead
431 of a null character as defined by standard
433 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
434 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
435 because never used... and in the same time, that's remove some memory leaks
437 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
438 * src/gdcmFile.cxx : now delete the PixelConvert instance.
439 * In examples and tests : change the type of image data variables from void*
440 to uint8_t*. Remmove all delete on image data variables
442 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
444 Verify the file pointer value before open the file, and if it's not null,
445 a verbose message is generated.
446 Close correctly the file when the file isn't considered dicom-like. The
447 correctly close is a call to CloseFile.
448 When closing the file pointer, test if its not null to close the file.
449 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
450 file. For an uncompressed image, the copied datas correspond in the least
451 case to the image size (calculated) or the image size specified in the
452 header. A verbose is generated if these two size mismatch
454 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
456 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
457 break under windows (with msvc6 compilation).
459 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
461 compiling with MSVC6)
463 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
464 * Bugs fix for the Windows build with VC6
465 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
466 needed (only for projects required VTK). If the VTK is included in all
467 projects, there is conflicts with the jpeg lib of vtk when compiling the
468 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
469 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
470 when compiling the gdcm_wrap.cxx file (created by the compilation of the
472 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
473 (like it's already made for the cout use). Otherwise, conflict with the
476 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
479 - comments on the DicomDir::Method related usage added.
480 - now that we use the namespace gdcm, a lot of internal classes do
481 NOT need to be wrapped anymore.
482 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
483 DicomDir::Method) new example added.
485 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
486 * Improve string manipulation. I now inforce the notion of 'DicomString'
487 A DicomString can contain as many \0 as they want
488 and it is *always* of even length.
489 We only support odd length for very rare case.
490 And in the near future this should be removed.
492 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
493 * /binary_write/ gdcm source. Now even on big endian we are writting
494 little endian. This should -heopfully- fix some tests
496 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
497 * Now the dictionary is compiled into gdcm lib. This is a default
498 behavior, thus any dic file specified is picked before failback to
499 the one comiled into lib
501 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
502 * Change internals for gdcmDict. Don't use any 'new' any more.
503 This should definitely solve any leak problem, and we should be
504 as fast as before, as long as don't modify too much the dictionary.
506 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
507 * STYLE: ivars should start with a capital letter.
508 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
509 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
511 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
513 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
514 new 2004 dictionaries added (thanks to JPR).
515 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
516 * CLEANUP_ROUND (15) for gdcmPixelConvert
517 - RLEFrame::NumberFragments is now of type unsigned int
518 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
519 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
522 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
523 * Initial work in gathering all transfer syntax accessors. clearly
524 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
525 ivars, but only one transfersyntax (class) ivar with equivalent method on
528 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
529 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
530 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
531 discussed (plus I didn't like having a 2000 lines patch not commited)
533 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
534 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
535 * CLEANUP_ROUND (14) for gdcmPixelConvert
536 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
537 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
538 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
540 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
541 anymore and hence avoids storing a copy of PixelConvert::Decompressed
542 into File::Pixel_Data.
544 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
545 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
546 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
547 * CLEANUP_ROUND (13) for gdcmPixelConvert
548 Substituted File::ParsePixelData() with PixelConvert::Print() new
550 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
551 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
552 method to those classes.
553 - src/gdcmFile.[cxx|h]:
554 -- Added a ::Print() method.
555 -- PixelConverter is now a reference instead of a member.
556 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
557 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
559 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
561 collaboration diagram and inheritance diagram should be generated with
563 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
564 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
565 pointlessly wrapped (see
566 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
567 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
568 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
569 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
570 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
571 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
572 -- File::Initialise: PixelConverter setup moved away to
573 PixelConverter::GrabInformationsFromHeader()
574 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
575 interpretation moved away to PixelConverter::BuildRGBImage()
577 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
578 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
579 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
581 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
583 displayed on Win32 when a brutal abort() occurs (because of uncatched
584 exception). See TODO new entry of this commit for more on this.
585 * TODO added new entry.
586 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
587 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
588 - HandleColor is no longer called from gdcmFile.cxx
589 - gdcmPixelConvert.cxx clean up on method arguments and internal
590 variable names for semantical coherence.
592 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
593 * Finished lossless transition, not only do we now read all lossless jpeg
594 images, without the need of the Cornwell lib, but we do read them properly now
595 * To reduce code (well to avoid code duplication), I defined a common place
596 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
597 redefine symbols. This is not prefect but this the best solution I found for a
598 compilation time jpeg option.
600 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
601 * Update jpeg ijg lib to support lossless jpeg implementation
602 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
604 * Also added a special copyright for dcmtk since we use their bugfixes.
607 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
608 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
609 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
610 matters, as stated in warning note at begining of %include section).
611 * src/gdcmDicomDir*.[cxx|h]: coding style
612 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
613 * src/gdcmJpeg8.cxx: doxygen fix.
614 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
615 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
616 from File:: to PixelConvert::.
618 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
619 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
620 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
621 - more code moved away from File:: to PixelConvert::
622 - fat setup of PixelConverter set in place in File::Initialise.
624 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
625 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
626 namespace at the file system level. So now you should convert your examples
628 gdcmHeader -> gdcm::Header
629 It would be nice if people keep in mind to no open the namespace, since it
630 allows compilation on broken plateform which were defining common symbol in
631 the standart namespace (like LP, Unknown ...)
633 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
635 The JPEG fragments are now parsed at the same stage than the RLE
636 information. All code related to JPEG is now in gdcmPixelConvert:
637 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
638 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
639 export a gdcmFile:: method. Those are simply global functions
640 (for the time being this is better than having them attach to
641 either gdcmFile:: or gdcmPixelConvert::).
642 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
643 and stores the result in a gdcmJPEGFragmentsInfo.
644 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
645 code (among other stuff) moved away from gdcmFile:; to
648 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
649 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
650 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
651 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
652 clean up of RLE related code.
653 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
654 - src/gdcmRLE.cxx removed
655 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
656 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
657 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
658 * CLEANUP_ROUND (9) for gdcmPixelConvert
659 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
660 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
661 away from gdcmFile:: to gdcmPixelConvert::.
663 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
664 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
665 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
666 This is because Parse7Fe0 used to parse the pixels to compute the
667 length. This task was passed over to FindDocEntryLengthOB() a long
668 time ago, EXCEPT I had forgotten the OW case...
669 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
670 we just recylce the code for parsing RLE fragments and computing
672 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
673 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
674 with the retired Parse7Fe0().
675 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
676 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
678 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
680 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
681 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
682 - src/CMakeLists.txt: alphabetic order reodering + new entries.
683 * CLEANUP_ROUND (4) for gdcmPixelConvert
684 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
685 to return an unused length.
687 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
688 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
689 this should be cleanner from the plane view. The iostream are erally a pain
690 to use to do simple stuff.
692 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
693 * Redo the compilation of the ijg jpeg library. Now only one source is
694 necesseray. No need to rename file by hand what so ever. CMake handle the
695 copying of the file within different directory, configure header file to
696 modify some symbol. The only addition made to ijg wasd a mangle table so
697 that symbol are different wether we are within 8bits or 12bits.
699 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
700 * Added documentation of vtkgdcmReader on Website:
701 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
702 with it's binary name).
703 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
704 the Website to be more complete.
705 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
706 doxygenated documentation.
707 - Doc/DoxyVtkGdcmReaderExamples.txt added
708 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
709 DoxyVtkGdmReaderExamples.html )
710 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
711 * CLEANUP_ROUND (3) for gdcmPixelConvert
712 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
714 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
715 * CLEANUP_ROUND (2) for gdcmPixelConvert
716 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
718 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
719 * CLEANUP_ROUND for gdcmPixelConvert:
720 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
721 - src/gdcmPixelStuff[h|cxx] removed
722 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
723 - src/CMakeLists.txt changed accordingly
725 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
726 gdcmVersion.py moved to newly created ATTIC related
727 gdcmPython/SetupOldies/ directory.
728 * Autotools clean up:
729 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
730 - autogen.sh configure.in acinclude.m4 python.m4 removed
732 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
733 * src/*.cxx *.h Reference to License.htm fixed to License.html.
734 * Doc/CMakeLists.txt, doxygen.config.in: fix.
735 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
737 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
738 * TODO updated with Mathieu suggestions. I proposed a template for
739 describing TODO entries and used it for new entries.
740 * Added Doc/Website/CodingStyle.html, Developpers.html,
741 DeveloppersPython.html, GdcmDataCvs.html and
742 DownloadVersion0_1.html, DownloadVersion0_3.html.
743 * Some Doc/*.txt Doxygen files (which do not really concern the
744 documentation itself, but the website) moved to html and
745 placed in directory Doc/Website:
746 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
747 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
748 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
749 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
750 * CMakeLists.txt changed accordingly.
751 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
752 DeveloppersPython.html
753 * INSTALL nows refers to Doc/Website/Installation.html
755 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * Added Doc/Website directory, that contains a first raw version
759 2004-09-23 Jean-Pierre Roux
760 * FIX In order not to be poluted any longer by casting problems,
761 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
762 we can now delete[] it safely
763 * VoidArea is now called BinArea (less confusing name),
764 and all the methods called ...VoidArea... are now ... BinArea...
765 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
767 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
768 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
769 clear) TagHT, which is an inherited member of gdcmElementSet. It is
770 up to the destructor of gdcmElementSet to clean up TagHt and it's
773 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * Test/CMakeLists.txt: update to follow gdcmData renamings.
775 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
777 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * ENH: added some utility method that builds a flat dictionnary
779 holding all the Dicom entries contained in the recursive structure
780 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
782 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
783 BuildFlatHashTable() that build a flat dictionary.
784 - src/gdcmElementSet.h: added a new private GetTag() accessor.
785 gdcmDocument is now a friend of gdcmElementSet.
786 - src/gdcmElementSet.cxx: clean up.
787 - Example/FlatHashTablePrint.cxx added.
788 - Example/CmakeLists.txt changed accordingly
790 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
792 moved away from gdcmDocEntrySet (since this class is an abstract class
793 acting like an interface). SQDepthLevel and BaseTagKey are now
795 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
796 and associated accessors. Doxygenation of the class.
797 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
799 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
800 Use SQDepthLevel accessor instead. ::Print() adapted.
801 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
802 - src/gdcmDocument.cxx changed accordingly.
804 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
806 - The following is the doxygen comment of the typedef declaration
807 of gdcmagKey in src/gdcmCommon.h:
808 gdcmTagKey is made to old an "universal" (as in URL, Universal
809 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
810 A dicom tag allways has a group and an element, but a set of tags
811 embeded in various (optionally nested) sequences and sharing
812 the same group and element all share the same (group, element)
813 "identifier". Hence the (group, element) cannot be used as an
814 identifier (in gdcm we shall refer to a "TagKey") of a tag.
815 In order to construct a proper tag identifier (i.e. a key) we
816 consider the following definition of a TagKey:
817 - let Group, Element be the string representation of the
818 group and element dicom tag members,
819 - let ItemNumber be the string representation of the integer
820 index of the considered item number of a sequence,
821 Let the key of a tag embeded in a sequence, noted SeqTag, be
823 /ItemNumber#Group|Element
824 where "/", "#" and "|" are characters acting as separators.
825 Then the general form of a gdcmTagKey is given by:
826 Group|Element<SeqTag>
827 where <SeqTag> means NO or many instances of SeqTag.
828 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
831 but the gdcmTagKey of a tag "embeded" is the first item of
832 a sequence, itself nested in the third item of a sequence is the
834 0004|1220/2#0008|0082/0#0008|0090
835 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
836 order to hold the new sequence compatible key. Previously, the
837 GetKey() method would look in the underlying gdcmDictEntry.
838 - src/gdcmDocEntry.cxx:
839 -- constructor now copies the underlying DictEntry key, in the local
841 -- ::Print: displays the member Key, instead of the (group, element).
842 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
843 - src/gdcmDocEntrySet.h:xi
844 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
845 -- now has a new BaseTagKey member.
847 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
848 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
850 This poses the problem with the semantics of the following lines
851 LoadEntryVoidArea(0x0028,0x1201); // R LUT
852 LoadEntryVoidArea(0x0028,0x1202); // G LUT
853 LoadEntryVoidArea(0x0028,0x1203); // B LUT
854 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
855 to the long FIXME note for what the problem is. Nevertheless in
856 order to get things working the dicom dictionary was altered !
857 Please fix things urgently...
858 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
859 information), see above note on moving the member VoidArea. Nevertheless
860 the following entries previously correctly set as US are now inproperly
862 0028 1201 OW IMG Red Palette Color Lookup Table Data
863 0028 1202 OW IMG Green Palette Color Lookup Table Data
864 0028 1203 OW IMG Blue Palette Color Lookup Table Data
865 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
866 of gdcmDocEntry moved to gdcmSeqEntry.
867 * src/gdcmSeqEntry.cxx: STYLE.
869 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * Test/TestAllEntryVerify.cxx minor fix and added comments.
872 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
873 * gdcmPython/testSuite.py: all the test suite in python is now moved
874 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
875 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
876 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
878 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
880 to avoid inclusion recursion until STL is reached.
881 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
882 mecanism. errno.h is not included in gdcm anymore.
883 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
884 (gdcmFormatError now inherits from gdcmFormatUnexpected).
886 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
887 gdcmData/TestAllEntryVerifyReference.txt
888 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
889 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
890 exception_on_error parameter.
891 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
892 - vtk/vtkGdcmReader.cxx changed accordingly,
893 - Example/*.cxx and Test/*.cxx changed accordingly.
895 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
897 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
898 enable_sequences removed from gdcmHeader constructor and dependencies.
899 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
900 * gdcmPython/demo/PrintHeader.py: dummy fix.
901 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
902 skip_shadow removed from gdcmHeader constructor and dependencies.
903 * Example/*.cxx and Test/*.cxx changed accordingly.
905 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
907 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
909 2004-07-21 Jean-Pierre Roux
910 * FIX Now, Parsing and Printing a DICOMDIR do work!
911 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
913 2004-07-20 Jean-Pierre Roux
914 * FIX Some brain damaged headers have Zero-Lenght fields
915 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
917 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
918 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
919 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
920 variable (instance of gdcmDebug) by a definition macro, and the instance
921 is now in static in the gdcmDebug class
922 * src/gdcmSQItem.h : (FIXME) remove an undefined method
923 * Test/PrintAllDocument.cxx : bug fix in the result of the test
925 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
926 * WARNING: ctest now depends more tightly on gdcmData. You should
927 check out gdcmData properly for things to run smoothly...
928 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
929 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
930 we need the pixels not be loaded in order to use the ValEntry
931 that displays position and size).
932 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
933 This is a C++ based equivalent of gdcmPython/testSuite.py that should
934 be deprecated. If you have any doubts about the advantages of a
935 modern scripting language (read Python) versus grass root C++ (i.e.
936 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
937 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
938 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
939 Anyhow, consider documenting the gdcmData images in
940 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
942 * Test/CMakeLists.txt:
943 - now uses TestAllEntryVerify.cxx
944 - specific comments on oldACR00001.ima (now renamed in gdcmData
945 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
946 gdcmData/TestAllEntryVerifyReference.txt
949 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
950 * src/*.[h|cxx] : typedef clean up
951 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
952 - TagKey renamed to gdcmTagKey (for external usage)
953 - VRKey renamed to gdcmVRKey (for external usage)
954 - removal of typedef duplication.
955 - Removed all unecessary inline keyword from class inline definitions.
956 - Some method|function(void) declarations replaced with method|function().
957 * src/jpeg/libijg12/jdhuff12.c:
958 - printf polluting ctest removed.
959 - TAB removal for comminting
961 - TestAllReadCompareDicom.cxx: added a test that compares all the
962 images in gdcmDataImages.h with corresponding images in
963 gdcmData/BaselineDicom/. When baseline images are not present
964 this test creates them.
965 Note: we need to validate each reference image, but before that
966 I'd like to rename them with a more explicit name...
967 - CMakeLists.txt: changed accordingly.
968 * Example/*.cxx: examples now only include gdcm.h (as opposed to
969 including each header needed).
971 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * Test/*.cxx and Example/*.cxx: moved some examples away from the
973 test suite to the Example directory. Are concerned:
978 - TestWriteSimple.cxx
979 * Test/CMakeLists.txt: added some comments on reasons for black listing
980 image gdcmData/oldACR00001.ima
982 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * Test/CmakeList.txt: removed the following from black list (to be coherent
984 with removal from gdcmData):
985 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
986 - gdcm-MR-PHILIPS-16.dcm
988 Added the following because after last cvs update, they cause
989 ctest -R TestReadWriteReadCompare
991 - gdcm-MR-SIEMENS-16-1.acr
993 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
994 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
995 new comments in this file) we temporarily (sigh) move to a weaker
997 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
998 we don't need to black list the following images anymore:
999 - 8BitsUncompressedColor.dcm
1001 - US-PAL-8-10x-echo.dcm
1002 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1003 fixes and the beautified code ;-)
1004 This fixes the bug introduced in version 1.42 (when beautifying)
1005 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1006 Note: ctest was blind to this bug (this means we need to still
1007 improve the test suite). The bug could be detected by using
1008 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1010 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1011 and by displaying the (garbage) produced file temp.XDCM...
1013 2004-06-29 Jean-Pierre Roux
1014 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1015 - replace by uggly but working old code :-(
1016 A lot of things should be OK again.
1017 It's really urgent to have a test suite that *tests*,
1018 to prevent Frog's beautifying sessions to break all the stuff
1019 (twice, withing a fortnigh ...)
1021 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1022 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1023 redundancy) to added Test/TestReadWriteReadCompare.cxx
1024 * Test/CmakeList.txt: because the compare test of
1025 Test/TestReadWriteReadCompare.cxx fails, the following images are
1026 black listed: - 8BitsUncompressedColor.dcm
1028 - US-PAL-8-10x-echo.dcm
1029 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1030 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1031 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1032 and ad-hoc kludge. This kludge is now removed, and on encountering
1033 such an image (OB field brain damaged) we set errno. Then in
1034 ::FindDocLength() we "fix" the length as being ALL what remains
1035 in the file (until EOF). We then proceed, hoping for the best...
1036 This fixes a SegFault in ShowDicom when trying to write such an
1038 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1039 (because TestWriteRead breaks on it, after a non conformal commit?).
1040 ctest now runs properly, except for MakeDicomDir (which was allways
1041 broken) and the Python related stuff (still not fixed).
1043 2004-06-24 Jean-Pierre Roux
1044 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1045 FIX : Test/TestReadWrite now iterates on all the file names
1046 (instead of infinite loop)
1047 ENH : Test/TestWriteRead now iterates on all the file names
1049 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1050 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1052 2004-06-24 Jean-Pierre Roux
1053 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1054 when SamplesPerPixel =3
1055 - now Write is no longer confused by
1056 'BitsAllocated = 12" and 'BitsStored=12"
1057 - "UN" value representation Elements are now written correctly
1058 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1059 ENH : - now gdcmHeader has its own Write methods
1060 (in order to split the job that has not to be done
1063 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1065 loop on the same image until memory went out.
1066 Note: this means we still have gobs of memory loss in PrintDocument
1067 * src/gdcmDocument.cxx: fixes problem on parsing on file
1068 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1070 2004-06-24 Jean-Pierre Roux
1071 FIX : Write - All the Sequences and Sequence Item are now written
1072 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1073 is added a the end, when necessary.
1074 - A lot of brain-damaged images, that were read correctly are
1075 now written correctly
1076 - length compatible BinEntry are now loaded correctly
1077 (even for odd groups)
1078 Note : only Explicit Value Representation was checked.
1079 (question : is implicit VR really necessary for gdcm ?)
1081 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1082 * DEVELOPPER: added a proposition of coding style.
1083 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1086 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1087 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1088 Use the gdcmDocEntry::Print() and Write() instead.
1089 * src/gdcmDocument.cxx: bug fix.
1091 2004-06-22 Jean-Pierre Roux
1092 FIX : gdcmDocument.cxx
1093 - Now we do recognize the JpegLossLess format (there was a misstyping in
1094 code 'beautyfication' :-(
1095 - Now we automaticaticaly load the Luts, if any
1097 2004-06-22 Jean-Pierre Roux
1098 In order : to write Sequences, whatever their imbrication level,
1099 : to allow user to create his own Sequences
1100 a lot of modif where necessary (adding, moving, or virtualising methods)
1102 WARNING : save your own sources *before* cvs up !
1105 ADD virtual void Write(FILE *fp, FileType filetype);
1108 ADD virtual void Write(FILE *fp, FileType filetype);
1109 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1112 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1113 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1114 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1115 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1116 ADD std::string GetEntryByName(TagName name);
1117 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1119 std::string vr = "unkn",
1120 std::string fourth = "unkn",
1121 std::string name = "unkn");
1122 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1123 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1124 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1125 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1126 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1127 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1128 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1129 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1132 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1133 ADD virtual std::string GetEntryByName (TagName tagName);
1134 ADD virtual std::string GetEntryVRByName (TagName tagName);
1135 REM virtual bool Write(FILE *, FileType);
1136 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1137 FILE *_fp, FileType type);
1138 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1139 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1140 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1141 REM virtual std::string GetEntryByName (std::string tagName);
1142 REM virtual std::string GetEntryVRByName (std::string tagName);
1143 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1144 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1145 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1147 std::string vr = "unkn",
1148 std::string fourth = "unkn",
1149 std::string name = "unkn");
1150 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1151 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1152 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1153 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1156 ADD virtual void Write(FILE *fp, FileType filetype);
1159 ADD virtual void Write(FILE *fp,FileType filetype);
1162 ADD virtual void Write(FILE *fp, FileType filetype);
1163 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1164 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1165 REM std::string GetEntryByName(TagName name);
1168 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1170 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1171 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1172 The default constructor invoked by the line
1173 gdcmHeader *f1 = new gdcmHeader( header );
1174 was gdcmHeader::gdcmHeader(bool) instead of the expected
1175 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1176 Hence the parsing wasn't executed... See also below.
1177 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1178 as explicit constructor didn't do the trick to fix the above problem.
1179 Could anyone explain why ?
1180 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1181 properly calls gdcmValEntry::Print() (that was weed out from
1182 code related to gdcmBinEntry).
1184 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1185 * In order to fix memory leaks:
1186 - Test/TestWriteSimple.cxx: added cleaning of free store through
1188 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1189 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1190 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1191 (through the call to ::AddDicomDirMeta()) or the destructor
1192 would crash when deleting uninitialized ::metaElems].
1193 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1194 - src/gdcmDocument.cxx:
1195 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1196 from dynamic stores.
1197 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1198 was causing memory leaks.
1199 - src/gdcmSQItem.cxx:
1200 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1201 cleanly handled with polymophism: sorry but my milage is low).
1202 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1203 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1204 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1205 This avoids SegFaulting.
1206 - src/gdcmSQItem.h: coding style.
1208 - Test/TestWriteSimple still severely sucks. The output image content
1209 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1210 damaged when displayed with vtkgdcmViewer.
1211 - on memory leaks: TestWriteSimple leaks really less (see entry
1212 of 2004-06-18 in Changelog file for the call to valgrind).
1213 - on segfaults: ctest now passes all the tests but one (no more
1215 * Erroneous leading white fix:
1216 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1217 white[s] (as opposed to from >> xxx, that removes it [them].
1218 - src/gdcmTS.cxx: ditto.
1219 - gdcmPython/testSuite.py: dirty related kludge removed.
1220 * src/*: remaining references to gdcmParser removed.
1221 * src/*[cxx|h]: added copy[way]left header.
1224 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1225 * In order to fix writing of dicom files:
1226 - Test/TestWriteSimple.cxx: a simpler example of writing.
1227 - Test/CMakeLists.txt changed accordingly.
1228 - src/gdcmDocument.cxx:
1229 -- The destructor now recursilvely removes potential sequences.
1230 -- Bug fix in ::IsJPEG2000()
1231 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1232 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1234 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1235 to only declared) and build on top of
1236 ::GetDocEntryByNumber(guint16, guint16).
1237 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1238 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1239 for usage in destructor and treatement of promotion in
1240 ::ReplaceOrCreateByNumber().
1241 - src/gdcmSQItem.cxx: destructor should better handle his job.
1242 Test/TestWriteSimple now runs (or at least it DOES something).
1243 * We can now start hutting memory links. A good starting point is:
1244 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1245 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1246 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1248 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1249 * Valgrind note: after Mathieu Malaterre teached me how to read
1250 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1252 Using gcc, you can force the STL to use malloc and to free memory as
1253 soon as possible by globally disabling memory caching.
1254 With 3.2.2 and later, you should export the environment variable
1255 GLIBCPP_FORCE_NEW before running your program.
1256 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1257 simply vanish (it is still not clear to me, whether this means that
1258 STL std::string leaks or if valgrind believes it leaks...).
1259 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1260 running bin/gdcmTests makeDicomDir):
1261 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1262 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1264 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1265 SegFaulting (I drowned in DicomDir related code when trying to
1266 understand why the list is empty...).
1267 * src/gdcmDocument.h: first BSD license header try.
1268 * Doc/License.txt added.
1270 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1271 * src/gdcmDocument.[h|cxx]:
1272 - Clean up of the Transfer related predicates. They are now all based
1273 on new method isGivenTransferSyntax, that (should) handle properly
1274 the padding problem.
1275 - general clean up, simplification, and coding style.
1276 - Specific clean up of Parse7FE0() (umproperly named actually).
1277 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1279 2004-06-14 Jean-Pierre Roux
1281 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1282 - fix the display of SQItem ordinal number
1283 - add the GetSQItemByOrdinalNumber method
1284 - remove some useless never written private methods
1286 2004-06-14 Jean-Pierre Roux
1288 - adding a constructor taking a gdcmDocEntry as an input param
1289 - ReplaceOrCreateByNumber now returns :
1290 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1291 a gdcmValEntry * if a string value is passed as a param
1293 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1294 according to the param type (no longer sets a gdcmDocEntry)
1295 - GetValEntryByNumber, GetBinEntryByNumber added
1296 - NewValEntryByNumber and NewBinEntryByNumber added
1298 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1300 - GetSQItemNumber and SetSQItemNumber added, to provide
1301 a (relative) Item identier inside a given Sequence
1302 \warning : some pb remaining around this number
1304 - AddEntry now takes the Item Number as a param
1306 - adding a constructor taking a gdcmDocEntry as an input param
1308 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1309 * Memory leak hunt with the following command:
1310 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1311 --show-reachable=yes gdcmTests PrintDocument
1312 It looks like many (all?) leaks are due to the STL (or a bad usage
1313 of the STL. The lines producing the leaks now have a comment with
1314 a "MEMORY LEAK" tag: you can retrieve them with
1315 grep "MEMORY LEAK" src/*
1316 Here are two typical examples which I can't help fixing:
1321 char * test = "babo";
1322 name = test; //// <--- valgrind detects 960 bytes lost in
1323 //// call to std::string::operator=(char const*)
1324 name.clear(); //// Doesn't help !
1332 std::cout << "Type a bunch of characters followed by RETURN: ";
1333 getline(std::cin, line); //// <--- valgrind dectects a loss
1334 //// of 1320 bytes in call to
1335 /// std::basic_istream<>& std::getline<>
1341 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1342 * src/gdcmHeader.[cxx|h]:
1343 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1344 and related, moved away to gdcmDocument.
1345 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1346 the corresponding protected accessors of inherited class
1347 gdcmDocument, removed ! As a consequence gdcmFile had to be
1348 declared friend of class gdcmDocument (see below).
1349 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1350 - Clean up of undefined or unused methods.
1351 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1352 account the changes to gdcmHeader.h).
1353 * src/gdcmDocument.h:
1354 - gdcmFile is now a friend class (in order to take into account the
1355 changes to gdcmHeader.h).
1356 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1357 (see changes to gdcmHeader.h).
1358 - Accessors (reading on the form GetEntry*) are now public.
1359 - Clean up of undefined or unused methods.
1360 * src/gdcmDocument.cxx:
1361 - adaptation to changes to gdcmDocument.h
1362 - ::OpenFile now writes a verbose message when file cannot be opened.
1363 - some std::string properly set to VRKey
1364 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1365 references to gdcmDocument.
1366 * Test/TestFindTags.cxx: changed accordingly to above changes.
1367 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1368 cvs repository gdcmData.
1370 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1371 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1372 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1373 conflicts with gdcmValEntry::voidArea.
1374 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1375 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1376 Value representation between StringRepresentable and BinaryRepresentable.
1377 * src/gdcmDocument.cxx:
1378 - method ParseDES: proper indentation restored and usage of
1379 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1380 - method LoadDocEntry: the fingerprint left in the SetValue() of
1381 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1382 removed. Reverting to previous code segment with the proper
1383 dynamic_cast< gdcmValEntry* >.
1384 Note: this was (partially) breaking the python test suite
1385 (gdcmPython/testSuite.py) that made usage of the above
1386 fingerprint to check presence of "Pixel Data".
1387 * src/gdcmDocEntry.h: coding style.
1388 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1389 now taken into account.
1390 * gdcmPython/gdcm.i: adaptation to the new internal representation
1391 of gdcm (exit gdcmParser, hello gdcmDocument).
1392 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1394 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1395 anymore, but instead prints the loaded Python dictionary.
1396 * .... alas, the python testSuite is still broken.
1398 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1399 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1401 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1402 * src/gdcmUtil.h : export methods
1404 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1405 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1407 * Initial addition of automatic python testing
1408 * Initial addition of automatic image comparison
1410 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1411 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1412 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1414 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1415 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1416 * Test/ShowDicom.cxx : bug fix for msvc compilation
1417 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1419 2004-05-04 Jean-Pierre Roux
1420 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1421 new concepts (and new classes) :
1422 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1423 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1424 - Sequence Doc Entries (gdcmSeqEntries)
1425 a Sequence is composed of Items.
1426 Each item is a set of Doc Entries (this is recursive)
1427 The non uniqueness of the 'Dicom tag' is due to this recursivity
1428 (never taken into account)
1429 Our unability to add a new 'entry' in the header
1430 at the proper location (neither in the H-Table (map or multimap),
1431 nor in the Chained List is also due to this recursivity.
1432 Don't try, right now, to use/modify/compile these new sources :
1433 nothing is finished.
1434 We just commit all the stuff, 'as is', in order not to loose it.
1436 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1437 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1439 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1440 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1441 file prefix (SetFilePrefix)
1443 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1444 * Add a new test: ShowDicom, for now this is just the c++ version of
1445 checkRead.sh, later it will be able to compare the image read against a
1447 * Replace the DEBUG on the stack with a global entry in cmake interface:
1448 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1450 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1451 * Add an example subdir, with a real example on how to read + write a
1454 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1455 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1456 * Doc/CMakeLists.txt: the main page is now properly differentiated
1457 between the developper and user version.
1458 * Doc/doxygen.config.in: dropped search related obsolete flags
1459 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1461 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1462 * DEVELOPPER: added some helpfull comments for compile/test/install
1465 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1466 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1467 src directory, now generated in the build dir.
1468 2. Tests as mentionned smarter
1470 4. Add a new method in gdcmDict that return the PubDict by name
1471 this is interesting for 3rd party lib like ITK,
1472 where we could set the institution name / patient name...
1474 * ENH: 1. Now the test suite is working for real
1475 2. All binaries are now output in the gdcm-bin directory
1476 (this was not true before)
1478 2004-04-28 Jean-Pierre Roux
1479 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1480 SeQuence indented printing of Dicom Header.
1481 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1482 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1483 Computation of SQDepthLevel is now part of gdcmHeader constructor
1484 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1485 tree-like structure of a Dicom Header.
1486 * FIX Test code cleaning
1488 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1489 * ENH: Adding automatic testing
1490 1. Need a DartConfig.cmake to submit to public
1491 2. Add a test driver gdcmTest.cxx
1492 3. gdcmTestMain, an helper for the main test driver gdcmTest
1493 4. Files in Test don't have a main anymore, this becomes interesting
1494 when we add more and more tests, thus dsw don't have to load
1496 * ENH: Adding a GDCM_DATA_ROOT for testing
1497 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1498 one file instead of seven + some small cleanup
1500 2004-04-22 Jean-Pierre Roux
1501 * ENH Minor changes to the Print() methods.
1502 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1503 Header printing. Example given with :
1504 > PrintHeader fileName 2 new
1505 (SQ based tree-like structure still to be done for the Header ...)
1507 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1508 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1509 1. I have added some unsigned where needed
1510 2. Some function parameter not used -> (void)
1511 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1512 4. g++ don't like character '\' in comment
1513 5. #define jpeg_create_decompress jCreaDecompress
1514 this really need to be fixed
1515 6. virtualize destructor of gdcmObject ... leakage
1516 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1517 this also really need to be fixed
1518 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1519 remove compression file
1520 (as we only do decompression, right ?)
1521 * ENH: Change malloc/calloc/free with c++ equivalent
1523 2004-04-21 Jean-Pierre Roux
1524 * FIX gdcmHeaderHelper::GetXSpacing
1525 when a single value is found (bug ?), xpacing is now
1526 defaulted to yspacing
1528 2004-04-19 Jean-Pierre Roux
1529 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1530 * ENH add parameters :
1531 bool exception_on_error = false,
1532 bool enable_sequences = false,
1533 bool ignore_shadow = false
1534 to the gdcmFile constructors to be full gdcmParser compliant
1535 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1536 to allow reading of PAPYRUS 3.0 files
1538 2004-04-06 Jean-Pierre Roux
1539 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1541 2004-04-02 Jean-Pierre Roux
1542 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1543 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1544 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1546 2004-03-30 Jean-Pierre Roux
1547 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1548 for ACR file, written out as DICOM files (hope so...)
1550 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1551 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1552 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1553 moved to base class gdcmParser and only the specialisation is kept
1555 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1556 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1557 already does the job.
1558 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1559 (to be consistent with gdcmParser::WriteEntries).
1561 2004-03-30 Benoit Regrain
1562 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1563 upate of the object's instance. It's passed to 2 in the unfavorable
1564 case : one in the ExecuteInformation, one in the ExecuteData
1566 2004-03-29 Jean-Pierre Roux
1567 * ENH : Check on file type to be written moved
1568 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1569 * FIX : gdcmObject::ResetBoundaries now stops properly
1570 when end-of-list is reached
1571 : gdcmVersion modified (as Benoit Regrain asked)
1573 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1574 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1575 * src/gdcmUtil.cxx: added forgotten iostream include.
1576 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1577 equivalent to ExplicitVR in existing code).
1579 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1580 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1581 now contains all the gdcmGlobal related code.
1582 * minor coding style and doxygenation changes.
1584 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1585 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1586 now contains all the Debug related code.
1587 * minor clean-up of includes in src/*.cxx
1588 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1589 CreateCleanString) removed.
1590 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1591 * Doc/DoxyMainPageUser.txt added.
1592 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1593 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1594 src/gdcmDirList.cxx)
1596 2004-03-24 Jean-Pierre Roux
1597 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1599 2004-03-23 Jean-Pierre Roux
1600 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1601 big endian made volumes
1602 * ENH Now gdcmParser constructor and destructor are protected to forbid
1603 end user to instanciate class gdcmParser
1604 (only gdcmHeader and gdcmDicomDir are meaningfull)
1606 2004-03-22 Benoit Regrain
1607 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1608 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1609 gdcmSerie to gdcmDicomDirSerie
1611 2004-03-19 Jean-Pierre Roux
1612 * ENH Now the tree-like structure describing a DICOMDIR comming from
1613 an already existing DICOMDIR file is consistent with
1614 the home-made tree-like structure build ex-nihilo
1615 or build from the files held (recursively) in a Directory
1616 functions gdcmDicomDir::CheckBoundaries()
1617 gdcmObject::SetBoundaries() added
1619 2004-03-17 Jean-Pierre Roux
1620 * REM (Eric Boix bug) : removal of meaningless
1621 gdcmDicomDirImage::NewImage function.
1622 * FIX now file names and directory name are written properly in the
1624 * FIX now gdcmDicomDir constructor may be call without any trick
1627 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1628 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1629 of gdcmDicomDirImage::NewImage as empty function.
1631 2004-02-28 Jean-Pierre Roux
1632 * ENH add gdcmDicomDir:NewPatient
1633 add gdcmDicomDirPatient:NewStudy
1634 add gdcmDicomDirStudy:NewSerie
1635 add gdcmDicomDirSerie:NewImage
1636 to allow making gdcDicomDir object.
1637 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1638 (as opposite to the gdcmHeader chained list)
1640 2004-02-11 Benoit Regrain
1641 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1642 when using from python
1644 2004-02-10 Benoit Regrain
1645 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1646 * FIX : in gdcmDicomDir when the directory is empty
1647 * ENH : add callback and methods to get the progression of dicomDir
1650 2004-02-06 Jean-Pierre Roux
1651 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1652 - GDCM_META added to gdcmDicomDirType
1653 - class gdcmMeta created
1654 * ENH : - A brief summary is now displayed at the beginning of
1655 'testDicomDir' to help disaster magnitude estimation
1656 * REM : Now useless Test/explDICOMDIR.cxx
1658 2004-02-05 Benoit Regrain
1659 * ENH : add methods in gdcmObject to get the hash table or the list of
1661 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1662 * FIX : wrapping python for TagHeaderEntryHT
1664 2004-02-04 Benoit Regrain
1665 * FIX : even length for some strings when writting the dicom dir
1666 * FIX : sort the images in the dicom dir
1667 * FIX : Bug fix for python use of dicom dir
1668 * ADD : a python demo
1670 2004-02-04 Jean-Pierre Roux
1671 * FIX : Final solution (?) for icone embedded images
1672 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1673 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1674 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1675 gdcmData/gdcm-MR-SIEMENS-16.acr1
1676 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1677 to make full checking easier
1679 2004-02-04 Benoit Regrain
1680 * FIX : WriteEntries : coding style & logic in parameters
1681 * FIX : Set the elements to create the DicomDir in a dictionary file
1683 2004-02-03 Benoit Regrain
1684 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1685 * gdcmDicomDir : add the load of directory
1686 * Bug fix and print add-on
1688 2004-02-03 Jean-Pierre Roux
1689 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1690 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1691 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1692 * FIX gdcmParser.cxx : 'group length' elements are now considered
1693 as integers, even for shadow groups, when file is Implicit VR
1695 2004-02-02 Jean-Pierre Roux
1696 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1698 of the last synonym :-(
1699 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1701 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1702 * FIX taking into account the possible 7fe0,0010 multiplicity
1703 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1704 to allow removal of references to 7fe0,0010, to deal with
1705 ACR-NEMA images, when 0028,0200 is meaningfull
1707 2004-01-31 Jean-Pierre Roux
1708 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1709 no longer writes 'Un' on disk
1710 * FIX SQ elements with actual length are now dealt with corectly
1711 * FIX gdcmFile::WriteBase make the difference, for color images, between
1712 the length (for Palette expanded images)
1713 and Raw Length (non expanded image + Palette)
1714 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1715 (that broke Write). Replaced by UL.
1716 Aware user will reload the field if he
1717 thinks it's necesssary
1719 2004-01-30 Jean-Pierre Roux
1720 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1721 when 'dirty Acr' is found, to be compliant with the new
1722 IsReadable() methods.
1724 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1725 (no DOUBLE images in kosher DICOM,
1726 but so usefull for people that miss them ;-)
1728 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1729 DICOMDIR related utilities (not checked as Windoze compliant)
1731 2004-01-28 Jean-Pierre Roux
1732 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1734 2004-01-27 Jean-Pierre Roux
1735 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1736 to allow skipping the shadow elements, to save memory space.
1737 The TRUE value for this param has to be used
1738 with a FALSE value for the 'enable_sequence' param.
1739 ('public elements' may be embedded in 'shadow Sequences')
1740 * gdcmHeader methods now deal with 'embedded icones images' in the header
1741 (even when an 'icone image sequence' is announced by the
1742 element (0x0088,0x0200), but there is NO icone at all ...
1744 * gdcmHeader sometimes Image Location value doesn't follow
1745 the supposed processor endianity (see gdcmData/cr172241.dcm).
1748 * gdcmHeader add the method
1749 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1750 to get *all* the Header Entries with the same tag.
1751 GetHeaderEntrySameName is probabely *useless*
1752 (no meaning : Name is *not* an identifier within the Dictionnary)
1754 2004-01-26 Benoit Regrain
1755 * Bug fix in the print of hexadecimal representations. Remove long fields
1756 in the print and add a third level of print to print them
1758 2004-01-23 Benoit Regrain
1759 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1760 * Bug fix on test suite after remove the strip made on not string fields
1761 * Split the IsReadable method between gdcmParser which test that the file
1762 is dicom and gdcmHeader which test that it's an image file
1764 2004-01-22 Benoit Regrain
1765 * DicomDir : clean code, add methods, set variables in protected or private
1766 * gdcmUtil : bug fix for the clean string method
1768 2004-01-19 Benoit Regrain
1769 * Add the use of shadow dictionaries
1770 * bug fix and coding style
1772 2004-01-19 Benoit Regrain
1773 * src/gdcmFile.cxx : bug fix concerning the close of file
1774 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1775 * Add the update of header entries using the shadow library
1777 2004-01-19 Benoit Regrain
1778 * removal of file gdcmHeader2.cxx
1779 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1780 inheriting from gdcmParser. This split is to prepare the integration
1781 of dicom dir parsing
1782 * bug fix under python
1784 2004-01-16 Jean-Pierre Roux
1785 * REM removal of class gdcmHeaderEntrySet
1786 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1787 * ADD add file gdcmHeader2.cxx
1788 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1790 2004-01-15 Benoit Regrain
1791 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1792 entries created while parsing the header. Thus, they will be destroyed
1793 when the gdcmDictSet will be destroyed
1794 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1797 2004-01-15 Benoit Regrain
1798 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1799 made a fatal error because of the memory release at the end of program.
1800 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1801 some memory and vtk seems to have some problems with that.
1802 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1804 2004-01-14 Benoit Regrain
1805 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1806 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1807 * src/*.[h|cxx] : make changes due to class name changes
1808 * gdcmPython/demo/*.py : bug fix due to method names
1810 2004-01-13 Benoit Regrain
1811 * src/*.[h|cxx] : coding style
1812 * vtk/*.[h|cxx] : coding style
1814 2004-01-13 Benoit Regrain
1815 * gdcmPython/testSuite.py : test the readable flag of file for tests
1816 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1817 It's lied to the stl compilation by MSVC (windows, always windows...)
1818 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1820 2004-01-12 Benoit Regrain
1821 * src/*.h : add comments
1822 * src/gdcmDictSet.h : set the method BuildDictPath in public
1823 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1824 directly setted in the source code
1825 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1828 2004-01-09 Benoit Regrain
1829 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1830 * setup.py : use a reference to gdcmVERSION
1832 2004-01-07 Benoit Regrain
1833 * Modification to compile with the distutils.
1836 2003-12-10 Benoit Regrain
1837 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1838 can use a gdcmHeaderHelper to load datas
1839 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1840 made in the source code
1842 2003-12-10 Benoit Regrain
1843 * Update Windows projects and .cvsignore files
1845 2003-11-12 Jean-Pierre Roux
1846 * ENH gdcmHeader constructor has one more parameter (default value : false)
1847 that allows the user to 'go inside' the SeQuences only
1849 gdcmElValSet:Print takes it into account
1851 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1852 * ENH: Update gdcmPython/CMakeLists
1853 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1854 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1856 2003-11-10 Jean-Pierre Roux
1857 * FIX : gdcmHeader::LoadElements is now based
1858 on the ListTag listElem member,
1859 not longer on the TagElValueHT tagHt member
1860 * ENH : PrintPubElVal shows (temporarily) both results,
1861 with the tagHt member and the listElem member.
1862 (it's easier to 'see' the problems when using Printheader)
1864 * FIX : old private member LgrElem is now splitted into
1865 ReadLength : Length actually found on disk (updated only
1866 if bug fixing is necessary), for internal
1868 UsableLength : Updated by FixFoundLength, to fix a bug
1869 or to allow Parser going on.
1870 Will allow to re-write a kosher header when a SeQuence
1871 with a length (not 0000) is found
1872 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1873 because gdcmElValSet::Add does not update ListElem
1876 2003-11-07 Jean-Pierre Roux
1877 * FIX misstyping in Transfert Syntax name table
1878 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1879 when they have an actual length (not 0000 nor FFFFF)
1880 (Nobody should care of it, but DICOMDIR explorers)
1882 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1883 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1885 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1886 * ENH: vtkGdcmReader now supports LUT !
1887 (vtkgdcmViewer for now is not able to use them though)
1889 2003-11-05 Jean-Pierre Roux
1890 * in testSuite.py : new files names for checking the package
1891 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1892 that returns the pixel area size to the *aware* (vtk) user
1893 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1895 2003-11-05 Benoit Regrain
1896 * in testSuite.py : Modify the rules for checking the paths
1897 : Explicit error messages
1898 * in __init__.py : Related modif
1900 2003-11-03 Jean-Pierre Roux
1901 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1902 to be used by aware (vtk) users that want to manage
1903 LUT (and no to turn the PALETTE image into an RGB pixels one)
1904 * GetPixelType now returns 8U for 24 Bits images
1905 (vtkGdcmReader compliant)
1907 2003-10-31 Jean-Pierre Roux
1908 * Removal of *all* gdcmData images and add them again
1909 in order to loose the 'history' of un-anonymised images
1911 2003-10-31 Jean-Pierre Roux
1912 * RMV : removal of useless jBitsInJsample.h
1913 for both 8 and 12 Bits JPEG Lossy Libraries
1915 2003-10-31 Jean-Pierre Roux
1916 * ENH : Add the functions gdcmFile::GetImageDataRaw
1917 gdcmFile::GetImageDataIntoVectorRaw
1918 that act as GetImageData and GetImageDataIntoVector
1919 except the making of an RGB Plane from Gray Plane + LUT
1920 Intended to aware (vtk) users who know how to manage
1923 GetLUTRGBA return a R,G,B,A LUT if any
1924 lgrTotaleRaw gives the 'Raw' length
1925 GetImageDataRaw returns the gray Plane
1926 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1927 (They stay Grey, just like with other Dicom viewers :-(
1929 2003-10-30 Jean-Pierre Roux
1930 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1932 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1933 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1934 being coherents dicom files.
1936 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1937 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1939 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1940 * ENH: Two steps is necessary to please VC++ compiler...
1941 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1942 * ENH: Add include dir to medcon lib
1943 * FIX: only one function is being exported for now !
1944 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1946 2003-10-29 Jean-Pierre Roux
1947 * adding gdcmHeader::GetLUTRGBA
1948 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1949 --> Mathieu, the modif u're waiting for is not yet committed
1950 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1952 2003-10-27 Jean-Pierre Roux
1953 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1954 00191113.dcm DermaColorLossLess.dcm
1955 MxTwinLossLess.dcm RadBWLossLess.dcm
1956 * ENH: For version prior to vtkImageViewer2 -r 1.19
1957 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1959 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1960 * Removal of ido stuff in CMakeLists.txt
1962 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1963 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1964 * FIX: remove a call to ->Modified ... see comments
1965 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1967 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1968 * FIX: Problem with path for libvtkgdcmPython
1969 * ENH: Try adding a search script for python site-package
1970 * RMV: Remove some file from medcon lib that are not necessary
1971 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1972 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1973 * FIX: More pragma disable fro VC++,
1974 I don't think I break something as it is also disable in VTK/ITK.
1975 But it fasten debug compilation time.
1977 2003-10-23 Jean-Pierre Roux
1978 * gdcm now deals with 16 Bits Run Length Encoded images
1979 (they are compressed as 2 planes images,
1980 one for the high Bytes, the other for low Bytes)
1982 2003-10-22 Jean-Pierre Roux
1983 * Now CheckRead takes into account :
1984 - the bugged 'Leonardo' Siemens images
1985 - the XA images, sent thru the burning VPRO station
1986 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1989 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1990 * FIX: When copying a Makefile.am to CMakeLists.txt
1991 one should remove the '\'
1993 2003-10-22 Jean-Pierre Roux
1994 * in gdcmData adding a bugged 'Leonardo' Siemens image
1995 (wrong lengths in header)
1996 OK with gdcm, KO with the other viewers :-)
1997 * add a GE dlx XA image, thru the VEPRO burning station
2000 2003-10-21 Jean-Pierre Roux
2001 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2002 for a brutal checking of vtkgdcmViewer compliance
2004 2003-10-21 Jean-Pierre Roux
2005 * add the files for 'xmedcon' Jpeg Lossless library
2006 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2008 2003-10-21 Jean-Pierre Roux
2009 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2011 2003-10-21 Jean-Pierre Roux
2012 * garbage Siemens 'Leonardo' images dealt with
2013 (the patch is easy to remove)
2014 * cosmetic changes to avoid warnings
2016 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2017 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2018 no need to press 'r' now.
2020 2003-10-20 Jean-Pierre Roux
2021 * upgrade of checkRead.sh checkWrite.sh according
2022 to new Jpeg Lossless decompressor
2023 * add US.3405.1.dcm, a genuine RGB medical file ...
2024 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2025 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2027 2003-10-15 Jean-Pierre Roux
2028 * general anonymisation in gdcmData
2029 * adding the 'color files' from
2030 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2031 * adding some well knowed bugged-header images
2032 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2033 waiting for their inclusion in Python testsuite
2035 2003-10-15 Jean-Pierre Roux
2036 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2037 no longer seg faults when file is not found
2039 2003-10-14 Jean-Pierre Roux
2040 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2043 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2044 * TODO: *.in file to genereate a UseGDCM later
2046 2003-10-14 Jean-Pierre Roux
2047 * Some supposed-to-be Dicom Images have no preamble.
2048 OpenFile takes it into account
2049 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2050 * Missing elements added in dicomV3.dic
2051 (just to be affraid : have a look at
2052 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2053 and do it again next year ;->
2055 2003-10-13 Jean-Pierre Roux
2056 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2057 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2058 But there are NOT. It's fixed !
2060 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2061 * FIX: "jpeglib.h" was not found on VC++
2062 * FIX: vtkgdcm was not being installed
2064 2003-10-10 Jean-Pierre Roux
2065 * ENH : OpenFile closes the file if it *really* doesn't look like
2066 an ACR-NEMA / DICOM one.
2067 * FIX : testWrite no longer writes an empty file if the source file
2068 is not gdcm Readable
2069 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2072 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2073 * FIX: CMake generate now documentation
2074 * ENH: out of source doc build !
2075 * ENH: Generate both user and dev documentation
2076 * ENH: Should work on windows too
2077 * ENH: Only one doxygen config.in file is needed
2078 * FIX: make install should be ok now on ùnix plateform
2079 * FIX: PATH to dictionary was wrong (missing /)
2080 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2082 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2083 * vtkGdcmReader is now able to read rgb dicom file.
2084 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2085 * added a gdcmViewer to vtk test, use mouse to control
2086 window level & window width
2088 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2089 * CMake-ification of gdcm, we have now two build system
2090 * FIX: on cygwin Wsock32 doesn't exist
2091 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2093 2003-10-06 Emanuel Ollart
2094 * FIX : compilation process wad broken.
2095 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2097 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2098 * change gdcmViewer -> vtkgdcmViewer
2099 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2101 2003-10-06 Jean-Pierre Roux
2102 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2103 ( e.g : well known GE images with a wrong elem length,
2104 : Philips MRI Images with a wrong Huffman table)
2105 * still to be done : allow the reading of bugged LEONARDO Siemens images
2107 2003-10-03 Jean-Pierre Roux
2108 * Odd length strings are padded with '\0' (not with spaces,
2109 to remain compliant with already defined strings,
2110 like Transfert Syntax UID and others)
2112 2003-10-03 Jean-Pierre Roux
2113 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2114 to allow displaying RGB images (not only by affim ;-)
2116 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2117 * vtkGdcmReader is now able to read rgb dicom file.
2118 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2120 2003-10-03 Jean-Pierre Roux
2121 * A few nasty patches to allow the reading of a lot of nasty images
2122 ( e.g : well known GE images with a wrong elem length,
2123 : Philips MRI Images with a wrong Huffman table)
2124 * still to be done : allow the reading of bugged LEONARDO Siemens images
2126 2003-10-03 Jean-Pierre Roux
2127 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2129 2003-10-03 Jean-Pierre Roux
2130 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2131 to allow displaying RGB images (not only by affim ;-)
2133 2003-10-03 Jean-Pierre Roux
2134 * gdcmFile::GetImageDataIntoVector now
2135 - deals with MultiFrames MultiFragments Run Length Encoded files
2136 - deals with YcBcR (YBR_FULL) files
2137 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2138 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2140 (no sample found :-(
2142 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2143 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2144 Two reasons: - clear things
2145 - third parties acces gdcm through header files, so won't
2146 suffer anymore VC++ complains
2148 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2149 * add argv[1] in testvtkGdcmReader.cxx
2152 2003-09-24 Jean-Pierre Roux
2153 * The lines are now eigthy characters long.for
2154 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2156 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2157 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2158 char* to std::string. Thus, the use of strdup becomes useless. (see
2159 previous commis of Malaterre)
2160 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2161 before the last Malaterre's commit.
2163 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2164 * This commit should fix the Debug building under VC++, the problem
2165 was mainly a mixture of debug and release lib being loaded at startup.
2166 * I also remove a depency to a specific C function: strdup. Because I had
2167 to force the link to msvcrtd (whereas strdup is in libc).
2169 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2170 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2171 located in the gdcmCommon.h file. All use of reference of tha has been
2172 changed to now use the variable GDCM_UNFOUND.
2174 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2176 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2177 Dicom dictionary. The test suite can now be run again. Note:
2178 I'm note very happy with the " (RET)" changes. I believe this
2179 RETAINED comment should be dropped when parsing the dictionary.
2180 - PACKAGER corrected
2182 - AUTHORS updated and now in alphabetical order
2183 * Makefile.am now exports gdcm.dsw for Windoze users.
2185 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2186 * cygwin complains about missing std:: in subdir Test/
2188 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2189 * remove some methods that are now in gdcmHeaderHelper
2191 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2192 * vtkGdcmReader set spacing and origin correctly
2194 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2195 * Fix a few delete/delete[] mismatch
2197 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2198 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2199 interpretation to data given by gdcmHeader. For instance there are
2200 heuristics to get informations (look at different places).
2201 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2202 sorting DICOM images based on different strategies.
2203 * modified Makefiles accordingly.
2205 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2206 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2207 when building in debug mode
2208 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2209 src/win32/gdcmdll.dsp
2210 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2212 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2213 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2216 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2217 * src/win32/libgdcmjpeg12.dsp was not dos format
2218 * src/win32/libgdcmjpeg12.dsp :
2219 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2220 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2222 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2223 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2225 * src/gdcmFile.cxx : bug fix in affectation type
2226 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2227 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2228 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2229 symbols... future problem ?
2231 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2232 * src/win32/libgdcmijpeg12.dsp was missing
2233 * modified gdcm.dsw accordingly
2235 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2236 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2238 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2239 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2240 commit of JPR (before his hollidays to facilitate our work).
2241 * setup.py : bug fix in code. Modifications made while the last commit
2242 of JPR. The code hasn't been tested before the commit... it's so
2243 useless to make that (for best programmer that is JPR) !!!
2245 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2246 * tagged the current version as Version0_3 (i.e. version 0.3)
2248 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2249 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2250 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2251 * *.dsp : modifications to use new libgdcmijpeg8 library
2252 * setup.py : bug fix on VTKPATH variable
2253 * PACKAGER : adding all concerning windows
2255 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2256 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2258 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2259 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2260 test suite reported error.
2261 * PACKAGER file added (describes what a packager must do when
2262 packaging a new release).
2263 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2264 * configure.in: upgraded version number to 0.3.0
2265 * fixing build of rpm (through rpm -ta):
2266 - Doc/Makefile.am exports proper doxygen files
2267 - src/jpeg/libijg8/Makefile.am exports the include files.
2269 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2270 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2271 * src/gdcmHeader.h : formatting code
2273 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2274 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2275 We were obtaining error message from vtk. Now, creation of file list
2276 is made in an internal list to prevent this problem.
2277 Bug fix when output is empty.
2278 Bug fix in update of progress value. Previous commit for this was a bad
2280 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2282 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2283 * src/gdcmHeader.h : added method to get the file name
2284 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2285 files. Added method to remove all files on the input
2286 Added FIXME comment concerning the bad parsing of header made by
2287 ExecuteInformation method (in ExecuteData method)
2289 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2290 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2291 when using make instal.
2292 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2293 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2295 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2296 * setup.py : adding include dir of jpeg lib to compile all sources
2297 * */Win32/*.dsp : JPR fix for windows compilation
2299 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2300 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2302 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2303 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2305 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2306 * setup.py is again effective on un*x (takes into account the
2307 addon of the jpeg library)
2308 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2309 * Doc/Doxy* updated (includes above enhancements)
2310 * INSTALL now points to web documentation
2312 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * src/gdcmHeader.h doesn't make unnecessary reference to
2315 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2317 * src/gdcm*.[cxx|h] :
2318 - to allow compilation with gcc 3.x
2319 -- clean up of STL usage (added explicit usage of std::)
2320 -- small fixes on exceptions.
2321 Note: linking not tested !
2322 - clean of doxygen comments to avoid warnings at documentation
2324 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2325 dependent convertion).
2327 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2328 * Clean up of previous JPR garbage commit (not even commented in the
2330 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2331 - moved all jpeg related files from src to src/jpeg/libijg8, with
2332 addition/modification of Makefile.am and configure.in.
2333 - the testSuite is still brain damage (not guilty).
2335 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2336 * WrapVTK.py : modifications to get correctly vtk source files to
2338 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2339 (FileName -> Filename)
2341 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * vtk/vtkGdcmReader.[cxx/h]:
2343 - UpdateProgress method should now be effective
2344 - removed the limitation on having only images loaded (as opposed
2346 - when building a stack of images/volume, a lesser number of
2347 gdcmHeader and gdcmFile instances should be used (hopefully
2348 accelerating things).
2349 - when building a stack of images/volumes, files which are not
2350 loadable (wrong path-filename, wrong permissions on existing file,
2351 or file not parsable by gdcm) are replaced with a black image
2352 in the stack (for the caller to notice the problem).
2354 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2355 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2357 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2358 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2359 between standard library (std) and vtk library (problems are found
2360 under Windows... thanks Windows !)
2362 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2363 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2365 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2367 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2370 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2371 * When compiling with distutils (see setup.py) the C++ compiler is
2372 called with different flags than the default ones (with automake).
2373 In order to fix all those warning, I compiled gdcm with the command
2374 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2375 and went for warning fixes:
2376 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2377 up from unused variables.
2378 - vtk/vtkGdcmReader.cxx: potential bug fix.
2379 * src/gdcmHeader.h: Doxygen warning cleanup
2381 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * gdcmPython/gdcm.i:
2383 - typemaps correction to take into account the systematic replacement
2384 of "using namespace std" with std:: prefix e.g. std::list,
2385 std::string... (cf changes of 2003-05-21).
2386 - gdcmGlob global variable of type gdcmGlobal (defined in
2387 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2388 exported to Python a as cvar.
2389 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2390 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2391 gdcmDictSet.GetPubDictTagNames() and
2392 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2393 C++ static methods).
2394 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2395 with the above changes.
2397 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2398 * setup.py, manifest.in : bug fix under linux
2400 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2401 * Modification of setup.py to compile vtk part too. Then, we have 2
2402 wrappers which must work with same distutils. For that, we have a
2403 generic distutils in distusiltsWrapping.py ; with :
2404 - build_extWrap class to wrap generically all extensions,
2405 - ExtensionWrap base class for all wrapping extension that contains
2407 - Wrapper interface which wrap sources
2408 + In WrapSwig.py we have extension and wrapper for Swig
2409 + In WrapVTK.py we have extension and wrapper for VTK
2410 * MANIFEST.in : modifications to consider vtk directory and new python
2411 files for compilation
2413 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2414 * Added python wrappers of vtkGdcmReader vtk class (see the
2415 source in vtk/vtkGdcmReader.cxx) :
2416 - vtk/Makefile.am now builds a library
2417 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2418 python library (as opposed to _gdcm.so wich are the python
2419 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2420 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2422 - configure.in has an additional flag --enable-vtk that needs
2423 to be set to enable compilation of vtk related code, that is:
2424 + vtk/vtkGdcmReader.so and
2425 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2426 + gdcmPython/vtkgdcmPython.so (see above)
2427 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2428 be read when compressed or when HighBit + 1 != BitsStored),
2429 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2430 the usage of the python wrapper of vtkGdcmReader vtk class.
2431 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2432 * src/*.[h] all occurences of stl classes are now prefixed with
2433 std::, and all occurences of "using namespace std;" where removed.
2434 This is to avoid pollution of global namespace in included files.
2435 Apparently vtk does not avoid this pitfall: when using both
2436 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2437 collision of various stl members (principally cout...).
2438 * gdcmPython/testSuite.py now cleanly removes temprory generated
2440 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2441 comply with above changes)
2443 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2444 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2445 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2446 vtk data structure (an image Flip was required).
2447 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2448 * cosmetic changes in documentation.
2450 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2451 * src/gdcmHeader.cxx: the constructor no longer exits when an
2452 unexisting file is given as argument.
2453 * The subdirectory Data (containing all the images used for the
2454 test suite) is not part of this repository anymore. A new module
2455 containing those images is now available at
2456 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2457 with the name gdcmData.
2458 All the python scripts (including the package initialisation file
2459 gdcmPython/__init__.py) were adapated to take this change into
2460 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2462 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2463 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2464 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2465 demo of the usage of this class.
2466 Compilation of this vtk part is only done when using the --enable-vtk
2467 at configure (or autogen.sh) stage.
2469 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2470 * More memory link related corrections and documentation fixes.
2472 - maximum info is obtained with a command of the form:
2473 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2474 --show-reachable=yes PrintHeader
2475 - the remaining reachable blocks seem to come from the STL
2476 allocation scheme through the usage of map and list. It looks
2477 like this memory cannot be freed but it is not a memory leak
2478 (in fact further invocation to the STL would recollect the
2479 unused memory allthough it cannot explicitely be freed).
2480 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2481 of displaying an image parsed with gdcm and displayed with VTK.
2482 Note: some images don't seem to work e.g.
2483 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2484 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2485 Allthough this weakens the semantics, it is a ditch attempt to
2486 make gdcm more thread friendly.
2488 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2489 * Memory link hunt (by using valgrind through the command
2490 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2491 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2492 gdcmHeader::_dicom_vr.
2493 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2494 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2496 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2498 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2499 * src/Makefile.am now exports all the necessary include files at
2503 * UpdateGroupLength replaced by new one
2506 * UpdateGroupLength re-written using H-Table
2507 (named UpdateGroupLengthNew untill checks are over)
2509 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2510 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2511 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2513 - gdcmHeader::GetPubElValSet removed.
2514 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2515 UpdateGroupLength, WriteElements, Write.
2516 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2517 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2518 carried the same semantics.
2519 - src/gdcmHeaderIdo.cxx changed accordingly.
2520 - gdcmFile::WriteBase now regroups all the codes from previous
2521 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2522 - enum FileType moved to gdcmCommon.h
2523 * src/gdcmHeader.cxx AddDefault trashed
2524 * gdcmGetXSize added
2525 * getimageDataSize now calls gdcmGetXSize
2526 * Test/*.cxx changed to agree with above changes
2528 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2529 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2530 (to avoid double call by end user).
2531 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2532 by end user, since gdcmHeader::gdcmHeader now handles it.
2534 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * gdcm/Doc many doxygen changes:
2536 - Doxyfile now has two different versions, DoxyfileUsers that generates
2537 the html.users end users oriented documentation and
2538 DoxyfileDeveloppers that generates the html.developper developper
2539 oriented documentation.
2540 - README changed accordingly
2541 - requirement.txt removed (old design info moved to TODO).
2542 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2543 DoxyMainPage.txt, DoxyPython.txt provide more information.
2544 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2545 be updated by simply regenerating the docs with doxygen and copying
2546 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2547 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2548 all the tests in the form "if (<map>.count() >1)" were removed.
2549 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2550 ill-formed documentation sections.
2551 * src/gdcmHeader.cxx: ditto
2553 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2554 * setup.py fixed for un*x (needed macro for stdint.h)
2555 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2556 un*ces with sh-utils test utility.
2557 * gdcmPython/demo/test.py renamed to PrintHeader.py
2558 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2559 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2560 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2561 * src/gdcm*.cxx JPR's bad inclusion fixed.
2563 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2564 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2565 * gdcmPython/demo/test.py changed accordingly.
2567 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2568 * gdcmPython/Makefile.am fixed linking against libstdc++
2569 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2570 * Swig subdir (historical tests of swig version 1.3.17++) removed
2571 * Test/testChangeEntete.cxx some lines commented out in order to make
2573 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2574 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2576 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2577 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2578 hence the user doesn't need this explicit call.
2579 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2580 i.e. LoadElements() call removed.
2581 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2582 - src/Makefile.am declares the proper flag for g++.
2583 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2584 for adding user defined new tags.
2585 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2586 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2587 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2589 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2590 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2591 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2592 src/Makefile.am : the project should properly compile and install
2593 with the autotools, included the python wrappers part.
2594 * gdcm.spec.in : added a spec file for RPM packaging.
2596 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2597 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2599 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2601 to exported to the environement (see gdcmPython/testSuite.py
2603 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2604 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2605 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2606 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2607 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2609 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2610 * gdcmPython/__init__.py doesn't crash anymore when running in
2611 in InstallMode or PreInstallMode but with an environement given
2612 value of GDCM_DICT_PATH.
2613 * src/gdcmDictSet.[cxx/h] coding style.
2615 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2616 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2617 * src/gdcm.h general comments moved to TODO, and README
2618 * src/gdcm.h should now be seen as a user commodity (including it
2619 should suffice to fully use gdcm). It is nowhere including within
2620 any of the kernel files src/*.cxx and src/*.h.
2622 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2623 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2624 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2626 * src/gdcm*.cxx only include their corresponding include file
2627 (as opposed to gdcm.h)
2628 * gdcmPython/gdcm.i changed accordingly
2629 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2630 the autogen.sh generated "make snapshot" command to work.
2631 * autogen.sh removed history related references to crea package.
2633 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2634 * distutilsSwigCPlusPlus.py work around some swig portability
2637 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2638 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2639 was done in a last ditch attempt to get setup.py _really_
2640 operationnal. The python/gdcmPython layaout add the advantage
2641 of hidding away the python related distutils specific files
2642 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2643 Alas, the src directory was out of scope (i.e. it's relative
2644 position to setup.py was ../src) which made things impossible to
2645 handle (see previous version of python/setup.py). Crossing fingers...
2647 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2648 * python/setup.py now works on Un*x. (harder than I thougth)
2649 * python/distutilsSwigCPlusPlus.py can now have include files
2650 among the list of sources.
2652 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2653 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2654 * modifications in MSVC projects
2656 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * As stated by the first lines of Test/ExceptionAndPython/README, it
2658 looks like we can move back to original usage of exception within
2659 src/gdcm* and hence remove the errno stuff that was introduced
2660 as a quick and dirty fixture of this problem (added to the TODO).
2661 * Doc/Doxyfile configuration file for Doxygen and corresponding
2662 README file for usage added.
2663 * Test/testWrite.cxx added. This new test comes from a split of
2664 test.cxx that is now reverted to its original purpous i.e.
2665 testing the proper parsing of a Dicom related file.
2666 testWrite.cxx concentrates on testing the IO part of gdcm.
2667 * Test/bug1.cxx (containing a bug on WIn32) added.
2668 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2669 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2670 whose purpose is to publish the content of the TagNames of the
2671 Dicom public dictionnary were not accessible without an
2672 instance of class gdcmHeader.
2673 - those methods are now static methods of gdcmDictSet and hence
2674 require no instances at all to be invocated.
2675 - within gdcmDictSet this change required to change some method
2676 to class methods (i.e. are now static) among which SetDictPath
2677 (renamed to BuildDictPath) and LoadDefaultPubDict.
2678 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2679 the above changes by calling the new method classes of gdcmDictSet.
2680 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2681 the above to be effective.
2682 * python/gdcmPython: in order to wrap properly the above changes
2683 for Python, swig version now needs to be > 1.3.17.
2684 * python/gdcmPython/Makefile fixed to adapt itself to new
2685 configure/make shema introduced by Johan Montagnat (thanks for the
2686 contribution). Alas this Makefile cannot be turned into a proper
2687 Makefile.am without some heavy changes in the configure.in
2688 (for python dectection).
2689 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2690 now avoids publishing the empty entries.
2692 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2693 * python/setup.py : bug fix concerning install under windows
2694 ExtraPath reused :-P
2695 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2697 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2698 * Dicts/dicomV3.dic : remove double spaces !!!
2699 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2700 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2703 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2704 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2705 method. Doxygenation.
2706 * src/gdcm.h clean up of JPR spurious comments.
2708 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * python/distutilsSwigCPlusPlus.py now properly collects the
2710 shadow classes generated by "swig -c++" (gdcm.py in our case)
2711 when using "python setup.py install".
2712 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2713 reexports the working classes.
2714 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2715 by the classical C errno scheme. This is to prevent an obscure
2716 behavior of the python wrappers when importing wxPython.wx prior
2717 to gdcmPython (which ended up in an abort call). An illustration
2718 of this oddity can be found in the Test/ExceptionAndPython
2719 subdir (see the README file). This problem probably due to
2720 an combination of g++ and dynamic loading.
2721 * added Test/ExceptionAndPython (see above)
2723 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * Changed the layout of the python part to avoid bloating main
2725 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2726 i.e. the distutils arsenal. All the python related stuff is
2727 again in a python subdir, but the package itself is now in
2729 * setup.py was cleaned up:
2730 - pythonIncludePath removed
2731 - python setup.py bdist target is now functional.
2732 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2733 collision with other packages). gdcmPython/demo/*.py changed
2736 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2737 * python subdir moved to gdcmPython (preparation of distutils packaging).
2738 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2739 distutils installer is operational.
2740 * - gdcmPython/__init__.py now properly loads the swig generated
2741 shadow classes (from gdcm.py).
2742 - gdcmPython/demo/*.py changed to import the package gdcmPython
2743 instead of gdcmPython/demo/load.py.
2744 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2746 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2747 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2748 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2749 entries within the associated public Dicom dictionary resp. the same
2750 information but sorted by the fourth field (PAT, IMG, DIR) of the
2752 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2753 are now in the "???" group.
2754 - python/gdcm.i changed accordingly,
2755 - python/demo/printGroupedPublicDict.py added, that gives an example
2756 of the above new functionalities in Python.
2758 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * src/gdcm.h, gdcmHeader.cxx:
2760 - historic references to glib's g_malloc and g_free (#defined)
2761 were definitively removed.
2762 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2763 * src/gdcmElValSet.cxx:
2764 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2765 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2766 - GetElValue(string) renamed to GetElValueByName.
2767 - Added GetElementByName(string).
2768 * src/gdcmHeader.cxx: added
2769 - GetPubElValRepByNumber(guint16, guint16)
2770 - GetPubElValRepByName(string)
2771 - GetShaElValRepByNumber(guint16, guint16)
2772 - GetShaElValRepByName(string)
2773 - GetShaElValByNumber(guint16, guint16)
2774 - GetShaElValRepByName(string)
2775 - GetElValRepByNumber(guint16, guint16)
2776 - GetElValRepByName(string)
2777 - GetElValByNumber(guint16, guint16)
2778 - GetElValRepByName(string)
2779 * Doc/requirements.txt added.
2781 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2782 * Test/Makefile building now depends on the one of libgdcm.so
2783 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2784 pixel data) aware which enables finding the address (offset) of
2785 the pixel data of JPEG encoded DICOM files. This leaves only a single
2786 file in the testSuite whose pixel data address (offset) is unknown.
2787 * python/testSuite.py changed accordingly.
2789 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2790 * VC++ has some strong limitations when working with the STL, as stated
2791 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2792 "Also note that some STL containers (map, set, queue, list, deque)
2793 cannot be exported. [...]
2794 Some STL classes contain nested classes. These classes can not
2796 This is caused by a designed limitation that once a template
2797 class is instantiated, it can not be re-instantiated and
2799 Since our usage of map<> is ubiquitous in gdcm, this "designed
2800 limitation" of VC++ is a pitfall.
2801 Hence the Python wrappers of gdcm cannot be incrementally linked
2802 against the c++ dynamic library. The dirty but only workaround is
2803 to forget about incremental link of dynamic libraries and to generate
2804 the Python wrappers library with the inclusions of the underlying C++
2806 The following modifications concern this matter on Win32/VC++:
2807 - wrapping python correct with standalone wrapped dll (don't use separate
2808 dll under windows !!!!)
2809 - python21_d debug mode enabled (ask Frog how to use it :-)
2810 - NO problem with having an STL member of class for example string in C++
2811 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2812 - Python test of dcmlib in Python is ok under windows on a large set
2814 * removed glib references
2815 * typedef's inserted in gdcm.i for correct swig type management
2817 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * python/demo/*.py load.py extracted from test.py. Added explore.py
2819 that only displays required tags and testAll.py that parses all
2820 the files of the testsuite without using unittest.
2821 * python/testSuite.py other additional test on new files added.
2822 * Data/* new test files added accordingly to the testSuite.
2823 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2824 the vr in the file differs from the one of the dictionary.
2826 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2827 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2828 values, but limits itself to values which are below a user specified
2829 size (by default 1024 bytes).
2830 * python/gdcm.i : elements not loaded (because their size is above the
2831 user specified treshold) are exported with their TagKey as key of the
2832 python dictionary. This enables the testsuite to make some checks
2833 on the unloaded elements (since we have their offset and size).
2834 * python/testSuite.py
2835 - now tests for the existence and proper value of the pixel data
2836 - two new examples added.
2837 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2839 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2840 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2841 aware. See the strategy comments in gdcmHeader::FindeLength().
2842 * Test/test.cxx now accepts a filename as first argument.
2843 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2844 * python/testSuite.py changed to integrate test on above files.
2846 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2847 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2848 the vr was also RET.
2849 * python/testSuite.py more tests added.
2851 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2852 * python/testSuite.py unittest test suite added (uses Data)
2853 * Data/* dcm and acr files for the test suite.
2854 * glib dependance removed from un*x version. We now use ISO C99
2855 7.18 Integer types (see stdint.h)
2856 - python/Makefile, src/Makefile src/gdcm.h
2857 * src/ when an explicit vr (like dicom files) suddenly poped an
2858 implicit element we use to mark the underlying DictEntry of the
2859 concerned ElValue with "Implicit". This strategy was damageable
2860 too the public or provite dictionaries, since some of their vr
2861 would be changed. Since Header::FindLength heavily relies on the
2862 detection by Header::FindVR of falsely explicit elements, I
2863 added an extra ImplicitVr member to ElValue (boolean).
2864 The rest of the changes we the necessary adaptations.
2866 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2867 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2869 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2871 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2872 * Adaptation for porting to VC++:
2874 o forced to use std namespace (for string to be known)
2875 o all class use __declspec export style on WIN32
2876 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2877 (in stdlib.h on Win32 but in std:: for gcc)
2878 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2879 variable GDCM_DICT_PATH.
2880 * src/gdcmHeader.cxx verbose comments made discrete.
2882 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2883 * python/gdcm.i: added a typemap that converts a C++ hashing table
2884 to native Python dictionary.
2885 * python/demo/test.py:
2886 - now uses the native dictionary for exploration of gdcmHeader.
2887 - takes an optional filename argument (the file to parse).
2888 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2889 PubElVals hashing table.
2890 * Dicts/dicomV3.dic removed error prone trailing spaces.
2892 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2893 * Python wrapping process moved away from src/Makefile to
2894 newly created python/Makefile (as well as gdcm.i)
2895 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2896 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2897 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2898 from the environement variable GDCM_DICT_PATH (when existing).
2899 * src/gdcmDict::GetTag bug fix.
2901 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2902 * Straightforward temporary fixes for swig to build the python wrappers.
2903 src/Makefile now has a python working entry [by working we mean
2904 that we can import de shadow classes without errors].
2906 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2907 * hashtest.cxx removed (since allready in Test)
2908 * src/gdcmlib.h renamed to src/gdcm.h
2909 * src/dcm.i renamed to src/gdcm.i
2910 * src/Makefile prepared for python wrapping
2912 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2913 * src/gdcmHeader.cxx :
2914 - Parsing of header is now separated from loading of element values
2915 (see gdcmHeader::LoadElements).
2916 - general clean up of hopefully all file access (creation of
2917 ReadInt16 and ReadInt32)
2919 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2920 * src/gdcmHeader.cxx :
2921 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2923 - SetLgrElem renamed to SetLength
2924 - GetLgrElem renamed to GetLength
2925 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2926 * src/gdcmElValSet.cxx fixed both GetElValue methods
2927 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2928 due to IdoDude was cleaned out.
2930 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2931 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2932 concentrates on finding the value representation (when it exists).
2933 RecupLgr now only finds the element value length, and it avoids
2934 returning the unecessary skL (skipped length).
2935 Also, offsetCourant was simply removed (with taille_fich) since
2936 it was redundant with the File position internals (by using
2937 ftell and fseek). This also made skL (see above in RecupLgr) usage
2939 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2940 on the libido specificities which are handled through class
2942 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2945 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2946 * Truckload of changes. Parsing of header is barely functional
2947 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2949 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2950 * src/gdcmHeader.cxx many addons of low level methods
2952 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2953 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2954 and _IdDcmSWAP_LONG.
2956 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2957 * This corresponds to all the changes decided at the meeting of
2958 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob