1 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
5 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * Bugs fix for the Windows build with VC6
7 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
8 needed (only for projects required VTK). If the VTK is included in all
9 projects, there is conflicts with the jpeg lib of vtk when compiling the
10 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
11 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
12 when compiling the gdcm_wrap.cxx file (created by the compilation of the
14 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
15 (like it's already made for the cout use). Otherwise, conflict with the
18 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
19 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
21 - comments on the DicomDir::Method related usage added.
22 - now that we use the namespace gdcm, a lot of internal classes do
23 NOT need to be wrapped anymore.
24 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
25 DicomDir::Method) new example added.
27 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
28 * Improve string manipulation. I now inforce the notion of 'DicomString'
29 A DicomString can contain as many \0 as they want
30 and it is *always* of even length.
31 We only support odd length for very rare case.
32 And in the near future this should be removed.
34 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * /binary_write/ gdcm source. Now even on big endian we are writting
36 little endian. This should -heopfully- fix some tests
38 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
39 * Now the dictionary is compiled into gdcm lib. This is a default
40 behavior, thus any dic file specified is picked before failback to
41 the one comiled into lib
43 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
44 * Change internals for gdcmDict. Don't use any 'new' any more.
45 This should definitely solve any leak problem, and we should be
46 as fast as before, as long as don't modify too much the dictionary.
48 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
49 * STYLE: ivars should start with a capital letter.
50 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
51 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
53 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
54 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
55 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
56 new 2004 dictionaries added (thanks to JPR).
57 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
58 * CLEANUP_ROUND (15) for gdcmPixelConvert
59 - RLEFrame::NumberFragments is now of type unsigned int
60 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
61 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
64 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
65 * Initial work in gathering all transfer syntax accessors. clearly
66 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
67 ivars, but only one transfersyntax (class) ivar with equivalent method on
70 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
71 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
72 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
73 discussed (plus I didn't like having a 2000 lines patch not commited)
75 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
77 * CLEANUP_ROUND (14) for gdcmPixelConvert
78 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
79 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
80 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
82 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
83 anymore and hence avoids storing a copy of PixelConvert::Decompressed
84 into File::Pixel_Data.
86 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
88 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
89 * CLEANUP_ROUND (13) for gdcmPixelConvert
90 Substituted File::ParsePixelData() with PixelConvert::Print() new
92 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
93 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
94 method to those classes.
95 - src/gdcmFile.[cxx|h]:
96 -- Added a ::Print() method.
97 -- PixelConverter is now a reference instead of a member.
98 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
99 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
101 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
102 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
103 collaboration diagram and inheritance diagram should be generated with
105 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
106 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
107 pointlessly wrapped (see
108 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
109 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
110 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
111 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
112 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
113 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
114 -- File::Initialise: PixelConverter setup moved away to
115 PixelConverter::GrabInformationsFromHeader()
116 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
117 interpretation moved away to PixelConverter::BuildRGBImage()
119 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
120 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
121 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
123 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
125 displayed on Win32 when a brutal abort() occurs (because of uncatched
126 exception). See TODO new entry of this commit for more on this.
127 * TODO added new entry.
128 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
129 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
130 - HandleColor is no longer called from gdcmFile.cxx
131 - gdcmPixelConvert.cxx clean up on method arguments and internal
132 variable names for semantical coherence.
134 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
135 * Finished lossless transition, not only do we now read all lossless jpeg
136 images, without the need of the Cornwell lib, but we do read them properly now
137 * To reduce code (well to avoid code duplication), I defined a common place
138 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
139 redefine symbols. This is not prefect but this the best solution I found for a
140 compilation time jpeg option.
142 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
143 * Update jpeg ijg lib to support lossless jpeg implementation
144 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
146 * Also added a special copyright for dcmtk since we use their bugfixes.
149 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
150 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
151 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
152 matters, as stated in warning note at begining of %include section).
153 * src/gdcmDicomDir*.[cxx|h]: coding style
154 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
155 * src/gdcmJpeg8.cxx: doxygen fix.
156 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
157 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
158 from File:: to PixelConvert::.
160 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
161 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
162 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
163 - more code moved away from File:: to PixelConvert::
164 - fat setup of PixelConverter set in place in File::Initialise.
166 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
167 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
168 namespace at the file system level. So now you should convert your examples
170 gdcmHeader -> gdcm::Header
171 It would be nice if people keep in mind to no open the namespace, since it
172 allows compilation on broken plateform which were defining common symbol in
173 the standart namespace (like LP, Unknown ...)
175 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
176 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
177 The JPEG fragments are now parsed at the same stage than the RLE
178 information. All code related to JPEG is now in gdcmPixelConvert:
179 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
180 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
181 export a gdcmFile:: method. Those are simply global functions
182 (for the time being this is better than having them attach to
183 either gdcmFile:: or gdcmPixelConvert::).
184 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
185 and stores the result in a gdcmJPEGFragmentsInfo.
186 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
187 code (among other stuff) moved away from gdcmFile:; to
190 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
191 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
192 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
193 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
194 clean up of RLE related code.
195 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
196 - src/gdcmRLE.cxx removed
197 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
198 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
199 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
200 * CLEANUP_ROUND (9) for gdcmPixelConvert
201 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
202 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
203 away from gdcmFile:: to gdcmPixelConvert::.
205 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
206 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
207 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
208 This is because Parse7Fe0 used to parse the pixels to compute the
209 length. This task was passed over to FindDocEntryLengthOB() a long
210 time ago, EXCEPT I had forgotten the OW case...
211 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
212 we just recylce the code for parsing RLE fragments and computing
214 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
215 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
216 with the retired Parse7Fe0().
217 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
218 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
220 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
221 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
222 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
223 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
224 - src/CMakeLists.txt: alphabetic order reodering + new entries.
225 * CLEANUP_ROUND (4) for gdcmPixelConvert
226 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
227 to return an unused length.
229 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
230 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
231 this should be cleanner from the plane view. The iostream are erally a pain
232 to use to do simple stuff.
234 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
235 * Redo the compilation of the ijg jpeg library. Now only one source is
236 necesseray. No need to rename file by hand what so ever. CMake handle the
237 copying of the file within different directory, configure header file to
238 modify some symbol. The only addition made to ijg wasd a mangle table so
239 that symbol are different wether we are within 8bits or 12bits.
241 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
242 * Added documentation of vtkgdcmReader on Website:
243 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
244 with it's binary name).
245 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
246 the Website to be more complete.
247 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
248 doxygenated documentation.
249 - Doc/DoxyVtkGdcmReaderExamples.txt added
250 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
251 DoxyVtkGdmReaderExamples.html )
252 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
253 * CLEANUP_ROUND (3) for gdcmPixelConvert
254 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
256 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
257 * CLEANUP_ROUND (2) for gdcmPixelConvert
258 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
260 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * CLEANUP_ROUND for gdcmPixelConvert:
262 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
263 - src/gdcmPixelStuff[h|cxx] removed
264 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
265 - src/CMakeLists.txt changed accordingly
267 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
268 gdcmVersion.py moved to newly created ATTIC related
269 gdcmPython/SetupOldies/ directory.
270 * Autotools clean up:
271 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
272 - autogen.sh configure.in acinclude.m4 python.m4 removed
274 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * src/*.cxx *.h Reference to License.htm fixed to License.html.
276 * Doc/CMakeLists.txt, doxygen.config.in: fix.
277 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
279 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
280 * TODO updated with Mathieu suggestions. I proposed a template for
281 describing TODO entries and used it for new entries.
282 * Added Doc/Website/CodingStyle.html, Developpers.html,
283 DeveloppersPython.html, GdcmDataCvs.html and
284 DownloadVersion0_1.html, DownloadVersion0_3.html.
285 * Some Doc/*.txt Doxygen files (which do not really concern the
286 documentation itself, but the website) moved to html and
287 placed in directory Doc/Website:
288 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
289 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
290 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
291 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
292 * CMakeLists.txt changed accordingly.
293 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
294 DeveloppersPython.html
295 * INSTALL nows refers to Doc/Website/Installation.html
297 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
298 * Added Doc/Website directory, that contains a first raw version
301 2004-09-23 Jean-Pierre Roux
302 * FIX In order not to be poluted any longer by casting problems,
303 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
304 we can now delete[] it safely
305 * VoidArea is now called BinArea (less confusing name),
306 and all the methods called ...VoidArea... are now ... BinArea...
307 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
309 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
311 clear) TagHT, which is an inherited member of gdcmElementSet. It is
312 up to the destructor of gdcmElementSet to clean up TagHt and it's
315 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
316 * Test/CMakeLists.txt: update to follow gdcmData renamings.
317 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
319 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * ENH: added some utility method that builds a flat dictionnary
321 holding all the Dicom entries contained in the recursive structure
322 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
324 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
325 BuildFlatHashTable() that build a flat dictionary.
326 - src/gdcmElementSet.h: added a new private GetTag() accessor.
327 gdcmDocument is now a friend of gdcmElementSet.
328 - src/gdcmElementSet.cxx: clean up.
329 - Example/FlatHashTablePrint.cxx added.
330 - Example/CmakeLists.txt changed accordingly
332 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
334 moved away from gdcmDocEntrySet (since this class is an abstract class
335 acting like an interface). SQDepthLevel and BaseTagKey are now
337 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
338 and associated accessors. Doxygenation of the class.
339 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
341 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
342 Use SQDepthLevel accessor instead. ::Print() adapted.
343 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
344 - src/gdcmDocument.cxx changed accordingly.
346 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
347 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
348 - The following is the doxygen comment of the typedef declaration
349 of gdcmagKey in src/gdcmCommon.h:
350 gdcmTagKey is made to old an "universal" (as in URL, Universal
351 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
352 A dicom tag allways has a group and an element, but a set of tags
353 embeded in various (optionally nested) sequences and sharing
354 the same group and element all share the same (group, element)
355 "identifier". Hence the (group, element) cannot be used as an
356 identifier (in gdcm we shall refer to a "TagKey") of a tag.
357 In order to construct a proper tag identifier (i.e. a key) we
358 consider the following definition of a TagKey:
359 - let Group, Element be the string representation of the
360 group and element dicom tag members,
361 - let ItemNumber be the string representation of the integer
362 index of the considered item number of a sequence,
363 Let the key of a tag embeded in a sequence, noted SeqTag, be
365 /ItemNumber#Group|Element
366 where "/", "#" and "|" are characters acting as separators.
367 Then the general form of a gdcmTagKey is given by:
368 Group|Element<SeqTag>
369 where <SeqTag> means NO or many instances of SeqTag.
370 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
373 but the gdcmTagKey of a tag "embeded" is the first item of
374 a sequence, itself nested in the third item of a sequence is the
376 0004|1220/2#0008|0082/0#0008|0090
377 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
378 order to hold the new sequence compatible key. Previously, the
379 GetKey() method would look in the underlying gdcmDictEntry.
380 - src/gdcmDocEntry.cxx:
381 -- constructor now copies the underlying DictEntry key, in the local
383 -- ::Print: displays the member Key, instead of the (group, element).
384 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
385 - src/gdcmDocEntrySet.h:xi
386 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
387 -- now has a new BaseTagKey member.
389 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
390 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
392 This poses the problem with the semantics of the following lines
393 LoadEntryVoidArea(0x0028,0x1201); // R LUT
394 LoadEntryVoidArea(0x0028,0x1202); // G LUT
395 LoadEntryVoidArea(0x0028,0x1203); // B LUT
396 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
397 to the long FIXME note for what the problem is. Nevertheless in
398 order to get things working the dicom dictionary was altered !
399 Please fix things urgently...
400 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
401 information), see above note on moving the member VoidArea. Nevertheless
402 the following entries previously correctly set as US are now inproperly
404 0028 1201 OW IMG Red Palette Color Lookup Table Data
405 0028 1202 OW IMG Green Palette Color Lookup Table Data
406 0028 1203 OW IMG Blue Palette Color Lookup Table Data
407 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
408 of gdcmDocEntry moved to gdcmSeqEntry.
409 * src/gdcmSeqEntry.cxx: STYLE.
411 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * Test/TestAllEntryVerify.cxx minor fix and added comments.
414 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
415 * gdcmPython/testSuite.py: all the test suite in python is now moved
416 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
417 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
418 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
420 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
421 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
422 to avoid inclusion recursion until STL is reached.
423 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
424 mecanism. errno.h is not included in gdcm anymore.
425 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
426 (gdcmFormatError now inherits from gdcmFormatUnexpected).
428 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
429 gdcmData/TestAllEntryVerifyReference.txt
430 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
431 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
432 exception_on_error parameter.
433 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
434 - vtk/vtkGdcmReader.cxx changed accordingly,
435 - Example/*.cxx and Test/*.cxx changed accordingly.
437 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
439 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
440 enable_sequences removed from gdcmHeader constructor and dependencies.
441 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
442 * gdcmPython/demo/PrintHeader.py: dummy fix.
443 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
444 skip_shadow removed from gdcmHeader constructor and dependencies.
445 * Example/*.cxx and Test/*.cxx changed accordingly.
447 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
449 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
451 2004-07-21 Jean-Pierre Roux
452 * FIX Now, Parsing and Printing a DICOMDIR do work!
453 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
455 2004-07-20 Jean-Pierre Roux
456 * FIX Some brain damaged headers have Zero-Lenght fields
457 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
459 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
461 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
462 variable (instance of gdcmDebug) by a definition macro, and the instance
463 is now in static in the gdcmDebug class
464 * src/gdcmSQItem.h : (FIXME) remove an undefined method
465 * Test/PrintAllDocument.cxx : bug fix in the result of the test
467 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
468 * WARNING: ctest now depends more tightly on gdcmData. You should
469 check out gdcmData properly for things to run smoothly...
470 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
471 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
472 we need the pixels not be loaded in order to use the ValEntry
473 that displays position and size).
474 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
475 This is a C++ based equivalent of gdcmPython/testSuite.py that should
476 be deprecated. If you have any doubts about the advantages of a
477 modern scripting language (read Python) versus grass root C++ (i.e.
478 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
479 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
480 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
481 Anyhow, consider documenting the gdcmData images in
482 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
484 * Test/CMakeLists.txt:
485 - now uses TestAllEntryVerify.cxx
486 - specific comments on oldACR00001.ima (now renamed in gdcmData
487 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
488 gdcmData/TestAllEntryVerifyReference.txt
491 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * src/*.[h|cxx] : typedef clean up
493 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
494 - TagKey renamed to gdcmTagKey (for external usage)
495 - VRKey renamed to gdcmVRKey (for external usage)
496 - removal of typedef duplication.
497 - Removed all unecessary inline keyword from class inline definitions.
498 - Some method|function(void) declarations replaced with method|function().
499 * src/jpeg/libijg12/jdhuff12.c:
500 - printf polluting ctest removed.
501 - TAB removal for comminting
503 - TestAllReadCompareDicom.cxx: added a test that compares all the
504 images in gdcmDataImages.h with corresponding images in
505 gdcmData/BaselineDicom/. When baseline images are not present
506 this test creates them.
507 Note: we need to validate each reference image, but before that
508 I'd like to rename them with a more explicit name...
509 - CMakeLists.txt: changed accordingly.
510 * Example/*.cxx: examples now only include gdcm.h (as opposed to
511 including each header needed).
513 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * Test/*.cxx and Example/*.cxx: moved some examples away from the
515 test suite to the Example directory. Are concerned:
520 - TestWriteSimple.cxx
521 * Test/CMakeLists.txt: added some comments on reasons for black listing
522 image gdcmData/oldACR00001.ima
524 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
525 * Test/CmakeList.txt: removed the following from black list (to be coherent
526 with removal from gdcmData):
527 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
528 - gdcm-MR-PHILIPS-16.dcm
530 Added the following because after last cvs update, they cause
531 ctest -R TestReadWriteReadCompare
533 - gdcm-MR-SIEMENS-16-1.acr
535 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
536 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
537 new comments in this file) we temporarily (sigh) move to a weaker
539 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
540 we don't need to black list the following images anymore:
541 - 8BitsUncompressedColor.dcm
543 - US-PAL-8-10x-echo.dcm
544 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
545 fixes and the beautified code ;-)
546 This fixes the bug introduced in version 1.42 (when beautifying)
547 that made the parsing of 8BitsRunLengthColor.dcm unproper.
548 Note: ctest was blind to this bug (this means we need to still
549 improve the test suite). The bug could be detected by using
550 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
552 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
553 and by displaying the (garbage) produced file temp.XDCM...
555 2004-06-29 Jean-Pierre Roux
556 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
557 - replace by uggly but working old code :-(
558 A lot of things should be OK again.
559 It's really urgent to have a test suite that *tests*,
560 to prevent Frog's beautifying sessions to break all the stuff
561 (twice, withing a fortnigh ...)
563 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
564 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
565 redundancy) to added Test/TestReadWriteReadCompare.cxx
566 * Test/CmakeList.txt: because the compare test of
567 Test/TestReadWriteReadCompare.cxx fails, the following images are
568 black listed: - 8BitsUncompressedColor.dcm
570 - US-PAL-8-10x-echo.dcm
571 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
572 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
573 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
574 and ad-hoc kludge. This kludge is now removed, and on encountering
575 such an image (OB field brain damaged) we set errno. Then in
576 ::FindDocLength() we "fix" the length as being ALL what remains
577 in the file (until EOF). We then proceed, hoping for the best...
578 This fixes a SegFault in ShowDicom when trying to write such an
580 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
581 (because TestWriteRead breaks on it, after a non conformal commit?).
582 ctest now runs properly, except for MakeDicomDir (which was allways
583 broken) and the Python related stuff (still not fixed).
585 2004-06-24 Jean-Pierre Roux
586 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
587 FIX : Test/TestReadWrite now iterates on all the file names
588 (instead of infinite loop)
589 ENH : Test/TestWriteRead now iterates on all the file names
591 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
594 2004-06-24 Jean-Pierre Roux
595 FIX : - now Write drops LUT Descriptors and LUTs (if any)
596 when SamplesPerPixel =3
597 - now Write is no longer confused by
598 'BitsAllocated = 12" and 'BitsStored=12"
599 - "UN" value representation Elements are now written correctly
600 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
601 ENH : - now gdcmHeader has its own Write methods
602 (in order to split the job that has not to be done
605 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
607 loop on the same image until memory went out.
608 Note: this means we still have gobs of memory loss in PrintDocument
609 * src/gdcmDocument.cxx: fixes problem on parsing on file
610 gdcmData/16BitsJpegLosslessGrayScale.dcm.
612 2004-06-24 Jean-Pierre Roux
613 FIX : Write - All the Sequences and Sequence Item are now written
614 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
615 is added a the end, when necessary.
616 - A lot of brain-damaged images, that were read correctly are
617 now written correctly
618 - length compatible BinEntry are now loaded correctly
619 (even for odd groups)
620 Note : only Explicit Value Representation was checked.
621 (question : is implicit VR really necessary for gdcm ?)
623 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
624 * DEVELOPPER: added a proposition of coding style.
625 * src/gdcmDocEntry.h: removed every inline declaration (for test of
628 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
629 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
630 Use the gdcmDocEntry::Print() and Write() instead.
631 * src/gdcmDocument.cxx: bug fix.
633 2004-06-22 Jean-Pierre Roux
634 FIX : gdcmDocument.cxx
635 - Now we do recognize the JpegLossLess format (there was a misstyping in
636 code 'beautyfication' :-(
637 - Now we automaticaticaly load the Luts, if any
639 2004-06-22 Jean-Pierre Roux
640 In order : to write Sequences, whatever their imbrication level,
641 : to allow user to create his own Sequences
642 a lot of modif where necessary (adding, moving, or virtualising methods)
644 WARNING : save your own sources *before* cvs up !
647 ADD virtual void Write(FILE *fp, FileType filetype);
650 ADD virtual void Write(FILE *fp, FileType filetype);
651 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
654 ADD virtual void Write (FILE *fp, FileType filetype)=0;
655 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
656 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
657 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
658 ADD std::string GetEntryByName(TagName name);
659 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
661 std::string vr = "unkn",
662 std::string fourth = "unkn",
663 std::string name = "unkn");
664 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
665 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
666 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
667 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
668 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
669 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
670 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
671 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
674 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
675 ADD virtual std::string GetEntryByName (TagName tagName);
676 ADD virtual std::string GetEntryVRByName (TagName tagName);
677 REM virtual bool Write(FILE *, FileType);
678 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
679 FILE *_fp, FileType type);
680 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
681 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
682 REM virtual bool WriteEntries(FILE *_fp,FileType type);
683 REM virtual std::string GetEntryByName (std::string tagName);
684 REM virtual std::string GetEntryVRByName (std::string tagName);
685 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
686 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
687 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
689 std::string vr = "unkn",
690 std::string fourth = "unkn",
691 std::string name = "unkn");
692 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
693 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
694 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
695 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
698 ADD virtual void Write(FILE *fp, FileType filetype);
701 ADD virtual void Write(FILE *fp,FileType filetype);
704 ADD virtual void Write(FILE *fp, FileType filetype);
705 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
706 REM std::string GetEntryByNumber(guint16 group, guint16 element);
707 REM std::string GetEntryByName(TagName name);
710 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
712 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
713 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
714 The default constructor invoked by the line
715 gdcmHeader *f1 = new gdcmHeader( header );
716 was gdcmHeader::gdcmHeader(bool) instead of the expected
717 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
718 Hence the parsing wasn't executed... See also below.
719 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
720 as explicit constructor didn't do the trick to fix the above problem.
721 Could anyone explain why ?
722 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
723 properly calls gdcmValEntry::Print() (that was weed out from
724 code related to gdcmBinEntry).
726 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
727 * In order to fix memory leaks:
728 - Test/TestWriteSimple.cxx: added cleaning of free store through
730 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
731 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
732 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
733 (through the call to ::AddDicomDirMeta()) or the destructor
734 would crash when deleting uninitialized ::metaElems].
735 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
736 - src/gdcmDocument.cxx:
737 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
739 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
740 was causing memory leaks.
741 - src/gdcmSQItem.cxx:
742 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
743 cleanly handled with polymophism: sorry but my milage is low).
744 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
745 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
746 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
747 This avoids SegFaulting.
748 - src/gdcmSQItem.h: coding style.
750 - Test/TestWriteSimple still severely sucks. The output image content
751 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
752 damaged when displayed with vtkgdcmViewer.
753 - on memory leaks: TestWriteSimple leaks really less (see entry
754 of 2004-06-18 in Changelog file for the call to valgrind).
755 - on segfaults: ctest now passes all the tests but one (no more
757 * Erroneous leading white fix:
758 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
759 white[s] (as opposed to from >> xxx, that removes it [them].
760 - src/gdcmTS.cxx: ditto.
761 - gdcmPython/testSuite.py: dirty related kludge removed.
762 * src/*: remaining references to gdcmParser removed.
763 * src/*[cxx|h]: added copy[way]left header.
766 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * In order to fix writing of dicom files:
768 - Test/TestWriteSimple.cxx: a simpler example of writing.
769 - Test/CMakeLists.txt changed accordingly.
770 - src/gdcmDocument.cxx:
771 -- The destructor now recursilvely removes potential sequences.
772 -- Bug fix in ::IsJPEG2000()
773 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
774 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
776 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
777 to only declared) and build on top of
778 ::GetDocEntryByNumber(guint16, guint16).
779 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
780 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
781 for usage in destructor and treatement of promotion in
782 ::ReplaceOrCreateByNumber().
783 - src/gdcmSQItem.cxx: destructor should better handle his job.
784 Test/TestWriteSimple now runs (or at least it DOES something).
785 * We can now start hutting memory links. A good starting point is:
786 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
787 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
788 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
790 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * Valgrind note: after Mathieu Malaterre teached me how to read
792 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
794 Using gcc, you can force the STL to use malloc and to free memory as
795 soon as possible by globally disabling memory caching.
796 With 3.2.2 and later, you should export the environment variable
797 GLIBCPP_FORCE_NEW before running your program.
798 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
799 simply vanish (it is still not clear to me, whether this means that
800 STL std::string leaks or if valgrind believes it leaks...).
801 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
802 running bin/gdcmTests makeDicomDir):
803 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
804 - Test/makeDicomDir.cxx now properly traps empty lists and returns
806 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
807 SegFaulting (I drowned in DicomDir related code when trying to
808 understand why the list is empty...).
809 * src/gdcmDocument.h: first BSD license header try.
810 * Doc/License.txt added.
812 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * src/gdcmDocument.[h|cxx]:
814 - Clean up of the Transfer related predicates. They are now all based
815 on new method isGivenTransferSyntax, that (should) handle properly
817 - general clean up, simplification, and coding style.
818 - Specific clean up of Parse7FE0() (umproperly named actually).
819 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
821 2004-06-14 Jean-Pierre Roux
823 - fix the display of Sequence Delimitor (SQDepthLevel pb)
824 - fix the display of SQItem ordinal number
825 - add the GetSQItemByOrdinalNumber method
826 - remove some useless never written private methods
828 2004-06-14 Jean-Pierre Roux
830 - adding a constructor taking a gdcmDocEntry as an input param
831 - ReplaceOrCreateByNumber now returns :
832 a gdcmBinEntry * if a Binary (void *) value is passed as a param
833 a gdcmValEntry * if a string value is passed as a param
835 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
836 according to the param type (no longer sets a gdcmDocEntry)
837 - GetValEntryByNumber, GetBinEntryByNumber added
838 - NewValEntryByNumber and NewBinEntryByNumber added
840 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
842 - GetSQItemNumber and SetSQItemNumber added, to provide
843 a (relative) Item identier inside a given Sequence
844 \warning : some pb remaining around this number
846 - AddEntry now takes the Item Number as a param
848 - adding a constructor taking a gdcmDocEntry as an input param
850 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
851 * Memory leak hunt with the following command:
852 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
853 --show-reachable=yes gdcmTests PrintDocument
854 It looks like many (all?) leaks are due to the STL (or a bad usage
855 of the STL. The lines producing the leaks now have a comment with
856 a "MEMORY LEAK" tag: you can retrieve them with
857 grep "MEMORY LEAK" src/*
858 Here are two typical examples which I can't help fixing:
863 char * test = "babo";
864 name = test; //// <--- valgrind detects 960 bytes lost in
865 //// call to std::string::operator=(char const*)
866 name.clear(); //// Doesn't help !
874 std::cout << "Type a bunch of characters followed by RETURN: ";
875 getline(std::cin, line); //// <--- valgrind dectects a loss
876 //// of 1320 bytes in call to
877 /// std::basic_istream<>& std::getline<>
883 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
884 * src/gdcmHeader.[cxx|h]:
885 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
886 and related, moved away to gdcmDocument.
887 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
888 the corresponding protected accessors of inherited class
889 gdcmDocument, removed ! As a consequence gdcmFile had to be
890 declared friend of class gdcmDocument (see below).
891 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
892 - Clean up of undefined or unused methods.
893 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
894 account the changes to gdcmHeader.h).
895 * src/gdcmDocument.h:
896 - gdcmFile is now a friend class (in order to take into account the
897 changes to gdcmHeader.h).
898 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
899 (see changes to gdcmHeader.h).
900 - Accessors (reading on the form GetEntry*) are now public.
901 - Clean up of undefined or unused methods.
902 * src/gdcmDocument.cxx:
903 - adaptation to changes to gdcmDocument.h
904 - ::OpenFile now writes a verbose message when file cannot be opened.
905 - some std::string properly set to VRKey
906 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
907 references to gdcmDocument.
908 * Test/TestFindTags.cxx: changed accordingly to above changes.
909 * gdcmPython/testSuite.py: adapted to renaming of acr files in
910 cvs repository gdcmData.
912 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
913 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
914 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
915 conflicts with gdcmValEntry::voidArea.
916 * src/gdcmValEntry.cxx: unmatching comment wiped out.
917 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
918 Value representation between StringRepresentable and BinaryRepresentable.
919 * src/gdcmDocument.cxx:
920 - method ParseDES: proper indentation restored and usage of
921 gdcmVR::IsVROfGdcmStringRepresentable wired in.
922 - method LoadDocEntry: the fingerprint left in the SetValue() of
923 unloaded entries (length > MaxSizeLoadEntry) had curiously been
924 removed. Reverting to previous code segment with the proper
925 dynamic_cast< gdcmValEntry* >.
926 Note: this was (partially) breaking the python test suite
927 (gdcmPython/testSuite.py) that made usage of the above
928 fingerprint to check presence of "Pixel Data".
929 * src/gdcmDocEntry.h: coding style.
930 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
931 now taken into account.
932 * gdcmPython/gdcm.i: adaptation to the new internal representation
933 of gdcm (exit gdcmParser, hello gdcmDocument).
934 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
936 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
937 anymore, but instead prints the loaded Python dictionary.
938 * .... alas, the python testSuite is still broken.
940 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
941 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
943 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
944 * src/gdcmUtil.h : export methods
946 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
947 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
949 * Initial addition of automatic python testing
950 * Initial addition of automatic image comparison
952 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
953 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
954 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
956 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
957 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
958 * Test/ShowDicom.cxx : bug fix for msvc compilation
959 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
961 2004-05-04 Jean-Pierre Roux
962 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
963 new concepts (and new classes) :
964 a 'gdcmDocument' is composed of a set of Doc Entries, that are
965 - elementary gdcmDocEntries (former gdcmHeaderEntries)
966 - Sequence Doc Entries (gdcmSeqEntries)
967 a Sequence is composed of Items.
968 Each item is a set of Doc Entries (this is recursive)
969 The non uniqueness of the 'Dicom tag' is due to this recursivity
970 (never taken into account)
971 Our unability to add a new 'entry' in the header
972 at the proper location (neither in the H-Table (map or multimap),
973 nor in the Chained List is also due to this recursivity.
974 Don't try, right now, to use/modify/compile these new sources :
976 We just commit all the stuff, 'as is', in order not to loose it.
978 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
979 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
981 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
982 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
983 file prefix (SetFilePrefix)
985 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
986 * Add a new test: ShowDicom, for now this is just the c++ version of
987 checkRead.sh, later it will be able to compare the image read against a
989 * Replace the DEBUG on the stack with a global entry in cmake interface:
990 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
992 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
993 * Add an example subdir, with a real example on how to read + write a
996 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
997 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
998 * Doc/CMakeLists.txt: the main page is now properly differentiated
999 between the developper and user version.
1000 * Doc/doxygen.config.in: dropped search related obsolete flags
1001 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1003 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * DEVELOPPER: added some helpfull comments for compile/test/install
1007 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1008 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1009 src directory, now generated in the build dir.
1010 2. Tests as mentionned smarter
1012 4. Add a new method in gdcmDict that return the PubDict by name
1013 this is interesting for 3rd party lib like ITK,
1014 where we could set the institution name / patient name...
1016 * ENH: 1. Now the test suite is working for real
1017 2. All binaries are now output in the gdcm-bin directory
1018 (this was not true before)
1020 2004-04-28 Jean-Pierre Roux
1021 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1022 SeQuence indented printing of Dicom Header.
1023 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1024 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1025 Computation of SQDepthLevel is now part of gdcmHeader constructor
1026 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1027 tree-like structure of a Dicom Header.
1028 * FIX Test code cleaning
1030 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1031 * ENH: Adding automatic testing
1032 1. Need a DartConfig.cmake to submit to public
1033 2. Add a test driver gdcmTest.cxx
1034 3. gdcmTestMain, an helper for the main test driver gdcmTest
1035 4. Files in Test don't have a main anymore, this becomes interesting
1036 when we add more and more tests, thus dsw don't have to load
1038 * ENH: Adding a GDCM_DATA_ROOT for testing
1039 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1040 one file instead of seven + some small cleanup
1042 2004-04-22 Jean-Pierre Roux
1043 * ENH Minor changes to the Print() methods.
1044 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1045 Header printing. Example given with :
1046 > PrintHeader fileName 2 new
1047 (SQ based tree-like structure still to be done for the Header ...)
1049 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1050 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1051 1. I have added some unsigned where needed
1052 2. Some function parameter not used -> (void)
1053 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1054 4. g++ don't like character '\' in comment
1055 5. #define jpeg_create_decompress jCreaDecompress
1056 this really need to be fixed
1057 6. virtualize destructor of gdcmObject ... leakage
1058 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1059 this also really need to be fixed
1060 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1061 remove compression file
1062 (as we only do decompression, right ?)
1063 * ENH: Change malloc/calloc/free with c++ equivalent
1065 2004-04-21 Jean-Pierre Roux
1066 * FIX gdcmHeaderHelper::GetXSpacing
1067 when a single value is found (bug ?), xpacing is now
1068 defaulted to yspacing
1070 2004-04-19 Jean-Pierre Roux
1071 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1072 * ENH add parameters :
1073 bool exception_on_error = false,
1074 bool enable_sequences = false,
1075 bool ignore_shadow = false
1076 to the gdcmFile constructors to be full gdcmParser compliant
1077 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1078 to allow reading of PAPYRUS 3.0 files
1080 2004-04-06 Jean-Pierre Roux
1081 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1083 2004-04-02 Jean-Pierre Roux
1084 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1085 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1086 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1088 2004-03-30 Jean-Pierre Roux
1089 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1090 for ACR file, written out as DICOM files (hope so...)
1092 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1093 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1094 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1095 moved to base class gdcmParser and only the specialisation is kept
1097 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1098 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1099 already does the job.
1100 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1101 (to be consistent with gdcmParser::WriteEntries).
1103 2004-03-30 Benoit Regrain
1104 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1105 upate of the object's instance. It's passed to 2 in the unfavorable
1106 case : one in the ExecuteInformation, one in the ExecuteData
1108 2004-03-29 Jean-Pierre Roux
1109 * ENH : Check on file type to be written moved
1110 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1111 * FIX : gdcmObject::ResetBoundaries now stops properly
1112 when end-of-list is reached
1113 : gdcmVersion modified (as Benoit Regrain asked)
1115 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1116 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1117 * src/gdcmUtil.cxx: added forgotten iostream include.
1118 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1119 equivalent to ExplicitVR in existing code).
1121 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1123 now contains all the gdcmGlobal related code.
1124 * minor coding style and doxygenation changes.
1126 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1127 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1128 now contains all the Debug related code.
1129 * minor clean-up of includes in src/*.cxx
1130 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1131 CreateCleanString) removed.
1132 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1133 * Doc/DoxyMainPageUser.txt added.
1134 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1135 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1136 src/gdcmDirList.cxx)
1138 2004-03-24 Jean-Pierre Roux
1139 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1141 2004-03-23 Jean-Pierre Roux
1142 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1143 big endian made volumes
1144 * ENH Now gdcmParser constructor and destructor are protected to forbid
1145 end user to instanciate class gdcmParser
1146 (only gdcmHeader and gdcmDicomDir are meaningfull)
1148 2004-03-22 Benoit Regrain
1149 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1150 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1151 gdcmSerie to gdcmDicomDirSerie
1153 2004-03-19 Jean-Pierre Roux
1154 * ENH Now the tree-like structure describing a DICOMDIR comming from
1155 an already existing DICOMDIR file is consistent with
1156 the home-made tree-like structure build ex-nihilo
1157 or build from the files held (recursively) in a Directory
1158 functions gdcmDicomDir::CheckBoundaries()
1159 gdcmObject::SetBoundaries() added
1161 2004-03-17 Jean-Pierre Roux
1162 * REM (Eric Boix bug) : removal of meaningless
1163 gdcmDicomDirImage::NewImage function.
1164 * FIX now file names and directory name are written properly in the
1166 * FIX now gdcmDicomDir constructor may be call without any trick
1169 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1170 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1171 of gdcmDicomDirImage::NewImage as empty function.
1173 2004-02-28 Jean-Pierre Roux
1174 * ENH add gdcmDicomDir:NewPatient
1175 add gdcmDicomDirPatient:NewStudy
1176 add gdcmDicomDirStudy:NewSerie
1177 add gdcmDicomDirSerie:NewImage
1178 to allow making gdcDicomDir object.
1179 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1180 (as opposite to the gdcmHeader chained list)
1182 2004-02-11 Benoit Regrain
1183 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1184 when using from python
1186 2004-02-10 Benoit Regrain
1187 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1188 * FIX : in gdcmDicomDir when the directory is empty
1189 * ENH : add callback and methods to get the progression of dicomDir
1192 2004-02-06 Jean-Pierre Roux
1193 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1194 - GDCM_META added to gdcmDicomDirType
1195 - class gdcmMeta created
1196 * ENH : - A brief summary is now displayed at the beginning of
1197 'testDicomDir' to help disaster magnitude estimation
1198 * REM : Now useless Test/explDICOMDIR.cxx
1200 2004-02-05 Benoit Regrain
1201 * ENH : add methods in gdcmObject to get the hash table or the list of
1203 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1204 * FIX : wrapping python for TagHeaderEntryHT
1206 2004-02-04 Benoit Regrain
1207 * FIX : even length for some strings when writting the dicom dir
1208 * FIX : sort the images in the dicom dir
1209 * FIX : Bug fix for python use of dicom dir
1210 * ADD : a python demo
1212 2004-02-04 Jean-Pierre Roux
1213 * FIX : Final solution (?) for icone embedded images
1214 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1215 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1216 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1217 gdcmData/gdcm-MR-SIEMENS-16.acr1
1218 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1219 to make full checking easier
1221 2004-02-04 Benoit Regrain
1222 * FIX : WriteEntries : coding style & logic in parameters
1223 * FIX : Set the elements to create the DicomDir in a dictionary file
1225 2004-02-03 Benoit Regrain
1226 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1227 * gdcmDicomDir : add the load of directory
1228 * Bug fix and print add-on
1230 2004-02-03 Jean-Pierre Roux
1231 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1232 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1233 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1234 * FIX gdcmParser.cxx : 'group length' elements are now considered
1235 as integers, even for shadow groups, when file is Implicit VR
1237 2004-02-02 Jean-Pierre Roux
1238 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1240 of the last synonym :-(
1241 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1243 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1244 * FIX taking into account the possible 7fe0,0010 multiplicity
1245 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1246 to allow removal of references to 7fe0,0010, to deal with
1247 ACR-NEMA images, when 0028,0200 is meaningfull
1249 2004-01-31 Jean-Pierre Roux
1250 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1251 no longer writes 'Un' on disk
1252 * FIX SQ elements with actual length are now dealt with corectly
1253 * FIX gdcmFile::WriteBase make the difference, for color images, between
1254 the length (for Palette expanded images)
1255 and Raw Length (non expanded image + Palette)
1256 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1257 (that broke Write). Replaced by UL.
1258 Aware user will reload the field if he
1259 thinks it's necesssary
1261 2004-01-30 Jean-Pierre Roux
1262 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1263 when 'dirty Acr' is found, to be compliant with the new
1264 IsReadable() methods.
1266 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1267 (no DOUBLE images in kosher DICOM,
1268 but so usefull for people that miss them ;-)
1270 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1271 DICOMDIR related utilities (not checked as Windoze compliant)
1273 2004-01-28 Jean-Pierre Roux
1274 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1276 2004-01-27 Jean-Pierre Roux
1277 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1278 to allow skipping the shadow elements, to save memory space.
1279 The TRUE value for this param has to be used
1280 with a FALSE value for the 'enable_sequence' param.
1281 ('public elements' may be embedded in 'shadow Sequences')
1282 * gdcmHeader methods now deal with 'embedded icones images' in the header
1283 (even when an 'icone image sequence' is announced by the
1284 element (0x0088,0x0200), but there is NO icone at all ...
1286 * gdcmHeader sometimes Image Location value doesn't follow
1287 the supposed processor endianity (see gdcmData/cr172241.dcm).
1290 * gdcmHeader add the method
1291 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1292 to get *all* the Header Entries with the same tag.
1293 GetHeaderEntrySameName is probabely *useless*
1294 (no meaning : Name is *not* an identifier within the Dictionnary)
1296 2004-01-26 Benoit Regrain
1297 * Bug fix in the print of hexadecimal representations. Remove long fields
1298 in the print and add a third level of print to print them
1300 2004-01-23 Benoit Regrain
1301 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1302 * Bug fix on test suite after remove the strip made on not string fields
1303 * Split the IsReadable method between gdcmParser which test that the file
1304 is dicom and gdcmHeader which test that it's an image file
1306 2004-01-22 Benoit Regrain
1307 * DicomDir : clean code, add methods, set variables in protected or private
1308 * gdcmUtil : bug fix for the clean string method
1310 2004-01-19 Benoit Regrain
1311 * Add the use of shadow dictionaries
1312 * bug fix and coding style
1314 2004-01-19 Benoit Regrain
1315 * src/gdcmFile.cxx : bug fix concerning the close of file
1316 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1317 * Add the update of header entries using the shadow library
1319 2004-01-19 Benoit Regrain
1320 * removal of file gdcmHeader2.cxx
1321 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1322 inheriting from gdcmParser. This split is to prepare the integration
1323 of dicom dir parsing
1324 * bug fix under python
1326 2004-01-16 Jean-Pierre Roux
1327 * REM removal of class gdcmHeaderEntrySet
1328 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1329 * ADD add file gdcmHeader2.cxx
1330 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1332 2004-01-15 Benoit Regrain
1333 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1334 entries created while parsing the header. Thus, they will be destroyed
1335 when the gdcmDictSet will be destroyed
1336 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1339 2004-01-15 Benoit Regrain
1340 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1341 made a fatal error because of the memory release at the end of program.
1342 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1343 some memory and vtk seems to have some problems with that.
1344 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1346 2004-01-14 Benoit Regrain
1347 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1348 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1349 * src/*.[h|cxx] : make changes due to class name changes
1350 * gdcmPython/demo/*.py : bug fix due to method names
1352 2004-01-13 Benoit Regrain
1353 * src/*.[h|cxx] : coding style
1354 * vtk/*.[h|cxx] : coding style
1356 2004-01-13 Benoit Regrain
1357 * gdcmPython/testSuite.py : test the readable flag of file for tests
1358 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1359 It's lied to the stl compilation by MSVC (windows, always windows...)
1360 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1362 2004-01-12 Benoit Regrain
1363 * src/*.h : add comments
1364 * src/gdcmDictSet.h : set the method BuildDictPath in public
1365 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1366 directly setted in the source code
1367 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1370 2004-01-09 Benoit Regrain
1371 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1372 * setup.py : use a reference to gdcmVERSION
1374 2004-01-07 Benoit Regrain
1375 * Modification to compile with the distutils.
1378 2003-12-10 Benoit Regrain
1379 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1380 can use a gdcmHeaderHelper to load datas
1381 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1382 made in the source code
1384 2003-12-10 Benoit Regrain
1385 * Update Windows projects and .cvsignore files
1387 2003-11-12 Jean-Pierre Roux
1388 * ENH gdcmHeader constructor has one more parameter (default value : false)
1389 that allows the user to 'go inside' the SeQuences only
1391 gdcmElValSet:Print takes it into account
1393 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1394 * ENH: Update gdcmPython/CMakeLists
1395 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1396 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1398 2003-11-10 Jean-Pierre Roux
1399 * FIX : gdcmHeader::LoadElements is now based
1400 on the ListTag listElem member,
1401 not longer on the TagElValueHT tagHt member
1402 * ENH : PrintPubElVal shows (temporarily) both results,
1403 with the tagHt member and the listElem member.
1404 (it's easier to 'see' the problems when using Printheader)
1406 * FIX : old private member LgrElem is now splitted into
1407 ReadLength : Length actually found on disk (updated only
1408 if bug fixing is necessary), for internal
1410 UsableLength : Updated by FixFoundLength, to fix a bug
1411 or to allow Parser going on.
1412 Will allow to re-write a kosher header when a SeQuence
1413 with a length (not 0000) is found
1414 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1415 because gdcmElValSet::Add does not update ListElem
1418 2003-11-07 Jean-Pierre Roux
1419 * FIX misstyping in Transfert Syntax name table
1420 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1421 when they have an actual length (not 0000 nor FFFFF)
1422 (Nobody should care of it, but DICOMDIR explorers)
1424 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1425 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1427 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * ENH: vtkGdcmReader now supports LUT !
1429 (vtkgdcmViewer for now is not able to use them though)
1431 2003-11-05 Jean-Pierre Roux
1432 * in testSuite.py : new files names for checking the package
1433 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1434 that returns the pixel area size to the *aware* (vtk) user
1435 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1437 2003-11-05 Benoit Regrain
1438 * in testSuite.py : Modify the rules for checking the paths
1439 : Explicit error messages
1440 * in __init__.py : Related modif
1442 2003-11-03 Jean-Pierre Roux
1443 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1444 to be used by aware (vtk) users that want to manage
1445 LUT (and no to turn the PALETTE image into an RGB pixels one)
1446 * GetPixelType now returns 8U for 24 Bits images
1447 (vtkGdcmReader compliant)
1449 2003-10-31 Jean-Pierre Roux
1450 * Removal of *all* gdcmData images and add them again
1451 in order to loose the 'history' of un-anonymised images
1453 2003-10-31 Jean-Pierre Roux
1454 * RMV : removal of useless jBitsInJsample.h
1455 for both 8 and 12 Bits JPEG Lossy Libraries
1457 2003-10-31 Jean-Pierre Roux
1458 * ENH : Add the functions gdcmFile::GetImageDataRaw
1459 gdcmFile::GetImageDataIntoVectorRaw
1460 that act as GetImageData and GetImageDataIntoVector
1461 except the making of an RGB Plane from Gray Plane + LUT
1462 Intended to aware (vtk) users who know how to manage
1465 GetLUTRGBA return a R,G,B,A LUT if any
1466 lgrTotaleRaw gives the 'Raw' length
1467 GetImageDataRaw returns the gray Plane
1468 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1469 (They stay Grey, just like with other Dicom viewers :-(
1471 2003-10-30 Jean-Pierre Roux
1472 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1474 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1475 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1476 being coherents dicom files.
1478 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1479 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1481 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1482 * ENH: Two steps is necessary to please VC++ compiler...
1483 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1484 * ENH: Add include dir to medcon lib
1485 * FIX: only one function is being exported for now !
1486 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1488 2003-10-29 Jean-Pierre Roux
1489 * adding gdcmHeader::GetLUTRGBA
1490 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1491 --> Mathieu, the modif u're waiting for is not yet committed
1492 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1494 2003-10-27 Jean-Pierre Roux
1495 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1496 00191113.dcm DermaColorLossLess.dcm
1497 MxTwinLossLess.dcm RadBWLossLess.dcm
1498 * ENH: For version prior to vtkImageViewer2 -r 1.19
1499 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1501 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1502 * Removal of ido stuff in CMakeLists.txt
1504 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1505 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1506 * FIX: remove a call to ->Modified ... see comments
1507 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1509 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1510 * FIX: Problem with path for libvtkgdcmPython
1511 * ENH: Try adding a search script for python site-package
1512 * RMV: Remove some file from medcon lib that are not necessary
1513 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1514 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1515 * FIX: More pragma disable fro VC++,
1516 I don't think I break something as it is also disable in VTK/ITK.
1517 But it fasten debug compilation time.
1519 2003-10-23 Jean-Pierre Roux
1520 * gdcm now deals with 16 Bits Run Length Encoded images
1521 (they are compressed as 2 planes images,
1522 one for the high Bytes, the other for low Bytes)
1524 2003-10-22 Jean-Pierre Roux
1525 * Now CheckRead takes into account :
1526 - the bugged 'Leonardo' Siemens images
1527 - the XA images, sent thru the burning VPRO station
1528 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1531 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1532 * FIX: When copying a Makefile.am to CMakeLists.txt
1533 one should remove the '\'
1535 2003-10-22 Jean-Pierre Roux
1536 * in gdcmData adding a bugged 'Leonardo' Siemens image
1537 (wrong lengths in header)
1538 OK with gdcm, KO with the other viewers :-)
1539 * add a GE dlx XA image, thru the VEPRO burning station
1542 2003-10-21 Jean-Pierre Roux
1543 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1544 for a brutal checking of vtkgdcmViewer compliance
1546 2003-10-21 Jean-Pierre Roux
1547 * add the files for 'xmedcon' Jpeg Lossless library
1548 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1550 2003-10-21 Jean-Pierre Roux
1551 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1553 2003-10-21 Jean-Pierre Roux
1554 * garbage Siemens 'Leonardo' images dealt with
1555 (the patch is easy to remove)
1556 * cosmetic changes to avoid warnings
1558 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1559 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1560 no need to press 'r' now.
1562 2003-10-20 Jean-Pierre Roux
1563 * upgrade of checkRead.sh checkWrite.sh according
1564 to new Jpeg Lossless decompressor
1565 * add US.3405.1.dcm, a genuine RGB medical file ...
1566 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1567 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1569 2003-10-15 Jean-Pierre Roux
1570 * general anonymisation in gdcmData
1571 * adding the 'color files' from
1572 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1573 * adding some well knowed bugged-header images
1574 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1575 waiting for their inclusion in Python testsuite
1577 2003-10-15 Jean-Pierre Roux
1578 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1579 no longer seg faults when file is not found
1581 2003-10-14 Jean-Pierre Roux
1582 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1585 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1586 * TODO: *.in file to genereate a UseGDCM later
1588 2003-10-14 Jean-Pierre Roux
1589 * Some supposed-to-be Dicom Images have no preamble.
1590 OpenFile takes it into account
1591 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1592 * Missing elements added in dicomV3.dic
1593 (just to be affraid : have a look at
1594 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1595 and do it again next year ;->
1597 2003-10-13 Jean-Pierre Roux
1598 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1599 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1600 But there are NOT. It's fixed !
1602 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1603 * FIX: "jpeglib.h" was not found on VC++
1604 * FIX: vtkgdcm was not being installed
1606 2003-10-10 Jean-Pierre Roux
1607 * ENH : OpenFile closes the file if it *really* doesn't look like
1608 an ACR-NEMA / DICOM one.
1609 * FIX : testWrite no longer writes an empty file if the source file
1610 is not gdcm Readable
1611 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1614 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1615 * FIX: CMake generate now documentation
1616 * ENH: out of source doc build !
1617 * ENH: Generate both user and dev documentation
1618 * ENH: Should work on windows too
1619 * ENH: Only one doxygen config.in file is needed
1620 * FIX: make install should be ok now on ùnix plateform
1621 * FIX: PATH to dictionary was wrong (missing /)
1622 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1624 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1625 * vtkGdcmReader is now able to read rgb dicom file.
1626 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1627 * added a gdcmViewer to vtk test, use mouse to control
1628 window level & window width
1630 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1631 * CMake-ification of gdcm, we have now two build system
1632 * FIX: on cygwin Wsock32 doesn't exist
1633 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1635 2003-10-06 Emanuel Ollart
1636 * FIX : compilation process wad broken.
1637 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1639 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1640 * change gdcmViewer -> vtkgdcmViewer
1641 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1643 2003-10-06 Jean-Pierre Roux
1644 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1645 ( e.g : well known GE images with a wrong elem length,
1646 : Philips MRI Images with a wrong Huffman table)
1647 * still to be done : allow the reading of bugged LEONARDO Siemens images
1649 2003-10-03 Jean-Pierre Roux
1650 * Odd length strings are padded with '\0' (not with spaces,
1651 to remain compliant with already defined strings,
1652 like Transfert Syntax UID and others)
1654 2003-10-03 Jean-Pierre Roux
1655 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1656 to allow displaying RGB images (not only by affim ;-)
1658 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * vtkGdcmReader is now able to read rgb dicom file.
1660 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1662 2003-10-03 Jean-Pierre Roux
1663 * A few nasty patches to allow the reading of a lot of nasty images
1664 ( e.g : well known GE images with a wrong elem length,
1665 : Philips MRI Images with a wrong Huffman table)
1666 * still to be done : allow the reading of bugged LEONARDO Siemens images
1668 2003-10-03 Jean-Pierre Roux
1669 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1671 2003-10-03 Jean-Pierre Roux
1672 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1673 to allow displaying RGB images (not only by affim ;-)
1675 2003-10-03 Jean-Pierre Roux
1676 * gdcmFile::GetImageDataIntoVector now
1677 - deals with MultiFrames MultiFragments Run Length Encoded files
1678 - deals with YcBcR (YBR_FULL) files
1679 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1680 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1682 (no sample found :-(
1684 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1686 Two reasons: - clear things
1687 - third parties acces gdcm through header files, so won't
1688 suffer anymore VC++ complains
1690 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1691 * add argv[1] in testvtkGdcmReader.cxx
1694 2003-09-24 Jean-Pierre Roux
1695 * The lines are now eigthy characters long.for
1696 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1698 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1699 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1700 char* to std::string. Thus, the use of strdup becomes useless. (see
1701 previous commis of Malaterre)
1702 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1703 before the last Malaterre's commit.
1705 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1706 * This commit should fix the Debug building under VC++, the problem
1707 was mainly a mixture of debug and release lib being loaded at startup.
1708 * I also remove a depency to a specific C function: strdup. Because I had
1709 to force the link to msvcrtd (whereas strdup is in libc).
1711 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1712 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1713 located in the gdcmCommon.h file. All use of reference of tha has been
1714 changed to now use the variable GDCM_UNFOUND.
1716 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1718 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1719 Dicom dictionary. The test suite can now be run again. Note:
1720 I'm note very happy with the " (RET)" changes. I believe this
1721 RETAINED comment should be dropped when parsing the dictionary.
1722 - PACKAGER corrected
1724 - AUTHORS updated and now in alphabetical order
1725 * Makefile.am now exports gdcm.dsw for Windoze users.
1727 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1728 * cygwin complains about missing std:: in subdir Test/
1730 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1731 * remove some methods that are now in gdcmHeaderHelper
1733 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1734 * vtkGdcmReader set spacing and origin correctly
1736 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1737 * Fix a few delete/delete[] mismatch
1739 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1740 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1741 interpretation to data given by gdcmHeader. For instance there are
1742 heuristics to get informations (look at different places).
1743 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1744 sorting DICOM images based on different strategies.
1745 * modified Makefiles accordingly.
1747 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1748 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1749 when building in debug mode
1750 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1751 src/win32/gdcmdll.dsp
1752 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1754 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1755 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1758 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1759 * src/win32/libgdcmjpeg12.dsp was not dos format
1760 * src/win32/libgdcmjpeg12.dsp :
1761 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1762 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1764 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1765 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1767 * src/gdcmFile.cxx : bug fix in affectation type
1768 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1769 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1770 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1771 symbols... future problem ?
1773 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * src/win32/libgdcmijpeg12.dsp was missing
1775 * modified gdcm.dsw accordingly
1777 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1778 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1780 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1781 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1782 commit of JPR (before his hollidays to facilitate our work).
1783 * setup.py : bug fix in code. Modifications made while the last commit
1784 of JPR. The code hasn't been tested before the commit... it's so
1785 useless to make that (for best programmer that is JPR) !!!
1787 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * tagged the current version as Version0_3 (i.e. version 0.3)
1790 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1791 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1792 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1793 * *.dsp : modifications to use new libgdcmijpeg8 library
1794 * setup.py : bug fix on VTKPATH variable
1795 * PACKAGER : adding all concerning windows
1797 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1798 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1800 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1801 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1802 test suite reported error.
1803 * PACKAGER file added (describes what a packager must do when
1804 packaging a new release).
1805 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1806 * configure.in: upgraded version number to 0.3.0
1807 * fixing build of rpm (through rpm -ta):
1808 - Doc/Makefile.am exports proper doxygen files
1809 - src/jpeg/libijg8/Makefile.am exports the include files.
1811 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1812 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1813 * src/gdcmHeader.h : formatting code
1815 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1816 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1817 We were obtaining error message from vtk. Now, creation of file list
1818 is made in an internal list to prevent this problem.
1819 Bug fix when output is empty.
1820 Bug fix in update of progress value. Previous commit for this was a bad
1822 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1824 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1825 * src/gdcmHeader.h : added method to get the file name
1826 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1827 files. Added method to remove all files on the input
1828 Added FIXME comment concerning the bad parsing of header made by
1829 ExecuteInformation method (in ExecuteData method)
1831 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1832 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1833 when using make instal.
1834 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1835 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1837 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1838 * setup.py : adding include dir of jpeg lib to compile all sources
1839 * */Win32/*.dsp : JPR fix for windows compilation
1841 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1842 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1844 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1845 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1847 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1848 * setup.py is again effective on un*x (takes into account the
1849 addon of the jpeg library)
1850 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1851 * Doc/Doxy* updated (includes above enhancements)
1852 * INSTALL now points to web documentation
1854 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1855 * src/gdcmHeader.h doesn't make unnecessary reference to
1857 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1859 * src/gdcm*.[cxx|h] :
1860 - to allow compilation with gcc 3.x
1861 -- clean up of STL usage (added explicit usage of std::)
1862 -- small fixes on exceptions.
1863 Note: linking not tested !
1864 - clean of doxygen comments to avoid warnings at documentation
1866 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1867 dependent convertion).
1869 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1870 * Clean up of previous JPR garbage commit (not even commented in the
1872 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1873 - moved all jpeg related files from src to src/jpeg/libijg8, with
1874 addition/modification of Makefile.am and configure.in.
1875 - the testSuite is still brain damage (not guilty).
1877 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1878 * WrapVTK.py : modifications to get correctly vtk source files to
1880 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1881 (FileName -> Filename)
1883 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1884 * vtk/vtkGdcmReader.[cxx/h]:
1885 - UpdateProgress method should now be effective
1886 - removed the limitation on having only images loaded (as opposed
1888 - when building a stack of images/volume, a lesser number of
1889 gdcmHeader and gdcmFile instances should be used (hopefully
1890 accelerating things).
1891 - when building a stack of images/volumes, files which are not
1892 loadable (wrong path-filename, wrong permissions on existing file,
1893 or file not parsable by gdcm) are replaced with a black image
1894 in the stack (for the caller to notice the problem).
1896 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1897 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1899 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1900 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1901 between standard library (std) and vtk library (problems are found
1902 under Windows... thanks Windows !)
1904 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1905 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1907 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1909 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1912 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1913 * When compiling with distutils (see setup.py) the C++ compiler is
1914 called with different flags than the default ones (with automake).
1915 In order to fix all those warning, I compiled gdcm with the command
1916 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1917 and went for warning fixes:
1918 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1919 up from unused variables.
1920 - vtk/vtkGdcmReader.cxx: potential bug fix.
1921 * src/gdcmHeader.h: Doxygen warning cleanup
1923 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1924 * gdcmPython/gdcm.i:
1925 - typemaps correction to take into account the systematic replacement
1926 of "using namespace std" with std:: prefix e.g. std::list,
1927 std::string... (cf changes of 2003-05-21).
1928 - gdcmGlob global variable of type gdcmGlobal (defined in
1929 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1930 exported to Python a as cvar.
1931 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1932 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1933 gdcmDictSet.GetPubDictTagNames() and
1934 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1935 C++ static methods).
1936 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1937 with the above changes.
1939 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1940 * setup.py, manifest.in : bug fix under linux
1942 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1943 * Modification of setup.py to compile vtk part too. Then, we have 2
1944 wrappers which must work with same distutils. For that, we have a
1945 generic distutils in distusiltsWrapping.py ; with :
1946 - build_extWrap class to wrap generically all extensions,
1947 - ExtensionWrap base class for all wrapping extension that contains
1949 - Wrapper interface which wrap sources
1950 + In WrapSwig.py we have extension and wrapper for Swig
1951 + In WrapVTK.py we have extension and wrapper for VTK
1952 * MANIFEST.in : modifications to consider vtk directory and new python
1953 files for compilation
1955 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1956 * Added python wrappers of vtkGdcmReader vtk class (see the
1957 source in vtk/vtkGdcmReader.cxx) :
1958 - vtk/Makefile.am now builds a library
1959 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1960 python library (as opposed to _gdcm.so wich are the python
1961 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1962 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1964 - configure.in has an additional flag --enable-vtk that needs
1965 to be set to enable compilation of vtk related code, that is:
1966 + vtk/vtkGdcmReader.so and
1967 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1968 + gdcmPython/vtkgdcmPython.so (see above)
1969 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1970 be read when compressed or when HighBit + 1 != BitsStored),
1971 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1972 the usage of the python wrapper of vtkGdcmReader vtk class.
1973 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1974 * src/*.[h] all occurences of stl classes are now prefixed with
1975 std::, and all occurences of "using namespace std;" where removed.
1976 This is to avoid pollution of global namespace in included files.
1977 Apparently vtk does not avoid this pitfall: when using both
1978 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1979 collision of various stl members (principally cout...).
1980 * gdcmPython/testSuite.py now cleanly removes temprory generated
1982 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1983 comply with above changes)
1985 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1986 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1987 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1988 vtk data structure (an image Flip was required).
1989 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1990 * cosmetic changes in documentation.
1992 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1993 * src/gdcmHeader.cxx: the constructor no longer exits when an
1994 unexisting file is given as argument.
1995 * The subdirectory Data (containing all the images used for the
1996 test suite) is not part of this repository anymore. A new module
1997 containing those images is now available at
1998 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1999 with the name gdcmData.
2000 All the python scripts (including the package initialisation file
2001 gdcmPython/__init__.py) were adapated to take this change into
2002 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2004 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2005 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2006 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2007 demo of the usage of this class.
2008 Compilation of this vtk part is only done when using the --enable-vtk
2009 at configure (or autogen.sh) stage.
2011 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2012 * More memory link related corrections and documentation fixes.
2014 - maximum info is obtained with a command of the form:
2015 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2016 --show-reachable=yes PrintHeader
2017 - the remaining reachable blocks seem to come from the STL
2018 allocation scheme through the usage of map and list. It looks
2019 like this memory cannot be freed but it is not a memory leak
2020 (in fact further invocation to the STL would recollect the
2021 unused memory allthough it cannot explicitely be freed).
2022 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2023 of displaying an image parsed with gdcm and displayed with VTK.
2024 Note: some images don't seem to work e.g.
2025 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2026 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2027 Allthough this weakens the semantics, it is a ditch attempt to
2028 make gdcm more thread friendly.
2030 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2031 * Memory link hunt (by using valgrind through the command
2032 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2033 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2034 gdcmHeader::_dicom_vr.
2035 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2036 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2038 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2040 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2041 * src/Makefile.am now exports all the necessary include files at
2045 * UpdateGroupLength replaced by new one
2048 * UpdateGroupLength re-written using H-Table
2049 (named UpdateGroupLengthNew untill checks are over)
2051 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2052 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2053 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2055 - gdcmHeader::GetPubElValSet removed.
2056 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2057 UpdateGroupLength, WriteElements, Write.
2058 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2059 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2060 carried the same semantics.
2061 - src/gdcmHeaderIdo.cxx changed accordingly.
2062 - gdcmFile::WriteBase now regroups all the codes from previous
2063 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2064 - enum FileType moved to gdcmCommon.h
2065 * src/gdcmHeader.cxx AddDefault trashed
2066 * gdcmGetXSize added
2067 * getimageDataSize now calls gdcmGetXSize
2068 * Test/*.cxx changed to agree with above changes
2070 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2071 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2072 (to avoid double call by end user).
2073 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2074 by end user, since gdcmHeader::gdcmHeader now handles it.
2076 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2077 * gdcm/Doc many doxygen changes:
2078 - Doxyfile now has two different versions, DoxyfileUsers that generates
2079 the html.users end users oriented documentation and
2080 DoxyfileDeveloppers that generates the html.developper developper
2081 oriented documentation.
2082 - README changed accordingly
2083 - requirement.txt removed (old design info moved to TODO).
2084 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2085 DoxyMainPage.txt, DoxyPython.txt provide more information.
2086 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2087 be updated by simply regenerating the docs with doxygen and copying
2088 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2089 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2090 all the tests in the form "if (<map>.count() >1)" were removed.
2091 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2092 ill-formed documentation sections.
2093 * src/gdcmHeader.cxx: ditto
2095 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2096 * setup.py fixed for un*x (needed macro for stdint.h)
2097 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2098 un*ces with sh-utils test utility.
2099 * gdcmPython/demo/test.py renamed to PrintHeader.py
2100 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2101 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2102 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2103 * src/gdcm*.cxx JPR's bad inclusion fixed.
2105 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2106 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2107 * gdcmPython/demo/test.py changed accordingly.
2109 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2110 * gdcmPython/Makefile.am fixed linking against libstdc++
2111 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2112 * Swig subdir (historical tests of swig version 1.3.17++) removed
2113 * Test/testChangeEntete.cxx some lines commented out in order to make
2115 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2116 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2118 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2119 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2120 hence the user doesn't need this explicit call.
2121 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2122 i.e. LoadElements() call removed.
2123 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2124 - src/Makefile.am declares the proper flag for g++.
2125 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2126 for adding user defined new tags.
2127 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2128 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2129 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2131 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2132 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2133 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2134 src/Makefile.am : the project should properly compile and install
2135 with the autotools, included the python wrappers part.
2136 * gdcm.spec.in : added a spec file for RPM packaging.
2138 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2139 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2141 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2142 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2143 to exported to the environement (see gdcmPython/testSuite.py
2145 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2146 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2147 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2148 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2149 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2151 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2152 * gdcmPython/__init__.py doesn't crash anymore when running in
2153 in InstallMode or PreInstallMode but with an environement given
2154 value of GDCM_DICT_PATH.
2155 * src/gdcmDictSet.[cxx/h] coding style.
2157 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2158 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2159 * src/gdcm.h general comments moved to TODO, and README
2160 * src/gdcm.h should now be seen as a user commodity (including it
2161 should suffice to fully use gdcm). It is nowhere including within
2162 any of the kernel files src/*.cxx and src/*.h.
2164 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2165 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2166 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2168 * src/gdcm*.cxx only include their corresponding include file
2169 (as opposed to gdcm.h)
2170 * gdcmPython/gdcm.i changed accordingly
2171 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2172 the autogen.sh generated "make snapshot" command to work.
2173 * autogen.sh removed history related references to crea package.
2175 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2176 * distutilsSwigCPlusPlus.py work around some swig portability
2179 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2180 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2181 was done in a last ditch attempt to get setup.py _really_
2182 operationnal. The python/gdcmPython layaout add the advantage
2183 of hidding away the python related distutils specific files
2184 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2185 Alas, the src directory was out of scope (i.e. it's relative
2186 position to setup.py was ../src) which made things impossible to
2187 handle (see previous version of python/setup.py). Crossing fingers...
2189 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2190 * python/setup.py now works on Un*x. (harder than I thougth)
2191 * python/distutilsSwigCPlusPlus.py can now have include files
2192 among the list of sources.
2194 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2195 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2196 * modifications in MSVC projects
2198 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2199 * As stated by the first lines of Test/ExceptionAndPython/README, it
2200 looks like we can move back to original usage of exception within
2201 src/gdcm* and hence remove the errno stuff that was introduced
2202 as a quick and dirty fixture of this problem (added to the TODO).
2203 * Doc/Doxyfile configuration file for Doxygen and corresponding
2204 README file for usage added.
2205 * Test/testWrite.cxx added. This new test comes from a split of
2206 test.cxx that is now reverted to its original purpous i.e.
2207 testing the proper parsing of a Dicom related file.
2208 testWrite.cxx concentrates on testing the IO part of gdcm.
2209 * Test/bug1.cxx (containing a bug on WIn32) added.
2210 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2211 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2212 whose purpose is to publish the content of the TagNames of the
2213 Dicom public dictionnary were not accessible without an
2214 instance of class gdcmHeader.
2215 - those methods are now static methods of gdcmDictSet and hence
2216 require no instances at all to be invocated.
2217 - within gdcmDictSet this change required to change some method
2218 to class methods (i.e. are now static) among which SetDictPath
2219 (renamed to BuildDictPath) and LoadDefaultPubDict.
2220 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2221 the above changes by calling the new method classes of gdcmDictSet.
2222 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2223 the above to be effective.
2224 * python/gdcmPython: in order to wrap properly the above changes
2225 for Python, swig version now needs to be > 1.3.17.
2226 * python/gdcmPython/Makefile fixed to adapt itself to new
2227 configure/make shema introduced by Johan Montagnat (thanks for the
2228 contribution). Alas this Makefile cannot be turned into a proper
2229 Makefile.am without some heavy changes in the configure.in
2230 (for python dectection).
2231 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2232 now avoids publishing the empty entries.
2234 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2235 * python/setup.py : bug fix concerning install under windows
2236 ExtraPath reused :-P
2237 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2239 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2240 * Dicts/dicomV3.dic : remove double spaces !!!
2241 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2242 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2245 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2246 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2247 method. Doxygenation.
2248 * src/gdcm.h clean up of JPR spurious comments.
2250 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2251 * python/distutilsSwigCPlusPlus.py now properly collects the
2252 shadow classes generated by "swig -c++" (gdcm.py in our case)
2253 when using "python setup.py install".
2254 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2255 reexports the working classes.
2256 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2257 by the classical C errno scheme. This is to prevent an obscure
2258 behavior of the python wrappers when importing wxPython.wx prior
2259 to gdcmPython (which ended up in an abort call). An illustration
2260 of this oddity can be found in the Test/ExceptionAndPython
2261 subdir (see the README file). This problem probably due to
2262 an combination of g++ and dynamic loading.
2263 * added Test/ExceptionAndPython (see above)
2265 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2266 * Changed the layout of the python part to avoid bloating main
2267 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2268 i.e. the distutils arsenal. All the python related stuff is
2269 again in a python subdir, but the package itself is now in
2271 * setup.py was cleaned up:
2272 - pythonIncludePath removed
2273 - python setup.py bdist target is now functional.
2274 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2275 collision with other packages). gdcmPython/demo/*.py changed
2278 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2279 * python subdir moved to gdcmPython (preparation of distutils packaging).
2280 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2281 distutils installer is operational.
2282 * - gdcmPython/__init__.py now properly loads the swig generated
2283 shadow classes (from gdcm.py).
2284 - gdcmPython/demo/*.py changed to import the package gdcmPython
2285 instead of gdcmPython/demo/load.py.
2286 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2288 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2289 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2290 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2291 entries within the associated public Dicom dictionary resp. the same
2292 information but sorted by the fourth field (PAT, IMG, DIR) of the
2294 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2295 are now in the "???" group.
2296 - python/gdcm.i changed accordingly,
2297 - python/demo/printGroupedPublicDict.py added, that gives an example
2298 of the above new functionalities in Python.
2300 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2301 * src/gdcm.h, gdcmHeader.cxx:
2302 - historic references to glib's g_malloc and g_free (#defined)
2303 were definitively removed.
2304 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2305 * src/gdcmElValSet.cxx:
2306 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2307 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2308 - GetElValue(string) renamed to GetElValueByName.
2309 - Added GetElementByName(string).
2310 * src/gdcmHeader.cxx: added
2311 - GetPubElValRepByNumber(guint16, guint16)
2312 - GetPubElValRepByName(string)
2313 - GetShaElValRepByNumber(guint16, guint16)
2314 - GetShaElValRepByName(string)
2315 - GetShaElValByNumber(guint16, guint16)
2316 - GetShaElValRepByName(string)
2317 - GetElValRepByNumber(guint16, guint16)
2318 - GetElValRepByName(string)
2319 - GetElValByNumber(guint16, guint16)
2320 - GetElValRepByName(string)
2321 * Doc/requirements.txt added.
2323 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2324 * Test/Makefile building now depends on the one of libgdcm.so
2325 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2326 pixel data) aware which enables finding the address (offset) of
2327 the pixel data of JPEG encoded DICOM files. This leaves only a single
2328 file in the testSuite whose pixel data address (offset) is unknown.
2329 * python/testSuite.py changed accordingly.
2331 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2332 * VC++ has some strong limitations when working with the STL, as stated
2333 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2334 "Also note that some STL containers (map, set, queue, list, deque)
2335 cannot be exported. [...]
2336 Some STL classes contain nested classes. These classes can not
2338 This is caused by a designed limitation that once a template
2339 class is instantiated, it can not be re-instantiated and
2341 Since our usage of map<> is ubiquitous in gdcm, this "designed
2342 limitation" of VC++ is a pitfall.
2343 Hence the Python wrappers of gdcm cannot be incrementally linked
2344 against the c++ dynamic library. The dirty but only workaround is
2345 to forget about incremental link of dynamic libraries and to generate
2346 the Python wrappers library with the inclusions of the underlying C++
2348 The following modifications concern this matter on Win32/VC++:
2349 - wrapping python correct with standalone wrapped dll (don't use separate
2350 dll under windows !!!!)
2351 - python21_d debug mode enabled (ask Frog how to use it :-)
2352 - NO problem with having an STL member of class for example string in C++
2353 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2354 - Python test of dcmlib in Python is ok under windows on a large set
2356 * removed glib references
2357 * typedef's inserted in gdcm.i for correct swig type management
2359 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2360 * python/demo/*.py load.py extracted from test.py. Added explore.py
2361 that only displays required tags and testAll.py that parses all
2362 the files of the testsuite without using unittest.
2363 * python/testSuite.py other additional test on new files added.
2364 * Data/* new test files added accordingly to the testSuite.
2365 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2366 the vr in the file differs from the one of the dictionary.
2368 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2369 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2370 values, but limits itself to values which are below a user specified
2371 size (by default 1024 bytes).
2372 * python/gdcm.i : elements not loaded (because their size is above the
2373 user specified treshold) are exported with their TagKey as key of the
2374 python dictionary. This enables the testsuite to make some checks
2375 on the unloaded elements (since we have their offset and size).
2376 * python/testSuite.py
2377 - now tests for the existence and proper value of the pixel data
2378 - two new examples added.
2379 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2381 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2383 aware. See the strategy comments in gdcmHeader::FindeLength().
2384 * Test/test.cxx now accepts a filename as first argument.
2385 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2386 * python/testSuite.py changed to integrate test on above files.
2388 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2389 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2390 the vr was also RET.
2391 * python/testSuite.py more tests added.
2393 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2394 * python/testSuite.py unittest test suite added (uses Data)
2395 * Data/* dcm and acr files for the test suite.
2396 * glib dependance removed from un*x version. We now use ISO C99
2397 7.18 Integer types (see stdint.h)
2398 - python/Makefile, src/Makefile src/gdcm.h
2399 * src/ when an explicit vr (like dicom files) suddenly poped an
2400 implicit element we use to mark the underlying DictEntry of the
2401 concerned ElValue with "Implicit". This strategy was damageable
2402 too the public or provite dictionaries, since some of their vr
2403 would be changed. Since Header::FindLength heavily relies on the
2404 detection by Header::FindVR of falsely explicit elements, I
2405 added an extra ImplicitVr member to ElValue (boolean).
2406 The rest of the changes we the necessary adaptations.
2408 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2411 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2413 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * Adaptation for porting to VC++:
2416 o forced to use std namespace (for string to be known)
2417 o all class use __declspec export style on WIN32
2418 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2419 (in stdlib.h on Win32 but in std:: for gcc)
2420 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2421 variable GDCM_DICT_PATH.
2422 * src/gdcmHeader.cxx verbose comments made discrete.
2424 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * python/gdcm.i: added a typemap that converts a C++ hashing table
2426 to native Python dictionary.
2427 * python/demo/test.py:
2428 - now uses the native dictionary for exploration of gdcmHeader.
2429 - takes an optional filename argument (the file to parse).
2430 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2431 PubElVals hashing table.
2432 * Dicts/dicomV3.dic removed error prone trailing spaces.
2434 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2435 * Python wrapping process moved away from src/Makefile to
2436 newly created python/Makefile (as well as gdcm.i)
2437 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2438 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2439 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2440 from the environement variable GDCM_DICT_PATH (when existing).
2441 * src/gdcmDict::GetTag bug fix.
2443 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2444 * Straightforward temporary fixes for swig to build the python wrappers.
2445 src/Makefile now has a python working entry [by working we mean
2446 that we can import de shadow classes without errors].
2448 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2449 * hashtest.cxx removed (since allready in Test)
2450 * src/gdcmlib.h renamed to src/gdcm.h
2451 * src/dcm.i renamed to src/gdcm.i
2452 * src/Makefile prepared for python wrapping
2454 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2455 * src/gdcmHeader.cxx :
2456 - Parsing of header is now separated from loading of element values
2457 (see gdcmHeader::LoadElements).
2458 - general clean up of hopefully all file access (creation of
2459 ReadInt16 and ReadInt32)
2461 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * src/gdcmHeader.cxx :
2463 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2465 - SetLgrElem renamed to SetLength
2466 - GetLgrElem renamed to GetLength
2467 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2468 * src/gdcmElValSet.cxx fixed both GetElValue methods
2469 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2470 due to IdoDude was cleaned out.
2472 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2474 concentrates on finding the value representation (when it exists).
2475 RecupLgr now only finds the element value length, and it avoids
2476 returning the unecessary skL (skipped length).
2477 Also, offsetCourant was simply removed (with taille_fich) since
2478 it was redundant with the File position internals (by using
2479 ftell and fseek). This also made skL (see above in RecupLgr) usage
2481 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2482 on the libido specificities which are handled through class
2484 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2487 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2488 * Truckload of changes. Parsing of header is barely functional
2489 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2491 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * src/gdcmHeader.cxx many addons of low level methods
2494 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2496 and _IdDcmSWAP_LONG.
2498 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * This corresponds to all the changes decided at the meeting of
2500 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob