1 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Valgrind note: after Mathieu Malaterre teached me how to read
3 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
5 Using gcc, you can force the STL to use malloc and to free memory as
6 soon as possible by globally disabling memory caching.
7 With 3.2.2 and later, you should export the environment variable
8 GLIBCPP_FORCE_NEW before running your program.
9 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
10 simply vanish (it is still not clear to me, whether this means that
11 STL std::string leaks or if valgrind believes it leaks...).
12 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
13 running bin/gdcmTests makeDicomDir):
14 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
15 - Test/makeDicomDir.cxx now properly traps empty lists and returns
17 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
18 SegFaulting (I drowned in DicomDir related code when trying to
19 understand why the list is empty...).
20 * src/gdcmDocument.h: first BSD license header try.
21 * Doc/License.txt added.
23 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
24 * src/gdcmDocument.[h|cxx]:
25 - Clean up of the Transfer related predicates. They are now all based
26 on new method isGivenTransferSyntax, that (should) handle properly
28 - general clean up, simplification, and coding style.
29 - Specific clean up of Parse7FE0() (umproperly named actually).
30 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
32 2004-06-14 Jean-Pierre Roux
34 - fix the display of Sequence Delimitor (SQDepthLevel pb)
35 - fix the display of SQItem ordinal number
36 - add the GetSQItemByOrdinalNumber method
37 - remove some useless never written private methods
39 2004-06-14 Jean-Pierre Roux
41 - adding a constructor taking a gdcmDocEntry as an input param
42 - ReplaceOrCreateByNumber now returns :
43 a gdcmBinEntry * if a Binary (void *) value is passed as a param
44 a gdcmValEntry * if a string value is passed as a param
46 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
47 according to the param type (no longer sets a gdcmDocEntry)
48 - GetValEntryByNumber, GetBinEntryByNumber added
49 - NewValEntryByNumber and NewBinEntryByNumber added
51 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
53 - GetSQItemNumber and SetSQItemNumber added, to provide
54 a (relative) Item identier inside a given Sequence
55 \warning : some pb remaining around this number
57 - AddEntry now takes the Item Number as a param
59 - adding a constructor taking a gdcmDocEntry as an input param
61 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
62 * Memory leak hunt with the following command:
63 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
64 --show-reachable=yes gdcmTests PrintDocument
65 It looks like many (all?) leaks are due to the STL (or a bad usage
66 of the STL. The lines producing the leaks now have a comment with
67 a "MEMORY LEAK" tag: you can retrieve them with
68 grep "MEMORY LEAK" src/*
69 Here are two typical examples which I can't help fixing:
75 name = test; //// <--- valgrind detects 960 bytes lost in
76 //// call to std::string::operator=(char const*)
77 name.clear(); //// Doesn't help !
85 std::cout << "Type a bunch of characters followed by RETURN: ";
86 getline(std::cin, line); //// <--- valgrind dectects a loss
87 //// of 1320 bytes in call to
88 /// std::basic_istream<>& std::getline<>
94 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
95 * src/gdcmHeader.[cxx|h]:
96 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
97 and related, moved away to gdcmDocument.
98 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
99 the corresponding protected accessors of inherited class
100 gdcmDocument, removed ! As a consequence gdcmFile had to be
101 declared friend of class gdcmDocument (see below).
102 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
103 - Clean up of undefined or unused methods.
104 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
105 account the changes to gdcmHeader.h).
106 * src/gdcmDocument.h:
107 - gdcmFile is now a friend class (in order to take into account the
108 changes to gdcmHeader.h).
109 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
110 (see changes to gdcmHeader.h).
111 - Accessors (reading on the form GetEntry*) are now public.
112 - Clean up of undefined or unused methods.
113 * src/gdcmDocument.cxx:
114 - adaptation to changes to gdcmDocument.h
115 - ::OpenFile now writes a verbose message when file cannot be opened.
116 - some std::string properly set to VRKey
117 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
118 references to gdcmDocument.
119 * Test/TestFindTags.cxx: changed accordingly to above changes.
120 * gdcmPython/testSuite.py: adapted to renaming of acr files in
121 cvs repository gdcmData.
123 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
125 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
126 conflicts with gdcmValEntry::voidArea.
127 * src/gdcmValEntry.cxx: unmatching comment wiped out.
128 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
129 Value representation between StringRepresentable and BinaryRepresentable.
130 * src/gdcmDocument.cxx:
131 - method ParseDES: proper indentation restored and usage of
132 gdcmVR::IsVROfGdcmStringRepresentable wired in.
133 - method LoadDocEntry: the fingerprint left in the SetValue() of
134 unloaded entries (length > MaxSizeLoadEntry) had curiously been
135 removed. Reverting to previous code segment with the proper
136 dynamic_cast< gdcmValEntry* >.
137 Note: this was (partially) breaking the python test suite
138 (gdcmPython/testSuite.py) that made usage of the above
139 fingerprint to check presence of "Pixel Data".
140 * src/gdcmDocEntry.h: coding style.
141 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
142 now taken into account.
143 * gdcmPython/gdcm.i: adaptation to the new internal representation
144 of gdcm (exit gdcmParser, hello gdcmDocument).
145 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
147 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
148 anymore, but instead prints the loaded Python dictionary.
149 * .... alas, the python testSuite is still broken.
151 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
154 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
155 * src/gdcmUtil.h : export methods
157 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
158 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
160 * Initial addition of automatic python testing
161 * Initial addition of automatic image comparison
163 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
165 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
167 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
169 * Test/ShowDicom.cxx : bug fix for msvc compilation
170 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
172 2004-05-04 Jean-Pierre Roux
173 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
174 new concepts (and new classes) :
175 a 'gdcmDocument' is composed of a set of Doc Entries, that are
176 - elementary gdcmDocEntries (former gdcmHeaderEntries)
177 - Sequence Doc Entries (gdcmSeqEntries)
178 a Sequence is composed of Items.
179 Each item is a set of Doc Entries (this is recursive)
180 The non uniqueness of the 'Dicom tag' is due to this recursivity
181 (never taken into account)
182 Our unability to add a new 'entry' in the header
183 at the proper location (neither in the H-Table (map or multimap),
184 nor in the Chained List is also due to this recursivity.
185 Don't try, right now, to use/modify/compile these new sources :
187 We just commit all the stuff, 'as is', in order not to loose it.
189 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
192 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
194 file prefix (SetFilePrefix)
196 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
197 * Add a new test: ShowDicom, for now this is just the c++ version of
198 checkRead.sh, later it will be able to compare the image read against a
200 * Replace the DEBUG on the stack with a global entry in cmake interface:
201 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
203 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
204 * Add an example subdir, with a real example on how to read + write a
207 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
208 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
209 * Doc/CMakeLists.txt: the main page is now properly differentiated
210 between the developper and user version.
211 * Doc/doxygen.config.in: dropped search related obsolete flags
212 * src/gdcmParser.h, gdcmHeader.h: doxygenation
214 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
215 * DEVELOPPER: added some helpfull comments for compile/test/install
218 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
219 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
220 src directory, now generated in the build dir.
221 2. Tests as mentionned smarter
223 4. Add a new method in gdcmDict that return the PubDict by name
224 this is interesting for 3rd party lib like ITK,
225 where we could set the institution name / patient name...
227 * ENH: 1. Now the test suite is working for real
228 2. All binaries are now output in the gdcm-bin directory
229 (this was not true before)
231 2004-04-28 Jean-Pierre Roux
232 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
233 SeQuence indented printing of Dicom Header.
234 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
235 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
236 Computation of SQDepthLevel is now part of gdcmHeader constructor
237 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
238 tree-like structure of a Dicom Header.
239 * FIX Test code cleaning
241 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
242 * ENH: Adding automatic testing
243 1. Need a DartConfig.cmake to submit to public
244 2. Add a test driver gdcmTest.cxx
245 3. gdcmTestMain, an helper for the main test driver gdcmTest
246 4. Files in Test don't have a main anymore, this becomes interesting
247 when we add more and more tests, thus dsw don't have to load
249 * ENH: Adding a GDCM_DATA_ROOT for testing
250 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
251 one file instead of seven + some small cleanup
253 2004-04-22 Jean-Pierre Roux
254 * ENH Minor changes to the Print() methods.
255 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
256 Header printing. Example given with :
257 > PrintHeader fileName 2 new
258 (SQ based tree-like structure still to be done for the Header ...)
260 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
261 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
262 1. I have added some unsigned where needed
263 2. Some function parameter not used -> (void)
264 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
265 4. g++ don't like character '\' in comment
266 5. #define jpeg_create_decompress jCreaDecompress
267 this really need to be fixed
268 6. virtualize destructor of gdcmObject ... leakage
269 7. sscanf(g->first.c_str(),"%x",&gr_bid);
270 this also really need to be fixed
271 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
272 remove compression file
273 (as we only do decompression, right ?)
274 * ENH: Change malloc/calloc/free with c++ equivalent
276 2004-04-21 Jean-Pierre Roux
277 * FIX gdcmHeaderHelper::GetXSpacing
278 when a single value is found (bug ?), xpacing is now
279 defaulted to yspacing
281 2004-04-19 Jean-Pierre Roux
282 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
283 * ENH add parameters :
284 bool exception_on_error = false,
285 bool enable_sequences = false,
286 bool ignore_shadow = false
287 to the gdcmFile constructors to be full gdcmParser compliant
288 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
289 to allow reading of PAPYRUS 3.0 files
291 2004-04-06 Jean-Pierre Roux
292 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
294 2004-04-02 Jean-Pierre Roux
295 * ADD : Test/checksequence.sh, for a general recap on SQ pb
296 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
297 for Philips spurious Tag fffe|0000 while rewritting Dicom files
299 2004-03-30 Jean-Pierre Roux
300 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
301 for ACR file, written out as DICOM files (hope so...)
303 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
304 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
305 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
306 moved to base class gdcmParser and only the specialisation is kept
308 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
309 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
310 already does the job.
311 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
312 (to be consistent with gdcmParser::WriteEntries).
314 2004-03-30 Benoit Regrain
315 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
316 upate of the object's instance. It's passed to 2 in the unfavorable
317 case : one in the ExecuteInformation, one in the ExecuteData
319 2004-03-29 Jean-Pierre Roux
320 * ENH : Check on file type to be written moved
321 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
322 * FIX : gdcmObject::ResetBoundaries now stops properly
323 when end-of-list is reached
324 : gdcmVersion modified (as Benoit Regrain asked)
326 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
328 * src/gdcmUtil.cxx: added forgotten iostream include.
329 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
330 equivalent to ExplicitVR in existing code).
332 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
334 now contains all the gdcmGlobal related code.
335 * minor coding style and doxygenation changes.
337 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
339 now contains all the Debug related code.
340 * minor clean-up of includes in src/*.cxx
341 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
342 CreateCleanString) removed.
343 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
344 * Doc/DoxyMainPageUser.txt added.
345 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
346 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
349 2004-03-24 Jean-Pierre Roux
350 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
352 2004-03-23 Jean-Pierre Roux
353 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
354 big endian made volumes
355 * ENH Now gdcmParser constructor and destructor are protected to forbid
356 end user to instanciate class gdcmParser
357 (only gdcmHeader and gdcmDicomDir are meaningfull)
359 2004-03-22 Benoit Regrain
360 * FIX : src/gdcmDicomDir.cxx : make windows compilable
361 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
362 gdcmSerie to gdcmDicomDirSerie
364 2004-03-19 Jean-Pierre Roux
365 * ENH Now the tree-like structure describing a DICOMDIR comming from
366 an already existing DICOMDIR file is consistent with
367 the home-made tree-like structure build ex-nihilo
368 or build from the files held (recursively) in a Directory
369 functions gdcmDicomDir::CheckBoundaries()
370 gdcmObject::SetBoundaries() added
372 2004-03-17 Jean-Pierre Roux
373 * REM (Eric Boix bug) : removal of meaningless
374 gdcmDicomDirImage::NewImage function.
375 * FIX now file names and directory name are written properly in the
377 * FIX now gdcmDicomDir constructor may be call without any trick
380 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
381 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
382 of gdcmDicomDirImage::NewImage as empty function.
384 2004-02-28 Jean-Pierre Roux
385 * ENH add gdcmDicomDir:NewPatient
386 add gdcmDicomDirPatient:NewStudy
387 add gdcmDicomDirStudy:NewSerie
388 add gdcmDicomDirSerie:NewImage
389 to allow making gdcDicomDir object.
390 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
391 (as opposite to the gdcmHeader chained list)
393 2004-02-11 Benoit Regrain
394 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
395 when using from python
397 2004-02-10 Benoit Regrain
398 * FIX : bug fix in the gdcmDirList for the recursivity in directories
399 * FIX : in gdcmDicomDir when the directory is empty
400 * ENH : add callback and methods to get the progression of dicomDir
403 2004-02-06 Jean-Pierre Roux
404 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
405 - GDCM_META added to gdcmDicomDirType
406 - class gdcmMeta created
407 * ENH : - A brief summary is now displayed at the beginning of
408 'testDicomDir' to help disaster magnitude estimation
409 * REM : Now useless Test/explDICOMDIR.cxx
411 2004-02-05 Benoit Regrain
412 * ENH : add methods in gdcmObject to get the hash table or the list of
414 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
415 * FIX : wrapping python for TagHeaderEntryHT
417 2004-02-04 Benoit Regrain
418 * FIX : even length for some strings when writting the dicom dir
419 * FIX : sort the images in the dicom dir
420 * FIX : Bug fix for python use of dicom dir
421 * ADD : a python demo
423 2004-02-04 Jean-Pierre Roux
424 * FIX : Final solution (?) for icone embedded images
425 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
426 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
427 add groups 6002, 6004, 6006, to allow 'clean' parsing of
428 gdcmData/gdcm-MR-SIEMENS-16.acr1
429 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
430 to make full checking easier
432 2004-02-04 Benoit Regrain
433 * FIX : WriteEntries : coding style & logic in parameters
434 * FIX : Set the elements to create the DicomDir in a dictionary file
436 2004-02-03 Benoit Regrain
437 * gdcmDirList : to parse a hard drive directory in recursive (or not)
438 * gdcmDicomDir : add the load of directory
439 * Bug fix and print add-on
441 2004-02-03 Jean-Pierre Roux
442 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
443 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
444 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
445 * FIX gdcmParser.cxx : 'group length' elements are now considered
446 as integers, even for shadow groups, when file is Implicit VR
448 2004-02-02 Jean-Pierre Roux
449 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
451 of the last synonym :-(
452 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
454 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
455 * FIX taking into account the possible 7fe0,0010 multiplicity
456 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
457 to allow removal of references to 7fe0,0010, to deal with
458 ACR-NEMA images, when 0028,0200 is meaningfull
460 2004-01-31 Jean-Pierre Roux
461 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
462 no longer writes 'Un' on disk
463 * FIX SQ elements with actual length are now dealt with corectly
464 * FIX gdcmFile::WriteBase make the difference, for color images, between
465 the length (for Palette expanded images)
466 and Raw Length (non expanded image + Palette)
467 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
468 (that broke Write). Replaced by UL.
469 Aware user will reload the field if he
470 thinks it's necesssary
472 2004-01-30 Jean-Pierre Roux
473 * gdcmParser::CheckSwap() now defaults the filetype to ACR
474 when 'dirty Acr' is found, to be compliant with the new
475 IsReadable() methods.
477 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
478 (no DOUBLE images in kosher DICOM,
479 but so usefull for people that miss them ;-)
481 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
482 DICOMDIR related utilities (not checked as Windoze compliant)
484 2004-01-28 Jean-Pierre Roux
485 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
487 2004-01-27 Jean-Pierre Roux
488 * gdcmParser constructor has a new boolean param,'ignore_shadow',
489 to allow skipping the shadow elements, to save memory space.
490 The TRUE value for this param has to be used
491 with a FALSE value for the 'enable_sequence' param.
492 ('public elements' may be embedded in 'shadow Sequences')
493 * gdcmHeader methods now deal with 'embedded icones images' in the header
494 (even when an 'icone image sequence' is announced by the
495 element (0x0088,0x0200), but there is NO icone at all ...
497 * gdcmHeader sometimes Image Location value doesn't follow
498 the supposed processor endianity (see gdcmData/cr172241.dcm).
501 * gdcmHeader add the method
502 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
503 to get *all* the Header Entries with the same tag.
504 GetHeaderEntrySameName is probabely *useless*
505 (no meaning : Name is *not* an identifier within the Dictionnary)
507 2004-01-26 Benoit Regrain
508 * Bug fix in the print of hexadecimal representations. Remove long fields
509 in the print and add a third level of print to print them
511 2004-01-23 Benoit Regrain
512 * Bug fix on field having a VR = 'UI'. Assume that is a string field
513 * Bug fix on test suite after remove the strip made on not string fields
514 * Split the IsReadable method between gdcmParser which test that the file
515 is dicom and gdcmHeader which test that it's an image file
517 2004-01-22 Benoit Regrain
518 * DicomDir : clean code, add methods, set variables in protected or private
519 * gdcmUtil : bug fix for the clean string method
521 2004-01-19 Benoit Regrain
522 * Add the use of shadow dictionaries
523 * bug fix and coding style
525 2004-01-19 Benoit Regrain
526 * src/gdcmFile.cxx : bug fix concerning the close of file
527 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
528 * Add the update of header entries using the shadow library
530 2004-01-19 Benoit Regrain
531 * removal of file gdcmHeader2.cxx
532 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
533 inheriting from gdcmParser. This split is to prepare the integration
535 * bug fix under python
537 2004-01-16 Jean-Pierre Roux
538 * REM removal of class gdcmHeaderEntrySet
539 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
540 * ADD add file gdcmHeader2.cxx
541 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
543 2004-01-15 Benoit Regrain
544 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
545 entries created while parsing the header. Thus, they will be destroyed
546 when the gdcmDictSet will be destroyed
547 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
550 2004-01-15 Benoit Regrain
551 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
552 made a fatal error because of the memory release at the end of program.
553 The problem was in vtkGdcmReader::ExecuteData where we were allocate
554 some memory and vtk seems to have some problems with that.
555 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
557 2004-01-14 Benoit Regrain
558 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
559 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
560 * src/*.[h|cxx] : make changes due to class name changes
561 * gdcmPython/demo/*.py : bug fix due to method names
563 2004-01-13 Benoit Regrain
564 * src/*.[h|cxx] : coding style
565 * vtk/*.[h|cxx] : coding style
567 2004-01-13 Benoit Regrain
568 * gdcmPython/testSuite.py : test the readable flag of file for tests
569 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
570 It's lied to the stl compilation by MSVC (windows, always windows...)
571 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
573 2004-01-12 Benoit Regrain
574 * src/*.h : add comments
575 * src/gdcmDictSet.h : set the method BuildDictPath in public
576 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
577 directly setted in the source code
578 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
581 2004-01-09 Benoit Regrain
582 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
583 * setup.py : use a reference to gdcmVERSION
585 2004-01-07 Benoit Regrain
586 * Modification to compile with the distutils.
589 2003-12-10 Benoit Regrain
590 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
591 can use a gdcmHeaderHelper to load datas
592 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
593 made in the source code
595 2003-12-10 Benoit Regrain
596 * Update Windows projects and .cvsignore files
598 2003-11-12 Jean-Pierre Roux
599 * ENH gdcmHeader constructor has one more parameter (default value : false)
600 that allows the user to 'go inside' the SeQuences only
602 gdcmElValSet:Print takes it into account
604 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
605 * ENH: Update gdcmPython/CMakeLists
606 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
607 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
609 2003-11-10 Jean-Pierre Roux
610 * FIX : gdcmHeader::LoadElements is now based
611 on the ListTag listElem member,
612 not longer on the TagElValueHT tagHt member
613 * ENH : PrintPubElVal shows (temporarily) both results,
614 with the tagHt member and the listElem member.
615 (it's easier to 'see' the problems when using Printheader)
617 * FIX : old private member LgrElem is now splitted into
618 ReadLength : Length actually found on disk (updated only
619 if bug fixing is necessary), for internal
621 UsableLength : Updated by FixFoundLength, to fix a bug
622 or to allow Parser going on.
623 Will allow to re-write a kosher header when a SeQuence
624 with a length (not 0000) is found
625 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
626 because gdcmElValSet::Add does not update ListElem
629 2003-11-07 Jean-Pierre Roux
630 * FIX misstyping in Transfert Syntax name table
631 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
632 when they have an actual length (not 0000 nor FFFFF)
633 (Nobody should care of it, but DICOMDIR explorers)
635 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
636 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
638 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
639 * ENH: vtkGdcmReader now supports LUT !
640 (vtkgdcmViewer for now is not able to use them though)
642 2003-11-05 Jean-Pierre Roux
643 * in testSuite.py : new files names for checking the package
644 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
645 that returns the pixel area size to the *aware* (vtk) user
646 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
648 2003-11-05 Benoit Regrain
649 * in testSuite.py : Modify the rules for checking the paths
650 : Explicit error messages
651 * in __init__.py : Related modif
653 2003-11-03 Jean-Pierre Roux
654 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
655 to be used by aware (vtk) users that want to manage
656 LUT (and no to turn the PALETTE image into an RGB pixels one)
657 * GetPixelType now returns 8U for 24 Bits images
658 (vtkGdcmReader compliant)
660 2003-10-31 Jean-Pierre Roux
661 * Removal of *all* gdcmData images and add them again
662 in order to loose the 'history' of un-anonymised images
664 2003-10-31 Jean-Pierre Roux
665 * RMV : removal of useless jBitsInJsample.h
666 for both 8 and 12 Bits JPEG Lossy Libraries
668 2003-10-31 Jean-Pierre Roux
669 * ENH : Add the functions gdcmFile::GetImageDataRaw
670 gdcmFile::GetImageDataIntoVectorRaw
671 that act as GetImageData and GetImageDataIntoVector
672 except the making of an RGB Plane from Gray Plane + LUT
673 Intended to aware (vtk) users who know how to manage
676 GetLUTRGBA return a R,G,B,A LUT if any
677 lgrTotaleRaw gives the 'Raw' length
678 GetImageDataRaw returns the gray Plane
679 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
680 (They stay Grey, just like with other Dicom viewers :-(
682 2003-10-30 Jean-Pierre Roux
683 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
685 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
686 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
687 being coherents dicom files.
689 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
690 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
692 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
693 * ENH: Two steps is necessary to please VC++ compiler...
694 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
695 * ENH: Add include dir to medcon lib
696 * FIX: only one function is being exported for now !
697 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
699 2003-10-29 Jean-Pierre Roux
700 * adding gdcmHeader::GetLUTRGBA
701 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
702 --> Mathieu, the modif u're waiting for is not yet committed
703 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
705 2003-10-27 Jean-Pierre Roux
706 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
707 00191113.dcm DermaColorLossLess.dcm
708 MxTwinLossLess.dcm RadBWLossLess.dcm
709 * ENH: For version prior to vtkImageViewer2 -r 1.19
710 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
712 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
713 * Removal of ido stuff in CMakeLists.txt
715 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
716 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
717 * FIX: remove a call to ->Modified ... see comments
718 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
720 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
721 * FIX: Problem with path for libvtkgdcmPython
722 * ENH: Try adding a search script for python site-package
723 * RMV: Remove some file from medcon lib that are not necessary
724 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
725 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
726 * FIX: More pragma disable fro VC++,
727 I don't think I break something as it is also disable in VTK/ITK.
728 But it fasten debug compilation time.
730 2003-10-23 Jean-Pierre Roux
731 * gdcm now deals with 16 Bits Run Length Encoded images
732 (they are compressed as 2 planes images,
733 one for the high Bytes, the other for low Bytes)
735 2003-10-22 Jean-Pierre Roux
736 * Now CheckRead takes into account :
737 - the bugged 'Leonardo' Siemens images
738 - the XA images, sent thru the burning VPRO station
739 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
742 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
743 * FIX: When copying a Makefile.am to CMakeLists.txt
744 one should remove the '\'
746 2003-10-22 Jean-Pierre Roux
747 * in gdcmData adding a bugged 'Leonardo' Siemens image
748 (wrong lengths in header)
749 OK with gdcm, KO with the other viewers :-)
750 * add a GE dlx XA image, thru the VEPRO burning station
753 2003-10-21 Jean-Pierre Roux
754 * in gdcmData add the checkvtkgdcmViewer.sh shell script
755 for a brutal checking of vtkgdcmViewer compliance
757 2003-10-21 Jean-Pierre Roux
758 * add the files for 'xmedcon' Jpeg Lossless library
759 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
761 2003-10-21 Jean-Pierre Roux
762 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
764 2003-10-21 Jean-Pierre Roux
765 * garbage Siemens 'Leonardo' images dealt with
766 (the patch is easy to remove)
767 * cosmetic changes to avoid warnings
769 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
770 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
771 no need to press 'r' now.
773 2003-10-20 Jean-Pierre Roux
774 * upgrade of checkRead.sh checkWrite.sh according
775 to new Jpeg Lossless decompressor
776 * add US.3405.1.dcm, a genuine RGB medical file ...
777 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
778 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
780 2003-10-15 Jean-Pierre Roux
781 * general anonymisation in gdcmData
782 * adding the 'color files' from
783 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
784 * adding some well knowed bugged-header images
785 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
786 waiting for their inclusion in Python testsuite
788 2003-10-15 Jean-Pierre Roux
789 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
790 no longer seg faults when file is not found
792 2003-10-14 Jean-Pierre Roux
793 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
796 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
797 * TODO: *.in file to genereate a UseGDCM later
799 2003-10-14 Jean-Pierre Roux
800 * Some supposed-to-be Dicom Images have no preamble.
801 OpenFile takes it into account
802 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
803 * Missing elements added in dicomV3.dic
804 (just to be affraid : have a look at
805 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
806 and do it again next year ;->
808 2003-10-13 Jean-Pierre Roux
809 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
810 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
811 But there are NOT. It's fixed !
813 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
814 * FIX: "jpeglib.h" was not found on VC++
815 * FIX: vtkgdcm was not being installed
817 2003-10-10 Jean-Pierre Roux
818 * ENH : OpenFile closes the file if it *really* doesn't look like
819 an ACR-NEMA / DICOM one.
820 * FIX : testWrite no longer writes an empty file if the source file
822 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
825 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
826 * FIX: CMake generate now documentation
827 * ENH: out of source doc build !
828 * ENH: Generate both user and dev documentation
829 * ENH: Should work on windows too
830 * ENH: Only one doxygen config.in file is needed
831 * FIX: make install should be ok now on ùnix plateform
832 * FIX: PATH to dictionary was wrong (missing /)
833 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
835 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
836 * vtkGdcmReader is now able to read rgb dicom file.
837 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
838 * added a gdcmViewer to vtk test, use mouse to control
839 window level & window width
841 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
842 * CMake-ification of gdcm, we have now two build system
843 * FIX: on cygwin Wsock32 doesn't exist
844 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
846 2003-10-06 Emanuel Ollart
847 * FIX : compilation process wad broken.
848 Changed gdcmViewer_sources to vtkgdcmViewer_sources
850 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
851 * change gdcmViewer -> vtkgdcmViewer
852 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
854 2003-10-06 Jean-Pierre Roux
855 * FIX :A few nasty patches to allow the reading of a lot of nasty images
856 ( e.g : well known GE images with a wrong elem length,
857 : Philips MRI Images with a wrong Huffman table)
858 * still to be done : allow the reading of bugged LEONARDO Siemens images
860 2003-10-03 Jean-Pierre Roux
861 * Odd length strings are padded with '\0' (not with spaces,
862 to remain compliant with already defined strings,
863 like Transfert Syntax UID and others)
865 2003-10-03 Jean-Pierre Roux
866 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
867 to allow displaying RGB images (not only by affim ;-)
869 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
870 * vtkGdcmReader is now able to read rgb dicom file.
871 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
873 2003-10-03 Jean-Pierre Roux
874 * A few nasty patches to allow the reading of a lot of nasty images
875 ( e.g : well known GE images with a wrong elem length,
876 : Philips MRI Images with a wrong Huffman table)
877 * still to be done : allow the reading of bugged LEONARDO Siemens images
879 2003-10-03 Jean-Pierre Roux
880 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
882 2003-10-03 Jean-Pierre Roux
883 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
884 to allow displaying RGB images (not only by affim ;-)
886 2003-10-03 Jean-Pierre Roux
887 * gdcmFile::GetImageDataIntoVector now
888 - deals with MultiFrames MultiFragments Run Length Encoded files
889 - deals with YcBcR (YBR_FULL) files
890 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
891 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
895 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
896 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
897 Two reasons: - clear things
898 - third parties acces gdcm through header files, so won't
899 suffer anymore VC++ complains
901 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
902 * add argv[1] in testvtkGdcmReader.cxx
905 2003-09-24 Jean-Pierre Roux
906 * The lines are now eigthy characters long.for
907 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
909 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
910 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
911 char* to std::string. Thus, the use of strdup becomes useless. (see
912 previous commis of Malaterre)
913 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
914 before the last Malaterre's commit.
916 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
917 * This commit should fix the Debug building under VC++, the problem
918 was mainly a mixture of debug and release lib being loaded at startup.
919 * I also remove a depency to a specific C function: strdup. Because I had
920 to force the link to msvcrtd (whereas strdup is in libc).
922 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
923 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
924 located in the gdcmCommon.h file. All use of reference of tha has been
925 changed to now use the variable GDCM_UNFOUND.
927 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
929 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
930 Dicom dictionary. The test suite can now be run again. Note:
931 I'm note very happy with the " (RET)" changes. I believe this
932 RETAINED comment should be dropped when parsing the dictionary.
935 - AUTHORS updated and now in alphabetical order
936 * Makefile.am now exports gdcm.dsw for Windoze users.
938 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
939 * cygwin complains about missing std:: in subdir Test/
941 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
942 * remove some methods that are now in gdcmHeaderHelper
944 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
945 * vtkGdcmReader set spacing and origin correctly
947 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
948 * Fix a few delete/delete[] mismatch
950 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
951 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
952 interpretation to data given by gdcmHeader. For instance there are
953 heuristics to get informations (look at different places).
954 * it also include a specific class: gdcmSerieHeaderHelper devoted to
955 sorting DICOM images based on different strategies.
956 * modified Makefiles accordingly.
958 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
959 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
960 when building in debug mode
961 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
962 src/win32/gdcmdll.dsp
963 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
965 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
966 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
969 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
970 * src/win32/libgdcmjpeg12.dsp was not dos format
971 * src/win32/libgdcmjpeg12.dsp :
972 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
973 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
975 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
976 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
978 * src/gdcmFile.cxx : bug fix in affectation type
979 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
980 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
981 * Modifs of MVSC projects to compile them. Not concerning 2 identic
982 symbols... future problem ?
984 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
985 * src/win32/libgdcmijpeg12.dsp was missing
986 * modified gdcm.dsw accordingly
988 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
989 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
991 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
992 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
993 commit of JPR (before his hollidays to facilitate our work).
994 * setup.py : bug fix in code. Modifications made while the last commit
995 of JPR. The code hasn't been tested before the commit... it's so
996 useless to make that (for best programmer that is JPR) !!!
998 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * tagged the current version as Version0_3 (i.e. version 0.3)
1001 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1002 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1003 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1004 * *.dsp : modifications to use new libgdcmijpeg8 library
1005 * setup.py : bug fix on VTKPATH variable
1006 * PACKAGER : adding all concerning windows
1008 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1009 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1011 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1012 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1013 test suite reported error.
1014 * PACKAGER file added (describes what a packager must do when
1015 packaging a new release).
1016 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1017 * configure.in: upgraded version number to 0.3.0
1018 * fixing build of rpm (through rpm -ta):
1019 - Doc/Makefile.am exports proper doxygen files
1020 - src/jpeg/libijg8/Makefile.am exports the include files.
1022 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1023 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1024 * src/gdcmHeader.h : formatting code
1026 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1027 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1028 We were obtaining error message from vtk. Now, creation of file list
1029 is made in an internal list to prevent this problem.
1030 Bug fix when output is empty.
1031 Bug fix in update of progress value. Previous commit for this was a bad
1033 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1035 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1036 * src/gdcmHeader.h : added method to get the file name
1037 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1038 files. Added method to remove all files on the input
1039 Added FIXME comment concerning the bad parsing of header made by
1040 ExecuteInformation method (in ExecuteData method)
1042 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1043 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1044 when using make instal.
1045 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1046 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1048 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1049 * setup.py : adding include dir of jpeg lib to compile all sources
1050 * */Win32/*.dsp : JPR fix for windows compilation
1052 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1053 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1055 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1056 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1058 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1059 * setup.py is again effective on un*x (takes into account the
1060 addon of the jpeg library)
1061 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1062 * Doc/Doxy* updated (includes above enhancements)
1063 * INSTALL now points to web documentation
1065 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1066 * src/gdcmHeader.h doesn't make unnecessary reference to
1068 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1070 * src/gdcm*.[cxx|h] :
1071 - to allow compilation with gcc 3.x
1072 -- clean up of STL usage (added explicit usage of std::)
1073 -- small fixes on exceptions.
1074 Note: linking not tested !
1075 - clean of doxygen comments to avoid warnings at documentation
1077 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1078 dependent convertion).
1080 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * Clean up of previous JPR garbage commit (not even commented in the
1083 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1084 - moved all jpeg related files from src to src/jpeg/libijg8, with
1085 addition/modification of Makefile.am and configure.in.
1086 - the testSuite is still brain damage (not guilty).
1088 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1089 * WrapVTK.py : modifications to get correctly vtk source files to
1091 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1092 (FileName -> Filename)
1094 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * vtk/vtkGdcmReader.[cxx/h]:
1096 - UpdateProgress method should now be effective
1097 - removed the limitation on having only images loaded (as opposed
1099 - when building a stack of images/volume, a lesser number of
1100 gdcmHeader and gdcmFile instances should be used (hopefully
1101 accelerating things).
1102 - when building a stack of images/volumes, files which are not
1103 loadable (wrong path-filename, wrong permissions on existing file,
1104 or file not parsable by gdcm) are replaced with a black image
1105 in the stack (for the caller to notice the problem).
1107 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1108 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1110 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1111 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1112 between standard library (std) and vtk library (problems are found
1113 under Windows... thanks Windows !)
1115 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1116 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1118 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1120 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1123 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1124 * When compiling with distutils (see setup.py) the C++ compiler is
1125 called with different flags than the default ones (with automake).
1126 In order to fix all those warning, I compiled gdcm with the command
1127 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1128 and went for warning fixes:
1129 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1130 up from unused variables.
1131 - vtk/vtkGdcmReader.cxx: potential bug fix.
1132 * src/gdcmHeader.h: Doxygen warning cleanup
1134 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1135 * gdcmPython/gdcm.i:
1136 - typemaps correction to take into account the systematic replacement
1137 of "using namespace std" with std:: prefix e.g. std::list,
1138 std::string... (cf changes of 2003-05-21).
1139 - gdcmGlob global variable of type gdcmGlobal (defined in
1140 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1141 exported to Python a as cvar.
1142 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1143 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1144 gdcmDictSet.GetPubDictTagNames() and
1145 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1146 C++ static methods).
1147 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1148 with the above changes.
1150 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1151 * setup.py, manifest.in : bug fix under linux
1153 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1154 * Modification of setup.py to compile vtk part too. Then, we have 2
1155 wrappers which must work with same distutils. For that, we have a
1156 generic distutils in distusiltsWrapping.py ; with :
1157 - build_extWrap class to wrap generically all extensions,
1158 - ExtensionWrap base class for all wrapping extension that contains
1160 - Wrapper interface which wrap sources
1161 + In WrapSwig.py we have extension and wrapper for Swig
1162 + In WrapVTK.py we have extension and wrapper for VTK
1163 * MANIFEST.in : modifications to consider vtk directory and new python
1164 files for compilation
1166 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1167 * Added python wrappers of vtkGdcmReader vtk class (see the
1168 source in vtk/vtkGdcmReader.cxx) :
1169 - vtk/Makefile.am now builds a library
1170 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1171 python library (as opposed to _gdcm.so wich are the python
1172 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1173 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1175 - configure.in has an additional flag --enable-vtk that needs
1176 to be set to enable compilation of vtk related code, that is:
1177 + vtk/vtkGdcmReader.so and
1178 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1179 + gdcmPython/vtkgdcmPython.so (see above)
1180 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1181 be read when compressed or when HighBit + 1 != BitsStored),
1182 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1183 the usage of the python wrapper of vtkGdcmReader vtk class.
1184 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1185 * src/*.[h] all occurences of stl classes are now prefixed with
1186 std::, and all occurences of "using namespace std;" where removed.
1187 This is to avoid pollution of global namespace in included files.
1188 Apparently vtk does not avoid this pitfall: when using both
1189 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1190 collision of various stl members (principally cout...).
1191 * gdcmPython/testSuite.py now cleanly removes temprory generated
1193 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1194 comply with above changes)
1196 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1197 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1198 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1199 vtk data structure (an image Flip was required).
1200 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1201 * cosmetic changes in documentation.
1203 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1204 * src/gdcmHeader.cxx: the constructor no longer exits when an
1205 unexisting file is given as argument.
1206 * The subdirectory Data (containing all the images used for the
1207 test suite) is not part of this repository anymore. A new module
1208 containing those images is now available at
1209 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1210 with the name gdcmData.
1211 All the python scripts (including the package initialisation file
1212 gdcmPython/__init__.py) were adapated to take this change into
1213 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1215 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1216 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1217 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1218 demo of the usage of this class.
1219 Compilation of this vtk part is only done when using the --enable-vtk
1220 at configure (or autogen.sh) stage.
1222 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1223 * More memory link related corrections and documentation fixes.
1225 - maximum info is obtained with a command of the form:
1226 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1227 --show-reachable=yes PrintHeader
1228 - the remaining reachable blocks seem to come from the STL
1229 allocation scheme through the usage of map and list. It looks
1230 like this memory cannot be freed but it is not a memory leak
1231 (in fact further invocation to the STL would recollect the
1232 unused memory allthough it cannot explicitely be freed).
1233 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1234 of displaying an image parsed with gdcm and displayed with VTK.
1235 Note: some images don't seem to work e.g.
1236 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1237 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1238 Allthough this weakens the semantics, it is a ditch attempt to
1239 make gdcm more thread friendly.
1241 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1242 * Memory link hunt (by using valgrind through the command
1243 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1244 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1245 gdcmHeader::_dicom_vr.
1246 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1247 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1249 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1251 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1252 * src/Makefile.am now exports all the necessary include files at
1256 * UpdateGroupLength replaced by new one
1259 * UpdateGroupLength re-written using H-Table
1260 (named UpdateGroupLengthNew untill checks are over)
1262 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1263 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1264 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1266 - gdcmHeader::GetPubElValSet removed.
1267 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1268 UpdateGroupLength, WriteElements, Write.
1269 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1270 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1271 carried the same semantics.
1272 - src/gdcmHeaderIdo.cxx changed accordingly.
1273 - gdcmFile::WriteBase now regroups all the codes from previous
1274 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1275 - enum FileType moved to gdcmCommon.h
1276 * src/gdcmHeader.cxx AddDefault trashed
1277 * gdcmGetXSize added
1278 * getimageDataSize now calls gdcmGetXSize
1279 * Test/*.cxx changed to agree with above changes
1281 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1282 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1283 (to avoid double call by end user).
1284 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1285 by end user, since gdcmHeader::gdcmHeader now handles it.
1287 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1288 * gdcm/Doc many doxygen changes:
1289 - Doxyfile now has two different versions, DoxyfileUsers that generates
1290 the html.users end users oriented documentation and
1291 DoxyfileDeveloppers that generates the html.developper developper
1292 oriented documentation.
1293 - README changed accordingly
1294 - requirement.txt removed (old design info moved to TODO).
1295 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1296 DoxyMainPage.txt, DoxyPython.txt provide more information.
1297 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1298 be updated by simply regenerating the docs with doxygen and copying
1299 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1300 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1301 all the tests in the form "if (<map>.count() >1)" were removed.
1302 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1303 ill-formed documentation sections.
1304 * src/gdcmHeader.cxx: ditto
1306 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1307 * setup.py fixed for un*x (needed macro for stdint.h)
1308 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1309 un*ces with sh-utils test utility.
1310 * gdcmPython/demo/test.py renamed to PrintHeader.py
1311 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1312 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1313 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1314 * src/gdcm*.cxx JPR's bad inclusion fixed.
1316 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1317 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1318 * gdcmPython/demo/test.py changed accordingly.
1320 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1321 * gdcmPython/Makefile.am fixed linking against libstdc++
1322 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1323 * Swig subdir (historical tests of swig version 1.3.17++) removed
1324 * Test/testChangeEntete.cxx some lines commented out in order to make
1326 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1327 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1329 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1330 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1331 hence the user doesn't need this explicit call.
1332 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1333 i.e. LoadElements() call removed.
1334 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1335 - src/Makefile.am declares the proper flag for g++.
1336 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1337 for adding user defined new tags.
1338 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1339 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1340 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1342 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1343 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1344 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1345 src/Makefile.am : the project should properly compile and install
1346 with the autotools, included the python wrappers part.
1347 * gdcm.spec.in : added a spec file for RPM packaging.
1349 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1350 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1352 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1353 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1354 to exported to the environement (see gdcmPython/testSuite.py
1356 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1357 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1358 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1359 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1360 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1362 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * gdcmPython/__init__.py doesn't crash anymore when running in
1364 in InstallMode or PreInstallMode but with an environement given
1365 value of GDCM_DICT_PATH.
1366 * src/gdcmDictSet.[cxx/h] coding style.
1368 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1369 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1370 * src/gdcm.h general comments moved to TODO, and README
1371 * src/gdcm.h should now be seen as a user commodity (including it
1372 should suffice to fully use gdcm). It is nowhere including within
1373 any of the kernel files src/*.cxx and src/*.h.
1375 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1376 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1377 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1379 * src/gdcm*.cxx only include their corresponding include file
1380 (as opposed to gdcm.h)
1381 * gdcmPython/gdcm.i changed accordingly
1382 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1383 the autogen.sh generated "make snapshot" command to work.
1384 * autogen.sh removed history related references to crea package.
1386 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1387 * distutilsSwigCPlusPlus.py work around some swig portability
1390 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1391 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1392 was done in a last ditch attempt to get setup.py _really_
1393 operationnal. The python/gdcmPython layaout add the advantage
1394 of hidding away the python related distutils specific files
1395 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1396 Alas, the src directory was out of scope (i.e. it's relative
1397 position to setup.py was ../src) which made things impossible to
1398 handle (see previous version of python/setup.py). Crossing fingers...
1400 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * python/setup.py now works on Un*x. (harder than I thougth)
1402 * python/distutilsSwigCPlusPlus.py can now have include files
1403 among the list of sources.
1405 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1406 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1407 * modifications in MSVC projects
1409 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1410 * As stated by the first lines of Test/ExceptionAndPython/README, it
1411 looks like we can move back to original usage of exception within
1412 src/gdcm* and hence remove the errno stuff that was introduced
1413 as a quick and dirty fixture of this problem (added to the TODO).
1414 * Doc/Doxyfile configuration file for Doxygen and corresponding
1415 README file for usage added.
1416 * Test/testWrite.cxx added. This new test comes from a split of
1417 test.cxx that is now reverted to its original purpous i.e.
1418 testing the proper parsing of a Dicom related file.
1419 testWrite.cxx concentrates on testing the IO part of gdcm.
1420 * Test/bug1.cxx (containing a bug on WIn32) added.
1421 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1422 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1423 whose purpose is to publish the content of the TagNames of the
1424 Dicom public dictionnary were not accessible without an
1425 instance of class gdcmHeader.
1426 - those methods are now static methods of gdcmDictSet and hence
1427 require no instances at all to be invocated.
1428 - within gdcmDictSet this change required to change some method
1429 to class methods (i.e. are now static) among which SetDictPath
1430 (renamed to BuildDictPath) and LoadDefaultPubDict.
1431 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1432 the above changes by calling the new method classes of gdcmDictSet.
1433 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1434 the above to be effective.
1435 * python/gdcmPython: in order to wrap properly the above changes
1436 for Python, swig version now needs to be > 1.3.17.
1437 * python/gdcmPython/Makefile fixed to adapt itself to new
1438 configure/make shema introduced by Johan Montagnat (thanks for the
1439 contribution). Alas this Makefile cannot be turned into a proper
1440 Makefile.am without some heavy changes in the configure.in
1441 (for python dectection).
1442 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1443 now avoids publishing the empty entries.
1445 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1446 * python/setup.py : bug fix concerning install under windows
1447 ExtraPath reused :-P
1448 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1450 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1451 * Dicts/dicomV3.dic : remove double spaces !!!
1452 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1453 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1456 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1458 method. Doxygenation.
1459 * src/gdcm.h clean up of JPR spurious comments.
1461 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1462 * python/distutilsSwigCPlusPlus.py now properly collects the
1463 shadow classes generated by "swig -c++" (gdcm.py in our case)
1464 when using "python setup.py install".
1465 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1466 reexports the working classes.
1467 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1468 by the classical C errno scheme. This is to prevent an obscure
1469 behavior of the python wrappers when importing wxPython.wx prior
1470 to gdcmPython (which ended up in an abort call). An illustration
1471 of this oddity can be found in the Test/ExceptionAndPython
1472 subdir (see the README file). This problem probably due to
1473 an combination of g++ and dynamic loading.
1474 * added Test/ExceptionAndPython (see above)
1476 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1477 * Changed the layout of the python part to avoid bloating main
1478 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1479 i.e. the distutils arsenal. All the python related stuff is
1480 again in a python subdir, but the package itself is now in
1482 * setup.py was cleaned up:
1483 - pythonIncludePath removed
1484 - python setup.py bdist target is now functional.
1485 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1486 collision with other packages). gdcmPython/demo/*.py changed
1489 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1490 * python subdir moved to gdcmPython (preparation of distutils packaging).
1491 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1492 distutils installer is operational.
1493 * - gdcmPython/__init__.py now properly loads the swig generated
1494 shadow classes (from gdcm.py).
1495 - gdcmPython/demo/*.py changed to import the package gdcmPython
1496 instead of gdcmPython/demo/load.py.
1497 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1499 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1500 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1501 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1502 entries within the associated public Dicom dictionary resp. the same
1503 information but sorted by the fourth field (PAT, IMG, DIR) of the
1505 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1506 are now in the "???" group.
1507 - python/gdcm.i changed accordingly,
1508 - python/demo/printGroupedPublicDict.py added, that gives an example
1509 of the above new functionalities in Python.
1511 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1512 * src/gdcm.h, gdcmHeader.cxx:
1513 - historic references to glib's g_malloc and g_free (#defined)
1514 were definitively removed.
1515 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1516 * src/gdcmElValSet.cxx:
1517 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1518 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1519 - GetElValue(string) renamed to GetElValueByName.
1520 - Added GetElementByName(string).
1521 * src/gdcmHeader.cxx: added
1522 - GetPubElValRepByNumber(guint16, guint16)
1523 - GetPubElValRepByName(string)
1524 - GetShaElValRepByNumber(guint16, guint16)
1525 - GetShaElValRepByName(string)
1526 - GetShaElValByNumber(guint16, guint16)
1527 - GetShaElValRepByName(string)
1528 - GetElValRepByNumber(guint16, guint16)
1529 - GetElValRepByName(string)
1530 - GetElValByNumber(guint16, guint16)
1531 - GetElValRepByName(string)
1532 * Doc/requirements.txt added.
1534 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1535 * Test/Makefile building now depends on the one of libgdcm.so
1536 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1537 pixel data) aware which enables finding the address (offset) of
1538 the pixel data of JPEG encoded DICOM files. This leaves only a single
1539 file in the testSuite whose pixel data address (offset) is unknown.
1540 * python/testSuite.py changed accordingly.
1542 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1543 * VC++ has some strong limitations when working with the STL, as stated
1544 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1545 "Also note that some STL containers (map, set, queue, list, deque)
1546 cannot be exported. [...]
1547 Some STL classes contain nested classes. These classes can not
1549 This is caused by a designed limitation that once a template
1550 class is instantiated, it can not be re-instantiated and
1552 Since our usage of map<> is ubiquitous in gdcm, this "designed
1553 limitation" of VC++ is a pitfall.
1554 Hence the Python wrappers of gdcm cannot be incrementally linked
1555 against the c++ dynamic library. The dirty but only workaround is
1556 to forget about incremental link of dynamic libraries and to generate
1557 the Python wrappers library with the inclusions of the underlying C++
1559 The following modifications concern this matter on Win32/VC++:
1560 - wrapping python correct with standalone wrapped dll (don't use separate
1561 dll under windows !!!!)
1562 - python21_d debug mode enabled (ask Frog how to use it :-)
1563 - NO problem with having an STL member of class for example string in C++
1564 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1565 - Python test of dcmlib in Python is ok under windows on a large set
1567 * removed glib references
1568 * typedef's inserted in gdcm.i for correct swig type management
1570 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1571 * python/demo/*.py load.py extracted from test.py. Added explore.py
1572 that only displays required tags and testAll.py that parses all
1573 the files of the testsuite without using unittest.
1574 * python/testSuite.py other additional test on new files added.
1575 * Data/* new test files added accordingly to the testSuite.
1576 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1577 the vr in the file differs from the one of the dictionary.
1579 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1580 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1581 values, but limits itself to values which are below a user specified
1582 size (by default 1024 bytes).
1583 * python/gdcm.i : elements not loaded (because their size is above the
1584 user specified treshold) are exported with their TagKey as key of the
1585 python dictionary. This enables the testsuite to make some checks
1586 on the unloaded elements (since we have their offset and size).
1587 * python/testSuite.py
1588 - now tests for the existence and proper value of the pixel data
1589 - two new examples added.
1590 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1592 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1593 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1594 aware. See the strategy comments in gdcmHeader::FindeLength().
1595 * Test/test.cxx now accepts a filename as first argument.
1596 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1597 * python/testSuite.py changed to integrate test on above files.
1599 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1600 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1601 the vr was also RET.
1602 * python/testSuite.py more tests added.
1604 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1605 * python/testSuite.py unittest test suite added (uses Data)
1606 * Data/* dcm and acr files for the test suite.
1607 * glib dependance removed from un*x version. We now use ISO C99
1608 7.18 Integer types (see stdint.h)
1609 - python/Makefile, src/Makefile src/gdcm.h
1610 * src/ when an explicit vr (like dicom files) suddenly poped an
1611 implicit element we use to mark the underlying DictEntry of the
1612 concerned ElValue with "Implicit". This strategy was damageable
1613 too the public or provite dictionaries, since some of their vr
1614 would be changed. Since Header::FindLength heavily relies on the
1615 detection by Header::FindVR of falsely explicit elements, I
1616 added an extra ImplicitVr member to ElValue (boolean).
1617 The rest of the changes we the necessary adaptations.
1619 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1620 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1622 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1624 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1625 * Adaptation for porting to VC++:
1627 o forced to use std namespace (for string to be known)
1628 o all class use __declspec export style on WIN32
1629 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1630 (in stdlib.h on Win32 but in std:: for gcc)
1631 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1632 variable GDCM_DICT_PATH.
1633 * src/gdcmHeader.cxx verbose comments made discrete.
1635 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1636 * python/gdcm.i: added a typemap that converts a C++ hashing table
1637 to native Python dictionary.
1638 * python/demo/test.py:
1639 - now uses the native dictionary for exploration of gdcmHeader.
1640 - takes an optional filename argument (the file to parse).
1641 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1642 PubElVals hashing table.
1643 * Dicts/dicomV3.dic removed error prone trailing spaces.
1645 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1646 * Python wrapping process moved away from src/Makefile to
1647 newly created python/Makefile (as well as gdcm.i)
1648 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1649 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1650 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1651 from the environement variable GDCM_DICT_PATH (when existing).
1652 * src/gdcmDict::GetTag bug fix.
1654 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1655 * Straightforward temporary fixes for swig to build the python wrappers.
1656 src/Makefile now has a python working entry [by working we mean
1657 that we can import de shadow classes without errors].
1659 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * hashtest.cxx removed (since allready in Test)
1661 * src/gdcmlib.h renamed to src/gdcm.h
1662 * src/dcm.i renamed to src/gdcm.i
1663 * src/Makefile prepared for python wrapping
1665 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * src/gdcmHeader.cxx :
1667 - Parsing of header is now separated from loading of element values
1668 (see gdcmHeader::LoadElements).
1669 - general clean up of hopefully all file access (creation of
1670 ReadInt16 and ReadInt32)
1672 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1673 * src/gdcmHeader.cxx :
1674 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1676 - SetLgrElem renamed to SetLength
1677 - GetLgrElem renamed to GetLength
1678 - ~gdcmHeader() made virtual to pesky warning messages at compile.
1679 * src/gdcmElValSet.cxx fixed both GetElValue methods
1680 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
1681 due to IdoDude was cleaned out.
1683 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1684 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
1685 concentrates on finding the value representation (when it exists).
1686 RecupLgr now only finds the element value length, and it avoids
1687 returning the unecessary skL (skipped length).
1688 Also, offsetCourant was simply removed (with taille_fich) since
1689 it was redundant with the File position internals (by using
1690 ftell and fseek). This also made skL (see above in RecupLgr) usage
1692 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
1693 on the libido specificities which are handled through class
1695 * Test/implicit_vr.dcm dicom v3 in implicit value representation
1698 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1699 * Truckload of changes. Parsing of header is barely functional
1700 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
1702 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1703 * src/gdcmHeader.cxx many addons of low level methods
1705 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1706 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
1707 and _IdDcmSWAP_LONG.
1709 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1710 * This corresponds to all the changes decided at the meeting of
1711 May 23 2002. Needless to say we are running late...