1 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
3 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
4 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
5 commit of JPR (before his hollidays to facilitate our work).
6 * setup.py : bug fix in code. Modifications made while the last commit
7 of JPR. The code hasn't been tested before the commit... it's so
8 useless to make that (for best programmer that is JPR) !!!
9 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
10 * tagged the current version as Version0_3 (i.e. version 0.3)
11 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
13 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
14 * *.dsp : modifications to use new libgdcmijpeg8 library
15 * setup.py : bug fix on VTKPATH variable
16 * PACKAGER : adding all concerning windows
17 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
18 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
20 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
21 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
22 test suite reported error.
23 * PACKAGER file added (describes what a packager must do when
24 packaging a new release).
25 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
26 * configure.in: upgraded version number to 0.3.0
27 * fixing build of rpm (through rpm -ta):
28 - Doc/Makefile.am exports proper doxygen files
29 - src/jpeg/libijg8/Makefile.am exports the include files.
30 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
32 * src/gdcmHeader.h : formatting code
33 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
35 We were obtaining error message from vtk. Now, creation of file list
36 is made in an internal list to prevent this problem.
37 Bug fix when output is empty.
38 Bug fix in update of progress value. Previous commit for this was a bad
40 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
41 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmHeader.h : added method to get the file name
43 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
44 files. Added method to remove all files on the input
45 Added FIXME comment concerning the bad parsing of header made by
46 ExecuteInformation method (in ExecuteData method)
47 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
48 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
49 when using make instal.
50 * src/gdcmFile.cxx : bug fix under Window after JPR commit
51 RQ : the JPR doesn't appear in the ChangeLog... normal for him
52 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * setup.py : adding include dir of jpeg lib to compile all sources
54 * */Win32/*.dsp : JPR fix for windows compilation
55 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
58 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
59 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
60 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
61 * setup.py is again effective on un*x (takes into account the
62 addon of the jpeg library)
63 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
64 * Doc/Doxy* updated (includes above enhancements)
65 * INSTALL now points to web documentation
66 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
67 * src/gdcmHeader.h doesn't make unnecessary reference to
69 * gdcmPython/Makefile.am now avoids calling the wrappers for the
72 - to allow compilation with gcc 3.x
73 -- clean up of STL usage (added explicit usage of std::)
74 -- small fixes on exceptions.
75 Note: linking not tested !
76 - clean of doxygen comments to avoid warnings at documentation
78 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
79 dependent convertion).
80 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
81 * Clean up of previous JPR garbage commit (not even commented in the
83 - Test/Makefile.am removed the reference to unexisting testTS.cxx
84 - moved all jpeg related files from src to src/jpeg/libijg8, with
85 addition/modification of Makefile.am and configure.in.
86 - the testSuite is still brain damage (not guilty).
87 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * WrapVTK.py : modifications to get correctly vtk source files to
90 * vtk/vtkGdcmReader.cxx : modification for an already existing name
91 (FileName -> Filename)
92 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
93 * vtk/vtkGdcmReader.[cxx/h]:
94 - UpdateProgress method should now be effective
95 - removed the limitation on having only images loaded (as opposed
97 - when building a stack of images/volume, a lesser number of
98 gdcmHeader and gdcmFile instances should be used (hopefully
100 - when building a stack of images/volumes, files which are not
101 loadable (wrong path-filename, wrong permissions on existing file,
102 or file not parsable by gdcm) are replaced with a black image
103 in the stack (for the caller to notice the problem).
104 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
105 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
106 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
108 between standard library (std) and vtk library (problems are found
109 under Windows... thanks Windows !)
110 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
111 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
113 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
114 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
115 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
116 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
117 * When compiling with distutils (see setup.py) the C++ compiler is
118 called with different flags than the default ones (with automake).
119 In order to fix all those warning, I compiled gdcm with the command
120 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
121 and went for warning fixes:
122 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
123 up from unused variables.
124 - vtk/vtkGdcmReader.cxx: potential bug fix.
125 * src/gdcmHeader.h: Doxygen warning cleanup
126 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 - typemaps correction to take into account the systematic replacement
129 of "using namespace std" with std:: prefix e.g. std::list,
130 std::string... (cf changes of 2003-05-21).
131 - gdcmGlob global variable of type gdcmGlobal (defined in
132 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
133 exported to Python a as cvar.
134 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
135 and GetPubDictTagNamesByCategory() as a replacement for deprecated
136 gdcmDictSet.GetPubDictTagNames() and
137 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
139 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
140 with the above changes.
141 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * setup.py, manifest.in : bug fix under linux
143 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * Modification of setup.py to compile vtk part too. Then, we have 2
145 wrappers which must work with same distutils. For that, we have a
146 generic distutils in distusiltsWrapping.py ; with :
147 - build_extWrap class to wrap generically all extensions,
148 - ExtensionWrap base class for all wrapping extension that contains
150 - Wrapper interface which wrap sources
151 + In WrapSwig.py we have extension and wrapper for Swig
152 + In WrapVTK.py we have extension and wrapper for VTK
153 * MANIFEST.in : modifications to consider vtk directory and new python
154 files for compilation
155 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
156 * Added python wrappers of vtkGdcmReader vtk class (see the
157 source in vtk/vtkGdcmReader.cxx) :
158 - vtk/Makefile.am now builds a library
159 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
160 python library (as opposed to _gdcm.so wich are the python
161 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
162 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
164 - configure.in has an additional flag --enable-vtk that needs
165 to be set to enable compilation of vtk related code, that is:
166 + vtk/vtkGdcmReader.so and
167 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
168 + gdcmPython/vtkgdcmPython.so (see above)
169 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
170 be read when compressed or when HighBit + 1 != BitsStored),
171 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
172 the usage of the python wrapper of vtkGdcmReader vtk class.
173 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
174 * src/*.[h] all occurences of stl classes are now prefixed with
175 std::, and all occurences of "using namespace std;" where removed.
176 This is to avoid pollution of global namespace in included files.
177 Apparently vtk does not avoid this pitfall: when using both
178 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
179 collision of various stl members (principally cout...).
180 * gdcmPython/testSuite.py now cleanly removes temprory generated
182 * gdcmPython/gdcm.i now declares a typemap for std::string (to
183 comply with above changes)
184 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
185 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
186 * vtk/vtkGdcmReader.cxx now properly inports the image in the
187 vtk data structure (an image Flip was required).
188 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
189 * cosmetic changes in documentation.
190 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
191 * src/gdcmHeader.cxx: the constructor no longer exits when an
192 unexisting file is given as argument.
193 * The subdirectory Data (containing all the images used for the
194 test suite) is not part of this repository anymore. A new module
195 containing those images is now available at
196 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
197 with the name gdcmData.
198 All the python scripts (including the package initialisation file
199 gdcmPython/__init__.py) were adapated to take this change into
200 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
201 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
202 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
203 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
204 demo of the usage of this class.
205 Compilation of this vtk part is only done when using the --enable-vtk
206 at configure (or autogen.sh) stage.
207 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
208 * More memmory link related corrections and documentation fixes.
210 - maximum info is obtained with a command of the form:
211 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
212 --show-reachable=yes PrintHeader
213 - the remaining reachable blocks seem to come from the STL
214 allocation scheme through the usage of map and list. It looks
215 like this memory cannot be freed but it is not a memory leak
216 (in fact further invocation to the STL would recollect the
217 unused memory allthough it cannot explicitely be freed).
218 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
219 of displaying an image parsed with gdcm and displayed with VTK.
220 Note: some images don't seem to work e.g.
221 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
222 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
223 Allthough this weakens the semantics, it is a ditch attempt to
224 make gdcm more thread friendly.
225 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
226 * Memory link hunt (by using valgrind through the command
227 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
228 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
229 gdcmHeader::_dicom_vr.
230 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
231 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
233 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
234 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
235 * src/Makefile.am now exports all the necessary include files at
238 * UpdateGroupLength replaced by new one
240 * UpdateGroupLength re-written using H-Table
241 (named UpdateGroupLengthNew untill checks are over)
243 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
244 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
245 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
247 - gdcmHeader::GetPubElValSet removed.
248 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
249 UpdateGroupLength, WriteElements, Write.
250 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
251 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
252 carried the same semantics.
253 - src/gdcmHeaderIdo.cxx changed accordingly.
254 - gdcmFile::WriteBase now regroups all the codes from previous
255 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
256 - enum FileType moved to gdcmCommon.h
257 * src/gdcmHeader.cxx AddDefault trashed
259 * getimageDataSize now calls gdcmGetXSize
260 * Test/*.cxx changed to agree with above changes
261 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
262 * src/gdcmHeader.h: LoadElements() is not a public method anymore
263 (to avoid double call by end user).
264 * Test/*.cxx LoadElements() doesn't need to be called explicitely
265 by end user, since gdcmHeader::gdcmHeader now handles it.
266 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * gdcm/Doc many doxygen changes:
268 - Doxyfile now has two different versions, DoxyfileUsers that generates
269 the html.users end users oriented documentation and
270 DoxyfileDeveloppers that generates the html.developper developper
271 oriented documentation.
272 - README changed accordingly
273 - requirement.txt removed (old design info moved to TODO).
274 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
275 DoxyMainPage.txt, DoxyPython.txt provide more information.
276 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
277 be updated by simply regenerating the docs with doxygen and copying
278 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
279 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
280 all the tests in the form "if (<map>.count() >1)" were removed.
281 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
282 ill-formed documentation sections.
283 * src/gdcmHeader.cxx: ditto
284 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * setup.py fixed for un*x (needed macro for stdint.h)
286 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
287 un*ces with sh-utils test utility.
288 * gdcmPython/demo/test.py renamed to PrintHeader.py
289 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
290 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
291 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
292 * src/gdcm*.cxx JPR's bad inclusion fixed.
293 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
295 * gdcmPython/demo/test.py changed accordingly.
296 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
297 * gdcmPython/Makefile.am fixed linking against libstdc++
298 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
299 * Swig subdir (historical tests of swig version 1.3.17++) removed
300 * Test/testChangeEntete.cxx some lines commented out in order to make
302 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
303 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
304 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
305 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
306 hence the user doesn't need this explicit call.
307 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
308 i.e. LoadElements() call removed.
309 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
310 - src/Makefile.am declares the proper flag for g++.
311 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
312 for adding user defined new tags.
313 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
314 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
315 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
316 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
317 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
318 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
319 src/Makefile.am : the project should properly compile and install
320 with the autotools, included the python wrappers part.
321 * gdcm.spec.in : added a spec file for RPM packaging.
322 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
323 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
324 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
326 to exported to the environement (see gdcmPython/testSuite.py
328 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
329 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
330 ElValue class renamed to gdcmElValue for obvious consistency reasons.
331 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
332 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
333 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
334 * gdcmPython/__init__.py doesn't crash anymore when running in
335 in InstallMode or PreInstallMode but with an environement given
336 value of GDCM_DICT_PATH.
337 * src/gdcmDictSet.[cxx/h] coding style.
338 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
339 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
340 * src/gdcm.h general comments moved to TODO, and README
341 * src/gdcm.h should now be seen as a user commodity (including it
342 should suffice to fully use gdcm). It is nowhere including within
343 any of the kernel files src/*.cxx and src/*.h.
344 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
345 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
346 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
348 * src/gdcm*.cxx only include their corresponding include file
349 (as opposed to gdcm.h)
350 * gdcmPython/gdcm.i changed accordingly
351 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
352 the autogen.sh generated "make snapshot" command to work.
353 * autogen.sh removed history related references to crea package.
354 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * distutilsSwigCPlusPlus.py work around some swig portability
357 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
358 * Eventually, python/gdcmPython was renamed to gdcmPython. This
359 was done in a last ditch attempt to get setup.py _really_
360 operationnal. The python/gdcmPython layaout add the advantage
361 of hidding away the python related distutils specific files
362 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
363 Alas, the src directory was out of scope (i.e. it's relative
364 position to setup.py was ../src) which made things impossible to
365 handle (see previous version of python/setup.py). Crossing fingers...
366 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
367 * python/setup.py now works on Un*x. (harder than I thougth)
368 * python/distutilsSwigCPlusPlus.py can now have include files
369 among the list of sources.
371 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
373 * modifications in MSVC projects
374 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * As stated by the first lines of Test/ExceptionAndPython/README, it
376 looks like we can move back to original usage of exception within
377 src/gdcm* and hence remove the errno stuff that was introduced
378 as a quick and dirty fixture of this problem (added to the TODO).
379 * Doc/Doxyfile configuration file for Doxygen and corresponding
380 README file for usage added.
381 * Test/testWrite.cxx added. This new test comes from a split of
382 test.cxx that is now reverted to its original purpous i.e.
383 testing the proper parsing of a Dicom related file.
384 testWrite.cxx concentrates on testing the IO part of gdcm.
385 * Test/bug1.cxx (containing a bug on WIn32) added.
386 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
387 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
388 whose purpose is to publish the content of the TagNames of the
389 Dicom public dictionnary were not accessible without an
390 instance of class gdcmHeader.
391 - those methods are now static methods of gdcmDictSet and hence
392 require no instances at all to be invocated.
393 - within gdcmDictSet this change required to change some method
394 to class methods (i.e. are now static) among which SetDictPath
395 (renamed to BuildDictPath) and LoadDefaultPubDict.
396 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
397 the above changes by calling the new method classes of gdcmDictSet.
398 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
399 the above to be effective.
400 * python/gdcmPython: in order to wrap properly the above changes
401 for Python, swig version now needs to be > 1.3.17.
402 * python/gdcmPython/Makefile fixed to adapt itself to new
403 configure/make shema introduced by Johan Montagnat (thanks for the
404 contribution). Alas this Makefile cannot be turned into a proper
405 Makefile.am without some heavy changes in the configure.in
406 (for python dectection).
407 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
408 now avoids publishing the empty entries.
409 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * python/setup.py : bug fix concerning install under windows
412 * gdcm.dsw : bug fix concerning path for libraries for python !!!
413 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * Dicts/dicomV3.dic : remove double spaces !!!
415 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
416 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
418 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
419 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
420 method. Doxygenation.
421 * src/gdcm.h clean up of JPR spurious comments.
422 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * python/distutilsSwigCPlusPlus.py now properly collects the
424 shadow classes generated by "swig -c++" (gdcm.py in our case)
425 when using "python setup.py install".
426 * python/gdcmPython/__init__.py imports gdcm.py and only manually
427 reexports the working classes.
428 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
429 by the classical C errno scheme. This is to prevent an obscure
430 behavior of the python wrappers when importing wxPython.wx prior
431 to gdcmPython (which ended up in an abort call). An illustration
432 of this oddity can be found in the Test/ExceptionAndPython
433 subdir (see the README file). This problem probably due to
434 an combination of g++ and dynamic loading.
435 * added Test/ExceptionAndPython (see above)
436 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
437 * Changed the layout of the python part to avoid bloating main
438 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
439 i.e. the distutils arsenal. All the python related stuff is
440 again in a python subdir, but the package itself is now in
442 * setup.py was cleaned up:
443 - pythonIncludePath removed
444 - python setup.py bdist target is now functional.
445 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
446 collision with other packages). gdcmPython/demo/*.py changed
448 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
449 * python subdir moved to gdcmPython (preparation of distutils packaging).
450 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
451 distutils installer is operational.
452 * - gdcmPython/__init__.py now properly loads the swig generated
453 shadow classes (from gdcm.py).
454 - gdcmPython/demo/*.py changed to import the package gdcmPython
455 instead of gdcmPython/demo/load.py.
456 - gdcmPython/testSuite.py changed to import the package gdcmPython.
458 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
460 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
461 entries within the associated public Dicom dictionary resp. the same
462 information but sorted by the fourth field (PAT, IMG, DIR) of the
464 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
465 are now in the "???" group.
466 - python/gdcm.i changed accordingly,
467 - python/demo/printGroupedPublicDict.py added, that gives an example
468 of the above new functionalities in Python.
469 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * src/gdcm.h, gdcmHeader.cxx:
471 - historic references to glib's g_malloc and g_free (#defined)
472 were definitively removed.
473 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
474 * src/gdcmElValSet.cxx:
475 - GetElement(guint32, guint32) renamed to GetElementByNumber.
476 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
477 - GetElValue(string) renamed to GetElValueByName.
478 - Added GetElementByName(string).
479 * src/gdcmHeader.cxx: added
480 - GetPubElValRepByNumber(guint16, guint16)
481 - GetPubElValRepByName(string)
482 - GetShaElValRepByNumber(guint16, guint16)
483 - GetShaElValRepByName(string)
484 - GetShaElValByNumber(guint16, guint16)
485 - GetShaElValRepByName(string)
486 - GetElValRepByNumber(guint16, guint16)
487 - GetElValRepByName(string)
488 - GetElValByNumber(guint16, guint16)
489 - GetElValRepByName(string)
490 * Doc/requirements.txt added.
491 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * Test/Makefile building now depends on the one of libgdcm.so
493 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
494 pixel data) aware which enables finding the address (offset) of
495 the pixel data of JPEG encoded DICOM files. This leaves only a single
496 file in the testSuite whose pixel data address (offset) is unknown.
497 * python/testSuite.py changed accordingly.
498 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
499 * VC++ has some strong limitations when working with the STL, as stated
500 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
501 "Also note that some STL containers (map, set, queue, list, deque)
502 cannot be exported. [...]
503 Some STL classes contain nested classes. These classes can not
505 This is caused by a designed limitation that once a template
506 class is instantiated, it can not be re-instantiated and
508 Since our usage of map<> is ubiquitous in gdcm, this "designed
509 limitation" of VC++ is a pitfall.
510 Hence the Python wrappers of gdcm cannot be incrementally linked
511 against the c++ dynamic library. The dirty but only workaround is
512 to forget about incremental link of dynamic libraries and to generate
513 the Python wrappers library with the inclusions of the underlying C++
515 The following modifications concern this matter on Win32/VC++:
516 - wrapping python correct with standalone wrapped dll (don't use separate
517 dll under windows !!!!)
518 - python21_d debug mode enabled (ask Frog how to use it :-)
519 - NO problem with having an STL member of class for example string in C++
520 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
521 - Python test of dcmlib in Python is ok under windows on a large set
523 * removed glib references
524 * typedef's inserted in gdcm.i for correct swig type management
525 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
526 * python/demo/*.py load.py extracted from test.py. Added explore.py
527 that only displays required tags and testAll.py that parses all
528 the files of the testsuite without using unittest.
529 * python/testSuite.py other additional test on new files added.
530 * Data/* new test files added accordingly to the testSuite.
531 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
532 the vr in the file differs from the one of the dictionary.
533 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
534 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
535 values, but limits itself to values which are below a user specified
536 size (by default 1024 bytes).
537 * python/gdcm.i : elements not loaded (because their size is above the
538 user specified treshold) are exported with their TagKey as key of the
539 python dictionary. This enables the testsuite to make some checks
540 on the unloaded elements (since we have their offset and size).
541 * python/testSuite.py
542 - now tests for the existence and proper value of the pixel data
543 - two new examples added.
544 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
545 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
546 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
547 aware. See the strategy comments in gdcmHeader::FindeLength().
548 * Test/test.cxx now accepts a filename as first argument.
549 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
550 * python/testSuite.py changed to integrate test on above files.
551 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
552 * Dicts/dicomV3.dic removed all the trailing (RET) when the
554 * python/testSuite.py more tests added.
555 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
556 * python/testSuite.py unittest test suite added (uses Data)
557 * Data/* dcm and acr files for the test suite.
558 * glib dependance removed from un*x version. We now use ISO C99
559 7.18 Integer types (see stdint.h)
560 - python/Makefile, src/Makefile src/gdcm.h
561 * src/ when an explicit vr (like dicom files) suddenly poped an
562 implicit element we use to mark the underlying DictEntry of the
563 concerned ElValue with "Implicit". This strategy was damageable
564 too the public or provite dictionaries, since some of their vr
565 would be changed. Since Header::FindLength heavily relies on the
566 detection by Header::FindVR of falsely explicit elements, I
567 added an extra ImplicitVr member to ElValue (boolean).
568 The rest of the changes we the necessary adaptations.
569 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
570 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
572 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
573 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
574 * Adaptation for porting to VC++:
576 o forced to use std namespace (for string to be known)
577 o all class use __declspec export style on WIN32
578 - src/gdcmUtil.cxx new Exit method that wraps the exit call
579 (in stdlib.h on Win32 but in std:: for gcc)
580 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
581 variable GDCM_DICT_PATH.
582 * src/gdcmHeader.cxx verbose comments made discrete.
583 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * python/gdcm.i: added a typemap that converts a C++ hashing table
585 to native Python dictionary.
586 * python/demo/test.py:
587 - now uses the native dictionary for exploration of gdcmHeader.
588 - takes an optional filename argument (the file to parse).
589 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
590 PubElVals hashing table.
591 * Dicts/dicomV3.dic removed error prone trailing spaces.
592 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
593 * Python wrapping process moved away from src/Makefile to
594 newly created python/Makefile (as well as gdcm.i)
595 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
596 * src/gdcmHeader::FindLength only looks for current vr when necessary.
597 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
598 from the environement variable GDCM_DICT_PATH (when existing).
599 * src/gdcmDict::GetTag bug fix.
600 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
601 * Straightforward temporary fixes for swig to build the python wrappers.
602 src/Makefile now has a python working entry [by working we mean
603 that we can import de shadow classes without errors].
604 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
605 * hashtest.cxx removed (since allready in Test)
606 * src/gdcmlib.h renamed to src/gdcm.h
607 * src/dcm.i renamed to src/gdcm.i
608 * src/Makefile prepared for python wrapping
609 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
610 * src/gdcmHeader.cxx :
611 - Parsing of header is now separated from loading of element values
612 (see gdcmHeader::LoadElements).
613 - general clean up of hopefully all file access (creation of
614 ReadInt16 and ReadInt32)
615 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
616 * src/gdcmHeader.cxx :
617 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
619 - SetLgrElem renamed to SetLength
620 - GetLgrElem renamed to GetLength
621 - ~gdcmHeader() made virtual to pesky warning messages at compile.
622 * src/gdcmElValSet.cxx fixed both GetElValue methods
623 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
624 due to IdoDude was cleaned out.
625 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
626 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
627 concentrates on finding the value representation (when it exists).
628 RecupLgr now only finds the element value length, and it avoids
629 returning the unecessary skL (skipped length).
630 Also, offsetCourant was simply removed (with taille_fich) since
631 it was redundant with the File position internals (by using
632 ftell and fseek). This also made skL (see above in RecupLgr) usage
634 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
635 on the libido specificities which are handled through class
637 * Test/implicit_vr.dcm dicom v3 in implicit value representation
639 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
640 * Truckload of changes. Parsing of header is barely functional
641 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
642 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * src/gdcmHeader.cxx many addons of low level methods
644 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
645 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
647 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
648 * This corresponds to all the changes decided at the meeting of
649 May 23 2002. Needless to say we are running late...