1 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/TestUtil.cxx : reformat the source code
3 * vtk/vtkGdcmReader.cxx : remove and change prints
4 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
6 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
7 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
9 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
11 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
13 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
15 by an eof to prevent all bad read of the file... and in this case, the
18 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * Example/Volume2Dicom.cxx : comment unused variables
20 * Test/PrintDicomDir.cxx : comment unused variables
21 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
22 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
23 method that is redondant with AddEntry.
24 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
27 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * Bug fix due my last commit (compilation under Windows).
29 * Example/Volume2Dicom : bug fix in the file and reformatting source code
30 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
32 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
34 - Remove printf / sprintf
35 - include iostream AFTER gdcm so we don't get warnings
36 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
38 - Also remove tons of include from header files, hopefully this should
39 speeup the compilation time, since it was becoming a dog slow.
40 - Remove gdcm.h as it include way too many files and slow down compilation
41 (plus it is not up to date)
42 - remove 'using namespace std' this is BAD !
44 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * Remove memory leaks on the DicomDir
46 * Remove some useless datas in DicomDirObject
47 * Add usefull methods in SQItem, to be complient withe the ElementSet
49 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
52 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
54 future, with convertion)
55 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
56 and ImageDataSize values. Remove the method to get the PixelReadConverter
57 from the output of the class
59 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
62 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
64 and vtkErrorMacro use.
65 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
67 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
70 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
71 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
72 The string leaves only in the fonction. So when we make a .c_str(), we
73 get the pointeur on the first element, element that will be destroyed
74 immediately after thee instruction.
75 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
76 file has been opened : the test must be made on the content of the
77 pointer and not directly on the pointer !
80 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
82 the python part recompiles
84 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
86 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
87 X session is killed (for my computer... it seems to not be identic on
90 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
92 avoid problems (otherwise, the difference test between the visible image
93 and the reference is incorrect. If the reference is greater than the
94 screen resolution, it's produce errors).
95 Can be used for only one image. Can be used with a visible flag.
96 * vtk/vtkGdcmReader.cxx : remove commented codes.
97 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
98 under windows at compilation
99 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
101 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
103 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
105 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
106 tests on the image size X, Y, Z
108 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
110 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
111 between the class name and the file name
113 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * src/ : fix compilation warnings for the Write method (2 different
115 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
116 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
117 variable... create a static method in gdcm::Document to access to
118 this variable content.
120 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
122 file, to be accessed by other files (like gdcmFile). Remove commented
123 code. Move the change of the header to the gdcmFile, using the
125 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
126 To be sure of that (and simplify calls), the Write of the header now
127 gets a file name and not a file pointer (std::ifstream).
128 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
129 DocEntryArchive. Remove all open of the written file
131 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
134 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
136 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
138 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
139 some corresponding methods. Write correctly the file and check before
141 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
142 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
143 is now on RGB datas (as before my last commit
144 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
146 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
148 Add a print information of the type of the entry
149 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
150 It was in the gdcmFile, and all write have been regrouped
151 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
152 Write correctly all dicom files (in decompressed mode only at this time)
153 * Test/ : test on files are now made using Raw datas and not color datas if
155 * Example/PrintFile.cxx : add more printings
157 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * Amelioration of code, remove some code copy. For the loading of
159 BinEntry (in gdcmDocument), add the test to verify if the file is already
162 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
164 remove a DocEntry in the header (push an empty DocEntry)
165 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
166 lines. Bug fix in the initialization of the PixelConvert and the
168 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
169 use in TestCopyDicom (now this test can run under windows... but fails)
170 * Test/TestCopyDicom.cxx : amelioration of the test :
171 - test the pixels written
172 - add test points to quickly find where is the error
173 - can set a file name input and output in arguments
174 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
175 amelioration of the test output
177 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
179 all replaced DocEntry's
180 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
181 Now, each needed DocEntry to modify is duplicated, modified and inserted
182 to the header using DocEntryArchive. Thus, after save, we can restore the
183 header initial state.
185 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
188 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
190 correct to copy it. The DictEntry is specified at the DocEntry creation,
191 then, it musn't change in the time.
192 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
193 header correctly. At this time, the change is only made for the first
194 level of the Document. In the future, it might consider sequences.
195 The change is made by replacing a DocEntry by an other that is created
196 outside the class. The old value is kept. When we restore the header
197 status, the added DocEntry is deleted and replaced by the old value.
198 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
199 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
200 set the write type to explicit VR, implicit VR or ACR. Add methods to set
201 the write mode to native, decompressed or RGB (but not used at this time)
203 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
205 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
207 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
208 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
209 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
211 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
212 set because already copied when copying the BinEntry's of the header
213 * Test/TestAllReadCompareDicom.cxx : remove warnings
215 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
217 Two problems appear when doing it :
218 - with the gdcmFile : when the GetImageData method is called, the pixels
219 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
220 datas (pixels). And each structure destruct the datas when it's
221 destructed. So we have two destructions for the same datas. To solve it,
222 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
223 datas or not. If it doesn't own datas, then they will not destroyed by
225 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
226 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
227 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
228 create a double destruction of the same DocEntry's. So, to solve it,
229 the TagHT is simply cleared and the DicomDir* elements are destroyed.
230 * TODO : add an entry concerning memory leaks in the DicomDir
232 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
234 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
237 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
238 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
239 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
240 after it have been deleted
242 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
243 * FIX: src/* fix the doxygen warnings.
244 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
245 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
246 was erroneously defined with a size of 15 instead of 16. [many thanks
247 to Jean Michel Rouet for pointing out this bug].
249 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
250 1. Finish merging JMR patch for writting DICOM from scratch
251 2. Fix -hopefully- bug with MONOCHROME and space vs null character
252 3. Use const ref when possible
253 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
254 5. A few more comments
255 6. CreateUniqueUID can now be called without parameter"
257 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * ENH: Slightly bigger patch:
259 1. Getting toward full integration of JMR patch for writting dicom from scratch
260 2. Update Test to test part of this patch: CreateUniqueUID
261 3. File was not close properly in gdcmDict
262 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
263 5. Use of const ref instead of copy (speed issue)
264 6. Remove temporary (duplicate) string in TranslateToKey
265 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
266 8. Do not repeat virtual in subclasses
267 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
269 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
270 * Apply first patch toward better string comparison when dealing with broken
271 DICOM files. Essentially the string could be padded with a space instead
272 of a null character as defined by standard
274 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
276 because never used... and in the same time, that's remove some memory leaks
278 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmFile.cxx : now delete the PixelConvert instance.
280 * In examples and tests : change the type of image data variables from void*
281 to uint8_t*. Remmove all delete on image data variables
283 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
285 Verify the file pointer value before open the file, and if it's not null,
286 a verbose message is generated.
287 Close correctly the file when the file isn't considered dicom-like. The
288 correctly close is a call to CloseFile.
289 When closing the file pointer, test if its not null to close the file.
290 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
291 file. For an uncompressed image, the copied datas correspond in the least
292 case to the image size (calculated) or the image size specified in the
293 header. A verbose is generated if these two size mismatch
295 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
297 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
298 break under windows (with msvc6 compilation).
300 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
302 compiling with MSVC6)
304 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * Bugs fix for the Windows build with VC6
306 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
307 needed (only for projects required VTK). If the VTK is included in all
308 projects, there is conflicts with the jpeg lib of vtk when compiling the
309 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
310 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
311 when compiling the gdcm_wrap.cxx file (created by the compilation of the
313 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
314 (like it's already made for the cout use). Otherwise, conflict with the
317 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
320 - comments on the DicomDir::Method related usage added.
321 - now that we use the namespace gdcm, a lot of internal classes do
322 NOT need to be wrapped anymore.
323 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
324 DicomDir::Method) new example added.
326 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Improve string manipulation. I now inforce the notion of 'DicomString'
328 A DicomString can contain as many \0 as they want
329 and it is *always* of even length.
330 We only support odd length for very rare case.
331 And in the near future this should be removed.
333 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
334 * /binary_write/ gdcm source. Now even on big endian we are writting
335 little endian. This should -heopfully- fix some tests
337 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
338 * Now the dictionary is compiled into gdcm lib. This is a default
339 behavior, thus any dic file specified is picked before failback to
340 the one comiled into lib
342 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
343 * Change internals for gdcmDict. Don't use any 'new' any more.
344 This should definitely solve any leak problem, and we should be
345 as fast as before, as long as don't modify too much the dictionary.
347 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
348 * STYLE: ivars should start with a capital letter.
349 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
350 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
352 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
353 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
354 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
355 new 2004 dictionaries added (thanks to JPR).
356 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
357 * CLEANUP_ROUND (15) for gdcmPixelConvert
358 - RLEFrame::NumberFragments is now of type unsigned int
359 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
360 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
363 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
364 * Initial work in gathering all transfer syntax accessors. clearly
365 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
366 ivars, but only one transfersyntax (class) ivar with equivalent method on
369 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
370 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
371 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
372 discussed (plus I didn't like having a 2000 lines patch not commited)
374 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
376 * CLEANUP_ROUND (14) for gdcmPixelConvert
377 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
378 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
379 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
381 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
382 anymore and hence avoids storing a copy of PixelConvert::Decompressed
383 into File::Pixel_Data.
385 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
387 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
388 * CLEANUP_ROUND (13) for gdcmPixelConvert
389 Substituted File::ParsePixelData() with PixelConvert::Print() new
391 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
392 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
393 method to those classes.
394 - src/gdcmFile.[cxx|h]:
395 -- Added a ::Print() method.
396 -- PixelConverter is now a reference instead of a member.
397 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
398 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
400 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
402 collaboration diagram and inheritance diagram should be generated with
404 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
405 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
406 pointlessly wrapped (see
407 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
408 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
409 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
410 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
411 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
412 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
413 -- File::Initialise: PixelConverter setup moved away to
414 PixelConverter::GrabInformationsFromHeader()
415 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
416 interpretation moved away to PixelConverter::BuildRGBImage()
418 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
419 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
420 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
422 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
424 displayed on Win32 when a brutal abort() occurs (because of uncatched
425 exception). See TODO new entry of this commit for more on this.
426 * TODO added new entry.
427 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
428 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
429 - HandleColor is no longer called from gdcmFile.cxx
430 - gdcmPixelConvert.cxx clean up on method arguments and internal
431 variable names for semantical coherence.
433 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
434 * Finished lossless transition, not only do we now read all lossless jpeg
435 images, without the need of the Cornwell lib, but we do read them properly now
436 * To reduce code (well to avoid code duplication), I defined a common place
437 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
438 redefine symbols. This is not prefect but this the best solution I found for a
439 compilation time jpeg option.
441 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
442 * Update jpeg ijg lib to support lossless jpeg implementation
443 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
445 * Also added a special copyright for dcmtk since we use their bugfixes.
448 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
449 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
450 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
451 matters, as stated in warning note at begining of %include section).
452 * src/gdcmDicomDir*.[cxx|h]: coding style
453 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
454 * src/gdcmJpeg8.cxx: doxygen fix.
455 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
456 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
457 from File:: to PixelConvert::.
459 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
460 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
461 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
462 - more code moved away from File:: to PixelConvert::
463 - fat setup of PixelConverter set in place in File::Initialise.
465 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
466 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
467 namespace at the file system level. So now you should convert your examples
469 gdcmHeader -> gdcm::Header
470 It would be nice if people keep in mind to no open the namespace, since it
471 allows compilation on broken plateform which were defining common symbol in
472 the standart namespace (like LP, Unknown ...)
474 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
475 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
476 The JPEG fragments are now parsed at the same stage than the RLE
477 information. All code related to JPEG is now in gdcmPixelConvert:
478 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
479 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
480 export a gdcmFile:: method. Those are simply global functions
481 (for the time being this is better than having them attach to
482 either gdcmFile:: or gdcmPixelConvert::).
483 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
484 and stores the result in a gdcmJPEGFragmentsInfo.
485 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
486 code (among other stuff) moved away from gdcmFile:; to
489 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
491 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
492 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
493 clean up of RLE related code.
494 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
495 - src/gdcmRLE.cxx removed
496 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
497 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
498 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
499 * CLEANUP_ROUND (9) for gdcmPixelConvert
500 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
501 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
502 away from gdcmFile:: to gdcmPixelConvert::.
504 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
505 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
506 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
507 This is because Parse7Fe0 used to parse the pixels to compute the
508 length. This task was passed over to FindDocEntryLengthOB() a long
509 time ago, EXCEPT I had forgotten the OW case...
510 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
511 we just recylce the code for parsing RLE fragments and computing
513 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
514 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
515 with the retired Parse7Fe0().
516 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
517 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
519 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
520 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
521 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
522 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
523 - src/CMakeLists.txt: alphabetic order reodering + new entries.
524 * CLEANUP_ROUND (4) for gdcmPixelConvert
525 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
526 to return an unused length.
528 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
529 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
530 this should be cleanner from the plane view. The iostream are erally a pain
531 to use to do simple stuff.
533 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
534 * Redo the compilation of the ijg jpeg library. Now only one source is
535 necesseray. No need to rename file by hand what so ever. CMake handle the
536 copying of the file within different directory, configure header file to
537 modify some symbol. The only addition made to ijg wasd a mangle table so
538 that symbol are different wether we are within 8bits or 12bits.
540 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
541 * Added documentation of vtkgdcmReader on Website:
542 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
543 with it's binary name).
544 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
545 the Website to be more complete.
546 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
547 doxygenated documentation.
548 - Doc/DoxyVtkGdcmReaderExamples.txt added
549 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
550 DoxyVtkGdmReaderExamples.html )
551 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
552 * CLEANUP_ROUND (3) for gdcmPixelConvert
553 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
555 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
556 * CLEANUP_ROUND (2) for gdcmPixelConvert
557 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
559 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * CLEANUP_ROUND for gdcmPixelConvert:
561 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
562 - src/gdcmPixelStuff[h|cxx] removed
563 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
564 - src/CMakeLists.txt changed accordingly
566 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
567 gdcmVersion.py moved to newly created ATTIC related
568 gdcmPython/SetupOldies/ directory.
569 * Autotools clean up:
570 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
571 - autogen.sh configure.in acinclude.m4 python.m4 removed
573 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
574 * src/*.cxx *.h Reference to License.htm fixed to License.html.
575 * Doc/CMakeLists.txt, doxygen.config.in: fix.
576 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
578 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
579 * TODO updated with Mathieu suggestions. I proposed a template for
580 describing TODO entries and used it for new entries.
581 * Added Doc/Website/CodingStyle.html, Developpers.html,
582 DeveloppersPython.html, GdcmDataCvs.html and
583 DownloadVersion0_1.html, DownloadVersion0_3.html.
584 * Some Doc/*.txt Doxygen files (which do not really concern the
585 documentation itself, but the website) moved to html and
586 placed in directory Doc/Website:
587 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
588 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
589 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
590 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
591 * CMakeLists.txt changed accordingly.
592 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
593 DeveloppersPython.html
594 * INSTALL nows refers to Doc/Website/Installation.html
596 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
597 * Added Doc/Website directory, that contains a first raw version
600 2004-09-23 Jean-Pierre Roux
601 * FIX In order not to be poluted any longer by casting problems,
602 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
603 we can now delete[] it safely
604 * VoidArea is now called BinArea (less confusing name),
605 and all the methods called ...VoidArea... are now ... BinArea...
606 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
608 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
609 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
610 clear) TagHT, which is an inherited member of gdcmElementSet. It is
611 up to the destructor of gdcmElementSet to clean up TagHt and it's
614 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
615 * Test/CMakeLists.txt: update to follow gdcmData renamings.
616 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
618 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
619 * ENH: added some utility method that builds a flat dictionnary
620 holding all the Dicom entries contained in the recursive structure
621 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
623 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
624 BuildFlatHashTable() that build a flat dictionary.
625 - src/gdcmElementSet.h: added a new private GetTag() accessor.
626 gdcmDocument is now a friend of gdcmElementSet.
627 - src/gdcmElementSet.cxx: clean up.
628 - Example/FlatHashTablePrint.cxx added.
629 - Example/CmakeLists.txt changed accordingly
631 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
633 moved away from gdcmDocEntrySet (since this class is an abstract class
634 acting like an interface). SQDepthLevel and BaseTagKey are now
636 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
637 and associated accessors. Doxygenation of the class.
638 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
640 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
641 Use SQDepthLevel accessor instead. ::Print() adapted.
642 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
643 - src/gdcmDocument.cxx changed accordingly.
645 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
647 - The following is the doxygen comment of the typedef declaration
648 of gdcmagKey in src/gdcmCommon.h:
649 gdcmTagKey is made to old an "universal" (as in URL, Universal
650 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
651 A dicom tag allways has a group and an element, but a set of tags
652 embeded in various (optionally nested) sequences and sharing
653 the same group and element all share the same (group, element)
654 "identifier". Hence the (group, element) cannot be used as an
655 identifier (in gdcm we shall refer to a "TagKey") of a tag.
656 In order to construct a proper tag identifier (i.e. a key) we
657 consider the following definition of a TagKey:
658 - let Group, Element be the string representation of the
659 group and element dicom tag members,
660 - let ItemNumber be the string representation of the integer
661 index of the considered item number of a sequence,
662 Let the key of a tag embeded in a sequence, noted SeqTag, be
664 /ItemNumber#Group|Element
665 where "/", "#" and "|" are characters acting as separators.
666 Then the general form of a gdcmTagKey is given by:
667 Group|Element<SeqTag>
668 where <SeqTag> means NO or many instances of SeqTag.
669 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
672 but the gdcmTagKey of a tag "embeded" is the first item of
673 a sequence, itself nested in the third item of a sequence is the
675 0004|1220/2#0008|0082/0#0008|0090
676 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
677 order to hold the new sequence compatible key. Previously, the
678 GetKey() method would look in the underlying gdcmDictEntry.
679 - src/gdcmDocEntry.cxx:
680 -- constructor now copies the underlying DictEntry key, in the local
682 -- ::Print: displays the member Key, instead of the (group, element).
683 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
684 - src/gdcmDocEntrySet.h:xi
685 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
686 -- now has a new BaseTagKey member.
688 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
689 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
691 This poses the problem with the semantics of the following lines
692 LoadEntryVoidArea(0x0028,0x1201); // R LUT
693 LoadEntryVoidArea(0x0028,0x1202); // G LUT
694 LoadEntryVoidArea(0x0028,0x1203); // B LUT
695 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
696 to the long FIXME note for what the problem is. Nevertheless in
697 order to get things working the dicom dictionary was altered !
698 Please fix things urgently...
699 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
700 information), see above note on moving the member VoidArea. Nevertheless
701 the following entries previously correctly set as US are now inproperly
703 0028 1201 OW IMG Red Palette Color Lookup Table Data
704 0028 1202 OW IMG Green Palette Color Lookup Table Data
705 0028 1203 OW IMG Blue Palette Color Lookup Table Data
706 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
707 of gdcmDocEntry moved to gdcmSeqEntry.
708 * src/gdcmSeqEntry.cxx: STYLE.
710 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
711 * Test/TestAllEntryVerify.cxx minor fix and added comments.
713 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
714 * gdcmPython/testSuite.py: all the test suite in python is now moved
715 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
716 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
717 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
719 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
720 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
721 to avoid inclusion recursion until STL is reached.
722 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
723 mecanism. errno.h is not included in gdcm anymore.
724 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
725 (gdcmFormatError now inherits from gdcmFormatUnexpected).
727 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
728 gdcmData/TestAllEntryVerifyReference.txt
729 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
730 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
731 exception_on_error parameter.
732 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
733 - vtk/vtkGdcmReader.cxx changed accordingly,
734 - Example/*.cxx and Test/*.cxx changed accordingly.
736 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
737 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
738 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
739 enable_sequences removed from gdcmHeader constructor and dependencies.
740 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
741 * gdcmPython/demo/PrintHeader.py: dummy fix.
742 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
743 skip_shadow removed from gdcmHeader constructor and dependencies.
744 * Example/*.cxx and Test/*.cxx changed accordingly.
746 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
747 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
748 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
750 2004-07-21 Jean-Pierre Roux
751 * FIX Now, Parsing and Printing a DICOMDIR do work!
752 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
754 2004-07-20 Jean-Pierre Roux
755 * FIX Some brain damaged headers have Zero-Lenght fields
756 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
758 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
759 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
760 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
761 variable (instance of gdcmDebug) by a definition macro, and the instance
762 is now in static in the gdcmDebug class
763 * src/gdcmSQItem.h : (FIXME) remove an undefined method
764 * Test/PrintAllDocument.cxx : bug fix in the result of the test
766 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * WARNING: ctest now depends more tightly on gdcmData. You should
768 check out gdcmData properly for things to run smoothly...
769 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
770 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
771 we need the pixels not be loaded in order to use the ValEntry
772 that displays position and size).
773 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
774 This is a C++ based equivalent of gdcmPython/testSuite.py that should
775 be deprecated. If you have any doubts about the advantages of a
776 modern scripting language (read Python) versus grass root C++ (i.e.
777 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
778 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
779 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
780 Anyhow, consider documenting the gdcmData images in
781 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
783 * Test/CMakeLists.txt:
784 - now uses TestAllEntryVerify.cxx
785 - specific comments on oldACR00001.ima (now renamed in gdcmData
786 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
787 gdcmData/TestAllEntryVerifyReference.txt
790 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * src/*.[h|cxx] : typedef clean up
792 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
793 - TagKey renamed to gdcmTagKey (for external usage)
794 - VRKey renamed to gdcmVRKey (for external usage)
795 - removal of typedef duplication.
796 - Removed all unecessary inline keyword from class inline definitions.
797 - Some method|function(void) declarations replaced with method|function().
798 * src/jpeg/libijg12/jdhuff12.c:
799 - printf polluting ctest removed.
800 - TAB removal for comminting
802 - TestAllReadCompareDicom.cxx: added a test that compares all the
803 images in gdcmDataImages.h with corresponding images in
804 gdcmData/BaselineDicom/. When baseline images are not present
805 this test creates them.
806 Note: we need to validate each reference image, but before that
807 I'd like to rename them with a more explicit name...
808 - CMakeLists.txt: changed accordingly.
809 * Example/*.cxx: examples now only include gdcm.h (as opposed to
810 including each header needed).
812 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * Test/*.cxx and Example/*.cxx: moved some examples away from the
814 test suite to the Example directory. Are concerned:
819 - TestWriteSimple.cxx
820 * Test/CMakeLists.txt: added some comments on reasons for black listing
821 image gdcmData/oldACR00001.ima
823 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
824 * Test/CmakeList.txt: removed the following from black list (to be coherent
825 with removal from gdcmData):
826 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
827 - gdcm-MR-PHILIPS-16.dcm
829 Added the following because after last cvs update, they cause
830 ctest -R TestReadWriteReadCompare
832 - gdcm-MR-SIEMENS-16-1.acr
834 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
835 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
836 new comments in this file) we temporarily (sigh) move to a weaker
838 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
839 we don't need to black list the following images anymore:
840 - 8BitsUncompressedColor.dcm
842 - US-PAL-8-10x-echo.dcm
843 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
844 fixes and the beautified code ;-)
845 This fixes the bug introduced in version 1.42 (when beautifying)
846 that made the parsing of 8BitsRunLengthColor.dcm unproper.
847 Note: ctest was blind to this bug (this means we need to still
848 improve the test suite). The bug could be detected by using
849 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
851 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
852 and by displaying the (garbage) produced file temp.XDCM...
854 2004-06-29 Jean-Pierre Roux
855 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
856 - replace by uggly but working old code :-(
857 A lot of things should be OK again.
858 It's really urgent to have a test suite that *tests*,
859 to prevent Frog's beautifying sessions to break all the stuff
860 (twice, withing a fortnigh ...)
862 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
863 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
864 redundancy) to added Test/TestReadWriteReadCompare.cxx
865 * Test/CmakeList.txt: because the compare test of
866 Test/TestReadWriteReadCompare.cxx fails, the following images are
867 black listed: - 8BitsUncompressedColor.dcm
869 - US-PAL-8-10x-echo.dcm
870 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
871 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
872 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
873 and ad-hoc kludge. This kludge is now removed, and on encountering
874 such an image (OB field brain damaged) we set errno. Then in
875 ::FindDocLength() we "fix" the length as being ALL what remains
876 in the file (until EOF). We then proceed, hoping for the best...
877 This fixes a SegFault in ShowDicom when trying to write such an
879 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
880 (because TestWriteRead breaks on it, after a non conformal commit?).
881 ctest now runs properly, except for MakeDicomDir (which was allways
882 broken) and the Python related stuff (still not fixed).
884 2004-06-24 Jean-Pierre Roux
885 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
886 FIX : Test/TestReadWrite now iterates on all the file names
887 (instead of infinite loop)
888 ENH : Test/TestWriteRead now iterates on all the file names
890 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
893 2004-06-24 Jean-Pierre Roux
894 FIX : - now Write drops LUT Descriptors and LUTs (if any)
895 when SamplesPerPixel =3
896 - now Write is no longer confused by
897 'BitsAllocated = 12" and 'BitsStored=12"
898 - "UN" value representation Elements are now written correctly
899 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
900 ENH : - now gdcmHeader has its own Write methods
901 (in order to split the job that has not to be done
904 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
905 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
906 loop on the same image until memory went out.
907 Note: this means we still have gobs of memory loss in PrintDocument
908 * src/gdcmDocument.cxx: fixes problem on parsing on file
909 gdcmData/16BitsJpegLosslessGrayScale.dcm.
911 2004-06-24 Jean-Pierre Roux
912 FIX : Write - All the Sequences and Sequence Item are now written
913 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
914 is added a the end, when necessary.
915 - A lot of brain-damaged images, that were read correctly are
916 now written correctly
917 - length compatible BinEntry are now loaded correctly
918 (even for odd groups)
919 Note : only Explicit Value Representation was checked.
920 (question : is implicit VR really necessary for gdcm ?)
922 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * DEVELOPPER: added a proposition of coding style.
924 * src/gdcmDocEntry.h: removed every inline declaration (for test of
927 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
928 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
929 Use the gdcmDocEntry::Print() and Write() instead.
930 * src/gdcmDocument.cxx: bug fix.
932 2004-06-22 Jean-Pierre Roux
933 FIX : gdcmDocument.cxx
934 - Now we do recognize the JpegLossLess format (there was a misstyping in
935 code 'beautyfication' :-(
936 - Now we automaticaticaly load the Luts, if any
938 2004-06-22 Jean-Pierre Roux
939 In order : to write Sequences, whatever their imbrication level,
940 : to allow user to create his own Sequences
941 a lot of modif where necessary (adding, moving, or virtualising methods)
943 WARNING : save your own sources *before* cvs up !
946 ADD virtual void Write(FILE *fp, FileType filetype);
949 ADD virtual void Write(FILE *fp, FileType filetype);
950 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
953 ADD virtual void Write (FILE *fp, FileType filetype)=0;
954 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
955 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
956 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
957 ADD std::string GetEntryByName(TagName name);
958 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
960 std::string vr = "unkn",
961 std::string fourth = "unkn",
962 std::string name = "unkn");
963 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
964 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
965 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
966 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
967 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
968 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
969 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
970 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
973 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
974 ADD virtual std::string GetEntryByName (TagName tagName);
975 ADD virtual std::string GetEntryVRByName (TagName tagName);
976 REM virtual bool Write(FILE *, FileType);
977 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
978 FILE *_fp, FileType type);
979 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
980 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
981 REM virtual bool WriteEntries(FILE *_fp,FileType type);
982 REM virtual std::string GetEntryByName (std::string tagName);
983 REM virtual std::string GetEntryVRByName (std::string tagName);
984 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
985 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
986 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
988 std::string vr = "unkn",
989 std::string fourth = "unkn",
990 std::string name = "unkn");
991 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
992 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
993 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
994 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
997 ADD virtual void Write(FILE *fp, FileType filetype);
1000 ADD virtual void Write(FILE *fp,FileType filetype);
1003 ADD virtual void Write(FILE *fp, FileType filetype);
1004 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1005 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1006 REM std::string GetEntryByName(TagName name);
1009 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1011 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1012 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1013 The default constructor invoked by the line
1014 gdcmHeader *f1 = new gdcmHeader( header );
1015 was gdcmHeader::gdcmHeader(bool) instead of the expected
1016 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1017 Hence the parsing wasn't executed... See also below.
1018 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1019 as explicit constructor didn't do the trick to fix the above problem.
1020 Could anyone explain why ?
1021 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1022 properly calls gdcmValEntry::Print() (that was weed out from
1023 code related to gdcmBinEntry).
1025 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * In order to fix memory leaks:
1027 - Test/TestWriteSimple.cxx: added cleaning of free store through
1029 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1030 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1031 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1032 (through the call to ::AddDicomDirMeta()) or the destructor
1033 would crash when deleting uninitialized ::metaElems].
1034 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1035 - src/gdcmDocument.cxx:
1036 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1037 from dynamic stores.
1038 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1039 was causing memory leaks.
1040 - src/gdcmSQItem.cxx:
1041 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1042 cleanly handled with polymophism: sorry but my milage is low).
1043 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1044 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1045 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1046 This avoids SegFaulting.
1047 - src/gdcmSQItem.h: coding style.
1049 - Test/TestWriteSimple still severely sucks. The output image content
1050 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1051 damaged when displayed with vtkgdcmViewer.
1052 - on memory leaks: TestWriteSimple leaks really less (see entry
1053 of 2004-06-18 in Changelog file for the call to valgrind).
1054 - on segfaults: ctest now passes all the tests but one (no more
1056 * Erroneous leading white fix:
1057 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1058 white[s] (as opposed to from >> xxx, that removes it [them].
1059 - src/gdcmTS.cxx: ditto.
1060 - gdcmPython/testSuite.py: dirty related kludge removed.
1061 * src/*: remaining references to gdcmParser removed.
1062 * src/*[cxx|h]: added copy[way]left header.
1065 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1066 * In order to fix writing of dicom files:
1067 - Test/TestWriteSimple.cxx: a simpler example of writing.
1068 - Test/CMakeLists.txt changed accordingly.
1069 - src/gdcmDocument.cxx:
1070 -- The destructor now recursilvely removes potential sequences.
1071 -- Bug fix in ::IsJPEG2000()
1072 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1073 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1075 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1076 to only declared) and build on top of
1077 ::GetDocEntryByNumber(guint16, guint16).
1078 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1079 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1080 for usage in destructor and treatement of promotion in
1081 ::ReplaceOrCreateByNumber().
1082 - src/gdcmSQItem.cxx: destructor should better handle his job.
1083 Test/TestWriteSimple now runs (or at least it DOES something).
1084 * We can now start hutting memory links. A good starting point is:
1085 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1086 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1087 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1089 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1090 * Valgrind note: after Mathieu Malaterre teached me how to read
1091 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1093 Using gcc, you can force the STL to use malloc and to free memory as
1094 soon as possible by globally disabling memory caching.
1095 With 3.2.2 and later, you should export the environment variable
1096 GLIBCPP_FORCE_NEW before running your program.
1097 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1098 simply vanish (it is still not clear to me, whether this means that
1099 STL std::string leaks or if valgrind believes it leaks...).
1100 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1101 running bin/gdcmTests makeDicomDir):
1102 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1103 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1105 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1106 SegFaulting (I drowned in DicomDir related code when trying to
1107 understand why the list is empty...).
1108 * src/gdcmDocument.h: first BSD license header try.
1109 * Doc/License.txt added.
1111 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * src/gdcmDocument.[h|cxx]:
1113 - Clean up of the Transfer related predicates. They are now all based
1114 on new method isGivenTransferSyntax, that (should) handle properly
1115 the padding problem.
1116 - general clean up, simplification, and coding style.
1117 - Specific clean up of Parse7FE0() (umproperly named actually).
1118 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1120 2004-06-14 Jean-Pierre Roux
1122 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1123 - fix the display of SQItem ordinal number
1124 - add the GetSQItemByOrdinalNumber method
1125 - remove some useless never written private methods
1127 2004-06-14 Jean-Pierre Roux
1129 - adding a constructor taking a gdcmDocEntry as an input param
1130 - ReplaceOrCreateByNumber now returns :
1131 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1132 a gdcmValEntry * if a string value is passed as a param
1134 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1135 according to the param type (no longer sets a gdcmDocEntry)
1136 - GetValEntryByNumber, GetBinEntryByNumber added
1137 - NewValEntryByNumber and NewBinEntryByNumber added
1139 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1141 - GetSQItemNumber and SetSQItemNumber added, to provide
1142 a (relative) Item identier inside a given Sequence
1143 \warning : some pb remaining around this number
1145 - AddEntry now takes the Item Number as a param
1147 - adding a constructor taking a gdcmDocEntry as an input param
1149 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1150 * Memory leak hunt with the following command:
1151 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1152 --show-reachable=yes gdcmTests PrintDocument
1153 It looks like many (all?) leaks are due to the STL (or a bad usage
1154 of the STL. The lines producing the leaks now have a comment with
1155 a "MEMORY LEAK" tag: you can retrieve them with
1156 grep "MEMORY LEAK" src/*
1157 Here are two typical examples which I can't help fixing:
1162 char * test = "babo";
1163 name = test; //// <--- valgrind detects 960 bytes lost in
1164 //// call to std::string::operator=(char const*)
1165 name.clear(); //// Doesn't help !
1173 std::cout << "Type a bunch of characters followed by RETURN: ";
1174 getline(std::cin, line); //// <--- valgrind dectects a loss
1175 //// of 1320 bytes in call to
1176 /// std::basic_istream<>& std::getline<>
1182 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1183 * src/gdcmHeader.[cxx|h]:
1184 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1185 and related, moved away to gdcmDocument.
1186 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1187 the corresponding protected accessors of inherited class
1188 gdcmDocument, removed ! As a consequence gdcmFile had to be
1189 declared friend of class gdcmDocument (see below).
1190 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1191 - Clean up of undefined or unused methods.
1192 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1193 account the changes to gdcmHeader.h).
1194 * src/gdcmDocument.h:
1195 - gdcmFile is now a friend class (in order to take into account the
1196 changes to gdcmHeader.h).
1197 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1198 (see changes to gdcmHeader.h).
1199 - Accessors (reading on the form GetEntry*) are now public.
1200 - Clean up of undefined or unused methods.
1201 * src/gdcmDocument.cxx:
1202 - adaptation to changes to gdcmDocument.h
1203 - ::OpenFile now writes a verbose message when file cannot be opened.
1204 - some std::string properly set to VRKey
1205 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1206 references to gdcmDocument.
1207 * Test/TestFindTags.cxx: changed accordingly to above changes.
1208 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1209 cvs repository gdcmData.
1211 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1212 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1213 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1214 conflicts with gdcmValEntry::voidArea.
1215 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1216 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1217 Value representation between StringRepresentable and BinaryRepresentable.
1218 * src/gdcmDocument.cxx:
1219 - method ParseDES: proper indentation restored and usage of
1220 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1221 - method LoadDocEntry: the fingerprint left in the SetValue() of
1222 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1223 removed. Reverting to previous code segment with the proper
1224 dynamic_cast< gdcmValEntry* >.
1225 Note: this was (partially) breaking the python test suite
1226 (gdcmPython/testSuite.py) that made usage of the above
1227 fingerprint to check presence of "Pixel Data".
1228 * src/gdcmDocEntry.h: coding style.
1229 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1230 now taken into account.
1231 * gdcmPython/gdcm.i: adaptation to the new internal representation
1232 of gdcm (exit gdcmParser, hello gdcmDocument).
1233 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1235 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1236 anymore, but instead prints the loaded Python dictionary.
1237 * .... alas, the python testSuite is still broken.
1239 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1240 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1242 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1243 * src/gdcmUtil.h : export methods
1245 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1246 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1248 * Initial addition of automatic python testing
1249 * Initial addition of automatic image comparison
1251 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1252 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1253 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1255 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1256 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1257 * Test/ShowDicom.cxx : bug fix for msvc compilation
1258 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1260 2004-05-04 Jean-Pierre Roux
1261 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1262 new concepts (and new classes) :
1263 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1264 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1265 - Sequence Doc Entries (gdcmSeqEntries)
1266 a Sequence is composed of Items.
1267 Each item is a set of Doc Entries (this is recursive)
1268 The non uniqueness of the 'Dicom tag' is due to this recursivity
1269 (never taken into account)
1270 Our unability to add a new 'entry' in the header
1271 at the proper location (neither in the H-Table (map or multimap),
1272 nor in the Chained List is also due to this recursivity.
1273 Don't try, right now, to use/modify/compile these new sources :
1274 nothing is finished.
1275 We just commit all the stuff, 'as is', in order not to loose it.
1277 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1278 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1280 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1281 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1282 file prefix (SetFilePrefix)
1284 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1285 * Add a new test: ShowDicom, for now this is just the c++ version of
1286 checkRead.sh, later it will be able to compare the image read against a
1288 * Replace the DEBUG on the stack with a global entry in cmake interface:
1289 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1291 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1292 * Add an example subdir, with a real example on how to read + write a
1295 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1296 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1297 * Doc/CMakeLists.txt: the main page is now properly differentiated
1298 between the developper and user version.
1299 * Doc/doxygen.config.in: dropped search related obsolete flags
1300 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1302 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * DEVELOPPER: added some helpfull comments for compile/test/install
1306 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1307 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1308 src directory, now generated in the build dir.
1309 2. Tests as mentionned smarter
1311 4. Add a new method in gdcmDict that return the PubDict by name
1312 this is interesting for 3rd party lib like ITK,
1313 where we could set the institution name / patient name...
1315 * ENH: 1. Now the test suite is working for real
1316 2. All binaries are now output in the gdcm-bin directory
1317 (this was not true before)
1319 2004-04-28 Jean-Pierre Roux
1320 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1321 SeQuence indented printing of Dicom Header.
1322 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1323 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1324 Computation of SQDepthLevel is now part of gdcmHeader constructor
1325 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1326 tree-like structure of a Dicom Header.
1327 * FIX Test code cleaning
1329 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1330 * ENH: Adding automatic testing
1331 1. Need a DartConfig.cmake to submit to public
1332 2. Add a test driver gdcmTest.cxx
1333 3. gdcmTestMain, an helper for the main test driver gdcmTest
1334 4. Files in Test don't have a main anymore, this becomes interesting
1335 when we add more and more tests, thus dsw don't have to load
1337 * ENH: Adding a GDCM_DATA_ROOT for testing
1338 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1339 one file instead of seven + some small cleanup
1341 2004-04-22 Jean-Pierre Roux
1342 * ENH Minor changes to the Print() methods.
1343 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1344 Header printing. Example given with :
1345 > PrintHeader fileName 2 new
1346 (SQ based tree-like structure still to be done for the Header ...)
1348 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1349 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1350 1. I have added some unsigned where needed
1351 2. Some function parameter not used -> (void)
1352 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1353 4. g++ don't like character '\' in comment
1354 5. #define jpeg_create_decompress jCreaDecompress
1355 this really need to be fixed
1356 6. virtualize destructor of gdcmObject ... leakage
1357 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1358 this also really need to be fixed
1359 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1360 remove compression file
1361 (as we only do decompression, right ?)
1362 * ENH: Change malloc/calloc/free with c++ equivalent
1364 2004-04-21 Jean-Pierre Roux
1365 * FIX gdcmHeaderHelper::GetXSpacing
1366 when a single value is found (bug ?), xpacing is now
1367 defaulted to yspacing
1369 2004-04-19 Jean-Pierre Roux
1370 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1371 * ENH add parameters :
1372 bool exception_on_error = false,
1373 bool enable_sequences = false,
1374 bool ignore_shadow = false
1375 to the gdcmFile constructors to be full gdcmParser compliant
1376 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1377 to allow reading of PAPYRUS 3.0 files
1379 2004-04-06 Jean-Pierre Roux
1380 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1382 2004-04-02 Jean-Pierre Roux
1383 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1384 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1385 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1387 2004-03-30 Jean-Pierre Roux
1388 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1389 for ACR file, written out as DICOM files (hope so...)
1391 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1392 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1393 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1394 moved to base class gdcmParser and only the specialisation is kept
1396 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1397 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1398 already does the job.
1399 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1400 (to be consistent with gdcmParser::WriteEntries).
1402 2004-03-30 Benoit Regrain
1403 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1404 upate of the object's instance. It's passed to 2 in the unfavorable
1405 case : one in the ExecuteInformation, one in the ExecuteData
1407 2004-03-29 Jean-Pierre Roux
1408 * ENH : Check on file type to be written moved
1409 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1410 * FIX : gdcmObject::ResetBoundaries now stops properly
1411 when end-of-list is reached
1412 : gdcmVersion modified (as Benoit Regrain asked)
1414 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1415 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1416 * src/gdcmUtil.cxx: added forgotten iostream include.
1417 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1418 equivalent to ExplicitVR in existing code).
1420 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1421 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1422 now contains all the gdcmGlobal related code.
1423 * minor coding style and doxygenation changes.
1425 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1426 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1427 now contains all the Debug related code.
1428 * minor clean-up of includes in src/*.cxx
1429 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1430 CreateCleanString) removed.
1431 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1432 * Doc/DoxyMainPageUser.txt added.
1433 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1434 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1435 src/gdcmDirList.cxx)
1437 2004-03-24 Jean-Pierre Roux
1438 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1440 2004-03-23 Jean-Pierre Roux
1441 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1442 big endian made volumes
1443 * ENH Now gdcmParser constructor and destructor are protected to forbid
1444 end user to instanciate class gdcmParser
1445 (only gdcmHeader and gdcmDicomDir are meaningfull)
1447 2004-03-22 Benoit Regrain
1448 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1449 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1450 gdcmSerie to gdcmDicomDirSerie
1452 2004-03-19 Jean-Pierre Roux
1453 * ENH Now the tree-like structure describing a DICOMDIR comming from
1454 an already existing DICOMDIR file is consistent with
1455 the home-made tree-like structure build ex-nihilo
1456 or build from the files held (recursively) in a Directory
1457 functions gdcmDicomDir::CheckBoundaries()
1458 gdcmObject::SetBoundaries() added
1460 2004-03-17 Jean-Pierre Roux
1461 * REM (Eric Boix bug) : removal of meaningless
1462 gdcmDicomDirImage::NewImage function.
1463 * FIX now file names and directory name are written properly in the
1465 * FIX now gdcmDicomDir constructor may be call without any trick
1468 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1469 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1470 of gdcmDicomDirImage::NewImage as empty function.
1472 2004-02-28 Jean-Pierre Roux
1473 * ENH add gdcmDicomDir:NewPatient
1474 add gdcmDicomDirPatient:NewStudy
1475 add gdcmDicomDirStudy:NewSerie
1476 add gdcmDicomDirSerie:NewImage
1477 to allow making gdcDicomDir object.
1478 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1479 (as opposite to the gdcmHeader chained list)
1481 2004-02-11 Benoit Regrain
1482 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1483 when using from python
1485 2004-02-10 Benoit Regrain
1486 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1487 * FIX : in gdcmDicomDir when the directory is empty
1488 * ENH : add callback and methods to get the progression of dicomDir
1491 2004-02-06 Jean-Pierre Roux
1492 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1493 - GDCM_META added to gdcmDicomDirType
1494 - class gdcmMeta created
1495 * ENH : - A brief summary is now displayed at the beginning of
1496 'testDicomDir' to help disaster magnitude estimation
1497 * REM : Now useless Test/explDICOMDIR.cxx
1499 2004-02-05 Benoit Regrain
1500 * ENH : add methods in gdcmObject to get the hash table or the list of
1502 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1503 * FIX : wrapping python for TagHeaderEntryHT
1505 2004-02-04 Benoit Regrain
1506 * FIX : even length for some strings when writting the dicom dir
1507 * FIX : sort the images in the dicom dir
1508 * FIX : Bug fix for python use of dicom dir
1509 * ADD : a python demo
1511 2004-02-04 Jean-Pierre Roux
1512 * FIX : Final solution (?) for icone embedded images
1513 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1514 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1515 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1516 gdcmData/gdcm-MR-SIEMENS-16.acr1
1517 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1518 to make full checking easier
1520 2004-02-04 Benoit Regrain
1521 * FIX : WriteEntries : coding style & logic in parameters
1522 * FIX : Set the elements to create the DicomDir in a dictionary file
1524 2004-02-03 Benoit Regrain
1525 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1526 * gdcmDicomDir : add the load of directory
1527 * Bug fix and print add-on
1529 2004-02-03 Jean-Pierre Roux
1530 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1531 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1532 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1533 * FIX gdcmParser.cxx : 'group length' elements are now considered
1534 as integers, even for shadow groups, when file is Implicit VR
1536 2004-02-02 Jean-Pierre Roux
1537 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1539 of the last synonym :-(
1540 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1542 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1543 * FIX taking into account the possible 7fe0,0010 multiplicity
1544 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1545 to allow removal of references to 7fe0,0010, to deal with
1546 ACR-NEMA images, when 0028,0200 is meaningfull
1548 2004-01-31 Jean-Pierre Roux
1549 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1550 no longer writes 'Un' on disk
1551 * FIX SQ elements with actual length are now dealt with corectly
1552 * FIX gdcmFile::WriteBase make the difference, for color images, between
1553 the length (for Palette expanded images)
1554 and Raw Length (non expanded image + Palette)
1555 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1556 (that broke Write). Replaced by UL.
1557 Aware user will reload the field if he
1558 thinks it's necesssary
1560 2004-01-30 Jean-Pierre Roux
1561 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1562 when 'dirty Acr' is found, to be compliant with the new
1563 IsReadable() methods.
1565 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1566 (no DOUBLE images in kosher DICOM,
1567 but so usefull for people that miss them ;-)
1569 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1570 DICOMDIR related utilities (not checked as Windoze compliant)
1572 2004-01-28 Jean-Pierre Roux
1573 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1575 2004-01-27 Jean-Pierre Roux
1576 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1577 to allow skipping the shadow elements, to save memory space.
1578 The TRUE value for this param has to be used
1579 with a FALSE value for the 'enable_sequence' param.
1580 ('public elements' may be embedded in 'shadow Sequences')
1581 * gdcmHeader methods now deal with 'embedded icones images' in the header
1582 (even when an 'icone image sequence' is announced by the
1583 element (0x0088,0x0200), but there is NO icone at all ...
1585 * gdcmHeader sometimes Image Location value doesn't follow
1586 the supposed processor endianity (see gdcmData/cr172241.dcm).
1589 * gdcmHeader add the method
1590 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1591 to get *all* the Header Entries with the same tag.
1592 GetHeaderEntrySameName is probabely *useless*
1593 (no meaning : Name is *not* an identifier within the Dictionnary)
1595 2004-01-26 Benoit Regrain
1596 * Bug fix in the print of hexadecimal representations. Remove long fields
1597 in the print and add a third level of print to print them
1599 2004-01-23 Benoit Regrain
1600 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1601 * Bug fix on test suite after remove the strip made on not string fields
1602 * Split the IsReadable method between gdcmParser which test that the file
1603 is dicom and gdcmHeader which test that it's an image file
1605 2004-01-22 Benoit Regrain
1606 * DicomDir : clean code, add methods, set variables in protected or private
1607 * gdcmUtil : bug fix for the clean string method
1609 2004-01-19 Benoit Regrain
1610 * Add the use of shadow dictionaries
1611 * bug fix and coding style
1613 2004-01-19 Benoit Regrain
1614 * src/gdcmFile.cxx : bug fix concerning the close of file
1615 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1616 * Add the update of header entries using the shadow library
1618 2004-01-19 Benoit Regrain
1619 * removal of file gdcmHeader2.cxx
1620 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1621 inheriting from gdcmParser. This split is to prepare the integration
1622 of dicom dir parsing
1623 * bug fix under python
1625 2004-01-16 Jean-Pierre Roux
1626 * REM removal of class gdcmHeaderEntrySet
1627 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1628 * ADD add file gdcmHeader2.cxx
1629 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1631 2004-01-15 Benoit Regrain
1632 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1633 entries created while parsing the header. Thus, they will be destroyed
1634 when the gdcmDictSet will be destroyed
1635 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1638 2004-01-15 Benoit Regrain
1639 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1640 made a fatal error because of the memory release at the end of program.
1641 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1642 some memory and vtk seems to have some problems with that.
1643 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1645 2004-01-14 Benoit Regrain
1646 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1647 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1648 * src/*.[h|cxx] : make changes due to class name changes
1649 * gdcmPython/demo/*.py : bug fix due to method names
1651 2004-01-13 Benoit Regrain
1652 * src/*.[h|cxx] : coding style
1653 * vtk/*.[h|cxx] : coding style
1655 2004-01-13 Benoit Regrain
1656 * gdcmPython/testSuite.py : test the readable flag of file for tests
1657 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1658 It's lied to the stl compilation by MSVC (windows, always windows...)
1659 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1661 2004-01-12 Benoit Regrain
1662 * src/*.h : add comments
1663 * src/gdcmDictSet.h : set the method BuildDictPath in public
1664 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1665 directly setted in the source code
1666 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1669 2004-01-09 Benoit Regrain
1670 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1671 * setup.py : use a reference to gdcmVERSION
1673 2004-01-07 Benoit Regrain
1674 * Modification to compile with the distutils.
1677 2003-12-10 Benoit Regrain
1678 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1679 can use a gdcmHeaderHelper to load datas
1680 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1681 made in the source code
1683 2003-12-10 Benoit Regrain
1684 * Update Windows projects and .cvsignore files
1686 2003-11-12 Jean-Pierre Roux
1687 * ENH gdcmHeader constructor has one more parameter (default value : false)
1688 that allows the user to 'go inside' the SeQuences only
1690 gdcmElValSet:Print takes it into account
1692 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1693 * ENH: Update gdcmPython/CMakeLists
1694 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1695 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1697 2003-11-10 Jean-Pierre Roux
1698 * FIX : gdcmHeader::LoadElements is now based
1699 on the ListTag listElem member,
1700 not longer on the TagElValueHT tagHt member
1701 * ENH : PrintPubElVal shows (temporarily) both results,
1702 with the tagHt member and the listElem member.
1703 (it's easier to 'see' the problems when using Printheader)
1705 * FIX : old private member LgrElem is now splitted into
1706 ReadLength : Length actually found on disk (updated only
1707 if bug fixing is necessary), for internal
1709 UsableLength : Updated by FixFoundLength, to fix a bug
1710 or to allow Parser going on.
1711 Will allow to re-write a kosher header when a SeQuence
1712 with a length (not 0000) is found
1713 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1714 because gdcmElValSet::Add does not update ListElem
1717 2003-11-07 Jean-Pierre Roux
1718 * FIX misstyping in Transfert Syntax name table
1719 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1720 when they have an actual length (not 0000 nor FFFFF)
1721 (Nobody should care of it, but DICOMDIR explorers)
1723 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1724 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1726 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1727 * ENH: vtkGdcmReader now supports LUT !
1728 (vtkgdcmViewer for now is not able to use them though)
1730 2003-11-05 Jean-Pierre Roux
1731 * in testSuite.py : new files names for checking the package
1732 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1733 that returns the pixel area size to the *aware* (vtk) user
1734 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1736 2003-11-05 Benoit Regrain
1737 * in testSuite.py : Modify the rules for checking the paths
1738 : Explicit error messages
1739 * in __init__.py : Related modif
1741 2003-11-03 Jean-Pierre Roux
1742 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1743 to be used by aware (vtk) users that want to manage
1744 LUT (and no to turn the PALETTE image into an RGB pixels one)
1745 * GetPixelType now returns 8U for 24 Bits images
1746 (vtkGdcmReader compliant)
1748 2003-10-31 Jean-Pierre Roux
1749 * Removal of *all* gdcmData images and add them again
1750 in order to loose the 'history' of un-anonymised images
1752 2003-10-31 Jean-Pierre Roux
1753 * RMV : removal of useless jBitsInJsample.h
1754 for both 8 and 12 Bits JPEG Lossy Libraries
1756 2003-10-31 Jean-Pierre Roux
1757 * ENH : Add the functions gdcmFile::GetImageDataRaw
1758 gdcmFile::GetImageDataIntoVectorRaw
1759 that act as GetImageData and GetImageDataIntoVector
1760 except the making of an RGB Plane from Gray Plane + LUT
1761 Intended to aware (vtk) users who know how to manage
1764 GetLUTRGBA return a R,G,B,A LUT if any
1765 lgrTotaleRaw gives the 'Raw' length
1766 GetImageDataRaw returns the gray Plane
1767 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1768 (They stay Grey, just like with other Dicom viewers :-(
1770 2003-10-30 Jean-Pierre Roux
1771 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1773 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1775 being coherents dicom files.
1777 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1778 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1780 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1781 * ENH: Two steps is necessary to please VC++ compiler...
1782 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1783 * ENH: Add include dir to medcon lib
1784 * FIX: only one function is being exported for now !
1785 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1787 2003-10-29 Jean-Pierre Roux
1788 * adding gdcmHeader::GetLUTRGBA
1789 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1790 --> Mathieu, the modif u're waiting for is not yet committed
1791 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1793 2003-10-27 Jean-Pierre Roux
1794 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1795 00191113.dcm DermaColorLossLess.dcm
1796 MxTwinLossLess.dcm RadBWLossLess.dcm
1797 * ENH: For version prior to vtkImageViewer2 -r 1.19
1798 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1800 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1801 * Removal of ido stuff in CMakeLists.txt
1803 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1804 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1805 * FIX: remove a call to ->Modified ... see comments
1806 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1808 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1809 * FIX: Problem with path for libvtkgdcmPython
1810 * ENH: Try adding a search script for python site-package
1811 * RMV: Remove some file from medcon lib that are not necessary
1812 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1813 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1814 * FIX: More pragma disable fro VC++,
1815 I don't think I break something as it is also disable in VTK/ITK.
1816 But it fasten debug compilation time.
1818 2003-10-23 Jean-Pierre Roux
1819 * gdcm now deals with 16 Bits Run Length Encoded images
1820 (they are compressed as 2 planes images,
1821 one for the high Bytes, the other for low Bytes)
1823 2003-10-22 Jean-Pierre Roux
1824 * Now CheckRead takes into account :
1825 - the bugged 'Leonardo' Siemens images
1826 - the XA images, sent thru the burning VPRO station
1827 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1830 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1831 * FIX: When copying a Makefile.am to CMakeLists.txt
1832 one should remove the '\'
1834 2003-10-22 Jean-Pierre Roux
1835 * in gdcmData adding a bugged 'Leonardo' Siemens image
1836 (wrong lengths in header)
1837 OK with gdcm, KO with the other viewers :-)
1838 * add a GE dlx XA image, thru the VEPRO burning station
1841 2003-10-21 Jean-Pierre Roux
1842 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1843 for a brutal checking of vtkgdcmViewer compliance
1845 2003-10-21 Jean-Pierre Roux
1846 * add the files for 'xmedcon' Jpeg Lossless library
1847 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1849 2003-10-21 Jean-Pierre Roux
1850 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1852 2003-10-21 Jean-Pierre Roux
1853 * garbage Siemens 'Leonardo' images dealt with
1854 (the patch is easy to remove)
1855 * cosmetic changes to avoid warnings
1857 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1858 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1859 no need to press 'r' now.
1861 2003-10-20 Jean-Pierre Roux
1862 * upgrade of checkRead.sh checkWrite.sh according
1863 to new Jpeg Lossless decompressor
1864 * add US.3405.1.dcm, a genuine RGB medical file ...
1865 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1866 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1868 2003-10-15 Jean-Pierre Roux
1869 * general anonymisation in gdcmData
1870 * adding the 'color files' from
1871 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1872 * adding some well knowed bugged-header images
1873 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1874 waiting for their inclusion in Python testsuite
1876 2003-10-15 Jean-Pierre Roux
1877 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1878 no longer seg faults when file is not found
1880 2003-10-14 Jean-Pierre Roux
1881 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1884 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1885 * TODO: *.in file to genereate a UseGDCM later
1887 2003-10-14 Jean-Pierre Roux
1888 * Some supposed-to-be Dicom Images have no preamble.
1889 OpenFile takes it into account
1890 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1891 * Missing elements added in dicomV3.dic
1892 (just to be affraid : have a look at
1893 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1894 and do it again next year ;->
1896 2003-10-13 Jean-Pierre Roux
1897 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1898 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1899 But there are NOT. It's fixed !
1901 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1902 * FIX: "jpeglib.h" was not found on VC++
1903 * FIX: vtkgdcm was not being installed
1905 2003-10-10 Jean-Pierre Roux
1906 * ENH : OpenFile closes the file if it *really* doesn't look like
1907 an ACR-NEMA / DICOM one.
1908 * FIX : testWrite no longer writes an empty file if the source file
1909 is not gdcm Readable
1910 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1913 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1914 * FIX: CMake generate now documentation
1915 * ENH: out of source doc build !
1916 * ENH: Generate both user and dev documentation
1917 * ENH: Should work on windows too
1918 * ENH: Only one doxygen config.in file is needed
1919 * FIX: make install should be ok now on ùnix plateform
1920 * FIX: PATH to dictionary was wrong (missing /)
1921 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1923 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1924 * vtkGdcmReader is now able to read rgb dicom file.
1925 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1926 * added a gdcmViewer to vtk test, use mouse to control
1927 window level & window width
1929 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1930 * CMake-ification of gdcm, we have now two build system
1931 * FIX: on cygwin Wsock32 doesn't exist
1932 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1934 2003-10-06 Emanuel Ollart
1935 * FIX : compilation process wad broken.
1936 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1938 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * change gdcmViewer -> vtkgdcmViewer
1940 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1942 2003-10-06 Jean-Pierre Roux
1943 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1944 ( e.g : well known GE images with a wrong elem length,
1945 : Philips MRI Images with a wrong Huffman table)
1946 * still to be done : allow the reading of bugged LEONARDO Siemens images
1948 2003-10-03 Jean-Pierre Roux
1949 * Odd length strings are padded with '\0' (not with spaces,
1950 to remain compliant with already defined strings,
1951 like Transfert Syntax UID and others)
1953 2003-10-03 Jean-Pierre Roux
1954 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1955 to allow displaying RGB images (not only by affim ;-)
1957 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1958 * vtkGdcmReader is now able to read rgb dicom file.
1959 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1961 2003-10-03 Jean-Pierre Roux
1962 * A few nasty patches to allow the reading of a lot of nasty images
1963 ( e.g : well known GE images with a wrong elem length,
1964 : Philips MRI Images with a wrong Huffman table)
1965 * still to be done : allow the reading of bugged LEONARDO Siemens images
1967 2003-10-03 Jean-Pierre Roux
1968 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1970 2003-10-03 Jean-Pierre Roux
1971 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1972 to allow displaying RGB images (not only by affim ;-)
1974 2003-10-03 Jean-Pierre Roux
1975 * gdcmFile::GetImageDataIntoVector now
1976 - deals with MultiFrames MultiFragments Run Length Encoded files
1977 - deals with YcBcR (YBR_FULL) files
1978 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1979 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1981 (no sample found :-(
1983 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1984 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1985 Two reasons: - clear things
1986 - third parties acces gdcm through header files, so won't
1987 suffer anymore VC++ complains
1989 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1990 * add argv[1] in testvtkGdcmReader.cxx
1993 2003-09-24 Jean-Pierre Roux
1994 * The lines are now eigthy characters long.for
1995 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1997 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1998 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1999 char* to std::string. Thus, the use of strdup becomes useless. (see
2000 previous commis of Malaterre)
2001 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2002 before the last Malaterre's commit.
2004 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2005 * This commit should fix the Debug building under VC++, the problem
2006 was mainly a mixture of debug and release lib being loaded at startup.
2007 * I also remove a depency to a specific C function: strdup. Because I had
2008 to force the link to msvcrtd (whereas strdup is in libc).
2010 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2011 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2012 located in the gdcmCommon.h file. All use of reference of tha has been
2013 changed to now use the variable GDCM_UNFOUND.
2015 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2017 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2018 Dicom dictionary. The test suite can now be run again. Note:
2019 I'm note very happy with the " (RET)" changes. I believe this
2020 RETAINED comment should be dropped when parsing the dictionary.
2021 - PACKAGER corrected
2023 - AUTHORS updated and now in alphabetical order
2024 * Makefile.am now exports gdcm.dsw for Windoze users.
2026 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * cygwin complains about missing std:: in subdir Test/
2029 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2030 * remove some methods that are now in gdcmHeaderHelper
2032 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2033 * vtkGdcmReader set spacing and origin correctly
2035 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2036 * Fix a few delete/delete[] mismatch
2038 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2039 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2040 interpretation to data given by gdcmHeader. For instance there are
2041 heuristics to get informations (look at different places).
2042 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2043 sorting DICOM images based on different strategies.
2044 * modified Makefiles accordingly.
2046 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2047 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2048 when building in debug mode
2049 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2050 src/win32/gdcmdll.dsp
2051 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2053 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2054 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2057 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2058 * src/win32/libgdcmjpeg12.dsp was not dos format
2059 * src/win32/libgdcmjpeg12.dsp :
2060 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2061 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2063 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2064 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2066 * src/gdcmFile.cxx : bug fix in affectation type
2067 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2068 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2069 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2070 symbols... future problem ?
2072 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2073 * src/win32/libgdcmijpeg12.dsp was missing
2074 * modified gdcm.dsw accordingly
2076 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2077 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2079 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2080 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2081 commit of JPR (before his hollidays to facilitate our work).
2082 * setup.py : bug fix in code. Modifications made while the last commit
2083 of JPR. The code hasn't been tested before the commit... it's so
2084 useless to make that (for best programmer that is JPR) !!!
2086 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2087 * tagged the current version as Version0_3 (i.e. version 0.3)
2089 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2090 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2091 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2092 * *.dsp : modifications to use new libgdcmijpeg8 library
2093 * setup.py : bug fix on VTKPATH variable
2094 * PACKAGER : adding all concerning windows
2096 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2097 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2099 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2100 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2101 test suite reported error.
2102 * PACKAGER file added (describes what a packager must do when
2103 packaging a new release).
2104 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2105 * configure.in: upgraded version number to 0.3.0
2106 * fixing build of rpm (through rpm -ta):
2107 - Doc/Makefile.am exports proper doxygen files
2108 - src/jpeg/libijg8/Makefile.am exports the include files.
2110 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2111 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2112 * src/gdcmHeader.h : formatting code
2114 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2115 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2116 We were obtaining error message from vtk. Now, creation of file list
2117 is made in an internal list to prevent this problem.
2118 Bug fix when output is empty.
2119 Bug fix in update of progress value. Previous commit for this was a bad
2121 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2123 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2124 * src/gdcmHeader.h : added method to get the file name
2125 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2126 files. Added method to remove all files on the input
2127 Added FIXME comment concerning the bad parsing of header made by
2128 ExecuteInformation method (in ExecuteData method)
2130 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2131 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2132 when using make instal.
2133 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2134 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2136 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2137 * setup.py : adding include dir of jpeg lib to compile all sources
2138 * */Win32/*.dsp : JPR fix for windows compilation
2140 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2141 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2143 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2144 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2146 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2147 * setup.py is again effective on un*x (takes into account the
2148 addon of the jpeg library)
2149 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2150 * Doc/Doxy* updated (includes above enhancements)
2151 * INSTALL now points to web documentation
2153 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * src/gdcmHeader.h doesn't make unnecessary reference to
2156 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2158 * src/gdcm*.[cxx|h] :
2159 - to allow compilation with gcc 3.x
2160 -- clean up of STL usage (added explicit usage of std::)
2161 -- small fixes on exceptions.
2162 Note: linking not tested !
2163 - clean of doxygen comments to avoid warnings at documentation
2165 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2166 dependent convertion).
2168 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2169 * Clean up of previous JPR garbage commit (not even commented in the
2171 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2172 - moved all jpeg related files from src to src/jpeg/libijg8, with
2173 addition/modification of Makefile.am and configure.in.
2174 - the testSuite is still brain damage (not guilty).
2176 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2177 * WrapVTK.py : modifications to get correctly vtk source files to
2179 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2180 (FileName -> Filename)
2182 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * vtk/vtkGdcmReader.[cxx/h]:
2184 - UpdateProgress method should now be effective
2185 - removed the limitation on having only images loaded (as opposed
2187 - when building a stack of images/volume, a lesser number of
2188 gdcmHeader and gdcmFile instances should be used (hopefully
2189 accelerating things).
2190 - when building a stack of images/volumes, files which are not
2191 loadable (wrong path-filename, wrong permissions on existing file,
2192 or file not parsable by gdcm) are replaced with a black image
2193 in the stack (for the caller to notice the problem).
2195 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2196 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2198 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2199 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2200 between standard library (std) and vtk library (problems are found
2201 under Windows... thanks Windows !)
2203 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2206 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2208 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2209 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2211 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * When compiling with distutils (see setup.py) the C++ compiler is
2213 called with different flags than the default ones (with automake).
2214 In order to fix all those warning, I compiled gdcm with the command
2215 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2216 and went for warning fixes:
2217 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2218 up from unused variables.
2219 - vtk/vtkGdcmReader.cxx: potential bug fix.
2220 * src/gdcmHeader.h: Doxygen warning cleanup
2222 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2223 * gdcmPython/gdcm.i:
2224 - typemaps correction to take into account the systematic replacement
2225 of "using namespace std" with std:: prefix e.g. std::list,
2226 std::string... (cf changes of 2003-05-21).
2227 - gdcmGlob global variable of type gdcmGlobal (defined in
2228 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2229 exported to Python a as cvar.
2230 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2231 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2232 gdcmDictSet.GetPubDictTagNames() and
2233 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2234 C++ static methods).
2235 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2236 with the above changes.
2238 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2239 * setup.py, manifest.in : bug fix under linux
2241 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2242 * Modification of setup.py to compile vtk part too. Then, we have 2
2243 wrappers which must work with same distutils. For that, we have a
2244 generic distutils in distusiltsWrapping.py ; with :
2245 - build_extWrap class to wrap generically all extensions,
2246 - ExtensionWrap base class for all wrapping extension that contains
2248 - Wrapper interface which wrap sources
2249 + In WrapSwig.py we have extension and wrapper for Swig
2250 + In WrapVTK.py we have extension and wrapper for VTK
2251 * MANIFEST.in : modifications to consider vtk directory and new python
2252 files for compilation
2254 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2255 * Added python wrappers of vtkGdcmReader vtk class (see the
2256 source in vtk/vtkGdcmReader.cxx) :
2257 - vtk/Makefile.am now builds a library
2258 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2259 python library (as opposed to _gdcm.so wich are the python
2260 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2261 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2263 - configure.in has an additional flag --enable-vtk that needs
2264 to be set to enable compilation of vtk related code, that is:
2265 + vtk/vtkGdcmReader.so and
2266 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2267 + gdcmPython/vtkgdcmPython.so (see above)
2268 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2269 be read when compressed or when HighBit + 1 != BitsStored),
2270 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2271 the usage of the python wrapper of vtkGdcmReader vtk class.
2272 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2273 * src/*.[h] all occurences of stl classes are now prefixed with
2274 std::, and all occurences of "using namespace std;" where removed.
2275 This is to avoid pollution of global namespace in included files.
2276 Apparently vtk does not avoid this pitfall: when using both
2277 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2278 collision of various stl members (principally cout...).
2279 * gdcmPython/testSuite.py now cleanly removes temprory generated
2281 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2282 comply with above changes)
2284 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2285 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2286 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2287 vtk data structure (an image Flip was required).
2288 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2289 * cosmetic changes in documentation.
2291 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2292 * src/gdcmHeader.cxx: the constructor no longer exits when an
2293 unexisting file is given as argument.
2294 * The subdirectory Data (containing all the images used for the
2295 test suite) is not part of this repository anymore. A new module
2296 containing those images is now available at
2297 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2298 with the name gdcmData.
2299 All the python scripts (including the package initialisation file
2300 gdcmPython/__init__.py) were adapated to take this change into
2301 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2303 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2304 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2305 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2306 demo of the usage of this class.
2307 Compilation of this vtk part is only done when using the --enable-vtk
2308 at configure (or autogen.sh) stage.
2310 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2311 * More memory link related corrections and documentation fixes.
2313 - maximum info is obtained with a command of the form:
2314 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2315 --show-reachable=yes PrintHeader
2316 - the remaining reachable blocks seem to come from the STL
2317 allocation scheme through the usage of map and list. It looks
2318 like this memory cannot be freed but it is not a memory leak
2319 (in fact further invocation to the STL would recollect the
2320 unused memory allthough it cannot explicitely be freed).
2321 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2322 of displaying an image parsed with gdcm and displayed with VTK.
2323 Note: some images don't seem to work e.g.
2324 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2325 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2326 Allthough this weakens the semantics, it is a ditch attempt to
2327 make gdcm more thread friendly.
2329 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2330 * Memory link hunt (by using valgrind through the command
2331 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2332 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2333 gdcmHeader::_dicom_vr.
2334 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2335 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2337 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2339 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2340 * src/Makefile.am now exports all the necessary include files at
2344 * UpdateGroupLength replaced by new one
2347 * UpdateGroupLength re-written using H-Table
2348 (named UpdateGroupLengthNew untill checks are over)
2350 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2351 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2352 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2354 - gdcmHeader::GetPubElValSet removed.
2355 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2356 UpdateGroupLength, WriteElements, Write.
2357 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2358 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2359 carried the same semantics.
2360 - src/gdcmHeaderIdo.cxx changed accordingly.
2361 - gdcmFile::WriteBase now regroups all the codes from previous
2362 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2363 - enum FileType moved to gdcmCommon.h
2364 * src/gdcmHeader.cxx AddDefault trashed
2365 * gdcmGetXSize added
2366 * getimageDataSize now calls gdcmGetXSize
2367 * Test/*.cxx changed to agree with above changes
2369 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2371 (to avoid double call by end user).
2372 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2373 by end user, since gdcmHeader::gdcmHeader now handles it.
2375 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2376 * gdcm/Doc many doxygen changes:
2377 - Doxyfile now has two different versions, DoxyfileUsers that generates
2378 the html.users end users oriented documentation and
2379 DoxyfileDeveloppers that generates the html.developper developper
2380 oriented documentation.
2381 - README changed accordingly
2382 - requirement.txt removed (old design info moved to TODO).
2383 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2384 DoxyMainPage.txt, DoxyPython.txt provide more information.
2385 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2386 be updated by simply regenerating the docs with doxygen and copying
2387 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2388 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2389 all the tests in the form "if (<map>.count() >1)" were removed.
2390 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2391 ill-formed documentation sections.
2392 * src/gdcmHeader.cxx: ditto
2394 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2395 * setup.py fixed for un*x (needed macro for stdint.h)
2396 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2397 un*ces with sh-utils test utility.
2398 * gdcmPython/demo/test.py renamed to PrintHeader.py
2399 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2400 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2401 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2402 * src/gdcm*.cxx JPR's bad inclusion fixed.
2404 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2405 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2406 * gdcmPython/demo/test.py changed accordingly.
2408 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * gdcmPython/Makefile.am fixed linking against libstdc++
2410 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2411 * Swig subdir (historical tests of swig version 1.3.17++) removed
2412 * Test/testChangeEntete.cxx some lines commented out in order to make
2414 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2415 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2417 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2418 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2419 hence the user doesn't need this explicit call.
2420 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2421 i.e. LoadElements() call removed.
2422 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2423 - src/Makefile.am declares the proper flag for g++.
2424 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2425 for adding user defined new tags.
2426 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2427 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2428 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2430 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2431 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2432 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2433 src/Makefile.am : the project should properly compile and install
2434 with the autotools, included the python wrappers part.
2435 * gdcm.spec.in : added a spec file for RPM packaging.
2437 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2438 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2440 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2442 to exported to the environement (see gdcmPython/testSuite.py
2444 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2445 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2446 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2447 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2448 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2450 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2451 * gdcmPython/__init__.py doesn't crash anymore when running in
2452 in InstallMode or PreInstallMode but with an environement given
2453 value of GDCM_DICT_PATH.
2454 * src/gdcmDictSet.[cxx/h] coding style.
2456 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2458 * src/gdcm.h general comments moved to TODO, and README
2459 * src/gdcm.h should now be seen as a user commodity (including it
2460 should suffice to fully use gdcm). It is nowhere including within
2461 any of the kernel files src/*.cxx and src/*.h.
2463 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2464 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2465 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2467 * src/gdcm*.cxx only include their corresponding include file
2468 (as opposed to gdcm.h)
2469 * gdcmPython/gdcm.i changed accordingly
2470 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2471 the autogen.sh generated "make snapshot" command to work.
2472 * autogen.sh removed history related references to crea package.
2474 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2475 * distutilsSwigCPlusPlus.py work around some swig portability
2478 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2480 was done in a last ditch attempt to get setup.py _really_
2481 operationnal. The python/gdcmPython layaout add the advantage
2482 of hidding away the python related distutils specific files
2483 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2484 Alas, the src directory was out of scope (i.e. it's relative
2485 position to setup.py was ../src) which made things impossible to
2486 handle (see previous version of python/setup.py). Crossing fingers...
2488 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * python/setup.py now works on Un*x. (harder than I thougth)
2490 * python/distutilsSwigCPlusPlus.py can now have include files
2491 among the list of sources.
2493 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2494 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2495 * modifications in MSVC projects
2497 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * As stated by the first lines of Test/ExceptionAndPython/README, it
2499 looks like we can move back to original usage of exception within
2500 src/gdcm* and hence remove the errno stuff that was introduced
2501 as a quick and dirty fixture of this problem (added to the TODO).
2502 * Doc/Doxyfile configuration file for Doxygen and corresponding
2503 README file for usage added.
2504 * Test/testWrite.cxx added. This new test comes from a split of
2505 test.cxx that is now reverted to its original purpous i.e.
2506 testing the proper parsing of a Dicom related file.
2507 testWrite.cxx concentrates on testing the IO part of gdcm.
2508 * Test/bug1.cxx (containing a bug on WIn32) added.
2509 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2510 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2511 whose purpose is to publish the content of the TagNames of the
2512 Dicom public dictionnary were not accessible without an
2513 instance of class gdcmHeader.
2514 - those methods are now static methods of gdcmDictSet and hence
2515 require no instances at all to be invocated.
2516 - within gdcmDictSet this change required to change some method
2517 to class methods (i.e. are now static) among which SetDictPath
2518 (renamed to BuildDictPath) and LoadDefaultPubDict.
2519 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2520 the above changes by calling the new method classes of gdcmDictSet.
2521 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2522 the above to be effective.
2523 * python/gdcmPython: in order to wrap properly the above changes
2524 for Python, swig version now needs to be > 1.3.17.
2525 * python/gdcmPython/Makefile fixed to adapt itself to new
2526 configure/make shema introduced by Johan Montagnat (thanks for the
2527 contribution). Alas this Makefile cannot be turned into a proper
2528 Makefile.am without some heavy changes in the configure.in
2529 (for python dectection).
2530 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2531 now avoids publishing the empty entries.
2533 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2534 * python/setup.py : bug fix concerning install under windows
2535 ExtraPath reused :-P
2536 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2538 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2539 * Dicts/dicomV3.dic : remove double spaces !!!
2540 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2541 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2544 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2545 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2546 method. Doxygenation.
2547 * src/gdcm.h clean up of JPR spurious comments.
2549 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2550 * python/distutilsSwigCPlusPlus.py now properly collects the
2551 shadow classes generated by "swig -c++" (gdcm.py in our case)
2552 when using "python setup.py install".
2553 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2554 reexports the working classes.
2555 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2556 by the classical C errno scheme. This is to prevent an obscure
2557 behavior of the python wrappers when importing wxPython.wx prior
2558 to gdcmPython (which ended up in an abort call). An illustration
2559 of this oddity can be found in the Test/ExceptionAndPython
2560 subdir (see the README file). This problem probably due to
2561 an combination of g++ and dynamic loading.
2562 * added Test/ExceptionAndPython (see above)
2564 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2565 * Changed the layout of the python part to avoid bloating main
2566 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2567 i.e. the distutils arsenal. All the python related stuff is
2568 again in a python subdir, but the package itself is now in
2570 * setup.py was cleaned up:
2571 - pythonIncludePath removed
2572 - python setup.py bdist target is now functional.
2573 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2574 collision with other packages). gdcmPython/demo/*.py changed
2577 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2578 * python subdir moved to gdcmPython (preparation of distutils packaging).
2579 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2580 distutils installer is operational.
2581 * - gdcmPython/__init__.py now properly loads the swig generated
2582 shadow classes (from gdcm.py).
2583 - gdcmPython/demo/*.py changed to import the package gdcmPython
2584 instead of gdcmPython/demo/load.py.
2585 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2587 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2588 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2589 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2590 entries within the associated public Dicom dictionary resp. the same
2591 information but sorted by the fourth field (PAT, IMG, DIR) of the
2593 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2594 are now in the "???" group.
2595 - python/gdcm.i changed accordingly,
2596 - python/demo/printGroupedPublicDict.py added, that gives an example
2597 of the above new functionalities in Python.
2599 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * src/gdcm.h, gdcmHeader.cxx:
2601 - historic references to glib's g_malloc and g_free (#defined)
2602 were definitively removed.
2603 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2604 * src/gdcmElValSet.cxx:
2605 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2606 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2607 - GetElValue(string) renamed to GetElValueByName.
2608 - Added GetElementByName(string).
2609 * src/gdcmHeader.cxx: added
2610 - GetPubElValRepByNumber(guint16, guint16)
2611 - GetPubElValRepByName(string)
2612 - GetShaElValRepByNumber(guint16, guint16)
2613 - GetShaElValRepByName(string)
2614 - GetShaElValByNumber(guint16, guint16)
2615 - GetShaElValRepByName(string)
2616 - GetElValRepByNumber(guint16, guint16)
2617 - GetElValRepByName(string)
2618 - GetElValByNumber(guint16, guint16)
2619 - GetElValRepByName(string)
2620 * Doc/requirements.txt added.
2622 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2623 * Test/Makefile building now depends on the one of libgdcm.so
2624 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2625 pixel data) aware which enables finding the address (offset) of
2626 the pixel data of JPEG encoded DICOM files. This leaves only a single
2627 file in the testSuite whose pixel data address (offset) is unknown.
2628 * python/testSuite.py changed accordingly.
2630 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2631 * VC++ has some strong limitations when working with the STL, as stated
2632 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2633 "Also note that some STL containers (map, set, queue, list, deque)
2634 cannot be exported. [...]
2635 Some STL classes contain nested classes. These classes can not
2637 This is caused by a designed limitation that once a template
2638 class is instantiated, it can not be re-instantiated and
2640 Since our usage of map<> is ubiquitous in gdcm, this "designed
2641 limitation" of VC++ is a pitfall.
2642 Hence the Python wrappers of gdcm cannot be incrementally linked
2643 against the c++ dynamic library. The dirty but only workaround is
2644 to forget about incremental link of dynamic libraries and to generate
2645 the Python wrappers library with the inclusions of the underlying C++
2647 The following modifications concern this matter on Win32/VC++:
2648 - wrapping python correct with standalone wrapped dll (don't use separate
2649 dll under windows !!!!)
2650 - python21_d debug mode enabled (ask Frog how to use it :-)
2651 - NO problem with having an STL member of class for example string in C++
2652 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2653 - Python test of dcmlib in Python is ok under windows on a large set
2655 * removed glib references
2656 * typedef's inserted in gdcm.i for correct swig type management
2658 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2659 * python/demo/*.py load.py extracted from test.py. Added explore.py
2660 that only displays required tags and testAll.py that parses all
2661 the files of the testsuite without using unittest.
2662 * python/testSuite.py other additional test on new files added.
2663 * Data/* new test files added accordingly to the testSuite.
2664 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2665 the vr in the file differs from the one of the dictionary.
2667 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2668 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2669 values, but limits itself to values which are below a user specified
2670 size (by default 1024 bytes).
2671 * python/gdcm.i : elements not loaded (because their size is above the
2672 user specified treshold) are exported with their TagKey as key of the
2673 python dictionary. This enables the testsuite to make some checks
2674 on the unloaded elements (since we have their offset and size).
2675 * python/testSuite.py
2676 - now tests for the existence and proper value of the pixel data
2677 - two new examples added.
2678 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2680 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2682 aware. See the strategy comments in gdcmHeader::FindeLength().
2683 * Test/test.cxx now accepts a filename as first argument.
2684 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2685 * python/testSuite.py changed to integrate test on above files.
2687 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2688 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2689 the vr was also RET.
2690 * python/testSuite.py more tests added.
2692 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2693 * python/testSuite.py unittest test suite added (uses Data)
2694 * Data/* dcm and acr files for the test suite.
2695 * glib dependance removed from un*x version. We now use ISO C99
2696 7.18 Integer types (see stdint.h)
2697 - python/Makefile, src/Makefile src/gdcm.h
2698 * src/ when an explicit vr (like dicom files) suddenly poped an
2699 implicit element we use to mark the underlying DictEntry of the
2700 concerned ElValue with "Implicit". This strategy was damageable
2701 too the public or provite dictionaries, since some of their vr
2702 would be changed. Since Header::FindLength heavily relies on the
2703 detection by Header::FindVR of falsely explicit elements, I
2704 added an extra ImplicitVr member to ElValue (boolean).
2705 The rest of the changes we the necessary adaptations.
2707 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2710 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2712 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * Adaptation for porting to VC++:
2715 o forced to use std namespace (for string to be known)
2716 o all class use __declspec export style on WIN32
2717 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2718 (in stdlib.h on Win32 but in std:: for gcc)
2719 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2720 variable GDCM_DICT_PATH.
2721 * src/gdcmHeader.cxx verbose comments made discrete.
2723 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * python/gdcm.i: added a typemap that converts a C++ hashing table
2725 to native Python dictionary.
2726 * python/demo/test.py:
2727 - now uses the native dictionary for exploration of gdcmHeader.
2728 - takes an optional filename argument (the file to parse).
2729 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2730 PubElVals hashing table.
2731 * Dicts/dicomV3.dic removed error prone trailing spaces.
2733 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * Python wrapping process moved away from src/Makefile to
2735 newly created python/Makefile (as well as gdcm.i)
2736 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2737 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2738 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2739 from the environement variable GDCM_DICT_PATH (when existing).
2740 * src/gdcmDict::GetTag bug fix.
2742 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * Straightforward temporary fixes for swig to build the python wrappers.
2744 src/Makefile now has a python working entry [by working we mean
2745 that we can import de shadow classes without errors].
2747 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2748 * hashtest.cxx removed (since allready in Test)
2749 * src/gdcmlib.h renamed to src/gdcm.h
2750 * src/dcm.i renamed to src/gdcm.i
2751 * src/Makefile prepared for python wrapping
2753 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2754 * src/gdcmHeader.cxx :
2755 - Parsing of header is now separated from loading of element values
2756 (see gdcmHeader::LoadElements).
2757 - general clean up of hopefully all file access (creation of
2758 ReadInt16 and ReadInt32)
2760 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * src/gdcmHeader.cxx :
2762 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2764 - SetLgrElem renamed to SetLength
2765 - GetLgrElem renamed to GetLength
2766 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2767 * src/gdcmElValSet.cxx fixed both GetElValue methods
2768 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2769 due to IdoDude was cleaned out.
2771 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2772 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2773 concentrates on finding the value representation (when it exists).
2774 RecupLgr now only finds the element value length, and it avoids
2775 returning the unecessary skL (skipped length).
2776 Also, offsetCourant was simply removed (with taille_fich) since
2777 it was redundant with the File position internals (by using
2778 ftell and fseek). This also made skL (see above in RecupLgr) usage
2780 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2781 on the libido specificities which are handled through class
2783 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2786 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * Truckload of changes. Parsing of header is barely functional
2788 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2790 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * src/gdcmHeader.cxx many addons of low level methods
2793 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2794 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2795 and _IdDcmSWAP_LONG.
2797 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2798 * This corresponds to all the changes decided at the meeting of
2799 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob