1 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Memory leak hunt with the following command:
3 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
4 --show-reachable=yes gdcmTests PrintDocument
5 It looks like many (all?) leaks are due to the STL (or a bad usage
6 of the STL. The lines producing the leaks now have a comment with
7 a "MEMORY LEAK" tag: you can retrieve them with
8 grep "MEMORY LEAK" src/*
9 Here are two typical examples which I can't help fixing:
15 name = test; //// <--- valgrind detects 960 bytes lost in
16 //// call to std::string::operator=(char const*)
17 name.clear(); //// Doesn't help !
25 std::cout << "Type a bunch of characters followed by RETURN: ";
26 getline(std::cin, line); //// <--- valgrind dectects a loss
27 //// of 1320 bytes in call to
28 /// std::basic_istream<>& std::getline<>
34 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
35 * src/gdcmHeader.[cxx|h]:
36 - Predicates on the Transfer syntax (of the form Is[JPEF|RLE]*)
37 and related, moved away to gdcmDocument.
38 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
39 the corresponding protected accessors of inherited class
40 gdcmDocument, removed ! As a consequence gdcmFile had to be
41 declared friend of class gdcmDocument (see below).
42 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
43 - Clean up of undefined or unused methods.
44 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
45 account the changes to gdcmHeader.h).
47 - gdcmFile is now a friend class (in order to take into account the
48 changes to gdcmHeader.h).
49 - Predicates on the Transfer syntax (of the form Is[JPEF|RLE]*) added
50 (see changes to gdcmHeader.h).
51 - Accessors (reading on the form GetEntry*) are now public.
52 - Clean up of undefined or unused methods.
53 * src/gdcmDocument.cxx:
54 - adaptation to changes to gdcmDocument.h
55 - ::OpenFile now writes a verbose message when file cannot be opened.
56 - some std::string properly set to VRKey
57 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
58 references to gdcmDocument.
59 * Test/TestFindTags.cxx: changed accordingly to above changes.
60 * gdcmPython/testSuite.py: adapted to renaming of acr files in
61 cvs repository gdcmData.
63 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
64 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
65 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
66 conflicts with gdcmValEntry::voidArea.
67 * src/gdcmValEntry.cxx: unmatching comment wiped out.
68 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
69 Value representation between StringRepresentable and BinaryRepresentable.
70 * src/gdcmDocument.cxx:
71 - method ParseDES: proper indentation restored and usage of
72 gdcmVR::IsVROfGdcmStringRepresentable wired in.
73 - method LoadDocEntry: the fingerprint left in the SetValue() of
74 unloaded entries (length > MaxSizeLoadEntry) had curiously been
75 removed. Reverting to previous code segment with the proper
76 dynamic_cast< gdcmValEntry* >.
77 Note: this was (partially) breaking the python test suite
78 (gdcmPython/testSuite.py) that made usage of the above
79 fingerprint to check presence of "Pixel Data".
80 * src/gdcmDocEntry.h: coding style.
81 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
82 now taken into account.
83 * gdcmPython/gdcm.i: adaptation to the new internal representation
84 of gdcm (exit gdcmParser, hello gdcmDocument).
85 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
87 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
88 anymore, but instead prints the loaded Python dictionary.
89 * .... alas, the python testSuite is still broken.
91 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
94 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
95 * src/gdcmUtil.h : export methods
97 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
98 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
100 * Initial addition of automatic python testing
101 * Initial addition of automatic image comparison
103 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
105 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
107 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
109 * Test/ShowDicom.cxx : bug fix for msvc compilation
110 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
112 2004-05-04 Jean-Pierre Roux
113 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
114 new concepts (and new classes) :
115 a 'gdcmDocument' is composed of a set of Doc Entries, that are
116 - elementary gdcmDocEntries (former gdcmHeaderEntries)
117 - Sequence Doc Entries (gdcmSeqEntries)
118 a Sequence is composed of Items.
119 Each item is a set of Doc Entries (this is recursive)
120 The non uniqueness of the 'Dicom tag' is due to this recursivity
121 (never taken into account)
122 Our unability to add a new 'entry' in the header
123 at the proper location (neither in the H-Table (map or multimap),
124 nor in the Chained List is also due to this recursivity.
125 Don't try, right now, to use/modify/compile these new sources :
127 We just commit all the stuff, 'as is', in order not to loose it.
129 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
132 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
134 file prefix (SetFilePrefix)
136 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
137 * Add a new test: ShowDicom, for now this is just the c++ version of
138 checkRead.sh, later it will be able to compare the image read against a
140 * Replace the DEBUG on the stack with a global entry in cmake interface:
141 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
143 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
144 * Add an example subdir, with a real example on how to read + write a
147 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
148 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
149 * Doc/CMakeLists.txt: the main page is now properly differentiated
150 between the developper and user version.
151 * Doc/doxygen.config.in: dropped search related obsolete flags
152 * src/gdcmParser.h, gdcmHeader.h: doxygenation
154 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
155 * DEVELOPPER: added some helpfull comments for compile/test/install
158 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
159 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
160 src directory, now generated in the build dir.
161 2. Tests as mentionned smarter
163 4. Add a new method in gdcmDict that return the PubDict by name
164 this is interesting for 3rd party lib like ITK,
165 where we could set the institution name / patient name...
167 * ENH: 1. Now the test suite is working for real
168 2. All binaries are now output in the gdcm-bin directory
169 (this was not true before)
171 2004-04-28 Jean-Pierre Roux
172 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
173 SeQuence indented printing of Dicom Header.
174 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
175 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
176 Computation of SQDepthLevel is now part of gdcmHeader constructor
177 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
178 tree-like structure of a Dicom Header.
179 * FIX Test code cleaning
181 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
182 * ENH: Adding automatic testing
183 1. Need a DartConfig.cmake to submit to public
184 2. Add a test driver gdcmTest.cxx
185 3. gdcmTestMain, an helper for the main test driver gdcmTest
186 4. Files in Test don't have a main anymore, this becomes interesting
187 when we add more and more tests, thus dsw don't have to load
189 * ENH: Adding a GDCM_DATA_ROOT for testing
190 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
191 one file instead of seven + some small cleanup
193 2004-04-22 Jean-Pierre Roux
194 * ENH Minor changes to the Print() methods.
195 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
196 Header printing. Example given with :
197 > PrintHeader fileName 2 new
198 (SQ based tree-like structure still to be done for the Header ...)
200 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
201 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
202 1. I have added some unsigned where needed
203 2. Some function parameter not used -> (void)
204 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
205 4. g++ don't like character '\' in comment
206 5. #define jpeg_create_decompress jCreaDecompress
207 this really need to be fixed
208 6. virtualize destructor of gdcmObject ... leakage
209 7. sscanf(g->first.c_str(),"%x",&gr_bid);
210 this also really need to be fixed
211 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
212 remove compression file
213 (as we only do decompression, right ?)
214 * ENH: Change malloc/calloc/free with c++ equivalent
216 2004-04-21 Jean-Pierre Roux
217 * FIX gdcmHeaderHelper::GetXSpacing
218 when a single value is found (bug ?), xpacing is now
219 defaulted to yspacing
221 2004-04-19 Jean-Pierre Roux
222 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
223 * ENH add parameters :
224 bool exception_on_error = false,
225 bool enable_sequences = false,
226 bool ignore_shadow = false
227 to the gdcmFile constructors to be full gdcmParser compliant
228 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
229 to allow reading of PAPYRUS 3.0 files
231 2004-04-06 Jean-Pierre Roux
232 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
234 2004-04-02 Jean-Pierre Roux
235 * ADD : Test/checksequence.sh, for a general recap on SQ pb
236 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
237 for Philips spurious Tag fffe|0000 while rewritting Dicom files
239 2004-03-30 Jean-Pierre Roux
240 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
241 for ACR file, written out as DICOM files (hope so...)
243 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
244 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
245 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
246 moved to base class gdcmParser and only the specialisation is kept
248 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
249 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
250 already does the job.
251 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
252 (to be consistent with gdcmParser::WriteEntries).
254 2004-03-30 Benoit Regrain
255 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
256 upate of the object's instance. It's passed to 2 in the unfavorable
257 case : one in the ExecuteInformation, one in the ExecuteData
259 2004-03-29 Jean-Pierre Roux
260 * ENH : Check on file type to be written moved
261 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
262 * FIX : gdcmObject::ResetBoundaries now stops properly
263 when end-of-list is reached
264 : gdcmVersion modified (as Benoit Regrain asked)
266 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
268 * src/gdcmUtil.cxx: added forgotten iostream include.
269 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
270 equivalent to ExplicitVR in existing code).
272 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
274 now contains all the gdcmGlobal related code.
275 * minor coding style and doxygenation changes.
277 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
278 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
279 now contains all the Debug related code.
280 * minor clean-up of includes in src/*.cxx
281 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
282 CreateCleanString) removed.
283 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
284 * Doc/DoxyMainPageUser.txt added.
285 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
286 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
289 2004-03-24 Jean-Pierre Roux
290 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
292 2004-03-23 Jean-Pierre Roux
293 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
294 big endian made volumes
295 * ENH Now gdcmParser constructor and destructor are protected to forbid
296 end user to instanciate class gdcmParser
297 (only gdcmHeader and gdcmDicomDir are meaningfull)
299 2004-03-22 Benoit Regrain
300 * FIX : src/gdcmDicomDir.cxx : make windows compilable
301 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
302 gdcmSerie to gdcmDicomDirSerie
304 2004-03-19 Jean-Pierre Roux
305 * ENH Now the tree-like structure describing a DICOMDIR comming from
306 an already existing DICOMDIR file is consistent with
307 the home-made tree-like structure build ex-nihilo
308 or build from the files held (recursively) in a Directory
309 functions gdcmDicomDir::CheckBoundaries()
310 gdcmObject::SetBoundaries() added
312 2004-03-17 Jean-Pierre Roux
313 * REM (Eric Boix bug) : removal of meaningless
314 gdcmDicomDirImage::NewImage function.
315 * FIX now file names and directory name are written properly in the
317 * FIX now gdcmDicomDir constructor may be call without any trick
320 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
322 of gdcmDicomDirImage::NewImage as empty function.
324 2004-02-28 Jean-Pierre Roux
325 * ENH add gdcmDicomDir:NewPatient
326 add gdcmDicomDirPatient:NewStudy
327 add gdcmDicomDirStudy:NewSerie
328 add gdcmDicomDirSerie:NewImage
329 to allow making gdcDicomDir object.
330 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
331 (as opposite to the gdcmHeader chained list)
333 2004-02-11 Benoit Regrain
334 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
335 when using from python
337 2004-02-10 Benoit Regrain
338 * FIX : bug fix in the gdcmDirList for the recursivity in directories
339 * FIX : in gdcmDicomDir when the directory is empty
340 * ENH : add callback and methods to get the progression of dicomDir
343 2004-02-06 Jean-Pierre Roux
344 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
345 - GDCM_META added to gdcmDicomDirType
346 - class gdcmMeta created
347 * ENH : - A brief summary is now displayed at the beginning of
348 'testDicomDir' to help disaster magnitude estimation
349 * REM : Now useless Test/explDICOMDIR.cxx
351 2004-02-05 Benoit Regrain
352 * ENH : add methods in gdcmObject to get the hash table or the list of
354 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
355 * FIX : wrapping python for TagHeaderEntryHT
357 2004-02-04 Benoit Regrain
358 * FIX : even length for some strings when writting the dicom dir
359 * FIX : sort the images in the dicom dir
360 * FIX : Bug fix for python use of dicom dir
361 * ADD : a python demo
363 2004-02-04 Jean-Pierre Roux
364 * FIX : Final solution (?) for icone embedded images
365 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
366 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
367 add groups 6002, 6004, 6006, to allow 'clean' parsing of
368 gdcmData/gdcm-MR-SIEMENS-16.acr1
369 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
370 to make full checking easier
372 2004-02-04 Benoit Regrain
373 * FIX : WriteEntries : coding style & logic in parameters
374 * FIX : Set the elements to create the DicomDir in a dictionary file
376 2004-02-03 Benoit Regrain
377 * gdcmDirList : to parse a hard drive directory in recursive (or not)
378 * gdcmDicomDir : add the load of directory
379 * Bug fix and print add-on
381 2004-02-03 Jean-Pierre Roux
382 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
383 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
384 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
385 * FIX gdcmParser.cxx : 'group length' elements are now considered
386 as integers, even for shadow groups, when file is Implicit VR
388 2004-02-02 Jean-Pierre Roux
389 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
391 of the last synonym :-(
392 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
394 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
395 * FIX taking into account the possible 7fe0,0010 multiplicity
396 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
397 to allow removal of references to 7fe0,0010, to deal with
398 ACR-NEMA images, when 0028,0200 is meaningfull
400 2004-01-31 Jean-Pierre Roux
401 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
402 no longer writes 'Un' on disk
403 * FIX SQ elements with actual length are now dealt with corectly
404 * FIX gdcmFile::WriteBase make the difference, for color images, between
405 the length (for Palette expanded images)
406 and Raw Length (non expanded image + Palette)
407 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
408 (that broke Write). Replaced by UL.
409 Aware user will reload the field if he
410 thinks it's necesssary
412 2004-01-30 Jean-Pierre Roux
413 * gdcmParser::CheckSwap() now defaults the filetype to ACR
414 when 'dirty Acr' is found, to be compliant with the new
415 IsReadable() methods.
417 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
418 (no DOUBLE images in kosher DICOM,
419 but so usefull for people that miss them ;-)
421 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
422 DICOMDIR related utilities (not checked as Windoze compliant)
424 2004-01-28 Jean-Pierre Roux
425 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
427 2004-01-27 Jean-Pierre Roux
428 * gdcmParser constructor has a new boolean param,'ignore_shadow',
429 to allow skipping the shadow elements, to save memory space.
430 The TRUE value for this param has to be used
431 with a FALSE value for the 'enable_sequence' param.
432 ('public elements' may be embedded in 'shadow Sequences')
433 * gdcmHeader methods now deal with 'embedded icones images' in the header
434 (even when an 'icone image sequence' is announced by the
435 element (0x0088,0x0200), but there is NO icone at all ...
437 * gdcmHeader sometimes Image Location value doesn't follow
438 the supposed processor endianity (see gdcmData/cr172241.dcm).
441 * gdcmHeader add the method
442 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
443 to get *all* the Header Entries with the same tag.
444 GetHeaderEntrySameName is probabely *useless*
445 (no meaning : Name is *not* an identifier within the Dictionnary)
447 2004-01-26 Benoit Regrain
448 * Bug fix in the print of hexadecimal representations. Remove long fields
449 in the print and add a third level of print to print them
451 2004-01-23 Benoit Regrain
452 * Bug fix on field having a VR = 'UI'. Assume that is a string field
453 * Bug fix on test suite after remove the strip made on not string fields
454 * Split the IsReadable method between gdcmParser which test that the file
455 is dicom and gdcmHeader which test that it's an image file
457 2004-01-22 Benoit Regrain
458 * DicomDir : clean code, add methods, set variables in protected or private
459 * gdcmUtil : bug fix for the clean string method
461 2004-01-19 Benoit Regrain
462 * Add the use of shadow dictionaries
463 * bug fix and coding style
465 2004-01-19 Benoit Regrain
466 * src/gdcmFile.cxx : bug fix concerning the close of file
467 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
468 * Add the update of header entries using the shadow library
470 2004-01-19 Benoit Regrain
471 * removal of file gdcmHeader2.cxx
472 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
473 inheriting from gdcmParser. This split is to prepare the integration
475 * bug fix under python
477 2004-01-16 Jean-Pierre Roux
478 * REM removal of class gdcmHeaderEntrySet
479 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
480 * ADD add file gdcmHeader2.cxx
481 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
483 2004-01-15 Benoit Regrain
484 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
485 entries created while parsing the header. Thus, they will be destroyed
486 when the gdcmDictSet will be destroyed
487 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
490 2004-01-15 Benoit Regrain
491 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
492 made a fatal error because of the memory release at the end of program.
493 The problem was in vtkGdcmReader::ExecuteData where we were allocate
494 some memory and vtk seems to have some problems with that.
495 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
497 2004-01-14 Benoit Regrain
498 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
499 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
500 * src/*.[h|cxx] : make changes due to class name changes
501 * gdcmPython/demo/*.py : bug fix due to method names
503 2004-01-13 Benoit Regrain
504 * src/*.[h|cxx] : coding style
505 * vtk/*.[h|cxx] : coding style
507 2004-01-13 Benoit Regrain
508 * gdcmPython/testSuite.py : test the readable flag of file for tests
509 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
510 It's lied to the stl compilation by MSVC (windows, always windows...)
511 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
513 2004-01-12 Benoit Regrain
514 * src/*.h : add comments
515 * src/gdcmDictSet.h : set the method BuildDictPath in public
516 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
517 directly setted in the source code
518 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
521 2004-01-09 Benoit Regrain
522 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
523 * setup.py : use a reference to gdcmVERSION
525 2004-01-07 Benoit Regrain
526 * Modification to compile with the distutils.
529 2003-12-10 Benoit Regrain
530 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
531 can use a gdcmHeaderHelper to load datas
532 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
533 made in the source code
535 2003-12-10 Benoit Regrain
536 * Update Windows projects and .cvsignore files
538 2003-11-12 Jean-Pierre Roux
539 * ENH gdcmHeader constructor has one more parameter (default value : false)
540 that allows the user to 'go inside' the SeQuences only
542 gdcmElValSet:Print takes it into account
544 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
545 * ENH: Update gdcmPython/CMakeLists
546 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
547 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
549 2003-11-10 Jean-Pierre Roux
550 * FIX : gdcmHeader::LoadElements is now based
551 on the ListTag listElem member,
552 not longer on the TagElValueHT tagHt member
553 * ENH : PrintPubElVal shows (temporarily) both results,
554 with the tagHt member and the listElem member.
555 (it's easier to 'see' the problems when using Printheader)
557 * FIX : old private member LgrElem is now splitted into
558 ReadLength : Length actually found on disk (updated only
559 if bug fixing is necessary), for internal
561 UsableLength : Updated by FixFoundLength, to fix a bug
562 or to allow Parser going on.
563 Will allow to re-write a kosher header when a SeQuence
564 with a length (not 0000) is found
565 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
566 because gdcmElValSet::Add does not update ListElem
569 2003-11-07 Jean-Pierre Roux
570 * FIX misstyping in Transfert Syntax name table
571 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
572 when they have an actual length (not 0000 nor FFFFF)
573 (Nobody should care of it, but DICOMDIR explorers)
575 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
576 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
578 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
579 * ENH: vtkGdcmReader now supports LUT !
580 (vtkgdcmViewer for now is not able to use them though)
582 2003-11-05 Jean-Pierre Roux
583 * in testSuite.py : new files names for checking the package
584 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
585 that returns the pixel area size to the *aware* (vtk) user
586 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
588 2003-11-05 Benoit Regrain
589 * in testSuite.py : Modify the rules for checking the paths
590 : Explicit error messages
591 * in __init__.py : Related modif
593 2003-11-03 Jean-Pierre Roux
594 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
595 to be used by aware (vtk) users that want to manage
596 LUT (and no to turn the PALETTE image into an RGB pixels one)
597 * GetPixelType now returns 8U for 24 Bits images
598 (vtkGdcmReader compliant)
600 2003-10-31 Jean-Pierre Roux
601 * Removal of *all* gdcmData images and add them again
602 in order to loose the 'history' of un-anonymised images
604 2003-10-31 Jean-Pierre Roux
605 * RMV : removal of useless jBitsInJsample.h
606 for both 8 and 12 Bits JPEG Lossy Libraries
608 2003-10-31 Jean-Pierre Roux
609 * ENH : Add the functions gdcmFile::GetImageDataRaw
610 gdcmFile::GetImageDataIntoVectorRaw
611 that act as GetImageData and GetImageDataIntoVector
612 except the making of an RGB Plane from Gray Plane + LUT
613 Intended to aware (vtk) users who know how to manage
616 GetLUTRGBA return a R,G,B,A LUT if any
617 lgrTotaleRaw gives the 'Raw' length
618 GetImageDataRaw returns the gray Plane
619 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
620 (They stay Grey, just like with other Dicom viewers :-(
622 2003-10-30 Jean-Pierre Roux
623 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
625 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
626 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
627 being coherents dicom files.
629 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
630 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
632 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
633 * ENH: Two steps is necessary to please VC++ compiler...
634 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
635 * ENH: Add include dir to medcon lib
636 * FIX: only one function is being exported for now !
637 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
639 2003-10-29 Jean-Pierre Roux
640 * adding gdcmHeader::GetLUTRGBA
641 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
642 --> Mathieu, the modif u're waiting for is not yet committed
643 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
645 2003-10-27 Jean-Pierre Roux
646 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
647 00191113.dcm DermaColorLossLess.dcm
648 MxTwinLossLess.dcm RadBWLossLess.dcm
649 * ENH: For version prior to vtkImageViewer2 -r 1.19
650 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
652 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
653 * Removal of ido stuff in CMakeLists.txt
655 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
656 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
657 * FIX: remove a call to ->Modified ... see comments
658 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
660 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
661 * FIX: Problem with path for libvtkgdcmPython
662 * ENH: Try adding a search script for python site-package
663 * RMV: Remove some file from medcon lib that are not necessary
664 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
665 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
666 * FIX: More pragma disable fro VC++,
667 I don't think I break something as it is also disable in VTK/ITK.
668 But it fasten debug compilation time.
670 2003-10-23 Jean-Pierre Roux
671 * gdcm now deals with 16 Bits Run Length Encoded images
672 (they are compressed as 2 planes images,
673 one for the high Bytes, the other for low Bytes)
675 2003-10-22 Jean-Pierre Roux
676 * Now CheckRead takes into account :
677 - the bugged 'Leonardo' Siemens images
678 - the XA images, sent thru the burning VPRO station
679 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
682 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
683 * FIX: When copying a Makefile.am to CMakeLists.txt
684 one should remove the '\'
686 2003-10-22 Jean-Pierre Roux
687 * in gdcmData adding a bugged 'Leonardo' Siemens image
688 (wrong lengths in header)
689 OK with gdcm, KO with the other viewers :-)
690 * add a GE dlx XA image, thru the VEPRO burning station
693 2003-10-21 Jean-Pierre Roux
694 * in gdcmData add the checkvtkgdcmViewer.sh shell script
695 for a brutal checking of vtkgdcmViewer compliance
697 2003-10-21 Jean-Pierre Roux
698 * add the files for 'xmedcon' Jpeg Lossless library
699 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
701 2003-10-21 Jean-Pierre Roux
702 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
704 2003-10-21 Jean-Pierre Roux
705 * garbage Siemens 'Leonardo' images dealt with
706 (the patch is easy to remove)
707 * cosmetic changes to avoid warnings
709 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
710 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
711 no need to press 'r' now.
713 2003-10-20 Jean-Pierre Roux
714 * upgrade of checkRead.sh checkWrite.sh according
715 to new Jpeg Lossless decompressor
716 * add US.3405.1.dcm, a genuine RGB medical file ...
717 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
718 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
720 2003-10-15 Jean-Pierre Roux
721 * general anonymisation in gdcmData
722 * adding the 'color files' from
723 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
724 * adding some well knowed bugged-header images
725 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
726 waiting for their inclusion in Python testsuite
728 2003-10-15 Jean-Pierre Roux
729 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
730 no longer seg faults when file is not found
732 2003-10-14 Jean-Pierre Roux
733 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
736 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
737 * TODO: *.in file to genereate a UseGDCM later
739 2003-10-14 Jean-Pierre Roux
740 * Some supposed-to-be Dicom Images have no preamble.
741 OpenFile takes it into account
742 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
743 * Missing elements added in dicomV3.dic
744 (just to be affraid : have a look at
745 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
746 and do it again next year ;->
748 2003-10-13 Jean-Pierre Roux
749 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
750 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
751 But there are NOT. It's fixed !
753 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
754 * FIX: "jpeglib.h" was not found on VC++
755 * FIX: vtkgdcm was not being installed
757 2003-10-10 Jean-Pierre Roux
758 * ENH : OpenFile closes the file if it *really* doesn't look like
759 an ACR-NEMA / DICOM one.
760 * FIX : testWrite no longer writes an empty file if the source file
762 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
765 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
766 * FIX: CMake generate now documentation
767 * ENH: out of source doc build !
768 * ENH: Generate both user and dev documentation
769 * ENH: Should work on windows too
770 * ENH: Only one doxygen config.in file is needed
771 * FIX: make install should be ok now on ùnix plateform
772 * FIX: PATH to dictionary was wrong (missing /)
773 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
775 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
776 * vtkGdcmReader is now able to read rgb dicom file.
777 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
778 * added a gdcmViewer to vtk test, use mouse to control
779 window level & window width
781 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
782 * CMake-ification of gdcm, we have now two build system
783 * FIX: on cygwin Wsock32 doesn't exist
784 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
786 2003-10-06 Emanuel Ollart
787 * FIX : compilation process wad broken.
788 Changed gdcmViewer_sources to vtkgdcmViewer_sources
790 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
791 * change gdcmViewer -> vtkgdcmViewer
792 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
794 2003-10-06 Jean-Pierre Roux
795 * FIX :A few nasty patches to allow the reading of a lot of nasty images
796 ( e.g : well known GE images with a wrong elem length,
797 : Philips MRI Images with a wrong Huffman table)
798 * still to be done : allow the reading of bugged LEONARDO Siemens images
800 2003-10-03 Jean-Pierre Roux
801 * Odd length strings are padded with '\0' (not with spaces,
802 to remain compliant with already defined strings,
803 like Transfert Syntax UID and others)
805 2003-10-03 Jean-Pierre Roux
806 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
807 to allow displaying RGB images (not only by affim ;-)
809 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
810 * vtkGdcmReader is now able to read rgb dicom file.
811 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
813 2003-10-03 Jean-Pierre Roux
814 * A few nasty patches to allow the reading of a lot of nasty images
815 ( e.g : well known GE images with a wrong elem length,
816 : Philips MRI Images with a wrong Huffman table)
817 * still to be done : allow the reading of bugged LEONARDO Siemens images
819 2003-10-03 Jean-Pierre Roux
820 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
822 2003-10-03 Jean-Pierre Roux
823 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
824 to allow displaying RGB images (not only by affim ;-)
826 2003-10-03 Jean-Pierre Roux
827 * gdcmFile::GetImageDataIntoVector now
828 - deals with MultiFrames MultiFragments Run Length Encoded files
829 - deals with YcBcR (YBR_FULL) files
830 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
831 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
835 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
836 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
837 Two reasons: - clear things
838 - third parties acces gdcm through header files, so won't
839 suffer anymore VC++ complains
841 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
842 * add argv[1] in testvtkGdcmReader.cxx
845 2003-09-24 Jean-Pierre Roux
846 * The lines are now eigthy characters long.for
847 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
849 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
850 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
851 char* to std::string. Thus, the use of strdup becomes useless. (see
852 previous commis of Malaterre)
853 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
854 before the last Malaterre's commit.
856 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
857 * This commit should fix the Debug building under VC++, the problem
858 was mainly a mixture of debug and release lib being loaded at startup.
859 * I also remove a depency to a specific C function: strdup. Because I had
860 to force the link to msvcrtd (whereas strdup is in libc).
862 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
863 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
864 located in the gdcmCommon.h file. All use of reference of tha has been
865 changed to now use the variable GDCM_UNFOUND.
867 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
869 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
870 Dicom dictionary. The test suite can now be run again. Note:
871 I'm note very happy with the " (RET)" changes. I believe this
872 RETAINED comment should be dropped when parsing the dictionary.
875 - AUTHORS updated and now in alphabetical order
876 * Makefile.am now exports gdcm.dsw for Windoze users.
878 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
879 * cygwin complains about missing std:: in subdir Test/
881 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
882 * remove some methods that are now in gdcmHeaderHelper
884 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
885 * vtkGdcmReader set spacing and origin correctly
887 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
888 * Fix a few delete/delete[] mismatch
890 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
891 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
892 interpretation to data given by gdcmHeader. For instance there are
893 heuristics to get informations (look at different places).
894 * it also include a specific class: gdcmSerieHeaderHelper devoted to
895 sorting DICOM images based on different strategies.
896 * modified Makefiles accordingly.
898 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
899 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
900 when building in debug mode
901 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
902 src/win32/gdcmdll.dsp
903 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
905 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
906 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
909 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
910 * src/win32/libgdcmjpeg12.dsp was not dos format
911 * src/win32/libgdcmjpeg12.dsp :
912 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
913 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
915 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
916 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
918 * src/gdcmFile.cxx : bug fix in affectation type
919 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
920 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
921 * Modifs of MVSC projects to compile them. Not concerning 2 identic
922 symbols... future problem ?
924 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
925 * src/win32/libgdcmijpeg12.dsp was missing
926 * modified gdcm.dsw accordingly
928 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
929 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
931 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
932 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
933 commit of JPR (before his hollidays to facilitate our work).
934 * setup.py : bug fix in code. Modifications made while the last commit
935 of JPR. The code hasn't been tested before the commit... it's so
936 useless to make that (for best programmer that is JPR) !!!
938 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
939 * tagged the current version as Version0_3 (i.e. version 0.3)
941 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
942 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
943 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
944 * *.dsp : modifications to use new libgdcmijpeg8 library
945 * setup.py : bug fix on VTKPATH variable
946 * PACKAGER : adding all concerning windows
948 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
951 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
952 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
953 test suite reported error.
954 * PACKAGER file added (describes what a packager must do when
955 packaging a new release).
956 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
957 * configure.in: upgraded version number to 0.3.0
958 * fixing build of rpm (through rpm -ta):
959 - Doc/Makefile.am exports proper doxygen files
960 - src/jpeg/libijg8/Makefile.am exports the include files.
962 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
963 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
964 * src/gdcmHeader.h : formatting code
966 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
967 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
968 We were obtaining error message from vtk. Now, creation of file list
969 is made in an internal list to prevent this problem.
970 Bug fix when output is empty.
971 Bug fix in update of progress value. Previous commit for this was a bad
973 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
975 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
976 * src/gdcmHeader.h : added method to get the file name
977 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
978 files. Added method to remove all files on the input
979 Added FIXME comment concerning the bad parsing of header made by
980 ExecuteInformation method (in ExecuteData method)
982 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
984 when using make instal.
985 * src/gdcmFile.cxx : bug fix under Window after JPR commit
986 RQ : the JPR doesn't appear in the ChangeLog... normal for him
988 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
989 * setup.py : adding include dir of jpeg lib to compile all sources
990 * */Win32/*.dsp : JPR fix for windows compilation
992 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
993 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
995 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
996 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
998 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * setup.py is again effective on un*x (takes into account the
1000 addon of the jpeg library)
1001 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1002 * Doc/Doxy* updated (includes above enhancements)
1003 * INSTALL now points to web documentation
1005 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1006 * src/gdcmHeader.h doesn't make unnecessary reference to
1008 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1010 * src/gdcm*.[cxx|h] :
1011 - to allow compilation with gcc 3.x
1012 -- clean up of STL usage (added explicit usage of std::)
1013 -- small fixes on exceptions.
1014 Note: linking not tested !
1015 - clean of doxygen comments to avoid warnings at documentation
1017 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1018 dependent convertion).
1020 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1021 * Clean up of previous JPR garbage commit (not even commented in the
1023 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1024 - moved all jpeg related files from src to src/jpeg/libijg8, with
1025 addition/modification of Makefile.am and configure.in.
1026 - the testSuite is still brain damage (not guilty).
1028 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1029 * WrapVTK.py : modifications to get correctly vtk source files to
1031 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1032 (FileName -> Filename)
1034 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1035 * vtk/vtkGdcmReader.[cxx/h]:
1036 - UpdateProgress method should now be effective
1037 - removed the limitation on having only images loaded (as opposed
1039 - when building a stack of images/volume, a lesser number of
1040 gdcmHeader and gdcmFile instances should be used (hopefully
1041 accelerating things).
1042 - when building a stack of images/volumes, files which are not
1043 loadable (wrong path-filename, wrong permissions on existing file,
1044 or file not parsable by gdcm) are replaced with a black image
1045 in the stack (for the caller to notice the problem).
1047 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1050 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1051 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1052 between standard library (std) and vtk library (problems are found
1053 under Windows... thanks Windows !)
1055 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1056 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1058 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1060 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1061 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1063 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * When compiling with distutils (see setup.py) the C++ compiler is
1065 called with different flags than the default ones (with automake).
1066 In order to fix all those warning, I compiled gdcm with the command
1067 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1068 and went for warning fixes:
1069 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1070 up from unused variables.
1071 - vtk/vtkGdcmReader.cxx: potential bug fix.
1072 * src/gdcmHeader.h: Doxygen warning cleanup
1074 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1075 * gdcmPython/gdcm.i:
1076 - typemaps correction to take into account the systematic replacement
1077 of "using namespace std" with std:: prefix e.g. std::list,
1078 std::string... (cf changes of 2003-05-21).
1079 - gdcmGlob global variable of type gdcmGlobal (defined in
1080 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1081 exported to Python a as cvar.
1082 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1083 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1084 gdcmDictSet.GetPubDictTagNames() and
1085 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1086 C++ static methods).
1087 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1088 with the above changes.
1090 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1091 * setup.py, manifest.in : bug fix under linux
1093 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1094 * Modification of setup.py to compile vtk part too. Then, we have 2
1095 wrappers which must work with same distutils. For that, we have a
1096 generic distutils in distusiltsWrapping.py ; with :
1097 - build_extWrap class to wrap generically all extensions,
1098 - ExtensionWrap base class for all wrapping extension that contains
1100 - Wrapper interface which wrap sources
1101 + In WrapSwig.py we have extension and wrapper for Swig
1102 + In WrapVTK.py we have extension and wrapper for VTK
1103 * MANIFEST.in : modifications to consider vtk directory and new python
1104 files for compilation
1106 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1107 * Added python wrappers of vtkGdcmReader vtk class (see the
1108 source in vtk/vtkGdcmReader.cxx) :
1109 - vtk/Makefile.am now builds a library
1110 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1111 python library (as opposed to _gdcm.so wich are the python
1112 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1113 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1115 - configure.in has an additional flag --enable-vtk that needs
1116 to be set to enable compilation of vtk related code, that is:
1117 + vtk/vtkGdcmReader.so and
1118 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1119 + gdcmPython/vtkgdcmPython.so (see above)
1120 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1121 be read when compressed or when HighBit + 1 != BitsStored),
1122 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1123 the usage of the python wrapper of vtkGdcmReader vtk class.
1124 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1125 * src/*.[h] all occurences of stl classes are now prefixed with
1126 std::, and all occurences of "using namespace std;" where removed.
1127 This is to avoid pollution of global namespace in included files.
1128 Apparently vtk does not avoid this pitfall: when using both
1129 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1130 collision of various stl members (principally cout...).
1131 * gdcmPython/testSuite.py now cleanly removes temprory generated
1133 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1134 comply with above changes)
1136 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1137 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1138 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1139 vtk data structure (an image Flip was required).
1140 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1141 * cosmetic changes in documentation.
1143 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1144 * src/gdcmHeader.cxx: the constructor no longer exits when an
1145 unexisting file is given as argument.
1146 * The subdirectory Data (containing all the images used for the
1147 test suite) is not part of this repository anymore. A new module
1148 containing those images is now available at
1149 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1150 with the name gdcmData.
1151 All the python scripts (including the package initialisation file
1152 gdcmPython/__init__.py) were adapated to take this change into
1153 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1155 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1156 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1157 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1158 demo of the usage of this class.
1159 Compilation of this vtk part is only done when using the --enable-vtk
1160 at configure (or autogen.sh) stage.
1162 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1163 * More memory link related corrections and documentation fixes.
1165 - maximum info is obtained with a command of the form:
1166 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1167 --show-reachable=yes PrintHeader
1168 - the remaining reachable blocks seem to come from the STL
1169 allocation scheme through the usage of map and list. It looks
1170 like this memory cannot be freed but it is not a memory leak
1171 (in fact further invocation to the STL would recollect the
1172 unused memory allthough it cannot explicitely be freed).
1173 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1174 of displaying an image parsed with gdcm and displayed with VTK.
1175 Note: some images don't seem to work e.g.
1176 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1177 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1178 Allthough this weakens the semantics, it is a ditch attempt to
1179 make gdcm more thread friendly.
1181 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1182 * Memory link hunt (by using valgrind through the command
1183 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1184 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1185 gdcmHeader::_dicom_vr.
1186 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1187 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1189 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1191 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1192 * src/Makefile.am now exports all the necessary include files at
1196 * UpdateGroupLength replaced by new one
1199 * UpdateGroupLength re-written using H-Table
1200 (named UpdateGroupLengthNew untill checks are over)
1202 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1203 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1204 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1206 - gdcmHeader::GetPubElValSet removed.
1207 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1208 UpdateGroupLength, WriteElements, Write.
1209 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1210 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1211 carried the same semantics.
1212 - src/gdcmHeaderIdo.cxx changed accordingly.
1213 - gdcmFile::WriteBase now regroups all the codes from previous
1214 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1215 - enum FileType moved to gdcmCommon.h
1216 * src/gdcmHeader.cxx AddDefault trashed
1217 * gdcmGetXSize added
1218 * getimageDataSize now calls gdcmGetXSize
1219 * Test/*.cxx changed to agree with above changes
1221 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1222 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1223 (to avoid double call by end user).
1224 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1225 by end user, since gdcmHeader::gdcmHeader now handles it.
1227 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * gdcm/Doc many doxygen changes:
1229 - Doxyfile now has two different versions, DoxyfileUsers that generates
1230 the html.users end users oriented documentation and
1231 DoxyfileDeveloppers that generates the html.developper developper
1232 oriented documentation.
1233 - README changed accordingly
1234 - requirement.txt removed (old design info moved to TODO).
1235 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1236 DoxyMainPage.txt, DoxyPython.txt provide more information.
1237 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1238 be updated by simply regenerating the docs with doxygen and copying
1239 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1240 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1241 all the tests in the form "if (<map>.count() >1)" were removed.
1242 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1243 ill-formed documentation sections.
1244 * src/gdcmHeader.cxx: ditto
1246 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1247 * setup.py fixed for un*x (needed macro for stdint.h)
1248 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1249 un*ces with sh-utils test utility.
1250 * gdcmPython/demo/test.py renamed to PrintHeader.py
1251 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1252 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1253 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1254 * src/gdcm*.cxx JPR's bad inclusion fixed.
1256 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1257 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1258 * gdcmPython/demo/test.py changed accordingly.
1260 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * gdcmPython/Makefile.am fixed linking against libstdc++
1262 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1263 * Swig subdir (historical tests of swig version 1.3.17++) removed
1264 * Test/testChangeEntete.cxx some lines commented out in order to make
1266 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1267 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1269 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1270 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1271 hence the user doesn't need this explicit call.
1272 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1273 i.e. LoadElements() call removed.
1274 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1275 - src/Makefile.am declares the proper flag for g++.
1276 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1277 for adding user defined new tags.
1278 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1279 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1280 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1282 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1283 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1284 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1285 src/Makefile.am : the project should properly compile and install
1286 with the autotools, included the python wrappers part.
1287 * gdcm.spec.in : added a spec file for RPM packaging.
1289 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1290 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1292 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1293 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1294 to exported to the environement (see gdcmPython/testSuite.py
1296 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1297 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1298 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1299 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1300 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1302 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * gdcmPython/__init__.py doesn't crash anymore when running in
1304 in InstallMode or PreInstallMode but with an environement given
1305 value of GDCM_DICT_PATH.
1306 * src/gdcmDictSet.[cxx/h] coding style.
1308 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1309 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1310 * src/gdcm.h general comments moved to TODO, and README
1311 * src/gdcm.h should now be seen as a user commodity (including it
1312 should suffice to fully use gdcm). It is nowhere including within
1313 any of the kernel files src/*.cxx and src/*.h.
1315 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1316 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1317 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1319 * src/gdcm*.cxx only include their corresponding include file
1320 (as opposed to gdcm.h)
1321 * gdcmPython/gdcm.i changed accordingly
1322 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1323 the autogen.sh generated "make snapshot" command to work.
1324 * autogen.sh removed history related references to crea package.
1326 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1327 * distutilsSwigCPlusPlus.py work around some swig portability
1330 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1331 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1332 was done in a last ditch attempt to get setup.py _really_
1333 operationnal. The python/gdcmPython layaout add the advantage
1334 of hidding away the python related distutils specific files
1335 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1336 Alas, the src directory was out of scope (i.e. it's relative
1337 position to setup.py was ../src) which made things impossible to
1338 handle (see previous version of python/setup.py). Crossing fingers...
1340 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1341 * python/setup.py now works on Un*x. (harder than I thougth)
1342 * python/distutilsSwigCPlusPlus.py can now have include files
1343 among the list of sources.
1345 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1346 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1347 * modifications in MSVC projects
1349 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1350 * As stated by the first lines of Test/ExceptionAndPython/README, it
1351 looks like we can move back to original usage of exception within
1352 src/gdcm* and hence remove the errno stuff that was introduced
1353 as a quick and dirty fixture of this problem (added to the TODO).
1354 * Doc/Doxyfile configuration file for Doxygen and corresponding
1355 README file for usage added.
1356 * Test/testWrite.cxx added. This new test comes from a split of
1357 test.cxx that is now reverted to its original purpous i.e.
1358 testing the proper parsing of a Dicom related file.
1359 testWrite.cxx concentrates on testing the IO part of gdcm.
1360 * Test/bug1.cxx (containing a bug on WIn32) added.
1361 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1362 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1363 whose purpose is to publish the content of the TagNames of the
1364 Dicom public dictionnary were not accessible without an
1365 instance of class gdcmHeader.
1366 - those methods are now static methods of gdcmDictSet and hence
1367 require no instances at all to be invocated.
1368 - within gdcmDictSet this change required to change some method
1369 to class methods (i.e. are now static) among which SetDictPath
1370 (renamed to BuildDictPath) and LoadDefaultPubDict.
1371 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1372 the above changes by calling the new method classes of gdcmDictSet.
1373 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1374 the above to be effective.
1375 * python/gdcmPython: in order to wrap properly the above changes
1376 for Python, swig version now needs to be > 1.3.17.
1377 * python/gdcmPython/Makefile fixed to adapt itself to new
1378 configure/make shema introduced by Johan Montagnat (thanks for the
1379 contribution). Alas this Makefile cannot be turned into a proper
1380 Makefile.am without some heavy changes in the configure.in
1381 (for python dectection).
1382 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1383 now avoids publishing the empty entries.
1385 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1386 * python/setup.py : bug fix concerning install under windows
1387 ExtraPath reused :-P
1388 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1390 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1391 * Dicts/dicomV3.dic : remove double spaces !!!
1392 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1393 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1396 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1397 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1398 method. Doxygenation.
1399 * src/gdcm.h clean up of JPR spurious comments.
1401 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1402 * python/distutilsSwigCPlusPlus.py now properly collects the
1403 shadow classes generated by "swig -c++" (gdcm.py in our case)
1404 when using "python setup.py install".
1405 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1406 reexports the working classes.
1407 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1408 by the classical C errno scheme. This is to prevent an obscure
1409 behavior of the python wrappers when importing wxPython.wx prior
1410 to gdcmPython (which ended up in an abort call). An illustration
1411 of this oddity can be found in the Test/ExceptionAndPython
1412 subdir (see the README file). This problem probably due to
1413 an combination of g++ and dynamic loading.
1414 * added Test/ExceptionAndPython (see above)
1416 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1417 * Changed the layout of the python part to avoid bloating main
1418 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1419 i.e. the distutils arsenal. All the python related stuff is
1420 again in a python subdir, but the package itself is now in
1422 * setup.py was cleaned up:
1423 - pythonIncludePath removed
1424 - python setup.py bdist target is now functional.
1425 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1426 collision with other packages). gdcmPython/demo/*.py changed
1429 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1430 * python subdir moved to gdcmPython (preparation of distutils packaging).
1431 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1432 distutils installer is operational.
1433 * - gdcmPython/__init__.py now properly loads the swig generated
1434 shadow classes (from gdcm.py).
1435 - gdcmPython/demo/*.py changed to import the package gdcmPython
1436 instead of gdcmPython/demo/load.py.
1437 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1439 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1440 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1441 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1442 entries within the associated public Dicom dictionary resp. the same
1443 information but sorted by the fourth field (PAT, IMG, DIR) of the
1445 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1446 are now in the "???" group.
1447 - python/gdcm.i changed accordingly,
1448 - python/demo/printGroupedPublicDict.py added, that gives an example
1449 of the above new functionalities in Python.
1451 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1452 * src/gdcm.h, gdcmHeader.cxx:
1453 - historic references to glib's g_malloc and g_free (#defined)
1454 were definitively removed.
1455 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1456 * src/gdcmElValSet.cxx:
1457 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1458 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1459 - GetElValue(string) renamed to GetElValueByName.
1460 - Added GetElementByName(string).
1461 * src/gdcmHeader.cxx: added
1462 - GetPubElValRepByNumber(guint16, guint16)
1463 - GetPubElValRepByName(string)
1464 - GetShaElValRepByNumber(guint16, guint16)
1465 - GetShaElValRepByName(string)
1466 - GetShaElValByNumber(guint16, guint16)
1467 - GetShaElValRepByName(string)
1468 - GetElValRepByNumber(guint16, guint16)
1469 - GetElValRepByName(string)
1470 - GetElValByNumber(guint16, guint16)
1471 - GetElValRepByName(string)
1472 * Doc/requirements.txt added.
1474 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1475 * Test/Makefile building now depends on the one of libgdcm.so
1476 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1477 pixel data) aware which enables finding the address (offset) of
1478 the pixel data of JPEG encoded DICOM files. This leaves only a single
1479 file in the testSuite whose pixel data address (offset) is unknown.
1480 * python/testSuite.py changed accordingly.
1482 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1483 * VC++ has some strong limitations when working with the STL, as stated
1484 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1485 "Also note that some STL containers (map, set, queue, list, deque)
1486 cannot be exported. [...]
1487 Some STL classes contain nested classes. These classes can not
1489 This is caused by a designed limitation that once a template
1490 class is instantiated, it can not be re-instantiated and
1492 Since our usage of map<> is ubiquitous in gdcm, this "designed
1493 limitation" of VC++ is a pitfall.
1494 Hence the Python wrappers of gdcm cannot be incrementally linked
1495 against the c++ dynamic library. The dirty but only workaround is
1496 to forget about incremental link of dynamic libraries and to generate
1497 the Python wrappers library with the inclusions of the underlying C++
1499 The following modifications concern this matter on Win32/VC++:
1500 - wrapping python correct with standalone wrapped dll (don't use separate
1501 dll under windows !!!!)
1502 - python21_d debug mode enabled (ask Frog how to use it :-)
1503 - NO problem with having an STL member of class for example string in C++
1504 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1505 - Python test of dcmlib in Python is ok under windows on a large set
1507 * removed glib references
1508 * typedef's inserted in gdcm.i for correct swig type management
1510 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1511 * python/demo/*.py load.py extracted from test.py. Added explore.py
1512 that only displays required tags and testAll.py that parses all
1513 the files of the testsuite without using unittest.
1514 * python/testSuite.py other additional test on new files added.
1515 * Data/* new test files added accordingly to the testSuite.
1516 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1517 the vr in the file differs from the one of the dictionary.
1519 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1520 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1521 values, but limits itself to values which are below a user specified
1522 size (by default 1024 bytes).
1523 * python/gdcm.i : elements not loaded (because their size is above the
1524 user specified treshold) are exported with their TagKey as key of the
1525 python dictionary. This enables the testsuite to make some checks
1526 on the unloaded elements (since we have their offset and size).
1527 * python/testSuite.py
1528 - now tests for the existence and proper value of the pixel data
1529 - two new examples added.
1530 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1532 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1533 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1534 aware. See the strategy comments in gdcmHeader::FindeLength().
1535 * Test/test.cxx now accepts a filename as first argument.
1536 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1537 * python/testSuite.py changed to integrate test on above files.
1539 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1541 the vr was also RET.
1542 * python/testSuite.py more tests added.
1544 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1545 * python/testSuite.py unittest test suite added (uses Data)
1546 * Data/* dcm and acr files for the test suite.
1547 * glib dependance removed from un*x version. We now use ISO C99
1548 7.18 Integer types (see stdint.h)
1549 - python/Makefile, src/Makefile src/gdcm.h
1550 * src/ when an explicit vr (like dicom files) suddenly poped an
1551 implicit element we use to mark the underlying DictEntry of the
1552 concerned ElValue with "Implicit". This strategy was damageable
1553 too the public or provite dictionaries, since some of their vr
1554 would be changed. Since Header::FindLength heavily relies on the
1555 detection by Header::FindVR of falsely explicit elements, I
1556 added an extra ImplicitVr member to ElValue (boolean).
1557 The rest of the changes we the necessary adaptations.
1559 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1560 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1562 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1564 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1565 * Adaptation for porting to VC++:
1567 o forced to use std namespace (for string to be known)
1568 o all class use __declspec export style on WIN32
1569 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1570 (in stdlib.h on Win32 but in std:: for gcc)
1571 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1572 variable GDCM_DICT_PATH.
1573 * src/gdcmHeader.cxx verbose comments made discrete.
1575 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1576 * python/gdcm.i: added a typemap that converts a C++ hashing table
1577 to native Python dictionary.
1578 * python/demo/test.py:
1579 - now uses the native dictionary for exploration of gdcmHeader.
1580 - takes an optional filename argument (the file to parse).
1581 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1582 PubElVals hashing table.
1583 * Dicts/dicomV3.dic removed error prone trailing spaces.
1585 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1586 * Python wrapping process moved away from src/Makefile to
1587 newly created python/Makefile (as well as gdcm.i)
1588 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1589 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1590 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1591 from the environement variable GDCM_DICT_PATH (when existing).
1592 * src/gdcmDict::GetTag bug fix.
1594 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1595 * Straightforward temporary fixes for swig to build the python wrappers.
1596 src/Makefile now has a python working entry [by working we mean
1597 that we can import de shadow classes without errors].
1599 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1600 * hashtest.cxx removed (since allready in Test)
1601 * src/gdcmlib.h renamed to src/gdcm.h
1602 * src/dcm.i renamed to src/gdcm.i
1603 * src/Makefile prepared for python wrapping
1605 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1606 * src/gdcmHeader.cxx :
1607 - Parsing of header is now separated from loading of element values
1608 (see gdcmHeader::LoadElements).
1609 - general clean up of hopefully all file access (creation of
1610 ReadInt16 and ReadInt32)
1612 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1613 * src/gdcmHeader.cxx :
1614 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1616 - SetLgrElem renamed to SetLength
1617 - GetLgrElem renamed to GetLength
1618 - ~gdcmHeader() made virtual to pesky warning messages at compile.
1619 * src/gdcmElValSet.cxx fixed both GetElValue methods
1620 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
1621 due to IdoDude was cleaned out.
1623 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
1625 concentrates on finding the value representation (when it exists).
1626 RecupLgr now only finds the element value length, and it avoids
1627 returning the unecessary skL (skipped length).
1628 Also, offsetCourant was simply removed (with taille_fich) since
1629 it was redundant with the File position internals (by using
1630 ftell and fseek). This also made skL (see above in RecupLgr) usage
1632 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
1633 on the libido specificities which are handled through class
1635 * Test/implicit_vr.dcm dicom v3 in implicit value representation
1638 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1639 * Truckload of changes. Parsing of header is barely functional
1640 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
1642 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1643 * src/gdcmHeader.cxx many addons of low level methods
1645 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1646 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
1647 and _IdDcmSWAP_LONG.
1649 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * This corresponds to all the changes decided at the meeting of
1651 May 23 2002. Needless to say we are running late...