1 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Test/CMakeLists.txt: update to follow gdcmData renamings.
4 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
5 * ENH: added some utility method that builds a flat dictionnary
6 holding all the Dicom entries contained in the recursive structure
7 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
9 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
10 BuildFlatHashTable() that build a flat dictionary.
11 - src/gdcmElementSet.h: added a new private GetTag() accessor.
12 gdcmDocument is now a friend of gdcmElementSet.
13 - src/gdcmElementSet.cxx: clean up.
14 - Example/FlatHashTablePrint.cxx added.
15 - Example/CmakeLists.txt changed accordingly
17 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
18 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
19 moved away from gdcmDocEntrySet (since this class is an abstract class
20 acting like an interface). SQDepthLevel and BaseTagKey are now
22 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
23 and associated accessors. Doxygenation of the class.
24 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
26 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
27 Use SQDepthLevel accessor instead. ::Print() adapted.
28 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
29 - src/gdcmDocument.cxx changed accordingly.
31 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
32 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
33 - The following is the doxygen comment of the typedef declaration
34 of gdcmagKey in src/gdcmCommon.h:
35 gdcmTagKey is made to old an "universal" (as in URL, Universal
36 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
37 A dicom tag allways has a group and an element, but a set of tags
38 embeded in various (optionally nested) sequences and sharing
39 the same group and element all share the same (group, element)
40 "identifier". Hence the (group, element) cannot be used as an
41 identifier (in gdcm we shall refer to a "TagKey") of a tag.
42 In order to construct a proper tag identifier (i.e. a key) we
43 consider the following definition of a TagKey:
44 - let Group, Element be the string representation of the
45 group and element dicom tag members,
46 - let ItemNumber be the string representation of the integer
47 index of the considered item number of a sequence,
48 Let the key of a tag embeded in a sequence, noted SeqTag, be
50 /ItemNumber#Group|Element
51 where "/", "#" and "|" are characters acting as separators.
52 Then the general form of a gdcmTagKey is given by:
54 where <SeqTag> means NO or many instances of SeqTag.
55 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
58 but the gdcmTagKey of a tag "embeded" is the first item of
59 a sequence, itself nested in the third item of a sequence is the
61 0004|1220/2#0008|0082/0#0008|0090
62 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
63 order to hold the new sequence compatible key. Previously, the
64 GetKey() method would look in the underlying gdcmDictEntry.
65 - src/gdcmDocEntry.cxx:
66 -- constructor now copies the underlying DictEntry key, in the local
68 -- ::Print: displays the member Key, instead of the (group, element).
69 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
70 - src/gdcmDocEntrySet.h:xi
71 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
72 -- now has a new BaseTagKey member.
74 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
75 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
77 This poses the problem with the semantics of the following lines
78 LoadEntryVoidArea(0x0028,0x1201); // R LUT
79 LoadEntryVoidArea(0x0028,0x1202); // G LUT
80 LoadEntryVoidArea(0x0028,0x1203); // B LUT
81 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
82 to the long FIXME note for what the problem is. Nevertheless in
83 order to get things working the dicom dictionary was altered !
84 Please fix things urgently...
85 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
86 information), see above note on moving the member VoidArea. Nevertheless
87 the following entries previously correctly set as US are now inproperly
89 0028 1201 OW IMG Red Palette Color Lookup Table Data
90 0028 1202 OW IMG Green Palette Color Lookup Table Data
91 0028 1203 OW IMG Blue Palette Color Lookup Table Data
92 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
93 of gdcmDocEntry moved to gdcmSeqEntry.
94 * src/gdcmSeqEntry.cxx: STYLE.
96 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
97 * Test/TestAllEntryVerify.cxx minor fix and added comments.
99 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
100 * gdcmPython/testSuite.py: all the test suite in python is now moved
101 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
102 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
103 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
105 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
106 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
107 to avoid inclusion recursion until STL is reached.
108 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
109 mecanism. errno.h is not included in gdcm anymore.
110 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
111 (gdcmFormatError now inherits from gdcmFormatUnexpected).
113 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
114 gdcmData/TestAllEntryVerifyReference.txt
115 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
116 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
117 exception_on_error parameter.
118 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
119 - vtk/vtkGdcmReader.cxx changed accordingly,
120 - Example/*.cxx and Test/*.cxx changed accordingly.
122 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
123 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
124 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
125 enable_sequences removed from gdcmHeader constructor and dependencies.
126 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
127 * gdcmPython/demo/PrintHeader.py: dummy fix.
128 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
129 skip_shadow removed from gdcmHeader constructor and dependencies.
130 * Example/*.cxx and Test/*.cxx changed accordingly.
132 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
133 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
134 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
136 2004-07-21 Jean-Pierre Roux
137 * FIX Now, Parsing and Printing a DICOMDIR do work!
138 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
140 2004-07-20 Jean-Pierre Roux
141 * FIX Some brain damaged headers have Zero-Lenght fields
142 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
144 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
146 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
147 variable (instance of gdcmDebug) by a definition macro, and the instance
148 is now in static in the gdcmDebug class
149 * src/gdcmSQItem.h : (FIXME) remove an undefined method
150 * Test/PrintAllDocument.cxx : bug fix in the result of the test
152 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
153 * WARNING: ctest now depends more tightly on gdcmData. You should
154 check out gdcmData properly for things to run smoothly...
155 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
156 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
157 we need the pixels not be loaded in order to use the ValEntry
158 that displays position and size).
159 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
160 This is a C++ based equivalent of gdcmPython/testSuite.py that should
161 be deprecated. If you have any doubts about the advantages of a
162 modern scripting language (read Python) versus grass root C++ (i.e.
163 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
164 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
165 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
166 Anyhow, consider documenting the gdcmData images in
167 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
169 * Test/CMakeLists.txt:
170 - now uses TestAllEntryVerify.cxx
171 - specific comments on oldACR00001.ima (now renamed in gdcmData
172 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
173 gdcmData/TestAllEntryVerifyReference.txt
176 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
177 * src/*.[h|cxx] : typedef clean up
178 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
179 - TagKey renamed to gdcmTagKey (for external usage)
180 - VRKey renamed to gdcmVRKey (for external usage)
181 - removal of typedef duplication.
182 - Removed all unecessary inline keyword from class inline definitions.
183 - Some method|function(void) declarations replaced with method|function().
184 * src/jpeg/libijg12/jdhuff12.c:
185 - printf polluting ctest removed.
186 - TAB removal for comminting
188 - TestAllReadCompareDicom.cxx: added a test that compares all the
189 images in gdcmDataImages.h with corresponding images in
190 gdcmData/BaselineDicom/. When baseline images are not present
191 this test creates them.
192 Note: we need to validate each reference image, but before that
193 I'd like to rename them with a more explicit name...
194 - CMakeLists.txt: changed accordingly.
195 * Example/*.cxx: examples now only include gdcm.h (as opposed to
196 including each header needed).
198 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
199 * Test/*.cxx and Example/*.cxx: moved some examples away from the
200 test suite to the Example directory. Are concerned:
205 - TestWriteSimple.cxx
206 * Test/CMakeLists.txt: added some comments on reasons for black listing
207 image gdcmData/oldACR00001.ima
209 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
210 * Test/CmakeList.txt: removed the following from black list (to be coherent
211 with removal from gdcmData):
212 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
213 - gdcm-MR-PHILIPS-16.dcm
215 Added the following because after last cvs update, they cause
216 ctest -R TestReadWriteReadCompare
218 - gdcm-MR-SIEMENS-16-1.acr
220 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
221 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
222 new comments in this file) we temporarily (sigh) move to a weaker
224 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
225 we don't need to black list the following images anymore:
226 - 8BitsUncompressedColor.dcm
228 - US-PAL-8-10x-echo.dcm
229 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
230 fixes and the beautified code ;-)
231 This fixes the bug introduced in version 1.42 (when beautifying)
232 that made the parsing of 8BitsRunLengthColor.dcm unproper.
233 Note: ctest was blind to this bug (this means we need to still
234 improve the test suite). The bug could be detected by using
235 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
237 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
238 and by displaying the (garbage) produced file temp.XDCM...
240 2004-06-29 Jean-Pierre Roux
241 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
242 - replace by uggly but working old code :-(
243 A lot of things should be OK again.
244 It's really urgent to have a test suite that *tests*,
245 to prevent Frog's beautifying sessions to break all the stuff
246 (twice, withing a fortnigh ...)
248 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
249 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
250 redundancy) to added Test/TestReadWriteReadCompare.cxx
251 * Test/CmakeList.txt: because the compare test of
252 Test/TestReadWriteReadCompare.cxx fails, the following images are
253 black listed: - 8BitsUncompressedColor.dcm
255 - US-PAL-8-10x-echo.dcm
256 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
257 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
258 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
259 and ad-hoc kludge. This kludge is now removed, and on encountering
260 such an image (OB field brain damaged) we set errno. Then in
261 ::FindDocLength() we "fix" the length as being ALL what remains
262 in the file (until EOF). We then proceed, hoping for the best...
263 This fixes a SegFault in ShowDicom when trying to write such an
265 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
266 (because TestWriteRead breaks on it, after a non conformal commit?).
267 ctest now runs properly, except for MakeDicomDir (which was allways
268 broken) and the Python related stuff (still not fixed).
270 2004-06-24 Jean-Pierre Roux
271 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
272 FIX : Test/TestReadWrite now iterates on all the file names
273 (instead of infinite loop)
274 ENH : Test/TestWriteRead now iterates on all the file names
276 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
277 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
279 2004-06-24 Jean-Pierre Roux
280 FIX : - now Write drops LUT Descriptors and LUTs (if any)
281 when SamplesPerPixel =3
282 - now Write is no longer confused by
283 'BitsAllocated = 12" and 'BitsStored=12"
284 - "UN" value representation Elements are now written correctly
285 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
286 ENH : - now gdcmHeader has its own Write methods
287 (in order to split the job that has not to be done
290 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
292 loop on the same image until memory went out.
293 Note: this means we still have gobs of memory loss in PrintDocument
294 * src/gdcmDocument.cxx: fixes problem on parsing on file
295 gdcmData/16BitsJpegLosslessGrayScale.dcm.
297 2004-06-24 Jean-Pierre Roux
298 FIX : Write - All the Sequences and Sequence Item are now written
299 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
300 is added a the end, when necessary.
301 - A lot of brain-damaged images, that were read correctly are
302 now written correctly
303 - length compatible BinEntry are now loaded correctly
304 (even for odd groups)
305 Note : only Explicit Value Representation was checked.
306 (question : is implicit VR really necessary for gdcm ?)
308 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
309 * DEVELOPPER: added a proposition of coding style.
310 * src/gdcmDocEntry.h: removed every inline declaration (for test of
313 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
315 Use the gdcmDocEntry::Print() and Write() instead.
316 * src/gdcmDocument.cxx: bug fix.
318 2004-06-22 Jean-Pierre Roux
319 FIX : gdcmDocument.cxx
320 - Now we do recognize the JpegLossLess format (there was a misstyping in
321 code 'beautyfication' :-(
322 - Now we automaticaticaly load the Luts, if any
324 2004-06-22 Jean-Pierre Roux
325 In order : to write Sequences, whatever their imbrication level,
326 : to allow user to create his own Sequences
327 a lot of modif where necessary (adding, moving, or virtualising methods)
329 WARNING : save your own sources *before* cvs up !
332 ADD virtual void Write(FILE *fp, FileType filetype);
335 ADD virtual void Write(FILE *fp, FileType filetype);
336 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
339 ADD virtual void Write (FILE *fp, FileType filetype)=0;
340 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
341 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
342 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
343 ADD std::string GetEntryByName(TagName name);
344 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
346 std::string vr = "unkn",
347 std::string fourth = "unkn",
348 std::string name = "unkn");
349 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
350 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
351 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
352 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
353 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
354 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
355 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
356 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
359 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
360 ADD virtual std::string GetEntryByName (TagName tagName);
361 ADD virtual std::string GetEntryVRByName (TagName tagName);
362 REM virtual bool Write(FILE *, FileType);
363 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
364 FILE *_fp, FileType type);
365 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
366 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
367 REM virtual bool WriteEntries(FILE *_fp,FileType type);
368 REM virtual std::string GetEntryByName (std::string tagName);
369 REM virtual std::string GetEntryVRByName (std::string tagName);
370 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
371 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
372 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
374 std::string vr = "unkn",
375 std::string fourth = "unkn",
376 std::string name = "unkn");
377 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
378 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
379 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
380 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
383 ADD virtual void Write(FILE *fp, FileType filetype);
386 ADD virtual void Write(FILE *fp,FileType filetype);
389 ADD virtual void Write(FILE *fp, FileType filetype);
390 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
391 REM std::string GetEntryByNumber(guint16 group, guint16 element);
392 REM std::string GetEntryByName(TagName name);
395 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
397 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
398 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
399 The default constructor invoked by the line
400 gdcmHeader *f1 = new gdcmHeader( header );
401 was gdcmHeader::gdcmHeader(bool) instead of the expected
402 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
403 Hence the parsing wasn't executed... See also below.
404 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
405 as explicit constructor didn't do the trick to fix the above problem.
406 Could anyone explain why ?
407 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
408 properly calls gdcmValEntry::Print() (that was weed out from
409 code related to gdcmBinEntry).
411 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * In order to fix memory leaks:
413 - Test/TestWriteSimple.cxx: added cleaning of free store through
415 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
416 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
417 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
418 (through the call to ::AddDicomDirMeta()) or the destructor
419 would crash when deleting uninitialized ::metaElems].
420 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
421 - src/gdcmDocument.cxx:
422 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
424 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
425 was causing memory leaks.
426 - src/gdcmSQItem.cxx:
427 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
428 cleanly handled with polymophism: sorry but my milage is low).
429 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
430 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
431 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
432 This avoids SegFaulting.
433 - src/gdcmSQItem.h: coding style.
435 - Test/TestWriteSimple still severely sucks. The output image content
436 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
437 damaged when displayed with vtkgdcmViewer.
438 - on memory leaks: TestWriteSimple leaks really less (see entry
439 of 2004-06-18 in Changelog file for the call to valgrind).
440 - on segfaults: ctest now passes all the tests but one (no more
442 * Erroneous leading white fix:
443 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
444 white[s] (as opposed to from >> xxx, that removes it [them].
445 - src/gdcmTS.cxx: ditto.
446 - gdcmPython/testSuite.py: dirty related kludge removed.
447 * src/*: remaining references to gdcmParser removed.
448 * src/*[cxx|h]: added copy[way]left header.
451 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
452 * In order to fix writing of dicom files:
453 - Test/TestWriteSimple.cxx: a simpler example of writing.
454 - Test/CMakeLists.txt changed accordingly.
455 - src/gdcmDocument.cxx:
456 -- The destructor now recursilvely removes potential sequences.
457 -- Bug fix in ::IsJPEG2000()
458 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
459 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
461 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
462 to only declared) and build on top of
463 ::GetDocEntryByNumber(guint16, guint16).
464 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
465 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
466 for usage in destructor and treatement of promotion in
467 ::ReplaceOrCreateByNumber().
468 - src/gdcmSQItem.cxx: destructor should better handle his job.
469 Test/TestWriteSimple now runs (or at least it DOES something).
470 * We can now start hutting memory links. A good starting point is:
471 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
472 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
473 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
475 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
476 * Valgrind note: after Mathieu Malaterre teached me how to read
477 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
479 Using gcc, you can force the STL to use malloc and to free memory as
480 soon as possible by globally disabling memory caching.
481 With 3.2.2 and later, you should export the environment variable
482 GLIBCPP_FORCE_NEW before running your program.
483 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
484 simply vanish (it is still not clear to me, whether this means that
485 STL std::string leaks or if valgrind believes it leaks...).
486 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
487 running bin/gdcmTests makeDicomDir):
488 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
489 - Test/makeDicomDir.cxx now properly traps empty lists and returns
491 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
492 SegFaulting (I drowned in DicomDir related code when trying to
493 understand why the list is empty...).
494 * src/gdcmDocument.h: first BSD license header try.
495 * Doc/License.txt added.
497 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
498 * src/gdcmDocument.[h|cxx]:
499 - Clean up of the Transfer related predicates. They are now all based
500 on new method isGivenTransferSyntax, that (should) handle properly
502 - general clean up, simplification, and coding style.
503 - Specific clean up of Parse7FE0() (umproperly named actually).
504 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
506 2004-06-14 Jean-Pierre Roux
508 - fix the display of Sequence Delimitor (SQDepthLevel pb)
509 - fix the display of SQItem ordinal number
510 - add the GetSQItemByOrdinalNumber method
511 - remove some useless never written private methods
513 2004-06-14 Jean-Pierre Roux
515 - adding a constructor taking a gdcmDocEntry as an input param
516 - ReplaceOrCreateByNumber now returns :
517 a gdcmBinEntry * if a Binary (void *) value is passed as a param
518 a gdcmValEntry * if a string value is passed as a param
520 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
521 according to the param type (no longer sets a gdcmDocEntry)
522 - GetValEntryByNumber, GetBinEntryByNumber added
523 - NewValEntryByNumber and NewBinEntryByNumber added
525 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
527 - GetSQItemNumber and SetSQItemNumber added, to provide
528 a (relative) Item identier inside a given Sequence
529 \warning : some pb remaining around this number
531 - AddEntry now takes the Item Number as a param
533 - adding a constructor taking a gdcmDocEntry as an input param
535 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * Memory leak hunt with the following command:
537 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
538 --show-reachable=yes gdcmTests PrintDocument
539 It looks like many (all?) leaks are due to the STL (or a bad usage
540 of the STL. The lines producing the leaks now have a comment with
541 a "MEMORY LEAK" tag: you can retrieve them with
542 grep "MEMORY LEAK" src/*
543 Here are two typical examples which I can't help fixing:
548 char * test = "babo";
549 name = test; //// <--- valgrind detects 960 bytes lost in
550 //// call to std::string::operator=(char const*)
551 name.clear(); //// Doesn't help !
559 std::cout << "Type a bunch of characters followed by RETURN: ";
560 getline(std::cin, line); //// <--- valgrind dectects a loss
561 //// of 1320 bytes in call to
562 /// std::basic_istream<>& std::getline<>
568 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
569 * src/gdcmHeader.[cxx|h]:
570 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
571 and related, moved away to gdcmDocument.
572 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
573 the corresponding protected accessors of inherited class
574 gdcmDocument, removed ! As a consequence gdcmFile had to be
575 declared friend of class gdcmDocument (see below).
576 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
577 - Clean up of undefined or unused methods.
578 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
579 account the changes to gdcmHeader.h).
580 * src/gdcmDocument.h:
581 - gdcmFile is now a friend class (in order to take into account the
582 changes to gdcmHeader.h).
583 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
584 (see changes to gdcmHeader.h).
585 - Accessors (reading on the form GetEntry*) are now public.
586 - Clean up of undefined or unused methods.
587 * src/gdcmDocument.cxx:
588 - adaptation to changes to gdcmDocument.h
589 - ::OpenFile now writes a verbose message when file cannot be opened.
590 - some std::string properly set to VRKey
591 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
592 references to gdcmDocument.
593 * Test/TestFindTags.cxx: changed accordingly to above changes.
594 * gdcmPython/testSuite.py: adapted to renaming of acr files in
595 cvs repository gdcmData.
597 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
599 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
600 conflicts with gdcmValEntry::voidArea.
601 * src/gdcmValEntry.cxx: unmatching comment wiped out.
602 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
603 Value representation between StringRepresentable and BinaryRepresentable.
604 * src/gdcmDocument.cxx:
605 - method ParseDES: proper indentation restored and usage of
606 gdcmVR::IsVROfGdcmStringRepresentable wired in.
607 - method LoadDocEntry: the fingerprint left in the SetValue() of
608 unloaded entries (length > MaxSizeLoadEntry) had curiously been
609 removed. Reverting to previous code segment with the proper
610 dynamic_cast< gdcmValEntry* >.
611 Note: this was (partially) breaking the python test suite
612 (gdcmPython/testSuite.py) that made usage of the above
613 fingerprint to check presence of "Pixel Data".
614 * src/gdcmDocEntry.h: coding style.
615 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
616 now taken into account.
617 * gdcmPython/gdcm.i: adaptation to the new internal representation
618 of gdcm (exit gdcmParser, hello gdcmDocument).
619 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
621 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
622 anymore, but instead prints the loaded Python dictionary.
623 * .... alas, the python testSuite is still broken.
625 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
628 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
629 * src/gdcmUtil.h : export methods
631 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
632 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
634 * Initial addition of automatic python testing
635 * Initial addition of automatic image comparison
637 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
639 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
641 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
642 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
643 * Test/ShowDicom.cxx : bug fix for msvc compilation
644 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
646 2004-05-04 Jean-Pierre Roux
647 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
648 new concepts (and new classes) :
649 a 'gdcmDocument' is composed of a set of Doc Entries, that are
650 - elementary gdcmDocEntries (former gdcmHeaderEntries)
651 - Sequence Doc Entries (gdcmSeqEntries)
652 a Sequence is composed of Items.
653 Each item is a set of Doc Entries (this is recursive)
654 The non uniqueness of the 'Dicom tag' is due to this recursivity
655 (never taken into account)
656 Our unability to add a new 'entry' in the header
657 at the proper location (neither in the H-Table (map or multimap),
658 nor in the Chained List is also due to this recursivity.
659 Don't try, right now, to use/modify/compile these new sources :
661 We just commit all the stuff, 'as is', in order not to loose it.
663 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
666 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
667 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
668 file prefix (SetFilePrefix)
670 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
671 * Add a new test: ShowDicom, for now this is just the c++ version of
672 checkRead.sh, later it will be able to compare the image read against a
674 * Replace the DEBUG on the stack with a global entry in cmake interface:
675 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
677 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
678 * Add an example subdir, with a real example on how to read + write a
681 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
682 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
683 * Doc/CMakeLists.txt: the main page is now properly differentiated
684 between the developper and user version.
685 * Doc/doxygen.config.in: dropped search related obsolete flags
686 * src/gdcmParser.h, gdcmHeader.h: doxygenation
688 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * DEVELOPPER: added some helpfull comments for compile/test/install
692 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
693 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
694 src directory, now generated in the build dir.
695 2. Tests as mentionned smarter
697 4. Add a new method in gdcmDict that return the PubDict by name
698 this is interesting for 3rd party lib like ITK,
699 where we could set the institution name / patient name...
701 * ENH: 1. Now the test suite is working for real
702 2. All binaries are now output in the gdcm-bin directory
703 (this was not true before)
705 2004-04-28 Jean-Pierre Roux
706 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
707 SeQuence indented printing of Dicom Header.
708 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
709 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
710 Computation of SQDepthLevel is now part of gdcmHeader constructor
711 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
712 tree-like structure of a Dicom Header.
713 * FIX Test code cleaning
715 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
716 * ENH: Adding automatic testing
717 1. Need a DartConfig.cmake to submit to public
718 2. Add a test driver gdcmTest.cxx
719 3. gdcmTestMain, an helper for the main test driver gdcmTest
720 4. Files in Test don't have a main anymore, this becomes interesting
721 when we add more and more tests, thus dsw don't have to load
723 * ENH: Adding a GDCM_DATA_ROOT for testing
724 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
725 one file instead of seven + some small cleanup
727 2004-04-22 Jean-Pierre Roux
728 * ENH Minor changes to the Print() methods.
729 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
730 Header printing. Example given with :
731 > PrintHeader fileName 2 new
732 (SQ based tree-like structure still to be done for the Header ...)
734 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
735 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
736 1. I have added some unsigned where needed
737 2. Some function parameter not used -> (void)
738 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
739 4. g++ don't like character '\' in comment
740 5. #define jpeg_create_decompress jCreaDecompress
741 this really need to be fixed
742 6. virtualize destructor of gdcmObject ... leakage
743 7. sscanf(g->first.c_str(),"%x",&gr_bid);
744 this also really need to be fixed
745 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
746 remove compression file
747 (as we only do decompression, right ?)
748 * ENH: Change malloc/calloc/free with c++ equivalent
750 2004-04-21 Jean-Pierre Roux
751 * FIX gdcmHeaderHelper::GetXSpacing
752 when a single value is found (bug ?), xpacing is now
753 defaulted to yspacing
755 2004-04-19 Jean-Pierre Roux
756 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
757 * ENH add parameters :
758 bool exception_on_error = false,
759 bool enable_sequences = false,
760 bool ignore_shadow = false
761 to the gdcmFile constructors to be full gdcmParser compliant
762 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
763 to allow reading of PAPYRUS 3.0 files
765 2004-04-06 Jean-Pierre Roux
766 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
768 2004-04-02 Jean-Pierre Roux
769 * ADD : Test/checksequence.sh, for a general recap on SQ pb
770 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
771 for Philips spurious Tag fffe|0000 while rewritting Dicom files
773 2004-03-30 Jean-Pierre Roux
774 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
775 for ACR file, written out as DICOM files (hope so...)
777 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
779 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
780 moved to base class gdcmParser and only the specialisation is kept
782 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
783 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
784 already does the job.
785 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
786 (to be consistent with gdcmParser::WriteEntries).
788 2004-03-30 Benoit Regrain
789 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
790 upate of the object's instance. It's passed to 2 in the unfavorable
791 case : one in the ExecuteInformation, one in the ExecuteData
793 2004-03-29 Jean-Pierre Roux
794 * ENH : Check on file type to be written moved
795 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
796 * FIX : gdcmObject::ResetBoundaries now stops properly
797 when end-of-list is reached
798 : gdcmVersion modified (as Benoit Regrain asked)
800 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
801 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
802 * src/gdcmUtil.cxx: added forgotten iostream include.
803 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
804 equivalent to ExplicitVR in existing code).
806 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
807 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
808 now contains all the gdcmGlobal related code.
809 * minor coding style and doxygenation changes.
811 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
812 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
813 now contains all the Debug related code.
814 * minor clean-up of includes in src/*.cxx
815 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
816 CreateCleanString) removed.
817 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
818 * Doc/DoxyMainPageUser.txt added.
819 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
820 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
823 2004-03-24 Jean-Pierre Roux
824 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
826 2004-03-23 Jean-Pierre Roux
827 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
828 big endian made volumes
829 * ENH Now gdcmParser constructor and destructor are protected to forbid
830 end user to instanciate class gdcmParser
831 (only gdcmHeader and gdcmDicomDir are meaningfull)
833 2004-03-22 Benoit Regrain
834 * FIX : src/gdcmDicomDir.cxx : make windows compilable
835 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
836 gdcmSerie to gdcmDicomDirSerie
838 2004-03-19 Jean-Pierre Roux
839 * ENH Now the tree-like structure describing a DICOMDIR comming from
840 an already existing DICOMDIR file is consistent with
841 the home-made tree-like structure build ex-nihilo
842 or build from the files held (recursively) in a Directory
843 functions gdcmDicomDir::CheckBoundaries()
844 gdcmObject::SetBoundaries() added
846 2004-03-17 Jean-Pierre Roux
847 * REM (Eric Boix bug) : removal of meaningless
848 gdcmDicomDirImage::NewImage function.
849 * FIX now file names and directory name are written properly in the
851 * FIX now gdcmDicomDir constructor may be call without any trick
854 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
855 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
856 of gdcmDicomDirImage::NewImage as empty function.
858 2004-02-28 Jean-Pierre Roux
859 * ENH add gdcmDicomDir:NewPatient
860 add gdcmDicomDirPatient:NewStudy
861 add gdcmDicomDirStudy:NewSerie
862 add gdcmDicomDirSerie:NewImage
863 to allow making gdcDicomDir object.
864 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
865 (as opposite to the gdcmHeader chained list)
867 2004-02-11 Benoit Regrain
868 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
869 when using from python
871 2004-02-10 Benoit Regrain
872 * FIX : bug fix in the gdcmDirList for the recursivity in directories
873 * FIX : in gdcmDicomDir when the directory is empty
874 * ENH : add callback and methods to get the progression of dicomDir
877 2004-02-06 Jean-Pierre Roux
878 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
879 - GDCM_META added to gdcmDicomDirType
880 - class gdcmMeta created
881 * ENH : - A brief summary is now displayed at the beginning of
882 'testDicomDir' to help disaster magnitude estimation
883 * REM : Now useless Test/explDICOMDIR.cxx
885 2004-02-05 Benoit Regrain
886 * ENH : add methods in gdcmObject to get the hash table or the list of
888 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
889 * FIX : wrapping python for TagHeaderEntryHT
891 2004-02-04 Benoit Regrain
892 * FIX : even length for some strings when writting the dicom dir
893 * FIX : sort the images in the dicom dir
894 * FIX : Bug fix for python use of dicom dir
895 * ADD : a python demo
897 2004-02-04 Jean-Pierre Roux
898 * FIX : Final solution (?) for icone embedded images
899 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
900 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
901 add groups 6002, 6004, 6006, to allow 'clean' parsing of
902 gdcmData/gdcm-MR-SIEMENS-16.acr1
903 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
904 to make full checking easier
906 2004-02-04 Benoit Regrain
907 * FIX : WriteEntries : coding style & logic in parameters
908 * FIX : Set the elements to create the DicomDir in a dictionary file
910 2004-02-03 Benoit Regrain
911 * gdcmDirList : to parse a hard drive directory in recursive (or not)
912 * gdcmDicomDir : add the load of directory
913 * Bug fix and print add-on
915 2004-02-03 Jean-Pierre Roux
916 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
917 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
918 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
919 * FIX gdcmParser.cxx : 'group length' elements are now considered
920 as integers, even for shadow groups, when file is Implicit VR
922 2004-02-02 Jean-Pierre Roux
923 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
925 of the last synonym :-(
926 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
928 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
929 * FIX taking into account the possible 7fe0,0010 multiplicity
930 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
931 to allow removal of references to 7fe0,0010, to deal with
932 ACR-NEMA images, when 0028,0200 is meaningfull
934 2004-01-31 Jean-Pierre Roux
935 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
936 no longer writes 'Un' on disk
937 * FIX SQ elements with actual length are now dealt with corectly
938 * FIX gdcmFile::WriteBase make the difference, for color images, between
939 the length (for Palette expanded images)
940 and Raw Length (non expanded image + Palette)
941 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
942 (that broke Write). Replaced by UL.
943 Aware user will reload the field if he
944 thinks it's necesssary
946 2004-01-30 Jean-Pierre Roux
947 * gdcmParser::CheckSwap() now defaults the filetype to ACR
948 when 'dirty Acr' is found, to be compliant with the new
949 IsReadable() methods.
951 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
952 (no DOUBLE images in kosher DICOM,
953 but so usefull for people that miss them ;-)
955 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
956 DICOMDIR related utilities (not checked as Windoze compliant)
958 2004-01-28 Jean-Pierre Roux
959 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
961 2004-01-27 Jean-Pierre Roux
962 * gdcmParser constructor has a new boolean param,'ignore_shadow',
963 to allow skipping the shadow elements, to save memory space.
964 The TRUE value for this param has to be used
965 with a FALSE value for the 'enable_sequence' param.
966 ('public elements' may be embedded in 'shadow Sequences')
967 * gdcmHeader methods now deal with 'embedded icones images' in the header
968 (even when an 'icone image sequence' is announced by the
969 element (0x0088,0x0200), but there is NO icone at all ...
971 * gdcmHeader sometimes Image Location value doesn't follow
972 the supposed processor endianity (see gdcmData/cr172241.dcm).
975 * gdcmHeader add the method
976 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
977 to get *all* the Header Entries with the same tag.
978 GetHeaderEntrySameName is probabely *useless*
979 (no meaning : Name is *not* an identifier within the Dictionnary)
981 2004-01-26 Benoit Regrain
982 * Bug fix in the print of hexadecimal representations. Remove long fields
983 in the print and add a third level of print to print them
985 2004-01-23 Benoit Regrain
986 * Bug fix on field having a VR = 'UI'. Assume that is a string field
987 * Bug fix on test suite after remove the strip made on not string fields
988 * Split the IsReadable method between gdcmParser which test that the file
989 is dicom and gdcmHeader which test that it's an image file
991 2004-01-22 Benoit Regrain
992 * DicomDir : clean code, add methods, set variables in protected or private
993 * gdcmUtil : bug fix for the clean string method
995 2004-01-19 Benoit Regrain
996 * Add the use of shadow dictionaries
997 * bug fix and coding style
999 2004-01-19 Benoit Regrain
1000 * src/gdcmFile.cxx : bug fix concerning the close of file
1001 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1002 * Add the update of header entries using the shadow library
1004 2004-01-19 Benoit Regrain
1005 * removal of file gdcmHeader2.cxx
1006 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1007 inheriting from gdcmParser. This split is to prepare the integration
1008 of dicom dir parsing
1009 * bug fix under python
1011 2004-01-16 Jean-Pierre Roux
1012 * REM removal of class gdcmHeaderEntrySet
1013 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1014 * ADD add file gdcmHeader2.cxx
1015 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1017 2004-01-15 Benoit Regrain
1018 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1019 entries created while parsing the header. Thus, they will be destroyed
1020 when the gdcmDictSet will be destroyed
1021 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1024 2004-01-15 Benoit Regrain
1025 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1026 made a fatal error because of the memory release at the end of program.
1027 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1028 some memory and vtk seems to have some problems with that.
1029 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1031 2004-01-14 Benoit Regrain
1032 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1033 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1034 * src/*.[h|cxx] : make changes due to class name changes
1035 * gdcmPython/demo/*.py : bug fix due to method names
1037 2004-01-13 Benoit Regrain
1038 * src/*.[h|cxx] : coding style
1039 * vtk/*.[h|cxx] : coding style
1041 2004-01-13 Benoit Regrain
1042 * gdcmPython/testSuite.py : test the readable flag of file for tests
1043 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1044 It's lied to the stl compilation by MSVC (windows, always windows...)
1045 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1047 2004-01-12 Benoit Regrain
1048 * src/*.h : add comments
1049 * src/gdcmDictSet.h : set the method BuildDictPath in public
1050 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1051 directly setted in the source code
1052 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1055 2004-01-09 Benoit Regrain
1056 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1057 * setup.py : use a reference to gdcmVERSION
1059 2004-01-07 Benoit Regrain
1060 * Modification to compile with the distutils.
1063 2003-12-10 Benoit Regrain
1064 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1065 can use a gdcmHeaderHelper to load datas
1066 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1067 made in the source code
1069 2003-12-10 Benoit Regrain
1070 * Update Windows projects and .cvsignore files
1072 2003-11-12 Jean-Pierre Roux
1073 * ENH gdcmHeader constructor has one more parameter (default value : false)
1074 that allows the user to 'go inside' the SeQuences only
1076 gdcmElValSet:Print takes it into account
1078 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1079 * ENH: Update gdcmPython/CMakeLists
1080 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1081 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1083 2003-11-10 Jean-Pierre Roux
1084 * FIX : gdcmHeader::LoadElements is now based
1085 on the ListTag listElem member,
1086 not longer on the TagElValueHT tagHt member
1087 * ENH : PrintPubElVal shows (temporarily) both results,
1088 with the tagHt member and the listElem member.
1089 (it's easier to 'see' the problems when using Printheader)
1091 * FIX : old private member LgrElem is now splitted into
1092 ReadLength : Length actually found on disk (updated only
1093 if bug fixing is necessary), for internal
1095 UsableLength : Updated by FixFoundLength, to fix a bug
1096 or to allow Parser going on.
1097 Will allow to re-write a kosher header when a SeQuence
1098 with a length (not 0000) is found
1099 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1100 because gdcmElValSet::Add does not update ListElem
1103 2003-11-07 Jean-Pierre Roux
1104 * FIX misstyping in Transfert Syntax name table
1105 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1106 when they have an actual length (not 0000 nor FFFFF)
1107 (Nobody should care of it, but DICOMDIR explorers)
1109 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1110 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1112 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1113 * ENH: vtkGdcmReader now supports LUT !
1114 (vtkgdcmViewer for now is not able to use them though)
1116 2003-11-05 Jean-Pierre Roux
1117 * in testSuite.py : new files names for checking the package
1118 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1119 that returns the pixel area size to the *aware* (vtk) user
1120 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1122 2003-11-05 Benoit Regrain
1123 * in testSuite.py : Modify the rules for checking the paths
1124 : Explicit error messages
1125 * in __init__.py : Related modif
1127 2003-11-03 Jean-Pierre Roux
1128 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1129 to be used by aware (vtk) users that want to manage
1130 LUT (and no to turn the PALETTE image into an RGB pixels one)
1131 * GetPixelType now returns 8U for 24 Bits images
1132 (vtkGdcmReader compliant)
1134 2003-10-31 Jean-Pierre Roux
1135 * Removal of *all* gdcmData images and add them again
1136 in order to loose the 'history' of un-anonymised images
1138 2003-10-31 Jean-Pierre Roux
1139 * RMV : removal of useless jBitsInJsample.h
1140 for both 8 and 12 Bits JPEG Lossy Libraries
1142 2003-10-31 Jean-Pierre Roux
1143 * ENH : Add the functions gdcmFile::GetImageDataRaw
1144 gdcmFile::GetImageDataIntoVectorRaw
1145 that act as GetImageData and GetImageDataIntoVector
1146 except the making of an RGB Plane from Gray Plane + LUT
1147 Intended to aware (vtk) users who know how to manage
1150 GetLUTRGBA return a R,G,B,A LUT if any
1151 lgrTotaleRaw gives the 'Raw' length
1152 GetImageDataRaw returns the gray Plane
1153 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1154 (They stay Grey, just like with other Dicom viewers :-(
1156 2003-10-30 Jean-Pierre Roux
1157 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1159 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1160 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1161 being coherents dicom files.
1163 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1164 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1166 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1167 * ENH: Two steps is necessary to please VC++ compiler...
1168 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1169 * ENH: Add include dir to medcon lib
1170 * FIX: only one function is being exported for now !
1171 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1173 2003-10-29 Jean-Pierre Roux
1174 * adding gdcmHeader::GetLUTRGBA
1175 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1176 --> Mathieu, the modif u're waiting for is not yet committed
1177 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1179 2003-10-27 Jean-Pierre Roux
1180 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1181 00191113.dcm DermaColorLossLess.dcm
1182 MxTwinLossLess.dcm RadBWLossLess.dcm
1183 * ENH: For version prior to vtkImageViewer2 -r 1.19
1184 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1186 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1187 * Removal of ido stuff in CMakeLists.txt
1189 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1190 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1191 * FIX: remove a call to ->Modified ... see comments
1192 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1194 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1195 * FIX: Problem with path for libvtkgdcmPython
1196 * ENH: Try adding a search script for python site-package
1197 * RMV: Remove some file from medcon lib that are not necessary
1198 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1199 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1200 * FIX: More pragma disable fro VC++,
1201 I don't think I break something as it is also disable in VTK/ITK.
1202 But it fasten debug compilation time.
1204 2003-10-23 Jean-Pierre Roux
1205 * gdcm now deals with 16 Bits Run Length Encoded images
1206 (they are compressed as 2 planes images,
1207 one for the high Bytes, the other for low Bytes)
1209 2003-10-22 Jean-Pierre Roux
1210 * Now CheckRead takes into account :
1211 - the bugged 'Leonardo' Siemens images
1212 - the XA images, sent thru the burning VPRO station
1213 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1216 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1217 * FIX: When copying a Makefile.am to CMakeLists.txt
1218 one should remove the '\'
1220 2003-10-22 Jean-Pierre Roux
1221 * in gdcmData adding a bugged 'Leonardo' Siemens image
1222 (wrong lengths in header)
1223 OK with gdcm, KO with the other viewers :-)
1224 * add a GE dlx XA image, thru the VEPRO burning station
1227 2003-10-21 Jean-Pierre Roux
1228 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1229 for a brutal checking of vtkgdcmViewer compliance
1231 2003-10-21 Jean-Pierre Roux
1232 * add the files for 'xmedcon' Jpeg Lossless library
1233 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1235 2003-10-21 Jean-Pierre Roux
1236 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1238 2003-10-21 Jean-Pierre Roux
1239 * garbage Siemens 'Leonardo' images dealt with
1240 (the patch is easy to remove)
1241 * cosmetic changes to avoid warnings
1243 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1244 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1245 no need to press 'r' now.
1247 2003-10-20 Jean-Pierre Roux
1248 * upgrade of checkRead.sh checkWrite.sh according
1249 to new Jpeg Lossless decompressor
1250 * add US.3405.1.dcm, a genuine RGB medical file ...
1251 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1252 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1254 2003-10-15 Jean-Pierre Roux
1255 * general anonymisation in gdcmData
1256 * adding the 'color files' from
1257 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1258 * adding some well knowed bugged-header images
1259 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1260 waiting for their inclusion in Python testsuite
1262 2003-10-15 Jean-Pierre Roux
1263 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1264 no longer seg faults when file is not found
1266 2003-10-14 Jean-Pierre Roux
1267 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1270 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1271 * TODO: *.in file to genereate a UseGDCM later
1273 2003-10-14 Jean-Pierre Roux
1274 * Some supposed-to-be Dicom Images have no preamble.
1275 OpenFile takes it into account
1276 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1277 * Missing elements added in dicomV3.dic
1278 (just to be affraid : have a look at
1279 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1280 and do it again next year ;->
1282 2003-10-13 Jean-Pierre Roux
1283 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1284 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1285 But there are NOT. It's fixed !
1287 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1288 * FIX: "jpeglib.h" was not found on VC++
1289 * FIX: vtkgdcm was not being installed
1291 2003-10-10 Jean-Pierre Roux
1292 * ENH : OpenFile closes the file if it *really* doesn't look like
1293 an ACR-NEMA / DICOM one.
1294 * FIX : testWrite no longer writes an empty file if the source file
1295 is not gdcm Readable
1296 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1299 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1300 * FIX: CMake generate now documentation
1301 * ENH: out of source doc build !
1302 * ENH: Generate both user and dev documentation
1303 * ENH: Should work on windows too
1304 * ENH: Only one doxygen config.in file is needed
1305 * FIX: make install should be ok now on ùnix plateform
1306 * FIX: PATH to dictionary was wrong (missing /)
1307 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1309 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1310 * vtkGdcmReader is now able to read rgb dicom file.
1311 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1312 * added a gdcmViewer to vtk test, use mouse to control
1313 window level & window width
1315 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1316 * CMake-ification of gdcm, we have now two build system
1317 * FIX: on cygwin Wsock32 doesn't exist
1318 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1320 2003-10-06 Emanuel Ollart
1321 * FIX : compilation process wad broken.
1322 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1324 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1325 * change gdcmViewer -> vtkgdcmViewer
1326 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1328 2003-10-06 Jean-Pierre Roux
1329 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1330 ( e.g : well known GE images with a wrong elem length,
1331 : Philips MRI Images with a wrong Huffman table)
1332 * still to be done : allow the reading of bugged LEONARDO Siemens images
1334 2003-10-03 Jean-Pierre Roux
1335 * Odd length strings are padded with '\0' (not with spaces,
1336 to remain compliant with already defined strings,
1337 like Transfert Syntax UID and others)
1339 2003-10-03 Jean-Pierre Roux
1340 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1341 to allow displaying RGB images (not only by affim ;-)
1343 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1344 * vtkGdcmReader is now able to read rgb dicom file.
1345 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1347 2003-10-03 Jean-Pierre Roux
1348 * A few nasty patches to allow the reading of a lot of nasty images
1349 ( e.g : well known GE images with a wrong elem length,
1350 : Philips MRI Images with a wrong Huffman table)
1351 * still to be done : allow the reading of bugged LEONARDO Siemens images
1353 2003-10-03 Jean-Pierre Roux
1354 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1356 2003-10-03 Jean-Pierre Roux
1357 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1358 to allow displaying RGB images (not only by affim ;-)
1360 2003-10-03 Jean-Pierre Roux
1361 * gdcmFile::GetImageDataIntoVector now
1362 - deals with MultiFrames MultiFragments Run Length Encoded files
1363 - deals with YcBcR (YBR_FULL) files
1364 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1365 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1367 (no sample found :-(
1369 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1370 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1371 Two reasons: - clear things
1372 - third parties acces gdcm through header files, so won't
1373 suffer anymore VC++ complains
1375 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1376 * add argv[1] in testvtkGdcmReader.cxx
1379 2003-09-24 Jean-Pierre Roux
1380 * The lines are now eigthy characters long.for
1381 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1383 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1384 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1385 char* to std::string. Thus, the use of strdup becomes useless. (see
1386 previous commis of Malaterre)
1387 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1388 before the last Malaterre's commit.
1390 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1391 * This commit should fix the Debug building under VC++, the problem
1392 was mainly a mixture of debug and release lib being loaded at startup.
1393 * I also remove a depency to a specific C function: strdup. Because I had
1394 to force the link to msvcrtd (whereas strdup is in libc).
1396 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1397 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1398 located in the gdcmCommon.h file. All use of reference of tha has been
1399 changed to now use the variable GDCM_UNFOUND.
1401 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1403 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1404 Dicom dictionary. The test suite can now be run again. Note:
1405 I'm note very happy with the " (RET)" changes. I believe this
1406 RETAINED comment should be dropped when parsing the dictionary.
1407 - PACKAGER corrected
1409 - AUTHORS updated and now in alphabetical order
1410 * Makefile.am now exports gdcm.dsw for Windoze users.
1412 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1413 * cygwin complains about missing std:: in subdir Test/
1415 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1416 * remove some methods that are now in gdcmHeaderHelper
1418 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1419 * vtkGdcmReader set spacing and origin correctly
1421 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1422 * Fix a few delete/delete[] mismatch
1424 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1425 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1426 interpretation to data given by gdcmHeader. For instance there are
1427 heuristics to get informations (look at different places).
1428 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1429 sorting DICOM images based on different strategies.
1430 * modified Makefiles accordingly.
1432 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1433 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1434 when building in debug mode
1435 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1436 src/win32/gdcmdll.dsp
1437 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1439 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1440 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1443 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1444 * src/win32/libgdcmjpeg12.dsp was not dos format
1445 * src/win32/libgdcmjpeg12.dsp :
1446 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1447 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1449 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1450 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1452 * src/gdcmFile.cxx : bug fix in affectation type
1453 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1454 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1455 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1456 symbols... future problem ?
1458 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1459 * src/win32/libgdcmijpeg12.dsp was missing
1460 * modified gdcm.dsw accordingly
1462 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1463 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1465 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1466 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1467 commit of JPR (before his hollidays to facilitate our work).
1468 * setup.py : bug fix in code. Modifications made while the last commit
1469 of JPR. The code hasn't been tested before the commit... it's so
1470 useless to make that (for best programmer that is JPR) !!!
1472 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1473 * tagged the current version as Version0_3 (i.e. version 0.3)
1475 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1476 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1477 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1478 * *.dsp : modifications to use new libgdcmijpeg8 library
1479 * setup.py : bug fix on VTKPATH variable
1480 * PACKAGER : adding all concerning windows
1482 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1483 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1485 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1486 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1487 test suite reported error.
1488 * PACKAGER file added (describes what a packager must do when
1489 packaging a new release).
1490 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1491 * configure.in: upgraded version number to 0.3.0
1492 * fixing build of rpm (through rpm -ta):
1493 - Doc/Makefile.am exports proper doxygen files
1494 - src/jpeg/libijg8/Makefile.am exports the include files.
1496 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1497 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1498 * src/gdcmHeader.h : formatting code
1500 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1501 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1502 We were obtaining error message from vtk. Now, creation of file list
1503 is made in an internal list to prevent this problem.
1504 Bug fix when output is empty.
1505 Bug fix in update of progress value. Previous commit for this was a bad
1507 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1509 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1510 * src/gdcmHeader.h : added method to get the file name
1511 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1512 files. Added method to remove all files on the input
1513 Added FIXME comment concerning the bad parsing of header made by
1514 ExecuteInformation method (in ExecuteData method)
1516 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1517 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1518 when using make instal.
1519 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1520 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1522 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1523 * setup.py : adding include dir of jpeg lib to compile all sources
1524 * */Win32/*.dsp : JPR fix for windows compilation
1526 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1527 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1529 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1530 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1532 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1533 * setup.py is again effective on un*x (takes into account the
1534 addon of the jpeg library)
1535 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1536 * Doc/Doxy* updated (includes above enhancements)
1537 * INSTALL now points to web documentation
1539 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * src/gdcmHeader.h doesn't make unnecessary reference to
1542 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1544 * src/gdcm*.[cxx|h] :
1545 - to allow compilation with gcc 3.x
1546 -- clean up of STL usage (added explicit usage of std::)
1547 -- small fixes on exceptions.
1548 Note: linking not tested !
1549 - clean of doxygen comments to avoid warnings at documentation
1551 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1552 dependent convertion).
1554 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1555 * Clean up of previous JPR garbage commit (not even commented in the
1557 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1558 - moved all jpeg related files from src to src/jpeg/libijg8, with
1559 addition/modification of Makefile.am and configure.in.
1560 - the testSuite is still brain damage (not guilty).
1562 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1563 * WrapVTK.py : modifications to get correctly vtk source files to
1565 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1566 (FileName -> Filename)
1568 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1569 * vtk/vtkGdcmReader.[cxx/h]:
1570 - UpdateProgress method should now be effective
1571 - removed the limitation on having only images loaded (as opposed
1573 - when building a stack of images/volume, a lesser number of
1574 gdcmHeader and gdcmFile instances should be used (hopefully
1575 accelerating things).
1576 - when building a stack of images/volumes, files which are not
1577 loadable (wrong path-filename, wrong permissions on existing file,
1578 or file not parsable by gdcm) are replaced with a black image
1579 in the stack (for the caller to notice the problem).
1581 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1582 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1584 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1585 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1586 between standard library (std) and vtk library (problems are found
1587 under Windows... thanks Windows !)
1589 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1590 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1592 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1594 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1595 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1597 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1598 * When compiling with distutils (see setup.py) the C++ compiler is
1599 called with different flags than the default ones (with automake).
1600 In order to fix all those warning, I compiled gdcm with the command
1601 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1602 and went for warning fixes:
1603 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1604 up from unused variables.
1605 - vtk/vtkGdcmReader.cxx: potential bug fix.
1606 * src/gdcmHeader.h: Doxygen warning cleanup
1608 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1609 * gdcmPython/gdcm.i:
1610 - typemaps correction to take into account the systematic replacement
1611 of "using namespace std" with std:: prefix e.g. std::list,
1612 std::string... (cf changes of 2003-05-21).
1613 - gdcmGlob global variable of type gdcmGlobal (defined in
1614 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1615 exported to Python a as cvar.
1616 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1617 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1618 gdcmDictSet.GetPubDictTagNames() and
1619 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1620 C++ static methods).
1621 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1622 with the above changes.
1624 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1625 * setup.py, manifest.in : bug fix under linux
1627 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1628 * Modification of setup.py to compile vtk part too. Then, we have 2
1629 wrappers which must work with same distutils. For that, we have a
1630 generic distutils in distusiltsWrapping.py ; with :
1631 - build_extWrap class to wrap generically all extensions,
1632 - ExtensionWrap base class for all wrapping extension that contains
1634 - Wrapper interface which wrap sources
1635 + In WrapSwig.py we have extension and wrapper for Swig
1636 + In WrapVTK.py we have extension and wrapper for VTK
1637 * MANIFEST.in : modifications to consider vtk directory and new python
1638 files for compilation
1640 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1641 * Added python wrappers of vtkGdcmReader vtk class (see the
1642 source in vtk/vtkGdcmReader.cxx) :
1643 - vtk/Makefile.am now builds a library
1644 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1645 python library (as opposed to _gdcm.so wich are the python
1646 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1647 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1649 - configure.in has an additional flag --enable-vtk that needs
1650 to be set to enable compilation of vtk related code, that is:
1651 + vtk/vtkGdcmReader.so and
1652 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1653 + gdcmPython/vtkgdcmPython.so (see above)
1654 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1655 be read when compressed or when HighBit + 1 != BitsStored),
1656 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1657 the usage of the python wrapper of vtkGdcmReader vtk class.
1658 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1659 * src/*.[h] all occurences of stl classes are now prefixed with
1660 std::, and all occurences of "using namespace std;" where removed.
1661 This is to avoid pollution of global namespace in included files.
1662 Apparently vtk does not avoid this pitfall: when using both
1663 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1664 collision of various stl members (principally cout...).
1665 * gdcmPython/testSuite.py now cleanly removes temprory generated
1667 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1668 comply with above changes)
1670 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1671 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1672 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1673 vtk data structure (an image Flip was required).
1674 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1675 * cosmetic changes in documentation.
1677 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1678 * src/gdcmHeader.cxx: the constructor no longer exits when an
1679 unexisting file is given as argument.
1680 * The subdirectory Data (containing all the images used for the
1681 test suite) is not part of this repository anymore. A new module
1682 containing those images is now available at
1683 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1684 with the name gdcmData.
1685 All the python scripts (including the package initialisation file
1686 gdcmPython/__init__.py) were adapated to take this change into
1687 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1689 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1690 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1691 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1692 demo of the usage of this class.
1693 Compilation of this vtk part is only done when using the --enable-vtk
1694 at configure (or autogen.sh) stage.
1696 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1697 * More memory link related corrections and documentation fixes.
1699 - maximum info is obtained with a command of the form:
1700 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1701 --show-reachable=yes PrintHeader
1702 - the remaining reachable blocks seem to come from the STL
1703 allocation scheme through the usage of map and list. It looks
1704 like this memory cannot be freed but it is not a memory leak
1705 (in fact further invocation to the STL would recollect the
1706 unused memory allthough it cannot explicitely be freed).
1707 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1708 of displaying an image parsed with gdcm and displayed with VTK.
1709 Note: some images don't seem to work e.g.
1710 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1711 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1712 Allthough this weakens the semantics, it is a ditch attempt to
1713 make gdcm more thread friendly.
1715 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1716 * Memory link hunt (by using valgrind through the command
1717 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1718 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1719 gdcmHeader::_dicom_vr.
1720 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1721 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1723 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1725 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1726 * src/Makefile.am now exports all the necessary include files at
1730 * UpdateGroupLength replaced by new one
1733 * UpdateGroupLength re-written using H-Table
1734 (named UpdateGroupLengthNew untill checks are over)
1736 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1737 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1738 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1740 - gdcmHeader::GetPubElValSet removed.
1741 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1742 UpdateGroupLength, WriteElements, Write.
1743 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1744 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1745 carried the same semantics.
1746 - src/gdcmHeaderIdo.cxx changed accordingly.
1747 - gdcmFile::WriteBase now regroups all the codes from previous
1748 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1749 - enum FileType moved to gdcmCommon.h
1750 * src/gdcmHeader.cxx AddDefault trashed
1751 * gdcmGetXSize added
1752 * getimageDataSize now calls gdcmGetXSize
1753 * Test/*.cxx changed to agree with above changes
1755 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1756 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1757 (to avoid double call by end user).
1758 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1759 by end user, since gdcmHeader::gdcmHeader now handles it.
1761 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * gdcm/Doc many doxygen changes:
1763 - Doxyfile now has two different versions, DoxyfileUsers that generates
1764 the html.users end users oriented documentation and
1765 DoxyfileDeveloppers that generates the html.developper developper
1766 oriented documentation.
1767 - README changed accordingly
1768 - requirement.txt removed (old design info moved to TODO).
1769 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1770 DoxyMainPage.txt, DoxyPython.txt provide more information.
1771 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1772 be updated by simply regenerating the docs with doxygen and copying
1773 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1774 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1775 all the tests in the form "if (<map>.count() >1)" were removed.
1776 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1777 ill-formed documentation sections.
1778 * src/gdcmHeader.cxx: ditto
1780 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1781 * setup.py fixed for un*x (needed macro for stdint.h)
1782 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1783 un*ces with sh-utils test utility.
1784 * gdcmPython/demo/test.py renamed to PrintHeader.py
1785 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1786 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1787 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1788 * src/gdcm*.cxx JPR's bad inclusion fixed.
1790 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1791 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1792 * gdcmPython/demo/test.py changed accordingly.
1794 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1795 * gdcmPython/Makefile.am fixed linking against libstdc++
1796 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1797 * Swig subdir (historical tests of swig version 1.3.17++) removed
1798 * Test/testChangeEntete.cxx some lines commented out in order to make
1800 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1801 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1803 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1804 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1805 hence the user doesn't need this explicit call.
1806 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1807 i.e. LoadElements() call removed.
1808 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1809 - src/Makefile.am declares the proper flag for g++.
1810 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1811 for adding user defined new tags.
1812 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1813 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1814 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1816 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1817 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1818 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1819 src/Makefile.am : the project should properly compile and install
1820 with the autotools, included the python wrappers part.
1821 * gdcm.spec.in : added a spec file for RPM packaging.
1823 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1824 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1826 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1827 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1828 to exported to the environement (see gdcmPython/testSuite.py
1830 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1831 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1832 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1833 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1834 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1836 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1837 * gdcmPython/__init__.py doesn't crash anymore when running in
1838 in InstallMode or PreInstallMode but with an environement given
1839 value of GDCM_DICT_PATH.
1840 * src/gdcmDictSet.[cxx/h] coding style.
1842 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1843 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1844 * src/gdcm.h general comments moved to TODO, and README
1845 * src/gdcm.h should now be seen as a user commodity (including it
1846 should suffice to fully use gdcm). It is nowhere including within
1847 any of the kernel files src/*.cxx and src/*.h.
1849 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1850 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1851 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1853 * src/gdcm*.cxx only include their corresponding include file
1854 (as opposed to gdcm.h)
1855 * gdcmPython/gdcm.i changed accordingly
1856 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1857 the autogen.sh generated "make snapshot" command to work.
1858 * autogen.sh removed history related references to crea package.
1860 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1861 * distutilsSwigCPlusPlus.py work around some swig portability
1864 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1865 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1866 was done in a last ditch attempt to get setup.py _really_
1867 operationnal. The python/gdcmPython layaout add the advantage
1868 of hidding away the python related distutils specific files
1869 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1870 Alas, the src directory was out of scope (i.e. it's relative
1871 position to setup.py was ../src) which made things impossible to
1872 handle (see previous version of python/setup.py). Crossing fingers...
1874 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1875 * python/setup.py now works on Un*x. (harder than I thougth)
1876 * python/distutilsSwigCPlusPlus.py can now have include files
1877 among the list of sources.
1879 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1880 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1881 * modifications in MSVC projects
1883 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1884 * As stated by the first lines of Test/ExceptionAndPython/README, it
1885 looks like we can move back to original usage of exception within
1886 src/gdcm* and hence remove the errno stuff that was introduced
1887 as a quick and dirty fixture of this problem (added to the TODO).
1888 * Doc/Doxyfile configuration file for Doxygen and corresponding
1889 README file for usage added.
1890 * Test/testWrite.cxx added. This new test comes from a split of
1891 test.cxx that is now reverted to its original purpous i.e.
1892 testing the proper parsing of a Dicom related file.
1893 testWrite.cxx concentrates on testing the IO part of gdcm.
1894 * Test/bug1.cxx (containing a bug on WIn32) added.
1895 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1896 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1897 whose purpose is to publish the content of the TagNames of the
1898 Dicom public dictionnary were not accessible without an
1899 instance of class gdcmHeader.
1900 - those methods are now static methods of gdcmDictSet and hence
1901 require no instances at all to be invocated.
1902 - within gdcmDictSet this change required to change some method
1903 to class methods (i.e. are now static) among which SetDictPath
1904 (renamed to BuildDictPath) and LoadDefaultPubDict.
1905 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1906 the above changes by calling the new method classes of gdcmDictSet.
1907 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1908 the above to be effective.
1909 * python/gdcmPython: in order to wrap properly the above changes
1910 for Python, swig version now needs to be > 1.3.17.
1911 * python/gdcmPython/Makefile fixed to adapt itself to new
1912 configure/make shema introduced by Johan Montagnat (thanks for the
1913 contribution). Alas this Makefile cannot be turned into a proper
1914 Makefile.am without some heavy changes in the configure.in
1915 (for python dectection).
1916 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1917 now avoids publishing the empty entries.
1919 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1920 * python/setup.py : bug fix concerning install under windows
1921 ExtraPath reused :-P
1922 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1924 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1925 * Dicts/dicomV3.dic : remove double spaces !!!
1926 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1927 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1930 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1931 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1932 method. Doxygenation.
1933 * src/gdcm.h clean up of JPR spurious comments.
1935 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * python/distutilsSwigCPlusPlus.py now properly collects the
1937 shadow classes generated by "swig -c++" (gdcm.py in our case)
1938 when using "python setup.py install".
1939 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1940 reexports the working classes.
1941 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1942 by the classical C errno scheme. This is to prevent an obscure
1943 behavior of the python wrappers when importing wxPython.wx prior
1944 to gdcmPython (which ended up in an abort call). An illustration
1945 of this oddity can be found in the Test/ExceptionAndPython
1946 subdir (see the README file). This problem probably due to
1947 an combination of g++ and dynamic loading.
1948 * added Test/ExceptionAndPython (see above)
1950 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * Changed the layout of the python part to avoid bloating main
1952 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1953 i.e. the distutils arsenal. All the python related stuff is
1954 again in a python subdir, but the package itself is now in
1956 * setup.py was cleaned up:
1957 - pythonIncludePath removed
1958 - python setup.py bdist target is now functional.
1959 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1960 collision with other packages). gdcmPython/demo/*.py changed
1963 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1964 * python subdir moved to gdcmPython (preparation of distutils packaging).
1965 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1966 distutils installer is operational.
1967 * - gdcmPython/__init__.py now properly loads the swig generated
1968 shadow classes (from gdcm.py).
1969 - gdcmPython/demo/*.py changed to import the package gdcmPython
1970 instead of gdcmPython/demo/load.py.
1971 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1973 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1974 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1975 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1976 entries within the associated public Dicom dictionary resp. the same
1977 information but sorted by the fourth field (PAT, IMG, DIR) of the
1979 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1980 are now in the "???" group.
1981 - python/gdcm.i changed accordingly,
1982 - python/demo/printGroupedPublicDict.py added, that gives an example
1983 of the above new functionalities in Python.
1985 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * src/gdcm.h, gdcmHeader.cxx:
1987 - historic references to glib's g_malloc and g_free (#defined)
1988 were definitively removed.
1989 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1990 * src/gdcmElValSet.cxx:
1991 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1992 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1993 - GetElValue(string) renamed to GetElValueByName.
1994 - Added GetElementByName(string).
1995 * src/gdcmHeader.cxx: added
1996 - GetPubElValRepByNumber(guint16, guint16)
1997 - GetPubElValRepByName(string)
1998 - GetShaElValRepByNumber(guint16, guint16)
1999 - GetShaElValRepByName(string)
2000 - GetShaElValByNumber(guint16, guint16)
2001 - GetShaElValRepByName(string)
2002 - GetElValRepByNumber(guint16, guint16)
2003 - GetElValRepByName(string)
2004 - GetElValByNumber(guint16, guint16)
2005 - GetElValRepByName(string)
2006 * Doc/requirements.txt added.
2008 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * Test/Makefile building now depends on the one of libgdcm.so
2010 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2011 pixel data) aware which enables finding the address (offset) of
2012 the pixel data of JPEG encoded DICOM files. This leaves only a single
2013 file in the testSuite whose pixel data address (offset) is unknown.
2014 * python/testSuite.py changed accordingly.
2016 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2017 * VC++ has some strong limitations when working with the STL, as stated
2018 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2019 "Also note that some STL containers (map, set, queue, list, deque)
2020 cannot be exported. [...]
2021 Some STL classes contain nested classes. These classes can not
2023 This is caused by a designed limitation that once a template
2024 class is instantiated, it can not be re-instantiated and
2026 Since our usage of map<> is ubiquitous in gdcm, this "designed
2027 limitation" of VC++ is a pitfall.
2028 Hence the Python wrappers of gdcm cannot be incrementally linked
2029 against the c++ dynamic library. The dirty but only workaround is
2030 to forget about incremental link of dynamic libraries and to generate
2031 the Python wrappers library with the inclusions of the underlying C++
2033 The following modifications concern this matter on Win32/VC++:
2034 - wrapping python correct with standalone wrapped dll (don't use separate
2035 dll under windows !!!!)
2036 - python21_d debug mode enabled (ask Frog how to use it :-)
2037 - NO problem with having an STL member of class for example string in C++
2038 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2039 - Python test of dcmlib in Python is ok under windows on a large set
2041 * removed glib references
2042 * typedef's inserted in gdcm.i for correct swig type management
2044 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * python/demo/*.py load.py extracted from test.py. Added explore.py
2046 that only displays required tags and testAll.py that parses all
2047 the files of the testsuite without using unittest.
2048 * python/testSuite.py other additional test on new files added.
2049 * Data/* new test files added accordingly to the testSuite.
2050 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2051 the vr in the file differs from the one of the dictionary.
2053 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2054 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2055 values, but limits itself to values which are below a user specified
2056 size (by default 1024 bytes).
2057 * python/gdcm.i : elements not loaded (because their size is above the
2058 user specified treshold) are exported with their TagKey as key of the
2059 python dictionary. This enables the testsuite to make some checks
2060 on the unloaded elements (since we have their offset and size).
2061 * python/testSuite.py
2062 - now tests for the existence and proper value of the pixel data
2063 - two new examples added.
2064 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2066 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2068 aware. See the strategy comments in gdcmHeader::FindeLength().
2069 * Test/test.cxx now accepts a filename as first argument.
2070 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2071 * python/testSuite.py changed to integrate test on above files.
2073 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2074 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2075 the vr was also RET.
2076 * python/testSuite.py more tests added.
2078 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2079 * python/testSuite.py unittest test suite added (uses Data)
2080 * Data/* dcm and acr files for the test suite.
2081 * glib dependance removed from un*x version. We now use ISO C99
2082 7.18 Integer types (see stdint.h)
2083 - python/Makefile, src/Makefile src/gdcm.h
2084 * src/ when an explicit vr (like dicom files) suddenly poped an
2085 implicit element we use to mark the underlying DictEntry of the
2086 concerned ElValue with "Implicit". This strategy was damageable
2087 too the public or provite dictionaries, since some of their vr
2088 would be changed. Since Header::FindLength heavily relies on the
2089 detection by Header::FindVR of falsely explicit elements, I
2090 added an extra ImplicitVr member to ElValue (boolean).
2091 The rest of the changes we the necessary adaptations.
2093 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2094 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2096 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2098 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2099 * Adaptation for porting to VC++:
2101 o forced to use std namespace (for string to be known)
2102 o all class use __declspec export style on WIN32
2103 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2104 (in stdlib.h on Win32 but in std:: for gcc)
2105 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2106 variable GDCM_DICT_PATH.
2107 * src/gdcmHeader.cxx verbose comments made discrete.
2109 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2110 * python/gdcm.i: added a typemap that converts a C++ hashing table
2111 to native Python dictionary.
2112 * python/demo/test.py:
2113 - now uses the native dictionary for exploration of gdcmHeader.
2114 - takes an optional filename argument (the file to parse).
2115 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2116 PubElVals hashing table.
2117 * Dicts/dicomV3.dic removed error prone trailing spaces.
2119 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2120 * Python wrapping process moved away from src/Makefile to
2121 newly created python/Makefile (as well as gdcm.i)
2122 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2123 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2124 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2125 from the environement variable GDCM_DICT_PATH (when existing).
2126 * src/gdcmDict::GetTag bug fix.
2128 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2129 * Straightforward temporary fixes for swig to build the python wrappers.
2130 src/Makefile now has a python working entry [by working we mean
2131 that we can import de shadow classes without errors].
2133 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2134 * hashtest.cxx removed (since allready in Test)
2135 * src/gdcmlib.h renamed to src/gdcm.h
2136 * src/dcm.i renamed to src/gdcm.i
2137 * src/Makefile prepared for python wrapping
2139 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2140 * src/gdcmHeader.cxx :
2141 - Parsing of header is now separated from loading of element values
2142 (see gdcmHeader::LoadElements).
2143 - general clean up of hopefully all file access (creation of
2144 ReadInt16 and ReadInt32)
2146 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2147 * src/gdcmHeader.cxx :
2148 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2150 - SetLgrElem renamed to SetLength
2151 - GetLgrElem renamed to GetLength
2152 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2153 * src/gdcmElValSet.cxx fixed both GetElValue methods
2154 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2155 due to IdoDude was cleaned out.
2157 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2158 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2159 concentrates on finding the value representation (when it exists).
2160 RecupLgr now only finds the element value length, and it avoids
2161 returning the unecessary skL (skipped length).
2162 Also, offsetCourant was simply removed (with taille_fich) since
2163 it was redundant with the File position internals (by using
2164 ftell and fseek). This also made skL (see above in RecupLgr) usage
2166 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2167 on the libido specificities which are handled through class
2169 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2172 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2173 * Truckload of changes. Parsing of header is barely functional
2174 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2176 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2177 * src/gdcmHeader.cxx many addons of low level methods
2179 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2180 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2181 and _IdDcmSWAP_LONG.
2183 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * This corresponds to all the changes decided at the meeting of
2185 May 23 2002. Needless to say we are running late...