1 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Update jpeg ijg lib to support lossless jpeg implementation
3 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
5 * Also added a special copyright for dcmtk since we use their bugfixes.
8 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
9 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
10 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
11 matters, as stated in warning note at begining of %include section).
12 * src/gdcmDicomDir*.[cxx|h]: coding style
13 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
14 * src/gdcmJpeg8.cxx: doxygen fix.
15 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
16 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
17 from File:: to PixelConvert::.
19 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
20 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
21 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
22 - more code moved away from File:: to PixelConvert::
23 - fat setup of PixelConverter set in place in File::Initialise.
25 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
26 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
27 namespace at the file system level. So now you should convert your examples
29 gdcmHeader -> gdcm::Header
30 It would be nice if people keep in mind to no open the namespace, since it
31 allows compilation on broken plateform which were defining common symbol in
32 the standart namespace (like LP, Unknown ...)
34 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
35 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
36 The JPEG fragments are now parsed at the same stage than the RLE
37 information. All code related to JPEG is now in gdcmPixelConvert:
38 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
39 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
40 export a gdcmFile:: method. Those are simply global functions
41 (for the time being this is better than having them attach to
42 either gdcmFile:: or gdcmPixelConvert::).
43 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
44 and stores the result in a gdcmJPEGFragmentsInfo.
45 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
46 code (among other stuff) moved away from gdcmFile:; to
49 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
51 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
52 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
53 clean up of RLE related code.
54 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
55 - src/gdcmRLE.cxx removed
56 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
57 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
58 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
59 * CLEANUP_ROUND (9) for gdcmPixelConvert
60 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
61 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
62 away from gdcmFile:: to gdcmPixelConvert::.
64 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
65 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
66 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
67 This is because Parse7Fe0 used to parse the pixels to compute the
68 length. This task was passed over to FindDocEntryLengthOB() a long
69 time ago, EXCEPT I had forgotten the OW case...
70 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
71 we just recylce the code for parsing RLE fragments and computing
73 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
74 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
75 with the retired Parse7Fe0().
76 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
77 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
79 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
80 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
81 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
82 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
83 - src/CMakeLists.txt: alphabetic order reodering + new entries.
84 * CLEANUP_ROUND (4) for gdcmPixelConvert
85 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
86 to return an unused length.
88 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
89 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
90 this should be cleanner from the plane view. The iostream are erally a pain
91 to use to do simple stuff.
93 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
94 * Redo the compilation of the ijg jpeg library. Now only one source is
95 necesseray. No need to rename file by hand what so ever. CMake handle the
96 copying of the file within different directory, configure header file to
97 modify some symbol. The only addition made to ijg wasd a mangle table so
98 that symbol are different wether we are within 8bits or 12bits.
100 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
101 * Added documentation of vtkgdcmReader on Website:
102 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
103 with it's binary name).
104 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
105 the Website to be more complete.
106 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
107 doxygenated documentation.
108 - Doc/DoxyVtkGdcmReaderExamples.txt added
109 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
110 DoxyVtkGdmReaderExamples.html )
111 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
112 * CLEANUP_ROUND (3) for gdcmPixelConvert
113 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
115 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
116 * CLEANUP_ROUND (2) for gdcmPixelConvert
117 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
119 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
120 * CLEANUP_ROUND for gdcmPixelConvert:
121 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
122 - src/gdcmPixelStuff[h|cxx] removed
123 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
124 - src/CMakeLists.txt changed accordingly
126 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
127 gdcmVersion.py moved to newly created ATTIC related
128 gdcmPython/SetupOldies/ directory.
129 * Autotools clean up:
130 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
131 - autogen.sh configure.in acinclude.m4 python.m4 removed
133 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
134 * src/*.cxx *.h Reference to License.htm fixed to License.html.
135 * Doc/CMakeLists.txt, doxygen.config.in: fix.
136 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
138 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * TODO updated with Mathieu suggestions. I proposed a template for
140 describing TODO entries and used it for new entries.
141 * Added Doc/Website/CodingStyle.html, Developpers.html,
142 DeveloppersPython.html, GdcmDataCvs.html and
143 DownloadVersion0_1.html, DownloadVersion0_3.html.
144 * Some Doc/*.txt Doxygen files (which do not really concern the
145 documentation itself, but the website) moved to html and
146 placed in directory Doc/Website:
147 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
148 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
149 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
150 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
151 * CMakeLists.txt changed accordingly.
152 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
153 DeveloppersPython.html
154 * INSTALL nows refers to Doc/Website/Installation.html
156 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * Added Doc/Website directory, that contains a first raw version
160 2004-09-23 Jean-Pierre Roux
161 * FIX In order not to be poluted any longer by casting problems,
162 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
163 we can now delete[] it safely
164 * VoidArea is now called BinArea (less confusing name),
165 and all the methods called ...VoidArea... are now ... BinArea...
166 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
168 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
169 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
170 clear) TagHT, which is an inherited member of gdcmElementSet. It is
171 up to the destructor of gdcmElementSet to clean up TagHt and it's
174 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
175 * Test/CMakeLists.txt: update to follow gdcmData renamings.
176 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
178 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
179 * ENH: added some utility method that builds a flat dictionnary
180 holding all the Dicom entries contained in the recursive structure
181 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
183 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
184 BuildFlatHashTable() that build a flat dictionary.
185 - src/gdcmElementSet.h: added a new private GetTag() accessor.
186 gdcmDocument is now a friend of gdcmElementSet.
187 - src/gdcmElementSet.cxx: clean up.
188 - Example/FlatHashTablePrint.cxx added.
189 - Example/CmakeLists.txt changed accordingly
191 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
193 moved away from gdcmDocEntrySet (since this class is an abstract class
194 acting like an interface). SQDepthLevel and BaseTagKey are now
196 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
197 and associated accessors. Doxygenation of the class.
198 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
200 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
201 Use SQDepthLevel accessor instead. ::Print() adapted.
202 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
203 - src/gdcmDocument.cxx changed accordingly.
205 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
206 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
207 - The following is the doxygen comment of the typedef declaration
208 of gdcmagKey in src/gdcmCommon.h:
209 gdcmTagKey is made to old an "universal" (as in URL, Universal
210 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
211 A dicom tag allways has a group and an element, but a set of tags
212 embeded in various (optionally nested) sequences and sharing
213 the same group and element all share the same (group, element)
214 "identifier". Hence the (group, element) cannot be used as an
215 identifier (in gdcm we shall refer to a "TagKey") of a tag.
216 In order to construct a proper tag identifier (i.e. a key) we
217 consider the following definition of a TagKey:
218 - let Group, Element be the string representation of the
219 group and element dicom tag members,
220 - let ItemNumber be the string representation of the integer
221 index of the considered item number of a sequence,
222 Let the key of a tag embeded in a sequence, noted SeqTag, be
224 /ItemNumber#Group|Element
225 where "/", "#" and "|" are characters acting as separators.
226 Then the general form of a gdcmTagKey is given by:
227 Group|Element<SeqTag>
228 where <SeqTag> means NO or many instances of SeqTag.
229 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
232 but the gdcmTagKey of a tag "embeded" is the first item of
233 a sequence, itself nested in the third item of a sequence is the
235 0004|1220/2#0008|0082/0#0008|0090
236 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
237 order to hold the new sequence compatible key. Previously, the
238 GetKey() method would look in the underlying gdcmDictEntry.
239 - src/gdcmDocEntry.cxx:
240 -- constructor now copies the underlying DictEntry key, in the local
242 -- ::Print: displays the member Key, instead of the (group, element).
243 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
244 - src/gdcmDocEntrySet.h:xi
245 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
246 -- now has a new BaseTagKey member.
248 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
249 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
251 This poses the problem with the semantics of the following lines
252 LoadEntryVoidArea(0x0028,0x1201); // R LUT
253 LoadEntryVoidArea(0x0028,0x1202); // G LUT
254 LoadEntryVoidArea(0x0028,0x1203); // B LUT
255 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
256 to the long FIXME note for what the problem is. Nevertheless in
257 order to get things working the dicom dictionary was altered !
258 Please fix things urgently...
259 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
260 information), see above note on moving the member VoidArea. Nevertheless
261 the following entries previously correctly set as US are now inproperly
263 0028 1201 OW IMG Red Palette Color Lookup Table Data
264 0028 1202 OW IMG Green Palette Color Lookup Table Data
265 0028 1203 OW IMG Blue Palette Color Lookup Table Data
266 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
267 of gdcmDocEntry moved to gdcmSeqEntry.
268 * src/gdcmSeqEntry.cxx: STYLE.
270 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
271 * Test/TestAllEntryVerify.cxx minor fix and added comments.
273 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * gdcmPython/testSuite.py: all the test suite in python is now moved
275 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
276 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
277 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
279 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
280 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
281 to avoid inclusion recursion until STL is reached.
282 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
283 mecanism. errno.h is not included in gdcm anymore.
284 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
285 (gdcmFormatError now inherits from gdcmFormatUnexpected).
287 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
288 gdcmData/TestAllEntryVerifyReference.txt
289 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
290 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
291 exception_on_error parameter.
292 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
293 - vtk/vtkGdcmReader.cxx changed accordingly,
294 - Example/*.cxx and Test/*.cxx changed accordingly.
296 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
297 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
298 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
299 enable_sequences removed from gdcmHeader constructor and dependencies.
300 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
301 * gdcmPython/demo/PrintHeader.py: dummy fix.
302 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
303 skip_shadow removed from gdcmHeader constructor and dependencies.
304 * Example/*.cxx and Test/*.cxx changed accordingly.
306 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
307 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
308 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
310 2004-07-21 Jean-Pierre Roux
311 * FIX Now, Parsing and Printing a DICOMDIR do work!
312 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
314 2004-07-20 Jean-Pierre Roux
315 * FIX Some brain damaged headers have Zero-Lenght fields
316 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
318 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
319 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
320 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
321 variable (instance of gdcmDebug) by a definition macro, and the instance
322 is now in static in the gdcmDebug class
323 * src/gdcmSQItem.h : (FIXME) remove an undefined method
324 * Test/PrintAllDocument.cxx : bug fix in the result of the test
326 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * WARNING: ctest now depends more tightly on gdcmData. You should
328 check out gdcmData properly for things to run smoothly...
329 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
330 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
331 we need the pixels not be loaded in order to use the ValEntry
332 that displays position and size).
333 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
334 This is a C++ based equivalent of gdcmPython/testSuite.py that should
335 be deprecated. If you have any doubts about the advantages of a
336 modern scripting language (read Python) versus grass root C++ (i.e.
337 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
338 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
339 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
340 Anyhow, consider documenting the gdcmData images in
341 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
343 * Test/CMakeLists.txt:
344 - now uses TestAllEntryVerify.cxx
345 - specific comments on oldACR00001.ima (now renamed in gdcmData
346 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
347 gdcmData/TestAllEntryVerifyReference.txt
350 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
351 * src/*.[h|cxx] : typedef clean up
352 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
353 - TagKey renamed to gdcmTagKey (for external usage)
354 - VRKey renamed to gdcmVRKey (for external usage)
355 - removal of typedef duplication.
356 - Removed all unecessary inline keyword from class inline definitions.
357 - Some method|function(void) declarations replaced with method|function().
358 * src/jpeg/libijg12/jdhuff12.c:
359 - printf polluting ctest removed.
360 - TAB removal for comminting
362 - TestAllReadCompareDicom.cxx: added a test that compares all the
363 images in gdcmDataImages.h with corresponding images in
364 gdcmData/BaselineDicom/. When baseline images are not present
365 this test creates them.
366 Note: we need to validate each reference image, but before that
367 I'd like to rename them with a more explicit name...
368 - CMakeLists.txt: changed accordingly.
369 * Example/*.cxx: examples now only include gdcm.h (as opposed to
370 including each header needed).
372 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * Test/*.cxx and Example/*.cxx: moved some examples away from the
374 test suite to the Example directory. Are concerned:
379 - TestWriteSimple.cxx
380 * Test/CMakeLists.txt: added some comments on reasons for black listing
381 image gdcmData/oldACR00001.ima
383 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * Test/CmakeList.txt: removed the following from black list (to be coherent
385 with removal from gdcmData):
386 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
387 - gdcm-MR-PHILIPS-16.dcm
389 Added the following because after last cvs update, they cause
390 ctest -R TestReadWriteReadCompare
392 - gdcm-MR-SIEMENS-16-1.acr
394 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
395 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
396 new comments in this file) we temporarily (sigh) move to a weaker
398 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
399 we don't need to black list the following images anymore:
400 - 8BitsUncompressedColor.dcm
402 - US-PAL-8-10x-echo.dcm
403 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
404 fixes and the beautified code ;-)
405 This fixes the bug introduced in version 1.42 (when beautifying)
406 that made the parsing of 8BitsRunLengthColor.dcm unproper.
407 Note: ctest was blind to this bug (this means we need to still
408 improve the test suite). The bug could be detected by using
409 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
411 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
412 and by displaying the (garbage) produced file temp.XDCM...
414 2004-06-29 Jean-Pierre Roux
415 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
416 - replace by uggly but working old code :-(
417 A lot of things should be OK again.
418 It's really urgent to have a test suite that *tests*,
419 to prevent Frog's beautifying sessions to break all the stuff
420 (twice, withing a fortnigh ...)
422 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
424 redundancy) to added Test/TestReadWriteReadCompare.cxx
425 * Test/CmakeList.txt: because the compare test of
426 Test/TestReadWriteReadCompare.cxx fails, the following images are
427 black listed: - 8BitsUncompressedColor.dcm
429 - US-PAL-8-10x-echo.dcm
430 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
431 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
432 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
433 and ad-hoc kludge. This kludge is now removed, and on encountering
434 such an image (OB field brain damaged) we set errno. Then in
435 ::FindDocLength() we "fix" the length as being ALL what remains
436 in the file (until EOF). We then proceed, hoping for the best...
437 This fixes a SegFault in ShowDicom when trying to write such an
439 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
440 (because TestWriteRead breaks on it, after a non conformal commit?).
441 ctest now runs properly, except for MakeDicomDir (which was allways
442 broken) and the Python related stuff (still not fixed).
444 2004-06-24 Jean-Pierre Roux
445 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
446 FIX : Test/TestReadWrite now iterates on all the file names
447 (instead of infinite loop)
448 ENH : Test/TestWriteRead now iterates on all the file names
450 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
451 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
453 2004-06-24 Jean-Pierre Roux
454 FIX : - now Write drops LUT Descriptors and LUTs (if any)
455 when SamplesPerPixel =3
456 - now Write is no longer confused by
457 'BitsAllocated = 12" and 'BitsStored=12"
458 - "UN" value representation Elements are now written correctly
459 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
460 ENH : - now gdcmHeader has its own Write methods
461 (in order to split the job that has not to be done
464 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
465 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
466 loop on the same image until memory went out.
467 Note: this means we still have gobs of memory loss in PrintDocument
468 * src/gdcmDocument.cxx: fixes problem on parsing on file
469 gdcmData/16BitsJpegLosslessGrayScale.dcm.
471 2004-06-24 Jean-Pierre Roux
472 FIX : Write - All the Sequences and Sequence Item are now written
473 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
474 is added a the end, when necessary.
475 - A lot of brain-damaged images, that were read correctly are
476 now written correctly
477 - length compatible BinEntry are now loaded correctly
478 (even for odd groups)
479 Note : only Explicit Value Representation was checked.
480 (question : is implicit VR really necessary for gdcm ?)
482 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
483 * DEVELOPPER: added a proposition of coding style.
484 * src/gdcmDocEntry.h: removed every inline declaration (for test of
487 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
489 Use the gdcmDocEntry::Print() and Write() instead.
490 * src/gdcmDocument.cxx: bug fix.
492 2004-06-22 Jean-Pierre Roux
493 FIX : gdcmDocument.cxx
494 - Now we do recognize the JpegLossLess format (there was a misstyping in
495 code 'beautyfication' :-(
496 - Now we automaticaticaly load the Luts, if any
498 2004-06-22 Jean-Pierre Roux
499 In order : to write Sequences, whatever their imbrication level,
500 : to allow user to create his own Sequences
501 a lot of modif where necessary (adding, moving, or virtualising methods)
503 WARNING : save your own sources *before* cvs up !
506 ADD virtual void Write(FILE *fp, FileType filetype);
509 ADD virtual void Write(FILE *fp, FileType filetype);
510 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
513 ADD virtual void Write (FILE *fp, FileType filetype)=0;
514 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
515 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
516 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
517 ADD std::string GetEntryByName(TagName name);
518 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
520 std::string vr = "unkn",
521 std::string fourth = "unkn",
522 std::string name = "unkn");
523 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
524 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
525 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
526 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
527 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
528 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
529 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
530 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
533 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
534 ADD virtual std::string GetEntryByName (TagName tagName);
535 ADD virtual std::string GetEntryVRByName (TagName tagName);
536 REM virtual bool Write(FILE *, FileType);
537 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
538 FILE *_fp, FileType type);
539 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
540 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
541 REM virtual bool WriteEntries(FILE *_fp,FileType type);
542 REM virtual std::string GetEntryByName (std::string tagName);
543 REM virtual std::string GetEntryVRByName (std::string tagName);
544 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
545 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
546 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
548 std::string vr = "unkn",
549 std::string fourth = "unkn",
550 std::string name = "unkn");
551 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
552 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
553 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
554 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
557 ADD virtual void Write(FILE *fp, FileType filetype);
560 ADD virtual void Write(FILE *fp,FileType filetype);
563 ADD virtual void Write(FILE *fp, FileType filetype);
564 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
565 REM std::string GetEntryByNumber(guint16 group, guint16 element);
566 REM std::string GetEntryByName(TagName name);
569 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
571 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
572 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
573 The default constructor invoked by the line
574 gdcmHeader *f1 = new gdcmHeader( header );
575 was gdcmHeader::gdcmHeader(bool) instead of the expected
576 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
577 Hence the parsing wasn't executed... See also below.
578 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
579 as explicit constructor didn't do the trick to fix the above problem.
580 Could anyone explain why ?
581 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
582 properly calls gdcmValEntry::Print() (that was weed out from
583 code related to gdcmBinEntry).
585 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
586 * In order to fix memory leaks:
587 - Test/TestWriteSimple.cxx: added cleaning of free store through
589 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
590 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
591 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
592 (through the call to ::AddDicomDirMeta()) or the destructor
593 would crash when deleting uninitialized ::metaElems].
594 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
595 - src/gdcmDocument.cxx:
596 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
598 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
599 was causing memory leaks.
600 - src/gdcmSQItem.cxx:
601 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
602 cleanly handled with polymophism: sorry but my milage is low).
603 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
604 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
605 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
606 This avoids SegFaulting.
607 - src/gdcmSQItem.h: coding style.
609 - Test/TestWriteSimple still severely sucks. The output image content
610 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
611 damaged when displayed with vtkgdcmViewer.
612 - on memory leaks: TestWriteSimple leaks really less (see entry
613 of 2004-06-18 in Changelog file for the call to valgrind).
614 - on segfaults: ctest now passes all the tests but one (no more
616 * Erroneous leading white fix:
617 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
618 white[s] (as opposed to from >> xxx, that removes it [them].
619 - src/gdcmTS.cxx: ditto.
620 - gdcmPython/testSuite.py: dirty related kludge removed.
621 * src/*: remaining references to gdcmParser removed.
622 * src/*[cxx|h]: added copy[way]left header.
625 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
626 * In order to fix writing of dicom files:
627 - Test/TestWriteSimple.cxx: a simpler example of writing.
628 - Test/CMakeLists.txt changed accordingly.
629 - src/gdcmDocument.cxx:
630 -- The destructor now recursilvely removes potential sequences.
631 -- Bug fix in ::IsJPEG2000()
632 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
633 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
635 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
636 to only declared) and build on top of
637 ::GetDocEntryByNumber(guint16, guint16).
638 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
639 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
640 for usage in destructor and treatement of promotion in
641 ::ReplaceOrCreateByNumber().
642 - src/gdcmSQItem.cxx: destructor should better handle his job.
643 Test/TestWriteSimple now runs (or at least it DOES something).
644 * We can now start hutting memory links. A good starting point is:
645 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
646 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
647 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
649 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * Valgrind note: after Mathieu Malaterre teached me how to read
651 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
653 Using gcc, you can force the STL to use malloc and to free memory as
654 soon as possible by globally disabling memory caching.
655 With 3.2.2 and later, you should export the environment variable
656 GLIBCPP_FORCE_NEW before running your program.
657 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
658 simply vanish (it is still not clear to me, whether this means that
659 STL std::string leaks or if valgrind believes it leaks...).
660 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
661 running bin/gdcmTests makeDicomDir):
662 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
663 - Test/makeDicomDir.cxx now properly traps empty lists and returns
665 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
666 SegFaulting (I drowned in DicomDir related code when trying to
667 understand why the list is empty...).
668 * src/gdcmDocument.h: first BSD license header try.
669 * Doc/License.txt added.
671 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * src/gdcmDocument.[h|cxx]:
673 - Clean up of the Transfer related predicates. They are now all based
674 on new method isGivenTransferSyntax, that (should) handle properly
676 - general clean up, simplification, and coding style.
677 - Specific clean up of Parse7FE0() (umproperly named actually).
678 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
680 2004-06-14 Jean-Pierre Roux
682 - fix the display of Sequence Delimitor (SQDepthLevel pb)
683 - fix the display of SQItem ordinal number
684 - add the GetSQItemByOrdinalNumber method
685 - remove some useless never written private methods
687 2004-06-14 Jean-Pierre Roux
689 - adding a constructor taking a gdcmDocEntry as an input param
690 - ReplaceOrCreateByNumber now returns :
691 a gdcmBinEntry * if a Binary (void *) value is passed as a param
692 a gdcmValEntry * if a string value is passed as a param
694 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
695 according to the param type (no longer sets a gdcmDocEntry)
696 - GetValEntryByNumber, GetBinEntryByNumber added
697 - NewValEntryByNumber and NewBinEntryByNumber added
699 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
701 - GetSQItemNumber and SetSQItemNumber added, to provide
702 a (relative) Item identier inside a given Sequence
703 \warning : some pb remaining around this number
705 - AddEntry now takes the Item Number as a param
707 - adding a constructor taking a gdcmDocEntry as an input param
709 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * Memory leak hunt with the following command:
711 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
712 --show-reachable=yes gdcmTests PrintDocument
713 It looks like many (all?) leaks are due to the STL (or a bad usage
714 of the STL. The lines producing the leaks now have a comment with
715 a "MEMORY LEAK" tag: you can retrieve them with
716 grep "MEMORY LEAK" src/*
717 Here are two typical examples which I can't help fixing:
722 char * test = "babo";
723 name = test; //// <--- valgrind detects 960 bytes lost in
724 //// call to std::string::operator=(char const*)
725 name.clear(); //// Doesn't help !
733 std::cout << "Type a bunch of characters followed by RETURN: ";
734 getline(std::cin, line); //// <--- valgrind dectects a loss
735 //// of 1320 bytes in call to
736 /// std::basic_istream<>& std::getline<>
742 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
743 * src/gdcmHeader.[cxx|h]:
744 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
745 and related, moved away to gdcmDocument.
746 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
747 the corresponding protected accessors of inherited class
748 gdcmDocument, removed ! As a consequence gdcmFile had to be
749 declared friend of class gdcmDocument (see below).
750 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
751 - Clean up of undefined or unused methods.
752 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
753 account the changes to gdcmHeader.h).
754 * src/gdcmDocument.h:
755 - gdcmFile is now a friend class (in order to take into account the
756 changes to gdcmHeader.h).
757 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
758 (see changes to gdcmHeader.h).
759 - Accessors (reading on the form GetEntry*) are now public.
760 - Clean up of undefined or unused methods.
761 * src/gdcmDocument.cxx:
762 - adaptation to changes to gdcmDocument.h
763 - ::OpenFile now writes a verbose message when file cannot be opened.
764 - some std::string properly set to VRKey
765 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
766 references to gdcmDocument.
767 * Test/TestFindTags.cxx: changed accordingly to above changes.
768 * gdcmPython/testSuite.py: adapted to renaming of acr files in
769 cvs repository gdcmData.
771 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
773 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
774 conflicts with gdcmValEntry::voidArea.
775 * src/gdcmValEntry.cxx: unmatching comment wiped out.
776 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
777 Value representation between StringRepresentable and BinaryRepresentable.
778 * src/gdcmDocument.cxx:
779 - method ParseDES: proper indentation restored and usage of
780 gdcmVR::IsVROfGdcmStringRepresentable wired in.
781 - method LoadDocEntry: the fingerprint left in the SetValue() of
782 unloaded entries (length > MaxSizeLoadEntry) had curiously been
783 removed. Reverting to previous code segment with the proper
784 dynamic_cast< gdcmValEntry* >.
785 Note: this was (partially) breaking the python test suite
786 (gdcmPython/testSuite.py) that made usage of the above
787 fingerprint to check presence of "Pixel Data".
788 * src/gdcmDocEntry.h: coding style.
789 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
790 now taken into account.
791 * gdcmPython/gdcm.i: adaptation to the new internal representation
792 of gdcm (exit gdcmParser, hello gdcmDocument).
793 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
795 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
796 anymore, but instead prints the loaded Python dictionary.
797 * .... alas, the python testSuite is still broken.
799 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
800 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
802 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
803 * src/gdcmUtil.h : export methods
805 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
806 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
808 * Initial addition of automatic python testing
809 * Initial addition of automatic image comparison
811 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
812 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
813 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
815 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
816 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
817 * Test/ShowDicom.cxx : bug fix for msvc compilation
818 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
820 2004-05-04 Jean-Pierre Roux
821 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
822 new concepts (and new classes) :
823 a 'gdcmDocument' is composed of a set of Doc Entries, that are
824 - elementary gdcmDocEntries (former gdcmHeaderEntries)
825 - Sequence Doc Entries (gdcmSeqEntries)
826 a Sequence is composed of Items.
827 Each item is a set of Doc Entries (this is recursive)
828 The non uniqueness of the 'Dicom tag' is due to this recursivity
829 (never taken into account)
830 Our unability to add a new 'entry' in the header
831 at the proper location (neither in the H-Table (map or multimap),
832 nor in the Chained List is also due to this recursivity.
833 Don't try, right now, to use/modify/compile these new sources :
835 We just commit all the stuff, 'as is', in order not to loose it.
837 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
838 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
840 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
841 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
842 file prefix (SetFilePrefix)
844 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
845 * Add a new test: ShowDicom, for now this is just the c++ version of
846 checkRead.sh, later it will be able to compare the image read against a
848 * Replace the DEBUG on the stack with a global entry in cmake interface:
849 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
851 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
852 * Add an example subdir, with a real example on how to read + write a
855 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
857 * Doc/CMakeLists.txt: the main page is now properly differentiated
858 between the developper and user version.
859 * Doc/doxygen.config.in: dropped search related obsolete flags
860 * src/gdcmParser.h, gdcmHeader.h: doxygenation
862 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
863 * DEVELOPPER: added some helpfull comments for compile/test/install
866 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
867 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
868 src directory, now generated in the build dir.
869 2. Tests as mentionned smarter
871 4. Add a new method in gdcmDict that return the PubDict by name
872 this is interesting for 3rd party lib like ITK,
873 where we could set the institution name / patient name...
875 * ENH: 1. Now the test suite is working for real
876 2. All binaries are now output in the gdcm-bin directory
877 (this was not true before)
879 2004-04-28 Jean-Pierre Roux
880 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
881 SeQuence indented printing of Dicom Header.
882 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
883 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
884 Computation of SQDepthLevel is now part of gdcmHeader constructor
885 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
886 tree-like structure of a Dicom Header.
887 * FIX Test code cleaning
889 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
890 * ENH: Adding automatic testing
891 1. Need a DartConfig.cmake to submit to public
892 2. Add a test driver gdcmTest.cxx
893 3. gdcmTestMain, an helper for the main test driver gdcmTest
894 4. Files in Test don't have a main anymore, this becomes interesting
895 when we add more and more tests, thus dsw don't have to load
897 * ENH: Adding a GDCM_DATA_ROOT for testing
898 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
899 one file instead of seven + some small cleanup
901 2004-04-22 Jean-Pierre Roux
902 * ENH Minor changes to the Print() methods.
903 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
904 Header printing. Example given with :
905 > PrintHeader fileName 2 new
906 (SQ based tree-like structure still to be done for the Header ...)
908 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
909 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
910 1. I have added some unsigned where needed
911 2. Some function parameter not used -> (void)
912 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
913 4. g++ don't like character '\' in comment
914 5. #define jpeg_create_decompress jCreaDecompress
915 this really need to be fixed
916 6. virtualize destructor of gdcmObject ... leakage
917 7. sscanf(g->first.c_str(),"%x",&gr_bid);
918 this also really need to be fixed
919 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
920 remove compression file
921 (as we only do decompression, right ?)
922 * ENH: Change malloc/calloc/free with c++ equivalent
924 2004-04-21 Jean-Pierre Roux
925 * FIX gdcmHeaderHelper::GetXSpacing
926 when a single value is found (bug ?), xpacing is now
927 defaulted to yspacing
929 2004-04-19 Jean-Pierre Roux
930 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
931 * ENH add parameters :
932 bool exception_on_error = false,
933 bool enable_sequences = false,
934 bool ignore_shadow = false
935 to the gdcmFile constructors to be full gdcmParser compliant
936 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
937 to allow reading of PAPYRUS 3.0 files
939 2004-04-06 Jean-Pierre Roux
940 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
942 2004-04-02 Jean-Pierre Roux
943 * ADD : Test/checksequence.sh, for a general recap on SQ pb
944 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
945 for Philips spurious Tag fffe|0000 while rewritting Dicom files
947 2004-03-30 Jean-Pierre Roux
948 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
949 for ACR file, written out as DICOM files (hope so...)
951 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
952 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
953 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
954 moved to base class gdcmParser and only the specialisation is kept
956 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
957 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
958 already does the job.
959 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
960 (to be consistent with gdcmParser::WriteEntries).
962 2004-03-30 Benoit Regrain
963 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
964 upate of the object's instance. It's passed to 2 in the unfavorable
965 case : one in the ExecuteInformation, one in the ExecuteData
967 2004-03-29 Jean-Pierre Roux
968 * ENH : Check on file type to be written moved
969 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
970 * FIX : gdcmObject::ResetBoundaries now stops properly
971 when end-of-list is reached
972 : gdcmVersion modified (as Benoit Regrain asked)
974 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
976 * src/gdcmUtil.cxx: added forgotten iostream include.
977 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
978 equivalent to ExplicitVR in existing code).
980 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
981 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
982 now contains all the gdcmGlobal related code.
983 * minor coding style and doxygenation changes.
985 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
986 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
987 now contains all the Debug related code.
988 * minor clean-up of includes in src/*.cxx
989 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
990 CreateCleanString) removed.
991 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
992 * Doc/DoxyMainPageUser.txt added.
993 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
994 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
997 2004-03-24 Jean-Pierre Roux
998 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1000 2004-03-23 Jean-Pierre Roux
1001 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1002 big endian made volumes
1003 * ENH Now gdcmParser constructor and destructor are protected to forbid
1004 end user to instanciate class gdcmParser
1005 (only gdcmHeader and gdcmDicomDir are meaningfull)
1007 2004-03-22 Benoit Regrain
1008 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1009 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1010 gdcmSerie to gdcmDicomDirSerie
1012 2004-03-19 Jean-Pierre Roux
1013 * ENH Now the tree-like structure describing a DICOMDIR comming from
1014 an already existing DICOMDIR file is consistent with
1015 the home-made tree-like structure build ex-nihilo
1016 or build from the files held (recursively) in a Directory
1017 functions gdcmDicomDir::CheckBoundaries()
1018 gdcmObject::SetBoundaries() added
1020 2004-03-17 Jean-Pierre Roux
1021 * REM (Eric Boix bug) : removal of meaningless
1022 gdcmDicomDirImage::NewImage function.
1023 * FIX now file names and directory name are written properly in the
1025 * FIX now gdcmDicomDir constructor may be call without any trick
1028 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1029 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1030 of gdcmDicomDirImage::NewImage as empty function.
1032 2004-02-28 Jean-Pierre Roux
1033 * ENH add gdcmDicomDir:NewPatient
1034 add gdcmDicomDirPatient:NewStudy
1035 add gdcmDicomDirStudy:NewSerie
1036 add gdcmDicomDirSerie:NewImage
1037 to allow making gdcDicomDir object.
1038 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1039 (as opposite to the gdcmHeader chained list)
1041 2004-02-11 Benoit Regrain
1042 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1043 when using from python
1045 2004-02-10 Benoit Regrain
1046 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1047 * FIX : in gdcmDicomDir when the directory is empty
1048 * ENH : add callback and methods to get the progression of dicomDir
1051 2004-02-06 Jean-Pierre Roux
1052 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1053 - GDCM_META added to gdcmDicomDirType
1054 - class gdcmMeta created
1055 * ENH : - A brief summary is now displayed at the beginning of
1056 'testDicomDir' to help disaster magnitude estimation
1057 * REM : Now useless Test/explDICOMDIR.cxx
1059 2004-02-05 Benoit Regrain
1060 * ENH : add methods in gdcmObject to get the hash table or the list of
1062 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1063 * FIX : wrapping python for TagHeaderEntryHT
1065 2004-02-04 Benoit Regrain
1066 * FIX : even length for some strings when writting the dicom dir
1067 * FIX : sort the images in the dicom dir
1068 * FIX : Bug fix for python use of dicom dir
1069 * ADD : a python demo
1071 2004-02-04 Jean-Pierre Roux
1072 * FIX : Final solution (?) for icone embedded images
1073 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1074 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1075 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1076 gdcmData/gdcm-MR-SIEMENS-16.acr1
1077 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1078 to make full checking easier
1080 2004-02-04 Benoit Regrain
1081 * FIX : WriteEntries : coding style & logic in parameters
1082 * FIX : Set the elements to create the DicomDir in a dictionary file
1084 2004-02-03 Benoit Regrain
1085 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1086 * gdcmDicomDir : add the load of directory
1087 * Bug fix and print add-on
1089 2004-02-03 Jean-Pierre Roux
1090 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1091 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1092 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1093 * FIX gdcmParser.cxx : 'group length' elements are now considered
1094 as integers, even for shadow groups, when file is Implicit VR
1096 2004-02-02 Jean-Pierre Roux
1097 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1099 of the last synonym :-(
1100 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1102 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1103 * FIX taking into account the possible 7fe0,0010 multiplicity
1104 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1105 to allow removal of references to 7fe0,0010, to deal with
1106 ACR-NEMA images, when 0028,0200 is meaningfull
1108 2004-01-31 Jean-Pierre Roux
1109 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1110 no longer writes 'Un' on disk
1111 * FIX SQ elements with actual length are now dealt with corectly
1112 * FIX gdcmFile::WriteBase make the difference, for color images, between
1113 the length (for Palette expanded images)
1114 and Raw Length (non expanded image + Palette)
1115 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1116 (that broke Write). Replaced by UL.
1117 Aware user will reload the field if he
1118 thinks it's necesssary
1120 2004-01-30 Jean-Pierre Roux
1121 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1122 when 'dirty Acr' is found, to be compliant with the new
1123 IsReadable() methods.
1125 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1126 (no DOUBLE images in kosher DICOM,
1127 but so usefull for people that miss them ;-)
1129 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1130 DICOMDIR related utilities (not checked as Windoze compliant)
1132 2004-01-28 Jean-Pierre Roux
1133 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1135 2004-01-27 Jean-Pierre Roux
1136 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1137 to allow skipping the shadow elements, to save memory space.
1138 The TRUE value for this param has to be used
1139 with a FALSE value for the 'enable_sequence' param.
1140 ('public elements' may be embedded in 'shadow Sequences')
1141 * gdcmHeader methods now deal with 'embedded icones images' in the header
1142 (even when an 'icone image sequence' is announced by the
1143 element (0x0088,0x0200), but there is NO icone at all ...
1145 * gdcmHeader sometimes Image Location value doesn't follow
1146 the supposed processor endianity (see gdcmData/cr172241.dcm).
1149 * gdcmHeader add the method
1150 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1151 to get *all* the Header Entries with the same tag.
1152 GetHeaderEntrySameName is probabely *useless*
1153 (no meaning : Name is *not* an identifier within the Dictionnary)
1155 2004-01-26 Benoit Regrain
1156 * Bug fix in the print of hexadecimal representations. Remove long fields
1157 in the print and add a third level of print to print them
1159 2004-01-23 Benoit Regrain
1160 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1161 * Bug fix on test suite after remove the strip made on not string fields
1162 * Split the IsReadable method between gdcmParser which test that the file
1163 is dicom and gdcmHeader which test that it's an image file
1165 2004-01-22 Benoit Regrain
1166 * DicomDir : clean code, add methods, set variables in protected or private
1167 * gdcmUtil : bug fix for the clean string method
1169 2004-01-19 Benoit Regrain
1170 * Add the use of shadow dictionaries
1171 * bug fix and coding style
1173 2004-01-19 Benoit Regrain
1174 * src/gdcmFile.cxx : bug fix concerning the close of file
1175 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1176 * Add the update of header entries using the shadow library
1178 2004-01-19 Benoit Regrain
1179 * removal of file gdcmHeader2.cxx
1180 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1181 inheriting from gdcmParser. This split is to prepare the integration
1182 of dicom dir parsing
1183 * bug fix under python
1185 2004-01-16 Jean-Pierre Roux
1186 * REM removal of class gdcmHeaderEntrySet
1187 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1188 * ADD add file gdcmHeader2.cxx
1189 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1191 2004-01-15 Benoit Regrain
1192 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1193 entries created while parsing the header. Thus, they will be destroyed
1194 when the gdcmDictSet will be destroyed
1195 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1198 2004-01-15 Benoit Regrain
1199 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1200 made a fatal error because of the memory release at the end of program.
1201 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1202 some memory and vtk seems to have some problems with that.
1203 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1205 2004-01-14 Benoit Regrain
1206 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1207 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1208 * src/*.[h|cxx] : make changes due to class name changes
1209 * gdcmPython/demo/*.py : bug fix due to method names
1211 2004-01-13 Benoit Regrain
1212 * src/*.[h|cxx] : coding style
1213 * vtk/*.[h|cxx] : coding style
1215 2004-01-13 Benoit Regrain
1216 * gdcmPython/testSuite.py : test the readable flag of file for tests
1217 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1218 It's lied to the stl compilation by MSVC (windows, always windows...)
1219 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1221 2004-01-12 Benoit Regrain
1222 * src/*.h : add comments
1223 * src/gdcmDictSet.h : set the method BuildDictPath in public
1224 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1225 directly setted in the source code
1226 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1229 2004-01-09 Benoit Regrain
1230 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1231 * setup.py : use a reference to gdcmVERSION
1233 2004-01-07 Benoit Regrain
1234 * Modification to compile with the distutils.
1237 2003-12-10 Benoit Regrain
1238 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1239 can use a gdcmHeaderHelper to load datas
1240 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1241 made in the source code
1243 2003-12-10 Benoit Regrain
1244 * Update Windows projects and .cvsignore files
1246 2003-11-12 Jean-Pierre Roux
1247 * ENH gdcmHeader constructor has one more parameter (default value : false)
1248 that allows the user to 'go inside' the SeQuences only
1250 gdcmElValSet:Print takes it into account
1252 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1253 * ENH: Update gdcmPython/CMakeLists
1254 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1255 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1257 2003-11-10 Jean-Pierre Roux
1258 * FIX : gdcmHeader::LoadElements is now based
1259 on the ListTag listElem member,
1260 not longer on the TagElValueHT tagHt member
1261 * ENH : PrintPubElVal shows (temporarily) both results,
1262 with the tagHt member and the listElem member.
1263 (it's easier to 'see' the problems when using Printheader)
1265 * FIX : old private member LgrElem is now splitted into
1266 ReadLength : Length actually found on disk (updated only
1267 if bug fixing is necessary), for internal
1269 UsableLength : Updated by FixFoundLength, to fix a bug
1270 or to allow Parser going on.
1271 Will allow to re-write a kosher header when a SeQuence
1272 with a length (not 0000) is found
1273 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1274 because gdcmElValSet::Add does not update ListElem
1277 2003-11-07 Jean-Pierre Roux
1278 * FIX misstyping in Transfert Syntax name table
1279 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1280 when they have an actual length (not 0000 nor FFFFF)
1281 (Nobody should care of it, but DICOMDIR explorers)
1283 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1284 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1286 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1287 * ENH: vtkGdcmReader now supports LUT !
1288 (vtkgdcmViewer for now is not able to use them though)
1290 2003-11-05 Jean-Pierre Roux
1291 * in testSuite.py : new files names for checking the package
1292 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1293 that returns the pixel area size to the *aware* (vtk) user
1294 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1296 2003-11-05 Benoit Regrain
1297 * in testSuite.py : Modify the rules for checking the paths
1298 : Explicit error messages
1299 * in __init__.py : Related modif
1301 2003-11-03 Jean-Pierre Roux
1302 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1303 to be used by aware (vtk) users that want to manage
1304 LUT (and no to turn the PALETTE image into an RGB pixels one)
1305 * GetPixelType now returns 8U for 24 Bits images
1306 (vtkGdcmReader compliant)
1308 2003-10-31 Jean-Pierre Roux
1309 * Removal of *all* gdcmData images and add them again
1310 in order to loose the 'history' of un-anonymised images
1312 2003-10-31 Jean-Pierre Roux
1313 * RMV : removal of useless jBitsInJsample.h
1314 for both 8 and 12 Bits JPEG Lossy Libraries
1316 2003-10-31 Jean-Pierre Roux
1317 * ENH : Add the functions gdcmFile::GetImageDataRaw
1318 gdcmFile::GetImageDataIntoVectorRaw
1319 that act as GetImageData and GetImageDataIntoVector
1320 except the making of an RGB Plane from Gray Plane + LUT
1321 Intended to aware (vtk) users who know how to manage
1324 GetLUTRGBA return a R,G,B,A LUT if any
1325 lgrTotaleRaw gives the 'Raw' length
1326 GetImageDataRaw returns the gray Plane
1327 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1328 (They stay Grey, just like with other Dicom viewers :-(
1330 2003-10-30 Jean-Pierre Roux
1331 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1333 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1334 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1335 being coherents dicom files.
1337 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1338 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1340 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1341 * ENH: Two steps is necessary to please VC++ compiler...
1342 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1343 * ENH: Add include dir to medcon lib
1344 * FIX: only one function is being exported for now !
1345 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1347 2003-10-29 Jean-Pierre Roux
1348 * adding gdcmHeader::GetLUTRGBA
1349 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1350 --> Mathieu, the modif u're waiting for is not yet committed
1351 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1353 2003-10-27 Jean-Pierre Roux
1354 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1355 00191113.dcm DermaColorLossLess.dcm
1356 MxTwinLossLess.dcm RadBWLossLess.dcm
1357 * ENH: For version prior to vtkImageViewer2 -r 1.19
1358 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1360 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1361 * Removal of ido stuff in CMakeLists.txt
1363 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1364 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1365 * FIX: remove a call to ->Modified ... see comments
1366 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1368 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1369 * FIX: Problem with path for libvtkgdcmPython
1370 * ENH: Try adding a search script for python site-package
1371 * RMV: Remove some file from medcon lib that are not necessary
1372 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1373 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1374 * FIX: More pragma disable fro VC++,
1375 I don't think I break something as it is also disable in VTK/ITK.
1376 But it fasten debug compilation time.
1378 2003-10-23 Jean-Pierre Roux
1379 * gdcm now deals with 16 Bits Run Length Encoded images
1380 (they are compressed as 2 planes images,
1381 one for the high Bytes, the other for low Bytes)
1383 2003-10-22 Jean-Pierre Roux
1384 * Now CheckRead takes into account :
1385 - the bugged 'Leonardo' Siemens images
1386 - the XA images, sent thru the burning VPRO station
1387 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1390 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1391 * FIX: When copying a Makefile.am to CMakeLists.txt
1392 one should remove the '\'
1394 2003-10-22 Jean-Pierre Roux
1395 * in gdcmData adding a bugged 'Leonardo' Siemens image
1396 (wrong lengths in header)
1397 OK with gdcm, KO with the other viewers :-)
1398 * add a GE dlx XA image, thru the VEPRO burning station
1401 2003-10-21 Jean-Pierre Roux
1402 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1403 for a brutal checking of vtkgdcmViewer compliance
1405 2003-10-21 Jean-Pierre Roux
1406 * add the files for 'xmedcon' Jpeg Lossless library
1407 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1409 2003-10-21 Jean-Pierre Roux
1410 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1412 2003-10-21 Jean-Pierre Roux
1413 * garbage Siemens 'Leonardo' images dealt with
1414 (the patch is easy to remove)
1415 * cosmetic changes to avoid warnings
1417 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1418 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1419 no need to press 'r' now.
1421 2003-10-20 Jean-Pierre Roux
1422 * upgrade of checkRead.sh checkWrite.sh according
1423 to new Jpeg Lossless decompressor
1424 * add US.3405.1.dcm, a genuine RGB medical file ...
1425 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1426 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1428 2003-10-15 Jean-Pierre Roux
1429 * general anonymisation in gdcmData
1430 * adding the 'color files' from
1431 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1432 * adding some well knowed bugged-header images
1433 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1434 waiting for their inclusion in Python testsuite
1436 2003-10-15 Jean-Pierre Roux
1437 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1438 no longer seg faults when file is not found
1440 2003-10-14 Jean-Pierre Roux
1441 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1444 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1445 * TODO: *.in file to genereate a UseGDCM later
1447 2003-10-14 Jean-Pierre Roux
1448 * Some supposed-to-be Dicom Images have no preamble.
1449 OpenFile takes it into account
1450 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1451 * Missing elements added in dicomV3.dic
1452 (just to be affraid : have a look at
1453 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1454 and do it again next year ;->
1456 2003-10-13 Jean-Pierre Roux
1457 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1458 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1459 But there are NOT. It's fixed !
1461 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1462 * FIX: "jpeglib.h" was not found on VC++
1463 * FIX: vtkgdcm was not being installed
1465 2003-10-10 Jean-Pierre Roux
1466 * ENH : OpenFile closes the file if it *really* doesn't look like
1467 an ACR-NEMA / DICOM one.
1468 * FIX : testWrite no longer writes an empty file if the source file
1469 is not gdcm Readable
1470 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1473 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1474 * FIX: CMake generate now documentation
1475 * ENH: out of source doc build !
1476 * ENH: Generate both user and dev documentation
1477 * ENH: Should work on windows too
1478 * ENH: Only one doxygen config.in file is needed
1479 * FIX: make install should be ok now on ùnix plateform
1480 * FIX: PATH to dictionary was wrong (missing /)
1481 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1483 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1484 * vtkGdcmReader is now able to read rgb dicom file.
1485 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1486 * added a gdcmViewer to vtk test, use mouse to control
1487 window level & window width
1489 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1490 * CMake-ification of gdcm, we have now two build system
1491 * FIX: on cygwin Wsock32 doesn't exist
1492 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1494 2003-10-06 Emanuel Ollart
1495 * FIX : compilation process wad broken.
1496 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1498 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1499 * change gdcmViewer -> vtkgdcmViewer
1500 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1502 2003-10-06 Jean-Pierre Roux
1503 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1504 ( e.g : well known GE images with a wrong elem length,
1505 : Philips MRI Images with a wrong Huffman table)
1506 * still to be done : allow the reading of bugged LEONARDO Siemens images
1508 2003-10-03 Jean-Pierre Roux
1509 * Odd length strings are padded with '\0' (not with spaces,
1510 to remain compliant with already defined strings,
1511 like Transfert Syntax UID and others)
1513 2003-10-03 Jean-Pierre Roux
1514 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1515 to allow displaying RGB images (not only by affim ;-)
1517 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1518 * vtkGdcmReader is now able to read rgb dicom file.
1519 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1521 2003-10-03 Jean-Pierre Roux
1522 * A few nasty patches to allow the reading of a lot of nasty images
1523 ( e.g : well known GE images with a wrong elem length,
1524 : Philips MRI Images with a wrong Huffman table)
1525 * still to be done : allow the reading of bugged LEONARDO Siemens images
1527 2003-10-03 Jean-Pierre Roux
1528 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1530 2003-10-03 Jean-Pierre Roux
1531 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1532 to allow displaying RGB images (not only by affim ;-)
1534 2003-10-03 Jean-Pierre Roux
1535 * gdcmFile::GetImageDataIntoVector now
1536 - deals with MultiFrames MultiFragments Run Length Encoded files
1537 - deals with YcBcR (YBR_FULL) files
1538 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1539 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1541 (no sample found :-(
1543 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1544 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1545 Two reasons: - clear things
1546 - third parties acces gdcm through header files, so won't
1547 suffer anymore VC++ complains
1549 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1550 * add argv[1] in testvtkGdcmReader.cxx
1553 2003-09-24 Jean-Pierre Roux
1554 * The lines are now eigthy characters long.for
1555 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1557 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1558 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1559 char* to std::string. Thus, the use of strdup becomes useless. (see
1560 previous commis of Malaterre)
1561 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1562 before the last Malaterre's commit.
1564 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1565 * This commit should fix the Debug building under VC++, the problem
1566 was mainly a mixture of debug and release lib being loaded at startup.
1567 * I also remove a depency to a specific C function: strdup. Because I had
1568 to force the link to msvcrtd (whereas strdup is in libc).
1570 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1571 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1572 located in the gdcmCommon.h file. All use of reference of tha has been
1573 changed to now use the variable GDCM_UNFOUND.
1575 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1577 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1578 Dicom dictionary. The test suite can now be run again. Note:
1579 I'm note very happy with the " (RET)" changes. I believe this
1580 RETAINED comment should be dropped when parsing the dictionary.
1581 - PACKAGER corrected
1583 - AUTHORS updated and now in alphabetical order
1584 * Makefile.am now exports gdcm.dsw for Windoze users.
1586 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1587 * cygwin complains about missing std:: in subdir Test/
1589 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1590 * remove some methods that are now in gdcmHeaderHelper
1592 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1593 * vtkGdcmReader set spacing and origin correctly
1595 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1596 * Fix a few delete/delete[] mismatch
1598 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1599 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1600 interpretation to data given by gdcmHeader. For instance there are
1601 heuristics to get informations (look at different places).
1602 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1603 sorting DICOM images based on different strategies.
1604 * modified Makefiles accordingly.
1606 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1607 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1608 when building in debug mode
1609 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1610 src/win32/gdcmdll.dsp
1611 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1613 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1614 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1617 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1618 * src/win32/libgdcmjpeg12.dsp was not dos format
1619 * src/win32/libgdcmjpeg12.dsp :
1620 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1621 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1623 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1624 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1626 * src/gdcmFile.cxx : bug fix in affectation type
1627 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1628 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1629 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1630 symbols... future problem ?
1632 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1633 * src/win32/libgdcmijpeg12.dsp was missing
1634 * modified gdcm.dsw accordingly
1636 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1637 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1639 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1640 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1641 commit of JPR (before his hollidays to facilitate our work).
1642 * setup.py : bug fix in code. Modifications made while the last commit
1643 of JPR. The code hasn't been tested before the commit... it's so
1644 useless to make that (for best programmer that is JPR) !!!
1646 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1647 * tagged the current version as Version0_3 (i.e. version 0.3)
1649 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1650 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1651 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1652 * *.dsp : modifications to use new libgdcmijpeg8 library
1653 * setup.py : bug fix on VTKPATH variable
1654 * PACKAGER : adding all concerning windows
1656 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1659 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1660 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1661 test suite reported error.
1662 * PACKAGER file added (describes what a packager must do when
1663 packaging a new release).
1664 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1665 * configure.in: upgraded version number to 0.3.0
1666 * fixing build of rpm (through rpm -ta):
1667 - Doc/Makefile.am exports proper doxygen files
1668 - src/jpeg/libijg8/Makefile.am exports the include files.
1670 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1671 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1672 * src/gdcmHeader.h : formatting code
1674 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1675 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1676 We were obtaining error message from vtk. Now, creation of file list
1677 is made in an internal list to prevent this problem.
1678 Bug fix when output is empty.
1679 Bug fix in update of progress value. Previous commit for this was a bad
1681 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1683 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1684 * src/gdcmHeader.h : added method to get the file name
1685 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1686 files. Added method to remove all files on the input
1687 Added FIXME comment concerning the bad parsing of header made by
1688 ExecuteInformation method (in ExecuteData method)
1690 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1691 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1692 when using make instal.
1693 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1694 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1696 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1697 * setup.py : adding include dir of jpeg lib to compile all sources
1698 * */Win32/*.dsp : JPR fix for windows compilation
1700 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1701 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1703 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1704 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1706 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1707 * setup.py is again effective on un*x (takes into account the
1708 addon of the jpeg library)
1709 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1710 * Doc/Doxy* updated (includes above enhancements)
1711 * INSTALL now points to web documentation
1713 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1714 * src/gdcmHeader.h doesn't make unnecessary reference to
1716 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1718 * src/gdcm*.[cxx|h] :
1719 - to allow compilation with gcc 3.x
1720 -- clean up of STL usage (added explicit usage of std::)
1721 -- small fixes on exceptions.
1722 Note: linking not tested !
1723 - clean of doxygen comments to avoid warnings at documentation
1725 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1726 dependent convertion).
1728 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * Clean up of previous JPR garbage commit (not even commented in the
1731 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1732 - moved all jpeg related files from src to src/jpeg/libijg8, with
1733 addition/modification of Makefile.am and configure.in.
1734 - the testSuite is still brain damage (not guilty).
1736 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1737 * WrapVTK.py : modifications to get correctly vtk source files to
1739 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1740 (FileName -> Filename)
1742 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1743 * vtk/vtkGdcmReader.[cxx/h]:
1744 - UpdateProgress method should now be effective
1745 - removed the limitation on having only images loaded (as opposed
1747 - when building a stack of images/volume, a lesser number of
1748 gdcmHeader and gdcmFile instances should be used (hopefully
1749 accelerating things).
1750 - when building a stack of images/volumes, files which are not
1751 loadable (wrong path-filename, wrong permissions on existing file,
1752 or file not parsable by gdcm) are replaced with a black image
1753 in the stack (for the caller to notice the problem).
1755 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1756 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1758 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1759 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1760 between standard library (std) and vtk library (problems are found
1761 under Windows... thanks Windows !)
1763 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1764 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1766 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1768 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1769 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1771 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1772 * When compiling with distutils (see setup.py) the C++ compiler is
1773 called with different flags than the default ones (with automake).
1774 In order to fix all those warning, I compiled gdcm with the command
1775 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1776 and went for warning fixes:
1777 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1778 up from unused variables.
1779 - vtk/vtkGdcmReader.cxx: potential bug fix.
1780 * src/gdcmHeader.h: Doxygen warning cleanup
1782 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1783 * gdcmPython/gdcm.i:
1784 - typemaps correction to take into account the systematic replacement
1785 of "using namespace std" with std:: prefix e.g. std::list,
1786 std::string... (cf changes of 2003-05-21).
1787 - gdcmGlob global variable of type gdcmGlobal (defined in
1788 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1789 exported to Python a as cvar.
1790 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1791 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1792 gdcmDictSet.GetPubDictTagNames() and
1793 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1794 C++ static methods).
1795 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1796 with the above changes.
1798 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1799 * setup.py, manifest.in : bug fix under linux
1801 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1802 * Modification of setup.py to compile vtk part too. Then, we have 2
1803 wrappers which must work with same distutils. For that, we have a
1804 generic distutils in distusiltsWrapping.py ; with :
1805 - build_extWrap class to wrap generically all extensions,
1806 - ExtensionWrap base class for all wrapping extension that contains
1808 - Wrapper interface which wrap sources
1809 + In WrapSwig.py we have extension and wrapper for Swig
1810 + In WrapVTK.py we have extension and wrapper for VTK
1811 * MANIFEST.in : modifications to consider vtk directory and new python
1812 files for compilation
1814 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1815 * Added python wrappers of vtkGdcmReader vtk class (see the
1816 source in vtk/vtkGdcmReader.cxx) :
1817 - vtk/Makefile.am now builds a library
1818 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1819 python library (as opposed to _gdcm.so wich are the python
1820 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1821 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1823 - configure.in has an additional flag --enable-vtk that needs
1824 to be set to enable compilation of vtk related code, that is:
1825 + vtk/vtkGdcmReader.so and
1826 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1827 + gdcmPython/vtkgdcmPython.so (see above)
1828 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1829 be read when compressed or when HighBit + 1 != BitsStored),
1830 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1831 the usage of the python wrapper of vtkGdcmReader vtk class.
1832 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1833 * src/*.[h] all occurences of stl classes are now prefixed with
1834 std::, and all occurences of "using namespace std;" where removed.
1835 This is to avoid pollution of global namespace in included files.
1836 Apparently vtk does not avoid this pitfall: when using both
1837 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1838 collision of various stl members (principally cout...).
1839 * gdcmPython/testSuite.py now cleanly removes temprory generated
1841 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1842 comply with above changes)
1844 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1845 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1846 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1847 vtk data structure (an image Flip was required).
1848 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1849 * cosmetic changes in documentation.
1851 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1852 * src/gdcmHeader.cxx: the constructor no longer exits when an
1853 unexisting file is given as argument.
1854 * The subdirectory Data (containing all the images used for the
1855 test suite) is not part of this repository anymore. A new module
1856 containing those images is now available at
1857 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1858 with the name gdcmData.
1859 All the python scripts (including the package initialisation file
1860 gdcmPython/__init__.py) were adapated to take this change into
1861 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1863 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1864 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1865 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1866 demo of the usage of this class.
1867 Compilation of this vtk part is only done when using the --enable-vtk
1868 at configure (or autogen.sh) stage.
1870 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1871 * More memory link related corrections and documentation fixes.
1873 - maximum info is obtained with a command of the form:
1874 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1875 --show-reachable=yes PrintHeader
1876 - the remaining reachable blocks seem to come from the STL
1877 allocation scheme through the usage of map and list. It looks
1878 like this memory cannot be freed but it is not a memory leak
1879 (in fact further invocation to the STL would recollect the
1880 unused memory allthough it cannot explicitely be freed).
1881 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1882 of displaying an image parsed with gdcm and displayed with VTK.
1883 Note: some images don't seem to work e.g.
1884 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1885 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1886 Allthough this weakens the semantics, it is a ditch attempt to
1887 make gdcm more thread friendly.
1889 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1890 * Memory link hunt (by using valgrind through the command
1891 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1892 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1893 gdcmHeader::_dicom_vr.
1894 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1895 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1897 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1899 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1900 * src/Makefile.am now exports all the necessary include files at
1904 * UpdateGroupLength replaced by new one
1907 * UpdateGroupLength re-written using H-Table
1908 (named UpdateGroupLengthNew untill checks are over)
1910 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1911 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1912 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1914 - gdcmHeader::GetPubElValSet removed.
1915 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1916 UpdateGroupLength, WriteElements, Write.
1917 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1918 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1919 carried the same semantics.
1920 - src/gdcmHeaderIdo.cxx changed accordingly.
1921 - gdcmFile::WriteBase now regroups all the codes from previous
1922 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1923 - enum FileType moved to gdcmCommon.h
1924 * src/gdcmHeader.cxx AddDefault trashed
1925 * gdcmGetXSize added
1926 * getimageDataSize now calls gdcmGetXSize
1927 * Test/*.cxx changed to agree with above changes
1929 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1930 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1931 (to avoid double call by end user).
1932 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1933 by end user, since gdcmHeader::gdcmHeader now handles it.
1935 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * gdcm/Doc many doxygen changes:
1937 - Doxyfile now has two different versions, DoxyfileUsers that generates
1938 the html.users end users oriented documentation and
1939 DoxyfileDeveloppers that generates the html.developper developper
1940 oriented documentation.
1941 - README changed accordingly
1942 - requirement.txt removed (old design info moved to TODO).
1943 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1944 DoxyMainPage.txt, DoxyPython.txt provide more information.
1945 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1946 be updated by simply regenerating the docs with doxygen and copying
1947 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1948 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1949 all the tests in the form "if (<map>.count() >1)" were removed.
1950 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1951 ill-formed documentation sections.
1952 * src/gdcmHeader.cxx: ditto
1954 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * setup.py fixed for un*x (needed macro for stdint.h)
1956 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1957 un*ces with sh-utils test utility.
1958 * gdcmPython/demo/test.py renamed to PrintHeader.py
1959 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1960 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1961 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1962 * src/gdcm*.cxx JPR's bad inclusion fixed.
1964 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1965 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1966 * gdcmPython/demo/test.py changed accordingly.
1968 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * gdcmPython/Makefile.am fixed linking against libstdc++
1970 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1971 * Swig subdir (historical tests of swig version 1.3.17++) removed
1972 * Test/testChangeEntete.cxx some lines commented out in order to make
1974 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1975 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1977 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1979 hence the user doesn't need this explicit call.
1980 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1981 i.e. LoadElements() call removed.
1982 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1983 - src/Makefile.am declares the proper flag for g++.
1984 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1985 for adding user defined new tags.
1986 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1987 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1988 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1990 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1991 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1992 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1993 src/Makefile.am : the project should properly compile and install
1994 with the autotools, included the python wrappers part.
1995 * gdcm.spec.in : added a spec file for RPM packaging.
1997 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1998 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2000 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2001 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2002 to exported to the environement (see gdcmPython/testSuite.py
2004 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2005 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2006 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2007 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2008 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2010 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2011 * gdcmPython/__init__.py doesn't crash anymore when running in
2012 in InstallMode or PreInstallMode but with an environement given
2013 value of GDCM_DICT_PATH.
2014 * src/gdcmDictSet.[cxx/h] coding style.
2016 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2017 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2018 * src/gdcm.h general comments moved to TODO, and README
2019 * src/gdcm.h should now be seen as a user commodity (including it
2020 should suffice to fully use gdcm). It is nowhere including within
2021 any of the kernel files src/*.cxx and src/*.h.
2023 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2024 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2025 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2027 * src/gdcm*.cxx only include their corresponding include file
2028 (as opposed to gdcm.h)
2029 * gdcmPython/gdcm.i changed accordingly
2030 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2031 the autogen.sh generated "make snapshot" command to work.
2032 * autogen.sh removed history related references to crea package.
2034 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * distutilsSwigCPlusPlus.py work around some swig portability
2038 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2040 was done in a last ditch attempt to get setup.py _really_
2041 operationnal. The python/gdcmPython layaout add the advantage
2042 of hidding away the python related distutils specific files
2043 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2044 Alas, the src directory was out of scope (i.e. it's relative
2045 position to setup.py was ../src) which made things impossible to
2046 handle (see previous version of python/setup.py). Crossing fingers...
2048 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2049 * python/setup.py now works on Un*x. (harder than I thougth)
2050 * python/distutilsSwigCPlusPlus.py can now have include files
2051 among the list of sources.
2053 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2054 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2055 * modifications in MSVC projects
2057 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * As stated by the first lines of Test/ExceptionAndPython/README, it
2059 looks like we can move back to original usage of exception within
2060 src/gdcm* and hence remove the errno stuff that was introduced
2061 as a quick and dirty fixture of this problem (added to the TODO).
2062 * Doc/Doxyfile configuration file for Doxygen and corresponding
2063 README file for usage added.
2064 * Test/testWrite.cxx added. This new test comes from a split of
2065 test.cxx that is now reverted to its original purpous i.e.
2066 testing the proper parsing of a Dicom related file.
2067 testWrite.cxx concentrates on testing the IO part of gdcm.
2068 * Test/bug1.cxx (containing a bug on WIn32) added.
2069 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2070 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2071 whose purpose is to publish the content of the TagNames of the
2072 Dicom public dictionnary were not accessible without an
2073 instance of class gdcmHeader.
2074 - those methods are now static methods of gdcmDictSet and hence
2075 require no instances at all to be invocated.
2076 - within gdcmDictSet this change required to change some method
2077 to class methods (i.e. are now static) among which SetDictPath
2078 (renamed to BuildDictPath) and LoadDefaultPubDict.
2079 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2080 the above changes by calling the new method classes of gdcmDictSet.
2081 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2082 the above to be effective.
2083 * python/gdcmPython: in order to wrap properly the above changes
2084 for Python, swig version now needs to be > 1.3.17.
2085 * python/gdcmPython/Makefile fixed to adapt itself to new
2086 configure/make shema introduced by Johan Montagnat (thanks for the
2087 contribution). Alas this Makefile cannot be turned into a proper
2088 Makefile.am without some heavy changes in the configure.in
2089 (for python dectection).
2090 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2091 now avoids publishing the empty entries.
2093 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2094 * python/setup.py : bug fix concerning install under windows
2095 ExtraPath reused :-P
2096 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2098 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2099 * Dicts/dicomV3.dic : remove double spaces !!!
2100 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2101 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2104 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2105 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2106 method. Doxygenation.
2107 * src/gdcm.h clean up of JPR spurious comments.
2109 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2110 * python/distutilsSwigCPlusPlus.py now properly collects the
2111 shadow classes generated by "swig -c++" (gdcm.py in our case)
2112 when using "python setup.py install".
2113 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2114 reexports the working classes.
2115 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2116 by the classical C errno scheme. This is to prevent an obscure
2117 behavior of the python wrappers when importing wxPython.wx prior
2118 to gdcmPython (which ended up in an abort call). An illustration
2119 of this oddity can be found in the Test/ExceptionAndPython
2120 subdir (see the README file). This problem probably due to
2121 an combination of g++ and dynamic loading.
2122 * added Test/ExceptionAndPython (see above)
2124 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * Changed the layout of the python part to avoid bloating main
2126 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2127 i.e. the distutils arsenal. All the python related stuff is
2128 again in a python subdir, but the package itself is now in
2130 * setup.py was cleaned up:
2131 - pythonIncludePath removed
2132 - python setup.py bdist target is now functional.
2133 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2134 collision with other packages). gdcmPython/demo/*.py changed
2137 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * python subdir moved to gdcmPython (preparation of distutils packaging).
2139 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2140 distutils installer is operational.
2141 * - gdcmPython/__init__.py now properly loads the swig generated
2142 shadow classes (from gdcm.py).
2143 - gdcmPython/demo/*.py changed to import the package gdcmPython
2144 instead of gdcmPython/demo/load.py.
2145 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2147 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2149 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2150 entries within the associated public Dicom dictionary resp. the same
2151 information but sorted by the fourth field (PAT, IMG, DIR) of the
2153 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2154 are now in the "???" group.
2155 - python/gdcm.i changed accordingly,
2156 - python/demo/printGroupedPublicDict.py added, that gives an example
2157 of the above new functionalities in Python.
2159 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2160 * src/gdcm.h, gdcmHeader.cxx:
2161 - historic references to glib's g_malloc and g_free (#defined)
2162 were definitively removed.
2163 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2164 * src/gdcmElValSet.cxx:
2165 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2166 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2167 - GetElValue(string) renamed to GetElValueByName.
2168 - Added GetElementByName(string).
2169 * src/gdcmHeader.cxx: added
2170 - GetPubElValRepByNumber(guint16, guint16)
2171 - GetPubElValRepByName(string)
2172 - GetShaElValRepByNumber(guint16, guint16)
2173 - GetShaElValRepByName(string)
2174 - GetShaElValByNumber(guint16, guint16)
2175 - GetShaElValRepByName(string)
2176 - GetElValRepByNumber(guint16, guint16)
2177 - GetElValRepByName(string)
2178 - GetElValByNumber(guint16, guint16)
2179 - GetElValRepByName(string)
2180 * Doc/requirements.txt added.
2182 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * Test/Makefile building now depends on the one of libgdcm.so
2184 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2185 pixel data) aware which enables finding the address (offset) of
2186 the pixel data of JPEG encoded DICOM files. This leaves only a single
2187 file in the testSuite whose pixel data address (offset) is unknown.
2188 * python/testSuite.py changed accordingly.
2190 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2191 * VC++ has some strong limitations when working with the STL, as stated
2192 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2193 "Also note that some STL containers (map, set, queue, list, deque)
2194 cannot be exported. [...]
2195 Some STL classes contain nested classes. These classes can not
2197 This is caused by a designed limitation that once a template
2198 class is instantiated, it can not be re-instantiated and
2200 Since our usage of map<> is ubiquitous in gdcm, this "designed
2201 limitation" of VC++ is a pitfall.
2202 Hence the Python wrappers of gdcm cannot be incrementally linked
2203 against the c++ dynamic library. The dirty but only workaround is
2204 to forget about incremental link of dynamic libraries and to generate
2205 the Python wrappers library with the inclusions of the underlying C++
2207 The following modifications concern this matter on Win32/VC++:
2208 - wrapping python correct with standalone wrapped dll (don't use separate
2209 dll under windows !!!!)
2210 - python21_d debug mode enabled (ask Frog how to use it :-)
2211 - NO problem with having an STL member of class for example string in C++
2212 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2213 - Python test of dcmlib in Python is ok under windows on a large set
2215 * removed glib references
2216 * typedef's inserted in gdcm.i for correct swig type management
2218 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * python/demo/*.py load.py extracted from test.py. Added explore.py
2220 that only displays required tags and testAll.py that parses all
2221 the files of the testsuite without using unittest.
2222 * python/testSuite.py other additional test on new files added.
2223 * Data/* new test files added accordingly to the testSuite.
2224 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2225 the vr in the file differs from the one of the dictionary.
2227 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2228 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2229 values, but limits itself to values which are below a user specified
2230 size (by default 1024 bytes).
2231 * python/gdcm.i : elements not loaded (because their size is above the
2232 user specified treshold) are exported with their TagKey as key of the
2233 python dictionary. This enables the testsuite to make some checks
2234 on the unloaded elements (since we have their offset and size).
2235 * python/testSuite.py
2236 - now tests for the existence and proper value of the pixel data
2237 - two new examples added.
2238 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2240 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2241 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2242 aware. See the strategy comments in gdcmHeader::FindeLength().
2243 * Test/test.cxx now accepts a filename as first argument.
2244 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2245 * python/testSuite.py changed to integrate test on above files.
2247 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2248 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2249 the vr was also RET.
2250 * python/testSuite.py more tests added.
2252 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2253 * python/testSuite.py unittest test suite added (uses Data)
2254 * Data/* dcm and acr files for the test suite.
2255 * glib dependance removed from un*x version. We now use ISO C99
2256 7.18 Integer types (see stdint.h)
2257 - python/Makefile, src/Makefile src/gdcm.h
2258 * src/ when an explicit vr (like dicom files) suddenly poped an
2259 implicit element we use to mark the underlying DictEntry of the
2260 concerned ElValue with "Implicit". This strategy was damageable
2261 too the public or provite dictionaries, since some of their vr
2262 would be changed. Since Header::FindLength heavily relies on the
2263 detection by Header::FindVR of falsely explicit elements, I
2264 added an extra ImplicitVr member to ElValue (boolean).
2265 The rest of the changes we the necessary adaptations.
2267 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2268 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2270 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2272 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2273 * Adaptation for porting to VC++:
2275 o forced to use std namespace (for string to be known)
2276 o all class use __declspec export style on WIN32
2277 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2278 (in stdlib.h on Win32 but in std:: for gcc)
2279 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2280 variable GDCM_DICT_PATH.
2281 * src/gdcmHeader.cxx verbose comments made discrete.
2283 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2284 * python/gdcm.i: added a typemap that converts a C++ hashing table
2285 to native Python dictionary.
2286 * python/demo/test.py:
2287 - now uses the native dictionary for exploration of gdcmHeader.
2288 - takes an optional filename argument (the file to parse).
2289 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2290 PubElVals hashing table.
2291 * Dicts/dicomV3.dic removed error prone trailing spaces.
2293 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2294 * Python wrapping process moved away from src/Makefile to
2295 newly created python/Makefile (as well as gdcm.i)
2296 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2297 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2298 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2299 from the environement variable GDCM_DICT_PATH (when existing).
2300 * src/gdcmDict::GetTag bug fix.
2302 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * Straightforward temporary fixes for swig to build the python wrappers.
2304 src/Makefile now has a python working entry [by working we mean
2305 that we can import de shadow classes without errors].
2307 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2308 * hashtest.cxx removed (since allready in Test)
2309 * src/gdcmlib.h renamed to src/gdcm.h
2310 * src/dcm.i renamed to src/gdcm.i
2311 * src/Makefile prepared for python wrapping
2313 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2314 * src/gdcmHeader.cxx :
2315 - Parsing of header is now separated from loading of element values
2316 (see gdcmHeader::LoadElements).
2317 - general clean up of hopefully all file access (creation of
2318 ReadInt16 and ReadInt32)
2320 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2321 * src/gdcmHeader.cxx :
2322 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2324 - SetLgrElem renamed to SetLength
2325 - GetLgrElem renamed to GetLength
2326 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2327 * src/gdcmElValSet.cxx fixed both GetElValue methods
2328 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2329 due to IdoDude was cleaned out.
2331 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2332 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2333 concentrates on finding the value representation (when it exists).
2334 RecupLgr now only finds the element value length, and it avoids
2335 returning the unecessary skL (skipped length).
2336 Also, offsetCourant was simply removed (with taille_fich) since
2337 it was redundant with the File position internals (by using
2338 ftell and fseek). This also made skL (see above in RecupLgr) usage
2340 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2341 on the libido specificities which are handled through class
2343 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2346 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * Truckload of changes. Parsing of header is barely functional
2348 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2350 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * src/gdcmHeader.cxx many addons of low level methods
2353 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2354 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2355 and _IdDcmSWAP_LONG.
2357 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2358 * This corresponds to all the changes decided at the meeting of
2359 May 23 2002. Needless to say we are running late...