1 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
2 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
3 JPEG decompression, especially when dicom frames are split into several
4 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
5 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
7 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * src/gdcmHeader.cxx : change the initialisation of default header.
9 Now, this header is readable by gdm, e-film, DicomWorks
11 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
13 Rename Decompressed to Raw
14 * Use the API changes in gdcm::File.
15 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
18 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
20 each added entry in the header. Replace the 'Planes' field by the 'Number
23 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
25 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
27 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
29 At this time, this image isn't readable by e-film... waiting JPR help to
32 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
34 DocEntry. Now use methods of the Document !
36 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Test/ShowDicomSeq.cxx : bug fix
39 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
41 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
42 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
43 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
45 * Test/TestCopyRescaleDicom.cxx : remove unused variable
46 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
47 containing found sequences
49 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
52 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
53 Some fields in BinEntry must be copied to not seg fault when making the :
54 gdcm::File *copy = new gdcm::File( copyH );
55 and tests are now made on good variables
57 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
59 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
61 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
62 * Add vtkGdcmWriter example and test
64 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Test/TestUtil.cxx : reformat the source code
66 * vtk/vtkGdcmReader.cxx : remove and change prints
67 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
69 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
70 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
72 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
74 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
76 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
78 by an eof to prevent all bad read of the file... and in this case, the
81 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * Example/Volume2Dicom.cxx : comment unused variables
83 * Test/PrintDicomDir.cxx : comment unused variables
84 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
85 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
86 method that is redondant with AddEntry.
87 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
90 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * Bug fix due my last commit (compilation under Windows).
92 * Example/Volume2Dicom : bug fix in the file and reformatting source code
93 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
95 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
97 - Remove printf / sprintf
98 - include iostream AFTER gdcm so we don't get warnings
99 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
101 - Also remove tons of include from header files, hopefully this should
102 speeup the compilation time, since it was becoming a dog slow.
103 - Remove gdcm.h as it include way too many files and slow down compilation
104 (plus it is not up to date)
105 - remove 'using namespace std' this is BAD !
107 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * Remove memory leaks on the DicomDir
109 * Remove some useless datas in DicomDirObject
110 * Add usefull methods in SQItem, to be complient withe the ElementSet
112 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
115 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
117 future, with convertion)
118 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
119 and ImageDataSize values. Remove the method to get the PixelReadConverter
120 from the output of the class
122 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
125 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
127 and vtkErrorMacro use.
128 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
130 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
133 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
134 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
135 The string leaves only in the fonction. So when we make a .c_str(), we
136 get the pointeur on the first element, element that will be destroyed
137 immediately after thee instruction.
138 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
139 file has been opened : the test must be made on the content of the
140 pointer and not directly on the pointer !
143 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
145 the python part recompiles
147 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
149 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
150 X session is killed (for my computer... it seems to not be identic on
153 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
155 avoid problems (otherwise, the difference test between the visible image
156 and the reference is incorrect. If the reference is greater than the
157 screen resolution, it's produce errors).
158 Can be used for only one image. Can be used with a visible flag.
159 * vtk/vtkGdcmReader.cxx : remove commented codes.
160 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
161 under windows at compilation
162 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
164 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
166 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
168 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
169 tests on the image size X, Y, Z
171 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
173 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
174 between the class name and the file name
176 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/ : fix compilation warnings for the Write method (2 different
178 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
179 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
180 variable... create a static method in gdcm::Document to access to
181 this variable content.
183 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
185 file, to be accessed by other files (like gdcmFile). Remove commented
186 code. Move the change of the header to the gdcmFile, using the
188 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
189 To be sure of that (and simplify calls), the Write of the header now
190 gets a file name and not a file pointer (std::ifstream).
191 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
192 DocEntryArchive. Remove all open of the written file
194 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
197 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
199 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
201 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
202 some corresponding methods. Write correctly the file and check before
204 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
205 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
206 is now on RGB datas (as before my last commit
207 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
209 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
211 Add a print information of the type of the entry
212 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
213 It was in the gdcmFile, and all write have been regrouped
214 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
215 Write correctly all dicom files (in decompressed mode only at this time)
216 * Test/ : test on files are now made using Raw datas and not color datas if
218 * Example/PrintFile.cxx : add more printings
220 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * Amelioration of code, remove some code copy. For the loading of
222 BinEntry (in gdcmDocument), add the test to verify if the file is already
225 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
227 remove a DocEntry in the header (push an empty DocEntry)
228 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
229 lines. Bug fix in the initialization of the PixelConvert and the
231 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
232 use in TestCopyDicom (now this test can run under windows... but fails)
233 * Test/TestCopyDicom.cxx : amelioration of the test :
234 - test the pixels written
235 - add test points to quickly find where is the error
236 - can set a file name input and output in arguments
237 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
238 amelioration of the test output
240 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
242 all replaced DocEntry's
243 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
244 Now, each needed DocEntry to modify is duplicated, modified and inserted
245 to the header using DocEntryArchive. Thus, after save, we can restore the
246 header initial state.
248 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
251 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
253 correct to copy it. The DictEntry is specified at the DocEntry creation,
254 then, it musn't change in the time.
255 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
256 header correctly. At this time, the change is only made for the first
257 level of the Document. In the future, it might consider sequences.
258 The change is made by replacing a DocEntry by an other that is created
259 outside the class. The old value is kept. When we restore the header
260 status, the added DocEntry is deleted and replaced by the old value.
261 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
262 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
263 set the write type to explicit VR, implicit VR or ACR. Add methods to set
264 the write mode to native, decompressed or RGB (but not used at this time)
266 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
268 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
270 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
272 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
274 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
275 set because already copied when copying the BinEntry's of the header
276 * Test/TestAllReadCompareDicom.cxx : remove warnings
278 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
280 Two problems appear when doing it :
281 - with the gdcmFile : when the GetImageData method is called, the pixels
282 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
283 datas (pixels). And each structure destruct the datas when it's
284 destructed. So we have two destructions for the same datas. To solve it,
285 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
286 datas or not. If it doesn't own datas, then they will not destroyed by
288 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
289 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
290 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
291 create a double destruction of the same DocEntry's. So, to solve it,
292 the TagHT is simply cleared and the DicomDir* elements are destroyed.
293 * TODO : add an entry concerning memory leaks in the DicomDir
295 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
296 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
297 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
300 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
301 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
302 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
303 after it have been deleted
305 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * FIX: src/* fix the doxygen warnings.
307 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
308 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
309 was erroneously defined with a size of 15 instead of 16. [many thanks
310 to Jean Michel Rouet for pointing out this bug].
312 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
313 1. Finish merging JMR patch for writting DICOM from scratch
314 2. Fix -hopefully- bug with MONOCHROME and space vs null character
315 3. Use const ref when possible
316 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
317 5. A few more comments
318 6. CreateUniqueUID can now be called without parameter"
320 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 * ENH: Slightly bigger patch:
322 1. Getting toward full integration of JMR patch for writting dicom from scratch
323 2. Update Test to test part of this patch: CreateUniqueUID
324 3. File was not close properly in gdcmDict
325 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
326 5. Use of const ref instead of copy (speed issue)
327 6. Remove temporary (duplicate) string in TranslateToKey
328 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
329 8. Do not repeat virtual in subclasses
330 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
332 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
333 * Apply first patch toward better string comparison when dealing with broken
334 DICOM files. Essentially the string could be padded with a space instead
335 of a null character as defined by standard
337 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
339 because never used... and in the same time, that's remove some memory leaks
341 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * src/gdcmFile.cxx : now delete the PixelConvert instance.
343 * In examples and tests : change the type of image data variables from void*
344 to uint8_t*. Remmove all delete on image data variables
346 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
347 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
348 Verify the file pointer value before open the file, and if it's not null,
349 a verbose message is generated.
350 Close correctly the file when the file isn't considered dicom-like. The
351 correctly close is a call to CloseFile.
352 When closing the file pointer, test if its not null to close the file.
353 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
354 file. For an uncompressed image, the copied datas correspond in the least
355 case to the image size (calculated) or the image size specified in the
356 header. A verbose is generated if these two size mismatch
358 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
359 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
360 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
361 break under windows (with msvc6 compilation).
363 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
364 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
365 compiling with MSVC6)
367 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * Bugs fix for the Windows build with VC6
369 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
370 needed (only for projects required VTK). If the VTK is included in all
371 projects, there is conflicts with the jpeg lib of vtk when compiling the
372 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
373 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
374 when compiling the gdcm_wrap.cxx file (created by the compilation of the
376 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
377 (like it's already made for the cout use). Otherwise, conflict with the
380 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
381 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
383 - comments on the DicomDir::Method related usage added.
384 - now that we use the namespace gdcm, a lot of internal classes do
385 NOT need to be wrapped anymore.
386 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
387 DicomDir::Method) new example added.
389 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
390 * Improve string manipulation. I now inforce the notion of 'DicomString'
391 A DicomString can contain as many \0 as they want
392 and it is *always* of even length.
393 We only support odd length for very rare case.
394 And in the near future this should be removed.
396 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
397 * /binary_write/ gdcm source. Now even on big endian we are writting
398 little endian. This should -heopfully- fix some tests
400 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
401 * Now the dictionary is compiled into gdcm lib. This is a default
402 behavior, thus any dic file specified is picked before failback to
403 the one comiled into lib
405 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
406 * Change internals for gdcmDict. Don't use any 'new' any more.
407 This should definitely solve any leak problem, and we should be
408 as fast as before, as long as don't modify too much the dictionary.
410 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
411 * STYLE: ivars should start with a capital letter.
412 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
413 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
415 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
416 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
417 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
418 new 2004 dictionaries added (thanks to JPR).
419 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
420 * CLEANUP_ROUND (15) for gdcmPixelConvert
421 - RLEFrame::NumberFragments is now of type unsigned int
422 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
423 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
426 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
427 * Initial work in gathering all transfer syntax accessors. clearly
428 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
429 ivars, but only one transfersyntax (class) ivar with equivalent method on
432 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
433 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
434 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
435 discussed (plus I didn't like having a 2000 lines patch not commited)
437 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
439 * CLEANUP_ROUND (14) for gdcmPixelConvert
440 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
441 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
442 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
444 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
445 anymore and hence avoids storing a copy of PixelConvert::Decompressed
446 into File::Pixel_Data.
448 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
449 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
450 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
451 * CLEANUP_ROUND (13) for gdcmPixelConvert
452 Substituted File::ParsePixelData() with PixelConvert::Print() new
454 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
455 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
456 method to those classes.
457 - src/gdcmFile.[cxx|h]:
458 -- Added a ::Print() method.
459 -- PixelConverter is now a reference instead of a member.
460 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
461 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
463 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
465 collaboration diagram and inheritance diagram should be generated with
467 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
468 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
469 pointlessly wrapped (see
470 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
471 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
472 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
473 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
474 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
475 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
476 -- File::Initialise: PixelConverter setup moved away to
477 PixelConverter::GrabInformationsFromHeader()
478 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
479 interpretation moved away to PixelConverter::BuildRGBImage()
481 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
482 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
483 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
485 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
486 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
487 displayed on Win32 when a brutal abort() occurs (because of uncatched
488 exception). See TODO new entry of this commit for more on this.
489 * TODO added new entry.
490 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
491 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
492 - HandleColor is no longer called from gdcmFile.cxx
493 - gdcmPixelConvert.cxx clean up on method arguments and internal
494 variable names for semantical coherence.
496 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
497 * Finished lossless transition, not only do we now read all lossless jpeg
498 images, without the need of the Cornwell lib, but we do read them properly now
499 * To reduce code (well to avoid code duplication), I defined a common place
500 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
501 redefine symbols. This is not prefect but this the best solution I found for a
502 compilation time jpeg option.
504 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
505 * Update jpeg ijg lib to support lossless jpeg implementation
506 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
508 * Also added a special copyright for dcmtk since we use their bugfixes.
511 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
513 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
514 matters, as stated in warning note at begining of %include section).
515 * src/gdcmDicomDir*.[cxx|h]: coding style
516 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
517 * src/gdcmJpeg8.cxx: doxygen fix.
518 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
519 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
520 from File:: to PixelConvert::.
522 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
523 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
524 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
525 - more code moved away from File:: to PixelConvert::
526 - fat setup of PixelConverter set in place in File::Initialise.
528 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
529 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
530 namespace at the file system level. So now you should convert your examples
532 gdcmHeader -> gdcm::Header
533 It would be nice if people keep in mind to no open the namespace, since it
534 allows compilation on broken plateform which were defining common symbol in
535 the standart namespace (like LP, Unknown ...)
537 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
538 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
539 The JPEG fragments are now parsed at the same stage than the RLE
540 information. All code related to JPEG is now in gdcmPixelConvert:
541 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
542 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
543 export a gdcmFile:: method. Those are simply global functions
544 (for the time being this is better than having them attach to
545 either gdcmFile:: or gdcmPixelConvert::).
546 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
547 and stores the result in a gdcmJPEGFragmentsInfo.
548 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
549 code (among other stuff) moved away from gdcmFile:; to
552 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
554 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
555 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
556 clean up of RLE related code.
557 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
558 - src/gdcmRLE.cxx removed
559 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
560 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
561 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
562 * CLEANUP_ROUND (9) for gdcmPixelConvert
563 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
564 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
565 away from gdcmFile:: to gdcmPixelConvert::.
567 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
569 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
570 This is because Parse7Fe0 used to parse the pixels to compute the
571 length. This task was passed over to FindDocEntryLengthOB() a long
572 time ago, EXCEPT I had forgotten the OW case...
573 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
574 we just recylce the code for parsing RLE fragments and computing
576 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
577 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
578 with the retired Parse7Fe0().
579 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
580 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
582 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
583 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
584 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
585 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
586 - src/CMakeLists.txt: alphabetic order reodering + new entries.
587 * CLEANUP_ROUND (4) for gdcmPixelConvert
588 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
589 to return an unused length.
591 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
592 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
593 this should be cleanner from the plane view. The iostream are erally a pain
594 to use to do simple stuff.
596 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
597 * Redo the compilation of the ijg jpeg library. Now only one source is
598 necesseray. No need to rename file by hand what so ever. CMake handle the
599 copying of the file within different directory, configure header file to
600 modify some symbol. The only addition made to ijg wasd a mangle table so
601 that symbol are different wether we are within 8bits or 12bits.
603 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
604 * Added documentation of vtkgdcmReader on Website:
605 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
606 with it's binary name).
607 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
608 the Website to be more complete.
609 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
610 doxygenated documentation.
611 - Doc/DoxyVtkGdcmReaderExamples.txt added
612 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
613 DoxyVtkGdmReaderExamples.html )
614 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
615 * CLEANUP_ROUND (3) for gdcmPixelConvert
616 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
618 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
619 * CLEANUP_ROUND (2) for gdcmPixelConvert
620 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
622 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
623 * CLEANUP_ROUND for gdcmPixelConvert:
624 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
625 - src/gdcmPixelStuff[h|cxx] removed
626 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
627 - src/CMakeLists.txt changed accordingly
629 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
630 gdcmVersion.py moved to newly created ATTIC related
631 gdcmPython/SetupOldies/ directory.
632 * Autotools clean up:
633 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
634 - autogen.sh configure.in acinclude.m4 python.m4 removed
636 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
637 * src/*.cxx *.h Reference to License.htm fixed to License.html.
638 * Doc/CMakeLists.txt, doxygen.config.in: fix.
639 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
641 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
642 * TODO updated with Mathieu suggestions. I proposed a template for
643 describing TODO entries and used it for new entries.
644 * Added Doc/Website/CodingStyle.html, Developpers.html,
645 DeveloppersPython.html, GdcmDataCvs.html and
646 DownloadVersion0_1.html, DownloadVersion0_3.html.
647 * Some Doc/*.txt Doxygen files (which do not really concern the
648 documentation itself, but the website) moved to html and
649 placed in directory Doc/Website:
650 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
651 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
652 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
653 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
654 * CMakeLists.txt changed accordingly.
655 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
656 DeveloppersPython.html
657 * INSTALL nows refers to Doc/Website/Installation.html
659 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * Added Doc/Website directory, that contains a first raw version
663 2004-09-23 Jean-Pierre Roux
664 * FIX In order not to be poluted any longer by casting problems,
665 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
666 we can now delete[] it safely
667 * VoidArea is now called BinArea (less confusing name),
668 and all the methods called ...VoidArea... are now ... BinArea...
669 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
671 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
673 clear) TagHT, which is an inherited member of gdcmElementSet. It is
674 up to the destructor of gdcmElementSet to clean up TagHt and it's
677 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
678 * Test/CMakeLists.txt: update to follow gdcmData renamings.
679 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
681 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
682 * ENH: added some utility method that builds a flat dictionnary
683 holding all the Dicom entries contained in the recursive structure
684 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
686 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
687 BuildFlatHashTable() that build a flat dictionary.
688 - src/gdcmElementSet.h: added a new private GetTag() accessor.
689 gdcmDocument is now a friend of gdcmElementSet.
690 - src/gdcmElementSet.cxx: clean up.
691 - Example/FlatHashTablePrint.cxx added.
692 - Example/CmakeLists.txt changed accordingly
694 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
696 moved away from gdcmDocEntrySet (since this class is an abstract class
697 acting like an interface). SQDepthLevel and BaseTagKey are now
699 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
700 and associated accessors. Doxygenation of the class.
701 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
703 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
704 Use SQDepthLevel accessor instead. ::Print() adapted.
705 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
706 - src/gdcmDocument.cxx changed accordingly.
708 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
710 - The following is the doxygen comment of the typedef declaration
711 of gdcmagKey in src/gdcmCommon.h:
712 gdcmTagKey is made to old an "universal" (as in URL, Universal
713 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
714 A dicom tag allways has a group and an element, but a set of tags
715 embeded in various (optionally nested) sequences and sharing
716 the same group and element all share the same (group, element)
717 "identifier". Hence the (group, element) cannot be used as an
718 identifier (in gdcm we shall refer to a "TagKey") of a tag.
719 In order to construct a proper tag identifier (i.e. a key) we
720 consider the following definition of a TagKey:
721 - let Group, Element be the string representation of the
722 group and element dicom tag members,
723 - let ItemNumber be the string representation of the integer
724 index of the considered item number of a sequence,
725 Let the key of a tag embeded in a sequence, noted SeqTag, be
727 /ItemNumber#Group|Element
728 where "/", "#" and "|" are characters acting as separators.
729 Then the general form of a gdcmTagKey is given by:
730 Group|Element<SeqTag>
731 where <SeqTag> means NO or many instances of SeqTag.
732 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
735 but the gdcmTagKey of a tag "embeded" is the first item of
736 a sequence, itself nested in the third item of a sequence is the
738 0004|1220/2#0008|0082/0#0008|0090
739 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
740 order to hold the new sequence compatible key. Previously, the
741 GetKey() method would look in the underlying gdcmDictEntry.
742 - src/gdcmDocEntry.cxx:
743 -- constructor now copies the underlying DictEntry key, in the local
745 -- ::Print: displays the member Key, instead of the (group, element).
746 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
747 - src/gdcmDocEntrySet.h:xi
748 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
749 -- now has a new BaseTagKey member.
751 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
752 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
754 This poses the problem with the semantics of the following lines
755 LoadEntryVoidArea(0x0028,0x1201); // R LUT
756 LoadEntryVoidArea(0x0028,0x1202); // G LUT
757 LoadEntryVoidArea(0x0028,0x1203); // B LUT
758 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
759 to the long FIXME note for what the problem is. Nevertheless in
760 order to get things working the dicom dictionary was altered !
761 Please fix things urgently...
762 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
763 information), see above note on moving the member VoidArea. Nevertheless
764 the following entries previously correctly set as US are now inproperly
766 0028 1201 OW IMG Red Palette Color Lookup Table Data
767 0028 1202 OW IMG Green Palette Color Lookup Table Data
768 0028 1203 OW IMG Blue Palette Color Lookup Table Data
769 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
770 of gdcmDocEntry moved to gdcmSeqEntry.
771 * src/gdcmSeqEntry.cxx: STYLE.
773 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * Test/TestAllEntryVerify.cxx minor fix and added comments.
776 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * gdcmPython/testSuite.py: all the test suite in python is now moved
778 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
779 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
780 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
782 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
783 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
784 to avoid inclusion recursion until STL is reached.
785 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
786 mecanism. errno.h is not included in gdcm anymore.
787 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
788 (gdcmFormatError now inherits from gdcmFormatUnexpected).
790 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
791 gdcmData/TestAllEntryVerifyReference.txt
792 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
793 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
794 exception_on_error parameter.
795 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
796 - vtk/vtkGdcmReader.cxx changed accordingly,
797 - Example/*.cxx and Test/*.cxx changed accordingly.
799 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
801 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
802 enable_sequences removed from gdcmHeader constructor and dependencies.
803 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
804 * gdcmPython/demo/PrintHeader.py: dummy fix.
805 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
806 skip_shadow removed from gdcmHeader constructor and dependencies.
807 * Example/*.cxx and Test/*.cxx changed accordingly.
809 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
810 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
811 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
813 2004-07-21 Jean-Pierre Roux
814 * FIX Now, Parsing and Printing a DICOMDIR do work!
815 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
817 2004-07-20 Jean-Pierre Roux
818 * FIX Some brain damaged headers have Zero-Lenght fields
819 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
821 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
822 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
823 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
824 variable (instance of gdcmDebug) by a definition macro, and the instance
825 is now in static in the gdcmDebug class
826 * src/gdcmSQItem.h : (FIXME) remove an undefined method
827 * Test/PrintAllDocument.cxx : bug fix in the result of the test
829 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * WARNING: ctest now depends more tightly on gdcmData. You should
831 check out gdcmData properly for things to run smoothly...
832 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
833 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
834 we need the pixels not be loaded in order to use the ValEntry
835 that displays position and size).
836 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
837 This is a C++ based equivalent of gdcmPython/testSuite.py that should
838 be deprecated. If you have any doubts about the advantages of a
839 modern scripting language (read Python) versus grass root C++ (i.e.
840 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
841 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
842 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
843 Anyhow, consider documenting the gdcmData images in
844 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
846 * Test/CMakeLists.txt:
847 - now uses TestAllEntryVerify.cxx
848 - specific comments on oldACR00001.ima (now renamed in gdcmData
849 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
850 gdcmData/TestAllEntryVerifyReference.txt
853 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
854 * src/*.[h|cxx] : typedef clean up
855 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
856 - TagKey renamed to gdcmTagKey (for external usage)
857 - VRKey renamed to gdcmVRKey (for external usage)
858 - removal of typedef duplication.
859 - Removed all unecessary inline keyword from class inline definitions.
860 - Some method|function(void) declarations replaced with method|function().
861 * src/jpeg/libijg12/jdhuff12.c:
862 - printf polluting ctest removed.
863 - TAB removal for comminting
865 - TestAllReadCompareDicom.cxx: added a test that compares all the
866 images in gdcmDataImages.h with corresponding images in
867 gdcmData/BaselineDicom/. When baseline images are not present
868 this test creates them.
869 Note: we need to validate each reference image, but before that
870 I'd like to rename them with a more explicit name...
871 - CMakeLists.txt: changed accordingly.
872 * Example/*.cxx: examples now only include gdcm.h (as opposed to
873 including each header needed).
875 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * Test/*.cxx and Example/*.cxx: moved some examples away from the
877 test suite to the Example directory. Are concerned:
882 - TestWriteSimple.cxx
883 * Test/CMakeLists.txt: added some comments on reasons for black listing
884 image gdcmData/oldACR00001.ima
886 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
887 * Test/CmakeList.txt: removed the following from black list (to be coherent
888 with removal from gdcmData):
889 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
890 - gdcm-MR-PHILIPS-16.dcm
892 Added the following because after last cvs update, they cause
893 ctest -R TestReadWriteReadCompare
895 - gdcm-MR-SIEMENS-16-1.acr
897 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
898 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
899 new comments in this file) we temporarily (sigh) move to a weaker
901 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
902 we don't need to black list the following images anymore:
903 - 8BitsUncompressedColor.dcm
905 - US-PAL-8-10x-echo.dcm
906 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
907 fixes and the beautified code ;-)
908 This fixes the bug introduced in version 1.42 (when beautifying)
909 that made the parsing of 8BitsRunLengthColor.dcm unproper.
910 Note: ctest was blind to this bug (this means we need to still
911 improve the test suite). The bug could be detected by using
912 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
914 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
915 and by displaying the (garbage) produced file temp.XDCM...
917 2004-06-29 Jean-Pierre Roux
918 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
919 - replace by uggly but working old code :-(
920 A lot of things should be OK again.
921 It's really urgent to have a test suite that *tests*,
922 to prevent Frog's beautifying sessions to break all the stuff
923 (twice, withing a fortnigh ...)
925 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
926 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
927 redundancy) to added Test/TestReadWriteReadCompare.cxx
928 * Test/CmakeList.txt: because the compare test of
929 Test/TestReadWriteReadCompare.cxx fails, the following images are
930 black listed: - 8BitsUncompressedColor.dcm
932 - US-PAL-8-10x-echo.dcm
933 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
934 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
935 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
936 and ad-hoc kludge. This kludge is now removed, and on encountering
937 such an image (OB field brain damaged) we set errno. Then in
938 ::FindDocLength() we "fix" the length as being ALL what remains
939 in the file (until EOF). We then proceed, hoping for the best...
940 This fixes a SegFault in ShowDicom when trying to write such an
942 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
943 (because TestWriteRead breaks on it, after a non conformal commit?).
944 ctest now runs properly, except for MakeDicomDir (which was allways
945 broken) and the Python related stuff (still not fixed).
947 2004-06-24 Jean-Pierre Roux
948 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
949 FIX : Test/TestReadWrite now iterates on all the file names
950 (instead of infinite loop)
951 ENH : Test/TestWriteRead now iterates on all the file names
953 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
956 2004-06-24 Jean-Pierre Roux
957 FIX : - now Write drops LUT Descriptors and LUTs (if any)
958 when SamplesPerPixel =3
959 - now Write is no longer confused by
960 'BitsAllocated = 12" and 'BitsStored=12"
961 - "UN" value representation Elements are now written correctly
962 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
963 ENH : - now gdcmHeader has its own Write methods
964 (in order to split the job that has not to be done
967 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
968 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
969 loop on the same image until memory went out.
970 Note: this means we still have gobs of memory loss in PrintDocument
971 * src/gdcmDocument.cxx: fixes problem on parsing on file
972 gdcmData/16BitsJpegLosslessGrayScale.dcm.
974 2004-06-24 Jean-Pierre Roux
975 FIX : Write - All the Sequences and Sequence Item are now written
976 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
977 is added a the end, when necessary.
978 - A lot of brain-damaged images, that were read correctly are
979 now written correctly
980 - length compatible BinEntry are now loaded correctly
981 (even for odd groups)
982 Note : only Explicit Value Representation was checked.
983 (question : is implicit VR really necessary for gdcm ?)
985 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
986 * DEVELOPPER: added a proposition of coding style.
987 * src/gdcmDocEntry.h: removed every inline declaration (for test of
990 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
991 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
992 Use the gdcmDocEntry::Print() and Write() instead.
993 * src/gdcmDocument.cxx: bug fix.
995 2004-06-22 Jean-Pierre Roux
996 FIX : gdcmDocument.cxx
997 - Now we do recognize the JpegLossLess format (there was a misstyping in
998 code 'beautyfication' :-(
999 - Now we automaticaticaly load the Luts, if any
1001 2004-06-22 Jean-Pierre Roux
1002 In order : to write Sequences, whatever their imbrication level,
1003 : to allow user to create his own Sequences
1004 a lot of modif where necessary (adding, moving, or virtualising methods)
1006 WARNING : save your own sources *before* cvs up !
1009 ADD virtual void Write(FILE *fp, FileType filetype);
1012 ADD virtual void Write(FILE *fp, FileType filetype);
1013 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1016 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1017 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1018 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1019 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1020 ADD std::string GetEntryByName(TagName name);
1021 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1023 std::string vr = "unkn",
1024 std::string fourth = "unkn",
1025 std::string name = "unkn");
1026 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1027 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1028 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1029 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1030 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1031 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1032 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1033 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1036 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1037 ADD virtual std::string GetEntryByName (TagName tagName);
1038 ADD virtual std::string GetEntryVRByName (TagName tagName);
1039 REM virtual bool Write(FILE *, FileType);
1040 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1041 FILE *_fp, FileType type);
1042 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1043 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1044 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1045 REM virtual std::string GetEntryByName (std::string tagName);
1046 REM virtual std::string GetEntryVRByName (std::string tagName);
1047 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1048 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1049 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1051 std::string vr = "unkn",
1052 std::string fourth = "unkn",
1053 std::string name = "unkn");
1054 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1055 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1056 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1057 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1060 ADD virtual void Write(FILE *fp, FileType filetype);
1063 ADD virtual void Write(FILE *fp,FileType filetype);
1066 ADD virtual void Write(FILE *fp, FileType filetype);
1067 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1068 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1069 REM std::string GetEntryByName(TagName name);
1072 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1074 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1075 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1076 The default constructor invoked by the line
1077 gdcmHeader *f1 = new gdcmHeader( header );
1078 was gdcmHeader::gdcmHeader(bool) instead of the expected
1079 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1080 Hence the parsing wasn't executed... See also below.
1081 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1082 as explicit constructor didn't do the trick to fix the above problem.
1083 Could anyone explain why ?
1084 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1085 properly calls gdcmValEntry::Print() (that was weed out from
1086 code related to gdcmBinEntry).
1088 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * In order to fix memory leaks:
1090 - Test/TestWriteSimple.cxx: added cleaning of free store through
1092 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1093 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1094 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1095 (through the call to ::AddDicomDirMeta()) or the destructor
1096 would crash when deleting uninitialized ::metaElems].
1097 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1098 - src/gdcmDocument.cxx:
1099 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1100 from dynamic stores.
1101 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1102 was causing memory leaks.
1103 - src/gdcmSQItem.cxx:
1104 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1105 cleanly handled with polymophism: sorry but my milage is low).
1106 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1107 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1108 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1109 This avoids SegFaulting.
1110 - src/gdcmSQItem.h: coding style.
1112 - Test/TestWriteSimple still severely sucks. The output image content
1113 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1114 damaged when displayed with vtkgdcmViewer.
1115 - on memory leaks: TestWriteSimple leaks really less (see entry
1116 of 2004-06-18 in Changelog file for the call to valgrind).
1117 - on segfaults: ctest now passes all the tests but one (no more
1119 * Erroneous leading white fix:
1120 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1121 white[s] (as opposed to from >> xxx, that removes it [them].
1122 - src/gdcmTS.cxx: ditto.
1123 - gdcmPython/testSuite.py: dirty related kludge removed.
1124 * src/*: remaining references to gdcmParser removed.
1125 * src/*[cxx|h]: added copy[way]left header.
1128 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * In order to fix writing of dicom files:
1130 - Test/TestWriteSimple.cxx: a simpler example of writing.
1131 - Test/CMakeLists.txt changed accordingly.
1132 - src/gdcmDocument.cxx:
1133 -- The destructor now recursilvely removes potential sequences.
1134 -- Bug fix in ::IsJPEG2000()
1135 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1136 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1138 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1139 to only declared) and build on top of
1140 ::GetDocEntryByNumber(guint16, guint16).
1141 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1142 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1143 for usage in destructor and treatement of promotion in
1144 ::ReplaceOrCreateByNumber().
1145 - src/gdcmSQItem.cxx: destructor should better handle his job.
1146 Test/TestWriteSimple now runs (or at least it DOES something).
1147 * We can now start hutting memory links. A good starting point is:
1148 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1149 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1150 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1152 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1153 * Valgrind note: after Mathieu Malaterre teached me how to read
1154 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1156 Using gcc, you can force the STL to use malloc and to free memory as
1157 soon as possible by globally disabling memory caching.
1158 With 3.2.2 and later, you should export the environment variable
1159 GLIBCPP_FORCE_NEW before running your program.
1160 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1161 simply vanish (it is still not clear to me, whether this means that
1162 STL std::string leaks or if valgrind believes it leaks...).
1163 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1164 running bin/gdcmTests makeDicomDir):
1165 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1166 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1168 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1169 SegFaulting (I drowned in DicomDir related code when trying to
1170 understand why the list is empty...).
1171 * src/gdcmDocument.h: first BSD license header try.
1172 * Doc/License.txt added.
1174 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * src/gdcmDocument.[h|cxx]:
1176 - Clean up of the Transfer related predicates. They are now all based
1177 on new method isGivenTransferSyntax, that (should) handle properly
1178 the padding problem.
1179 - general clean up, simplification, and coding style.
1180 - Specific clean up of Parse7FE0() (umproperly named actually).
1181 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1183 2004-06-14 Jean-Pierre Roux
1185 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1186 - fix the display of SQItem ordinal number
1187 - add the GetSQItemByOrdinalNumber method
1188 - remove some useless never written private methods
1190 2004-06-14 Jean-Pierre Roux
1192 - adding a constructor taking a gdcmDocEntry as an input param
1193 - ReplaceOrCreateByNumber now returns :
1194 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1195 a gdcmValEntry * if a string value is passed as a param
1197 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1198 according to the param type (no longer sets a gdcmDocEntry)
1199 - GetValEntryByNumber, GetBinEntryByNumber added
1200 - NewValEntryByNumber and NewBinEntryByNumber added
1202 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1204 - GetSQItemNumber and SetSQItemNumber added, to provide
1205 a (relative) Item identier inside a given Sequence
1206 \warning : some pb remaining around this number
1208 - AddEntry now takes the Item Number as a param
1210 - adding a constructor taking a gdcmDocEntry as an input param
1212 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * Memory leak hunt with the following command:
1214 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1215 --show-reachable=yes gdcmTests PrintDocument
1216 It looks like many (all?) leaks are due to the STL (or a bad usage
1217 of the STL. The lines producing the leaks now have a comment with
1218 a "MEMORY LEAK" tag: you can retrieve them with
1219 grep "MEMORY LEAK" src/*
1220 Here are two typical examples which I can't help fixing:
1225 char * test = "babo";
1226 name = test; //// <--- valgrind detects 960 bytes lost in
1227 //// call to std::string::operator=(char const*)
1228 name.clear(); //// Doesn't help !
1236 std::cout << "Type a bunch of characters followed by RETURN: ";
1237 getline(std::cin, line); //// <--- valgrind dectects a loss
1238 //// of 1320 bytes in call to
1239 /// std::basic_istream<>& std::getline<>
1245 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * src/gdcmHeader.[cxx|h]:
1247 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1248 and related, moved away to gdcmDocument.
1249 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1250 the corresponding protected accessors of inherited class
1251 gdcmDocument, removed ! As a consequence gdcmFile had to be
1252 declared friend of class gdcmDocument (see below).
1253 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1254 - Clean up of undefined or unused methods.
1255 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1256 account the changes to gdcmHeader.h).
1257 * src/gdcmDocument.h:
1258 - gdcmFile is now a friend class (in order to take into account the
1259 changes to gdcmHeader.h).
1260 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1261 (see changes to gdcmHeader.h).
1262 - Accessors (reading on the form GetEntry*) are now public.
1263 - Clean up of undefined or unused methods.
1264 * src/gdcmDocument.cxx:
1265 - adaptation to changes to gdcmDocument.h
1266 - ::OpenFile now writes a verbose message when file cannot be opened.
1267 - some std::string properly set to VRKey
1268 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1269 references to gdcmDocument.
1270 * Test/TestFindTags.cxx: changed accordingly to above changes.
1271 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1272 cvs repository gdcmData.
1274 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1275 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1276 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1277 conflicts with gdcmValEntry::voidArea.
1278 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1279 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1280 Value representation between StringRepresentable and BinaryRepresentable.
1281 * src/gdcmDocument.cxx:
1282 - method ParseDES: proper indentation restored and usage of
1283 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1284 - method LoadDocEntry: the fingerprint left in the SetValue() of
1285 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1286 removed. Reverting to previous code segment with the proper
1287 dynamic_cast< gdcmValEntry* >.
1288 Note: this was (partially) breaking the python test suite
1289 (gdcmPython/testSuite.py) that made usage of the above
1290 fingerprint to check presence of "Pixel Data".
1291 * src/gdcmDocEntry.h: coding style.
1292 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1293 now taken into account.
1294 * gdcmPython/gdcm.i: adaptation to the new internal representation
1295 of gdcm (exit gdcmParser, hello gdcmDocument).
1296 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1298 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1299 anymore, but instead prints the loaded Python dictionary.
1300 * .... alas, the python testSuite is still broken.
1302 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1303 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1305 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1306 * src/gdcmUtil.h : export methods
1308 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1309 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1311 * Initial addition of automatic python testing
1312 * Initial addition of automatic image comparison
1314 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1315 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1316 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1318 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1319 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1320 * Test/ShowDicom.cxx : bug fix for msvc compilation
1321 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1323 2004-05-04 Jean-Pierre Roux
1324 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1325 new concepts (and new classes) :
1326 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1327 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1328 - Sequence Doc Entries (gdcmSeqEntries)
1329 a Sequence is composed of Items.
1330 Each item is a set of Doc Entries (this is recursive)
1331 The non uniqueness of the 'Dicom tag' is due to this recursivity
1332 (never taken into account)
1333 Our unability to add a new 'entry' in the header
1334 at the proper location (neither in the H-Table (map or multimap),
1335 nor in the Chained List is also due to this recursivity.
1336 Don't try, right now, to use/modify/compile these new sources :
1337 nothing is finished.
1338 We just commit all the stuff, 'as is', in order not to loose it.
1340 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1341 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1343 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1344 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1345 file prefix (SetFilePrefix)
1347 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1348 * Add a new test: ShowDicom, for now this is just the c++ version of
1349 checkRead.sh, later it will be able to compare the image read against a
1351 * Replace the DEBUG on the stack with a global entry in cmake interface:
1352 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1354 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1355 * Add an example subdir, with a real example on how to read + write a
1358 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1359 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1360 * Doc/CMakeLists.txt: the main page is now properly differentiated
1361 between the developper and user version.
1362 * Doc/doxygen.config.in: dropped search related obsolete flags
1363 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1365 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1366 * DEVELOPPER: added some helpfull comments for compile/test/install
1369 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1370 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1371 src directory, now generated in the build dir.
1372 2. Tests as mentionned smarter
1374 4. Add a new method in gdcmDict that return the PubDict by name
1375 this is interesting for 3rd party lib like ITK,
1376 where we could set the institution name / patient name...
1378 * ENH: 1. Now the test suite is working for real
1379 2. All binaries are now output in the gdcm-bin directory
1380 (this was not true before)
1382 2004-04-28 Jean-Pierre Roux
1383 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1384 SeQuence indented printing of Dicom Header.
1385 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1386 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1387 Computation of SQDepthLevel is now part of gdcmHeader constructor
1388 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1389 tree-like structure of a Dicom Header.
1390 * FIX Test code cleaning
1392 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1393 * ENH: Adding automatic testing
1394 1. Need a DartConfig.cmake to submit to public
1395 2. Add a test driver gdcmTest.cxx
1396 3. gdcmTestMain, an helper for the main test driver gdcmTest
1397 4. Files in Test don't have a main anymore, this becomes interesting
1398 when we add more and more tests, thus dsw don't have to load
1400 * ENH: Adding a GDCM_DATA_ROOT for testing
1401 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1402 one file instead of seven + some small cleanup
1404 2004-04-22 Jean-Pierre Roux
1405 * ENH Minor changes to the Print() methods.
1406 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1407 Header printing. Example given with :
1408 > PrintHeader fileName 2 new
1409 (SQ based tree-like structure still to be done for the Header ...)
1411 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1412 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1413 1. I have added some unsigned where needed
1414 2. Some function parameter not used -> (void)
1415 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1416 4. g++ don't like character '\' in comment
1417 5. #define jpeg_create_decompress jCreaDecompress
1418 this really need to be fixed
1419 6. virtualize destructor of gdcmObject ... leakage
1420 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1421 this also really need to be fixed
1422 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1423 remove compression file
1424 (as we only do decompression, right ?)
1425 * ENH: Change malloc/calloc/free with c++ equivalent
1427 2004-04-21 Jean-Pierre Roux
1428 * FIX gdcmHeaderHelper::GetXSpacing
1429 when a single value is found (bug ?), xpacing is now
1430 defaulted to yspacing
1432 2004-04-19 Jean-Pierre Roux
1433 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1434 * ENH add parameters :
1435 bool exception_on_error = false,
1436 bool enable_sequences = false,
1437 bool ignore_shadow = false
1438 to the gdcmFile constructors to be full gdcmParser compliant
1439 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1440 to allow reading of PAPYRUS 3.0 files
1442 2004-04-06 Jean-Pierre Roux
1443 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1445 2004-04-02 Jean-Pierre Roux
1446 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1447 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1448 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1450 2004-03-30 Jean-Pierre Roux
1451 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1452 for ACR file, written out as DICOM files (hope so...)
1454 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1455 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1456 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1457 moved to base class gdcmParser and only the specialisation is kept
1459 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1460 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1461 already does the job.
1462 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1463 (to be consistent with gdcmParser::WriteEntries).
1465 2004-03-30 Benoit Regrain
1466 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1467 upate of the object's instance. It's passed to 2 in the unfavorable
1468 case : one in the ExecuteInformation, one in the ExecuteData
1470 2004-03-29 Jean-Pierre Roux
1471 * ENH : Check on file type to be written moved
1472 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1473 * FIX : gdcmObject::ResetBoundaries now stops properly
1474 when end-of-list is reached
1475 : gdcmVersion modified (as Benoit Regrain asked)
1477 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1479 * src/gdcmUtil.cxx: added forgotten iostream include.
1480 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1481 equivalent to ExplicitVR in existing code).
1483 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1484 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1485 now contains all the gdcmGlobal related code.
1486 * minor coding style and doxygenation changes.
1488 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1489 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1490 now contains all the Debug related code.
1491 * minor clean-up of includes in src/*.cxx
1492 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1493 CreateCleanString) removed.
1494 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1495 * Doc/DoxyMainPageUser.txt added.
1496 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1497 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1498 src/gdcmDirList.cxx)
1500 2004-03-24 Jean-Pierre Roux
1501 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1503 2004-03-23 Jean-Pierre Roux
1504 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1505 big endian made volumes
1506 * ENH Now gdcmParser constructor and destructor are protected to forbid
1507 end user to instanciate class gdcmParser
1508 (only gdcmHeader and gdcmDicomDir are meaningfull)
1510 2004-03-22 Benoit Regrain
1511 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1512 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1513 gdcmSerie to gdcmDicomDirSerie
1515 2004-03-19 Jean-Pierre Roux
1516 * ENH Now the tree-like structure describing a DICOMDIR comming from
1517 an already existing DICOMDIR file is consistent with
1518 the home-made tree-like structure build ex-nihilo
1519 or build from the files held (recursively) in a Directory
1520 functions gdcmDicomDir::CheckBoundaries()
1521 gdcmObject::SetBoundaries() added
1523 2004-03-17 Jean-Pierre Roux
1524 * REM (Eric Boix bug) : removal of meaningless
1525 gdcmDicomDirImage::NewImage function.
1526 * FIX now file names and directory name are written properly in the
1528 * FIX now gdcmDicomDir constructor may be call without any trick
1531 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1532 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1533 of gdcmDicomDirImage::NewImage as empty function.
1535 2004-02-28 Jean-Pierre Roux
1536 * ENH add gdcmDicomDir:NewPatient
1537 add gdcmDicomDirPatient:NewStudy
1538 add gdcmDicomDirStudy:NewSerie
1539 add gdcmDicomDirSerie:NewImage
1540 to allow making gdcDicomDir object.
1541 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1542 (as opposite to the gdcmHeader chained list)
1544 2004-02-11 Benoit Regrain
1545 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1546 when using from python
1548 2004-02-10 Benoit Regrain
1549 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1550 * FIX : in gdcmDicomDir when the directory is empty
1551 * ENH : add callback and methods to get the progression of dicomDir
1554 2004-02-06 Jean-Pierre Roux
1555 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1556 - GDCM_META added to gdcmDicomDirType
1557 - class gdcmMeta created
1558 * ENH : - A brief summary is now displayed at the beginning of
1559 'testDicomDir' to help disaster magnitude estimation
1560 * REM : Now useless Test/explDICOMDIR.cxx
1562 2004-02-05 Benoit Regrain
1563 * ENH : add methods in gdcmObject to get the hash table or the list of
1565 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1566 * FIX : wrapping python for TagHeaderEntryHT
1568 2004-02-04 Benoit Regrain
1569 * FIX : even length for some strings when writting the dicom dir
1570 * FIX : sort the images in the dicom dir
1571 * FIX : Bug fix for python use of dicom dir
1572 * ADD : a python demo
1574 2004-02-04 Jean-Pierre Roux
1575 * FIX : Final solution (?) for icone embedded images
1576 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1577 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1578 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1579 gdcmData/gdcm-MR-SIEMENS-16.acr1
1580 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1581 to make full checking easier
1583 2004-02-04 Benoit Regrain
1584 * FIX : WriteEntries : coding style & logic in parameters
1585 * FIX : Set the elements to create the DicomDir in a dictionary file
1587 2004-02-03 Benoit Regrain
1588 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1589 * gdcmDicomDir : add the load of directory
1590 * Bug fix and print add-on
1592 2004-02-03 Jean-Pierre Roux
1593 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1594 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1595 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1596 * FIX gdcmParser.cxx : 'group length' elements are now considered
1597 as integers, even for shadow groups, when file is Implicit VR
1599 2004-02-02 Jean-Pierre Roux
1600 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1602 of the last synonym :-(
1603 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1605 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1606 * FIX taking into account the possible 7fe0,0010 multiplicity
1607 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1608 to allow removal of references to 7fe0,0010, to deal with
1609 ACR-NEMA images, when 0028,0200 is meaningfull
1611 2004-01-31 Jean-Pierre Roux
1612 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1613 no longer writes 'Un' on disk
1614 * FIX SQ elements with actual length are now dealt with corectly
1615 * FIX gdcmFile::WriteBase make the difference, for color images, between
1616 the length (for Palette expanded images)
1617 and Raw Length (non expanded image + Palette)
1618 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1619 (that broke Write). Replaced by UL.
1620 Aware user will reload the field if he
1621 thinks it's necesssary
1623 2004-01-30 Jean-Pierre Roux
1624 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1625 when 'dirty Acr' is found, to be compliant with the new
1626 IsReadable() methods.
1628 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1629 (no DOUBLE images in kosher DICOM,
1630 but so usefull for people that miss them ;-)
1632 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1633 DICOMDIR related utilities (not checked as Windoze compliant)
1635 2004-01-28 Jean-Pierre Roux
1636 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1638 2004-01-27 Jean-Pierre Roux
1639 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1640 to allow skipping the shadow elements, to save memory space.
1641 The TRUE value for this param has to be used
1642 with a FALSE value for the 'enable_sequence' param.
1643 ('public elements' may be embedded in 'shadow Sequences')
1644 * gdcmHeader methods now deal with 'embedded icones images' in the header
1645 (even when an 'icone image sequence' is announced by the
1646 element (0x0088,0x0200), but there is NO icone at all ...
1648 * gdcmHeader sometimes Image Location value doesn't follow
1649 the supposed processor endianity (see gdcmData/cr172241.dcm).
1652 * gdcmHeader add the method
1653 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1654 to get *all* the Header Entries with the same tag.
1655 GetHeaderEntrySameName is probabely *useless*
1656 (no meaning : Name is *not* an identifier within the Dictionnary)
1658 2004-01-26 Benoit Regrain
1659 * Bug fix in the print of hexadecimal representations. Remove long fields
1660 in the print and add a third level of print to print them
1662 2004-01-23 Benoit Regrain
1663 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1664 * Bug fix on test suite after remove the strip made on not string fields
1665 * Split the IsReadable method between gdcmParser which test that the file
1666 is dicom and gdcmHeader which test that it's an image file
1668 2004-01-22 Benoit Regrain
1669 * DicomDir : clean code, add methods, set variables in protected or private
1670 * gdcmUtil : bug fix for the clean string method
1672 2004-01-19 Benoit Regrain
1673 * Add the use of shadow dictionaries
1674 * bug fix and coding style
1676 2004-01-19 Benoit Regrain
1677 * src/gdcmFile.cxx : bug fix concerning the close of file
1678 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1679 * Add the update of header entries using the shadow library
1681 2004-01-19 Benoit Regrain
1682 * removal of file gdcmHeader2.cxx
1683 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1684 inheriting from gdcmParser. This split is to prepare the integration
1685 of dicom dir parsing
1686 * bug fix under python
1688 2004-01-16 Jean-Pierre Roux
1689 * REM removal of class gdcmHeaderEntrySet
1690 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1691 * ADD add file gdcmHeader2.cxx
1692 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1694 2004-01-15 Benoit Regrain
1695 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1696 entries created while parsing the header. Thus, they will be destroyed
1697 when the gdcmDictSet will be destroyed
1698 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1701 2004-01-15 Benoit Regrain
1702 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1703 made a fatal error because of the memory release at the end of program.
1704 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1705 some memory and vtk seems to have some problems with that.
1706 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1708 2004-01-14 Benoit Regrain
1709 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1710 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1711 * src/*.[h|cxx] : make changes due to class name changes
1712 * gdcmPython/demo/*.py : bug fix due to method names
1714 2004-01-13 Benoit Regrain
1715 * src/*.[h|cxx] : coding style
1716 * vtk/*.[h|cxx] : coding style
1718 2004-01-13 Benoit Regrain
1719 * gdcmPython/testSuite.py : test the readable flag of file for tests
1720 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1721 It's lied to the stl compilation by MSVC (windows, always windows...)
1722 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1724 2004-01-12 Benoit Regrain
1725 * src/*.h : add comments
1726 * src/gdcmDictSet.h : set the method BuildDictPath in public
1727 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1728 directly setted in the source code
1729 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1732 2004-01-09 Benoit Regrain
1733 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1734 * setup.py : use a reference to gdcmVERSION
1736 2004-01-07 Benoit Regrain
1737 * Modification to compile with the distutils.
1740 2003-12-10 Benoit Regrain
1741 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1742 can use a gdcmHeaderHelper to load datas
1743 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1744 made in the source code
1746 2003-12-10 Benoit Regrain
1747 * Update Windows projects and .cvsignore files
1749 2003-11-12 Jean-Pierre Roux
1750 * ENH gdcmHeader constructor has one more parameter (default value : false)
1751 that allows the user to 'go inside' the SeQuences only
1753 gdcmElValSet:Print takes it into account
1755 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1756 * ENH: Update gdcmPython/CMakeLists
1757 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1758 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1760 2003-11-10 Jean-Pierre Roux
1761 * FIX : gdcmHeader::LoadElements is now based
1762 on the ListTag listElem member,
1763 not longer on the TagElValueHT tagHt member
1764 * ENH : PrintPubElVal shows (temporarily) both results,
1765 with the tagHt member and the listElem member.
1766 (it's easier to 'see' the problems when using Printheader)
1768 * FIX : old private member LgrElem is now splitted into
1769 ReadLength : Length actually found on disk (updated only
1770 if bug fixing is necessary), for internal
1772 UsableLength : Updated by FixFoundLength, to fix a bug
1773 or to allow Parser going on.
1774 Will allow to re-write a kosher header when a SeQuence
1775 with a length (not 0000) is found
1776 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1777 because gdcmElValSet::Add does not update ListElem
1780 2003-11-07 Jean-Pierre Roux
1781 * FIX misstyping in Transfert Syntax name table
1782 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1783 when they have an actual length (not 0000 nor FFFFF)
1784 (Nobody should care of it, but DICOMDIR explorers)
1786 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1787 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1789 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1790 * ENH: vtkGdcmReader now supports LUT !
1791 (vtkgdcmViewer for now is not able to use them though)
1793 2003-11-05 Jean-Pierre Roux
1794 * in testSuite.py : new files names for checking the package
1795 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1796 that returns the pixel area size to the *aware* (vtk) user
1797 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1799 2003-11-05 Benoit Regrain
1800 * in testSuite.py : Modify the rules for checking the paths
1801 : Explicit error messages
1802 * in __init__.py : Related modif
1804 2003-11-03 Jean-Pierre Roux
1805 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1806 to be used by aware (vtk) users that want to manage
1807 LUT (and no to turn the PALETTE image into an RGB pixels one)
1808 * GetPixelType now returns 8U for 24 Bits images
1809 (vtkGdcmReader compliant)
1811 2003-10-31 Jean-Pierre Roux
1812 * Removal of *all* gdcmData images and add them again
1813 in order to loose the 'history' of un-anonymised images
1815 2003-10-31 Jean-Pierre Roux
1816 * RMV : removal of useless jBitsInJsample.h
1817 for both 8 and 12 Bits JPEG Lossy Libraries
1819 2003-10-31 Jean-Pierre Roux
1820 * ENH : Add the functions gdcmFile::GetImageDataRaw
1821 gdcmFile::GetImageDataIntoVectorRaw
1822 that act as GetImageData and GetImageDataIntoVector
1823 except the making of an RGB Plane from Gray Plane + LUT
1824 Intended to aware (vtk) users who know how to manage
1827 GetLUTRGBA return a R,G,B,A LUT if any
1828 lgrTotaleRaw gives the 'Raw' length
1829 GetImageDataRaw returns the gray Plane
1830 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1831 (They stay Grey, just like with other Dicom viewers :-(
1833 2003-10-30 Jean-Pierre Roux
1834 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1836 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1837 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1838 being coherents dicom files.
1840 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1843 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1844 * ENH: Two steps is necessary to please VC++ compiler...
1845 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1846 * ENH: Add include dir to medcon lib
1847 * FIX: only one function is being exported for now !
1848 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1850 2003-10-29 Jean-Pierre Roux
1851 * adding gdcmHeader::GetLUTRGBA
1852 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1853 --> Mathieu, the modif u're waiting for is not yet committed
1854 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1856 2003-10-27 Jean-Pierre Roux
1857 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1858 00191113.dcm DermaColorLossLess.dcm
1859 MxTwinLossLess.dcm RadBWLossLess.dcm
1860 * ENH: For version prior to vtkImageViewer2 -r 1.19
1861 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1863 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1864 * Removal of ido stuff in CMakeLists.txt
1866 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1867 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1868 * FIX: remove a call to ->Modified ... see comments
1869 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1871 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1872 * FIX: Problem with path for libvtkgdcmPython
1873 * ENH: Try adding a search script for python site-package
1874 * RMV: Remove some file from medcon lib that are not necessary
1875 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1876 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1877 * FIX: More pragma disable fro VC++,
1878 I don't think I break something as it is also disable in VTK/ITK.
1879 But it fasten debug compilation time.
1881 2003-10-23 Jean-Pierre Roux
1882 * gdcm now deals with 16 Bits Run Length Encoded images
1883 (they are compressed as 2 planes images,
1884 one for the high Bytes, the other for low Bytes)
1886 2003-10-22 Jean-Pierre Roux
1887 * Now CheckRead takes into account :
1888 - the bugged 'Leonardo' Siemens images
1889 - the XA images, sent thru the burning VPRO station
1890 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1893 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1894 * FIX: When copying a Makefile.am to CMakeLists.txt
1895 one should remove the '\'
1897 2003-10-22 Jean-Pierre Roux
1898 * in gdcmData adding a bugged 'Leonardo' Siemens image
1899 (wrong lengths in header)
1900 OK with gdcm, KO with the other viewers :-)
1901 * add a GE dlx XA image, thru the VEPRO burning station
1904 2003-10-21 Jean-Pierre Roux
1905 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1906 for a brutal checking of vtkgdcmViewer compliance
1908 2003-10-21 Jean-Pierre Roux
1909 * add the files for 'xmedcon' Jpeg Lossless library
1910 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1912 2003-10-21 Jean-Pierre Roux
1913 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1915 2003-10-21 Jean-Pierre Roux
1916 * garbage Siemens 'Leonardo' images dealt with
1917 (the patch is easy to remove)
1918 * cosmetic changes to avoid warnings
1920 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1921 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1922 no need to press 'r' now.
1924 2003-10-20 Jean-Pierre Roux
1925 * upgrade of checkRead.sh checkWrite.sh according
1926 to new Jpeg Lossless decompressor
1927 * add US.3405.1.dcm, a genuine RGB medical file ...
1928 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1929 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1931 2003-10-15 Jean-Pierre Roux
1932 * general anonymisation in gdcmData
1933 * adding the 'color files' from
1934 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1935 * adding some well knowed bugged-header images
1936 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1937 waiting for their inclusion in Python testsuite
1939 2003-10-15 Jean-Pierre Roux
1940 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1941 no longer seg faults when file is not found
1943 2003-10-14 Jean-Pierre Roux
1944 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1947 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1948 * TODO: *.in file to genereate a UseGDCM later
1950 2003-10-14 Jean-Pierre Roux
1951 * Some supposed-to-be Dicom Images have no preamble.
1952 OpenFile takes it into account
1953 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1954 * Missing elements added in dicomV3.dic
1955 (just to be affraid : have a look at
1956 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1957 and do it again next year ;->
1959 2003-10-13 Jean-Pierre Roux
1960 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1961 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1962 But there are NOT. It's fixed !
1964 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1965 * FIX: "jpeglib.h" was not found on VC++
1966 * FIX: vtkgdcm was not being installed
1968 2003-10-10 Jean-Pierre Roux
1969 * ENH : OpenFile closes the file if it *really* doesn't look like
1970 an ACR-NEMA / DICOM one.
1971 * FIX : testWrite no longer writes an empty file if the source file
1972 is not gdcm Readable
1973 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1976 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1977 * FIX: CMake generate now documentation
1978 * ENH: out of source doc build !
1979 * ENH: Generate both user and dev documentation
1980 * ENH: Should work on windows too
1981 * ENH: Only one doxygen config.in file is needed
1982 * FIX: make install should be ok now on ùnix plateform
1983 * FIX: PATH to dictionary was wrong (missing /)
1984 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1986 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1987 * vtkGdcmReader is now able to read rgb dicom file.
1988 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1989 * added a gdcmViewer to vtk test, use mouse to control
1990 window level & window width
1992 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1993 * CMake-ification of gdcm, we have now two build system
1994 * FIX: on cygwin Wsock32 doesn't exist
1995 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1997 2003-10-06 Emanuel Ollart
1998 * FIX : compilation process wad broken.
1999 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2001 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2002 * change gdcmViewer -> vtkgdcmViewer
2003 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2005 2003-10-06 Jean-Pierre Roux
2006 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2007 ( e.g : well known GE images with a wrong elem length,
2008 : Philips MRI Images with a wrong Huffman table)
2009 * still to be done : allow the reading of bugged LEONARDO Siemens images
2011 2003-10-03 Jean-Pierre Roux
2012 * Odd length strings are padded with '\0' (not with spaces,
2013 to remain compliant with already defined strings,
2014 like Transfert Syntax UID and others)
2016 2003-10-03 Jean-Pierre Roux
2017 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2018 to allow displaying RGB images (not only by affim ;-)
2020 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * vtkGdcmReader is now able to read rgb dicom file.
2022 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2024 2003-10-03 Jean-Pierre Roux
2025 * A few nasty patches to allow the reading of a lot of nasty images
2026 ( e.g : well known GE images with a wrong elem length,
2027 : Philips MRI Images with a wrong Huffman table)
2028 * still to be done : allow the reading of bugged LEONARDO Siemens images
2030 2003-10-03 Jean-Pierre Roux
2031 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2033 2003-10-03 Jean-Pierre Roux
2034 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2035 to allow displaying RGB images (not only by affim ;-)
2037 2003-10-03 Jean-Pierre Roux
2038 * gdcmFile::GetImageDataIntoVector now
2039 - deals with MultiFrames MultiFragments Run Length Encoded files
2040 - deals with YcBcR (YBR_FULL) files
2041 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2042 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2044 (no sample found :-(
2046 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2047 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2048 Two reasons: - clear things
2049 - third parties acces gdcm through header files, so won't
2050 suffer anymore VC++ complains
2052 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2053 * add argv[1] in testvtkGdcmReader.cxx
2056 2003-09-24 Jean-Pierre Roux
2057 * The lines are now eigthy characters long.for
2058 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2060 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2061 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2062 char* to std::string. Thus, the use of strdup becomes useless. (see
2063 previous commis of Malaterre)
2064 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2065 before the last Malaterre's commit.
2067 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2068 * This commit should fix the Debug building under VC++, the problem
2069 was mainly a mixture of debug and release lib being loaded at startup.
2070 * I also remove a depency to a specific C function: strdup. Because I had
2071 to force the link to msvcrtd (whereas strdup is in libc).
2073 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2074 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2075 located in the gdcmCommon.h file. All use of reference of tha has been
2076 changed to now use the variable GDCM_UNFOUND.
2078 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2080 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2081 Dicom dictionary. The test suite can now be run again. Note:
2082 I'm note very happy with the " (RET)" changes. I believe this
2083 RETAINED comment should be dropped when parsing the dictionary.
2084 - PACKAGER corrected
2086 - AUTHORS updated and now in alphabetical order
2087 * Makefile.am now exports gdcm.dsw for Windoze users.
2089 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2090 * cygwin complains about missing std:: in subdir Test/
2092 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2093 * remove some methods that are now in gdcmHeaderHelper
2095 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2096 * vtkGdcmReader set spacing and origin correctly
2098 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2099 * Fix a few delete/delete[] mismatch
2101 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2102 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2103 interpretation to data given by gdcmHeader. For instance there are
2104 heuristics to get informations (look at different places).
2105 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2106 sorting DICOM images based on different strategies.
2107 * modified Makefiles accordingly.
2109 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2110 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2111 when building in debug mode
2112 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2113 src/win32/gdcmdll.dsp
2114 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2116 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2117 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2120 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2121 * src/win32/libgdcmjpeg12.dsp was not dos format
2122 * src/win32/libgdcmjpeg12.dsp :
2123 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2124 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2126 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2127 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2129 * src/gdcmFile.cxx : bug fix in affectation type
2130 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2131 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2132 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2133 symbols... future problem ?
2135 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2136 * src/win32/libgdcmijpeg12.dsp was missing
2137 * modified gdcm.dsw accordingly
2139 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2140 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2142 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2143 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2144 commit of JPR (before his hollidays to facilitate our work).
2145 * setup.py : bug fix in code. Modifications made while the last commit
2146 of JPR. The code hasn't been tested before the commit... it's so
2147 useless to make that (for best programmer that is JPR) !!!
2149 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2150 * tagged the current version as Version0_3 (i.e. version 0.3)
2152 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2153 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2154 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2155 * *.dsp : modifications to use new libgdcmijpeg8 library
2156 * setup.py : bug fix on VTKPATH variable
2157 * PACKAGER : adding all concerning windows
2159 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2160 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2162 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2163 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2164 test suite reported error.
2165 * PACKAGER file added (describes what a packager must do when
2166 packaging a new release).
2167 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2168 * configure.in: upgraded version number to 0.3.0
2169 * fixing build of rpm (through rpm -ta):
2170 - Doc/Makefile.am exports proper doxygen files
2171 - src/jpeg/libijg8/Makefile.am exports the include files.
2173 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2174 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2175 * src/gdcmHeader.h : formatting code
2177 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2178 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2179 We were obtaining error message from vtk. Now, creation of file list
2180 is made in an internal list to prevent this problem.
2181 Bug fix when output is empty.
2182 Bug fix in update of progress value. Previous commit for this was a bad
2184 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2186 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2187 * src/gdcmHeader.h : added method to get the file name
2188 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2189 files. Added method to remove all files on the input
2190 Added FIXME comment concerning the bad parsing of header made by
2191 ExecuteInformation method (in ExecuteData method)
2193 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2194 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2195 when using make instal.
2196 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2197 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2199 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2200 * setup.py : adding include dir of jpeg lib to compile all sources
2201 * */Win32/*.dsp : JPR fix for windows compilation
2203 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2204 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2206 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2207 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2209 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2210 * setup.py is again effective on un*x (takes into account the
2211 addon of the jpeg library)
2212 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2213 * Doc/Doxy* updated (includes above enhancements)
2214 * INSTALL now points to web documentation
2216 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2217 * src/gdcmHeader.h doesn't make unnecessary reference to
2219 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2221 * src/gdcm*.[cxx|h] :
2222 - to allow compilation with gcc 3.x
2223 -- clean up of STL usage (added explicit usage of std::)
2224 -- small fixes on exceptions.
2225 Note: linking not tested !
2226 - clean of doxygen comments to avoid warnings at documentation
2228 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2229 dependent convertion).
2231 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2232 * Clean up of previous JPR garbage commit (not even commented in the
2234 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2235 - moved all jpeg related files from src to src/jpeg/libijg8, with
2236 addition/modification of Makefile.am and configure.in.
2237 - the testSuite is still brain damage (not guilty).
2239 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2240 * WrapVTK.py : modifications to get correctly vtk source files to
2242 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2243 (FileName -> Filename)
2245 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2246 * vtk/vtkGdcmReader.[cxx/h]:
2247 - UpdateProgress method should now be effective
2248 - removed the limitation on having only images loaded (as opposed
2250 - when building a stack of images/volume, a lesser number of
2251 gdcmHeader and gdcmFile instances should be used (hopefully
2252 accelerating things).
2253 - when building a stack of images/volumes, files which are not
2254 loadable (wrong path-filename, wrong permissions on existing file,
2255 or file not parsable by gdcm) are replaced with a black image
2256 in the stack (for the caller to notice the problem).
2258 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2259 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2261 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2262 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2263 between standard library (std) and vtk library (problems are found
2264 under Windows... thanks Windows !)
2266 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2267 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2269 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2271 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2272 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2274 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2275 * When compiling with distutils (see setup.py) the C++ compiler is
2276 called with different flags than the default ones (with automake).
2277 In order to fix all those warning, I compiled gdcm with the command
2278 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2279 and went for warning fixes:
2280 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2281 up from unused variables.
2282 - vtk/vtkGdcmReader.cxx: potential bug fix.
2283 * src/gdcmHeader.h: Doxygen warning cleanup
2285 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2286 * gdcmPython/gdcm.i:
2287 - typemaps correction to take into account the systematic replacement
2288 of "using namespace std" with std:: prefix e.g. std::list,
2289 std::string... (cf changes of 2003-05-21).
2290 - gdcmGlob global variable of type gdcmGlobal (defined in
2291 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2292 exported to Python a as cvar.
2293 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2294 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2295 gdcmDictSet.GetPubDictTagNames() and
2296 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2297 C++ static methods).
2298 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2299 with the above changes.
2301 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2302 * setup.py, manifest.in : bug fix under linux
2304 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2305 * Modification of setup.py to compile vtk part too. Then, we have 2
2306 wrappers which must work with same distutils. For that, we have a
2307 generic distutils in distusiltsWrapping.py ; with :
2308 - build_extWrap class to wrap generically all extensions,
2309 - ExtensionWrap base class for all wrapping extension that contains
2311 - Wrapper interface which wrap sources
2312 + In WrapSwig.py we have extension and wrapper for Swig
2313 + In WrapVTK.py we have extension and wrapper for VTK
2314 * MANIFEST.in : modifications to consider vtk directory and new python
2315 files for compilation
2317 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2318 * Added python wrappers of vtkGdcmReader vtk class (see the
2319 source in vtk/vtkGdcmReader.cxx) :
2320 - vtk/Makefile.am now builds a library
2321 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2322 python library (as opposed to _gdcm.so wich are the python
2323 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2324 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2326 - configure.in has an additional flag --enable-vtk that needs
2327 to be set to enable compilation of vtk related code, that is:
2328 + vtk/vtkGdcmReader.so and
2329 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2330 + gdcmPython/vtkgdcmPython.so (see above)
2331 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2332 be read when compressed or when HighBit + 1 != BitsStored),
2333 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2334 the usage of the python wrapper of vtkGdcmReader vtk class.
2335 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2336 * src/*.[h] all occurences of stl classes are now prefixed with
2337 std::, and all occurences of "using namespace std;" where removed.
2338 This is to avoid pollution of global namespace in included files.
2339 Apparently vtk does not avoid this pitfall: when using both
2340 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2341 collision of various stl members (principally cout...).
2342 * gdcmPython/testSuite.py now cleanly removes temprory generated
2344 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2345 comply with above changes)
2347 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2348 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2349 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2350 vtk data structure (an image Flip was required).
2351 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2352 * cosmetic changes in documentation.
2354 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2355 * src/gdcmHeader.cxx: the constructor no longer exits when an
2356 unexisting file is given as argument.
2357 * The subdirectory Data (containing all the images used for the
2358 test suite) is not part of this repository anymore. A new module
2359 containing those images is now available at
2360 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2361 with the name gdcmData.
2362 All the python scripts (including the package initialisation file
2363 gdcmPython/__init__.py) were adapated to take this change into
2364 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2366 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2367 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2368 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2369 demo of the usage of this class.
2370 Compilation of this vtk part is only done when using the --enable-vtk
2371 at configure (or autogen.sh) stage.
2373 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2374 * More memory link related corrections and documentation fixes.
2376 - maximum info is obtained with a command of the form:
2377 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2378 --show-reachable=yes PrintHeader
2379 - the remaining reachable blocks seem to come from the STL
2380 allocation scheme through the usage of map and list. It looks
2381 like this memory cannot be freed but it is not a memory leak
2382 (in fact further invocation to the STL would recollect the
2383 unused memory allthough it cannot explicitely be freed).
2384 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2385 of displaying an image parsed with gdcm and displayed with VTK.
2386 Note: some images don't seem to work e.g.
2387 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2388 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2389 Allthough this weakens the semantics, it is a ditch attempt to
2390 make gdcm more thread friendly.
2392 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2393 * Memory link hunt (by using valgrind through the command
2394 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2395 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2396 gdcmHeader::_dicom_vr.
2397 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2398 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2400 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2402 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2403 * src/Makefile.am now exports all the necessary include files at
2407 * UpdateGroupLength replaced by new one
2410 * UpdateGroupLength re-written using H-Table
2411 (named UpdateGroupLengthNew untill checks are over)
2413 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2414 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2415 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2417 - gdcmHeader::GetPubElValSet removed.
2418 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2419 UpdateGroupLength, WriteElements, Write.
2420 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2421 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2422 carried the same semantics.
2423 - src/gdcmHeaderIdo.cxx changed accordingly.
2424 - gdcmFile::WriteBase now regroups all the codes from previous
2425 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2426 - enum FileType moved to gdcmCommon.h
2427 * src/gdcmHeader.cxx AddDefault trashed
2428 * gdcmGetXSize added
2429 * getimageDataSize now calls gdcmGetXSize
2430 * Test/*.cxx changed to agree with above changes
2432 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2434 (to avoid double call by end user).
2435 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2436 by end user, since gdcmHeader::gdcmHeader now handles it.
2438 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2439 * gdcm/Doc many doxygen changes:
2440 - Doxyfile now has two different versions, DoxyfileUsers that generates
2441 the html.users end users oriented documentation and
2442 DoxyfileDeveloppers that generates the html.developper developper
2443 oriented documentation.
2444 - README changed accordingly
2445 - requirement.txt removed (old design info moved to TODO).
2446 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2447 DoxyMainPage.txt, DoxyPython.txt provide more information.
2448 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2449 be updated by simply regenerating the docs with doxygen and copying
2450 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2451 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2452 all the tests in the form "if (<map>.count() >1)" were removed.
2453 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2454 ill-formed documentation sections.
2455 * src/gdcmHeader.cxx: ditto
2457 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * setup.py fixed for un*x (needed macro for stdint.h)
2459 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2460 un*ces with sh-utils test utility.
2461 * gdcmPython/demo/test.py renamed to PrintHeader.py
2462 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2463 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2464 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2465 * src/gdcm*.cxx JPR's bad inclusion fixed.
2467 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2468 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2469 * gdcmPython/demo/test.py changed accordingly.
2471 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2472 * gdcmPython/Makefile.am fixed linking against libstdc++
2473 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2474 * Swig subdir (historical tests of swig version 1.3.17++) removed
2475 * Test/testChangeEntete.cxx some lines commented out in order to make
2477 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2478 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2480 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2481 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2482 hence the user doesn't need this explicit call.
2483 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2484 i.e. LoadElements() call removed.
2485 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2486 - src/Makefile.am declares the proper flag for g++.
2487 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2488 for adding user defined new tags.
2489 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2490 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2491 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2493 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2494 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2495 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2496 src/Makefile.am : the project should properly compile and install
2497 with the autotools, included the python wrappers part.
2498 * gdcm.spec.in : added a spec file for RPM packaging.
2500 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2501 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2503 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2505 to exported to the environement (see gdcmPython/testSuite.py
2507 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2508 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2509 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2510 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2511 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2513 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * gdcmPython/__init__.py doesn't crash anymore when running in
2515 in InstallMode or PreInstallMode but with an environement given
2516 value of GDCM_DICT_PATH.
2517 * src/gdcmDictSet.[cxx/h] coding style.
2519 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2521 * src/gdcm.h general comments moved to TODO, and README
2522 * src/gdcm.h should now be seen as a user commodity (including it
2523 should suffice to fully use gdcm). It is nowhere including within
2524 any of the kernel files src/*.cxx and src/*.h.
2526 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2527 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2528 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2530 * src/gdcm*.cxx only include their corresponding include file
2531 (as opposed to gdcm.h)
2532 * gdcmPython/gdcm.i changed accordingly
2533 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2534 the autogen.sh generated "make snapshot" command to work.
2535 * autogen.sh removed history related references to crea package.
2537 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2538 * distutilsSwigCPlusPlus.py work around some swig portability
2541 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2543 was done in a last ditch attempt to get setup.py _really_
2544 operationnal. The python/gdcmPython layaout add the advantage
2545 of hidding away the python related distutils specific files
2546 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2547 Alas, the src directory was out of scope (i.e. it's relative
2548 position to setup.py was ../src) which made things impossible to
2549 handle (see previous version of python/setup.py). Crossing fingers...
2551 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * python/setup.py now works on Un*x. (harder than I thougth)
2553 * python/distutilsSwigCPlusPlus.py can now have include files
2554 among the list of sources.
2556 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2557 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2558 * modifications in MSVC projects
2560 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * As stated by the first lines of Test/ExceptionAndPython/README, it
2562 looks like we can move back to original usage of exception within
2563 src/gdcm* and hence remove the errno stuff that was introduced
2564 as a quick and dirty fixture of this problem (added to the TODO).
2565 * Doc/Doxyfile configuration file for Doxygen and corresponding
2566 README file for usage added.
2567 * Test/testWrite.cxx added. This new test comes from a split of
2568 test.cxx that is now reverted to its original purpous i.e.
2569 testing the proper parsing of a Dicom related file.
2570 testWrite.cxx concentrates on testing the IO part of gdcm.
2571 * Test/bug1.cxx (containing a bug on WIn32) added.
2572 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2573 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2574 whose purpose is to publish the content of the TagNames of the
2575 Dicom public dictionnary were not accessible without an
2576 instance of class gdcmHeader.
2577 - those methods are now static methods of gdcmDictSet and hence
2578 require no instances at all to be invocated.
2579 - within gdcmDictSet this change required to change some method
2580 to class methods (i.e. are now static) among which SetDictPath
2581 (renamed to BuildDictPath) and LoadDefaultPubDict.
2582 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2583 the above changes by calling the new method classes of gdcmDictSet.
2584 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2585 the above to be effective.
2586 * python/gdcmPython: in order to wrap properly the above changes
2587 for Python, swig version now needs to be > 1.3.17.
2588 * python/gdcmPython/Makefile fixed to adapt itself to new
2589 configure/make shema introduced by Johan Montagnat (thanks for the
2590 contribution). Alas this Makefile cannot be turned into a proper
2591 Makefile.am without some heavy changes in the configure.in
2592 (for python dectection).
2593 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2594 now avoids publishing the empty entries.
2596 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2597 * python/setup.py : bug fix concerning install under windows
2598 ExtraPath reused :-P
2599 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2601 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2602 * Dicts/dicomV3.dic : remove double spaces !!!
2603 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2604 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2607 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2608 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2609 method. Doxygenation.
2610 * src/gdcm.h clean up of JPR spurious comments.
2612 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2613 * python/distutilsSwigCPlusPlus.py now properly collects the
2614 shadow classes generated by "swig -c++" (gdcm.py in our case)
2615 when using "python setup.py install".
2616 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2617 reexports the working classes.
2618 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2619 by the classical C errno scheme. This is to prevent an obscure
2620 behavior of the python wrappers when importing wxPython.wx prior
2621 to gdcmPython (which ended up in an abort call). An illustration
2622 of this oddity can be found in the Test/ExceptionAndPython
2623 subdir (see the README file). This problem probably due to
2624 an combination of g++ and dynamic loading.
2625 * added Test/ExceptionAndPython (see above)
2627 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2628 * Changed the layout of the python part to avoid bloating main
2629 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2630 i.e. the distutils arsenal. All the python related stuff is
2631 again in a python subdir, but the package itself is now in
2633 * setup.py was cleaned up:
2634 - pythonIncludePath removed
2635 - python setup.py bdist target is now functional.
2636 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2637 collision with other packages). gdcmPython/demo/*.py changed
2640 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * python subdir moved to gdcmPython (preparation of distutils packaging).
2642 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2643 distutils installer is operational.
2644 * - gdcmPython/__init__.py now properly loads the swig generated
2645 shadow classes (from gdcm.py).
2646 - gdcmPython/demo/*.py changed to import the package gdcmPython
2647 instead of gdcmPython/demo/load.py.
2648 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2650 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2651 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2652 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2653 entries within the associated public Dicom dictionary resp. the same
2654 information but sorted by the fourth field (PAT, IMG, DIR) of the
2656 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2657 are now in the "???" group.
2658 - python/gdcm.i changed accordingly,
2659 - python/demo/printGroupedPublicDict.py added, that gives an example
2660 of the above new functionalities in Python.
2662 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * src/gdcm.h, gdcmHeader.cxx:
2664 - historic references to glib's g_malloc and g_free (#defined)
2665 were definitively removed.
2666 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2667 * src/gdcmElValSet.cxx:
2668 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2669 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2670 - GetElValue(string) renamed to GetElValueByName.
2671 - Added GetElementByName(string).
2672 * src/gdcmHeader.cxx: added
2673 - GetPubElValRepByNumber(guint16, guint16)
2674 - GetPubElValRepByName(string)
2675 - GetShaElValRepByNumber(guint16, guint16)
2676 - GetShaElValRepByName(string)
2677 - GetShaElValByNumber(guint16, guint16)
2678 - GetShaElValRepByName(string)
2679 - GetElValRepByNumber(guint16, guint16)
2680 - GetElValRepByName(string)
2681 - GetElValByNumber(guint16, guint16)
2682 - GetElValRepByName(string)
2683 * Doc/requirements.txt added.
2685 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * Test/Makefile building now depends on the one of libgdcm.so
2687 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2688 pixel data) aware which enables finding the address (offset) of
2689 the pixel data of JPEG encoded DICOM files. This leaves only a single
2690 file in the testSuite whose pixel data address (offset) is unknown.
2691 * python/testSuite.py changed accordingly.
2693 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2694 * VC++ has some strong limitations when working with the STL, as stated
2695 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2696 "Also note that some STL containers (map, set, queue, list, deque)
2697 cannot be exported. [...]
2698 Some STL classes contain nested classes. These classes can not
2700 This is caused by a designed limitation that once a template
2701 class is instantiated, it can not be re-instantiated and
2703 Since our usage of map<> is ubiquitous in gdcm, this "designed
2704 limitation" of VC++ is a pitfall.
2705 Hence the Python wrappers of gdcm cannot be incrementally linked
2706 against the c++ dynamic library. The dirty but only workaround is
2707 to forget about incremental link of dynamic libraries and to generate
2708 the Python wrappers library with the inclusions of the underlying C++
2710 The following modifications concern this matter on Win32/VC++:
2711 - wrapping python correct with standalone wrapped dll (don't use separate
2712 dll under windows !!!!)
2713 - python21_d debug mode enabled (ask Frog how to use it :-)
2714 - NO problem with having an STL member of class for example string in C++
2715 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2716 - Python test of dcmlib in Python is ok under windows on a large set
2718 * removed glib references
2719 * typedef's inserted in gdcm.i for correct swig type management
2721 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2722 * python/demo/*.py load.py extracted from test.py. Added explore.py
2723 that only displays required tags and testAll.py that parses all
2724 the files of the testsuite without using unittest.
2725 * python/testSuite.py other additional test on new files added.
2726 * Data/* new test files added accordingly to the testSuite.
2727 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2728 the vr in the file differs from the one of the dictionary.
2730 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2732 values, but limits itself to values which are below a user specified
2733 size (by default 1024 bytes).
2734 * python/gdcm.i : elements not loaded (because their size is above the
2735 user specified treshold) are exported with their TagKey as key of the
2736 python dictionary. This enables the testsuite to make some checks
2737 on the unloaded elements (since we have their offset and size).
2738 * python/testSuite.py
2739 - now tests for the existence and proper value of the pixel data
2740 - two new examples added.
2741 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2743 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2744 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2745 aware. See the strategy comments in gdcmHeader::FindeLength().
2746 * Test/test.cxx now accepts a filename as first argument.
2747 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2748 * python/testSuite.py changed to integrate test on above files.
2750 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2751 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2752 the vr was also RET.
2753 * python/testSuite.py more tests added.
2755 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * python/testSuite.py unittest test suite added (uses Data)
2757 * Data/* dcm and acr files for the test suite.
2758 * glib dependance removed from un*x version. We now use ISO C99
2759 7.18 Integer types (see stdint.h)
2760 - python/Makefile, src/Makefile src/gdcm.h
2761 * src/ when an explicit vr (like dicom files) suddenly poped an
2762 implicit element we use to mark the underlying DictEntry of the
2763 concerned ElValue with "Implicit". This strategy was damageable
2764 too the public or provite dictionaries, since some of their vr
2765 would be changed. Since Header::FindLength heavily relies on the
2766 detection by Header::FindVR of falsely explicit elements, I
2767 added an extra ImplicitVr member to ElValue (boolean).
2768 The rest of the changes we the necessary adaptations.
2770 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2773 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2775 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * Adaptation for porting to VC++:
2778 o forced to use std namespace (for string to be known)
2779 o all class use __declspec export style on WIN32
2780 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2781 (in stdlib.h on Win32 but in std:: for gcc)
2782 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2783 variable GDCM_DICT_PATH.
2784 * src/gdcmHeader.cxx verbose comments made discrete.
2786 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * python/gdcm.i: added a typemap that converts a C++ hashing table
2788 to native Python dictionary.
2789 * python/demo/test.py:
2790 - now uses the native dictionary for exploration of gdcmHeader.
2791 - takes an optional filename argument (the file to parse).
2792 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2793 PubElVals hashing table.
2794 * Dicts/dicomV3.dic removed error prone trailing spaces.
2796 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2797 * Python wrapping process moved away from src/Makefile to
2798 newly created python/Makefile (as well as gdcm.i)
2799 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2800 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2801 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2802 from the environement variable GDCM_DICT_PATH (when existing).
2803 * src/gdcmDict::GetTag bug fix.
2805 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * Straightforward temporary fixes for swig to build the python wrappers.
2807 src/Makefile now has a python working entry [by working we mean
2808 that we can import de shadow classes without errors].
2810 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2811 * hashtest.cxx removed (since allready in Test)
2812 * src/gdcmlib.h renamed to src/gdcm.h
2813 * src/dcm.i renamed to src/gdcm.i
2814 * src/Makefile prepared for python wrapping
2816 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * src/gdcmHeader.cxx :
2818 - Parsing of header is now separated from loading of element values
2819 (see gdcmHeader::LoadElements).
2820 - general clean up of hopefully all file access (creation of
2821 ReadInt16 and ReadInt32)
2823 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2824 * src/gdcmHeader.cxx :
2825 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2827 - SetLgrElem renamed to SetLength
2828 - GetLgrElem renamed to GetLength
2829 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2830 * src/gdcmElValSet.cxx fixed both GetElValue methods
2831 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2832 due to IdoDude was cleaned out.
2834 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2835 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2836 concentrates on finding the value representation (when it exists).
2837 RecupLgr now only finds the element value length, and it avoids
2838 returning the unecessary skL (skipped length).
2839 Also, offsetCourant was simply removed (with taille_fich) since
2840 it was redundant with the File position internals (by using
2841 ftell and fseek). This also made skL (see above in RecupLgr) usage
2843 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2844 on the libido specificities which are handled through class
2846 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2849 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2850 * Truckload of changes. Parsing of header is barely functional
2851 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2853 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2854 * src/gdcmHeader.cxx many addons of low level methods
2856 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2857 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2858 and _IdDcmSWAP_LONG.
2860 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * This corresponds to all the changes decided at the meeting of
2862 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob