1 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
3 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
5 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
6 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
7 displayed on Win32 when a brutal abort() occurs (because of uncatched
8 exception). See TODO new entry of this commit for more on this.
9 * TODO added new entry.
10 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
11 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
12 - HandleColor is no longer called from gdcmFile.cxx
13 - gdcmPixelConvert.cxx clean up on method arguments and internal
14 variable names for semantical coherence.
16 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
17 * Finished lossless transition, not only do we now read all lossless jpeg
18 images, without the need of the Cornwell lib, but we do read them properly now
19 * To reduce code (well to avoid code duplication), I defined a common place
20 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
21 redefine symbols. This is not prefect but this the best solution I found for a
22 compilation time jpeg option.
24 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
25 * Update jpeg ijg lib to support lossless jpeg implementation
26 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
28 * Also added a special copyright for dcmtk since we use their bugfixes.
31 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
32 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
33 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
34 matters, as stated in warning note at begining of %include section).
35 * src/gdcmDicomDir*.[cxx|h]: coding style
36 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
37 * src/gdcmJpeg8.cxx: doxygen fix.
38 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
39 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
40 from File:: to PixelConvert::.
42 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
44 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
45 - more code moved away from File:: to PixelConvert::
46 - fat setup of PixelConverter set in place in File::Initialise.
48 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
49 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
50 namespace at the file system level. So now you should convert your examples
52 gdcmHeader -> gdcm::Header
53 It would be nice if people keep in mind to no open the namespace, since it
54 allows compilation on broken plateform which were defining common symbol in
55 the standart namespace (like LP, Unknown ...)
57 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
59 The JPEG fragments are now parsed at the same stage than the RLE
60 information. All code related to JPEG is now in gdcmPixelConvert:
61 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
62 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
63 export a gdcmFile:: method. Those are simply global functions
64 (for the time being this is better than having them attach to
65 either gdcmFile:: or gdcmPixelConvert::).
66 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
67 and stores the result in a gdcmJPEGFragmentsInfo.
68 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
69 code (among other stuff) moved away from gdcmFile:; to
72 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
74 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
75 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
76 clean up of RLE related code.
77 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
78 - src/gdcmRLE.cxx removed
79 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
80 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
81 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
82 * CLEANUP_ROUND (9) for gdcmPixelConvert
83 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
84 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
85 away from gdcmFile:: to gdcmPixelConvert::.
87 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
88 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
89 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
90 This is because Parse7Fe0 used to parse the pixels to compute the
91 length. This task was passed over to FindDocEntryLengthOB() a long
92 time ago, EXCEPT I had forgotten the OW case...
93 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
94 we just recylce the code for parsing RLE fragments and computing
96 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
97 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
98 with the retired Parse7Fe0().
99 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
100 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
102 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
103 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
104 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
105 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
106 - src/CMakeLists.txt: alphabetic order reodering + new entries.
107 * CLEANUP_ROUND (4) for gdcmPixelConvert
108 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
109 to return an unused length.
111 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
112 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
113 this should be cleanner from the plane view. The iostream are erally a pain
114 to use to do simple stuff.
116 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
117 * Redo the compilation of the ijg jpeg library. Now only one source is
118 necesseray. No need to rename file by hand what so ever. CMake handle the
119 copying of the file within different directory, configure header file to
120 modify some symbol. The only addition made to ijg wasd a mangle table so
121 that symbol are different wether we are within 8bits or 12bits.
123 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * Added documentation of vtkgdcmReader on Website:
125 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
126 with it's binary name).
127 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
128 the Website to be more complete.
129 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
130 doxygenated documentation.
131 - Doc/DoxyVtkGdcmReaderExamples.txt added
132 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
133 DoxyVtkGdmReaderExamples.html )
134 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
135 * CLEANUP_ROUND (3) for gdcmPixelConvert
136 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
138 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
139 * CLEANUP_ROUND (2) for gdcmPixelConvert
140 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
142 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
143 * CLEANUP_ROUND for gdcmPixelConvert:
144 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
145 - src/gdcmPixelStuff[h|cxx] removed
146 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
147 - src/CMakeLists.txt changed accordingly
149 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
150 gdcmVersion.py moved to newly created ATTIC related
151 gdcmPython/SetupOldies/ directory.
152 * Autotools clean up:
153 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
154 - autogen.sh configure.in acinclude.m4 python.m4 removed
156 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * src/*.cxx *.h Reference to License.htm fixed to License.html.
158 * Doc/CMakeLists.txt, doxygen.config.in: fix.
159 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
161 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
162 * TODO updated with Mathieu suggestions. I proposed a template for
163 describing TODO entries and used it for new entries.
164 * Added Doc/Website/CodingStyle.html, Developpers.html,
165 DeveloppersPython.html, GdcmDataCvs.html and
166 DownloadVersion0_1.html, DownloadVersion0_3.html.
167 * Some Doc/*.txt Doxygen files (which do not really concern the
168 documentation itself, but the website) moved to html and
169 placed in directory Doc/Website:
170 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
171 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
172 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
173 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
174 * CMakeLists.txt changed accordingly.
175 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
176 DeveloppersPython.html
177 * INSTALL nows refers to Doc/Website/Installation.html
179 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
180 * Added Doc/Website directory, that contains a first raw version
183 2004-09-23 Jean-Pierre Roux
184 * FIX In order not to be poluted any longer by casting problems,
185 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
186 we can now delete[] it safely
187 * VoidArea is now called BinArea (less confusing name),
188 and all the methods called ...VoidArea... are now ... BinArea...
189 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
191 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
192 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
193 clear) TagHT, which is an inherited member of gdcmElementSet. It is
194 up to the destructor of gdcmElementSet to clean up TagHt and it's
197 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
198 * Test/CMakeLists.txt: update to follow gdcmData renamings.
199 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
201 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
202 * ENH: added some utility method that builds a flat dictionnary
203 holding all the Dicom entries contained in the recursive structure
204 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
206 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
207 BuildFlatHashTable() that build a flat dictionary.
208 - src/gdcmElementSet.h: added a new private GetTag() accessor.
209 gdcmDocument is now a friend of gdcmElementSet.
210 - src/gdcmElementSet.cxx: clean up.
211 - Example/FlatHashTablePrint.cxx added.
212 - Example/CmakeLists.txt changed accordingly
214 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
215 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
216 moved away from gdcmDocEntrySet (since this class is an abstract class
217 acting like an interface). SQDepthLevel and BaseTagKey are now
219 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
220 and associated accessors. Doxygenation of the class.
221 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
223 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
224 Use SQDepthLevel accessor instead. ::Print() adapted.
225 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
226 - src/gdcmDocument.cxx changed accordingly.
228 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
229 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
230 - The following is the doxygen comment of the typedef declaration
231 of gdcmagKey in src/gdcmCommon.h:
232 gdcmTagKey is made to old an "universal" (as in URL, Universal
233 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
234 A dicom tag allways has a group and an element, but a set of tags
235 embeded in various (optionally nested) sequences and sharing
236 the same group and element all share the same (group, element)
237 "identifier". Hence the (group, element) cannot be used as an
238 identifier (in gdcm we shall refer to a "TagKey") of a tag.
239 In order to construct a proper tag identifier (i.e. a key) we
240 consider the following definition of a TagKey:
241 - let Group, Element be the string representation of the
242 group and element dicom tag members,
243 - let ItemNumber be the string representation of the integer
244 index of the considered item number of a sequence,
245 Let the key of a tag embeded in a sequence, noted SeqTag, be
247 /ItemNumber#Group|Element
248 where "/", "#" and "|" are characters acting as separators.
249 Then the general form of a gdcmTagKey is given by:
250 Group|Element<SeqTag>
251 where <SeqTag> means NO or many instances of SeqTag.
252 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
255 but the gdcmTagKey of a tag "embeded" is the first item of
256 a sequence, itself nested in the third item of a sequence is the
258 0004|1220/2#0008|0082/0#0008|0090
259 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
260 order to hold the new sequence compatible key. Previously, the
261 GetKey() method would look in the underlying gdcmDictEntry.
262 - src/gdcmDocEntry.cxx:
263 -- constructor now copies the underlying DictEntry key, in the local
265 -- ::Print: displays the member Key, instead of the (group, element).
266 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
267 - src/gdcmDocEntrySet.h:xi
268 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
269 -- now has a new BaseTagKey member.
271 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
272 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
274 This poses the problem with the semantics of the following lines
275 LoadEntryVoidArea(0x0028,0x1201); // R LUT
276 LoadEntryVoidArea(0x0028,0x1202); // G LUT
277 LoadEntryVoidArea(0x0028,0x1203); // B LUT
278 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
279 to the long FIXME note for what the problem is. Nevertheless in
280 order to get things working the dicom dictionary was altered !
281 Please fix things urgently...
282 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
283 information), see above note on moving the member VoidArea. Nevertheless
284 the following entries previously correctly set as US are now inproperly
286 0028 1201 OW IMG Red Palette Color Lookup Table Data
287 0028 1202 OW IMG Green Palette Color Lookup Table Data
288 0028 1203 OW IMG Blue Palette Color Lookup Table Data
289 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
290 of gdcmDocEntry moved to gdcmSeqEntry.
291 * src/gdcmSeqEntry.cxx: STYLE.
293 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * Test/TestAllEntryVerify.cxx minor fix and added comments.
296 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
297 * gdcmPython/testSuite.py: all the test suite in python is now moved
298 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
299 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
300 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
302 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
304 to avoid inclusion recursion until STL is reached.
305 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
306 mecanism. errno.h is not included in gdcm anymore.
307 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
308 (gdcmFormatError now inherits from gdcmFormatUnexpected).
310 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
311 gdcmData/TestAllEntryVerifyReference.txt
312 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
313 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
314 exception_on_error parameter.
315 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
316 - vtk/vtkGdcmReader.cxx changed accordingly,
317 - Example/*.cxx and Test/*.cxx changed accordingly.
319 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
321 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
322 enable_sequences removed from gdcmHeader constructor and dependencies.
323 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
324 * gdcmPython/demo/PrintHeader.py: dummy fix.
325 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
326 skip_shadow removed from gdcmHeader constructor and dependencies.
327 * Example/*.cxx and Test/*.cxx changed accordingly.
329 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
330 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
331 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
333 2004-07-21 Jean-Pierre Roux
334 * FIX Now, Parsing and Printing a DICOMDIR do work!
335 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
337 2004-07-20 Jean-Pierre Roux
338 * FIX Some brain damaged headers have Zero-Lenght fields
339 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
341 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
343 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
344 variable (instance of gdcmDebug) by a definition macro, and the instance
345 is now in static in the gdcmDebug class
346 * src/gdcmSQItem.h : (FIXME) remove an undefined method
347 * Test/PrintAllDocument.cxx : bug fix in the result of the test
349 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
350 * WARNING: ctest now depends more tightly on gdcmData. You should
351 check out gdcmData properly for things to run smoothly...
352 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
353 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
354 we need the pixels not be loaded in order to use the ValEntry
355 that displays position and size).
356 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
357 This is a C++ based equivalent of gdcmPython/testSuite.py that should
358 be deprecated. If you have any doubts about the advantages of a
359 modern scripting language (read Python) versus grass root C++ (i.e.
360 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
361 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
362 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
363 Anyhow, consider documenting the gdcmData images in
364 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
366 * Test/CMakeLists.txt:
367 - now uses TestAllEntryVerify.cxx
368 - specific comments on oldACR00001.ima (now renamed in gdcmData
369 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
370 gdcmData/TestAllEntryVerifyReference.txt
373 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * src/*.[h|cxx] : typedef clean up
375 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
376 - TagKey renamed to gdcmTagKey (for external usage)
377 - VRKey renamed to gdcmVRKey (for external usage)
378 - removal of typedef duplication.
379 - Removed all unecessary inline keyword from class inline definitions.
380 - Some method|function(void) declarations replaced with method|function().
381 * src/jpeg/libijg12/jdhuff12.c:
382 - printf polluting ctest removed.
383 - TAB removal for comminting
385 - TestAllReadCompareDicom.cxx: added a test that compares all the
386 images in gdcmDataImages.h with corresponding images in
387 gdcmData/BaselineDicom/. When baseline images are not present
388 this test creates them.
389 Note: we need to validate each reference image, but before that
390 I'd like to rename them with a more explicit name...
391 - CMakeLists.txt: changed accordingly.
392 * Example/*.cxx: examples now only include gdcm.h (as opposed to
393 including each header needed).
395 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * Test/*.cxx and Example/*.cxx: moved some examples away from the
397 test suite to the Example directory. Are concerned:
402 - TestWriteSimple.cxx
403 * Test/CMakeLists.txt: added some comments on reasons for black listing
404 image gdcmData/oldACR00001.ima
406 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
407 * Test/CmakeList.txt: removed the following from black list (to be coherent
408 with removal from gdcmData):
409 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
410 - gdcm-MR-PHILIPS-16.dcm
412 Added the following because after last cvs update, they cause
413 ctest -R TestReadWriteReadCompare
415 - gdcm-MR-SIEMENS-16-1.acr
417 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
418 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
419 new comments in this file) we temporarily (sigh) move to a weaker
421 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
422 we don't need to black list the following images anymore:
423 - 8BitsUncompressedColor.dcm
425 - US-PAL-8-10x-echo.dcm
426 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
427 fixes and the beautified code ;-)
428 This fixes the bug introduced in version 1.42 (when beautifying)
429 that made the parsing of 8BitsRunLengthColor.dcm unproper.
430 Note: ctest was blind to this bug (this means we need to still
431 improve the test suite). The bug could be detected by using
432 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
434 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
435 and by displaying the (garbage) produced file temp.XDCM...
437 2004-06-29 Jean-Pierre Roux
438 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
439 - replace by uggly but working old code :-(
440 A lot of things should be OK again.
441 It's really urgent to have a test suite that *tests*,
442 to prevent Frog's beautifying sessions to break all the stuff
443 (twice, withing a fortnigh ...)
445 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
446 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
447 redundancy) to added Test/TestReadWriteReadCompare.cxx
448 * Test/CmakeList.txt: because the compare test of
449 Test/TestReadWriteReadCompare.cxx fails, the following images are
450 black listed: - 8BitsUncompressedColor.dcm
452 - US-PAL-8-10x-echo.dcm
453 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
454 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
455 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
456 and ad-hoc kludge. This kludge is now removed, and on encountering
457 such an image (OB field brain damaged) we set errno. Then in
458 ::FindDocLength() we "fix" the length as being ALL what remains
459 in the file (until EOF). We then proceed, hoping for the best...
460 This fixes a SegFault in ShowDicom when trying to write such an
462 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
463 (because TestWriteRead breaks on it, after a non conformal commit?).
464 ctest now runs properly, except for MakeDicomDir (which was allways
465 broken) and the Python related stuff (still not fixed).
467 2004-06-24 Jean-Pierre Roux
468 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
469 FIX : Test/TestReadWrite now iterates on all the file names
470 (instead of infinite loop)
471 ENH : Test/TestWriteRead now iterates on all the file names
473 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
474 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
476 2004-06-24 Jean-Pierre Roux
477 FIX : - now Write drops LUT Descriptors and LUTs (if any)
478 when SamplesPerPixel =3
479 - now Write is no longer confused by
480 'BitsAllocated = 12" and 'BitsStored=12"
481 - "UN" value representation Elements are now written correctly
482 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
483 ENH : - now gdcmHeader has its own Write methods
484 (in order to split the job that has not to be done
487 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
489 loop on the same image until memory went out.
490 Note: this means we still have gobs of memory loss in PrintDocument
491 * src/gdcmDocument.cxx: fixes problem on parsing on file
492 gdcmData/16BitsJpegLosslessGrayScale.dcm.
494 2004-06-24 Jean-Pierre Roux
495 FIX : Write - All the Sequences and Sequence Item are now written
496 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
497 is added a the end, when necessary.
498 - A lot of brain-damaged images, that were read correctly are
499 now written correctly
500 - length compatible BinEntry are now loaded correctly
501 (even for odd groups)
502 Note : only Explicit Value Representation was checked.
503 (question : is implicit VR really necessary for gdcm ?)
505 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * DEVELOPPER: added a proposition of coding style.
507 * src/gdcmDocEntry.h: removed every inline declaration (for test of
510 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
511 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
512 Use the gdcmDocEntry::Print() and Write() instead.
513 * src/gdcmDocument.cxx: bug fix.
515 2004-06-22 Jean-Pierre Roux
516 FIX : gdcmDocument.cxx
517 - Now we do recognize the JpegLossLess format (there was a misstyping in
518 code 'beautyfication' :-(
519 - Now we automaticaticaly load the Luts, if any
521 2004-06-22 Jean-Pierre Roux
522 In order : to write Sequences, whatever their imbrication level,
523 : to allow user to create his own Sequences
524 a lot of modif where necessary (adding, moving, or virtualising methods)
526 WARNING : save your own sources *before* cvs up !
529 ADD virtual void Write(FILE *fp, FileType filetype);
532 ADD virtual void Write(FILE *fp, FileType filetype);
533 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
536 ADD virtual void Write (FILE *fp, FileType filetype)=0;
537 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
538 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
539 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
540 ADD std::string GetEntryByName(TagName name);
541 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
543 std::string vr = "unkn",
544 std::string fourth = "unkn",
545 std::string name = "unkn");
546 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
547 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
548 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
549 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
550 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
551 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
552 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
553 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
556 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
557 ADD virtual std::string GetEntryByName (TagName tagName);
558 ADD virtual std::string GetEntryVRByName (TagName tagName);
559 REM virtual bool Write(FILE *, FileType);
560 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
561 FILE *_fp, FileType type);
562 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
563 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
564 REM virtual bool WriteEntries(FILE *_fp,FileType type);
565 REM virtual std::string GetEntryByName (std::string tagName);
566 REM virtual std::string GetEntryVRByName (std::string tagName);
567 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
568 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
569 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
571 std::string vr = "unkn",
572 std::string fourth = "unkn",
573 std::string name = "unkn");
574 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
575 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
576 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
577 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
580 ADD virtual void Write(FILE *fp, FileType filetype);
583 ADD virtual void Write(FILE *fp,FileType filetype);
586 ADD virtual void Write(FILE *fp, FileType filetype);
587 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
588 REM std::string GetEntryByNumber(guint16 group, guint16 element);
589 REM std::string GetEntryByName(TagName name);
592 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
594 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
595 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
596 The default constructor invoked by the line
597 gdcmHeader *f1 = new gdcmHeader( header );
598 was gdcmHeader::gdcmHeader(bool) instead of the expected
599 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
600 Hence the parsing wasn't executed... See also below.
601 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
602 as explicit constructor didn't do the trick to fix the above problem.
603 Could anyone explain why ?
604 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
605 properly calls gdcmValEntry::Print() (that was weed out from
606 code related to gdcmBinEntry).
608 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
609 * In order to fix memory leaks:
610 - Test/TestWriteSimple.cxx: added cleaning of free store through
612 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
613 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
614 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
615 (through the call to ::AddDicomDirMeta()) or the destructor
616 would crash when deleting uninitialized ::metaElems].
617 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
618 - src/gdcmDocument.cxx:
619 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
621 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
622 was causing memory leaks.
623 - src/gdcmSQItem.cxx:
624 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
625 cleanly handled with polymophism: sorry but my milage is low).
626 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
627 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
628 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
629 This avoids SegFaulting.
630 - src/gdcmSQItem.h: coding style.
632 - Test/TestWriteSimple still severely sucks. The output image content
633 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
634 damaged when displayed with vtkgdcmViewer.
635 - on memory leaks: TestWriteSimple leaks really less (see entry
636 of 2004-06-18 in Changelog file for the call to valgrind).
637 - on segfaults: ctest now passes all the tests but one (no more
639 * Erroneous leading white fix:
640 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
641 white[s] (as opposed to from >> xxx, that removes it [them].
642 - src/gdcmTS.cxx: ditto.
643 - gdcmPython/testSuite.py: dirty related kludge removed.
644 * src/*: remaining references to gdcmParser removed.
645 * src/*[cxx|h]: added copy[way]left header.
648 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
649 * In order to fix writing of dicom files:
650 - Test/TestWriteSimple.cxx: a simpler example of writing.
651 - Test/CMakeLists.txt changed accordingly.
652 - src/gdcmDocument.cxx:
653 -- The destructor now recursilvely removes potential sequences.
654 -- Bug fix in ::IsJPEG2000()
655 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
656 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
658 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
659 to only declared) and build on top of
660 ::GetDocEntryByNumber(guint16, guint16).
661 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
662 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
663 for usage in destructor and treatement of promotion in
664 ::ReplaceOrCreateByNumber().
665 - src/gdcmSQItem.cxx: destructor should better handle his job.
666 Test/TestWriteSimple now runs (or at least it DOES something).
667 * We can now start hutting memory links. A good starting point is:
668 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
669 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
670 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
672 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * Valgrind note: after Mathieu Malaterre teached me how to read
674 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
676 Using gcc, you can force the STL to use malloc and to free memory as
677 soon as possible by globally disabling memory caching.
678 With 3.2.2 and later, you should export the environment variable
679 GLIBCPP_FORCE_NEW before running your program.
680 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
681 simply vanish (it is still not clear to me, whether this means that
682 STL std::string leaks or if valgrind believes it leaks...).
683 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
684 running bin/gdcmTests makeDicomDir):
685 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
686 - Test/makeDicomDir.cxx now properly traps empty lists and returns
688 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
689 SegFaulting (I drowned in DicomDir related code when trying to
690 understand why the list is empty...).
691 * src/gdcmDocument.h: first BSD license header try.
692 * Doc/License.txt added.
694 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * src/gdcmDocument.[h|cxx]:
696 - Clean up of the Transfer related predicates. They are now all based
697 on new method isGivenTransferSyntax, that (should) handle properly
699 - general clean up, simplification, and coding style.
700 - Specific clean up of Parse7FE0() (umproperly named actually).
701 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
703 2004-06-14 Jean-Pierre Roux
705 - fix the display of Sequence Delimitor (SQDepthLevel pb)
706 - fix the display of SQItem ordinal number
707 - add the GetSQItemByOrdinalNumber method
708 - remove some useless never written private methods
710 2004-06-14 Jean-Pierre Roux
712 - adding a constructor taking a gdcmDocEntry as an input param
713 - ReplaceOrCreateByNumber now returns :
714 a gdcmBinEntry * if a Binary (void *) value is passed as a param
715 a gdcmValEntry * if a string value is passed as a param
717 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
718 according to the param type (no longer sets a gdcmDocEntry)
719 - GetValEntryByNumber, GetBinEntryByNumber added
720 - NewValEntryByNumber and NewBinEntryByNumber added
722 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
724 - GetSQItemNumber and SetSQItemNumber added, to provide
725 a (relative) Item identier inside a given Sequence
726 \warning : some pb remaining around this number
728 - AddEntry now takes the Item Number as a param
730 - adding a constructor taking a gdcmDocEntry as an input param
732 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
733 * Memory leak hunt with the following command:
734 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
735 --show-reachable=yes gdcmTests PrintDocument
736 It looks like many (all?) leaks are due to the STL (or a bad usage
737 of the STL. The lines producing the leaks now have a comment with
738 a "MEMORY LEAK" tag: you can retrieve them with
739 grep "MEMORY LEAK" src/*
740 Here are two typical examples which I can't help fixing:
745 char * test = "babo";
746 name = test; //// <--- valgrind detects 960 bytes lost in
747 //// call to std::string::operator=(char const*)
748 name.clear(); //// Doesn't help !
756 std::cout << "Type a bunch of characters followed by RETURN: ";
757 getline(std::cin, line); //// <--- valgrind dectects a loss
758 //// of 1320 bytes in call to
759 /// std::basic_istream<>& std::getline<>
765 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
766 * src/gdcmHeader.[cxx|h]:
767 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
768 and related, moved away to gdcmDocument.
769 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
770 the corresponding protected accessors of inherited class
771 gdcmDocument, removed ! As a consequence gdcmFile had to be
772 declared friend of class gdcmDocument (see below).
773 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
774 - Clean up of undefined or unused methods.
775 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
776 account the changes to gdcmHeader.h).
777 * src/gdcmDocument.h:
778 - gdcmFile is now a friend class (in order to take into account the
779 changes to gdcmHeader.h).
780 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
781 (see changes to gdcmHeader.h).
782 - Accessors (reading on the form GetEntry*) are now public.
783 - Clean up of undefined or unused methods.
784 * src/gdcmDocument.cxx:
785 - adaptation to changes to gdcmDocument.h
786 - ::OpenFile now writes a verbose message when file cannot be opened.
787 - some std::string properly set to VRKey
788 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
789 references to gdcmDocument.
790 * Test/TestFindTags.cxx: changed accordingly to above changes.
791 * gdcmPython/testSuite.py: adapted to renaming of acr files in
792 cvs repository gdcmData.
794 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
795 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
796 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
797 conflicts with gdcmValEntry::voidArea.
798 * src/gdcmValEntry.cxx: unmatching comment wiped out.
799 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
800 Value representation between StringRepresentable and BinaryRepresentable.
801 * src/gdcmDocument.cxx:
802 - method ParseDES: proper indentation restored and usage of
803 gdcmVR::IsVROfGdcmStringRepresentable wired in.
804 - method LoadDocEntry: the fingerprint left in the SetValue() of
805 unloaded entries (length > MaxSizeLoadEntry) had curiously been
806 removed. Reverting to previous code segment with the proper
807 dynamic_cast< gdcmValEntry* >.
808 Note: this was (partially) breaking the python test suite
809 (gdcmPython/testSuite.py) that made usage of the above
810 fingerprint to check presence of "Pixel Data".
811 * src/gdcmDocEntry.h: coding style.
812 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
813 now taken into account.
814 * gdcmPython/gdcm.i: adaptation to the new internal representation
815 of gdcm (exit gdcmParser, hello gdcmDocument).
816 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
818 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
819 anymore, but instead prints the loaded Python dictionary.
820 * .... alas, the python testSuite is still broken.
822 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
823 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
825 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
826 * src/gdcmUtil.h : export methods
828 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
829 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
831 * Initial addition of automatic python testing
832 * Initial addition of automatic image comparison
834 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
836 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
838 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
839 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
840 * Test/ShowDicom.cxx : bug fix for msvc compilation
841 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
843 2004-05-04 Jean-Pierre Roux
844 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
845 new concepts (and new classes) :
846 a 'gdcmDocument' is composed of a set of Doc Entries, that are
847 - elementary gdcmDocEntries (former gdcmHeaderEntries)
848 - Sequence Doc Entries (gdcmSeqEntries)
849 a Sequence is composed of Items.
850 Each item is a set of Doc Entries (this is recursive)
851 The non uniqueness of the 'Dicom tag' is due to this recursivity
852 (never taken into account)
853 Our unability to add a new 'entry' in the header
854 at the proper location (neither in the H-Table (map or multimap),
855 nor in the Chained List is also due to this recursivity.
856 Don't try, right now, to use/modify/compile these new sources :
858 We just commit all the stuff, 'as is', in order not to loose it.
860 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
861 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
863 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
864 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
865 file prefix (SetFilePrefix)
867 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
868 * Add a new test: ShowDicom, for now this is just the c++ version of
869 checkRead.sh, later it will be able to compare the image read against a
871 * Replace the DEBUG on the stack with a global entry in cmake interface:
872 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
874 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
875 * Add an example subdir, with a real example on how to read + write a
878 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
880 * Doc/CMakeLists.txt: the main page is now properly differentiated
881 between the developper and user version.
882 * Doc/doxygen.config.in: dropped search related obsolete flags
883 * src/gdcmParser.h, gdcmHeader.h: doxygenation
885 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
886 * DEVELOPPER: added some helpfull comments for compile/test/install
889 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
890 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
891 src directory, now generated in the build dir.
892 2. Tests as mentionned smarter
894 4. Add a new method in gdcmDict that return the PubDict by name
895 this is interesting for 3rd party lib like ITK,
896 where we could set the institution name / patient name...
898 * ENH: 1. Now the test suite is working for real
899 2. All binaries are now output in the gdcm-bin directory
900 (this was not true before)
902 2004-04-28 Jean-Pierre Roux
903 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
904 SeQuence indented printing of Dicom Header.
905 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
906 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
907 Computation of SQDepthLevel is now part of gdcmHeader constructor
908 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
909 tree-like structure of a Dicom Header.
910 * FIX Test code cleaning
912 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
913 * ENH: Adding automatic testing
914 1. Need a DartConfig.cmake to submit to public
915 2. Add a test driver gdcmTest.cxx
916 3. gdcmTestMain, an helper for the main test driver gdcmTest
917 4. Files in Test don't have a main anymore, this becomes interesting
918 when we add more and more tests, thus dsw don't have to load
920 * ENH: Adding a GDCM_DATA_ROOT for testing
921 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
922 one file instead of seven + some small cleanup
924 2004-04-22 Jean-Pierre Roux
925 * ENH Minor changes to the Print() methods.
926 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
927 Header printing. Example given with :
928 > PrintHeader fileName 2 new
929 (SQ based tree-like structure still to be done for the Header ...)
931 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
932 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
933 1. I have added some unsigned where needed
934 2. Some function parameter not used -> (void)
935 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
936 4. g++ don't like character '\' in comment
937 5. #define jpeg_create_decompress jCreaDecompress
938 this really need to be fixed
939 6. virtualize destructor of gdcmObject ... leakage
940 7. sscanf(g->first.c_str(),"%x",&gr_bid);
941 this also really need to be fixed
942 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
943 remove compression file
944 (as we only do decompression, right ?)
945 * ENH: Change malloc/calloc/free with c++ equivalent
947 2004-04-21 Jean-Pierre Roux
948 * FIX gdcmHeaderHelper::GetXSpacing
949 when a single value is found (bug ?), xpacing is now
950 defaulted to yspacing
952 2004-04-19 Jean-Pierre Roux
953 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
954 * ENH add parameters :
955 bool exception_on_error = false,
956 bool enable_sequences = false,
957 bool ignore_shadow = false
958 to the gdcmFile constructors to be full gdcmParser compliant
959 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
960 to allow reading of PAPYRUS 3.0 files
962 2004-04-06 Jean-Pierre Roux
963 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
965 2004-04-02 Jean-Pierre Roux
966 * ADD : Test/checksequence.sh, for a general recap on SQ pb
967 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
968 for Philips spurious Tag fffe|0000 while rewritting Dicom files
970 2004-03-30 Jean-Pierre Roux
971 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
972 for ACR file, written out as DICOM files (hope so...)
974 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
976 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
977 moved to base class gdcmParser and only the specialisation is kept
979 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
980 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
981 already does the job.
982 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
983 (to be consistent with gdcmParser::WriteEntries).
985 2004-03-30 Benoit Regrain
986 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
987 upate of the object's instance. It's passed to 2 in the unfavorable
988 case : one in the ExecuteInformation, one in the ExecuteData
990 2004-03-29 Jean-Pierre Roux
991 * ENH : Check on file type to be written moved
992 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
993 * FIX : gdcmObject::ResetBoundaries now stops properly
994 when end-of-list is reached
995 : gdcmVersion modified (as Benoit Regrain asked)
997 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
999 * src/gdcmUtil.cxx: added forgotten iostream include.
1000 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1001 equivalent to ExplicitVR in existing code).
1003 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1005 now contains all the gdcmGlobal related code.
1006 * minor coding style and doxygenation changes.
1008 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1009 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1010 now contains all the Debug related code.
1011 * minor clean-up of includes in src/*.cxx
1012 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1013 CreateCleanString) removed.
1014 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1015 * Doc/DoxyMainPageUser.txt added.
1016 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1017 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1018 src/gdcmDirList.cxx)
1020 2004-03-24 Jean-Pierre Roux
1021 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1023 2004-03-23 Jean-Pierre Roux
1024 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1025 big endian made volumes
1026 * ENH Now gdcmParser constructor and destructor are protected to forbid
1027 end user to instanciate class gdcmParser
1028 (only gdcmHeader and gdcmDicomDir are meaningfull)
1030 2004-03-22 Benoit Regrain
1031 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1032 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1033 gdcmSerie to gdcmDicomDirSerie
1035 2004-03-19 Jean-Pierre Roux
1036 * ENH Now the tree-like structure describing a DICOMDIR comming from
1037 an already existing DICOMDIR file is consistent with
1038 the home-made tree-like structure build ex-nihilo
1039 or build from the files held (recursively) in a Directory
1040 functions gdcmDicomDir::CheckBoundaries()
1041 gdcmObject::SetBoundaries() added
1043 2004-03-17 Jean-Pierre Roux
1044 * REM (Eric Boix bug) : removal of meaningless
1045 gdcmDicomDirImage::NewImage function.
1046 * FIX now file names and directory name are written properly in the
1048 * FIX now gdcmDicomDir constructor may be call without any trick
1051 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1052 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1053 of gdcmDicomDirImage::NewImage as empty function.
1055 2004-02-28 Jean-Pierre Roux
1056 * ENH add gdcmDicomDir:NewPatient
1057 add gdcmDicomDirPatient:NewStudy
1058 add gdcmDicomDirStudy:NewSerie
1059 add gdcmDicomDirSerie:NewImage
1060 to allow making gdcDicomDir object.
1061 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1062 (as opposite to the gdcmHeader chained list)
1064 2004-02-11 Benoit Regrain
1065 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1066 when using from python
1068 2004-02-10 Benoit Regrain
1069 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1070 * FIX : in gdcmDicomDir when the directory is empty
1071 * ENH : add callback and methods to get the progression of dicomDir
1074 2004-02-06 Jean-Pierre Roux
1075 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1076 - GDCM_META added to gdcmDicomDirType
1077 - class gdcmMeta created
1078 * ENH : - A brief summary is now displayed at the beginning of
1079 'testDicomDir' to help disaster magnitude estimation
1080 * REM : Now useless Test/explDICOMDIR.cxx
1082 2004-02-05 Benoit Regrain
1083 * ENH : add methods in gdcmObject to get the hash table or the list of
1085 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1086 * FIX : wrapping python for TagHeaderEntryHT
1088 2004-02-04 Benoit Regrain
1089 * FIX : even length for some strings when writting the dicom dir
1090 * FIX : sort the images in the dicom dir
1091 * FIX : Bug fix for python use of dicom dir
1092 * ADD : a python demo
1094 2004-02-04 Jean-Pierre Roux
1095 * FIX : Final solution (?) for icone embedded images
1096 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1097 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1098 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1099 gdcmData/gdcm-MR-SIEMENS-16.acr1
1100 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1101 to make full checking easier
1103 2004-02-04 Benoit Regrain
1104 * FIX : WriteEntries : coding style & logic in parameters
1105 * FIX : Set the elements to create the DicomDir in a dictionary file
1107 2004-02-03 Benoit Regrain
1108 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1109 * gdcmDicomDir : add the load of directory
1110 * Bug fix and print add-on
1112 2004-02-03 Jean-Pierre Roux
1113 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1114 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1115 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1116 * FIX gdcmParser.cxx : 'group length' elements are now considered
1117 as integers, even for shadow groups, when file is Implicit VR
1119 2004-02-02 Jean-Pierre Roux
1120 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1122 of the last synonym :-(
1123 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1125 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1126 * FIX taking into account the possible 7fe0,0010 multiplicity
1127 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1128 to allow removal of references to 7fe0,0010, to deal with
1129 ACR-NEMA images, when 0028,0200 is meaningfull
1131 2004-01-31 Jean-Pierre Roux
1132 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1133 no longer writes 'Un' on disk
1134 * FIX SQ elements with actual length are now dealt with corectly
1135 * FIX gdcmFile::WriteBase make the difference, for color images, between
1136 the length (for Palette expanded images)
1137 and Raw Length (non expanded image + Palette)
1138 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1139 (that broke Write). Replaced by UL.
1140 Aware user will reload the field if he
1141 thinks it's necesssary
1143 2004-01-30 Jean-Pierre Roux
1144 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1145 when 'dirty Acr' is found, to be compliant with the new
1146 IsReadable() methods.
1148 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1149 (no DOUBLE images in kosher DICOM,
1150 but so usefull for people that miss them ;-)
1152 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1153 DICOMDIR related utilities (not checked as Windoze compliant)
1155 2004-01-28 Jean-Pierre Roux
1156 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1158 2004-01-27 Jean-Pierre Roux
1159 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1160 to allow skipping the shadow elements, to save memory space.
1161 The TRUE value for this param has to be used
1162 with a FALSE value for the 'enable_sequence' param.
1163 ('public elements' may be embedded in 'shadow Sequences')
1164 * gdcmHeader methods now deal with 'embedded icones images' in the header
1165 (even when an 'icone image sequence' is announced by the
1166 element (0x0088,0x0200), but there is NO icone at all ...
1168 * gdcmHeader sometimes Image Location value doesn't follow
1169 the supposed processor endianity (see gdcmData/cr172241.dcm).
1172 * gdcmHeader add the method
1173 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1174 to get *all* the Header Entries with the same tag.
1175 GetHeaderEntrySameName is probabely *useless*
1176 (no meaning : Name is *not* an identifier within the Dictionnary)
1178 2004-01-26 Benoit Regrain
1179 * Bug fix in the print of hexadecimal representations. Remove long fields
1180 in the print and add a third level of print to print them
1182 2004-01-23 Benoit Regrain
1183 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1184 * Bug fix on test suite after remove the strip made on not string fields
1185 * Split the IsReadable method between gdcmParser which test that the file
1186 is dicom and gdcmHeader which test that it's an image file
1188 2004-01-22 Benoit Regrain
1189 * DicomDir : clean code, add methods, set variables in protected or private
1190 * gdcmUtil : bug fix for the clean string method
1192 2004-01-19 Benoit Regrain
1193 * Add the use of shadow dictionaries
1194 * bug fix and coding style
1196 2004-01-19 Benoit Regrain
1197 * src/gdcmFile.cxx : bug fix concerning the close of file
1198 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1199 * Add the update of header entries using the shadow library
1201 2004-01-19 Benoit Regrain
1202 * removal of file gdcmHeader2.cxx
1203 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1204 inheriting from gdcmParser. This split is to prepare the integration
1205 of dicom dir parsing
1206 * bug fix under python
1208 2004-01-16 Jean-Pierre Roux
1209 * REM removal of class gdcmHeaderEntrySet
1210 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1211 * ADD add file gdcmHeader2.cxx
1212 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1214 2004-01-15 Benoit Regrain
1215 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1216 entries created while parsing the header. Thus, they will be destroyed
1217 when the gdcmDictSet will be destroyed
1218 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1221 2004-01-15 Benoit Regrain
1222 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1223 made a fatal error because of the memory release at the end of program.
1224 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1225 some memory and vtk seems to have some problems with that.
1226 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1228 2004-01-14 Benoit Regrain
1229 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1230 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1231 * src/*.[h|cxx] : make changes due to class name changes
1232 * gdcmPython/demo/*.py : bug fix due to method names
1234 2004-01-13 Benoit Regrain
1235 * src/*.[h|cxx] : coding style
1236 * vtk/*.[h|cxx] : coding style
1238 2004-01-13 Benoit Regrain
1239 * gdcmPython/testSuite.py : test the readable flag of file for tests
1240 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1241 It's lied to the stl compilation by MSVC (windows, always windows...)
1242 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1244 2004-01-12 Benoit Regrain
1245 * src/*.h : add comments
1246 * src/gdcmDictSet.h : set the method BuildDictPath in public
1247 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1248 directly setted in the source code
1249 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1252 2004-01-09 Benoit Regrain
1253 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1254 * setup.py : use a reference to gdcmVERSION
1256 2004-01-07 Benoit Regrain
1257 * Modification to compile with the distutils.
1260 2003-12-10 Benoit Regrain
1261 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1262 can use a gdcmHeaderHelper to load datas
1263 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1264 made in the source code
1266 2003-12-10 Benoit Regrain
1267 * Update Windows projects and .cvsignore files
1269 2003-11-12 Jean-Pierre Roux
1270 * ENH gdcmHeader constructor has one more parameter (default value : false)
1271 that allows the user to 'go inside' the SeQuences only
1273 gdcmElValSet:Print takes it into account
1275 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1276 * ENH: Update gdcmPython/CMakeLists
1277 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1278 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1280 2003-11-10 Jean-Pierre Roux
1281 * FIX : gdcmHeader::LoadElements is now based
1282 on the ListTag listElem member,
1283 not longer on the TagElValueHT tagHt member
1284 * ENH : PrintPubElVal shows (temporarily) both results,
1285 with the tagHt member and the listElem member.
1286 (it's easier to 'see' the problems when using Printheader)
1288 * FIX : old private member LgrElem is now splitted into
1289 ReadLength : Length actually found on disk (updated only
1290 if bug fixing is necessary), for internal
1292 UsableLength : Updated by FixFoundLength, to fix a bug
1293 or to allow Parser going on.
1294 Will allow to re-write a kosher header when a SeQuence
1295 with a length (not 0000) is found
1296 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1297 because gdcmElValSet::Add does not update ListElem
1300 2003-11-07 Jean-Pierre Roux
1301 * FIX misstyping in Transfert Syntax name table
1302 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1303 when they have an actual length (not 0000 nor FFFFF)
1304 (Nobody should care of it, but DICOMDIR explorers)
1306 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1307 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1309 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1310 * ENH: vtkGdcmReader now supports LUT !
1311 (vtkgdcmViewer for now is not able to use them though)
1313 2003-11-05 Jean-Pierre Roux
1314 * in testSuite.py : new files names for checking the package
1315 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1316 that returns the pixel area size to the *aware* (vtk) user
1317 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1319 2003-11-05 Benoit Regrain
1320 * in testSuite.py : Modify the rules for checking the paths
1321 : Explicit error messages
1322 * in __init__.py : Related modif
1324 2003-11-03 Jean-Pierre Roux
1325 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1326 to be used by aware (vtk) users that want to manage
1327 LUT (and no to turn the PALETTE image into an RGB pixels one)
1328 * GetPixelType now returns 8U for 24 Bits images
1329 (vtkGdcmReader compliant)
1331 2003-10-31 Jean-Pierre Roux
1332 * Removal of *all* gdcmData images and add them again
1333 in order to loose the 'history' of un-anonymised images
1335 2003-10-31 Jean-Pierre Roux
1336 * RMV : removal of useless jBitsInJsample.h
1337 for both 8 and 12 Bits JPEG Lossy Libraries
1339 2003-10-31 Jean-Pierre Roux
1340 * ENH : Add the functions gdcmFile::GetImageDataRaw
1341 gdcmFile::GetImageDataIntoVectorRaw
1342 that act as GetImageData and GetImageDataIntoVector
1343 except the making of an RGB Plane from Gray Plane + LUT
1344 Intended to aware (vtk) users who know how to manage
1347 GetLUTRGBA return a R,G,B,A LUT if any
1348 lgrTotaleRaw gives the 'Raw' length
1349 GetImageDataRaw returns the gray Plane
1350 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1351 (They stay Grey, just like with other Dicom viewers :-(
1353 2003-10-30 Jean-Pierre Roux
1354 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1356 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1357 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1358 being coherents dicom files.
1360 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1361 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1363 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1364 * ENH: Two steps is necessary to please VC++ compiler...
1365 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1366 * ENH: Add include dir to medcon lib
1367 * FIX: only one function is being exported for now !
1368 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1370 2003-10-29 Jean-Pierre Roux
1371 * adding gdcmHeader::GetLUTRGBA
1372 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1373 --> Mathieu, the modif u're waiting for is not yet committed
1374 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1376 2003-10-27 Jean-Pierre Roux
1377 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1378 00191113.dcm DermaColorLossLess.dcm
1379 MxTwinLossLess.dcm RadBWLossLess.dcm
1380 * ENH: For version prior to vtkImageViewer2 -r 1.19
1381 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1383 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1384 * Removal of ido stuff in CMakeLists.txt
1386 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1387 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1388 * FIX: remove a call to ->Modified ... see comments
1389 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1391 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1392 * FIX: Problem with path for libvtkgdcmPython
1393 * ENH: Try adding a search script for python site-package
1394 * RMV: Remove some file from medcon lib that are not necessary
1395 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1396 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1397 * FIX: More pragma disable fro VC++,
1398 I don't think I break something as it is also disable in VTK/ITK.
1399 But it fasten debug compilation time.
1401 2003-10-23 Jean-Pierre Roux
1402 * gdcm now deals with 16 Bits Run Length Encoded images
1403 (they are compressed as 2 planes images,
1404 one for the high Bytes, the other for low Bytes)
1406 2003-10-22 Jean-Pierre Roux
1407 * Now CheckRead takes into account :
1408 - the bugged 'Leonardo' Siemens images
1409 - the XA images, sent thru the burning VPRO station
1410 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1413 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1414 * FIX: When copying a Makefile.am to CMakeLists.txt
1415 one should remove the '\'
1417 2003-10-22 Jean-Pierre Roux
1418 * in gdcmData adding a bugged 'Leonardo' Siemens image
1419 (wrong lengths in header)
1420 OK with gdcm, KO with the other viewers :-)
1421 * add a GE dlx XA image, thru the VEPRO burning station
1424 2003-10-21 Jean-Pierre Roux
1425 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1426 for a brutal checking of vtkgdcmViewer compliance
1428 2003-10-21 Jean-Pierre Roux
1429 * add the files for 'xmedcon' Jpeg Lossless library
1430 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1432 2003-10-21 Jean-Pierre Roux
1433 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1435 2003-10-21 Jean-Pierre Roux
1436 * garbage Siemens 'Leonardo' images dealt with
1437 (the patch is easy to remove)
1438 * cosmetic changes to avoid warnings
1440 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1441 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1442 no need to press 'r' now.
1444 2003-10-20 Jean-Pierre Roux
1445 * upgrade of checkRead.sh checkWrite.sh according
1446 to new Jpeg Lossless decompressor
1447 * add US.3405.1.dcm, a genuine RGB medical file ...
1448 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1449 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1451 2003-10-15 Jean-Pierre Roux
1452 * general anonymisation in gdcmData
1453 * adding the 'color files' from
1454 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1455 * adding some well knowed bugged-header images
1456 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1457 waiting for their inclusion in Python testsuite
1459 2003-10-15 Jean-Pierre Roux
1460 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1461 no longer seg faults when file is not found
1463 2003-10-14 Jean-Pierre Roux
1464 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1467 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1468 * TODO: *.in file to genereate a UseGDCM later
1470 2003-10-14 Jean-Pierre Roux
1471 * Some supposed-to-be Dicom Images have no preamble.
1472 OpenFile takes it into account
1473 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1474 * Missing elements added in dicomV3.dic
1475 (just to be affraid : have a look at
1476 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1477 and do it again next year ;->
1479 2003-10-13 Jean-Pierre Roux
1480 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1481 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1482 But there are NOT. It's fixed !
1484 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1485 * FIX: "jpeglib.h" was not found on VC++
1486 * FIX: vtkgdcm was not being installed
1488 2003-10-10 Jean-Pierre Roux
1489 * ENH : OpenFile closes the file if it *really* doesn't look like
1490 an ACR-NEMA / DICOM one.
1491 * FIX : testWrite no longer writes an empty file if the source file
1492 is not gdcm Readable
1493 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1496 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1497 * FIX: CMake generate now documentation
1498 * ENH: out of source doc build !
1499 * ENH: Generate both user and dev documentation
1500 * ENH: Should work on windows too
1501 * ENH: Only one doxygen config.in file is needed
1502 * FIX: make install should be ok now on ùnix plateform
1503 * FIX: PATH to dictionary was wrong (missing /)
1504 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1506 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1507 * vtkGdcmReader is now able to read rgb dicom file.
1508 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1509 * added a gdcmViewer to vtk test, use mouse to control
1510 window level & window width
1512 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1513 * CMake-ification of gdcm, we have now two build system
1514 * FIX: on cygwin Wsock32 doesn't exist
1515 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1517 2003-10-06 Emanuel Ollart
1518 * FIX : compilation process wad broken.
1519 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1521 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1522 * change gdcmViewer -> vtkgdcmViewer
1523 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1525 2003-10-06 Jean-Pierre Roux
1526 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1527 ( e.g : well known GE images with a wrong elem length,
1528 : Philips MRI Images with a wrong Huffman table)
1529 * still to be done : allow the reading of bugged LEONARDO Siemens images
1531 2003-10-03 Jean-Pierre Roux
1532 * Odd length strings are padded with '\0' (not with spaces,
1533 to remain compliant with already defined strings,
1534 like Transfert Syntax UID and others)
1536 2003-10-03 Jean-Pierre Roux
1537 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1538 to allow displaying RGB images (not only by affim ;-)
1540 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1541 * vtkGdcmReader is now able to read rgb dicom file.
1542 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1544 2003-10-03 Jean-Pierre Roux
1545 * A few nasty patches to allow the reading of a lot of nasty images
1546 ( e.g : well known GE images with a wrong elem length,
1547 : Philips MRI Images with a wrong Huffman table)
1548 * still to be done : allow the reading of bugged LEONARDO Siemens images
1550 2003-10-03 Jean-Pierre Roux
1551 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1553 2003-10-03 Jean-Pierre Roux
1554 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1555 to allow displaying RGB images (not only by affim ;-)
1557 2003-10-03 Jean-Pierre Roux
1558 * gdcmFile::GetImageDataIntoVector now
1559 - deals with MultiFrames MultiFragments Run Length Encoded files
1560 - deals with YcBcR (YBR_FULL) files
1561 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1562 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1564 (no sample found :-(
1566 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1567 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1568 Two reasons: - clear things
1569 - third parties acces gdcm through header files, so won't
1570 suffer anymore VC++ complains
1572 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1573 * add argv[1] in testvtkGdcmReader.cxx
1576 2003-09-24 Jean-Pierre Roux
1577 * The lines are now eigthy characters long.for
1578 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1580 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1581 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1582 char* to std::string. Thus, the use of strdup becomes useless. (see
1583 previous commis of Malaterre)
1584 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1585 before the last Malaterre's commit.
1587 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1588 * This commit should fix the Debug building under VC++, the problem
1589 was mainly a mixture of debug and release lib being loaded at startup.
1590 * I also remove a depency to a specific C function: strdup. Because I had
1591 to force the link to msvcrtd (whereas strdup is in libc).
1593 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1594 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1595 located in the gdcmCommon.h file. All use of reference of tha has been
1596 changed to now use the variable GDCM_UNFOUND.
1598 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1600 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1601 Dicom dictionary. The test suite can now be run again. Note:
1602 I'm note very happy with the " (RET)" changes. I believe this
1603 RETAINED comment should be dropped when parsing the dictionary.
1604 - PACKAGER corrected
1606 - AUTHORS updated and now in alphabetical order
1607 * Makefile.am now exports gdcm.dsw for Windoze users.
1609 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1610 * cygwin complains about missing std:: in subdir Test/
1612 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1613 * remove some methods that are now in gdcmHeaderHelper
1615 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1616 * vtkGdcmReader set spacing and origin correctly
1618 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1619 * Fix a few delete/delete[] mismatch
1621 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1622 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1623 interpretation to data given by gdcmHeader. For instance there are
1624 heuristics to get informations (look at different places).
1625 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1626 sorting DICOM images based on different strategies.
1627 * modified Makefiles accordingly.
1629 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1630 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1631 when building in debug mode
1632 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1633 src/win32/gdcmdll.dsp
1634 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1636 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1637 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1640 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1641 * src/win32/libgdcmjpeg12.dsp was not dos format
1642 * src/win32/libgdcmjpeg12.dsp :
1643 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1644 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1646 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1647 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1649 * src/gdcmFile.cxx : bug fix in affectation type
1650 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1651 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1652 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1653 symbols... future problem ?
1655 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1656 * src/win32/libgdcmijpeg12.dsp was missing
1657 * modified gdcm.dsw accordingly
1659 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1660 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1662 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1663 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1664 commit of JPR (before his hollidays to facilitate our work).
1665 * setup.py : bug fix in code. Modifications made while the last commit
1666 of JPR. The code hasn't been tested before the commit... it's so
1667 useless to make that (for best programmer that is JPR) !!!
1669 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1670 * tagged the current version as Version0_3 (i.e. version 0.3)
1672 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1673 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1674 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1675 * *.dsp : modifications to use new libgdcmijpeg8 library
1676 * setup.py : bug fix on VTKPATH variable
1677 * PACKAGER : adding all concerning windows
1679 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1680 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1682 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1683 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1684 test suite reported error.
1685 * PACKAGER file added (describes what a packager must do when
1686 packaging a new release).
1687 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1688 * configure.in: upgraded version number to 0.3.0
1689 * fixing build of rpm (through rpm -ta):
1690 - Doc/Makefile.am exports proper doxygen files
1691 - src/jpeg/libijg8/Makefile.am exports the include files.
1693 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1694 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1695 * src/gdcmHeader.h : formatting code
1697 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1698 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1699 We were obtaining error message from vtk. Now, creation of file list
1700 is made in an internal list to prevent this problem.
1701 Bug fix when output is empty.
1702 Bug fix in update of progress value. Previous commit for this was a bad
1704 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1706 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1707 * src/gdcmHeader.h : added method to get the file name
1708 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1709 files. Added method to remove all files on the input
1710 Added FIXME comment concerning the bad parsing of header made by
1711 ExecuteInformation method (in ExecuteData method)
1713 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1714 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1715 when using make instal.
1716 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1717 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1719 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1720 * setup.py : adding include dir of jpeg lib to compile all sources
1721 * */Win32/*.dsp : JPR fix for windows compilation
1723 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1724 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1726 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1727 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1729 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1730 * setup.py is again effective on un*x (takes into account the
1731 addon of the jpeg library)
1732 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1733 * Doc/Doxy* updated (includes above enhancements)
1734 * INSTALL now points to web documentation
1736 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1737 * src/gdcmHeader.h doesn't make unnecessary reference to
1739 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1741 * src/gdcm*.[cxx|h] :
1742 - to allow compilation with gcc 3.x
1743 -- clean up of STL usage (added explicit usage of std::)
1744 -- small fixes on exceptions.
1745 Note: linking not tested !
1746 - clean of doxygen comments to avoid warnings at documentation
1748 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1749 dependent convertion).
1751 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1752 * Clean up of previous JPR garbage commit (not even commented in the
1754 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1755 - moved all jpeg related files from src to src/jpeg/libijg8, with
1756 addition/modification of Makefile.am and configure.in.
1757 - the testSuite is still brain damage (not guilty).
1759 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1760 * WrapVTK.py : modifications to get correctly vtk source files to
1762 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1763 (FileName -> Filename)
1765 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1766 * vtk/vtkGdcmReader.[cxx/h]:
1767 - UpdateProgress method should now be effective
1768 - removed the limitation on having only images loaded (as opposed
1770 - when building a stack of images/volume, a lesser number of
1771 gdcmHeader and gdcmFile instances should be used (hopefully
1772 accelerating things).
1773 - when building a stack of images/volumes, files which are not
1774 loadable (wrong path-filename, wrong permissions on existing file,
1775 or file not parsable by gdcm) are replaced with a black image
1776 in the stack (for the caller to notice the problem).
1778 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1779 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1781 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1782 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1783 between standard library (std) and vtk library (problems are found
1784 under Windows... thanks Windows !)
1786 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1787 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1789 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1791 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1792 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1794 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1795 * When compiling with distutils (see setup.py) the C++ compiler is
1796 called with different flags than the default ones (with automake).
1797 In order to fix all those warning, I compiled gdcm with the command
1798 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1799 and went for warning fixes:
1800 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1801 up from unused variables.
1802 - vtk/vtkGdcmReader.cxx: potential bug fix.
1803 * src/gdcmHeader.h: Doxygen warning cleanup
1805 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1806 * gdcmPython/gdcm.i:
1807 - typemaps correction to take into account the systematic replacement
1808 of "using namespace std" with std:: prefix e.g. std::list,
1809 std::string... (cf changes of 2003-05-21).
1810 - gdcmGlob global variable of type gdcmGlobal (defined in
1811 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1812 exported to Python a as cvar.
1813 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1814 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1815 gdcmDictSet.GetPubDictTagNames() and
1816 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1817 C++ static methods).
1818 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1819 with the above changes.
1821 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1822 * setup.py, manifest.in : bug fix under linux
1824 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1825 * Modification of setup.py to compile vtk part too. Then, we have 2
1826 wrappers which must work with same distutils. For that, we have a
1827 generic distutils in distusiltsWrapping.py ; with :
1828 - build_extWrap class to wrap generically all extensions,
1829 - ExtensionWrap base class for all wrapping extension that contains
1831 - Wrapper interface which wrap sources
1832 + In WrapSwig.py we have extension and wrapper for Swig
1833 + In WrapVTK.py we have extension and wrapper for VTK
1834 * MANIFEST.in : modifications to consider vtk directory and new python
1835 files for compilation
1837 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1838 * Added python wrappers of vtkGdcmReader vtk class (see the
1839 source in vtk/vtkGdcmReader.cxx) :
1840 - vtk/Makefile.am now builds a library
1841 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1842 python library (as opposed to _gdcm.so wich are the python
1843 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1844 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1846 - configure.in has an additional flag --enable-vtk that needs
1847 to be set to enable compilation of vtk related code, that is:
1848 + vtk/vtkGdcmReader.so and
1849 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1850 + gdcmPython/vtkgdcmPython.so (see above)
1851 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1852 be read when compressed or when HighBit + 1 != BitsStored),
1853 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1854 the usage of the python wrapper of vtkGdcmReader vtk class.
1855 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1856 * src/*.[h] all occurences of stl classes are now prefixed with
1857 std::, and all occurences of "using namespace std;" where removed.
1858 This is to avoid pollution of global namespace in included files.
1859 Apparently vtk does not avoid this pitfall: when using both
1860 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1861 collision of various stl members (principally cout...).
1862 * gdcmPython/testSuite.py now cleanly removes temprory generated
1864 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1865 comply with above changes)
1867 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1868 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1869 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1870 vtk data structure (an image Flip was required).
1871 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1872 * cosmetic changes in documentation.
1874 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1875 * src/gdcmHeader.cxx: the constructor no longer exits when an
1876 unexisting file is given as argument.
1877 * The subdirectory Data (containing all the images used for the
1878 test suite) is not part of this repository anymore. A new module
1879 containing those images is now available at
1880 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1881 with the name gdcmData.
1882 All the python scripts (including the package initialisation file
1883 gdcmPython/__init__.py) were adapated to take this change into
1884 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1886 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1887 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1888 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1889 demo of the usage of this class.
1890 Compilation of this vtk part is only done when using the --enable-vtk
1891 at configure (or autogen.sh) stage.
1893 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1894 * More memory link related corrections and documentation fixes.
1896 - maximum info is obtained with a command of the form:
1897 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1898 --show-reachable=yes PrintHeader
1899 - the remaining reachable blocks seem to come from the STL
1900 allocation scheme through the usage of map and list. It looks
1901 like this memory cannot be freed but it is not a memory leak
1902 (in fact further invocation to the STL would recollect the
1903 unused memory allthough it cannot explicitely be freed).
1904 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1905 of displaying an image parsed with gdcm and displayed with VTK.
1906 Note: some images don't seem to work e.g.
1907 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1908 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1909 Allthough this weakens the semantics, it is a ditch attempt to
1910 make gdcm more thread friendly.
1912 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1913 * Memory link hunt (by using valgrind through the command
1914 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1915 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1916 gdcmHeader::_dicom_vr.
1917 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1918 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1920 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1922 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1923 * src/Makefile.am now exports all the necessary include files at
1927 * UpdateGroupLength replaced by new one
1930 * UpdateGroupLength re-written using H-Table
1931 (named UpdateGroupLengthNew untill checks are over)
1933 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1934 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1935 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1937 - gdcmHeader::GetPubElValSet removed.
1938 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1939 UpdateGroupLength, WriteElements, Write.
1940 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1941 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1942 carried the same semantics.
1943 - src/gdcmHeaderIdo.cxx changed accordingly.
1944 - gdcmFile::WriteBase now regroups all the codes from previous
1945 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1946 - enum FileType moved to gdcmCommon.h
1947 * src/gdcmHeader.cxx AddDefault trashed
1948 * gdcmGetXSize added
1949 * getimageDataSize now calls gdcmGetXSize
1950 * Test/*.cxx changed to agree with above changes
1952 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1953 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1954 (to avoid double call by end user).
1955 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1956 by end user, since gdcmHeader::gdcmHeader now handles it.
1958 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * gdcm/Doc many doxygen changes:
1960 - Doxyfile now has two different versions, DoxyfileUsers that generates
1961 the html.users end users oriented documentation and
1962 DoxyfileDeveloppers that generates the html.developper developper
1963 oriented documentation.
1964 - README changed accordingly
1965 - requirement.txt removed (old design info moved to TODO).
1966 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1967 DoxyMainPage.txt, DoxyPython.txt provide more information.
1968 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1969 be updated by simply regenerating the docs with doxygen and copying
1970 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1971 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1972 all the tests in the form "if (<map>.count() >1)" were removed.
1973 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1974 ill-formed documentation sections.
1975 * src/gdcmHeader.cxx: ditto
1977 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * setup.py fixed for un*x (needed macro for stdint.h)
1979 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1980 un*ces with sh-utils test utility.
1981 * gdcmPython/demo/test.py renamed to PrintHeader.py
1982 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1983 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1984 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1985 * src/gdcm*.cxx JPR's bad inclusion fixed.
1987 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1988 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1989 * gdcmPython/demo/test.py changed accordingly.
1991 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1992 * gdcmPython/Makefile.am fixed linking against libstdc++
1993 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1994 * Swig subdir (historical tests of swig version 1.3.17++) removed
1995 * Test/testChangeEntete.cxx some lines commented out in order to make
1997 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1998 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2000 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2001 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2002 hence the user doesn't need this explicit call.
2003 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2004 i.e. LoadElements() call removed.
2005 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2006 - src/Makefile.am declares the proper flag for g++.
2007 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2008 for adding user defined new tags.
2009 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2010 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2011 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2013 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2014 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2015 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2016 src/Makefile.am : the project should properly compile and install
2017 with the autotools, included the python wrappers part.
2018 * gdcm.spec.in : added a spec file for RPM packaging.
2020 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2021 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2023 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2024 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2025 to exported to the environement (see gdcmPython/testSuite.py
2027 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2028 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2029 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2030 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2031 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2033 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * gdcmPython/__init__.py doesn't crash anymore when running in
2035 in InstallMode or PreInstallMode but with an environement given
2036 value of GDCM_DICT_PATH.
2037 * src/gdcmDictSet.[cxx/h] coding style.
2039 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2040 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2041 * src/gdcm.h general comments moved to TODO, and README
2042 * src/gdcm.h should now be seen as a user commodity (including it
2043 should suffice to fully use gdcm). It is nowhere including within
2044 any of the kernel files src/*.cxx and src/*.h.
2046 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2047 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2048 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2050 * src/gdcm*.cxx only include their corresponding include file
2051 (as opposed to gdcm.h)
2052 * gdcmPython/gdcm.i changed accordingly
2053 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2054 the autogen.sh generated "make snapshot" command to work.
2055 * autogen.sh removed history related references to crea package.
2057 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * distutilsSwigCPlusPlus.py work around some swig portability
2061 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2062 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2063 was done in a last ditch attempt to get setup.py _really_
2064 operationnal. The python/gdcmPython layaout add the advantage
2065 of hidding away the python related distutils specific files
2066 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2067 Alas, the src directory was out of scope (i.e. it's relative
2068 position to setup.py was ../src) which made things impossible to
2069 handle (see previous version of python/setup.py). Crossing fingers...
2071 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2072 * python/setup.py now works on Un*x. (harder than I thougth)
2073 * python/distutilsSwigCPlusPlus.py can now have include files
2074 among the list of sources.
2076 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2077 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2078 * modifications in MSVC projects
2080 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2081 * As stated by the first lines of Test/ExceptionAndPython/README, it
2082 looks like we can move back to original usage of exception within
2083 src/gdcm* and hence remove the errno stuff that was introduced
2084 as a quick and dirty fixture of this problem (added to the TODO).
2085 * Doc/Doxyfile configuration file for Doxygen and corresponding
2086 README file for usage added.
2087 * Test/testWrite.cxx added. This new test comes from a split of
2088 test.cxx that is now reverted to its original purpous i.e.
2089 testing the proper parsing of a Dicom related file.
2090 testWrite.cxx concentrates on testing the IO part of gdcm.
2091 * Test/bug1.cxx (containing a bug on WIn32) added.
2092 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2093 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2094 whose purpose is to publish the content of the TagNames of the
2095 Dicom public dictionnary were not accessible without an
2096 instance of class gdcmHeader.
2097 - those methods are now static methods of gdcmDictSet and hence
2098 require no instances at all to be invocated.
2099 - within gdcmDictSet this change required to change some method
2100 to class methods (i.e. are now static) among which SetDictPath
2101 (renamed to BuildDictPath) and LoadDefaultPubDict.
2102 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2103 the above changes by calling the new method classes of gdcmDictSet.
2104 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2105 the above to be effective.
2106 * python/gdcmPython: in order to wrap properly the above changes
2107 for Python, swig version now needs to be > 1.3.17.
2108 * python/gdcmPython/Makefile fixed to adapt itself to new
2109 configure/make shema introduced by Johan Montagnat (thanks for the
2110 contribution). Alas this Makefile cannot be turned into a proper
2111 Makefile.am without some heavy changes in the configure.in
2112 (for python dectection).
2113 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2114 now avoids publishing the empty entries.
2116 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2117 * python/setup.py : bug fix concerning install under windows
2118 ExtraPath reused :-P
2119 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2121 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2122 * Dicts/dicomV3.dic : remove double spaces !!!
2123 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2124 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2127 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2129 method. Doxygenation.
2130 * src/gdcm.h clean up of JPR spurious comments.
2132 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2133 * python/distutilsSwigCPlusPlus.py now properly collects the
2134 shadow classes generated by "swig -c++" (gdcm.py in our case)
2135 when using "python setup.py install".
2136 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2137 reexports the working classes.
2138 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2139 by the classical C errno scheme. This is to prevent an obscure
2140 behavior of the python wrappers when importing wxPython.wx prior
2141 to gdcmPython (which ended up in an abort call). An illustration
2142 of this oddity can be found in the Test/ExceptionAndPython
2143 subdir (see the README file). This problem probably due to
2144 an combination of g++ and dynamic loading.
2145 * added Test/ExceptionAndPython (see above)
2147 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * Changed the layout of the python part to avoid bloating main
2149 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2150 i.e. the distutils arsenal. All the python related stuff is
2151 again in a python subdir, but the package itself is now in
2153 * setup.py was cleaned up:
2154 - pythonIncludePath removed
2155 - python setup.py bdist target is now functional.
2156 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2157 collision with other packages). gdcmPython/demo/*.py changed
2160 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * python subdir moved to gdcmPython (preparation of distutils packaging).
2162 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2163 distutils installer is operational.
2164 * - gdcmPython/__init__.py now properly loads the swig generated
2165 shadow classes (from gdcm.py).
2166 - gdcmPython/demo/*.py changed to import the package gdcmPython
2167 instead of gdcmPython/demo/load.py.
2168 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2170 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2171 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2172 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2173 entries within the associated public Dicom dictionary resp. the same
2174 information but sorted by the fourth field (PAT, IMG, DIR) of the
2176 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2177 are now in the "???" group.
2178 - python/gdcm.i changed accordingly,
2179 - python/demo/printGroupedPublicDict.py added, that gives an example
2180 of the above new functionalities in Python.
2182 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * src/gdcm.h, gdcmHeader.cxx:
2184 - historic references to glib's g_malloc and g_free (#defined)
2185 were definitively removed.
2186 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2187 * src/gdcmElValSet.cxx:
2188 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2189 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2190 - GetElValue(string) renamed to GetElValueByName.
2191 - Added GetElementByName(string).
2192 * src/gdcmHeader.cxx: added
2193 - GetPubElValRepByNumber(guint16, guint16)
2194 - GetPubElValRepByName(string)
2195 - GetShaElValRepByNumber(guint16, guint16)
2196 - GetShaElValRepByName(string)
2197 - GetShaElValByNumber(guint16, guint16)
2198 - GetShaElValRepByName(string)
2199 - GetElValRepByNumber(guint16, guint16)
2200 - GetElValRepByName(string)
2201 - GetElValByNumber(guint16, guint16)
2202 - GetElValRepByName(string)
2203 * Doc/requirements.txt added.
2205 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2206 * Test/Makefile building now depends on the one of libgdcm.so
2207 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2208 pixel data) aware which enables finding the address (offset) of
2209 the pixel data of JPEG encoded DICOM files. This leaves only a single
2210 file in the testSuite whose pixel data address (offset) is unknown.
2211 * python/testSuite.py changed accordingly.
2213 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2214 * VC++ has some strong limitations when working with the STL, as stated
2215 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2216 "Also note that some STL containers (map, set, queue, list, deque)
2217 cannot be exported. [...]
2218 Some STL classes contain nested classes. These classes can not
2220 This is caused by a designed limitation that once a template
2221 class is instantiated, it can not be re-instantiated and
2223 Since our usage of map<> is ubiquitous in gdcm, this "designed
2224 limitation" of VC++ is a pitfall.
2225 Hence the Python wrappers of gdcm cannot be incrementally linked
2226 against the c++ dynamic library. The dirty but only workaround is
2227 to forget about incremental link of dynamic libraries and to generate
2228 the Python wrappers library with the inclusions of the underlying C++
2230 The following modifications concern this matter on Win32/VC++:
2231 - wrapping python correct with standalone wrapped dll (don't use separate
2232 dll under windows !!!!)
2233 - python21_d debug mode enabled (ask Frog how to use it :-)
2234 - NO problem with having an STL member of class for example string in C++
2235 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2236 - Python test of dcmlib in Python is ok under windows on a large set
2238 * removed glib references
2239 * typedef's inserted in gdcm.i for correct swig type management
2241 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2242 * python/demo/*.py load.py extracted from test.py. Added explore.py
2243 that only displays required tags and testAll.py that parses all
2244 the files of the testsuite without using unittest.
2245 * python/testSuite.py other additional test on new files added.
2246 * Data/* new test files added accordingly to the testSuite.
2247 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2248 the vr in the file differs from the one of the dictionary.
2250 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2251 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2252 values, but limits itself to values which are below a user specified
2253 size (by default 1024 bytes).
2254 * python/gdcm.i : elements not loaded (because their size is above the
2255 user specified treshold) are exported with their TagKey as key of the
2256 python dictionary. This enables the testsuite to make some checks
2257 on the unloaded elements (since we have their offset and size).
2258 * python/testSuite.py
2259 - now tests for the existence and proper value of the pixel data
2260 - two new examples added.
2261 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2263 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2264 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2265 aware. See the strategy comments in gdcmHeader::FindeLength().
2266 * Test/test.cxx now accepts a filename as first argument.
2267 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2268 * python/testSuite.py changed to integrate test on above files.
2270 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2271 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2272 the vr was also RET.
2273 * python/testSuite.py more tests added.
2275 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2276 * python/testSuite.py unittest test suite added (uses Data)
2277 * Data/* dcm and acr files for the test suite.
2278 * glib dependance removed from un*x version. We now use ISO C99
2279 7.18 Integer types (see stdint.h)
2280 - python/Makefile, src/Makefile src/gdcm.h
2281 * src/ when an explicit vr (like dicom files) suddenly poped an
2282 implicit element we use to mark the underlying DictEntry of the
2283 concerned ElValue with "Implicit". This strategy was damageable
2284 too the public or provite dictionaries, since some of their vr
2285 would be changed. Since Header::FindLength heavily relies on the
2286 detection by Header::FindVR of falsely explicit elements, I
2287 added an extra ImplicitVr member to ElValue (boolean).
2288 The rest of the changes we the necessary adaptations.
2290 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2291 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2293 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2295 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * Adaptation for porting to VC++:
2298 o forced to use std namespace (for string to be known)
2299 o all class use __declspec export style on WIN32
2300 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2301 (in stdlib.h on Win32 but in std:: for gcc)
2302 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2303 variable GDCM_DICT_PATH.
2304 * src/gdcmHeader.cxx verbose comments made discrete.
2306 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2307 * python/gdcm.i: added a typemap that converts a C++ hashing table
2308 to native Python dictionary.
2309 * python/demo/test.py:
2310 - now uses the native dictionary for exploration of gdcmHeader.
2311 - takes an optional filename argument (the file to parse).
2312 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2313 PubElVals hashing table.
2314 * Dicts/dicomV3.dic removed error prone trailing spaces.
2316 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2317 * Python wrapping process moved away from src/Makefile to
2318 newly created python/Makefile (as well as gdcm.i)
2319 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2320 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2321 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2322 from the environement variable GDCM_DICT_PATH (when existing).
2323 * src/gdcmDict::GetTag bug fix.
2325 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2326 * Straightforward temporary fixes for swig to build the python wrappers.
2327 src/Makefile now has a python working entry [by working we mean
2328 that we can import de shadow classes without errors].
2330 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2331 * hashtest.cxx removed (since allready in Test)
2332 * src/gdcmlib.h renamed to src/gdcm.h
2333 * src/dcm.i renamed to src/gdcm.i
2334 * src/Makefile prepared for python wrapping
2336 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2337 * src/gdcmHeader.cxx :
2338 - Parsing of header is now separated from loading of element values
2339 (see gdcmHeader::LoadElements).
2340 - general clean up of hopefully all file access (creation of
2341 ReadInt16 and ReadInt32)
2343 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2344 * src/gdcmHeader.cxx :
2345 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2347 - SetLgrElem renamed to SetLength
2348 - GetLgrElem renamed to GetLength
2349 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2350 * src/gdcmElValSet.cxx fixed both GetElValue methods
2351 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2352 due to IdoDude was cleaned out.
2354 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2355 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2356 concentrates on finding the value representation (when it exists).
2357 RecupLgr now only finds the element value length, and it avoids
2358 returning the unecessary skL (skipped length).
2359 Also, offsetCourant was simply removed (with taille_fich) since
2360 it was redundant with the File position internals (by using
2361 ftell and fseek). This also made skL (see above in RecupLgr) usage
2363 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2364 on the libido specificities which are handled through class
2366 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2369 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * Truckload of changes. Parsing of header is barely functional
2371 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2373 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2374 * src/gdcmHeader.cxx many addons of low level methods
2376 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2378 and _IdDcmSWAP_LONG.
2380 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2381 * This corresponds to all the changes decided at the meeting of
2382 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob