1 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
3 by an eof to prevent all bad read of the file... and in this case, the
6 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * Example/Volume2Dicom.cxx : comment unused variables
8 * Test/PrintDicomDir.cxx : comment unused variables
9 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
10 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
11 method that is redondant with AddEntry.
12 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
15 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * Bug fix due my last commit (compilation under Windows).
17 * Example/Volume2Dicom : bug fix in the file and reformatting source code
18 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
20 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
22 - Remove printf / sprintf
23 - include iostream AFTER gdcm so we don't get warnings
24 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
26 - Also remove tons of include from header files, hopefully this should
27 speeup the compilation time, since it was becoming a dog slow.
28 - Remove gdcm.h as it include way too many files and slow down compilation
29 (plus it is not up to date)
30 - remove 'using namespace std' this is BAD !
32 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * Remove memory leaks on the DicomDir
34 * Remove some useless datas in DicomDirObject
35 * Add usefull methods in SQItem, to be complient withe the ElementSet
37 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
40 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
42 future, with convertion)
43 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
44 and ImageDataSize values. Remove the method to get the PixelReadConverter
45 from the output of the class
47 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
50 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
52 and vtkErrorMacro use.
53 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
55 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
58 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
59 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
60 The string leaves only in the fonction. So when we make a .c_str(), we
61 get the pointeur on the first element, element that will be destroyed
62 immediately after thee instruction.
63 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
64 file has been opened : the test must be made on the content of the
65 pointer and not directly on the pointer !
68 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
70 the python part recompiles
72 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
74 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
75 X session is killed (for my computer... it seems to not be identic on
78 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
80 avoid problems (otherwise, the difference test between the visible image
81 and the reference is incorrect. If the reference is greater than the
82 screen resolution, it's produce errors).
83 Can be used for only one image. Can be used with a visible flag.
84 * vtk/vtkGdcmReader.cxx : remove commented codes.
85 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
86 under windows at compilation
87 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
89 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
91 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
93 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
94 tests on the image size X, Y, Z
96 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
98 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
99 between the class name and the file name
101 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/ : fix compilation warnings for the Write method (2 different
103 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
104 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
105 variable... create a static method in gdcm::Document to access to
106 this variable content.
108 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
110 file, to be accessed by other files (like gdcmFile). Remove commented
111 code. Move the change of the header to the gdcmFile, using the
113 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
114 To be sure of that (and simplify calls), the Write of the header now
115 gets a file name and not a file pointer (std::ifstream).
116 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
117 DocEntryArchive. Remove all open of the written file
119 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
122 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
124 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
126 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
127 some corresponding methods. Write correctly the file and check before
129 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
130 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
131 is now on RGB datas (as before my last commit
132 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
134 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
136 Add a print information of the type of the entry
137 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
138 It was in the gdcmFile, and all write have been regrouped
139 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
140 Write correctly all dicom files (in decompressed mode only at this time)
141 * Test/ : test on files are now made using Raw datas and not color datas if
143 * Example/PrintFile.cxx : add more printings
145 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * Amelioration of code, remove some code copy. For the loading of
147 BinEntry (in gdcmDocument), add the test to verify if the file is already
150 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
152 remove a DocEntry in the header (push an empty DocEntry)
153 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
154 lines. Bug fix in the initialization of the PixelConvert and the
156 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
157 use in TestCopyDicom (now this test can run under windows... but fails)
158 * Test/TestCopyDicom.cxx : amelioration of the test :
159 - test the pixels written
160 - add test points to quickly find where is the error
161 - can set a file name input and output in arguments
162 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
163 amelioration of the test output
165 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
167 all replaced DocEntry's
168 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
169 Now, each needed DocEntry to modify is duplicated, modified and inserted
170 to the header using DocEntryArchive. Thus, after save, we can restore the
171 header initial state.
173 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
176 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
178 correct to copy it. The DictEntry is specified at the DocEntry creation,
179 then, it musn't change in the time.
180 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
181 header correctly. At this time, the change is only made for the first
182 level of the Document. In the future, it might consider sequences.
183 The change is made by replacing a DocEntry by an other that is created
184 outside the class. The old value is kept. When we restore the header
185 status, the added DocEntry is deleted and replaced by the old value.
186 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
187 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
188 set the write type to explicit VR, implicit VR or ACR. Add methods to set
189 the write mode to native, decompressed or RGB (but not used at this time)
191 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
193 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
195 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
197 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
199 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
200 set because already copied when copying the BinEntry's of the header
201 * Test/TestAllReadCompareDicom.cxx : remove warnings
203 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
205 Two problems appear when doing it :
206 - with the gdcmFile : when the GetImageData method is called, the pixels
207 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
208 datas (pixels). And each structure destruct the datas when it's
209 destructed. So we have two destructions for the same datas. To solve it,
210 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
211 datas or not. If it doesn't own datas, then they will not destroyed by
213 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
214 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
215 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
216 create a double destruction of the same DocEntry's. So, to solve it,
217 the TagHT is simply cleared and the DicomDir* elements are destroyed.
218 * TODO : add an entry concerning memory leaks in the DicomDir
220 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
222 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
225 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
227 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
228 after it have been deleted
230 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
231 * FIX: src/* fix the doxygen warnings.
232 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
233 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
234 was erroneously defined with a size of 15 instead of 16. [many thanks
235 to Jean Michel Rouet for pointing out this bug].
237 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
238 1. Finish merging JMR patch for writting DICOM from scratch
239 2. Fix -hopefully- bug with MONOCHROME and space vs null character
240 3. Use const ref when possible
241 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
242 5. A few more comments
243 6. CreateUniqueUID can now be called without parameter"
245 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
246 * ENH: Slightly bigger patch:
247 1. Getting toward full integration of JMR patch for writting dicom from scratch
248 2. Update Test to test part of this patch: CreateUniqueUID
249 3. File was not close properly in gdcmDict
250 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
251 5. Use of const ref instead of copy (speed issue)
252 6. Remove temporary (duplicate) string in TranslateToKey
253 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
254 8. Do not repeat virtual in subclasses
255 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
257 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
258 * Apply first patch toward better string comparison when dealing with broken
259 DICOM files. Essentially the string could be padded with a space instead
260 of a null character as defined by standard
262 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
263 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
264 because never used... and in the same time, that's remove some memory leaks
266 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/gdcmFile.cxx : now delete the PixelConvert instance.
268 * In examples and tests : change the type of image data variables from void*
269 to uint8_t*. Remmove all delete on image data variables
271 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
273 Verify the file pointer value before open the file, and if it's not null,
274 a verbose message is generated.
275 Close correctly the file when the file isn't considered dicom-like. The
276 correctly close is a call to CloseFile.
277 When closing the file pointer, test if its not null to close the file.
278 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
279 file. For an uncompressed image, the copied datas correspond in the least
280 case to the image size (calculated) or the image size specified in the
281 header. A verbose is generated if these two size mismatch
283 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
285 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
286 break under windows (with msvc6 compilation).
288 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
290 compiling with MSVC6)
292 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
293 * Bugs fix for the Windows build with VC6
294 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
295 needed (only for projects required VTK). If the VTK is included in all
296 projects, there is conflicts with the jpeg lib of vtk when compiling the
297 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
298 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
299 when compiling the gdcm_wrap.cxx file (created by the compilation of the
301 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
302 (like it's already made for the cout use). Otherwise, conflict with the
305 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
308 - comments on the DicomDir::Method related usage added.
309 - now that we use the namespace gdcm, a lot of internal classes do
310 NOT need to be wrapped anymore.
311 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
312 DicomDir::Method) new example added.
314 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
315 * Improve string manipulation. I now inforce the notion of 'DicomString'
316 A DicomString can contain as many \0 as they want
317 and it is *always* of even length.
318 We only support odd length for very rare case.
319 And in the near future this should be removed.
321 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
322 * /binary_write/ gdcm source. Now even on big endian we are writting
323 little endian. This should -heopfully- fix some tests
325 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
326 * Now the dictionary is compiled into gdcm lib. This is a default
327 behavior, thus any dic file specified is picked before failback to
328 the one comiled into lib
330 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
331 * Change internals for gdcmDict. Don't use any 'new' any more.
332 This should definitely solve any leak problem, and we should be
333 as fast as before, as long as don't modify too much the dictionary.
335 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
336 * STYLE: ivars should start with a capital letter.
337 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
338 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
340 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
341 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
342 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
343 new 2004 dictionaries added (thanks to JPR).
344 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
345 * CLEANUP_ROUND (15) for gdcmPixelConvert
346 - RLEFrame::NumberFragments is now of type unsigned int
347 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
348 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
351 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
352 * Initial work in gathering all transfer syntax accessors. clearly
353 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
354 ivars, but only one transfersyntax (class) ivar with equivalent method on
357 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
359 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
360 discussed (plus I didn't like having a 2000 lines patch not commited)
362 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
363 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
364 * CLEANUP_ROUND (14) for gdcmPixelConvert
365 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
366 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
367 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
369 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
370 anymore and hence avoids storing a copy of PixelConvert::Decompressed
371 into File::Pixel_Data.
373 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
375 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
376 * CLEANUP_ROUND (13) for gdcmPixelConvert
377 Substituted File::ParsePixelData() with PixelConvert::Print() new
379 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
380 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
381 method to those classes.
382 - src/gdcmFile.[cxx|h]:
383 -- Added a ::Print() method.
384 -- PixelConverter is now a reference instead of a member.
385 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
386 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
388 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
389 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
390 collaboration diagram and inheritance diagram should be generated with
392 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
393 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
394 pointlessly wrapped (see
395 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
396 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
397 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
398 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
399 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
400 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
401 -- File::Initialise: PixelConverter setup moved away to
402 PixelConverter::GrabInformationsFromHeader()
403 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
404 interpretation moved away to PixelConverter::BuildRGBImage()
406 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
407 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
408 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
410 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
412 displayed on Win32 when a brutal abort() occurs (because of uncatched
413 exception). See TODO new entry of this commit for more on this.
414 * TODO added new entry.
415 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
416 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
417 - HandleColor is no longer called from gdcmFile.cxx
418 - gdcmPixelConvert.cxx clean up on method arguments and internal
419 variable names for semantical coherence.
421 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
422 * Finished lossless transition, not only do we now read all lossless jpeg
423 images, without the need of the Cornwell lib, but we do read them properly now
424 * To reduce code (well to avoid code duplication), I defined a common place
425 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
426 redefine symbols. This is not prefect but this the best solution I found for a
427 compilation time jpeg option.
429 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
430 * Update jpeg ijg lib to support lossless jpeg implementation
431 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
433 * Also added a special copyright for dcmtk since we use their bugfixes.
436 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
437 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
438 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
439 matters, as stated in warning note at begining of %include section).
440 * src/gdcmDicomDir*.[cxx|h]: coding style
441 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
442 * src/gdcmJpeg8.cxx: doxygen fix.
443 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
444 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
445 from File:: to PixelConvert::.
447 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
449 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
450 - more code moved away from File:: to PixelConvert::
451 - fat setup of PixelConverter set in place in File::Initialise.
453 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
454 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
455 namespace at the file system level. So now you should convert your examples
457 gdcmHeader -> gdcm::Header
458 It would be nice if people keep in mind to no open the namespace, since it
459 allows compilation on broken plateform which were defining common symbol in
460 the standart namespace (like LP, Unknown ...)
462 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
463 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
464 The JPEG fragments are now parsed at the same stage than the RLE
465 information. All code related to JPEG is now in gdcmPixelConvert:
466 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
467 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
468 export a gdcmFile:: method. Those are simply global functions
469 (for the time being this is better than having them attach to
470 either gdcmFile:: or gdcmPixelConvert::).
471 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
472 and stores the result in a gdcmJPEGFragmentsInfo.
473 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
474 code (among other stuff) moved away from gdcmFile:; to
477 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
478 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
479 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
480 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
481 clean up of RLE related code.
482 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
483 - src/gdcmRLE.cxx removed
484 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
485 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
486 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
487 * CLEANUP_ROUND (9) for gdcmPixelConvert
488 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
489 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
490 away from gdcmFile:: to gdcmPixelConvert::.
492 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
493 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
494 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
495 This is because Parse7Fe0 used to parse the pixels to compute the
496 length. This task was passed over to FindDocEntryLengthOB() a long
497 time ago, EXCEPT I had forgotten the OW case...
498 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
499 we just recylce the code for parsing RLE fragments and computing
501 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
502 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
503 with the retired Parse7Fe0().
504 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
505 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
507 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
508 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
509 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
510 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
511 - src/CMakeLists.txt: alphabetic order reodering + new entries.
512 * CLEANUP_ROUND (4) for gdcmPixelConvert
513 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
514 to return an unused length.
516 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
517 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
518 this should be cleanner from the plane view. The iostream are erally a pain
519 to use to do simple stuff.
521 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
522 * Redo the compilation of the ijg jpeg library. Now only one source is
523 necesseray. No need to rename file by hand what so ever. CMake handle the
524 copying of the file within different directory, configure header file to
525 modify some symbol. The only addition made to ijg wasd a mangle table so
526 that symbol are different wether we are within 8bits or 12bits.
528 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
529 * Added documentation of vtkgdcmReader on Website:
530 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
531 with it's binary name).
532 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
533 the Website to be more complete.
534 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
535 doxygenated documentation.
536 - Doc/DoxyVtkGdcmReaderExamples.txt added
537 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
538 DoxyVtkGdmReaderExamples.html )
539 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
540 * CLEANUP_ROUND (3) for gdcmPixelConvert
541 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
543 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
544 * CLEANUP_ROUND (2) for gdcmPixelConvert
545 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
547 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * CLEANUP_ROUND for gdcmPixelConvert:
549 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
550 - src/gdcmPixelStuff[h|cxx] removed
551 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
552 - src/CMakeLists.txt changed accordingly
554 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
555 gdcmVersion.py moved to newly created ATTIC related
556 gdcmPython/SetupOldies/ directory.
557 * Autotools clean up:
558 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
559 - autogen.sh configure.in acinclude.m4 python.m4 removed
561 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
562 * src/*.cxx *.h Reference to License.htm fixed to License.html.
563 * Doc/CMakeLists.txt, doxygen.config.in: fix.
564 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
566 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
567 * TODO updated with Mathieu suggestions. I proposed a template for
568 describing TODO entries and used it for new entries.
569 * Added Doc/Website/CodingStyle.html, Developpers.html,
570 DeveloppersPython.html, GdcmDataCvs.html and
571 DownloadVersion0_1.html, DownloadVersion0_3.html.
572 * Some Doc/*.txt Doxygen files (which do not really concern the
573 documentation itself, but the website) moved to html and
574 placed in directory Doc/Website:
575 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
576 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
577 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
578 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
579 * CMakeLists.txt changed accordingly.
580 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
581 DeveloppersPython.html
582 * INSTALL nows refers to Doc/Website/Installation.html
584 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * Added Doc/Website directory, that contains a first raw version
588 2004-09-23 Jean-Pierre Roux
589 * FIX In order not to be poluted any longer by casting problems,
590 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
591 we can now delete[] it safely
592 * VoidArea is now called BinArea (less confusing name),
593 and all the methods called ...VoidArea... are now ... BinArea...
594 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
596 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
597 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
598 clear) TagHT, which is an inherited member of gdcmElementSet. It is
599 up to the destructor of gdcmElementSet to clean up TagHt and it's
602 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * Test/CMakeLists.txt: update to follow gdcmData renamings.
604 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
606 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * ENH: added some utility method that builds a flat dictionnary
608 holding all the Dicom entries contained in the recursive structure
609 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
611 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
612 BuildFlatHashTable() that build a flat dictionary.
613 - src/gdcmElementSet.h: added a new private GetTag() accessor.
614 gdcmDocument is now a friend of gdcmElementSet.
615 - src/gdcmElementSet.cxx: clean up.
616 - Example/FlatHashTablePrint.cxx added.
617 - Example/CmakeLists.txt changed accordingly
619 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
621 moved away from gdcmDocEntrySet (since this class is an abstract class
622 acting like an interface). SQDepthLevel and BaseTagKey are now
624 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
625 and associated accessors. Doxygenation of the class.
626 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
628 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
629 Use SQDepthLevel accessor instead. ::Print() adapted.
630 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
631 - src/gdcmDocument.cxx changed accordingly.
633 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
635 - The following is the doxygen comment of the typedef declaration
636 of gdcmagKey in src/gdcmCommon.h:
637 gdcmTagKey is made to old an "universal" (as in URL, Universal
638 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
639 A dicom tag allways has a group and an element, but a set of tags
640 embeded in various (optionally nested) sequences and sharing
641 the same group and element all share the same (group, element)
642 "identifier". Hence the (group, element) cannot be used as an
643 identifier (in gdcm we shall refer to a "TagKey") of a tag.
644 In order to construct a proper tag identifier (i.e. a key) we
645 consider the following definition of a TagKey:
646 - let Group, Element be the string representation of the
647 group and element dicom tag members,
648 - let ItemNumber be the string representation of the integer
649 index of the considered item number of a sequence,
650 Let the key of a tag embeded in a sequence, noted SeqTag, be
652 /ItemNumber#Group|Element
653 where "/", "#" and "|" are characters acting as separators.
654 Then the general form of a gdcmTagKey is given by:
655 Group|Element<SeqTag>
656 where <SeqTag> means NO or many instances of SeqTag.
657 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
660 but the gdcmTagKey of a tag "embeded" is the first item of
661 a sequence, itself nested in the third item of a sequence is the
663 0004|1220/2#0008|0082/0#0008|0090
664 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
665 order to hold the new sequence compatible key. Previously, the
666 GetKey() method would look in the underlying gdcmDictEntry.
667 - src/gdcmDocEntry.cxx:
668 -- constructor now copies the underlying DictEntry key, in the local
670 -- ::Print: displays the member Key, instead of the (group, element).
671 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
672 - src/gdcmDocEntrySet.h:xi
673 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
674 -- now has a new BaseTagKey member.
676 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
677 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
679 This poses the problem with the semantics of the following lines
680 LoadEntryVoidArea(0x0028,0x1201); // R LUT
681 LoadEntryVoidArea(0x0028,0x1202); // G LUT
682 LoadEntryVoidArea(0x0028,0x1203); // B LUT
683 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
684 to the long FIXME note for what the problem is. Nevertheless in
685 order to get things working the dicom dictionary was altered !
686 Please fix things urgently...
687 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
688 information), see above note on moving the member VoidArea. Nevertheless
689 the following entries previously correctly set as US are now inproperly
691 0028 1201 OW IMG Red Palette Color Lookup Table Data
692 0028 1202 OW IMG Green Palette Color Lookup Table Data
693 0028 1203 OW IMG Blue Palette Color Lookup Table Data
694 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
695 of gdcmDocEntry moved to gdcmSeqEntry.
696 * src/gdcmSeqEntry.cxx: STYLE.
698 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
699 * Test/TestAllEntryVerify.cxx minor fix and added comments.
701 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
702 * gdcmPython/testSuite.py: all the test suite in python is now moved
703 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
704 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
705 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
707 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
708 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
709 to avoid inclusion recursion until STL is reached.
710 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
711 mecanism. errno.h is not included in gdcm anymore.
712 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
713 (gdcmFormatError now inherits from gdcmFormatUnexpected).
715 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
716 gdcmData/TestAllEntryVerifyReference.txt
717 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
718 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
719 exception_on_error parameter.
720 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
721 - vtk/vtkGdcmReader.cxx changed accordingly,
722 - Example/*.cxx and Test/*.cxx changed accordingly.
724 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
726 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
727 enable_sequences removed from gdcmHeader constructor and dependencies.
728 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
729 * gdcmPython/demo/PrintHeader.py: dummy fix.
730 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
731 skip_shadow removed from gdcmHeader constructor and dependencies.
732 * Example/*.cxx and Test/*.cxx changed accordingly.
734 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
735 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
736 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
738 2004-07-21 Jean-Pierre Roux
739 * FIX Now, Parsing and Printing a DICOMDIR do work!
740 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
742 2004-07-20 Jean-Pierre Roux
743 * FIX Some brain damaged headers have Zero-Lenght fields
744 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
746 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
747 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
748 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
749 variable (instance of gdcmDebug) by a definition macro, and the instance
750 is now in static in the gdcmDebug class
751 * src/gdcmSQItem.h : (FIXME) remove an undefined method
752 * Test/PrintAllDocument.cxx : bug fix in the result of the test
754 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
755 * WARNING: ctest now depends more tightly on gdcmData. You should
756 check out gdcmData properly for things to run smoothly...
757 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
758 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
759 we need the pixels not be loaded in order to use the ValEntry
760 that displays position and size).
761 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
762 This is a C++ based equivalent of gdcmPython/testSuite.py that should
763 be deprecated. If you have any doubts about the advantages of a
764 modern scripting language (read Python) versus grass root C++ (i.e.
765 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
766 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
767 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
768 Anyhow, consider documenting the gdcmData images in
769 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
771 * Test/CMakeLists.txt:
772 - now uses TestAllEntryVerify.cxx
773 - specific comments on oldACR00001.ima (now renamed in gdcmData
774 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
775 gdcmData/TestAllEntryVerifyReference.txt
778 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
779 * src/*.[h|cxx] : typedef clean up
780 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
781 - TagKey renamed to gdcmTagKey (for external usage)
782 - VRKey renamed to gdcmVRKey (for external usage)
783 - removal of typedef duplication.
784 - Removed all unecessary inline keyword from class inline definitions.
785 - Some method|function(void) declarations replaced with method|function().
786 * src/jpeg/libijg12/jdhuff12.c:
787 - printf polluting ctest removed.
788 - TAB removal for comminting
790 - TestAllReadCompareDicom.cxx: added a test that compares all the
791 images in gdcmDataImages.h with corresponding images in
792 gdcmData/BaselineDicom/. When baseline images are not present
793 this test creates them.
794 Note: we need to validate each reference image, but before that
795 I'd like to rename them with a more explicit name...
796 - CMakeLists.txt: changed accordingly.
797 * Example/*.cxx: examples now only include gdcm.h (as opposed to
798 including each header needed).
800 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
801 * Test/*.cxx and Example/*.cxx: moved some examples away from the
802 test suite to the Example directory. Are concerned:
807 - TestWriteSimple.cxx
808 * Test/CMakeLists.txt: added some comments on reasons for black listing
809 image gdcmData/oldACR00001.ima
811 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
812 * Test/CmakeList.txt: removed the following from black list (to be coherent
813 with removal from gdcmData):
814 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
815 - gdcm-MR-PHILIPS-16.dcm
817 Added the following because after last cvs update, they cause
818 ctest -R TestReadWriteReadCompare
820 - gdcm-MR-SIEMENS-16-1.acr
822 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
823 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
824 new comments in this file) we temporarily (sigh) move to a weaker
826 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
827 we don't need to black list the following images anymore:
828 - 8BitsUncompressedColor.dcm
830 - US-PAL-8-10x-echo.dcm
831 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
832 fixes and the beautified code ;-)
833 This fixes the bug introduced in version 1.42 (when beautifying)
834 that made the parsing of 8BitsRunLengthColor.dcm unproper.
835 Note: ctest was blind to this bug (this means we need to still
836 improve the test suite). The bug could be detected by using
837 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
839 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
840 and by displaying the (garbage) produced file temp.XDCM...
842 2004-06-29 Jean-Pierre Roux
843 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
844 - replace by uggly but working old code :-(
845 A lot of things should be OK again.
846 It's really urgent to have a test suite that *tests*,
847 to prevent Frog's beautifying sessions to break all the stuff
848 (twice, withing a fortnigh ...)
850 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
851 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
852 redundancy) to added Test/TestReadWriteReadCompare.cxx
853 * Test/CmakeList.txt: because the compare test of
854 Test/TestReadWriteReadCompare.cxx fails, the following images are
855 black listed: - 8BitsUncompressedColor.dcm
857 - US-PAL-8-10x-echo.dcm
858 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
859 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
860 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
861 and ad-hoc kludge. This kludge is now removed, and on encountering
862 such an image (OB field brain damaged) we set errno. Then in
863 ::FindDocLength() we "fix" the length as being ALL what remains
864 in the file (until EOF). We then proceed, hoping for the best...
865 This fixes a SegFault in ShowDicom when trying to write such an
867 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
868 (because TestWriteRead breaks on it, after a non conformal commit?).
869 ctest now runs properly, except for MakeDicomDir (which was allways
870 broken) and the Python related stuff (still not fixed).
872 2004-06-24 Jean-Pierre Roux
873 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
874 FIX : Test/TestReadWrite now iterates on all the file names
875 (instead of infinite loop)
876 ENH : Test/TestWriteRead now iterates on all the file names
878 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
881 2004-06-24 Jean-Pierre Roux
882 FIX : - now Write drops LUT Descriptors and LUTs (if any)
883 when SamplesPerPixel =3
884 - now Write is no longer confused by
885 'BitsAllocated = 12" and 'BitsStored=12"
886 - "UN" value representation Elements are now written correctly
887 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
888 ENH : - now gdcmHeader has its own Write methods
889 (in order to split the job that has not to be done
892 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
893 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
894 loop on the same image until memory went out.
895 Note: this means we still have gobs of memory loss in PrintDocument
896 * src/gdcmDocument.cxx: fixes problem on parsing on file
897 gdcmData/16BitsJpegLosslessGrayScale.dcm.
899 2004-06-24 Jean-Pierre Roux
900 FIX : Write - All the Sequences and Sequence Item are now written
901 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
902 is added a the end, when necessary.
903 - A lot of brain-damaged images, that were read correctly are
904 now written correctly
905 - length compatible BinEntry are now loaded correctly
906 (even for odd groups)
907 Note : only Explicit Value Representation was checked.
908 (question : is implicit VR really necessary for gdcm ?)
910 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * DEVELOPPER: added a proposition of coding style.
912 * src/gdcmDocEntry.h: removed every inline declaration (for test of
915 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
916 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
917 Use the gdcmDocEntry::Print() and Write() instead.
918 * src/gdcmDocument.cxx: bug fix.
920 2004-06-22 Jean-Pierre Roux
921 FIX : gdcmDocument.cxx
922 - Now we do recognize the JpegLossLess format (there was a misstyping in
923 code 'beautyfication' :-(
924 - Now we automaticaticaly load the Luts, if any
926 2004-06-22 Jean-Pierre Roux
927 In order : to write Sequences, whatever their imbrication level,
928 : to allow user to create his own Sequences
929 a lot of modif where necessary (adding, moving, or virtualising methods)
931 WARNING : save your own sources *before* cvs up !
934 ADD virtual void Write(FILE *fp, FileType filetype);
937 ADD virtual void Write(FILE *fp, FileType filetype);
938 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
941 ADD virtual void Write (FILE *fp, FileType filetype)=0;
942 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
943 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
944 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
945 ADD std::string GetEntryByName(TagName name);
946 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
948 std::string vr = "unkn",
949 std::string fourth = "unkn",
950 std::string name = "unkn");
951 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
952 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
953 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
954 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
955 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
956 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
957 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
958 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
961 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
962 ADD virtual std::string GetEntryByName (TagName tagName);
963 ADD virtual std::string GetEntryVRByName (TagName tagName);
964 REM virtual bool Write(FILE *, FileType);
965 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
966 FILE *_fp, FileType type);
967 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
968 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
969 REM virtual bool WriteEntries(FILE *_fp,FileType type);
970 REM virtual std::string GetEntryByName (std::string tagName);
971 REM virtual std::string GetEntryVRByName (std::string tagName);
972 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
973 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
974 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
976 std::string vr = "unkn",
977 std::string fourth = "unkn",
978 std::string name = "unkn");
979 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
980 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
981 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
982 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
985 ADD virtual void Write(FILE *fp, FileType filetype);
988 ADD virtual void Write(FILE *fp,FileType filetype);
991 ADD virtual void Write(FILE *fp, FileType filetype);
992 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
993 REM std::string GetEntryByNumber(guint16 group, guint16 element);
994 REM std::string GetEntryByName(TagName name);
997 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
999 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1001 The default constructor invoked by the line
1002 gdcmHeader *f1 = new gdcmHeader( header );
1003 was gdcmHeader::gdcmHeader(bool) instead of the expected
1004 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1005 Hence the parsing wasn't executed... See also below.
1006 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1007 as explicit constructor didn't do the trick to fix the above problem.
1008 Could anyone explain why ?
1009 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1010 properly calls gdcmValEntry::Print() (that was weed out from
1011 code related to gdcmBinEntry).
1013 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * In order to fix memory leaks:
1015 - Test/TestWriteSimple.cxx: added cleaning of free store through
1017 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1018 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1019 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1020 (through the call to ::AddDicomDirMeta()) or the destructor
1021 would crash when deleting uninitialized ::metaElems].
1022 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1023 - src/gdcmDocument.cxx:
1024 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1025 from dynamic stores.
1026 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1027 was causing memory leaks.
1028 - src/gdcmSQItem.cxx:
1029 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1030 cleanly handled with polymophism: sorry but my milage is low).
1031 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1032 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1033 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1034 This avoids SegFaulting.
1035 - src/gdcmSQItem.h: coding style.
1037 - Test/TestWriteSimple still severely sucks. The output image content
1038 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1039 damaged when displayed with vtkgdcmViewer.
1040 - on memory leaks: TestWriteSimple leaks really less (see entry
1041 of 2004-06-18 in Changelog file for the call to valgrind).
1042 - on segfaults: ctest now passes all the tests but one (no more
1044 * Erroneous leading white fix:
1045 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1046 white[s] (as opposed to from >> xxx, that removes it [them].
1047 - src/gdcmTS.cxx: ditto.
1048 - gdcmPython/testSuite.py: dirty related kludge removed.
1049 * src/*: remaining references to gdcmParser removed.
1050 * src/*[cxx|h]: added copy[way]left header.
1053 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * In order to fix writing of dicom files:
1055 - Test/TestWriteSimple.cxx: a simpler example of writing.
1056 - Test/CMakeLists.txt changed accordingly.
1057 - src/gdcmDocument.cxx:
1058 -- The destructor now recursilvely removes potential sequences.
1059 -- Bug fix in ::IsJPEG2000()
1060 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1061 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1063 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1064 to only declared) and build on top of
1065 ::GetDocEntryByNumber(guint16, guint16).
1066 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1067 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1068 for usage in destructor and treatement of promotion in
1069 ::ReplaceOrCreateByNumber().
1070 - src/gdcmSQItem.cxx: destructor should better handle his job.
1071 Test/TestWriteSimple now runs (or at least it DOES something).
1072 * We can now start hutting memory links. A good starting point is:
1073 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1074 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1075 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1077 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1078 * Valgrind note: after Mathieu Malaterre teached me how to read
1079 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1081 Using gcc, you can force the STL to use malloc and to free memory as
1082 soon as possible by globally disabling memory caching.
1083 With 3.2.2 and later, you should export the environment variable
1084 GLIBCPP_FORCE_NEW before running your program.
1085 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1086 simply vanish (it is still not clear to me, whether this means that
1087 STL std::string leaks or if valgrind believes it leaks...).
1088 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1089 running bin/gdcmTests makeDicomDir):
1090 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1091 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1093 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1094 SegFaulting (I drowned in DicomDir related code when trying to
1095 understand why the list is empty...).
1096 * src/gdcmDocument.h: first BSD license header try.
1097 * Doc/License.txt added.
1099 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1100 * src/gdcmDocument.[h|cxx]:
1101 - Clean up of the Transfer related predicates. They are now all based
1102 on new method isGivenTransferSyntax, that (should) handle properly
1103 the padding problem.
1104 - general clean up, simplification, and coding style.
1105 - Specific clean up of Parse7FE0() (umproperly named actually).
1106 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1108 2004-06-14 Jean-Pierre Roux
1110 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1111 - fix the display of SQItem ordinal number
1112 - add the GetSQItemByOrdinalNumber method
1113 - remove some useless never written private methods
1115 2004-06-14 Jean-Pierre Roux
1117 - adding a constructor taking a gdcmDocEntry as an input param
1118 - ReplaceOrCreateByNumber now returns :
1119 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1120 a gdcmValEntry * if a string value is passed as a param
1122 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1123 according to the param type (no longer sets a gdcmDocEntry)
1124 - GetValEntryByNumber, GetBinEntryByNumber added
1125 - NewValEntryByNumber and NewBinEntryByNumber added
1127 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1129 - GetSQItemNumber and SetSQItemNumber added, to provide
1130 a (relative) Item identier inside a given Sequence
1131 \warning : some pb remaining around this number
1133 - AddEntry now takes the Item Number as a param
1135 - adding a constructor taking a gdcmDocEntry as an input param
1137 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1138 * Memory leak hunt with the following command:
1139 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1140 --show-reachable=yes gdcmTests PrintDocument
1141 It looks like many (all?) leaks are due to the STL (or a bad usage
1142 of the STL. The lines producing the leaks now have a comment with
1143 a "MEMORY LEAK" tag: you can retrieve them with
1144 grep "MEMORY LEAK" src/*
1145 Here are two typical examples which I can't help fixing:
1150 char * test = "babo";
1151 name = test; //// <--- valgrind detects 960 bytes lost in
1152 //// call to std::string::operator=(char const*)
1153 name.clear(); //// Doesn't help !
1161 std::cout << "Type a bunch of characters followed by RETURN: ";
1162 getline(std::cin, line); //// <--- valgrind dectects a loss
1163 //// of 1320 bytes in call to
1164 /// std::basic_istream<>& std::getline<>
1170 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1171 * src/gdcmHeader.[cxx|h]:
1172 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1173 and related, moved away to gdcmDocument.
1174 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1175 the corresponding protected accessors of inherited class
1176 gdcmDocument, removed ! As a consequence gdcmFile had to be
1177 declared friend of class gdcmDocument (see below).
1178 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1179 - Clean up of undefined or unused methods.
1180 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1181 account the changes to gdcmHeader.h).
1182 * src/gdcmDocument.h:
1183 - gdcmFile is now a friend class (in order to take into account the
1184 changes to gdcmHeader.h).
1185 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1186 (see changes to gdcmHeader.h).
1187 - Accessors (reading on the form GetEntry*) are now public.
1188 - Clean up of undefined or unused methods.
1189 * src/gdcmDocument.cxx:
1190 - adaptation to changes to gdcmDocument.h
1191 - ::OpenFile now writes a verbose message when file cannot be opened.
1192 - some std::string properly set to VRKey
1193 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1194 references to gdcmDocument.
1195 * Test/TestFindTags.cxx: changed accordingly to above changes.
1196 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1197 cvs repository gdcmData.
1199 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1200 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1201 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1202 conflicts with gdcmValEntry::voidArea.
1203 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1204 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1205 Value representation between StringRepresentable and BinaryRepresentable.
1206 * src/gdcmDocument.cxx:
1207 - method ParseDES: proper indentation restored and usage of
1208 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1209 - method LoadDocEntry: the fingerprint left in the SetValue() of
1210 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1211 removed. Reverting to previous code segment with the proper
1212 dynamic_cast< gdcmValEntry* >.
1213 Note: this was (partially) breaking the python test suite
1214 (gdcmPython/testSuite.py) that made usage of the above
1215 fingerprint to check presence of "Pixel Data".
1216 * src/gdcmDocEntry.h: coding style.
1217 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1218 now taken into account.
1219 * gdcmPython/gdcm.i: adaptation to the new internal representation
1220 of gdcm (exit gdcmParser, hello gdcmDocument).
1221 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1223 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1224 anymore, but instead prints the loaded Python dictionary.
1225 * .... alas, the python testSuite is still broken.
1227 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1228 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1230 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1231 * src/gdcmUtil.h : export methods
1233 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1234 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1236 * Initial addition of automatic python testing
1237 * Initial addition of automatic image comparison
1239 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1240 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1241 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1243 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1244 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1245 * Test/ShowDicom.cxx : bug fix for msvc compilation
1246 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1248 2004-05-04 Jean-Pierre Roux
1249 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1250 new concepts (and new classes) :
1251 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1252 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1253 - Sequence Doc Entries (gdcmSeqEntries)
1254 a Sequence is composed of Items.
1255 Each item is a set of Doc Entries (this is recursive)
1256 The non uniqueness of the 'Dicom tag' is due to this recursivity
1257 (never taken into account)
1258 Our unability to add a new 'entry' in the header
1259 at the proper location (neither in the H-Table (map or multimap),
1260 nor in the Chained List is also due to this recursivity.
1261 Don't try, right now, to use/modify/compile these new sources :
1262 nothing is finished.
1263 We just commit all the stuff, 'as is', in order not to loose it.
1265 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1266 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1268 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1269 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1270 file prefix (SetFilePrefix)
1272 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1273 * Add a new test: ShowDicom, for now this is just the c++ version of
1274 checkRead.sh, later it will be able to compare the image read against a
1276 * Replace the DEBUG on the stack with a global entry in cmake interface:
1277 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1279 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1280 * Add an example subdir, with a real example on how to read + write a
1283 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1284 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1285 * Doc/CMakeLists.txt: the main page is now properly differentiated
1286 between the developper and user version.
1287 * Doc/doxygen.config.in: dropped search related obsolete flags
1288 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1290 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1291 * DEVELOPPER: added some helpfull comments for compile/test/install
1294 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1295 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1296 src directory, now generated in the build dir.
1297 2. Tests as mentionned smarter
1299 4. Add a new method in gdcmDict that return the PubDict by name
1300 this is interesting for 3rd party lib like ITK,
1301 where we could set the institution name / patient name...
1303 * ENH: 1. Now the test suite is working for real
1304 2. All binaries are now output in the gdcm-bin directory
1305 (this was not true before)
1307 2004-04-28 Jean-Pierre Roux
1308 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1309 SeQuence indented printing of Dicom Header.
1310 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1311 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1312 Computation of SQDepthLevel is now part of gdcmHeader constructor
1313 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1314 tree-like structure of a Dicom Header.
1315 * FIX Test code cleaning
1317 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1318 * ENH: Adding automatic testing
1319 1. Need a DartConfig.cmake to submit to public
1320 2. Add a test driver gdcmTest.cxx
1321 3. gdcmTestMain, an helper for the main test driver gdcmTest
1322 4. Files in Test don't have a main anymore, this becomes interesting
1323 when we add more and more tests, thus dsw don't have to load
1325 * ENH: Adding a GDCM_DATA_ROOT for testing
1326 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1327 one file instead of seven + some small cleanup
1329 2004-04-22 Jean-Pierre Roux
1330 * ENH Minor changes to the Print() methods.
1331 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1332 Header printing. Example given with :
1333 > PrintHeader fileName 2 new
1334 (SQ based tree-like structure still to be done for the Header ...)
1336 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1337 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1338 1. I have added some unsigned where needed
1339 2. Some function parameter not used -> (void)
1340 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1341 4. g++ don't like character '\' in comment
1342 5. #define jpeg_create_decompress jCreaDecompress
1343 this really need to be fixed
1344 6. virtualize destructor of gdcmObject ... leakage
1345 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1346 this also really need to be fixed
1347 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1348 remove compression file
1349 (as we only do decompression, right ?)
1350 * ENH: Change malloc/calloc/free with c++ equivalent
1352 2004-04-21 Jean-Pierre Roux
1353 * FIX gdcmHeaderHelper::GetXSpacing
1354 when a single value is found (bug ?), xpacing is now
1355 defaulted to yspacing
1357 2004-04-19 Jean-Pierre Roux
1358 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1359 * ENH add parameters :
1360 bool exception_on_error = false,
1361 bool enable_sequences = false,
1362 bool ignore_shadow = false
1363 to the gdcmFile constructors to be full gdcmParser compliant
1364 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1365 to allow reading of PAPYRUS 3.0 files
1367 2004-04-06 Jean-Pierre Roux
1368 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1370 2004-04-02 Jean-Pierre Roux
1371 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1372 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1373 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1375 2004-03-30 Jean-Pierre Roux
1376 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1377 for ACR file, written out as DICOM files (hope so...)
1379 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1380 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1381 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1382 moved to base class gdcmParser and only the specialisation is kept
1384 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1385 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1386 already does the job.
1387 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1388 (to be consistent with gdcmParser::WriteEntries).
1390 2004-03-30 Benoit Regrain
1391 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1392 upate of the object's instance. It's passed to 2 in the unfavorable
1393 case : one in the ExecuteInformation, one in the ExecuteData
1395 2004-03-29 Jean-Pierre Roux
1396 * ENH : Check on file type to be written moved
1397 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1398 * FIX : gdcmObject::ResetBoundaries now stops properly
1399 when end-of-list is reached
1400 : gdcmVersion modified (as Benoit Regrain asked)
1402 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1404 * src/gdcmUtil.cxx: added forgotten iostream include.
1405 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1406 equivalent to ExplicitVR in existing code).
1408 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1410 now contains all the gdcmGlobal related code.
1411 * minor coding style and doxygenation changes.
1413 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1414 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1415 now contains all the Debug related code.
1416 * minor clean-up of includes in src/*.cxx
1417 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1418 CreateCleanString) removed.
1419 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1420 * Doc/DoxyMainPageUser.txt added.
1421 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1422 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1423 src/gdcmDirList.cxx)
1425 2004-03-24 Jean-Pierre Roux
1426 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1428 2004-03-23 Jean-Pierre Roux
1429 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1430 big endian made volumes
1431 * ENH Now gdcmParser constructor and destructor are protected to forbid
1432 end user to instanciate class gdcmParser
1433 (only gdcmHeader and gdcmDicomDir are meaningfull)
1435 2004-03-22 Benoit Regrain
1436 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1437 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1438 gdcmSerie to gdcmDicomDirSerie
1440 2004-03-19 Jean-Pierre Roux
1441 * ENH Now the tree-like structure describing a DICOMDIR comming from
1442 an already existing DICOMDIR file is consistent with
1443 the home-made tree-like structure build ex-nihilo
1444 or build from the files held (recursively) in a Directory
1445 functions gdcmDicomDir::CheckBoundaries()
1446 gdcmObject::SetBoundaries() added
1448 2004-03-17 Jean-Pierre Roux
1449 * REM (Eric Boix bug) : removal of meaningless
1450 gdcmDicomDirImage::NewImage function.
1451 * FIX now file names and directory name are written properly in the
1453 * FIX now gdcmDicomDir constructor may be call without any trick
1456 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1458 of gdcmDicomDirImage::NewImage as empty function.
1460 2004-02-28 Jean-Pierre Roux
1461 * ENH add gdcmDicomDir:NewPatient
1462 add gdcmDicomDirPatient:NewStudy
1463 add gdcmDicomDirStudy:NewSerie
1464 add gdcmDicomDirSerie:NewImage
1465 to allow making gdcDicomDir object.
1466 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1467 (as opposite to the gdcmHeader chained list)
1469 2004-02-11 Benoit Regrain
1470 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1471 when using from python
1473 2004-02-10 Benoit Regrain
1474 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1475 * FIX : in gdcmDicomDir when the directory is empty
1476 * ENH : add callback and methods to get the progression of dicomDir
1479 2004-02-06 Jean-Pierre Roux
1480 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1481 - GDCM_META added to gdcmDicomDirType
1482 - class gdcmMeta created
1483 * ENH : - A brief summary is now displayed at the beginning of
1484 'testDicomDir' to help disaster magnitude estimation
1485 * REM : Now useless Test/explDICOMDIR.cxx
1487 2004-02-05 Benoit Regrain
1488 * ENH : add methods in gdcmObject to get the hash table or the list of
1490 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1491 * FIX : wrapping python for TagHeaderEntryHT
1493 2004-02-04 Benoit Regrain
1494 * FIX : even length for some strings when writting the dicom dir
1495 * FIX : sort the images in the dicom dir
1496 * FIX : Bug fix for python use of dicom dir
1497 * ADD : a python demo
1499 2004-02-04 Jean-Pierre Roux
1500 * FIX : Final solution (?) for icone embedded images
1501 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1502 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1503 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1504 gdcmData/gdcm-MR-SIEMENS-16.acr1
1505 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1506 to make full checking easier
1508 2004-02-04 Benoit Regrain
1509 * FIX : WriteEntries : coding style & logic in parameters
1510 * FIX : Set the elements to create the DicomDir in a dictionary file
1512 2004-02-03 Benoit Regrain
1513 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1514 * gdcmDicomDir : add the load of directory
1515 * Bug fix and print add-on
1517 2004-02-03 Jean-Pierre Roux
1518 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1519 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1520 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1521 * FIX gdcmParser.cxx : 'group length' elements are now considered
1522 as integers, even for shadow groups, when file is Implicit VR
1524 2004-02-02 Jean-Pierre Roux
1525 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1527 of the last synonym :-(
1528 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1530 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1531 * FIX taking into account the possible 7fe0,0010 multiplicity
1532 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1533 to allow removal of references to 7fe0,0010, to deal with
1534 ACR-NEMA images, when 0028,0200 is meaningfull
1536 2004-01-31 Jean-Pierre Roux
1537 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1538 no longer writes 'Un' on disk
1539 * FIX SQ elements with actual length are now dealt with corectly
1540 * FIX gdcmFile::WriteBase make the difference, for color images, between
1541 the length (for Palette expanded images)
1542 and Raw Length (non expanded image + Palette)
1543 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1544 (that broke Write). Replaced by UL.
1545 Aware user will reload the field if he
1546 thinks it's necesssary
1548 2004-01-30 Jean-Pierre Roux
1549 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1550 when 'dirty Acr' is found, to be compliant with the new
1551 IsReadable() methods.
1553 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1554 (no DOUBLE images in kosher DICOM,
1555 but so usefull for people that miss them ;-)
1557 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1558 DICOMDIR related utilities (not checked as Windoze compliant)
1560 2004-01-28 Jean-Pierre Roux
1561 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1563 2004-01-27 Jean-Pierre Roux
1564 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1565 to allow skipping the shadow elements, to save memory space.
1566 The TRUE value for this param has to be used
1567 with a FALSE value for the 'enable_sequence' param.
1568 ('public elements' may be embedded in 'shadow Sequences')
1569 * gdcmHeader methods now deal with 'embedded icones images' in the header
1570 (even when an 'icone image sequence' is announced by the
1571 element (0x0088,0x0200), but there is NO icone at all ...
1573 * gdcmHeader sometimes Image Location value doesn't follow
1574 the supposed processor endianity (see gdcmData/cr172241.dcm).
1577 * gdcmHeader add the method
1578 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1579 to get *all* the Header Entries with the same tag.
1580 GetHeaderEntrySameName is probabely *useless*
1581 (no meaning : Name is *not* an identifier within the Dictionnary)
1583 2004-01-26 Benoit Regrain
1584 * Bug fix in the print of hexadecimal representations. Remove long fields
1585 in the print and add a third level of print to print them
1587 2004-01-23 Benoit Regrain
1588 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1589 * Bug fix on test suite after remove the strip made on not string fields
1590 * Split the IsReadable method between gdcmParser which test that the file
1591 is dicom and gdcmHeader which test that it's an image file
1593 2004-01-22 Benoit Regrain
1594 * DicomDir : clean code, add methods, set variables in protected or private
1595 * gdcmUtil : bug fix for the clean string method
1597 2004-01-19 Benoit Regrain
1598 * Add the use of shadow dictionaries
1599 * bug fix and coding style
1601 2004-01-19 Benoit Regrain
1602 * src/gdcmFile.cxx : bug fix concerning the close of file
1603 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1604 * Add the update of header entries using the shadow library
1606 2004-01-19 Benoit Regrain
1607 * removal of file gdcmHeader2.cxx
1608 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1609 inheriting from gdcmParser. This split is to prepare the integration
1610 of dicom dir parsing
1611 * bug fix under python
1613 2004-01-16 Jean-Pierre Roux
1614 * REM removal of class gdcmHeaderEntrySet
1615 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1616 * ADD add file gdcmHeader2.cxx
1617 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1619 2004-01-15 Benoit Regrain
1620 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1621 entries created while parsing the header. Thus, they will be destroyed
1622 when the gdcmDictSet will be destroyed
1623 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1626 2004-01-15 Benoit Regrain
1627 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1628 made a fatal error because of the memory release at the end of program.
1629 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1630 some memory and vtk seems to have some problems with that.
1631 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1633 2004-01-14 Benoit Regrain
1634 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1635 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1636 * src/*.[h|cxx] : make changes due to class name changes
1637 * gdcmPython/demo/*.py : bug fix due to method names
1639 2004-01-13 Benoit Regrain
1640 * src/*.[h|cxx] : coding style
1641 * vtk/*.[h|cxx] : coding style
1643 2004-01-13 Benoit Regrain
1644 * gdcmPython/testSuite.py : test the readable flag of file for tests
1645 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1646 It's lied to the stl compilation by MSVC (windows, always windows...)
1647 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1649 2004-01-12 Benoit Regrain
1650 * src/*.h : add comments
1651 * src/gdcmDictSet.h : set the method BuildDictPath in public
1652 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1653 directly setted in the source code
1654 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1657 2004-01-09 Benoit Regrain
1658 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1659 * setup.py : use a reference to gdcmVERSION
1661 2004-01-07 Benoit Regrain
1662 * Modification to compile with the distutils.
1665 2003-12-10 Benoit Regrain
1666 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1667 can use a gdcmHeaderHelper to load datas
1668 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1669 made in the source code
1671 2003-12-10 Benoit Regrain
1672 * Update Windows projects and .cvsignore files
1674 2003-11-12 Jean-Pierre Roux
1675 * ENH gdcmHeader constructor has one more parameter (default value : false)
1676 that allows the user to 'go inside' the SeQuences only
1678 gdcmElValSet:Print takes it into account
1680 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * ENH: Update gdcmPython/CMakeLists
1682 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1683 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1685 2003-11-10 Jean-Pierre Roux
1686 * FIX : gdcmHeader::LoadElements is now based
1687 on the ListTag listElem member,
1688 not longer on the TagElValueHT tagHt member
1689 * ENH : PrintPubElVal shows (temporarily) both results,
1690 with the tagHt member and the listElem member.
1691 (it's easier to 'see' the problems when using Printheader)
1693 * FIX : old private member LgrElem is now splitted into
1694 ReadLength : Length actually found on disk (updated only
1695 if bug fixing is necessary), for internal
1697 UsableLength : Updated by FixFoundLength, to fix a bug
1698 or to allow Parser going on.
1699 Will allow to re-write a kosher header when a SeQuence
1700 with a length (not 0000) is found
1701 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1702 because gdcmElValSet::Add does not update ListElem
1705 2003-11-07 Jean-Pierre Roux
1706 * FIX misstyping in Transfert Syntax name table
1707 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1708 when they have an actual length (not 0000 nor FFFFF)
1709 (Nobody should care of it, but DICOMDIR explorers)
1711 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1712 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1714 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1715 * ENH: vtkGdcmReader now supports LUT !
1716 (vtkgdcmViewer for now is not able to use them though)
1718 2003-11-05 Jean-Pierre Roux
1719 * in testSuite.py : new files names for checking the package
1720 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1721 that returns the pixel area size to the *aware* (vtk) user
1722 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1724 2003-11-05 Benoit Regrain
1725 * in testSuite.py : Modify the rules for checking the paths
1726 : Explicit error messages
1727 * in __init__.py : Related modif
1729 2003-11-03 Jean-Pierre Roux
1730 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1731 to be used by aware (vtk) users that want to manage
1732 LUT (and no to turn the PALETTE image into an RGB pixels one)
1733 * GetPixelType now returns 8U for 24 Bits images
1734 (vtkGdcmReader compliant)
1736 2003-10-31 Jean-Pierre Roux
1737 * Removal of *all* gdcmData images and add them again
1738 in order to loose the 'history' of un-anonymised images
1740 2003-10-31 Jean-Pierre Roux
1741 * RMV : removal of useless jBitsInJsample.h
1742 for both 8 and 12 Bits JPEG Lossy Libraries
1744 2003-10-31 Jean-Pierre Roux
1745 * ENH : Add the functions gdcmFile::GetImageDataRaw
1746 gdcmFile::GetImageDataIntoVectorRaw
1747 that act as GetImageData and GetImageDataIntoVector
1748 except the making of an RGB Plane from Gray Plane + LUT
1749 Intended to aware (vtk) users who know how to manage
1752 GetLUTRGBA return a R,G,B,A LUT if any
1753 lgrTotaleRaw gives the 'Raw' length
1754 GetImageDataRaw returns the gray Plane
1755 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1756 (They stay Grey, just like with other Dicom viewers :-(
1758 2003-10-30 Jean-Pierre Roux
1759 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1761 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1762 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1763 being coherents dicom files.
1765 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1766 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1768 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1769 * ENH: Two steps is necessary to please VC++ compiler...
1770 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1771 * ENH: Add include dir to medcon lib
1772 * FIX: only one function is being exported for now !
1773 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1775 2003-10-29 Jean-Pierre Roux
1776 * adding gdcmHeader::GetLUTRGBA
1777 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1778 --> Mathieu, the modif u're waiting for is not yet committed
1779 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1781 2003-10-27 Jean-Pierre Roux
1782 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1783 00191113.dcm DermaColorLossLess.dcm
1784 MxTwinLossLess.dcm RadBWLossLess.dcm
1785 * ENH: For version prior to vtkImageViewer2 -r 1.19
1786 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1788 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1789 * Removal of ido stuff in CMakeLists.txt
1791 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1792 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1793 * FIX: remove a call to ->Modified ... see comments
1794 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1796 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1797 * FIX: Problem with path for libvtkgdcmPython
1798 * ENH: Try adding a search script for python site-package
1799 * RMV: Remove some file from medcon lib that are not necessary
1800 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1801 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1802 * FIX: More pragma disable fro VC++,
1803 I don't think I break something as it is also disable in VTK/ITK.
1804 But it fasten debug compilation time.
1806 2003-10-23 Jean-Pierre Roux
1807 * gdcm now deals with 16 Bits Run Length Encoded images
1808 (they are compressed as 2 planes images,
1809 one for the high Bytes, the other for low Bytes)
1811 2003-10-22 Jean-Pierre Roux
1812 * Now CheckRead takes into account :
1813 - the bugged 'Leonardo' Siemens images
1814 - the XA images, sent thru the burning VPRO station
1815 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1818 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * FIX: When copying a Makefile.am to CMakeLists.txt
1820 one should remove the '\'
1822 2003-10-22 Jean-Pierre Roux
1823 * in gdcmData adding a bugged 'Leonardo' Siemens image
1824 (wrong lengths in header)
1825 OK with gdcm, KO with the other viewers :-)
1826 * add a GE dlx XA image, thru the VEPRO burning station
1829 2003-10-21 Jean-Pierre Roux
1830 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1831 for a brutal checking of vtkgdcmViewer compliance
1833 2003-10-21 Jean-Pierre Roux
1834 * add the files for 'xmedcon' Jpeg Lossless library
1835 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1837 2003-10-21 Jean-Pierre Roux
1838 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1840 2003-10-21 Jean-Pierre Roux
1841 * garbage Siemens 'Leonardo' images dealt with
1842 (the patch is easy to remove)
1843 * cosmetic changes to avoid warnings
1845 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1847 no need to press 'r' now.
1849 2003-10-20 Jean-Pierre Roux
1850 * upgrade of checkRead.sh checkWrite.sh according
1851 to new Jpeg Lossless decompressor
1852 * add US.3405.1.dcm, a genuine RGB medical file ...
1853 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1854 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1856 2003-10-15 Jean-Pierre Roux
1857 * general anonymisation in gdcmData
1858 * adding the 'color files' from
1859 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1860 * adding some well knowed bugged-header images
1861 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1862 waiting for their inclusion in Python testsuite
1864 2003-10-15 Jean-Pierre Roux
1865 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1866 no longer seg faults when file is not found
1868 2003-10-14 Jean-Pierre Roux
1869 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1872 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1873 * TODO: *.in file to genereate a UseGDCM later
1875 2003-10-14 Jean-Pierre Roux
1876 * Some supposed-to-be Dicom Images have no preamble.
1877 OpenFile takes it into account
1878 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1879 * Missing elements added in dicomV3.dic
1880 (just to be affraid : have a look at
1881 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1882 and do it again next year ;->
1884 2003-10-13 Jean-Pierre Roux
1885 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1886 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1887 But there are NOT. It's fixed !
1889 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1890 * FIX: "jpeglib.h" was not found on VC++
1891 * FIX: vtkgdcm was not being installed
1893 2003-10-10 Jean-Pierre Roux
1894 * ENH : OpenFile closes the file if it *really* doesn't look like
1895 an ACR-NEMA / DICOM one.
1896 * FIX : testWrite no longer writes an empty file if the source file
1897 is not gdcm Readable
1898 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1901 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1902 * FIX: CMake generate now documentation
1903 * ENH: out of source doc build !
1904 * ENH: Generate both user and dev documentation
1905 * ENH: Should work on windows too
1906 * ENH: Only one doxygen config.in file is needed
1907 * FIX: make install should be ok now on ùnix plateform
1908 * FIX: PATH to dictionary was wrong (missing /)
1909 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1911 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1912 * vtkGdcmReader is now able to read rgb dicom file.
1913 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1914 * added a gdcmViewer to vtk test, use mouse to control
1915 window level & window width
1917 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1918 * CMake-ification of gdcm, we have now two build system
1919 * FIX: on cygwin Wsock32 doesn't exist
1920 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1922 2003-10-06 Emanuel Ollart
1923 * FIX : compilation process wad broken.
1924 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1926 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1927 * change gdcmViewer -> vtkgdcmViewer
1928 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1930 2003-10-06 Jean-Pierre Roux
1931 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1932 ( e.g : well known GE images with a wrong elem length,
1933 : Philips MRI Images with a wrong Huffman table)
1934 * still to be done : allow the reading of bugged LEONARDO Siemens images
1936 2003-10-03 Jean-Pierre Roux
1937 * Odd length strings are padded with '\0' (not with spaces,
1938 to remain compliant with already defined strings,
1939 like Transfert Syntax UID and others)
1941 2003-10-03 Jean-Pierre Roux
1942 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1943 to allow displaying RGB images (not only by affim ;-)
1945 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1946 * vtkGdcmReader is now able to read rgb dicom file.
1947 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1949 2003-10-03 Jean-Pierre Roux
1950 * A few nasty patches to allow the reading of a lot of nasty images
1951 ( e.g : well known GE images with a wrong elem length,
1952 : Philips MRI Images with a wrong Huffman table)
1953 * still to be done : allow the reading of bugged LEONARDO Siemens images
1955 2003-10-03 Jean-Pierre Roux
1956 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1958 2003-10-03 Jean-Pierre Roux
1959 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1960 to allow displaying RGB images (not only by affim ;-)
1962 2003-10-03 Jean-Pierre Roux
1963 * gdcmFile::GetImageDataIntoVector now
1964 - deals with MultiFrames MultiFragments Run Length Encoded files
1965 - deals with YcBcR (YBR_FULL) files
1966 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1967 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1969 (no sample found :-(
1971 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1972 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1973 Two reasons: - clear things
1974 - third parties acces gdcm through header files, so won't
1975 suffer anymore VC++ complains
1977 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1978 * add argv[1] in testvtkGdcmReader.cxx
1981 2003-09-24 Jean-Pierre Roux
1982 * The lines are now eigthy characters long.for
1983 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1985 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1986 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1987 char* to std::string. Thus, the use of strdup becomes useless. (see
1988 previous commis of Malaterre)
1989 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1990 before the last Malaterre's commit.
1992 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1993 * This commit should fix the Debug building under VC++, the problem
1994 was mainly a mixture of debug and release lib being loaded at startup.
1995 * I also remove a depency to a specific C function: strdup. Because I had
1996 to force the link to msvcrtd (whereas strdup is in libc).
1998 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1999 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2000 located in the gdcmCommon.h file. All use of reference of tha has been
2001 changed to now use the variable GDCM_UNFOUND.
2003 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2005 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2006 Dicom dictionary. The test suite can now be run again. Note:
2007 I'm note very happy with the " (RET)" changes. I believe this
2008 RETAINED comment should be dropped when parsing the dictionary.
2009 - PACKAGER corrected
2011 - AUTHORS updated and now in alphabetical order
2012 * Makefile.am now exports gdcm.dsw for Windoze users.
2014 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2015 * cygwin complains about missing std:: in subdir Test/
2017 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2018 * remove some methods that are now in gdcmHeaderHelper
2020 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * vtkGdcmReader set spacing and origin correctly
2023 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2024 * Fix a few delete/delete[] mismatch
2026 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2028 interpretation to data given by gdcmHeader. For instance there are
2029 heuristics to get informations (look at different places).
2030 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2031 sorting DICOM images based on different strategies.
2032 * modified Makefiles accordingly.
2034 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2035 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2036 when building in debug mode
2037 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2038 src/win32/gdcmdll.dsp
2039 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2041 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2042 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2045 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2046 * src/win32/libgdcmjpeg12.dsp was not dos format
2047 * src/win32/libgdcmjpeg12.dsp :
2048 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2049 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2051 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2052 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2054 * src/gdcmFile.cxx : bug fix in affectation type
2055 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2056 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2057 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2058 symbols... future problem ?
2060 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2061 * src/win32/libgdcmijpeg12.dsp was missing
2062 * modified gdcm.dsw accordingly
2064 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2065 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2067 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2068 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2069 commit of JPR (before his hollidays to facilitate our work).
2070 * setup.py : bug fix in code. Modifications made while the last commit
2071 of JPR. The code hasn't been tested before the commit... it's so
2072 useless to make that (for best programmer that is JPR) !!!
2074 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2075 * tagged the current version as Version0_3 (i.e. version 0.3)
2077 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2078 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2079 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2080 * *.dsp : modifications to use new libgdcmijpeg8 library
2081 * setup.py : bug fix on VTKPATH variable
2082 * PACKAGER : adding all concerning windows
2084 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2085 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2087 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2088 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2089 test suite reported error.
2090 * PACKAGER file added (describes what a packager must do when
2091 packaging a new release).
2092 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2093 * configure.in: upgraded version number to 0.3.0
2094 * fixing build of rpm (through rpm -ta):
2095 - Doc/Makefile.am exports proper doxygen files
2096 - src/jpeg/libijg8/Makefile.am exports the include files.
2098 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2099 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2100 * src/gdcmHeader.h : formatting code
2102 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2103 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2104 We were obtaining error message from vtk. Now, creation of file list
2105 is made in an internal list to prevent this problem.
2106 Bug fix when output is empty.
2107 Bug fix in update of progress value. Previous commit for this was a bad
2109 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2111 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2112 * src/gdcmHeader.h : added method to get the file name
2113 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2114 files. Added method to remove all files on the input
2115 Added FIXME comment concerning the bad parsing of header made by
2116 ExecuteInformation method (in ExecuteData method)
2118 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2119 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2120 when using make instal.
2121 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2122 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2124 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2125 * setup.py : adding include dir of jpeg lib to compile all sources
2126 * */Win32/*.dsp : JPR fix for windows compilation
2128 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2129 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2131 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2132 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2134 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * setup.py is again effective on un*x (takes into account the
2136 addon of the jpeg library)
2137 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2138 * Doc/Doxy* updated (includes above enhancements)
2139 * INSTALL now points to web documentation
2141 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2142 * src/gdcmHeader.h doesn't make unnecessary reference to
2144 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2146 * src/gdcm*.[cxx|h] :
2147 - to allow compilation with gcc 3.x
2148 -- clean up of STL usage (added explicit usage of std::)
2149 -- small fixes on exceptions.
2150 Note: linking not tested !
2151 - clean of doxygen comments to avoid warnings at documentation
2153 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2154 dependent convertion).
2156 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * Clean up of previous JPR garbage commit (not even commented in the
2159 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2160 - moved all jpeg related files from src to src/jpeg/libijg8, with
2161 addition/modification of Makefile.am and configure.in.
2162 - the testSuite is still brain damage (not guilty).
2164 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2165 * WrapVTK.py : modifications to get correctly vtk source files to
2167 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2168 (FileName -> Filename)
2170 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2171 * vtk/vtkGdcmReader.[cxx/h]:
2172 - UpdateProgress method should now be effective
2173 - removed the limitation on having only images loaded (as opposed
2175 - when building a stack of images/volume, a lesser number of
2176 gdcmHeader and gdcmFile instances should be used (hopefully
2177 accelerating things).
2178 - when building a stack of images/volumes, files which are not
2179 loadable (wrong path-filename, wrong permissions on existing file,
2180 or file not parsable by gdcm) are replaced with a black image
2181 in the stack (for the caller to notice the problem).
2183 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2186 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2187 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2188 between standard library (std) and vtk library (problems are found
2189 under Windows... thanks Windows !)
2191 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2192 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2194 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2196 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2197 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2199 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2200 * When compiling with distutils (see setup.py) the C++ compiler is
2201 called with different flags than the default ones (with automake).
2202 In order to fix all those warning, I compiled gdcm with the command
2203 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2204 and went for warning fixes:
2205 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2206 up from unused variables.
2207 - vtk/vtkGdcmReader.cxx: potential bug fix.
2208 * src/gdcmHeader.h: Doxygen warning cleanup
2210 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2211 * gdcmPython/gdcm.i:
2212 - typemaps correction to take into account the systematic replacement
2213 of "using namespace std" with std:: prefix e.g. std::list,
2214 std::string... (cf changes of 2003-05-21).
2215 - gdcmGlob global variable of type gdcmGlobal (defined in
2216 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2217 exported to Python a as cvar.
2218 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2219 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2220 gdcmDictSet.GetPubDictTagNames() and
2221 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2222 C++ static methods).
2223 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2224 with the above changes.
2226 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2227 * setup.py, manifest.in : bug fix under linux
2229 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2230 * Modification of setup.py to compile vtk part too. Then, we have 2
2231 wrappers which must work with same distutils. For that, we have a
2232 generic distutils in distusiltsWrapping.py ; with :
2233 - build_extWrap class to wrap generically all extensions,
2234 - ExtensionWrap base class for all wrapping extension that contains
2236 - Wrapper interface which wrap sources
2237 + In WrapSwig.py we have extension and wrapper for Swig
2238 + In WrapVTK.py we have extension and wrapper for VTK
2239 * MANIFEST.in : modifications to consider vtk directory and new python
2240 files for compilation
2242 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2243 * Added python wrappers of vtkGdcmReader vtk class (see the
2244 source in vtk/vtkGdcmReader.cxx) :
2245 - vtk/Makefile.am now builds a library
2246 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2247 python library (as opposed to _gdcm.so wich are the python
2248 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2249 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2251 - configure.in has an additional flag --enable-vtk that needs
2252 to be set to enable compilation of vtk related code, that is:
2253 + vtk/vtkGdcmReader.so and
2254 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2255 + gdcmPython/vtkgdcmPython.so (see above)
2256 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2257 be read when compressed or when HighBit + 1 != BitsStored),
2258 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2259 the usage of the python wrapper of vtkGdcmReader vtk class.
2260 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2261 * src/*.[h] all occurences of stl classes are now prefixed with
2262 std::, and all occurences of "using namespace std;" where removed.
2263 This is to avoid pollution of global namespace in included files.
2264 Apparently vtk does not avoid this pitfall: when using both
2265 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2266 collision of various stl members (principally cout...).
2267 * gdcmPython/testSuite.py now cleanly removes temprory generated
2269 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2270 comply with above changes)
2272 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2273 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2274 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2275 vtk data structure (an image Flip was required).
2276 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2277 * cosmetic changes in documentation.
2279 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2280 * src/gdcmHeader.cxx: the constructor no longer exits when an
2281 unexisting file is given as argument.
2282 * The subdirectory Data (containing all the images used for the
2283 test suite) is not part of this repository anymore. A new module
2284 containing those images is now available at
2285 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2286 with the name gdcmData.
2287 All the python scripts (including the package initialisation file
2288 gdcmPython/__init__.py) were adapated to take this change into
2289 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2291 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2292 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2293 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2294 demo of the usage of this class.
2295 Compilation of this vtk part is only done when using the --enable-vtk
2296 at configure (or autogen.sh) stage.
2298 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2299 * More memory link related corrections and documentation fixes.
2301 - maximum info is obtained with a command of the form:
2302 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2303 --show-reachable=yes PrintHeader
2304 - the remaining reachable blocks seem to come from the STL
2305 allocation scheme through the usage of map and list. It looks
2306 like this memory cannot be freed but it is not a memory leak
2307 (in fact further invocation to the STL would recollect the
2308 unused memory allthough it cannot explicitely be freed).
2309 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2310 of displaying an image parsed with gdcm and displayed with VTK.
2311 Note: some images don't seem to work e.g.
2312 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2313 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2314 Allthough this weakens the semantics, it is a ditch attempt to
2315 make gdcm more thread friendly.
2317 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2318 * Memory link hunt (by using valgrind through the command
2319 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2320 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2321 gdcmHeader::_dicom_vr.
2322 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2323 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2325 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2327 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2328 * src/Makefile.am now exports all the necessary include files at
2332 * UpdateGroupLength replaced by new one
2335 * UpdateGroupLength re-written using H-Table
2336 (named UpdateGroupLengthNew untill checks are over)
2338 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2339 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2340 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2342 - gdcmHeader::GetPubElValSet removed.
2343 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2344 UpdateGroupLength, WriteElements, Write.
2345 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2346 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2347 carried the same semantics.
2348 - src/gdcmHeaderIdo.cxx changed accordingly.
2349 - gdcmFile::WriteBase now regroups all the codes from previous
2350 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2351 - enum FileType moved to gdcmCommon.h
2352 * src/gdcmHeader.cxx AddDefault trashed
2353 * gdcmGetXSize added
2354 * getimageDataSize now calls gdcmGetXSize
2355 * Test/*.cxx changed to agree with above changes
2357 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2358 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2359 (to avoid double call by end user).
2360 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2361 by end user, since gdcmHeader::gdcmHeader now handles it.
2363 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2364 * gdcm/Doc many doxygen changes:
2365 - Doxyfile now has two different versions, DoxyfileUsers that generates
2366 the html.users end users oriented documentation and
2367 DoxyfileDeveloppers that generates the html.developper developper
2368 oriented documentation.
2369 - README changed accordingly
2370 - requirement.txt removed (old design info moved to TODO).
2371 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2372 DoxyMainPage.txt, DoxyPython.txt provide more information.
2373 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2374 be updated by simply regenerating the docs with doxygen and copying
2375 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2376 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2377 all the tests in the form "if (<map>.count() >1)" were removed.
2378 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2379 ill-formed documentation sections.
2380 * src/gdcmHeader.cxx: ditto
2382 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * setup.py fixed for un*x (needed macro for stdint.h)
2384 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2385 un*ces with sh-utils test utility.
2386 * gdcmPython/demo/test.py renamed to PrintHeader.py
2387 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2388 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2389 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2390 * src/gdcm*.cxx JPR's bad inclusion fixed.
2392 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2393 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2394 * gdcmPython/demo/test.py changed accordingly.
2396 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2397 * gdcmPython/Makefile.am fixed linking against libstdc++
2398 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2399 * Swig subdir (historical tests of swig version 1.3.17++) removed
2400 * Test/testChangeEntete.cxx some lines commented out in order to make
2402 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2403 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2405 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2406 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2407 hence the user doesn't need this explicit call.
2408 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2409 i.e. LoadElements() call removed.
2410 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2411 - src/Makefile.am declares the proper flag for g++.
2412 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2413 for adding user defined new tags.
2414 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2415 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2416 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2418 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2419 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2420 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2421 src/Makefile.am : the project should properly compile and install
2422 with the autotools, included the python wrappers part.
2423 * gdcm.spec.in : added a spec file for RPM packaging.
2425 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2426 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2428 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2429 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2430 to exported to the environement (see gdcmPython/testSuite.py
2432 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2433 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2434 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2435 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2436 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2438 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2439 * gdcmPython/__init__.py doesn't crash anymore when running in
2440 in InstallMode or PreInstallMode but with an environement given
2441 value of GDCM_DICT_PATH.
2442 * src/gdcmDictSet.[cxx/h] coding style.
2444 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2446 * src/gdcm.h general comments moved to TODO, and README
2447 * src/gdcm.h should now be seen as a user commodity (including it
2448 should suffice to fully use gdcm). It is nowhere including within
2449 any of the kernel files src/*.cxx and src/*.h.
2451 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2453 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2455 * src/gdcm*.cxx only include their corresponding include file
2456 (as opposed to gdcm.h)
2457 * gdcmPython/gdcm.i changed accordingly
2458 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2459 the autogen.sh generated "make snapshot" command to work.
2460 * autogen.sh removed history related references to crea package.
2462 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2463 * distutilsSwigCPlusPlus.py work around some swig portability
2466 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2467 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2468 was done in a last ditch attempt to get setup.py _really_
2469 operationnal. The python/gdcmPython layaout add the advantage
2470 of hidding away the python related distutils specific files
2471 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2472 Alas, the src directory was out of scope (i.e. it's relative
2473 position to setup.py was ../src) which made things impossible to
2474 handle (see previous version of python/setup.py). Crossing fingers...
2476 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2477 * python/setup.py now works on Un*x. (harder than I thougth)
2478 * python/distutilsSwigCPlusPlus.py can now have include files
2479 among the list of sources.
2481 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2482 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2483 * modifications in MSVC projects
2485 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * As stated by the first lines of Test/ExceptionAndPython/README, it
2487 looks like we can move back to original usage of exception within
2488 src/gdcm* and hence remove the errno stuff that was introduced
2489 as a quick and dirty fixture of this problem (added to the TODO).
2490 * Doc/Doxyfile configuration file for Doxygen and corresponding
2491 README file for usage added.
2492 * Test/testWrite.cxx added. This new test comes from a split of
2493 test.cxx that is now reverted to its original purpous i.e.
2494 testing the proper parsing of a Dicom related file.
2495 testWrite.cxx concentrates on testing the IO part of gdcm.
2496 * Test/bug1.cxx (containing a bug on WIn32) added.
2497 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2498 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2499 whose purpose is to publish the content of the TagNames of the
2500 Dicom public dictionnary were not accessible without an
2501 instance of class gdcmHeader.
2502 - those methods are now static methods of gdcmDictSet and hence
2503 require no instances at all to be invocated.
2504 - within gdcmDictSet this change required to change some method
2505 to class methods (i.e. are now static) among which SetDictPath
2506 (renamed to BuildDictPath) and LoadDefaultPubDict.
2507 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2508 the above changes by calling the new method classes of gdcmDictSet.
2509 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2510 the above to be effective.
2511 * python/gdcmPython: in order to wrap properly the above changes
2512 for Python, swig version now needs to be > 1.3.17.
2513 * python/gdcmPython/Makefile fixed to adapt itself to new
2514 configure/make shema introduced by Johan Montagnat (thanks for the
2515 contribution). Alas this Makefile cannot be turned into a proper
2516 Makefile.am without some heavy changes in the configure.in
2517 (for python dectection).
2518 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2519 now avoids publishing the empty entries.
2521 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2522 * python/setup.py : bug fix concerning install under windows
2523 ExtraPath reused :-P
2524 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2526 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2527 * Dicts/dicomV3.dic : remove double spaces !!!
2528 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2529 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2532 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2533 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2534 method. Doxygenation.
2535 * src/gdcm.h clean up of JPR spurious comments.
2537 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2538 * python/distutilsSwigCPlusPlus.py now properly collects the
2539 shadow classes generated by "swig -c++" (gdcm.py in our case)
2540 when using "python setup.py install".
2541 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2542 reexports the working classes.
2543 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2544 by the classical C errno scheme. This is to prevent an obscure
2545 behavior of the python wrappers when importing wxPython.wx prior
2546 to gdcmPython (which ended up in an abort call). An illustration
2547 of this oddity can be found in the Test/ExceptionAndPython
2548 subdir (see the README file). This problem probably due to
2549 an combination of g++ and dynamic loading.
2550 * added Test/ExceptionAndPython (see above)
2552 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2553 * Changed the layout of the python part to avoid bloating main
2554 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2555 i.e. the distutils arsenal. All the python related stuff is
2556 again in a python subdir, but the package itself is now in
2558 * setup.py was cleaned up:
2559 - pythonIncludePath removed
2560 - python setup.py bdist target is now functional.
2561 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2562 collision with other packages). gdcmPython/demo/*.py changed
2565 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * python subdir moved to gdcmPython (preparation of distutils packaging).
2567 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2568 distutils installer is operational.
2569 * - gdcmPython/__init__.py now properly loads the swig generated
2570 shadow classes (from gdcm.py).
2571 - gdcmPython/demo/*.py changed to import the package gdcmPython
2572 instead of gdcmPython/demo/load.py.
2573 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2575 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2576 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2577 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2578 entries within the associated public Dicom dictionary resp. the same
2579 information but sorted by the fourth field (PAT, IMG, DIR) of the
2581 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2582 are now in the "???" group.
2583 - python/gdcm.i changed accordingly,
2584 - python/demo/printGroupedPublicDict.py added, that gives an example
2585 of the above new functionalities in Python.
2587 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2588 * src/gdcm.h, gdcmHeader.cxx:
2589 - historic references to glib's g_malloc and g_free (#defined)
2590 were definitively removed.
2591 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2592 * src/gdcmElValSet.cxx:
2593 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2594 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2595 - GetElValue(string) renamed to GetElValueByName.
2596 - Added GetElementByName(string).
2597 * src/gdcmHeader.cxx: added
2598 - GetPubElValRepByNumber(guint16, guint16)
2599 - GetPubElValRepByName(string)
2600 - GetShaElValRepByNumber(guint16, guint16)
2601 - GetShaElValRepByName(string)
2602 - GetShaElValByNumber(guint16, guint16)
2603 - GetShaElValRepByName(string)
2604 - GetElValRepByNumber(guint16, guint16)
2605 - GetElValRepByName(string)
2606 - GetElValByNumber(guint16, guint16)
2607 - GetElValRepByName(string)
2608 * Doc/requirements.txt added.
2610 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * Test/Makefile building now depends on the one of libgdcm.so
2612 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2613 pixel data) aware which enables finding the address (offset) of
2614 the pixel data of JPEG encoded DICOM files. This leaves only a single
2615 file in the testSuite whose pixel data address (offset) is unknown.
2616 * python/testSuite.py changed accordingly.
2618 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2619 * VC++ has some strong limitations when working with the STL, as stated
2620 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2621 "Also note that some STL containers (map, set, queue, list, deque)
2622 cannot be exported. [...]
2623 Some STL classes contain nested classes. These classes can not
2625 This is caused by a designed limitation that once a template
2626 class is instantiated, it can not be re-instantiated and
2628 Since our usage of map<> is ubiquitous in gdcm, this "designed
2629 limitation" of VC++ is a pitfall.
2630 Hence the Python wrappers of gdcm cannot be incrementally linked
2631 against the c++ dynamic library. The dirty but only workaround is
2632 to forget about incremental link of dynamic libraries and to generate
2633 the Python wrappers library with the inclusions of the underlying C++
2635 The following modifications concern this matter on Win32/VC++:
2636 - wrapping python correct with standalone wrapped dll (don't use separate
2637 dll under windows !!!!)
2638 - python21_d debug mode enabled (ask Frog how to use it :-)
2639 - NO problem with having an STL member of class for example string in C++
2640 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2641 - Python test of dcmlib in Python is ok under windows on a large set
2643 * removed glib references
2644 * typedef's inserted in gdcm.i for correct swig type management
2646 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2647 * python/demo/*.py load.py extracted from test.py. Added explore.py
2648 that only displays required tags and testAll.py that parses all
2649 the files of the testsuite without using unittest.
2650 * python/testSuite.py other additional test on new files added.
2651 * Data/* new test files added accordingly to the testSuite.
2652 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2653 the vr in the file differs from the one of the dictionary.
2655 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2656 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2657 values, but limits itself to values which are below a user specified
2658 size (by default 1024 bytes).
2659 * python/gdcm.i : elements not loaded (because their size is above the
2660 user specified treshold) are exported with their TagKey as key of the
2661 python dictionary. This enables the testsuite to make some checks
2662 on the unloaded elements (since we have their offset and size).
2663 * python/testSuite.py
2664 - now tests for the existence and proper value of the pixel data
2665 - two new examples added.
2666 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2668 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2669 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2670 aware. See the strategy comments in gdcmHeader::FindeLength().
2671 * Test/test.cxx now accepts a filename as first argument.
2672 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2673 * python/testSuite.py changed to integrate test on above files.
2675 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2677 the vr was also RET.
2678 * python/testSuite.py more tests added.
2680 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * python/testSuite.py unittest test suite added (uses Data)
2682 * Data/* dcm and acr files for the test suite.
2683 * glib dependance removed from un*x version. We now use ISO C99
2684 7.18 Integer types (see stdint.h)
2685 - python/Makefile, src/Makefile src/gdcm.h
2686 * src/ when an explicit vr (like dicom files) suddenly poped an
2687 implicit element we use to mark the underlying DictEntry of the
2688 concerned ElValue with "Implicit". This strategy was damageable
2689 too the public or provite dictionaries, since some of their vr
2690 would be changed. Since Header::FindLength heavily relies on the
2691 detection by Header::FindVR of falsely explicit elements, I
2692 added an extra ImplicitVr member to ElValue (boolean).
2693 The rest of the changes we the necessary adaptations.
2695 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2698 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2700 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2701 * Adaptation for porting to VC++:
2703 o forced to use std namespace (for string to be known)
2704 o all class use __declspec export style on WIN32
2705 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2706 (in stdlib.h on Win32 but in std:: for gcc)
2707 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2708 variable GDCM_DICT_PATH.
2709 * src/gdcmHeader.cxx verbose comments made discrete.
2711 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2712 * python/gdcm.i: added a typemap that converts a C++ hashing table
2713 to native Python dictionary.
2714 * python/demo/test.py:
2715 - now uses the native dictionary for exploration of gdcmHeader.
2716 - takes an optional filename argument (the file to parse).
2717 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2718 PubElVals hashing table.
2719 * Dicts/dicomV3.dic removed error prone trailing spaces.
2721 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2722 * Python wrapping process moved away from src/Makefile to
2723 newly created python/Makefile (as well as gdcm.i)
2724 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2725 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2726 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2727 from the environement variable GDCM_DICT_PATH (when existing).
2728 * src/gdcmDict::GetTag bug fix.
2730 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * Straightforward temporary fixes for swig to build the python wrappers.
2732 src/Makefile now has a python working entry [by working we mean
2733 that we can import de shadow classes without errors].
2735 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * hashtest.cxx removed (since allready in Test)
2737 * src/gdcmlib.h renamed to src/gdcm.h
2738 * src/dcm.i renamed to src/gdcm.i
2739 * src/Makefile prepared for python wrapping
2741 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * src/gdcmHeader.cxx :
2743 - Parsing of header is now separated from loading of element values
2744 (see gdcmHeader::LoadElements).
2745 - general clean up of hopefully all file access (creation of
2746 ReadInt16 and ReadInt32)
2748 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * src/gdcmHeader.cxx :
2750 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2752 - SetLgrElem renamed to SetLength
2753 - GetLgrElem renamed to GetLength
2754 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2755 * src/gdcmElValSet.cxx fixed both GetElValue methods
2756 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2757 due to IdoDude was cleaned out.
2759 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2761 concentrates on finding the value representation (when it exists).
2762 RecupLgr now only finds the element value length, and it avoids
2763 returning the unecessary skL (skipped length).
2764 Also, offsetCourant was simply removed (with taille_fich) since
2765 it was redundant with the File position internals (by using
2766 ftell and fseek). This also made skL (see above in RecupLgr) usage
2768 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2769 on the libido specificities which are handled through class
2771 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2774 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * Truckload of changes. Parsing of header is barely functional
2776 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2778 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * src/gdcmHeader.cxx many addons of low level methods
2781 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2782 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2783 and _IdDcmSWAP_LONG.
2785 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * This corresponds to all the changes decided at the meeting of
2787 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob